*** stevemar has joined #openstack-horizon | 00:00 | |
*** dsneddon has quit IRC | 00:17 | |
*** dsneddon has joined #openstack-horizon | 00:18 | |
*** dsneddon has quit IRC | 00:38 | |
*** dsneddon has joined #openstack-horizon | 00:38 | |
*** nlahouti has joined #openstack-horizon | 00:46 | |
*** dsneddon has quit IRC | 00:58 | |
*** dsneddon has joined #openstack-horizon | 00:59 | |
*** MaxV has joined #openstack-horizon | 01:13 | |
*** MaxV has quit IRC | 01:18 | |
*** dsneddon has quit IRC | 01:19 | |
*** dsneddon has joined #openstack-horizon | 01:20 | |
openstackgerrit | tinytmy proposed openstack/horizon: left side header panel doesn't expand but show up arrow https://review.openstack.org/94127 | 01:30 |
---|---|---|
*** dsneddon has quit IRC | 01:40 | |
*** dsneddon has joined #openstack-horizon | 01:42 | |
*** venky has quit IRC | 01:45 | |
*** mwhagedorn_ has joined #openstack-horizon | 02:03 | |
*** ozialien_ has joined #openstack-horizon | 02:04 | |
*** mwhagedorn has quit IRC | 02:05 | |
*** mwhagedorn_ is now known as mwhagedorn | 02:05 | |
*** venky has joined #openstack-horizon | 02:15 | |
*** yingjun has joined #openstack-horizon | 02:20 | |
*** dsneddon has quit IRC | 02:22 | |
*** dsneddon has joined #openstack-horizon | 02:23 | |
*** venky has quit IRC | 02:28 | |
*** alexpilotti has joined #openstack-horizon | 02:33 | |
*** venky has joined #openstack-horizon | 02:36 | |
*** dsneddon has quit IRC | 02:43 | |
*** dsneddon has joined #openstack-horizon | 02:44 | |
*** venky has quit IRC | 02:57 | |
*** MaxV has joined #openstack-horizon | 03:02 | |
*** dsneddon has quit IRC | 03:04 | |
*** dsneddon has joined #openstack-horizon | 03:05 | |
*** MaxV has quit IRC | 03:07 | |
*** venky has joined #openstack-horizon | 03:09 | |
*** MaxV has joined #openstack-horizon | 03:25 | |
*** alexpilotti has quit IRC | 03:27 | |
openstackgerrit | Wu Wenxiang proposed openstack/horizon: Incorrect error message when VM deletion failed https://review.openstack.org/149881 | 03:29 |
*** MaxV has quit IRC | 03:30 | |
*** dboik has joined #openstack-horizon | 03:40 | |
*** dsneddon has quit IRC | 03:46 | |
*** dsneddon has joined #openstack-horizon | 03:47 | |
*** yingjun has quit IRC | 03:50 | |
*** venky has quit IRC | 03:52 | |
*** amotoki has joined #openstack-horizon | 03:53 | |
*** julim_ has quit IRC | 04:01 | |
*** dsneddon has quit IRC | 04:07 | |
*** dsneddon has joined #openstack-horizon | 04:08 | |
*** dboik has quit IRC | 04:10 | |
*** mitz has quit IRC | 04:10 | |
*** mitz has joined #openstack-horizon | 04:11 | |
*** dboik has joined #openstack-horizon | 04:15 | |
*** Longgeek has joined #openstack-horizon | 04:24 | |
*** dsneddon has quit IRC | 04:28 | |
*** dsneddon has joined #openstack-horizon | 04:28 | |
*** sayan has joined #openstack-horizon | 04:45 | |
*** Longgeek_ has joined #openstack-horizon | 04:47 | |
*** dsneddon has quit IRC | 04:48 | |
*** dsneddon has joined #openstack-horizon | 04:49 | |
*** Longgeek has quit IRC | 04:50 | |
*** dsneddon has quit IRC | 05:30 | |
*** dsneddon has joined #openstack-horizon | 05:32 | |
*** TravT has joined #openstack-horizon | 05:36 | |
*** nikunj2512_ has joined #openstack-horizon | 05:48 | |
nikunj2512_ | amotoki: Hello, i have a question related to Floating IPs tab in Access & Security | 05:48 |
amotoki | nikunj2512_: hello. what can i help? | 05:49 |
nikunj2512_ | amotoki: There is bug filed which says that Floating IPs tab should be moved under networks panel. Do you think we should move it? | 05:49 |
amotoki | nikunj2512_: i think it is correct if neutron is enabled, but it is not so good with nova-network. | 05:50 |
amotoki | nikunj2512_: this is the only thing I concern. what is your thoguht? | 05:51 |
nikunj2512_ | amotoki: i think we should move it but i didn't knew about the nova-network problem | 05:51 |
*** yingjun has joined #openstack-horizon | 05:51 | |
*** dsneddon has quit IRC | 05:51 | |
nikunj2512_ | amotoki: you are right when neutron is not enabled then user will not able to see the Floating IPs tab | 05:52 |
*** dsneddon has joined #openstack-horizon | 05:52 | |
nikunj2512_ | amotoki: Isn't there a way to check if neutron is enabled then show floating IP in networks tab and if nova-network is enabled then show the FIP in the Access & Secutity? | 05:53 |
amotoki | nikunj2512_: precisely speaking, panel group is eanbled based on its child panels, so users will see Network panel group with a single "Floating IP" panel (for nova-net | 05:53 |
amotoki | nikunj2512_: if is is acceptable, we can move Floating IP panel under Network. | 05:54 |
nikunj2512_ | amotoki: Ok but what about when neutron is disabled? | 05:54 |
nikunj2512_ | amotoki: won't it will cause any problem for user when they will not able to see Floating IP panel? | 05:55 |
amotoki | nikunj2512_: no, PanelGroup checks its child panels are enabled and if at least one of panels is enabled PanelGruoup will be dispayed. | 05:56 |
amotoki | nikunj2512_: so I think even if nova-net is used, users will see Floating IP panel. | 05:56 |
nikunj2512_ | amotoki: Ok | 05:56 |
amotoki | nikunj2512_: how about security group panel? it is related to networking too. | 05:57 |
nikunj2512_ | amotoki: But what if both are enabled then won't user will see it FIP in two places? | 05:57 |
nikunj2512_ | But keypair is related to nova | 05:57 |
amotoki | nikunj2512_: are you talking about keeping Floating IP panel under "Compute" when nova-network? | 05:58 |
nikunj2512_ | amotoki: i am floating IP tab which comes under the Compute->Access & Security | 05:58 |
nikunj2512_ | amotoki: There is no seperate FIP panel | 05:59 |
amotoki | nikunj2512_: I think we are in the same page. I should say floating IP "tab" :-) | 05:59 |
*** dboik has quit IRC | 05:59 | |
nikunj2512_ | amotoki: ohhh... Yes -:) | 05:59 |
amotoki | I think the discussion point is whether we should keep Floating IP "tab" under "Compute" for nova-network or not. right? | 06:00 |
nikunj2512_ | amotoki: Yes | 06:00 |
nikunj2512_ | amotoki: People are saying the Floating IP should be moved to networks because it is more suited there | 06:01 |
amotoki | IMHO it is not confusing even if we have Floating Panel under Network when nova-net. | 06:01 |
amotoki | so moving it to "network" looks reasonable. | 06:01 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/149862 | 06:01 |
nikunj2512_ | amotoki: OK... Thank You | 06:02 |
nikunj2512_ | amotoki: one more question | 06:02 |
amotoki | nikunj2512_: yeah | 06:02 |
nikunj2512_ | amotoki: As you see in the networks panel, when we click on the network for details there we get the subnet and port details also | 06:02 |
nikunj2512_ | amotoki: So how should i show the Floating IP in the networks panel? | 06:03 |
amotoki | I think a separate panel sounds good. | 06:03 |
nikunj2512_ | amotoki: Ohh.. Ok | 06:04 |
nikunj2512_ | amotoki: Thank You very much | 06:04 |
amotoki | nikunj2512_: youre welcome | 06:04 |
nikunj2512_ | amotoki: Sorry but just remembered of one more question.. If you have few more minutes than may i? | 06:04 |
amotoki | nikunj2512_: sure, go ahead. | 06:05 |
nikunj2512_ | amotoki: There is a bug which i remember correctly is that we can't disable the network panel in the project without breaking the Horizon | 06:05 |
nikunj2512_ | amotoki: As you know we have two network tabs -> one in project and one in Admin | 06:05 |
amotoki | nikunj2512_: yes | 06:06 |
nikunj2512_ | amotoki: So, if we disable the network tab under project the Admin->network tab code breaks | 06:06 |
nikunj2512_ | amotoki: So, do you think that this is a valid usecase? | 06:06 |
amotoki | nikunj2512_: Theoretically it is a valid case I think. | 06:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/149863 | 06:07 |
nikunj2512_ | amotoki: And practically? | 06:07 |
amotoki | nikunj2512_: I am not sure what use cases are expected, so I wrote "theoretically"... | 06:08 |
nikunj2512_ | amotoki: Ok... take a look at the same bug - >https://bugs.launchpad.net/horizon/+bug/1321865 | 06:09 |
amotoki | nikunj2512_: I think one case is "flat network mode". In most of this case, users will use a single network crated by admin. | 06:09 |
amotoki | nikunj2512_: IIRC the problem is that templates from project panel is unavailable. | 06:09 |
nikunj2512_ | amotoki: Ok.. Ya in that case users will not need to have a network panel | 06:10 |
nikunj2512_ | amotoki: Yes.... That is why code breaks | 06:10 |
nikunj2512_ | amotoki: But if we separate their code than it will be possible | 06:10 |
amotoki | nikunj2512_: the point is how to make them avialable even if project panel(s) is disabled. | 06:10 |
nikunj2512_ | amotoki: one think is put the code in a common location | 06:11 |
nikunj2512_ | amotoki: and export from there | 06:11 |
amotoki | nikunj2512_: it is not specific to Network panel. I think Instance table has the same problem. | 06:11 |
nikunj2512_ | amotoki: ohh... Why? | 06:11 |
*** stevemar has quit IRC | 06:12 | |
nikunj2512_ | amotoki: i meant why admin will want users not able to launch instances | 06:12 |
*** dsneddon has quit IRC | 06:12 | |
amotoki | nikunj2512_: I am just talking about disabling some panel from "Project" dashboard, and not tlaking about the use case. | 06:13 |
*** dsneddon has joined #openstack-horizon | 06:13 | |
nikunj2512_ | amotoki: Ok.. Sorry | 06:13 |
amotoki | nikunj2512_: At now, some (many?) Admin panels borrow templates from "project" panels, | 06:14 |
nikunj2512_ | amotoki: Can't we place the code these common panels in some common place and import from there? | 06:14 |
amotoki | so if project panel is disabled, we wil have the similar problem. | 06:14 |
nikunj2512_ | correct | 06:14 |
amotoki | I wonder if we can locate tempalte in a common place... | 06:14 |
amotoki | but I have not tried it yet. | 06:14 |
nikunj2512_ | amotoki: But with templates we have to locate the common python code also | 06:15 |
nikunj2512_ | amotoki: ok, i will give this a short | 06:15 |
nikunj2512_ | amotoki: and let you know the finding | 06:15 |
amotoki | nikunj2512_: thanks for taking care of these bugs. awesome. | 06:15 |
nikunj2512_ | amotoki: at the top of your mind, do you have any specific location where we can move it? | 06:15 |
amotoki | nikunj2512_: I have no specific location now. | 06:16 |
nikunj2512_ | amotoki: Thanks for being helpful... Couldn't have done without you | 06:16 |
amotoki | nikunj2512_: I am not so familiar with templatwe loading mechanism... | 06:16 |
nikunj2512_ | amotoki: Ok than i will put it somewhere and try it | 06:16 |
nikunj2512_ | amotoki: -:) | 06:17 |
amotoki | nikunj2512_: thanks anyway | 06:17 |
nikunj2512_ | amotoki: and if you ever get some free time, please take a look at my other network patches. Thank You -:) | 06:18 |
*** jcoufal has joined #openstack-horizon | 06:19 | |
amotoki | nikunj2512_: will loos. you have many patches :-) | 06:19 |
*** _gryf has joined #openstack-horizon | 06:19 | |
amotoki | *will look* | 06:19 |
nikunj2512_ | amotoki: :-) | 06:20 |
*** TravT has quit IRC | 06:20 | |
nikunj2512_ | amotoki: Thank You | 06:20 |
*** Miouge has joined #openstack-horizon | 06:24 | |
*** nlahouti has quit IRC | 06:26 | |
*** nlahouti has joined #openstack-horizon | 06:28 | |
*** dsneddon has quit IRC | 06:33 | |
*** dsneddon has joined #openstack-horizon | 06:35 | |
*** Miouge has quit IRC | 06:35 | |
*** Miouge has joined #openstack-horizon | 06:36 | |
*** Miouge has quit IRC | 06:38 | |
*** sayan has quit IRC | 06:40 | |
*** rwsu has joined #openstack-horizon | 06:54 | |
*** rwsu is now known as rwsu-afk | 06:54 | |
*** dsneddon has quit IRC | 06:55 | |
*** dsneddon has joined #openstack-horizon | 06:55 | |
*** dboik has joined #openstack-horizon | 07:00 | |
*** dboik has quit IRC | 07:04 | |
*** mrunge has joined #openstack-horizon | 07:08 | |
*** vivekd has joined #openstack-horizon | 07:12 | |
*** e0ne has joined #openstack-horizon | 07:13 | |
*** dsneddon has quit IRC | 07:15 | |
*** dsneddon has joined #openstack-horizon | 07:16 | |
*** jtomasek has joined #openstack-horizon | 07:27 | |
*** Putns has joined #openstack-horizon | 07:28 | |
*** dsneddon has quit IRC | 07:36 | |
*** dsneddon has joined #openstack-horizon | 07:37 | |
*** amotoki_ has joined #openstack-horizon | 07:39 | |
*** amotoki has quit IRC | 07:39 | |
*** nlahouti1 has joined #openstack-horizon | 07:41 | |
*** nlahouti has quit IRC | 07:41 | |
*** jprovazn has joined #openstack-horizon | 07:42 | |
*** nlahouti1 has quit IRC | 07:46 | |
*** nlahouti has joined #openstack-horizon | 07:47 | |
*** Miouge has joined #openstack-horizon | 07:50 | |
*** aberezin has quit IRC | 07:52 | |
*** MaxV has joined #openstack-horizon | 07:53 | |
*** nyechiel has joined #openstack-horizon | 07:57 | |
*** simon-AS559 has joined #openstack-horizon | 08:00 | |
*** e0ne has quit IRC | 08:00 | |
*** dboik has joined #openstack-horizon | 08:01 | |
*** dboik has quit IRC | 08:06 | |
*** MaxV has quit IRC | 08:07 | |
*** MaxV has joined #openstack-horizon | 08:08 | |
*** MaxV has quit IRC | 08:14 | |
openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/149862 | 08:15 |
nikunj2512_ | amotoki_: Hi, are you online? | 08:15 |
*** Ala has joined #openstack-horizon | 08:17 | |
*** markus_z has joined #openstack-horizon | 08:23 | |
*** aberezin has joined #openstack-horizon | 08:23 | |
*** vivekd_ has joined #openstack-horizon | 08:24 | |
*** pkarikh has joined #openstack-horizon | 08:25 | |
*** nlahouti has quit IRC | 08:25 | |
*** vivekd has quit IRC | 08:25 | |
*** vivekd_ is now known as vivekd | 08:25 | |
*** sayan has joined #openstack-horizon | 08:34 | |
*** mpavlase has joined #openstack-horizon | 08:44 | |
*** sayan has quit IRC | 08:45 | |
*** rdopiera has joined #openstack-horizon | 08:46 | |
*** rdopiera has quit IRC | 08:46 | |
*** rdopiera has joined #openstack-horizon | 08:47 | |
*** MaxV has joined #openstack-horizon | 08:49 | |
openstackgerrit | Kamil Rykowski proposed openstack/horizon: Metadata widget support for default values https://review.openstack.org/143444 | 08:50 |
*** vivekd_ has joined #openstack-horizon | 08:51 | |
*** vivekd has quit IRC | 08:52 | |
openstackgerrit | ziyu032 proposed openstack/horizon: test https://review.openstack.org/149946 | 08:52 |
*** vivekd_ is now known as vivekd | 08:52 | |
*** romainh has joined #openstack-horizon | 08:53 | |
*** ygbo has joined #openstack-horizon | 08:54 | |
*** mpavlase has quit IRC | 08:56 | |
*** dsneddon has quit IRC | 08:59 | |
*** aberezin has quit IRC | 09:00 | |
*** dsneddon has joined #openstack-horizon | 09:00 | |
*** dboik has joined #openstack-horizon | 09:03 | |
*** jpich has joined #openstack-horizon | 09:04 | |
*** Ala has quit IRC | 09:06 | |
*** dboik has quit IRC | 09:08 | |
*** ygbo has quit IRC | 09:11 | |
*** hhuang has joined #openstack-horizon | 09:11 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:13 | |
*** ygbo has joined #openstack-horizon | 09:14 | |
*** Ala has joined #openstack-horizon | 09:17 | |
jpich | pkarikh: On the plus side it looks like django_openstack_auth was finally pushed to pypi :-) On the minus side it looks like all the unit tests are exploding now | 09:19 |
*** JeanBriceCombebi has quit IRC | 09:19 | |
jpich | Looks like lcheng is on top of it though, yay - https://bugs.launchpad.net/horizon/+bug/1413876 | 09:20 |
*** dsneddon has quit IRC | 09:20 | |
*** akrivoka has joined #openstack-horizon | 09:20 | |
pkarikh | jpich: hi! :) ALL unit tests? :) I saw Lin Hua Cheng's patch, looks like all tests were fine. Have I missed something? | 09:20 |
*** dsneddon has joined #openstack-horizon | 09:21 | |
jpich | pkarikh: That's for doa, the horizon unit tests are failing on all branches | 09:21 |
*** JeanBriceCombebi has joined #openstack-horizon | 09:21 | |
*** Ala has quit IRC | 09:21 | |
*** TravT has joined #openstack-horizon | 09:21 | |
pkarikh | jpich: So, what we have to do now? | 09:22 |
*** Ala has joined #openstack-horizon | 09:22 | |
jpich | pkarikh: Verify that Lin's patch works, approve it, do a new urgent pypi release :) | 09:22 |
*** Guest66252 is now known as d0ugal | 09:22 | |
*** d0ugal has quit IRC | 09:23 | |
*** d0ugal has joined #openstack-horizon | 09:23 | |
mrunge | all unit tests are failing, down to icehouse, yes. | 09:23 |
*** sambetts has joined #openstack-horizon | 09:23 | |
mrunge | jpich, pkarikh or cap doa to < 1.1.8 | 09:25 |
*** TravT has quit IRC | 09:25 | |
jpich | mrunge: That works too! Since there's already a fix that doesn't look overly complex though, it'd be nice to get it fixed the proper way | 09:26 |
*** sambetts has quit IRC | 09:26 | |
*** sambetts has joined #openstack-horizon | 09:27 | |
*** sambetts has quit IRC | 09:28 | |
mrunge | jpich, yes, you're right. it *just* depends on how fast we're going to get a new release sent up to pypi | 09:28 |
jpich | mrunge: Since the upload mechanism seems fixed, once it's approved it should be a matter to get david-ly_ or someone who can to upload a tag in the afternoon and we'll be sorted | 09:28 |
amotoki_ | mrunge: jpich: it seems we need to add horizon integrated check to django-openstack-auth check. | 09:28 |
*** sambetts has joined #openstack-horizon | 09:29 | |
pkarikh | jpich, mrung: yes, fix looks very accurate. | 09:29 |
amotoki_ | at least we need horizon unit test with proposed openstack-auth patch | 09:29 |
mrunge | amotoki_, yes, that seems to be a good idea | 09:29 |
mrunge | amotoki_, in this case, openstack_dashboard broke. not horizon part | 09:29 |
jpich | amotoki_: That might take a bit of work, if the horizon unit tests use the package release by default | 09:29 |
*** mpavlase has joined #openstack-horizon | 09:30 | |
*** Longgeek has joined #openstack-horizon | 09:30 | |
amotoki_ | jpich: yes. it needs some work. This is similar to cases of *client (for example noavclient patch is tested with nova integrated tempest) | 09:31 |
jpich | amotoki_: I didn't know that, but that makes sense. And it means we shouldn't have to research and reinvent the wheel from scratch, very good to know :) | 09:32 |
amotoki_ | jpich: for novaclient case, the unit test is not used. nova related test from tempest is used, so we can easily use novaclient from the git repo | 09:33 |
*** Longgeek_ has quit IRC | 09:33 | |
amotoki_ | by specifying USE_LIBS_FROM_GIT devstack option. | 09:33 |
*** yingjun has quit IRC | 09:34 | |
jpich | amotoki_: I'm not very familiar with this, but it sounds like it shouldn't be a huge effort then :) | 09:36 |
*** bradjones has joined #openstack-horizon | 09:39 | |
*** dsneddon has quit IRC | 09:40 | |
*** dsneddon has joined #openstack-horizon | 09:41 | |
amotoki_ | jpich: i think so. I an not sure which approach is better using devstack or adding another tox menu to openstack-auth. | 09:42 |
-amotoki_- now understands doa stands for django openstack auth :-) | 09:42 | |
* jpich too lazy to spell the whole name all the time | 09:43 | |
pkarikh | amotoki: now me too. :) | 09:46 |
amotoki_ | btw can we set upper limit of openstack-auth in requirements.txt temporarily? | 09:49 |
amotoki_ | i am not sure global-req check allows this... | 09:49 |
*** sayan has joined #openstack-horizon | 09:51 | |
mrunge | amotoki_, quickest way is to try it out ;-) | 09:53 |
pkarikh | amotoki_: I'm not sure, but why just '<1.1.*' could not work? | 09:53 |
mrunge | pkarikh, that'd exclude 1.1.7 as well, and I think we want that version | 09:54 |
jpich | Pins/Upper limits are allowed but it'll still need to go through the global-requirements review process first | 09:54 |
jpich | I approved the doa patch, works for me etc :-) | 09:54 |
*** quist has joined #openstack-horizon | 09:54 | |
*** sayan has quit IRC | 09:56 | |
*** vivekd has quit IRC | 09:56 | |
*** vivekd has joined #openstack-horizon | 09:58 | |
nikunj2512_ | jpich: Please can you tell me how i can add a value in the object dict with we get in the tests? | 09:59 |
jpich | nikunj2512_: Hi! You can look at the existing files for the test data and add the new value wherever it makes sense ( https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_data ) | 10:00 |
openstackgerrit | Sam Betts proposed openstack/horizon: Reduced code duplication in creating page headers https://review.openstack.org/142802 | 10:01 |
openstackgerrit | Sam Betts proposed openstack/horizon: Add mixin to project templates https://review.openstack.org/149960 | 10:01 |
*** dsneddon has quit IRC | 10:01 | |
nikunj2512_ | jpich: i did but i got a comment that rather changing the test data add the missing value in the Test itself | 10:01 |
*** dsneddon has joined #openstack-horizon | 10:02 | |
amotoki_ | nikunj2512_: my comment? | 10:03 |
*** e0ne has joined #openstack-horizon | 10:03 | |
nikunj2512_ | amotoki_: Yes | 10:03 |
amotoki_ | nikunj2512_: please see how TEST.api_networks and TEST.networks are setup. | 10:03 |
*** dboik has joined #openstack-horizon | 10:04 | |
nikunj2512_ | amotoki_: Ok.. | 10:04 |
nikunj2512_ | amotoki_: and please take a look at this patch again -> https://review.openstack.org/148946, i replied to your comments | 10:05 |
*** amotoki_ has quit IRC | 10:06 | |
*** dboik has quit IRC | 10:09 | |
*** rushiagr_away is now known as rushiagr | 10:10 | |
*** simon-AS559 has quit IRC | 10:12 | |
openstackgerrit | Merged openstack/django_openstack_auth: Add defaulting of services_region in User class https://review.openstack.org/149800 | 10:19 |
*** vivekd_ has joined #openstack-horizon | 10:19 | |
*** vivekd has quit IRC | 10:20 | |
*** vivekd_ is now known as vivekd | 10:20 | |
*** dsneddon has quit IRC | 10:21 | |
*** vivekd has quit IRC | 10:21 | |
*** vivekd has joined #openstack-horizon | 10:22 | |
*** dsneddon has joined #openstack-horizon | 10:22 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds support to accept IPv6 in VIP Address for LB Pool https://review.openstack.org/142670 | 10:23 |
*** svasheka has joined #openstack-horizon | 10:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/149964 | 10:26 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/149966 | 10:27 |
nikunj2512_ | jpich: Hi, Need you suggestion with this bug - > https://bugs.launchpad.net/horizon/+bug/884482 | 10:27 |
*** simon-AS559 has joined #openstack-horizon | 10:28 | |
*** simon-AS559 has quit IRC | 10:28 | |
nikunj2512_ | jpich: While implementing this feature do i have to show whole form like create instance or just a confirm dialog and launch the instance? | 10:28 |
jpich | nikunj2512_: What are your thoughts on it? | 10:30 |
*** aix has joined #openstack-horizon | 10:30 | |
nikunj2512_ | jpich: i am thinking of showing everything like create instance, incase if user wants to change anything | 10:30 |
nikunj2512_ | jpich: but it will then be just like creating an new instance | 10:31 |
nikunj2512_ | jpich: So, i think second one is better.. Fast and simple | 10:31 |
nikunj2512_ | jpich: Your thoughts? | 10:31 |
jpich | nikunj2512_: Except it should come prefilled with the values from the existing instance, right? | 10:31 |
nikunj2512_ | jpich: Yes, all the fields will be prefilled | 10:32 |
nikunj2512_ | jpich: So, in your view which is better? | 10:35 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/149986 | 10:35 |
jpich | nikunj2512_: Personally I think it makes sense to allow the user to tweak a couple of settings before launching a similar instance (especially the name in that context), but I can see arguments for both sides (and it is possible to change the name and a couple other things after launching). As long as you have good reasons and justification for the approach you choose it should be fine either way | 10:36 |
nikunj2512_ | jpich: Ok thank You | 10:37 |
nikunj2512_ | jpich: one last thing, do you know any good blog where i can learn more about how workflows in Horizon works? i tried reading the documentation but still have alot of doubts in mind | 10:38 |
nikunj2512_ | jpich: last time Your blog post helped me alot in learning about how to write test cases. Anything similar You might know | 10:38 |
jpich | nikunj2512_: I'm not aware of anything beside our documentation at http://docs.openstack.org/developer/horizon/topics/workflows.html unfortunately :/ You should write up one as you slowly learn more about it :) and/or maybe update our docs to be clearer too then | 10:39 |
nikunj2512_ | jpich: Ok... That is also a good idea.. if you don't mind may i ask some questions related to the workflow workings? | 10:40 |
*** simon-AS559 has joined #openstack-horizon | 10:40 | |
*** e0ne is now known as e0ne_ | 10:41 | |
nikunj2512_ | jpich: let me read this doc first... and then i will ask questions.. Thank You again | 10:41 |
jpich | nikunj2512_: Sorry, now isn't a good time for me, it's not fresh in my mind anyway so you probably now more about it than I do right now :) Feel free to ask general questions on IRC if you get stuck, someone else may have the answer | 10:41 |
*** simon-AS5591 has joined #openstack-horizon | 10:42 | |
nikunj2512_ | jpich: Ok..No problem... Thank You.. I will :) | 10:42 |
*** dsneddon has quit IRC | 10:42 | |
jpich | Good luck! | 10:42 |
*** dsneddon has joined #openstack-horizon | 10:43 | |
nikunj2512_ | jpich: -:).. Sorry to disturbing You again but for this https://review.openstack.org/#/c/149869/ all the tests are failing.. i mean each and every single test. and i only made changes in the HTML file.. | 10:44 |
nikunj2512_ | jpich: do you have any idea why? | 10:44 |
nikunj2512_ | jpich: Is gate is broken?> | 10:44 |
*** simon-AS559 has quit IRC | 10:45 | |
*** tosky has joined #openstack-horizon | 10:45 | |
*** e0ne_ is now known as e0ne | 10:46 | |
jpich | nikunj2512_: It is, we were chatting about it earlier. This is due to https://bugs.launchpad.net/horizon/+bug/1413876 , the fix is merged but we need to release a new version of the library now before the tests can pass | 10:49 |
jpich | no need to recheck until 1.1.9 is available currently | 10:49 |
jpich | mrunge: Weren't you saying you have The Power to tag and do releases? Fancy trying to learn how to do it this morning? :-) | 10:50 |
nikunj2512_ | jpich: ok but i did recheck twice and still failing :( | 10:51 |
jpich | nikunj2512_: Yes, I mean there is no point in rechecking until the library is released - it will not work, it just uses up infra resources | 10:51 |
mrunge | jpich, yupp | 10:51 |
mrunge | jpich, let me try it after finishing some other unrelated stuff, please | 10:52 |
nikunj2512_ | jpich: ohh... Ok | 10:52 |
jpich | mrunge: Sure! | 10:52 |
jpich | Oh, suggestion to do negative pinning on the requirements | 10:55 |
jpich | that'd be less messy than doing upper limit pinning because we wouldn't have to change it then | 10:55 |
jpich | it just won't use 1.1.8 and when 1.1.9 it'll use that - no need to rush the release out either | 10:56 |
openstackgerrit | Paul Karikh proposed openstack/horizon: Fix replacement of exception category list https://review.openstack.org/143832 | 11:00 |
*** mpavlase1 has joined #openstack-horizon | 11:00 | |
*** htruta has joined #openstack-horizon | 11:01 | |
mrunge | not sure, if just taggging is sufficient to push a release | 11:02 |
*** mpavlase has quit IRC | 11:03 | |
*** dsneddon has quit IRC | 11:03 | |
mrunge | jpich, https://pypi.python.org/pypi/django_openstack_auth | 11:04 |
mrunge | :D | 11:04 |
*** simon-AS559 has joined #openstack-horizon | 11:04 | |
jpich | mrunge: like a pro :D | 11:04 |
*** dsneddon has joined #openstack-horizon | 11:04 | |
mrunge | well, too easy to follow: https://wiki.openstack.org/wiki/StableBranchRelease | 11:04 |
jpich | mrunge: I thought it had to be a signed tag, is that how it worked in the end? | 11:04 |
*** simon-AS5591 has quit IRC | 11:05 | |
mrunge | jpich, I thought, I signed it | 11:05 |
jpich | Ok, let's try to recheck a patch and see where we're at! | 11:05 |
jpich | mrunge: Cool! Congrats on your first library release so :-) | 11:05 |
mrunge | jpich, hmm, I haven't done there anything. it was you, and amotoki and Lin to to the work here | 11:07 |
mrunge | applause to the right people, please ;-) | 11:07 |
jpich | mrunge: I'll transfer all my credit to Lin Hua for debugging that one then! I tried a recheck on the translation patch at https://review.openstack.org/#/c/149863/ , let's see what happens now :) | 11:07 |
jpich | mrunge: Still, releasing stuff is cool :-) | 11:08 |
*** romainh has left #openstack-horizon | 11:10 | |
jpich | Not sure how to create the doa 1.1.9 milestone in launchpad to assign the bugs fixes included in that release properly | 11:13 |
jpich | Zuul shows that the unit test jobs are passing again, yay. Recheck away people | 11:14 |
*** Miouge has quit IRC | 11:15 | |
*** mpavlase1 has quit IRC | 11:17 | |
*** mpavlase has joined #openstack-horizon | 11:17 | |
sambetts | Did something break the UTs on master? I just ran ./run_tests.sh and am seeing a huge number of failures | 11:19 |
rdopiera | anybody has any idea where this comes from? `AttributeError: 'list' object has no attribute '_queued_messages'` | 11:21 |
jpich | sambetts: Yep, see https://bugs.launchpad.net/horizon/+bug/1413876 . The fix was in django_openstack_auth and the library is now released so you should be able to recheck successfully | 11:24 |
sambetts | jpich: I was have similar issue locally, because even though I was prompted to do an Env update, I've had to ./run_tests -f to get things working again | 11:25 |
sambetts | jpich: all sorted now though I think :-) | 11:26 |
jpich | sambetts: Yup, should be | 11:26 |
*** e0ne is now known as e0ne_ | 11:28 | |
openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Add Roles rest api https://review.openstack.org/148865 | 11:32 |
*** vivekd_ has joined #openstack-horizon | 11:34 | |
*** vivekd has quit IRC | 11:35 | |
*** vivekd_ is now known as vivekd | 11:35 | |
*** e0ne_ has quit IRC | 11:38 | |
*** e0ne has joined #openstack-horizon | 11:39 | |
*** sayan has joined #openstack-horizon | 11:44 | |
*** akrivoka has quit IRC | 11:45 | |
*** dsneddon has quit IRC | 11:45 | |
*** dsneddon has joined #openstack-horizon | 11:46 | |
openstackgerrit | Merged openstack/tuskar-ui: Add tests for templatetags https://review.openstack.org/149311 | 11:46 |
openstackgerrit | Merged openstack/tuskar-ui: Add test for the _get_role_data function https://review.openstack.org/149248 | 11:47 |
*** akrivoka has joined #openstack-horizon | 11:48 | |
*** vivekd_ has joined #openstack-horizon | 11:58 | |
*** vivekd has quit IRC | 12:00 | |
*** vivekd_ is now known as vivekd | 12:00 | |
*** quist has quit IRC | 12:03 | |
*** dsneddon has quit IRC | 12:06 | |
*** raildo has joined #openstack-horizon | 12:07 | |
*** dsneddon has joined #openstack-horizon | 12:07 | |
openstackgerrit | Merged openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/149986 | 12:11 |
mrunge | jpich, created a release on launchpad | 12:17 |
mrunge | darn, I just can't add bugs to the milestone/release: No. Drivers cannot target bugs and blueprints to this milestone. | 12:19 |
openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 12:22 |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Moves the Floating IP from compute to Networking https://review.openstack.org/150016 | 12:26 |
*** dsneddon has quit IRC | 12:27 | |
*** dsneddon has joined #openstack-horizon | 12:28 | |
openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Tests for the plan validation https://review.openstack.org/148927 | 12:31 |
openstackgerrit | Merged openstack/tuskar-ui: Add tests for nodes.forms https://review.openstack.org/149265 | 12:44 |
*** dsneddon has quit IRC | 12:48 | |
*** dsneddon has joined #openstack-horizon | 12:49 | |
*** jcooley has quit IRC | 12:51 | |
*** NikitaKonovalov has quit IRC | 12:51 | |
*** romainh has joined #openstack-horizon | 12:51 | |
*** romainh has left #openstack-horizon | 12:52 | |
*** jcooley has joined #openstack-horizon | 12:53 | |
*** NikitaKonovalov has joined #openstack-horizon | 12:53 | |
openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: WIP Angular roles list https://review.openstack.org/150023 | 12:59 |
*** simon-AS5591 has joined #openstack-horizon | 13:00 | |
*** alexpilotti has joined #openstack-horizon | 13:03 | |
*** simon-AS559 has quit IRC | 13:03 | |
openstackgerrit | zhu.rong proposed openstack/horizon: Test, please ignore the patch https://review.openstack.org/150024 | 13:04 |
openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Tests for the plan validation https://review.openstack.org/148927 | 13:05 |
*** dboik has joined #openstack-horizon | 13:07 | |
*** tzumainn has joined #openstack-horizon | 13:08 | |
*** dsneddon has quit IRC | 13:09 | |
*** vivekd has quit IRC | 13:10 | |
*** dsneddon has joined #openstack-horizon | 13:10 | |
*** dboik has quit IRC | 13:12 | |
*** simon-AS5591 has quit IRC | 13:14 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds configuration to disable the password in stack creation https://review.openstack.org/148997 | 13:14 |
jpich | mrunge: Cool, I see the gate-breaking bug is included in 1.1.9 now - thanks! :) | 13:15 |
mrunge | my pleasure | 13:16 |
mrunge | jpich, all, just fyi, I added a new milestone for doa to launchpad | 13:16 |
jpich | mrunge: Oh, maybe that's what I'm talking about then | 13:16 |
jpich | Thanks either way :-) | 13:17 |
mrunge | jpich, I added both :D | 13:17 |
openstackgerrit | Merged openstack/tuskar-ui: Added tests form tuskar_ui.infrastructure.flavors.utils https://review.openstack.org/148880 | 13:17 |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds configuration to disable the password in stack creation form https://review.openstack.org/148997 | 13:19 |
openstackgerrit | Merged openstack/tuskar-ui: Tests for the plan validation https://review.openstack.org/148927 | 13:28 |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/149863 | 13:30 |
*** dsneddon has quit IRC | 13:30 | |
*** dsneddon has joined #openstack-horizon | 13:31 | |
*** dkorn has joined #openstack-horizon | 13:32 | |
*** trown|outttypeww is now known as trown | 13:49 | |
*** dboik has joined #openstack-horizon | 14:00 | |
*** yingjun has joined #openstack-horizon | 14:01 | |
*** _crobertsrh is now known as crobertsrh | 14:07 | |
*** julim has joined #openstack-horizon | 14:10 | |
openstackgerrit | Julien Danjou proposed openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 14:11 |
*** yingjun has quit IRC | 14:14 | |
*** yingjun has joined #openstack-horizon | 14:14 | |
*** neelashah has joined #openstack-horizon | 14:15 | |
*** yingjun has quit IRC | 14:18 | |
*** yingjun has joined #openstack-horizon | 14:22 | |
*** stevemar has joined #openstack-horizon | 14:24 | |
*** e0ne is now known as e0ne_ | 14:26 | |
*** peristeri has joined #openstack-horizon | 14:27 | |
*** Drago has joined #openstack-horizon | 14:29 | |
*** Drago has quit IRC | 14:29 | |
*** Drago has joined #openstack-horizon | 14:29 | |
*** vhoward has joined #openstack-horizon | 14:30 | |
*** Drago has quit IRC | 14:32 | |
*** Drago has joined #openstack-horizon | 14:32 | |
*** dsneddon has quit IRC | 14:32 | |
*** sayan has quit IRC | 14:32 | |
*** yingjun has quit IRC | 14:33 | |
*** lblanchard has joined #openstack-horizon | 14:33 | |
*** dsneddon has joined #openstack-horizon | 14:33 | |
*** e0ne_ is now known as e0ne | 14:35 | |
openstackgerrit | Merged openstack/tuskar-ui: Refactor StackMixin and RoleMixin https://review.openstack.org/148531 | 14:35 |
openstackgerrit | Merged openstack/tuskar-ui: Move tarball requirements to test-requirements.txt https://review.openstack.org/143045 | 14:35 |
*** mattfarina has joined #openstack-horizon | 14:36 | |
*** dboik has quit IRC | 14:37 | |
rodrigods | hi all, which is horizon's deadline for big features (similar to specs)? | 14:40 |
rdopiera | rodrigods: https://wiki.openstack.org/wiki/Kilo_Release_Schedule | 14:43 |
rodrigods | rdopiera, thanks | 14:44 |
*** dboik has joined #openstack-horizon | 14:45 | |
*** davelowe has joined #openstack-horizon | 14:46 | |
*** davelowe has quit IRC | 14:46 | |
*** davelowe has joined #openstack-horizon | 14:47 | |
*** dboik has quit IRC | 14:47 | |
*** dboik has joined #openstack-horizon | 14:48 | |
*** Miouge has joined #openstack-horizon | 14:48 | |
*** jpomero has joined #openstack-horizon | 14:49 | |
*** dsneddon has quit IRC | 14:54 | |
*** dsneddon has joined #openstack-horizon | 14:54 | |
*** woodm1979 has joined #openstack-horizon | 15:00 | |
openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 15:00 |
*** radez_g0n3 is now known as radez | 15:00 | |
*** jprovazn has quit IRC | 15:03 | |
*** dboik has quit IRC | 15:06 | |
*** dboik has joined #openstack-horizon | 15:08 | |
*** dboik has quit IRC | 15:10 | |
*** e0ne is now known as e0ne_ | 15:11 | |
*** e0ne_ is now known as e0ne | 15:12 | |
*** Longgeek has quit IRC | 15:13 | |
*** dboik has joined #openstack-horizon | 15:14 | |
*** Miouge has quit IRC | 15:14 | |
*** Miouge has joined #openstack-horizon | 15:15 | |
*** Ctina has joined #openstack-horizon | 15:16 | |
*** Drago1 has joined #openstack-horizon | 15:18 | |
*** Drago has quit IRC | 15:18 | |
*** Drago has joined #openstack-horizon | 15:18 | |
*** vijendar has joined #openstack-horizon | 15:25 | |
openstackgerrit | lawrancejing proposed openstack/horizon: Add project column for admin images tables https://review.openstack.org/147997 | 15:26 |
*** jprovazn has joined #openstack-horizon | 15:26 | |
*** TravT has joined #openstack-horizon | 15:31 | |
*** ericpeterson has joined #openstack-horizon | 15:31 | |
*** JeanBriceCombebi has quit IRC | 15:32 | |
*** EmilienM is now known as EmilienM|mtg | 15:33 | |
*** JeanBriceCombebi has joined #openstack-horizon | 15:34 | |
*** Miouge has quit IRC | 15:35 | |
*** dsneddon has quit IRC | 15:36 | |
*** dsneddon has joined #openstack-horizon | 15:37 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix disappearing Sahara workflow navbar in 'Jobs' panel https://review.openstack.org/150060 | 15:38 |
*** Ctina has quit IRC | 15:40 | |
*** Ctina has joined #openstack-horizon | 15:41 | |
jpich | TravT: Hello o/ I should have a fugly little read-only wrapper uploaded for you within the next hour or so :-) That's like, 1% of the work or something | 15:45 |
jpich | Long journey, single step, etc etc | 15:45 |
TravT | jpich hello o/ | 15:51 |
*** alexpilotti has quit IRC | 15:51 | |
TravT | your fugly wrapper is still a start! | 15:51 |
TravT | I will definitely take a look and see if I am able to add to it today. | 15:53 |
jpich | TravT: Yup! Basically now, one can display the images table and details when using v2 (and that uses the correct client), and things still work normally [ or they should now anyway ] when using v1 (and that uses the correct v1 client too) | 15:53 |
jpich | Cool | 15:53 |
openstackgerrit | Julien Danjou proposed openstack/horizon: Replace lockfile by oslo_concurrency https://review.openstack.org/148539 | 15:53 |
TravT | jpich: that sounds like a great start! | 15:54 |
jpich | TravT: \o/ I'll send you a link / add you as reviewer when it's up there in a bit, I think I've solved the latest set of nasties | 15:54 |
TravT | :) | 15:55 |
TravT | ok. maybe this will give me something "fun" to do on my flight later today. | 15:56 |
*** dsneddon has quit IRC | 15:56 | |
*** dsneddon has joined #openstack-horizon | 15:57 | |
jpich | TravT: I'll be honest | 15:57 |
jpich | TravT: I could think of more fun things to do | 15:57 |
jpich | ;) | 15:57 |
TravT | lol | 15:57 |
TravT | what's wrong with breaking your neck in economy class while trying to code against some whacky APIs? | 15:58 |
nikunj2512_ | mrunge: Hi, I have a question about this bug you reported - > https://bugs.launchpad.net/horizon/+bug/1396562 | 15:59 |
nikunj2512_ | mrunge: Currently i had moved the floating IP from the Access & security panel. So, in your view what more have to be moved from this panel? | 16:00 |
*** JeanBriceCombebi has quit IRC | 16:00 | |
mrunge | nikunj2512_, uhm sorrry, no time to look that up currently | 16:01 |
nikunj2512_ | mrunge: Will you be able to talk within 2 hours or will i ask tomorrow? | 16:02 |
*** aix has quit IRC | 16:02 | |
mrunge | nikunj2512_, in two weeks? | 16:02 |
mrunge | nikunj2512_, or in two months? | 16:03 |
nikunj2512_ | mrunge: Sadly, That is too long :) | 16:03 |
*** JeanBriceCombebi has joined #openstack-horizon | 16:04 | |
nikunj2512_ | mrunge: Please if you can just spare 5 minutes from your busy schedule, i will be appreciative :) | 16:04 |
*** neelashah has quit IRC | 16:11 | |
*** neelashah has joined #openstack-horizon | 16:12 | |
*** dkorn has quit IRC | 16:12 | |
jtomasek | mrunge: hi, I think I recall some patch/discussion about removing or merging _config.html with _scripts.html could you please point me to that? I am not able to find it anywhere | 16:16 |
*** dsneddon has quit IRC | 16:17 | |
mrunge | nikunj2512_, ok, tomorrow in the morning then | 16:18 |
*** dkorn has joined #openstack-horizon | 16:18 | |
*** dsneddon has joined #openstack-horizon | 16:18 | |
mrunge | jtomasek, that was during a patch review and in last weekly meeting | 16:18 |
*** mrunge is now known as mrunge_afk | 16:18 | |
nikunj2512_ | mrunge: Thank You very much | 16:21 |
*** alexpilotti has joined #openstack-horizon | 16:21 | |
*** e0ne is now known as e0ne_ | 16:22 | |
*** e0ne_ is now known as e0ne | 16:23 | |
openstackgerrit | Julie Pichon proposed openstack/horizon: /!\ WIP /!\ Support for Glance v2 https://review.openstack.org/150084 | 16:28 |
*** dkorn has quit IRC | 16:29 | |
*** rebelagentm has joined #openstack-horizon | 16:30 | |
openstackgerrit | Merged openstack/horizon: Remove unused wait_for_title method https://review.openstack.org/149565 | 16:32 |
*** david-ly_ is now known as david-lyle | 16:33 | |
*** doug-fish has joined #openstack-horizon | 16:36 | |
*** nlahouti has joined #openstack-horizon | 16:36 | |
*** Ala has quit IRC | 16:38 | |
*** rwsu-afk is now known as rwsu | 16:38 | |
*** gokrokve has joined #openstack-horizon | 16:51 | |
*** gary-smith__ has quit IRC | 16:53 | |
*** Miouge has joined #openstack-horizon | 16:53 | |
*** gary-smith has joined #openstack-horizon | 16:54 | |
*** dsneddon has quit IRC | 16:58 | |
*** dsneddon has joined #openstack-horizon | 16:59 | |
*** fischerw has joined #openstack-horizon | 17:01 | |
*** venky has joined #openstack-horizon | 17:03 | |
*** EmilienM|mtg is now known as EmilienM|afk | 17:05 | |
*** bradjones has quit IRC | 17:07 | |
*** bradjones has joined #openstack-horizon | 17:10 | |
*** bradjones has quit IRC | 17:10 | |
*** bradjones has joined #openstack-horizon | 17:10 | |
*** markus_z has quit IRC | 17:12 | |
*** lhcheng has joined #openstack-horizon | 17:13 | |
*** ayoung is now known as adminyoung | 17:20 | |
*** jpich has quit IRC | 17:24 | |
*** JeanBriceCombebi has quit IRC | 17:32 | |
*** neelashah has quit IRC | 17:33 | |
openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Refactor metering utility and view functions https://review.openstack.org/149671 | 17:37 |
*** ygbo has quit IRC | 17:37 | |
*** gary-smith has quit IRC | 17:38 | |
*** gary-smith has joined #openstack-horizon | 17:38 | |
*** MaxV has quit IRC | 17:39 | |
*** dsneddon has quit IRC | 17:39 | |
nikunj2512_ | david-lyle: Hello, need some help with this patch -> https://review.openstack.org/150016 | 17:39 |
*** tqtran has joined #openstack-horizon | 17:40 | |
nikunj2512_ | david-lyle: almost all the tests are failing for this patch | 17:40 |
nikunj2512_ | david-lyle: i am not able to figure out way. Please can You take a look, if You have some time | 17:40 |
tqtran | david-lyle: just a heads up, this is what the keystone folks are cooking for websso | 17:40 |
tqtran | david-lyle: https://review.openstack.org/#/c/133529/14 | 17:40 |
*** dsneddon has joined #openstack-horizon | 17:42 | |
*** amotoki has joined #openstack-horizon | 17:42 | |
*** amotoki has quit IRC | 17:42 | |
*** rdopiera has quit IRC | 17:42 | |
akrivoka | hey horizon cores, may I ask that you please take a look at this patch https://review.openstack.org/#/c/149665/ - it is missing the final +2/A. we have a dependent patch in tuskar-ui which must wait for this one to land. thanks! | 17:42 |
*** julim has quit IRC | 17:46 | |
lhcheng | nikunj2512_: you have to update the code referencing the class you moved. | 17:47 |
david-lyle | nikunj2512_: there are references in the code to the old location | 17:47 |
david-lyle | the test failures point to those | 17:48 |
nikunj2512_ | lhcheng, david-lyle: Ok but i was sure that i removed all the references | 17:49 |
david-lyle | nikunj2512_: openstack_dashboard/dashboards/project/instances/tables.py", line 39 is listed in the test output | 17:50 |
stevemar | thanks tqtran, cc david-lyle if we could get more eyes on https://review.openstack.org/#/c/133529/14 that would be great | 17:51 |
stevemar | lhcheng, reviewed it a bit at the mid-cycle | 17:51 |
david-lyle | I suggest grepping for access_and_security.floating_ips | 17:51 |
nikunj2512_ | david-lyle: Thank You | 17:51 |
stevemar | we just need to know if theres anything we need to do from a process point of view for horizon | 17:51 |
nikunj2512_ | david-lyle: Yes.. I will do it | 17:51 |
david-lyle | tqtran, stevemar, that seems inline with what we discussed at the summit | 17:51 |
stevemar | like submit a spec or blueprint | 17:51 |
nikunj2512_ | david-lyle: Thank You again' | 17:51 |
*** julim has joined #openstack-horizon | 17:56 | |
stevemar | david-lyle, just checking to make sure we don't need to submit a spec or bp? don't want the code submitted and then get locked out of horizon reviews :O | 17:57 |
tqtran | stevemar: looks like there is already a bp for it | 18:00 |
tqtran | stevemar: https://blueprints.launchpad.net/horizon/+spec/federated-horizon | 18:00 |
*** alexpilotti has quit IRC | 18:01 | |
*** dsneddon has quit IRC | 18:01 | |
tqtran | stevemar: looks like its a little different than what was suggested in https://review.openstack.org/#/c/133529/ though | 18:02 |
*** julim_ has joined #openstack-horizon | 18:02 | |
*** dsneddon has joined #openstack-horizon | 18:02 | |
*** EmilienM|afk is now known as EmilienM | 18:03 | |
*** gyee has joined #openstack-horizon | 18:04 | |
*** alexpilotti has joined #openstack-horizon | 18:04 | |
*** julim has quit IRC | 18:05 | |
sambetts | Good evening/Morning, tqtran | 18:05 |
tqtran | sambetts: gm sam | 18:05 |
*** venky has quit IRC | 18:06 | |
stevemar | tqtran, yeah, i was hoping to re-use that one | 18:07 |
tqtran | lhcheng, david-lyle: need clarification on something. when user logs in today, the user credentials are forwarded to keystone in exchange for a token. if the horizon server is compromise, would the password be expose? and can they use that token to do further damage? | 18:07 |
stevemar | or worst case, make a new one, and y'all can mark that one as expired when needed | 18:07 |
*** venky has joined #openstack-horizon | 18:08 | |
*** ttrifonow is now known as zz_ttrifonow | 18:08 | |
david-lyle | tqtran: we don't store the password anywhere, but if the server is compromised, anything is possible, much like if the keystone server is compromised | 18:08 |
david-lyle | we just forward the password as part of the request | 18:09 |
tqtran | david-lyle: right, just wanted to confirm that | 18:09 |
*** adminyoung is now known as ayoung | 18:09 | |
*** akrivoka has quit IRC | 18:09 | |
*** harlowja has joined #openstack-horizon | 18:09 | |
tqtran | david-lyle: https://review.openstack.org/#/c/133529/14/specs/kilo/websso-portal.rst line 26 | 18:10 |
tqtran | i think thats a bit misleading unless im reading it wrong | 18:10 |
david-lyle | that's a hollow sentence | 18:11 |
tqtran | lol "hollow" hahaha | 18:11 |
david-lyle | unless you have a server that is just relaying encrypted data without knowledge of the key | 18:11 |
david-lyle | the proposal just moves the point of risk to the IdP server | 18:12 |
david-lyle | which is fine | 18:12 |
*** harlowja has quit IRC | 18:14 | |
*** harlowja has joined #openstack-horizon | 18:15 | |
openstackgerrit | Merged openstack/horizon: Add "Suspend" and "Resume" actions to Stacks table https://review.openstack.org/149598 | 18:17 |
*** venky has quit IRC | 18:19 | |
*** sbfox has joined #openstack-horizon | 18:19 | |
*** ybathia has joined #openstack-horizon | 18:21 | |
*** dsneddon has quit IRC | 18:22 | |
*** dsneddon has joined #openstack-horizon | 18:23 | |
*** e0ne has quit IRC | 18:28 | |
*** mpavlase has quit IRC | 18:29 | |
nikunj2512_ | david-lyle: Hello again, one question. i have removed this code from the tabs -> https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/tabs.py#L79 | 18:37 |
*** jcoufal has quit IRC | 18:37 | |
nikunj2512_ | david-lyle: and placed in the views | 18:37 |
nikunj2512_ | david-lyle: But my tests are failing due to https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/tabs.py#L122 | 18:38 |
nikunj2512_ | david-lyle: But my tests are failing due to allowed function. Can you tell me how can i replicate the allowed function in the views? | 18:38 |
david-lyle | nikunj2512_: I guessing you didn't mock the floating_ip_supported call | 18:39 |
david-lyle | you should ;-) | 18:39 |
nikunj2512_ | david-lyle: But i have the allowed function in the code | 18:40 |
nikunj2512_ | david-lyle: see here -> https://review.openstack.org/#/c/150016/1/openstack_dashboard/dashboards/project/floating_ips/views.py L88 | 18:41 |
david-lyle | yes, but it's making an API call that has to be mocked in tests | 18:41 |
david-lyle | otherwise, you're attempting to make a call to the neutron server that will fail and floating_ip_support will return false | 18:42 |
nikunj2512_ | david-lyle: This code was in the tabs.py file and then i moved it in the views.py will that cause any problem? | 18:42 |
*** dsneddon has quit IRC | 18:42 | |
david-lyle | view type needs to change | 18:43 |
*** dsneddon has joined #openstack-horizon | 18:43 | |
david-lyle | I've not dug into your change fully, but yes, I imagine there are other implications that will need to be addressed | 18:44 |
nikunj2512_ | Please can you tell me where the view type have to be changed? | 18:45 |
nikunj2512_ | i am trying but not able to | 18:45 |
openstackgerrit | Merged openstack/horizon: Keystone REST API for angular front end. https://review.openstack.org/139532 | 18:46 |
openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Add general function for generating random names https://review.openstack.org/144206 | 18:54 |
*** rushiagr is now known as rushiagr_away | 18:57 | |
*** harlowja has quit IRC | 18:57 | |
*** nyechiel has quit IRC | 18:59 | |
*** jprovazn has quit IRC | 19:01 | |
nikunj2512_ | david-lyle: like allowed function can be used in tabs and tables. Can it be used in views?> | 19:02 |
*** dsneddon has quit IRC | 19:03 | |
*** peristeri has quit IRC | 19:04 | |
*** dsneddon has joined #openstack-horizon | 19:04 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: WIP REST API for create instance angular front end https://review.openstack.org/141273 | 19:04 |
*** alexpilotti has quit IRC | 19:05 | |
*** venky has joined #openstack-horizon | 19:11 | |
*** peristeri has joined #openstack-horizon | 19:15 | |
*** david-lyle is now known as david-lyle_afk | 19:15 | |
rbertram | nikunj2512_: I reviewed your code, but did not know you were stuck on this; just now saw your ask for help | 19:19 |
*** salty has joined #openstack-horizon | 19:19 | |
*** salty is now known as Guest12308 | 19:20 | |
rbertram | nikunj2512_: I can look at it some - still need me to? | 19:20 |
*** dsneddon has quit IRC | 19:24 | |
*** dsneddon has joined #openstack-horizon | 19:25 | |
*** alexpilotti has joined #openstack-horizon | 19:25 | |
*** tosky has quit IRC | 19:28 | |
*** hhuang has quit IRC | 19:33 | |
nikunj2512_ | rbertram: Thank You.. Yes, i still need help | 19:34 |
rbertram | nikunj2512_: ok, let me shift back to it... | 19:34 |
nikunj2512_ | rbertram: i am going to submit a patch with some modifications in test cases but they are still failing. Give me 5 minutes | 19:34 |
nikunj2512_ | rbertram: Thank You | 19:34 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 19:37 |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Moves the Floating IP from compute to Networking https://review.openstack.org/150016 | 19:39 |
nikunj2512_ | rbertram: New patch uploaded. Please wait few minutes for zuul to show the logs or you can download the patch and run the local tests | 19:39 |
*** harlowja has joined #openstack-horizon | 19:41 | |
openstackgerrit | Tomáš Nová?ik proposed openstack/horizon: Add general function for generating random names https://review.openstack.org/144206 | 19:42 |
rbertram | nikunj2512_: looks like you make good progress, just a few Es and Fs now | 19:43 |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds configuration to disable the password in stack creation https://review.openstack.org/148997 | 19:45 |
*** dsneddon has quit IRC | 19:45 | |
*** dsneddon has joined #openstack-horizon | 19:45 | |
openstackgerrit | Merged openstack/horizon: Wrap the main block of detail.html with col-sm-12 class https://review.openstack.org/140000 | 19:45 |
*** radez is now known as radez_g0n3 | 19:46 | |
tqtran | lhcheng: do you know which settings file have higher precedence? the one in horizon, openstack_dashboard, or openstack_dashboard/local? | 19:47 |
tqtran | im assuming the one in local | 19:47 |
*** hhuang has joined #openstack-horizon | 19:47 | |
nikunj2512_ | rbertram: Yes but not able to figure out why thsose errors are coming.. Please if you have any suggestions let me know | 19:48 |
rbertram | nikunj2512_: looking at it now, will let you know | 19:49 |
*** alexpilotti has quit IRC | 19:49 | |
lhcheng | tqtran: should be the os_dashboard/local/local_settings.py - it is loaded last | 19:49 |
nikunj2512_ | rbertram: Thank You | 19:50 |
tqtran | lhcheng: ok thanks, just wanted to make sure | 19:50 |
nikunj2512_ | rbertram: Can we talk about this patch also -> https://review.openstack.org/#/c/149873/ | 19:50 |
nikunj2512_ | rbertram: i have given my comments, please take a look | 19:50 |
*** e0ne has joined #openstack-horizon | 19:51 | |
rbertram | nikunj2512_: sure, but might be tomorrow, I have to leave soon | 19:53 |
nikunj2512_ | rbertram: Ok | 19:55 |
nikunj2512_ | rbertram: did you find out anything about the errors? | 19:55 |
*** venky has quit IRC | 19:55 | |
*** julim_ has quit IRC | 19:55 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds filtering option by Image & Flavor names https://review.openstack.org/149873 | 19:55 |
rbertram | nikunj2512_: Still looking. I notice that openstack_dashboard/dashboards/project/access_and_security/tests.py is where errors originate, and there are a list of floating_ips still in there... | 19:56 |
*** julim has joined #openstack-horizon | 19:57 | |
nikunj2512_ | rbertram: ohhh | 19:58 |
nikunj2512_ | rbertram: i will look again.. i though i removed every reference of it | 19:59 |
rbertram | nikunj2512_: retrying now with them removed... | 19:59 |
nikunj2512_ | Ok | 19:59 |
nikunj2512_ | rbertram: ok | 19:59 |
*** venky has joined #openstack-horizon | 20:03 | |
*** dsneddon has quit IRC | 20:05 | |
*** dsneddon has joined #openstack-horizon | 20:06 | |
*** dboik has quit IRC | 20:11 | |
nikunj2512_ | i am getting this error while running the tests -> UnicodeEncodeError: 'ascii' codec can't encode characters in position 9-11: ordinal not in range(128) | 20:11 |
nikunj2512_ | Anyone have any idea what might be the problem? | 20:12 |
*** julim has quit IRC | 20:14 | |
*** venky has quit IRC | 20:14 | |
rbertram | nikunj2512_: Right, taking the floating_ips out wasn't the whole problem. I have to drop now, but will look again at it later. Please mention here in IRC if you fix it, so I won't bother. | 20:18 |
*** venky has joined #openstack-horizon | 20:18 | |
tqtran | TravT: i remember you ran into an issue where the REST client was getting denied | 20:20 |
tqtran | TravT: it says "request must be AJAX" | 20:20 |
tqtran | TravT: what did you do to resolve this? | 20:20 |
nikunj2512_ | rbertram: definately | 20:20 |
nikunj2512_ | rbertram: Thank You for your efforts | 20:20 |
nikunj2512_ | rbertram: Bye | 20:20 |
*** TravT has quit IRC | 20:23 | |
*** dsneddon has quit IRC | 20:26 | |
*** sbfox has quit IRC | 20:26 | |
*** dsneddon has joined #openstack-horizon | 20:27 | |
*** radez_g0n3 is now known as radez | 20:29 | |
*** nikunj2512_ has quit IRC | 20:30 | |
Piet | A group of students with the University of Washington's UCD program are running a study with Domain Admins in February. Does anyone know someone in their org that would be interested in participating as a subject? | 20:33 |
*** e0ne has quit IRC | 20:34 | |
*** lblanchard has quit IRC | 20:35 | |
*** venky has quit IRC | 20:38 | |
*** sbfox has joined #openstack-horizon | 20:38 | |
*** venky has joined #openstack-horizon | 20:40 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 20:42 |
*** dsneddon has quit IRC | 20:46 | |
*** dsneddon has joined #openstack-horizon | 20:48 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 20:50 |
*** dkorn has joined #openstack-horizon | 20:57 | |
woodm1979 | So… I'm working on some Keystone v3 stuff. Hopefully someone here can help me with the "What's the intended behavior?" type questions. | 20:58 |
*** mrunge_afk has quit IRC | 20:58 | |
*** Ctina_ has joined #openstack-horizon | 21:01 | |
*** Ctina has quit IRC | 21:04 | |
*** nlahouti has quit IRC | 21:05 | |
*** Ctina_ has quit IRC | 21:06 | |
*** raildo has quit IRC | 21:07 | |
*** htruta has quit IRC | 21:07 | |
*** mpavlase has joined #openstack-horizon | 21:07 | |
*** dsneddon has quit IRC | 21:07 | |
*** dsneddon has joined #openstack-horizon | 21:09 | |
*** raildo has joined #openstack-horizon | 21:12 | |
*** htruta has joined #openstack-horizon | 21:12 | |
*** ybathia has quit IRC | 21:15 | |
ericpeterson | woodm1979: it just works™ | 21:15 |
woodm1979 | LOL | 21:15 |
openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 21:18 |
*** TravT has joined #openstack-horizon | 21:19 | |
openstackgerrit | Gabriel Hurley proposed openstack/horizon: Quality of life improvements to APIVersionManager https://review.openstack.org/147670 | 21:19 |
openstackgerrit | George Peristerakis proposed openstack/horizon: Generate a drop down field for custom heat parameters https://review.openstack.org/133270 | 21:19 |
*** dkorn has quit IRC | 21:20 | |
*** jtomasek has quit IRC | 21:22 | |
*** e0ne has joined #openstack-horizon | 21:28 | |
*** dsneddon has quit IRC | 21:29 | |
*** julim has joined #openstack-horizon | 21:30 | |
*** dsneddon has joined #openstack-horizon | 21:31 | |
*** e0ne has quit IRC | 21:33 | |
*** david-lyle_afk is now known as david-lyle | 21:40 | |
david-lyle | woodm1979: what do you need for me to make more confusing? | 21:40 |
woodm1979 | heh. | 21:41 |
tqtran | david-lyle: quick question, concerning https://blueprints.launchpad.net/horizon/+spec/federated-horizon its outdated and not accurate, whats the procedure to override it. Should I start a new bp or modify the existing one? | 21:42 |
woodm1979 | One of the keystone v3 tasks is to allow users that aren't associated with a project to still login. Is this correct? Should we allow that for keystone v2 as well? | 21:43 |
david-lyle | tqtran: either way really | 21:43 |
woodm1979 | david-lyle: ^ | 21:43 |
david-lyle | whatever you prefer | 21:43 |
tqtran | david-lyle: ok, i'll go ahead and create a new bp | 21:43 |
woodm1979 | oh god. | 21:43 |
david-lyle | tqtran: maybe update | 21:44 |
woodm1979 | oh, you were talking to tqtran. :-) | 21:44 |
david-lyle | incase people are already watching that one | 21:44 |
david-lyle | lots of subscribers | 21:44 |
david-lyle | keep and update | 21:44 |
david-lyle | second and more reasoned response | 21:44 |
david-lyle | woodm1979: yes and no | 21:45 |
david-lyle | in that order | 21:45 |
david-lyle | doesn't make sense for v2 | 21:45 |
david-lyle | it actually doesn't make sense for a non-multidomain set up | 21:45 |
woodm1979 | that's what I'm thinking. | 21:45 |
woodm1979 | Good good. | 21:45 |
david-lyle | that's why I have conditions around multidomain | 21:46 |
woodm1979 | perfect. | 21:46 |
*** packet has joined #openstack-horizon | 21:50 | |
*** dsneddon has quit IRC | 21:50 | |
*** e0ne has joined #openstack-horizon | 21:52 | |
*** crobertsrh is now known as _crobertsrh | 21:52 | |
*** sbfox1 has joined #openstack-horizon | 21:52 | |
*** sbfox has quit IRC | 21:54 | |
*** e0ne has quit IRC | 21:57 | |
*** dboik has joined #openstack-horizon | 21:58 | |
*** Miouge has quit IRC | 21:59 | |
*** e0ne has joined #openstack-horizon | 21:59 | |
*** e0ne has quit IRC | 21:59 | |
*** dboik_ has joined #openstack-horizon | 21:59 | |
*** dsneddon has joined #openstack-horizon | 22:00 | |
*** dboik has quit IRC | 22:03 | |
*** nlahouti has joined #openstack-horizon | 22:03 | |
stevemar | tqtran, sounds like keep and update! | 22:04 |
tqtran | stevemar: i'll just create a new bp | 22:04 |
* david-lyle shakes fist | 22:05 | |
tqtran | stevemar: :D | 22:05 |
tqtran | david-lyle: thanks david =) | 22:05 |
stevemar | tqtran, i think you just got a fist shook at you | 22:05 |
woodm1979 | Just make sure you use the OLD blueprint format. | 22:05 |
woodm1979 | david-lyle likes that. ;-) | 22:05 |
* tqtran dodges the fist shake | 22:06 | |
tqtran | woodm1979: lol | 22:06 |
woodm1979 | I should probably dodge the fist shake too. | 22:09 |
* david-lyle is too lazy to shake further | 22:10 | |
*** ybathia has joined #openstack-horizon | 22:11 | |
*** dsneddon has quit IRC | 22:12 | |
*** dsneddon has joined #openstack-horizon | 22:13 | |
activedecay | is there an example horizon plugin someone here has vetted with the latest devstack? This plugin requires modifying the "/opt/stack/horizon/openstack_dashboard/local/local_settings.py" in a way that I don't understand: https://github.com/cloudbuilders/simple_horizon_plugin | 22:15 |
activedecay | actually, I'm just looking for a place to start writing a horizon plugin | 22:18 |
*** venky has quit IRC | 22:19 | |
activedecay | david-lyle: this looks interesting: https://blueprints.launchpad.net/horizon/+spec/plugin-architecture | 22:20 |
david-lyle | activedecay: https://github.com/dklyle/mon-ext | 22:21 |
david-lyle | is a sample I wrote | 22:21 |
activedecay | thanks! | 22:21 |
ayoung | david-lyle, can you bless this review on D-O-A please https://review.openstack.org/#/c/121281/ it has finally gotten some eyeballs. | 22:22 |
*** venky has joined #openstack-horizon | 22:22 | |
david-lyle | ayoung: started reviewing, haven't finished yet | 22:22 |
ayoung | david-lyle, thank you | 22:22 |
david-lyle | activedecay: that's for panels to plugin | 22:22 |
*** radez is now known as radez_g0n3 | 22:22 | |
david-lyle | there is also the tutorial in the horizon docs | 22:23 |
activedecay | david-lyle: *thumbs way up* | 22:23 |
david-lyle | activedecay: https://github.com/openstack/horizon/blob/master/doc/source/topics/tutorial.rst | 22:23 |
david-lyle | but the repo on github is a concrete example of a simple plugin | 22:24 |
activedecay | gotcha | 22:24 |
*** venky has quit IRC | 22:24 | |
*** dboik_ has quit IRC | 22:25 | |
*** jasondotstar has joined #openstack-horizon | 22:28 | |
*** alexpilotti has joined #openstack-horizon | 22:32 | |
*** dsneddon has quit IRC | 22:38 | |
*** dsneddon has joined #openstack-horizon | 22:38 | |
*** mattfarina has quit IRC | 22:39 | |
*** cbader has quit IRC | 22:40 | |
*** jamielennox|away is now known as jamielennox | 22:41 | |
*** nlahouti has quit IRC | 22:41 | |
*** dboik has joined #openstack-horizon | 22:42 | |
*** nlahouti has joined #openstack-horizon | 22:45 | |
*** nlahouti has quit IRC | 22:45 | |
*** e0ne has joined #openstack-horizon | 22:46 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Add Unit column to Usage Report table https://review.openstack.org/150175 | 22:47 |
*** nlahouti has joined #openstack-horizon | 22:47 | |
david-lyle | units, who needs that, just random number without context, that's where it's at | 22:47 |
*** dboik has quit IRC | 22:48 | |
tqtran | david-lyle: or better yet, confusing units | 22:49 |
tqtran | david-lyle: tell people the wrong unit and see them freak out | 22:49 |
david-lyle | ooh, you're on to something now tqtran | 22:49 |
david-lyle | the dashboard of obfuscation and misdirection | 22:49 |
*** dboik has joined #openstack-horizon | 22:50 | |
*** alexpilotti has quit IRC | 22:54 | |
*** jpomero has quit IRC | 22:54 | |
*** dsneddon has quit IRC | 22:58 | |
*** alexpilotti has joined #openstack-horizon | 22:59 | |
*** dsneddon has joined #openstack-horizon | 22:59 | |
TravT | david-lyle: i think you should change the room topic to that | 23:04 |
*** Sukhdev has joined #openstack-horizon | 23:08 | |
*** ZZelle has quit IRC | 23:11 | |
*** ZZelle has joined #openstack-horizon | 23:11 | |
woodm1979 | david-lyle: that's going to have some interesting repercussions for https://review.openstack.org/#/c/141153/2 | 23:13 |
woodm1979 | whooa, that was delayed like crazy. | 23:13 |
woodm1979 | ignore me. | 23:13 |
woodm1979 | * continue to ignore me | 23:14 |
*** TravT_ has joined #openstack-horizon | 23:19 | |
*** stevemar has quit IRC | 23:19 | |
*** dsneddon has quit IRC | 23:19 | |
*** e0ne has quit IRC | 23:20 | |
*** dsneddon has joined #openstack-horizon | 23:20 | |
*** TravT has quit IRC | 23:21 | |
woodm1979 | Procedural question here: If I have a patch that is part 4 of 7 on a blueprint, what do I put in the commit message? | 23:22 |
*** dboik has quit IRC | 23:26 | |
*** woodm1979 has quit IRC | 23:30 | |
*** dboik has joined #openstack-horizon | 23:30 | |
*** vijendar has quit IRC | 23:31 | |
*** david-lyle is now known as david-lyle_afk | 23:31 | |
*** mpavlase has quit IRC | 23:33 | |
*** alexpilotti has quit IRC | 23:38 | |
*** doug-fish has left #openstack-horizon | 23:39 | |
TravT_ | woodm1979: I think: "Partially implements: blueprint name-of-blueprint" | 23:43 |
openstackgerrit | Cindy Lu proposed openstack/horizon: Add Unit column to Usage Report table https://review.openstack.org/150175 | 23:43 |
*** TravT_ has quit IRC | 23:43 | |
*** ybathia has quit IRC | 23:50 | |
*** ybathia has joined #openstack-horizon | 23:50 | |
*** chlong has joined #openstack-horizon | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!