| *** dkingshott has quit IRC | 00:05 | |
| *** bpokorny has joined #openstack-horizon | 00:08 | |
| *** iamjarvo has quit IRC | 00:17 | |
| *** Sukhdev has quit IRC | 00:18 | |
| *** amerine has quit IRC | 00:22 | |
| *** amerine has joined #openstack-horizon | 00:23 | |
| *** stevemar has quit IRC | 00:27 | |
| *** tnovacik has quit IRC | 00:33 | |
| *** gyee has quit IRC | 00:34 | |
| *** Sukhdev has joined #openstack-horizon | 00:36 | |
| *** cody-somerville has quit IRC | 00:41 | |
| *** tzumainn has quit IRC | 00:48 | |
| *** yingjun has joined #openstack-horizon | 00:48 | |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Make values for name&status about job_executions be translatable https://review.openstack.org/152941 | 00:49 |
|---|---|---|
| *** yingjun has quit IRC | 00:52 | |
| openstackgerrit | Mohan Seri proposed openstack/horizon: Integration tests - Volumes tests https://review.openstack.org/119501 | 00:57 |
| *** yingjun has joined #openstack-horizon | 00:57 | |
| *** chlong has joined #openstack-horizon | 01:05 | |
| *** neillc is now known as neillc_afk | 01:07 | |
| *** TravT has joined #openstack-horizon | 01:09 | |
| *** doug-fish has left #openstack-horizon | 01:16 | |
| *** bradjones has quit IRC | 01:17 | |
| *** david-lyle is now known as david-lyle_afk | 01:18 | |
| *** bradjones has joined #openstack-horizon | 01:18 | |
| *** jamielennox|away is now known as jamielennox | 01:19 | |
| *** TravT has quit IRC | 01:22 | |
| *** chlong has quit IRC | 01:22 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular alert/messaging service https://review.openstack.org/141273 | 01:32 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Angular alert/messaging service https://review.openstack.org/134250 | 01:34 |
| *** rwsu is now known as rwsu-afk | 01:43 | |
| openstackgerrit | Andrew Lazarev proposed openstack/horizon: [Sahara] Fixed copy nodegroup template when sec groups missing https://review.openstack.org/153105 | 01:48 |
| *** sivy has quit IRC | 01:49 | |
| *** EmilienM is now known as EmilienM|afk | 01:55 | |
| *** lblanchard has joined #openstack-horizon | 01:58 | |
| *** lblanchard has quit IRC | 02:05 | |
| *** tqtran has quit IRC | 02:10 | |
| *** yingjun has quit IRC | 02:18 | |
| *** ybathia has quit IRC | 02:24 | |
| *** chlong has joined #openstack-horizon | 02:26 | |
| *** Sukhdev has quit IRC | 02:36 | |
| *** bpokorny has quit IRC | 02:39 | |
| *** rushiagr_away is now known as rushiagr | 02:40 | |
| *** chlong has quit IRC | 02:40 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Add project column for admin images tables https://review.openstack.org/147997 | 02:43 |
| *** nlahouti has quit IRC | 02:44 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Move to hacking 0.10 https://review.openstack.org/153120 | 02:56 |
| *** lhcheng has quit IRC | 02:57 | |
| *** Longgeek has joined #openstack-horizon | 02:57 | |
| *** jwy has quit IRC | 03:00 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Nova REST API for angular front end https://review.openstack.org/141273 | 03:00 |
| *** stevemar has joined #openstack-horizon | 03:12 | |
| *** rushiagr is now known as rushiagr_away | 03:18 | |
| *** josecastroleon has quit IRC | 03:23 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 03:24 | |
| *** amotoki has joined #openstack-horizon | 03:25 | |
| *** echevemaster has quit IRC | 03:26 | |
| *** chlong has joined #openstack-horizon | 03:30 | |
| *** chlong has quit IRC | 03:37 | |
| *** stevemar has quit IRC | 03:38 | |
| *** stevemar has joined #openstack-horizon | 03:40 | |
| *** rushiagr_away is now known as rushiagr | 03:43 | |
| *** neillc_afk is now known as neillc | 03:45 | |
| *** Putns has quit IRC | 03:48 | |
| *** Longgeek has quit IRC | 03:53 | |
| *** harlowja is now known as harlowja_away | 03:56 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 03:59 | |
| *** absubram has joined #openstack-horizon | 04:06 | |
| *** absubram has quit IRC | 04:06 | |
| *** lhcheng has joined #openstack-horizon | 04:09 | |
| *** Longgeek has joined #openstack-horizon | 04:10 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 04:17 |
| *** julim has joined #openstack-horizon | 04:32 | |
| *** chlong has joined #openstack-horizon | 04:35 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Move to hacking 0.10 https://review.openstack.org/153120 | 04:39 |
| *** nikunj2512 has joined #openstack-horizon | 04:43 | |
| *** nlahouti has joined #openstack-horizon | 04:52 | |
| *** chlong has quit IRC | 04:54 | |
| *** nlahouti has quit IRC | 04:58 | |
| *** nlahouti has joined #openstack-horizon | 04:59 | |
| *** chlong has joined #openstack-horizon | 05:03 | |
| *** mpavlase has joined #openstack-horizon | 05:06 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Create a reusable angular-based wizard https://review.openstack.org/137417 | 05:17 |
| *** masco has joined #openstack-horizon | 05:22 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds asterisk symbol for image location https://review.openstack.org/124712 | 05:36 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Fixes Error message during instance snapshot creation. https://review.openstack.org/152909 | 05:36 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Changes Identity->Projects Forms into Horizontal Forms https://review.openstack.org/146314 | 05:39 |
| *** dguerri has quit IRC | 05:44 | |
| *** lhcheng has quit IRC | 05:44 | |
| *** lhcheng has joined #openstack-horizon | 05:45 | |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Add "Back To Previous Page" link from all Detail pages https://review.openstack.org/134888 | 05:45 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Fixes inconsistent Router Details page https://review.openstack.org/151226 | 05:45 |
| *** dguerri has joined #openstack-horizon | 05:45 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Activate the timezone while we can get from request.COOKIES https://review.openstack.org/152888 | 05:48 |
| *** coolsvap_ is now known as coolsvap | 05:49 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Activate the timezone while we can get from request.COOKIES https://review.openstack.org/152888 | 05:49 |
| *** mpavlase has quit IRC | 05:50 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: base angular-based launch instance wizard https://review.openstack.org/152822 | 05:54 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds asterisk symbol for image location https://review.openstack.org/124712 | 06:08 |
| openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adds asterisk symbol for image location https://review.openstack.org/124712 | 06:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153139 | 06:13 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/153141 | 06:17 |
| *** _gryf|afk is now known as _gryf | 06:22 | |
| *** TravT has joined #openstack-horizon | 06:23 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:33 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 06:35 |
| *** lhcheng has quit IRC | 06:37 | |
| *** oro has joined #openstack-horizon | 06:38 | |
| *** denis_makogon has joined #openstack-horizon | 06:42 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 06:43 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: IE9 has limit on how many css rules can be parsed in a single css file. The limit is 4095 = (4k - 1). In Horizon, the single generated css file has about 10k lines, which includes more than 4095 css rules. The css rules that come after 4095 will be ignore https://review.openstack.org/153147 | 06:50 |
| *** jprovazn has joined #openstack-horizon | 06:52 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: IE9 cuts off CSS rules https://review.openstack.org/153147 | 06:57 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: IE9 cuts off CSS rules https://review.openstack.org/153147 | 06:58 |
| *** josecastroleon has joined #openstack-horizon | 07:00 | |
| *** nikunj2512 has quit IRC | 07:03 | |
| *** nikunj2512 has joined #openstack-horizon | 07:03 | |
| *** wuhg has joined #openstack-horizon | 07:09 | |
| *** tnovacik has joined #openstack-horizon | 07:12 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: fix bug - IE9 cuts off CSS rules https://review.openstack.org/153147 | 07:22 |
| *** harlowja_away has quit IRC | 07:23 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:26 | |
| *** sayan has joined #openstack-horizon | 07:27 | |
| *** quist has quit IRC | 07:33 | |
| *** jcoufal has joined #openstack-horizon | 07:38 | |
| *** chlong has quit IRC | 07:39 | |
| *** rdopiera has joined #openstack-horizon | 07:49 | |
| *** e0ne has joined #openstack-horizon | 07:51 | |
| *** e0ne has quit IRC | 07:58 | |
| *** jtomasek has joined #openstack-horizon | 08:02 | |
| *** lsmola has quit IRC | 08:05 | |
| *** nlahouti has quit IRC | 08:10 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 08:12 |
| *** stevemar has quit IRC | 08:12 | |
| *** Ala has joined #openstack-horizon | 08:12 | |
| *** jtomasek has quit IRC | 08:18 | |
| *** lsmola has joined #openstack-horizon | 08:22 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: fix bug - IE9 cuts off css rules https://review.openstack.org/153147 | 08:26 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: fix bug - IE9 cuts off css rules https://review.openstack.org/153147 | 08:28 |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/153141 | 08:29 |
| *** markus_z has joined #openstack-horizon | 08:29 | |
| *** TravT has quit IRC | 08:32 | |
| *** shadower has joined #openstack-horizon | 08:34 | |
| *** lsmola has quit IRC | 08:36 | |
| *** lsmola has joined #openstack-horizon | 08:38 | |
| *** MaxV has joined #openstack-horizon | 08:44 | |
| *** oro has quit IRC | 08:49 | |
| *** TravT has joined #openstack-horizon | 08:54 | |
| *** jpich has joined #openstack-horizon | 08:55 | |
| *** denis_makogon has quit IRC | 08:59 | |
| *** TravT has quit IRC | 08:59 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153139 | 09:00 |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:03 | |
| openstackgerrit | Swati Shukla proposed openstack/horizon: Type and Code fields' not marked manadatory in Access-Security tab https://review.openstack.org/153165 | 09:04 |
| *** Longgeek has quit IRC | 09:05 | |
| *** mpavlase has joined #openstack-horizon | 09:06 | |
| *** mpavlase has quit IRC | 09:10 | |
| openstackgerrit | Merged openstack/horizon: Remove unused import urlencode https://review.openstack.org/152899 | 09:15 |
| *** tosky has joined #openstack-horizon | 09:23 | |
| *** JeanBriceCombebi has quit IRC | 09:24 | |
| *** ygbo has joined #openstack-horizon | 09:26 | |
| *** bluex-pl has joined #openstack-horizon | 09:29 | |
| *** bluex-pl has quit IRC | 09:29 | |
| *** bluex-pl has joined #openstack-horizon | 09:29 | |
| *** oro has joined #openstack-horizon | 09:36 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Wait till spinner is visible https://review.openstack.org/151608 | 09:44 |
| *** obutenko has joined #openstack-horizon | 09:49 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: made stack status value is translatable https://review.openstack.org/152092 | 09:49 |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add project-dropdown https://review.openstack.org/151638 | 09:51 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: made stack status value is translatable https://review.openstack.org/152092 | 09:53 |
| *** regebro has joined #openstack-horizon | 09:55 | |
| openstackgerrit | Jamie Lennox proposed openstack/horizon: Redirect initial hit to login page https://review.openstack.org/153174 | 09:55 |
| *** robcresswell_afk is now known as robcresswell | 09:57 | |
| *** obutenko has quit IRC | 10:01 | |
| *** obutenko_ has joined #openstack-horizon | 10:01 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:07 | |
| *** JeanBriceCombebi has quit IRC | 10:08 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:12 | |
| robcresswell | nikunj2512_: https://review.openstack.org/#/c/151226/ | 10:13 |
| robcresswell | nikunj2512_: Why...? | 10:13 |
| robcresswell | nikunj2512_: Please don't override my patches with totally different patches | 10:13 |
| nikunj2512 | robcresswell: Sorry, i didn't do it intentionally, i was removing the merge conflits from previous link patch and it automatically overridden your patch | 10:15 |
| nikunj2512 | robcresswell: i am really sorry... I don't know why because it didn't happen in the past when i added your patch as a dependency for my patch | 10:16 |
| robcresswell | nikunj2512: Ugh its fine, please just check your commits before you push. I'll revert to patchset 6. | 10:16 |
| nikunj2512 | robcresswell: Ok Sorry again | 10:17 |
| *** regebro has left #openstack-horizon | 10:19 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inconsistent Router Details page https://review.openstack.org/151226 | 10:20 |
| *** coolsvap is now known as coolsvap_ | 10:29 | |
| *** jtomasek has joined #openstack-horizon | 10:37 | |
| *** JeanBriceCombebi has quit IRC | 10:39 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style https://review.openstack.org/151762 | 10:42 |
| robcresswell | nikunj2512: Okay, all resolved now. You'll need to rebase your "Back to previous.." patch | 10:46 |
| *** chlong has joined #openstack-horizon | 10:50 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Add integration tests for Identity->Projects page https://review.openstack.org/110919 | 10:51 |
| *** TravT has joined #openstack-horizon | 10:55 | |
| *** alexpilotti has joined #openstack-horizon | 10:56 | |
| *** TravT has quit IRC | 11:00 | |
| *** aix has joined #openstack-horizon | 11:04 | |
| *** sayan has quit IRC | 11:06 | |
| *** e0ne has joined #openstack-horizon | 11:12 | |
| *** akrivoka has joined #openstack-horizon | 11:18 | |
| *** sayan has joined #openstack-horizon | 11:20 | |
| *** sayan has quit IRC | 11:21 | |
| *** sayan has joined #openstack-horizon | 11:21 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Added a migrate_settings command https://review.openstack.org/81255 | 11:24 |
| *** quist has joined #openstack-horizon | 11:30 | |
| *** e0ne is now known as e0ne_ | 11:37 | |
| *** josecastroleon has quit IRC | 11:46 | |
| *** coolsvap_ is now known as coolsvap | 11:46 | |
| *** e0ne_ is now known as e0ne | 11:55 | |
| *** TravT has joined #openstack-horizon | 11:56 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Remove Inheritable*TestCase https://review.openstack.org/150454 | 11:59 |
| *** e0ne has quit IRC | 12:00 | |
| *** josecastroleon has joined #openstack-horizon | 12:00 | |
| *** TravT has quit IRC | 12:01 | |
| *** coolsvap is now known as coolsvap_ | 12:01 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 12:02 |
| openstackgerrit | Sam Betts proposed openstack/horizon: Reduced code duplication in creating page headers https://review.openstack.org/142802 | 12:02 |
| *** EmilienM|afk is now known as EmilienM | 12:02 | |
| *** wuhg has quit IRC | 12:09 | |
| *** e0ne has joined #openstack-horizon | 12:09 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Add page_title mixin to all templates https://review.openstack.org/149960 | 12:13 |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Add blue mark tips in change password description https://review.openstack.org/153204 | 12:19 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 12:31 |
| openstackgerrit | Thomas Bechtold proposed openstack/horizon: Fix display of ports when associating floating IP https://review.openstack.org/142605 | 12:36 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata widget multivalue selection support https://review.openstack.org/153210 | 12:37 |
| *** chlong has quit IRC | 12:38 | |
| *** nikunj2512 has quit IRC | 12:48 | |
| *** quist` has joined #openstack-horizon | 12:56 | |
| *** tosky has quit IRC | 12:57 | |
| *** quist` has left #openstack-horizon | 12:57 | |
| *** quist` has joined #openstack-horizon | 12:59 | |
| *** quist has quit IRC | 12:59 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata display widget https://review.openstack.org/151745 | 13:00 |
| *** quist` has quit IRC | 13:01 | |
| *** quist` has joined #openstack-horizon | 13:01 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:02 | |
| *** tzumainn has joined #openstack-horizon | 13:06 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Remove Inheritable*TestCase https://review.openstack.org/150454 | 13:11 |
| *** masco has quit IRC | 13:19 | |
| *** Ctina has joined #openstack-horizon | 13:23 | |
| *** tosky has joined #openstack-horizon | 13:27 | |
| *** quist` has quit IRC | 13:38 | |
| *** kromanenko has joined #openstack-horizon | 13:39 | |
| *** jpomero has joined #openstack-horizon | 13:41 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style https://review.openstack.org/151762 | 13:44 |
| *** gerchardon has joined #openstack-horizon | 13:45 | |
| robcresswell | TravT_: Could take a look over https://review.openstack.org/#/c/151762/7 if you get chance. Its the Details page cleanup. | 13:48 |
| *** mpavlase has joined #openstack-horizon | 13:49 | |
| robcresswell | TravT_: Been moving details pages over to tabbed pages - done Routers, working on Networks, so they can share that common template. | 13:49 |
| *** amotoki has quit IRC | 14:00 | |
| *** quist` has joined #openstack-horizon | 14:07 | |
| *** davelowe has joined #openstack-horizon | 14:10 | |
| *** gerchardon has quit IRC | 14:12 | |
| *** lblanchard has joined #openstack-horizon | 14:14 | |
| *** e0ne is now known as e0ne_ | 14:14 | |
| *** neelashah has joined #openstack-horizon | 14:20 | |
| *** doug-fish has joined #openstack-horizon | 14:20 | |
| openstackgerrit | Bartosz Fic proposed openstack/horizon: Migrate all instances from host marked for maintenance https://review.openstack.org/109586 | 14:20 |
| *** gerchardon has joined #openstack-horizon | 14:24 | |
| *** e0ne_ has quit IRC | 14:24 | |
| *** e0ne has joined #openstack-horizon | 14:26 | |
| *** jcoufal_ has joined #openstack-horizon | 14:30 | |
| *** TravT has joined #openstack-horizon | 14:32 | |
| *** jcoufal has quit IRC | 14:33 | |
| *** ZZelle has quit IRC | 14:34 | |
| *** ZZelle has joined #openstack-horizon | 14:35 | |
| *** TravT has quit IRC | 14:37 | |
| *** TravT has joined #openstack-horizon | 14:41 | |
| *** Drago has joined #openstack-horizon | 14:44 | |
| *** Drago has quit IRC | 14:44 | |
| *** Drago has joined #openstack-horizon | 14:44 | |
| *** krykowski has joined #openstack-horizon | 14:45 | |
| *** absubram has joined #openstack-horizon | 14:47 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: WIP Service configuration form https://review.openstack.org/152558 | 14:55 |
| *** josecastroleon has quit IRC | 15:00 | |
| *** masco has joined #openstack-horizon | 15:03 | |
| *** TravT has quit IRC | 15:04 | |
| *** ericpeterson has joined #openstack-horizon | 15:07 | |
| *** e0ne is now known as e0ne_ | 15:17 | |
| *** e0ne_ is now known as e0ne | 15:17 | |
| *** rm_work|away is now known as rm_work | 15:18 | |
| *** TravT has joined #openstack-horizon | 15:21 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Addresses Detail page inconsistencies & code style https://review.openstack.org/151762 | 15:22 |
| *** david-lyle_afk is now known as david-lyle | 15:23 | |
| *** TravT has quit IRC | 15:25 | |
| *** TravT has joined #openstack-horizon | 15:27 | |
| robcresswell | Hmm... how do I go about reporting an incorrect translation? | 15:28 |
| robcresswell | or localisation, really. | 15:28 |
| robcresswell | "Flavor" becomes "Flavour" in the UK, but "Flavor ID" remains incorrect, it seems. | 15:30 |
| openstackgerrit | Merged openstack/horizon: Fix typo in calling _is_element_visible method https://review.openstack.org/153084 | 15:30 |
| *** josecastroleon has joined #openstack-horizon | 15:30 | |
| openstackgerrit | Merged openstack/horizon: Move to hacking 0.10 https://review.openstack.org/153120 | 15:31 |
| *** jcoufal_ has quit IRC | 15:33 | |
| *** jcoufal has joined #openstack-horizon | 15:34 | |
| jpich | robcresswell: I think the fastest way would be for you to contribute the fix yourself on Transifex ( https://wiki.openstack.org/wiki/Documentation/Translation#Contribute_as_a_translator ) | 15:36 |
| jpich | The slower way would be to report a bug on the i18n LP project I think, but since there's not translation coordinator for British English I think it would just languish | 15:37 |
| *** vijendar has joined #openstack-horizon | 15:38 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Error handling patterns are consistent in volumes forms https://review.openstack.org/143470 | 15:39 |
| robcresswell | jpich: Yeah I'd rather do it myself, thankyou for the link | 15:41 |
| jpich | robcresswell: Thanks! | 15:41 |
| *** jcoufal has quit IRC | 15:45 | |
| *** jcoufal has joined #openstack-horizon | 15:46 | |
| *** jcoufal_ has joined #openstack-horizon | 15:47 | |
| *** Ctina_ has joined #openstack-horizon | 15:48 | |
| *** stevemar has joined #openstack-horizon | 15:50 | |
| *** Ctina has quit IRC | 15:50 | |
| *** jcoufal has quit IRC | 15:50 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Make ipmi_address, ssh_address, ssh_key_contents and ssh_username required https://review.openstack.org/153265 | 15:53 |
| *** rm_work is now known as rm_work|away | 15:54 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Make ipmi_address, ssh_address, ssh_key_contents and ssh_username required https://review.openstack.org/153265 | 15:55 |
| rbertram | Is the scss compiled every time a Horizon page is rendered? Or do I need to do a compile step first? | 15:56 |
| pkarikh | Hi all! Does anybody knows where ceilometer's admin role is located in horizon/conf/*_policy.json files? Does it exist? | 16:01 |
| *** bpokorny has joined #openstack-horizon | 16:01 | |
| *** tzumainn has quit IRC | 16:03 | |
| *** tzumainn has joined #openstack-horizon | 16:03 | |
| david-lyle | rbertram: how are you running horizon? | 16:05 |
| david-lyle | but no, not every time a page is rendered | 16:05 |
| david-lyle | either on start up of the horizon server (online compression) or manually while horizon is offline (offline compression) | 16:06 |
| david-lyle | if you are running the dev server, it will restart and recompress every time a change is made to the code | 16:06 |
| jpich | pkarikh: If there is no ceilometer_policy.json file, it likely means no one has had a chance to implement RBAC on the Ceilometer panels yet | 16:07 |
| david-lyle | jpich, pkarikh are the time there was no policy in ceilometer, has that changed? | 16:08 |
| david-lyle | I think admin is hard coded | 16:08 |
| jpich | That could explain it too :) | 16:08 |
| david-lyle | unless something has changed | 16:08 |
| pkarikh | davil-dyle: maybe I've misunderstood you here? https://review.openstack.org/#/c/123741/12/openstack_dashboard/dashboards/admin/metering/panel.py I thought it already exists.. | 16:10 |
| pkarikh | *david-lyle, sorry. :) | 16:10 |
| david-lyle | pkarikh: no, I was wrong there | 16:11 |
| david-lyle | but looking at the ceilometer code, I see a policy.json | 16:11 |
| david-lyle | trying to determine if they are using it | 16:11 |
| *** TravT has quit IRC | 16:11 | |
| david-lyle | I may want to add that one in | 16:12 |
| rbertram | david-lyle: Thanks. I am running the dev server - yes, what you say matches what I'm seeing. | 16:12 |
| *** JeanBriceCombebi has quit IRC | 16:14 | |
| david-lyle | pkarikh: policy support in ceilometer was added 2 months ago | 16:14 |
| david-lyle | I work on pulling that in | 16:15 |
| * david-lyle looking for the end of his queue to add it to | 16:15 | |
| pkarikh | david-lyle: hm.. So, should I mark my patch as WIP until you'll pull it? I can try to implement some draft there until I'll be able to use pulled policies. | 16:16 |
| *** jcoufal_ has quit IRC | 16:17 | |
| *** jcoufal has joined #openstack-horizon | 16:17 | |
| david-lyle | pkarikh: just leave the metering panel as is for now and do the rest of your patch, I'll fix that when the policy stuff is ready | 16:18 |
| david-lyle | no need to WIP | 16:18 |
| david-lyle | just W | 16:18 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Remove outdated FIXME https://review.openstack.org/153275 | 16:19 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Make node registration fields required https://review.openstack.org/153265 | 16:20 |
| pkarikh | david-lyle: and should I do not make any changes here? https://review.openstack.org/#/c/123741/12/openstack_dashboard/dashboards/admin/dashboard.py | 16:21 |
| *** rushiagr is now known as rushiagr_away | 16:21 | |
| david-lyle | pkarikh: that one should change | 16:21 |
| david-lyle | you can just remove that role check | 16:21 |
| david-lyle | if the other panels have proper checks | 16:21 |
| *** htruta has quit IRC | 16:22 | |
| david-lyle | as I commented the dashboard won't show if the user doesn't have permission on any of the panels in it | 16:22 |
| *** rm_work|away is now known as rm_work | 16:22 | |
| pkarikh | david-lyle: yep, it was the second idea. :) | 16:22 |
| pkarikh | david-lyle: thank you! I'm going to refactor it. | 16:25 |
| *** rdopiera has quit IRC | 16:25 | |
| david-lyle | pkarikh: thanks | 16:26 |
| *** rwsu-afk is now known as rwsu | 16:28 | |
| *** TravT has joined #openstack-horizon | 16:34 | |
| *** alexvictorchan has joined #openstack-horizon | 16:41 | |
| *** ybathia has joined #openstack-horizon | 16:41 | |
| *** kromanenko has quit IRC | 16:44 | |
| *** oro has quit IRC | 16:46 | |
| *** nlahouti has joined #openstack-horizon | 16:46 | |
| *** htruta has joined #openstack-horizon | 16:48 | |
| *** rushiagr_away is now known as rushiagr | 16:49 | |
| *** ayoung has quit IRC | 16:49 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 16:50 |
| *** e0ne has quit IRC | 16:51 | |
| *** e0ne has joined #openstack-horizon | 16:51 | |
| *** obutenko_ has quit IRC | 16:54 | |
| *** mattfarina has joined #openstack-horizon | 17:01 | |
| *** neelashah has quit IRC | 17:02 | |
| *** tqtran has joined #openstack-horizon | 17:06 | |
| *** josecastroleon has quit IRC | 17:11 | |
| *** sayan has quit IRC | 17:11 | |
| *** ygbo has quit IRC | 17:12 | |
| *** akrivoka has quit IRC | 17:14 | |
| *** aix has quit IRC | 17:14 | |
| *** sivy has joined #openstack-horizon | 17:15 | |
| sivy | mornin folks | 17:16 |
| *** neelashah has joined #openstack-horizon | 17:16 | |
| *** jprovazn has quit IRC | 17:17 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 17:19 |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: WIP Service configuration form https://review.openstack.org/152558 | 17:22 |
| *** jpich has quit IRC | 17:23 | |
| *** jtomasek has quit IRC | 17:23 | |
| *** MaxV has quit IRC | 17:26 | |
| *** neelashah has quit IRC | 17:26 | |
| *** ayoung has joined #openstack-horizon | 17:26 | |
| *** lhcheng has joined #openstack-horizon | 17:27 | |
| *** tosky has quit IRC | 17:31 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: WIP Magic Search in Angular User https://review.openstack.org/151386 | 17:32 |
| *** KanagarajM has joined #openstack-horizon | 17:33 | |
| *** masco has quit IRC | 17:34 | |
| *** oro has joined #openstack-horizon | 17:36 | |
| *** e0ne is now known as e0ne_ | 17:39 | |
| *** e0ne_ is now known as e0ne | 17:41 | |
| *** tsufiev is now known as tsufiev_ | 17:44 | |
| KanagarajM | Hi cores, could some one review the patch https://review.openstack.org/141759 its critical for the customers who uses VMWare vCenter cluster in nova. | 17:46 |
| openstackgerrit | Merged openstack/horizon: Make params order fixed in stack forms https://review.openstack.org/152509 | 17:48 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular Modal https://review.openstack.org/140932 | 17:49 |
| openstackgerrit | Thai Tran proposed openstack/horizon: add angular-bootstrap to jasmine spec runner page https://review.openstack.org/152814 | 17:49 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular Modal https://review.openstack.org/140932 | 17:51 |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Move to hacking 0.10 https://review.openstack.org/153313 | 17:52 |
| openstackgerrit | Merged openstack/horizon: [Sahara] Fixed copy nodegroup template when sec groups missing https://review.openstack.org/153105 | 17:56 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 17:57 |
| *** ayoung has quit IRC | 17:57 | |
| openstackgerrit | Merged openstack/horizon: added filter for stacks table https://review.openstack.org/152409 | 17:58 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 17:58 |
| *** KanagarajM has quit IRC | 17:58 | |
| *** bpokorny_ has joined #openstack-horizon | 17:59 | |
| *** Ctina_ has quit IRC | 17:59 | |
| *** bpokorny has quit IRC | 18:02 | |
| *** Piet has joined #openstack-horizon | 18:02 | |
| *** clu_ has joined #openstack-horizon | 18:02 | |
| *** tosky has joined #openstack-horizon | 18:03 | |
| openstackgerrit | Andrew Bramley proposed openstack/horizon: Add support for Trove Replication https://review.openstack.org/114380 | 18:03 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inconsistent Router Details page https://review.openstack.org/151226 | 18:07 |
| *** krykowski has quit IRC | 18:07 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Consolidating conf and scripts https://review.openstack.org/141457 | 18:11 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inconsistent Router Details page https://review.openstack.org/151226 | 18:13 |
| *** mattfarina has quit IRC | 18:19 | |
| *** e0ne has quit IRC | 18:21 | |
| *** jcoufal has quit IRC | 18:22 | |
| *** radez_g0n3 is now known as radez | 18:23 | |
| *** neelashah has joined #openstack-horizon | 18:26 | |
| *** mattfarina has joined #openstack-horizon | 18:28 | |
| *** harlowja has joined #openstack-horizon | 18:30 | |
| *** bluex-pl has quit IRC | 18:31 | |
| *** rushiagr is now known as rushiagr_away | 18:36 | |
| *** markus_z has quit IRC | 18:37 | |
| *** sayan has joined #openstack-horizon | 18:40 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Fix import order in utils/metering.py https://review.openstack.org/150862 | 18:42 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 18:47 |
| *** bpokorny has joined #openstack-horizon | 18:48 | |
| *** sayan has quit IRC | 18:49 | |
| *** sayan has joined #openstack-horizon | 18:50 | |
| *** bpokorny_ has quit IRC | 18:51 | |
| *** bpokorny has quit IRC | 18:52 | |
| *** sayan has quit IRC | 18:56 | |
| *** sayan has joined #openstack-horizon | 18:57 | |
| *** mattfarina has quit IRC | 18:57 | |
| *** ybathia has quit IRC | 18:58 | |
| *** mattfarina has joined #openstack-horizon | 19:01 | |
| *** sayan has quit IRC | 19:03 | |
| *** mpavlase has quit IRC | 19:14 | |
| *** ayoung has joined #openstack-horizon | 19:18 | |
| *** jpomero has quit IRC | 19:20 | |
| *** rhsu has joined #openstack-horizon | 19:31 | |
| *** rhsu has quit IRC | 19:31 | |
| mattfarina | tqtran ping | 19:33 |
| tqtran | mattfarina: hey matt | 19:33 |
| mattfarina | tqtran since JS is code... and it's distributed from servers to browsers.... should the license comments be at the top of them like python files? | 19:34 |
| tqtran | I would like to think so, it takes as much effort, its something we can bring up at the horizon meetup. I would prefer that we don't get into another mailing list war. | 19:35 |
| tqtran | *horizon meeting, not meetup lol | 19:35 |
| mattfarina | tqtran i'm heading out on vacation for 2 weeks so i won't be around to bring it up in the next couple meetings. is that something you'd be up for doing? | 19:36 |
| david-lyle | tqtran: d oto | 19:36 |
| tqtran | its nice to get opinions from others, but its ultimately us who is going to work and maintain the code. | 19:36 |
| david-lyle | do to | 19:36 |
| robcresswell | do to? | 19:36 |
| tqtran | mattfarina: sure, i can do that =) | 19:36 |
| david-lyle | tqtran: does want another mailing list war | 19:37 |
| tqtran | lol | 19:37 |
| * david-lyle being a childish instigator | 19:37 | |
| robcresswell | haha | 19:37 |
| mattfarina | yeah, i didn't want to drop a bomb on the mailing list and then leave on vacation. | 19:38 |
| *** robcresswell is now known as robcresswell_afk | 19:38 | |
| mattfarina | tqtran thanks | 19:38 |
| tqtran | mattfarina: lol np | 19:39 |
| *** Sukhdev has joined #openstack-horizon | 19:40 | |
| *** ericpeterson has quit IRC | 19:44 | |
| *** oro has quit IRC | 19:53 | |
| *** oro has joined #openstack-horizon | 19:55 | |
| *** ericpeterson has joined #openstack-horizon | 19:58 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 19:59 |
| *** ericpeterson has quit IRC | 20:00 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Glance Rest API for Angular Front End https://review.openstack.org/151468 | 20:00 |
| *** ericpeterson has joined #openstack-horizon | 20:00 | |
| *** ttrifonov is now known as zz_ttrifonov | 20:02 | |
| *** neelashah1 has joined #openstack-horizon | 20:04 | |
| *** oro has quit IRC | 20:05 | |
| *** neelashah has quit IRC | 20:05 | |
| samueldmq | david-lyle, could you give me an entry point in the code for the call used on the *management of project roles* screen? | 20:10 |
| samueldmq | david-lyle, need to see how you're using the client... | 20:11 |
| david-lyle | samueldmq: all keystone client calls in Horizon proper are here https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py | 20:12 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/roles/views.py#L43 is where we call to get the list | 20:13 |
| samueldmq | david-lyle, thank you very much :) | 20:13 |
| samueldmq | david-lyle, great! will get the info that I need there | 20:13 |
| david-lyle | sure all role interaction is contained in that identity/roles directory | 20:13 |
| david-lyle | either in views.py tables.py or forms.py | 20:14 |
| *** e0ne has joined #openstack-horizon | 20:17 | |
| *** e0ne is now known as e0ne_ | 20:17 | |
| *** e0ne_ is now known as e0ne | 20:19 | |
| *** bpokorny has joined #openstack-horizon | 20:33 | |
| *** TravT has quit IRC | 20:34 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:46 | |
| r1chardj0n3s | morning | 20:46 |
| *** neelashah1 has quit IRC | 21:04 | |
| rbertram | r1chardj0n3s: morning | 21:08 |
| r1chardj0n3s | hiya rbertram | 21:08 |
| rbertram | r1chardj0n3s: I'm still wanting to discuss this change with you: https://review.openstack.org/#/c/151386/8/openstack_dashboard/api/rest/keystone.py | 21:08 |
| rbertram | r1chardj0n3s: when you have a chance | 21:08 |
| r1chardj0n3s | ah yep | 21:09 |
| rbertram | r1chardj0n3s: I have a proposal for how it should work (it's not the kludge that's coded now) | 21:09 |
| rbertram | r1chardj0n3s: and also wonder whether it belongs in a change you are working on, or it's own bug or what | 21:09 |
| r1chardj0n3s | my patch landed yesterday ;) | 21:10 |
| rbertram | r1chardj0n3s: good | 21:10 |
| r1chardj0n3s | so no worries there then! :) | 21:10 |
| *** zul has quit IRC | 21:12 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 21:15 |
| openstackgerrit | Merged openstack/horizon: [Sahara] Support Cinder availability zones https://review.openstack.org/128906 | 21:17 |
| *** neelashah has joined #openstack-horizon | 21:27 | |
| *** tnovacik has quit IRC | 21:28 | |
| *** amerine has quit IRC | 21:32 | |
| *** amerine has joined #openstack-horizon | 21:33 | |
| *** denis_makogon has joined #openstack-horizon | 21:34 | |
| *** absubram has left #openstack-horizon | 21:39 | |
| *** Sukhdev has quit IRC | 21:40 | |
| *** lhcheng has quit IRC | 21:44 | |
| *** lhcheng has joined #openstack-horizon | 21:45 | |
| *** Piet has quit IRC | 21:46 | |
| *** crobertsrh is now known as _crobertsrh | 21:50 | |
| *** MaxV has joined #openstack-horizon | 21:55 | |
| *** neelashah has quit IRC | 21:56 | |
| *** sivy has quit IRC | 21:56 | |
| *** ZZelle_ has joined #openstack-horizon | 21:58 | |
| *** MaxV has quit IRC | 22:00 | |
| *** e0ne has quit IRC | 22:00 | |
| *** mattfarina has quit IRC | 22:02 | |
| *** denis_makogon has quit IRC | 22:08 | |
| *** lblanchard has quit IRC | 22:11 | |
| *** neillc is now known as neill_afk | 22:12 | |
| *** neelashah has joined #openstack-horizon | 22:23 | |
| *** radez is now known as radez_g0n3 | 22:46 | |
| david-lyle | tqtran: how did you test https://review.openstack.org/#/c/137417/30 ? | 22:50 |
| david-lyle | is Sean on IRC? | 22:50 |
| tqtran | https://review.openstack.org/#/c/152822/ | 22:50 |
| tqtran | he created a dependency patch | 22:50 |
| tqtran | to demo it off | 22:50 |
| david-lyle | ah, had overlooked that one | 22:51 |
| david-lyle | thanks! | 22:51 |
| tqtran | np! | 22:51 |
| david-lyle | all the duplication of patches made that bp a mess to sort out | 22:52 |
| david-lyle | less of that is better | 22:52 |
| * david-lyle point to obvious | 22:53 | |
| tqtran | david-lyle: lol yeah, all the angular work points to 2 bp | 22:53 |
| tqtran | david-lyle: which is craaazy, it means we will never be truly done | 22:54 |
| david-lyle | but in the reusable wizard there were two separate implementations | 22:54 |
| tqtran | david-lyle: oh right lol yes, very confusing | 22:54 |
| tqtran | david-lyle: thats gotten resolve i think | 22:54 |
| david-lyle | I feel like posting a third just to clarify things ;P | 22:54 |
| tqtran | lol | 22:54 |
| david-lyle | that's kinda slick | 22:55 |
| david-lyle | \o/ | 22:55 |
| david-lyle | progress | 22:55 |
| tqtran | yeah, its pretty slick | 22:56 |
| tqtran | https://review.openstack.org/#/c/151101/ | 22:56 |
| tqtran | check out that demo as well | 22:56 |
| david-lyle | here I thought you all were just milking the clock | 22:56 |
| david-lyle | :D | 22:57 |
| tqtran | lol | 22:57 |
| tqtran | i prefer the term, "babysitting" the clock | 22:57 |
| *** ybathia has joined #openstack-horizon | 22:57 | |
| david-lyle | well it's not going to tick on its own | 22:58 |
| david-lyle | couple of questions | 22:58 |
| * tqtran ducks | 22:58 | |
| *** neelashah has quit IRC | 22:59 | |
| david-lyle | https://review.openstack.org/#/c/152822/2/horizon/static/angular/app.module.js seems problematic. I hope we have a better way to register these than that | 22:59 |
| david-lyle | oh god, and https://review.openstack.org/#/c/152822/2/horizon/templates/horizon/_scripts.html | 23:00 |
| tqtran | lol | 23:00 |
| david-lyle | I'm hoping these are quick and dirty hacks | 23:00 |
| david-lyle | but leads me to think that a mechanism is not in place | 23:01 |
| tqtran | I think we could write something on the django side | 23:01 |
| david-lyle | we better | 23:01 |
| tqtran | that would auto detect certain folders, and script and auto include them | 23:01 |
| tqtran | that would help us clean out a lot of stuff | 23:01 |
| david-lyle | akin to the template loader | 23:01 |
| tqtran | yep | 23:01 |
| *** vijendar has quit IRC | 23:02 | |
| david-lyle | I'm also going to want to add steps in my deployment because you horizon developers have forgot the most important part | 23:03 |
| david-lyle | how do I add that important step to the wizard? | 23:03 |
| *** tosky has quit IRC | 23:04 | |
| david-lyle | can I add to steps in https://review.openstack.org/#/c/152822/2/horizon/static/angular/launch-instance/launch-instance.js | 23:04 |
| tqtran | i'm not clear | 23:05 |
| david-lyle | ok, I know the second patch is not intended to merge as is | 23:05 |
| tqtran | you mean, if someone wants to extend the launch instance steps? | 23:05 |
| david-lyle | exactly | 23:05 |
| r1chardj0n3s | hi folks, I'm in a meeting at the moment, but I would very much like to talk about the angular module madness ;) | 23:05 |
| david-lyle | is that a new disorder | 23:06 |
| david-lyle | AMM | 23:06 |
| david-lyle | I'm suffering too | 23:06 |
| r1chardj0n3s | yep | 23:06 |
| david-lyle | this needs to be more dynamic | 23:06 |
| r1chardj0n3s | we need to have a good think about how to make the new work we're doing extension-friendly (my coworker neillc who is away today just did some angular-based horizon extending, and it was tricky in a few ways) | 23:07 |
| david-lyle | r1chardj0n3s: I couldn't agree more | 23:07 |
| david-lyle | hard-coding is not going to get us very far | 23:07 |
| tqtran | david-lyle: i spoke to doug about it as well, i have some ideas on how to make it more extension-friendly | 23:08 |
| lhcheng | +1 on adding steps | 23:08 |
| lhcheng | if it is not extensible to add steps, it wouldn't work for most deployer that has customization. | 23:08 |
| tqtran | david-lyle, lhcheng: to be fair, you could just insert a step into the code. not ideal but it would work | 23:09 |
| tqtran | much like how you would do it today in django | 23:09 |
| david-lyle | tqtran: no, I insert a step, a hard-coded js file, a hard-coded angular module, etc | 23:10 |
| lhcheng | umm that's patching the code | 23:10 |
| david-lyle | lhcheng: to be fair, you have to patch now | 23:10 |
| david-lyle | the step list is not dynamic | 23:11 |
| lhcheng | ideally we can extend and add steps, doesn't that work now? | 23:11 |
| david-lyle | oh yeah, extend | 23:11 |
| tqtran | so when we say extend, we're talking about inheritance? | 23:11 |
| david-lyle | you could still do that if module discovery is done with a loader | 23:11 |
| lhcheng | tqtran: yeah | 23:11 |
| tqtran | or completely replace a panel via a file somewhere else? | 23:11 |
| lhcheng | tqtran: radomir touch upon it in the last summit | 23:12 |
| r1chardj0n3s | I've got neillc working on some of the bower stuff (and there's a whole conversation I had with #infra yesterday that was fun around that) but It'd be good if he could be included in the conversation around extending | 23:12 |
| *** zul has joined #openstack-horizon | 23:12 | |
| r1chardj0n3s | tqtran if you end up OOB'ing the conversation, please include neillc :) | 23:12 |
| lhcheng | tqtran: I think hide the existing panel, and expose the extended panel | 23:12 |
| tqtran | OOB? | 23:12 |
| r1chardj0n3s | out-of-band | 23:13 |
| tqtran | r1chardj0n3s: still don't get what you're saying lol | 23:13 |
| david-lyle | tqtran: offline | 23:13 |
| tqtran | ah... ok | 23:13 |
| david-lyle | not in a public forum | 23:13 |
| david-lyle | on the down-low | 23:13 |
| david-lyle | :D | 23:14 |
| tqtran | lol | 23:14 |
| tqtran | thanks david, very helpful | 23:14 |
| david-lyle | and I wasn't even trying | 23:14 |
| r1chardj0n3s | yeah, what david-lyle said | 23:14 |
| tqtran | so example of how to extend, you could create a factory that depends on launchInstanceWorkFlow | 23:14 |
| tqtran | it returns an object with the steps, and you can easily just override that with your own, or append to it, whatever youw ant | 23:15 |
| david-lyle | how do I do that override? | 23:15 |
| tqtran | then in your template, simply use your own factory/controller | 23:15 |
| david-lyle | surpress the current template and use mine instead | 23:16 |
| tqtran | its not true classical inheritance, the entire thing revolves around dependency injection | 23:16 |
| david-lyle | so I hit at the django template level | 23:16 |
| r1chardj0n3s | indeed it's not inheritance, it's composition and subbing things in through replacing dependencies before they're injected | 23:16 |
| r1chardj0n3s | angular supports that through a couple of mechanisms | 23:17 |
| david-lyle | cut and paster | 23:17 |
| david-lyle | *paste | 23:17 |
| * david-lyle not being helpful again | 23:17 | |
| *** mpavlase has joined #openstack-horizon | 23:18 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Move to hacking 0.10 https://review.openstack.org/153313 | 23:19 |
| *** echevemaster has joined #openstack-horizon | 23:19 | |
| tqtran | im not sure its entirely possible to extend without modifying existing code? there's gotta be some point somewhere you have to hardcode | 23:19 |
| r1chardj0n3s | tqtran: do you have a specific scenario you're thinking of? | 23:20 |
| tqtran | well, lets take the wizard for example. if i wanted to add extra step to it, how would i do that? | 23:20 |
| r1chardj0n3s | yeah, so you'd need to replace the variable listing the steps | 23:21 |
| r1chardj0n3s | is that something you'd call "hard code"? | 23:22 |
| david-lyle | that's fine, but you have to get that change picked up | 23:22 |
| david-lyle | even if it lives in a custom application | 23:23 |
| *** chlong has joined #openstack-horizon | 23:23 | |
| r1chardj0n3s | so you're wondering how to have the custom code be invoked to make that change? | 23:23 |
| *** zul has quit IRC | 23:24 | |
| david-lyle | yes, in django it's done with template loading order | 23:24 |
| david-lyle | how is that handled in angular? | 23:24 |
| r1chardj0n3s | in angular, loading order still matters | 23:24 |
| r1chardj0n3s | so that takes care of precedence | 23:24 |
| david-lyle | I guess it is javascript | 23:24 |
| david-lyle | last write wins | 23:25 |
| r1chardj0n3s | and then to have code actually do something useful, angular provides two "set up" methods | 23:25 |
| *** alexpilotti has quit IRC | 23:25 | |
| r1chardj0n3s | module.config() for during setup and module.run() when the app is being launched | 23:25 |
| r1chardj0n3s | so if you want to override some setting in a module, you have yourself loaded after it, and do smoething useful in yourt module.config() | 23:26 |
| david-lyle | makes sense, like append workflow step to contain your fancy step | 23:26 |
| *** ericpeterson has quit IRC | 23:26 | |
| david-lyle | *workflow steps | 23:26 |
| r1chardj0n3s | yep | 23:26 |
| david-lyle | ok, that's reasonable | 23:27 |
| david-lyle | but we still have the js inclusion problem | 23:27 |
| r1chardj0n3s | so you still need to modify the _scripts.html to include your code | 23:27 |
| david-lyle | noooo! | 23:27 |
| r1chardj0n3s | *unless* | 23:27 |
| david-lyle | that's terrible | 23:27 |
| r1chardj0n3s | oh man, my enter key is too touchy ;) | 23:28 |
| david-lyle | you're scaring me | 23:28 |
| tqtran | you could write _script as a django template and auto include *.js files | 23:28 |
| r1chardj0n3s | I meant to continue to say *unless* we create some sort of pattern which populates _scripts.html from the filesystem | 23:28 |
| tqtran | exactly | 23:28 |
| r1chardj0n3s | *and* we should use that to load all *our* components | 23:28 |
| r1chardj0n3s | but then precedence becomes an issue | 23:28 |
| r1chardj0n3s | ordering | 23:28 |
| r1chardj0n3s | 001-my-cool-component.js | 23:29 |
| r1chardj0n3s | \o/ | 23:29 |
| r1chardj0n3s | :( | 23:29 |
| tqtran | ... didnt think about that..... | 23:29 |
| tqtran | ordering would be a huge problem | 23:29 |
| r1chardj0n3s | we could have a meta file in the component directory which specifies dependencies and solve them :) | 23:30 |
| tqtran | omg... no | 23:30 |
| r1chardj0n3s | (I have some code to do that sort of solving actually) | 23:30 |
| tqtran | we really don't need to make it more complicated | 23:30 |
| r1chardj0n3s | but we want it to be consistent so people writing extensions are doing things the same way the *core* does it | 23:30 |
| r1chardj0n3s | for *many* good reasons | 23:30 |
| *** ZZelle_ has quit IRC | 23:31 | |
| r1chardj0n3s | so the ordering has to be specified somehow by the components | 23:31 |
| r1chardj0n3s | *or* everyone edits _scripts.html | 23:31 |
| david-lyle | not the latter | 23:31 |
| r1chardj0n3s | :) | 23:31 |
| david-lyle | _scripts.html can contain a block the includes | 23:32 |
| david-lyle | that includes | 23:32 |
| david-lyle | whatever you shove in your custom _my_scripts.html file | 23:32 |
| david-lyle | but it needs to pick up multiple | 23:33 |
| david-lyle | no guarantee of there not being namespace collisions either | 23:33 |
| tqtran | so in django, if you have the same folder layout, the replacement happens automatically | 23:33 |
| *** EmilienM is now known as EmilienM|afk | 23:33 | |
| david-lyle | tqtran: yes | 23:33 |
| tqtran | is there a way to do it, but without the same folder layout? and instead have some custome layout? | 23:34 |
| *** ericpeterson has joined #openstack-horizon | 23:34 | |
| tqtran | so that in your angular module, you'll have some directory structure that gets pick up by _script.html | 23:34 |
| tqtran | via a block like you said | 23:34 |
| david-lyle | you can load whatever you want, but it won't replace the existing template | 23:34 |
| tqtran | where you can extend the origin _script.html | 23:34 |
| david-lyle | injecting files includes into, yeah | 23:35 |
| *** mgarza has joined #openstack-horizon | 23:35 | |
| david-lyle | but that has to be repeatable for pluggable extensions | 23:35 |
| david-lyle | hmm, nevermind on that last point | 23:35 |
| david-lyle | those are picked up because they are in static | 23:36 |
| *** Drago has quit IRC | 23:36 | |
| tqtran | or another way to do it is, give certain folders higher precedence | 23:37 |
| *** zul has joined #openstack-horizon | 23:37 | |
| tqtran | so if i have js libraries, and i put them into lib folder, that gets included in _script.html earlier | 23:37 |
| *** zul has quit IRC | 23:37 | |
| david-lyle | earlier than? | 23:38 |
| tqtran | earlier than the scripts that depend on those libraries | 23:38 |
| r1chardj0n3s | but there's still precedence issues in the lib though (wizard uses modal, perhaps) | 23:39 |
| david-lyle | won't you order those in you _my_scripts.html | 23:39 |
| david-lyle | ? | 23:39 |
| david-lyle | *in your | 23:39 |
| david-lyle | so many letters | 23:39 |
| tqtran | r1chardj0n3s: yeah... but angular is DI, so does ordering still matter? it isn't evaluated right away is it? | 23:40 |
| david-lyle | I have to run for the evening. I'll catch up reading the backlog. and the awesome solution you guys come with! | 23:41 |
| r1chardj0n3s | tqtran: hm, I'm still trying remember whether angular.config is invoked during script loading, or as part of the app launch | 23:41 |
| r1chardj0n3s | maybe this is all a dead herring | 23:41 |
| tqtran | david-lyle: catch you later david | 23:41 |
| r1chardj0n3s | cya david-lyle | 23:41 |
| david-lyle | I just want the files not all hardcoded in ang.modules and _scripts.html | 23:41 |
| david-lyle | later | 23:41 |
| *** david-lyle is now known as david-lyle_afk | 23:41 | |
| r1chardj0n3s | I want there to be far fewer modules in the hz namespace :/ | 23:42 |
| r1chardj0n3s | that would simplify the ang.modules malarky | 23:42 |
| *** davelowe has quit IRC | 23:43 | |
| r1chardj0n3s | tqtran: hm, yeah, so if the override actions are performed in the module run() then all modules are loaded, no problems. Looking at angboard, tjat's why I had the nav menu configuration in run() and not config() so we could guarantee the menu was loaded and ready for modification | 23:45 |
| tqtran | r1chardj0n3s: lets address one thing at a time. how do we simplify the script includes? | 23:46 |
| tqtran | r1chardj0n3s: and module includes | 23:46 |
| tqtran | and its easier to solve i think than the extension issue | 23:46 |
| r1chardj0n3s | I think it'd be a mistake to come up with a new system that simplifies that while ignoring extensions | 23:46 |
| r1chardj0n3s | so it's just something to keep in mind, is all | 23:47 |
| r1chardj0n3s | brb | 23:47 |
| *** Sukhdev has joined #openstack-horizon | 23:47 | |
| *** rm_work is now known as rm_work|away | 23:47 | |
| *** zul has joined #openstack-horizon | 23:47 | |
| tqtran | r1chardj0n3s: good point.... | 23:48 |
| *** Piet has joined #openstack-horizon | 23:50 | |
| openstackgerrit | Merged openstack/horizon: Fix import order in utils/metering.py https://review.openstack.org/150862 | 23:50 |
| *** ericpeterson has quit IRC | 23:52 | |
| *** openstack has joined #openstack-horizon | 23:57 | |
| *** Sukhdev has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!