| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Improving jshint https://review.openstack.org/153894 | 00:12 |
|---|---|---|
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Improving jshint https://review.openstack.org/153894 | 00:15 |
| *** mpavlase has quit IRC | 00:19 | |
| *** nlahouti has quit IRC | 00:21 | |
| *** nlahouti has joined #openstack-horizon | 00:34 | |
| TravT | r1chardj0n3s: yes, i think it did. | 01:16 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 01:27 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 01:27 |
| r1chardj0n3s | TravT: great, thanks! | 01:37 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Re-designed and Angularized tables https://review.openstack.org/147393 | 01:38 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Re-designed Tables https://review.openstack.org/151101 | 01:38 |
| ongk | TravT: I know you were really looking forward to setting the slide down speed… | 01:45 |
| TravT | ongk: yeah, I know it was my suggestion because previously it just seemed to pop up and down. | 01:46 |
| ongk | TravT: I’ll stop spamming everyone now with new patches :) | 01:46 |
| ongk | it’s set to 200 in the demo - might be too quick | 01:47 |
| *** amerine has joined #openstack-horizon | 01:48 | |
| *** amerine has quit IRC | 01:48 | |
| *** amerine has joined #openstack-horizon | 01:48 | |
| TravT | ongk: so, it looks like you extracted it into input options. | 01:49 |
| *** wuhg has joined #openstack-horizon | 01:49 | |
| ongk | yup with a default if not specified | 01:49 |
| TravT | yep, right in the middle at 400 | 01:50 |
| TravT | +1 | 01:51 |
| ongk | yeah. so if the slider rows are all going to be really tall, it can be adjusted in the options | 01:51 |
| TravT | actually, the 200 is pretty nice in the demo. | 01:56 |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/horizon: Also look for volumev2 endpoints https://review.openstack.org/151081 | 02:00 |
| TravT | maybe we'll figure out a way to set this as a global setting or variable | 02:00 |
| TravT | either way | 02:01 |
| TravT | still looks good | 02:01 |
| ongk | yeah, I can look into it | 02:03 |
| openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration test - Create and delete user https://review.openstack.org/143027 | 02:03 |
| TravT | well, don't feel like you have to do it right now. | 02:04 |
| TravT | have a good night! | 02:04 |
| ongk | haha, yeah | 02:04 |
| ongk | g'night | 02:04 |
| *** yoshikawa-sxb has joined #openstack-horizon | 02:08 | |
| *** yoshikawa-sxb has quit IRC | 02:08 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153836 | 02:14 |
| openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE https://review.openstack.org/147426 | 02:21 |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 02:30 | |
| *** ctina has quit IRC | 02:32 | |
| *** ryo has joined #openstack-horizon | 02:33 | |
| openstackgerrit | Jamie Lennox proposed openstack/django_openstack_auth: Changes required for kerberos login https://review.openstack.org/153910 | 02:33 |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 02:35 | |
| *** radez_g0n3 is now known as radez | 03:01 | |
| *** kenji_ has joined #openstack-horizon | 03:03 | |
| openstackgerrit | Wu Wenxiang proposed openstack/horizon: Make the values of Resource status be translatable https://review.openstack.org/153845 | 03:07 |
| *** Longgeek has joined #openstack-horizon | 03:11 | |
| *** kenji_ has quit IRC | 03:11 | |
| *** Longgeek has quit IRC | 03:14 | |
| *** ryo has quit IRC | 03:16 | |
| *** Longgeek has joined #openstack-horizon | 03:20 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Improving jshint https://review.openstack.org/153894 | 03:29 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Improving jshint https://review.openstack.org/153894 | 03:31 |
| openstackgerrit | tinytmy proposed openstack/horizon: change the network page's layout when launch instance https://review.openstack.org/151976 | 03:39 |
| *** rushiagr_away is now known as rushiagr | 03:53 | |
| *** ishant has joined #openstack-horizon | 03:57 | |
| *** coolsvap_ is now known as coolsvap | 04:02 | |
| *** lnxnut has quit IRC | 04:04 | |
| *** radez is now known as radez_g0n3 | 04:09 | |
| *** iamjarvo has joined #openstack-horizon | 04:10 | |
| *** lnxnut has joined #openstack-horizon | 04:13 | |
| *** amotoki has joined #openstack-horizon | 04:13 | |
| *** rushiagr is now known as rushiagr_away | 04:24 | |
| *** rushiagr_away is now known as rushiagr | 04:31 | |
| *** jasondotstar has joined #openstack-horizon | 04:36 | |
| *** lnxnut has quit IRC | 04:43 | |
| *** lnxnut has joined #openstack-horizon | 04:49 | |
| *** lnxnut has quit IRC | 04:53 | |
| *** coolsvap is now known as coolsvap_ | 04:55 | |
| *** coolsvap_ is now known as coolsvap | 04:56 | |
| *** sayan has joined #openstack-horizon | 05:12 | |
| *** sayan has quit IRC | 05:33 | |
| *** stevemar has quit IRC | 05:41 | |
| *** lnxnut has joined #openstack-horizon | 05:50 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 05:55 | |
| *** iamjarvo has quit IRC | 06:00 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in architecture to Jasmine https://review.openstack.org/153927 | 06:01 |
| *** nikunj2512 has joined #openstack-horizon | 06:06 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153928 | 06:09 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: made stack status value is translatable https://review.openstack.org/152092 | 06:10 |
| *** masco has joined #openstack-horizon | 06:11 | |
| *** sunilm has joined #openstack-horizon | 06:13 | |
| *** pcaruana has quit IRC | 06:28 | |
| *** lnxnut has quit IRC | 06:41 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Improving jshint https://review.openstack.org/153894 | 06:46 |
| *** josecastroleon has joined #openstack-horizon | 06:48 | |
| openstackgerrit | tinytmy proposed openstack/horizon: Fix the router details's name column is empty https://review.openstack.org/153934 | 06:54 |
| *** __gryf is now known as _gryf | 06:58 | |
| *** neillc is now known as neillc_afk | 07:00 | |
| openstackgerrit | Trung Trinh proposed openstack/horizon: Ignore Exception in process of Edit Attachments https://review.openstack.org/153460 | 07:03 |
| *** stevemar has joined #openstack-horizon | 07:35 | |
| *** chlong has quit IRC | 07:37 | |
| *** nlahouti has quit IRC | 07:38 | |
| *** Miouge has joined #openstack-horizon | 07:42 | |
| *** jprovazn has joined #openstack-horizon | 07:50 | |
| *** e0ne has joined #openstack-horizon | 07:55 | |
| *** e0ne has quit IRC | 08:03 | |
| *** Ala has joined #openstack-horizon | 08:09 | |
| *** pkarikh has joined #openstack-horizon | 08:13 | |
| *** Guest90369 has quit IRC | 08:14 | |
| *** mfisch has joined #openstack-horizon | 08:17 | |
| *** mfisch is now known as Guest22817 | 08:18 | |
| openstackgerrit | tinytmy proposed openstack/horizon: Change N/A to id in the message https://review.openstack.org/153948 | 08:19 |
| *** stevemar has quit IRC | 08:20 | |
| *** bradjones has quit IRC | 08:31 | |
| *** bradjones has joined #openstack-horizon | 08:32 | |
| *** vokhrimenko has quit IRC | 08:39 | |
| *** aix has joined #openstack-horizon | 08:40 | |
| *** jcoufal has joined #openstack-horizon | 08:40 | |
| *** markus_z has joined #openstack-horizon | 08:47 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:53 | |
| *** rdopiera has joined #openstack-horizon | 08:55 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: added filter for keypair and security and access tables https://review.openstack.org/153952 | 08:58 |
| *** aberezin has joined #openstack-horizon | 09:01 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:02 | |
| *** vokhrimenko has joined #openstack-horizon | 09:02 | |
| *** jpich has joined #openstack-horizon | 09:02 | |
| *** ygbo has joined #openstack-horizon | 09:08 | |
| *** MaxV has joined #openstack-horizon | 09:16 | |
| *** aix has quit IRC | 09:23 | |
| *** athomas has joined #openstack-horizon | 09:30 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fixes inline edit icon size/placement https://review.openstack.org/145197 | 09:51 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/153928 | 09:59 |
| *** e0ne has joined #openstack-horizon | 10:00 | |
| openstackgerrit | Merged openstack/tuskar-ui: Auto-discover missing node parameters by default https://review.openstack.org/152219 | 10:03 |
| *** e0ne has quit IRC | 10:09 | |
| *** e0ne has joined #openstack-horizon | 10:09 | |
| openstackgerrit | Wu Hong Guang proposed openstack/horizon: Integration tests - Run test on Windows with Chrome or IE https://review.openstack.org/147426 | 10:15 |
| *** akrivoka has joined #openstack-horizon | 10:15 | |
| *** e0ne is now known as e0ne_ | 10:19 | |
| *** oro has joined #openstack-horizon | 10:20 | |
| *** e0ne_ has quit IRC | 10:24 | |
| *** e0ne has joined #openstack-horizon | 10:24 | |
| openstackgerrit | Bartosz Fic proposed openstack/horizon: Migrate all instances from host marked for maintenance https://review.openstack.org/109586 | 10:31 |
| *** rdopiera has quit IRC | 10:46 | |
| *** binBASH has joined #openstack-horizon | 10:56 | |
| *** rdopiera has joined #openstack-horizon | 10:58 | |
| binBASH | Hi there. Quick question. I want to customize Horizon Dashboard. How could I add a link in the left sidebar? My goal is to have that Launch Instances button as text link at the dashboard links. | 10:59 |
| robcresswell | binBASH: http://docs.openstack.org/developer/horizon/topics/customizing.html | 11:00 |
| robcresswell | binBASH: Although, for your goals all you'd need is to put the link in the sidebar html I suppose... | 11:01 |
| binBASH | Yeah, I've read that link already. I was able to add new Dashboard + Tabs also which is already good :) | 11:02 |
| *** rm_work|away has quit IRC | 11:02 | |
| binBASH | The only thing I'm a bit stuck is how to get a link to the sidebar instead of creating completely new dashboard. | 11:02 |
| robcresswell | binBASH: I've never tried doing that. You could hunt around in the templates @ https://github.com/openstack/horizon/tree/master/horizon/templates/horizon | 11:03 |
| *** rm_work|away has joined #openstack-horizon | 11:04 | |
| binBASH | robcresswell: ok thx, will have to find the correct one then. | 11:04 |
| *** rm_work|away is now known as rm_work | 11:04 | |
| *** rm_work has joined #openstack-horizon | 11:04 | |
| robcresswell | binBASH: Sorry I don't have any good solutions off the top of my head | 11:04 |
| *** oro has quit IRC | 11:07 | |
| binBASH | robcresswell: maybe you can help me though with another problem I have. Do you know how to get logged in user name? | 11:08 |
| *** e0ne is now known as e0ne_ | 11:08 | |
| *** e0ne_ has quit IRC | 11:14 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Adds initial SRIOV creation/config support https://review.openstack.org/143139 | 11:20 |
| *** JeanBriceCombebi has quit IRC | 11:27 | |
| openstackgerrit | Andrew Pashkin proposed openstack/horizon: Adds auto fade-out for AJAX messages https://review.openstack.org/152635 | 11:42 |
| *** josecastroleon has quit IRC | 11:49 | |
| *** e0ne has joined #openstack-horizon | 11:51 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Cache the role/image and role/resource mappings https://review.openstack.org/154002 | 11:52 |
| *** binBASH has left #openstack-horizon | 11:54 | |
| *** jamielennox is now known as jamielennox|away | 11:56 | |
| *** e0ne is now known as e0ne_ | 11:58 | |
| *** e0ne_ is now known as e0ne | 11:59 | |
| *** Miouge has quit IRC | 11:59 | |
| pkarikh | robcresswell: finally I've got a time to review your mammoth patch. :) And now I'm not sure if you have to split it into several patches. It looks consistent despite the fact that it's huge. | 11:59 |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Resource.get_by_node is already cached https://review.openstack.org/154006 | 12:01 |
| *** Miouge has joined #openstack-horizon | 12:02 | |
| *** josecastroleon has joined #openstack-horizon | 12:06 | |
| *** Longgeek has quit IRC | 12:12 | |
| *** chlong has joined #openstack-horizon | 12:25 | |
| *** aberezin has quit IRC | 12:27 | |
| *** aix has joined #openstack-horizon | 12:29 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Resource.get_by_node is already cached https://review.openstack.org/154006 | 12:30 |
| *** rushiagr is now known as rushiagr_away | 12:35 | |
| *** chlong has quit IRC | 12:35 | |
| *** chlong has joined #openstack-horizon | 12:36 | |
| *** raildo has joined #openstack-horizon | 12:36 | |
| *** sunilm has quit IRC | 12:39 | |
| *** oro has joined #openstack-horizon | 12:47 | |
| *** lnxnut has joined #openstack-horizon | 12:53 | |
| *** lnxnut has quit IRC | 12:58 | |
| *** e0ne is now known as e0ne_ | 12:59 | |
| *** lblanchard has joined #openstack-horizon | 13:00 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:04 | |
| *** rdopiera has quit IRC | 13:06 | |
| *** e0ne_ is now known as e0ne | 13:06 | |
| robcresswell | pkarikh: Haha, I did shrink it too in the latest patchset. Ripped out data_processing for later. | 13:08 |
| robcresswell | pkarikh: Thanks for the comments, I'll look into them | 13:08 |
| *** tzumainn has joined #openstack-horizon | 13:08 | |
| *** masco has quit IRC | 13:10 | |
| *** krykowski has joined #openstack-horizon | 13:12 | |
| *** rushiagr_away is now known as rushiagr | 13:16 | |
| *** tzumainn has quit IRC | 13:16 | |
| *** tzumainn has joined #openstack-horizon | 13:16 | |
| *** ctina has joined #openstack-horizon | 13:22 | |
| *** Miouge has quit IRC | 13:23 | |
| *** masco has joined #openstack-horizon | 13:24 | |
| pkarikh | robcresswell: hm, ok, I'll take a look. :) | 13:28 |
| pkarikh | robcresswell: also, no problem. :) | 13:28 |
| *** e0ne is now known as e0ne_ | 13:30 | |
| *** htruta has joined #openstack-horizon | 13:31 | |
| robcresswell | pkarikh: You already reviewed the reduced one. It went from something like +600/-1100 to +300/-700 | 13:33 |
| robcresswell | pkarikh: Hopefully it is straightforward enough for others to review too. | 13:34 |
| pkarikh | robcresswell: so, now we know the true reason why today this patch doesn't look so huge to me as he was on friday. :) | 13:35 |
| *** chlong has quit IRC | 13:36 | |
| *** e0ne_ is now known as e0ne | 13:38 | |
| robcresswell | pkarikh: haha, yes indeed | 13:38 |
| *** jprovazn has quit IRC | 13:39 | |
| pkarikh | Does anybody know which policy rule matches with `api.nova.hypervisor_list` call? | 13:40 |
| openstackgerrit | tinytmy proposed openstack/horizon: Fix the router details's name column is empty https://review.openstack.org/153934 | 13:40 |
| *** rushiagr is now known as rushiagr_away | 13:41 | |
| *** Longgeek has joined #openstack-horizon | 13:44 | |
| *** Drago has joined #openstack-horizon | 13:44 | |
| *** ishant has quit IRC | 13:44 | |
| *** aix has quit IRC | 13:47 | |
| *** Drago has quit IRC | 13:48 | |
| *** Drago has joined #openstack-horizon | 13:48 | |
| *** Miouge has joined #openstack-horizon | 13:50 | |
| *** oro_ has joined #openstack-horizon | 13:51 | |
| openstackgerrit | tinytmy proposed openstack/horizon: Add help text for vcpu hours https://review.openstack.org/152794 | 13:55 |
| *** Longgeek has quit IRC | 13:57 | |
| *** masco has quit IRC | 13:59 | |
| *** ctina has joined #openstack-horizon | 14:00 | |
| *** Longgeek has joined #openstack-horizon | 14:00 | |
| *** _crobertsrh is now known as crobertsrh | 14:00 | |
| *** sayan has joined #openstack-horizon | 14:00 | |
| pkarikh | Looks like "compute_extension:hypervisors": "rule:admin_api" is what I need. Another question is how should I use it. Is ('compute', 'compute_extension:hypervisors') the right way? | 14:01 |
| david-lyle_afk | pkarikh: did you see my ceilometer policy patch? | 14:01 |
| openstackgerrit | tinytmy proposed openstack/horizon: Fix the router details's name column is empty https://review.openstack.org/153934 | 14:01 |
| *** david-lyle_afk is now known as david-lyle | 14:01 | |
| pkarikh | david-lyle_afk: not yet | 14:01 |
| david-lyle | and yes, for the compute rule synta | 14:02 |
| david-lyle | x | 14:02 |
| david-lyle | the first field is which service, the second is the particular rule | 14:02 |
| *** jcoufal has quit IRC | 14:02 | |
| david-lyle | only way to map rules to services | 14:02 |
| david-lyle | although, it's a list of tuples | 14:02 |
| *** jcoufal has joined #openstack-horizon | 14:02 | |
| david-lyle | so (("compute", "compute_extenson:hypervisors"),) | 14:03 |
| *** krykowski has quit IRC | 14:03 | |
| david-lyle | pkarikh: https://review.openstack.org/#/c/153738/ | 14:04 |
| david-lyle | as an example in the panel.py | 14:04 |
| *** e0ne has quit IRC | 14:05 | |
| openstackgerrit | tinytmy proposed openstack/horizon: unite the property of usage test https://review.openstack.org/152381 | 14:05 |
| openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Data_processing] fix job_executions table https://review.openstack.org/125927 | 14:05 |
| openstackgerrit | tinytmy proposed openstack/horizon: fix usage property(vcpus, vcpu_hours) error use https://review.openstack.org/152376 | 14:05 |
| *** e0ne has joined #openstack-horizon | 14:05 | |
| pkarikh | david-lyle: yep, I see now. So, now I can use it my patch. Cool! | 14:06 |
| *** amotoki has quit IRC | 14:09 | |
| *** aberezin has joined #openstack-horizon | 14:14 | |
| *** rbertram_afk has joined #openstack-horizon | 14:16 | |
| *** rbertram_afk is now known as rbertram | 14:16 | |
| *** lnxnut has joined #openstack-horizon | 14:17 | |
| *** krykowski has joined #openstack-horizon | 14:17 | |
| *** cbader has joined #openstack-horizon | 14:19 | |
| *** lnxnut has quit IRC | 14:21 | |
| *** jprovazn has joined #openstack-horizon | 14:23 | |
| *** e0ne is now known as e0ne_ | 14:23 | |
| *** Longgeek has quit IRC | 14:23 | |
| *** TravT_ has joined #openstack-horizon | 14:25 | |
| *** ctina has quit IRC | 14:26 | |
| *** TravT has quit IRC | 14:28 | |
| *** wuhg has quit IRC | 14:29 | |
| *** rushiagr_away is now known as rushiagr | 14:29 | |
| pkarikh | david-lyle: oh, sorry. If you've already implemented RBAC-check for metering panel in https://review.openstack.org/#/c/153738/1/openstack_dashboard/dashboards/admin/metering/panel.py, I shouldn't do it again in my patch, should I? | 14:30 |
| *** iamjarvo has joined #openstack-horizon | 14:30 | |
| david-lyle | pkarikh: that would be unnecessary :) | 14:31 |
| david-lyle | I also thought it would be more illustrative of what I meant for the panel.py files to look like | 14:32 |
| david-lyle | the ceilometer one is odd in that the default policy file in ceilometer is overly simple | 14:32 |
| david-lyle | not sure why | 14:32 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode https://review.openstack.org/123741 | 14:33 |
| david-lyle | all the rules you base your panel.py policy checks on should be in the appropriate policy files | 14:33 |
| *** jcoufal has quit IRC | 14:34 | |
| *** jcoufal has joined #openstack-horizon | 14:34 | |
| *** JeanBriceCombebi has quit IRC | 14:36 | |
| *** doug-fish has joined #openstack-horizon | 14:38 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:38 | |
| *** woodm1979 has joined #openstack-horizon | 14:39 | |
| *** ctina has joined #openstack-horizon | 14:39 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Remove admin role name 'admin' hardcode https://review.openstack.org/123741 | 14:42 |
| pkarikh | david-lyle: it seems that now I'm starting to underestand this approach. :) | 14:43 |
| *** e0ne_ is now known as e0ne | 14:49 | |
| *** mpavlase has joined #openstack-horizon | 14:54 | |
| *** jpomero has joined #openstack-horizon | 14:55 | |
| *** JeanBriceCombebi has quit IRC | 14:55 | |
| *** aix has joined #openstack-horizon | 14:56 | |
| *** radez_g0n3 is now known as radez | 14:58 | |
| *** lnxnut has joined #openstack-horizon | 14:58 | |
| *** jtriley has joined #openstack-horizon | 15:00 | |
| *** lnxnut_ has joined #openstack-horizon | 15:01 | |
| *** lnxnut has quit IRC | 15:02 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:02 | |
| *** absubram has joined #openstack-horizon | 15:06 | |
| *** stevemar has joined #openstack-horizon | 15:08 | |
| pkarikh | david-lyle: sorry for bother, but could you please take a look at the new patchset? If you have some time, of course. https://review.openstack.org/#/c/123741/ I've made the changes you've suggested about policy rules.. | 15:08 |
| *** amotoki has joined #openstack-horizon | 15:10 | |
| *** neelashah has joined #openstack-horizon | 15:10 | |
| *** vijendar has joined #openstack-horizon | 15:24 | |
| *** Longgeek has joined #openstack-horizon | 15:24 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Parallel testing https://review.openstack.org/154078 | 15:24 |
| *** jtriley has quit IRC | 15:25 | |
| *** KanagarajM has joined #openstack-horizon | 15:26 | |
| *** jcoufal_ has joined #openstack-horizon | 15:26 | |
| *** jtriley has joined #openstack-horizon | 15:28 | |
| *** peristeri has joined #openstack-horizon | 15:28 | |
| *** jcoufal has quit IRC | 15:29 | |
| *** oro_ has quit IRC | 15:31 | |
| *** medberry is now known as med_ | 15:34 | |
| *** jtriley has quit IRC | 15:42 | |
| *** jcoufal_ has quit IRC | 15:43 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generate a drop down field for custom heat parameters https://review.openstack.org/133270 | 15:43 |
| *** jcoufal has joined #openstack-horizon | 15:44 | |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 15:44 |
| *** jtriley has joined #openstack-horizon | 15:44 | |
| *** sayan has quit IRC | 15:49 | |
| *** Longgeek has quit IRC | 15:50 | |
| *** JeanBriceCombebi has quit IRC | 15:53 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:53 | |
| *** Guest22817 is now known as mfisch | 15:56 | |
| *** mfisch has joined #openstack-horizon | 15:56 | |
| nikunj2512 | david-lyle: Hi, please take a look at these patches as per your convenince. they already have one +2. https://review.openstack.org/#/c/135256/ and https://review.openstack.org/#/c/153520/ | 15:56 |
| *** aix has quit IRC | 16:00 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 16:09 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Adds initial SRIOV creation/config support https://review.openstack.org/143139 | 16:13 |
| *** coolsvap is now known as coolsvap_ | 16:15 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: Serial Console https://review.openstack.org/144659 | 16:16 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 16:17 |
| *** mpavlase has quit IRC | 16:19 | |
| woodm1979 | Has anyone ran into this type of test error: | 16:19 |
| woodm1979 | UnexpectedMethodCallError: Unexpected method call. unexpected:- expected:+ | 16:19 |
| woodm1979 | - tenant_list.__call__(<class 'django.http.HttpRequest'>, domain=<openstack_auth.user.Token object at 0x10b56ee50>, marker=None, paginate=True) -> None | 16:19 |
| woodm1979 | + tenant_list.__call__(<class 'django.http.request.HttpRequest'>, domain='1', marker=None, paginate=True) -> [[<Tenant {'description': 'a test tenant.', 'enabled': True, 'domain_name': 'test_domain', 'id': '1', 'domain_id': '1', 'name': 'test_tenant'}>], False] | 16:19 |
| woodm1979 | Those two objects are exactly the same. | 16:20 |
| woodm1979 | oh wait | 16:20 |
| woodm1979 | ignore me. | 16:20 |
| nikunj2512 | woodm1979: ok :) | 16:20 |
| woodm1979 | Continue to ignore me. :-) | 16:20 |
| nikunj2512 | woodm1979: ok.. We will :) | 16:21 |
| *** krykowski has quit IRC | 16:26 | |
| *** aix has joined #openstack-horizon | 16:29 | |
| *** gyee has joined #openstack-horizon | 16:33 | |
| *** vokhrimenko has quit IRC | 16:33 | |
| *** ayoung has joined #openstack-horizon | 16:33 | |
| openstackgerrit | Merged openstack/horizon: made stack status value is translatable https://review.openstack.org/152092 | 16:36 |
| *** nlahouti has joined #openstack-horizon | 16:37 | |
| *** rwsu has joined #openstack-horizon | 16:44 | |
| *** oro has quit IRC | 16:45 | |
| *** Longgeek has joined #openstack-horizon | 16:47 | |
| pkarikh | lcheng lhcheng: Hello! Do I understang you correctly that you suggest to close this bug as invalid (in comments)? https://bugs.launchpad.net/horizon/+bug/1403815 since this bug has been merged? https://bugs.launchpad.net/horizon/+bug/1400872 | 16:48 |
| openstack | Launchpad bug 1403815 in OpenStack Dashboard (Horizon) "User can access password other user through login form password autocomplete" [Undecided,In progress] - Assigned to Paul Karikh (pkarikh) | 16:48 |
| openstack | Launchpad bug 1400872 in OpenStack Dashboard (Horizon) "Show password feature should be configurable" [High,Fix released] - Assigned to Cindy Lu (clu-m) | 16:48 |
| *** rebelagentm has joined #openstack-horizon | 16:56 | |
| *** Ephur has joined #openstack-horizon | 16:58 | |
| *** tqtran has joined #openstack-horizon | 17:00 | |
| *** dsneddon has quit IRC | 17:02 | |
| *** coolsvap_ is now known as coolsvap | 17:02 | |
| *** amotoki has quit IRC | 17:03 | |
| *** MaxV has quit IRC | 17:03 | |
| *** nikunj2512 has quit IRC | 17:03 | |
| *** Ephur has quit IRC | 17:04 | |
| *** woodm1979 has quit IRC | 17:05 | |
| *** woodm1979 has joined #openstack-horizon | 17:05 | |
| *** woodm19791 has joined #openstack-horizon | 17:06 | |
| *** woodm1979 has quit IRC | 17:06 | |
| *** krykowski has joined #openstack-horizon | 17:06 | |
| woodm19791 | Are domain names (in Keystone v3) guaranteed to be unique? | 17:09 |
| stevemar | woodm19791, nope, just IDs | 17:09 |
| woodm19791 | I thought not. | 17:09 |
| woodm19791 | Thanks. | 17:09 |
| *** Longgeek has quit IRC | 17:10 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Join node registration and upload forms https://review.openstack.org/153650 | 17:10 |
| *** rwsu has quit IRC | 17:10 | |
| stevemar | woodm19791, actually... i take that back | 17:10 |
| *** woodm1979 has joined #openstack-horizon | 17:11 | |
| *** rwsu has joined #openstack-horizon | 17:11 | |
| *** woodm1979 has quit IRC | 17:11 | |
| *** woodm1979 has joined #openstack-horizon | 17:11 | |
| *** ttrifonov is now known as zz_ttrifonov | 17:12 | |
| *** woodm19791 has quit IRC | 17:12 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Join node registration and upload forms https://review.openstack.org/153650 | 17:14 |
| *** EmilienM is now known as EmilienM|afk | 17:15 | |
| *** alexvictorchan has joined #openstack-horizon | 17:15 | |
| *** alexvictorchan has quit IRC | 17:15 | |
| *** alexvictorchan has joined #openstack-horizon | 17:16 | |
| stevemar | woodm1979, for now... we don't allow duplicate names | 17:16 |
| stevemar | woodm1979, i suspect that is incorrect, but let me double check | 17:17 |
| woodm1979 | I'm confused. :-) | 17:17 |
| *** jpich has quit IRC | 17:19 | |
| woodm1979 | stevemar: What I'm really looking for is a good way to identify what the default domain is for Keystone v3. Does it have a consistent ID? Or Name that can be tied to an ID or …? | 17:20 |
| *** ygbo has quit IRC | 17:21 | |
| david-lyle | woodm1979: only in the policy file | 17:21 |
| david-lyle | haha | 17:21 |
| woodm1979 | hrmmm. | 17:21 |
| david-lyle | which is straight up nuts | 17:21 |
| david-lyle | but I'll let stevemar answer | 17:21 |
| woodm1979 | that seems … not good. (Or nuts as you say.) | 17:21 |
| david-lyle | straight up nuts | 17:22 |
| david-lyle | that's the 11 of nuts | 17:22 |
| robcresswell | haha | 17:22 |
| *** amerine has quit IRC | 17:22 | |
| KanagarajM | david-lyle: Hi, For the https://review.openstack.org/#/c/141759/. nova api does uses hostname as searching key for servers. | 17:22 |
| KanagarajM | david-lyle: and i updated the comments for the same. could you look at it. | 17:23 |
| woodm1979 | david-lyle: We define what the default domain is inside a policy file? I thought it was just a list of potential roles/permissions. | 17:23 |
| woodm1979 | What am I missing? (Don't say "alot" even though it's true.) :-) | 17:24 |
| david-lyle | woodm1979: for horizon to discover | 17:24 |
| openstackgerrit | Brian Fischer proposed openstack/horizon: Update to horizon tutorial.rst https://review.openstack.org/145870 | 17:25 |
| david-lyle | I don't believe there is a programmatic way to determine default | 17:25 |
| david-lyle | so then we have to hard code it | 17:25 |
| david-lyle | bootstrapping of a domain id doesn't exist upstream | 17:25 |
| woodm1979 | That would suggest that there's no good way to solve "Determining if you're in the default domain." (I'm taking over Dan's review.) | 17:26 |
| woodm1979 | Here: https://review.openstack.org/#/c/148082/1..13/openstack_dashboard/dashboards/identity/projects/views.py Brad wants us to compare our domain_id with the default domain name. That seems … bad. | 17:27 |
| *** athomas has quit IRC | 17:27 | |
| *** zigo has quit IRC | 17:29 | |
| *** JeanBriceCombebi has quit IRC | 17:31 | |
| *** smc7 has joined #openstack-horizon | 17:32 | |
| *** woodm1979 has quit IRC | 17:33 | |
| *** woodm19791 has joined #openstack-horizon | 17:33 | |
| *** KanagarajM has quit IRC | 17:33 | |
| robcresswell | Do we have a widget available for entering dicts? | 17:35 |
| *** lhcheng has joined #openstack-horizon | 17:37 | |
| *** alexvictorchan has quit IRC | 17:38 | |
| *** amerine has joined #openstack-horizon | 17:39 | |
| *** alexvictorchan1 has joined #openstack-horizon | 17:40 | |
| *** akrivoka has quit IRC | 17:42 | |
| *** alexvictorchan1 has left #openstack-horizon | 17:42 | |
| *** alexvictorchan has joined #openstack-horizon | 17:43 | |
| *** nikunj2512_ has joined #openstack-horizon | 17:45 | |
| *** nikunj2512 has joined #openstack-horizon | 17:51 | |
| *** aberezin has quit IRC | 17:55 | |
| david-lyle | robcresswell: not that I recall | 17:55 |
| david-lyle | for heat, you can put in a big text blob that should be json | 17:56 |
| david-lyle | but we should not replicate that much | 17:56 |
| *** jcoufal has quit IRC | 17:57 | |
| david-lyle | there's also the metadata widget, but that's more for new entries in a dict | 17:57 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Pie and donut chart directive https://review.openstack.org/146934 | 18:01 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Demo for Pie/Donut Chart Directive https://review.openstack.org/154160 | 18:01 |
| robcresswell | david-lyle: Yeah just finishing off my bp, which has been sitting a while. Has options for dict entry... Trying to figure out a sane way of tackling it. | 18:02 |
| robcresswell | david-lyle: Thanks for the other examples | 18:02 |
| *** harlowja has joined #openstack-horizon | 18:04 | |
| *** krykowski has quit IRC | 18:06 | |
| *** e0ne has quit IRC | 18:09 | |
| *** nikunj2512 has quit IRC | 18:13 | |
| *** nikunj2512_ has quit IRC | 18:13 | |
| sambetts | tqtran: /exit | 18:13 |
| sambetts | sigh... well done irc client haha | 18:14 |
| sambetts | night all | 18:14 |
| tqtran | gnite sam! ;D | 18:14 |
| *** aix has quit IRC | 18:15 | |
| *** rushiagr is now known as rushiagr_away | 18:18 | |
| robcresswell | sambetts: haha, derp :p Night Sam | 18:19 |
| *** markus_z has quit IRC | 18:33 | |
| tqtran | ongk: is there a way to contact sean? seems like his wizard and help panel code is failing jasmine test | 18:38 |
| tqtran | ongk: one of the issue is due to gettext, we need to include django translation in jasmine template | 18:39 |
| ongk | tqtran: yeah, I was gonna ask him about that | 18:39 |
| ongk | tqtran: I’ll ping him | 18:39 |
| tqtran | ongk: so until that gets resolve, i cant push yours through | 18:39 |
| tqtran | or mine for that matter :P | 18:40 |
| *** iamjarvo has quit IRC | 18:40 | |
| *** fischerw has joined #openstack-horizon | 18:41 | |
| *** TravT_ has quit IRC | 18:45 | |
| *** coolsvap is now known as coolsvap_ | 18:45 | |
| *** coolsvap_ is now known as coolsvap | 18:46 | |
| *** sqchen has joined #openstack-horizon | 18:47 | |
| *** coolsvap is now known as coolsvap_ | 18:47 | |
| *** ybathia has joined #openstack-horizon | 18:48 | |
| *** devlaps has joined #openstack-horizon | 18:48 | |
| *** jprovazn has quit IRC | 18:54 | |
| *** Longgeek has joined #openstack-horizon | 18:55 | |
| ongk | tqtran: haha, let’s get that resolved then :) looks like Sean’s here now | 18:57 |
| tqtran | sqchen: hey sean, if you hit the jasmine test page, you'll see that there are 14 failsures | 18:58 |
| tqtran | sqchen: all of them from the wizard spec | 18:58 |
| tqtran | some of them can be easily fixed, while some are harder (the gettext example) | 18:59 |
| tqtran | i think we need to embed the django translation in our jasmine test page | 18:59 |
| tqtran | in order for that to work properly | 18:59 |
| sqchen | That are caused by missing gettext() globally defined. I have a code review there for improve Jasmine, the fix will be included. | 19:00 |
| tqtran | im looking at the patch right now | 19:00 |
| *** cbader has quit IRC | 19:01 | |
| sqchen | We can define a place holder function gettext(text) { retuen text; }, and defined the real loic later. | 19:01 |
| sqchen | Thanks. | 19:01 |
| tqtran | um... hold on there buddy lol | 19:02 |
| *** smc7 has quit IRC | 19:03 | |
| *** dsneddon has joined #openstack-horizon | 19:03 | |
| *** zigo has joined #openstack-horizon | 19:03 | |
| *** iamjarvo has joined #openstack-horizon | 19:04 | |
| tqtran | thats fine, i'll look into it a bit more on my end we can carry the convo onto the patch | 19:04 |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: WIP REST API to support create instance angular (Neutron) https://review.openstack.org/151313 | 19:04 |
| *** devlaps has quit IRC | 19:06 | |
| *** woodm19791 has quit IRC | 19:06 | |
| *** woodm1979 has joined #openstack-horizon | 19:09 | |
| *** woodm19791 has joined #openstack-horizon | 19:10 | |
| *** woodm1979 has quit IRC | 19:10 | |
| *** Longgeek has quit IRC | 19:11 | |
| *** EmilienM|afk is now known as EmilienM | 19:12 | |
| openstackgerrit | Randy Bertram proposed openstack/horizon: WIP Magic Search in Angular User https://review.openstack.org/151386 | 19:18 |
| openstackgerrit | Brian Fischer proposed openstack/horizon: Update to horizon tutorial.rst https://review.openstack.org/145870 | 19:19 |
| *** gokrokve has joined #openstack-horizon | 19:25 | |
| *** e0ne has joined #openstack-horizon | 19:30 | |
| *** clu_ has joined #openstack-horizon | 19:34 | |
| *** ZZelle has joined #openstack-horizon | 19:34 | |
| *** stevemar has quit IRC | 19:37 | |
| tqtran | sqchen: ping | 19:37 |
| *** stevemar has joined #openstack-horizon | 19:38 | |
| sqchen | Hi tqtran | 19:38 |
| tqtran | sqchen: i would prefer to see the gettext issue get address in a dfferent patch | 19:38 |
| sqchen | sure. | 19:38 |
| tqtran | sqchen: instead of bundling it together with the config stuff | 19:38 |
| sqchen | I’ll create one now. | 19:38 |
| tqtran | sqchen: awesome, i also left a comment there, so please take a look | 19:39 |
| sqchen | ok, thanks. | 19:39 |
| *** openstackgerrit has quit IRC | 19:41 | |
| *** openstackgerrit has joined #openstack-horizon | 19:41 | |
| *** smc7 has joined #openstack-horizon | 19:46 | |
| *** woodm19791 has quit IRC | 19:48 | |
| *** woodm1979 has joined #openstack-horizon | 19:48 | |
| *** neelashah has quit IRC | 19:51 | |
| woodm1979 | If I'm putting a patch up over the top of someone else's patch (coworker, we're cool) do I need to do anything other than keep the change-id and add Co-Authored-By tags? | 19:58 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 19:58 |
| openstackgerrit | Matthew D. Wood proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 19:59 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Adds initial SRIOV creation/config support https://review.openstack.org/143139 | 20:01 |
| *** gyee has quit IRC | 20:07 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Adds initial SRIOV creation/config support https://review.openstack.org/143139 | 20:09 |
| *** woodm19791 has joined #openstack-horizon | 20:13 | |
| *** woodm1979 has quit IRC | 20:13 | |
| *** woodm19791 has quit IRC | 20:13 | |
| *** woodm1979 has joined #openstack-horizon | 20:13 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:13 | |
| r1chardj0n3s | morning | 20:14 |
| woodm1979 | God I hope it's not still morning here. :-) | 20:14 |
| r1chardj0n3s | ;) | 20:14 |
| robcresswell | Ha, I was just heading off... 8.15pm. Yay for international projects! | 20:15 |
| robcresswell | Am I correct in thinking most of the core REST APIs are now being worked on? Glance, Nova, Neutron... | 20:16 |
| *** zz_ttrifonov is now known as ttrifonov | 20:16 | |
| tqtran | robcresswell: yes Rob, with room for improvements. their aim right now isnt comprehensive coverage, more focus on getting the launch instance up and running | 20:17 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Defining gettext function place holder https://review.openstack.org/154223 | 20:17 |
| robcresswell | tqtran: Mm, and building up from there. H'okay. | 20:17 |
| *** mpavlase has joined #openstack-horizon | 20:18 | |
| tqtran | sqchen: sean, please read my comment https://review.openstack.org/#/c/153927/1/horizon/templates/horizon/jasmine/jasmine.html | 20:19 |
| robcresswell | o/ Night all | 20:19 |
| tqtran | robcresswell: nite rob | 20:20 |
| *** robcresswell is now known as robcresswell_afk | 20:20 | |
| *** Miouge has quit IRC | 20:22 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Enable jsi18n in Jasmine spec runner. https://review.openstack.org/154223 | 20:26 |
| r1chardj0n3s | oh, cya robcresswell_afk ;) | 20:38 |
| r1chardj0n3s | how's it going tqtran? | 20:38 |
| *** kmartin has quit IRC | 20:38 | |
| tqtran | r1chardj0n3s: its going =) trying to clean up some jasmine stuff with sean | 20:39 |
| tqtran | r1chardj0n3s: and get the angular modal thing to go in | 20:39 |
| r1chardj0n3s | switching to karma to run the tests? | 20:39 |
| * r1chardj0n3s crosses fingers | 20:39 | |
| tqtran | r1chardj0n3s: not sure if you're aware, but apparently, angular-bootstrap and bootrap.js conflicts | 20:39 |
| tqtran | r1chardj0n3s: lol dream on | 20:39 |
| *** Ephur has joined #openstack-horizon | 20:39 | |
| tqtran | r1chardj0n3s: https://github.com/angular-ui/bootstrap/issues/2156 if you're interested | 20:40 |
| r1chardj0n3s | huh, conflict eg | 20:40 |
| r1chardj0n3s | eh | 20:40 |
| tqtran | r1chardj0n3s: anyway, not a big deal, theres a workaround, but it caused me great pains. I couldnt figure out why it was failiing integration tests. | 20:41 |
| tqtran | r1chardj0n3s: that and gettext not included in jasmine also caused many new angular widgets to fail because its referencing something we did not include | 20:41 |
| r1chardj0n3s | interesting, I've never seen the conflict before | 20:41 |
| r1chardj0n3s | but I've used both | 20:41 |
| *** bpokorny has joined #openstack-horizon | 20:41 | |
| r1chardj0n3s | ah, right | 20:41 |
| tqtran | r1chardj0n3s: theres probably a few more we are bound to discover along the way | 20:41 |
| r1chardj0n3s | yeah | 20:42 |
| r1chardj0n3s | the configuration of jasmine in our codebase is a bad thing :( | 20:42 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Enable jsi18n in Jasmine spec runner. https://review.openstack.org/154223 | 20:42 |
| tqtran | sqchen: i dont have a bug for it sean, should create one | 20:43 |
| sqchen | Done | 20:43 |
| *** btully has joined #openstack-horizon | 20:44 | |
| tqtran | ok i'm off to lunch, bbl | 20:44 |
| *** tqtran is now known as tqtran_afk | 20:44 | |
| *** radez is now known as radez_g0n3 | 20:46 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:49 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Move out loading horizon modals to a named function https://review.openstack.org/154230 | 20:49 |
| *** kmartin has joined #openstack-horizon | 20:50 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 20:53 |
| *** Longgeek has joined #openstack-horizon | 20:56 | |
| *** neelashah has joined #openstack-horizon | 20:59 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in architecture to Jasmine https://review.openstack.org/153927 | 21:00 |
| samueldmq | greetings horizon community : ) | 21:06 |
| samueldmq | I've drafted the Hierarchical Projects and Inherited Role Assignments blueprint on horizon | 21:06 |
| samueldmq | please see it at https://blueprints.launchpad.net/horizon/+spec/hierarchical-projects-and-inherited-assignments | 21:06 |
| *** dsneddon is now known as dsneddon_lunch | 21:06 | |
| samueldmq | david-lyle ^ | 21:06 |
| *** Longgeek has quit IRC | 21:10 | |
| *** sqchen has quit IRC | 21:12 | |
| *** gyee has joined #openstack-horizon | 21:14 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 21:15 |
| *** iamjarvo has quit IRC | 21:15 | |
| *** dsneddon_lunch has quit IRC | 21:18 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 21:19 |
| *** neillc_afk is now known as neillc | 21:20 | |
| *** tqtran_afk is now known as tqtran | 21:22 | |
| *** sqchen has joined #openstack-horizon | 21:24 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Angular Modal https://review.openstack.org/140932 | 21:27 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Guided job execution page for Sahara https://review.openstack.org/147918 | 21:27 |
| *** scsnow has joined #openstack-horizon | 21:28 | |
| scsnow | hi, when multidomains are configured is it possible to select domain from a dropdown list on login page instead of typing in the text box? | 21:29 |
| *** jtriley has quit IRC | 21:37 | |
| *** neelashah has quit IRC | 21:38 | |
| lhcheng | scsnow: not possible at the moment, to support that horizon need to be able to get the list of domains from keystone (which requires a token). It would also introduce a security issue since other users will see what are the other domains. | 21:47 |
| scsnow | lhcheng: I think it can be impelemented like AVAILABLE_REGIONS, I mean there is no need to query keystone for domains. | 21:53 |
| david-lyle | scsnow: the number of domains is not fixed | 22:00 |
| david-lyle | a new domain could be added at any time by a cloud operator | 22:00 |
| david-lyle | or other means, depending on how your cloud is managed | 22:01 |
| *** ctina has quit IRC | 22:01 | |
| tqtran | ongk: your demo patch for the hypervisors isnt working, is there any extra steps im suppose to take? | 22:01 |
| tqtran | https://review.openstack.org/#/c/154160/ | 22:01 |
| david-lyle | tqtran: worked for me earlier today | 22:02 |
| r1chardj0n3s | tqtran: are you aware of why the "angular" tables are using jquery selectors in the implementation?? | 22:02 |
| tqtran | r1chardj0n3s: omg here we go lol | 22:02 |
| r1chardj0n3s | ... well ... | 22:02 |
| tqtran | r1chardj0n3s: i know theres jqlite | 22:02 |
| r1chardj0n3s | which is effectively jquery in this discussion. I'm wondering why any jquery *or* jqlite in this code | 22:03 |
| tqtran | r1chardj0n3s: angular tables? which patch? | 22:03 |
| r1chardj0n3s | https://review.openstack.org/#/c/147393/ | 22:03 |
| tqtran | r1chardj0n3s: so are you arguing for why we should use it? or why we shouldn't use it? | 22:04 |
| r1chardj0n3s | I've +1'ed it because I saw something about IE9 being the reason, just wondering what the specifics of that were | 22:04 |
| r1chardj0n3s | tqtran: we shouldn't be mixing in old jquery spaghetti into angular directives | 22:04 |
| r1chardj0n3s | (any angular code, really) | 22:04 |
| woodm1979 | r1chardj0n3s: Whose patch is that? Kelly? Sean? Matt Borland? | 22:05 |
| r1chardj0n3s | woodm1979: Kelly's | 22:05 |
| woodm1979 | I'll ask. Or get her in here. :-) | 22:05 |
| r1chardj0n3s | (Kelly not being here on IRC, AFAICT) | 22:05 |
| *** oro has joined #openstack-horizon | 22:05 | |
| david-lyle | ongk: ping | 22:05 |
| david-lyle | ^^^^ | 22:05 |
| david-lyle | reverse order of those two | 22:06 |
| tqtran | r1chardj0n3s: oh, even better. looks like angular already has element.querySelector | 22:06 |
| r1chardj0n3s | oh! Kelly is ongk | 22:06 |
| david-lyle | completely obvious, no? | 22:06 |
| *** mwhagedorn has joined #openstack-horizon | 22:06 | |
| r1chardj0n3s | david-lyle: :) | 22:06 |
| ongk | hello. I’m getting pinged from everywhere | 22:06 |
| r1chardj0n3s | tqtran: angular is built on jqlite, I get that, but a more structured approach wouldn't use selectors and stuff | 22:06 |
| david-lyle | ongk: questions have been raised, your expertise is required | 22:07 |
| r1chardj0n3s | ohai ongk ;) I was just looking at https://review.openstack.org/#/c/147393/ and wondering what the IE9 thing was that meant you had to use jquery instead of angular in the animation | 22:07 |
| tqtran | r1chardj0n3s: are you referring to the specs or the actual table code itself? | 22:07 |
| r1chardj0n3s | tqtran: the table code | 22:08 |
| r1chardj0n3s | the hzExpandDetail directive | 22:08 |
| tqtran | looks like angular 1.3 supports IE9+ | 22:09 |
| ongk | r1chardj0n3s: had to use jQuery for the slide down animation | 22:09 |
| tqtran | ongk: is it possible to use $animate? | 22:09 |
| ongk | IE9 doesn’t support CSS transitions/animations | 22:09 |
| tqtran | oh right..... | 22:09 |
| ongk | The issue is because it’s a table cell | 22:09 |
| r1chardj0n3s | agh, right | 22:09 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Guided cluster creation mode for Sahara https://review.openstack.org/147677 | 22:09 |
| r1chardj0n3s | bloody IE9 | 22:09 |
| tqtran | so $animate wouldnt work too well...... | 22:09 |
| r1chardj0n3s | :/ | 22:09 |
| ongk | And table cells, you can’t animate the height | 22:09 |
| r1chardj0n3s | right, thanks ongk! | 22:09 |
| ongk | r1chardj0n3s: np | 22:09 |
| ongk | I tried to be tricky and use line-height and that was not very smooth | 22:10 |
| r1chardj0n3s | I just don't like seeing the purity of my angular code sullied like that ;) | 22:10 |
| tqtran | lol richard was about to cause a storm, good answer kelly | 22:10 |
| ongk | r1chardj0n3s: I’m with you there | 22:10 |
| r1chardj0n3s | nono, no storm, I even +1'ed it, without knowing that answer! | 22:10 |
| ongk | what other questions did I miss? | 22:10 |
| *** crobertsrh is now known as _crobertsrh | 22:11 | |
| r1chardj0n3s | none from me | 22:11 |
| ongk | tqtran: issues with pie chart demo? | 22:11 |
| david-lyle | ongk: I had a couple bits of feedback on that, but I'll leave it on the patch | 22:12 |
| david-lyle | really looks pretty good | 22:12 |
| david-lyle | actually since you're all here | 22:12 |
| * r1chardj0n3s ducks | 22:13 | |
| tqtran | ongk: yep | 22:13 |
| david-lyle | I didn't have the answer, but the key have numerator and denominator in seems sub-optimal | 22:14 |
| david-lyle | is there another place we could put the denominator? | 22:14 |
| ongk | tqtran: are you getting a blank page or just a weird chart? | 22:14 |
| david-lyle | like a smaller percentage and the total value under it in the middle | 22:14 |
| tqtran | ongk: blank list, with an alert error saying: unable to retrieve hypervisor instances list | 22:14 |
| david-lyle | or just a total in the key? | 22:14 |
| tqtran | ongk: the original page works fine for me | 22:14 |
| david-lyle | I googled up examples, and that chart is surprisingly useless in most examples | 22:15 |
| david-lyle | it's great if you are out of 100%, or the denominator is well known, like hours in a day | 22:16 |
| ongk | so something like 20% of [denomitor]? | 22:16 |
| david-lyle | or 20%\n28GB | 22:16 |
| david-lyle | not sure there's room | 22:17 |
| ongk | In the launch instance workflow, there might not be room. The charts are pretty small in the modal. | 22:17 |
| david-lyle | second thought, donut charts are pretty, but do they actually convey information well? | 22:18 |
| tqtran | david-lyle: of course, reminds me that im hungry | 22:18 |
| david-lyle | they're fairly standard, so maybe that's not our battle here | 22:18 |
| david-lyle | tqtran: stay on target, stay on target | 22:19 |
| david-lyle | I'd ping Piet but he seems occupied with work and stuff | 22:20 |
| ongk | tqtran: lol | 22:20 |
| ongk | I bet Piet has some strong opinions on it | 22:20 |
| david-lyle | bah | 22:20 |
| david-lyle | :D | 22:20 |
| ongk | well, these donut charts look like a meter. I think that’s maybe what UX was trying to go for | 22:21 |
| david-lyle | it's because dashboards should have meters that look like cars, because the metaphor isn't far enough removed, I get it | 22:22 |
| david-lyle | I'm ok with the chart | 22:23 |
| david-lyle | I just think list the fraction in the key could be done differently | 22:23 |
| david-lyle | overall, I actually like them | 22:23 |
| david-lyle | oh and hover shows values | 22:24 |
| openstackgerrit | Doug Fish proposed openstack/horizon: Fix documentation for setting password_autocomplete https://review.openstack.org/154266 | 22:24 |
| david-lyle | that's the next feature to add | 22:24 |
| david-lyle | :D | 22:24 |
| ongk | david-lyle: show the value in the center on hover? | 22:25 |
| david-lyle | no, value of the region being hovered over with key | 22:25 |
| ongk | Ah, gotcha | 22:26 |
| *** woodm1979 has quit IRC | 22:27 | |
| *** lblanchard has quit IRC | 22:27 | |
| *** lblanchard has joined #openstack-horizon | 22:28 | |
| *** peristeri has quit IRC | 22:29 | |
| *** gokrokve has quit IRC | 22:29 | |
| *** gokrokve has joined #openstack-horizon | 22:29 | |
| ongk | david-lyle: I can play around with that hover and denominator and see how it looks | 22:31 |
| ongk | might not be too bad | 22:31 |
| david-lyle | ongk: not huge items, if you have a chance | 22:31 |
| david-lyle | hoping someone here would just have a suggestion | 22:32 |
| *** lblanchard has quit IRC | 22:38 | |
| *** rbertram has quit IRC | 22:40 | |
| *** iamjarvo has joined #openstack-horizon | 22:43 | |
| openstackgerrit | Merged openstack/horizon: Adds styling of "Confirm Password" Field in user forms https://review.openstack.org/153520 | 22:45 |
| *** bitblt2 has joined #openstack-horizon | 22:46 | |
| openstackgerrit | Merged openstack/horizon: Fixes inline edit icon size/placement https://review.openstack.org/145197 | 22:47 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in architecture to Jasmine https://review.openstack.org/153927 | 22:48 |
| *** absubram has quit IRC | 22:49 | |
| *** woodm1979 has joined #openstack-horizon | 22:52 | |
| woodm1979 | lhcheng: or david-lyle: was there ever a bug where custom panels/dashboards were only loading in openstack_dashboard, but any reference to horizon.conf didn't find them? | 22:52 |
| *** e0ne has quit IRC | 22:53 | |
| david-lyle | woodm1979: ? | 22:53 |
| lhcheng | woodm1979: more details | 22:53 |
| david-lyle | what lin said | 22:54 |
| woodm1979 | hehe | 22:54 |
| lhcheng | woodm1979: maybe if you can give us the jira #, we'll remember it :P | 22:54 |
| woodm1979 | So, using print statements to debug things (for another group inside HP here) we are loading a custom panel into openstack_dashboard. | 22:54 |
| woodm1979 | LOL | 22:54 |
| *** Longgeek has joined #openstack-horizon | 22:55 | |
| david-lyle | you're loading custom panels with print statements? | 22:55 |
| woodm1979 | BUT when we look at the code inside horizon.base.py Site._Load_panel_customization, the list of panels is empty. | 22:55 |
| woodm1979 | Nobody likes you david-lyle. | 22:55 |
| woodm1979 | except me. | 22:55 |
| david-lyle | woodm1979: fair enough | 22:55 |
| woodm1979 | Even your mother doesn't like you any more. | 22:55 |
| lhcheng | woodm1979: there was one group in HP that has loading issue with custom panel, is that deployed on tripleo? | 22:56 |
| woodm1979 | I don't know that answer, but I can ask. | 22:56 |
| lhcheng | but it was a deployment issue though. not sure if this is the same group. | 22:56 |
| woodm1979 | Cloud System? | 22:56 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Enable jsi18n in Jasmine spec runner. https://review.openstack.org/154223 | 22:57 |
| woodm1979 | We're finding the data inside the openstack_dashboard code though. So we know it's there. But when horizon attempts to look inside it's conf the list is empty. | 22:57 |
| david-lyle | woodm1979: you have an plugin file in the enabled directory and when that is loaded it's not added to the list of content | 22:57 |
| david-lyle | ? | 22:57 |
| woodm1979 | That's correct. | 22:59 |
| woodm1979 | When debugging (with print statements) the openstack_dashboard code seems to know that the panels are there. (openstack_dashboard.utile.settings.py update_dashboards. | 22:59 |
| btully | are there other files in the enabled directory that disable those panels? | 23:00 |
| lhcheng | woodm1979: I assume that the custom panel is in a different directory? | 23:00 |
| woodm1979 | btully: Pretty sure not, but we'll check. | 23:00 |
| btully | i.e., “REMOVE_PANEL = True” | 23:00 |
| woodm1979 | lhcheng: Yeah. Maybe we need to update python path? | 23:00 |
| lhcheng | woodm1979: maybe the code is not in the python path? | 23:01 |
| woodm1979 | ok. I'll check that out. | 23:01 |
| woodm1979 | Thanks man. | 23:01 |
| lhcheng | maybe it is not installed in the system python | 23:01 |
| woodm1979 | Where's the officially suggested place to update that? There's no mechanism inside horizon's settings files or anything, right. Just use the env-var? | 23:02 |
| woodm1979 | Or stuff it inside the .venv | 23:02 |
| woodm1979 | ? | 23:02 |
| david-lyle | woodm1979: it should be installed on the system like any other python package | 23:02 |
| david-lyle | so the pluggable should have a setup.py, etc | 23:02 |
| *** scsnow has quit IRC | 23:02 | |
| *** mpavlase has quit IRC | 23:03 | |
| david-lyle | that's the least invasive way to do it | 23:03 |
| woodm1979 | Oh, we can get away with just a dir of code any more? | 23:03 |
| david-lyle | woodm1979: you can, but the update story is a mess | 23:03 |
| david-lyle | but that's your business I suppose | 23:03 |
| woodm1979 | hahaha. | 23:03 |
| *** bitblt2 has quit IRC | 23:03 | |
| david-lyle | just blanket another golden image down and blow everything away | 23:04 |
| woodm1979 | :-) | 23:04 |
| david-lyle | (facepalm) | 23:04 |
| woodm1979 | I'm pretty sure we're not even getting to the import statements though. THe list is empty prior to that code line. | 23:04 |
| david-lyle | where are the import statements? | 23:05 |
| woodm1979 | https://github.com/openstack/horizon/blob/master/horizon/base.py#L881 | 23:05 |
| *** jamielennox|away is now known as jamielennox | 23:05 | |
| woodm1979 | That's where our debugging print-statement is coming back with an empty list. | 23:06 |
| david-lyle | that's just reading the enabled file | 23:06 |
| woodm1979 | Sure, but we attempt to load them all in the next method down. | 23:06 |
| david-lyle | that's how it discovers things like the python path | 23:06 |
| david-lyle | yes the module | 23:06 |
| david-lyle | but if it's not in the python path, that's not going to work | 23:07 |
| woodm1979 | I'll dig some more. This is like 3rd hand helping, so I was just hoping it'd tickle your memories. | 23:07 |
| *** clu__ has joined #openstack-horizon | 23:07 | |
| david-lyle | woodm1979: I've used the mechanism extensively recently and it worked fine | 23:07 |
| woodm1979 | Yeah, I was thinking they might have an older version of horizon with a known bug or something. | 23:08 |
| woodm1979 | but if it's not ringing any bells, we'll keep looking. | 23:08 |
| david-lyle | I think even icehouse worked to some degree | 23:08 |
| *** clu_ has quit IRC | 23:08 | |
| david-lyle | if you had a stack trace or something | 23:08 |
| david-lyle | was it working before, or is this a new integration | 23:09 |
| r1chardj0n3s | "david-lyle: I think even icehouse worked to some degree" Imma keep that one for out of context quoting | 23:09 |
| woodm1979 | There's no stacktrace, the list just gets emptied. | 23:09 |
| david-lyle | r1chardj0n3s: it true in the broader sense | 23:09 |
| david-lyle | feel free to reuse | 23:10 |
| woodm1979 | How does the horizon conf get tied to the HORIZON_CONFIG inside openstack_dashboard? That may be key to our debugging efforts. | 23:10 |
| woodm1979 | (And thank you both for your help. I really apprecaite it.) | 23:10 |
| david-lyle | woodm1979: it's not | 23:10 |
| woodm1979 | oh. | 23:11 |
| david-lyle | you're registering it with the dashboard | 23:11 |
| david-lyle | or panel_group | 23:11 |
| david-lyle | https://github.com/openstack/horizon/blob/master/horizon/base.py#L924 ish | 23:11 |
| woodm1979 | But the code here: https://github.com/openstack/horizon/blob/master/horizon/base.py#L880 is pulling it from teh horizon.conf | 23:11 |
| *** vijendar has quit IRC | 23:12 | |
| *** Longgeek has quit IRC | 23:12 | |
| woodm1979 | That all leads back from horizon's conf. | 23:12 |
| david-lyle | that's the base yes | 23:12 |
| woodm1979 | :-) And it's empty. So perhaps we're loading it wrong? Thing is, we're seeing our dashboard data in this var: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L88 | 23:14 |
| woodm1979 | Gah, sorry, here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L132 | 23:14 |
| woodm1979 | horizon_config['panel_customization'] | 23:14 |
| woodm1979 | So we're really confused why we'd see it there, but not in horizon's panel loading mechanisms. | 23:15 |
| david-lyle | panel_customization is empty? | 23:15 |
| woodm1979 | horizon_config['panel_customization'] in https://github.com/openstack/horizon/blob/master/openstack_dashboard/utils/settings.py#L132 is populated. | 23:15 |
| woodm1979 | panel_customization in https://github.com/openstack/horizon/blob/master/horizon/base.py#L880 is empty. | 23:16 |
| *** TravT has joined #openstack-horizon | 23:17 | |
| *** TravT has quit IRC | 23:18 | |
| *** TravT_ has joined #openstack-horizon | 23:18 | |
| david-lyle | me either, are you/they overwriting it somewhere? | 23:20 |
| woodm1979 | I don't think they are. | 23:20 |
| woodm1979 | Don't spend any more time on it. I'll help them dig deeper. | 23:20 |
| david-lyle | this whole asking for a friend facade is convenient | 23:20 |
| woodm1979 | Like I said, I was hoping for a known-solved-old bug. | 23:20 |
| david-lyle | :D | 23:20 |
| woodm1979 | hahaha | 23:20 |
| david-lyle | I have no idea | 23:21 |
| woodm1979 | It's someone Jeff Walls knows, though he's only 3 cubes away as the crow-flies. :-) | 23:21 |
| woodm1979 | Thanks though. | 23:21 |
| woodm1979 | I do appreciate it. | 23:21 |
| david-lyle | oh, well then | 23:21 |
| woodm1979 | Now, I'm going to abandon them for the day though. Gotta drive home before traffic gets ugly. | 23:22 |
| david-lyle | sure | 23:22 |
| david-lyle | ttyl | 23:22 |
| *** woodm1979 has quit IRC | 23:22 | |
| *** sqchen has quit IRC | 23:22 | |
| *** iamjarvo has quit IRC | 23:24 | |
| *** sqchen has joined #openstack-horizon | 23:24 | |
| *** EmilienM is now known as EmilienM|afk | 23:28 | |
| *** alexvictorchan has quit IRC | 23:35 | |
| *** EmilyW has joined #openstack-horizon | 23:35 | |
| *** alexvictorchan has joined #openstack-horizon | 23:35 | |
| *** Drago has quit IRC | 23:45 | |
| *** iamjarvo has joined #openstack-horizon | 23:46 | |
| *** btully has quit IRC | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!