*** btully has joined #openstack-horizon | 00:10 | |
*** aix has quit IRC | 00:26 | |
*** aix has joined #openstack-horizon | 00:30 | |
*** annashen has joined #openstack-horizon | 00:36 | |
*** annashen has quit IRC | 00:41 | |
*** nlahouti has quit IRC | 00:49 | |
*** iamjarvo has joined #openstack-horizon | 00:53 | |
*** Longgeek has joined #openstack-horizon | 01:08 | |
*** kiseok7_ has joined #openstack-horizon | 01:11 | |
*** Longgeek has quit IRC | 01:15 | |
*** alexpilotti has quit IRC | 01:19 | |
*** amotoki has joined #openstack-horizon | 01:38 | |
*** tzumainn has joined #openstack-horizon | 01:47 | |
*** annashen has joined #openstack-horizon | 01:54 | |
*** nlahouti has joined #openstack-horizon | 01:56 | |
*** annashen has quit IRC | 01:58 | |
*** annashen has joined #openstack-horizon | 01:59 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 02:01 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 02:08 |
---|---|---|
*** tzumainn has quit IRC | 02:15 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 02:19 | |
*** julim has quit IRC | 02:24 | |
*** nlahouti has quit IRC | 02:39 | |
*** SimonChung1 has quit IRC | 02:40 | |
*** SimonChung has joined #openstack-horizon | 02:40 | |
*** btully has quit IRC | 02:42 | |
*** jrist has quit IRC | 03:01 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 03:04 |
*** annashen has quit IRC | 03:05 | |
*** kiseok7_ has quit IRC | 03:05 | |
*** kiseok7_ has joined #openstack-horizon | 03:06 | |
*** Longgeek has joined #openstack-horizon | 03:11 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 03:11 |
*** iamjarvo has quit IRC | 03:12 | |
*** jrist has joined #openstack-horizon | 03:13 | |
*** Longgeek has quit IRC | 03:13 | |
*** Longgeek has joined #openstack-horizon | 03:14 | |
*** akanksha has quit IRC | 03:17 | |
*** stevemar has joined #openstack-horizon | 03:19 | |
*** Longgeek_ has joined #openstack-horizon | 03:19 | |
*** Longgeek has quit IRC | 03:20 | |
*** amotoki has quit IRC | 03:28 | |
*** Longgeek has joined #openstack-horizon | 03:41 | |
*** Longgeek_ has quit IRC | 03:44 | |
*** iamjarvo has joined #openstack-horizon | 03:46 | |
*** iamjarvo has quit IRC | 03:46 | |
*** bpokorny has joined #openstack-horizon | 03:47 | |
*** iamjarvo has joined #openstack-horizon | 03:47 | |
*** bpokorny has quit IRC | 03:51 | |
*** iamjarvo has quit IRC | 04:03 | |
*** Longgeek has quit IRC | 04:11 | |
*** Longgeek has joined #openstack-horizon | 04:11 | |
*** lhcheng has quit IRC | 04:25 | |
*** gokrokve has joined #openstack-horizon | 04:40 | |
*** gokrokve has quit IRC | 04:45 | |
*** gokrokve has joined #openstack-horizon | 04:46 | |
*** annashen has joined #openstack-horizon | 04:47 | |
*** gokrokve has quit IRC | 04:50 | |
*** masco has joined #openstack-horizon | 04:54 | |
*** masco has quit IRC | 04:58 | |
*** nlahouti has joined #openstack-horizon | 05:00 | |
*** nlahouti has quit IRC | 05:01 | |
*** nlahouti has joined #openstack-horizon | 05:02 | |
*** annashen has quit IRC | 05:03 | |
openstackgerrit | Merged openstack/horizon: Launch instance - common style https://review.openstack.org/160221 | 05:07 |
*** gokrokve has joined #openstack-horizon | 05:16 | |
*** gokrokve has quit IRC | 05:18 | |
*** gokrokve has joined #openstack-horizon | 05:18 | |
*** gokrokve has quit IRC | 05:23 | |
*** btully has joined #openstack-horizon | 05:24 | |
*** lhcheng has joined #openstack-horizon | 05:25 | |
*** lhcheng has quit IRC | 05:30 | |
*** lhcheng has joined #openstack-horizon | 05:36 | |
*** stevemar has quit IRC | 05:55 | |
*** masco has joined #openstack-horizon | 05:59 | |
*** nikunj2512 has joined #openstack-horizon | 06:02 | |
*** dboik_ has quit IRC | 06:05 | |
*** sayan has joined #openstack-horizon | 06:05 | |
openstackgerrit | Brian Tully proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 06:05 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 06:10 |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 06:13 | |
openstackgerrit | Nikunj Aggarwal proposed openstack/horizon: Adding missing cancel button in create & edit subnet https://review.openstack.org/131928 | 06:17 |
*** gokrokve has joined #openstack-horizon | 06:18 | |
*** amotoki has joined #openstack-horizon | 06:21 | |
*** nlahouti has quit IRC | 06:21 | |
*** nlahouti has joined #openstack-horizon | 06:22 | |
*** gokrokve has quit IRC | 06:23 | |
*** sseago has quit IRC | 06:28 | |
openstackgerrit | Brian Tully proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 06:28 |
*** jprovazn has joined #openstack-horizon | 06:31 | |
*** nlahouti has quit IRC | 06:37 | |
*** _gryf|afk has quit IRC | 06:41 | |
*** amotoki has quit IRC | 06:43 | |
*** amotoki has joined #openstack-horizon | 06:44 | |
*** ishant has joined #openstack-horizon | 06:47 | |
*** amotoki has quit IRC | 06:48 | |
*** _gryf has joined #openstack-horizon | 06:49 | |
nikunj2512 | vokhrimenko: Hello | 06:51 |
*** Longgeek_ has joined #openstack-horizon | 06:52 | |
*** Longgeek has quit IRC | 06:52 | |
*** tnovacik has joined #openstack-horizon | 06:53 | |
*** sayan has quit IRC | 06:55 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: made all status values translatable in port table https://review.openstack.org/164587 | 07:00 |
*** mrunge has joined #openstack-horizon | 07:08 | |
*** pcaruana has quit IRC | 07:14 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: fixed row update of firewall table https://review.openstack.org/158244 | 07:17 |
*** gokrokve has joined #openstack-horizon | 07:18 | |
*** gokrokve has quit IRC | 07:20 | |
*** gokrokve has joined #openstack-horizon | 07:20 | |
*** oro has joined #openstack-horizon | 07:21 | |
*** oro_ has joined #openstack-horizon | 07:21 | |
*** gokrokve has quit IRC | 07:24 | |
*** e0ne has joined #openstack-horizon | 07:34 | |
*** romainh has joined #openstack-horizon | 07:36 | |
*** jtomasek has joined #openstack-horizon | 07:36 | |
*** e0ne has quit IRC | 07:39 | |
*** mflobo has quit IRC | 07:43 | |
*** rwsu has joined #openstack-horizon | 07:43 | |
*** Miouge has joined #openstack-horizon | 07:44 | |
*** amotoki has joined #openstack-horizon | 07:44 | |
*** mflobo has joined #openstack-horizon | 07:45 | |
*** oro_ has quit IRC | 08:08 | |
*** oro has quit IRC | 08:08 | |
*** markus_z has joined #openstack-horizon | 08:08 | |
*** mrunge has quit IRC | 08:18 | |
*** gokrokve has joined #openstack-horizon | 08:18 | |
*** mrunge has joined #openstack-horizon | 08:20 | |
*** gokrokve has quit IRC | 08:23 | |
*** Miouge has quit IRC | 08:29 | |
*** Miouge has joined #openstack-horizon | 08:32 | |
*** jcoufal has joined #openstack-horizon | 08:33 | |
*** rdopiera has joined #openstack-horizon | 08:34 | |
*** Miouge has quit IRC | 08:36 | |
*** btully has quit IRC | 08:36 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: made all status values translatable in port table https://review.openstack.org/164587 | 08:37 |
*** pkarikh has joined #openstack-horizon | 08:39 | |
*** Miouge has joined #openstack-horizon | 08:44 | |
*** KanagarajM has joined #openstack-horizon | 08:45 | |
*** Ala has joined #openstack-horizon | 08:46 | |
*** zz_ttrifonov is now known as ttrifonov | 08:49 | |
*** Ala has quit IRC | 08:49 | |
*** Ala has joined #openstack-horizon | 08:50 | |
*** Ala has quit IRC | 08:52 | |
*** Ala has joined #openstack-horizon | 08:52 | |
*** Miouge has quit IRC | 08:54 | |
*** oro_ has joined #openstack-horizon | 08:54 | |
*** JeanBriceCombebi has joined #openstack-horizon | 08:55 | |
*** oro has joined #openstack-horizon | 08:55 | |
*** jcoufal has quit IRC | 08:57 | |
*** ttrifonov is now known as zz_ttrifonov | 08:57 | |
*** zz_ttrifonov is now known as ttrifonov | 08:58 | |
*** ttrifonov is now known as zz_ttrifonov | 09:03 | |
*** zz_ttrifonov is now known as ttrifonov | 09:04 | |
*** robcresswell_afk is now known as robcresswell | 09:05 | |
*** JeanBriceCombebi has quit IRC | 09:05 | |
*** dkorn has joined #openstack-horizon | 09:06 | |
*** ttrifonov is now known as zz_ttrifonov | 09:07 | |
*** JeanBriceCombebi has joined #openstack-horizon | 09:08 | |
*** zz_ttrifonov is now known as ttrifonov | 09:08 | |
*** JeanBriceCombebi has quit IRC | 09:08 | |
*** ttrifonov is now known as zz_ttrifonov | 09:10 | |
*** dkorn has quit IRC | 09:11 | |
openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Don't crash when a bulk action is done with empty node list https://review.openstack.org/161706 | 09:11 |
*** zz_ttrifonov is now known as ttrifonov | 09:12 | |
*** ttrifonov is now known as zz_ttrifonov | 09:15 | |
*** zz_ttrifonov is now known as ttrifonov | 09:15 | |
*** gokrokve has joined #openstack-horizon | 09:18 | |
*** gokrokve has quit IRC | 09:22 | |
openstackgerrit | Kamil Rykowski proposed openstack/horizon: Change ports range in validators and test function https://review.openstack.org/116508 | 09:33 |
*** ygbo has joined #openstack-horizon | 09:33 | |
*** btully has joined #openstack-horizon | 09:34 | |
*** Ala has quit IRC | 09:35 | |
*** Ala has joined #openstack-horizon | 09:37 | |
*** btully has quit IRC | 09:39 | |
openstackgerrit | Merged openstack/tuskar-ui: Don't crash when a bulk action is done with empty node list https://review.openstack.org/161706 | 09:45 |
*** lhcheng has quit IRC | 09:50 | |
*** enykeev has joined #openstack-horizon | 09:56 | |
*** akrivoka has joined #openstack-horizon | 10:10 | |
robcresswell | nikunj2512: ping | 10:16 |
*** gokrokve has joined #openstack-horizon | 10:18 | |
robcresswell | nikunj2512: Would you consider my comment here please? https://bugs.launchpad.net/horizon/+bug/1431341 | 10:19 |
openstack | Launchpad bug 1431341 in OpenStack Dashboard (Horizon) "Tab bar in Firefox displays unnecessary dotted focus outline" [Undecided,New] - Assigned to Nikunj Aggarwal (nikunj2512) | 10:19 |
*** gokrokve has quit IRC | 10:23 | |
*** oro_ has quit IRC | 10:29 | |
KanagarajM | david_lyle: could you review https://review.openstack.org/#/c/141759/ ? I have given my inputs for your comments. | 10:30 |
*** oro has quit IRC | 10:30 | |
*** tosky has joined #openstack-horizon | 10:31 | |
*** sseago has joined #openstack-horizon | 10:47 | |
*** tnovacik_ has joined #openstack-horizon | 10:47 | |
*** tnovacik has quit IRC | 10:48 | |
robcresswell | KanagarajM: I think what david-lyle_afk is arguing is, why use hostname? Just use id alone | 10:52 |
robcresswell | KanagarajM: Seems that just using id would be easier | 10:52 |
KanagarajM | robcresswell: nova os-hypervisor does uses the hostname as the key | 10:52 |
KanagarajM | so i couldn't move it to using id instead of hostname | 10:54 |
robcresswell | KanagarajM: So it uses a non-unique key? That seems like bizarre behaviour | 10:55 |
*** ZZelle has joined #openstack-horizon | 10:55 | |
KanagarajM | robcresswell: yes, the design problem is with nova, the defect is seen on horizon, its like inter-project issue. i tried to send mail on this with subject: '[openstack-dev][nova][horizon] Inter-project issue : redundant hyperviosr_hostname ' some time back but didn't help. | 10:57 |
KanagarajM | robcresswell: would you suggest a way to fix this problem ? | 10:58 |
robcresswell | KanagarajM: It looks to me like we're using hypervisors.search in the nova api. Can't we use hypervisor get? https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/hypervisors.py#L55 | 10:59 |
robcresswell | KanagarajM: I'm not very familiar with Nova. But it seems like we should just change the API call and get a specific hypervisor, rather than searching for a matching hostname then filtering by id... | 11:00 |
KanagarajM | robcresswell: let me look at it, 1 sec | 11:00 |
KanagarajM | robcresswell: we need to get the hyerpvisor and its instances list and for the same we are using the search which give this details | 11:03 |
KanagarajM | robcresswell: http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-hypervisors, the last API in this doc, is the one we uses | 11:03 |
robcresswell | KanagarajM: I'm not sure I understand. Does get not return the information needed? | 11:06 |
robcresswell | KanagarajM: The only distinction in those two calls seems to be that one returns a matching list, and the other returns a single item | 11:07 |
KanagarajM | robcresswell: yes. | 11:07 |
robcresswell | KanagarajM: If we're passing an id to view a single item, it seems strange to use hostname and then id, when we could just use id and get. | 11:07 |
KanagarajM | robcresswell: I completely agreee that its an nova issue, but horizon is the one hitting the issue, the same issue was there in nova cli as well, but they have fixed by displayin name and id next to the each of the instance row | 11:09 |
KanagarajM | robcresswell: similar thing, we may not to do in the horizon, i think, so tried to fix it by work arround as in the patch. | 11:10 |
robcresswell | KanagarajM: :/ I think you're confusing two distinct issues | 11:11 |
robcresswell | KanagarajM: in https://review.openstack.org/#/c/141759/1/openstack_dashboard/dashboards/admin/hypervisors/views.py you are just returning the servers for one hypervisor | 11:11 |
robcresswell | KanagarajM: So rather than use hypervisor_search with a hostname, just hypervisor get with an id. | 11:12 |
*** tosky has quit IRC | 11:12 | |
robcresswell | KanagarajM: Then you can remove hostname entirely | 11:12 |
robcresswell | name* | 11:12 |
*** tosky has joined #openstack-horizon | 11:12 | |
KanagarajM | robcresswell: i thought about this approach, but this will change the current behavior on the hypervisor index page, where currently user can click on the hyerpervisor name and indexing happens on the name | 11:13 |
KanagarajM | but we may need to change to adding one more id column in the index page and make id column as clickable | 11:14 |
KanagarajM | robcresswell: is it ok to go with this change in behavior? | 11:14 |
*** gokrokve has joined #openstack-horizon | 11:18 | |
KanagarajM | robcresswell: in this approach, we need 1. first get the hypervisor name by using get(id) method 2. then use serach method with name paramenter | 11:20 |
KanagarajM | robcresswell: for each of the the hypervisor click. | 11:21 |
*** aix has quit IRC | 11:21 | |
*** tnovacik_ has quit IRC | 11:23 | |
*** gokrokve has quit IRC | 11:23 | |
robcresswell | KanagarajM: I'm not sure why you would need to search for the hypervisor after having done a get on the hypervisor. Just trying to work out if Nova can actually interpret ID or if it is strictly hostname. Docs say hostname, but that get function using an ID is confusing me. | 11:26 |
robcresswell | KanagarajM: Maybe the current approach is the only reasonable way to do it :/ ugly code though | 11:28 |
robcresswell | KanagarajM: Nova's fault :p | 11:28 |
KanagarajM | robcresswell: yes its a nova fault, if nova given the instances for the given hypervisor as part of get hyerpervisor, the problem would not been there :( | 11:31 |
*** tsufiev has quit IRC | 11:38 | |
*** rushiagr_away is now known as rushiagr | 11:39 | |
*** tsufiev_ is now known as tsufiev | 11:42 | |
*** mpavlase has joined #openstack-horizon | 11:45 | |
openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Heat resource url mapping improvement https://review.openstack.org/164658 | 11:54 |
*** rushiagr is now known as rushiagr_away | 11:55 | |
*** KanagarajM has quit IRC | 11:55 | |
openstackgerrit | Doug Fish proposed openstack/horizon: Hide panels without services https://review.openstack.org/163888 | 11:57 |
*** rushiagr_away is now known as rushiagr | 12:01 | |
*** mpavlase has quit IRC | 12:02 | |
*** henrique_ has joined #openstack-horizon | 12:04 | |
*** mpavlase has joined #openstack-horizon | 12:08 | |
*** tzumainn has joined #openstack-horizon | 12:11 | |
*** tnovacik_ has joined #openstack-horizon | 12:12 | |
*** rm_work is now known as rm_work|away | 12:14 | |
*** sayan has joined #openstack-horizon | 12:16 | |
*** fthiagogv has joined #openstack-horizon | 12:17 | |
*** gokrokve has joined #openstack-horizon | 12:18 | |
*** raildo has joined #openstack-horizon | 12:21 | |
*** gokrokve has quit IRC | 12:23 | |
*** davelowe has quit IRC | 12:23 | |
*** masco has quit IRC | 12:26 | |
* nikunj2512 away | 12:27 | |
*** alexpilotti has joined #openstack-horizon | 12:27 | |
*** davelowe has joined #openstack-horizon | 12:27 | |
rdopiera | nikunj2512: can you please disable that? | 12:28 |
*** fthiagogv has quit IRC | 12:28 | |
*** fthiagogv has joined #openstack-horizon | 12:28 | |
*** lblanchard has joined #openstack-horizon | 12:29 | |
openstackgerrit | Nikita Konovalov proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 12:29 |
*** fthiagogv has quit IRC | 12:30 | |
*** radez_g0n3 is now known as radez | 12:38 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: Show ports from shared nets in floating IP assoc https://review.openstack.org/163728 | 12:38 |
*** mattamizer has joined #openstack-horizon | 12:47 | |
*** openstackgerrit has quit IRC | 12:50 | |
*** openstackgerrit has joined #openstack-horizon | 12:50 | |
*** fifieldt has joined #openstack-horizon | 12:51 | |
*** lblanchard has quit IRC | 12:56 | |
*** oro has joined #openstack-horizon | 12:56 | |
*** oro_ has joined #openstack-horizon | 12:56 | |
*** wuhg has joined #openstack-horizon | 12:57 | |
*** dboik has joined #openstack-horizon | 12:57 | |
*** mattamizer has quit IRC | 13:01 | |
*** _crobertsrh is now known as crobertsrh | 13:06 | |
*** Ala has quit IRC | 13:07 | |
*** Ala has joined #openstack-horizon | 13:08 | |
*** julim has joined #openstack-horizon | 13:09 | |
*** dboik has quit IRC | 13:09 | |
*** aix has joined #openstack-horizon | 13:10 | |
*** btully has joined #openstack-horizon | 13:11 | |
*** btully has quit IRC | 13:15 | |
*** gokrokve has joined #openstack-horizon | 13:18 | |
*** masco has joined #openstack-horizon | 13:20 | |
*** gokrokve has quit IRC | 13:22 | |
*** underbyte1 has joined #openstack-horizon | 13:23 | |
*** underbyte1 has quit IRC | 13:24 | |
*** underbyte1 has joined #openstack-horizon | 13:24 | |
*** amotoki has quit IRC | 13:26 | |
openstackgerrit | Bradley Jones proposed openstack/horizon: Updated overview graph when usage exceeds quota https://review.openstack.org/119427 | 13:27 |
*** underbyte1 has left #openstack-horizon | 13:28 | |
*** ishant has quit IRC | 13:31 | |
*** bluex-pl has joined #openstack-horizon | 13:32 | |
*** Ctina_ has joined #openstack-horizon | 13:35 | |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: upstream deltas needed for neutron api https://review.openstack.org/164287 | 13:35 |
*** btully has joined #openstack-horizon | 13:36 | |
*** sseago has left #openstack-horizon | 13:37 | |
*** nikunj2512 has quit IRC | 13:38 | |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: upstream deltas needed for neutron api https://review.openstack.org/164287 | 13:39 |
*** dboik has joined #openstack-horizon | 13:39 | |
*** dboik has quit IRC | 13:39 | |
*** Ctina_ is now known as ctina | 13:39 | |
*** dboik has joined #openstack-horizon | 13:40 | |
*** andrewbogott_afk is now known as andrewbogott | 13:43 | |
*** sambetts_ is now known as sambetts | 13:45 | |
*** jtriley has joined #openstack-horizon | 13:52 | |
*** tnovacik_ has quit IRC | 13:53 | |
*** gokrokve has joined #openstack-horizon | 13:56 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: Add Django-1.7 support https://review.openstack.org/161117 | 13:57 |
*** matt-borland has joined #openstack-horizon | 13:57 | |
*** radez is now known as radez_g0n3 | 13:58 | |
*** andrewbogott is now known as andrewbogott_afk | 13:58 | |
matt-borland | andrewbogott: wait...did you go to Carleton? | 13:59 |
matt-borland | andrewbogott_afk: ^^ | 14:00 |
*** samueldmq has quit IRC | 14:00 | |
*** gokrokve_ has joined #openstack-horizon | 14:00 | |
*** mwhagedorn has quit IRC | 14:01 | |
*** ctina has quit IRC | 14:01 | |
*** mwhagedorn has joined #openstack-horizon | 14:02 | |
*** peristeri has joined #openstack-horizon | 14:03 | |
*** gokrokve has quit IRC | 14:04 | |
*** tnovacik_ has joined #openstack-horizon | 14:05 | |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Refactor, customization and fixes of Metadata Widget https://review.openstack.org/136437 | 14:06 |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Metadata display widget https://review.openstack.org/151745 | 14:06 |
*** doug-fish has joined #openstack-horizon | 14:07 | |
*** mattfarina has joined #openstack-horizon | 14:08 | |
*** bluex-pl has quit IRC | 14:12 | |
*** Ala has quit IRC | 14:15 | |
*** Ala has joined #openstack-horizon | 14:20 | |
*** krykowski has joined #openstack-horizon | 14:23 | |
*** amerine has quit IRC | 14:24 | |
*** Drago has joined #openstack-horizon | 14:26 | |
*** amotoki has joined #openstack-horizon | 14:26 | |
*** Drago has quit IRC | 14:27 | |
*** Drago has joined #openstack-horizon | 14:27 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:28 | |
*** jtriley has quit IRC | 14:30 | |
*** amotoki has quit IRC | 14:32 | |
*** jtriley has joined #openstack-horizon | 14:32 | |
*** JeanBriceCombebi has quit IRC | 14:34 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:36 | |
*** stevemar has joined #openstack-horizon | 14:40 | |
*** angular_mike has joined #openstack-horizon | 14:42 | |
*** iamjarvo has joined #openstack-horizon | 14:49 | |
*** tmcpeak has joined #openstack-horizon | 14:52 | |
tmcpeak | hey all - I had a question about cache-control in Horizon… namely I'm running a scanner and it's finding an insecure cache control issue. In a signed cookies backend when I make an auth request it responds with my signed cookie session ID as expected, but Cache-Control is set to "max-age=0" only. Is this sufficient to ensure that the session ID cookie is not saved to disk in all browsers, or should we include "Private" as well? | 14:55 |
*** krykowski has quit IRC | 14:55 | |
tmcpeak | "no-store" etc | 14:55 |
tmcpeak | I've found online that max-age=0 seems to fulfill this requirement, but then it seems like "Private" is what we really want | 14:56 |
*** neelashah has joined #openstack-horizon | 14:57 | |
tmcpeak | also seems like Django has ways to set these, just wondering if there is a conscious reason we're only using max-age | 14:57 |
*** rushiagr is now known as rushiagr_away | 15:02 | |
openstackgerrit | Radomir Dopieralski proposed openstack/tuskar-ui: Make role validation more useful https://review.openstack.org/164727 | 15:08 |
*** lblanchard has joined #openstack-horizon | 15:10 | |
*** JeanBriceCombebi has quit IRC | 15:12 | |
*** david-lyle_afk is now known as david-lyle | 15:15 | |
*** bpokorny has joined #openstack-horizon | 15:16 | |
*** SimonChung has quit IRC | 15:19 | |
*** alexvictorchan has joined #openstack-horizon | 15:24 | |
*** Piet has joined #openstack-horizon | 15:26 | |
*** jtriley has quit IRC | 15:27 | |
*** rm_work|away is now known as rm_work | 15:30 | |
*** rushiagr_away is now known as rushiagr | 15:30 | |
*** masco has quit IRC | 15:30 | |
*** jtriley has joined #openstack-horizon | 15:31 | |
*** jprovazn has quit IRC | 15:33 | |
*** rdopiera has quit IRC | 15:34 | |
*** krykowski has joined #openstack-horizon | 15:36 | |
*** Longgeek_ has quit IRC | 15:36 | |
*** rdopiera has joined #openstack-horizon | 15:36 | |
*** romainh has quit IRC | 15:38 | |
*** JeanBriceCombebi has joined #openstack-horizon | 15:40 | |
*** btully has quit IRC | 15:44 | |
*** lhcheng has joined #openstack-horizon | 15:45 | |
*** iamjarvo has quit IRC | 15:46 | |
*** ZZelle_ has joined #openstack-horizon | 15:46 | |
*** wuhg has quit IRC | 15:49 | |
*** tqtran has joined #openstack-horizon | 15:51 | |
*** rushiagr is now known as rushiagr_away | 15:53 | |
*** gokrokve_ has quit IRC | 15:53 | |
*** gokrokve has joined #openstack-horizon | 15:57 | |
*** gyee has joined #openstack-horizon | 15:59 | |
*** tnovacik_ has quit IRC | 15:59 | |
*** gary-smith_ has left #openstack-horizon | 16:01 | |
*** gary-smith_ has quit IRC | 16:01 | |
*** btully has joined #openstack-horizon | 16:01 | |
*** absubram has quit IRC | 16:01 | |
*** gary-smith_ has joined #openstack-horizon | 16:01 | |
*** rushiagr_away is now known as rushiagr | 16:02 | |
*** gary-smith_ has quit IRC | 16:03 | |
*** gary-smith_ has joined #openstack-horizon | 16:04 | |
*** SimonChung has joined #openstack-horizon | 16:06 | |
*** ZZelle_ has quit IRC | 16:08 | |
*** vokhrimenko has quit IRC | 16:09 | |
*** openstackgerrit has quit IRC | 16:11 | |
*** openstackgerrit has joined #openstack-horizon | 16:12 | |
*** vijendar has joined #openstack-horizon | 16:12 | |
*** vijendar has quit IRC | 16:12 | |
*** iamjarvo has joined #openstack-horizon | 16:12 | |
*** vijendar has joined #openstack-horizon | 16:13 | |
*** samueldmq has joined #openstack-horizon | 16:13 | |
*** amotoki has joined #openstack-horizon | 16:16 | |
*** Piet has quit IRC | 16:16 | |
*** aix has quit IRC | 16:16 | |
*** radez_g0n3 is now known as radez | 16:16 | |
*** amotoki has quit IRC | 16:21 | |
*** nlahouti has joined #openstack-horizon | 16:21 | |
*** rdopiera has quit IRC | 16:21 | |
*** vijendar has quit IRC | 16:22 | |
*** iamjarvo has quit IRC | 16:29 | |
*** dboik_ has joined #openstack-horizon | 16:30 | |
*** alanf-mc has joined #openstack-horizon | 16:31 | |
*** iamjarvo has joined #openstack-horizon | 16:32 | |
*** dboik has quit IRC | 16:33 | |
*** gokrokve has quit IRC | 16:34 | |
*** gokrokve has joined #openstack-horizon | 16:36 | |
*** iamjarvo has quit IRC | 16:36 | |
*** krykowski has quit IRC | 16:37 | |
*** samueldmq has quit IRC | 16:40 | |
*** sbfox has joined #openstack-horizon | 16:43 | |
*** oro has quit IRC | 16:43 | |
*** smc7 has joined #openstack-horizon | 16:43 | |
*** oro_ has quit IRC | 16:44 | |
*** tnovacik_ has joined #openstack-horizon | 16:47 | |
*** neelashah has quit IRC | 16:47 | |
*** markus_z has quit IRC | 16:52 | |
*** angular_mike has quit IRC | 16:53 | |
*** openstackgerrit has quit IRC | 16:54 | |
*** openstackgerrit has joined #openstack-horizon | 16:54 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Replace usage of urllib in nova rest api https://review.openstack.org/164780 | 16:56 |
*** neelashah has joined #openstack-horizon | 17:00 | |
*** neelashah1 has joined #openstack-horizon | 17:00 | |
*** SimonChung has quit IRC | 17:00 | |
*** annashen has joined #openstack-horizon | 17:00 | |
*** SimonChung1 has joined #openstack-horizon | 17:00 | |
*** iamjarvo has joined #openstack-horizon | 17:01 | |
*** SimonChung1 has quit IRC | 17:01 | |
*** SimonChung has joined #openstack-horizon | 17:01 | |
*** SimonChung has quit IRC | 17:01 | |
*** SimonChung1 has joined #openstack-horizon | 17:01 | |
*** iamjarvo has quit IRC | 17:01 | |
*** SimonChung1 has quit IRC | 17:01 | |
*** SimonChung has joined #openstack-horizon | 17:01 | |
*** henrique_ has quit IRC | 17:02 | |
*** htruta has quit IRC | 17:02 | |
*** iamjarvo has joined #openstack-horizon | 17:02 | |
*** iamjarvo has quit IRC | 17:02 | |
*** htruta has joined #openstack-horizon | 17:03 | |
*** SimonChung has quit IRC | 17:03 | |
*** SimonChung has joined #openstack-horizon | 17:03 | |
*** iamjarvo has joined #openstack-horizon | 17:03 | |
*** neelashah has quit IRC | 17:04 | |
*** iamjarvo has quit IRC | 17:04 | |
*** iamjarvo has joined #openstack-horizon | 17:05 | |
*** ttrifonov is now known as zz_ttrifonov | 17:05 | |
*** dboik_ has quit IRC | 17:06 | |
*** dboik has joined #openstack-horizon | 17:09 | |
*** JeanBriceCombebi has quit IRC | 17:09 | |
*** ygbo has quit IRC | 17:10 | |
*** gokrokve has quit IRC | 17:11 | |
*** alanf-mc has quit IRC | 17:11 | |
*** kaufer has joined #openstack-horizon | 17:12 | |
*** cbader has joined #openstack-horizon | 17:16 | |
*** cbader02 has joined #openstack-horizon | 17:16 | |
*** jwy has joined #openstack-horizon | 17:16 | |
*** Piet has joined #openstack-horizon | 17:16 | |
*** romainh has joined #openstack-horizon | 17:17 | |
*** cbader02 has quit IRC | 17:21 | |
*** Piet has quit IRC | 17:23 | |
*** alanf-mc has joined #openstack-horizon | 17:26 | |
*** harlowja has joined #openstack-horizon | 17:28 | |
*** SimonChung has quit IRC | 17:36 | |
*** SimonChung1 has joined #openstack-horizon | 17:36 | |
*** rushiagr is now known as rushiagr_away | 17:36 | |
openstackgerrit | Thai Tran proposed openstack/django_openstack_auth: Add authentication using openID and SAML https://review.openstack.org/136178 | 17:36 |
openstackgerrit | Thai Tran proposed openstack/horizon: Enable login via openID and SAML https://review.openstack.org/151842 | 17:36 |
*** clu_ has joined #openstack-horizon | 17:36 | |
tmcpeak | hey all - I had a question about cache-control in Horizon… namely I'm running a scanner and it's finding an insecure cache control issue. In a signed cookies backend when I make an auth request it responds with my signed cookie session ID as expected, but Cache-Control is set to "max-age=0" only. Is this sufficient to ensure that the session ID cookie is not saved to disk in all browsers, or should we include "Private" as well? | 17:37 |
*** SimonChung1 has quit IRC | 17:38 | |
*** SimonChung has joined #openstack-horizon | 17:38 | |
*** Sukhdev has joined #openstack-horizon | 17:38 | |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: upstream deltas needed for neutron api https://review.openstack.org/164287 | 17:38 |
*** gokrokve has joined #openstack-horizon | 17:39 | |
*** vijendar has joined #openstack-horizon | 17:42 | |
*** jtriley has quit IRC | 17:43 | |
*** andrewbogott_afk is now known as andrewbogott | 17:45 | |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP angularize identity users. https://review.openstack.org/133767 | 17:45 |
*** Ala has quit IRC | 17:46 | |
andrewbogott | matt-borland: yep, that’s me :) I recognized your name but decided it must be a coincidence :) | 17:47 |
andrewbogott | matt-borland: are you at RS these days? | 17:49 |
*** ybathia has joined #openstack-horizon | 17:50 | |
kaufer | I'm trying to understand if Horizon uses (or would like support for) a "previous" link when doing GET paginated queries ... many projects support a "next" link but I cannot find much support for a "previous" link ... anyone familiar with this? | 17:51 |
*** sayan has quit IRC | 17:53 | |
*** mpavlase has quit IRC | 17:54 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 17:56 |
*** rm_work has left #openstack-horizon | 17:56 | |
*** romainh has quit IRC | 17:57 | |
jwy | kaufer: there's a blueprint for adding "previous" links - https://blueprints.launchpad.net/horizon/+spec/pagination-add-prev-link | 17:59 |
jwy | there was also discussion about pagination at the last summit - https://etherpad.openstack.org/p/kilo-horizon-clientside-data | 17:59 |
*** amerine has joined #openstack-horizon | 18:01 | |
*** SimonChung1 has joined #openstack-horizon | 18:02 | |
*** SimonChung has quit IRC | 18:02 | |
kaufer | jwy: Ok thanks, seems like the 2nd link focuses on paging the data client-side, instead of server-side | 18:02 |
*** SimonChung1 has quit IRC | 18:02 | |
*** SimonChung has joined #openstack-horizon | 18:02 | |
*** amerine has quit IRC | 18:03 | |
david-lyle | kaufer: the target is to move that control to the client | 18:03 |
*** peristeri has quit IRC | 18:04 | |
kaufer | david-lyle: Ok, so then you'd get the first page of items from the server (maybe 100) and then client-side you'd show a subset of that (maybe 10) and then having prev/next links to move within the page of items from the server? | 18:05 |
*** peristeri has joined #openstack-horizon | 18:05 | |
*** iamjarvo has quit IRC | 18:08 | |
kaufer | jwy david-lyle: The reason I'm asking is that I cannot find many projects that support the "previous" link for pagination, they only support the "next" link. If support for this would be useful for Horizon then we need to get the projects to support it. | 18:10 |
david-lyle | kaufer: they don't that's why we're going to do it in the client side | 18:11 |
david-lyle | and we'll pull the full list to the client | 18:11 |
david-lyle | this allows for useful filtering and pagination which most APIs don't provide | 18:11 |
smc7 | are the service teams not interested in doing that on the API side? | 18:12 |
david-lyle | projects aren't interested in supporting previous | 18:12 |
david-lyle | marker and limit is what we get | 18:12 |
kaufer | david-lyle: Ok, that makes sense ... would you see value in getting server-side "previous" support, or do the filtering issues make it not work pursuing? | 18:13 |
kaufer | david-lyle: When you say that they "aren't interested" in supporting previous does that mean that it has been proposed and rejected? | 18:13 |
david-lyle | we can fake the previous on our side by storing a reference to the ID beginning the last page, but that's of limited value | 18:13 |
david-lyle | the other benefit of pulling the larger list to the client is we can give a value for # of pages and indexing to those pages | 18:14 |
david-lyle | which is also lacking | 18:14 |
david-lyle | kaufer: yes | 18:14 |
david-lyle | marker and limit is the scheme | 18:14 |
*** oro_ has joined #openstack-horizon | 18:14 | |
david-lyle | because it is most efficient for DB interaction | 18:15 |
david-lyle | additionally, Keystone in v3 does not support pagination at all | 18:15 |
kaufer | david-lyle: Yes, I'm familiar with that limitation | 18:15 |
stevemar | david-lyle, filtering is your friend | 18:15 |
david-lyle | and since all projects are free to do whatever they want, we're going standardize on our end | 18:16 |
david-lyle | and try to make something usable | 18:16 |
*** welldannit has joined #openstack-horizon | 18:16 | |
david-lyle | which is not what we have now | 18:16 |
*** oro has joined #openstack-horizon | 18:17 | |
david-lyle | stevemar: do you support filtering on any string input? :) | 18:17 |
*** rushiagr_away is now known as rushiagr | 18:17 | |
david-lyle | but yes faceted searching is part of the clientside implementation | 18:18 |
david-lyle | which will go back to the server | 18:18 |
david-lyle | and service | 18:18 |
*** iamjarvo has joined #openstack-horizon | 18:18 | |
stevemar | david-lyle, i think we support most of the resource's attributes | 18:19 |
*** paul-- has quit IRC | 18:20 | |
kaufer | stevemar: It is definately a subset, at least for nova and cinder | 18:20 |
david-lyle | but by attribute, correct? | 18:20 |
stevemar | david-lyle, kaufer right, by attribute - http://specs.openstack.org/openstack/keystone-specs/api/v3/identity-api-v3.html#list-users | 18:21 |
david-lyle | stevemar: just making sure you all haven't changed things on me again | 18:21 |
*** packet has joined #openstack-horizon | 18:21 | |
david-lyle | :D | 18:21 |
openstackgerrit | Dan Nguyen proposed openstack/horizon: Add example keystone v3 policy file to horizon https://review.openstack.org/162325 | 18:21 |
stevemar | nah | 18:21 |
stevemar | again? | 18:21 |
stevemar | :P | 18:21 |
david-lyle | not pagination per se, but domains, tokens, project hierarchies, etc | 18:23 |
*** tmcpeak has left #openstack-horizon | 18:23 | |
*** peristeri has quit IRC | 18:25 | |
*** peristeri has joined #openstack-horizon | 18:27 | |
*** Piet has joined #openstack-horizon | 18:28 | |
*** paul-- has joined #openstack-horizon | 18:29 | |
*** welldannit has quit IRC | 18:38 | |
*** annashen has quit IRC | 18:44 | |
*** annashen has joined #openstack-horizon | 18:45 | |
*** smc7 has quit IRC | 18:46 | |
*** oro_ has quit IRC | 18:54 | |
*** annashen has quit IRC | 18:55 | |
*** smc7 has joined #openstack-horizon | 18:56 | |
*** annashen has joined #openstack-horizon | 18:58 | |
*** welldannit has joined #openstack-horizon | 18:59 | |
openstackgerrit | Michael Hagedorn proposed openstack/horizon: upstream deltas needed for neutron api https://review.openstack.org/164287 | 19:01 |
matt-borland | andrewbogott: I'm at HP out in Fort Collins CO working on Horizon :) | 19:02 |
*** KanagarajM has joined #openstack-horizon | 19:03 | |
KanagarajM | lhcheng: hi, could you kindly review https://review.openstack.org/#/c/141759/ | 19:04 |
*** samueldmq has joined #openstack-horizon | 19:07 | |
andrewbogott | matt-borland: sounds like fun! | 19:07 |
*** nlahouti has quit IRC | 19:08 | |
*** iamjarvo has quit IRC | 19:08 | |
matt-borland | andrewbogott: the Carleton mafia never ceases to amaze. | 19:09 |
andrewbogott | well, I’m in Minneapolis so it’s not as much of a surprise here :) | 19:09 |
*** annashen has quit IRC | 19:11 | |
*** oro_ has joined #openstack-horizon | 19:11 | |
*** annashen has joined #openstack-horizon | 19:11 | |
matt-borland | andrewbogott: yeah, true! there's a small pocket of resistance out here. | 19:12 |
*** dboik has quit IRC | 19:12 | |
matt-borland | such a small world | 19:12 |
*** dboik has joined #openstack-horizon | 19:13 | |
*** neelashah1 has quit IRC | 19:13 | |
*** mpavlase has joined #openstack-horizon | 19:15 | |
*** SimonChung has quit IRC | 19:16 | |
*** akanksha has joined #openstack-horizon | 19:17 | |
*** neelashah has joined #openstack-horizon | 19:18 | |
*** SimonChung has joined #openstack-horizon | 19:19 | |
*** annashen has quit IRC | 19:25 | |
openstackgerrit | Merged openstack/horizon: made all status values translatable in port table https://review.openstack.org/164587 | 19:26 |
*** annashen has joined #openstack-horizon | 19:28 | |
*** iamjarvo has joined #openstack-horizon | 19:30 | |
openstackgerrit | Merged openstack/horizon: add the package 'which' to fedora https://review.openstack.org/163828 | 19:31 |
*** annashen has quit IRC | 19:31 | |
*** annashen has joined #openstack-horizon | 19:32 | |
*** mpavlase has quit IRC | 19:35 | |
*** mpavlase has joined #openstack-horizon | 19:36 | |
*** annashen has quit IRC | 19:37 | |
*** annashen has joined #openstack-horizon | 19:37 | |
*** packet has quit IRC | 19:37 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Auto-focus for modal dialog https://review.openstack.org/156785 | 19:37 |
openstackgerrit | Thai Tran proposed openstack/django_openstack_auth: Add authentication using openID and SAML https://review.openstack.org/136178 | 19:37 |
KanagarajM | could someone review https://review.openstack.org/#/c/141759/ and approve if changes are fine? | 19:38 |
*** Sukhdev has quit IRC | 19:38 | |
*** rushiagr is now known as rushiagr_away | 19:42 | |
*** packet has joined #openstack-horizon | 19:43 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Auto-focus for modal dialog https://review.openstack.org/156785 | 19:43 |
openstackgerrit | Thai Tran proposed openstack/horizon: Enable login via openID and SAML https://review.openstack.org/151842 | 19:43 |
openstackgerrit | Anna Shen proposed openstack/horizon: Initial support for database clustering in Horizon https://review.openstack.org/110411 | 19:45 |
*** jtriley has joined #openstack-horizon | 19:47 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: Add Django-1.7 support https://review.openstack.org/161117 | 19:48 |
*** alexpilotti has quit IRC | 19:50 | |
lhcheng | KanagarajM: patch reviewed | 19:53 |
*** amotoki has joined #openstack-horizon | 19:53 | |
KanagarajM | lhcheng: thanks. let me look at. | 19:53 |
robcresswell | lhcheng: Oh good catch. Seems my reviewing skills need more work :) | 19:54 |
lhcheng | robcresswell: heh | 19:57 |
lhcheng | robcresswell: not sure if you've got the chance to see my comment on the launchpad ticket | 19:57 |
lhcheng | robcresswell: about the misaligned data cell | 19:57 |
lhcheng | robcresswell: the misalignment doesn't seem too obvious to me | 19:57 |
robcresswell | lhcheng: Yes actually, I had intended to respond, I didn't think it was the patch you had linked | 19:58 |
*** amotoki has quit IRC | 19:58 | |
robcresswell | lhcheng: Hmm, on my system its very clear | 19:58 |
*** mpavlase has quit IRC | 19:58 | |
robcresswell | lhcheng: Like something is overriding vertical-align:middle to vertical-align:top, but I couldnt identify where it was in the time I spent looking | 19:58 |
robcresswell | lhcheng: Ha, it actually appears to be fixed now... | 19:59 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Demo for auto-focus https://review.openstack.org/158100 | 20:00 |
KanagarajM | lhcheng: trying to understand your comment, intead of using pop(), get one of the hypervisor from the list and and use it in the test further, is it right? | 20:00 |
lhcheng | robcresswell: hah things just fixes automatically. :) | 20:01 |
robcresswell | lhcheng: Bizarre. I checked on master. Guess I'll remove the bug. | 20:02 |
openstackgerrit | Merged openstack/horizon: Launch Instance Model https://review.openstack.org/158929 | 20:02 |
openstackgerrit | Merged openstack/horizon: Launch Instance Step - Select Source https://review.openstack.org/158934 | 20:02 |
david-lyle | holy cow | 20:02 |
* david-lyle faints | 20:02 | |
openstackgerrit | Merged openstack/horizon: Launch Instance Step - Select Flavor https://review.openstack.org/158945 | 20:02 |
* david-lyle faints again | 20:02 | |
robcresswell | woohoo! | 20:02 |
lhcheng | robcresswell: some recent patch could have fixed it, as long as it works now :) | 20:03 |
robcresswell | lhcheng: Seems to be resolved. Thanks. | 20:03 |
*** akrivoka has quit IRC | 20:04 | |
robcresswell | I'll be localising all those awful spellings of "Flavour" in the morning... :p | 20:05 |
lhcheng | robcresswell: anytime | 20:07 |
*** rushiagr_away is now known as rushiagr | 20:07 | |
lhcheng | KanagarajM: yes, that is correct. we should not be modifying the test data. | 20:07 |
KanagarajM | lhchend: sure. thx. | 20:09 |
matt-borland | robcresswell: lol | 20:09 |
KanagarajM | lhcheng: i'm using the first hypervisor from the list | 20:09 |
*** mrunge has quit IRC | 20:10 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Focus-trap for modal dialog https://review.openstack.org/157656 | 20:10 |
*** tsufiev is now known as tsufiev_ | 20:10 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Demo for focus-trap https://review.openstack.org/158416 | 20:11 |
*** romainh has joined #openstack-horizon | 20:12 | |
*** dak419 has joined #openstack-horizon | 20:16 | |
*** akrivoka has joined #openstack-horizon | 20:16 | |
*** jtomasek has quit IRC | 20:17 | |
*** alexpilotti has joined #openstack-horizon | 20:19 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/horizon: hypervisor list and details page reports invalid data https://review.openstack.org/141759 | 20:19 |
*** nlahouti has joined #openstack-horizon | 20:24 | |
*** gokrokve has quit IRC | 20:27 | |
openstackgerrit | Aaron Sahlin proposed openstack/horizon: Magic Search Enablement https://review.openstack.org/157481 | 20:27 |
*** gokrokve has joined #openstack-horizon | 20:27 | |
*** rushiagr is now known as rushiagr_away | 20:27 | |
*** crobertsrh has quit IRC | 20:29 | |
*** SimonChung2 has joined #openstack-horizon | 20:29 | |
*** SimonChung has quit IRC | 20:29 | |
KanagarajM | lhcheng: i updated the patch and could you validate the changes once ? | 20:29 |
*** SimonChung has joined #openstack-horizon | 20:30 | |
*** SimonChung2 has quit IRC | 20:30 | |
*** SimonChung has quit IRC | 20:30 | |
*** SimonChung1 has joined #openstack-horizon | 20:30 | |
*** julim has quit IRC | 20:31 | |
lhcheng | KanagarajM: I still don't see the test being added to exercise the new logic | 20:32 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Details UX/Angular redesign https://review.openstack.org/158409 | 20:32 |
openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 20:32 |
mattfarina | anyone know an *easy way* to calculate code coverage over the JS in horizon? | 20:32 |
KanagarajM | lhcheng: i couldn't get you. | 20:33 |
KanagarajM | lhcheng: in this patch only the way args are passed geting changed from name to id_name format | 20:34 |
KanagarajM | lhcheng: kindly let me know what is missing? | 20:34 |
lhcheng | KanagarajM: the patch fixes the issue when two hypervisor have the same name, but different ID | 20:35 |
lhcheng | KanagarajM: I'd like to see a test that validates that. | 20:36 |
*** vishwanathj has quit IRC | 20:37 | |
*** vishwanathj has joined #openstack-horizon | 20:37 | |
*** vishwana_ has joined #openstack-horizon | 20:39 | |
*** e0ne has joined #openstack-horizon | 20:39 | |
*** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:39 | |
*** dboik has quit IRC | 20:40 | |
*** annashen has quit IRC | 20:40 | |
r1chardj0n3s | morning | 20:41 |
*** dboik has joined #openstack-horizon | 20:41 | |
mattfarina | r1chardj0n3s good morning | 20:41 |
KanagarajM | lhcheng: ok. instead of using blank [] , do you want to use some meaning full data object and validate the resource.ctx.data with that ? | 20:41 |
*** lhcheng is now known as lhcheng_afk | 20:41 | |
mattfarina | r1chardj0n3s you might have some idea about this... any thoughts on JS code coverage for Horizon? | 20:41 |
openstackgerrit | Merged openstack/horizon: Launch Instance Step - Configuration https://review.openstack.org/158953 | 20:41 |
r1chardj0n3s | mattfarina: if we used a proper testing tool like karma it can report coverage | 20:42 |
*** vishwanathj has quit IRC | 20:42 | |
matt-borland | r1chardj0n3s: knew you'd say that :) | 20:42 |
r1chardj0n3s | welp :) | 20:42 |
mattfarina | r1chardj0n3s next thing you'll suggest we use package management with bower | 20:43 |
matt-borland | I use karma for my side projects :) | 20:43 |
* mattfarina ducks and covers | 20:43 | |
mattfarina | r1chardj0n3s any experience with blanket.js? | 20:43 |
*** shivrao has joined #openstack-horizon | 20:44 | |
r1chardj0n3s | mattfarina: nope | 20:44 |
mattfarina | http://blanketjs.org/ | 20:44 |
mattfarina | seems it works in browser with both qunit and jasmine | 20:45 |
r1chardj0n3s | righto | 20:45 |
openstackgerrit | Kelly Domico proposed openstack/horizon: Fixed transcluded content not updating in action list https://review.openstack.org/164862 | 20:45 |
r1chardj0n3s | I've only ever used the plugin for karma which is so much nicer to use than in-browser ;) | 20:45 |
r1chardj0n3s | I feel like a dinosaur using in-browser javascript testing | 20:46 |
mattfarina | r1chardj0n3s i'm not sure how to get around in browser with openstack-infra in the near future | 20:46 |
mattfarina | or i would suggest something that way | 20:46 |
openstackgerrit | Kelly Domico proposed openstack/horizon: Demo of Action List https://review.openstack.org/162496 | 20:47 |
r1chardj0n3s | mattfarina: openstack-infra are totally not against using the correct tool for the job; in fact as far as I'm aware no-one has any issue with us moving to using bower for js unit testing | 20:47 |
r1chardj0n3s | & I also wish to look into using phantomjs for selenium tests; running selenium tests in an actual browser with a window and all also makes me feel like a dinosaur. | 20:48 |
mattfarina | i was thinking the exact same thing | 20:48 |
r1chardj0n3s | moving to those two things should only make infra happier; less resources to run our tests *and* they will run much faster | 20:48 |
mattfarina | if we can solve the local mirror problem that would pave the way for them | 20:49 |
*** e0ne has quit IRC | 20:49 | |
r1chardj0n3s | the bower issue? that's very much an independent issue | 20:49 |
r1chardj0n3s | and also we have a solution for that in the spec I co-wrote with #infra | 20:49 |
*** packet has quit IRC | 20:50 | |
*** dak419 has quit IRC | 20:50 | |
r1chardj0n3s | we have most of the code for it done, we just have run into the end of this cycle so are unlikely to get it in before the summit | 20:50 |
*** annashen has joined #openstack-horizon | 20:51 | |
*** alanf-mc has quit IRC | 20:58 | |
*** alanf-mc_ has joined #openstack-horizon | 20:58 | |
*** harlowja is now known as harlowja_away | 20:58 | |
*** packet has joined #openstack-horizon | 21:00 | |
*** Sukhdev has joined #openstack-horizon | 21:01 | |
*** mpavlase has joined #openstack-horizon | 21:02 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Instance Details UX/Angular redesign https://review.openstack.org/153602 | 21:04 |
openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 21:04 |
*** SimonChung1 has quit IRC | 21:05 | |
*** SimonChung has joined #openstack-horizon | 21:05 | |
*** oro_ has quit IRC | 21:06 | |
*** htruta has quit IRC | 21:06 | |
*** iamjarvo has quit IRC | 21:06 | |
*** oro has quit IRC | 21:07 | |
*** amotoki has joined #openstack-horizon | 21:09 | |
*** neelashah has quit IRC | 21:11 | |
*** annashen has quit IRC | 21:12 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/horizon: Create Hierarchical Projects https://review.openstack.org/119469 | 21:12 |
*** lhcheng_afk is now known as lhcheng | 21:16 | |
*** alanf-mc_ has quit IRC | 21:16 | |
*** radez is now known as radez_g0n3 | 21:16 | |
*** akrivoka has quit IRC | 21:19 | |
*** iamjarvo has joined #openstack-horizon | 21:20 | |
*** iamjarvo has quit IRC | 21:21 | |
*** iamjarvo has joined #openstack-horizon | 21:21 | |
*** sambetts has quit IRC | 21:22 | |
*** sambetts has joined #openstack-horizon | 21:25 | |
*** matt-borland has quit IRC | 21:25 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance Step - Network https://review.openstack.org/158950 | 21:27 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 21:27 |
*** akanksha has quit IRC | 21:27 | |
*** packet has quit IRC | 21:27 | |
*** oro has joined #openstack-horizon | 21:27 | |
jwy | any core devs available to review this and help me get ATC status for kilo? :) it has five +1s - https://review.openstack.org/#/c/145654/ (Prevent flash of left nav panels when loading page) | 21:27 |
*** SimonChung1 has joined #openstack-horizon | 21:28 | |
*** oro_ has joined #openstack-horizon | 21:28 | |
*** SimonChung has quit IRC | 21:29 | |
*** lblanchard has quit IRC | 21:29 | |
*** annashen has joined #openstack-horizon | 21:30 | |
*** mattfarina has quit IRC | 21:33 | |
*** iamjarvo has quit IRC | 21:35 | |
jwy | david-lyle: thank you! | 21:44 |
*** vijendar has quit IRC | 21:45 | |
*** jtriley has quit IRC | 21:48 | |
openstackgerrit | Aaron Sahlin proposed openstack/horizon: Magic Search Demo in Users table https://review.openstack.org/151386 | 21:49 |
*** echevemaster_ has joined #openstack-horizon | 21:52 | |
*** echevemaster_ has quit IRC | 21:58 | |
*** echevemaster has joined #openstack-horizon | 21:58 | |
*** SimonChung has joined #openstack-horizon | 22:02 | |
*** SimonChung1 has quit IRC | 22:02 | |
*** SimonChung1 has joined #openstack-horizon | 22:04 | |
*** SimonChung has quit IRC | 22:04 | |
*** SimonChung has joined #openstack-horizon | 22:04 | |
*** absubram has joined #openstack-horizon | 22:06 | |
*** rdopiera has joined #openstack-horizon | 22:08 | |
*** iamjarvo has joined #openstack-horizon | 22:10 | |
robcresswell | Long day. Night all. | 22:11 |
*** harlowja_away is now known as harlowja | 22:11 | |
*** stevemar has quit IRC | 22:13 | |
*** welldannit has quit IRC | 22:13 | |
*** annashen has quit IRC | 22:14 | |
*** annashen has joined #openstack-horizon | 22:15 | |
*** robcresswell is now known as robcresswell_afk | 22:15 | |
*** mattfarina has joined #openstack-horizon | 22:18 | |
*** mattfarina has quit IRC | 22:18 | |
*** bpokorny_ has joined #openstack-horizon | 22:20 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/horizon: hypervisor list and details page reports invalid data https://review.openstack.org/141759 | 22:21 |
*** bpokorny has quit IRC | 22:23 | |
*** Piet has quit IRC | 22:24 | |
*** dboik_ has joined #openstack-horizon | 22:30 | |
*** dboik has quit IRC | 22:33 | |
*** dboik_ has quit IRC | 22:34 | |
tqtran | r1chardj0n3s: ping | 22:34 |
r1chardj0n3s | hi tqtran | 22:34 |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L153 | 22:35 |
tqtran | when you dont return anything, the client side thinks its an error | 22:35 |
tqtran | how is that handle today? | 22:35 |
r1chardj0n3s | it will return a 204 (no content) | 22:36 |
r1chardj0n3s | no error there... | 22:36 |
*** peristeri has quit IRC | 22:36 | |
tqtran | it actually returns a 501, not implemented | 22:36 |
r1chardj0n3s | which client thinks that's an error? | 22:36 |
tqtran | the keystone | 22:36 |
*** romainh has left #openstack-horizon | 22:36 | |
tqtran | got a min? i can show you on hangout | 22:36 |
r1chardj0n3s | sure | 22:37 |
tqtran | https://plus.google.com/hangouts/_/gudjnpxtc33fdotsgpl6c6dd6ia?hl=en | 22:37 |
openstackgerrit | David Lyle proposed openstack/horizon: Launch Instance Step - Key Pair Import https://review.openstack.org/164303 | 22:37 |
*** mpavlase1 has joined #openstack-horizon | 22:46 | |
*** mpavlase has quit IRC | 22:48 | |
*** kaufer has quit IRC | 22:56 | |
*** rdopiera has quit IRC | 22:58 | |
*** amotoki has quit IRC | 23:01 | |
*** Sukhdev has quit IRC | 23:01 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/horizon: hypervisor list and details page reports invalid data https://review.openstack.org/141759 | 23:01 |
*** iamjarvo has quit IRC | 23:07 | |
*** mwhagedorn has quit IRC | 23:07 | |
jamielennox | david-lyle: what's the horizon policy on freezing for kilo? are we likely to get at least the plugin stuff merged by then? | 23:13 |
*** gyee has quit IRC | 23:16 | |
*** oro_ has quit IRC | 23:17 | |
*** sbfox has quit IRC | 23:17 | |
*** oro_ has joined #openstack-horizon | 23:17 | |
*** oro has quit IRC | 23:17 | |
*** mwhagedorn has joined #openstack-horizon | 23:17 | |
*** absubram has quit IRC | 23:23 | |
*** smc7 has quit IRC | 23:23 | |
*** ZZelle has quit IRC | 23:25 | |
*** jtriley has joined #openstack-horizon | 23:27 | |
*** nkinder has joined #openstack-horizon | 23:29 | |
*** oro has joined #openstack-horizon | 23:34 | |
*** dak419 has joined #openstack-horizon | 23:39 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Correct ngdoc in Neutron AngularJS service https://review.openstack.org/163486 | 23:39 |
*** oro_ has quit IRC | 23:42 | |
*** oro has quit IRC | 23:43 | |
*** dboik has joined #openstack-horizon | 23:48 | |
*** gokrokve has quit IRC | 23:49 | |
*** dboik_ has joined #openstack-horizon | 23:49 | |
*** dboik has quit IRC | 23:53 | |
*** alexpilotti has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!