| *** dboik has quit IRC | 00:28 | |
| *** mpavlase has quit IRC | 00:30 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/166434 | 00:46 |
|---|---|---|
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Allow to control word order in create_pseudo_folder https://review.openstack.org/166560 | 00:49 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: I18N: Allow to control word order in create_pseudo_folder https://review.openstack.org/166560 | 00:51 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Adding launch details step -WIP https://review.openstack.org/166561 | 00:53 |
| *** ZZelle_ has quit IRC | 01:11 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 01:26 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 01:37 |
| *** alexvictorchan has joined #openstack-horizon | 01:43 | |
| *** sbfox has joined #openstack-horizon | 01:47 | |
| *** nkinder has joined #openstack-horizon | 01:49 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 02:00 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enabling loading script from local file https://review.openstack.org/165300 | 02:01 |
| *** nkinder has quit IRC | 02:13 | |
| *** alexvictorchan has quit IRC | 02:16 | |
| *** nkinder has joined #openstack-horizon | 02:18 | |
| *** sbfox has quit IRC | 02:21 | |
| *** nkinder has quit IRC | 02:35 | |
| openstackgerrit | Joseph Bajin proposed openstack/horizon: Added cancel_url to settings dashboard https://review.openstack.org/166569 | 02:42 |
| *** lhcheng has quit IRC | 02:47 | |
| david-lyle | vishwana_: if you ping me on Monday, I'd be happy to help you | 02:57 |
| vishwana_ | david_lyle, Thanks a bunch, I was able to get past the issue with guidance from Akhiro, however, I still have an issue with the router URLs being incorrect in the firewall details page, I may contact you on Monday if it does not get resolved before then. Thanks once again for offer of help | 02:59 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 03:09 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enabling loading script from local file https://review.openstack.org/165300 | 03:13 |
| *** sbfox has joined #openstack-horizon | 03:25 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Launch Instance - Optional Network Enabled https://review.openstack.org/164359 | 03:29 |
| openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 03:35 |
| *** sbfox has quit IRC | 03:38 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 03:39 |
| *** lhcheng has joined #openstack-horizon | 03:47 | |
| *** lhcheng has quit IRC | 03:52 | |
| *** raginbaj- has joined #openstack-horizon | 03:57 | |
| *** raginbajin has quit IRC | 03:58 | |
| *** raginbaj- is now known as raginbajin | 03:59 | |
| *** lhcheng has joined #openstack-horizon | 04:03 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Wizard should have max-width of 1440px https://review.openstack.org/166363 | 04:24 |
| *** bpokorny has quit IRC | 04:55 | |
| openstackgerrit | Abishek Subramanian proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 04:57 |
| absubram | hi.. anyone familiar with the index tests that we have in the tests.py files? I’m having a little trouble with a particular index test and would love some help in figuring out why | 05:15 |
| lhcheng | hey absubram | 05:15 |
| lhcheng | what's going on? | 05:16 |
| *** akanksha has quit IRC | 05:17 | |
| absubram | hey lhcheng! ty | 05:17 |
| absubram | so most index tests have this self.assertEqual test at the end? | 05:17 |
| absubram | and somehow the changes we have made is causing that to fail.. I understand it is comparing the “data” that from the context.. to what is provided in the test_data files, correct? | 05:18 |
| absubram | so I’m wondering what I’m missing that’s causing the assert | 05:18 |
| lhcheng | do you have which test is failing? | 05:19 |
| absubram | sure.. but you might need to patch in our review diffs for that :) | 05:19 |
| lhcheng | mostly index test checks that the correct template used, and the table data | 05:20 |
| absubram | https://review.openstack.org/#/c/162552/ | 05:20 |
| lhcheng | do you have it in gerrit? | 05:20 |
| absubram | I am failing the index_firewall tests.. | 05:20 |
| absubram | we had it all working ok till version 19.. but the last couple of changes we have made seem to have broken this one test.. | 05:20 |
| lhcheng | maybe additional api call was added and haven't been mocked? | 05:21 |
| lhcheng | https://review.openstack.org/#/c/162552/19..22/openstack_dashboard/dashboards/project/firewalls/views.py | 05:22 |
| lhcheng | could it be failing on this api call? | 05:22 |
| lhcheng | what's the error you see when test fails | 05:23 |
| absubram | hmm the error is self.failureException(‘0’ != ‘1’) | 05:24 |
| absubram | so essentially.. the context data is somehow null | 05:24 |
| absubram | and that’s why it is not equal to the test data | 05:24 |
| absubram | so the question is why is the context data null… hmm | 05:25 |
| lhcheng | some error hiding | 05:25 |
| lhcheng | pulling the patch | 05:25 |
| absubram | ok.. thanks.. | 05:26 |
| absubram | so my question was.. for these index tests.. | 05:26 |
| absubram | what actual code is it that is actually run? Is it the IndexView class in views.py? | 05:26 |
| absubram | or is it the tables.py code? | 05:26 |
| absubram | where do I set my breakpoint to step through this test :) | 05:26 |
| *** early has quit IRC | 05:27 | |
| *** briancline has quit IRC | 05:27 | |
| *** early has joined #openstack-horizon | 05:27 | |
| *** briancline has joined #openstack-horizon | 05:27 | |
| lhcheng | IndexView and FirewallTabs (contains the table) | 05:27 |
| absubram | gotcha.. | 05:28 |
| absubram | so the difference in versions 18 and 19 is what caused this | 05:28 |
| lhcheng | https://review.openstack.org/#/c/162552/18..19/openstack_dashboard/dashboards/project/firewalls/tabs.py | 05:32 |
| lhcheng | api.neutron.router_get(..) <- this call is not mocked | 05:32 |
| absubram | aha! | 05:32 |
| lhcheng | https://review.openstack.org/#/c/162552/22/openstack_dashboard/test/test_data/neutron_data.py | 05:33 |
| lhcheng | router_ids and router_names should be a list no? | 05:33 |
| absubram | yep.. you’re right on both accounts | 05:33 |
| absubram | the assert checks only for len.. so we haven’t been flagged yet | 05:34 |
| absubram | but that will fail new tests.. | 05:34 |
| absubram | thanks Lin Hua! :) | 05:34 |
| lhcheng | I guess the firewallTabs throw an error, and eat up the exception | 05:34 |
| absubram | I’m just testing with the new mock | 05:34 |
| vishwana_ | absubram, lhcheng, I have another question related to this patch.... | 05:34 |
| lhcheng | returning empty firewall records | 05:34 |
| vishwana_ | The cod in file https://review.openstack.org/#/c/162552/22/openstack_dashboard/dashboards/project/firewalls/templates/firewalls/_firewall_details.html is not behaving as expected....the links to routers are pointing to the firewall instead of the individual routers | 05:36 |
| vishwana_ | associated with the firewall | 05:37 |
| lhcheng | the url should be "horizon:project:routers:detail" | 05:39 |
| lhcheng | without the detail, it will open the routers index page | 05:40 |
| vishwana_ | oh, I see | 05:40 |
| vishwana_ | let me try that out | 05:40 |
| vishwana_ | lhcheng, that was it, that did the trick, I have spent many a sleepless nights the last week regarding this, a BIG THANKS to your help | 05:43 |
| lhcheng | vishwana_: anytime, if you get blocked again just reach out to this room | 05:44 |
| vishwana_ | lhcheng, will do, thanks a lot, I can now sleep peacefully :), you have a nice day | 05:45 |
| lhcheng | vishwana_: hah okay, you can enjoy the rest of weekend | 05:45 |
| absubram | lhcheng: thank you so much! that worked like a charm :) | 05:45 |
| lhcheng | absubram: cool :) | 05:46 |
| absubram | vishwana_ : haha guess we fixed both the problems we were hitting!! | 05:46 |
| absubram | all thanks to Lin Hua! :) | 05:46 |
| absubram | we owe him a drink in Vancouver ;) | 05:46 |
| vishwana_ | +1 | 05:46 |
| vishwana_ | a drink from me as well | 05:47 |
| lhcheng | heh | 05:47 |
| *** rushiagr_away is now known as rushiagr | 05:56 | |
| openstackgerrit | Abishek Subramanian proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 05:56 |
| *** vishwana_ has quit IRC | 06:00 | |
| *** stevemar has joined #openstack-horizon | 06:14 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/166583 | 06:16 |
| *** early has quit IRC | 06:27 | |
| *** briancline has quit IRC | 06:27 | |
| *** vishwanathj has joined #openstack-horizon | 06:29 | |
| *** early has joined #openstack-horizon | 06:29 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/166432 | 06:31 |
| *** briancline has joined #openstack-horizon | 06:43 | |
| openstackgerrit | Abishek Subramanian proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 06:48 |
| *** lhcheng has quit IRC | 06:57 | |
| *** lhcheng has joined #openstack-horizon | 07:08 | |
| *** xazel has joined #openstack-horizon | 07:58 | |
| *** enykeev has quit IRC | 07:59 | |
| *** oro has joined #openstack-horizon | 08:18 | |
| *** rushiagr is now known as rushiagr_away | 08:19 | |
| *** stevemar has quit IRC | 08:30 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/166583 | 08:51 |
| *** tnovacik has joined #openstack-horizon | 08:53 | |
| *** absubram has quit IRC | 08:57 | |
| *** dkorn has joined #openstack-horizon | 09:03 | |
| *** dkorn has quit IRC | 09:14 | |
| *** dkorn has joined #openstack-horizon | 09:30 | |
| *** ZZelle has quit IRC | 09:43 | |
| *** ZZelle has joined #openstack-horizon | 09:44 | |
| *** rushiagr_away is now known as rushiagr | 09:52 | |
| *** rushiagr is now known as rushiagr_away | 10:14 | |
| *** oro has quit IRC | 10:15 | |
| *** oro has joined #openstack-horizon | 10:26 | |
| *** Longgeek has joined #openstack-horizon | 10:28 | |
| *** btully has quit IRC | 10:34 | |
| *** btully has joined #openstack-horizon | 10:35 | |
| *** bradjones has quit IRC | 11:07 | |
| *** bradjones has joined #openstack-horizon | 11:10 | |
| *** lhcheng has quit IRC | 11:16 | |
| *** mpavlase has joined #openstack-horizon | 11:22 | |
| *** ZZelle_ has joined #openstack-horizon | 11:40 | |
| *** tnovacik has quit IRC | 11:57 | |
| *** lhcheng has joined #openstack-horizon | 12:16 | |
| *** lhcheng has quit IRC | 12:21 | |
| *** Longgeek has quit IRC | 12:22 | |
| *** mpavlase has quit IRC | 12:36 | |
| *** tnovacik has joined #openstack-horizon | 13:30 | |
| *** lhcheng has joined #openstack-horizon | 14:06 | |
| *** andrewbogott_afk is now known as andrewbogott | 14:07 | |
| *** lhcheng has quit IRC | 14:10 | |
| *** andrewbogott is now known as andrewbogott_afk | 14:21 | |
| *** ericksonsantos has joined #openstack-horizon | 14:21 | |
| *** htruta has joined #openstack-horizon | 14:21 | |
| *** dkorn has left #openstack-horizon | 14:53 | |
| *** mpavlase has joined #openstack-horizon | 14:58 | |
| *** tnovacik has quit IRC | 15:51 | |
| *** andrewbogott_afk is now known as andrewbogott | 16:08 | |
| *** cody-somerville has quit IRC | 17:03 | |
| *** andrewbogott is now known as andrewbogott_afk | 17:08 | |
| *** amotoki has joined #openstack-horizon | 17:15 | |
| *** cody-somerville has joined #openstack-horizon | 17:17 | |
| *** sbfox has joined #openstack-horizon | 17:24 | |
| *** andrewbogott_afk is now known as andrewbogott | 17:28 | |
| *** andrewbogott is now known as andrewbogott_afk | 17:28 | |
| *** lhcheng has joined #openstack-horizon | 17:43 | |
| *** lhcheng has quit IRC | 17:47 | |
| *** lhcheng has joined #openstack-horizon | 18:23 | |
| *** sbfox has quit IRC | 18:57 | |
| *** absubram has joined #openstack-horizon | 19:08 | |
| *** stevemar has joined #openstack-horizon | 19:15 | |
| *** sbfox has joined #openstack-horizon | 19:21 | |
| *** alexvictorchan has joined #openstack-horizon | 19:21 | |
| *** andrewbogott_afk is now known as andrewbogott | 19:28 | |
| *** andrewbogott is now known as andrewbogott_afk | 19:28 | |
| *** sbfox has quit IRC | 19:35 | |
| openstackgerrit | vishwanath jayaraman proposed openstack/horizon: Adds configuration support to associate firewall to routers https://review.openstack.org/162552 | 19:42 |
| *** iamjarvo has joined #openstack-horizon | 20:08 | |
| *** ZZelle__ has joined #openstack-horizon | 20:16 | |
| ZZelle__ | amotoki, hi | 20:16 |
| *** lhcheng is now known as lhcheng_afk | 20:16 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 20:21 | |
| r1chardj0n3s | morning | 20:22 |
| *** ZZelle__ has quit IRC | 20:40 | |
| *** tnovacik has joined #openstack-horizon | 21:00 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 21:05 |
| *** rwsu has quit IRC | 21:06 | |
| *** rwsu has joined #openstack-horizon | 21:07 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 21:09 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Enhancing wizard widget https://review.openstack.org/165475 | 21:14 |
| *** e0ne has joined #openstack-horizon | 21:27 | |
| *** stevemar has quit IRC | 21:33 | |
| *** e0ne has quit IRC | 21:53 | |
| *** iamjarvo has quit IRC | 21:59 | |
| *** jamielennox|away is now known as jamielennox | 22:00 | |
| *** ccrouch has joined #openstack-horizon | 22:10 | |
| *** ccrouch has left #openstack-horizon | 22:10 | |
| *** echevemaster has joined #openstack-horizon | 22:25 | |
| *** iamjarvo has joined #openstack-horizon | 22:29 | |
| *** iamjarvo has quit IRC | 22:40 | |
| *** mpavlase has quit IRC | 22:42 | |
| *** stevemar has joined #openstack-horizon | 22:58 | |
| *** Anticimex has quit IRC | 23:07 | |
| *** Anticimex has joined #openstack-horizon | 23:14 | |
| *** tnovacik has quit IRC | 23:17 | |
| *** alexvictorchan has quit IRC | 23:22 | |
| *** chlong has joined #openstack-horizon | 23:26 | |
| *** chlong has quit IRC | 23:40 | |
| *** chlong has joined #openstack-horizon | 23:40 | |
| *** oro has quit IRC | 23:46 | |
| *** echevemaster has quit IRC | 23:46 | |
| *** julim has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!