| *** annashen has quit IRC | 00:02 | |
| *** petertr7_away is now known as petertr7 | 00:02 | |
| *** Sukhdev has quit IRC | 00:03 | |
| *** Sukhdev has joined #openstack-horizon | 00:03 | |
| *** yamamoto has joined #openstack-horizon | 00:03 | |
| *** radez_g0n3 is now known as radez | 00:05 | |
| *** alexvictorchan has quit IRC | 00:05 | |
| *** Sukhdev has quit IRC | 00:08 | |
| *** lhcheng_ has joined #openstack-horizon | 00:09 | |
| *** jingjing_ren has quit IRC | 00:09 | |
| *** petertr7 is now known as petertr7_away | 00:12 | |
| *** lhcheng has quit IRC | 00:12 | |
| *** annashen has joined #openstack-horizon | 00:17 | |
| *** julim has quit IRC | 00:27 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 00:29 |
|---|---|---|
| *** yamamoto has quit IRC | 00:33 | |
| *** sjmc7 has quit IRC | 00:39 | |
| *** annashen has quit IRC | 00:39 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 00:40 |
| *** jingjing_ren has joined #openstack-horizon | 00:40 | |
| *** stevemar has joined #openstack-horizon | 00:42 | |
| *** annashen has joined #openstack-horizon | 00:44 | |
| *** jingjing_ren has quit IRC | 00:46 | |
| *** annashen has quit IRC | 00:47 | |
| *** radez is now known as radez_g0n3 | 00:47 | |
| *** annashen has joined #openstack-horizon | 00:53 | |
| *** ducttape_ has joined #openstack-horizon | 00:54 | |
| *** stevemar has quit IRC | 00:55 | |
| *** clu has quit IRC | 00:55 | |
| *** juggler has quit IRC | 01:00 | |
| *** juggler has joined #openstack-horizon | 01:00 | |
| *** jbell8 has quit IRC | 01:03 | |
| *** ducttape_ has quit IRC | 01:13 | |
| *** KunalGandhi has quit IRC | 01:14 | |
| *** nlahouti has quit IRC | 01:18 | |
| *** jwy has quit IRC | 01:21 | |
| *** annashen has quit IRC | 01:23 | |
| *** bpokorny has quit IRC | 01:25 | |
| *** yamamoto has joined #openstack-horizon | 01:32 | |
| *** yingjun has joined #openstack-horizon | 01:33 | |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 01:38 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Utils for auto-file-discovery https://review.openstack.org/183364 | 01:40 |
| *** alexvictorchan has joined #openstack-horizon | 01:42 | |
| *** jwy has joined #openstack-horizon | 01:42 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Rename files to enable auto-file-discovery https://review.openstack.org/190028 | 01:43 |
| *** yamamoto has quit IRC | 01:46 | |
| *** Piet has quit IRC | 01:47 | |
| *** hurgleburgler has quit IRC | 01:48 | |
| openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Tests for Base Controllers https://review.openstack.org/172057 | 01:49 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 01:57 |
| *** jtriley has joined #openstack-horizon | 01:57 | |
| *** yamamoto has joined #openstack-horizon | 01:59 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 02:00 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 02:01 |
| *** jtriley has quit IRC | 02:02 | |
| *** neillc is now known as neillc_away | 02:02 | |
| *** htruta has quit IRC | 02:02 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Trying to get pool/health_monitor only if existing https://review.openstack.org/160594 | 02:03 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Utils for auto-file-discovery https://review.openstack.org/183364 | 02:06 |
| *** jwy has quit IRC | 02:07 | |
| *** yamamoto has quit IRC | 02:09 | |
| *** mwhagedorn has joined #openstack-horizon | 02:12 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Rename files to enable auto-file-discovery https://review.openstack.org/190028 | 02:12 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 02:13 |
| *** Ephur has quit IRC | 02:24 | |
| *** alexvictorchan has quit IRC | 02:24 | |
| *** yingjun has quit IRC | 02:25 | |
| *** yingjun has joined #openstack-horizon | 02:27 | |
| *** yamamoto has joined #openstack-horizon | 02:28 | |
| *** alexvictorchan has joined #openstack-horizon | 02:29 | |
| *** Kunal has joined #openstack-horizon | 02:29 | |
| *** KunalGandhi has joined #openstack-horizon | 02:29 | |
| *** KunalGan_ has joined #openstack-horizon | 02:34 | |
| *** KunalGandhi has quit IRC | 02:35 | |
| *** Kunal has quit IRC | 02:35 | |
| *** drupalmonkey has quit IRC | 02:41 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: auto-file-discovery - apply to jasmine runner https://review.openstack.org/189997 | 02:46 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Apply auto-file-discovery to _10_project https://review.openstack.org/190038 | 02:47 |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 02:52 |
| *** julim has joined #openstack-horizon | 02:58 | |
| *** stevemar has joined #openstack-horizon | 03:09 | |
| *** julim has quit IRC | 03:09 | |
| *** kiran-r has joined #openstack-horizon | 03:12 | |
| *** annashen has joined #openstack-horizon | 03:13 | |
| *** jpomero has quit IRC | 03:16 | |
| *** yingjun has quit IRC | 03:18 | |
| *** annashen has quit IRC | 03:19 | |
| *** mwhagedorn has quit IRC | 03:23 | |
| *** lblanchard has joined #openstack-horizon | 03:29 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 03:36 |
| *** stevemar has quit IRC | 03:41 | |
| *** stevemar2 has joined #openstack-horizon | 03:41 | |
| *** fifieldt has joined #openstack-horizon | 03:42 | |
| *** dguerri` is now known as dguerri | 03:44 | |
| *** kiran-r has quit IRC | 03:45 | |
| *** kiran-r has joined #openstack-horizon | 03:51 | |
| *** lblanchard has quit IRC | 03:54 | |
| *** dguerri is now known as dguerri` | 03:54 | |
| *** kiranr has joined #openstack-horizon | 03:55 | |
| *** kiran-r has quit IRC | 03:55 | |
| *** kiranr has quit IRC | 04:02 | |
| *** fedexo has joined #openstack-horizon | 04:03 | |
| *** mohankumar has quit IRC | 04:05 | |
| *** annashen has joined #openstack-horizon | 04:09 | |
| *** annashen has quit IRC | 04:11 | |
| *** stevemar2 has quit IRC | 04:12 | |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 04:13 |
| *** mohankumar has joined #openstack-horizon | 04:14 | |
| *** Sukhdev has joined #openstack-horizon | 04:19 | |
| *** neillc_away is now known as neillc | 04:25 | |
| *** mohankumar has quit IRC | 04:32 | |
| *** KunalGan_ has quit IRC | 04:34 | |
| *** annashen has joined #openstack-horizon | 04:40 | |
| *** annashen has quit IRC | 04:42 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 04:57 |
| *** chlong is now known as chlong_mtg | 04:59 | |
| *** kiran-r has joined #openstack-horizon | 05:17 | |
| *** kiran-r has quit IRC | 05:21 | |
| *** kiran-r has joined #openstack-horizon | 05:21 | |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 05:55 |
| *** vishwana_ has quit IRC | 05:58 | |
| *** jtomasek has joined #openstack-horizon | 06:00 | |
| *** vishwanathj has joined #openstack-horizon | 06:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/190942 | 06:02 |
| *** chlong_mtg is now known as chlong | 06:06 | |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add discription field in the user table https://review.openstack.org/190944 | 06:11 |
| *** yingjun has joined #openstack-horizon | 06:11 | |
| *** amotoki has joined #openstack-horizon | 06:16 | |
| *** Sukhdev has quit IRC | 06:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/190947 | 06:21 |
| *** mrunge has joined #openstack-horizon | 06:23 | |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 06:24 |
| *** KunalGandhi has joined #openstack-horizon | 06:32 | |
| *** oro has joined #openstack-horizon | 06:33 | |
| *** Kunal has joined #openstack-horizon | 06:34 | |
| *** KunalGandhi has quit IRC | 06:39 | |
| *** KunalGandhi has joined #openstack-horizon | 06:39 | |
| *** belmoreira has joined #openstack-horizon | 06:40 | |
| *** KunalGandhi has quit IRC | 06:43 | |
| *** Kunal has quit IRC | 06:44 | |
| *** Guest____ has joined #openstack-horizon | 06:45 | |
| *** amotoki has quit IRC | 06:47 | |
| *** amotoki has joined #openstack-horizon | 06:50 | |
| *** Guest____ is now known as jcoufal | 06:51 | |
| *** jcoufal is now known as Guest76410 | 06:51 | |
| *** Guest76410 has quit IRC | 06:53 | |
| *** alexvictorchan has quit IRC | 06:53 | |
| *** jcoufal_ has joined #openstack-horizon | 06:53 | |
| *** romainh has joined #openstack-horizon | 06:56 | |
| *** TravT_ has joined #openstack-horizon | 07:06 | |
| *** Ala has joined #openstack-horizon | 07:07 | |
| *** markus_z has joined #openstack-horizon | 07:14 | |
| *** fedexo has quit IRC | 07:15 | |
| *** fedexo has joined #openstack-horizon | 07:16 | |
| *** MaxV has joined #openstack-horizon | 07:19 | |
| *** oro has quit IRC | 07:20 | |
| *** lhcheng_ has quit IRC | 07:21 | |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add discription field in the user table https://review.openstack.org/190944 | 07:28 |
| mflobo | Morning guys, question: Do we have any dev-guide to write Horizon panels based on AngularJS. | 07:29 |
| mflobo | ? | 07:29 |
| mrunge | mflobo, only the stuff covered in http://docs.openstack.org/developer/horizon/contributing.html | 07:31 |
| mrunge | if that's not sufficient, faulty, whatever, please file a bug | 07:31 |
| mrunge | honestly! | 07:31 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Add Model Block Device Test https://review.openstack.org/188967 | 07:34 |
| mflobo | mrunge, thanks, but for me is not enough. Maybe because I'm very new in AngularJS, but I was looking for a guide like: "For create a new panel in Horizon using AngularJS, you should start with bla, bla, bla" | 07:38 |
| mflobo | mrunge, something like http://docs.openstack.org/developer/horizon/topics/tutorial.html but for AngularJS | 07:38 |
| mrunge | mflobo, it's been promised since paris summit. but unfortunately, nobody came up with such a tutorial | 07:40 |
| mflobo | mrunge, mmmm, I understand... | 07:41 |
| mrunge | mflobo, I was not kidding with opening a bug | 07:41 |
| mflobo | mrunge, yep, I think I'll do | 07:41 |
| mrunge | thank you mflobo | 07:41 |
| mflobo | mrunge, thanks again for your support! | 07:41 |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:44 | |
| *** fedexo has quit IRC | 07:56 | |
| mflobo | mrunge, I've found an opened bug report! https://review.openstack.org/#/c/182243/5 | 07:57 |
| mflobo | mrunge, but is still WIP, so I think I'll shake it ;) | 07:58 |
| *** ygbo has joined #openstack-horizon | 07:59 | |
| mrunge | mflobo, thanks for sharing | 08:01 |
| mrunge | you might even want to read through the review and give feedback there | 08:01 |
| mflobo | mrunge, I'll do for sure | 08:02 |
| *** ZZelle has quit IRC | 08:02 | |
| mrunge | I'm quite sure, robcresswell will do the best he can on improving docs | 08:02 |
| *** ZZelle has joined #openstack-horizon | 08:02 | |
| *** TravT_ has quit IRC | 08:09 | |
| openstackgerrit | Merged openstack/horizon: Removing unused file references in Jasmine https://review.openstack.org/190830 | 08:11 |
| *** erelwell has joined #openstack-horizon | 08:13 | |
| *** yingjun has quit IRC | 08:14 | |
| *** kiranr has joined #openstack-horizon | 08:15 | |
| *** kiran-r has quit IRC | 08:15 | |
| *** kiranr has quit IRC | 08:15 | |
| ekarlso | mflobo: you doing panels in angular ? | 08:15 |
| *** kiranr has joined #openstack-horizon | 08:16 | |
| *** chlong is now known as chlong_afk | 08:16 | |
| mflobo | ekarlso, I'm planing to create/re-write someone | 08:16 |
| openstackgerrit | Merged openstack/horizon: Add no-cache directive when generating keypair https://review.openstack.org/189904 | 08:18 |
| *** kiranr is now known as kiran-r | 08:18 | |
| ekarlso | mflobo: I was linked https://review.openstack.org/#/c/133767/ as a example before :) | 08:20 |
| *** yingjun has joined #openstack-horizon | 08:22 | |
| mflobo | ekarlso, Thank you for share | 08:23 |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add discription field in the user table https://review.openstack.org/190944 | 08:35 |
| *** e0ne has joined #openstack-horizon | 08:38 | |
| *** oro has joined #openstack-horizon | 08:39 | |
| *** bluex-pl has joined #openstack-horizon | 08:50 | |
| *** esp has quit IRC | 08:52 | |
| *** esp has joined #openstack-horizon | 08:53 | |
| *** e0ne has quit IRC | 08:57 | |
| *** yingjun has quit IRC | 09:03 | |
| *** chlong_afk has quit IRC | 09:03 | |
| *** dguerri` is now known as dguerri | 09:05 | |
| *** JeanBriceCombebi has quit IRC | 09:07 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:08 | |
| *** yingjun has joined #openstack-horizon | 09:20 | |
| *** aix has joined #openstack-horizon | 09:22 | |
| *** tosky has joined #openstack-horizon | 09:23 | |
| *** mwhagedorn has joined #openstack-horizon | 09:35 | |
| *** yingjun has quit IRC | 09:38 | |
| *** akrivoka has joined #openstack-horizon | 09:49 | |
| *** romainh has quit IRC | 09:50 | |
| *** akrivoka has quit IRC | 09:51 | |
| *** akrivoka has joined #openstack-horizon | 09:51 | |
| *** bluex-pl has quit IRC | 09:58 | |
| *** aix has quit IRC | 10:00 | |
| *** bluex-pl has joined #openstack-horizon | 10:02 | |
| *** bluex-pl has quit IRC | 10:02 | |
| *** bluex-pl has joined #openstack-horizon | 10:03 | |
| *** bluex-pl has quit IRC | 10:03 | |
| *** bluex-pl has joined #openstack-horizon | 10:04 | |
| *** e0ne has joined #openstack-horizon | 10:04 | |
| *** e0ne is now known as e0ne_ | 10:04 | |
| *** e0ne_ is now known as e0ne | 10:06 | |
| *** alexpilotti has joined #openstack-horizon | 10:09 | |
| *** romainh has joined #openstack-horizon | 10:10 | |
| *** eandersson has joined #openstack-horizon | 10:10 | |
| *** akrivoka has quit IRC | 10:15 | |
| eandersson | Hey! Anyone familiar with the domain scoped token patches? | 10:17 |
| *** akrivoka has joined #openstack-horizon | 10:18 | |
| *** Miouge has joined #openstack-horizon | 10:20 | |
| *** akrivoka has quit IRC | 10:23 | |
| *** romainh has quit IRC | 10:27 | |
| *** aix has joined #openstack-horizon | 10:28 | |
| *** akrivoka has joined #openstack-horizon | 10:31 | |
| openstackgerrit | Ryan Brady proposed openstack/tuskar-ui: Adds network configuration (WIP) https://review.openstack.org/189473 | 10:32 |
| *** mwhagedorn has quit IRC | 10:38 | |
| *** Miouge has left #openstack-horizon | 10:40 | |
| *** MaxV has quit IRC | 10:41 | |
| *** fifieldt has quit IRC | 10:58 | |
| *** yamamoto has quit IRC | 11:01 | |
| *** bluex-pl has quit IRC | 11:04 | |
| *** bluex-pl has joined #openstack-horizon | 11:05 | |
| *** bluex-pl has quit IRC | 11:05 | |
| *** bluex-pl has joined #openstack-horizon | 11:05 | |
| *** romainh has joined #openstack-horizon | 11:09 | |
| *** vijendar has joined #openstack-horizon | 11:38 | |
| *** e0ne is now known as e0ne_ | 11:38 | |
| *** JeanBriceCombebi has quit IRC | 11:38 | |
| *** vijendar has quit IRC | 11:41 | |
| *** vijendar has joined #openstack-horizon | 11:41 | |
| *** yamamoto has joined #openstack-horizon | 11:42 | |
| *** yamamoto_ has joined #openstack-horizon | 11:42 | |
| *** yamamoto has quit IRC | 11:47 | |
| *** e0ne_ has quit IRC | 11:49 | |
| *** ducttape_ has joined #openstack-horizon | 11:58 | |
| *** zhenguo has quit IRC | 11:58 | |
| *** mrunge has quit IRC | 12:00 | |
| *** vijendar has quit IRC | 12:01 | |
| *** lblanchard has joined #openstack-horizon | 12:02 | |
| *** oro has quit IRC | 12:11 | |
| robcresswell | mflobo: I'm working on it :p The new panels part still needs some work, I aaw your comment. Will update that today. | 12:12 |
| mflobo | robcresswell, thanks | 12:13 |
| robcresswell | saw** | 12:13 |
| openstackgerrit | svasheka proposed openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 12:13 |
| mflobo | robcresswell, by the way, you are doing a very good and important work with that documentation ;) | 12:17 |
| *** ducttape_ has quit IRC | 12:17 | |
| *** julim has joined #openstack-horizon | 12:19 | |
| *** lblanchard has quit IRC | 12:20 | |
| *** lblanchard has joined #openstack-horizon | 12:22 | |
| robcresswell | mflobo: Thanks! | 12:22 |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:25 | |
| ekarlso | robcresswell: you doing some panels in angular ? | 12:26 |
| *** raildo has joined #openstack-horizon | 12:27 | |
| robcresswell | ekarlso: I have one in the works, but it isn't absolute top priority, so will likely show up around July, I imagine. Working on Network details. | 12:28 |
| robcresswell | ekarlso: Generally would like to work on Networks/ Routing/ Firewalls tablets and details page. | 12:29 |
| robcresswell | But depends on time. First aim is to finish docs so new people can stop wandering around in the dark. | 12:29 |
| robcresswell | Then to rip out the Cisco-specific Router dashboard :) | 12:29 |
| ekarlso | robcresswell: aweosme :p | 12:29 |
| *** josecastroleon has joined #openstack-horizon | 12:30 | |
| robcresswell | ekarlso: If there's anything you think needs documenting, or that I have done wrong, feel free to comment! :) https://review.openstack.org/#/c/182243/ | 12:31 |
| openstackgerrit | svasheka proposed openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 12:31 |
| *** doug-fish has joined #openstack-horizon | 12:35 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/190947 | 12:40 |
| *** MaxV has joined #openstack-horizon | 12:45 | |
| robcresswell | mrunge: Amongst some of the npm changes, you pointed out a regression, but I didnt have time to follow up on it. Do you have a bug for it? | 12:48 |
| robcresswell | mrunge: I think it was related to using run_tests offline, but I may be mistaken | 12:49 |
| *** matt-borland has joined #openstack-horizon | 12:50 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 12:51 |
| *** _crobertsrh is now known as crobertsrh | 12:56 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 12:57 |
| *** nlahouti has joined #openstack-horizon | 12:58 | |
| *** nlahouti has quit IRC | 12:58 | |
| *** e0ne has joined #openstack-horizon | 13:01 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 13:02 |
| *** dboik has joined #openstack-horizon | 13:02 | |
| *** jtriley has joined #openstack-horizon | 13:06 | |
| *** dboik has quit IRC | 13:07 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 13:07 |
| *** davidmichaelkarr has quit IRC | 13:07 | |
| *** htruta has joined #openstack-horizon | 13:07 | |
| *** ducttape_ has joined #openstack-horizon | 13:08 | |
| *** jprovazn has joined #openstack-horizon | 13:09 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 13:13 |
| *** davidmichaelkarr has joined #openstack-horizon | 13:14 | |
| *** peristeri has joined #openstack-horizon | 13:15 | |
| *** ducttape_ has quit IRC | 13:15 | |
| *** ducttape_ has joined #openstack-horizon | 13:20 | |
| *** petertr7_away is now known as petertr7 | 13:20 | |
| *** dboik has joined #openstack-horizon | 13:28 | |
| *** ducttape_ has quit IRC | 13:29 | |
| *** jpomero has joined #openstack-horizon | 13:34 | |
| *** bradjones has quit IRC | 13:35 | |
| *** bradjones has joined #openstack-horizon | 13:38 | |
| *** bradjones has quit IRC | 13:38 | |
| *** bradjones has joined #openstack-horizon | 13:38 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS cleanup - openstack_dashboard/static/ https://review.openstack.org/187971 | 13:41 |
| *** drupalmonkey has joined #openstack-horizon | 13:44 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 13:49 |
| *** kiran-r has quit IRC | 13:49 | |
| *** tvanderwiel has joined #openstack-horizon | 13:50 | |
| *** mwhagedorn has joined #openstack-horizon | 13:57 | |
| *** lucas has joined #openstack-horizon | 13:59 | |
| *** sseago has quit IRC | 14:13 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 14:22 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal-wait-spinner https://review.openstack.org/189431 | 14:24 |
| *** sseago has joined #openstack-horizon | 14:25 | |
| *** yamamoto_ has quit IRC | 14:26 | |
| *** dscottsf has joined #openstack-horizon | 14:27 | |
| *** dscottsf has quit IRC | 14:28 | |
| *** Drago has joined #openstack-horizon | 14:28 | |
| *** Drago has quit IRC | 14:29 | |
| *** Drago has joined #openstack-horizon | 14:29 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for action-list https://review.openstack.org/188995 | 14:30 |
| *** JeanBriceCombebi has quit IRC | 14:33 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for charts https://review.openstack.org/188998 | 14:35 |
| *** tyr has joined #openstack-horizon | 14:37 | |
| rodrigods | doug-fish, ping... updated the k2k plugin review, can you check if it works for you now? | 14:39 |
| doug-fish | rodrigods: thanks! can't check it immediately but will spend time on it today | 14:41 |
| *** romainh has left #openstack-horizon | 14:41 | |
| rodrigods | doug-fish, awesome, thanks for testing it btw | 14:41 |
| doug-fish | np. Thanks for writing it. :-) | 14:41 |
| *** sjmc7 has joined #openstack-horizon | 14:42 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for metadata-display https://review.openstack.org/189074 | 14:43 |
| *** yamamoto has joined #openstack-horizon | 14:43 | |
| *** yamamoto has quit IRC | 14:43 | |
| *** jbell8 has joined #openstack-horizon | 14:45 | |
| *** mrunge has joined #openstack-horizon | 14:47 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for metadata-display https://review.openstack.org/189074 | 14:48 |
| *** ongk has joined #openstack-horizon | 14:48 | |
| *** e0ne is now known as e0ne_ | 14:49 | |
| erelwell | Hi all! Having a quiet afternoon so do ping me if there are any FE code reviews you specifically want looked at! | 14:52 |
| *** erelwell is now known as bethelwell | 14:53 | |
| *** e0ne_ is now known as e0ne | 14:55 | |
| *** Ala has quit IRC | 14:56 | |
| *** htruta has quit IRC | 14:59 | |
| *** yamamoto has joined #openstack-horizon | 15:00 | |
| *** lucas has quit IRC | 15:01 | |
| *** jcoufal_ has quit IRC | 15:07 | |
| *** belmoreira has quit IRC | 15:10 | |
| *** bpokorny has joined #openstack-horizon | 15:16 | |
| *** e0ne is now known as e0ne_ | 15:18 | |
| *** lucas has joined #openstack-horizon | 15:19 | |
| *** zhenguo has joined #openstack-horizon | 15:20 | |
| ongk | krotscheck: was there a decision on linters and which to keep? | 15:23 |
| *** lucas has quit IRC | 15:24 | |
| *** lucas has joined #openstack-horizon | 15:24 | |
| *** e0ne_ is now known as e0ne | 15:27 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Fix image filtering in create node form https://review.openstack.org/191114 | 15:27 |
| *** hurgleburgler has joined #openstack-horizon | 15:33 | |
| *** petertr7 is now known as petertr7_away | 15:34 | |
| *** nlahouti has joined #openstack-horizon | 15:37 | |
| *** petertr7_away is now known as petertr7 | 15:38 | |
| bethelwell | ongk: as I understand from the last on the subject the following was suggested "start with the Google Style Guidelines, and let projects use plugins (like eslint-angular) to support additional project guidelines." | 15:39 |
| *** absubram has joined #openstack-horizon | 15:41 | |
| bethelwell | the email prior to this though suggested a 4 step rule basis starting with John Papa, otherwise pep8, otherwise thing in hacking, if none of them on case by case basis but I think that was overridden by the email re Google Style Guidelines | 15:41 |
| bethelwell | krotscheck: ^^^ is that the final decision on that or is it waiting on further discussion? | 15:41 |
| *** absubram has quit IRC | 15:42 | |
| *** absubram has joined #openstack-horizon | 15:43 | |
| ongk | thx bethelwell | 15:43 |
| bethelwell | welcome :) | 15:46 |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for modal-wait-spinner https://review.openstack.org/189431 | 15:46 |
| *** clu has joined #openstack-horizon | 15:48 | |
| *** lucas has quit IRC | 15:54 | |
| *** belmoreira has joined #openstack-horizon | 15:55 | |
| *** belmoreira has quit IRC | 15:55 | |
| *** masco has joined #openstack-horizon | 15:58 | |
| *** KunalGandhi has joined #openstack-horizon | 16:03 | |
| *** Kunal has joined #openstack-horizon | 16:03 | |
| *** jtriley has quit IRC | 16:05 | |
| *** wuhg has joined #openstack-horizon | 16:05 | |
| *** lucas___ has joined #openstack-horizon | 16:06 | |
| *** lucas___ has quit IRC | 16:10 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 16:13 |
| *** lucas has joined #openstack-horizon | 16:14 | |
| *** bluex-pl has quit IRC | 16:14 | |
| *** kiran-r has joined #openstack-horizon | 16:14 | |
| *** bluex-pl has joined #openstack-horizon | 16:14 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 16:15 |
| *** KunalGandhi has quit IRC | 16:16 | |
| *** jbell8 has quit IRC | 16:16 | |
| *** lucas has quit IRC | 16:19 | |
| *** Kunal has quit IRC | 16:20 | |
| *** alexvictorchan has joined #openstack-horizon | 16:21 | |
| *** dguerri is now known as dguerri` | 16:22 | |
| *** htruta has joined #openstack-horizon | 16:22 | |
| *** masco has quit IRC | 16:23 | |
| *** e0ne has quit IRC | 16:24 | |
| *** gyee_ has joined #openstack-horizon | 16:28 | |
| *** MaxV has quit IRC | 16:30 | |
| *** ygbo has quit IRC | 16:31 | |
| ongk | bradjones: I’d like to help out with the Magnum web UI. Is there a list I can add myself to? | 16:34 |
| *** petertr7 is now known as petertr7_away | 16:35 | |
| *** zhenguo has quit IRC | 16:35 | |
| robcresswell | ongk: I think just get involved when the repo is up. May be worth replying to the mailer if you were wanting to be core for magnum-ui, though. | 16:38 |
| ongk | k, thanks robcresswell | 16:39 |
| robcresswell | ongk: No probs. I'll be reviewing too, though not sure how much time I'll have for writing code. | 16:40 |
| robcresswell | ongk: Would be nice to make it a mostly angular project, though we'll see how that goes. | 16:41 |
| ongk | robcresswell: i’ll keep a lookout. I’m interested in anything that uses D3 :) | 16:41 |
| *** KunalGandhi has joined #openstack-horizon | 16:45 | |
| *** bluex-pl has quit IRC | 16:45 | |
| *** Sukhdev has joined #openstack-horizon | 16:46 | |
| *** lhcheng has joined #openstack-horizon | 16:49 | |
| *** lhcheng has quit IRC | 16:51 | |
| *** bethelwell has quit IRC | 16:53 | |
| *** lucas___ has joined #openstack-horizon | 16:53 | |
| robcresswell | ongk: Ahh I see. You might be fighting with bradjones for that work then :p | 16:53 |
| *** dscottsf has joined #openstack-horizon | 17:00 | |
| *** dscottsf has quit IRC | 17:02 | |
| *** garthb_ has joined #openstack-horizon | 17:02 | |
| *** garthb has joined #openstack-horizon | 17:02 | |
| *** mwhagedorn has quit IRC | 17:05 | |
| *** mwhagedorn has joined #openstack-horizon | 17:06 | |
| *** lucas___ has quit IRC | 17:07 | |
| *** mwhagedorn has left #openstack-horizon | 17:09 | |
| *** lucas___ has joined #openstack-horizon | 17:09 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 17:10 |
| *** kiran-r has quit IRC | 17:10 | |
| *** jprovazn has quit IRC | 17:11 | |
| *** markus_z has quit IRC | 17:13 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 17:14 |
| *** lhcheng has joined #openstack-horizon | 17:15 | |
| *** yamamoto has quit IRC | 17:17 | |
| *** eandersson has quit IRC | 17:20 | |
| *** TravT_ has joined #openstack-horizon | 17:21 | |
| *** tvanderwiel has quit IRC | 17:22 | |
| *** gyee_ has quit IRC | 17:23 | |
| *** yamamoto has joined #openstack-horizon | 17:25 | |
| *** yamamoto has quit IRC | 17:27 | |
| *** wznoinsk has joined #openstack-horizon | 17:27 | |
| *** yamamoto has joined #openstack-horizon | 17:27 | |
| *** Sukhdev has quit IRC | 17:27 | |
| *** petertr7_away is now known as petertr7 | 17:33 | |
| *** Sukhdev has joined #openstack-horizon | 17:33 | |
| krotscheck | ongk: It's ongoing at the moment. There's some discussion on exactly how some of these things get persisted through openstack. There are... opinionated persons in the infra world that don't want to overload the global requirements repository with linting rules. | 17:37 |
| *** radez_g0n3 is now known as radez | 17:38 | |
| *** jwy has joined #openstack-horizon | 17:39 | |
| *** amotoki has quit IRC | 17:41 | |
| *** jingjing_ren has joined #openstack-horizon | 17:43 | |
| *** kiran-r has joined #openstack-horizon | 17:43 | |
| *** Drago has quit IRC | 17:45 | |
| openstackgerrit | Doug Fish proposed openstack/django_openstack_auth: WIP: Sample keystone client usage for k2k federation https://review.openstack.org/160851 | 17:46 |
| doug-fish | rodrigods: I tried out your patch and it solves the immediate problem. Thanks! | 17:46 |
| doug-fish | I'm having trouble with the next step -- listing projects on the remote sp. Not sure where things are failing yet. | 17:47 |
| *** ybathia has joined #openstack-horizon | 17:48 | |
| rodrigods | doug-fish, nice, can you put the trace in a paste? also would be nice to see the token response | 17:48 |
| *** annashen has joined #openstack-horizon | 17:48 | |
| *** Sukhdev has quit IRC | 17:56 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Utils for auto-file-discovery https://review.openstack.org/183364 | 17:56 |
| *** gyee_ has joined #openstack-horizon | 17:57 | |
| *** bpokorny_ has joined #openstack-horizon | 17:58 | |
| *** e0ne has joined #openstack-horizon | 18:00 | |
| *** annashen has quit IRC | 18:00 | |
| *** bpokorn__ has joined #openstack-horizon | 18:01 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Rename files to enable auto-file-discovery https://review.openstack.org/190028 | 18:01 |
| *** jingjing_ren has quit IRC | 18:01 | |
| *** annashen has joined #openstack-horizon | 18:01 | |
| *** bpokorny has quit IRC | 18:02 | |
| *** bpokorny_ has quit IRC | 18:04 | |
| *** Ephur has joined #openstack-horizon | 18:04 | |
| *** jingjing_ren has joined #openstack-horizon | 18:04 | |
| *** tosky has quit IRC | 18:12 | |
| *** e0ne has quit IRC | 18:13 | |
| *** TravT_ has quit IRC | 18:14 | |
| *** yamamoto has quit IRC | 18:15 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 18:16 |
| *** Sukhdev has joined #openstack-horizon | 18:19 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP - injectjs - a Django command to inject JS https://review.openstack.org/189415 | 18:19 |
| *** e0ne has joined #openstack-horizon | 18:19 | |
| openstackgerrit | Jingjing Ren proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 18:22 |
| *** aix has quit IRC | 18:22 | |
| openstackgerrit | Ana Krivokapic proposed openstack/horizon: Remove "More Projects" link from the header https://review.openstack.org/191174 | 18:24 |
| *** e0ne is now known as e0ne_ | 18:25 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 18:25 |
| akrivoka | bug #1399126 now breaks the gate test for tuskar-ui | 18:26 |
| openstack | bug 1399126 in OpenStack Dashboard (Horizon) "identity panel link in header" [Critical,In progress] https://launchpad.net/bugs/1399126 - Assigned to Ana Krivokapić (akrivoka) | 18:26 |
| akrivoka | I have posted a patch to remove the "More Projects" link https://review.openstack.org/#/c/191174 | 18:26 |
| akrivoka | please review this asap as it is blocking us completely | 18:27 |
| *** jbell8 has joined #openstack-horizon | 18:28 | |
| *** jingjin__ has joined #openstack-horizon | 18:29 | |
| *** kiran-r has quit IRC | 18:30 | |
| *** e0ne_ has quit IRC | 18:30 | |
| *** jingjing_ren has quit IRC | 18:30 | |
| *** tvanderwiel has joined #openstack-horizon | 18:33 | |
| *** annashen has quit IRC | 18:43 | |
| *** TravT_ has joined #openstack-horizon | 18:48 | |
| *** ZZelle_ has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: auto-file-discovery - apply to jasmine runner https://review.openstack.org/189997 | 18:52 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Apply auto-file-discovery to _10_project https://review.openstack.org/190038 | 18:53 |
| *** wuhg has quit IRC | 19:04 | |
| *** petertr7 is now known as petertr7_away | 19:05 | |
| *** petertr7_away is now known as petertr7 | 19:05 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 19:06 |
| *** dontalton has joined #openstack-horizon | 19:09 | |
| *** e0ne has joined #openstack-horizon | 19:09 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 19:14 |
| *** yamamoto has joined #openstack-horizon | 19:15 | |
| *** tqtran has joined #openstack-horizon | 19:16 | |
| *** e0ne is now known as e0ne_ | 19:18 | |
| *** yamamoto has quit IRC | 19:21 | |
| *** ybathia has quit IRC | 19:21 | |
| *** e0ne_ is now known as e0ne | 19:22 | |
| *** jingjin__ has quit IRC | 19:27 | |
| *** Drago has joined #openstack-horizon | 19:29 | |
| *** Drago has quit IRC | 19:30 | |
| *** Drago has joined #openstack-horizon | 19:30 | |
| *** lucas___ has quit IRC | 19:33 | |
| *** absubram has quit IRC | 19:37 | |
| *** lhcheng has quit IRC | 19:37 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for transfer-table https://review.openstack.org/191200 | 19:38 |
| *** dboik has quit IRC | 19:39 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 19:42 |
| *** jbell8 has quit IRC | 19:44 | |
| *** zz_ttrifonov is now known as ttrifonov | 19:46 | |
| *** dontalton has quit IRC | 19:52 | |
| *** sjmc7 has quit IRC | 19:54 | |
| *** dboik_ has joined #openstack-horizon | 19:56 | |
| *** jingjing_ren has joined #openstack-horizon | 19:59 | |
| *** lhcheng has joined #openstack-horizon | 19:59 | |
| *** mwhagedorn_ has joined #openstack-horizon | 20:01 | |
| *** petertr7 is now known as petertr7_away | 20:01 | |
| *** nlahouti has quit IRC | 20:03 | |
| *** petertr7_away is now known as petertr7 | 20:04 | |
| *** dboik_ has quit IRC | 20:07 | |
| *** SlickNik has quit IRC | 20:07 | |
| *** NikitaKonovalov has quit IRC | 20:07 | |
| *** csd has quit IRC | 20:07 | |
| *** dboik has joined #openstack-horizon | 20:08 | |
| *** SlickNik has joined #openstack-horizon | 20:08 | |
| *** mwhagedorn_ has left #openstack-horizon | 20:09 | |
| *** EmilienM is now known as EmilienM|afk | 20:10 | |
| *** csd has joined #openstack-horizon | 20:11 | |
| *** NikitaKonovalov has joined #openstack-horizon | 20:12 | |
| *** jingjin__ has joined #openstack-horizon | 20:16 | |
| *** ongk has quit IRC | 20:18 | |
| *** Sukhdev has quit IRC | 20:19 | |
| *** e0ne has quit IRC | 20:19 | |
| *** dboik has quit IRC | 20:19 | |
| *** jingjing_ren has quit IRC | 20:20 | |
| *** greghaynes has quit IRC | 20:27 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 20:28 |
| *** crobertsrh is now known as _crobertsrh | 20:29 | |
| *** mrunge has quit IRC | 20:30 | |
| akrivoka | we need +A here to unblock the tuskar-ui gate, please review if you have a moment https://review.openstack.org/#/c/191174/ | 20:32 |
| *** radez is now known as radez_g0n3 | 20:34 | |
| *** alexpilotti has quit IRC | 20:35 | |
| *** TravT_ has quit IRC | 20:36 | |
| *** alexpilotti has joined #openstack-horizon | 20:36 | |
| *** sjmc7 has joined #openstack-horizon | 20:39 | |
| *** htruta has quit IRC | 20:41 | |
| *** raildo has quit IRC | 20:46 | |
| *** ybathia has joined #openstack-horizon | 20:47 | |
| *** dboik has joined #openstack-horizon | 20:49 | |
| *** nlahouti has joined #openstack-horizon | 20:52 | |
| *** jingjin__ has quit IRC | 20:52 | |
| *** TravT_ has joined #openstack-horizon | 20:53 | |
| *** jingjing_ren has joined #openstack-horizon | 20:54 | |
| *** lhcheng has quit IRC | 20:54 | |
| *** TravT_ has quit IRC | 20:54 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Utils folder (partial) https://review.openstack.org/191213 | 20:55 |
| *** bpokorn__ has quit IRC | 20:56 | |
| *** bpokorny has joined #openstack-horizon | 20:56 | |
| *** ongk has joined #openstack-horizon | 20:58 | |
| *** peristeri has quit IRC | 21:00 | |
| *** ttrifonov is now known as zz_ttrifonov | 21:00 | |
| *** petertr7 is now known as petertr7_away | 21:07 | |
| *** akrivoka has quit IRC | 21:12 | |
| *** vishwanathj has quit IRC | 21:13 | |
| *** vishwanathj has joined #openstack-horizon | 21:13 | |
| *** asahlin has quit IRC | 21:15 | |
| *** rbertram has quit IRC | 21:15 | |
| *** asahlin has joined #openstack-horizon | 21:16 | |
| *** rbertram has joined #openstack-horizon | 21:16 | |
| *** dguerri` is now known as dguerri | 21:17 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Utils folder (partial) https://review.openstack.org/191213 | 21:22 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Angularize Identity Projects Panel https://review.openstack.org/191225 | 21:24 |
| *** Sukhdev has joined #openstack-horizon | 21:25 | |
| *** doug-fish has left #openstack-horizon | 21:26 | |
| *** matt-borland has quit IRC | 21:27 | |
| tqtran | david-lyle, TravT: https://review.openstack.org/#/c/190852/ | 21:29 |
| tqtran | some initial work to get the angular dashboard setup | 21:29 |
| tqtran | I broke the identity patch into smaller consumable pieces, so sooner we get the stuff in, the better | 21:29 |
| tqtran | TravT: also if you can bug your infra friends, https://review.openstack.org/#/c/189507/ that would really help | 21:29 |
| *** gyee_ has quit IRC | 21:33 | |
| *** jingjing_ren has quit IRC | 21:37 | |
| *** dboik has quit IRC | 21:38 | |
| *** cbader has quit IRC | 21:39 | |
| *** lblanchard has quit IRC | 21:39 | |
| -openstackstatus- NOTICE: Gerrit will be offline for project renames between 22:00 and 22:30 UTC | 21:42 | |
| *** ChanServ changes topic to "Gerrit will be offline for project renames between 22:00 and 22:30 UTC" | 21:42 | |
| *** jingjing_ren has joined #openstack-horizon | 21:53 | |
| *** Raildo has joined #openstack-horizon | 21:59 | |
| -openstackstatus- NOTICE: Gerrit is offline for project renames. ETA 20:30 | 22:03 | |
| *** ChanServ changes topic to "Gerrit is offline for project renames. ETA 20:30" | 22:03 | |
| *** tvanderwiel has quit IRC | 22:07 | |
| -openstackstatus- NOTICE: Gerrit is offline for project renames. ETA 22:40 | 22:08 | |
| *** ChanServ changes topic to "Gerrit is offline for project renames. ETA 22:40" | 22:08 | |
| *** drupalmonkey has quit IRC | 22:15 | |
| *** TravT_ has joined #openstack-horizon | 22:38 | |
| r1chardj0n3s | tqtran: around? | 22:39 |
| r1chardj0n3s | I'll just comment on the patch ;) | 22:40 |
| *** clu has quit IRC | 22:41 | |
| *** ChanServ changes topic to "Gerrit is offline for project renames. ETA 20:30" | 22:42 | |
| -openstackstatus- NOTICE: Gerrit is back online. Zuul reconfiguration for renamed projects is still in progress, ETA 23:30. | 22:42 | |
| *** garthb_ has quit IRC | 22:43 | |
| *** garthb has quit IRC | 22:43 | |
| *** clu has joined #openstack-horizon | 22:43 | |
| tqtran | r1chardj0n3s: wasup? | 22:43 |
| r1chardj0n3s | too late! I commented ;) | 22:43 |
| r1chardj0n3s | https://review.openstack.org/#/c/190852/2 | 22:43 |
| r1chardj0n3s | just mulling over how optional panels are going to work in angularjs space | 22:44 |
| tqtran | not sure i following what you're saying | 22:45 |
| tqtran | right now, the only way to include JS files in dashboard is via the enabled file | 22:46 |
| r1chardj0n3s | so the change in dashboard.module.js has hz.dashboard.identity added as a dependency | 22:46 |
| r1chardj0n3s | tqtran: right, so maybe we need to change that | 22:46 |
| r1chardj0n3s | since *disabling* that will break the dashboard module | 22:46 |
| tqtran | I believe that was already decided a while back, its the plugin architecture that we all agreed on | 22:46 |
| r1chardj0n3s | er, no, we still haven't solved the general case of stuff that always needs to be "enabled" | 22:47 |
| tqtran | well, if you want to disable it, just comment it out in the enabled file and you're good to go | 22:47 |
| r1chardj0n3s | there's one file that's just shoved into the settings.py directly, but that's a temporary measure as more files will be added | 22:47 |
| r1chardj0n3s | tqtran: no, because commenting out the enabled file *will break the dashboard module* | 22:48 |
| r1chardj0n3s | since the identity module will no longer be defined anywhere | 22:48 |
| r1chardj0n3s | since the JS it's defined in is no longer loaded | 22:48 |
| r1chardj0n3s | that's the point of my comment, though I didn't write it clearly enough ;) | 22:48 |
| tqtran | right, if you comment it out, the dashboard module will no longer depend on identity | 22:49 |
| tqtran | but it won't break it | 22:49 |
| r1chardj0n3s | of, you are also editing the dashboard.module.js? | 22:49 |
| r1chardj0n3s | to disable it? | 22:49 |
| tqtran | no need | 22:49 |
| r1chardj0n3s | wut | 22:49 |
| tqtran | oh..... | 22:49 |
| *** lhcheng has joined #openstack-horizon | 22:50 | |
| *** ChanServ changes topic to "OpenStack Horizon" | 22:50 | |
| r1chardj0n3s | no, the dashboard.module.js code requires that module 'hz.dashboard.identity' to be defined | 22:50 |
| tqtran | ok i get what you're saying | 22:50 |
| tqtran | um..hm... | 22:50 |
| r1chardj0n3s | right, and that's my Friday afternoon (evening?) present to you :) | 22:50 |
| r1chardj0n3s | (hey, it's Saturday morning here ;) | 22:50 |
| tqtran | lol | 22:50 |
| tqtran | ok so if you dont want to load identity for example | 22:51 |
| tqtran | you just need to disable it in dashboard.module | 22:51 |
| r1chardj0n3s | well, *and* any links to it, ... | 22:51 |
| tqtran | but you should also clean house in enabled file | 22:51 |
| r1chardj0n3s | I think TravT's feature enablement ideas might be appropriate here | 22:52 |
| tqtran | so thats two places you need to update, but only one is critical | 22:52 |
| tqtran | how would it fit in? | 22:52 |
| r1chardj0n3s | it'd be a central place to configure enabled things, and other code could use those settings | 22:52 |
| *** clu has quit IRC | 22:52 | |
| *** dsneddon has quit IRC | 22:52 | |
| r1chardj0n3s | including module JS which could optionally include dependencies | 22:52 |
| tqtran | hm... i see but it wouldn't look as nice | 22:53 |
| *** lhcheng_ has joined #openstack-horizon | 22:53 | |
| r1chardj0n3s | you're welcome to come up with another solution which doesn't involve editing 3+ files to enable/disable a feature ;) | 22:53 |
| tqtran | basically, its going to be like: if (something_is_enabled) dashboard.module.$inject.push(some_dashboard) | 22:53 |
| tqtran | and you | 22:54 |
| tqtran | will need to provide this if check in 2 places | 22:54 |
| tqtran | the enabled and dashboard file | 22:54 |
| *** dguerri is now known as dguerri` | 22:54 | |
| r1chardj0n3s | yep | 22:54 |
| tqtran | thats ugly | 22:54 |
| r1chardj0n3s | it's an ugly problem. we might come up with a better solution :) | 22:55 |
| tqtran | yeah i think we need something better | 22:55 |
| *** TravT_ has quit IRC | 22:55 | |
| r1chardj0n3s | but in the shorter term, we do need to come up with something that allows us to add panels *outside* of "enabled" | 22:55 |
| r1chardj0n3s | ... panels and the top-level app (which is the file that's now hard-coded into settings.py) | 22:55 |
| *** lhcheng has quit IRC | 22:55 | |
| *** clu has joined #openstack-horizon | 22:56 | |
| r1chardj0n3s | ... er, *will* be, when my patch lands | 22:56 |
| tqtran | ok, let me think about it | 22:56 |
| *** TravT_ has joined #openstack-horizon | 22:56 | |
| r1chardj0n3s | hm, actually, I might be wrong there. hm. | 22:56 |
| r1chardj0n3s | oh, that's right, I just include the always-included JS directly in _conf.html | 22:57 |
| r1chardj0n3s | duh | 22:57 |
| r1chardj0n3s | identity would also go there, if it's always on | 22:57 |
| tqtran | lol | 22:57 |
| tqtran | or it can always be in enabled | 22:57 |
| r1chardj0n3s | hey, it's early Saturday morning and I haven't even turned the heater on (and it's cold) gimme a break :) | 22:57 |
| tqtran | as default list | 22:57 |
| tqtran | and you can append to that list | 22:58 |
| tqtran | ok you know what, we dont need it atm, it should always be there | 22:58 |
| r1chardj0n3s | *shrug* yeah, but why have that in Python land when it doesn't need to (well, might not need to) | 22:58 |
| r1chardj0n3s | just edit it straight into _conf | 22:58 |
| tqtran | because its a dashboard, its not a framework thing | 22:58 |
| r1chardj0n3s | is what I'm about to write in the review | 22:58 |
| tqtran | plus, you would need to do it in 2 places | 22:58 |
| tqtran | jasmine.html needs it for testing too | 22:59 |
| r1chardj0n3s | yeah, *that* malarky is something I really want to look into soon | 22:59 |
| r1chardj0n3s | we've got way too much duplication of references like that. I'm not sure it can be solved, but I do want to look into it | 22:59 |
| tqtran | ok, i think we should leave it alone for now | 22:59 |
| *** Ephur has quit IRC | 22:59 | |
| tqtran | since identity is going to be a core dashboard, i think we can assume that it will always be there | 22:59 |
| r1chardj0n3s | yep | 23:00 |
| tqtran | basically, i dont wanna solve all of the problems right now, its going to hang progress on dashboard work | 23:00 |
| r1chardj0n3s | _conf.html comment added to the review | 23:00 |
| r1chardj0n3s | yup! | 23:00 |
| r1chardj0n3s | I'm turning the damned heater on | 23:00 |
| tqtran | so that means i need to manually add this to jasmine.html too? | 23:01 |
| tqtran | and what about the specs? | 23:01 |
| tqtran | thats going to get long and ugly really fast | 23:01 |
| *** Raildo has quit IRC | 23:02 | |
| r1chardj0n3s | mmm | 23:03 |
| *** jingjing_ren has quit IRC | 23:05 | |
| tqtran | my vote is to keep it in enabled for now | 23:05 |
| tqtran | until we have something cleaner | 23:05 |
| tqtran | as long as people don't modify the default list, we will be fine | 23:06 |
| r1chardj0n3s | it's tech debt either way, yah | 23:06 |
| tqtran | yeah, but i think it can/should be fix in a different patch | 23:06 |
| tqtran | the goal is to introduce a dashboard, not solve how we load them. and i really dont wanna tackle yet another infra thing, the dashboard needs to get in | 23:07 |
| r1chardj0n3s | yep! | 23:07 |
| tyr | tqtran: was a bit confused by the backscroll...but why do you need to modify dashboard.module.js? | 23:13 |
| tqtran | ok cool, just commented, if you can remove that -1, would really appreciate it :) | 23:13 |
| tqtran | tyr: well, in this case, you don't | 23:13 |
| tqtran | richard was just pointing out that in case you need to remove this dashboard in the future, you'll have to modify two files | 23:14 |
| tqtran | dashboard.module.js and enabled file | 23:14 |
| tqtran | but the enabled file is optional, since the JS file will get loaded but not accessible anywhere | 23:14 |
| tqtran | but the counter argument here is that the identity is going to be ship as a core horizon dashboard, so people shouldn't be messing with it anyway | 23:15 |
| tyr | if you place hz.dashboard.identity into the ADD_ANGULAR_MODULES section of the enabled file...it will get included into the top level application for you | 23:15 |
| tqtran | plus, that is how we're doing it today, and i see no reason to stall the dashboard work because of it. if there is a cleaner mechanism, lets add it and refactor this later to fit the new pattern | 23:16 |
| tqtran | tyr: yes that is true, but i think you're missing richard's point :P | 23:16 |
| tqtran | tyr: ok, let me see if i can be clearer. basically, you would need to modify dashboard.module.js when you want to remove/add dashboards. and yes, once you add it, it will be included at the top level/base.html | 23:19 |
| openstackgerrit | Merged openstack/horizon: JSCS cleanup - style guide cleanup for modal https://review.openstack.org/189460 | 23:19 |
| tqtran | however, say, i created my_custom_dashboard and i want to add/remove it. i would need to update two places, the dashboard.module.js and /enabled/_xx_my_custom_dashboard.py | 23:20 |
| tyr | horizon.dashboard-app module already includes a "concat(angularModuleExtension)" that will pull in any modules listed as requirements in the enabled files | 23:20 |
| tqtran | this isn't the most ideal solution, its a bit error prone and richard wants something more ideal | 23:21 |
| tqtran | tyr: right, understood | 23:21 |
| *** TravT_ has quit IRC | 23:21 | |
| *** openstackgerrit has quit IRC | 23:22 | |
| *** dsneddon has joined #openstack-horizon | 23:22 | |
| *** openstackgerrit has joined #openstack-horizon | 23:22 | |
| tqtran | now that i think about it some more, thats actually how angular works anyway. if you wanted to use some 3rd party angular module, you'll have to manually include the script in the html, and inject it as a dependency in the js | 23:22 |
| tqtran | so in a sense, thats kind of what we're doing here. maybe it can just be a documentation thing? if you modify stuff, and things break, well... its your own fault? or do we want to make it a bit more resilient? | 23:23 |
| *** Sukhdev has quit IRC | 23:25 | |
| tyr | I'm still confused. Unless you are providing something required by multiple dashboards (like the API files), the module and .js dependencies are handled for you from the enabled file. | 23:26 |
| tyr | I don't think there is any need to edit the dashboard.module.js to add a new dashboard. | 23:26 |
| tqtran | https://plus.google.com/hangouts/_/gudldqtgrc3elieu3th5j4cofea?hl=en | 23:26 |
| tqtran | can you hop on hangout? i'll try to explain in person | 23:27 |
| tyr | We don't yet have an elegant solution for things like the API files...but that is unrelated to what you are trying to do with identity. | 23:27 |
| tyr | Sure | 23:27 |
| *** hurgleburgler has quit IRC | 23:28 | |
| tyr | https://plus.google.com/hangouts/_/hp.com/Horizon-Team-902c777e-340 | 23:29 |
| tqtran | whoa | 23:29 |
| tqtran | you guys have your own hangout? | 23:29 |
| *** ybathia has quit IRC | 23:32 | |
| *** Sukhdev has joined #openstack-horizon | 23:38 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Utils folder (partial) https://review.openstack.org/191213 | 23:48 |
| *** zhenguo has joined #openstack-horizon | 23:48 | |
| *** jingjing_ren has joined #openstack-horizon | 23:54 | |
| *** ZZelle_ has quit IRC | 23:57 | |
| *** jingjing_ren has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!