| *** yamamoto has joined #openstack-horizon | 00:00 | |
| openstackgerrit | Jingjing Ren proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 00:02 |
|---|---|---|
| tqtran | neillc: ping | 00:03 |
| *** ozialien has quit IRC | 00:04 | |
| neillc | tqtran: sorry - in daily standup meeting. If you're still here in 15 minutes you'll get my full attention. | 00:04 |
| tqtran | neillc: ok ping me when done | 00:04 |
| neillc | tqtran: feel free to ask your question, kust may be a bit before I answer | 00:04 |
| tqtran | https://review.openstack.org/#/c/188665/7/run_tests.sh L442 regarding the OPTS, how were you able to discern that these are the opts that we need vs what we don't need? | 00:05 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 00:05 |
| tqtran | https://github.com/django/django/blob/master/django/core/management/commands/makemessages.py#L123 | 00:05 |
| *** dsneddon is now known as dsneddon_biab | 00:05 | |
| tqtran | these are the default options in django, where are the ones for babel-django? i couldn't find it in source | 00:06 |
| tqtran | also it seems like passing -l en is needed for some, while for others it is not? | 00:06 |
| *** alexvictorchan has quit IRC | 00:07 | |
| *** petertr7 is now known as petertr7_away | 00:08 | |
| *** bpokorny has quit IRC | 00:09 | |
| *** bpokorny has joined #openstack-horizon | 00:10 | |
| *** bpokorny has quit IRC | 00:14 | |
| neillc | tqtran: I disabled all of the opts. Ran the tests and checked for differences. Enabled opts one by one to see if they made a difference. Kept the set of opts that I found made a difference. | 00:25 |
| tqtran | omg lol | 00:25 |
| tqtran | ok, so you did it the painful way | 00:25 |
| neillc | yep | 00:26 |
| *** yamamoto has quit IRC | 00:26 | |
| tqtran | im gonna dig through the source and try to locate it | 00:26 |
| tqtran | this way, we know for sure in case we missed anything | 00:26 |
| neillc | that sounds like a good idea :) | 00:26 |
| tqtran | its entirely possible that there is a patter that is supported in django that we missed | 00:26 |
| tqtran | and wont be evident until someone tries to use and it fails | 00:26 |
| neillc | true. I think the initial set of options I used was taken from the django source. It is now just those that we seemed to be using. | 00:27 |
| neillc | my thought was that this is what we need now, if we start using something else it can be added to the opts later. | 00:27 |
| *** yingjun has joined #openstack-horizon | 00:28 | |
| neillc | seemed unlikely that we would need more in horizon, but who know what someone has done in a third party panel | 00:28 |
| tqtran | thats true | 00:28 |
| tqtran | maybe its ok for now, saves me some work lol | 00:28 |
| neillc | :) | 00:29 |
| tqtran | but regarding passing in the locale each time, i would assume that it is english by default? seems to work on some folders but not others | 00:29 |
| tqtran | this is very strange to m | 00:29 |
| *** Piet has joined #openstack-horizon | 00:30 | |
| neillc | that is a little odd. I would expect it's the default, but haven't verified that | 00:30 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 00:30 |
| Piet | Starting to add the presentations from research to the UX wiki. Take a look and let me know what you think. https://wiki.openstack.org/wiki/HorizonUsability_Testing#December_2014_Card_Sort | 00:30 |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 00:31 |
| neillc | tqtran: going to go poke at default locale stuff | 00:34 |
| *** kztsv_mbp has quit IRC | 00:34 | |
| tqtran | ok | 00:35 |
| *** tyr has joined #openstack-horizon | 00:37 | |
| neillc | tqtran: so, I am always passing -l en to pybabel update. pybabel extract does not take a locale parameter. | 00:38 |
| neillc | tqtran: am I missing something? | 00:38 |
| tqtran | let me try something | 00:39 |
| tqtran | so for example | 00:41 |
| *** tyr has quit IRC | 00:41 | |
| tqtran | if you run update on horizon for python, and exclude the -l en | 00:42 |
| tqtran | it will still work | 00:42 |
| *** jasondotstar has quit IRC | 00:42 | |
| *** chlong has joined #openstack-horizon | 00:42 | |
| *** oro has quit IRC | 00:42 | |
| tqtran | running it right now on other dirs, for one of them, it will fail | 00:43 |
| neillc | The pybabel doco for update says "If neither the output_file nor the locale option is set, this command looks for all catalog files in the base directory that match the given domain, and updates each of them. | 00:43 |
| neillc | " | 00:43 |
| tqtran | can you provide the link? | 00:44 |
| neillc | Seems a little odd that it only fails for some. | 00:44 |
| neillc | http://babel.edgewall.org/wiki/Documentation/cmdline.html#update | 00:44 |
| tqtran | ok so i just ran the same thing in dashboard and it fails | 00:44 |
| neillc | weird. | 00:44 |
| neillc | just realised that's old doco. Let me check the new site | 00:44 |
| neillc | pretty much the same http://babel.pocoo.org/docs/cmdline/#update | 00:45 |
| neillc | tqtran: which one fails? | 00:46 |
| *** btully has quit IRC | 00:46 | |
| tqtran | python for dashboard, if you remove the -l en | 00:47 |
| *** ybathia has quit IRC | 00:47 | |
| *** ybathia has joined #openstack-horizon | 00:48 | |
| *** btully has joined #openstack-horizon | 00:48 | |
| *** dsneddon_biab is now known as dsneddon | 00:48 | |
| tqtran | yeah, just verified, it works in all other folders | 00:49 |
| tqtran | except for dashboard python | 00:49 |
| *** lhcheng has quit IRC | 00:49 | |
| *** hurgleburgler has quit IRC | 00:49 | |
| *** hurgleburgler has joined #openstack-horizon | 00:50 | |
| neillc | Difference seems to be that horizon/locale contains .pot files, while openstack_dashboard/locale does not. | 00:51 |
| tqtran | it does? i dont see it on my file system | 00:51 |
| tqtran | i think its fine to include the --locale options for all | 00:52 |
| tqtran | looks like old script did it as well | 00:52 |
| neillc | old makemessages has OPTS="-l en --no-obsolete --settings=openstack_dashboard.test.settings" | 00:54 |
| tqtran | right | 00:54 |
| neillc | perhaps I should move "-l en" back into $OPTS | 00:54 |
| tqtran | yeah i think so | 00:54 |
| tqtran | i think you need 3 OPTS line | 00:55 |
| tqtran | one for the keywords | 00:55 |
| tqtran | one for the python | 00:55 |
| tqtran | one for the JS | 00:55 |
| neillc | I will need slight;y different opts because two different commands now | 00:55 |
| neillc | yep :) | 00:55 |
| neillc | well, one for extract, one for update | 00:56 |
| tqtran | right | 00:56 |
| tqtran | ok i'm going ot leave those comments and a few others in the patch, but its looking good, just need to run one more test and compare files | 00:57 |
| neillc | tqtran: thanks :) | 00:58 |
| *** ybathia has quit IRC | 00:58 | |
| *** ducttape_ has quit IRC | 00:58 | |
| tqtran | neillc: one last thing, i think its safe to replace the old makemessages script with this one | 01:02 |
| neillc | tqtran: cool. will do. | 01:02 |
| tqtran | i verified that the babel one extracts the same exact thing, only difference is the ordering of some stuff, which will be fine as pointed out in the ML | 01:02 |
| *** yamamoto has joined #openstack-horizon | 01:06 | |
| *** nlahouti has quit IRC | 01:12 | |
| *** clu_ has quit IRC | 01:15 | |
| tqtran | neillc: https://github.com/Phaiax/python-babel/blob/80933afc659b809b7a8d4ab1ca503b5ce0ccf1e3/babel/messages/extract.py#L36 | 01:15 |
| tqtran | i may have found the default keywords for babel | 01:15 |
| *** bradjones has quit IRC | 01:21 | |
| *** tqtran is now known as tqtran_afk_gowar | 01:27 | |
| *** bradjones has joined #openstack-horizon | 01:29 | |
| *** bradjones has quit IRC | 01:29 | |
| *** bradjones has joined #openstack-horizon | 01:29 | |
| *** tqtran_afk_gowar has quit IRC | 01:32 | |
| *** mtecer has quit IRC | 01:34 | |
| *** kiran-r has joined #openstack-horizon | 01:37 | |
| *** ducttape_ has joined #openstack-horizon | 01:38 | |
| *** ducttape_ has quit IRC | 01:40 | |
| *** sjmc7 has joined #openstack-horizon | 01:41 | |
| *** sjmc7 has quit IRC | 01:46 | |
| *** gyee is now known as operator99 | 01:49 | |
| *** sqchen has quit IRC | 01:51 | |
| *** jtriley has joined #openstack-horizon | 01:52 | |
| *** jtriley has quit IRC | 01:57 | |
| *** iamjarvo has joined #openstack-horizon | 01:57 | |
| *** jingjin__ has quit IRC | 01:58 | |
| *** kztsv_mbp has joined #openstack-horizon | 02:00 | |
| *** yingjun has quit IRC | 02:05 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in mechanism to scss https://review.openstack.org/192500 | 02:07 |
| openstackgerrit | Amogh proposed openstack/horizon: Integration tests - Instances tests https://review.openstack.org/117091 | 02:09 |
| *** jasondotstar has joined #openstack-horizon | 02:09 | |
| *** jasondotstar has quit IRC | 02:09 | |
| *** garthb_ has joined #openstack-horizon | 02:10 | |
| *** garthb has joined #openstack-horizon | 02:10 | |
| *** jasondotstar has joined #openstack-horizon | 02:10 | |
| *** kiran-r has quit IRC | 02:11 | |
| *** kztsv_mbp has quit IRC | 02:17 | |
| *** jasondotstar has quit IRC | 02:24 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 02:25 |
| openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 02:39 |
| openstackgerrit | Merged openstack/horizon: Fix for test_image_create_delete https://review.openstack.org/190596 | 02:40 |
| *** lhcheng has joined #openstack-horizon | 02:42 | |
| openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 02:42 |
| *** lhcheng has quit IRC | 02:45 | |
| *** lhcheng has joined #openstack-horizon | 02:52 | |
| *** kiran-r has joined #openstack-horizon | 03:05 | |
| *** lhcheng has quit IRC | 03:21 | |
| *** raildo has quit IRC | 03:21 | |
| *** htruta has quit IRC | 03:22 | |
| *** pauloewerton has quit IRC | 03:22 | |
| *** ericksonsantos has quit IRC | 03:22 | |
| *** jpomero has quit IRC | 03:22 | |
| *** iamjarvo has quit IRC | 03:26 | |
| *** iamjarvo has joined #openstack-horizon | 03:29 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 03:33 |
| *** fedexo has joined #openstack-horizon | 03:33 | |
| *** jtriley has joined #openstack-horizon | 03:41 | |
| *** Piet has quit IRC | 03:44 | |
| *** tjones1 has joined #openstack-horizon | 03:44 | |
| *** jtriley has quit IRC | 03:46 | |
| *** stevemar has quit IRC | 03:47 | |
| *** stevemar has joined #openstack-horizon | 03:48 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in mechanism to scss https://review.openstack.org/192500 | 03:50 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Extending Horizon's plug-in mechanism to scss https://review.openstack.org/192500 | 03:53 |
| *** KunalGandhi has quit IRC | 03:58 | |
| *** Drago has quit IRC | 04:00 | |
| *** iamjarvo has quit IRC | 04:00 | |
| *** Drago has joined #openstack-horizon | 04:01 | |
| *** ozialien has joined #openstack-horizon | 04:03 | |
| *** tjones1 has quit IRC | 04:03 | |
| *** kiran-r has quit IRC | 04:06 | |
| *** rushiagr_away is now known as rushiagr | 04:10 | |
| *** neillc is now known as neillc_away | 04:17 | |
| *** amotoki has joined #openstack-horizon | 04:19 | |
| *** josecastroleon has quit IRC | 04:31 | |
| *** josecastroleon has joined #openstack-horizon | 04:32 | |
| *** hurgleburgler has joined #openstack-horizon | 04:37 | |
| *** kztsv_mbp has joined #openstack-horizon | 04:58 | |
| *** ozialien has quit IRC | 05:01 | |
| *** kztsv_mbp has quit IRC | 05:03 | |
| *** KunalGandhi has joined #openstack-horizon | 05:09 | |
| *** Kunal has joined #openstack-horizon | 05:09 | |
| *** fifieldt has joined #openstack-horizon | 05:10 | |
| *** stevemar has quit IRC | 05:14 | |
| *** masco has joined #openstack-horizon | 05:14 | |
| *** vishwana_ has joined #openstack-horizon | 05:16 | |
| *** sjmc7 has joined #openstack-horizon | 05:19 | |
| *** vishwanathj has quit IRC | 05:19 | |
| *** sqchen has joined #openstack-horizon | 05:21 | |
| *** sjmc7 has quit IRC | 05:23 | |
| *** dscottsf has joined #openstack-horizon | 05:25 | |
| *** dscottsf has quit IRC | 05:26 | |
| *** dscottsf has joined #openstack-horizon | 05:30 | |
| *** jtriley has joined #openstack-horizon | 05:30 | |
| *** alexvictorchan has joined #openstack-horizon | 05:34 | |
| *** jtriley has quit IRC | 05:35 | |
| *** belmoreira has joined #openstack-horizon | 05:44 | |
| *** dscottsf has quit IRC | 05:44 | |
| *** neelabh has joined #openstack-horizon | 05:49 | |
| *** fedexo has quit IRC | 05:49 | |
| *** sqchen has left #openstack-horizon | 05:49 | |
| *** lhcheng has joined #openstack-horizon | 05:53 | |
| *** alexvictorchan has quit IRC | 05:53 | |
| *** garthb_ has quit IRC | 05:56 | |
| *** garthb has quit IRC | 05:57 | |
| *** kiran-r has joined #openstack-horizon | 06:02 | |
| openstackgerrit | zouyee proposed openstack/horizon: No hostname validation for create instance https://review.openstack.org/185904 | 06:03 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/192525 | 06:05 |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add description field in the user table https://review.openstack.org/190944 | 06:19 |
| *** KunalGandhi has quit IRC | 06:22 | |
| *** Kunal has quit IRC | 06:27 | |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add description field in the user table https://review.openstack.org/190944 | 06:27 |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/horizon: Add hostname validation for create instance https://review.openstack.org/185904 | 06:37 |
| *** Longgeek has joined #openstack-horizon | 06:49 | |
| *** mrunge has joined #openstack-horizon | 06:50 | |
| *** Longgeek_ has joined #openstack-horizon | 06:53 | |
| *** romainh has joined #openstack-horizon | 06:56 | |
| *** Longgeek has quit IRC | 06:57 | |
| *** lhcheng has quit IRC | 06:58 | |
| *** neelabh has quit IRC | 06:58 | |
| *** Ala has joined #openstack-horizon | 06:59 | |
| *** neelabh has joined #openstack-horizon | 06:59 | |
| *** btully has quit IRC | 07:01 | |
| *** KunalGandhi has joined #openstack-horizon | 07:02 | |
| *** Drago has quit IRC | 07:02 | |
| *** Kunal has joined #openstack-horizon | 07:02 | |
| *** btully has joined #openstack-horizon | 07:03 | |
| *** KunalGandhi has quit IRC | 07:06 | |
| *** jtomasek has quit IRC | 07:07 | |
| *** sjmc7 has joined #openstack-horizon | 07:08 | |
| *** Kunal has quit IRC | 07:11 | |
| *** sjmc7 has quit IRC | 07:12 | |
| *** jtriley has joined #openstack-horizon | 07:19 | |
| *** mrunge has quit IRC | 07:21 | |
| *** jtriley has quit IRC | 07:24 | |
| *** Longgeek_ has quit IRC | 07:26 | |
| *** kztsv_mbp has joined #openstack-horizon | 07:29 | |
| *** MaxV has joined #openstack-horizon | 07:30 | |
| *** kztsv_mbp has quit IRC | 07:34 | |
| *** mrunge has joined #openstack-horizon | 07:35 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/192525 | 07:37 |
| *** zz_ttrifonov is now known as ttrifonov | 07:38 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/192297 | 07:45 |
| *** Longgeek has joined #openstack-horizon | 07:47 | |
| openstackgerrit | Canh Van Truong proposed openstack/horizon: Add description field in the user table https://review.openstack.org/190944 | 07:47 |
| *** Longgeek has quit IRC | 07:48 | |
| *** Longgeek has joined #openstack-horizon | 07:48 | |
| *** mrunge_ has joined #openstack-horizon | 07:48 | |
| *** mrunge has quit IRC | 07:49 | |
| *** markus_z has joined #openstack-horizon | 07:56 | |
| *** davidmichaelkarr has quit IRC | 07:57 | |
| *** bluex-pl has joined #openstack-horizon | 08:01 | |
| *** mrunge_ is now known as mrunge | 08:02 | |
| *** ZZelle has quit IRC | 08:02 | |
| *** ZZelle has joined #openstack-horizon | 08:03 | |
| *** jcoufal has joined #openstack-horizon | 08:08 | |
| *** jcoufal has quit IRC | 08:09 | |
| *** jcoufal has joined #openstack-horizon | 08:10 | |
| *** mpavlase has joined #openstack-horizon | 08:14 | |
| *** ygbo has joined #openstack-horizon | 08:16 | |
| *** ttrifonov is now known as zz_ttrifonov | 08:17 | |
| *** chlong has quit IRC | 08:18 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:18 | |
| *** kztsv_mbp has joined #openstack-horizon | 08:30 | |
| *** bluex-pl has quit IRC | 08:30 | |
| *** belmoreira has quit IRC | 08:33 | |
| *** belmoreira has joined #openstack-horizon | 08:33 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/horizon: Fixes a typo 'use_strict' -> 'use strict' https://review.openstack.org/192549 | 08:39 |
| *** bluex-pl has joined #openstack-horizon | 08:47 | |
| *** akrivoka has joined #openstack-horizon | 08:52 | |
| *** sjmc7 has joined #openstack-horizon | 08:56 | |
| *** sjmc7 has quit IRC | 09:01 | |
| *** kkiegler has joined #openstack-horizon | 09:05 | |
| *** kkiegler has quit IRC | 09:06 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/horizon: Fixes a typo 'use_strict' -> 'use strict' https://review.openstack.org/192549 | 09:09 |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 09:13 |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 09:13 |
| *** kztsv_mbp has quit IRC | 09:16 | |
| openstackgerrit | Romain Hardouin proposed openstack/horizon: DataTable column level policy https://review.openstack.org/164010 | 09:22 |
| openstackgerrit | Merged openstack/horizon: LB method column is added in pools table https://review.openstack.org/190556 | 09:24 |
| *** wznoinsk has joined #openstack-horizon | 09:24 | |
| *** dguerri` is now known as dguerri | 09:31 | |
| *** jtomasek has joined #openstack-horizon | 09:32 | |
| svasheka | mrunge, mpavlase hi guys | 09:35 |
| *** e0ne has joined #openstack-horizon | 09:36 | |
| mpavlase | svasheka: Hi! | 09:36 |
| svasheka | mrunge, mpavlase we did fix couple integration tests, no it's only sahara tests are failing. and we need activate sahara in gate devstack (not it is not active), or exclude these tests | 09:36 |
| svasheka | to make it all green :) | 09:37 |
| svasheka | mrunge, mpavlase, tests aren't very stable yet either. but we will work on that also | 09:38 |
| mpavlase | svasheka: I'm just wondering that isn't enabled... I didn't find line in code that explicitely enable it, but in past sahara tests were running fine. | 09:39 |
| svasheka | yeah, I did find out in infra chat that it was disabled | 09:40 |
| svasheka | I even got patch, but I can't find it atm | 09:40 |
| svasheka | mpavlase, they work localy on devstack with sahara though | 09:40 |
| svasheka | mpavlase, atm we only need come up with decision on whether we should enable sahara (I don't think it was disabled without reason), or move these tests somewhere else | 09:41 |
| svasheka | mpavlase, I've tried comunicate this with david-lyle , but time difference doesnt' make it easy :( | 09:41 |
| mpavlase | svasheka: hmm.. why should be that tests moved to some other place? It's 'component' of horizon... | 09:41 |
| mpavlase | svasheka: what is his timezone? | 09:42 |
| *** e0ne is now known as e0ne_ | 09:43 | |
| svasheka | mpavlase, If there's no reason to move them, I think we should create a bug on openstack-infra to enable it again | 09:43 |
| *** MaxV has quit IRC | 09:44 | |
| svasheka | mpavlase, I don't know exactly his time zone, but his workday start around that time when my ends ) | 09:44 |
| mpavlase | svasheka: one my colleague created that sahara tests, so I can ask him more | 09:44 |
| mpavlase | svasheka: what is your current local time? | 09:45 |
| svasheka | 12:45 | 09:45 |
| svasheka | mpavlase, I totaly behind using them in this gate | 09:45 |
| svasheka | mpavlase, we need to get on enabling sahara back then | 09:45 |
| *** e0ne_ is now known as e0ne | 09:47 | |
| svasheka | mpavlase, I believe this will make gate green at least some times. tests are still able to fail randomly | 09:48 |
| mpavlase | svasheka: i'm -1h against you, I can ask him | 09:48 |
| svasheka | mpavlase, It would be great if you do that | 09:48 |
| mpavlase | svasheka: btw, can you point me to your patches? I couldn't find them on review.. | 09:49 |
| svasheka | https://review.openstack.org/#/c/191784/2 | 09:50 |
| svasheka | https://review.openstack.org/#/c/190596/5 | 09:50 |
| svasheka | mpavlase, first one made by tsufiev | 09:51 |
| svasheka | mpavlase, and it fixes not tests itself, but the reason test failed | 09:52 |
| *** tosky has joined #openstack-horizon | 09:52 | |
| mpavlase | svasheka: thx for the links | 09:54 |
| mrunge | svasheka, mpavlase david-lyle is in US West | 09:54 |
| svasheka | mrunge, mpavlase most likley we only need to include sahara in gate devstack back | 09:55 |
| mpavlase | mrunge: ou... it's almost other side of world compared to middle of europe.. | 09:55 |
| mrunge | yepp. | 09:55 |
| mrunge | we have an upstream meeting today at 20 UTC | 09:55 |
| mrunge | that's a good topic for the meeting | 09:56 |
| mrunge | next week will be at 12 UTC | 09:56 |
| mpavlase | mrunge: good point | 09:56 |
| mrunge | ^ svasheka just fyi, that should be fine with you then? | 09:56 |
| svasheka | mrunge, meening meeting on next week? | 09:57 |
| mrunge | If we can enable this back this week, the better.... ;-) | 09:57 |
| svasheka | mrunge, sure time is good. it would be better to rise this question on todays meeting though | 09:57 |
| mrunge | yes, that's my thought | 09:57 |
| svasheka | mrunge, meeting held here? irc chanel? | 09:58 |
| mrunge | svasheka, in #openstack-meeting-3 | 09:58 |
| mpavlase | svasheka: http://eavesdrop.openstack.org/, search for Horizon Team Meeting | 09:58 |
| mrunge | https://wiki.openstack.org/wiki/Meetings/Horizon | 09:59 |
| svasheka | mrunge, mpavlase thanks | 09:59 |
| *** romainh has quit IRC | 09:59 | |
| svasheka | mrunge, mpavlase I'll try to attend, but can't promise aything yeat | 09:59 |
| mrunge | svasheka, that would be awesome | 09:59 |
| mrunge | but I acknowledge, it's quite late for you | 09:59 |
| svasheka | mrunge, is there some agenda, we could put this into? | 10:00 |
| mrunge | svasheka, I was about to do it right now | 10:00 |
| mpavlase | svasheka: mrunge I usually don't go to bed before midnight (it would be at 10PM my localtime) | 10:00 |
| mrunge | svasheka, mpavlase the agenda is directly on https://wiki.openstack.org/wiki/Meetings/Horizon | 10:01 |
| mrunge | where an item for today should be added | 10:01 |
| svasheka | mrunge, mpavlase in my understanding disabled sahara is the only thing holding us from green integration-dsvm gate | 10:01 |
| mrunge | svasheka, I just added something for today | 10:02 |
| *** mou has joined #openstack-horizon | 10:02 | |
| mrunge | but you might be able to specify it a bit more | 10:02 |
| svasheka | mrunge, thanks. saw it. will add some description | 10:02 |
| *** MaxV has joined #openstack-horizon | 10:02 | |
| mrunge | awesome! | 10:02 |
| mpavlase | svasheka: can I add also you to the bullet in agenda? | 10:06 |
| svasheka | mpavlase, sure | 10:06 |
| mpavlase | svasheka: done | 10:07 |
| *** oro has joined #openstack-horizon | 10:07 | |
| svasheka | mpavlase, thanks. | 10:11 |
| svasheka | mrunge, mpavlase https://github.com/openstack-infra/devstack-gate/commit/56fc5627a1ed785b2c3081c1a8b2246f2762d647 can't find gerrit thread for this, but this is the change disabling sahara I believe | 10:13 |
| svasheka | mrunge, mpavlase jfyi | 10:13 |
| mpavlase | tosky: ^^^ do you know why was sahara removed from default configuration? | 10:14 |
| *** oro has quit IRC | 10:14 | |
| tosky | mpavlase: maybe as follow-up to the "big tent" project - sahara is not exactly core | 10:15 |
| tosky | just my speculation | 10:15 |
| *** mpavlase is now known as mpavlase|afk | 10:15 | |
| tosky | mpavlase|afk: no, different reason, there is a dedicated job: https://review.openstack.org/#/c/181230/ | 10:16 |
| *** kztsv_mbp has joined #openstack-horizon | 10:19 | |
| *** mpavlase|afk is now known as mpavlase | 10:25 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/horizon: Fixes a typo 'use_strict' -> 'use strict' https://review.openstack.org/192549 | 10:33 |
| *** kiran-r has quit IRC | 10:39 | |
| *** jasondotstar has joined #openstack-horizon | 10:41 | |
| *** neelabh_ has joined #openstack-horizon | 10:45 | |
| *** sjmc7 has joined #openstack-horizon | 10:45 | |
| *** neelabh has quit IRC | 10:47 | |
| *** e0ne is now known as e0ne_ | 10:49 | |
| *** aix has joined #openstack-horizon | 10:49 | |
| robcresswell | r1chardj0n3s: In that case it's just a matter of asking around, as clu_ said. Perhaps we should etherpad it. | 10:49 |
| *** sjmc7 has quit IRC | 10:50 | |
| robcresswell | r1chardj0n3s: I'll try and hang around late tonight so we can all be online and discuss. | 10:50 |
| *** yamamoto has quit IRC | 10:54 | |
| *** e0ne_ has quit IRC | 10:54 | |
| *** e0ne has joined #openstack-horizon | 10:56 | |
| *** kztsv_mbp has quit IRC | 10:58 | |
| neelabh_ | Hi Guys, I am searching JavaScript or angularJS file which they are using for making graph In ResourceUsage under stats tab, Please help me on this.. | 11:00 |
| neelabh_ | robcresswell, sorry to interrupt you, Could you tell me Javascript file, which is use to fill the graph in ResouceUsage/stats tab... | 11:06 |
| *** jasondotstar has quit IRC | 11:06 | |
| *** kztsv_mbp has joined #openstack-horizon | 11:09 | |
| *** oro has joined #openstack-horizon | 11:16 | |
| *** romainh has joined #openstack-horizon | 11:18 | |
| *** rushiagr is now known as rushiagr_away | 11:24 | |
| *** e0ne is now known as e0ne_ | 11:29 | |
| *** yamamoto has joined #openstack-horizon | 11:31 | |
| *** e0ne_ has quit IRC | 11:34 | |
| *** ericksonsantos has joined #openstack-horizon | 11:36 | |
| *** pauloewerton has joined #openstack-horizon | 11:36 | |
| *** yamamoto_ has joined #openstack-horizon | 11:38 | |
| *** kiran-r has joined #openstack-horizon | 11:38 | |
| *** pauloewerton has quit IRC | 11:41 | |
| *** ducttape_ has joined #openstack-horizon | 11:41 | |
| *** ericksonsantos has quit IRC | 11:41 | |
| *** yamamoto has quit IRC | 11:42 | |
| *** MaxV has quit IRC | 11:43 | |
| *** ducttape_ has quit IRC | 11:52 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Allow to attach FIP without a router https://review.openstack.org/189215 | 11:53 |
| *** tosky has quit IRC | 12:05 | |
| *** htruta has joined #openstack-horizon | 12:06 | |
| *** julim has joined #openstack-horizon | 12:08 | |
| *** rushiagr_away is now known as rushiagr | 12:11 | |
| *** MaxV has joined #openstack-horizon | 12:12 | |
| *** tosky has joined #openstack-horizon | 12:15 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila-ui: Add mock manilaclient to APITestCase class https://review.openstack.org/185351 | 12:19 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila-ui: Add extend support to manila-ui https://review.openstack.org/185352 | 12:19 |
| *** e0ne has joined #openstack-horizon | 12:19 | |
| *** oro has quit IRC | 12:23 | |
| *** pauloewerton has joined #openstack-horizon | 12:23 | |
| *** raildo has joined #openstack-horizon | 12:26 | |
| *** neelabh_ has quit IRC | 12:34 | |
| *** sjmc7 has joined #openstack-horizon | 12:34 | |
| *** oro has joined #openstack-horizon | 12:36 | |
| *** sjmc7 has quit IRC | 12:39 | |
| *** jtriley has joined #openstack-horizon | 12:45 | |
| *** jtriley has quit IRC | 12:50 | |
| mrunge | svasheka, you might want to weight in: https://review.openstack.org/#/c/192645/ | 12:52 |
| mrunge | ^ tsufiev | 12:52 |
| *** Ctina_ has joined #openstack-horizon | 12:52 | |
| *** petertr7_away is now known as petertr7 | 12:53 | |
| tsufiev | mrunge, sure! | 12:53 |
| svasheka | mrunge, great, thanks! | 12:55 |
| *** e0ne is now known as e0ne_ | 12:55 | |
| *** e0ne_ is now known as e0ne | 12:57 | |
| *** julim has quit IRC | 13:01 | |
| *** masco has quit IRC | 13:02 | |
| *** julim has joined #openstack-horizon | 13:05 | |
| *** jpomero has joined #openstack-horizon | 13:08 | |
| *** jamielennox is now known as jamielennox|away | 13:13 | |
| *** amotoki_ has joined #openstack-horizon | 13:14 | |
| *** davidmichaelkarr has joined #openstack-horizon | 13:17 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila-ui: Remove usage of unexciting openstack.common code https://review.openstack.org/192659 | 13:17 |
| *** _crobertsrh is now known as crobertsrh | 13:19 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 13:20 |
| *** jamielennox|away is now known as jamielennox | 13:21 | |
| *** lblanchard has joined #openstack-horizon | 13:26 | |
| *** stevemar has joined #openstack-horizon | 13:30 | |
| *** tosky has quit IRC | 13:31 | |
| *** jamielennox is now known as jamielennox|away | 13:33 | |
| *** cardeois has joined #openstack-horizon | 13:36 | |
| *** tosky has joined #openstack-horizon | 13:37 | |
| *** jtriley has joined #openstack-horizon | 13:40 | |
| *** jamielennox|away is now known as jamielennox | 13:42 | |
| *** peristeri has joined #openstack-horizon | 13:45 | |
| *** tvanderwiel has joined #openstack-horizon | 13:46 | |
| *** Longgeek has quit IRC | 13:48 | |
| *** Longgeek has joined #openstack-horizon | 13:49 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Sort images list in ascending alphabetical order https://review.openstack.org/130844 | 13:50 |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila-ui: Remove usage of openstack.common._i18n module https://review.openstack.org/192659 | 13:51 |
| *** doug-fish has joined #openstack-horizon | 13:52 | |
| *** katyafervent_awa is now known as katyafervent | 13:53 | |
| openstackgerrit | tinytmy proposed openstack/django_openstack_auth: Add message show for switch project https://review.openstack.org/169577 | 13:58 |
| *** masco has joined #openstack-horizon | 14:00 | |
| *** kbee has joined #openstack-horizon | 14:00 | |
| *** yamamoto has joined #openstack-horizon | 14:02 | |
| *** yamamoto_ has quit IRC | 14:02 | |
| *** sjmc7 has joined #openstack-horizon | 14:02 | |
| *** jingliuqing has joined #openstack-horizon | 14:03 | |
| *** eandersson has quit IRC | 14:13 | |
| *** Drago has joined #openstack-horizon | 14:15 | |
| *** kbee has quit IRC | 14:20 | |
| *** kbee has joined #openstack-horizon | 14:21 | |
| *** mrunge has quit IRC | 14:21 | |
| *** iamjarvo has joined #openstack-horizon | 14:22 | |
| *** eandersson has joined #openstack-horizon | 14:23 | |
| *** jtriley has quit IRC | 14:26 | |
| *** kbee has quit IRC | 14:27 | |
| *** jtriley has joined #openstack-horizon | 14:28 | |
| *** absubram has joined #openstack-horizon | 14:33 | |
| *** Drago has quit IRC | 14:40 | |
| *** kiran-r has quit IRC | 14:41 | |
| *** belmoreira has quit IRC | 14:45 | |
| *** Piet has joined #openstack-horizon | 14:49 | |
| openstackgerrit | Igor Malinovskiy proposed openstack/manila-ui: Remove usage of openstack.common._i18n module https://review.openstack.org/192659 | 14:51 |
| *** tjones1 has joined #openstack-horizon | 14:52 | |
| *** Drago has joined #openstack-horizon | 14:57 | |
| *** clu_ has joined #openstack-horizon | 14:59 | |
| *** tyr has joined #openstack-horizon | 14:59 | |
| *** rhagarty__ has quit IRC | 15:01 | |
| *** rhagarty has quit IRC | 15:02 | |
| Piet | We are have a design review if anyone is interested in attending. https://cisco.webex.com/join/rcresswe | 15:02 |
| *** rhagarty__ has joined #openstack-horizon | 15:02 | |
| *** rhagarty has joined #openstack-horizon | 15:02 | |
| wznoinsk | hi all | 15:03 |
| wznoinsk | is angularjs planned to be default in Liberty? | 15:04 |
| *** openstackgerrit has quit IRC | 15:05 | |
| *** openstackgerrit has joined #openstack-horizon | 15:05 | |
| *** amotoki_ has quit IRC | 15:06 | |
| robcresswell | wznoinsk: As in, default language? We would encourage new contributors to write in AngularJS. However, it is not mandatory, and 99% of the existing code is still python based. | 15:06 |
| wznoinsk | robcresswell: how about Launch Instance then? | 15:08 |
| *** amotoki_ has joined #openstack-horizon | 15:08 | |
| *** iamjarvo has quit IRC | 15:09 | |
| *** masco has quit IRC | 15:10 | |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Update Neutron initialization setup https://review.openstack.org/192726 | 15:10 |
| *** kztsv_mbp has quit IRC | 15:10 | |
| *** iamjarvo has joined #openstack-horizon | 15:12 | |
| *** iamjarvo has quit IRC | 15:12 | |
| *** iamjarvo has joined #openstack-horizon | 15:13 | |
| *** jingliuqing has quit IRC | 15:16 | |
| *** kztsv_mbp has joined #openstack-horizon | 15:20 | |
| *** bpokorny has joined #openstack-horizon | 15:21 | |
| *** absubram has quit IRC | 15:21 | |
| *** yamamoto has quit IRC | 15:30 | |
| wznoinsk | so if old 'Launch instance' will not be developed then the angularJS wizard becomes default for Liberty? | 15:32 |
| *** alexvictorchan has joined #openstack-horizon | 15:37 | |
| *** jamielennox is now known as jamielennox|away | 15:38 | |
| *** KunalGandhi has joined #openstack-horizon | 15:39 | |
| *** Kunal has joined #openstack-horizon | 15:39 | |
| robcresswell | wznoinsk: The aim is to make the angular Launch Instance the primary launch instance during the Liberty cycle afaik. | 15:40 |
| *** vishwana_ has quit IRC | 15:40 | |
| robcresswell | wznoinsk: But it will depend on community decision, obviously :) | 15:41 |
| *** vishwanathj has joined #openstack-horizon | 15:41 | |
| *** esp has joined #openstack-horizon | 15:41 | |
| wznoinsk | I have a plan to implement an additional feature request support in launch instance, would I do it in both 'launch instance' workflows? | 15:41 |
| wznoinsk | robcresswell: what's ptl/core plans for that? | 15:41 |
| *** jprovazn has joined #openstack-horizon | 15:41 | |
| robcresswell | wznoinsk: The PTL is david-lyle, so you can ask him here | 15:42 |
| robcresswell | wznoinsk: Personally, I would add new features to the new Launch Instance. I would expect that to be the main workflow at the Liberty release. | 15:42 |
| *** yamamoto has joined #openstack-horizon | 15:42 | |
| robcresswell | new meaning angular. | 15:42 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Fix get_nodes_stats() https://review.openstack.org/192737 | 15:44 |
| *** KunalGandhi has quit IRC | 15:45 | |
| *** ericksonsantos has joined #openstack-horizon | 15:46 | |
| *** garthb has joined #openstack-horizon | 15:46 | |
| *** garthb_ has joined #openstack-horizon | 15:46 | |
| *** jamielennox|away is now known as jamielennox | 15:47 | |
| *** MaxV has quit IRC | 15:48 | |
| *** petertr7 is now known as petertr7_away | 15:48 | |
| *** Kunal has quit IRC | 15:48 | |
| *** hurgleburgler has joined #openstack-horizon | 15:49 | |
| *** jbell8 has joined #openstack-horizon | 15:50 | |
| *** stevemar has quit IRC | 15:50 | |
| *** bethelwell has joined #openstack-horizon | 15:52 | |
| openstackgerrit | Merged openstack/manila-ui: Remove usage of openstack.common._i18n module https://review.openstack.org/192659 | 15:52 |
| *** kiran-r has joined #openstack-horizon | 15:52 | |
| *** stevemar has joined #openstack-horizon | 15:52 | |
| *** nlahouti has joined #openstack-horizon | 15:52 | |
| *** tjones1 has quit IRC | 15:54 | |
| *** tjones1 has joined #openstack-horizon | 15:56 | |
| *** kiran-r has quit IRC | 15:56 | |
| *** kiran-r has joined #openstack-horizon | 15:57 | |
| *** tosky has quit IRC | 15:57 | |
| *** jamielennox is now known as jamielennox|away | 15:58 | |
| *** tosky has joined #openstack-horizon | 15:58 | |
| *** Sukhdev has joined #openstack-horizon | 15:58 | |
| *** iamjarvo has quit IRC | 16:00 | |
| *** jtriley has quit IRC | 16:02 | |
| *** kiran-r has quit IRC | 16:03 | |
| *** kiran-r has joined #openstack-horizon | 16:03 | |
| *** jamielennox|away is now known as jamielennox | 16:06 | |
| *** kbee has joined #openstack-horizon | 16:06 | |
| *** jtriley has joined #openstack-horizon | 16:06 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix broken header dropdowns https://review.openstack.org/165893 | 16:06 |
| krotscheck | david-lyle: There's a patch pending to make the karma test job voting. If you think horizon's ready for that, a +1 on this review would be appreciated: https://review.openstack.org/#/c/191919/ | 16:06 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix broken header dropdowns https://review.openstack.org/165893 | 16:07 |
| krotscheck | Also, is the gate-horizon-jshint test still relevant? | 16:07 |
| *** jcoufal has quit IRC | 16:10 | |
| *** kiran-r has quit IRC | 16:10 | |
| *** absubram has joined #openstack-horizon | 16:11 | |
| robcresswell | krotscheck: Sorry, missed the reply yesterday. Just wanted to say that my mailer reply was not intended to imply that Horizon should not change its tooling, just that I was curious about the workload involved | 16:12 |
| robcresswell | krotscheck: Your reply to my email made me think I'd perhaps phrased that badly. I was by no means stating Horizons importance over the other projects :) | 16:12 |
| krotscheck | robcresswell: Oh, gotcha. | 16:13 |
| krotscheck | robcresswell: Yeah, I'm not entirely happy with the workload either, except to say that it's something we would have had to do eventually anyway, simply because JSCS doesn't apply certain rules which we probably want to use. | 16:13 |
| robcresswell | krotscheck: Yes, and it seems JSHint is bad due to licensing. I hadn't realised this. | 16:14 |
| *** kztsv_mbp has quit IRC | 16:15 | |
| krotscheck | robcresswell: And it's not even that bad! It's one single file (the language lexer), which is about 75% brand new code, which still has 25% legacy from the jslint fork. But that 25% is killer. | 16:15 |
| *** dguerri is now known as dguerri` | 16:15 | |
| krotscheck | Furthermore, it's a license clause which will never hold up in court. | 16:16 |
| krotscheck | It's just that nobody's willing to test that license. | 16:16 |
| robcresswell | krotscheck: Gah, yes, I hate these stupid licenses. | 16:16 |
| krotscheck | robcresswell: You and me both. | 16:17 |
| krotscheck | robcresswell: With that in mind though, I can conceive of a path forward where we tune the .eslintrc file to be papa-guides only, and then slowly enable rules on a case-by-case basis. | 16:17 |
| krotscheck | It's just hard to do that when the existing codebase isn't yet error free. | 16:18 |
| robcresswell | krotscheck: I think its the Debian Project (?) that had a really nice article about training people, and why non-standard licenses are a pain. Anyway, thankyou for looking into the issue and trying to find some common ground between the projects. | 16:18 |
| openstackgerrit | Merged openstack/manila-ui: Use UPDATE_HORIZON_CONFIG for manila_ui.overrides https://review.openstack.org/192214 | 16:18 |
| krotscheck | robcresswell: Of course! I really just want OpenStack to have available API abstractions published to NPM and bower so the app development community can go hogwild. | 16:19 |
| robcresswell | krotscheck: Realistically, most of the rules will cross over. We should quickly tune eslint for JP, then swap and keep fixing. Light ruling at first IMO, then add a rule and fix etc. | 16:19 |
| krotscheck | And that means standardization. | 16:19 |
| krotscheck | robcresswell: I may have a patch I'm working on for that :) https://review.openstack.org/#/c/192327/ | 16:19 |
| krotscheck | Also, in other news, npm run lint is now a non-voting check job. | 16:20 |
| robcresswell | krotscheck: Yes, saw this earlier, yet to comment. What are your thoughts on strictness? Do we turn on all rules we need at once? Or a few and fix quicker, so the gate can be voting? | 16:21 |
| robcresswell | Oh, that makes the jshint test redundant then I assume. | 16:21 |
| krotscheck | robcresswell: My opinion depends on which hat I'm wearing :) | 16:21 |
| krotscheck | robcresswell: If I'm wearing my "I have a german citizenship" hat, the ALL THE RULES MUST BE FOLLOWED NOW. | 16:22 |
| krotscheck | robcresswell: If i'm wearing my "I'm doing infra work" hat, then I want voting builds faster. | 16:22 |
| krotscheck | robcresswell: If I'm wearing my JS engineer hat, I think all y'alls rules are crazy and I want to nuke it all and start over :) | 16:22 |
| krotscheck | Right now I'm wearing my infra hat. | 16:23 |
| robcresswell | I will wear my British hat, so I will grumble quietly about changing and then get on with the fixes | 16:23 |
| *** yamamoto has quit IRC | 16:23 | |
| robcresswell | But, I sit on the infra-hat scenario personally | 16:24 |
| robcresswell | Better to have a few bugs actually caught, than none caught until 3 months down the line. | 16:24 |
| robcresswell | Especially with the pace of JS changes. | 16:24 |
| *** dguerri` is now known as dguerri | 16:25 | |
| *** mpavlase has quit IRC | 16:26 | |
| *** masco has joined #openstack-horizon | 16:27 | |
| *** markus_z has quit IRC | 16:27 | |
| krotscheck | Yep | 16:27 |
| krotscheck | I've managed to get the rules down to 7000 errors so far :) | 16:27 |
| *** ygbo has quit IRC | 16:28 | |
| robcresswell | Oof. | 16:29 |
| * robcresswell waves goodbye to sleep. | 16:29 | |
| *** tqtran_afk_gowar has joined #openstack-horizon | 16:30 | |
| *** kbee has quit IRC | 16:30 | |
| *** jtomasek has quit IRC | 16:30 | |
| *** tqtran_afk_gowar is now known as tqtran | 16:30 | |
| *** kbee has joined #openstack-horizon | 16:30 | |
| *** dguerri is now known as dguerri` | 16:32 | |
| *** openstackgerrit has quit IRC | 16:33 | |
| *** clu_ has quit IRC | 16:34 | |
| *** sjmc7 has quit IRC | 16:34 | |
| krotscheck | Woo, down to 1500! | 16:34 |
| *** openstackgerrit has joined #openstack-horizon | 16:34 | |
| *** jamielennox is now known as jamielennox|away | 16:35 | |
| robcresswell | krotscheck: 1500 isn't so bad. I don't think JSCS is much off that. | 16:38 |
| *** sjmc7 has joined #openstack-horizon | 16:38 | |
| Piet | We are planning to have design reviews within the community every other week. Go ahead and place your name in the wiki if your would like feedback on a design - https://etherpad.openstack.org/p/horizon-ux-core | 16:39 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix broken header dropdowns https://review.openstack.org/165893 | 16:41 |
| *** rhagarty_ has joined #openstack-horizon | 16:43 | |
| *** oro_ has joined #openstack-horizon | 16:43 | |
| *** gyee_ has joined #openstack-horizon | 16:43 | |
| *** fifieldt_ has joined #openstack-horizon | 16:43 | |
| *** rhagarty has quit IRC | 16:45 | |
| *** rhagarty__ has quit IRC | 16:45 | |
| *** oro has quit IRC | 16:45 | |
| *** fifieldt has quit IRC | 16:45 | |
| *** josecastroleon has quit IRC | 16:45 | |
| *** operator99 has quit IRC | 16:45 | |
| *** josecastroleon1 has joined #openstack-horizon | 16:45 | |
| *** crobertsrh has left #openstack-horizon | 16:45 | |
| *** a| has joined #openstack-horizon | 16:46 | |
| *** a| has quit IRC | 16:46 | |
| *** mfisch has quit IRC | 16:47 | |
| *** logan2 has joined #openstack-horizon | 16:47 | |
| *** KunalGandhi has joined #openstack-horizon | 16:49 | |
| *** jamielennox|away is now known as jamielennox | 16:49 | |
| *** crobertsrh has joined #openstack-horizon | 16:49 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 16:49 |
| *** mfisch has joined #openstack-horizon | 16:49 | |
| krotscheck | robcresswell: 1127 John papa rules remaining ^^ | 16:50 |
| *** mfisch has quit IRC | 16:50 | |
| *** mfisch has joined #openstack-horizon | 16:50 | |
| krotscheck | (Plus about 20K 'Other' errors that have been deactivated') | 16:50 |
| *** kiran-r has joined #openstack-horizon | 16:50 | |
| *** alexpilotti has joined #openstack-horizon | 16:51 | |
| *** gyee has joined #openstack-horizon | 16:52 | |
| *** romainh has left #openstack-horizon | 16:52 | |
| *** bethelwell has quit IRC | 16:55 | |
| *** jmolo has joined #openstack-horizon | 16:56 | |
| *** belmoreira has joined #openstack-horizon | 16:57 | |
| *** kiran-r has quit IRC | 16:59 | |
| *** kiran-r has joined #openstack-horizon | 16:59 | |
| *** e0ne has quit IRC | 17:00 | |
| *** dscottsf has joined #openstack-horizon | 17:02 | |
| *** dsneddon has quit IRC | 17:02 | |
| *** dscottsf has quit IRC | 17:04 | |
| *** rushiagr is now known as rushiagr_away | 17:04 | |
| *** kbee has quit IRC | 17:05 | |
| *** ducttape_ has joined #openstack-horizon | 17:05 | |
| *** mou has quit IRC | 17:07 | |
| *** mou has joined #openstack-horizon | 17:07 | |
| *** petertr7_away is now known as petertr7 | 17:10 | |
| *** jamielennox is now known as jamielennox|away | 17:13 | |
| *** mrunge has joined #openstack-horizon | 17:13 | |
| *** Ala has quit IRC | 17:16 | |
| *** jtriley has quit IRC | 17:17 | |
| *** dsneddon has joined #openstack-horizon | 17:18 | |
| *** clu_ has joined #openstack-horizon | 17:18 | |
| *** dsneddon has quit IRC | 17:18 | |
| *** dsneddon has joined #openstack-horizon | 17:19 | |
| *** masco has quit IRC | 17:19 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 17:24 |
| *** yamamoto has joined #openstack-horizon | 17:24 | |
| *** siaras-alexd has joined #openstack-horizon | 17:26 | |
| siaras-alexd | Hello. I am looking to debug Horizon's python code with pycharm. Is there any guides out there that could give me some pointers? | 17:27 |
| *** yamamoto has quit IRC | 17:29 | |
| *** ybathia has joined #openstack-horizon | 17:31 | |
| openstackgerrit | Merged openstack/horizon: Fixes a typo 'use_strict' -> 'use strict' https://review.openstack.org/192549 | 17:31 |
| *** crobertsrh has quit IRC | 17:33 | |
| *** tosky has quit IRC | 17:33 | |
| *** belmoreira has quit IRC | 17:38 | |
| *** crobertsrh has joined #openstack-horizon | 17:40 | |
| *** jtriley has joined #openstack-horizon | 17:42 | |
| *** aix has quit IRC | 17:42 | |
| *** amotoki_ has quit IRC | 17:43 | |
| *** Longgeek has quit IRC | 17:48 | |
| *** eandersson has quit IRC | 17:48 | |
| *** petertr7 is now known as petertr7_away | 17:49 | |
| *** mpavlase has joined #openstack-horizon | 17:49 | |
| *** jingjing_ren has joined #openstack-horizon | 17:50 | |
| *** kiranr has joined #openstack-horizon | 17:51 | |
| *** jingjing_ren has quit IRC | 17:51 | |
| *** e0ne has joined #openstack-horizon | 17:51 | |
| *** jingjing_ren has joined #openstack-horizon | 17:51 | |
| *** mrunge has quit IRC | 17:52 | |
| *** akrivoka has quit IRC | 17:52 | |
| *** petertr7_away is now known as petertr7 | 17:55 | |
| *** jtriley has quit IRC | 17:55 | |
| *** kiran-r has quit IRC | 17:55 | |
| *** sambetts has quit IRC | 17:56 | |
| *** sambetts has joined #openstack-horizon | 17:57 | |
| *** kiranr has quit IRC | 17:58 | |
| *** Sukhdev has quit IRC | 17:58 | |
| *** jingjing_ren has quit IRC | 18:00 | |
| *** cody-somerville has quit IRC | 18:01 | |
| *** Sukhdev has joined #openstack-horizon | 18:01 | |
| *** cody-somerville has joined #openstack-horizon | 18:02 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Sort images list in ascending alphabetical order https://review.openstack.org/130844 | 18:04 |
| *** annashen has joined #openstack-horizon | 18:07 | |
| *** dsneddon is now known as dsneddon_biab | 18:09 | |
| *** akrivoka has joined #openstack-horizon | 18:10 | |
| *** annashen has quit IRC | 18:13 | |
| *** annashen has joined #openstack-horizon | 18:15 | |
| *** dsneddon_biab is now known as dsneddon | 18:25 | |
| *** bluex-pl has quit IRC | 18:30 | |
| *** jingjing_ren has joined #openstack-horizon | 18:31 | |
| *** lapalm has joined #openstack-horizon | 18:34 | |
| *** lapalm has left #openstack-horizon | 18:34 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style cleanup for Flavor Step https://review.openstack.org/192828 | 18:35 |
| *** jingjing_ren has quit IRC | 18:35 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - style guide cleanup for table and basic-table https://review.openstack.org/190354 | 18:36 |
| *** ZZelle_ has joined #openstack-horizon | 18:41 | |
| *** lhcheng has joined #openstack-horizon | 18:43 | |
| *** akrivoka has quit IRC | 18:48 | |
| *** Longgeek has joined #openstack-horizon | 18:48 | |
| *** mtecer has joined #openstack-horizon | 18:50 | |
| *** ttrifonov is now known as zz_ttrifonov | 18:53 | |
| *** Longgeek has quit IRC | 18:53 | |
| *** tqtran_ has joined #openstack-horizon | 18:55 | |
| *** oro_ has quit IRC | 18:55 | |
| *** sjmc7 has quit IRC | 18:56 | |
| *** jingjing_ren has joined #openstack-horizon | 18:56 | |
| *** jingjing_ren has quit IRC | 18:57 | |
| *** mtecer has quit IRC | 19:02 | |
| *** jtriley has joined #openstack-horizon | 19:03 | |
| *** siaras-alexd has quit IRC | 19:04 | |
| *** Sukhdev_ has joined #openstack-horizon | 19:10 | |
| *** fifieldt_ has quit IRC | 19:12 | |
| *** Sukhdev has quit IRC | 19:13 | |
| *** openstackgerrit has quit IRC | 19:16 | |
| *** openstackgerrit has joined #openstack-horizon | 19:17 | |
| *** jtriley has quit IRC | 19:18 | |
| *** Piet has quit IRC | 19:19 | |
| openstackgerrit | Duk Loi proposed openstack/horizon: Add support for root enable and show https://review.openstack.org/183196 | 19:20 |
| *** cardeois has quit IRC | 19:22 | |
| *** cardeois has joined #openstack-horizon | 19:23 | |
| *** gyee has quit IRC | 19:25 | |
| *** jtriley has joined #openstack-horizon | 19:26 | |
| *** mtecer has joined #openstack-horizon | 19:27 | |
| *** jingjing_ren has joined #openstack-horizon | 19:27 | |
| *** tjones1 has quit IRC | 19:29 | |
| *** fifieldt_ has joined #openstack-horizon | 19:29 | |
| *** jingjing_ren has quit IRC | 19:32 | |
| *** jingjing_ren has joined #openstack-horizon | 19:33 | |
| asahlin | clu_: I see you started JP cleanup on Launch Instance wizard. Has the cleanup effort been divided up for that already? Or looking for assistance? | 19:33 |
| *** nlahouti has quit IRC | 19:39 | |
| *** kztsv_mbp has joined #openstack-horizon | 19:43 | |
| *** kztsv_mbp has quit IRC | 19:48 | |
| *** jphor has joined #openstack-horizon | 19:49 | |
| *** Longgeek has joined #openstack-horizon | 19:49 | |
| *** kztsv_mbp has joined #openstack-horizon | 19:51 | |
| *** jtriley has quit IRC | 19:52 | |
| *** Piet has joined #openstack-horizon | 19:53 | |
| *** zz_ttrifonov is now known as ttrifonov | 19:53 | |
| *** jphor has quit IRC | 19:54 | |
| *** Jean-Paul has joined #openstack-horizon | 19:55 | |
| r1chardj0n3s | morning | 19:58 |
| *** alexvictorchan has quit IRC | 19:58 | |
| *** alexvictorchan_ has joined #openstack-horizon | 19:58 | |
| *** Ctina_ has quit IRC | 19:59 | |
| *** mrunge has joined #openstack-horizon | 19:59 | |
| *** stevemar has quit IRC | 20:00 | |
| mpavlase | svasheka: are you still here? mtng already started... | 20:01 |
| *** tjones1 has joined #openstack-horizon | 20:02 | |
| *** jtriley has joined #openstack-horizon | 20:04 | |
| *** neillc_away is now known as neillc | 20:05 | |
| *** sjmc7 has joined #openstack-horizon | 20:06 | |
| *** Longgeek has quit IRC | 20:06 | |
| openstackgerrit | pratap vedula proposed openstack/horizon: Made changes per doc conventions to 2012_1.rst, 2012_2.rst, 2013_1.rst ,2013_2.rst, 2014_1.rst and 2014_2.rst https://review.openstack.org/175045 | 20:07 |
| *** harlowja has joined #openstack-horizon | 20:13 | |
| *** klindgren_ has joined #openstack-horizon | 20:13 | |
| *** Jean-Paul has quit IRC | 20:22 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style cleanup for Flavor Step https://review.openstack.org/192828 | 20:25 |
| *** jprovazn has quit IRC | 20:29 | |
| *** e0ne has quit IRC | 20:32 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 20:33 |
| *** e0ne has joined #openstack-horizon | 20:33 | |
| *** mtecer has quit IRC | 20:33 | |
| *** mou has quit IRC | 20:37 | |
| *** mou has joined #openstack-horizon | 20:38 | |
| *** e0ne has quit IRC | 20:41 | |
| tqtran_ | ducttape_:question, what is your real name? i have no idea who you are lol | 20:41 |
| ducttape_ | eric peterson | 20:42 |
| ducttape_ | you know me ;) | 20:43 |
| *** absubram has quit IRC | 20:44 | |
| *** gyee has joined #openstack-horizon | 20:46 | |
| *** nlahouti has joined #openstack-horizon | 20:47 | |
| tqtran_ | oh wth lol, why the name change? | 20:48 |
| tqtran_ | ericpeterson not good enough for you? | 20:49 |
| lhcheng | david-lyle: the magic search tar contains the .git folder https://pypi.python.org/pypi/XStatic-Magic-Search | 20:49 |
| lhcheng | david-lyle: is this something for infra or we need to fix on our side? | 20:49 |
| ducttape_ | tqtran_ - ducttape_ is my name in other spots, it's all about consistent branding ;) | 20:49 |
| tqtran_ | i see | 20:50 |
| tqtran_ | i should rebrand as well :/ | 20:50 |
| r1chardj0n3s | IRC really needs the ability to attach real names to accounts : | 20:53 |
| tqtran_ | time for a startup r1chardj0n3s | 20:53 |
| r1chardj0n3s | (actually, it probably does have that, but I'm just too clueless) | 20:53 |
| *** josecastroleon1 has quit IRC | 20:53 | |
| klindgren_ | david-lyle, its seems like the tarball that should have been uploaded to pypi is actually the xstatic-magic-search/dist/XStatic-Magic-Search-0.2.0.1.tar.gz - seems like someone built a dist package and then tar'd up the entire git repo that was checked out and uploaded that to pypi- vs's the built dist package. | 20:53 |
| tqtran_ | r1chardj0n3s:looks like you can request info on the nick | 20:53 |
| *** josecastroleon has joined #openstack-horizon | 20:54 | |
| r1chardj0n3s | oh, look, "/whois ducttape_" | 20:55 |
| *** dguerri` is now known as dguerri | 20:55 | |
| r1chardj0n3s | doesn't always work, for eg hurgleburgler | 20:55 |
| *** alexvictorchan_ has quit IRC | 20:56 | |
| hurgleburgler | Nope, its completely accurate: real name: Adium User | 20:56 |
| ducttape_ | TravT Piet david-lyle - if I can help with any offsite stuff, please let me know. Maybe some type of hike or other event in old town / brewery tour, I can try to get something going. | 20:58 |
| ducttape_ | offsite/midcycle | 20:59 |
| Piet | Roughly how many people? Need to look into getting a conference room for a few days. | 21:00 |
| * r1chardj0n3s AFKs for a while | 21:01 | |
| r1chardj0n3s | (and I have no idea how to set my "away" message, so I'll be going fishing) | 21:01 |
| tqtran_ | ducttape_: ooo hike and brewery | 21:01 |
| krotscheck | So, I need help mapping the jscs rules to eslint rules. | 21:02 |
| ducttape_ | Piet - I'd bet 5-15, but hp might send a ton | 21:02 |
| tqtran_ | you guys have shade in fort collins or should i bring an umbrella? | 21:02 |
| krotscheck | Because i wasn't part of the discussion when horizon set its exceptions. | 21:02 |
| *** pauloewerton has quit IRC | 21:02 | |
| *** lblanchard has quit IRC | 21:03 | |
| *** gyee has quit IRC | 21:03 | |
| Piet | The rattlers are in the shade | 21:03 |
| krotscheck | r1chardj0n3s: You seem to be the most opinionated about enforcing rules. Would you like to help? | 21:03 |
| ducttape_ | in the morning, they are in the sun. once it reaches 105F they like to cool off ;) | 21:03 |
| *** petertr7 is now known as petertr7_away | 21:03 | |
| ducttape_ | krotscheck - he is AFK for a bit | 21:03 |
| tqtran_ | krotscheck: i think clu_ is volunteering to help you | 21:04 |
| Piet | Yeah, I always run into them on the trail in the evening when it cools | 21:04 |
| *** bluex-pl has joined #openstack-horizon | 21:04 | |
| *** annashen has quit IRC | 21:05 | |
| Piet | Real quick: take a look at the patterns library and feel free to make changes: https://wiki.openstack.org/wiki/UX/PatternsLibrary | 21:05 |
| Piet | Research results with downloadable PDF presentations here: | 21:06 |
| Piet | https://wiki.openstack.org/wiki/HorizonUsability_Testing | 21:06 |
| lhcheng | klindgren_: seems like there is already a bug reported - https://bugs.launchpad.net/horizon/+bug/1451567 | 21:06 |
| openstack | Launchpad bug 1451567 in OpenStack Dashboard (Horizon) "XStatic-Magic-Search pypi package has errors" [Undecided,New] | 21:06 |
| lhcheng | klindgren_: no idea if its an infra issue or horizon config issue | 21:07 |
| mrunge | lhcheng, klindgren_ that's an issue of how the package was produced | 21:08 |
| klindgren_ | lhcheng, pretty sure its in infra issue - looks like someone tar'd up the git directory that was checked out, vs's uploading the dist tarball | 21:08 |
| mrunge | those packages live on stackforge | 21:08 |
| kztsv_mbp | Since the tests were brought up in the meeting, I'd want to note, that horizon still runs it's tests under PYTHONHASHSEED=0. I've been tinkering with the test for a while, and came up with this https://review.openstack.org/#/c/191567/ patch to disable that requirement. I get that it's not top priority (given how long this has been a thing) but still would be happy to help with the issue =) | 21:09 |
| r1chardj0n3s | krotscheck: I'm not the one who's opinionated about us making a tool change :) | 21:09 |
| r1chardj0n3s | krotscheck: on a more serious note, my plate is full at the moment, sorry :/ | 21:09 |
| lhcheng | mrunge: I supposed we need to contact " Author: Randy Bertram " ? | 21:10 |
| *** Sukhdev_ has quit IRC | 21:10 | |
| mrunge | lhcheng, yes, that'll be my best guess | 21:10 |
| lhcheng | rbertram: ping | 21:10 |
| mrunge | or tqtran as he also packaged xstatic up | 21:10 |
| tqtran_ | Piet: i am interested to see what you have for simple modal, i think the responsive table should be pretty solid | 21:11 |
| r1chardj0n3s | you can't blame tqtran_ for that package ;) | 21:11 |
| mrunge | r1chardj0n3s, right. | 21:11 |
| r1chardj0n3s | rbertram needs to fix it | 21:11 |
| r1chardj0n3s | xstatic needs to die in a fire, also | 21:11 |
| tqtran_ | lol | 21:11 |
| *** jtriley has quit IRC | 21:11 | |
| mrunge | but tqtran is currently the person with most experience there | 21:11 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS - Demo patch for error filter https://review.openstack.org/190307 | 21:12 |
| mrunge | since rdopiera left | 21:12 |
| r1chardj0n3s | oh, man, I thought you *liked* thai too | 21:12 |
| tqtran_ | lol | 21:12 |
| r1chardj0n3s | and you go and say something like that? :) | 21:12 |
| * tqtran_ ducks under | 21:12 | |
| mrunge | wh? | 21:12 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS - Allow ignoring specific kinds of errors https://review.openstack.org/190305 | 21:12 |
| mrunge | who? | 21:12 |
| Piet | tqtran: which modal are you working on? | 21:12 |
| tqtran_ | Identity users modal | 21:12 |
| Piet | Add/edit user? | 21:13 |
| tqtran_ | basically it looks the same way as it does today, i didnt do any styling on it, but since we're changing it anyway, would be good to have it look more like the launch instance | 21:13 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Integration tests - Object store https://review.openstack.org/151187 | 21:13 |
| Piet | k | 21:13 |
| tqtran_ | add/edit/change password/etc.... | 21:13 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS - Allow ignoring specific kinds of errors https://review.openstack.org/190305 | 21:13 |
| tqtran_ | delete | 21:13 |
| tqtran_ | the whole shebang | 21:13 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Rename helpers.py to basetestcases.py https://review.openstack.org/154965 | 21:13 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Use default values in horizon.conf https://review.openstack.org/165102 | 21:14 |
| r1chardj0n3s | krotscheck so Tyr is someone you should reach out to - he's never on here AFAICT which is a shame | 21:14 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Use gen_resource_name in create/delete user test https://review.openstack.org/172858 | 21:14 |
| Piet | tqtran: Are you working on it now? | 21:14 |
| openstackgerrit | Martin Pavlásek proposed openstack/horizon: Refactor of BaseTestCase https://review.openstack.org/190077 | 21:14 |
| r1chardj0n3s | krotscheck: given that he has a patch in flight for JSCS tweaking | 21:14 |
| tqtran_ | Piet: not actively, still working on pushing translation and autodiscovery through first | 21:14 |
| tqtran_ | once the infra pieces are in, i will push for the identity panel | 21:15 |
| *** bluex-pl has quit IRC | 21:15 | |
| Piet | tqtran: how soon do you need mocks? | 21:15 |
| tqtran_ | the sooner the better, just so we can start discussions | 21:15 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS - Demo patch for error filter https://review.openstack.org/190307 | 21:16 |
| klindgren_ | lhcheng, rbertram - updated that bug with what I see - https://bugs.launchpad.net/horizon/+bug/1451567/comments/1 looks like the correct tarball jsut needs to be uploaded to pypi | 21:17 |
| openstack | Launchpad bug 1451567 in OpenStack Dashboard (Horizon) "XStatic-Magic-Search pypi package has errors" [Undecided,New] | 21:17 |
| *** tqtran_ has quit IRC | 21:19 | |
| lhcheng | klindgren_: bumped up the priority of the bug | 21:19 |
| *** mpavlase has quit IRC | 21:19 | |
| david-lyle | klindgren_: I'll try to track that down, the publish script that pushed to pypi doesn't like the ...# releases | 21:21 |
| *** peristeri has quit IRC | 21:21 | |
| david-lyle | and doesn't push them | 21:21 |
| tqtran | neillc: do you have some time to work on the makemessages patch today? | 21:22 |
| *** openstackgerrit has quit IRC | 21:24 | |
| *** openstackgerrit has joined #openstack-horizon | 21:24 | |
| neillc | tqtran: sure do | 21:25 |
| tqtran | coolios, lets try and get that patch merge | 21:25 |
| tqtran | so we can proceed to the next step | 21:26 |
| neillc | Sounds like a plan. Just have to wake my wife up with coffee and then I'll start on your latest comments. | 21:26 |
| asahlin | r1chardj0n3s: ongk: robcresswell: Cindy started JP cleanup on Launch Instance wizard's flavor step. Just checking to see if any of you have started JP'ing any other Lauch Instance's steps? | 21:27 |
| asahlin | r1chardj0n3s: ongk: robcresswell: If not, I will start at the top with configuration | 21:27 |
| r1chardj0n3s | asahlin: nope, I'm still trying to figure out what's up for grabs ;) | 21:27 |
| asahlin | r1chardj0n3s: afaik, I think the horizon branch is well underway, dashboard side not so much. | 21:29 |
| r1chardj0n3s | ok | 21:29 |
| *** kztsv_mbp has quit IRC | 21:30 | |
| *** jbell8 has quit IRC | 21:32 | |
| *** asahlin is now known as asahlin_away | 21:32 | |
| *** jingjing_ren has quit IRC | 21:33 | |
| krotscheck | clu_: So, tqtran mentioned you'd be interested in helping figuring out the leftover style rules? | 21:33 |
| *** alexvictorchan has joined #openstack-horizon | 21:36 | |
| clu_ | hi krotscheck | 21:37 |
| clu_ | yes, i can help figure those out | 21:38 |
| krotscheck | clu_: Excellent, thanks! | 21:40 |
| krotscheck | clu_: I'm currently trying to find the correct mapping for requireCamelCaseOrUpperCaseIdentifiers | 21:40 |
| *** kztsv_mbp has joined #openstack-horizon | 21:40 | |
| *** annashen has joined #openstack-horizon | 21:42 | |
| tyr | r1chardj0n3s: You were looking for me? | 21:43 |
| clu_ | krotscheck: http://eslint.org/docs/rules/camelcase#options - {"camelcase": [2, {"properties": "never"}]} -- seems equivalent | 21:43 |
| *** jingjing_ren has joined #openstack-horizon | 21:44 | |
| krotscheck | clu_: Thanks! | 21:45 |
| r1chardj0n3s | tyr: ohai, krotscheck is trampling all over your jscs work at the moment by switching us to eslint, thought you should get in on the action :) | 21:46 |
| * r1chardj0n3s ducks | 21:46 | |
| krotscheck | r1chardj0n3s: Can we please not use aggressive words like "Trample"? | 21:46 |
| tyr | lol | 21:46 |
| krotscheck | Anyone know how to express "space-unary-ops": [1, { "words": true, "nonwords": true }] in YAML? | 21:47 |
| r1chardj0n3s | krotscheck: :) | 21:47 |
| * krotscheck is unclear about the object-in-a-list thing | 21:47 | |
| r1chardj0n3s | krotscheck: "stomp"? :) | 21:47 |
| r1chardj0n3s | (sorry, I'll try to reign in my Australian Sarcasm) | 21:48 |
| krotscheck | tyr, clu_: I'm currently converting line30 of https://review.openstack.org/#/c/192327/2/.jscsrc over | 21:49 |
| *** tjones1 has quit IRC | 21:51 | |
| *** crobertsrh has quit IRC | 21:51 | |
| tyr | any background on the motivation for the eslint change? | 21:52 |
| r1chardj0n3s | tyr: consistency of tool use across openstack projects - there was an openstack-dev mail about it | 21:52 |
| openstackgerrit | Doug Hellmann proposed openstack/horizon: Update version for Liberty https://review.openstack.org/192403 | 21:53 |
| krotscheck | tyr: Several. 1) It's on the roadmap for horizon, 2) JSCS is only limited to code style, not bug detection, to which it defers to JSHint, 3) We can't use JSHint because of licensing, 4) ESlint does both JSCS and JSHint's job in one tool. | 21:54 |
| tyr | looks better documented and easier to tweak to boot | 21:54 |
| krotscheck | If JSHint didn't have a stupid license, I'd be recommending that. | 21:54 |
| krotscheck | tyr: That too | 21:55 |
| r1chardj0n3s | thanks for the more detailed response krotscheck | 21:55 |
| * r1chardj0n3s is preparing breakfast and trying to get daughter ready for school | 21:55 | |
| * krotscheck is peering at requireSpaceAfterKeywords | 21:55 | |
| tyr | krotscheck: with jscs I was able to add a filter so that errors in certain well known situations (like gettext line too long) could be ignored without littering the code with comments. | 21:56 |
| krotscheck | tyr: That seems useful. | 21:57 |
| krotscheck | tyr: That also seems like something x-project-relevant | 21:57 |
| *** ZZelle_ has quit IRC | 21:57 | |
| r1chardj0n3s | yeah, my main concern was that all the discussion we've had around getting jscs configuration right-for-Horizon isn't lost in the switch to eslint | 21:57 |
| tyr | have you seen ways we can get similar error filtering in the eslint rule configs? | 21:57 |
| krotscheck | Checking | 21:57 |
| krotscheck | I haven't. | 21:57 |
| krotscheck | But I can look | 21:57 |
| krotscheck | Huhn. We can publish eslint-config-openstack. | 21:58 |
| krotscheck | That's useful. | 21:58 |
| *** doug-fish has left #openstack-horizon | 21:58 | |
| r1chardj0n3s | what does "publish eslint-config-openstack" mean? As in encapsulate it and put it out in the tubes for discovery? | 22:00 |
| krotscheck | r1chardj0n3s: npm publish. | 22:00 |
| r1chardj0n3s | oh, cool | 22:00 |
| r1chardj0n3s | altho ... packagers ain't gonna like it :/ | 22:00 |
| krotscheck | r1chardj0n3s: Well, right now linting and karma tests are "Developer tools" not required to build the package. | 22:02 |
| krotscheck | r1chardj0n3s: Sooner or later, I expect all of horizon will become a "Developer tool" | 22:02 |
| krotscheck | ;) | 22:02 |
| r1chardj0n3s | sure, but deployers like to be able to just use system packages, and deployers like to create their own extensions... | 22:02 |
| r1chardj0n3s | *I* understdand the insanity of that, don't you worry :) | 22:02 |
| r1chardj0n3s | just flagging a potential hurdle | 22:02 |
| krotscheck | r1chardj0n3s: Well then, packagers are more than happy to help us maintain the code necessary to do the things that they need for packaging. | 22:03 |
| krotscheck | Don't get me wrong, I've got "Fix NPM" and "Fix Bower" on my roadmap. | 22:03 |
| r1chardj0n3s | small TODO list then ;) | 22:03 |
| krotscheck | It's just that "Get OpenStack to publish to those two" Is ahead of that in the priority list. | 22:03 |
| *** Longgeek has joined #openstack-horizon | 22:03 | |
| r1chardj0n3s | mmm | 22:03 |
| *** mrunge has quit IRC | 22:03 | |
| krotscheck | r1chardj0n3s: You have seen my roadmap, right? https://etherpad.openstack.org/p/modern-javascript-roadmap | 22:03 |
| r1chardj0n3s | yep, I'm just not sure packages have seen it | 22:04 |
| r1chardj0n3s | I know you want to solve the problem, but I worry :) | 22:05 |
| krotscheck | tyr: I don't see anything that explicitly permits error filters. There might be a way that we can write our own custom rule for those things. | 22:05 |
| tyr | are you using any custom rules so far? | 22:05 |
| *** tvanderwiel has quit IRC | 22:06 | |
| tyr | looks like existing max-len at the moment. | 22:06 |
| *** crobertsrh has joined #openstack-horizon | 22:08 | |
| tyr | ah ha! "Runtime Rules" --rulesdir | 22:09 |
| krotscheck | tyr: Other than the angular plugin, no. I wanted to get everyone on the same tool before I create eslint-plugin-openstack | 22:10 |
| *** KunalGandhi has quit IRC | 22:11 | |
| tyr | krotscheck: Looks like we can provide our own rules via --rulesdir and a directory in the horizon source. I'll experiment with a custom version of max-len and make it dependent on your patch. | 22:11 |
| krotscheck | tyr: Thanks | 22:11 |
| *** KunalGandhi has joined #openstack-horizon | 22:11 | |
| krotscheck | tyr: Once I get the eslint plugin repo set up, we can share it, too. | 22:12 |
| tyr | krotscheck: r1chardj0n3s: presumably I should just abandon the JSCS error filter patches now? | 22:13 |
| r1chardj0n3s | yeah | 22:13 |
| tyr | roger. thx | 22:13 |
| r1chardj0n3s | sorry for the wasted effort, altho it was very useful to have the conversation around it! | 22:13 |
| tyr | np. on the surface eslint looks like a better tool anyhow | 22:14 |
| tyr | and the error filter gives us an example of exceptions that we want whatever tool to be capable of. | 22:15 |
| openstackgerrit | Andrew Lazarev proposed openstack/horizon: [Sahara] Added support of placeholders in datasource URLs https://review.openstack.org/158918 | 22:16 |
| krotscheck | tyr: disallowMultipleLineBreaks - > Is there a max to the number of line breaks? I can configure that. | 22:17 |
| *** julim has quit IRC | 22:19 | |
| tyr | krotscheck: I don't have any special knowledge about the rules selected for JSCS. Of the top of my head, anything more than 1 blank line...someone will disagree about it :) | 22:19 |
| krotscheck | tyr: Works for me. | 22:20 |
| krotscheck | tyr: For the record: There's a bunch of rules that are implicit and/or defaulted in JSCS, that need to be manually enabled in eslint. | 22:21 |
| krotscheck | tyr: That's really the tricky part to figure out | 22:21 |
| tyr | With great power comes great responsibility | 22:21 |
| tyr | krotscheck: you are running eslint by hand for now? | 22:23 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 22:23 |
| krotscheck | tyr: `npm run lint` | 22:23 |
| tyr | ok...just curious why your patch didn't modify run_tests.sh | 22:24 |
| krotscheck | There. That patch adds the rules from the .jscrc. It moves the needle up to about 1800 style violations. | 22:24 |
| krotscheck | tyr: Oooh, good catch. | 22:24 |
| tyr | consider a few comments in the commit msg for those of us new to this tool | 22:25 |
| tyr | (about how to run) | 22:25 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 22:26 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 22:27 |
| krotscheck | tyr: ^^ Done | 22:27 |
| tyr | krotscheck: not adding a eslint option? | 22:27 |
| krotscheck | tyr: Isn;'t run_tests.sh deprecated? | 22:27 |
| tyr | not sure. We had updated it for karma | 22:28 |
| tyr | krotscheck: when I run this, I get the 1127 problems output, but then "npm ERR!"...is that expected? | 22:29 |
| krotscheck | tyr: Yep. If the tests passed, that ERR wouldn't be tehre. | 22:29 |
| krotscheck | tyr: What's actually happening there is that NPM is setting up a venv-like environment in which to execute the installed eslint, and is then coming back and saying: Hey that didn't work. | 22:30 |
| tyr | maybe dumb question...why npm run lint instead of "eslint" ? | 22:30 |
| krotscheck | The error messages are not helpful. | 22:30 |
| krotscheck | tyr: If you have eslint installed globally, go for it. | 22:30 |
| tyr | i meant, instead of "npm run eslist" | 22:31 |
| krotscheck | tyr: The npm invocation just simplifies all the various commandline options (see package.json -> scripts -> lint) | 22:31 |
| krotscheck | Oh | 22:31 |
| tyr | er..."npm run eslint" was what I was expecting | 22:32 |
| krotscheck | tyr: https://review.openstack.org/#/c/188133/3/jenkins/jobs/javascript.yaml | 22:32 |
| krotscheck | lint is the generic "Hey do a linting thing" in infra. | 22:32 |
| tyr | I see. ok. | 22:32 |
| krotscheck | I called it that because, quite frankly, the speed at which javascript evolves means that eslint might not be a thing 2 years down the road. | 22:32 |
| krotscheck | But we want to keep the command the same. | 22:33 |
| * krotscheck doesn't really have an opinion on that name. | 22:33 | |
| krotscheck | We can always change it. | 22:33 |
| krotscheck | Opinions? | 22:33 |
| tyr | makes sense. Just groking it as a makefile target name | 22:34 |
| *** dguerri is now known as dguerri` | 22:34 | |
| krotscheck | kk | 22:35 |
| krotscheck | There's a bunch of rules I had to deactivate which made me a little leery. | 22:35 |
| krotscheck | For example: semi | 22:35 |
| *** Longgeek has quit IRC | 22:36 | |
| tyr | why semi deactivated for example? | 22:37 |
| *** yamamoto has joined #openstack-horizon | 22:37 | |
| *** yamamoto has quit IRC | 22:42 | |
| krotscheck | tyr: Why is semi deactivated? | 22:43 |
| krotscheck | tyr: Because I was told "Do only what JSCS does and nothing more. | 22:43 |
| tyr | ah. sure. | 22:44 |
| tqtran | tyr: could you get sqchen online? | 22:44 |
| tyr | semi seems sensible, but maybe we only apply it to non-angular code | 22:44 |
| tqtran | wanted to help him debug the tempest issue | 22:45 |
| tqtran | i think im onto something | 22:45 |
| tyr | great! I just pinged him. Thanks tqtran | 22:45 |
| *** jasondotstar has joined #openstack-horizon | 22:45 | |
| krotscheck | Mind you, there's only 2 occurrences of it. | 22:45 |
| krotscheck | And one duplicate semi | 22:45 |
| tyr | only two errors flagged by semi? | 22:45 |
| krotscheck | Yep. | 22:46 |
| krotscheck | Might as well just turn it on. | 22:46 |
| tyr | no objection here | 22:46 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 22:46 |
| *** josecastroleon has quit IRC | 22:47 | |
| *** josecastroleon has joined #openstack-horizon | 22:48 | |
| *** KunalGandhi has quit IRC | 22:50 | |
| krotscheck | tyr: What timezone are you in? | 22:51 |
| *** oro_ has joined #openstack-horizon | 22:51 | |
| tyr | US Mountain | 22:51 |
| tyr | GMT-7 | 22:51 |
| krotscheck | tyr. PDT for me, Seattle. | 22:51 |
| tyr | oops. GMT-6 currently. | 22:52 |
| tyr | Fort Collins | 22:52 |
| krotscheck | tyr: I'm done for the day though. I'll be able to throw some hours at reducing the linting violations tommorrow, how are you guys splitting up the work? | 22:52 |
| krotscheck | tyr: HP? | 22:52 |
| tyr | yep | 22:52 |
| krotscheck | tyr: Hah. Me too. | 22:52 |
| krotscheck | THere's a lot of us :/ | 22:53 |
| *** cardeois has quit IRC | 22:53 | |
| *** Ephur has quit IRC | 22:53 | |
| tyr | HA! Sheesh. I joined this org in Jan so I'm still learning who is who :) | 22:53 |
| tyr | sure enough...you in HipChat ever? | 22:54 |
| krotscheck | tyr: No worries. I'm with mordred's team, so we're the wacky special snowflakes who get to work upstream. | 22:54 |
| krotscheck | tyr: WHen it works, yeah. | 22:54 |
| tyr | gotta split in a few too. At the moment, Sean and I are able to focus upstream, the rest of the HP Horizon team has "real" jobs ;) | 22:55 |
| *** ducttape_ has quit IRC | 22:55 | |
| *** dboik_ has quit IRC | 22:56 | |
| *** dboik has joined #openstack-horizon | 22:56 | |
| tyr | at least for the last few weeks. The upstream emphasis comes in waves. | 22:57 |
| *** lhcheng has quit IRC | 22:59 | |
| *** sqchen has joined #openstack-horizon | 22:59 | |
| sqchen | Hi tqtran: | 23:00 |
| tqtran | hi sean, i left a comment on your patch | 23:00 |
| sqchen | let me take a look... | 23:01 |
| openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 23:01 |
| tqtran | i think it has something to do with compression? | 23:01 |
| *** gyee has joined #openstack-horizon | 23:01 | |
| *** lhcheng has joined #openstack-horizon | 23:01 | |
| *** oro_ has quit IRC | 23:02 | |
| *** lhcheng has quit IRC | 23:02 | |
| *** lhcheng has joined #openstack-horizon | 23:02 | |
| *** Drago has quit IRC | 23:03 | |
| *** KunalGandhi has joined #openstack-horizon | 23:04 | |
| tqtran | sqchen: https://github.com/openstack/horizon/blob/master/openstack_dashboard/templates/horizon/_scripts.html#L117 | 23:07 |
| tqtran | notice how the discovered files are included inside of a compress block | 23:07 |
| r1chardj0n3s | tqtran: heh, you ran into that thing in my patch that annoyed me and I filed a bug about it because we all missed it in Ryan's API patch :) | 23:07 |
| tqtran | really? linky | 23:08 |
| r1chardj0n3s | https://bugs.launchpad.net/horizon/+bug/1465885 | 23:08 |
| openstack | Launchpad bug 1465885 in OpenStack Dashboard (Horizon) "API reorg retained some framework/dashboard crossover" [Undecided,New] | 23:08 |
| tqtran | :( yeah i didnt catch that either | 23:09 |
| tqtran | ugh... what a nightmare, we need to fix that | 23:09 |
| r1chardj0n3s | yeah. I'm still to look into how to fix it. I suspect it's because the framework config thing can look up settings stuff through the API | 23:10 |
| sqchen | I haven’t got it yet, what is the issue with tempest? | 23:10 |
| tqtran | sqchen: im not 100% sure, but i think the autodiscovery introduced something that is causing js compression to fail | 23:11 |
| tqtran | what that "something" is requires further investigation | 23:11 |
| sqchen | Ok I see, I will turn on my comtressor and try. | 23:12 |
| tqtran | r1chardj0n3s: so i did a search for openstack-service-api in horizon/horizon | 23:13 |
| tqtran | karma.conf.js and dashboard-app.module.js are the only 2 files using it | 23:13 |
| tqtran | my recommendation would be to simply remove it from horizon/karma.conf | 23:13 |
| r1chardj0n3s | try it ;) | 23:13 |
| r1chardj0n3s | something depends on it :) | 23:13 |
| *** tjones1 has joined #openstack-horizon | 23:13 | |
| tqtran | ok i shall try | 23:14 |
| tqtran | let me pull down your patch | 23:14 |
| r1chardj0n3s | nono, just do it in master | 23:14 |
| tqtran | well of course i will fail in master | 23:14 |
| tqtran | because you havent move dashboard module yet | 23:14 |
| r1chardj0n3s | ah, yeah, good point. but even so, it's not related to that I think | 23:15 |
| r1chardj0n3s | as in, there's other failures. let me investigate | 23:15 |
| r1chardj0n3s | you've got other things you could be doing, I'm sure ;) | 23:15 |
| tqtran | lol like the xstatic stuff? | 23:16 |
| * tqtran ducks. | 23:16 | |
| r1chardj0n3s | hmm. I can't pull down from git.o.o :/ | 23:16 |
| *** sjmc7 has quit IRC | 23:18 | |
| r1chardj0n3s | ugh, I wish karma wouldn't spit out these angular $injector error URLs when injection failed :/ | 23:18 |
| tqtran | sqchen: just enabled compression in settings.py, its passing still ;/ | 23:20 |
| tqtran | https://github.com/django-compressor/django-compressor/issues/169 | 23:20 |
| sqchen | hm | 23:20 |
| tqtran | :) got it!!!!!!!!!!!!!!!!!!! | 23:21 |
| tqtran | add COMPRESS_OFFLINE = True to settings.py | 23:22 |
| sqchen | what is it!? | 23:22 |
| tqtran | you will get the same error in tempest | 23:22 |
| sqchen | Yes, this is what I was thinking about, there is no JS to be found yet. | 23:23 |
| tqtran | that cant be true | 23:24 |
| tqtran | because once you start the server, you see the log outputting the discovered files | 23:25 |
| tqtran | and i believe compression happens when you make a request to django | 23:25 |
| tqtran | let me try somethings and see if it helps | 23:26 |
| sqchen | but if COMPRESS_OFFLINE = True if should be compressed before the server get started. | 23:26 |
| sqchen | Thx a log for your help, tqtran: | 23:27 |
| tqtran | hm that might be true too lol | 23:27 |
| * david-lyle never gets logs :( | 23:27 | |
| tqtran | sqchen: https://review.openstack.org/#/c/191592/10/openstack_dashboard/utils/settings.py L116 | 23:28 |
| tqtran | this is where you are invoking the autodiscovery right? | 23:28 |
| tqtran | the question is, does this happen before or after compression? | 23:29 |
| sqchen | This is where I discover files from enabled dashboards. | 23:30 |
| tqtran | but.... does it matter? if there is nothing there, it should still pass right? | 23:30 |
| r1chardj0n3s | tqtran: ok, this is weird. that whole thing about that line in karma.conf isn't a thing any more and I'm not sure I understand why :) | 23:31 |
| *** ttrifonov is now known as zz_ttrifonov | 23:31 | |
| sqchen | It happens before the setting.py | 23:31 |
| tqtran | r1chardj0n3s: lol its not weird, it make sense to me | 23:31 |
| tqtran | if its not getting use in horizon, then removing it from karma.conf shouldnt be an issue right? | 23:31 |
| r1chardj0n3s | haha, sure. it was BROKEN yesterday I tell you BROKEN!!!!~!!!111!!! | 23:31 |
| tqtran | lol | 23:32 |
| * r1chardj0n3s slinks away | 23:32 | |
| sqchen | tqtran, so if other files from framework get discovered, these files from openstack_dashoard already discovered. | 23:32 |
| r1chardj0n3s | tqtran: and you really, really want me to still log "an error occurred" eh? OK then | 23:32 |
| tqtran | r1chardj0n3s: lol yes, that would be preferable | 23:35 |
| sqchen | tqtran: the system works in this order: discover files for enabled dashboards first, and then the others. | 23:35 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app to dashboard https://review.openstack.org/185191 | 23:36 |
| tqtran | sqchen: sorry, im not following. so you're saying compression happens before settings.py is invoke? | 23:36 |
| tqtran | and hence, there is actually no files in there? | 23:36 |
| *** mou has quit IRC | 23:36 | |
| sqchen | I said two things: | 23:36 |
| sqchen | 1) The offline compression happens without running the settings.py | 23:37 |
| *** mou has joined #openstack-horizon | 23:37 | |
| *** chlong has joined #openstack-horizon | 23:38 | |
| sqchen | 2) During the discovery, the files from openstack_dashboard get discovered first, and then: | 23:38 |
| sqchen | a. openstack-service-api | 23:38 |
| sqchen | b. dashboard/core/ | 23:39 |
| sqchen | c. ./horizon/static/ | 23:39 |
| *** jingjing_ren has quit IRC | 23:39 | |
| sqchen | Yes, if compressed offline, there is no JS files form angular there yet. | 23:40 |
| sqchen | and the page got broken, since… | 23:40 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app to dashboard https://review.openstack.org/185191 | 23:40 |
| sqchen | the old JS now has dependencies on the angular js files. | 23:40 |
| neillc | tqtran: do you have time to look at https://review.openstack.org/#/c/188665/10 | 23:40 |
| tqtran | sqchen: i'll have to read more about offline compression, not really following..... | 23:41 |
| tqtran | but im debugging the compressor atm | 23:41 |
| tqtran | so should be able to narrow down the snippet that is causing us trouble | 23:41 |
| sqchen | yeah, we are making progess. :) | 23:41 |
| tqtran | neillc: did you get the comment about moving those keywords and stuff out into setup.cfg? | 23:42 |
| neillc | yes. I've replied on the patchset. | 23:42 |
| neillc | did most of them :) | 23:42 |
| neillc | keywords turn out to be more complicated I think, would like to deferr moving into cfg | 23:42 |
| tqtran | i dont see your comment, did you submit it? | 23:43 |
| neillc | tqtran: sigh no because I suck at gerrit. | 23:45 |
| tqtran | sqchen: ok got it to work | 23:48 |
| *** sqchen has left #openstack-horizon | 23:48 | |
| neillc | tqtran: comments should be there now | 23:48 |
| *** sqchen has joined #openstack-horizon | 23:48 | |
| tqtran | sqchen: we need to run "manage.py compress" first | 23:49 |
| tqtran | that solves the compression issue | 23:49 |
| sqchen | tqtran: ok, let me try. | 23:50 |
| tqtran | ./tools/with_venv.sh ./manage.py compress | 23:50 |
| tqtran | run that inside the horizon folder | 23:50 |
| *** nlahouti has quit IRC | 23:52 | |
| sqchen | yes, the console listed all the discovered files. | 23:54 |
| sqchen | looks correct to me. | 23:55 |
| *** garthb_ has quit IRC | 23:57 | |
| *** garthb has quit IRC | 23:57 | |
| tqtran | that should solve your tempest problem | 23:57 |
| tqtran | i'll do a bit more reading about offline compression | 23:57 |
| tqtran | and where it make sense for us to run that cmd | 23:58 |
| *** yamamoto has joined #openstack-horizon | 23:58 | |
| tqtran | neillc: i'll also do a bit more reading on setup.cfg, would be ideal if we can get it right first time around | 23:58 |
| tqtran | if its too complicated, i'll go ahead and +2 it through, otherwise, look forward to more comments! lol | 23:58 |
| sqchen | wait there are missing files from enabled dashboards. | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!