*** ZZelle_ has joined #openstack-horizon | 00:01 | |
*** ZZelle_ has quit IRC | 00:01 | |
*** Raildo has quit IRC | 00:02 | |
*** nlahouti has quit IRC | 00:02 | |
openstackgerrit | Neill Cox proposed openstack/horizon: Replace makemessages with babel https://review.openstack.org/188665 | 00:03 |
---|---|---|
*** petertr7_away is now known as petertr7 | 00:03 | |
neillc | r1chardj0n3s: fixed :) | 00:04 |
r1chardj0n3s | ok, Imma wait for the gate to speak and then +1 :) | 00:04 |
r1chardj0n3s | thanks for the name change | 00:04 |
*** tqtran_afk is now known as tqtran | 00:05 | |
tqtran | kfox1111: still there? | 00:05 |
tqtran | was busy earlier, i have some time now | 00:05 |
kfox1111 | yup. | 00:07 |
kfox1111 | I'm really close I think. just trying to figure out how to get the initial params from SelectTemplateView into TemplateForm. | 00:08 |
tqtran | ok cool, let me scroll up and read what you need and see if i can help | 00:09 |
kfox1111 | I'm not finding where the params from the get request are showing up. | 00:09 |
kfox1111 | and the heat stuff are not using workflow's so it doesn't just automatically happen. | 00:09 |
kfox1111 | so, in openstack_dashboard/dashboards/project/stacks/views.py:class SelectTemplateView(forms.ModalFormView) | 00:10 |
tqtran | ok got it | 00:10 |
tqtran | let me play with the code and see what i can find | 00:11 |
kfox1111 | I instrumented the TemplateForm __init__ but arn't seeing any of the get params in kwargs. | 00:11 |
kfox1111 | thanks. :) | 00:11 |
*** petertr7 is now known as petertr7_away | 00:12 | |
*** kztsv_mbp has joined #openstack-horizon | 00:13 | |
*** annashen has joined #openstack-horizon | 00:14 | |
tqtran | damn i cant log in, dont have heat enabled | 00:14 |
tqtran | er... ok meta code time | 00:14 |
tqtran | so let me take a step back and get clarification. you want to pass a query param and you want the view to extract it? | 00:15 |
kfox1111 | yeah. so it can set the default in the dropdown/text box. | 00:16 |
kfox1111 | so I think SelectTemplateView needs a get_initial member maybe. | 00:17 |
kfox1111 | but its still not clear to me where to fetch the query params. | 00:17 |
tqtran | ok lets take it one step at a time | 00:17 |
tqtran | so right now, you want to pass query param and extract from url in the view | 00:17 |
tqtran | is that where we are at? | 00:18 |
kfox1111 | yeah. I think so. | 00:18 |
*** kztsv_mbp has quit IRC | 00:18 | |
tqtran | ok gimme a sec to dig through code and see where we can extract the query param | 00:18 |
kfox1111 | k. thx. | 00:18 |
*** annashen has quit IRC | 00:19 | |
*** ybathia has joined #openstack-horizon | 00:21 | |
*** amotoki_ has joined #openstack-horizon | 00:23 | |
*** ybathia has quit IRC | 00:24 | |
*** yamamoto has joined #openstack-horizon | 00:24 | |
tqtran | ok got it | 00:24 |
*** alexvictorchan has quit IRC | 00:25 | |
tqtran | im gonna use the identity users panel as an example | 00:26 |
kfox1111 | k. | 00:26 |
*** Piet has quit IRC | 00:26 | |
tqtran | but it will work in your case as well | 00:26 |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/views.py#L153 | 00:26 |
tqtran | what you need is to add the get_initial method | 00:26 |
tqtran | in that method, you have access to self.request object | 00:26 |
*** gyee has quit IRC | 00:27 | |
kfox1111 | hmm.... ok. | 00:27 |
tqtran | so to get the query param, it is: self.request.GET.get('SOME_KEY_HERE') | 00:27 |
tqtran | or to see the entire query param, it is just self.request.GET | 00:27 |
tqtran | it is a dict | 00:27 |
tqtran | what you do next is return that object and it becomes incorporated as the initial object | 00:28 |
*** amotoki_ has quit IRC | 00:28 | |
kfox1111 | ok. trying it... | 00:28 |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/forms.py#L107 | 00:28 |
tqtran | and then in your modalFormView, you add an init method | 00:28 |
tqtran | this will give you access to the kwargs object | 00:29 |
tqtran | which will contain the initial object that you created in the view earlier | 00:29 |
tqtran | from there, you can do whatever you want in terms of populating the choicefields | 00:29 |
tqtran | hope that helps! | 00:29 |
kfox1111 | I think so. let me coder up real quick. | 00:29 |
*** yamamoto has quit IRC | 00:29 | |
kfox1111 | yup. the inital thing passed through... let me see if I can get the init function hooked up now. | 00:30 |
tqtran | :) nice | 00:30 |
kfox1111 | I think that may have done it.... testing end to end. | 00:33 |
kfox1111 | thats awesome. :) | 00:35 |
kfox1111 | totally worked. :) | 00:35 |
kfox1111 | thanks so much for the help. :) | 00:35 |
tqtran | :) np! | 00:36 |
tqtran | thats one crazy abstraction that hopefully angular will simplify | 00:37 |
kfox1111 | yeah. totally. | 00:38 |
kfox1111 | is there a class for making a link look like the button's ususally used in the rows? | 00:38 |
tqtran | just have to class it properly | 00:38 |
*** kcaj has joined #openstack-horizon | 00:39 | |
kfox1111 | know offhand what it is? | 00:39 |
tqtran | btn btn-default btn-sm ajax-modal | 00:39 |
*** yingjun has joined #openstack-horizon | 00:39 | |
tqtran | is it the split button? | 00:39 |
tqtran | or the button inside of the menu? | 00:39 |
kfox1111 | Split one. but I don't have any submenu needed at the moment. | 00:39 |
kfox1111 | That did the trick. :) | 00:40 |
tqtran | ok cool :) | 00:40 |
tqtran | btw, who are you? have we met before or are you new? | 00:41 |
kfox1111 | been around a while but not on any particular project. | 00:41 |
kfox1111 | more of an operator then a developer, but doing stuff on the app catalog right now. | 00:41 |
tqtran | i see i see | 00:42 |
*** bpokorny_ has quit IRC | 00:43 | |
kfox1111 | is it possible to use an angular panel merged into the Projects panel or does it need to be seperate for now? | 00:43 |
tqtran | it is possible | 00:44 |
tqtran | https://review.openstack.org/#/c/181253/ | 00:44 |
tqtran | shows an example of creating a dashboard, but it doesnt have to be in that dashboard | 00:45 |
tqtran | you can just hook it up to the project dashboard instead | 00:45 |
kfox1111 | that looks very familior. :) | 00:45 |
kfox1111 | thats the code I started with basically. | 00:45 |
tqtran | just move your files into dashboards/projects/MAI_PROJECT/**..... | 00:46 |
tqtran | hahaha | 00:46 |
tqtran | yeah i figured as much | 00:46 |
kfox1111 | do you rename hz.dashboard.demo to hz.dashboard.project then? | 00:46 |
tqtran | more like hz.dashboard.project.demo | 00:48 |
*** dsneddon has quit IRC | 00:48 | |
tqtran | the demo patch hasn't been updated | 00:48 |
kfox1111 | oh. so do you move dashboards/demo to dashboards/projects/myproject? | 00:48 |
tqtran | so fivecircle is basically your panel | 00:49 |
kfox1111 | yeah. | 00:49 |
tqtran | while demo is your project | 00:49 |
tqtran | i mean dashboard | 00:49 |
kfox1111 | There's "My Group" in there somewhere too. | 00:49 |
tqtran | so if you want to have fivecircle under project, then yes, you need to move it into the /dashboards/projects/ folder | 00:50 |
kfox1111 | I'd kind of like to keep My Group, but have the group under Projects. | 00:50 |
*** jwy has quit IRC | 00:50 | |
kfox1111 | k. | 00:50 |
tqtran | and modify the dashboard.py and panel.py accordingly | 00:50 |
kfox1111 | perfect. thanks. :) | 00:50 |
tqtran | alrighty, gotta head out, but feel free to shoot me an email if you have further questions | 00:51 |
tqtran | take it ez! | 00:51 |
kfox1111 | will do. thanks again for all the help. your a life saver. :) | 00:51 |
*** tqtran has quit IRC | 00:51 | |
kfox1111 | you to. | 00:51 |
*** ducttape_ has joined #openstack-horizon | 00:52 | |
*** sqchen has joined #openstack-horizon | 00:53 | |
*** openstack has joined #openstack-horizon | 00:55 | |
-cameron.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 00:55 | |
*** akrivoka has quit IRC | 00:55 | |
*** ducttape_ has quit IRC | 00:57 | |
*** sqchen has joined #openstack-horizon | 00:58 | |
*** bpokorny has joined #openstack-horizon | 00:59 | |
*** sqchen has left #openstack-horizon | 01:07 | |
*** sqchen has joined #openstack-horizon | 01:07 | |
*** kfox1111 has quit IRC | 01:08 | |
*** bpokorny has quit IRC | 01:10 | |
*** bpokorny has joined #openstack-horizon | 01:11 | |
*** bpokorny has quit IRC | 01:11 | |
*** bpokorny has joined #openstack-horizon | 01:12 | |
*** kztsv_mbp has joined #openstack-horizon | 01:14 | |
*** ccrouch has quit IRC | 01:14 | |
*** yamamoto has joined #openstack-horizon | 01:14 | |
*** yingjun has quit IRC | 01:15 | |
*** jwy has joined #openstack-horizon | 01:17 | |
*** yamamoto has quit IRC | 01:18 | |
*** kztsv_mbp has quit IRC | 01:19 | |
*** ducttape_ has joined #openstack-horizon | 01:21 | |
*** yingjun has joined #openstack-horizon | 01:27 | |
*** Longgeek has joined #openstack-horizon | 01:31 | |
*** bpokorny has quit IRC | 01:33 | |
*** clu_ has quit IRC | 01:39 | |
*** Longgeek has quit IRC | 01:50 | |
*** tjones1 has joined #openstack-horizon | 01:54 | |
*** ducttape_ has quit IRC | 01:55 | |
*** tsufiev has quit IRC | 02:01 | |
*** aix has quit IRC | 02:02 | |
*** yamamoto has joined #openstack-horizon | 02:02 | |
*** tsufiev has joined #openstack-horizon | 02:06 | |
*** sqchen has left #openstack-horizon | 02:07 | |
lifeless | r1chardj0n3s: have you seen https://review.openstack.org/#/c/121459/ ? | 02:10 |
r1chardj0n3s | lifeless: nope, I had not. neillc, tqtran and matt borland are the prime movers in the horizon i18n space | 02:12 |
lifeless | r1chardj0n3s: I've seen you chatting about i18n stuff, so thought you should be looped in :) | 02:13 |
lifeless | if its irrelevant toyou, thats fine too:) | 02:13 |
*** kztsv_mbp has joined #openstack-horizon | 02:14 | |
r1chardj0n3s | lifeless: oslo's message extraction is very specifically aimed at gettext() in python code, we'd need to do significant work just to get it up to the level of the existing babel + babel-django | 02:15 |
lifeless | r1chardj0n3s: should we be consolidating around babel? | 02:15 |
r1chardj0n3s | it might make sense, not sure | 02:16 |
lifeless | I'm not a deep i18n-head. | 02:16 |
lifeless | ok | 02:16 |
lifeless | tanks | 02:16 |
neillc | lifeless: babel should be looked at, but there are likely to be some issues for oslo I suspect. | 02:16 |
neillc | we want/need it for angular | 02:17 |
r1chardj0n3s | babel was already in the Horizon suite, we're just using it for extraction also now. and adding angular support is a pretty simple exercise | 02:17 |
* r1chardj0n3s butts out and leaves it to the expert to discuss :) | 02:17 | |
neillc | lol expert | 02:17 |
neillc | as r1chardj0n3ssays we're just using it for extraction so it may be worth oslo looking at it for that | 02:18 |
lifeless | so | 02:18 |
lifeless | I'd love it if oslo.i18n weren't needed, or were super thin | 02:18 |
lifeless | if babel has stuff that can help, cool | 02:18 |
neillc | django's built in message compilation actually supports at least one locale that babel does not | 02:18 |
lifeless | but we're outside the django ecosystem for much of openstack [for better or worse] | 02:19 |
neillc | I am a bit vague on exactly how compilation is done, beyond knowing it has something to do with transifex :) | 02:19 |
neillc | andreas jaeger knows more about that | 02:20 |
*** Drago has quit IRC | 02:21 | |
*** amotoki_ has joined #openstack-horizon | 02:24 | |
*** yingjun has quit IRC | 02:25 | |
*** bpokorny has joined #openstack-horizon | 02:26 | |
*** yingjun has joined #openstack-horizon | 02:29 | |
*** amotoki_ has quit IRC | 02:30 | |
*** kztsv_mbp has quit IRC | 02:31 | |
*** kiran-r has joined #openstack-horizon | 02:33 | |
*** tjones1 has quit IRC | 02:39 | |
*** ducttape_ has joined #openstack-horizon | 02:45 | |
*** jamielennox is now known as jamielennox|away | 02:46 | |
*** Longgeek has joined #openstack-horizon | 02:47 | |
*** jamielennox|away is now known as jamielennox | 02:53 | |
*** ducttape_ has quit IRC | 02:56 | |
*** stevemar has joined #openstack-horizon | 03:01 | |
*** ducttape_ has joined #openstack-horizon | 03:02 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Fix enabled/dependency relationship https://review.openstack.org/193401 | 03:03 |
*** wuhg has joined #openstack-horizon | 03:03 | |
*** andrewbogott has joined #openstack-horizon | 03:04 | |
*** jingjing_ren has quit IRC | 03:08 | |
*** ducttape_ has quit IRC | 03:12 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Fix enabled/dependency relationship in enabled/_10_project.py https://review.openstack.org/193401 | 03:17 |
openstackgerrit | Richard Jones proposed openstack/horizon: Fix enabled/dependency relationship in project dashboard https://review.openstack.org/193401 | 03:17 |
*** annashen has joined #openstack-horizon | 03:17 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Fix enabled/dependency relationship in project dashboard https://review.openstack.org/193401 | 03:18 |
*** yingjun has quit IRC | 03:19 | |
*** Longgeek has quit IRC | 03:19 | |
*** stevemar has quit IRC | 03:22 | |
*** annashen has quit IRC | 03:22 | |
*** amotoki_ has joined #openstack-horizon | 03:25 | |
*** stevemar has joined #openstack-horizon | 03:26 | |
*** amotoki_ has quit IRC | 03:30 | |
*** rm_work|away has joined #openstack-horizon | 03:31 | |
*** rm_work|away is now known as rm_work | 03:31 | |
*** rm_work has joined #openstack-horizon | 03:31 | |
*** bpokorny has quit IRC | 03:40 | |
*** jwy has quit IRC | 03:42 | |
*** kiran-r has quit IRC | 03:44 | |
*** andrewbogott has quit IRC | 03:45 | |
*** alexvictorchan has joined #openstack-horizon | 03:46 | |
*** Longgeek has joined #openstack-horizon | 04:00 | |
*** Longgeek has quit IRC | 04:06 | |
*** yingjun has joined #openstack-horizon | 04:07 | |
*** Longgeek has joined #openstack-horizon | 04:08 | |
*** yingjun has quit IRC | 04:11 | |
*** Longgeek_ has joined #openstack-horizon | 04:12 | |
*** fedexo has joined #openstack-horizon | 04:12 | |
*** Longgeek has quit IRC | 04:15 | |
*** amotoki_ has joined #openstack-horizon | 04:26 | |
*** jbell8 has joined #openstack-horizon | 04:30 | |
*** amotoki_ has quit IRC | 04:31 | |
*** masco has joined #openstack-horizon | 04:36 | |
*** andrewbogott has joined #openstack-horizon | 04:38 | |
*** andrewbogott has joined #openstack-horizon | 04:38 | |
*** andrewbogott has quit IRC | 04:39 | |
*** jtomasek has joined #openstack-horizon | 04:42 | |
*** hurgleburgler has quit IRC | 04:54 | |
*** kztsv_mbp has joined #openstack-horizon | 04:57 | |
*** alexvictorchan has quit IRC | 05:01 | |
*** kztsv_mbp has quit IRC | 05:01 | |
*** kztsv_mbp has joined #openstack-horizon | 05:07 | |
*** dsneddon has joined #openstack-horizon | 05:14 | |
*** jprovazn has joined #openstack-horizon | 05:16 | |
*** jbell8 has quit IRC | 05:20 | |
*** amotoki_ has joined #openstack-horizon | 05:27 | |
*** Drago1 has joined #openstack-horizon | 05:28 | |
*** amotoki_ has quit IRC | 05:31 | |
*** kztsv_mbp has quit IRC | 05:34 | |
*** Drago1 has quit IRC | 05:42 | |
*** sayan has quit IRC | 05:48 | |
*** belmoreira has joined #openstack-horizon | 05:57 | |
*** absubram has joined #openstack-horizon | 06:01 | |
*** absubram has quit IRC | 06:01 | |
*** kiran-r has joined #openstack-horizon | 06:02 | |
*** jbell8 has joined #openstack-horizon | 06:05 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/193416 | 06:08 |
*** stevemar has quit IRC | 06:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/193420 | 06:11 |
*** annashen has joined #openstack-horizon | 06:20 | |
*** e0ne has joined #openstack-horizon | 06:25 | |
*** annashen has quit IRC | 06:25 | |
*** mrunge has joined #openstack-horizon | 06:25 | |
*** e0ne has quit IRC | 06:31 | |
*** jtomasek has quit IRC | 06:32 | |
*** juggler has quit IRC | 06:43 | |
*** MaxV has joined #openstack-horizon | 06:49 | |
*** fedexo has quit IRC | 06:55 | |
svasheka | mrunge, hi. there's one test failing in integration suit. is there a fast way to disable it while investigating, so it wouldn't -1 everyone? | 07:03 |
mrunge | svasheka, I didn't saw it's back to voting | 07:04 |
mrunge | (which is good!) | 07:04 |
svasheka | mrunge, yeah, did all required yesterday) | 07:04 |
svasheka | mrunge, but now its -1 every one :) | 07:04 |
mrunge | svasheka, congrats! | 07:04 |
svasheka | mrunge, thanks! | 07:04 |
mrunge | svasheka, I'd say: let's find the failing test quickly and just disable that one | 07:05 |
svasheka | mrunge, already found test, already investigating reasons, just don't know how to disable exact test | 07:05 |
mrunge | svasheka, something like @skiptest? | 07:06 |
mrunge | svasheka, we have some tests deactivated in horizon, for whatever reasons | 07:06 |
*** chlong has quit IRC | 07:06 | |
svasheka | mrunge, ok, I'll look into it | 07:06 |
mrunge | svasheka, I'd be mainly around here, but unfortunately quite busy with other stuff | 07:07 |
mrunge | svasheka, if you have a patch, please ping me to review it | 07:07 |
svasheka | mrunge, sure, I'll just ping you if review will required | 07:07 |
mrunge | yes please! | 07:07 |
mrunge | svasheka, we'll find folks to review it quickly | 07:07 |
svasheka | mrunge, great. | 07:08 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:16 |
*** markus_z has joined #openstack-horizon | 07:16 | |
mrunge | svasheka, could you please open a bug on launchpad | 07:17 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:17 |
mrunge | (to mark the bug fixed by your commit?) | 07:18 |
mrunge | svasheka, that makes the whole thing a bit more trackable | 07:18 |
mrunge | this might be an issue outside of horizon | 07:18 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:19 |
mrunge | awesome, I just saw the updated commit message | 07:19 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:20 |
svasheka | mrunge, updated it again) | 07:21 |
mrunge | svasheka, final nit: could you please add a TDOD(svasheka): .... to the patch? | 07:21 |
mrunge | it's easy to find TODO items there | 07:22 |
mrunge | which marks it clearly as: there is work to do | 07:22 |
svasheka | mrunge, sure. | 07:22 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:23 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:23 |
svasheka | mrunge, mm is it TDOD or TODO, neither of it highlits. sorry I'm not familiar with the process :) | 07:24 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:24 |
mrunge | ah, I meant to add TODO to the python file | 07:24 |
svasheka | mrunge, oh that, sure | 07:24 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:25 |
mrunge | it's TODO, and not TDOD (which was just due to my still sleeping fingers) | 07:25 |
mrunge | sorry about that | 07:25 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 07:26 |
mrunge | svasheka, thank you. Now let's see, what jenkins thinks | 07:28 |
*** Ala has joined #openstack-horizon | 07:29 | |
svasheka | mrunge, yeah, hopefully his on my side | 07:29 |
*** zz_ttrifonov is now known as ttrifonov | 07:33 | |
*** bluex-pl has joined #openstack-horizon | 07:34 | |
*** ygbo has joined #openstack-horizon | 07:45 | |
*** romainh has joined #openstack-horizon | 07:46 | |
*** jamielennox is now known as jamielennox|away | 08:00 | |
*** ZZelle has quit IRC | 08:03 | |
*** ZZelle has joined #openstack-horizon | 08:03 | |
*** jcoufal has joined #openstack-horizon | 08:06 | |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 08:11 |
mrunge | svasheka, you were faster than me :) | 08:13 |
svasheka | mrunge, :) | 08:13 |
openstackgerrit | svasheka proposed openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 08:13 |
*** e0ne has joined #openstack-horizon | 08:18 | |
*** rushiagr_away is now known as rushiagr | 08:18 | |
*** e0ne has quit IRC | 08:25 | |
*** amotoki_ has joined #openstack-horizon | 08:29 | |
*** mpavlase has joined #openstack-horizon | 08:30 | |
*** aix has joined #openstack-horizon | 08:32 | |
*** alexpilotti has joined #openstack-horizon | 08:33 | |
*** amotoki_ has quit IRC | 08:34 | |
*** ankit_ag has joined #openstack-horizon | 08:41 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Remove current consumer in QoS spec edit https://review.openstack.org/193456 | 08:43 |
*** Longgeek_ has quit IRC | 08:51 | |
*** Longgeek has joined #openstack-horizon | 08:51 | |
svasheka | mrunge, jenkins satisfied | 09:00 |
svasheka | mrunge, has to go afk for some time, though | 09:01 |
*** svasheka has quit IRC | 09:01 | |
*** wznoinsk has quit IRC | 09:03 | |
*** bluex-pl has quit IRC | 09:04 | |
*** bluex-pl has joined #openstack-horizon | 09:04 | |
*** wznoinsk has joined #openstack-horizon | 09:05 | |
*** bluex-pl has quit IRC | 09:07 | |
*** bluex-pl has joined #openstack-horizon | 09:08 | |
*** kztsv_mbp has joined #openstack-horizon | 09:09 | |
*** akrivoka has joined #openstack-horizon | 09:10 | |
*** juggler has joined #openstack-horizon | 09:14 | |
*** kztsv_mbp has quit IRC | 09:20 | |
*** annashen has joined #openstack-horizon | 09:22 | |
*** jbell8 has quit IRC | 09:26 | |
*** annashen has quit IRC | 09:27 | |
*** e0ne has joined #openstack-horizon | 09:28 | |
*** hexlibris has joined #openstack-horizon | 09:28 | |
*** amotoki_ has joined #openstack-horizon | 09:30 | |
masco | is the jenkins normal now? | 09:31 |
masco | can i do recheck now? | 09:31 |
*** amotoki_ has quit IRC | 09:34 | |
*** jasondotstar has joined #openstack-horizon | 09:41 | |
mrunge | masco, it's not | 09:43 |
mrunge | masco, https://review.openstack.org/#/c/193438/ needs to be merged | 09:43 |
masco | mrunge, thanks :) | 09:43 |
mrunge | any core here to ack https://review.openstack.org/#/c/193438/ ? | 09:43 |
mrunge | zhenguo, ? are you still available? | 09:45 |
*** tosky has joined #openstack-horizon | 09:45 | |
*** dsneddon has quit IRC | 09:47 | |
masco | less number of cores in this time zone :( | 09:48 |
mrunge | yes | 09:48 |
mrunge | robcresswell seems to be away | 09:48 |
masco | yes | 09:48 |
mrunge | amotoki, are you still there and could have a look at https://review.openstack.org/#/c/193438/ ? | 09:49 |
mrunge | it's currently blocking the gate for us | 09:49 |
*** e0ne is now known as e0ne_ | 09:52 | |
*** romainh has quit IRC | 09:53 | |
*** e0ne_ is now known as e0ne | 09:54 | |
*** bluex-pl has quit IRC | 10:04 | |
*** bluex-pl has joined #openstack-horizon | 10:07 | |
*** amotoki_ has joined #openstack-horizon | 10:07 | |
*** romainh has joined #openstack-horizon | 10:08 | |
*** kztsv_mbp has joined #openstack-horizon | 10:17 | |
*** kztsv_mbp has quit IRC | 10:22 | |
*** romainh has quit IRC | 10:24 | |
*** dsneddon has joined #openstack-horizon | 10:40 | |
*** svasheka has joined #openstack-horizon | 10:40 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 10:42 |
*** bluex-pl has quit IRC | 11:01 | |
*** wuhg has quit IRC | 11:04 | |
robcresswell | Hey there. Timezones -.- I had to go to an internal thing all day yesterday | 11:08 |
robcresswell | sqchen: asahlin: clu_: ^^ | 11:08 |
robcresswell | sqchen: asahlin: clu_: Any cleanup work youd like me to help out with? | 11:08 |
*** jprovazn has quit IRC | 11:10 | |
*** jprovazn has joined #openstack-horizon | 11:12 | |
robcresswell | mrunge: I'm around now. | 11:14 |
masco | robcresswell, we were looking for you for your +2 on this patch https://review.openstack.org/#/c/193438/ | 11:19 |
masco | thanks | 11:19 |
*** e0ne is now known as e0ne_ | 11:19 | |
robcresswell | Hmm | 11:21 |
robcresswell | I think today is going to be "review day" | 11:21 |
masco | good, i have four five patches for review, you can go through ;) | 11:23 |
*** ala_ has joined #openstack-horizon | 11:24 | |
robcresswell | masco: Will do! | 11:24 |
masco | robcresswell, thank you!! | 11:25 |
*** akrivoka has quit IRC | 11:27 | |
*** Ala has quit IRC | 11:27 | |
mrunge | thanks robcresswell | 11:29 |
*** e0ne_ has quit IRC | 11:29 | |
*** samueldmq has joined #openstack-horizon | 11:32 | |
samueldmq | hi guys, does Horizon support domain scoped tokens ? | 11:32 |
samueldmq | I think it does not, I just want to confirm that info :) | 11:33 |
mrunge | samueldmq, you're right, it does not | 11:35 |
samueldmq | mrunge: thanks for your quick reply, have a nice day | 11:36 |
mrunge | samueldmq, likewise! | 11:37 |
tsufiev | a question to the experts in Horizon's angular.js refactoring: if a controller resides in tech-debt/ folder, does it mean that I shouldn't add anything to it (e.g. to fix some bug)? | 11:40 |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Remove current QoS spec in volume type https://review.openstack.org/193504 | 11:42 |
tsufiev | robcresswell, Rob, sorry for disturbing, but do you know the policies here ^^^ by chance? | 11:42 |
*** lblanchard has joined #openstack-horizon | 11:43 | |
*** jasondotstar has quit IRC | 11:43 | |
robcresswell | tsufiev: If it's a bug, I think it should still be fixed | 11:44 |
robcresswell | tsufiev: The tech-debt folder is just temporary while things are refactored/ moved around I believe, but the code may still be used | 11:45 |
tsufiev | robcresswell, yes, sounds reasonable | 11:45 |
robcresswell | tsufiev: :D | 11:45 |
*** mrunge has quit IRC | 11:54 | |
zhenguo | mrunge: yes | 11:56 |
openstackgerrit | Merged openstack/horizon: Skip test_sahara_image_registry while investigating reasons https://review.openstack.org/193438 | 11:56 |
zhenguo | mrunge: ping back | 11:57 |
*** akrivoka has joined #openstack-horizon | 11:57 | |
*** asahlin_away has quit IRC | 12:00 | |
*** rbertram has quit IRC | 12:00 | |
*** asahlin has joined #openstack-horizon | 12:01 | |
*** rbertram has joined #openstack-horizon | 12:02 | |
*** romainh has joined #openstack-horizon | 12:03 | |
*** bluex-pl has joined #openstack-horizon | 12:07 | |
*** e0ne has joined #openstack-horizon | 12:08 | |
*** radez_g0n3 is now known as radez | 12:09 | |
*** masco has quit IRC | 12:14 | |
*** ducttape_ has joined #openstack-horizon | 12:16 | |
*** yamamoto has quit IRC | 12:19 | |
*** jbell8 has joined #openstack-horizon | 12:27 | |
robcresswell | gate should be alive again after that patch merged | 12:28 |
*** ducttape_ has quit IRC | 12:30 | |
*** jbell8 has quit IRC | 12:31 | |
*** raildo has joined #openstack-horizon | 12:41 | |
*** Longgeek has quit IRC | 12:41 | |
*** Longgeek has joined #openstack-horizon | 12:42 | |
*** jasondotstar has joined #openstack-horizon | 12:43 | |
*** mrunge has joined #openstack-horizon | 12:48 | |
*** zhenguo has quit IRC | 12:51 | |
*** ankit_ag has quit IRC | 12:51 | |
*** kztsv_mbp has joined #openstack-horizon | 12:56 | |
*** yamamoto has joined #openstack-horizon | 12:57 | |
*** yamamoto has quit IRC | 12:57 | |
*** yamamoto has joined #openstack-horizon | 12:57 | |
*** Longgeek has quit IRC | 12:57 | |
*** Longgeek has joined #openstack-horizon | 12:59 | |
*** dboik has joined #openstack-horizon | 13:03 | |
*** julim has joined #openstack-horizon | 13:05 | |
*** HenryG has quit IRC | 13:05 | |
*** dboik_ has joined #openstack-horizon | 13:05 | |
*** HenryG has joined #openstack-horizon | 13:05 | |
*** kztsv_mbp has quit IRC | 13:06 | |
*** HenryG has quit IRC | 13:06 | |
*** petertr7_away is now known as petertr7 | 13:06 | |
*** julim has quit IRC | 13:07 | |
*** HenryG has joined #openstack-horizon | 13:07 | |
*** kztsv_mbp has joined #openstack-horizon | 13:07 | |
*** julim has joined #openstack-horizon | 13:08 | |
*** dboik has quit IRC | 13:08 | |
*** kztsv_mbp has quit IRC | 13:12 | |
*** yamamoto has quit IRC | 13:17 | |
*** pauloewerton has joined #openstack-horizon | 13:19 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Fix function name reference in cinder.service.spec.js https://review.openstack.org/193534 | 13:22 |
*** dguerri` is now known as dguerri | 13:26 | |
*** andrewbogott has joined #openstack-horizon | 13:27 | |
*** ducttape_ has joined #openstack-horizon | 13:27 | |
*** yamamoto has joined #openstack-horizon | 13:27 | |
*** peristeri has joined #openstack-horizon | 13:30 | |
*** kiran-r has quit IRC | 13:34 | |
*** mpavlase has quit IRC | 13:34 | |
*** jtriley has joined #openstack-horizon | 13:35 | |
*** akrivoka has quit IRC | 13:36 | |
openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Network Step https://review.openstack.org/193548 | 13:39 |
asahlin | robcresswell: Hi Rob, Cindy and I have been walking through the Create Instance Steps. So to avoid overlap, I would say anything outside of that I think is fair game. | 13:39 |
*** ducttape_ has quit IRC | 13:39 | |
*** tvanderwiel has joined #openstack-horizon | 13:39 | |
robcresswell | asahlin: Sure thing, thanks | 13:40 |
robcresswell | asahlin: On a review spree atm, anything need looking at? | 13:40 |
*** dguerri is now known as dguerri` | 13:40 | |
*** andrewbogott has left #openstack-horizon | 13:40 | |
asahlin | robcresswell: Nothing particular... Just have a couple of JP code shuffling patches up | 13:41 |
asahlin | robcresswell: clu_: ongk: FYI starting to JP the Launch Instance Security group step. | 13:42 |
asahlin | robcresswell: clu_: ongk: Thinking it might be a good idea for us 4 to communicate what we are grabbing next so we dont step on each other. | 13:42 |
*** dguerri` is now known as dguerri | 13:45 | |
openstackgerrit | Merged openstack/horizon: Removing unnecessary test setting of dashboards https://review.openstack.org/193329 | 13:45 |
*** Drago has joined #openstack-horizon | 13:47 | |
*** yamamoto_ has joined #openstack-horizon | 13:47 | |
*** Drago has quit IRC | 13:47 | |
*** Drago has joined #openstack-horizon | 13:48 | |
robcresswell | asahlin: Agreed, although I can't stick around late today (Friday = Beer day). I'll see if I can hang around late on Monday to catch everyone in the US and r1chardj0n3s too | 13:48 |
*** yamamoto has quit IRC | 13:51 | |
*** drupalmonkey has joined #openstack-horizon | 13:52 | |
*** bluex-pl has quit IRC | 13:59 | |
*** Piet has joined #openstack-horizon | 13:59 | |
*** bluex-pl has joined #openstack-horizon | 14:00 | |
*** akrivoka has joined #openstack-horizon | 14:04 | |
*** morganfainberg is now known as morgan-devserver | 14:06 | |
*** ducttape_ has joined #openstack-horizon | 14:07 | |
openstackgerrit | Merged openstack/horizon: Revert "added a 'shared' column in FW policy table" https://review.openstack.org/193304 | 14:07 |
*** morgan-devserver is now known as CaptainMorgan | 14:08 | |
*** bethelwell has joined #openstack-horizon | 14:10 | |
*** bluex-pl has quit IRC | 14:12 | |
*** stevemar has joined #openstack-horizon | 14:24 | |
*** MaxV has quit IRC | 14:24 | |
*** garthb_ has joined #openstack-horizon | 14:27 | |
*** garthb has joined #openstack-horizon | 14:27 | |
asahlin | robcresswell: and you can't be late for Beer day!! I know I would never forgive myself | 14:27 |
*** archers has joined #openstack-horizon | 14:29 | |
*** stevemar is now known as stevedoor | 14:29 | |
*** sjmc7 has joined #openstack-horizon | 14:31 | |
*** josecastroleon has quit IRC | 14:31 | |
openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Do not use a mutable as default argument https://review.openstack.org/193575 | 14:32 |
*** dboik_ has quit IRC | 14:34 | |
*** jasondotstar has quit IRC | 14:35 | |
*** jasondotstar has joined #openstack-horizon | 14:37 | |
*** tvanderwiel has quit IRC | 14:41 | |
*** dguerri is now known as dguerri` | 14:44 | |
*** yamamoto_ has quit IRC | 14:48 | |
*** Piet has quit IRC | 14:49 | |
*** archers has quit IRC | 14:50 | |
*** dguerri` is now known as dguerri | 14:50 | |
openstackgerrit | Merged openstack/horizon: JSCS cleanup - horizon/static/framework conf and util https://review.openstack.org/188987 | 14:51 |
*** MaxV has joined #openstack-horizon | 14:52 | |
david-lyle | samueldmq: there is a set of patches to support domain-scoped tokens, but they have not merge yet | 14:52 |
*** absubram has joined #openstack-horizon | 14:52 | |
*** yamamoto has joined #openstack-horizon | 14:53 | |
david-lyle | https://review.openstack.org/#/c/141153/ and https://review.openstack.org/#/c/148082/ | 14:53 |
*** Longgeek has quit IRC | 14:53 | |
*** absubram has quit IRC | 14:54 | |
*** Longgeek has joined #openstack-horizon | 14:54 | |
*** absubram has joined #openstack-horizon | 14:55 | |
samueldmq | david-lyle: nice thanks ! | 14:55 |
*** clu_ has joined #openstack-horizon | 14:56 | |
openstackgerrit | George Peristerakis proposed openstack/horizon: Display event stream in the instance audit tab https://review.openstack.org/188134 | 14:58 |
*** Ephur has joined #openstack-horizon | 14:59 | |
*** rushiagr is now known as rushiagr_away | 15:02 | |
*** ala_ has quit IRC | 15:03 | |
*** bpokorny has joined #openstack-horizon | 15:04 | |
*** yamamoto has quit IRC | 15:06 | |
*** jbell8 has joined #openstack-horizon | 15:06 | |
*** jbell8 has quit IRC | 15:07 | |
*** jbell8 has joined #openstack-horizon | 15:07 | |
*** belmoreira has quit IRC | 15:08 | |
*** dboik has joined #openstack-horizon | 15:10 | |
*** yamamoto has joined #openstack-horizon | 15:13 | |
tosky | svasheka: hi, don't you mind if I try a patch to fix https://bugs.launchpad.net/horizon/+bug/1466744 (test_image_register_unregister failing)? | 15:14 |
openstack | Launchpad bug 1466744 in OpenStack Dashboard (Horizon) "Integration test test_image_register_unregister failing gate" [Undecided,In progress] - Assigned to svasheka (svasheka) | 15:14 |
*** mou has joined #openstack-horizon | 15:15 | |
*** MaxV has quit IRC | 15:15 | |
*** tvanderwiel has joined #openstack-horizon | 15:18 | |
*** tyr has joined #openstack-horizon | 15:18 | |
openstackgerrit | Luigi Toscano proposed openstack/horizon: wait until the image is registered in Sahara image test https://review.openstack.org/193592 | 15:19 |
svasheka | tosky, sure. working on it also. haven't done anything useful yet, just investigating. | 15:22 |
tosky | svasheka: thanks; the patch is the one above, if it does not work... I'm out of ideas | 15:22 |
tosky | also because, *of course*, I can't reproduce it locally | 15:22 |
svasheka | tosky, same here. | 15:23 |
*** yamamoto has quit IRC | 15:23 | |
*** petertr7 is now known as petertr7_away | 15:24 | |
tosky | svasheka: oh, interesting - what is the environment, if I can ask? I'm on Fedora 21 right now (dependencies from virtualenv/pip when testing, not system packages) | 15:24 |
svasheka | tosky, ubuntu 14.04 | 15:24 |
tosky | svasheka: like the gate | 15:25 |
tosky | grrr | 15:25 |
svasheka | tosky, yeah I think something with performance of gate | 15:26 |
svasheka | tosky, beter/worse than mine | 15:26 |
*** jasondotstar has quit IRC | 15:26 | |
svasheka | tosky, and that why it fails | 15:26 |
tosky | svasheka: so let's hope that the dirty "active polling" hack solution I put on will work | 15:26 |
*** absubram has quit IRC | 15:26 | |
svasheka | tosky, holding fingers :) | 15:27 |
*** annashen has joined #openstack-horizon | 15:27 | |
*** jasondotstar has joined #openstack-horizon | 15:28 | |
*** hurgleburgler has joined #openstack-horizon | 15:32 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 15:32 |
*** annashen has quit IRC | 15:32 | |
*** yamamoto has joined #openstack-horizon | 15:35 | |
*** kztsv_mbp has joined #openstack-horizon | 15:41 | |
*** jtriley has quit IRC | 15:47 | |
*** gary-smith has quit IRC | 15:49 | |
*** masco has joined #openstack-horizon | 15:50 | |
*** sjmc7 has quit IRC | 15:50 | |
*** kiran-r has joined #openstack-horizon | 15:51 | |
*** hurgleburgler has quit IRC | 15:51 | |
*** hurgleburgler has joined #openstack-horizon | 15:51 | |
*** ygbo has quit IRC | 15:52 | |
*** sjmc7 has joined #openstack-horizon | 15:53 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Relocate launch-instance to project/workflows/ https://review.openstack.org/192444 | 15:53 |
openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS Cleanup - style cleanup for Launch Instance Security Groups Step https://review.openstack.org/193608 | 15:54 |
*** jtriley has joined #openstack-horizon | 15:54 | |
asahlin | robcresswell: clu_: ongk: FYI starting to JP the Launch Instance Sources step. | 15:56 |
clu_ | thanks asahlin! | 15:57 |
*** belmoreira has joined #openstack-horizon | 15:58 | |
openstackgerrit | Romain Hardouin proposed openstack/horizon: Show datastores and versions for Trove https://review.openstack.org/163196 | 16:01 |
*** alexvictorchan has joined #openstack-horizon | 16:03 | |
*** markus_z has quit IRC | 16:06 | |
*** masco has quit IRC | 16:08 | |
*** nlahouti has joined #openstack-horizon | 16:09 | |
*** e0ne has quit IRC | 16:10 | |
openstackgerrit | Merged openstack/horizon: Fix function name reference in cinder.service.spec.js https://review.openstack.org/193534 | 16:10 |
*** gyee has joined #openstack-horizon | 16:14 | |
peristeri | robcresswell, Hi Rob, do you have the time to look into https://review.openstack.org/#/c/173027/ ? | 16:15 |
openstackgerrit | Luigi Toscano proposed openstack/horizon: Wait until the image is registered in Sahara image test https://review.openstack.org/193592 | 16:15 |
romainh | abramley: hi, I've uploaded a "policy checks" version of bp trove-list-datastores-and-versions https://review.openstack.org/163196 | 16:18 |
*** kiran-r has quit IRC | 16:21 | |
*** jtriley has quit IRC | 16:21 | |
*** jtriley has joined #openstack-horizon | 16:23 | |
*** petertr7_away is now known as petertr7 | 16:28 | |
*** raildo has quit IRC | 16:29 | |
*** dguerri is now known as dguerri` | 16:29 | |
*** raildo has joined #openstack-horizon | 16:30 | |
*** kiran-r has joined #openstack-horizon | 16:32 | |
*** fedexo has joined #openstack-horizon | 16:32 | |
*** yamamoto has quit IRC | 16:36 | |
*** rm_work is now known as rm_work|away | 16:37 | |
*** asahlin is now known as asahlin_away | 16:38 | |
*** dguerri` is now known as dguerri | 16:45 | |
*** dguerri is now known as dguerri` | 16:46 | |
*** jcoufal has quit IRC | 16:47 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for action-list https://review.openstack.org/188995 | 16:48 |
*** ZZelle_ has joined #openstack-horizon | 16:48 | |
*** kztsv_mbp has quit IRC | 16:50 | |
*** ZZelle__ has joined #openstack-horizon | 16:51 | |
*** rm_work|away is now known as rm_work | 16:53 | |
*** kztsv_mbp has joined #openstack-horizon | 16:55 | |
*** hurgleburgler has quit IRC | 16:55 | |
*** hurgleburgler has joined #openstack-horizon | 16:55 | |
*** raildo has quit IRC | 16:55 | |
*** raildo has joined #openstack-horizon | 16:56 | |
*** bradjones has quit IRC | 16:58 | |
*** bradjones has joined #openstack-horizon | 16:58 | |
*** bradjones has quit IRC | 16:58 | |
*** bradjones has joined #openstack-horizon | 16:58 | |
*** bethelwell has quit IRC | 16:59 | |
*** doug-fish has joined #openstack-horizon | 17:01 | |
abramley | romainh - i asked dloi to take a look at it - I am working on other things right now | 17:01 |
romainh | abramley: ok great, thank you | 17:02 |
*** belmoreira has quit IRC | 17:03 | |
*** jingjing_ren has joined #openstack-horizon | 17:04 | |
ducttape_ | I've had a horizon lbaas patch awaiting review for a while, is there something I could do to help it proceed? Is having lbaas setup an impediment to getting horizon reviews? We have more lbaas horizon work that will be coming along soon too. | 17:04 |
esp | david-lyle: MEH49NMCTP9 | 17:05 |
*** lblanchard has quit IRC | 17:06 | |
*** tvanderwiel has quit IRC | 17:07 | |
*** romainh has left #openstack-horizon | 17:09 | |
*** jtomasek has joined #openstack-horizon | 17:11 | |
*** bradjones has quit IRC | 17:11 | |
*** klindgren has joined #openstack-horizon | 17:12 | |
*** kfox1111 has joined #openstack-horizon | 17:12 | |
*** bradjones has joined #openstack-horizon | 17:12 | |
*** bradjones has quit IRC | 17:12 | |
*** bradjones has joined #openstack-horizon | 17:12 | |
*** jingjing_ren has quit IRC | 17:16 | |
*** kztsv_mbp has quit IRC | 17:17 | |
*** sqchen has joined #openstack-horizon | 17:20 | |
dloi | romainh: I am wrapping up a few things and hopefully will get to the review soon! | 17:21 |
*** zul has quit IRC | 17:25 | |
*** zul has joined #openstack-horizon | 17:25 | |
*** annashen has joined #openstack-horizon | 17:27 | |
*** mrunge has quit IRC | 17:27 | |
*** dscottsf has joined #openstack-horizon | 17:27 | |
*** dscottsf has quit IRC | 17:28 | |
*** ybathia has joined #openstack-horizon | 17:30 | |
*** ZZelle_ has quit IRC | 17:32 | |
*** ZZelle__ has quit IRC | 17:33 | |
*** tqtran has joined #openstack-horizon | 17:35 | |
*** crobertsrh has quit IRC | 17:36 | |
*** yamamoto has joined #openstack-horizon | 17:37 | |
*** e0ne has joined #openstack-horizon | 17:38 | |
*** bpokorny_ has joined #openstack-horizon | 17:41 | |
*** yamamoto has quit IRC | 17:42 | |
kfox1111 | tqtran: https://www.youtube.com/watch?v=N3onNfjf4uY&feature=youtu.be :) | 17:42 |
*** jingjing_ren has joined #openstack-horizon | 17:43 | |
*** crobertsrh has joined #openstack-horizon | 17:43 | |
*** bpokorny has quit IRC | 17:43 | |
*** lblanchard has joined #openstack-horizon | 17:44 | |
tqtran | kfox1111: :) ooooo nice | 17:44 |
tqtran | looks like your colspan for the detail section is off though | 17:44 |
*** Longgeek has quit IRC | 17:45 | |
openstackgerrit | Merged openstack/horizon: Update version for Liberty https://review.openstack.org/192403 | 17:46 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable streaming while uploading images to Glance via Horizon https://review.openstack.org/166969 | 17:47 |
kfox1111 | yeah. I was planning on fixing that. | 17:47 |
kfox1111 | same with the description. its vcentered. | 17:47 |
kfox1111 | I figure those are all consmetic and easy to fix. | 17:48 |
*** tvanderwiel has joined #openstack-horizon | 17:48 | |
david-lyle | kfox1111: nice | 17:49 |
tqtran | yep, looks great! good job! | 17:49 |
kfox1111 | thanks again guys for all the help. :) | 17:49 |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for Keypair step https://review.openstack.org/193658 | 17:49 |
*** jwy has joined #openstack-horizon | 17:50 | |
tqtran | r1chardj0n3s, tyr, sqchen: ping pong guys | 17:50 |
kfox1111 | I'll try and submit a review for the few bits needed to make the dialog reusable. THen the rest can be a plugin I think. | 17:50 |
sqchen | Hi tqtran | 17:50 |
tqtran | wanted to sit down with you guys have and a chat about file structure again.... | 17:50 |
tqtran | https://review.openstack.org/#/c/190852/ | 17:50 |
sqchen | sure | 17:50 |
tqtran | regarding richard's comments | 17:50 |
tqtran | just wanted to make sure we're all on the same page and that it still fits with the autodiscovery work you are doing sean | 17:51 |
sqchen | Yesterdat Tyr and me had a discussion on this topic, we have some idea, and tyr will put up a patch to resolve the issue. | 17:52 |
kfox1111 | thought that raises a question. Is it possible to have the ui like in the video where the Catalog group under Projects is in an external plugin? | 17:54 |
sqchen | The goal here is, if someone plugin some new dashboard, there should no need to change any other source code, it should be automatically integrated to the system after retart the server. | 17:54 |
*** jasondotstar has quit IRC | 17:56 | |
tqtran | kfox1111: it should be possible | 17:56 |
tqtran | kfox1111: say you have some 3rd party service sitting on some port, you have 2 options to make that work: 1. a proxy or 2. enable CORS | 17:57 |
tqtran | once you have that set up, create a horizon API wrapper for it and you're gtg | 17:57 |
tqtran | sqchen: yes i agree | 17:58 |
tqtran | i also have a proposition that i think will work, does tyr have something up already? | 17:58 |
sqchen | let me check. | 17:58 |
*** devananda has joined #openstack-horizon | 17:58 | |
devananda | david-lyle: ping | 17:59 |
*** jasondot_ has joined #openstack-horizon | 17:59 | |
sqchen | Tyr’s change is up yet. | 18:00 |
*** jprovazn has quit IRC | 18:01 | |
kfox1111 | tqtran: I've been talking with the other app-catalog folks to enable cors on apps.openstack.org. | 18:01 |
kfox1111 | so that sounds feasable. | 18:01 |
tqtran | +1 nice! | 18:02 |
*** akrivoka has quit IRC | 18:03 | |
kfox1111 | for a while though, since things are in quick development, it would be nice if you could upgrade the plugin code without needing to upgrade horizon. since right now we have just flat json, and are starting to look at things like elastic search. | 18:03 |
ducttape_ | TravT- ping | 18:05 |
tqtran | kfox1111: not sure i follow. plugin code as in the demo code? or the horizon plugin mechanism for new angular dashboards? | 18:06 |
kfox1111 | as in the demo code. | 18:09 |
kfox1111 | but it should still show up under the Projects section. | 18:10 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Enable streaming while uploading images to Glance via Horizon https://review.openstack.org/166969 | 18:10 |
kfox1111 | is there a predefined class for a table cell to valign=top? | 18:10 |
*** tosky has quit IRC | 18:12 | |
*** mrunge has joined #openstack-horizon | 18:12 | |
david-lyle | ducttape_: TravT is on vacation | 18:13 |
david-lyle | devananda: pong | 18:13 |
ducttape_ | thanks david-lyle | 18:13 |
david-lyle | back on Tues or Wed I think | 18:13 |
kfox1111 | ugg... I just noticed the heat password dialog box is still there in Kilo. :/ | 18:13 |
kfox1111 | Is there still no way to turn that off? :/ | 18:13 |
kfox1111 | We've been using trusts for over a year, and its really lame to have to put a dummy value in the box every time. | 18:14 |
*** akrivoka has joined #openstack-horizon | 18:14 | |
*** dscottsf has joined #openstack-horizon | 18:15 | |
*** dscottsf_ has joined #openstack-horizon | 18:15 | |
*** dscottsf_ has quit IRC | 18:15 | |
*** akrivoka has quit IRC | 18:15 | |
tqtran | david-lyle, clu_ : can you guys help push this patch through? :D its kinda needed and sitting there for quite some time | 18:17 |
clu_ | tqtran: patch plz | 18:17 |
*** doug-fish has left #openstack-horizon | 18:18 | |
*** alexpilotti has quit IRC | 18:18 | |
tqtran | https://review.openstack.org/#/c/185191/ | 18:19 |
tqtran | oh right... lol | 18:19 |
tqtran | i forgot you guys dont read minds | 18:19 |
*** dscottsf has quit IRC | 18:19 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding angular dashboard plugin mechanism https://review.openstack.org/193671 | 18:20 |
tqtran | sqchen, tyr, r1chardj0n3s: this patch is what i have in mind for fixing our problem, let me know your thoughts by commenting on the patch | 18:20 |
sqchen | I am looking into right now… | 18:21 |
openstackgerrit | Luigi Toscano proposed openstack/horizon: Wait until the image is registered in Sahara image test https://review.openstack.org/193592 | 18:23 |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style cleanup for Flavor Step https://review.openstack.org/192828 | 18:26 |
devananda | david-lyle: have a few to chat about the ironic dashboard proposed by Niu Zhengguo? | 18:28 |
david-lyle | devananda: sure | 18:29 |
*** kiran-r has quit IRC | 18:29 | |
devananda | david-lyle: there's been some discussion in -infra and the ML. tldr; I dont think I knew about it. I also didn't know Niu was a horizon core ... | 18:30 |
devananda | david-lyle: were you aware of the work // if so, what's your opinion on it? | 18:31 |
*** mou has quit IRC | 18:31 | |
david-lyle | yeah, the two efforts started in isolation, once I discovered Niu was working on another implementation, I pointed him to krotscheck | 18:32 |
david-lyle | I think neither effort was publicized and thus the duplication | 18:32 |
* krotscheck seems to recall talking about the ironic-webclient in vancouver, over mailing lists, in specs.... | 18:32 | |
david-lyle | krotscheck: I know Niu wasn't in vancouver | 18:33 |
* krotscheck hasn't written a single line of code on that without the other teams knowing what's going on. | 18:33 | |
devananda | david-lyle: yea, as krotscheck says, ironic-core knew about his work months ago, and we dicussed it in YVR | 18:33 |
devananda | david-lyle: whereas Niu proposed this to governance before I even knew about the project | 18:33 |
david-lyle | there's a lot of that going on :/ | 18:33 |
david-lyle | PTL = last to know | 18:33 |
devananda | david-lyle: that's no justificatoin | 18:34 |
david-lyle | I'm not trying to find fault, I'm just trying to explain how we got here | 18:34 |
david-lyle | at least my understanding of it | 18:34 |
david-lyle | devananda: I fully agree | 18:34 |
devananda | david-lyle: *nod* i appreciate that. I'm not trying to point fingers -- just want to figure out how to move forward | 18:34 |
david-lyle | sure | 18:34 |
devananda | and to do that, I need to know where we are now | 18:35 |
devananda | like -- does this project have the support of horizon? | 18:35 |
devananda | or is it totally off in a corner? | 18:35 |
david-lyle | so the first I had heard of the ironic work by Niu was the proposal to project-config | 18:35 |
david-lyle | so it's been done in isolation | 18:35 |
devananda | ... great. at least you and I were both surprised at the same time | 18:35 |
david-lyle | yes | 18:36 |
david-lyle | that's less than ideal | 18:36 |
*** stevedoor has quit IRC | 18:40 | |
devananda | as far as project alignment goes, aside from tripleo/tuskar, I haven't really seen much interest expressed in a horizon panel for ironic | 18:40 |
devananda | it's not a user-facing project. ie, we expect users to just use nova -- only operators will need a panel for ironic | 18:41 |
openstackgerrit | George Peristerakis proposed openstack/horizon: Add py34 env https://review.openstack.org/178342 | 18:41 |
*** jingjing_ren has quit IRC | 18:42 | |
david-lyle | I've had a few inquiries from different companies, but the use cases haven't always been clear | 18:42 |
devananda | ditto - and when i've drilled down, it has usually been a misperception | 18:42 |
*** nlahouti has quit IRC | 18:43 | |
david-lyle | I certainly think going through nova can handle the majority of use cases | 18:43 |
david-lyle | I really need to go through the proposed project and see what is being attempted to deliver | 18:44 |
devananda | ditto | 18:44 |
david-lyle | If the use cases make sense, I would favor sharing a common library component for horizon and ironic-webclient use | 18:45 |
david-lyle | rather than a second implementation | 18:45 |
devananda | as far as which project team takes on the horizon panel (regardless of current proposal) do you have a strong preference if that's the horizon team or the ironic team? | 18:46 |
*** Longgeek has joined #openstack-horizon | 18:46 | |
devananda | sharing common libs +100 | 18:46 |
*** clu_ has quit IRC | 18:46 | |
david-lyle | I've been advocating a stronger tie-in from the service teams, like ironic | 18:47 |
david-lyle | the horizon scope is too large already | 18:47 |
david-lyle | I have no issue with ironic owning it | 18:47 |
devananda | ack | 18:48 |
david-lyle | what I have suggested in other instances is either a shared core or horizon attempting to provide reviews around UX and compatibility with Horizon | 18:48 |
devananda | if we accept it, i'll probably create a subteam with its own cores | 18:48 |
*** sqchen has quit IRC | 18:49 | |
*** sqchen has joined #openstack-horizon | 18:49 | |
devananda | since none of the current ironic core are UI/UX devs, or much a part of horizon community, that team could be seeded with horizon folks | 18:49 |
devananda | *some horizon folks | 18:49 |
david-lyle | I think that makes sense | 18:49 |
david-lyle | my biggest goal is to not slow down progress on UI projects by just whole sale taking them into the horizon project | 18:50 |
tyr | Hi tqtran. I don't think your patch will be necessary. | 18:50 |
devananda | my main concern is that none of the current ironic cores take any interest in it | 18:50 |
devananda | but it gets dropped on us and we're left with the responsibility for it | 18:51 |
david-lyle | that can be an issue too | 18:51 |
david-lyle | if it needs a home, we can take it, but I would want cross-project core list for sure | 18:51 |
devananda | *nod* | 18:51 |
devananda | if ya'll, like docs and qa, are moving to a more self-service model (which I think is great, as long as the APIs are clear and documented and stable) | 18:52 |
devananda | then the right place for it is, indeed, in ironic project team | 18:52 |
david-lyle | that's really the goal, but I will admit we're still working on a lot of the documentation | 18:52 |
devananda | so are qa and docs :) | 18:53 |
david-lyle | sure | 18:53 |
*** ZZelle_ has joined #openstack-horizon | 18:54 | |
david-lyle | devananda: I think ironic should own it unless you feel like it won't get any attention, but we could determine that down the road | 18:55 |
david-lyle | especially due to the standalone goal as well | 18:55 |
tqtran | tyr: what do you have in mind? | 18:56 |
david-lyle | I'll provide feedback to Niu and hopefully he can help/work with krotscheck, and the two teams can contribute to reviews | 18:56 |
*** jtomasek has quit IRC | 18:57 | |
*** nlahouti has joined #openstack-horizon | 18:57 | |
tqtran | r1chardj0n3s: you awake yet? | 18:57 |
david-lyle | tqtran: 5 am in Melbourne on Saturday | 18:59 |
tyr | tqtran: working on posting a patch now that shows it. But with the auto-collection, enabled dashboards are simply included into dashboard-app. | 18:59 |
tyr | tqtran: dashboard.module.js ends up having no purpose and goes away. | 18:59 |
tqtran | david-lyle: oh right.... | 19:00 |
tqtran | its sat their time | 19:00 |
devananda | david-lyle: thanks. if Niu works with the rest of the team, this could be very useful. if not, it may be short lived | 19:00 |
tqtran | tyr: thats what i dont think is right | 19:00 |
david-lyle | devananda: hopefully the former | 19:00 |
tqtran | tyr: https://review.openstack.org/#/c/193401/4/openstack_dashboard/enabled/_10_project.py | 19:00 |
david-lyle | :) | 19:00 |
tqtran | tyr: lets talk now, you and sqchen free? | 19:01 |
tqtran | david-lyle: you're welcome to chime in | 19:01 |
tqtran | and anyone else | 19:01 |
tqtran | could you post hat awesome tinyurl hp room again? | 19:01 |
david-lyle | tqtran: we talkin' software? | 19:01 |
*** clu_ has joined #openstack-horizon | 19:01 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Extending Horizon's plug-in mechanism to scss https://review.openstack.org/192500 | 19:01 |
openstackgerrit | Tyr Johanson proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 19:01 |
openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Reorganize openstack_dashboard https://review.openstack.org/193681 | 19:01 |
tyr | tqtran: sqchen: Talking about openstack_dashboard structure https://plus.google.com/hangouts/_/hp.com/ng-527625ab-ee6 | 19:03 |
tqtran | david-lyle: file structure for angular dashboard plugins | 19:03 |
*** petertr7 is now known as petertr7_away | 19:04 | |
tqtran | BAM! first! i call first! | 19:04 |
tqtran | do you have to host it tyr? | 19:05 |
tqtran | ok hangout is online, anyone interested can join | 19:06 |
tqtran | we have going to talk about angular file structure for dashboard plugin | 19:06 |
*** jtomasek has joined #openstack-horizon | 19:07 | |
*** hurgleburgler1 has joined #openstack-horizon | 19:09 | |
*** hurgleburgler has quit IRC | 19:09 | |
tqtran | https://review.openstack.org/#/c/193401/4/openstack_dashboard/enabled/_10_project.py | 19:11 |
*** jingjing_ren has joined #openstack-horizon | 19:12 | |
*** petertr7_away is now known as petertr7 | 19:15 | |
*** jingjing_ren has quit IRC | 19:17 | |
*** crobertsrh has quit IRC | 19:19 | |
*** bradjones has quit IRC | 19:20 | |
*** bradjones has joined #openstack-horizon | 19:22 | |
*** bradjones has quit IRC | 19:22 | |
*** bradjones has joined #openstack-horizon | 19:22 | |
*** crobertsrh has joined #openstack-horizon | 19:24 | |
*** Sukhdev has joined #openstack-horizon | 19:28 | |
*** annashen has quit IRC | 19:35 | |
*** jtomasek has quit IRC | 19:37 | |
*** amotoki_ has quit IRC | 19:41 | |
*** crobertsrh has quit IRC | 19:43 | |
*** crobertsrh has joined #openstack-horizon | 19:44 | |
*** petertr7 is now known as petertr7_away | 19:45 | |
*** ttrifonov is now known as zz_ttrifonov | 19:47 | |
*** annashen has joined #openstack-horizon | 19:53 | |
*** belmoreira has joined #openstack-horizon | 19:57 | |
*** petertr7_away is now known as petertr7 | 20:01 | |
kfox1111 | tqtran: why abandon it? | 20:03 |
*** Piet has joined #openstack-horizon | 20:03 | |
tqtran | kfox1111: talked to david-lyle, tyr, sqchen and we decided on a different path | 20:04 |
tyr | tqtran: just a thought...perhaps your identity panel should go into static/dashboard/identity for now...so that all the angular related code is in the same area...then we can move it all to /dashboards/ at the same time | 20:05 |
kfox1111 | ah. ok. | 20:05 |
tyr | tqtran: Otherwise we will have the identity angular code in the "new" good place (/dashboards), but the project angular code is the "old" bad place (static/dashboard) | 20:06 |
*** stevemar has joined #openstack-horizon | 20:07 | |
*** peristeri has quit IRC | 20:10 | |
*** e0ne has quit IRC | 20:11 | |
Piet | tqtran: can we chat about Add/Edit User modals on Monday? I have cycles to do UX work on them next week. | 20:13 |
*** belmoreira has quit IRC | 20:14 | |
*** crobertsrh has left #openstack-horizon | 20:19 | |
tqtran | Piet: yes, can you give me like 30m? | 20:19 |
tqtran | on a call atm | 20:20 |
Piet | tqtran: Let's do this on Monday | 20:20 |
*** annashen has quit IRC | 20:23 | |
tqtran | ok that sounds fine, what time? | 20:23 |
tqtran | tyr: im fine with that as well, either way, as long as it gets merge :) | 20:24 |
Piet | I have meetings from 10:30 - 12PM PST and 1PM PST. Free any other time | 20:25 |
tqtran | 1pm PST will be good | 20:25 |
*** annashen has joined #openstack-horizon | 20:25 | |
tqtran | are you free at 1pm pst? or did i miss read that? | 20:26 |
Piet | Anyone else want to join the UX meeting for the Add/Edit User modal? | 20:26 |
Piet | You did...I'm also busy from 1-2PM PST to discuss a Unified CLI study | 20:27 |
Piet | How about 2PM PST? | 20:27 |
tqtran | sounds grand | 20:27 |
tqtran | i'll block it out now | 20:27 |
Piet | k | 20:27 |
Piet | Anyone else want to attend this meeting? Domains may need to be part of the discussion (treading lightly...) | 20:29 |
Piet | Tyr: You may want to attend | 20:30 |
tqtran | Tyr got drafted | 20:30 |
tqtran | lol | 20:30 |
*** julim has quit IRC | 20:31 | |
tyr | very interested, but stuck in another meeting atm | 20:31 |
Piet | Maybe have Mathew Wood attend? | 20:31 |
Piet | david-lyle? | 20:32 |
* tqtran finds david-lyle ducking under the table. | 20:32 | |
Piet | Heh - no worries | 20:33 |
tqtran | i think it will be fine with just the 2 of us, no need to drag other folks in | 20:34 |
david-lyle | Piet: huh? | 20:34 |
Piet | david-lyle: Do you want to join the meeting on Monday to discuss UX for the Add/Edit User modals | 20:35 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 20:35 |
david-lyle | Piet yes | 20:36 |
Piet | Thats what I gigured | 20:36 |
Piet | "figured" | 20:36 |
ducttape_ | are you making domains a real thing now Piet ? | 20:37 |
Piet | OK...who is ducttape? | 20:37 |
ducttape_ | Eric P :p | 20:37 |
Piet | Ahhhhh | 20:37 |
Piet | Do you want to join? Improving both Domain and Project selection is a priority for me in this modal | 20:38 |
ducttape_ | umm.... sure. | 20:38 |
* ducttape_ is not sure what he got himself into | 20:38 | |
Piet | Was thinking the same thing...but you totally add value and glad to have you there | 20:39 |
* ducttape_ sees the clock on the wall says 20 minutes until beer o'clock | 20:39 | |
david-lyle | yeah, value | 20:39 |
david-lyle | :P | 20:39 |
ducttape_ | we have worked around domains with project roles for our deployment, and reading between the lines from keystone in YVR, it seems like domains are not going to be a big area of focus going forward | 20:40 |
*** CaptainMorgan is now known as morgan | 20:41 | |
ducttape_ | I'd think the project hierarchy would do that same thing, and would be more broadly useful / applicable. | 20:41 |
*** amotoki_ has joined #openstack-horizon | 20:42 | |
ducttape_ | this not not what you want to hear, but it's my $.02 | 20:42 |
* ducttape_ sees that he is still on track for beer o'clock | 20:42 | |
*** kztsv_mbp has joined #openstack-horizon | 20:42 | |
david-lyle | I think we're just trading fantasies | 20:43 |
david-lyle | domains, HMT, unicorn farts | 20:43 |
ducttape_ | HMT seems like it shouldn't be the complex to do (code wise), though management and implementation / deployment would melt peoples brains | 20:44 |
david-lyle | as long as you don't really care about roles and quotas | 20:45 |
*** lblanchard has quit IRC | 20:45 | |
david-lyle | otherwise it's all good | 20:45 |
*** Piet has quit IRC | 20:45 | |
ducttape_ | david-lyle - I can write a lot of that code like this "# TODO - figure this out" | 20:46 |
ducttape_ | and see - it's totally easy! | 20:46 |
david-lyle | that's my fear | 20:47 |
*** amotoki_ has quit IRC | 20:47 | |
*** mrunge has quit IRC | 20:47 | |
david-lyle | or something so convoluted to be useless | 20:47 |
ducttape_ | anyway, point being that domains have been around for a long time, and they have partially been picked up (being generous here). might as well try to go with the new hotness of HMT instead | 20:47 |
*** sqchen has quit IRC | 20:50 | |
ducttape_ | http://adam.younglogic.com/2013/11/policy-enforcement-openstack/ ayoung's article is fairly old at this point, and those techniques still can get at some of the same stuff that many people want | 20:51 |
*** raildo has quit IRC | 20:53 | |
*** jingjing_ren has joined #openstack-horizon | 20:55 | |
*** jbell8 has quit IRC | 20:57 | |
*** sqchen has joined #openstack-horizon | 21:05 | |
*** petertr7 is now known as petertr7_away | 21:07 | |
*** rushiagr_away is now known as rushiagr | 21:08 | |
*** radez is now known as radez_g0n3 | 21:14 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 21:17 |
*** tvanderwiel has quit IRC | 21:18 | |
sqchen | Hi tqtran: | 21:18 |
tqtran | hi sqchen | 21:19 |
sqchen | Pls take a look at the patch above. JS files works easily with the new code org as David said. jasmine passed. but ... | 21:20 |
*** bradjones has quit IRC | 21:20 | |
sqchen | wuth run the production, scss failed for this error:SuspiciousFileOperation: Attempted access to 'dashboard/../../dashboards/project/static/launch-instance/_launch-instance.scss' denied. | 21:21 |
*** bradjones has joined #openstack-horizon | 21:22 | |
*** bradjones has quit IRC | 21:22 | |
*** bradjones has joined #openstack-horizon | 21:22 | |
tqtran | ok, i'll take a look | 21:24 |
sqchen | The access get denied when trying to import a scss file from a folder out of the folder where doshboard.css resides. | 21:25 |
sqchen | thx. | 21:25 |
*** Piet_ has joined #openstack-horizon | 21:26 | |
*** annashen has quit IRC | 21:26 | |
*** Sukhdev has quit IRC | 21:27 | |
tqtran | lol kthxbye | 21:28 |
Piet_ | ducttape: That's the kind of info I need during the meeting on Monday | 21:28 |
*** tqtran is now known as tqtran_afk | 21:29 | |
Piet_ | david-lyle: Should I assume that default Domains and Projects should be part of the Add/Edit User modal? | 21:30 |
*** dboik has quit IRC | 21:33 | |
david-lyle | Piet, I actually believe default project is going away | 21:34 |
david-lyle | and I'm not sure what default domain is, other than the Domain "Default" | 21:34 |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 21:34 |
Piet_ | david-lyle: I believe that you could select which domain a new user would be added to. | 21:37 |
*** tqtran_afk is now known as tqtran | 21:38 | |
tqtran | Piet_: i dont want to complicate the add/edit user modals too much for this iteration | 21:38 |
tqtran | the main purpose is to demonstrate that we can angularize these panels | 21:39 |
tqtran | we can definitely iterate and improve on it down the road | 21:40 |
*** jtriley has quit IRC | 21:41 | |
*** annashen has joined #openstack-horizon | 21:41 | |
*** jingjing_ren has quit IRC | 21:41 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Create Project button for proper access only https://review.openstack.org/193307 | 21:42 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Updated UX for project and region selector https://review.openstack.org/186193 | 21:42 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 21:42 |
*** dboik has joined #openstack-horizon | 21:43 | |
tqtran | sqchen: for https://review.openstack.org/#/c/191592/ can we create a dependent patch for the renames? | 21:44 |
tqtran | its really hard to focus on the content when there are a ton of other files in there for renaming | 21:44 |
tqtran | we can approve them both at the same time | 21:44 |
tqtran | so there shouldnt be an issue | 21:44 |
sqchen | Can we ignore the renaming part? | 21:45 |
sqchen | I mean in the review? | 21:45 |
btully | anyone know if there’s a way to run ‘run_tests.sh’ more verbosely? I have a test that keeps hanging but I don’t know which test it is | 21:48 |
tqtran | so the patch works with the new plugin with the exception of the scss? | 21:48 |
sqchen | Maybe pull the patch down to your local machine makes it easier to see the structure of the code. | 21:48 |
sqchen | yes. | 21:48 |
btully | in the output of the run_tests.sh command I see that it runs nosetests with an option of —verbosity=1 | 21:49 |
tqtran | btully: doesnt look like there is a verbose option | 21:49 |
tqtran | there should be a stack trace of the error? | 21:49 |
btully | is there a way to override that from the run_tests.sh command? | 21:49 |
tqtran | sqchen: can you remind me why the renaming has to happen in this patch again? | 21:50 |
btully | thanks tqtran no i have to ctrl-c out of the hanging test in order to continue | 21:50 |
tqtran | i dont remember the reason | 21:50 |
tqtran | btully: really? wow... it should time out after a while? | 21:51 |
sqchen | I need to re-org the code to make the autodiscovery possible, and… | 21:51 |
sqchen | without the auto-discovery, re-org the code is very hard. :) | 21:51 |
tqtran | so my question is, can the renaming happen before the autodiscovery? | 21:52 |
*** stevemar has quit IRC | 21:52 | |
sqchen | can, but even harder then wihout the autodiscovery. | 21:52 |
tqtran | gah.... i dont get it, let me just take a look at the patch | 21:52 |
tqtran | pull it down an play with it | 21:53 |
*** dboik has quit IRC | 21:53 | |
tqtran | david-lyle: do you know if anyone is looking into this error? http://logs.openstack.org/65/188665/17/check/gate-horizon-dsvm-integration/3c246f0/console.html | 21:54 |
tqtran | its blocking a bunch of patches atm | 21:54 |
david-lyle | tqtran: it's being skipped as of this morning | 21:54 |
tqtran | ok awesome | 21:54 |
david-lyle | I believe there are people looking at it | 21:55 |
david-lyle | I'd have to scroll back to remember who | 21:55 |
tqtran | david-lyle, clu_: https://review.openstack.org/#/c/188665/ when you guys get a chance, i think its pretty solid and ready to go. | 21:56 |
*** rushiagr is now known as rushiagr_away | 22:01 | |
*** drupalmonkey has quit IRC | 22:05 | |
*** garthb has quit IRC | 22:11 | |
*** garthb_ has quit IRC | 22:11 | |
r1chardj0n3s | morning | 22:16 |
r1chardj0n3s | tqtran: you pinged? | 22:16 |
r1chardj0n3s | (it being Saturday, I felt an 8am sleep in was OK :) | 22:17 |
r1chardj0n3s | tqtran: I just saw https://review.openstack.org/#/c/193671 - at first glance, I don't know why we need it. we already have a mechanism for adding dependencies to the app, why do we need one to add dependencies deep in the app? | 22:18 |
r1chardj0n3s | tqtran: there's absolutely nothing wrong with two things declaring they have a dependency on a common third thing (ie two dashboard modules declaring they depdend on the common dashboard module) | 22:20 |
r1chardj0n3s | tqtran: angular's module structure doesn't require you to have all the sub-modules possible as dependencies of a module | 22:21 |
r1chardj0n3s | tqtran: see the structure of angular itself for a good example | 22:21 |
r1chardj0n3s | tqtran: the hz.dashboard module is doing two things: declaring a namespace (which isn't entirely necessary but is *neat*) and also declaring a constant | 22:22 |
*** jpomero has quit IRC | 22:30 | |
*** jasondot_ has quit IRC | 22:32 | |
*** ducttape_ has quit IRC | 22:37 | |
*** gyee has quit IRC | 22:39 | |
r1chardj0n3s | I've moved my words over to the openstack-dev list | 22:43 |
*** amotoki_ has joined #openstack-horizon | 22:43 | |
hurgleburgler1 | Does anyone know what might cause this error? | 22:45 |
hurgleburgler1 | Recoverable error: Invalid service catalog service: network | 22:45 |
r1chardj0n3s | I reckon it might be an invalid service catalog. That'd be your problem | 22:45 |
* r1chardj0n3s ducks | 22:46 | |
esp | lol | 22:46 |
hurgleburgler1 | ಠ_ಠ | 22:46 |
r1chardj0n3s | has someone been hand-editing your service catalog? | 22:47 |
tqtran | r1chardj0n3s: i think we are removing the hz.dashboard module | 22:47 |
r1chardj0n3s | but it defines that useful constant | 22:47 |
r1chardj0n3s | "we"? | 22:47 |
r1chardj0n3s | :) | 22:47 |
tqtran | that can move up to the app level | 22:47 |
r1chardj0n3s | I think maybe I missed another conversation | 22:48 |
r1chardj0n3s | ;) | 22:48 |
tqtran | yeah you did lol | 22:48 |
r1chardj0n3s | hmm | 22:48 |
tqtran | here is the outcome of the discussion | 22:48 |
r1chardj0n3s | I actually like that the dashboard defines that constant | 22:48 |
tqtran | and the reasons behind it | 22:48 |
r1chardj0n3s | could you maybe reply to my mail? | 22:48 |
r1chardj0n3s | rather than in here please? | 22:48 |
tqtran | hasnt shown up yet | 22:48 |
tqtran | but yeah i can do that there | 22:49 |
*** amotoki_ has quit IRC | 22:49 | |
r1chardj0n3s | thanks mate I think that'll help things be clearer :) | 22:49 |
tqtran | yeah, theres quite a few things to consider because we want to keep the dashboards pluggable | 22:49 |
r1chardj0n3s | yep, that was tip-top in my mind when I was thinking this through yesterday | 22:50 |
tqtran | so some of the static actually has to move out of the static folder and into /dashboards/static instead of /static/dashboards | 22:50 |
*** annashen has quit IRC | 22:50 | |
r1chardj0n3s | ok, now I really want to read the full explanation, 'cos I don't see the point of that ;) | 22:50 |
tqtran | haha yeah, i'll explain it better in the email | 22:51 |
* r1chardj0n3s waits for email :) | 22:51 | |
tqtran | just waiting for it to show up | 22:51 |
tqtran | omg, you didnt prefix it with [horizon] | 22:51 |
tqtran | it ended up in my junk | 22:51 |
r1chardj0n3s | bugger. sorry! | 22:52 |
* r1chardj0n3s goes off to instruct daughter in pancake batter preparation | 22:53 | |
openstackgerrit | Brianna Poulos proposed openstack/horizon: Add volume type encryption update https://review.openstack.org/72024 | 22:57 |
*** bpokorny has joined #openstack-horizon | 23:03 | |
*** bpokorny_ has quit IRC | 23:03 | |
*** jingjing_ren has joined #openstack-horizon | 23:04 | |
*** dsneddon is now known as dsneddon_away | 23:05 | |
*** bigjools has quit IRC | 23:05 | |
*** zigo has quit IRC | 23:05 | |
*** juggler has quit IRC | 23:06 | |
r1chardj0n3s | tqtran (feel free to add [horizon] ;) | 23:06 |
tqtran | i am haha, almost done with the email | 23:06 |
*** juggler has joined #openstack-horizon | 23:06 | |
*** zigo has joined #openstack-horizon | 23:07 | |
*** bigjools has joined #openstack-horizon | 23:08 | |
*** jingjing_ren has quit IRC | 23:08 | |
*** alexvictorchan has quit IRC | 23:09 | |
*** r1chardj0n3s is now known as r1chardj0n3s_afk | 23:10 | |
tqtran | r1chardj0n3s_afk: ok replied in the email, hopefully its clear, if not, ping me and we can talk about it | 23:11 |
openstackgerrit | Brianna Poulos proposed openstack/horizon: Add volume type encryption update https://review.openstack.org/72024 | 23:14 |
*** juggler has quit IRC | 23:16 | |
*** alexvictorchan has joined #openstack-horizon | 23:17 | |
*** juggler has joined #openstack-horizon | 23:17 | |
*** alexvictorchan has quit IRC | 23:19 | |
*** bpokorny_ has joined #openstack-horizon | 23:21 | |
*** bpokorny has quit IRC | 23:22 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 23:22 |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 23:24 |
*** fedexo has quit IRC | 23:31 | |
*** fedexo has joined #openstack-horizon | 23:32 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 23:33 |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 23:34 |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 23:35 |
tqtran | sqchen: https://review.openstack.org/#/c/191592/14/openstack_dashboard/dashboards/admin/static/dashboard/admin/namespace-controller.js | 23:38 |
tqtran | i think because it is in the tech-debt folder, it doesn't belong in /dashboards/admin/static | 23:39 |
tqtran | *tech-debt moduler | 23:39 |
*** kztsv_mbp has quit IRC | 23:39 | |
*** gugl has joined #openstack-horizon | 23:39 | |
tqtran | it should go into /static/dashboard/core/tech-debt ? | 23:40 |
sqchen | ok | 23:40 |
*** ducttape_ has joined #openstack-horizon | 23:41 | |
*** ducttape_ has quit IRC | 23:41 | |
*** ducttape_ has joined #openstack-horizon | 23:41 | |
*** Drago has quit IRC | 23:43 | |
tqtran | sqchen: i wonder if the scss compiler kick in before the statics are aggregated? | 23:45 |
tqtran | that might be why it isn't able to find the imports properly | 23:45 |
sqchen | but it works before I moving them into dashboards | 23:46 |
sqchen | I think that is security issue. It is try to find file out of the current folder. | 23:47 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: WIP Applying auto-file-discovery https://review.openstack.org/191592 | 23:48 |
tqtran | that might be true, i dont know if django aggregates the folder or just create some form of links | 23:49 |
tqtran | god... i would hate to have to separate out the css like we do today | 23:49 |
tqtran | this should be a common problem enough, google should have an answer for | 23:50 |
*** ducttape_ has quit IRC | 23:53 | |
sqchen | tqtran:, Karma is crying about this change. :) | 23:54 |
*** alexvictorchan has joined #openstack-horizon | 23:56 | |
*** ZZelle_ has quit IRC | 23:57 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for transfer-table https://review.openstack.org/191200 | 23:58 |
*** petertr7_away is now known as petertr7 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!