*** alexvictorchan has quit IRC | 00:03 | |
*** kzaitsev_mb has quit IRC | 00:07 | |
*** davidmichaelkarr has quit IRC | 00:07 | |
*** jtriley has quit IRC | 00:09 | |
*** yamamoto has quit IRC | 00:13 | |
*** sqchen has quit IRC | 00:18 | |
openstackgerrit | Merged openstack/horizon: Wait until the image is registered in Sahara image test https://review.openstack.org/193592 | 00:19 |
---|---|---|
*** garthb_ has joined #openstack-horizon | 00:20 | |
*** garthb has quit IRC | 00:24 | |
*** garthb__ has quit IRC | 00:24 | |
*** garthb_ has quit IRC | 00:26 | |
*** dsneddon has quit IRC | 00:26 | |
*** dsneddon has joined #openstack-horizon | 00:27 | |
*** sqchen has joined #openstack-horizon | 00:27 | |
*** SimonChung has quit IRC | 00:32 | |
*** bradjones has quit IRC | 00:34 | |
*** bradjones has joined #openstack-horizon | 00:35 | |
*** bradjones has quit IRC | 00:35 | |
*** bradjones has joined #openstack-horizon | 00:35 | |
*** ducttape_ has joined #openstack-horizon | 00:38 | |
*** tjones1 has joined #openstack-horizon | 00:39 | |
*** jingjing_ren has joined #openstack-horizon | 00:40 | |
*** yingjun has joined #openstack-horizon | 00:42 | |
*** chen12 has left #openstack-horizon | 00:43 | |
*** jasondotstar has quit IRC | 00:43 | |
*** jingjing_ren has quit IRC | 00:46 | |
*** jingjing_ren has joined #openstack-horizon | 00:46 | |
*** annashen has joined #openstack-horizon | 00:48 | |
*** nlahouti has quit IRC | 00:51 | |
openstackgerrit | Jingjing Ren proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 01:05 |
*** bpokorny has quit IRC | 01:09 | |
*** bpokorny has joined #openstack-horizon | 01:10 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: [Launch instance Fix] Fixes booting issue when booting from volume https://review.openstack.org/191716 | 01:12 |
*** yingjun has quit IRC | 01:12 | |
*** yingjun has joined #openstack-horizon | 01:12 | |
*** bpokorny has quit IRC | 01:14 | |
*** tjones1 has quit IRC | 01:18 | |
*** tjones1 has joined #openstack-horizon | 01:18 | |
*** jingjing_ren has quit IRC | 01:19 | |
*** yingjun_ has joined #openstack-horizon | 01:19 | |
*** ducttape_ has quit IRC | 01:21 | |
*** yingjun has quit IRC | 01:23 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: CIDR is required for creating subnet workflow https://review.openstack.org/194904 | 01:24 |
*** sqchen has quit IRC | 01:25 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: CIDR is required for creating subnet workflow https://review.openstack.org/194904 | 01:26 |
*** sqchen has joined #openstack-horizon | 01:26 | |
*** darrenc is now known as darrenc_afk | 01:27 | |
*** ybathia has quit IRC | 01:27 | |
*** ducttape_ has joined #openstack-horizon | 01:34 | |
*** jtriley has joined #openstack-horizon | 01:36 | |
*** ducttape_ has quit IRC | 01:42 | |
*** jtriley has quit IRC | 01:42 | |
*** yingjun_ has quit IRC | 01:42 | |
*** Raildo_ has joined #openstack-horizon | 01:48 | |
*** Raildo_ has quit IRC | 01:48 | |
*** dsneddon has quit IRC | 01:49 | |
*** Raildo_ has joined #openstack-horizon | 01:49 | |
*** dsneddon has joined #openstack-horizon | 01:50 | |
*** jingjing_ren has joined #openstack-horizon | 01:50 | |
*** darrenc_afk is now known as darrenc | 01:53 | |
*** jingjing_ren has quit IRC | 01:54 | |
*** yamamoto has joined #openstack-horizon | 01:57 | |
*** stevemar has joined #openstack-horizon | 01:57 | |
*** Ctina___ has quit IRC | 01:58 | |
*** julim has joined #openstack-horizon | 01:58 | |
*** Ctina___ has joined #openstack-horizon | 01:58 | |
*** Ctina___ has quit IRC | 01:59 | |
*** Ctina___ has joined #openstack-horizon | 01:59 | |
*** yingjun has joined #openstack-horizon | 02:01 | |
*** yingjun has quit IRC | 02:02 | |
*** Ctina___ has quit IRC | 02:04 | |
*** reed has quit IRC | 02:09 | |
*** reed has joined #openstack-horizon | 02:10 | |
openstackgerrit | Merged openstack/horizon: Normalizing Karma configuration https://review.openstack.org/193851 | 02:10 |
*** Drago has quit IRC | 02:16 | |
*** tyr__ has quit IRC | 02:17 | |
*** zhenguo has joined #openstack-horizon | 02:18 | |
*** jasondotstar has joined #openstack-horizon | 02:18 | |
*** fifieldt_ has quit IRC | 02:23 | |
*** ducttape_ has joined #openstack-horizon | 02:26 | |
*** annashen has quit IRC | 02:28 | |
*** lhcheng has joined #openstack-horizon | 02:30 | |
*** sqchen has quit IRC | 02:37 | |
*** jtriley has joined #openstack-horizon | 02:38 | |
*** jtriley has quit IRC | 02:43 | |
*** Longgeek_ has joined #openstack-horizon | 02:52 | |
*** Longgeek has quit IRC | 02:52 | |
*** sqchen has joined #openstack-horizon | 02:52 | |
*** Longgeek has joined #openstack-horizon | 02:53 | |
*** Longgeek has quit IRC | 02:55 | |
*** Longgeek has joined #openstack-horizon | 02:55 | |
*** Longgeek_ has quit IRC | 02:56 | |
*** chlong has quit IRC | 02:57 | |
*** chlong has joined #openstack-horizon | 02:58 | |
*** Longgeek has quit IRC | 02:59 | |
*** Longgeek_ has joined #openstack-horizon | 02:59 | |
*** Longgeek has joined #openstack-horizon | 03:04 | |
*** Longgeek_ has quit IRC | 03:08 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: [Launch instance Fix] Fixes booting issue when booting from volume https://review.openstack.org/191716 | 03:11 |
*** bradjones has quit IRC | 03:16 | |
*** bradjones has joined #openstack-horizon | 03:18 | |
*** bradjones has quit IRC | 03:18 | |
*** bradjones has joined #openstack-horizon | 03:18 | |
*** iamjarvo has joined #openstack-horizon | 03:19 | |
*** Longgeek has quit IRC | 03:20 | |
*** Longgeek has joined #openstack-horizon | 03:23 | |
*** julim has quit IRC | 03:26 | |
*** Raildo_ has quit IRC | 03:27 | |
*** tyr_ has joined #openstack-horizon | 03:28 | |
*** ducttape_ has quit IRC | 03:31 | |
*** tyr_ has quit IRC | 03:32 | |
*** jasondotstar has quit IRC | 03:33 | |
*** neelabh has joined #openstack-horizon | 03:36 | |
*** Longgeek has quit IRC | 03:37 | |
*** Longgeek has joined #openstack-horizon | 03:37 | |
neelabh | Hi Guys, I am testing the angularjs for ceilometer same as the in launch-instance. Please help me on this, see this link: https://ask.openstack.org/en/question/68879/how-to-request-the-graph-data-in-ceilometer-through-angularjs-as-launch-instance/ | 03:39 |
*** Longgeek_ has joined #openstack-horizon | 03:42 | |
*** SimonChung has joined #openstack-horizon | 03:42 | |
*** Longgee__ has joined #openstack-horizon | 03:43 | |
openstackgerrit | Merged openstack/horizon: Optimize getting unit in "metering" dashboard https://review.openstack.org/173894 | 03:45 |
*** sqchen has quit IRC | 03:45 | |
*** Longgeek has quit IRC | 03:46 | |
*** SimonChung1 has joined #openstack-horizon | 03:46 | |
*** Longgeek_ has quit IRC | 03:47 | |
*** Longgeek has joined #openstack-horizon | 03:48 | |
*** SimonChung has quit IRC | 03:49 | |
*** Longgee__ has quit IRC | 03:52 | |
*** sqchen has joined #openstack-horizon | 03:57 | |
openstackgerrit | zhu.rong proposed openstack/horizon: fix network_topology router add interface redirect url https://review.openstack.org/194926 | 03:57 |
*** masco has joined #openstack-horizon | 04:01 | |
*** kiran-r has joined #openstack-horizon | 04:05 | |
*** Longgeek has quit IRC | 04:11 | |
*** Longgeek has joined #openstack-horizon | 04:12 | |
*** asahlin has quit IRC | 04:13 | |
*** rbertram has quit IRC | 04:13 | |
*** kiranr has joined #openstack-horizon | 04:14 | |
*** kiranr has quit IRC | 04:15 | |
*** hurgleburgler has quit IRC | 04:18 | |
*** hurgleburgler has joined #openstack-horizon | 04:19 | |
*** davidmichaelkarr has joined #openstack-horizon | 04:21 | |
*** iamjarvo has quit IRC | 04:22 | |
openstackgerrit | Canh Truong proposed openstack/horizon: Add description field in the user table https://review.openstack.org/190944 | 04:23 |
*** jtriley has joined #openstack-horizon | 04:27 | |
*** drupalmonkey has quit IRC | 04:29 | |
*** kiran-r has quit IRC | 04:30 | |
*** sayan_ has joined #openstack-horizon | 04:30 | |
*** jtriley has quit IRC | 04:32 | |
openstackgerrit | Kelly Domico proposed openstack/horizon: JSCS cleanup - style guide cleanup for action-list https://review.openstack.org/188995 | 04:34 |
openstackgerrit | Merged openstack/horizon: Error message for invalid cluster details page https://review.openstack.org/193072 | 04:34 |
*** yamamoto has quit IRC | 04:34 | |
*** yamamoto has joined #openstack-horizon | 04:39 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: [Launch instance Fix] Fixes booting issue when booting from volume https://review.openstack.org/191716 | 04:48 |
*** alexvictorchan has joined #openstack-horizon | 04:50 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: ID Panels with long roles names should fit https://review.openstack.org/192028 | 05:21 |
*** SimonChung has joined #openstack-horizon | 05:21 | |
*** SimonChung1 has quit IRC | 05:22 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: ID Panels with long roles names should fit https://review.openstack.org/192028 | 05:23 |
*** SimonChung1 has joined #openstack-horizon | 05:25 | |
*** SimonChung2 has joined #openstack-horizon | 05:26 | |
*** SimonChung has quit IRC | 05:27 | |
openstackgerrit | zhu.rong proposed openstack/horizon: fix network_topology router add interface redirect url https://review.openstack.org/194926 | 05:27 |
*** jtriley has joined #openstack-horizon | 05:28 | |
*** SimonChung1 has quit IRC | 05:30 | |
*** jtriley has quit IRC | 05:34 | |
*** mgarza_ has joined #openstack-horizon | 05:41 | |
*** rbertram has joined #openstack-horizon | 05:45 | |
*** asahlin has joined #openstack-horizon | 05:45 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Making farma.config.js files compliant to jscs rules https://review.openstack.org/194944 | 05:48 |
*** neelabh has quit IRC | 05:55 | |
*** neelabh has joined #openstack-horizon | 05:56 | |
openstackgerrit | zhu.rong proposed openstack/horizon: test, please ignore it https://review.openstack.org/194947 | 05:56 |
neelabh | How add angularjs similar to launch instance for ceilometer, I tried to follow the same procedure but didn't succeeded, please see this link: https://ask.openstack.org/en/question/68879/how-to-request-the-graph-data-in-ceilometer-through-angularjs-as-launch-instance/ | 05:58 |
*** alexvictorchan has quit IRC | 05:59 | |
*** jtomasek has joined #openstack-horizon | 06:03 | |
*** zhenguo has quit IRC | 06:03 | |
*** neelabh has quit IRC | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/194948 | 06:06 |
*** e0ne has joined #openstack-horizon | 06:07 | |
*** tjones1 has quit IRC | 06:09 | |
*** lhcheng has quit IRC | 06:14 | |
*** kiran-r has joined #openstack-horizon | 06:16 | |
*** fedexo has joined #openstack-horizon | 06:17 | |
*** lhcheng has joined #openstack-horizon | 06:17 | |
*** belmoreira has joined #openstack-horizon | 06:18 | |
*** kiranr has joined #openstack-horizon | 06:18 | |
*** kiranr has quit IRC | 06:18 | |
*** _kiran_ has joined #openstack-horizon | 06:18 | |
*** e0ne has quit IRC | 06:20 | |
*** bradjones has quit IRC | 06:20 | |
*** kiran-r has quit IRC | 06:21 | |
*** kiranr has joined #openstack-horizon | 06:22 | |
*** bradjones has joined #openstack-horizon | 06:22 | |
*** bradjones has quit IRC | 06:22 | |
*** bradjones has joined #openstack-horizon | 06:22 | |
*** JeanBriceCombebi has joined #openstack-horizon | 06:22 | |
*** _kiran_ has quit IRC | 06:23 | |
*** kiranr has quit IRC | 06:23 | |
*** e0ne has joined #openstack-horizon | 06:24 | |
*** kiran-r has joined #openstack-horizon | 06:24 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Making karma.config.js files compliant to jscs rules https://review.openstack.org/194944 | 06:25 |
*** kiranr has joined #openstack-horizon | 06:27 | |
*** kiran-r has quit IRC | 06:29 | |
*** amotoki has joined #openstack-horizon | 06:29 | |
*** mrunge has joined #openstack-horizon | 06:31 | |
*** kiranr has quit IRC | 06:32 | |
*** e0ne is now known as e0ne_ | 06:36 | |
*** bradjones has quit IRC | 06:36 | |
*** stevemar has quit IRC | 06:38 | |
*** bradjones has joined #openstack-horizon | 06:39 | |
*** bradjones has quit IRC | 06:39 | |
*** bradjones has joined #openstack-horizon | 06:39 | |
*** hurgleburgler has quit IRC | 06:40 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Add required to cidr field for 'Add Subnet' https://review.openstack.org/194904 | 06:40 |
*** e0ne_ has quit IRC | 06:42 | |
*** e0ne has joined #openstack-horizon | 06:45 | |
*** e0ne is now known as e0ne_ | 06:46 | |
*** e0ne_ has quit IRC | 06:55 | |
*** markus_z has joined #openstack-horizon | 06:56 | |
*** Ala has joined #openstack-horizon | 06:58 | |
*** sayan_ has quit IRC | 07:01 | |
*** sayan has joined #openstack-horizon | 07:02 | |
*** sqchen has left #openstack-horizon | 07:02 | |
*** fedexo has quit IRC | 07:05 | |
*** dguerri` is now known as dguerri | 07:12 | |
*** kiran-r has joined #openstack-horizon | 07:13 | |
*** kiran-r has quit IRC | 07:14 | |
*** jtomasek has quit IRC | 07:15 | |
*** kiran-r has joined #openstack-horizon | 07:17 | |
*** jtriley has joined #openstack-horizon | 07:17 | |
openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Added 'enabled' option in create user form https://review.openstack.org/194967 | 07:19 |
*** jtriley has quit IRC | 07:22 | |
*** SimonChung2 has quit IRC | 07:23 | |
*** dguerri is now known as dguerri` | 07:27 | |
*** lhcheng_ has joined #openstack-horizon | 07:30 | |
*** MaxV has joined #openstack-horizon | 07:30 | |
*** lhcheng has quit IRC | 07:33 | |
*** mgarza_ has quit IRC | 07:33 | |
*** romainh has joined #openstack-horizon | 07:35 | |
*** dguerri` is now known as dguerri | 07:42 | |
*** dguerri is now known as dguerri` | 07:44 | |
*** lisssb has joined #openstack-horizon | 07:48 | |
*** zhenguo has joined #openstack-horizon | 07:50 | |
*** bluex-pl has joined #openstack-horizon | 08:00 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:00 | |
*** bluex-pl has quit IRC | 08:00 | |
*** zz_ttrifonov is now known as ttrifonov | 08:00 | |
*** bluex-pl has joined #openstack-horizon | 08:01 | |
*** chlong has quit IRC | 08:01 | |
*** JeanBriceCombebi has quit IRC | 08:07 | |
*** JeanBriceCombebi has joined #openstack-horizon | 08:09 | |
*** bluex-pl has quit IRC | 08:10 | |
*** ygbo has joined #openstack-horizon | 08:17 | |
*** openstack has quit IRC | 08:25 | |
*** openstack has joined #openstack-horizon | 08:26 | |
*** JeanBriceCombebi has quit IRC | 08:30 | |
*** jcoufal has joined #openstack-horizon | 08:31 | |
*** e0ne is now known as e0ne_ | 08:34 | |
*** rushiagr_away is now known as rushiagr | 08:38 | |
*** e0ne_ has quit IRC | 08:39 | |
*** e0ne has joined #openstack-horizon | 08:40 | |
*** kiran-r has quit IRC | 08:41 | |
*** yamamoto has quit IRC | 08:41 | |
*** kzaitsev_mb has quit IRC | 08:45 | |
*** e0ne has quit IRC | 08:45 | |
*** bradjones has quit IRC | 08:49 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/194948 | 08:49 |
*** bradjones has joined #openstack-horizon | 08:51 | |
*** bradjones has quit IRC | 08:51 | |
*** bradjones has joined #openstack-horizon | 08:51 | |
*** mpavlase has joined #openstack-horizon | 08:51 | |
*** pkarikh has joined #openstack-horizon | 08:54 | |
*** yamamoto has joined #openstack-horizon | 08:54 | |
*** lhcheng_ has quit IRC | 08:55 | |
openstackgerrit | zhu.rong proposed openstack/horizon: Set cidr required true for create network https://review.openstack.org/194998 | 08:56 |
*** lhcheng has joined #openstack-horizon | 08:57 | |
*** jtriley has joined #openstack-horizon | 09:05 | |
*** bradjones has quit IRC | 09:09 | |
*** jtriley has quit IRC | 09:10 | |
*** bradjones has joined #openstack-horizon | 09:11 | |
*** bradjones has quit IRC | 09:11 | |
*** bradjones has joined #openstack-horizon | 09:11 | |
*** oro has joined #openstack-horizon | 09:12 | |
*** lhcheng has quit IRC | 09:12 | |
*** dguerri` is now known as dguerri | 09:13 | |
*** jtomasek has joined #openstack-horizon | 09:28 | |
*** sayan has quit IRC | 09:29 | |
*** bluex-pl has joined #openstack-horizon | 09:31 | |
*** akrivoka has joined #openstack-horizon | 09:35 | |
*** lisssb has quit IRC | 09:37 | |
*** tosky has joined #openstack-horizon | 09:38 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: Change widget attribute to string https://review.openstack.org/194642 | 09:45 |
*** e0ne has joined #openstack-horizon | 09:46 | |
*** jasondotstar has joined #openstack-horizon | 09:49 | |
*** vijendar1 has joined #openstack-horizon | 10:04 | |
*** kzaitsev_mb has joined #openstack-horizon | 10:05 | |
*** vijendar has quit IRC | 10:06 | |
*** mrunge has quit IRC | 10:13 | |
*** vijendar1 has quit IRC | 10:13 | |
*** zhenguo has quit IRC | 10:13 | |
*** vijendar has joined #openstack-horizon | 10:13 | |
*** DRoBeR has joined #openstack-horizon | 10:15 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: fix delete action always cause error https://review.openstack.org/195023 | 10:17 |
*** sayan has joined #openstack-horizon | 10:17 | |
*** mrunge has joined #openstack-horizon | 10:21 | |
*** yamamoto has quit IRC | 10:22 | |
*** bluex-pl has quit IRC | 10:23 | |
*** kiranr has joined #openstack-horizon | 10:36 | |
*** robcresswell has joined #openstack-horizon | 10:36 | |
robcresswell | Gooood morning everyone. | 10:37 |
tosky | hi robcresswell | 10:38 |
robcresswell | tosky: o/ | 10:38 |
*** kiranr has quit IRC | 10:40 | |
DRoBeR | Hello, mates. I just found a bug in horizon behaviour and reported it at launchpad. I think it's not a security vulnerability but I might be wrong. So, to be sure, I just ask: A user without a password... can't log in, right? :) | 10:46 |
DRoBeR | I tried using no pass in CLI and no pass in dashboard and couldn't log in. Which is nice, indeed. Perhaps there's a way to do it and I'm just ignoring it. | 10:48 |
openstackgerrit | Merged openstack/tuskar-ui: Update Neutron initialization setup https://review.openstack.org/192726 | 10:50 |
robcresswell | DRoBeR: Sorry, what's the issue? | 10:50 |
robcresswell | I am confused :) | 10:50 |
mrunge | DRoBeR, uhm, you need to have a username/password to be able to interact with horizon | 10:52 |
openstackgerrit | Merged openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/194838 | 10:53 |
*** vgridnev has joined #openstack-horizon | 10:54 | |
*** jtriley has joined #openstack-horizon | 10:55 | |
DRoBeR | Issue is that Horizon removes user password when, at least, you change a user's email address from user list | 10:55 |
DRoBeR | https://bugs.launchpad.net/horizon/+bug/1468300 | 10:56 |
openstack | Launchpad bug 1468300 in OpenStack Dashboard (Horizon) "changing user's email from user list deletes user password" [Undecided,New] | 10:56 |
robcresswell | Woah | 10:57 |
mrunge | DRoBeR, what database are you querying there? | 10:57 |
DRoBeR | As far as I tested, when it removes the password it is making the user unable to interact with Openstack. I had to set admin password directly at the database due to this. | 10:58 |
DRoBeR | MariaDB -> Keystone | 10:58 |
*** jtriley has quit IRC | 10:59 | |
mrunge | ok, we're talking about keystone database, not any temporary user in django | 11:01 |
DRoBeR | That's right, sir. I guess that it's a behavirour related to the "fast change" functionality on Dashboard which tells the backend to set a null password. So, I think it could have effect on any connected backend. [I'm really new here. don't know how many can have] | 11:07 |
*** ZZelle-away has quit IRC | 11:14 | |
*** ZZelle-away has joined #openstack-horizon | 11:14 | |
robcresswell | It sounds like an empty value is being passed through on update | 11:17 |
robcresswell | Rather than just not updating | 11:17 |
robcresswell | Someone has derped. Just seeing if I can confirm | 11:17 |
*** jasondotstar has quit IRC | 11:21 | |
*** yamamoto has joined #openstack-horizon | 11:27 | |
mrunge | DRoBeR, what browser were you using? | 11:27 |
mrunge | DRoBeR, did you use password store in your browser? | 11:27 |
*** masco has quit IRC | 11:28 | |
*** bluex-pl has joined #openstack-horizon | 11:29 | |
*** bluex-pl has quit IRC | 11:29 | |
*** bradjones has quit IRC | 11:29 | |
*** bluex-pl has joined #openstack-horizon | 11:29 | |
*** bradjones has joined #openstack-horizon | 11:30 | |
*** bradjones has quit IRC | 11:30 | |
*** bradjones has joined #openstack-horizon | 11:30 | |
robcresswell | I think I can recreate it fine | 11:31 |
robcresswell | Yeah, wow, thats broken | 11:33 |
robcresswell | Changing the email with the inline table edit | 11:33 |
robcresswell | Makes that user unable to login | 11:33 |
robcresswell | Tried with existing and newly created user, checked they could login, then changed to admin, altered password | 11:33 |
robcresswell | and now neither can login | 11:34 |
robcresswell | That is on master btw | 11:34 |
*** sayan has quit IRC | 11:35 | |
*** sayan has joined #openstack-horizon | 11:36 | |
*** aix has quit IRC | 11:37 | |
*** kzaitsev_mb has quit IRC | 11:41 | |
robcresswell | mrunge: Any luck confirming that bug also? | 11:43 |
*** kiranr has joined #openstack-horizon | 11:48 | |
*** kzaitsev_mb has joined #openstack-horizon | 11:51 | |
r1chardj0n3s | hullo | 11:51 |
*** kiranr has quit IRC | 11:52 | |
*** ducttape_ has joined #openstack-horizon | 11:53 | |
robcresswell | r1chardj0n3s: o/ | 11:55 |
r1chardj0n3s | how's things robcresswell? | 11:56 |
*** alexpilotti has joined #openstack-horizon | 11:56 | |
robcresswell | Goood. Catching up with upstream work. How's things with you? | 11:57 |
robcresswell | Also it is very late/early for you, right? | 11:58 |
r1chardj0n3s | things are good - bunch of horizon reviews & have finally got the pycon au programme all settled so I'm looking into the venue options for 2016/17 now (I'll be chairing in Melbourne, most likely) | 11:58 |
r1chardj0n3s | yeah, it's 10pm | 11:58 |
r1chardj0n3s | I stopped work for a while to crash some Kerbals around :) | 11:58 |
r1chardj0n3s | totally stumped on this gate check issue that sean's run into with his auto-js-discovery patch | 11:59 |
robcresswell | link? | 11:59 |
r1chardj0n3s | gonna lean on some #infra folk tomorrow to try to sort it out, and maybe the other integration failure we've been seeing for ages too | 11:59 |
robcresswell | There's a whole bunch of integration failures right now. I know a couple people around my tz have been looking at them | 12:00 |
r1chardj0n3s | https://review.openstack.org/#/c/193771/ is the patch. you can see pretty consistent tempest fail. It's something in the way the gate devstack is set up with apache to do the minification/compression that's breaking | 12:00 |
robcresswell | Also infra appears to have stopped linking bugs to patches (or at least several I just looked at), which is making my cleanup a pita. | 12:01 |
r1chardj0n3s | it's a bugger to reproduce (impossible almost) without reproducing the entire gate environment, which is a tricky proposition :/ | 12:01 |
r1chardj0n3s | I had a crack at it today, but could not get a "gate" to build :/ | 12:01 |
r1chardj0n3s | fortunately I have a #infra root as a minion, so I'll work with him tomorrow if no-one cracks it while I'm asleep :) | 12:02 |
*** doug-fish has joined #openstack-horizon | 12:03 | |
robcresswell | Ahh okay. I don't have any contacts in infra. I need to bump that jasmine update patch if it hasnt gone in yet, and then I had a meeting with diana yesterday about the theming changes | 12:03 |
neillc | Hello. Is there a meeting tonight or has my calendar lied to me? | 12:03 |
robcresswell | Which are soo awesome, she sent me her presentation. Damn cool stuff. | 12:03 |
r1chardj0n3s | we are in meeting 3 | 12:03 |
robcresswell | Oh yeah, 1pm already | 12:03 |
neillc | Yeah I see that now :) | 12:04 |
*** yamamoto has quit IRC | 12:04 | |
*** ducttape_ has quit IRC | 12:07 | |
*** yamamoto has joined #openstack-horizon | 12:07 | |
*** jasondotstar has joined #openstack-horizon | 12:09 | |
*** JeanBriceCombebi has joined #openstack-horizon | 12:10 | |
*** jasondotstar has quit IRC | 12:11 | |
*** rushiagr is now known as rushiagr_away | 12:14 | |
openstackgerrit | svasheka proposed openstack/horizon: Draft of screenshot_on_failure decorator https://review.openstack.org/194646 | 12:22 |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:23 |
svasheka | mpavlase, mrunge hi guys. I'm trying to find selenium-integration-testing blueprint, but with no success. Was it renamed? | 12:25 |
mpavlase | svasheka: hi, let me check it | 12:26 |
*** MaxV has quit IRC | 12:27 | |
mpavlase | svasheka: I found something here.. https://blueprints.launchpad.net/horizon/+spec/selenium-integration-testing | 12:29 |
svasheka | mpavlase, hm.. thanks. don't know why I couldn't find it :( | 12:29 |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:30 |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:30 |
*** JeanBriceCombebi has quit IRC | 12:32 | |
tosky | svasheka: because it's closed | 12:32 |
tosky | svasheka: as it's marked as implemented for juno I think, so maybe we should not use it anymore, or reopen it, or... I don't know | 12:32 |
* tosky summons mrunge | 12:32 | |
svasheka | tosky, oh I see, some questions there ) | 12:33 |
mrunge | hmm? | 12:33 |
svasheka | mrunge, blueprint for integration tests marked implemented | 12:33 |
svasheka | mrunge, which is far from it ) | 12:33 |
mrunge | I can not make it not implemented | 12:34 |
*** drupalmonkey has joined #openstack-horizon | 12:34 | |
mrunge | that's some functionality missing in launchpad | 12:34 |
svasheka | mrunge, we should create another blueprint? | 12:34 |
*** packet has joined #openstack-horizon | 12:34 | |
mrunge | wait | 12:34 |
mrunge | ok seems to be in progress now | 12:35 |
david-lyle | tosky: blueprints should be smaller attainable pieces of work, all integration tests is not a useful blueprint | 12:35 |
*** JeanBriceCombebi has joined #openstack-horizon | 12:35 | |
david-lyle | break it up | 12:35 |
tosky | right | 12:35 |
svasheka | mrunge, david-lyle sure, thanks | 12:35 |
mrunge | changed it back to implemented | 12:35 |
svasheka | so close | 12:36 |
mrunge | svasheka, tosky mpavlase please add another bp for this | 12:36 |
tosky | david-lyle: it's something that came from the past; I only marginally contributed to the integration tests, so I didn't question what happened | 12:36 |
svasheka | it's all legacy :) | 12:36 |
*** akrivoka has quit IRC | 12:37 | |
svasheka | tosky, mpavlase btw I'm going on vacation so since monday I wouldn't be able to react on review comments for https://review.openstack.org/194646 jfyi | 12:37 |
DRoBeR | mrunge, sorry for not replying. I left for lunch ^^ Perhaps the info is currently worthless: Browser is Chrome; negative, no password saved. | 12:39 |
*** JeanBriceCombebi has quit IRC | 12:39 | |
mpavlase | svasheka: ok | 12:41 |
*** JeanBriceCombebi has joined #openstack-horizon | 12:41 | |
*** akrivoka has joined #openstack-horizon | 12:42 | |
*** jtriley has joined #openstack-horizon | 12:43 | |
david-lyle | tosky: no worries | 12:45 |
*** MaxV has joined #openstack-horizon | 12:45 | |
david-lyle | I'm just not a fan of tracking open ended tasks | 12:45 |
*** romainh has left #openstack-horizon | 12:48 | |
*** teju has joined #openstack-horizon | 12:48 | |
*** jtriley has quit IRC | 12:48 | |
*** EmilienM is now known as EmilienM|off | 12:50 | |
*** tosky has quit IRC | 12:51 | |
*** tosky has joined #openstack-horizon | 12:52 | |
*** aix has joined #openstack-horizon | 12:56 | |
r1chardj0n3s | 'night all! | 13:01 |
robcresswell | r1chardj0n3s: night! | 13:02 |
neillc | Night all | 13:03 |
robcresswell | neillc: \o | 13:03 |
*** rushiagr_away has quit IRC | 13:04 | |
*** petertr7_away is now known as petertr7 | 13:06 | |
*** ducttape_ has joined #openstack-horizon | 13:10 | |
*** doug-fish has quit IRC | 13:12 | |
*** ducttape_ has quit IRC | 13:13 | |
*** gerchardon has quit IRC | 13:13 | |
*** gerchardon has joined #openstack-horizon | 13:13 | |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 13:19 |
*** Ctina___ has joined #openstack-horizon | 13:19 | |
*** dscottsf has joined #openstack-horizon | 13:25 | |
*** doug-fish has joined #openstack-horizon | 13:27 | |
*** MaxV has quit IRC | 13:30 | |
*** jpomero has joined #openstack-horizon | 13:31 | |
openstackgerrit | Matthew D. Wood proposed openstack/horizon: Adding tests for button-tooltip.js https://review.openstack.org/178434 | 13:32 |
*** tvanderwiel has joined #openstack-horizon | 13:33 | |
*** e0ne is now known as e0ne_ | 13:33 | |
*** mou has joined #openstack-horizon | 13:34 | |
*** woodm1979 has joined #openstack-horizon | 13:34 | |
*** iamjarvo has joined #openstack-horizon | 13:34 | |
*** iamjarvo has quit IRC | 13:34 | |
woodm1979 | robcresswell: Did you ever have a chance to look at https://review.openstack.org/#/c/189481/ ? | 13:35 |
*** rushiagr_away has joined #openstack-horizon | 13:35 | |
*** teju has quit IRC | 13:35 | |
woodm1979 | I'm hoping to get Dave to look at it later today. | 13:35 |
*** masco has joined #openstack-horizon | 13:36 | |
*** kiranr has joined #openstack-horizon | 13:36 | |
*** e0ne_ is now known as e0ne | 13:37 | |
robcresswell | woodm1979: No, I'm a terrible person | 13:39 |
robcresswell | woodm1979: I will do that right now. | 13:40 |
*** jprovazn has joined #openstack-horizon | 13:40 | |
*** kiranr has quit IRC | 13:41 | |
woodm1979 | I wouldn't say terrible. Though I'd accept "less good looking than you woodm1979" | 13:42 |
*** jtriley has joined #openstack-horizon | 13:43 | |
*** MaxV has joined #openstack-horizon | 13:45 | |
robcresswell | woodm1979: Is there a patch to add a .gitreview to that repo, or can I push that quickly | 13:46 |
woodm1979 | There is a patch. You've given it a +2 but that's as far as it's gone. | 13:46 |
robcresswell | woodm1979: *sigh* | 13:46 |
woodm1979 | https://review.openstack.org/#/c/189483/ (Just in case someone is listening.) :-D | 13:47 |
robcresswell | mrunge: Can you approve https://review.openstack.org/#/c/189483 ? | 13:47 |
robcresswell | or david-lyle unless he went back to sleep like a sensible person | 13:47 |
robcresswell | woodm1979: Also needs a tox.ini, I believe, is there a patch for that too? | 13:49 |
robcresswell | If not I'll push one quickly... | 13:51 |
woodm1979 | There is not a patch for that. | 13:51 |
*** Raildo_ has joined #openstack-horizon | 13:52 | |
woodm1979 | I didn't know! STOP BLAMING ME ROB! | 13:52 |
woodm1979 | :-) | 13:52 |
openstackgerrit | Merged stackforge/xstatic-jasmine: Add a .gitreview file to this project https://review.openstack.org/189483 | 13:55 |
*** yamamoto has quit IRC | 13:55 | |
*** dscottsf has quit IRC | 13:55 | |
*** yamamoto has joined #openstack-horizon | 13:56 | |
robcresswell | woodm1979: Cool, works for me, +2 | 13:56 |
robcresswell | Thanks david-lyle you da best | 13:56 |
woodm1979 | robcresswell: I take back my "not better looking than me" comment from before. You're a beautiful human being. | 13:57 |
woodm1979 | OOooooh, I got some love from david-lyle too? It is a good morning! | 13:58 |
openstackgerrit | Rob Cresswell proposed stackforge/xstatic-jasmine: Add tox.ini to xstatic-jasmine https://review.openstack.org/195089 | 13:58 |
openstackgerrit | Merged stackforge/xstatic-jasmine: Add tox.ini to xstatic-jasmine https://review.openstack.org/195089 | 13:59 |
woodm1979 | david-lyle: You're drunk with power. | 13:59 |
robcresswell | baha, outright approval. | 13:59 |
openstackgerrit | Merged stackforge/xstatic-jasmine: Upgrade Jasmine to 2.2.0 https://review.openstack.org/189481 | 14:00 |
robcresswell | Progress everywhere | 14:00 |
woodm1979 | Oh good god! What's happening! | 14:00 |
openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 14:00 |
*** jasondot_ has joined #openstack-horizon | 14:00 | |
robcresswell | Quick, someone upload clippy again | 14:00 |
woodm1979 | LOL | 14:00 |
woodm1979 | I feel like we could slip in great stuff right now. Like putting the Mt. Dew logo on everything. | 14:01 |
*** vgridnev has quit IRC | 14:02 | |
*** vgridnev has joined #openstack-horizon | 14:02 | |
*** marzif has joined #openstack-horizon | 14:02 | |
svasheka | woodm1979, I'm totally behind this experiment | 14:03 |
woodm1979 | We could make a theme! | 14:03 |
woodm1979 | a Mt. Dew theme! | 14:03 |
*** dboik has joined #openstack-horizon | 14:03 | |
robcresswell | woodm1979: I'd rather the powerthirst logo: https://www.youtube.com/watch?v=qRuNxHqwazs | 14:03 |
*** absubram has joined #openstack-horizon | 14:03 | |
*** ducttape_ has joined #openstack-horizon | 14:03 | |
woodm1979 | http://wallpaperswide.com/mountain_dew_cans-wallpapers.html | 14:04 |
woodm1979 | I like it. | 14:04 |
woodm1979 | What was the drink from Silicon Valley? Murder Energy? | 14:05 |
woodm1979 | No! | 14:06 |
woodm1979 | http://drinkhomicide.com/ | 14:06 |
robcresswell | "Murder Energy" haha | 14:06 |
*** vgridnev has quit IRC | 14:06 | |
robcresswell | SWOT analysis of Blaine dying was so funny | 14:06 |
robcresswell | (spoilers?) | 14:07 |
woodm1979 | Was good stuff. | 14:07 |
*** logan2 has quit IRC | 14:08 | |
woodm1979 | david-lyle: Since you're obviously awake… How do we know when that xstatic package becomes available enough that we can depend upon it? Just check on pypi every day? :-) | 14:09 |
woodm1979 | Or is there a place we can sign-up for notifications? | 14:09 |
woodm1979 | Or better yet, make my gerrit review check for me! | 14:09 |
david-lyle | I have to tag it | 14:09 |
david-lyle | I can test the new tox patch | 14:10 |
*** julim has joined #openstack-horizon | 14:11 | |
*** iamjarvo has joined #openstack-horizon | 14:12 | |
*** julim has quit IRC | 14:16 | |
*** dboik_ has joined #openstack-horizon | 14:17 | |
*** jtriley has quit IRC | 14:19 | |
*** dboik has quit IRC | 14:20 | |
*** yamamoto has quit IRC | 14:24 | |
*** JeanBriceCombebi has quit IRC | 14:24 | |
*** Ctina___ has quit IRC | 14:27 | |
*** jtriley has joined #openstack-horizon | 14:29 | |
*** masco has quit IRC | 14:30 | |
*** logan2 has joined #openstack-horizon | 14:31 | |
*** stevemar has joined #openstack-horizon | 14:34 | |
openstackgerrit | Merged openstack/horizon: Add missing content-length header https://review.openstack.org/185403 | 14:35 |
*** tjones1 has joined #openstack-horizon | 14:38 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/195110 | 14:39 |
*** JeanBriceCombebi has joined #openstack-horizon | 14:40 | |
*** Piet has quit IRC | 14:42 | |
*** oro has quit IRC | 14:46 | |
*** jasondot_ has quit IRC | 14:47 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/tuskar-ui: Updated from global requirements https://review.openstack.org/195124 | 14:47 |
*** e0ne is now known as e0ne_ | 14:47 | |
*** absubram has quit IRC | 14:48 | |
*** e0ne_ is now known as e0ne | 14:48 | |
*** jasondotstar has joined #openstack-horizon | 14:54 | |
*** stevemar has quit IRC | 14:59 | |
*** nlahouti has joined #openstack-horizon | 14:59 | |
*** rwsu has joined #openstack-horizon | 15:04 | |
*** jbell8 has joined #openstack-horizon | 15:06 | |
*** logan2 has quit IRC | 15:07 | |
*** JeanBriceCombebi has quit IRC | 15:08 | |
*** jasondotstar has quit IRC | 15:08 | |
*** Piet has joined #openstack-horizon | 15:09 | |
*** hurgleburgler has joined #openstack-horizon | 15:09 | |
*** JeanBriceCombebi has joined #openstack-horizon | 15:10 | |
*** julim has joined #openstack-horizon | 15:12 | |
*** jasondotstar has joined #openstack-horizon | 15:12 | |
*** ttrifonov is now known as zz_ttrifonov | 15:14 | |
*** bpokorny has joined #openstack-horizon | 15:15 | |
*** julim has quit IRC | 15:16 | |
*** rwsu has quit IRC | 15:17 | |
*** julim has joined #openstack-horizon | 15:17 | |
*** rwsu has joined #openstack-horizon | 15:17 | |
*** Piet has quit IRC | 15:17 | |
*** hurgleburgler has quit IRC | 15:18 | |
*** hurgleburgler has joined #openstack-horizon | 15:18 | |
*** Piet has joined #openstack-horizon | 15:18 | |
*** Ctina___ has joined #openstack-horizon | 15:18 | |
*** logan2 has joined #openstack-horizon | 15:18 | |
*** Drago has joined #openstack-horizon | 15:19 | |
*** Drago has quit IRC | 15:20 | |
*** Drago has joined #openstack-horizon | 15:20 | |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 15:24 |
*** yamamoto has joined #openstack-horizon | 15:24 | |
*** tyr_ has joined #openstack-horizon | 15:28 | |
*** yamamoto has quit IRC | 15:30 | |
*** mou has quit IRC | 15:35 | |
*** mou has joined #openstack-horizon | 15:35 | |
*** jbell8 has quit IRC | 15:36 | |
*** logan2 has quit IRC | 15:39 | |
*** e0ne is now known as e0ne_ | 15:40 | |
*** e0ne_ is now known as e0ne | 15:45 | |
*** zul has quit IRC | 15:45 | |
*** zul has joined #openstack-horizon | 15:46 | |
*** petertr7 is now known as petertr7_away | 15:47 | |
*** alexvictorchan has joined #openstack-horizon | 15:50 | |
*** jasondotstar has quit IRC | 15:50 | |
*** jasondot_ has joined #openstack-horizon | 15:54 | |
*** jasondot_ has quit IRC | 15:55 | |
*** JeanBriceCombebi has quit IRC | 15:55 | |
*** Ephur has joined #openstack-horizon | 15:59 | |
*** iamjarvo has quit IRC | 16:04 | |
*** MaxV has quit IRC | 16:06 | |
*** aix has quit IRC | 16:06 | |
*** belmoreira has quit IRC | 16:12 | |
*** jwy has joined #openstack-horizon | 16:13 | |
*** jbell8 has joined #openstack-horizon | 16:13 | |
*** doug-fish has quit IRC | 16:14 | |
*** wznoinsk has quit IRC | 16:15 | |
*** ZZelle has joined #openstack-horizon | 16:21 | |
*** markus_z has quit IRC | 16:22 | |
*** garthb has joined #openstack-horizon | 16:22 | |
*** garthb_ has joined #openstack-horizon | 16:22 | |
*** Ala has quit IRC | 16:25 | |
*** jcoufal has quit IRC | 16:26 | |
*** clu_ has joined #openstack-horizon | 16:26 | |
*** tqtran has joined #openstack-horizon | 16:27 | |
*** rushiagr_away is now known as rushiagr | 16:38 | |
*** petertr7_away is now known as petertr7 | 16:39 | |
*** kzaitsev_mb has quit IRC | 16:48 | |
*** petertr7 is now known as petertr7_away | 16:49 | |
*** jtomasek has quit IRC | 16:49 | |
krotscheck | So, https://review.openstack.org/#/c/192327/ has been sitting up there for about a week now, after about a weeks worth of discussion. Given that there doesn't seem to be anyone who minds switching tools, can we move forward on landing it? | 16:49 |
*** iamjarvo has joined #openstack-horizon | 16:50 | |
*** Sukhdev has joined #openstack-horizon | 16:51 | |
krotscheck | david-lyle: ^^ Can I get your opinion on moving this forward? I'd be happy to contribute to outstanding jscs cleanup patches to get them rebased and fixed appropriately. | 16:51 |
*** tyr__ has joined #openstack-horizon | 16:51 | |
*** stevemar has joined #openstack-horizon | 16:51 | |
krotscheck | But I'm not going to do that until we're ready to land it. | 16:52 |
*** petertr7_away is now known as petertr7 | 16:52 | |
*** tyr_ has quit IRC | 16:52 | |
*** dontalton has joined #openstack-horizon | 16:52 | |
*** lsmola has quit IRC | 16:53 | |
*** henrynash has joined #openstack-horizon | 16:54 | |
*** gyee_ has joined #openstack-horizon | 16:55 | |
*** jasondot_ has joined #openstack-horizon | 16:56 | |
*** ygbo has quit IRC | 16:58 | |
*** dscottsf has joined #openstack-horizon | 17:01 | |
*** dscottsf_ has joined #openstack-horizon | 17:01 | |
openstackgerrit | Brian Tully proposed openstack/horizon: Hide Quota/Usage table actions for non Cloud-Admin https://review.openstack.org/187783 | 17:05 |
*** dscottsf has quit IRC | 17:05 | |
*** stevemar has quit IRC | 17:06 | |
*** stevemar has joined #openstack-horizon | 17:07 | |
*** jasondot_ has quit IRC | 17:07 | |
*** woodm1979 has quit IRC | 17:09 | |
*** julim_ has joined #openstack-horizon | 17:10 | |
*** julim has quit IRC | 17:10 | |
*** hurgleburgler1 has joined #openstack-horizon | 17:10 | |
*** hurgleburgler has quit IRC | 17:11 | |
openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/195110 | 17:11 |
*** iamjarvo has quit IRC | 17:11 | |
*** jasondot_ has joined #openstack-horizon | 17:12 | |
*** stevemar has quit IRC | 17:14 | |
*** yamamoto has joined #openstack-horizon | 17:14 | |
*** e0ne has quit IRC | 17:16 | |
*** oro has joined #openstack-horizon | 17:17 | |
*** iamjarvo has joined #openstack-horizon | 17:18 | |
*** yamamoto has quit IRC | 17:18 | |
*** sayan has quit IRC | 17:19 | |
*** Ctina___ has quit IRC | 17:21 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS cleanup - style guide cleanup for karma.config.js files https://review.openstack.org/194944 | 17:21 |
*** Ctina___ has joined #openstack-horizon | 17:22 | |
*** jingjing_ren has joined #openstack-horizon | 17:23 | |
*** jingjing_ren has quit IRC | 17:25 | |
*** jingjing_ren has joined #openstack-horizon | 17:26 | |
*** julim_ has quit IRC | 17:26 | |
*** jasondot_ has quit IRC | 17:26 | |
*** julim has joined #openstack-horizon | 17:27 | |
*** akrivoka has quit IRC | 17:27 | |
*** MaxV has joined #openstack-horizon | 17:28 | |
*** akrivoka has joined #openstack-horizon | 17:30 | |
*** bluex-pl has quit IRC | 17:31 | |
*** jasondot_ has joined #openstack-horizon | 17:31 | |
openstackgerrit | Jingjing Ren proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 17:32 |
*** ybathia has joined #openstack-horizon | 17:34 | |
*** lhcheng has joined #openstack-horizon | 17:37 | |
*** dguerri is now known as dguerri` | 17:37 | |
*** openstackgerrit has quit IRC | 17:38 | |
*** jasondot_ has quit IRC | 17:38 | |
*** openstackgerrit has joined #openstack-horizon | 17:38 | |
*** henrynash has quit IRC | 17:39 | |
*** hurgleburgler1 has quit IRC | 17:39 | |
*** hurgleburgler has joined #openstack-horizon | 17:39 | |
*** henrynash has joined #openstack-horizon | 17:41 | |
*** hurgleburgler1 has joined #openstack-horizon | 17:43 | |
*** hurgleburgler has quit IRC | 17:43 | |
*** jprovazn has quit IRC | 17:45 | |
*** mgarza_ has joined #openstack-horizon | 17:45 | |
*** mou has quit IRC | 17:47 | |
*** Raildo_ has quit IRC | 17:47 | |
*** stevemar has joined #openstack-horizon | 17:48 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 17:53 |
*** zul has quit IRC | 17:55 | |
*** amotoki has quit IRC | 17:55 | |
*** robcresswell has quit IRC | 17:57 | |
*** ybathia has quit IRC | 17:58 | |
*** ybathia has joined #openstack-horizon | 17:58 | |
*** sayan has joined #openstack-horizon | 17:59 | |
*** logan2 has joined #openstack-horizon | 18:00 | |
*** harlowja has quit IRC | 18:00 | |
*** e0ne has joined #openstack-horizon | 18:01 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for transfer-table https://review.openstack.org/191200 | 18:03 |
*** garthb_ has quit IRC | 18:03 | |
*** garthb has quit IRC | 18:03 | |
*** harlowja has joined #openstack-horizon | 18:04 | |
*** garthb_ has joined #openstack-horizon | 18:04 | |
*** garthb has joined #openstack-horizon | 18:04 | |
*** oro has quit IRC | 18:04 | |
*** woodm1979 has joined #openstack-horizon | 18:06 | |
*** e0ne has quit IRC | 18:08 | |
*** stevemar has quit IRC | 18:08 | |
*** stevemar has joined #openstack-horizon | 18:09 | |
*** stevemar has quit IRC | 18:10 | |
*** ericpeterson has joined #openstack-horizon | 18:10 | |
*** MaxV has quit IRC | 18:11 | |
*** stevemar has joined #openstack-horizon | 18:11 | |
*** ducttape_ has quit IRC | 18:13 | |
asahlin | lhcheng: Sorry was distracted yesterday and never got to looking at the XStatic Magic Serach packaging bug. Has there been any movement or thoughts on it? I see you added .tox.ini to all the xstatic projects, but am assuming that is not what caused the issue with the xstatic magic search tarball? | 18:15 |
lhcheng | asahlin: the issue was caused bu manually uploading xstatic tarball. | 18:17 |
lhcheng | adding the tox.ini will allow infra to enable a publish/tarball job on the magic search repo. | 18:18 |
*** annashen has joined #openstack-horizon | 18:18 | |
asahlin | lhcheng: ah ok. | 18:18 |
asahlin | lhcheng: so there is nothing wrong with code / structure of files that were uploaded to repo then. | 18:19 |
lhcheng | asahlin: yeah, the code in the repo is correct | 18:20 |
lhcheng | asahlin: it was just the uploaded package is wrong, instead of just uploading the dist tarball, the whole repo was tar and uploaded | 18:20 |
*** stevemar has quit IRC | 18:20 | |
*** jasondot_ has joined #openstack-horizon | 18:21 | |
asahlin | lhcheng: okay... One thing I did just notice is that the file permissions on stackforge/xstatic-magic-search are wrong ( most are executable). | 18:23 |
*** jwy has quit IRC | 18:23 | |
asahlin | lhcheng: Is that worth correcting? | 18:24 |
*** stevemar has joined #openstack-horizon | 18:25 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Create a Bootstrap Theme Preview Page with HTML Hints https://review.openstack.org/187818 | 18:27 |
*** hurgleburgler has joined #openstack-horizon | 18:30 | |
*** hurgleburgler1 has quit IRC | 18:30 | |
*** dguerri` is now known as dguerri | 18:30 | |
*** ybathia has quit IRC | 18:30 | |
*** tosky has quit IRC | 18:31 | |
*** dguerri is now known as dguerri` | 18:32 | |
*** jwy has joined #openstack-horizon | 18:33 | |
*** julim_ has joined #openstack-horizon | 18:34 | |
*** julim has quit IRC | 18:34 | |
lhcheng | asahlin: that wouldn't hurt, sure. | 18:36 |
*** garthb has quit IRC | 18:38 | |
*** garthb_ has quit IRC | 18:38 | |
*** garthb__ has joined #openstack-horizon | 18:38 | |
*** garthb has joined #openstack-horizon | 18:39 | |
*** julim_ has quit IRC | 18:41 | |
asahlin | alright I will throw a patch up for that... Should the bug (1451567) be linked to your patch where you added the tox.ini | 18:41 |
*** logan2 has quit IRC | 18:46 | |
*** absubram has joined #openstack-horizon | 18:49 | |
*** Sukhdev has quit IRC | 18:51 | |
*** stevemar has quit IRC | 18:54 | |
openstackgerrit | Aaron Sahlin proposed stackforge/xstatic-magic-search: Fix file permissions for XStatic Magic Search https://review.openstack.org/195266 | 18:55 |
openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - style guide cleanup for wizard https://review.openstack.org/189983 | 18:55 |
*** stevemar has joined #openstack-horizon | 18:55 | |
*** amotoki has joined #openstack-horizon | 18:56 | |
*** stevemar has quit IRC | 18:56 | |
*** julim has joined #openstack-horizon | 18:56 | |
*** stevemar has joined #openstack-horizon | 18:57 | |
openstackgerrit | Matthias Runge proposed openstack/horizon: Change widget attribute to string https://review.openstack.org/194642 | 18:57 |
*** bpokorny has quit IRC | 18:57 | |
*** amotoki has quit IRC | 19:01 | |
*** mrunge has quit IRC | 19:01 | |
*** yamamoto has joined #openstack-horizon | 19:03 | |
*** jasondot_ has quit IRC | 19:05 | |
*** yamamoto has quit IRC | 19:07 | |
*** Longgeek has quit IRC | 19:09 | |
*** stevemar has quit IRC | 19:09 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 19:09 |
*** stevemar has joined #openstack-horizon | 19:10 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 19:10 |
*** bpokorny has joined #openstack-horizon | 19:11 | |
tqtran | tyr__: can you get sqchen online? need to talk to him about scss and stuff | 19:11 |
tqtran | you're also welcome to join Tyr | 19:11 |
tyr__ | sure. | 19:12 |
tqtran | neillc: i'll take some time to test your translation patch as well, maybe even edit it if thats ok with you. | 19:12 |
tyr__ | tqtran: he's off-line here as well. Did you have any insights about the Django compressor errors on his auto-collect patch? | 19:13 |
tqtran | tyr__: i was testing it last night, tried changing the order of the installed_apps, didnt work | 19:13 |
tqtran | tyr__: right now, my priority is getting the dashboard stuff in, so auto-discovery will have to take a 2nd seat. but i do want to touch base on the scss stuff | 19:14 |
tqtran | since i want the plugin file-structure to work | 19:14 |
tqtran | thats what i wanted to talk about today | 19:14 |
*** harlowja has quit IRC | 19:15 | |
tyr__ | k. | 19:15 |
*** harlowja has joined #openstack-horizon | 19:15 | |
tqtran | https://review.openstack.org/#/c/192500/ | 19:16 |
*** mgarza_ has quit IRC | 19:17 | |
tqtran | so sean's patch is a bit outdate since we decided to move the scss file to /openstack_dashboards/dashboards/identity/static/..... | 19:17 |
tyr__ | yes | 19:18 |
tqtran | https://review.openstack.org/#/c/192500/4/openstack_dashboard/templates/_stylesheets.html L17 | 19:19 |
tyr__ | but basic idea is that each dashboard provides a SCSS file that pulls in all the SCSS below it | 19:19 |
*** annashen has quit IRC | 19:20 | |
tqtran | yes agree, that should work | 19:20 |
tqtran | but i don't want to muddle this patch with the auto-discovery part | 19:20 |
tqtran | i think they can be two separate patches | 19:20 |
tqtran | one for scss inclusion via plugin, and it can be follow by auto-discovery for ease of use | 19:20 |
*** stevemar has quit IRC | 19:22 | |
tyr__ | which patch is yours? | 19:22 |
*** petertr7 is now known as petertr7_away | 19:22 | |
*** nlahouti has quit IRC | 19:22 | |
*** stevemar has joined #openstack-horizon | 19:22 | |
tqtran | i dont have one up yet, thinking of doing it now | 19:23 |
tqtran | unless you want to do it? then i can help review :) | 19:23 |
*** mgarza_ has joined #openstack-horizon | 19:24 | |
tyr__ | I'm trying to sort out the Django compress error triggered by the auto-collection changes. If we can unblock that, re-org becomes a lot less painful | 19:24 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Allowing data sources to be edited https://review.openstack.org/195282 | 19:24 |
tqtran | ok thats fine, my agenda right now is to get the plugin thing sorted out and the translation moving along. i'll continue to keep an eye out for the auto-collection stuff but its currently not high priority for me. | 19:26 |
*** alexpilotti has quit IRC | 19:26 | |
tyr__ | I thought from the summit the auto-collection was a high priority? Is that true...or just wishful thinking? | 19:27 |
*** jtomasek has joined #openstack-horizon | 19:27 | |
tqtran | I spoke to david about it, we feel that getting the dashboard landed is higher priority. a lot of newer projects coming along need something to base off of | 19:27 |
*** petertr7_away is now known as petertr7 | 19:28 | |
tyr__ | ok. You are talking about identity dashboard? | 19:28 |
tqtran | the collection stuff is important for sure, but i think its secondary, its a bonus | 19:28 |
tqtran | yes | 19:28 |
tyr__ | kk | 19:28 |
*** dsneddon is now known as dsneddon_biab | 19:29 | |
tqtran | i will still help out with the effort, i do want it, but i want to prioritize getting the dashboard landed first | 19:29 |
tqtran | theres been a lot of noise lately, with the jscs stuff and reorg, and collection. time to get back on track, i dont want to look back and liberty and say all we did was move files around. | 19:29 |
tyr__ | yeah. makes sense | 19:30 |
*** jwy has quit IRC | 19:30 | |
*** jbell8 has quit IRC | 19:30 | |
*** garthb__ has quit IRC | 19:32 | |
*** garthb has quit IRC | 19:32 | |
*** stevemar has quit IRC | 19:32 | |
*** jbell8 has joined #openstack-horizon | 19:33 | |
*** Sukhdev has joined #openstack-horizon | 19:33 | |
*** stevemar has joined #openstack-horizon | 19:33 | |
*** e0ne has joined #openstack-horizon | 19:33 | |
tqtran | david-lyle: do you know if it is possible to add a static folder at the panel level? https://github.com/stackforge/monasca-ui/tree/master/monitoring/overview | 19:36 |
*** jasondotstar has joined #openstack-horizon | 19:36 | |
tqtran | and if it is, would it be /overview/static/overview/? or /overview/static/identity/overview/? | 19:37 |
*** dsneddon_biab is now known as dsneddon | 19:40 | |
*** zul has joined #openstack-horizon | 19:40 | |
*** dscottsf_ has quit IRC | 19:40 | |
*** dguerri` is now known as dguerri | 19:41 | |
*** hurgleburgler has quit IRC | 19:41 | |
*** hurgleburgler1 has joined #openstack-horizon | 19:41 | |
*** stevemar has quit IRC | 19:42 | |
*** akrivoka has quit IRC | 19:42 | |
*** stevemar has joined #openstack-horizon | 19:43 | |
*** bpokorny has quit IRC | 19:44 | |
*** zul has quit IRC | 19:44 | |
*** dguerri is now known as dguerri` | 19:44 | |
*** zul has joined #openstack-horizon | 19:45 | |
*** sayan has quit IRC | 19:52 | |
*** dguerri` is now known as dguerri | 19:52 | |
*** packet has quit IRC | 19:53 | |
openstackgerrit | Merged openstack/horizon: Add required to cidr field for 'Add Subnet' https://review.openstack.org/194904 | 19:54 |
*** amotoki has joined #openstack-horizon | 19:57 | |
*** bpokorny has joined #openstack-horizon | 19:59 | |
*** dguerri is now known as dguerri` | 19:59 | |
*** stevemar has quit IRC | 19:59 | |
*** stevemar has joined #openstack-horizon | 20:01 | |
*** amotoki has quit IRC | 20:01 | |
*** oro has joined #openstack-horizon | 20:05 | |
*** e0ne has quit IRC | 20:06 | |
*** annashen has joined #openstack-horizon | 20:09 | |
*** harlowja has quit IRC | 20:18 | |
*** garthb__ has joined #openstack-horizon | 20:18 | |
*** garthb has joined #openstack-horizon | 20:18 | |
*** harlowja has joined #openstack-horizon | 20:18 | |
*** oro has quit IRC | 20:19 | |
*** jtriley has quit IRC | 20:19 | |
*** iamjarvo has quit IRC | 20:22 | |
*** jtomasek has quit IRC | 20:22 | |
*** jtriley has joined #openstack-horizon | 20:23 | |
*** jasondotstar has quit IRC | 20:29 | |
*** julim has quit IRC | 20:30 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:31 | |
*** rushiagr is now known as rushiagr_away | 20:31 | |
*** robcresswell has joined #openstack-horizon | 20:32 | |
*** julim has joined #openstack-horizon | 20:35 | |
sjmc7 | david-lyle - is django-openstack-auth capable of authenticating a raw token like the service APIs do (take X-Auth-Token and interrogate keystone for the user info)? | 20:36 |
*** jasondotstar has joined #openstack-horizon | 20:36 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Provides a mechanism for adding scss for pluggable dashboards https://review.openstack.org/195297 | 20:37 |
sjmc7 | i've been asked to look into a weird use case that wouldn't fit with the horizon session auth | 20:37 |
*** nlahouti has joined #openstack-horizon | 20:37 | |
david-lyle | sjmc7: it requests tokens and puts them in the session | 20:37 |
*** kzaitsev_mb has quit IRC | 20:37 | |
david-lyle | then based on roles, user can find out user info, if allowed | 20:37 |
tqtran | tyr__, david-lyle: please take a look and leave comments. patch allows adding of custom scss at the app level. | 20:38 |
sjmc7 | but it requires username/password to do that? | 20:38 |
tqtran | tyr__: let me know when sean is available, lets touch base again | 20:38 |
david-lyle | sjmc7: initially yes, stores token and rescopes the token as necessary | 20:38 |
sjmc7 | ok, thanks | 20:39 |
*** stevemar has quit IRC | 20:39 | |
david-lyle | although federated identity is supported | 20:39 |
*** julim has quit IRC | 20:39 | |
*** stevemar2 has joined #openstack-horizon | 20:39 | |
*** julim has joined #openstack-horizon | 20:41 | |
*** julim has quit IRC | 20:41 | |
*** stevemar2 has quit IRC | 20:43 | |
david-lyle | tqtran: what's the relation to https://review.openstack.org/#/c/192500/ | 20:43 |
david-lyle | ? | 20:43 |
tqtran | https://review.openstack.org/#/c/192500/4/openstack_dashboard/templates/_stylesheets.html | 20:43 |
*** stevemar2 has joined #openstack-horizon | 20:44 | |
david-lyle | seems like the same base concept although the one I linked is unnecessarily noisy | 20:44 |
*** julim has joined #openstack-horizon | 20:44 | |
tqtran | yeah pretty much | 20:44 |
tqtran | i pulled out the core part of it | 20:44 |
tqtran | sean has autodiscovery in his | 20:45 |
tqtran | and a refactor of the dashboard.scss | 20:45 |
tqtran | the refactor part i want to leave for a later patch | 20:45 |
krotscheck | So, given that there doesn'ts eem to be any disagreement on switching to eslint, what process do I have to follow to get https://review.openstack.org/#/c/192327/ to land? | 20:45 |
krotscheck | Because it's just sitting there and nobody's looking at it. | 20:45 |
david-lyle | tqtran: and a gratuitous rename, just because | 20:46 |
david-lyle | :( | 20:46 |
tqtran | haha :P that was part of Tyr's effort to move common api stuff into core, but yeah, totally unrelated | 20:47 |
*** sqchen has joined #openstack-horizon | 20:48 | |
tqtran | i'll create a bp for this one | 20:48 |
sqchen | Hi tqthai and tyr__ | 20:49 |
*** ybathia has joined #openstack-horizon | 20:49 | |
david-lyle | tqthai, I like that | 20:50 |
*** woodm1979 has quit IRC | 20:50 | |
sqchen | hi tqtran: | 20:50 |
tqtran | tyr__: can you provide the link to hp's hangout? | 20:50 |
tqtran | lets hop now and have a chat to touch base | 20:51 |
tyr__ | sure | 20:51 |
tyr__ | https://plus.google.com/hangouts/_/hp.com/ngScss-99f59236-9e7 | 20:51 |
tqtran | david-lyle: you're welcome to join if you have time | 20:52 |
tqtran | clu_: ping ping you too | 20:52 |
clu_ | hi tqtran | 20:52 |
tqtran | hop on :) | 20:52 |
*** julim has quit IRC | 20:53 | |
*** jasondotstar has quit IRC | 20:54 | |
*** ZZelle has quit IRC | 20:54 | |
*** pcarver has joined #openstack-horizon | 20:55 | |
pcarver | Anybody know if there's an issue with the Network Topology screen in Horizon in Devstack currently? On a fresh | 20:55 |
pcarver | install of Ubuntu 14.04.2 I did a fresh clone of Devstack with n-net disabled and the q- services enabled. When I | 20:55 |
pcarver | access the Network Topology screen as a non-admin user (e.g. demo or a new user/project that I create) I get an HTTP | 20:55 |
pcarver | 403 with "Policy doesn't allow compute:get_all_tenants to be performed" | 20:55 |
pcarver | This is actually a permission in Nova's policy.json which is restricted to admin only, but I don't understand why a Nova policy default would completely prevent a non-admin user to see their own Neutron topology. | 20:55 |
*** belmoreira has joined #openstack-horizon | 20:58 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:58 | |
*** ZZelle has joined #openstack-horizon | 21:01 | |
*** garthb_ has joined #openstack-horizon | 21:02 | |
*** garthb__ has quit IRC | 21:02 | |
*** garthb has quit IRC | 21:02 | |
*** tjones2 has joined #openstack-horizon | 21:03 | |
*** garthb has joined #openstack-horizon | 21:03 | |
*** garthb_ has quit IRC | 21:03 | |
*** SimonChung has joined #openstack-horizon | 21:03 | |
*** garthb_ has joined #openstack-horizon | 21:03 | |
*** julim has joined #openstack-horizon | 21:03 | |
*** SimonChung has quit IRC | 21:04 | |
*** ybathia has quit IRC | 21:05 | |
*** SimonChung has joined #openstack-horizon | 21:05 | |
*** ybathia has joined #openstack-horizon | 21:05 | |
*** SimonChung1 has joined #openstack-horizon | 21:06 | |
*** SimonChung has quit IRC | 21:06 | |
david-lyle | pcarver: seeing the same author | 21:06 |
david-lyle | same issue | 21:06 |
david-lyle | not good, will fix | 21:06 |
pcarver | david-lyle: glad I'm not crazy. Looks like Horizon is making a quota call but I don't know if it's supposed to. | 21:07 |
pcarver | This is what I see in the horizon screen immediately after clicking the network topology tab https://gist.github.com/pcarver/e838e807265b920dab61 | 21:08 |
*** Longgeek has joined #openstack-horizon | 21:09 | |
pcarver | There's a GET for os-quota-sets and then a GET for servers/detail?all_tenants | 21:09 |
*** SimonChung has joined #openstack-horizon | 21:09 | |
*** SimonChung1 has quit IRC | 21:09 | |
*** SimonChung1 has joined #openstack-horizon | 21:10 | |
*** SimonChung has quit IRC | 21:10 | |
*** petertr7 is now known as petertr7_away | 21:10 | |
pcarver | This bug might be related although the info in the bug doesn't say anything about network topology: https://bugs.launchpad.net/horizon/+bug/1413426 | 21:11 |
openstack | Launchpad bug 1413426 in OpenStack Dashboard (Horizon) "Forbidden: Policy doesn't allow compute:get_all_tenants to be performed. (HTTP 403)" [Undecided,New] | 21:11 |
*** SimonChung has joined #openstack-horizon | 21:11 | |
*** SimonChung1 has quit IRC | 21:11 | |
david-lyle | pcarver: looking into now | 21:11 |
pcarver | david-lyle: thanks. I'll be quiet now. | 21:12 |
david-lyle | pcarver: thanks for raising the issue, I hadn't seen it until you brought it up | 21:12 |
*** stevemar2 has quit IRC | 21:12 | |
*** Longgeek has quit IRC | 21:15 | |
*** vishwana_ has quit IRC | 21:17 | |
*** vishwanathj has joined #openstack-horizon | 21:18 | |
*** sqchen has left #openstack-horizon | 21:20 | |
r1chardj0n3s | morning | 21:20 |
david-lyle | pcarver: https://github.com/openstack/nova/commit/55e63f83a7caec5a8d85b7532c501e1b846295ba changed | 21:21 |
krotscheck | Attempt #3: Can any of the cores give me pointers as to the next step on how to get https://review.openstack.org/#/c/192327/ landed? | 21:22 |
david-lyle | so the default policy clamped down | 21:22 |
krotscheck | Shoudl I wait for the other JSCS patches to land? Should I check with those people to rebase their work on mine? Should I just abandon it and wait for all JSCS things to settle out before I try again? | 21:23 |
krotscheck | Something other than silence would be lovely. | 21:23 |
*** morganfainberg is now known as ayspryn | 21:24 | |
*** ayspryn is now known as morganfainberg | 21:24 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Provides a mechanism for adding scss for pluggable dashboards https://review.openstack.org/195297 | 21:27 |
*** dboik_ has quit IRC | 21:27 | |
tqtran | clu_: do you know where the doc for plugin is stored? | 21:28 |
pcarver | david-lyle: well that policy restriction makes sense, but the question is why it's necessary for a query against all tenants for a non-admin tenant to see their own network topology | 21:28 |
r1chardj0n3s | tqtran: isn't that stuff all in the contributing doc? | 21:28 |
clu_ | tqtran: the pluggable settings stuff? | 21:28 |
tqtran | yes | 21:28 |
openstackgerrit | Lin Hua Cheng proposed stackforge/xstatic-magic-search: Add tox.ini to enable publish/tarball job https://review.openstack.org/194803 | 21:28 |
*** jasondotstar has joined #openstack-horizon | 21:29 | |
*** ybathia has quit IRC | 21:29 | |
tqtran | ok found it | 21:30 |
tqtran | its in settings.rst | 21:30 |
*** alexpilotti has joined #openstack-horizon | 21:30 | |
clu_ | tqtran: yea, https://github.com/openstack/horizon/blob/master/doc/source/topics/settings.rst | 21:30 |
*** garthb_ has quit IRC | 21:30 | |
*** garthb has quit IRC | 21:30 | |
*** garthb_ has joined #openstack-horizon | 21:31 | |
*** garthb has joined #openstack-horizon | 21:31 | |
*** Ctina___ is now known as Ctina | 21:32 | |
*** Sukhdev has quit IRC | 21:33 | |
david-lyle | pcarver: I agree, non-admin shouldn't be requesting all_tenants | 21:35 |
david-lyle | krotscheck: I have other hotter fires at the moment, but will take a look when I have a chance. There are other cores much more excited about the jscs/eslint effort that you may want to ping. | 21:37 |
pcarver | david-lyle: Should I open a bug? | 21:38 |
krotscheck | david-lyle: It's somewhat difficult to make a tooling change without the PTL's buy-in. | 21:38 |
*** garthb_ has quit IRC | 21:38 | |
*** sqchen has joined #openstack-horizon | 21:38 | |
krotscheck | But I'll annoy tqtran and others | 21:38 |
*** garthb has quit IRC | 21:38 | |
david-lyle | krotscheck: you would be surprised how easy it is :( | 21:38 |
krotscheck | david-lyle: Let me amend that. I want to make sure that people I like buy in to what I'm trying to do :) | 21:39 |
*** alexpilotti has quit IRC | 21:40 | |
david-lyle | krotscheck: I have no problem with the effort, I just don't have time to review the patch in depth at the moment | 21:40 |
* krotscheck bites back the inevitable followup comparison joke to r1chardj0n3s :) | 21:40 | |
david-lyle | I think overall it makes sense to have a unified set of tools for JS work in OpenStack | 21:40 |
openstackgerrit | Thai Tran proposed openstack/horizon: Provides a mechanism for adding scss for pluggable dashboards https://review.openstack.org/195297 | 21:40 |
r1chardj0n3s | krotscheck ;) | 21:41 |
*** alexpilotti has joined #openstack-horizon | 21:42 | |
*** jbell8 has quit IRC | 21:42 | |
*** ybathia has joined #openstack-horizon | 21:42 | |
krotscheck | tqtran: Review for ya :) https://review.openstack.org/#/c/192327/ | 21:42 |
*** dguerri` is now known as dguerri | 21:44 | |
tqtran | krotscheck: :) ok, i'll get around to it, added to my Q | 21:44 |
krotscheck | robcresswell: Review for ya :) https://review.openstack.org/#/c/192327/ | 21:45 |
david-lyle | krotscheck: eslint is only runnable via tox then? | 21:45 |
krotscheck | david-lyle: not tox. npm. | 21:46 |
david-lyle | and only npm | 21:46 |
krotscheck | Yep. Need an addon to tox? | 21:46 |
david-lyle | that's just what the jscs job was doing to allow running from run_tests.sh | 21:47 |
david-lyle | which is the unified testing tool in horizon | 21:47 |
*** garthb_ has joined #openstack-horizon | 21:47 | |
*** garthb has joined #openstack-horizon | 21:47 | |
krotscheck | Didn't you tell me that run_tests is deprecated? | 21:47 |
david-lyle | oh no, not me | 21:48 |
*** julim has quit IRC | 21:48 | |
* david-lyle thinks that sounded sarcastic, wasn't | 21:48 | |
krotscheck | Hrm. Someone did. Something about horizon's one of the few that still uses it... | 21:49 |
* krotscheck 's memory may be spotty | 21:49 | |
*** julim has joined #openstack-horizon | 21:49 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 21:49 |
openstackgerrit | Thai Tran proposed openstack/horizon: Provides a mechanism for adding scss for pluggable dashboards https://review.openstack.org/195297 | 21:49 |
*** tvanderwiel has quit IRC | 21:50 | |
krotscheck | david-lyle: I can add the commandline call easily enough, I just didn't include it because of that dirty rumor. | 21:50 |
david-lyle | horizon is one of the few for sure, but I'm not interested in removing it at this point | 21:51 |
david-lyle | ties into a lot of different tool chains | 21:51 |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Identity Dashboard https://review.openstack.org/190852 | 21:53 |
*** annashen has quit IRC | 21:54 | |
* david-lyle is not entirely aware of coups in the making | 21:55 | |
*** jtriley has quit IRC | 21:56 | |
* krotscheck shrugs. | 21:57 | |
*** dguerri is now known as dguerri` | 21:58 | |
*** amotoki has joined #openstack-horizon | 21:58 | |
david-lyle | down with run_tests.sh | 21:59 |
david-lyle | :P | 22:00 |
*** dboik has joined #openstack-horizon | 22:01 | |
openstackgerrit | Michael Krotscheck proposed openstack/horizon: Switched from JSCS to ESLint https://review.openstack.org/192327 | 22:01 |
tqtran | sqchen: just replied to your question, we still need the hz.dashboard | 22:01 |
sqchen | ok | 22:02 |
krotscheck | david-lyle: ^^ There ya go. | 22:02 |
*** Piet has quit IRC | 22:02 | |
*** Ctina has quit IRC | 22:03 | |
*** amotoki has quit IRC | 22:04 | |
david-lyle | krotscheck: one last piece of ignorance on my part, with npm run lint, I don't need to specify the paths because they are in package.json? | 22:04 |
*** garthb_ has quit IRC | 22:04 | |
*** garthb has quit IRC | 22:04 | |
*** garthb_ has joined #openstack-horizon | 22:04 | |
*** garthb__ has joined #openstack-horizon | 22:04 | |
*** annashen has joined #openstack-horizon | 22:05 | |
*** julim has quit IRC | 22:07 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 22:08 |
*** jasondotstar has quit IRC | 22:09 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular Users Panel https://review.openstack.org/190865 | 22:09 |
*** Longgeek has joined #openstack-horizon | 22:11 | |
*** Longgeek has quit IRC | 22:16 | |
*** henrynash has quit IRC | 22:18 | |
sqchen | Hi tqtran, do you mind I add some simple scss code into https://review.openstack.org/#/c/190852/ to make it easier for people to start more code there? | 22:18 |
*** ericpeterson has quit IRC | 22:19 | |
*** belmoreira has quit IRC | 22:19 | |
r1chardj0n3s | sqchen: any movement on that gate issue overnight? I'll make it a priority today if not. | 22:19 |
*** alexpilotti has quit IRC | 22:19 | |
tqtran | sqchen: what do you have in mind? i prefer not to complicate it | 22:19 |
sqchen | r1chardj0n3s pls. :) | 22:20 |
r1chardj0n3s | ok :) | 22:20 |
sqchen | tqtran: I’ll add this lines to it: | 22:20 |
sqchen | / Custom Theme Variables | 22:20 |
sqchen | @import "/custom/variables"; | 22:20 |
sqchen | @import "scss/variables"; | 22:20 |
sqchen | / @import ...; | 22:20 |
sqchen | / Custom Style Variables | 22:21 |
sqchen | @import "/custom/styles"; | 22:21 |
sqchen | Oops, how could I post code here. | 22:21 |
david-lyle | paste.openstack.org | 22:21 |
sqchen | tqtran, I’ll add them in, and you can remove it if you don’t like. | 22:22 |
tqtran | ok so you're going to remove dashboard.scss so thats why we need it? | 22:22 |
tqtran | wait sqchen .... | 22:22 |
tqtran | dont add them | 22:22 |
*** mpavlase has quit IRC | 22:22 | |
sqchen | ok. | 22:23 |
*** Sukhdev has joined #openstack-horizon | 22:23 | |
tqtran | are those common scss? | 22:23 |
*** annashen has quit IRC | 22:23 | |
sqchen | yes. | 22:23 |
tqtran | why not have the dashboard.scss and then follow by plugabble scss? | 22:23 |
sqchen | for variables ony | 22:23 |
tqtran | otherwise, all pluggable scss have to include them | 22:24 |
hurgleburgler1 | "/custom/styles" aren't variables … | 22:24 |
*** kzaitsev_mb has quit IRC | 22:24 | |
sqchen | now, since each dashboard has a root scss file, it should be wrapped with scss variable files. | 22:25 |
sqchen | Take a look in the dashboard.scss, you will understand I am talking about. | 22:26 |
tqtran | https://github.com/openstack/horizon/tree/master/openstack_dashboard/static/dashboard/scss | 22:26 |
tqtran | i dont even see custom folder? is that something you have to add if you want to theme? | 22:26 |
openstackgerrit | Jingjing Ren proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 22:26 |
hurgleburgler1 | custom is added as a static directory | 22:26 |
tqtran | ok, so when im themeing something, i add this custom static dir at the dashboard level? or the horizon level? | 22:27 |
hurgleburgler1 | STATICFILES_DIRS.append( | 22:27 |
hurgleburgler1 | ('custom', CUSTOM_THEME), | 22:27 |
hurgleburgler1 | ) | 22:27 |
hurgleburgler1 | wherever you set your CUSTOM_THEME path, but its root is openstack_dashboard | 22:28 |
*** jtriley has joined #openstack-horizon | 22:28 | |
*** annashen has joined #openstack-horizon | 22:28 | |
sqchen | What I am going to do is just copy all the code in dashboard.scss into identity.scss withou @import “launch-instance”; | 22:28 |
*** belmoreira has joined #openstack-horizon | 22:29 | |
sqchen | But if you are worried about it, I won’t do it, since the identity.scss is empty now. | 22:30 |
r1chardj0n3s | tqtran, sqchen This discussion sounds like the sort of thing that belongs in the (... terse) bp https://blueprints.launchpad.net/horizon/+spec/pluggable-scss | 22:30 |
tqtran | sqchen: hold your horses lol, let me understand the situation a bit better | 22:32 |
sqchen | sure. :) | 22:33 |
sqchen | here is an example https://review.openstack.org/#/c/192500/4/openstack_dashboard/static/dashboards/admin/admin.scss | 22:34 |
tqtran | so sean, my question is as follows. | 22:35 |
tqtran | does each dashboard have to include these/ | 22:35 |
tqtran | ? | 22:35 |
*** belmoreira has quit IRC | 22:35 | |
tqtran | if so, why not have a dashboard.scss that includes it by default? | 22:36 |
tqtran | so that each subsequent dashboard doesnt have to | 22:36 |
*** alexvictorchan has quit IRC | 22:36 | |
sqchen | yes, each scss that go to the stylesheet.html directly should has similar structure. | 22:38 |
sqchen | those are pure scss variables, not going generate any css code. | 22:38 |
tqtran | hurgleburgler1, sqchen: ok let me take a step back and see if i understand this correctly. you guys are saying, 1. you can include a custom folder 2. you can theme at the dashboard level. am i correct in making this assumption? | 22:39 |
sqchen | every @imported scss file can automatically use them. | 22:39 |
*** yamamoto has joined #openstack-horizon | 22:40 | |
*** dsneddon has quit IRC | 22:40 | |
*** ZZelle has quit IRC | 22:40 | |
tqtran | or are you guys saying 1. you can include a custom folder at the root level. 2. theming only applies to the application, not dashboard | 22:41 |
sqchen | now, indentity.scss is not part of dashboard.scss, code in identity.scss has no idea of variables, if code in identity want to use variables, you have to import them in. | 22:41 |
tqtran | or 3. are we talking pass each other and no one is understanding anyone else? lol | 22:41 |
*** tjones2 has quit IRC | 22:42 | |
*** annashen has quit IRC | 22:42 | |
*** dsneddon has joined #openstack-horizon | 22:42 | |
sqchen | yes, they don’t understand each other, they compete, actually, in the css way. :) | 22:42 |
tqtran | sqchen: ok, i think i understand what you're saying. let create a different patch for it then, i have a feeling that the @import "/dashboard/scss/variables" might not play nice. | 22:43 |
hurgleburgler1 | Cascade All the things! | 22:43 |
hurgleburgler1 | hehehehe | 22:43 |
*** Piet has joined #openstack-horizon | 22:43 | |
sqchen | ok, as I said I don’t have to do that, since it is empty now. | 22:44 |
tqtran | david-lyle, clu_: https://review.openstack.org/#/c/195297/ is ready for your blessing. | 22:44 |
tqtran | yeah, lets keep it empty for now, i can add it later when i start to use it. | 22:45 |
*** yamamoto has quit IRC | 22:45 | |
david-lyle | dare I say test? | 22:45 |
tqtran | hm... test... what is that? | 22:45 |
*** garthb_ has quit IRC | 22:46 | |
*** garthb__ has quit IRC | 22:46 | |
david-lyle | I think the change looks good, I'm worried about with so many chefs trying to reinvent horizon, that it will get broken soon | 22:46 |
*** dboik has quit IRC | 22:46 | |
david-lyle | the test is to protect against that | 22:46 |
*** tjones1 has quit IRC | 22:47 | |
david-lyle | something in panel loading | 22:47 |
tqtran | yeah looking into it atm | 22:47 |
david-lyle | https://github.com/openstack/horizon/tree/master/openstack_dashboard/test/test_plugins | 22:47 |
david-lyle | somewhere around there | 22:47 |
*** garthb__ has joined #openstack-horizon | 22:50 | |
*** garthb_ has joined #openstack-horizon | 22:50 | |
tqtran | david-lyle: lol sadly it doesnt look like the test for plugin is that comprehensive | 22:53 |
*** belmoreira has joined #openstack-horizon | 22:53 | |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_plugins/panel_tests.py#L44 | 22:53 |
tqtran | doesnt check that the JS injections are all there | 22:54 |
r1chardj0n3s | tqtran: please file a bug, I can look into that :) | 22:54 |
tqtran | r1chardj0n3s: blah, held back by yet another thing >< | 22:55 |
tqtran | um let me take a closer look, then if thats the case, i'll file a bug and assign to you | 22:55 |
r1chardj0n3s | yep, thanks | 22:55 |
*** mgarza_ has quit IRC | 22:57 | |
*** Drago has quit IRC | 22:59 | |
*** amotoki has joined #openstack-horizon | 22:59 | |
*** amotoki has quit IRC | 23:04 | |
tqtran | r1chardj0n3s: https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_plugins/panel_tests.py#L44 | 23:04 |
*** jtriley has quit IRC | 23:04 | |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_plugins/panel_config/_10_admin_add_panel.py#L16 | 23:04 |
tqtran | looks like the tests doesn't look for JS injection, i'll file a bug and assign you to it | 23:04 |
*** alexvictorchan has joined #openstack-horizon | 23:05 | |
*** Ephur has quit IRC | 23:06 | |
tqtran | https://bugs.launchpad.net/horizon/+bug/1468547 | 23:07 |
openstack | Launchpad bug 1468547 in OpenStack Dashboard (Horizon) "Plugin test should check js injections" [High,New] - Assigned to Richard Jones (r1chardj0n3s) | 23:07 |
tqtran | r1chardj0n3s: could you prioritize this? once you're done, i can add tests to this patch https://review.openstack.org/#/c/195297/ | 23:08 |
tqtran | and get it moving happily along | 23:08 |
tqtran | neillc: i tested out your angular translate patch, doesn't look it works! | 23:09 |
*** belmoreira has quit IRC | 23:15 | |
tqtran | jk, it works, i didnt use the right directive | 23:15 |
*** darrenc is now known as darrenc_afk | 23:16 | |
r1chardj0n3s | tqtran: you want me to fix the tech debt before you add a test to your already in flight patch?! | 23:17 |
*** chlong has joined #openstack-horizon | 23:18 | |
*** jtriley has joined #openstack-horizon | 23:18 | |
r1chardj0n3s | my priority for today is to solve the gate issue that sqchen has run into with his js-auto-find | 23:18 |
tqtran | r1chardj0n3s: can you re-prioritize? :) i'd like to land the dashboard stuff asap | 23:19 |
sqchen | Thx a lot to put it as your priority.! | 23:19 |
tqtran | the auto-discovery stuff can come as a bonus, i'll also help after the dashboard lands | 23:19 |
sqchen | what you need for dashboard, tqtran? | 23:19 |
tqtran | david wants to see test for the add_scss_files before he is comfortable pushing it through | 23:19 |
tqtran | i could just hack something up quickly as well, up to you | 23:20 |
tqtran | or if we want to do it the proper way, we should also check for other js_files, js_spec_files, etc..... | 23:20 |
r1chardj0n3s | I don't think your patch should do all that as well. scope creep | 23:21 |
tqtran | well, its introducing a ADD_SCSS_FILES, make sense to have test for it. | 23:22 |
tqtran | could be attach as a follow on patch as well, but david-lyle wants to see it | 23:23 |
r1chardj0n3s | yes, you should test for that | 23:23 |
tqtran | right, which is why i need your patch to land first :) | 23:23 |
r1chardj0n3s | no, you're adding functionality you should test it works :) | 23:23 |
*** darrenc_afk is now known as darrenc | 23:23 | |
tqtran | in the mean time, im running tests on neill's makemessages patch | 23:24 |
tqtran | i think if it passes, then i just need to look into interpolate and everything will be set to push the remaining dashboard things through | 23:24 |
*** bradjones has quit IRC | 23:26 | |
*** bradjones has joined #openstack-horizon | 23:26 | |
*** bradjones has quit IRC | 23:26 | |
*** bradjones has joined #openstack-horizon | 23:26 | |
*** garthb has joined #openstack-horizon | 23:34 | |
neillc | tqtran: Not funny! :P | 23:34 |
tqtran | neillc: just left a comment on your patch | 23:34 |
tqtran | few small things to adjust and you're gtg | 23:35 |
neillc | cool. I shall go fixy fixy | 23:36 |
*** garthb__ has quit IRC | 23:36 | |
*** garthb_ has quit IRC | 23:36 | |
*** garthb_ has joined #openstack-horizon | 23:37 | |
*** Sukhdev has quit IRC | 23:40 | |
tqtran | running integration tests on your patch, gonna figure out why its failing on openstack_dashboard.test.integration_tests.tests.test_flavors.TestFlavors.test_flavor_create | 23:41 |
*** jtriley has quit IRC | 23:46 | |
*** dboik has joined #openstack-horizon | 23:47 | |
*** jingjing_ren has quit IRC | 23:51 | |
*** jtriley has joined #openstack-horizon | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!