| tqtran | krotscheck: one last request, commented on patch :P | 00:03 |
|---|---|---|
| krotscheck | tqtran: Is that also an angular component? | 00:04 |
| tqtran | yup, recently written | 00:04 |
| krotscheck | tqtran: Dude, you could have added that comment to your first review :-P | 00:04 |
| tqtran | lol well, i thought that you could disable plugins at subdir level | 00:04 |
| tqtran | but apparently you cant, so i didnt mention it | 00:04 |
| *** mayurig has quit IRC | 00:05 | |
| *** nzeplowi has quit IRC | 00:05 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Add selective ESLint rule activation for Horizon Legacy JS https://review.openstack.org/195799 | 00:06 |
| krotscheck | There ya go. | 00:06 |
| tqtran | perfect! I'll +2 as soon as it passes gate | 00:06 |
| *** nzeplowi has joined #openstack-horizon | 00:08 | |
| *** nzeplowi has quit IRC | 00:09 | |
| *** pamo has quit IRC | 00:13 | |
| *** Piet has joined #openstack-horizon | 00:14 | |
| *** darrenc is now known as darrenc_afk | 00:14 | |
| *** jingjing_ren has quit IRC | 00:18 | |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: fix a couple lint errors in filters.js https://review.openstack.org/199789 | 00:21 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Remove hz dashboard module from enabled https://review.openstack.org/199791 | 00:24 |
| *** yingjun has joined #openstack-horizon | 00:24 | |
| *** darrenc_afk is now known as darrenc | 00:26 | |
| *** jamielennox is now known as jamielennox|away | 00:29 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 00:34 |
| *** jamielennox|away is now known as jamielennox | 00:39 | |
| deuce | @krotscheck: I have a question about the eslint rule changes. | 00:39 |
| deuce | since there are so few violations in horizon/static/auth/, would it be worthwhile just to fix them? I'd be willing to do it | 00:39 |
| *** skylerberg has quit IRC | 00:45 | |
| *** dsneddon is now known as dsneddon_away | 00:45 | |
| *** mwhagedorn has joined #openstack-horizon | 00:48 | |
| *** jingjing_ren has joined #openstack-horizon | 00:49 | |
| *** garthb has quit IRC | 00:49 | |
| *** Piet has quit IRC | 00:51 | |
| *** nzeplowi has joined #openstack-horizon | 00:51 | |
| *** jingjing_ren has quit IRC | 00:53 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding Angular-gettext to requirements https://review.openstack.org/197244 | 00:56 |
| *** Piet has joined #openstack-horizon | 00:57 | |
| *** nzeplowi has quit IRC | 00:57 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 00:57 |
| *** tqtran has quit IRC | 00:59 | |
| *** piyanai has joined #openstack-horizon | 01:00 | |
| *** nlahouti has quit IRC | 01:00 | |
| *** btully has quit IRC | 01:10 | |
| *** amotoki has joined #openstack-horizon | 01:10 | |
| *** davidmichaelkarr has quit IRC | 01:17 | |
| *** yingjun has quit IRC | 01:19 | |
| *** yingjun has joined #openstack-horizon | 01:19 | |
| *** tjones1 has quit IRC | 01:27 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: WIP: Multidomain false and project admin support https://review.openstack.org/199251 | 01:28 |
| *** dguerri` is now known as dguerri | 01:29 | |
| *** saksham_ has quit IRC | 01:33 | |
| *** jasondotstar has joined #openstack-horizon | 01:35 | |
| *** deuce has quit IRC | 01:39 | |
| *** bitblt has quit IRC | 01:45 | |
| *** ybathia has quit IRC | 01:47 | |
| *** davidmichaelkarr has joined #openstack-horizon | 01:48 | |
| *** Sukhdev has quit IRC | 01:48 | |
| *** TravT has joined #openstack-horizon | 01:51 | |
| *** TravT is now known as TravT_away | 01:51 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: WIP: Multidomain false and project admin support https://review.openstack.org/199251 | 01:56 |
| *** sqchen has quit IRC | 01:57 | |
| *** jwy has quit IRC | 02:06 | |
| *** mwhagedorn has quit IRC | 02:07 | |
| *** Sukhdev has joined #openstack-horizon | 02:11 | |
| *** dguerri is now known as dguerri` | 02:17 | |
| *** Sukhdev has quit IRC | 02:20 | |
| *** dguerri` is now known as dguerri | 02:22 | |
| *** dguerri is now known as dguerri` | 02:25 | |
| *** annashen has joined #openstack-horizon | 02:26 | |
| *** gyee has quit IRC | 02:28 | |
| *** dguerri` is now known as dguerri | 02:30 | |
| *** yamamoto has joined #openstack-horizon | 02:32 | |
| *** dguerri is now known as dguerri` | 02:34 | |
| *** lhcheng has quit IRC | 02:35 | |
| *** stevemar has joined #openstack-horizon | 02:40 | |
| *** annashen has quit IRC | 02:42 | |
| *** annashen has joined #openstack-horizon | 02:42 | |
| *** annashen has quit IRC | 02:43 | |
| *** btully has joined #openstack-horizon | 02:48 | |
| *** btully has quit IRC | 02:53 | |
| *** mwhagedorn has joined #openstack-horizon | 02:57 | |
| *** sqchen has joined #openstack-horizon | 02:59 | |
| *** sqchen has quit IRC | 02:59 | |
| *** nzeplowi has joined #openstack-horizon | 03:04 | |
| *** mayurig has joined #openstack-horizon | 03:06 | |
| *** lhcheng has joined #openstack-horizon | 03:09 | |
| *** mayurig has quit IRC | 03:10 | |
| *** andrewbogott is now known as andrewbogott_afk | 03:14 | |
| *** nzeplowi has quit IRC | 03:14 | |
| *** nzeplowi has joined #openstack-horizon | 03:16 | |
| *** annashen has joined #openstack-horizon | 03:17 | |
| *** garthb has joined #openstack-horizon | 03:20 | |
| *** garthb has quit IRC | 03:20 | |
| *** garthb has joined #openstack-horizon | 03:20 | |
| *** garthb_ has joined #openstack-horizon | 03:20 | |
| *** nzeplowi has quit IRC | 03:22 | |
| *** jamielennox is now known as jamielennox|away | 03:22 | |
| *** jamielennox|away is now known as jamielennox | 03:31 | |
| *** piyanai has quit IRC | 03:34 | |
| *** piyanai has joined #openstack-horizon | 03:34 | |
| *** julim has quit IRC | 03:36 | |
| *** julim has joined #openstack-horizon | 03:37 | |
| *** julim has quit IRC | 03:37 | |
| *** amotoki has quit IRC | 03:37 | |
| *** jasondotstar has quit IRC | 03:37 | |
| *** yamamoto has quit IRC | 03:45 | |
| *** piyanai has quit IRC | 03:47 | |
| *** yingjun has quit IRC | 03:51 | |
| *** kiran-r has joined #openstack-horizon | 03:51 | |
| *** yamamoto has joined #openstack-horizon | 03:51 | |
| *** amotoki has joined #openstack-horizon | 03:51 | |
| *** mwhagedorn has quit IRC | 03:57 | |
| *** Drago has quit IRC | 04:01 | |
| *** vishwanathj has quit IRC | 04:02 | |
| *** vishwanathj has joined #openstack-horizon | 04:03 | |
| *** piyanai has joined #openstack-horizon | 04:05 | |
| *** vishwana_ has joined #openstack-horizon | 04:07 | |
| *** vishwanathj has quit IRC | 04:09 | |
| *** yamamoto has quit IRC | 04:12 | |
| *** vijendar has quit IRC | 04:12 | |
| *** vijendar has joined #openstack-horizon | 04:13 | |
| *** amotoki has quit IRC | 04:17 | |
| *** pamo has joined #openstack-horizon | 04:18 | |
| *** amotoki has joined #openstack-horizon | 04:23 | |
| *** kiran-r has quit IRC | 04:25 | |
| *** amotoki has quit IRC | 04:33 | |
| *** piyanai has quit IRC | 04:37 | |
| *** pamo has quit IRC | 04:40 | |
| *** amotoki has joined #openstack-horizon | 04:43 | |
| *** pamo has joined #openstack-horizon | 04:44 | |
| *** davidmichaelkarr has quit IRC | 04:47 | |
| *** pamo has quit IRC | 04:49 | |
| *** annashen has quit IRC | 04:50 | |
| *** pamo has joined #openstack-horizon | 04:52 | |
| *** masco__ has joined #openstack-horizon | 04:54 | |
| *** nzeplowi has joined #openstack-horizon | 04:58 | |
| *** btully has joined #openstack-horizon | 05:01 | |
| *** davidmichaelkarr has joined #openstack-horizon | 05:05 | |
| *** yamamoto has joined #openstack-horizon | 05:10 | |
| *** vijendar1 has joined #openstack-horizon | 05:14 | |
| *** vijendar has quit IRC | 05:16 | |
| *** stevemar has quit IRC | 05:22 | |
| *** Sukhdev has joined #openstack-horizon | 05:25 | |
| *** garthb has quit IRC | 05:48 | |
| *** garthb_ has quit IRC | 05:48 | |
| *** ig0r_ has joined #openstack-horizon | 05:51 | |
| *** ig0r__ has quit IRC | 05:55 | |
| *** pamo has quit IRC | 06:00 | |
| *** yingjun has joined #openstack-horizon | 06:01 | |
| *** yingjun has quit IRC | 06:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/199881 | 06:06 |
| *** yingjun has joined #openstack-horizon | 06:08 | |
| *** aix has joined #openstack-horizon | 06:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/199889 | 06:10 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 06:16 |
| *** jtomasek has joined #openstack-horizon | 06:16 | |
| *** kiran-r has joined #openstack-horizon | 06:19 | |
| *** josecastroleon has quit IRC | 06:22 | |
| *** annashen_ has joined #openstack-horizon | 06:27 | |
| *** jbell8 has joined #openstack-horizon | 06:33 | |
| *** nzeplowi has quit IRC | 06:36 | |
| *** dguerri` is now known as dguerri | 06:40 | |
| *** yingjun has quit IRC | 06:43 | |
| *** annashen_ has quit IRC | 06:45 | |
| *** dguerri is now known as dguerri` | 06:46 | |
| *** bfic has joined #openstack-horizon | 06:46 | |
| *** yingjun has joined #openstack-horizon | 06:46 | |
| *** _kiran_ has joined #openstack-horizon | 06:48 | |
| *** kiran-r has quit IRC | 06:51 | |
| *** lhcheng has quit IRC | 06:52 | |
| *** rdopiera has joined #openstack-horizon | 06:53 | |
| *** mpavlase has joined #openstack-horizon | 06:53 | |
| *** sqchen has joined #openstack-horizon | 06:57 | |
| *** ybathia has joined #openstack-horizon | 07:03 | |
| *** ybathia_ has joined #openstack-horizon | 07:04 | |
| *** ybathia has quit IRC | 07:07 | |
| *** ybathia_ is now known as ybathia | 07:07 | |
| *** _kiran_ has quit IRC | 07:08 | |
| *** TravT_away has quit IRC | 07:08 | |
| *** Piet has quit IRC | 07:10 | |
| *** Longgeek has quit IRC | 07:10 | |
| *** belmoreira has joined #openstack-horizon | 07:15 | |
| *** mrunge has joined #openstack-horizon | 07:16 | |
| *** Miouge has joined #openstack-horizon | 07:20 | |
| *** belmoreira has quit IRC | 07:21 | |
| *** Sukhdev has quit IRC | 07:25 | |
| *** krykowski has joined #openstack-horizon | 07:28 | |
| *** belmoreira has joined #openstack-horizon | 07:28 | |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix CSS GET None when mouse over the table cell https://review.openstack.org/199923 | 07:29 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Support of rescue instance in Horizon https://review.openstack.org/107379 | 07:35 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Show Admin Password https://review.openstack.org/171450 | 07:36 |
| *** stevemar has joined #openstack-horizon | 07:37 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:38 | |
| *** stevemar has quit IRC | 07:40 | |
| *** btully has quit IRC | 07:43 | |
| *** lhcheng has joined #openstack-horizon | 07:44 | |
| *** jbell8 has quit IRC | 07:46 | |
| *** Sukhdev has joined #openstack-horizon | 07:46 | |
| *** amotoki_ has joined #openstack-horizon | 07:47 | |
| *** amotoki has quit IRC | 07:49 | |
| *** Longgeek has joined #openstack-horizon | 07:50 | |
| *** yamamoto has quit IRC | 07:52 | |
| *** sayan has joined #openstack-horizon | 07:53 | |
| *** sayan_ has joined #openstack-horizon | 07:53 | |
| *** krykowski has quit IRC | 07:54 | |
| *** krykowski_ has joined #openstack-horizon | 07:57 | |
| *** ^Gal^ has joined #openstack-horizon | 07:57 | |
| *** pamo has joined #openstack-horizon | 07:58 | |
| *** bluex-pl has joined #openstack-horizon | 07:59 | |
| *** sayan has quit IRC | 07:59 | |
| *** bluex-pl has quit IRC | 08:00 | |
| *** sayan_ has quit IRC | 08:00 | |
| *** bluex-pl has joined #openstack-horizon | 08:00 | |
| *** Sukhdev has quit IRC | 08:02 | |
| *** pamo has quit IRC | 08:02 | |
| *** Ala has joined #openstack-horizon | 08:02 | |
| *** krykowski_ has quit IRC | 08:03 | |
| *** kzaitsev_mb has quit IRC | 08:03 | |
| *** jasondotstar has joined #openstack-horizon | 08:04 | |
| *** mrunge has quit IRC | 08:07 | |
| *** yamamoto has joined #openstack-horizon | 08:07 | |
| *** ^Gal^ has quit IRC | 08:11 | |
| *** saksham has joined #openstack-horizon | 08:12 | |
| *** sayan_ has joined #openstack-horizon | 08:12 | |
| *** saksham has quit IRC | 08:12 | |
| *** sayan has joined #openstack-horizon | 08:14 | |
| *** neillc is now known as neillc_away | 08:14 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:15 | |
| *** MaxV has joined #openstack-horizon | 08:17 | |
| *** ^Gal^ has joined #openstack-horizon | 08:18 | |
| *** kzaitsev_mb has quit IRC | 08:20 | |
| *** sqchen has quit IRC | 08:22 | |
| *** katyafervent_awa is now known as katyafervent | 08:24 | |
| *** Longgeek has quit IRC | 08:25 | |
| *** akrivoka has joined #openstack-horizon | 08:26 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/199889 | 08:28 |
| *** btully has joined #openstack-horizon | 08:29 | |
| *** jasondotstar has quit IRC | 08:29 | |
| *** sqchen has joined #openstack-horizon | 08:31 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:33 | |
| *** Longgeek has joined #openstack-horizon | 08:34 | |
| *** btully has quit IRC | 08:34 | |
| *** JeanBriceCombebi has quit IRC | 08:37 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:37 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/199881 | 08:44 |
| *** masco__ has quit IRC | 08:47 | |
| *** masco__ has joined #openstack-horizon | 08:47 | |
| *** kiran-r has joined #openstack-horizon | 08:49 | |
| *** ybathia has quit IRC | 08:50 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor network topology graph as an Angular directive https://review.openstack.org/199063 | 08:50 |
| *** sayan has quit IRC | 08:50 | |
| *** sayan_ has quit IRC | 08:50 | |
| *** kjelly has joined #openstack-horizon | 08:50 | |
| kjelly | #openstack-glance | 08:51 |
| *** JeanBriceCombebi has quit IRC | 08:52 | |
| *** ygbo has joined #openstack-horizon | 08:53 | |
| *** jasondotstar has joined #openstack-horizon | 08:53 | |
| *** sqchen has quit IRC | 08:54 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:57 | |
| *** TravT_away has joined #openstack-horizon | 09:01 | |
| *** amotoki_ has quit IRC | 09:02 | |
| *** akrivoka has quit IRC | 09:04 | |
| *** akrivoka has joined #openstack-horizon | 09:04 | |
| *** JeanBriceCombebi has quit IRC | 09:06 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:06 | |
| *** ^Gal^ has quit IRC | 09:07 | |
| *** ^Gal^ has joined #openstack-horizon | 09:07 | |
| *** tosky has joined #openstack-horizon | 09:07 | |
| *** mohankumar has quit IRC | 09:14 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:24 | |
| *** mpavlase has quit IRC | 09:25 | |
| *** e0ne has joined #openstack-horizon | 09:28 | |
| *** yingjun has quit IRC | 09:32 | |
| *** yamamoto has quit IRC | 09:32 | |
| *** lhcheng has quit IRC | 09:36 | |
| *** JeanBriceCombebi has quit IRC | 09:38 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:57 | |
| *** pamo has joined #openstack-horizon | 09:59 | |
| *** pamo has quit IRC | 10:04 | |
| *** mrunge has joined #openstack-horizon | 10:11 | |
| *** mrunge has quit IRC | 10:12 | |
| *** mrunge has joined #openstack-horizon | 10:12 | |
| *** e0ne is now known as e0ne_ | 10:24 | |
| openstackgerrit | Albert Tu proposed openstack/horizon: Add i18n support to Angular humanizeNumbers helper https://review.openstack.org/199997 | 10:26 |
| *** e0ne_ is now known as e0ne | 10:31 | |
| openstackgerrit | Merged openstack/horizon: Remove hz dashboard module from enabled https://review.openstack.org/199791 | 10:32 |
| *** kzaitsev_mb has quit IRC | 10:39 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:41 | |
| *** robcresswell has joined #openstack-horizon | 10:44 | |
| *** e0ne is now known as e0ne_ | 10:51 | |
| *** eandersson has joined #openstack-horizon | 10:54 | |
| *** sayan has joined #openstack-horizon | 10:54 | |
| eandersson | Morning | 10:55 |
| *** mpavlase has joined #openstack-horizon | 10:55 | |
| eandersson | Anyone know why I am getting this error only when trying to delete images? "BadStoreUri: Location is missing user:password information." | 10:55 |
| eandersson | and wrong channel sorry :D | 10:56 |
| *** JeanBriceCombebi has quit IRC | 10:58 | |
| robcresswell | Anyone else got today's master | 10:59 |
| robcresswell | JS seems totally dead | 10:59 |
| *** Longgeek has quit IRC | 10:59 | |
| *** vijendar1 has quit IRC | 11:00 | |
| *** vijendar has joined #openstack-horizon | 11:04 | |
| *** ^Gal^_ has joined #openstack-horizon | 11:05 | |
| *** piyanai has joined #openstack-horizon | 11:06 | |
| *** ^Gal^_ has quit IRC | 11:06 | |
| *** ^Gal^ has quit IRC | 11:06 | |
| *** ^Gal^ has joined #openstack-horizon | 11:08 | |
| *** MaxV has quit IRC | 11:10 | |
| *** Longgeek has joined #openstack-horizon | 11:14 | |
| *** sayan has quit IRC | 11:17 | |
| *** kzaitsev_mb has quit IRC | 11:20 | |
| *** MaxV has joined #openstack-horizon | 11:23 | |
| *** Miouge_ has joined #openstack-horizon | 11:32 | |
| *** Miouge has quit IRC | 11:35 | |
| *** Miouge_ is now known as Miouge | 11:35 | |
| *** sayan has joined #openstack-horizon | 11:36 | |
| *** ducttape_ has joined #openstack-horizon | 11:37 | |
| *** kzaitsev_mb has joined #openstack-horizon | 11:40 | |
| *** zhenguo has quit IRC | 11:50 | |
| *** e0ne_ is now known as e0ne | 11:50 | |
| *** ducttape_ has quit IRC | 11:51 | |
| *** sayan has quit IRC | 11:59 | |
| *** pamo has joined #openstack-horizon | 12:00 | |
| openstackgerrit | Matthias Runge proposed openstack/django_openstack_auth: Replace AnonymousUser with AbstractBaseUser https://review.openstack.org/167981 | 12:01 |
| *** e0ne is now known as e0ne_ | 12:02 | |
| *** KingKhan has joined #openstack-horizon | 12:05 | |
| *** pamo has quit IRC | 12:05 | |
| *** btully has joined #openstack-horizon | 12:05 | |
| *** e0ne_ is now known as e0ne | 12:09 | |
| *** btully has quit IRC | 12:10 | |
| KingKhan | hi @mrunge I had pinged some days back about reigistering/unregistering dashboards/panels | 12:13 |
| *** sayan has joined #openstack-horizon | 12:13 | |
| mrunge | KingKhan, hey | 12:13 |
| KingKhan | i was able to use the customisation module overrides in kilo for unregistering and stuff | 12:14 |
| KingKhan | and for removing dashboards @mrunge I went the enabled folder way jus as u said | 12:15 |
| KingKhan | @mrunge it worked thanks | 12:15 |
| mrunge | KingKhan, thanks for the feedback | 12:15 |
| KingKhan | @mrunge you had asked me if the dashboards were called somewhere which was and hence I faced the issue neways phew.... was able to figure that out thanks again on that front too | 12:17 |
| mrunge | glad you were able to figure it out | 12:18 |
| mrunge | horizon is kind of hard to debug :( | 12:18 |
| mrunge | in most cases you need more than just an educated guess | 12:18 |
| *** Miouge has quit IRC | 12:20 | |
| *** Miouge has joined #openstack-horizon | 12:21 | |
| *** mwhagedorn has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Angular doc tweaks https://review.openstack.org/200043 | 12:27 |
| *** yingjun has joined #openstack-horizon | 12:28 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix missing Identity JS files https://review.openstack.org/200044 | 12:28 |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:29 | |
| mrunge | robcresswell, you were able to fix your broken JS? | 12:29 |
| openstackgerrit | Jiri Tomasek proposed openstack/tuskar-ui: Delay introspection between nodes by 5 seconds https://review.openstack.org/200045 | 12:29 |
| *** sayan has quit IRC | 12:30 | |
| robcresswell | mrunge: It is a workaround... I've reverted the inclusion behaviour | 12:30 |
| robcresswell | mrunge: But I am unsure if this is a confirmed bug; do you see the same thing? | 12:30 |
| mrunge | robcresswell, I'm not using latest master right now | 12:31 |
| mrunge | wait, I do | 12:31 |
| mrunge | what do you see? | 12:31 |
| mrunge | or what issues do you see? | 12:31 |
| *** ducttape_ has joined #openstack-horizon | 12:31 | |
| *** svasheka has quit IRC | 12:31 | |
| robcresswell | https://bugs.launchpad.net/horizon/+bug/1473030 | 12:32 |
| openstack | Launchpad bug 1473030 in OpenStack Dashboard (Horizon) "JS load failing due to Identity" [Undecided,In progress] - Assigned to Rob Cresswell (robcresswell) | 12:32 |
| *** e0ne has quit IRC | 12:32 | |
| robcresswell | mrunge: ^^ | 12:32 |
| *** ducttape_ has quit IRC | 12:32 | |
| * mrunge clicks | 12:33 | |
| robcresswell | It seems to be stopping me doing much of anything | 12:33 |
| robcresswell | Only found it as of this morning | 12:33 |
| *** ducttape_ has joined #openstack-horizon | 12:33 | |
| mrunge | robcresswell, hmm, I can not reproduce that | 12:35 |
| robcresswell | mrunge: perhaps my env is borken. | 12:36 |
| mrunge | robcresswell, just by coincidence, I ran ./manage.py collectstatic --clear | 12:37 |
| *** ducttape_ has quit IRC | 12:37 | |
| mrunge | I just wanted to be sure, when reporting a new bug it's not my environment, which is broken | 12:37 |
| *** jasondotstar has quit IRC | 12:38 | |
| *** KingKhan has quit IRC | 12:38 | |
| mrunge | hmmm, it looks like my environment still uses old identity dashboard | 12:39 |
| mrunge | which would explain, why it's not broken | 12:39 |
| robcresswell | It isnt specific to the new one | 12:39 |
| mrunge | ah, ok | 12:39 |
| robcresswell | My JS is breaking regardless | 12:39 |
| robcresswell | Must be a setup issue | 12:39 |
| mrunge | robcresswell, are you using devstack? | 12:40 |
| robcresswell | mrunge: Currently, yes. :( | 12:41 |
| *** piyanai has quit IRC | 12:41 | |
| *** neelashah has joined #openstack-horizon | 12:43 | |
| mrunge | robcresswell, I can only recommend to use a real install to the rest and git checkouts for horizon | 12:43 |
| *** sayan has joined #openstack-horizon | 12:43 | |
| mrunge | robcresswell, pro is, you environment doesn't change, just point your horizon install to your keystone | 12:44 |
| robcresswell | mrunge: It seems to be working now anyway. Thanks | 12:44 |
| *** julim has joined #openstack-horizon | 12:44 | |
| mrunge | good luck | 12:44 |
| *** yingjun has quit IRC | 12:45 | |
| *** MaxV has quit IRC | 12:45 | |
| *** pserebryakov has joined #openstack-horizon | 12:48 | |
| *** Longgeek has quit IRC | 12:49 | |
| *** sayan has quit IRC | 12:50 | |
| *** amotoki has joined #openstack-horizon | 12:56 | |
| *** sayan has joined #openstack-horizon | 12:56 | |
| *** jasondotstar has joined #openstack-horizon | 12:58 | |
| *** svasheka has joined #openstack-horizon | 12:59 | |
| *** e0ne has joined #openstack-horizon | 13:00 | |
| *** yingjun has joined #openstack-horizon | 13:00 | |
| *** MaxV has joined #openstack-horizon | 13:01 | |
| *** ZZelle has quit IRC | 13:01 | |
| robcresswell | mrunge: On a review spree, any code need looking at? | 13:01 |
| robcresswell | Actually, that stands for anyone, ping if you've been waiting for reviews for a while. | 13:02 |
| *** ZZelle has joined #openstack-horizon | 13:02 | |
| mrunge | robcresswell, might be a good idea to look at david-lyle s patch to move sahara to contrib | 13:02 |
| robcresswell | mrunge: Good call | 13:03 |
| *** JeanBriceCombebi has quit IRC | 13:04 | |
| *** sayan has quit IRC | 13:04 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:05 | |
| *** stevemar has joined #openstack-horizon | 13:06 | |
| mrunge | robcresswell, for reference, that is https://review.openstack.org/#/c/197363/ | 13:07 |
| mrunge | took me a bit to find it | 13:07 |
| *** radez_g0n3 is now known as radez | 13:08 | |
| *** bfic has quit IRC | 13:08 | |
| *** zhenguo has joined #openstack-horizon | 13:09 | |
| *** amotoki has quit IRC | 13:09 | |
| tellesnobrega | hi, have you guys seen this | 13:09 |
| tellesnobrega | Hash of the package https://pypi.python.org/packages/py2.py3/D/Django/Django-1.7.9-py2.py3-none-any.whl#md5=2df76c90453477a9d0bb6a1608f0dfa5 (from https://pypi.python.org/simple/django/) (52358ac5f48fd514d6c4eb9e08830985) doesn't match the expected hash 2df76c90453477a9d0bb6a1608f0dfa5! | 13:09 |
| *** MaxV has quit IRC | 13:10 | |
| tellesnobrega | i cloned horizon and tried to run ./run_tests.sh and got this error | 13:10 |
| *** Miouge has quit IRC | 13:10 | |
| mrunge | tellesnobrega, try ./run_tests.sh -f | 13:13 |
| *** peristeri has joined #openstack-horizon | 13:14 | |
| *** Miouge has joined #openstack-horizon | 13:15 | |
| *** ducttape_ has joined #openstack-horizon | 13:16 | |
| *** amotoki has joined #openstack-horizon | 13:16 | |
| *** Longgeek has joined #openstack-horizon | 13:17 | |
| openstackgerrit | Matthias Runge proposed openstack/django_openstack_auth: Replace AnonymousUser with AbstractBaseUser https://review.openstack.org/167981 | 13:17 |
| *** Miouge has quit IRC | 13:17 | |
| *** Miouge has joined #openstack-horizon | 13:18 | |
| *** pauloewerton has joined #openstack-horizon | 13:19 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Fix 'paginate' and 'admin' GET parameters in Keystone Projects REST API https://review.openstack.org/199717 | 13:20 |
| *** ducttape_ has quit IRC | 13:22 | |
| *** piyanai has joined #openstack-horizon | 13:22 | |
| *** matt-borland has joined #openstack-horizon | 13:22 | |
| *** stevemar has quit IRC | 13:26 | |
| *** MaxV has joined #openstack-horizon | 13:26 | |
| *** stevemar has joined #openstack-horizon | 13:26 | |
| *** amotoki has quit IRC | 13:28 | |
| *** amotoki_ has joined #openstack-horizon | 13:28 | |
| tellesnobrega | mrunge, tried it | 13:28 |
| *** kzaitsev_mb has quit IRC | 13:29 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:31 | |
| *** piyanai has quit IRC | 13:33 | |
| *** JeanBriceCombebi has quit IRC | 13:33 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:33 | |
| *** stevemar has quit IRC | 13:33 | |
| *** dboik_ has quit IRC | 13:36 | |
| *** petertr7_away is now known as petertr7 | 13:37 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update example local_conf https://review.openstack.org/200080 | 13:37 |
| *** lucas__ has joined #openstack-horizon | 13:39 | |
| *** jtriley has joined #openstack-horizon | 13:39 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Update example local_conf https://review.openstack.org/200080 | 13:41 |
| *** andrewbogott_afk is now known as andrewbogott | 13:42 | |
| tellesnobrega | anyone else has an idea on how to work this out? | 13:44 |
| robcresswell | tellesnobrega: Afraid not, I've not seen that before | 13:45 |
| tellesnobrega | robcresswell, was anything from the requirements updated lately? | 13:46 |
| robcresswell | tellesnobrega: We cap Django at <1.8, so perhaps upstream. I'll look. | 13:47 |
| *** kzaitsev_mb has quit IRC | 13:48 | |
| *** MaxV has quit IRC | 13:49 | |
| *** kzaitsev_mb has joined #openstack-horizon | 13:49 | |
| robcresswell | tellesnobrega: It seems that version of django was uploaded yesterday, but I have no issues when running `./run_tests.sh -f` | 13:49 |
| *** lblanchard has joined #openstack-horizon | 13:49 | |
| *** katyafervent is now known as katyafervent_awa | 13:50 | |
| tellesnobrega | robcresswell, hum, weird...i'm gonna try on a different environment | 13:50 |
| *** ducttape_ has joined #openstack-horizon | 13:51 | |
| tellesnobrega | robcresswell, seems like my machine doesnt like horizon tests... tried on a vm and it worked | 13:51 |
| *** katyafervent_awa is now known as katyafervent | 13:52 | |
| robcresswell | tellesnobrega: :D | 13:53 |
| robcresswell | tellesnobrega: Hope you manage to get it resolved | 13:53 |
| tellesnobrega | robcresswell, thanks | 13:53 |
| *** btully has joined #openstack-horizon | 13:56 | |
| *** dboik has joined #openstack-horizon | 13:56 | |
| *** _crobertsrh is now known as crobertsrh | 13:57 | |
| *** kiran-r has quit IRC | 13:58 | |
| *** amotoki has joined #openstack-horizon | 13:58 | |
| *** pserebryakov has quit IRC | 14:00 | |
| *** TravT_away is now known as TravT | 14:01 | |
| *** amotoki_ has quit IRC | 14:01 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 14:02 |
| *** pamo has joined #openstack-horizon | 14:02 | |
| *** amotoki has quit IRC | 14:03 | |
| *** JeanBriceCombebi has quit IRC | 14:05 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:05 | |
| *** pamo has quit IRC | 14:06 | |
| binBASH | Hi, how to change ajax polling speed for row_update action? | 14:09 |
| *** kzaitsev_mb has quit IRC | 14:10 | |
| *** yingjun has quit IRC | 14:10 | |
| echozdog | Hi asked about this error yesterday but had to run home. I get this when I try to open the dashboard (5:06:13 PM) echozdog: [Wed Jul 08 17:04:57.060450 2015] [:error] [pid 6053] [remote 172.31.23.39:15045] IOError: [Errno 13] Permission denied: '/usr/share/openstack-dashboard/openstack_dashboard/local/_usr_share_openstack-dashboard_openstack_dashboard_local_.secret_key_store.lock' I got a couple replies namely that I can set the SECRET | 14:14 |
| echozdog | BTW thank you for the replies. I'm sorry I had to leave right after posted the question yesterady. | 14:14 |
| *** kzaitsev_mb has joined #openstack-horizon | 14:17 | |
| *** masco__ has quit IRC | 14:18 | |
| *** piyanai has joined #openstack-horizon | 14:20 | |
| openstackgerrit | Ryan Brady proposed openstack/tuskar-ui: Optimizes API Calls https://review.openstack.org/200121 | 14:22 |
| mrunge | echozdog, for production? | 14:22 |
| mrunge | I mean, in a production environment? | 14:22 |
| mrunge | echozdog, nevermind, I see your issue was solved | 14:23 |
| *** piyanai has quit IRC | 14:23 | |
| *** ongk has joined #openstack-horizon | 14:25 | |
| *** stevemar has joined #openstack-horizon | 14:25 | |
| *** stevemar has quit IRC | 14:25 | |
| *** stevemar has joined #openstack-horizon | 14:26 | |
| *** lucas__ has quit IRC | 14:27 | |
| *** lucas__ has joined #openstack-horizon | 14:28 | |
| *** amotoki has joined #openstack-horizon | 14:29 | |
| *** piyanai has joined #openstack-horizon | 14:30 | |
| *** Mzoo___ has joined #openstack-horizon | 14:33 | |
| echozdog | Yes production, but working twoards alpha. No I didn't get it solved. I have the code that generates the key in but it doesn't generate the key I guess | 14:36 |
| *** bluex-pl has quit IRC | 14:39 | |
| EmilienM | mrunge: thx for your help on https://review.openstack.org/#/c/198119/ | 14:39 |
| *** Mzoo___ has quit IRC | 14:39 | |
| *** bluex-pl has joined #openstack-horizon | 14:40 | |
| mrunge | EmilienM, you're welcome | 14:40 |
| *** petertr7 is now known as petertr7_away | 14:41 | |
| openstackgerrit | Brianna Poulos proposed openstack/horizon: Add volume type encryption update https://review.openstack.org/72024 | 14:42 |
| *** Mzoo has joined #openstack-horizon | 14:42 | |
| *** MaxV has joined #openstack-horizon | 14:42 | |
| *** petertr7_away is now known as petertr7 | 14:43 | |
| Mzoo | Hi experts, I don't know why nobody yet wrote test_deleting_tenant unit test, but I want to write it now, becasue its necessary as the other delete action tests(users, ...). | 14:43 |
| Mzoo | But i have a problem writting it. responce object is empty in my test: res = self.client.post(INDEX_URL, formData) api.keystone.tenant_delete(IgnoreArg(), project_id). Does anybody know why the responce object is empty? | 14:44 |
| Mzoo | formData = {'action': 'tenants__delete__%s' % project_id} | 14:45 |
| Mzoo | I want to assert the horizon success message(Deleted project: test_project) body returns in responce object in the test. But responce body is empty | 14:47 |
| Mzoo | Can anybody help me? | 14:48 |
| Mzoo | The status_code in res is 302(redirection). | 14:52 |
| *** notmars has joined #openstack-horizon | 14:53 | |
| Mzoo | No idea? | 14:59 |
| openstackgerrit | Ryan Brady proposed openstack/tuskar-ui: Optimizes API Calls https://review.openstack.org/200121 | 14:59 |
| david-lyle | Mzoo, are you wanting to write a unit test? | 15:00 |
| Mzoo | @david-lyle: Exactly, unit test for delete tenant. | 15:00 |
| echozdog | Hi. I'm not sure why I'm getting this error when I try to open the dashboard: [Thu Jul 09 09:50:18.547370 2015] [:error] [pid 6053] [remote 172.31.23.39:192] self.lockfile = open(self.fname, 'a') | 15:01 |
| echozdog | [Thu Jul 09 09:50:18.547415 2015] [:error] [pid 6053] [remote 172.31.23.39:192] IOError: [Errno 13] Permission denied: '/usr/share/openstack-dashboard/openstack_dashboard/local/_usr_share_openstack-dashboard_openstack_dashboard_local_.secret_key_store.lock'. The file doesn't exist, but I thought this line in local_settings.py generates it: | 15:01 |
| echozdog | SECRET_KEY = secret_key.generate_or_read_from_file( | 15:01 |
| echozdog | os.path.join(LOCAL_PATH, '.secret_key_store')) | 15:01 |
| david-lyle | you will need to mock the api calls, so you're providing the results for the API call | 15:01 |
| *** JeanBriceCombebi has quit IRC | 15:02 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:02 | |
| Mzoo | @david-lyle: I know, I wrote these sections, but when I want to send post action to delete tenant using res = self.client.post(INDEX_URL, formData), the res body is empty(becasue it is redirection header(302 status)) | 15:03 |
| *** TravT has quit IRC | 15:03 | |
| Mzoo | it is redirection to horizon/identity | 15:03 |
| *** TravT has joined #openstack-horizon | 15:04 | |
| Mzoo | @david-lyle: it is redirection to horizon/identity | 15:04 |
| david-lyle | I believe you are still missing a mock | 15:04 |
| david-lyle | possibly to the tenant list call made | 15:05 |
| david-lyle | do you have a stack trace? | 15:05 |
| binBASH | Hi david-lyle btw. | 15:05 |
| *** absubram has joined #openstack-horizon | 15:05 | |
| david-lyle | hello binBASH | 15:07 |
| *** Ala has quit IRC | 15:07 | |
| *** neelashah has quit IRC | 15:08 | |
| Mzoo | @david-lyle: This is my test unit: http://paste.openstack.org/show/358855/ | 15:08 |
| david-lyle | Mzoo: you are call delete manually at the end, why? | 15:09 |
| david-lyle | you mocked it once on line 3 the it should be called on line 6 | 15:10 |
| david-lyle | 7 is not necessary | 15:10 |
| david-lyle | also project_id is not defined yet | 15:11 |
| david-lyle | should match current_project_id | 15:11 |
| eandersson | Disabling DEBUG in Horizon was an interesting experience. Getting these > django.request Not Found: /static/dashboard/js/76adef98ad14.js | 15:11 |
| eandersson | Anything obvious I have missed that would cause that when disabling Debugging? | 15:12 |
| *** JeanBriceCombebi has quit IRC | 15:14 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:14 | |
| Mzoo | @david-lyle: To get rid of some error. I got this: 'ExpectedMethodCallsError: Verify: Expected methods never called:' when I comment this line out. (current_project_id was defined. It was typo!) | 15:15 |
| *** nlahouti has joined #openstack-horizon | 15:15 | |
| *** matt-borland has quit IRC | 15:15 | |
| *** sambetts has quit IRC | 15:15 | |
| Mzoo | @david-lyle: ExpectedMethodCallsError: Verify: Expected methods never called: 0. tenant_delete.__call__(<IgnoreArg>, '1') -> None | 15:15 |
| david-lyle | Mzoo: that error indicates the mock is not set up correctly | 15:16 |
| *** sayan has joined #openstack-horizon | 15:16 | |
| david-lyle | there should be a + and - line in your output to indicate what is being passed in | 15:16 |
| *** rdopiera has quit IRC | 15:16 | |
| *** sambetts has joined #openstack-horizon | 15:17 | |
| *** jbell8 has joined #openstack-horizon | 15:18 | |
| *** yingjun has joined #openstack-horizon | 15:18 | |
| *** yingjun has quit IRC | 15:18 | |
| *** jprovazn has joined #openstack-horizon | 15:19 | |
| *** Drago has joined #openstack-horizon | 15:20 | |
| *** Drago has quit IRC | 15:20 | |
| *** Mzoo has quit IRC | 15:20 | |
| david-lyle | Mzoo: I'm also wondering if a mock of tenant_list may be necessary | 15:20 |
| *** Drago has joined #openstack-horizon | 15:20 | |
| david-lyle | before tenant_delete | 15:20 |
| *** neelashah has joined #openstack-horizon | 15:20 | |
| robcresswell | david-lyle: Going through your sahara contrib patch, what is this part for? https://review.openstack.org/#/c/197363/4/openstack_dashboard/test/test_plugins/panel_tests.py | 15:22 |
| *** vishwana_ has quit IRC | 15:23 | |
| *** vishwanathj has joined #openstack-horizon | 15:23 | |
| *** jamielennox is now known as jamielennox|away | 15:23 | |
| david-lyle | robcresswell: it's slightly unrelated, but I was playing with that code trying to figure out why the test content setup was incorrect | 15:26 |
| david-lyle | but it's basically throwing out the config content for testing loading a custom panel | 15:27 |
| david-lyle | originally I was reusing that | 15:27 |
| *** ducttape_ has quit IRC | 15:27 | |
| david-lyle | but I found the underlying issue elsewhere | 15:28 |
| *** JeanBriceCombebi has quit IRC | 15:28 | |
| david-lyle | I could move that change into a separate patch if desired, but it's something that had been overlooked as all the changes to pluggable content had been made | 15:28 |
| robcresswell | david-lyle: No, its fine in there. I was wondering if it was actually a requirement, but running tests without it seems to break them. The other thing was, do we also need to add the 'external_templates' bit to that? I'm not clear how the panel tests work yet, still looking. | 15:30 |
| *** ducttape_ has joined #openstack-horizon | 15:30 | |
| *** ducttape_ has quit IRC | 15:30 | |
| openstackgerrit | Merged openstack/tuskar-ui: Optimizes API Calls https://review.openstack.org/200121 | 15:31 |
| david-lyle | robcresswell: most likely | 15:31 |
| david-lyle | robcresswell: it's just a simplification to remove the rest of the content and test that only the specified thing is loaded | 15:31 |
| *** jamielennox|away is now known as jamielennox | 15:32 | |
| david-lyle | theoretically we could just load more content, but that would be a less black/white test | 15:32 |
| *** e0ne is now known as e0ne_ | 15:32 | |
| robcresswell | david-lyle: Yeah I see. Regardless, rest of patch seems to be fine as far as I can tell. Tests are passing, and everything is rendering as I'd expect. | 15:32 |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:32 | |
| david-lyle | robcresswell: so what is external_templates for exactly, I was looking at that newly merged content and it's not documented at all | 15:33 |
| robcresswell | david-lyle: I was also looking through the commit for that after I saw you WTF-ing at it. I think its for pulling in external HTML files in the same way we pull in the SCSS and JS files | 15:34 |
| david-lyle | too much is falling through the cracks | 15:34 |
| robcresswell | But probably better to ask sqchen or TravT | 15:34 |
| robcresswell | Ha, yes, difficult to keep on top of it all. | 15:34 |
| david-lyle | robcresswell: so we're ignoring the django toolset for loading templates and writing another? | 15:35 |
| *** Miouge has quit IRC | 15:35 | |
| david-lyle | why? | 15:35 |
| david-lyle | since you conceived and wrote it and all :P | 15:35 |
| robcresswell | david-lyle: Lets wait for one of the others to confirm, I may be totally wrong. | 15:35 |
| robcresswell | haha | 15:35 |
| robcresswell | david-lyle: If you want to get really confused by it, this patch lets you override Django templates from the themes folder... https://review.openstack.org/#/c/188162/ | 15:36 |
| robcresswell | david-lyle: Which I still feel unsure about, hence the comment without review. | 15:37 |
| *** piyanai has quit IRC | 15:37 | |
| david-lyle | robcresswell: at least that patch adds the dir to TEMPLATE_DIRS | 15:38 |
| david-lyle | why external_templates wouldn't do that, I have no idea | 15:38 |
| *** garthb_ has joined #openstack-horizon | 15:38 | |
| *** garthb has joined #openstack-horizon | 15:38 | |
| david-lyle | basically because people don't understand django | 15:38 |
| david-lyle | hurgleburgler at least understands the django implications | 15:39 |
| david-lyle | I think I'll just leave a stand WTF | 15:41 |
| david-lyle | and just assume it applies | 15:41 |
| david-lyle | :P | 15:41 |
| david-lyle | *standing | 15:41 |
| *** piyanai has joined #openstack-horizon | 15:42 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Fix eslint errors on the login controller https://review.openstack.org/198148 | 15:43 |
| *** jcoufal has quit IRC | 15:43 | |
| robcresswell | ha, yeah I just wanted to point out it may screw with your plugin testing | 15:45 |
| robcresswell | perhaps one of the angular folk can explain the thinking | 15:45 |
| *** e0ne_ is now known as e0ne | 15:48 | |
| *** belmoreira has quit IRC | 15:48 | |
| *** MaxV has quit IRC | 15:49 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Use form field errors on volume Extend form https://review.openstack.org/200158 | 15:49 |
| *** ducttape_ has joined #openstack-horizon | 15:51 | |
| *** Miouge has joined #openstack-horizon | 15:52 | |
| *** stevemar has quit IRC | 15:56 | |
| *** matt-borland has joined #openstack-horizon | 15:59 | |
| *** SimonChung has quit IRC | 16:00 | |
| *** notmars has quit IRC | 16:03 | |
| *** bitblt has joined #openstack-horizon | 16:03 | |
| *** pamo has joined #openstack-horizon | 16:03 | |
| *** lucas__ has quit IRC | 16:05 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-ui: Update version to 1.0.1 https://review.openstack.org/200166 | 16:07 |
| *** mpavlase has quit IRC | 16:08 | |
| *** pamo has quit IRC | 16:08 | |
| *** notmars has joined #openstack-horizon | 16:08 | |
| *** nzeplowi has joined #openstack-horizon | 16:10 | |
| *** notmars_ has joined #openstack-horizon | 16:11 | |
| *** ghundal_TW has joined #openstack-horizon | 16:12 | |
| *** notmars has quit IRC | 16:13 | |
| *** notmars_ is now known as notmars | 16:13 | |
| *** Miouge has quit IRC | 16:13 | |
| *** TravT_ has joined #openstack-horizon | 16:13 | |
| *** sqchen has joined #openstack-horizon | 16:13 | |
| echozdog | BTW I fixed my issue by changing the SECRET_KEY to this: SECRET_KEY = secret_key.generate_or_read_from_file('/var/lib/openstack-dashboard/secret_key') | 16:15 |
| *** JeanBriceCombebi has quit IRC | 16:16 | |
| *** TravT has quit IRC | 16:16 | |
| *** TravT_ is now known as TravT | 16:16 | |
| *** tjones1 has joined #openstack-horizon | 16:17 | |
| *** piyanai has left #openstack-horizon | 16:18 | |
| *** clu_ has joined #openstack-horizon | 16:19 | |
| ghundal_TW | RobCresswell you there? | 16:19 |
| *** clu_ has quit IRC | 16:20 | |
| *** deuce has joined #openstack-horizon | 16:20 | |
| *** jamielennox is now known as jamielennox|away | 16:21 | |
| *** clu_ has joined #openstack-horizon | 16:22 | |
| *** Miouge has joined #openstack-horizon | 16:22 | |
| *** sqchen has quit IRC | 16:25 | |
| *** sqchen has joined #openstack-horizon | 16:27 | |
| *** jbell8 has quit IRC | 16:28 | |
| *** jamielennox|away is now known as jamielennox | 16:29 | |
| TravT | robcresswell: just saw earlier conversation on external templates and saying to ask me. Looks like my contribution to that patch was a comment post merge asking for documentation. so, i don't have much to add to the earlier conversation (https://review.openstack.org/#/c/183364/) | 16:30 |
| *** tqtran has joined #openstack-horizon | 16:31 | |
| TravT | david-lyle ^ | 16:31 |
| *** notmars has quit IRC | 16:31 | |
| *** garthb_ has quit IRC | 16:31 | |
| *** ygbo has quit IRC | 16:32 | |
| *** rajatvig_ has joined #openstack-horizon | 16:33 | |
| *** kiran-r has joined #openstack-horizon | 16:33 | |
| *** mgarza_ has joined #openstack-horizon | 16:35 | |
| *** pamo has joined #openstack-horizon | 16:36 | |
| *** petertr7 is now known as petertr7_away | 16:38 | |
| *** annashen has joined #openstack-horizon | 16:38 | |
| *** dsneddon_away is now known as dsneddon | 16:41 | |
| *** jingjing_ren has joined #openstack-horizon | 16:41 | |
| *** e0ne has quit IRC | 16:42 | |
| *** SimonChung has joined #openstack-horizon | 16:42 | |
| *** kzaitsev_mb has quit IRC | 16:43 | |
| krotscheck | deuce: Actually, there's a review up right now to more selectively apply the various rules. As you can see, the /auth package is included in the angular style guides, while the legacy code isn't. https://review.openstack.org/#/c/195799/ | 16:43 |
| *** lucas__ has joined #openstack-horizon | 16:44 | |
| *** varoske has joined #openstack-horizon | 16:44 | |
| *** jingjing_ren has quit IRC | 16:44 | |
| *** jbell8 has joined #openstack-horizon | 16:45 | |
| *** bitblt has quit IRC | 16:45 | |
| *** lucas___ has joined #openstack-horizon | 16:46 | |
| *** lucas___ has quit IRC | 16:47 | |
| *** Miouge has quit IRC | 16:47 | |
| *** lucas___ has joined #openstack-horizon | 16:47 | |
| *** lucas__ has quit IRC | 16:48 | |
| *** kbrown has joined #openstack-horizon | 16:49 | |
| *** lucas___ has quit IRC | 16:51 | |
| *** andrewbogott is now known as andrewbogott_afk | 16:55 | |
| *** pamo has quit IRC | 16:56 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 16:56 |
| *** lhcheng has joined #openstack-horizon | 16:57 | |
| *** Miouge has joined #openstack-horizon | 16:57 | |
| *** lucas__ has joined #openstack-horizon | 16:57 | |
| *** lucas__ has quit IRC | 17:02 | |
| david-lyle | TravT: I guess my greater concern is we're reinventing django features, wondering why | 17:03 |
| *** Sukhdev has joined #openstack-horizon | 17:05 | |
| ducttape_ | thanks tqtran btw | 17:05 |
| tqtran | david-lyle, TravT: what are we reinventing? i missed the convo | 17:06 |
| tqtran | ducttape_: np :P | 17:06 |
| *** jpomero has quit IRC | 17:06 | |
| TravT | david-lyle: tqtran: https://review.openstack.org/#/c/183364/20 | 17:06 |
| *** dscottsf has joined #openstack-horizon | 17:07 | |
| TravT | i think. i don't know if that was the patch under discussion earlier or not | 17:07 |
| tqtran | i think the primary reason for doing it that way is the ordering of static resources by file extension | 17:08 |
| *** dscottsf has quit IRC | 17:08 | |
| tqtran | django can collect static resources, but i dont think it knows how to order them | 17:08 |
| *** tosky has quit IRC | 17:09 | |
| ducttape_ | I'm w david-lyle. there is a lot of code around auto discovery and setup of files, and the new code seems no better (or not much better) than the original situation. | 17:09 |
| tqtran | but i dont know django super well, so there might be ways for us to hook into it and do something similar | 17:09 |
| david-lyle | it's the external_templates I'm concerned with | 17:09 |
| david-lyle | it looks like a hasty after thought | 17:09 |
| david-lyle | wasn't part of the bp | 17:09 |
| david-lyle | and looks like it's reinventing django | 17:10 |
| *** kzaitsev_mb has joined #openstack-horizon | 17:10 | |
| david-lyle | which I don't think we need to do | 17:10 |
| tqtran | let me take a look what is actually using it, i think i know why its there but let me confirm | 17:10 |
| david-lyle | it's not documented what the purpose even is | 17:10 |
| david-lyle | but it looks like I'm going to manually list HTML files | 17:11 |
| david-lyle | that happen to live in static rather than tempates | 17:11 |
| tqtran | i just did a search for it, looks like we aren't using, but i think i know why its there | 17:12 |
| tqtran | btw, i might just drop off anytime, in the midst of a presentation so.... | 17:12 |
| david-lyle | now that's multitasking | 17:13 |
| tqtran | basically, the idea behind external_templates is two fold | 17:13 |
| tqtran | well, im in Q for the next person up | 17:13 |
| tqtran | so just chillin until they call on me | 17:13 |
| tqtran | 1. this would allow us to list templates we want to compress in the future | 17:13 |
| *** TravT_ has joined #openstack-horizon | 17:13 | |
| *** TravT_ has quit IRC | 17:13 | |
| tqtran | and yeah, we're talking about static html, not django templates | 17:14 |
| *** TravT_ has joined #openstack-horizon | 17:14 | |
| ducttape_ | so https://github.com/openstack/horizon/blob/master/openstack_dashboard/static_settings.py is about 120 lines of python. and it creates an html snippet that is about 40 lines | 17:14 |
| ducttape_ | not sure how that made sense :\ | 17:14 |
| tqtran | 2. this would allow us to pre-process html that are needed by directives, we need to do this for testing them | 17:14 |
| *** jprovazn has quit IRC | 17:15 | |
| *** notmars has joined #openstack-horizon | 17:15 | |
| tqtran | there are libraries that converting your HTML into <script> and embedding them into your main test HTML (aka jasmine.html) but its another npm package that we would have to pull in | 17:15 |
| david-lyle | ducttape_: that was simpler, but moving webroot made it more complicated | 17:15 |
| *** lucas__ has joined #openstack-horizon | 17:16 | |
| ducttape_ | something is certainly making things more complicated, I agree :P | 17:16 |
| *** TravT has quit IRC | 17:16 | |
| tqtran | anyway, going back to point 1, if we compress css and js, we can similarly do it for static html. this would require less fetches and improve performance in the long run | 17:17 |
| tqtran | but yeah, those are the 2 points i wanted to raise. on the flip side, we arent there yet, and doesn't look like external templates is getting used anywhere | 17:17 |
| david-lyle | tqtran: are we over engineering here for a future goal that may or may not happed? | 17:17 |
| david-lyle | happen* | 17:17 |
| ducttape_ | tqtran - I can tell you that compression of static html is not your performance problem to chase | 17:17 |
| ducttape_ | there are much bigger fish to catch | 17:17 |
| tqtran | we might be overengineer | 17:18 |
| david-lyle | let's address the problems as they come up, not preplan | 17:18 |
| david-lyle | we won't get it right | 17:18 |
| david-lyle | :P | 17:18 |
| david-lyle | but you're wanting to compress the HTML how? | 17:18 |
| tqtran | im ok with removing the external_templates, since its not use anywhere. but prefer to keep the auto-discovery part intact, that part is really really nice | 17:19 |
| tqtran | i dont think its something we should focus on this cycle | 17:19 |
| ducttape_ | tqtran - the huge problem with horizon and performance is the number of api calls, and how long each takes to run. this is like 99.99% of the issue with horizon slowness, and part of why searchlight has such appeal | 17:19 |
| tqtran | ducttape_: yes, i agree | 17:19 |
| tqtran | in fact, if you dont compress anything, you'll barely notice a difference | 17:20 |
| david-lyle | I think it was slipped in, and not part of the spec | 17:20 |
| david-lyle | I'd prefer to have it removed unless there is a real reason for it | 17:20 |
| tqtran | im fine with that | 17:20 |
| david-lyle | if we don't overcomplicate the patches, they will move faster | 17:21 |
| david-lyle | and not make people wonder what the heck things are for | 17:21 |
| tqtran | ok, hold on, let me show an example | 17:21 |
| tqtran | https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/action-list/action-list.spec.js#L44 | 17:22 |
| tqtran | so right now, in order for us to test a directive, we have to inline it | 17:22 |
| TravT_ | ducttape_ you'll be happy to know that searchlight now has a designate plugin review up | 17:22 |
| tqtran | it would be far superior to have that as a action-list.test.html or something similar | 17:22 |
| david-lyle | so this is purely for testing? | 17:23 |
| *** saksham has joined #openstack-horizon | 17:23 | |
| ducttape_ | TravT_ - thats good, I hope you get more data than the cli provides ;) | 17:23 |
| TravT_ | i haven't looked at it yet. was written by a member of the designate team | 17:23 |
| TravT_ | if you want to comment on it, i'll shoot you the review id | 17:23 |
| tqtran | as i understand it, it can be use for testing | 17:23 |
| tqtran | but again, we're not using it atm | 17:23 |
| *** geoffarnold has quit IRC | 17:24 | |
| tqtran | but i have a feeling that it will be needed very soon | 17:24 |
| tqtran | i'll leave the decision up to you dave, :P just thought you should have as much info about it as possible before you make the decision | 17:24 |
| david-lyle | I just really don't like the trojan aspect of it | 17:24 |
| tqtran | i agree | 17:25 |
| tqtran | that wasnt clearly detailed anywhere | 17:25 |
| david-lyle | nor documented, nor added to settings properly | 17:25 |
| tqtran | i sneak in easter-eggs all the time, you guys just dont know it :P | 17:25 |
| *** TravT_ is now known as TravT | 17:25 | |
| david-lyle | we call those bugs :P | 17:26 |
| tqtran | lol | 17:26 |
| ghundal_TW | Easter Eggs or Undocumented Features? | 17:26 |
| david-lyle | and we know it | 17:26 |
| david-lyle | :D | 17:26 |
| * TravT so tired of my internet flakiness | 17:26 | |
| tqtran | hahaha | 17:26 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create app/core directory https://review.openstack.org/197310 | 17:26 |
| tqtran | so, are we removing then? or keeping? | 17:26 |
| ducttape_ | tqtran - your job is to prevent sneaky stuff from coming in. I know you are joking now, but half the humor is lost on me | 17:26 |
| tqtran | haha ouchies | 17:27 |
| david-lyle | this merged on june 16, and there is no follow-on patch right, just a bug | 17:28 |
| david-lyle | which TravT filed 53 minutes ago | 17:28 |
| david-lyle | so, the aim was to sweep it under the rug | 17:28 |
| TravT | whose aim? | 17:29 |
| david-lyle | no idea, but certainly wasn't addressed | 17:30 |
| david-lyle | docs and tests aren't fun, but we can't remain slack on them | 17:31 |
| TravT | definitely agreed on that | 17:31 |
| *** lucas__ has quit IRC | 17:32 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create app/core directory https://review.openstack.org/197310 | 17:32 |
| *** kzaitsev_mb has quit IRC | 17:35 | |
| *** mwhagedorn has quit IRC | 17:35 | |
| *** saksham has quit IRC | 17:36 | |
| *** tosky has joined #openstack-horizon | 17:36 | |
| *** stevemar has joined #openstack-horizon | 17:36 | |
| *** raildo has quit IRC | 17:37 | |
| *** petertr7_away is now known as petertr7 | 17:37 | |
| *** raildo has joined #openstack-horizon | 17:37 | |
| lhcheng | ++ david-lyle | 17:38 |
| lhcheng | the quality of reviews has been going down, we need to do a better job on that. | 17:39 |
| *** saksham has joined #openstack-horizon | 17:39 | |
| openstackgerrit | Telles Mota Vidal Nóbrega proposed openstack/horizon: Allow multiple clusters creation https://review.openstack.org/198847 | 17:40 |
| *** raildo has quit IRC | 17:40 | |
| *** raildo has joined #openstack-horizon | 17:41 | |
| *** mwhagedorn has joined #openstack-horizon | 17:41 | |
| *** pamo has joined #openstack-horizon | 17:42 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Fix eslint errors about ng-di on the cloud-services. https://review.openstack.org/198840 | 17:42 |
| david-lyle | lhcheng: ++ | 17:42 |
| *** raildo has quit IRC | 17:42 | |
| openstackgerrit | KBrown proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 17:44 |
| *** lucas__ has joined #openstack-horizon | 17:44 | |
| lhcheng | david-lyle: for impacting changes, we should have more core looks at it before it gets approved instead of the conventional two +2s. | 17:45 |
| david-lyle | lhcheng: they all are potentially impacting changes if not done right :) | 17:46 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: LBAAS VIP floating IP table actions https://review.openstack.org/196740 | 17:46 |
| ghundal_TW | Can someone send me a link on how to undo accidentally clcking rebase on a change in gerrit? | 17:46 |
| mfisch | not sure you can | 17:47 |
| mfisch | maybe by hand | 17:47 |
| david-lyle | ghundal_TW: not sure why you wouldn't want to rebase | 17:48 |
| david-lyle | it will have to before merging anyway | 17:48 |
| ghundal_TW | iclicking the button was a mistake.. :) | 17:48 |
| matt-borland | lhcheng: if the quality of reviews have gone down...what are the ways to improve it rather than just "add more core approvals?" | 17:48 |
| david-lyle | your patch, or someone else's? | 17:48 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move cloud-services into app/core https://review.openstack.org/197334 | 17:48 |
| ghundal_TW | someone else's | 17:48 |
| david-lyle | no worries | 17:48 |
| david-lyle | like I said, it has to rebase anyway | 17:49 |
| david-lyle | it's appropriate to rebase and see if it works with top of tree | 17:49 |
| *** raildo_ has joined #openstack-horizon | 17:49 | |
| ghundal_TW | thanks David.. | 17:50 |
| david-lyle | matt-borland: I suppose I need to specify the criteria more clearly | 17:50 |
| lhcheng | david-lyle: I mean changes that has impact across panels or framework. :P but yeah, all changes can break something :) | 17:50 |
| *** e0ne has joined #openstack-horizon | 17:51 | |
| *** lucas__ has quit IRC | 17:51 | |
| *** pamo has quit IRC | 17:52 | |
| varoske | *are* there criteria for reviews specified somewhere? that'd be helpful | 17:52 |
| lhcheng | matt-borland, varoske: there should be some general guideline somewhere | 17:53 |
| *** pamo has joined #openstack-horizon | 17:53 | |
| david-lyle | https://wiki.openstack.org/wiki/CodeReviewGuidelines | 17:53 |
| lhcheng | like looking for docs, test and validating that it actually works | 17:53 |
| lhcheng | thanks david-lyle | 17:54 |
| david-lyle | are the general guidelines, but I will add more specific Horizon guidelines on https://wiki.openstack.org/wiki/Horizon/Reviews | 17:54 |
| *** lucas__ has joined #openstack-horizon | 17:54 | |
| varoske | thanks | 17:54 |
| matt-borland | david-lyle: sounds like a good topic for *discussion* :) | 17:55 |
| *** geoffarnold has joined #openstack-horizon | 17:55 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Fix eslint errors about ng-di on the cloud-services. https://review.openstack.org/198840 | 18:04 |
| *** kiran-r has quit IRC | 18:09 | |
| varoske | maybe the horizon guidelines can include expectations such as, pulling it down and testing locally... what sorts of things to test | 18:10 |
| *** jpomero has joined #openstack-horizon | 18:10 | |
| *** notmars has quit IRC | 18:10 | |
| *** notmars has joined #openstack-horizon | 18:10 | |
| *** sayan has quit IRC | 18:11 | |
| *** stevemar has quit IRC | 18:11 | |
| ekarlso | is there a reason why when I do a associate floating ip from the instance page the ports list is empty ? | 18:13 |
| *** stevemar has joined #openstack-horizon | 18:14 | |
| *** bluex-pl has quit IRC | 18:14 | |
| *** stevemar has quit IRC | 18:15 | |
| *** stevemar has joined #openstack-horizon | 18:15 | |
| robcresswell | ghundal_TW: Hullo, how can I help? | 18:16 |
| *** Sukhdev has quit IRC | 18:19 | |
| *** jingjing_ren has joined #openstack-horizon | 18:23 | |
| *** jwy has joined #openstack-horizon | 18:24 | |
| ducttape_ | ekarlso - this is where that starts at: https://github.com/openstack/horizon/blob/65db6d33aa40a202cd16ad60e08273f715a67745/openstack_dashboard/dashboards/project/access_and_security/floating_ips/workflows.py#L83 | 18:24 |
| ducttape_ | and floating_ip_target_list() varies by neutron vs nova networking | 18:25 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 18:25 |
| *** esp_ has joined #openstack-horizon | 18:27 | |
| *** jingjing_ren has quit IRC | 18:28 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 18:29 |
| ghundal_TW | robcresswell: msg sent | 18:31 |
| sjmc7 | ekarlso - your instance's network needs to be attached to a router that's attached to the external gateway | 18:32 |
| *** jingjing_ren has joined #openstack-horizon | 18:33 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:35 | |
| *** sqchen has quit IRC | 18:35 | |
| ekarlso | aha sjmc7 ! | 18:39 |
| *** mwhagedorn has quit IRC | 18:39 | |
| *** lucas__ has quit IRC | 18:40 | |
| *** mwhagedorn has joined #openstack-horizon | 18:40 | |
| *** andrewbogott_afk is now known as andrewbogott | 18:41 | |
| *** doug-fish has joined #openstack-horizon | 18:43 | |
| *** geoffarnold has quit IRC | 18:43 | |
| *** jingjing_ren has quit IRC | 18:45 | |
| *** jingjing_ren has joined #openstack-horizon | 18:46 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add New UX CSS for Upcoming Detail Screens https://review.openstack.org/158881 | 18:48 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 18:48 |
| openstackgerrit | Matt Borland proposed openstack/horizon: Detail-page directives (Angular/UX) https://review.openstack.org/173359 | 18:49 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Dashboard karma is missing framework files https://review.openstack.org/200207 | 18:49 |
| *** raildo_ has quit IRC | 18:50 | |
| *** Sukhdev has joined #openstack-horizon | 18:50 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Dashboard karma is missing framework files https://review.openstack.org/200207 | 18:51 |
| *** lucas__ has joined #openstack-horizon | 18:51 | |
| tqtran | wow, my email in the ML shows up a day later | 18:53 |
| *** sqchen has joined #openstack-horizon | 18:54 | |
| *** geoffarnold has joined #openstack-horizon | 18:54 | |
| *** mpavlase has joined #openstack-horizon | 18:56 | |
| *** ducttape_ has quit IRC | 18:57 | |
| *** ducttape_ has joined #openstack-horizon | 18:58 | |
| *** tosky has quit IRC | 18:58 | |
| *** tosky has joined #openstack-horizon | 18:59 | |
| *** jcoufal has joined #openstack-horizon | 19:00 | |
| *** absubram has quit IRC | 19:00 | |
| *** petertr7 is now known as petertr7_away | 19:01 | |
| *** petertr7_away is now known as petertr7 | 19:01 | |
| *** TravT is now known as TravT_away | 19:03 | |
| david-lyle | I have changed, https://wiki.openstack.org/wiki/Horizon/Reviews this is what I expect from reviews. | 19:04 |
| david-lyle | in addition to the overriding ideas around constructive, positive comments | 19:05 |
| david-lyle | which are true across OpenStack | 19:06 |
| *** emw has joined #openstack-horizon | 19:07 | |
| mrunge | great, thank you david-lyle | 19:07 |
| *** neelashah has quit IRC | 19:08 | |
| matt-borland | david-lyle: thanks for the writeup | 19:11 |
| *** annashen has quit IRC | 19:11 | |
| varoske | thanks! | 19:12 |
| *** nzeplowi has quit IRC | 19:14 | |
| *** tqtran has quit IRC | 19:14 | |
| rajatvig_ | great | 19:15 |
| *** lucas__ has quit IRC | 19:15 | |
| *** lucas__ has joined #openstack-horizon | 19:16 | |
| *** esp_ has quit IRC | 19:18 | |
| *** jingjing_ren has quit IRC | 19:19 | |
| *** jtomasek has quit IRC | 19:21 | |
| *** tqtran has joined #openstack-horizon | 19:21 | |
| *** jingjing_ren has joined #openstack-horizon | 19:22 | |
| krotscheck | david-lyle: Need those recommendations for cores on eslint-config-openstack | 19:22 |
| *** notmars has quit IRC | 19:24 | |
| *** pamo has quit IRC | 19:25 | |
| *** jingjing_ren has quit IRC | 19:26 | |
| david-lyle | krotscheck: clu_, r1chardj0n3s? | 19:28 |
| krotscheck | clu_, r1chardj0n3s: Either of you interested in becoming cores on openstack/eslint-config-openstack? | 19:28 |
| clu_ | hey krotscheck: sure | 19:29 |
| david-lyle | krotscheck: how many are you wanting? shouldn't need too many is my guess | 19:29 |
| krotscheck | david-lyle: We've got mtreinish (head of QA) and myself at this point. I figure one or two more would be nice. | 19:30 |
| krotscheck | But I have to go do the official nomination thing. | 19:30 |
| *** notmars has joined #openstack-horizon | 19:31 | |
| david-lyle | sure | 19:31 |
| *** varoske has quit IRC | 19:31 | |
| krotscheck | Email out! | 19:34 |
| *** nlahouti has quit IRC | 19:34 | |
| *** annashen has joined #openstack-horizon | 19:35 | |
| *** emw has quit IRC | 19:35 | |
| *** sambetts has quit IRC | 19:35 | |
| *** emw has joined #openstack-horizon | 19:35 | |
| tqtran | sqchen: is the table patch failing karma locally for you? | 19:35 |
| *** sqchen has quit IRC | 19:36 | |
| *** sambetts has joined #openstack-horizon | 19:38 | |
| *** emilyw has joined #openstack-horizon | 19:38 | |
| tqtran | this patch should fix it, https://review.openstack.org/#/c/200207/ | 19:38 |
| tqtran | the problem was that we were missing files from framework | 19:38 |
| *** mrunge has quit IRC | 19:39 | |
| *** jbell8 has quit IRC | 19:39 | |
| *** deuce has quit IRC | 19:41 | |
| *** rajatvig_ has quit IRC | 19:41 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 19:41 |
| *** emw has quit IRC | 19:42 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 19:42 |
| *** zhenguo has quit IRC | 19:43 | |
| *** lucas__ has quit IRC | 19:43 | |
| *** TravT_away has quit IRC | 19:44 | |
| *** jbell8 has joined #openstack-horizon | 19:46 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Helper script to set up a development environment https://review.openstack.org/200228 | 19:47 |
| *** jbell8 has quit IRC | 19:47 | |
| *** petertr7 is now known as petertr7_away | 19:48 | |
| *** lucas___ has joined #openstack-horizon | 19:49 | |
| *** rajatvig_ has joined #openstack-horizon | 19:49 | |
| *** Longgeek has quit IRC | 19:49 | |
| *** lucas___ has quit IRC | 19:50 | |
| *** jingjing_ren has joined #openstack-horizon | 19:50 | |
| *** annashen has quit IRC | 19:51 | |
| *** akrivoka has quit IRC | 19:51 | |
| *** jingjing_ren has quit IRC | 19:51 | |
| *** lucas___ has joined #openstack-horizon | 19:51 | |
| *** jingjing_ren has joined #openstack-horizon | 19:51 | |
| *** annashen has joined #openstack-horizon | 19:51 | |
| *** petertr7_away is now known as petertr7 | 19:52 | |
| openstackgerrit | Ben Swartzlander proposed openstack/manila-ui: Switch to post-versioning https://review.openstack.org/200234 | 19:52 |
| *** jwy has quit IRC | 19:54 | |
| *** jbell8 has joined #openstack-horizon | 19:55 | |
| *** jwy has joined #openstack-horizon | 19:55 | |
| *** annashen has quit IRC | 19:56 | |
| *** esp_ has joined #openstack-horizon | 19:57 | |
| *** rajatvig_ has quit IRC | 19:57 | |
| *** nzeplowi has joined #openstack-horizon | 19:59 | |
| *** varoske has joined #openstack-horizon | 19:59 | |
| *** kzaitsev_mb has quit IRC | 20:00 | |
| *** TravT_away has joined #openstack-horizon | 20:00 | |
| *** lucas___ has quit IRC | 20:00 | |
| *** tjones1 has quit IRC | 20:02 | |
| pauloewerton | tqtran, hi | 20:03 |
| tqtran | hi pauloewerton | 20:04 |
| pauloewerton | tqtran, I'm wondering whether it would be necessary to check policy rules to individually control access to action links in the new angular tables | 20:04 |
| pauloewerton | something like when you set policy_rules in a horizon tables.LinkAction class: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tables.py#L30 | 20:05 |
| *** lblanchard has quit IRC | 20:05 | |
| david-lyle | pauloewerton: yes | 20:05 |
| *** ducttape_ has quit IRC | 20:05 | |
| *** andrewbogott is now known as andrewbogott_afk | 20:05 | |
| tqtran | yes that would make sense | 20:05 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:06 | |
| tqtran | we should use to it control which action links are visible | 20:06 |
| *** ducttape_ has joined #openstack-horizon | 20:06 | |
| *** sqchen has joined #openstack-horizon | 20:07 | |
| pauloewerton | I thought so. I believe it'll be a lot of requests to the policy rest api then, right? | 20:07 |
| *** ducttape_ has quit IRC | 20:08 | |
| *** ducttape_ has joined #openstack-horizon | 20:08 | |
| *** stevemar has quit IRC | 20:08 | |
| david-lyle | yes, a batch call would be preferred, but is not implemented yet | 20:08 |
| *** robcresswell has quit IRC | 20:09 | |
| sqchen | tqtran: yes | 20:10 |
| *** tqtran has quit IRC | 20:11 | |
| *** stevemar has joined #openstack-horizon | 20:11 | |
| pauloewerton | ok, thanks | 20:11 |
| sqchen | tqtran, will try with the latest patch... | 20:12 |
| *** stevemar has quit IRC | 20:12 | |
| *** stevemar has joined #openstack-horizon | 20:12 | |
| *** tqtran has joined #openstack-horizon | 20:13 | |
| sqchen | tqtran: Karma test get passed with the latest patch. | 20:14 |
| tqtran | woot woot! | 20:14 |
| tqtran | yeah, lets get it in then | 20:14 |
| tqtran | david-lyle: btw, was a decision reached concerning the external_templates? | 20:14 |
| tqtran | i had to sort of tune out earlier | 20:14 |
| tqtran | sqchen: just waiting on the table patch to pass gate, then i'll start bugging folks | 20:15 |
| sqchen | Sure, having two karma is a mistake, I’ll corparated them into one. thoguht? | 20:15 |
| tqtran | david-lyle: if you want to take a look at it https://review.openstack.org/#/c/197373/ | 20:15 |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Set 'this' to 'vm' for source/source-help.controller https://review.openstack.org/199223 | 20:16 |
| tqtran | adds the table feature to the users panel | 20:16 |
| *** packet has joined #openstack-horizon | 20:16 | |
| tqtran | sqchen: lets keep them separate for now | 20:16 |
| *** notmars has quit IRC | 20:17 | |
| sqchen | sure. | 20:17 |
| tqtran | i think matt-borland did a good job explaning why we need to do that in the first place | 20:17 |
| sqchen | hm, ok | 20:18 |
| *** stevemar has quit IRC | 20:19 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Set 'this' to 'vm' for source/helper.controller https://review.openstack.org/199223 | 20:20 |
| *** TravT_away is now known as TravT | 20:21 | |
| *** deuce has joined #openstack-horizon | 20:21 | |
| *** stevemar has joined #openstack-horizon | 20:21 | |
| *** pamo has joined #openstack-horizon | 20:21 | |
| matt-borland | sqchen: I don't think that 2 karma runs are necessarily a mistake | 20:23 |
| ghundal_TW | david-lyle: I added something to the test section on https://wiki.openstack.org/wiki/Horizon/Reviews | 20:24 |
| sqchen | running one karma for all code could prevent regression. | 20:25 |
| david-lyle | ghundal_TW: definitely true, but more of a developer criteria, maybe we need one of those :P | 20:25 |
| david-lyle | #1 reviewers are not your QA | 20:25 |
| david-lyle | #2 have run the code | 20:25 |
| *** stevemar has quit IRC | 20:25 | |
| david-lyle | #3 have run the tests | 20:25 |
| *** jcoufal has quit IRC | 20:26 | |
| TravT | david-lyle: I'd like to add a section onto there regarding user experience. | 20:26 |
| ghundal_TW | david-lyle: Yes, sometime it's taken for granted that the code has been run and that the reviewers are QA.. :) | 20:26 |
| tqtran | matt-borland: what was the reason for having 2 karma.conf again matt-borland? i remember there was a good reason, just cant remember what :P | 20:26 |
| *** pamo has quit IRC | 20:27 | |
| ghundal_TW | TravT: Totally - how about page or action or request has to return or display or render context in X number of seconds too.. :) | 20:27 |
| david-lyle | tqtran: more is mo' better | 20:27 |
| tqtran | got it, make sense | 20:27 |
| david-lyle | ghundal_TW: nothing will pass that | 20:27 |
| TravT | david-lyle: we need to say that if approved mockups exist, that the output should follow them | 20:27 |
| * david-lyle wishes he was kidding | 20:28 | |
| TravT | and if not, some explanation | 20:28 |
| *** gyee has joined #openstack-horizon | 20:28 | |
| david-lyle | TravT: maybe something more general about patch actually addressing the bp or bug | 20:28 |
| david-lyle | as the mock should be part of the bp | 20:28 |
| TravT | ok, but a simple statement to remind them to look at mocks if they exist on the BP should be good as well. | 20:29 |
| david-lyle | sure | 20:31 |
| *** annashen has joined #openstack-horizon | 20:31 | |
| nzeplowi | tqtran: The use of the 'vm' instead of 'ctrl' in angular is suggested by JP but enforced by the eslint tool. If we don't think this is a valuable rule we can change the eslint file to not incorporate the rule. | 20:31 |
| nzeplowi | the only reason it is there is to keep a standardization between files. If we keep using 'ctrl' we need to make it known to the community that this is the convention. | 20:32 |
| ghundal_TW | david-lyle: there should be some criteria. At least to help establish a baseline so that during builds, if performance numbers are increasing drastically, it be an issue with the algorithm used. | 20:32 |
| TravT | nzeplowi: i kind of hate the vm... just because VM is a very often used in the context of cloud. | 20:33 |
| *** neelashah has joined #openstack-horizon | 20:33 | |
| david-lyle | ghundal_TW: our biggest performance issue is the API calls made to populate the page | 20:33 |
| tqtran | nzeplowi: sigh.... fine | 20:33 |
| ghundal_TW | david-lyle: it could be an issue with the algorithm used. | 20:33 |
| david-lyle | depending on deployment some API calls can take on the order of seconds | 20:34 |
| tqtran | nzeplowi: again, i dont have a strong preference, but when we're dictating how code is written at that level of detail, it becomes code tyranny | 20:34 |
| nzeplowi | tqtran: I agree I have traditionally used 'self' in that position. But I think it might be a necessary evil of using eslint to enforce conventions. | 20:34 |
| david-lyle | ghundal_TW: with django content, we can't address that very well as the page is rendered server side | 20:34 |
| david-lyle | with angular content we can do better | 20:34 |
| david-lyle | devstack is terrible for predicting actual performance numbers | 20:35 |
| nzeplowi | tqtran: Again if this feels like code tyranny we can turn off the rules that don't lint out errors or bad smells and that are too strong. | 20:35 |
| * david-lyle has to step away for a minute | 20:35 | |
| tqtran | TravT, r1chardj0n3s, clu_, david-lyle, lhcheng: what are your take on this? code tyranny or ok with vm? | 20:36 |
| TravT | i have to read up a bit... too many things going on at once | 20:36 |
| ghundal_TW | david-lyle: So lets say for example, right now api FOO takes 10 seconds. That is a baseline we use, then some after some changeset it goes to 20 seconds. It could be just a new feature was added and well it's going to take that extra amount of time. But instead, lets say that the api isn't caching data from some backend, so adding caching speeds it up. If there are tests that radiate the difference in performance fro | 20:36 |
| *** ongk has quit IRC | 20:37 | |
| ghundal_TW | david-lyle: If you want to continue this conversation just shoot me an email, we can wrestle with it, and then come back to present it to the larger community | 20:37 |
| ghundal_TW | anyways, I'm out.. see y'all tomorrow! | 20:37 |
| tqtran | ghundal_TW: i dont think its that simple. did the performence decrease come from the api or the new feature? and it really depends on your system's load as well | 20:37 |
| *** deuce has left #openstack-horizon | 20:38 | |
| tqtran | the best you can do is get an average over a few thousand runs, but that is probably not something we can afford to do | 20:38 |
| *** gyee has quit IRC | 20:38 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Fix eslint errors about ng-di on the cloud-services. https://review.openstack.org/198840 | 20:39 |
| ghundal_TW | tqtran: I just used a simple example, but I've been on projects where we have done this and been very useful.. :) | 20:39 |
| ghundal_TW | anyways.. ciao | 20:39 |
| tqtran | ghundal_TW catch you later | 20:40 |
| *** ghundal_TW has quit IRC | 20:41 | |
| *** gyee has joined #openstack-horizon | 20:41 | |
| *** nlahouti has joined #openstack-horizon | 20:42 | |
| TravT | tqtran: matt-borland: david-lyle: We have to resolve the webroot problem. | 20:42 |
| *** e0ne has quit IRC | 20:42 | |
| TravT | as FYI, this is now biting other people | 20:42 |
| echozdog | That'd be me :) | 20:42 |
| tqtran | yeah, lets get it over with | 20:42 |
| TravT | I've been trying to help out echozdog with his company's stuff on the side for a few days | 20:42 |
| TravT | and we just debugged it down to webroot | 20:43 |
| matt-borland | TravT: agreed! | 20:43 |
| TravT | https://review.openstack.org/#/c/181095/ | 20:43 |
| tqtran | ok, cool i was about to verify that we were talking about the same patch | 20:43 |
| echozdog | Do you have a solution for Liberty? Can it back ported to Kilo? | 20:43 |
| echozdog | ah | 20:43 |
| *** wmlynch has quit IRC | 20:44 | |
| TravT | i don't believe that this can be directly backported to Kilo, I think we can apply same pattern to Kilo. | 20:44 |
| tqtran | ok, so there are are things discussed there. | 20:44 |
| tqtran | what is the main issue? | 20:45 |
| TravT | main issue is that it doesn't work and this patch fixes it. | 20:45 |
| tqtran | whether we want to use it vs static_url? | 20:45 |
| TravT | :P | 20:45 |
| tqtran | well, thats not an issue then right? lol | 20:45 |
| tqtran | i guess whats the reservation? | 20:46 |
| echozdog | the auser auth on the API calls doesn't work with a webroot other than / as I understand the problem | 20:46 |
| TravT | main issue that I'm aware of is your interest in this COMPRESS_OFFLINE_CONTEXT thing | 20:46 |
| tqtran | i already stated mine, which is the incorporation of WEBROOT as oppose to hacking the STATIC_URL | 20:46 |
| TravT | but matt-borland saying you guys couldn't get that to work, but if it did it would take more user configuration and documentation | 20:47 |
| tqtran | let me try and get it to work, don't see why it doesn't | 20:47 |
| tqtran | i just totally got caught up in other things | 20:47 |
| TravT | dang it... i just had a service person show up at my door to do something. bbiab | 20:47 |
| tqtran | let me take another stab at it | 20:48 |
| *** pamo has joined #openstack-horizon | 20:48 | |
| *** jtriley has quit IRC | 20:49 | |
| *** tjones1 has joined #openstack-horizon | 20:49 | |
| matt-borland | tqtran: go for it, I'd be interested in the results...it just didn't work when we tried it | 20:49 |
| tqtran | hip hip HOORRAY! my table patch finally passed | 20:50 |
| *** Sukhdev has quit IRC | 20:50 | |
| tqtran | ok, NOW im going to take a stab at it lol | 20:50 |
| *** Longgeek has joined #openstack-horizon | 20:50 | |
| *** tjones1 has quit IRC | 20:54 | |
| *** lucas__ has joined #openstack-horizon | 20:55 | |
| *** Longgeek has quit IRC | 20:55 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add keystone version to REST API https://review.openstack.org/200261 | 20:56 |
| *** jtriley has joined #openstack-horizon | 20:57 | |
| *** pamo has quit IRC | 20:57 | |
| *** julim has quit IRC | 20:57 | |
| *** Miouge has quit IRC | 20:58 | |
| *** tjones1 has joined #openstack-horizon | 20:59 | |
| *** packet has quit IRC | 21:01 | |
| *** pamo has joined #openstack-horizon | 21:02 | |
| *** lucas__ has quit IRC | 21:03 | |
| *** andrewbogott_afk is now known as andrewbogott | 21:05 | |
| pauloewerton | doug-fish, hi | 21:05 |
| doug-fish | hi pauloewerton | 21:05 |
| *** tjones1 has quit IRC | 21:05 | |
| pauloewerton | I've been trying to test https://review.openstack.org/#/c/159910/ | 21:05 |
| pauloewerton | kind of updating the calls according to https://review.openstack.org/#/c/159910/ | 21:06 |
| *** crobertsrh is now known as _crobertsrh | 21:06 | |
| pauloewerton | sorry, wrong link: https://review.openstack.org/#/c/160851/ | 21:06 |
| *** tjones1 has joined #openstack-horizon | 21:07 | |
| pauloewerton | I've reached a point where there's two, apparently incompatible, versions of AccessInfo objects | 21:07 |
| *** ongk has joined #openstack-horizon | 21:07 | |
| doug-fish | oh? | 21:07 |
| doug-fish | you mean like v3.Token/v3.Password objects? | 21:08 |
| pauloewerton | It seems that we would really have to use the version in keystoneauth1: https://github.com/openstack/django_openstack_auth/blob/master/openstack_auth/user.py#L63 because it includes the sp auth url needed for remote authentication | 21:08 |
| pauloewerton | yes | 21:08 |
| openstackgerrit | Merged openstack/horizon: Fix eslint errors on the login controller https://review.openstack.org/198148 | 21:08 |
| pauloewerton | sorry wrong link again | 21:09 |
| doug-fish | I haven't thought all of the way through that, but I think that d_o_a will need to be updated to use the new keystoneauth1 objects | 21:09 |
| pauloewerton | that is code that breaks if we use the version in keystoneauth1 | 21:09 |
| pauloewerton | due to references to info that are not properly handled (domain id etc.) | 21:10 |
| *** lucas__ has joined #openstack-horizon | 21:10 | |
| *** jtriley has quit IRC | 21:10 | |
| doug-fish | yeah ... so again, I haven't thought all of the way through it, but I think all of our references should be updated to use the keystoneauth1 objects instead of the python-keystoneclient ones (which are getting deprecated) | 21:11 |
| tqtran | david-lyle: how are we passing context to the base.html? | 21:11 |
| *** lucas___ has joined #openstack-horizon | 21:11 | |
| ducttape_ | it's part of normal django view / templating stuff | 21:11 |
| doug-fish | pauloewerton: that's probably a good patch to make a prereq for the k2k patch | 21:11 |
| ducttape_ | tqtran - you mean in the get_context() methods??? passing variables that templates can muck with? | 21:12 |
| pauloewerton | doug-fish, yeah, I thought so | 21:12 |
| tqtran | ducttape_: not really sure what i want exactly, but i want access to the base.html's get_context | 21:13 |
| tqtran | which might not exist since each page is a view with its on context | 21:13 |
| tqtran | basically, trying to find a superclass where i can inject a context that would be globally accessible by all pages that extend base.html | 21:13 |
| doug-fish | pauloewerton: are you going to work that one? I'm taking another day off tomorrow, but I'd be happy to review it on Monday if you have code ready. :-D | 21:14 |
| ducttape_ | tqtran - there is a common super class most classes are extending from. you could place some common info in there | 21:14 |
| tqtran | right, do you know what this common super class is? | 21:14 |
| tqtran | i did a search and it looks like table has its own, tabs, etc.... | 21:14 |
| *** lucas__ has quit IRC | 21:14 | |
| ducttape_ | https://github.com/openstack/horizon/blob/master/horizon/views.py | 21:15 |
| pauloewerton | doug-fish, not sure if I can tackle it right now, but I'll try to start it out | 21:15 |
| doug-fish | pauloewerton: part of my concern about updating the auth objects is that I haven't sorted out if it is contained to d_o_a or if it's going to leak into Horizon. | 21:15 |
| ducttape_ | the pagetitlemixin would be one spot you could use tqtran, but I'd try HorizonTemplateView first | 21:15 |
| *** lucas___ has quit IRC | 21:15 | |
| pauloewerton | doug-fish, I see | 21:16 |
| tqtran | ducttape_: ok while we're at it, let me get to the real meat lol | 21:16 |
| *** petertr7 is now known as petertr7_away | 21:17 | |
| tqtran | STATIC_URL isn't pass in as a context, it seems like Django internally does this for you | 21:17 |
| ducttape_ | yep, some stuff is "just there" like the request etc | 21:17 |
| tqtran | I'm attempting to do the same with WEBROOT, which is why I asked. Do you know if this is the case or is it via a different mechanism? | 21:17 |
| *** lucas__ has joined #openstack-horizon | 21:18 | |
| *** cbader has quit IRC | 21:18 | |
| tqtran | i guess base answer is to look at the django source via github :P | 21:18 |
| tqtran | *best answer | 21:18 |
| ducttape_ | WEBROOT - that I think is a horizon'ism | 21:18 |
| ducttape_ | and as such, it's up to us / you to place it into context | 21:19 |
| doug-fish | WEBROOT is certainly a horizon'ism | 21:19 |
| tqtran | oh is it? lol omg... ok | 21:19 |
| ducttape_ | just placing all the config variables into the context would be a horrible idea, on django's part | 21:19 |
| tqtran | in THAT case, yeah, it needs to get pass in as context then | 21:19 |
| tqtran | well, i figured since they had STATIC_URL, WEBROOT would make sense? | 21:19 |
| doug-fish | https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L45 is the origin | 21:19 |
| tqtran | right, but i assumed that webroot was also a "key" setting | 21:20 |
| tqtran | ok that makes a lot of sense now, thanks guys | 21:20 |
| ducttape_ | https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-simple/ | 21:20 |
| *** notmars has joined #openstack-horizon | 21:21 | |
| ducttape_ | think of it this way - WEBROOT is something we have invented..... and if django placed all our configs into context, then stuff like DB_PASSWORD, DB_URL etc / whatever would also be there | 21:21 |
| ducttape_ | and that's a terrible idea | 21:21 |
| ducttape_ | so it's up to you / us to place stuff in there we need / want to use | 21:22 |
| *** lucas__ has quit IRC | 21:22 | |
| tqtran | right, i understand that part. i just thought that WEBROOT was a django setting | 21:23 |
| tqtran | wasnt aware that it was a horizon thing | 21:23 |
| *** annashen has quit IRC | 21:26 | |
| tqtran | matt-borland: got a minute to hangout? | 21:27 |
| tqtran | i got the solution | 21:27 |
| *** annashen has joined #openstack-horizon | 21:27 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create app/core directory https://review.openstack.org/197310 | 21:28 |
| *** dsneddon is now known as dsneddon_away | 21:29 | |
| *** neelashah has quit IRC | 21:29 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create app/core directory https://review.openstack.org/197310 | 21:30 |
| *** lucas__ has joined #openstack-horizon | 21:30 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Create app/core directory https://review.openstack.org/197310 | 21:32 |
| *** gyee has quit IRC | 21:34 | |
| *** kbrown has quit IRC | 21:35 | |
| *** lucas__ has quit IRC | 21:35 | |
| *** jmolo has quit IRC | 21:36 | |
| *** kbrown has joined #openstack-horizon | 21:36 | |
| *** jamielennox is now known as jamielennox|away | 21:37 | |
| *** peristeri has quit IRC | 21:38 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity Projects Table https://review.openstack.org/199567 | 21:39 |
| matt-borland | tqtran: sorry, I missed your ping! I see your review notes and will get that going. | 21:39 |
| *** fnordahl has quit IRC | 21:39 | |
| tqtran | matt-borland: i can upload the patch for you if you want | 21:40 |
| tqtran | but up to you | 21:40 |
| matt-borland | go for it! :) | 21:40 |
| tqtran | ok, doing it right now | 21:40 |
| matt-borland | thx | 21:40 |
| matt-borland | ya learn something every day | 21:40 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 21:41 |
| tqtran | ok done! | 21:41 |
| *** gyee has joined #openstack-horizon | 21:41 | |
| *** fnordahl has joined #openstack-horizon | 21:41 | |
| matt-borland | thx again! | 21:41 |
| tqtran | np | 21:41 |
| tqtran | i think for this patch, we should have more than 2 cores review it | 21:42 |
| tqtran | just to be on the safe side | 21:42 |
| *** jmolo has joined #openstack-horizon | 21:42 | |
| tqtran | the more reviewers we can get on it, the better | 21:42 |
| tqtran | ducttape_: ^---\ | 21:42 |
| tqtran | :) | 21:42 |
| *** dboik has quit IRC | 21:43 | |
| sqchen | tqtran, thx for your help on webroon, one question... | 21:44 |
| tqtran | sure thing | 21:44 |
| sqchen | do we still need our change in https://review.openstack.org/#/c/181095/40/openstack_dashboard/templates/horizon/_scripts.html | 21:45 |
| sqchen | oh yes, nmd | 21:45 |
| sqchen | :) | 21:45 |
| *** jbell8 has quit IRC | 21:45 | |
| *** echozdog has quit IRC | 21:45 | |
| tqtran | i just did a search for STATIC_URL, apparently only use in one place lol. I'll amend a patch to remove STATIC_URL from client-side | 21:45 |
| sqchen | TravT: ping | 21:45 |
| *** echozdog has joined #openstack-horizon | 21:46 | |
| sqchen | tqtran: sure. | 21:46 |
| *** pauloewerton has quit IRC | 21:46 | |
| david-lyle | tqtran: static and other built-ins come from context processors | 21:47 |
| david-lyle | was away | 21:47 |
| *** nlahouti has quit IRC | 21:47 | |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L114 | 21:47 |
| david-lyle | is where those are set up | 21:47 |
| david-lyle | horizon has its own | 21:48 |
| david-lyle | as does openstack_dashboard | 21:48 |
| *** jamielennox|away is now known as jamielennox | 21:48 | |
| *** lhcheng has quit IRC | 21:49 | |
| *** lhcheng has joined #openstack-horizon | 21:49 | |
| david-lyle | tqtran, why not just override the static context processor? | 21:49 |
| david-lyle | because you're worried about JS | 21:50 |
| david-lyle | at least in the patch | 21:50 |
| david-lyle | nevermind | 21:50 |
| david-lyle | piecing together scroll back and patch | 21:50 |
| *** Sukhdev has joined #openstack-horizon | 21:51 | |
| tqtran | hm.... that could work as well..... | 21:51 |
| *** Longgeek has joined #openstack-horizon | 21:51 | |
| tqtran | iono, which do you think is the better way to go about this? | 21:51 |
| david-lyle | need to look more closely at patch | 21:51 |
| tqtran | looks like both should work, just different point of injection | 21:52 |
| david-lyle | I'm not sure HorizonTemplateView is general enough | 21:53 |
| david-lyle | what about HorizonFormView for instance? | 21:53 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 21:54 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 21:54 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move cloud-services into app/core https://review.openstack.org/197334 | 21:54 |
| david-lyle | I don't think you're using it in the angular views | 21:54 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move cloud-services into app/core https://review.openstack.org/197334 | 21:54 |
| *** notmars has quit IRC | 21:55 | |
| tqtran | well, right now the base stuff still inherit from base.html | 21:55 |
| david-lyle | but how would WEBROOT be defined in those cases? | 21:55 |
| tqtran | so there is that reliance on HorizonTemplateView, but that might change | 21:55 |
| david-lyle | forms won't use that | 21:56 |
| tqtran | so the context_processor gets injected into any views that makes a request? | 21:56 |
| *** dboik has joined #openstack-horizon | 21:56 | |
| tqtran | right, form wouldnt | 21:56 |
| tqtran | ok, seems like context processor is better way to go | 21:56 |
| david-lyle | well it creates the context for any views requested | 21:56 |
| *** mpavlase has quit IRC | 21:56 | |
| david-lyle | tqtran: that's what it's there for | 21:57 |
| tqtran | right, that was my question, poorly worded lol | 21:57 |
| tqtran | ok, i'll update the change | 21:57 |
| *** dboik has quit IRC | 21:57 | |
| david-lyle | tqtran: so two ways to update | 21:57 |
| david-lyle | either override the static context processor, which is not really necessary | 21:58 |
| david-lyle | or add it to the openstack_dashboard context_processor.py | 21:58 |
| tqtran | i prefer the openstack_dashboard context_processor | 21:58 |
| *** nlahouti has joined #openstack-horizon | 21:58 | |
| *** neillc_away is now known as neillc | 21:58 | |
| david-lyle | and I guess in the horizon one too | 21:58 |
| tqtran | we're mainly using this for client-side stuff, pertains to dashboard stuf only atm | 21:58 |
| tqtran | not sure we need it for horizon | 21:58 |
| david-lyle | so no js on the horizon side with hardcoded links to /static? | 21:59 |
| tqtran | since horizon only provies the widgets, which doesnt need to care about pathing | 21:59 |
| tqtran | yeah, there shouldnt be any lol | 21:59 |
| david-lyle | or just none that we've found? | 21:59 |
| tqtran | if there is one, its sort of wrong and violates the entire library premise | 21:59 |
| david-lyle | tqtran: do me a favor | 22:00 |
| david-lyle | got to horizon/horizon/static and type 'rgrep static' | 22:00 |
| tqtran | i just recently did a search for static_url on client-side, there is only one place that uses it horizon.table.js | 22:00 |
| david-lyle | I see 2 or 3 hardcoded constants | 22:01 |
| matt-borland | sorry, I've been in another conversation | 22:01 |
| david-lyle | using '/static/framework/ | 22:01 |
| tqtran | and that file really belongs in dashboard, not horizon, but its legacy so....... anyway messy | 22:01 |
| david-lyle | make that 4 | 22:01 |
| *** amotoki has quit IRC | 22:02 | |
| david-lyle | doesn't remove the need to update /static to webroot/static | 22:02 |
| david-lyle | whether it should be there or not, it is | 22:02 |
| tqtran | hm... you're right | 22:02 |
| tqtran | ok so it needs to go into static processor then | 22:02 |
| david-lyle | tqtran: let me think for a sec | 22:04 |
| tqtran | i'm still not entirely sure why client-side need webroot at all? isn't it just relative? | 22:04 |
| tqtran | all we're really saying is, there is a static folder relatively to whatever url you have right now | 22:04 |
| matt-borland | tqtran: sadly, it's not relative | 22:05 |
| tqtran | so... why doesnt clientside care> | 22:05 |
| *** jtriley has joined #openstack-horizon | 22:07 | |
| matt-borland | I guess I'm missing the question...what am I missing? | 22:07 |
| matt-borland | It seems there are a few questions: 1) does your patch correctly work for "all" conditions, | 22:07 |
| *** varoske has quit IRC | 22:07 | |
| matt-borland | 2) are there conditions that are not met by the general patch for WEBROOT fixing? | 22:08 |
| david-lyle | tqtran: I think you are fine just adding it to openstack_dashboard/context_processor.py | 22:08 |
| david-lyle | leaving the change in _scripts.html | 22:08 |
| matt-borland | cool, we can at least test with that going forward and see if there are any current exceptions/problems | 22:08 |
| david-lyle | but updating the js files in horizon/horizon/static to honor the value | 22:09 |
| matt-borland | thanks david-lyle for looking into that | 22:09 |
| *** varoske has joined #openstack-horizon | 22:09 | |
| *** Longgeek has quit IRC | 22:10 | |
| *** pamo has quit IRC | 22:11 | |
| TravT | tqtran matt-borland... back now... | 22:11 |
| TravT | so, we should expect another patch from tqtran? | 22:12 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move workflow into app/core https://review.openstack.org/197347 | 22:12 |
| david-lyle | yes | 22:14 |
| *** jingjing_ren has quit IRC | 22:14 | |
| david-lyle | TravT: | 22:14 |
| *** jingjin__ has joined #openstack-horizon | 22:14 | |
| david-lyle | or someone | 22:14 |
| TravT | ? | 22:14 |
| tqtran | yeah | 22:15 |
| david-lyle | about the new patch | 22:15 |
| tqtran | sorry, clu_ stopped by | 22:15 |
| david-lyle | simple update | 22:15 |
| tqtran | we went to get our free coffee | 22:15 |
| tqtran | i'll update now | 22:15 |
| tqtran | wait one sec, ok, so we're leaving static_url alone? and just adding webroot right? | 22:15 |
| tqtran | and we're adding this to the dashboard context processor | 22:16 |
| david-lyle | yes | 22:16 |
| david-lyle | static_url is prepended with webroot | 22:16 |
| david-lyle | already | 22:17 |
| david-lyle | wait so why not pass static url to js? | 22:17 |
| david-lyle | so confused | 22:17 |
| david-lyle | half read the patch | 22:17 |
| david-lyle | just got agitated about context processors and their under use | 22:18 |
| TravT | the static url could be fine on the js for html calls | 22:18 |
| tqtran | because js api doesn't reside in static | 22:18 |
| TravT | but not for the api calls | 22:18 |
| r1chardj0n3s | tqtran: I agree with you on that style guide issue (ctrl vs vm) and I think eslint is in the wrong (jscs didn't have this issue /me ducks) | 22:18 |
| tqtran | r1chardj0n3s: yeah, sort of becomes tyranny at that point i think | 22:19 |
| tqtran | i'd hate to get that granular | 22:19 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 22:19 |
| r1chardj0n3s | tqtran: yep | 22:20 |
| * r1chardj0n3s is sick, taking the day off. "catch y'all next week" | 22:20 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 22:20 | |
| *** jbell8 has joined #openstack-horizon | 22:21 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move tech-debt into app/ https://review.openstack.org/197353 | 22:22 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 22:24 |
| tqtran | TravT: table patch is updated as well, let me know if there's anything else. im ready to move onto the actions once the table patch lands | 22:24 |
| *** jasondotstar has quit IRC | 22:25 | |
| *** jbell8 has quit IRC | 22:25 | |
| tqtran | that should be easy review as well, since i'll be using the launch instance workflows | 22:25 |
| tqtran | well, widgets... | 22:25 |
| TravT | tqtran: just ran eslint on it... | 22:25 |
| TravT | 14 errors | 22:25 |
| tqtran | :O | 22:26 |
| TravT | 1 is the vm error | 22:26 |
| tqtran | omg.... damn vm | 22:26 |
| TravT | so, we can ignore that one... i guess... | 22:26 |
| TravT | i don't mind consistent naming | 22:26 |
| TravT | but i hate vm | 22:26 |
| tqtran | how do i run eslint on a specific folder? | 22:26 |
| TravT | way too overloaded | 22:26 |
| TravT | i put that in the paste | 22:26 |
| tqtran | yeah, ctrl or self is better | 22:26 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Dashboard ReOrg - Move tech-debt into app/ https://review.openstack.org/197353 | 22:26 |
| TravT | here you go: | 22:26 |
| TravT | npm i -g eslint | 22:26 |
| matt-borland | tqtran: TravT: my initial pass at testing Thai's WEBROOT changes is good | 22:27 |
| tqtran | ah ok, so you have a global independent version | 22:27 |
| TravT | npm i -g eslint-plugin-angular | 22:27 |
| tqtran | theres no way to do it via run_script atm | 22:27 |
| TravT | eslint openstack_dashboard/dashboards/identity/static | 22:27 |
| TravT | yeah, i'm doing it independent | 22:27 |
| nzeplowi | yeah, the vm check adds a lot of errors | 22:27 |
| TravT | maybe there's a better way | 22:27 |
| matt-borland | I don't like the vm check :) | 22:27 |
| nzeplowi | I don't think anyone does | 22:28 |
| david-lyle | more feedback on webroot patch tqtran | 22:28 |
| matt-borland | yessir | 22:28 |
| david-lyle | I'm sure you're happy to hear | 22:28 |
| tqtran | david-lyle: not sure i understand your comment | 22:29 |
| tqtran | how do i do a resolve from js? | 22:29 |
| david-lyle | you don't | 22:29 |
| david-lyle | the call is just made correctly | 22:29 |
| tqtran | ah ok | 22:30 |
| tqtran | so basically, no need for window.WEBROOT | 22:30 |
| *** matt-borland has quit IRC | 22:30 | |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tables.py#L359 is wrong | 22:30 |
| david-lyle | and lazy | 22:30 |
| david-lyle | not there, but the calls to the NG launch should do a resolve to set the launchContext | 22:31 |
| *** deuce has joined #openstack-horizon | 22:31 | |
| david-lyle | not lazy, just wrong :P | 22:31 |
| david-lyle | django is our friend here, it has nice tools to help with much of this | 22:32 |
| tqtran | ok, but not within scope of this patch, file it as a bug lol | 22:32 |
| david-lyle | well, if you're fixing webroot, you'll have to fix that | 22:32 |
| tqtran | GAH | 22:32 |
| david-lyle | otherwise the return link is busted | 22:32 |
| tqtran | ok | 22:32 |
| david-lyle | err redirect link | 22:32 |
| david-lyle | dashboards/project/images/images/tables.py needs to be fixed too | 22:34 |
| tqtran | i might need to lint this code as well | 22:34 |
| nzeplowi | Just found that we can specify what the variable we check for in eslint. We can change it to check that the var is set to ctrl instead of vm | 22:34 |
| *** jpomero has quit IRC | 22:34 | |
| tqtran | nzeplowi: cool, that would be a good move | 22:37 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 22:37 |
| david-lyle | tqtran: updated with 3 locations to fix | 22:38 |
| tjones1 | @david-lyle ^^ i addressed your comments about the docs (i think) | 22:38 |
| *** pamo has joined #openstack-horizon | 22:38 | |
| tqtran | ok fixing now | 22:38 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add keystone version to REST API https://review.openstack.org/200261 | 22:38 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 22:39 |
| tjones1 | removed whitespace ^^ | 22:39 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Ignore the ESLINT controller as VM rule https://review.openstack.org/200297 | 22:40 |
| nzeplowi | tqtran: looking into changing it to ctrl and will report back on the results. | 22:40 |
| TravT | tqtran: nzeplowi: | 22:40 |
| TravT | i just disabled it in above patch | 22:41 |
| TravT | https://review.openstack.org/200297 | 22:41 |
| tqtran | im fine with disabling it too lol, maybe we can just disable it and softly enforce it via code review? | 22:41 |
| tqtran | but im also fine with ctrl as the standard | 22:41 |
| * david-lyle has to run | 22:41 | |
| TravT | hasta david-lyle | 22:42 |
| tqtran | david-lyle: https://docs.djangoproject.com/en/1.8/ref/urlresolvers/ this is what you mean right? | 22:42 |
| tqtran | wait.. before you go | 22:42 |
| david-lyle | tqtran: yeah that's what I meat | 22:42 |
| tqtran | ok cool | 22:42 |
| david-lyle | *meant | 22:42 |
| tqtran | just wanted to confirm | 22:42 |
| david-lyle | like elsewhere in the code base | 22:43 |
| *** jasondotstar has joined #openstack-horizon | 22:43 | |
| *** annashen has quit IRC | 22:43 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add keystone version to REST API https://review.openstack.org/200261 | 22:44 |
| *** annashen has joined #openstack-horizon | 22:44 | |
| *** jtriley has quit IRC | 22:45 | |
| *** annashen has quit IRC | 22:49 | |
| *** doug-fish has left #openstack-horizon | 22:49 | |
| *** stevemar has joined #openstack-horizon | 22:49 | |
| tqtran | gah, it looks terrible, hopefully once we have a instances panel up, we won't have to do this hackery | 22:50 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Change the ESLINT controller as to ctrl https://review.openstack.org/200297 | 22:50 |
| nzeplowi | TravT: So we can change the linter to check for ctrl instead of vm. Do you want to continue having it ignored | 22:51 |
| TravT | ok, so that changes it to look for ctrl | 22:51 |
| *** annashen has joined #openstack-horizon | 22:51 | |
| TravT | and have it warning | 22:51 |
| TravT | nzeplowi | 22:51 |
| TravT | already put that in updated patch | 22:51 |
| nzeplowi | nice just saw it | 22:51 |
| *** stevemar has quit IRC | 22:54 | |
| openstackgerrit | Tracy Jones proposed openstack/horizon: code cleanup from commits on https://review.openstack.org/#/c/195751/ https://review.openstack.org/200301 | 22:56 |
| tjones1 | pamo: david-lyle varosky ^^ cleanup code from the comments on https://review.openstack.org/#/c/195751/ | 22:57 |
| varoske | tjones1: looks good, thanks | 22:59 |
| tjones1 | varoske: thanks | 22:59 |
| *** ducttape_ has quit IRC | 22:59 | |
| *** jpomero has joined #openstack-horizon | 22:59 | |
| *** nlahouti has quit IRC | 23:00 | |
| *** nlahouti has joined #openstack-horizon | 23:02 | |
| *** nlahouti has quit IRC | 23:02 | |
| *** amotoki has joined #openstack-horizon | 23:02 | |
| *** TravT has quit IRC | 23:05 | |
| tjones1 | varoske: oops - i made a mistake on the logo-location. fixing it | 23:06 |
| *** amotoki has quit IRC | 23:07 | |
| *** TravT has joined #openstack-horizon | 23:08 | |
| *** kzaitsev_mb has quit IRC | 23:09 | |
| deuce | Can anyone here answer questions about magic-search.js? | 23:12 |
| deuce | I'm in the middle of a refactor, and am unable to make sense of some things | 23:13 |
| *** ongk has quit IRC | 23:13 | |
| *** mwhagedorn has quit IRC | 23:13 | |
| openstackgerrit | Merged openstack/horizon: Dashboard karma is missing framework files https://review.openstack.org/200207 | 23:13 |
| sqchen | TravT: ping | 23:16 |
| TravT | pong | 23:16 |
| sqchen | Hi TravT, can you take a look at https://review.openstack.org/#/c/197310, it is pretty simple, but can unblock many other things. | 23:17 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 23:19 |
| *** zhenguo has joined #openstack-horizon | 23:21 | |
| *** nlahouti has joined #openstack-horizon | 23:25 | |
| *** geoffarnold has quit IRC | 23:28 | |
| tjones1 | 5FE90047-35A5-45F1-9E85-87A08E003F28-2954-00005A336C97B3E7 | 23:29 |
| tjones1 | oops | 23:29 |
| tjones1 | sorry | 23:29 |
| openstackgerrit | Tracy Jones proposed openstack/horizon: move favicon, logo and logo-splash to default theme https://review.openstack.org/195751 | 23:33 |
| tjones1 | ok there i fixed it. I was hoping to do both of the TODO in 500.html in another patch if that is ok with you varoske | 23:34 |
| *** annashen has quit IRC | 23:34 | |
| varoske | yeah that's cool with me tjones1 :) | 23:34 |
| tjones1 | thanks | 23:36 |
| *** mgarza_ has quit IRC | 23:37 | |
| *** Longgeek has joined #openstack-horizon | 23:38 | |
| *** openstack has joined #openstack-horizon | 23:39 | |
| -cameron.freenode.net- [freenode-info] channel flooding and no channel staff around to help? Please check with freenode support: http://freenode.net/faq.shtml#gettinghelp | 23:39 | |
| *** tosky has quit IRC | 23:42 | |
| *** emilyw has quit IRC | 23:45 | |
| *** jingjin__ has quit IRC | 23:47 | |
| *** chlong has quit IRC | 23:49 | |
| *** sqchen has quit IRC | 23:49 | |
| *** yamamoto has joined #openstack-horizon | 23:49 | |
| *** yamamoto_ has joined #openstack-horizon | 23:49 | |
| *** SimonChung1 has joined #openstack-horizon | 23:50 | |
| *** SimonChung has quit IRC | 23:50 | |
| *** Sukhdev has quit IRC | 23:51 | |
| *** yamamoto_ has quit IRC | 23:52 | |
| *** Longgeek has quit IRC | 23:52 | |
| *** Sukhdev has joined #openstack-horizon | 23:52 | |
| *** kbrown has quit IRC | 23:53 | |
| *** yamamoto has quit IRC | 23:53 | |
| *** jbell8 has joined #openstack-horizon | 23:55 | |
| *** ongk has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!