| *** logan2 has quit IRC | 00:01 | |
| *** amotoki has joined #openstack-horizon | 00:03 | |
| *** logan2 has joined #openstack-horizon | 00:08 | |
| *** lhcheng has quit IRC | 00:11 | |
| *** geoffarnold has joined #openstack-horizon | 00:16 | |
| *** jcoufal has quit IRC | 00:22 | |
| *** esp_ has quit IRC | 00:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:25 | |
| *** cody-somerville has quit IRC | 00:40 | |
| *** raildo_ has joined #openstack-horizon | 00:44 | |
| *** zhenguo has joined #openstack-horizon | 00:49 | |
| *** ducttape_ has joined #openstack-horizon | 00:50 | |
| *** kzaitsev_mb has quit IRC | 00:50 | |
| *** openstackgerrit has quit IRC | 00:51 | |
| *** openstackgerrit has joined #openstack-horizon | 00:52 | |
| *** raildo_ has quit IRC | 01:08 | |
| *** ericksonsantos has quit IRC | 01:09 | |
| *** pauloewerton has quit IRC | 01:09 | |
| *** raildo has quit IRC | 01:10 | |
| *** nzeplowi has joined #openstack-horizon | 01:13 | |
| *** lucas__ has joined #openstack-horizon | 01:22 | |
| *** ducttape_ has quit IRC | 01:26 | |
| *** lucas__ has quit IRC | 01:28 | |
| *** yingjun has joined #openstack-horizon | 01:28 | |
| *** geoffarnold has quit IRC | 01:34 | |
| *** geoffarnold has joined #openstack-horizon | 01:38 | |
| *** geoffarnold has quit IRC | 01:42 | |
| *** nzeplowi has quit IRC | 01:47 | |
| *** lucas__ has joined #openstack-horizon | 01:48 | |
| *** yamamoto has joined #openstack-horizon | 01:49 | |
| *** lucas__ has quit IRC | 01:50 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Use form field errors on volume Extend form https://review.openstack.org/200158 | 01:56 |
|---|---|---|
| *** lhcheng has joined #openstack-horizon | 01:59 | |
| *** lhcheng has quit IRC | 02:04 | |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix CSS GET None when mouse over the table cell https://review.openstack.org/199923 | 02:05 |
| *** DCWilliams_VA has joined #openstack-horizon | 02:08 | |
| *** DCWilliams_VA has quit IRC | 02:08 | |
| *** esp has joined #openstack-horizon | 02:22 | |
| *** pamo has joined #openstack-horizon | 02:22 | |
| *** btully has joined #openstack-horizon | 02:25 | |
| *** btully has quit IRC | 02:30 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:43 | |
| *** kzaitsev_mb has quit IRC | 02:48 | |
| *** nzeplowi has joined #openstack-horizon | 03:03 | |
| *** r1chardj0n3s has quit IRC | 03:09 | |
| *** r1chardj0n3s has joined #openstack-horizon | 03:10 | |
| *** pamo has quit IRC | 03:17 | |
| *** pamo has joined #openstack-horizon | 03:18 | |
| *** lucas__ has joined #openstack-horizon | 03:21 | |
| *** lyanchih has joined #openstack-horizon | 03:28 | |
| lyanchih | guys plz help me to review this https://review.openstack.org/#/c/199457/ | 03:29 |
| *** kevinbenton has quit IRC | 03:35 | |
| openstackgerrit | Albert Tu proposed openstack/horizon: Add i18n support to Angular humanizeNumbers helper https://review.openstack.org/199997 | 03:37 |
| *** lhcheng has joined #openstack-horizon | 03:48 | |
| *** lhcheng has quit IRC | 03:53 | |
| *** yamamoto has quit IRC | 03:54 | |
| *** yingjun has quit IRC | 03:55 | |
| *** lucas__ has quit IRC | 03:59 | |
| *** lyanchih has quit IRC | 04:05 | |
| *** btully has joined #openstack-horizon | 04:08 | |
| *** nzeplowi has quit IRC | 04:12 | |
| *** lhcheng has joined #openstack-horizon | 04:13 | |
| *** kevinbenton has joined #openstack-horizon | 04:14 | |
| *** nzeplowi has joined #openstack-horizon | 04:14 | |
| *** neelashah has joined #openstack-horizon | 04:15 | |
| *** lhcheng has quit IRC | 04:17 | |
| *** liangbo has joined #openstack-horizon | 04:20 | |
| *** yamamoto has joined #openstack-horizon | 04:22 | |
| *** liangbo has quit IRC | 04:26 | |
| *** liangbo has joined #openstack-horizon | 04:27 | |
| *** neelashah has quit IRC | 04:32 | |
| *** yingjun has joined #openstack-horizon | 04:46 | |
| *** kevinbenton has quit IRC | 04:53 | |
| *** amotoki_ has joined #openstack-horizon | 04:53 | |
| *** kevinbenton has joined #openstack-horizon | 04:59 | |
| *** tqtran-bot has joined #openstack-horizon | 05:01 | |
| *** tqtran-bot has quit IRC | 05:03 | |
| *** pamo has quit IRC | 05:06 | |
| *** pcaruana has quit IRC | 05:08 | |
| *** masco__ has joined #openstack-horizon | 05:10 | |
| *** tjones1 has joined #openstack-horizon | 05:13 | |
| *** tjones1 has left #openstack-horizon | 05:13 | |
| *** pamo has joined #openstack-horizon | 05:18 | |
| *** Longgeek has quit IRC | 05:18 | |
| *** Longgeek has joined #openstack-horizon | 05:20 | |
| *** nzeplowi has quit IRC | 05:23 | |
| *** amotoki_ has quit IRC | 05:39 | |
| *** lyanchih has joined #openstack-horizon | 05:55 | |
| *** juggler_ has joined #openstack-horizon | 06:09 | |
| *** mrunge has joined #openstack-horizon | 06:10 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/200793 | 06:10 |
| *** juggler has quit IRC | 06:12 | |
| *** rwsu has joined #openstack-horizon | 06:14 | |
| *** rwsu has quit IRC | 06:16 | |
| *** pamo has quit IRC | 06:19 | |
| *** btully has quit IRC | 06:32 | |
| *** psanchez_ has joined #openstack-horizon | 06:41 | |
| *** lhcheng has joined #openstack-horizon | 06:41 | |
| *** pcaruana has joined #openstack-horizon | 06:42 | |
| *** amotoki_ has joined #openstack-horizon | 06:43 | |
| *** yingjun has quit IRC | 06:45 | |
| *** yamamoto has quit IRC | 06:57 | |
| *** yamamoto has joined #openstack-horizon | 06:59 | |
| *** markus_z has joined #openstack-horizon | 07:09 | |
| *** rdopiera has joined #openstack-horizon | 07:10 | |
| *** masco__ has quit IRC | 07:10 | |
| *** Ala has joined #openstack-horizon | 07:11 | |
| *** psanchez_ has quit IRC | 07:12 | |
| *** lyanchih has quit IRC | 07:20 | |
| *** lyanchih has joined #openstack-horizon | 07:23 | |
| *** masco__ has joined #openstack-horizon | 07:24 | |
| *** markus_z has quit IRC | 07:30 | |
| *** chlong-weekend is now known as chlong-afk | 07:33 | |
| *** markus_z has joined #openstack-horizon | 07:33 | |
| *** btully has joined #openstack-horizon | 07:34 | |
| *** btully has quit IRC | 07:38 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Include angular rules in eslint https://review.openstack.org/201027 | 07:39 |
| *** rajatvig has joined #openstack-horizon | 07:42 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Include angular rules in eslint https://review.openstack.org/201027 | 07:52 |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:52 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Include angular plugin for auth js https://review.openstack.org/201027 | 07:56 |
| *** katyafervent_awa is now known as katyafervent | 07:57 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Include angular plugin for auth js https://review.openstack.org/201027 | 07:59 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Include angular plugin for auth js https://review.openstack.org/201027 | 08:03 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - rename vm as ctrl for login controller https://review.openstack.org/201032 | 08:03 |
| *** rajatvig has quit IRC | 08:04 | |
| *** rajatvig has joined #openstack-horizon | 08:04 | |
| *** rajatvig has quit IRC | 08:09 | |
| *** pamo has joined #openstack-horizon | 08:15 | |
| *** zz_ttrifonov is now known as ttrifonov | 08:18 | |
| *** ygbo has joined #openstack-horizon | 08:19 | |
| *** pamo has quit IRC | 08:20 | |
| *** nzeplowi has joined #openstack-horizon | 08:24 | |
| *** DaveJ__ has joined #openstack-horizon | 08:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:26 | |
| *** nzeplowi has quit IRC | 08:28 | |
| *** JeanBriceCombebi has quit IRC | 08:34 | |
| openstackgerrit | ziyu032 proposed openstack/horizon: make cancel button a unified style https://review.openstack.org/150686 | 08:35 |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:35 | |
| *** robcresswell has joined #openstack-horizon | 08:41 | |
| *** amotoki_ has quit IRC | 08:46 | |
| *** jamielennox has quit IRC | 08:46 | |
| *** masco__ has quit IRC | 08:48 | |
| *** kzaitsev_mb has quit IRC | 08:50 | |
| *** JeanBriceCombebi has quit IRC | 08:55 | |
| *** lhcheng has quit IRC | 08:55 | |
| *** bfic has joined #openstack-horizon | 08:55 | |
| *** masco__ has joined #openstack-horizon | 09:00 | |
| *** KingKhan has joined #openstack-horizon | 09:02 | |
| *** yingjun has joined #openstack-horizon | 09:03 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:06 | |
| *** sambetts_ is now known as sambetts | 09:07 | |
| *** aix has joined #openstack-horizon | 09:08 | |
| *** tosky has joined #openstack-horizon | 09:14 | |
| *** e0ne has joined #openstack-horizon | 09:19 | |
| robcresswell | sambetts: o/ | 09:24 |
| sambetts | robcresswell: o/ | 09:26 |
| *** lhcheng has joined #openstack-horizon | 09:32 | |
| *** pkarikh has joined #openstack-horizon | 09:34 | |
| *** yingjun has quit IRC | 09:35 | |
| *** e0ne is now known as e0ne_ | 09:36 | |
| *** liangbo has quit IRC | 09:39 | |
| *** haypo has joined #openstack-horizon | 09:40 | |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix the loading block wouldn't disappear in Mac OS X https://review.openstack.org/201057 | 09:40 |
| haypo | hi. does anyone know the status of python 3 in swift? | 09:41 |
| haypo | django now works well on python 3 ;) | 09:41 |
| haypo | horizon is the latest major openstack application with no py34 gate: https://wiki.openstack.org/wiki/Python3#OpenStack_applications | 09:41 |
| mrunge | haypo, we usually don't test horizon with py3 | 09:41 |
| mrunge | but I heard it is working | 09:42 |
| haypo | "but I heard it is working" i read "it doesn't work" :) | 09:42 |
| haypo | if it's not tested and not widely used on python 3, there are probably many subtle issues with python 3, no? | 09:42 |
| mrunge | sure | 09:43 |
| mrunge | you're right and I agree | 09:43 |
| haypo | (especially if it's not automatically tested on python3) | 09:43 |
| * mrunge asks himself, what about all those xstatic packages | 09:44 | |
| mrunge | I would expect a bit work at that front | 09:44 |
| *** jamielennox has joined #openstack-horizon | 09:46 | |
| *** oro has joined #openstack-horizon | 09:46 | |
| * haypo runs tox -e py34 | 09:49 | |
| haypo | mrunge: nice. tox -e py34 fails with SyntaxError in mox :) | 09:51 |
| mrunge | I'd say: feel free to fix it :P | 09:52 |
| haypo | mrunge: FIY i'm porting python 3 stuff in openstack since 12 months or more, so yes i can try to help | 09:53 |
| mrunge | haypo, I saw your mails on dev list. this is really appreciated | 09:54 |
| mrunge | haypo, and I really didn't try to offend you. If you felt that way, I apologize | 09:55 |
| haypo | hum? i don't feel offended | 09:55 |
| haypo | don't worry | 09:55 |
| *** akrivoka has joined #openstack-horizon | 10:00 | |
| *** alexpilotti has joined #openstack-horizon | 10:00 | |
| *** rdopiera has quit IRC | 10:03 | |
| *** e0ne_ is now known as e0ne | 10:05 | |
| *** marzif has joined #openstack-horizon | 10:07 | |
| *** lhcheng has quit IRC | 10:08 | |
| *** kjelly has quit IRC | 10:11 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:15 | |
| robcresswell | mrunge: Nice work on the mock fixes. Are there any other issues thus far? | 10:16 |
| haypo | mrunge: "83 files changed, 128 insertions(+), 124 deletions(-)" later, "tox -e py34" pass. so i'm sure that horizon doesn't work fully on python 3 in its current state ;) | 10:16 |
| robcresswell | haypo: Huh, interesting that it's so many files but such a small line count. Tiny tweaks? | 10:17 |
| *** pamo has joined #openstack-horizon | 10:17 | |
| mrunge | robcresswell, I didn't fix mock stuff. That was lhcheng | 10:17 |
| haypo | robcresswell: many small changes. i'm now splitting this stuff into reviewable patches | 10:17 |
| openstackgerrit | Matthias Runge proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 10:17 |
| robcresswell | mrunge: Oh, my bad, I just saw the backport and assumed. | 10:18 |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix the loading block wouldn't disappear in Mac OS X https://review.openstack.org/201057 | 10:18 |
| mrunge | robcresswell, sure. I just don't want to take credit for things I didn't do | 10:18 |
| mrunge | I'm trying to keep kilo in a shape, where we could do backports | 10:19 |
| robcresswell | mrunge: Yeah, I've seen them going through. Nice work. | 10:19 |
| openstackgerrit | JasonPan proposed openstack/horizon: Fix CSS GET None when mouse over the table cell https://review.openstack.org/199923 | 10:21 |
| tosky | mrunge: do you think that the fix for this bug https://bugs.launchpad.net/horizon/+bug/1456171 could be accepted as kilo backport? (https://review.openstack.org/#/c/184033/) | 10:21 |
| openstack | Launchpad bug 1456171 in OpenStack Dashboard (Horizon) "[sahara] relaunch job fail if job is created by saharaclient and no input args" [Low,Fix released] - Assigned to Ken Chen (ken-chen-i) | 10:21 |
| *** pamo has quit IRC | 10:21 | |
| mrunge | tosky, /me clicks | 10:22 |
| mrunge | tosky, sure | 10:22 |
| mrunge | tosky, makes sense to me, it's end user visible, no string change included | 10:23 |
| tosky | mrunge: I personally hit it | 10:23 |
| mrunge | tosky, are you going to propose a backport? | 10:24 |
| mrunge | or shall I? | 10:24 |
| tosky | mrunge: I was rechecking the condition (funny because I did it); I guess it's just "cherry-pick the patch to stable/kilo and push", right? | 10:24 |
| mrunge | git checkout origin/stable/kilo && git cherry-pick -x (hash...) && git review | 10:25 |
| mrunge | you might want to name the branch too | 10:25 |
| mrunge | git checkout -b bugs/foo or whatever | 10:26 |
| tosky | isn't the topic called automagically from the bug number? | 10:26 |
| mrunge | uhm, it is? | 10:26 |
| tosky | but yeah, easier to add the topic | 10:26 |
| tosky | not sure, I thought I have seen it but I could have just misread it | 10:27 |
| tosky | let's try | 10:27 |
| tosky | in the worst case I can change the topic later | 10:27 |
| mrunge | sure | 10:27 |
| tosky | mrunge: yep, I didn't set the topic, but it's the correct one (bug/<num>): https://review.openstack.org/#/c/201074/ | 10:31 |
| *** mpavlase has joined #openstack-horizon | 10:32 | |
| mrunge | cool, goo to know then tosky | 10:33 |
| *** kzaitsev_mb has quit IRC | 10:34 | |
| *** e0ne is now known as e0ne_ | 10:43 | |
| *** e0ne_ is now known as e0ne | 10:43 | |
| *** aix has quit IRC | 10:44 | |
| *** yamamoto has quit IRC | 10:44 | |
| *** sayan has joined #openstack-horizon | 10:46 | |
| *** sayan_ has joined #openstack-horizon | 10:46 | |
| *** DaveJ__ has quit IRC | 10:51 | |
| *** kzaitsev_mb has joined #openstack-horizon | 10:51 | |
| *** e0ne is now known as e0ne_ | 11:01 | |
| *** belmoreira has joined #openstack-horizon | 11:06 | |
| *** aix has joined #openstack-horizon | 11:11 | |
| *** vijendar has joined #openstack-horizon | 11:14 | |
| *** e0ne_ is now known as e0ne | 11:14 | |
| *** _crobertsrh is now known as crobertsrh | 11:18 | |
| *** bfic has quit IRC | 11:27 | |
| *** yamamoto has joined #openstack-horizon | 11:28 | |
| *** vijendar has quit IRC | 11:29 | |
| *** vijendar has joined #openstack-horizon | 11:29 | |
| *** yamamoto has quit IRC | 11:29 | |
| *** yamamoto_ has joined #openstack-horizon | 11:30 | |
| *** yamamoto has joined #openstack-horizon | 11:30 | |
| *** yamamoto has quit IRC | 11:33 | |
| *** yamamoto_ has quit IRC | 11:34 | |
| *** bfic has joined #openstack-horizon | 11:36 | |
| *** yamamoto has joined #openstack-horizon | 11:37 | |
| *** lyanchih has quit IRC | 11:37 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Refactor network topology graph as an Angular directive https://review.openstack.org/199063 | 11:40 |
| tosky | mrunge: you proposed it, it has a +2, so do we need another +2 from the 3rd stable maintainer? https://review.openstack.org/#/c/201012/ :) | 11:50 |
| *** sayan has quit IRC | 11:52 | |
| *** sayan_ has quit IRC | 11:53 | |
| *** bfic has quit IRC | 11:56 | |
| mrunge | tosky, yes | 11:56 |
| mrunge | there are not so many stable maintainers in horizon | 11:57 |
| *** bfic has joined #openstack-horizon | 12:02 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace mox with mox3 https://review.openstack.org/201095 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues in base modules https://review.openstack.org/201096 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/201097 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues on dictionaries https://review.openstack.org/201098 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Use relative imports https://review.openstack.org/201099 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Get izip from six.moves https://review.openstack.org/201100 | 12:03 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace filter() with a list-comprehension https://review.openstack.org/201101 | 12:03 |
| haypo | mrunge, robcresswell : ok, here you have my patches to fix tox -e py34 ^^ | 12:03 |
| mrunge | awesome haypo | 12:04 |
| haypo | mrunge: i hope that i splitted my changes enough to have patches easy to review | 12:04 |
| mrunge | haypo, do you know out of your head, if we already have mox3 in fedora? | 12:04 |
| haypo | it's probably not enough to port horizon to python 3, tox -e py34 says: "Ran 0 tests in 0.000s" and then "Ran 1 test in 0.007s" | 12:04 |
| haypo | whereas tox -e py27 runs +100 tests!? | 12:04 |
| mrunge | it's probably a matter of missing dependencies for those tests | 12:05 |
| *** sayan_ has joined #openstack-horizon | 12:05 | |
| *** sayan has joined #openstack-horizon | 12:06 | |
| mrunge | haypo, just found the bug report rhbz#1174974 | 12:06 |
| haypo | mrunge: hum, https://bugzilla.redhat.com/show_bug.cgi?id=1174974 is a request to add a package for mock3 in Fedora | 12:07 |
| openstack | bugzilla.redhat.com bug 1174974 in Package Review "Review Request: python-mox3 - Mock object framework for Python" [Medium,New] - Assigned to apevec | 12:07 |
| haypo | mrunge: mock3 is still heavily used in openstack, as i wrote in my commit message | 12:07 |
| haypo | it would be surprised that Ubuntu, Fedora, RHEL don't have a package for it in their OpenStack repositories | 12:08 |
| haypo | i* would | 12:10 |
| mrunge | are we talking about mox3 or about mock3? | 12:10 |
| haypo | mrunge: sorry, mox3. there is no mock3 project :) | 12:11 |
| mrunge | :D just to be clear | 12:11 |
| haypo | (but the way, mock got a new maintainer, there was a release last friday which broke all gates in openstack. funny release.) | 12:11 |
| mrunge | yupp, I know about it | 12:12 |
| haypo | (mock is the backport of unittest.mock, it's now in the python standard library) | 12:12 |
| *** pamo has joined #openstack-horizon | 12:19 | |
| *** lyanchih has joined #openstack-horizon | 12:21 | |
| *** pamo has quit IRC | 12:23 | |
| *** rdopiera has joined #openstack-horizon | 12:25 | |
| *** rdopiera_ has joined #openstack-horizon | 12:26 | |
| *** ducttape_ has joined #openstack-horizon | 12:28 | |
| *** yamamoto has quit IRC | 12:30 | |
| *** e0ne is now known as e0ne_ | 12:33 | |
| robcresswell | haypo: Right, just starting to look over. Thanks for doing this work! | 12:33 |
| haypo | robcresswell, mrunge : i plan to write an article on the progress of the openstack port to python 3. i would be a shame that there is still an application without anyone working on it | 12:34 |
| haypo | even swift started to review my patches for python 3, even swift! :-D | 12:34 |
| mrunge | I thought, swift moved to go | 12:34 |
| mrunge | *jokingÜ | 12:34 |
| haypo | mrunge: well, dropping immediatly python 2 was discussion during the latest swift meeting, but they didn't pick this option | 12:35 |
| haypo | was discussed* | 12:35 |
| haypo | ( i'm serious: https://wiki.openstack.org/wiki/Meetings/Swift ) | 12:35 |
| *** sayan_ has quit IRC | 12:35 | |
| mrunge | oh! I didn't knew that | 12:36 |
| robcresswell | haypo: Why mox 0.7.0 as base, btw? | 12:37 |
| robcresswell | and not just use 0.8 | 12:37 |
| *** mtecer has joined #openstack-horizon | 12:39 | |
| *** haypo has quit IRC | 12:40 | |
| *** haypo has joined #openstack-horizon | 12:40 | |
| *** e0ne_ is now known as e0ne | 12:46 | |
| *** ttrifonov is now known as zz_ttrifonov | 12:49 | |
| *** absubram has quit IRC | 12:50 | |
| *** ducttape_ has quit IRC | 12:50 | |
| *** mtecer has quit IRC | 12:52 | |
| haypo | robcresswell: i found https://blueprints.launchpad.net/horizon/+spec/porting-python3 | 12:55 |
| haypo | robcresswell: can i reuse this blueprint? | 12:56 |
| *** btully has joined #openstack-horizon | 12:58 | |
| *** bfic has quit IRC | 13:01 | |
| robcresswell | haypo: Yeah, that looks like a good one to link to | 13:01 |
| *** yingjun has joined #openstack-horizon | 13:01 | |
| *** julim has joined #openstack-horizon | 13:01 | |
| robcresswell | haypo: May also be worth reaching out to the owner to let him know | 13:01 |
| *** ZZelle has quit IRC | 13:02 | |
| *** btully has quit IRC | 13:02 | |
| *** ZZelle has joined #openstack-horizon | 13:02 | |
| *** julim_ has joined #openstack-horizon | 13:04 | |
| haypo | robcresswell: George Peristerakis is a colleague, i will try to find him :) | 13:04 |
| haypo | robcresswell: this morning, i asked if anyone was working on python 3, but i got no reply | 13:04 |
| haypo | cool if the work already started! | 13:04 |
| haypo | robcresswell: i also found https://review.openstack.org/#/c/178342/ which combines some of my patches, but it fixes some issues differently | 13:05 |
| *** neelashah has joined #openstack-horizon | 13:06 | |
| *** doug-fish has joined #openstack-horizon | 13:06 | |
| *** julim has quit IRC | 13:07 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace dict.iteritems() with six.iteritems(dict) https://review.openstack.org/201097 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues in base modules https://review.openstack.org/201096 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Use relative imports https://review.openstack.org/201099 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix Python 3 issues on dictionaries https://review.openstack.org/201098 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace filter() with a list-comprehension https://review.openstack.org/201101 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Get izip from six.moves https://review.openstack.org/201100 | 13:09 |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Replace mox with mox3 https://review.openstack.org/201095 | 13:09 |
| *** bfic has joined #openstack-horizon | 13:09 | |
| haypo | robcresswell: would it make sense to accept https://blueprints.launchpad.net/horizon/+spec/porting-python3 for this cycle? | 13:13 |
| *** dboik has joined #openstack-horizon | 13:14 | |
| *** belmoreira has quit IRC | 13:20 | |
| *** peristeri has joined #openstack-horizon | 13:25 | |
| *** ^Gal^ has quit IRC | 13:26 | |
| *** vishwana_ has quit IRC | 13:28 | |
| *** lyanchih has quit IRC | 13:30 | |
| *** dboik_ has joined #openstack-horizon | 13:30 | |
| *** yamamoto has joined #openstack-horizon | 13:31 | |
| *** jtriley has joined #openstack-horizon | 13:33 | |
| *** ericksonsantos has joined #openstack-horizon | 13:33 | |
| *** raildo has joined #openstack-horizon | 13:33 | |
| *** dboik has quit IRC | 13:33 | |
| *** masco__ has quit IRC | 13:34 | |
| *** tvanderwiel has joined #openstack-horizon | 13:35 | |
| *** andrewbogott_afk is now known as andrewbogott | 13:35 | |
| *** yamamoto has quit IRC | 13:36 | |
| *** vijendar1 has joined #openstack-horizon | 13:38 | |
| *** vijendar has quit IRC | 13:39 | |
| *** vijendar1 has quit IRC | 13:39 | |
| *** vijendar has joined #openstack-horizon | 13:39 | |
| *** raildo has quit IRC | 13:40 | |
| *** raildo has joined #openstack-horizon | 13:44 | |
| *** rdopiera_ has quit IRC | 13:44 | |
| *** rdopiera has quit IRC | 13:44 | |
| *** vijendar has quit IRC | 13:45 | |
| *** vijendar has joined #openstack-horizon | 13:45 | |
| *** lyanchih has joined #openstack-horizon | 13:49 | |
| *** jpomero has joined #openstack-horizon | 13:49 | |
| *** andrewbogott is now known as andrewbogott_afk | 13:51 | |
| *** JeanBriceCombebi has quit IRC | 13:52 | |
| *** pauloewerton has joined #openstack-horizon | 13:53 | |
| *** mrunge has quit IRC | 13:55 | |
| *** rdopiera has joined #openstack-horizon | 13:55 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:56 | |
| *** KingKhan has quit IRC | 13:58 | |
| *** haypo has quit IRC | 14:00 | |
| *** lblanchard has joined #openstack-horizon | 14:00 | |
| *** haypo has joined #openstack-horizon | 14:01 | |
| *** petertr7_away is now known as petertr7 | 14:05 | |
| *** absubram has joined #openstack-horizon | 14:06 | |
| *** andrewbogott_afk is now known as andrewbogott | 14:06 | |
| *** bfic has quit IRC | 14:07 | |
| *** drupalmonkey has joined #openstack-horizon | 14:15 | |
| *** btully has joined #openstack-horizon | 14:16 | |
| *** Piet has quit IRC | 14:17 | |
| *** Alister has joined #openstack-horizon | 14:20 | |
| Alister | Hello guys, | 14:20 |
| *** pamo has joined #openstack-horizon | 14:20 | |
| Alister | I am customizing horizon and I would like to retrieve the curent tenant_id, how can I do? | 14:20 |
| *** pamo has quit IRC | 14:25 | |
| *** JeanBriceCombebi has quit IRC | 14:26 | |
| sjmc7 | morning, david-lyle. i asked this on friday but everyone had disappeared; when we were deploying juno (from upstream tripleo), we were overriding STATIC_ROOT in local_settings.py to serve it from apache from /var/www/horizon/static | 14:31 |
| sjmc7 | as of https://github.com/openstack/horizon/commit/18dddd97da19af894a0974e3560197036ea8969a, that no longer works | 14:31 |
| sjmc7 | since it wasn't really documented, i suspect we shouldn't have been doing that, and changing ROOT_PATH has some strange side effects | 14:32 |
| sjmc7 | is there any support for doing this or is it best to serve it from horizon/static, as the defaults suggest? | 14:32 |
| *** ^Gal^ has joined #openstack-horizon | 14:33 | |
| *** julim_ has quit IRC | 14:33 | |
| *** julim has joined #openstack-horizon | 14:34 | |
| *** echozdog has joined #openstack-horizon | 14:34 | |
| lyanchih | Hi folks, would you please review our patch? https://review.openstack.org/#/c/199457/ | 14:34 |
| *** stevemar has joined #openstack-horizon | 14:36 | |
| *** jtriley has quit IRC | 14:36 | |
| *** rhagarty_ has quit IRC | 14:39 | |
| *** rhagarty has quit IRC | 14:39 | |
| *** petertr7 is now known as petertr7_away | 14:40 | |
| *** oro has quit IRC | 14:41 | |
| *** Alister has quit IRC | 14:42 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:43 | |
| *** petertr7_away is now known as petertr7 | 14:46 | |
| *** htruta has joined #openstack-horizon | 14:49 | |
| *** alexpilotti has quit IRC | 14:54 | |
| *** Piet has joined #openstack-horizon | 14:55 | |
| *** alexpilotti has joined #openstack-horizon | 14:55 | |
| *** alexpilotti has quit IRC | 14:56 | |
| *** alexpilotti has joined #openstack-horizon | 14:57 | |
| *** ygbo has quit IRC | 14:57 | |
| *** akrivoka has quit IRC | 14:57 | |
| *** rhagarty has joined #openstack-horizon | 14:58 | |
| *** rhagarty_ has joined #openstack-horizon | 14:58 | |
| *** akrivoka has joined #openstack-horizon | 14:59 | |
| *** Ala has quit IRC | 14:59 | |
| *** cbader has joined #openstack-horizon | 14:59 | |
| *** alexpilotti has quit IRC | 14:59 | |
| *** JeanBriceCombebi has quit IRC | 15:01 | |
| *** yingjun has quit IRC | 15:01 | |
| *** alexpilotti has joined #openstack-horizon | 15:01 | |
| *** alexpilotti has quit IRC | 15:03 | |
| *** alexpilotti has joined #openstack-horizon | 15:05 | |
| *** cody-somerville has joined #openstack-horizon | 15:06 | |
| *** jbell8 has joined #openstack-horizon | 15:06 | |
| *** cbader has quit IRC | 15:10 | |
| *** alexpilotti has quit IRC | 15:11 | |
| *** jtriley has joined #openstack-horizon | 15:11 | |
| david-lyle | sjmc7: I curious why a commit on kilo master would affect Juno deploys | 15:16 |
| david-lyle | did you mean Kilo? | 15:16 |
| sjmc7 | sorry, i wasn't clear - we moved from juno to kilo last week | 15:16 |
| david-lyle | ok | 15:16 |
| david-lyle | making more sense | 15:16 |
| sjmc7 | yeah. for juno, the tripleo config overrode STATIC_ROOT explicitly | 15:17 |
| *** matt-borland has joined #openstack-horizon | 15:17 | |
| sjmc7 | right now, the defaults put 'static' in site-packages/static | 15:17 |
| david-lyle | where are you wanting to serve horizon from / or /something/ | 15:18 |
| sjmc7 | yeah, /var/www/horizon | 15:18 |
| sjmc7 | i guess we can symlink or something | 15:19 |
| david-lyle | sjmc7: I meant the url | 15:19 |
| *** rwsu has joined #openstack-horizon | 15:19 | |
| sjmc7 | ah - we don't change the url, so i think the default's /static | 15:19 |
| david-lyle | ok | 15:19 |
| david-lyle | so the problem is, you were setting static_root and now that's now working? | 15:20 |
| sjmc7 | so this isn't WEBROOT related (and i have no wish to get involved in that) | 15:20 |
| sjmc7 | yeah - and it may be it was never officially supported, which is fine | 15:20 |
| david-lyle | sjmc7: if you want to still do the same thing you'll likely just have to set static_root in settings.py | 15:21 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L281 | 15:21 |
| sjmc7 | yeah, looks like it | 15:21 |
| sjmc7 | ok | 15:21 |
| *** pamo has joined #openstack-horizon | 15:21 | |
| david-lyle | just change that | 15:21 |
| *** SimonChung1 has quit IRC | 15:22 | |
| david-lyle | but there may be room for improvement there, but that would only be on master | 15:22 |
| david-lyle | once done :) | 15:22 |
| sjmc7 | yep, understood. ok, i'll maybe file a bug and make the change | 15:23 |
| david-lyle | that could be cherry-pickable | 15:23 |
| david-lyle | small and localized change | 15:23 |
| sjmc7 | yeah.. it doesn't look like it needs to be tangled up in the WEBROOT stuff | 15:24 |
| *** sayan has quit IRC | 15:24 | |
| david-lyle | sjmc7: change could be as simple as checking that STATIC_ROOT wasn't already set in local_settings.py | 15:25 |
| david-lyle | and only set it if it wasn't | 15:25 |
| david-lyle | like LOGIN_URL is handled | 15:25 |
| *** Sukhdev has joined #openstack-horizon | 15:25 | |
| *** pamo has quit IRC | 15:26 | |
| sjmc7 | yep, that's a good point | 15:26 |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Add a OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED settings option https://review.openstack.org/201221 | 15:26 |
| *** garthb has joined #openstack-horizon | 15:31 | |
| *** garthb_ has joined #openstack-horizon | 15:31 | |
| *** notmars has joined #openstack-horizon | 15:36 | |
| *** radez_g0n3 has quit IRC | 15:36 | |
| *** ramishra has quit IRC | 15:36 | |
| *** mitz_ has quit IRC | 15:36 | |
| *** tsufiev has quit IRC | 15:36 | |
| *** crobertsrh has quit IRC | 15:36 | |
| *** petertr7 has quit IRC | 15:36 | |
| *** tristanC has quit IRC | 15:36 | |
| *** SlickNik has quit IRC | 15:36 | |
| *** DuncanT has quit IRC | 15:36 | |
| *** pcarver has quit IRC | 15:36 | |
| *** pcarver has joined #openstack-horizon | 15:37 | |
| *** tristanC has joined #openstack-horizon | 15:37 | |
| *** SlickNik has joined #openstack-horizon | 15:37 | |
| *** radez_g0n3 has joined #openstack-horizon | 15:37 | |
| *** radez_g0n3 has quit IRC | 15:37 | |
| *** radez_g0n3 has joined #openstack-horizon | 15:37 | |
| *** mitz has joined #openstack-horizon | 15:37 | |
| *** petertr7 has joined #openstack-horizon | 15:37 | |
| *** crobertsrh has joined #openstack-horizon | 15:38 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** tsufiev has joined #openstack-horizon | 15:39 | |
| *** ghundal_tw has joined #openstack-horizon | 15:43 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity Projects Table https://review.openstack.org/199567 | 15:47 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Panel https://review.openstack.org/199139 | 15:47 |
| *** nlahouti has joined #openstack-horizon | 15:49 | |
| krotscheck | robcresswell: I agree with your assessment on the ng_on_watch rule, especially in light of the thing I found in the Papa guides. Revert? | 15:50 |
| *** ramishra has joined #openstack-horizon | 15:50 | |
| *** morganfainberg has quit IRC | 15:51 | |
| *** morganfainberg has joined #openstack-horizon | 15:52 | |
| *** Piet has quit IRC | 15:54 | |
| *** garthb_ has quit IRC | 15:55 | |
| *** garthb has quit IRC | 15:55 | |
| *** DuncanT has joined #openstack-horizon | 15:57 | |
| robcresswell | krotscheck: Wait until Thai is around so we can ask why it was pushed through. I would prefer its explicity cleaned up (and so the rule is turned on) but I want to understand the reasoning. | 15:57 |
| robcresswell | krotscheck: Just to save time on pushing up a revert patch which may not be needed. | 15:58 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Revert "Ignore the ng_on_watch error from eslint" https://review.openstack.org/201235 | 15:58 |
| robcresswell | haha | 15:58 |
| robcresswell | or not :p | 15:58 |
| krotscheck | robcresswell: Too late ;) | 15:58 |
| krotscheck | robcresswell: I dunno, I guess my own eingeering background goes back to C++'s "Always clean up your pointers", and relying on framework/language magic to do that for me always makes me leery. | 15:59 |
| krotscheck | I mean yeah, it's one thing to have nice garbage collection _in_ the runtime, but even that requires pointer dereferencing. | 15:59 |
| krotscheck | But it's another entirely to assume someone elses's code will do it for you. | 16:00 |
| robcresswell | krotscheck: Yeah, I'm inclined to agree. Especially because that angular discussion seemed to imply it was only needed in *some* situations, I'd rather we just did it every time, than risk missing tricky bugs. | 16:00 |
| krotscheck | (Someone else's code in your library) | 16:00 |
| *** garthb has joined #openstack-horizon | 16:00 | |
| *** TravT has joined #openstack-horizon | 16:00 | |
| *** Drago has joined #openstack-horizon | 16:02 | |
| *** gyee has joined #openstack-horizon | 16:03 | |
| *** sayan has joined #openstack-horizon | 16:10 | |
| *** notmars_ has joined #openstack-horizon | 16:12 | |
| *** nzeplowi has joined #openstack-horizon | 16:13 | |
| *** SimonChung has joined #openstack-horizon | 16:13 | |
| *** sayan has quit IRC | 16:13 | |
| *** zhenguo has quit IRC | 16:13 | |
| *** notmars has quit IRC | 16:14 | |
| *** notmars_ is now known as notmars | 16:14 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: Fix eslint for the metadata-tree widgets. https://review.openstack.org/200752 | 16:18 |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Add an OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED settings option https://review.openstack.org/201221 | 16:19 |
| *** oro has joined #openstack-horizon | 16:20 | |
| *** jrist has quit IRC | 16:20 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 16:21 |
| *** e0ne has quit IRC | 16:21 | |
| *** mgarza_ has joined #openstack-horizon | 16:22 | |
| *** pamo has joined #openstack-horizon | 16:22 | |
| *** dboik_ has quit IRC | 16:22 | |
| *** dboik has joined #openstack-horizon | 16:23 | |
| *** Drago has quit IRC | 16:24 | |
| *** petertr7 is now known as petertr7_away | 16:24 | |
| *** tyr has joined #openstack-horizon | 16:25 | |
| *** jrist has joined #openstack-horizon | 16:26 | |
| *** lyanchih has quit IRC | 16:26 | |
| *** clu_ has joined #openstack-horizon | 16:26 | |
| *** pamo has quit IRC | 16:27 | |
| *** pamo has joined #openstack-horizon | 16:27 | |
| openstackgerrit | Nathan Zeplowitz proposed openstack/horizon: JSCS Cleanup - Fix eslint metadata-tree widgets. https://review.openstack.org/200752 | 16:28 |
| *** clu__ has joined #openstack-horizon | 16:28 | |
| *** clu_ has quit IRC | 16:28 | |
| *** lyanchih has joined #openstack-horizon | 16:28 | |
| *** rajatvig has joined #openstack-horizon | 16:31 | |
| *** ghundal_tw has quit IRC | 16:34 | |
| *** TravT_ has joined #openstack-horizon | 16:34 | |
| *** kiran-r has joined #openstack-horizon | 16:35 | |
| *** TravT has quit IRC | 16:37 | |
| *** rajatvig has quit IRC | 16:37 | |
| *** rajatvig has joined #openstack-horizon | 16:37 | |
| *** Drago has joined #openstack-horizon | 16:38 | |
| *** raildo has quit IRC | 16:38 | |
| *** ghundal_TW has joined #openstack-horizon | 16:39 | |
| *** Drago has quit IRC | 16:41 | |
| *** Drago has joined #openstack-horizon | 16:41 | |
| *** TravT has joined #openstack-horizon | 16:42 | |
| *** TravT_ has quit IRC | 16:42 | |
| *** ducttape_ has joined #openstack-horizon | 16:45 | |
| *** lyanchih has quit IRC | 16:49 | |
| *** kbrown has joined #openstack-horizon | 16:50 | |
| *** alexpilotti has joined #openstack-horizon | 16:51 | |
| *** Drago has quit IRC | 16:53 | |
| *** Drago has joined #openstack-horizon | 16:53 | |
| *** Drago has quit IRC | 16:53 | |
| *** dscottsf has joined #openstack-horizon | 16:53 | |
| *** dscottsf has quit IRC | 16:53 | |
| *** Drago has joined #openstack-horizon | 16:54 | |
| ducttape_ | mrunge - let me know if I am wrong about https://review.openstack.org/#/c/201066/1 | 16:55 |
| *** notmars has quit IRC | 16:55 | |
| ducttape_ | maybe that change was also meant to roll tox too, but I don't think so | 16:55 |
| *** annashen has joined #openstack-horizon | 17:01 | |
| *** alexpilotti has quit IRC | 17:02 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 17:03 |
| *** juggler_ is now known as juggler | 17:04 | |
| *** tqtran-afk has joined #openstack-horizon | 17:05 | |
| *** tqtran-afk is now known as tqtran | 17:05 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Images Project Panel https://review.openstack.org/200324 | 17:06 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 17:06 |
| *** skylerberg has joined #openstack-horizon | 17:06 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 17:07 |
| *** neelashah has quit IRC | 17:07 | |
| *** alexpilotti has joined #openstack-horizon | 17:08 | |
| ducttape_ | TravT and tqtran - I subscribe you guys to this bug https://bugs.launchpad.net/horizon/+bug/1473978 Maybe its some new required setup for deployment of horizon, not sure | 17:08 |
| openstack | Launchpad bug 1473978 in OpenStack Dashboard (Horizon) "static url path does not work consistently" [Undecided,New] | 17:08 |
| ducttape_ | I tried to deploy the new launch instance thing, then I found pain, suffering, and failure | 17:09 |
| TravT | ducttape_: is this related to this: https://review.openstack.org/#/c/181095/ | 17:10 |
| matt-borland | duccttape_: also, please note the documentation for WEBROOT in the settings docs | 17:10 |
| tqtran | ducttape_: hm... why is the dashboard path /dashboard or /horizon? | 17:10 |
| matt-borland | http://docs.openstack.org/developer/horizon/topics/settings.html#webroot | 17:10 |
| ducttape_ | I think WEBROOT might have been / | 17:10 |
| tqtran | by path, we're referring to URL path right? | 17:11 |
| *** oro has quit IRC | 17:11 | |
| tqtran | not file path is it? | 17:11 |
| matt-borland | There's a note in the settings regarding setting $webroot in _variables.scss | 17:11 |
| matt-borland | between the patch and the documentation, everything should work | 17:12 |
| *** annashen has quit IRC | 17:12 | |
| ducttape_ | not sure, but I have the setup to get the old launch instance working correctly it seems and was probably pre-2015.1 (even though I have deployed code from within the last month) | 17:13 |
| openstackgerrit | David Lyle proposed openstack/horizon: remove django<1.7 from tests https://review.openstack.org/201066 | 17:13 |
| ducttape_ | I am probably missing the correct config, but it's wierd that what I have right now works fine with old launch instance.... try to use the new and (boom) no dice | 17:13 |
| ducttape_ | so it seems like now if you run out of the path /dashboard/ -> that you must have static to be served out of /dashboard/static ..... is that correct? | 17:15 |
| tqtran | yes that is correct, assuming you setup webroot correctly | 17:15 |
| *** petertr7_away is now known as petertr7 | 17:15 | |
| tqtran | ok now hold, let us append url path or file path to the wording | 17:16 |
| ducttape_ | ok, thats new to me, thanks | 17:16 |
| *** notmars has joined #openstack-horizon | 17:16 | |
| *** TravT has quit IRC | 17:16 | |
| tqtran | when you say, if you run of the path /dashboard/, you mean file path? or is that the webroot you are referring to? | 17:16 |
| ducttape_ | the url / uri path | 17:16 |
| tqtran | ok, then yes, the static should be /dashboard/static/ | 17:16 |
| ducttape_ | so like http://foo/horizon or http://foo/dashboard | 17:16 |
| ducttape_ | puppet module from a few months ago did not setup horizon this way | 17:17 |
| tqtran | there shouldn't be a horizon or dashboard folder at all | 17:18 |
| ducttape_ | why not? | 17:18 |
| tqtran | if you need to access static resources, it will be foo/static/......** | 17:18 |
| tqtran | if you need to access panels, it will be foo/dashboard/panel | 17:18 |
| ducttape_ | so now you require deployments to be setup on root url path? | 17:19 |
| tqtran | correction, it will be foo/<dashboard>/<panel> | 17:19 |
| tqtran | no, it will be relative to whatever your webroot is | 17:19 |
| *** TravT has joined #openstack-horizon | 17:19 | |
| tqtran | this is how it has always been, we havent change the behavior | 17:19 |
| *** annashen has joined #openstack-horizon | 17:20 | |
| ducttape_ | no, it certainly is not tqtran | 17:20 |
| ducttape_ | that much I am certain of | 17:20 |
| tqtran | all we have done is give the JS side access to the webroot path | 17:20 |
| matt-borland | ducttape_: does your question have anything to do with the use of STATIC_ROOT in your local_settings.py? Which is a different issue? | 17:20 |
| ducttape_ | the js stuff previously ran out of a folder that was not within the webroot, at least for 20014.2 and before | 17:21 |
| tqtran | so you're saying static resources are served as foo/static, so what is foo/horizon use for? | 17:21 |
| ducttape_ | http://foo/horizon/auth/login/?next=/horizon/ | 17:21 |
| ducttape_ | then http://foo/horizon/project/ | 17:22 |
| ducttape_ | and all your static stuff would be in http://foo/static/ | 17:22 |
| tqtran | ok, so /foo/horizon/ would be your webroot right? and you're saying that statics can be access as /foo/static? | 17:22 |
| tqtran | ok didn't know you can do that | 17:22 |
| ducttape_ | that has been behavior, for at least a little bit | 17:22 |
| tqtran | so why would a deployer set it up this way? | 17:22 |
| tqtran | wouldn't you end up with collision? | 17:23 |
| ducttape_ | that was puppet module, and I thought default deb package from canonical | 17:23 |
| *** ybathia has joined #openstack-horizon | 17:23 | |
| ducttape_ | I would say the new way is likely for collision, and ask why the new way | 17:23 |
| ducttape_ | if you separate all that static stuff out, then you wsgi app can have any path it needs | 17:24 |
| ducttape_ | with the new way, the wsgi app can never use the path static/ | 17:24 |
| ducttape_ | because that is needed for static content serving | 17:24 |
| tqtran | hold on.... that doesn't quite make sense to me. | 17:25 |
| ducttape_ | it's fine to have it either way / whatever.... this is new config / change in path that caught me napping | 17:25 |
| tqtran | so lets say you have 2 applications, app A and app B, with foo/A/ and foo/B/ url | 17:25 |
| *** petertr7 is now known as petertr7_away | 17:25 | |
| *** Sukhdev has quit IRC | 17:25 | |
| tqtran | and to access their static resources, it would be foo/static/, this would essentially give app A and app B access to this universal static folder | 17:26 |
| *** Sukhdev has joined #openstack-horizon | 17:26 | |
| tqtran | and if you have an app named static, what happens then? foo/static/? | 17:26 |
| matt-borland | ducttape_: you might want to check out https://github.com/openstack/horizon/commit/18dddd97da19af894a0974e3560197036ea8969a | 17:26 |
| ducttape_ | you can configure static to be any path you want -> that was the previous setup. So you could have foo/A/static if you wanted, or you could do foo/static | 17:27 |
| tqtran | having it as foo/A/static and foo/B/static is much safer no? | 17:27 |
| matt-borland | In that commit, certain vars like STATIC_URL stopped being respected if placed in local_settings.py | 17:27 |
| *** rdopiera has quit IRC | 17:27 | |
| ducttape_ | tqtran - giving flexibility is safer, I would say | 17:27 |
| tqtran | i just don't think having that much flexibility make sense here. the static contents of your app should live under your app | 17:28 |
| *** neelashah has joined #openstack-horizon | 17:28 | |
| tqtran | and hence, a sub url of it, aka (foo/<app>/static/) | 17:28 |
| *** Longgeek has quit IRC | 17:29 | |
| tqtran | unless you plan on sharing static contents between multiple apps, but thats a weird use, i dont think i have seen any webapp like taht before | 17:29 |
| ducttape_ | thats fine if thats the decision, just trying to give feedback of someone who is actually deploying and using this stuff | 17:29 |
| tqtran | no, this is a good discussion, i didnt know that you can configure your static outside of your app's webroot | 17:30 |
| *** vijendar has quit IRC | 17:30 | |
| tqtran | we'll have to think about that a bit.... | 17:31 |
| *** iamjarvo has joined #openstack-horizon | 17:31 | |
| tqtran | either document that extremely well on what we expect or have support for it (which could be a bit challenging) | 17:32 |
| ducttape_ | I know what I need to do to adjust for now, thanks ;) | 17:32 |
| *** vijendar has joined #openstack-horizon | 17:32 | |
| *** kzaitsev_mb has quit IRC | 17:33 | |
| tqtran | matt-borland or TravT, do you guys have some time today? need some help setting up the test for webroot, i still havent gotten it to work | 17:33 |
| *** jingjing_ren has joined #openstack-horizon | 17:33 | |
| tqtran | i tried everything.. not sure what is going on | 17:33 |
| *** geoffarnold has joined #openstack-horizon | 17:34 | |
| tqtran | or i can code it up and you guys can test it, that will work as well | 17:34 |
| david-lyle | I don't think STATIC_ROOT should have to be tied to WEB_ROOT | 17:34 |
| tqtran | whatever is easier | 17:34 |
| david-lyle | err, WEBROOT | 17:34 |
| david-lyle | that was just a convenience | 17:34 |
| david-lyle | sjmc7: had the same issue | 17:35 |
| david-lyle | a simple fix to honoring local_settings.py override of the value is all that's required | 17:35 |
| david-lyle | sjmc7: did you file a bug? | 17:35 |
| david-lyle | is that the concern ducttape_ STATIC_ROOT ? | 17:36 |
| ducttape_ | yeah, there is new code changes that require static to be nested within the app url path | 17:37 |
| david-lyle | I'll post a patch, just a sec | 17:37 |
| *** geoffarnold has quit IRC | 17:37 | |
| *** alexpilotti has quit IRC | 17:37 | |
| *** chlong-afk has quit IRC | 17:38 | |
| tqtran | which patch was this? | 17:38 |
| ducttape_ | tqtran - I just verified that ubuntu's horizon package from 2014.2 had /horizon and /static as different paths | 17:38 |
| tqtran | interesting.... | 17:38 |
| tqtran | so the STATIC_ROOT override happens in local_settings? | 17:39 |
| tqtran | thats fine, so what we're referring to as WEBROOT in matt's patch is actually STATIC_ROOT, it should still all work | 17:40 |
| ducttape_ | now, WEBROOT would be /horizon | 17:40 |
| ducttape_ | err no I mean | 17:40 |
| *** geoffarnold has joined #openstack-horizon | 17:40 | |
| ducttape_ | I'd say you need an app path (i.e. WEBROOT) -> this is where wsgi and python get to play | 17:40 |
| *** akrivoka has quit IRC | 17:41 | |
| tqtran | do you know if STATIC_ROOT is a django reserved setting? or is that something horizon made up? | 17:41 |
| ducttape_ | and then there is STATIC -> this is where python and wsgi don't do anything, and the webserver serves this | 17:41 |
| *** akrivoka has joined #openstack-horizon | 17:41 | |
| ducttape_ | https://docs.djangoproject.com/en/1.8/howto/static-files/#configuring-static-files tqtran | 17:41 |
| tqtran | yeah just saw it | 17:42 |
| *** lhcheng has joined #openstack-horizon | 17:42 | |
| tqtran | cool! that makes it even easier :) | 17:42 |
| tqtran | no need to pass in context at all | 17:42 |
| *** petertr7_away is now known as petertr7 | 17:42 | |
| tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L282 | 17:43 |
| *** markus_z has quit IRC | 17:44 | |
| *** tyr has quit IRC | 17:44 | |
| *** alexpilotti has joined #openstack-horizon | 17:44 | |
| *** Piet has joined #openstack-horizon | 17:45 | |
| tqtran | it looks like static_root is a folder path? | 17:45 |
| openstackgerrit | David Lyle proposed openstack/horizon: Allow STATIC_ROOT override https://review.openstack.org/201270 | 17:45 |
| *** nzeplowi has quit IRC | 17:46 | |
| *** kiran-r has quit IRC | 17:46 | |
| tqtran | david-lyle: help me understand something, do we currently support having a different URL path for static and app? | 17:49 |
| tqtran | or are we expecting that the static be a sub URL of the app? we're not talking about file paths here | 17:49 |
| *** nzeplowi has joined #openstack-horizon | 17:49 | |
| david-lyle | tqtran: django would support static being anywhere, we've forced it to be local | 17:49 |
| david-lyle | but there are two things here | 17:50 |
| david-lyle | STATIC_URL which is where the static content is served from, that should honor WEBROOT | 17:50 |
| ducttape_ | tqtran - I think I have already said - historically static has been outside of the django url path | 17:50 |
| david-lyle | and STATIC_ROOT which is just where the application should find the static content in the filesystem | 17:50 |
| tqtran | ok, and WEBROOT is the app's starting url? or the server? | 17:52 |
| david-lyle | yes | 17:52 |
| *** oro has joined #openstack-horizon | 17:52 | |
| david-lyle | the url | 17:52 |
| tqtran | for the app or server? | 17:52 |
| david-lyle | the url that I access Horizon at | 17:52 |
| tqtran | so url for the app? | 17:53 |
| david-lyle | in devstack that would be / | 17:53 |
| david-lyle | in the future is may be /dashboard | 17:53 |
| david-lyle | the server address is prepended on that when making requests | 17:53 |
| tqtran | and you're saying then that STATIC_URL should honor this | 17:53 |
| david-lyle | yes | 17:53 |
| tqtran | ok, im saying the same thing :) | 17:54 |
| david-lyle | ducttape_ is asking about static_root | 17:54 |
| david-lyle | where the files are accessed from | 17:54 |
| *** alexpilotti has quit IRC | 17:54 | |
| tqtran | ok, if thats the case, then i misunderstood him. but that has no relation to what matt's patch is trying to do | 17:54 |
| tqtran | all matt's patch is doing is saying, whatever the webroot is, let me expose that to the client-side | 17:55 |
| ducttape_ | I think I have -1 one of matt's patches already, bringing up this point | 17:56 |
| *** tosky has quit IRC | 17:56 | |
| ducttape_ | it seems to be lost on people | 17:56 |
| ducttape_ | but if you want to make a rule to move STATIC_URL to reside within the wsgi path, then lets do that. I think that's wrong, but I just need a clear decision on "do this, not that" or whatever | 17:57 |
| david-lyle | ducttape_: so you want STATIC_URL at an arbitrary location as well? | 17:58 |
| david-lyle | or did I just miss the boat? | 17:58 |
| tqtran | yes, thats what eric is saying/want | 17:58 |
| ducttape_ | btw - don't take me as an enemy here, I think I am one of the first larger deployments getting the launch instance changes in front of real users | 17:58 |
| tqtran | i sort of disagree with it, but im not a deployer and i dont quite understand the rationale for it | 17:59 |
| david-lyle | just trying to figure out what the request is | 17:59 |
| david-lyle | I think I wrapped it into another coversation | 17:59 |
| tqtran | lol yes you did | 17:59 |
| david-lyle | *conversation | 17:59 |
| david-lyle | well you were referring to STATIC_ROOT | 17:59 |
| ducttape_ | in the past, STATIC_URL has been = "/static" and the wsgi path has been "/horizon" or "/dashboard" | 17:59 |
| david-lyle | ducttape_: for your installation? | 18:00 |
| ducttape_ | you *could* also set the wsgi path to be "/" | 18:00 |
| ducttape_ | david-lyle - for mine, for older puppet modules, for ubuntus horizon package | 18:00 |
| ducttape_ | I am speaking from common debian package background on what has been deployed / used | 18:01 |
| david-lyle | ducttape_: so was horizon aliased in the apache conf for horizon or did you access it at https://server/horizon ? | 18:01 |
| david-lyle | rather than https://server/ | 18:02 |
| ducttape_ | yep, it had the /horizon path | 18:02 |
| ducttape_ | the big change now is that I need to move the /static STATIC_URL path to be something like /horizon/static to get stuff to work | 18:02 |
| ducttape_ | it's not really a big change per se, but it's broken if you don't see this comming | 18:03 |
| ducttape_ | and again, this is less flexible because now part of the url paths that previously were flexible - are no longer flexible | 18:03 |
| ducttape_ | you have to nest the static url to be within the wsgi path | 18:03 |
| tqtran | ducttape_: im not sure we changed that recently though, we didnt even touch it until matt's patch | 18:04 |
| david-lyle | I suppose as long at STATIC_URL is configurable that should work | 18:04 |
| openstackgerrit | Brian Tully proposed openstack/horizon: WIP - Project Admin support for Domains https://review.openstack.org/201277 | 18:04 |
| ducttape_ | it's now configurable -> but you have one correct choice | 18:05 |
| *** garthb has quit IRC | 18:05 | |
| tqtran | can django be configured to allow users to access a url one level up from the application? | 18:05 |
| ducttape_ | previously it was configurable (end of statement) | 18:05 |
| ducttape_ | thats really an apache or wsgi host question, but the answer is yes | 18:06 |
| david-lyle | currently /static is the only path that would work | 18:06 |
| tqtran | that can get a bit tricky now that we have static resources with pathing requirement | 18:06 |
| david-lyle | by currently I mean for 2014.2 | 18:07 |
| david-lyle | it's a false option to set that to something else | 18:07 |
| david-lyle | tqtran: it's just a URL | 18:07 |
| *** kbrown has quit IRC | 18:08 | |
| *** cody-somerville has quit IRC | 18:09 | |
| tqtran | but that would mean we have 2 static_urls in settings (one is a django reserved, and the other an apache url where you can get static resources) | 18:09 |
| david-lyle | django reserved? | 18:09 |
| tqtran | or are they one and the same? | 18:09 |
| tqtran | right now, STATIC_URL = WEBROOT + 'static/' | 18:09 |
| tqtran | are you saying that we can just replace that and things will work smoothly? | 18:10 |
| david-lyle | and to support that you have to add the alias in horizon.conf in your apache confi | 18:10 |
| david-lyle | g | 18:10 |
| ducttape_ | STATIC_URL = WEBROOT + 'static/' -> I would say this is wrong | 18:10 |
| ducttape_ | and should probably look for instances of that, and change it | 18:11 |
| *** aix has quit IRC | 18:11 | |
| david-lyle | tqtran: it should if all the webroot honoring fixes were done correctly | 18:11 |
| tqtran | sounds really messy | 18:11 |
| david-lyle | why? | 18:11 |
| david-lyle | which part? | 18:12 |
| tqtran | so right now, we are passing STATIC_URL to the client | 18:12 |
| david-lyle | yup | 18:12 |
| tqtran | and if STATIC_URL is one level up, i'm not sure it will be possible for client to reach it? | 18:12 |
| ducttape_ | why not? | 18:13 |
| david-lyle | apache controls that | 18:13 |
| david-lyle | if I tell apache to server /var/www/horizon/static at /static, it will | 18:13 |
| david-lyle | the access limitation in horizon are application induced | 18:14 |
| tqtran | right... i get that | 18:14 |
| * ducttape_ wonders if anyone tells apache anything, always the last to know | 18:14 | |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: JSCS Cleanup-style guide cleanup for filters.js https://review.openstack.org/199789 | 18:15 |
| *** mpavlase has quit IRC | 18:15 | |
| *** jwy has joined #openstack-horizon | 18:17 | |
| *** geoffarnold has quit IRC | 18:17 | |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: JSCS Cleanup-style guide cleanup for filters.js https://review.openstack.org/199789 | 18:20 |
| david-lyle | will post a patch to sit indefinitely | 18:20 |
| david-lyle | then try to work on better documentation | 18:20 |
| tqtran | ok so let me bring up a scenario | 18:21 |
| tqtran | assume that static resources reside in localhost/static/*.** | 18:21 |
| tqtran | and horizon app at localhost/horizon/ | 18:21 |
| tqtran | so my webroot would be /horizon/ | 18:22 |
| tqtran | and my static_url would be? | 18:22 |
| david-lyle | static/ | 18:22 |
| *** notmars has quit IRC | 18:23 | |
| tqtran | ok, so how does clientside know that static doesn't reside within webroot? | 18:23 |
| tqtran | would it have to be '../static/'? | 18:23 |
| tqtran | *wouldn't it | 18:23 |
| david-lyle | because they should be using the value for STATIC_URL and not some hard-coded url | 18:23 |
| ducttape_ | tqtran - the templates from django would use src="{{ STATIC_URL }}/my_jacked_up.js" | 18:24 |
| ducttape_ | or something like that | 18:24 |
| david-lyle | so, to take a step back | 18:24 |
| *** bpokorny has joined #openstack-horizon | 18:24 | |
| tqtran | but from the clientside, when you're making a request, you're making the request relatively to where you are right? | 18:24 |
| david-lyle | tqtran: you're passing in the URL | 18:24 |
| ducttape_ | no, the client makes a complete request | 18:24 |
| david-lyle | you can have it be whatever you want | 18:24 |
| tqtran | ok i see | 18:25 |
| tqtran | right, it can also be relative | 18:25 |
| david-lyle | the current situation likely is because we couldn't put /static under a different WEBROOT in the past | 18:25 |
| david-lyle | it just didn't work | 18:25 |
| tqtran | ok got it, so what changes (if any) do we need to make? seems like it should all work the way things are now? | 18:26 |
| david-lyle | but making it work both ways is probably the best path forward | 18:26 |
| *** sqchen has joined #openstack-horizon | 18:26 | |
| david-lyle | with Django, I could host my static content on another server if I wanted | 18:26 |
| david-lyle | so hardcoding that behavior is not ideal | 18:26 |
| tqtran | sure, basically kind of like cdn | 18:26 |
| david-lyle | exactly like a cdn | 18:27 |
| *** kbrown has joined #openstack-horizon | 18:28 | |
| david-lyle | we can make the solution flexible so we don't break all downstream consumers in one fell swoop | 18:28 |
| david-lyle | at least not by that change | 18:28 |
| david-lyle | there will be others :( | 18:29 |
| *** rwsu has quit IRC | 18:29 | |
| *** geoffarnold has joined #openstack-horizon | 18:29 | |
| *** pamo has quit IRC | 18:29 | |
| tqtran | ok, so the conversation we just had is all prior to matt's change. is there anything else we need to do at this point to get it working? it seems like it is all a config thing right? | 18:30 |
| tqtran | set static_url to whatever, then config apache to point to static resources correctly | 18:30 |
| tqtran | and it should all work w/o further code change right? | 18:30 |
| david-lyle | yeah, I can post a change for honoring static_url setting | 18:30 |
| david-lyle | but I need to look at Matt's change | 18:30 |
| david-lyle | which change is that? | 18:31 |
| tqtran | https://review.openstack.org/#/c/181095/41 | 18:31 |
| tqtran | his change can come afterward | 18:31 |
| tqtran | and instead of relying on WEBROOT, it will rely on both WEBROOT for apis and STATIC_URL for static resources | 18:31 |
| david-lyle | that should be fine, but I will look more closely | 18:32 |
| *** oro has quit IRC | 18:32 | |
| tqtran | ok, i'll update code accordingly | 18:32 |
| david-lyle | actually that patch looks like it's hardcoding the use of webroot on static resources | 18:34 |
| david-lyle | which I assume was ducttape_'s issue with it | 18:34 |
| tqtran | yeah, thats what im changing | 18:34 |
| tqtran | we were assumingn that statics came out of webroot, but thats no longer the case | 18:34 |
| david-lyle | that's the concern yes | 18:37 |
| *** pamo has joined #openstack-horizon | 18:39 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - use $apply instead of $digest for action-list.spec https://review.openstack.org/201289 | 18:40 |
| robcresswell | tqtran: https://review.openstack.org/#/c/201235/ | 18:41 |
| *** kyleolivo has joined #openstack-horizon | 18:41 | |
| *** sayan has joined #openstack-horizon | 18:41 | |
| robcresswell | Thoughts? I don't think the original patch should've been pushed through with a -1 | 18:42 |
| *** kyleolivo has left #openstack-horizon | 18:43 | |
| *** kyleolivo has joined #openstack-horizon | 18:43 | |
| tqtran | reading | 18:43 |
| tqtran | i understand the need to do it in the directive, i have done that myself on several occasions | 18:44 |
| tqtran | but its not necessary all the time in other cases | 18:45 |
| *** kbrown has quit IRC | 18:45 | |
| * ducttape_ returns to read scrollback with a sammie | 18:45 | |
| tqtran | sure, having an assignment there does make it less fragile, but why assign if you're not going to use? | 18:46 |
| robcresswell | My thinking atm is that its better to just explicitly do it. I would hate to be chasing down a bug in the tests to do with cleanup, that stuff becomes a pita very very fast | 18:46 |
| *** kbrown has joined #openstack-horizon | 18:46 | |
| tqtran | its an extra linting rule that doesn't have to be there 100% of the time. if you're writing a directive, then yes, have it there, but for other scenarios, i dont see the benefit | 18:46 |
| tqtran | lets say you're watching the scope in a controller, that gets automatically recycled for you. doesn't hurt to have an extra assignment, but you'll violate another linting rule if you dont use it | 18:47 |
| *** Piet has quit IRC | 18:48 | |
| tqtran | just my personal take, if another core feels strongly about it, they can revert it, i dont have a strongly opinion on it | 18:49 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Identity dashboard's style should be customizable https://review.openstack.org/200718 | 18:49 |
| robcresswell | Yeah maybe I'm being petty. IMO it just seems sensible to leave the rules on unless there is a very good reason not to. They only exist to help prevent issues. | 18:49 |
| robcresswell | And if this helps us catch more issues at the cost of a couple more lines of code, I'm okay with that | 18:50 |
| robcresswell | sqchen, any thoughts? | 18:50 |
| tqtran | agreed, most of those rules make sense. but we can't all agree on the same thing :) | 18:50 |
| sqchen | reading the conversation… | 18:51 |
| *** ekarlso has quit IRC | 18:56 | |
| tqtran | could use some +1s on this patch when you guys have time, https://review.openstack.org/#/c/199349/ | 18:57 |
| *** ekarlso has joined #openstack-horizon | 18:58 | |
| *** Sukhdev has quit IRC | 18:59 | |
| robcresswell | tqtran: That reqs lists 2.1.0.1 but https://pypi.python.org/pypi/XStatic-Angular-Gettext/ is 2.1.0.2? | 18:59 |
| *** deuce has joined #openstack-horizon | 19:01 | |
| tqtran | oh, hm... maybe openstackci uploaded a new version | 19:01 |
| sqchen | robcresswell: tqtran: I prefer not force to unwatch in controllers, unnecessary boilerplate code. If we ad a watch in other scope (root scope for example), we should clean it up, other wise, we are doing it twice to try to clean-up in the same scope object. | 19:01 |
| *** ongk has joined #openstack-horizon | 19:02 | |
| *** e0ne has joined #openstack-horizon | 19:02 | |
| *** julim has quit IRC | 19:03 | |
| tqtran | sqchen: so is that a vote to revert or no? | 19:03 |
| robcresswell | That's a vote for no revert | 19:03 |
| sqchen | not revert. | 19:03 |
| tqtran | ok, just wanted to confirm | 19:04 |
| robcresswell | tqtran: Looks like lhcheng got you with the "track your changes" stick | 19:05 |
| tqtran | haha what? | 19:05 |
| *** pamo_ has joined #openstack-horizon | 19:06 | |
| *** jingjing_ren has quit IRC | 19:06 | |
| *** julim has joined #openstack-horizon | 19:06 | |
| *** pamo has quit IRC | 19:07 | |
| tqtran | hm...trying to figure out if i uploaded v2.1.0.2 or did openstackci did that | 19:08 |
| robcresswell | tqtran: on your global reqs patch | 19:08 |
| *** e0ne is now known as e0ne_ | 19:08 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:08 | |
| tqtran | ah... lol yeah | 19:09 |
| tqtran | lhcheng: i didnt really follow the discussion you had with randy, but is the license file suppose to be included in the tar ball? | 19:09 |
| *** sayan has quit IRC | 19:11 | |
| tqtran | ok nvm, its not suppose to be included | 19:11 |
| lhcheng | tqtran: yup. we only need to upload the sdist tar ball instead of the whole repo. | 19:12 |
| sjmc7 | afternoon. i'm getting some errors with kilo's policy checks - a "NoSuchOptError: no such option: config_dir" error from openstack/common/policy (which has since been replaced by oslo_policy in liberty) | 19:15 |
| sjmc7 | looks somewhat similar to https://bugs.launchpad.net/horizon/+bug/1416516 | 19:16 |
| openstack | Launchpad bug 1416516 in OpenStack Dashboard (Horizon) "use of oslo config in code uses two different versions" [Medium,In progress] - Assigned to Nikunj Aggarwal (nikunj2512) | 19:16 |
| sjmc7 | which was never resolved | 19:16 |
| *** skylerberg has quit IRC | 19:17 | |
| *** deuce1 has joined #openstack-horizon | 19:18 | |
| robcresswell | lhcheng: Just went to remove nikunj; you are fast! | 19:19 |
| lhcheng | sjmc7: I removed the assignee, you can fix it if you like :) | 19:19 |
| lhcheng | robcresswell: hah | 19:19 |
| sjmc7 | lhcheng :) it looks like this was resolved in master by using oslo.policy (the whole openstack/common module is gone now) | 19:20 |
| lhcheng | robcresswell: I wonder if this should be fixed now.. | 19:20 |
| lhcheng | sjmc7: cool | 19:20 |
| *** julim has quit IRC | 19:20 | |
| *** annashen has quit IRC | 19:20 | |
| sjmc7 | well, except that's not an option for a backport to kilo | 19:20 |
| robcresswell | lhcheng: Sorry, wonder if what should be fixed? | 19:21 |
| *** annashen has joined #openstack-horizon | 19:21 | |
| *** deuce has quit IRC | 19:21 | |
| *** e0ne_ is now known as e0ne | 19:22 | |
| robcresswell | sjmc7: I imagine if there is reason, you can propose a bugfix to kilo in this circumstance? Depends on risk. | 19:22 |
| *** nlahouti has quit IRC | 19:22 | |
| lhcheng | robcresswell: I think resync of the oslo code in kilo needs to happen | 19:22 |
| *** nzeplowi has quit IRC | 19:23 | |
| sjmc7 | ok. i'm not totally clear, looking at oslo.config, what's causing the problem, but i guess i can have a go at it | 19:23 |
| lhcheng | yeah, it have to be submitted directly to stable/kilo | 19:23 |
| *** julim has joined #openstack-horizon | 19:23 | |
| robcresswell | lhcheng: Big change though, right? Potential for breakages. | 19:23 |
| sjmc7 | not sure how much risk there'll be | 19:23 |
| *** annashen has quit IRC | 19:23 | |
| sjmc7 | it seems like a big change, yes. and a new dependency | 19:23 |
| *** annashen has joined #openstack-horizon | 19:23 | |
| robcresswell | sjmc7: Talk it over with lhcheng and the other kilo stable cores first | 19:23 |
| lhcheng | I mean sync it with kilo version of oslo | 19:24 |
| sjmc7 | ok. i'm not sure we're on the same page :) | 19:24 |
| sjmc7 | the fix on master was to bring in oslo.policy, which seems like a big change to backport to kilo | 19:25 |
| *** kyleolivo has quit IRC | 19:25 | |
| lhcheng | sjmc7: no, we're not backporting that | 19:25 |
| sjmc7 | ok | 19:25 |
| *** TravT has quit IRC | 19:25 | |
| *** kzaitsev_mb has quit IRC | 19:26 | |
| *** tyr has joined #openstack-horizon | 19:26 | |
| lhcheng | sjmc7: did you errors or just warning? | 19:27 |
| lhcheng | *you see | 19:27 |
| sjmc7 | "Error while checking action permissions." | 19:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 19:27 |
| sjmc7 | errors | 19:27 |
| *** kzaitsev_mb has joined #openstack-horizon | 19:28 | |
| *** iamjarvo has quit IRC | 19:29 | |
| matt-borland | tqtran: I read your reply in comments on https://review.openstack.org/#/c/181095/ | 19:29 |
| tqtran | and i replied to yours :) | 19:29 |
| tqtran | working on the solution atm | 19:30 |
| matt-borland | I'm talking about your very last reply | 19:30 |
| tqtran | ah | 19:30 |
| matt-borland | ok, just want to know if you're addressing the configuration problem in another patch, or expecting this patch to deal with it | 19:30 |
| tqtran | no, the config is something david will address | 19:30 |
| matt-borland | OK. | 19:30 |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding option for Java jobs to be adapted to Oozie https://review.openstack.org/188539 | 19:31 |
| matt-borland | So it's a matter of splitting out the WEBROOT vs. STATIC_URL uses in this patch. | 19:31 |
| *** Sukhdev has joined #openstack-horizon | 19:31 | |
| matt-borland | that works for me | 19:31 |
| *** kyleolivo has joined #openstack-horizon | 19:32 | |
| tqtran | and the python fix for the launch instance button | 19:32 |
| robcresswell | I'm off, night all o/ | 19:33 |
| tqtran | gnite robcresswell | 19:33 |
| echozdog | git gui | 19:34 |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 19:34 |
| echozdog | oops wrong window :/ | 19:34 |
| *** robcresswell has quit IRC | 19:34 | |
| matt-borland | tqtran: thanks for working on this | 19:35 |
| matt-borland | do you have your test env working? | 19:35 |
| tqtran | yep np, still need to add a few more things, WIP atm | 19:35 |
| *** rajatvig has quit IRC | 19:41 | |
| *** jwy has quit IRC | 19:43 | |
| *** TravT has joined #openstack-horizon | 19:44 | |
| *** sqchen has quit IRC | 19:44 | |
| *** ybathia has quit IRC | 19:45 | |
| *** sqchen has joined #openstack-horizon | 19:45 | |
| *** rajatvig has joined #openstack-horizon | 19:47 | |
| annashen | does horizon support configurable external url in template? | 19:50 |
| openstackgerrit | Merged openstack/horizon: Adding identity users table https://review.openstack.org/197373 | 19:50 |
| *** kbrown has quit IRC | 19:51 | |
| *** ghundal_TW has quit IRC | 19:52 | |
| david-lyle | tqtran: how are policy and ldap config settings handled in https://review.openstack.org/#/c/197373/22 ? | 19:54 |
| david-lyle | I see a policy check for list users, but none for edit | 19:54 |
| david-lyle | and I see no check to disable the edit based on https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L185 | 19:55 |
| *** rwsu has joined #openstack-horizon | 19:55 | |
| tqtran | edit isn't in yet | 19:55 |
| tqtran | the actions are coming in subsequent patches | 19:56 |
| tqtran | right now, if you click on the actions, nothing will happen | 19:56 |
| tqtran | this patch introduces only the table | 19:56 |
| david-lyle | https://review.openstack.org/#/c/197373/22/openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table-row-actions.html line 8? | 19:56 |
| tqtran | yeah, action buttons are there, but it doesn't do anything | 19:57 |
| *** jingjing_ren has joined #openstack-horizon | 19:57 | |
| tqtran | the callback isn't bound, so it resolves to null | 19:57 |
| openstackgerrit | Merged openstack/horizon: Fix eslint error on framework.module. https://review.openstack.org/200725 | 19:57 |
| david-lyle | so we show actions that don't do anything? | 19:58 |
| tqtran | for now yes | 19:58 |
| tqtran | i could include it all in one shot, but then the patch will sit there forever | 19:59 |
| david-lyle | just seems like an action should come in all at once | 20:01 |
| *** echozdog1 has joined #openstack-horizon | 20:02 | |
| tqtran | ideally, yes, that should happen. but it would bloat the patch. this is easier to review imo. the dashboard is disabled by default, so i think it should be ok? | 20:02 |
| tqtran | right now, you only enable for testing, when we're done, we can enable it by default and remove the old one, it will be almost seamless | 20:03 |
| *** cody-somerville has joined #openstack-horizon | 20:03 | |
| tqtran | "almost" | 20:03 |
| *** cody-somerville has quit IRC | 20:03 | |
| *** cody-somerville has joined #openstack-horizon | 20:03 | |
| *** e0ne is now known as e0ne_ | 20:04 | |
| *** e0ne_ is now known as e0ne | 20:04 | |
| david-lyle | tqtran: I meant do the table patch first, add action view and handling in the next | 20:04 |
| *** echozdog has quit IRC | 20:05 | |
| tqtran | ok, i can add another patch to remove all of the actions, but that is rather pointless considering that im about to add the action patches, which i would then have to re-include | 20:05 |
| *** nzeplowi has joined #openstack-horizon | 20:05 | |
| tqtran | plus, im planning on adding one action at a time, so having multiple patches that include html snippet would conflict | 20:06 |
| tqtran | and make it a bit harder, i would have to resolve merge conflict for each action patch i upload | 20:06 |
| tqtran | if i do it this way, i dont have to modify the html at all. just add the action to the controller and im set | 20:07 |
| david-lyle | that's what dependency chains are for, but I'm giving up | 20:07 |
| david-lyle | at this point it's pointless to revert, but when adding features we should think about how we're doing it | 20:07 |
| david-lyle | we're getting more debt than feature in general these days, so future promises don't mean much right now | 20:08 |
| *** matt-borland has quit IRC | 20:08 | |
| david-lyle | we're going to stop the debt train and fill in the gaps | 20:08 |
| ducttape_ | https://review.openstack.org/#/c/197373/ tqtran - will each new rewrite require 400 lines of html / js code ??? | 20:08 |
| lhcheng | ducttape_: that's just table | 20:09 |
| ducttape_ | yeah, you are not helping lhcheng :p | 20:09 |
| ducttape_ | it seems like we need the first example version of a table to really flush out "this is how you should do things, and this is reusable" | 20:10 |
| *** deuce1 has quit IRC | 20:11 | |
| ducttape_ | if it means copy and paste 400 lines of whatever, it's going to get bananas quickly | 20:11 |
| *** jwy has joined #openstack-horizon | 20:14 | |
| *** kyleolivo has quit IRC | 20:16 | |
| *** rwsu has quit IRC | 20:16 | |
| *** geoffarnold has quit IRC | 20:18 | |
| *** kyleolivo has joined #openstack-horizon | 20:18 | |
| *** lifeless has quit IRC | 20:20 | |
| *** lifeless has joined #openstack-horizon | 20:21 | |
| *** geoffarnold has joined #openstack-horizon | 20:21 | |
| *** garthb has joined #openstack-horizon | 20:25 | |
| *** dguerri` is now known as dguerri | 20:27 | |
| lhcheng | ducttape_: I think we need to write high-level directives to reduce the boilerplate code | 20:27 |
| lhcheng | this is what horizon does for the django code | 20:27 |
| ducttape_ | yeah, thats what I was looking for | 20:28 |
| ducttape_ | on the ML I saw someone saying "should we stop python and really focus on angular 100%?" - we need our first examples to be a bit more reusable / generally applicable in my mind | 20:29 |
| lhcheng | ideally, developers can write table/panel more easily without deep-diving into the details of django/angular | 20:29 |
| *** rwsu has joined #openstack-horizon | 20:29 | |
| *** tyr_ has joined #openstack-horizon | 20:30 | |
| *** tyr has quit IRC | 20:30 | |
| lhcheng | and make it easy for other projects to develop panels on their own | 20:31 |
| tqtran | that is in progress, we have plans for it | 20:31 |
| tqtran | we're just taking baby steps atm | 20:31 |
| *** geoffarn_ has joined #openstack-horizon | 20:31 | |
| ducttape_ | yep. if I was to work on designate rewrite of stuff for this angular stuff, I have no idea where I would start. and it would not end up very pretty* *to be fair, most of my code is not pretty | 20:32 |
| ducttape_ | ;) | 20:32 |
| *** pamo_ has quit IRC | 20:32 | |
| david-lyle | *true story | 20:33 |
| *** geoffarnold has quit IRC | 20:33 | |
| *** nlahouti has joined #openstack-horizon | 20:36 | |
| david-lyle | The goal is a reference implementation, we are fighting two things | 20:37 |
| david-lyle | 1) we're starting from scratch and making many mis-steps | 20:37 |
| david-lyle | this is to be expected | 20:37 |
| david-lyle | 2) understanding of this existing framework is spotty and that's creating problems | 20:38 |
| david-lyle | and the bonus item | 20:38 |
| david-lyle | 3) we're racing so fast, we're leaving things half done | 20:38 |
| david-lyle | which in the end just slows us down more | 20:39 |
| david-lyle | because people are busy trying to put out the fires from all this creation | 20:39 |
| ducttape_ | 4) PROFIT | 20:39 |
| * ducttape_ is the reason david-lyle can't have nice things | 20:40 | |
| TravT | I wouldn't exactly call taking 2 years to get anything real in angular "racing" :P | 20:40 |
| david-lyle | I'm on an opportunity based compensation system | 20:40 |
| david-lyle | not throughout the whole process, but we have this illusion that we're going to make up for lost time | 20:41 |
| *** annashen has quit IRC | 20:41 | |
| tqtran | to be fair, i have a huge patch with all of the contents already there, and it sat there for quite some time. all i really have to do is move that logic into small patches. so the work is already there, its just a matter of patch presentation for easier review. | 20:42 |
| david-lyle | tqtran: the table patch has been there for a long time. the underlying framework to make it reality has been lacking | 20:43 |
| david-lyle | we're getting much closer on that front | 20:44 |
| david-lyle | I agree | 20:44 |
| david-lyle | and we'll continue to build the example | 20:44 |
| TravT | so, i got the images table done base on the user's patch, but the next thing i'm starting to look at is making it into a directive. | 20:44 |
| TravT | because we need that to share between dashboards without copy paste | 20:44 |
| david-lyle | but as with the first on anything, we figure out what we don't know and what we need that's not there | 20:45 |
| TravT | but I for one was happy to see the patches get broken down. | 20:45 |
| TravT | and it is often difficult to create a pattern from a single concrete instance | 20:45 |
| *** sqchen has quit IRC | 20:45 | |
| TravT | for example identity users, doesn't have the admin / project need that images and instance have | 20:45 |
| david-lyle | you're welcome | 20:46 |
| david-lyle | :P | 20:46 |
| *** geoffarnold has joined #openstack-horizon | 20:46 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Images Project Panel https://review.openstack.org/200324 | 20:47 |
| *** geoffarn_ has quit IRC | 20:48 | |
| david-lyle | For me, the problem comes in the form that we're building an example. Absorbing a ton of tech debt and reorganizing the entire code tree, as well as changing the name of anything to conform to a style guide. Individually all are great, together it becomes very chaotic. | 20:49 |
| david-lyle | in it what actually works about the existing application is getting lost | 20:50 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Panel https://review.openstack.org/200324 | 20:51 |
| ducttape_ | david-lyle - so like TravT's review above, is very much partial | 20:51 |
| ducttape_ | even says so in the checkin comments pretty much | 20:52 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 20:52 |
| ducttape_ | it seems like it is inappropriate to merge half-done stuff | 20:52 |
| *** tyr_ has quit IRC | 20:52 | |
| *** tyr has joined #openstack-horizon | 20:53 | |
| ducttape_ | what if I like TravT's checkin above, but the follow on is something I detest? We are stuck at that point | 20:53 |
| *** Piet has joined #openstack-horizon | 20:54 | |
| Piet | UX Project proposal: https://review.openstack.org/#/c/199768/ | 20:54 |
| *** notmars has joined #openstack-horizon | 20:54 | |
| ducttape_ | I know this is trying to do complex stuff, and we are fining our way here, but just exploring what is ok / not so ok | 20:54 |
| *** nzeplowi has quit IRC | 20:54 | |
| *** tyr has quit IRC | 20:54 | |
| *** tyr has joined #openstack-horizon | 20:54 | |
| TravT | had we followed that approach, nothing in launch instance would have made it in. | 20:58 |
| *** deuce has joined #openstack-horizon | 20:59 | |
| *** dguerri is now known as dguerri` | 21:00 | |
| ducttape_ | I would have said launch instance could have used more of that, after trying to deploy it | 21:00 |
| *** annashen has joined #openstack-horizon | 21:01 | |
| *** echozdog has joined #openstack-horizon | 21:01 | |
| *** Piet has quit IRC | 21:02 | |
| *** geoffarn_ has joined #openstack-horizon | 21:03 | |
| *** sqchen has joined #openstack-horizon | 21:03 | |
| *** geoffarnold has quit IRC | 21:04 | |
| *** echozdog1 has quit IRC | 21:04 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Panel https://review.openstack.org/200324 | 21:04 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 21:05 |
| *** ybathia has joined #openstack-horizon | 21:05 | |
| TravT | because you had issues with deploying in different env. | 21:05 |
| TravT | which you couldn't have even tried if there was no code to deploy | 21:05 |
| * TravT starts thinking angboard was a good idea | 21:05 | |
| ducttape_ | TravT - would you recomend I try helion then? | 21:05 |
| ducttape_ | everyone is in "a different environment" | 21:06 |
| TravT | my point | 21:06 |
| TravT | exactly | 21:06 |
| TravT | maybe we should revert to python mixins. | 21:07 |
| *** crobertsrh is now known as _crobertsrh | 21:07 | |
| r1chardj0n3s | morning all | 21:07 |
| TravT | r1chardj0n3s: morning | 21:07 |
| ducttape_ | not sure I get it, but ok. I'm not pushing back on angular, I am pushing back on code that is halfway complete | 21:07 |
| r1chardj0n3s | this sounds like an interesting discussion I've stumbled into ;) | 21:07 |
| *** mwhagedorn has joined #openstack-horizon | 21:08 | |
| ducttape_ | stuff that is missing docs / communication on how stuff needs to be configured / followed as an example etc | 21:08 |
| *** Berezin has quit IRC | 21:08 | |
| TravT | here's the recap: it is hared to move a code base forward. and apparently if you can't completely rewrite the app in one big patch so that it is ready for the world to consume, you shouldn't do it. | 21:09 |
| *** absubram has quit IRC | 21:09 | |
| r1chardj0n3s | ouch, yeah | 21:09 |
| ducttape_ | part of that I agree with TravT ;) | 21:10 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Panel https://review.openstack.org/200324 | 21:10 |
| *** Berezin has joined #openstack-horizon | 21:10 | |
| *** geoffarn_ has quit IRC | 21:10 | |
| r1chardj0n3s | so yeah, it's hard, but you gotta address all that tech debt or it becomes impossible to get anything done | 21:11 |
| TravT | yeah, not an easy task any way you look at it. | 21:11 |
| *** doug-fish has left #openstack-horizon | 21:11 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 21:12 |
| david-lyle | TravT: I don't think any one is arguing the difficulty, but some of the debt got swept and newer shiny things are taking their place | 21:12 |
| *** Berezin has quit IRC | 21:12 | |
| r1chardj0n3s | and rewrites from scratch are almost never a good idea | 21:12 |
| david-lyle | we added missing tests to launch, so that part got addressed +1 | 21:13 |
| david-lyle | we're addressing localization, also +1 | 21:13 |
| david-lyle | extensibility and documentation are not | 21:14 |
| david-lyle | and those are key hurdles for deployers | 21:14 |
| ducttape_ | I think TravT and tqtran, maybe r1chardj0n3s too, has enough insight to write docs on "this is how others should extend horizon in the new world" Having some vision of this would help me | 21:14 |
| tqtran | extensibility right now follows the old way, we havent change that | 21:15 |
| TravT | david-lyle: we made docs and getting the patches for LI done a top priority | 21:15 |
| tqtran | its part of the plugin architecture that we have had for some time now | 21:15 |
| TravT | and that has been what we spent most our time on to this point in Liberty | 21:16 |
| TravT | agreed whole heartedly on extensiblity | 21:16 |
| david-lyle | orly? | 21:16 |
| tqtran | the only "new" thing is how you can extend angular, but that cant be documented if the patch for it is still going in | 21:16 |
| ducttape_ | tqtran - the plugin stuff is pretty thin right now, and eventually you are doing a lot of python stuff | 21:16 |
| *** clu__ has quit IRC | 21:16 | |
| *** matt-borland has joined #openstack-horizon | 21:16 | |
| *** jingjing_ren has quit IRC | 21:18 | |
| *** lblanchard has quit IRC | 21:19 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 21:20 |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 21:21 |
| *** neelashah has quit IRC | 21:21 | |
| *** bpokorny has quit IRC | 21:23 | |
| *** jbell8 has quit IRC | 21:26 | |
| TravT | so, i think we should work on the shareable directives next, like lhcheng mentioned. | 21:26 |
| TravT | tqtran^ | 21:26 |
| TravT | but, we can't do it at the expense of customization | 21:27 |
| *** matt-borland has quit IRC | 21:28 | |
| *** Sukhdev has quit IRC | 21:31 | |
| *** dboik_ has joined #openstack-horizon | 21:31 | |
| *** neelashah has joined #openstack-horizon | 21:34 | |
| *** e0ne has quit IRC | 21:35 | |
| *** dboik has quit IRC | 21:35 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move tech-debt into app/ https://review.openstack.org/197353 | 21:35 |
| *** dboik_ has quit IRC | 21:36 | |
| openstackgerrit | Coleman Beasley proposed openstack/horizon: JSCS Cleanup-style guide cleanup for filters.js https://review.openstack.org/199789 | 21:40 |
| *** nzeplowi has joined #openstack-horizon | 21:41 | |
| *** nzeplowi has quit IRC | 21:42 | |
| *** jingjing_ren has joined #openstack-horizon | 21:42 | |
| *** cody-somerville has quit IRC | 21:44 | |
| *** Sukhdev has joined #openstack-horizon | 21:44 | |
| *** Piet has joined #openstack-horizon | 21:45 | |
| *** julim has quit IRC | 21:46 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move workflow into app/core https://review.openstack.org/197347 | 21:48 |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Makes policy.check aware of domain scoped token https://review.openstack.org/196068 | 21:49 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move cloud-services into app/core https://review.openstack.org/197334 | 21:50 |
| *** jtriley has quit IRC | 21:51 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 21:52 |
| *** albertom has quit IRC | 21:58 | |
| *** cody-somerville has joined #openstack-horizon | 21:58 | |
| krotscheck | r1chardj0n3s: I guess we disagree on best practices, eh? | 22:00 |
| r1chardj0n3s | krotscheck: in this single instance, yes | 22:00 |
| krotscheck | r1chardj0n3s: That's ok, you're allowed to be wrong. :) | 22:00 |
| r1chardj0n3s | it's like asking Python developers to manually invoke __del__ all over | 22:00 |
| krotscheck | r1chardj0n3s: It's really not. __del__ is a language construct. on($destroy) is a framework construct. | 22:01 |
| r1chardj0n3s | ... and on($destroy) will be called *because the framework is cleaning up* | 22:01 |
| * r1chardj0n3s shakes head | 22:01 | |
| tqtran | I'll have to side with r1chardj0n3s on this | 22:02 |
| krotscheck | r1chardj0n3s: At no point does the framework actually guarantee that. There's no specification, as there is with python, that does that. Furthermore, it _never_ guards against an engineer not dereferencing properly and having the scope destruction not catch the event listener anyway. | 22:02 |
| *** rajatvig has quit IRC | 22:02 | |
| *** jcoufal has joined #openstack-horizon | 22:02 | |
| *** tjones1 has joined #openstack-horizon | 22:02 | |
| *** kyleolivo has quit IRC | 22:03 | |
| *** petertr7 is now known as petertr7_away | 22:03 | |
| krotscheck | r1chardj0n3s, tqtran: Tell ya what. Show me a framework specification that _explicitly guarantees it_ and makes sure that every version of angular out there will do this, or be ejected from their packaging, and I'll side with you. | 22:04 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding Angular Project Images Table https://review.openstack.org/200385 | 22:04 |
| krotscheck | But you can't. Because there isn't. | 22:04 |
| *** albertom has joined #openstack-horizon | 22:04 | |
| krotscheck | But hey, if you want horizon to leave dangling listeners all over the place, that's your prerogative as core. | 22:04 |
| *** jcoufal_ has joined #openstack-horizon | 22:04 | |
| tqtran | I agree that for directives, an explicit removal of it might be needed, but im just not sure we want a blanket approach | 22:05 |
| krotscheck | tqtran: Engineers are creatures of habit, we like to do things one way. If we set a rule in place that is "Do this thing, except in case X Y and Z", then you're muddying the water. | 22:06 |
| krotscheck | It assumes that everyone who reads that rule has enough expert understanding to know why X, Y, and Z. | 22:06 |
| *** tvanderwiel has quit IRC | 22:07 | |
| *** ydixon has joined #openstack-horizon | 22:07 | |
| *** jcoufal has quit IRC | 22:07 | |
| *** rajatvig has joined #openstack-horizon | 22:08 | |
| *** kyleolivo has joined #openstack-horizon | 22:08 | |
| *** ybathia has quit IRC | 22:08 | |
| Piet | Please +1 the UX Project proposal? https://review.openstack.org/#/c/199768/ That is assuming that you are comfortable with it! If not, then please let me know why. | 22:09 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 22:09 |
| *** peristeri has quit IRC | 22:11 | |
| *** deuce has quit IRC | 22:13 | |
| *** jcoufal_ has quit IRC | 22:15 | |
| *** pauloewerton has quit IRC | 22:18 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: WIP Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 22:18 |
| *** alexpilotti has joined #openstack-horizon | 22:19 | |
| *** tyr has quit IRC | 22:25 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 22:26 |
| *** rajatvig has quit IRC | 22:26 | |
| *** pamo has joined #openstack-horizon | 22:27 | |
| *** rajatvig has joined #openstack-horizon | 22:28 | |
| *** mpavlase has joined #openstack-horizon | 22:30 | |
| *** nzeplowi has joined #openstack-horizon | 22:30 | |
| *** bradjones has quit IRC | 22:33 | |
| r1chardj0n3s | krotscheck: creatures of habit, indeed | 22:36 |
| *** ybathia has joined #openstack-horizon | 22:39 | |
| *** mpavlase has quit IRC | 22:40 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Disable angular/ng_window_service on the service-api specs https://review.openstack.org/199333 | 22:44 |
| TravT | david-lyle: are you around? | 22:45 |
| david-lyle | TravT: for a minute, just about to leave | 22:46 |
| david-lyle | what's up? | 22:46 |
| TravT | between dashboards today | 22:47 |
| TravT | e.g. admin and project | 22:47 |
| openstackgerrit | KBrown proposed openstack/horizon: JSCS Cleanup - Fix eslint errors in flavor https://review.openstack.org/201359 | 22:47 |
| *** jtriley has joined #openstack-horizon | 22:47 | |
| TravT | i can disable project and admin can still function, because the python packages are server side | 22:48 |
| pamo | TravT: where does _100_project_images_panel.py live? | 22:49 |
| pamo | re: https://review.openstack.org/#/c/200385/12//COMMIT_MSG | 22:49 |
| TravT | pamo: will update that commit message | 22:49 |
| tqtran | pamo its 103_ | 22:49 |
| *** stevemar has quit IRC | 22:50 | |
| TravT | david-lyle: sorry, three people talking to me | 22:50 |
| david-lyle | I was trying to stake out _100 - _110 for data_processing, but shrug | 22:50 |
| david-lyle | easy to rename | 22:51 |
| TravT | david-lyle: can change that | 22:51 |
| TravT | anyway, on the js side, | 22:51 |
| TravT | if we disable project | 22:51 |
| TravT | none of the js come to client side | 22:51 |
| *** stevemar has joined #openstack-horizon | 22:51 | |
| TravT | right? | 22:51 |
| TravT | or am i missing something? | 22:51 |
| TravT | just starting to look at sharing images table js from project to admin | 22:51 |
| *** notmars has quit IRC | 22:51 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/django_openstack_auth: Configurable token hashing https://review.openstack.org/201360 | 22:52 |
| *** rwsu has quit IRC | 22:52 | |
| david-lyle | my original intent was to use RBAC to combine the project and admin dash | 22:53 |
| TravT | yeah, i was wondering about that as well... | 22:53 |
| david-lyle | since there are more than two roles we should be worrying about | 22:53 |
| david-lyle | the problem is, it does provide a nice contextual split between operating on one thing I own and any of a number of things in a larger collection | 22:54 |
| david-lyle | so I backed off on that a bit | 22:54 |
| david-lyle | but even if the JS goes to the client side, the RBAC in the services will block the call | 22:54 |
| david-lyle | for some common items like usage, we have openstack_dashboard/usage today | 22:55 |
| TravT | so we could put all of images in the openstack_dashboard/static/images | 22:55 |
| *** rajatvig has quit IRC | 22:55 | |
| TravT | not quite that.. but just not under project | 22:56 |
| david-lyle | if we want to share static content across dashboards I would think we just need to move it to a common level | 22:56 |
| *** stevemar has quit IRC | 22:56 | |
| david-lyle | right | 22:56 |
| TravT | and then within project we still have html, we just pull in that stuff | 22:56 |
| TravT | since it is part of core app | 22:56 |
| TravT | via directive perhaps | 22:56 |
| david-lyle | makes sense to me | 22:56 |
| david-lyle | even iIFwe address the funky UX of project/admin dashes, we would still need what you're suggesting in the interim | 22:57 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: Use an explict __globalTestHelpers__ instead of window in service-api specs https://review.openstack.org/199333 | 22:57 |
| david-lyle | *even IF | 22:57 |
| david-lyle | so I'd go with that | 22:58 |
| *** cody-somerville has quit IRC | 22:58 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Use explict __globalTestHelpers__ in service-api specs https://review.openstack.org/199333 | 22:58 |
| TravT | well, i'll play with that a bit | 22:58 |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Multidomain false and project admin support https://review.openstack.org/199251 | 22:58 |
| david-lyle | TravT: have fun :) | 22:58 |
| TravT | wheee!!! | 22:59 |
| *** rajatvig has joined #openstack-horizon | 22:59 | |
| david-lyle | I have a board to hit your head with if that doesn't prove sufficiently enjoyable :P | 22:59 |
| TravT | lol | 22:59 |
| tqtran | i have a sign that says "bang your head here" | 22:59 |
| david-lyle | I'm thinking about reinforcing my walls in my office | 23:00 |
| david-lyle | too many dents | 23:00 |
| tqtran | lol | 23:00 |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Fix eslint metadata-tree widgets. https://review.openstack.org/200752 | 23:00 |
| david-lyle | have to run, later | 23:01 |
| TravT | ttyl | 23:01 |
| openstackgerrit | KBrown proposed openstack/horizon: JSCS Cleanup - Fix eslint errors in source spec file https://review.openstack.org/201363 | 23:01 |
| *** Drago has quit IRC | 23:02 | |
| *** tjones1 has quit IRC | 23:05 | |
| *** jingjing_ren has quit IRC | 23:09 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Multidomain false and project admin support https://review.openstack.org/199251 | 23:10 |
| *** nzeplowi has quit IRC | 23:11 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: WIP - Project Admin support for Domains https://review.openstack.org/201277 | 23:12 |
| *** mgarza_ has quit IRC | 23:12 | |
| *** nzeplowi has joined #openstack-horizon | 23:13 | |
| *** ducttape_ has quit IRC | 23:16 | |
| *** deuce has joined #openstack-horizon | 23:17 | |
| *** jtriley has quit IRC | 23:18 | |
| *** chlong-afk has joined #openstack-horizon | 23:18 | |
| *** darrenc is now known as darrenc_afk | 23:19 | |
| openstackgerrit | Dan Nguyen proposed openstack/django_openstack_auth: Makes policy.check aware of domain scoped token https://review.openstack.org/196328 | 23:21 |
| *** jtriley has joined #openstack-horizon | 23:22 | |
| *** yamamoto has joined #openstack-horizon | 23:23 | |
| *** yamamoto has quit IRC | 23:23 | |
| *** deuce has quit IRC | 23:25 | |
| *** nzeplowi has quit IRC | 23:26 | |
| openstackgerrit | Kyle Olivo proposed openstack/horizon: JSCS Cleanup - Fix eslint metadata-tree widgets. https://review.openstack.org/200752 | 23:33 |
| *** chlong-afk has quit IRC | 23:36 | |
| kzaitsev_mb | folks, I've had a conversation with dims from oslo today, and he suggested I volounteer as a OSLO CPL (https://wiki.openstack.org/wiki/CrossProjectLiaisons) for horizon. I would gladly do so, but I feel, that this should be approved by horizon community, since I'm not (at least not yet =)) a well known top contributor to horizon. What do you think? | 23:37 |
| *** nzeplowi has joined #openstack-horizon | 23:38 | |
| kzaitsev_mb | Should I ask about this during the next meeting this Wednesday, for example? | 23:38 |
| lhcheng | kzaitsev_mb: that sounds good | 23:40 |
| lhcheng | add it to the next meeting agenda: https://wiki.openstack.org/wiki/Meetings/Horizon | 23:40 |
| *** kyleolivo has quit IRC | 23:42 | |
| lhcheng | kzaitsev_mb: we also have something for you that we need help with :) | 23:42 |
| lhcheng | https://bugs.launchpad.net/horizon/+bug/1416516 | 23:42 |
| openstack | Launchpad bug 1416516 in OpenStack Dashboard (Horizon) "use of oslo config in code uses two different versions" [Medium,Confirmed] | 23:42 |
| *** kyleolivo has joined #openstack-horizon | 23:42 | |
| *** darrenc_afk is now known as darrenc | 23:42 | |
| *** ducttape_ has joined #openstack-horizon | 23:44 | |
| *** jwy1 has joined #openstack-horizon | 23:44 | |
| *** Sukhdev has quit IRC | 23:44 | |
| *** nzeplowi has quit IRC | 23:45 | |
| *** jwy has quit IRC | 23:47 | |
| *** ducttape_ has quit IRC | 23:48 | |
| *** kyleolivo has quit IRC | 23:52 | |
| *** yamamoto has joined #openstack-horizon | 23:52 | |
| *** kyleolivo has joined #openstack-horizon | 23:52 | |
| *** stevemar has joined #openstack-horizon | 23:53 | |
| *** annashen has quit IRC | 23:54 | |
| *** kyleolivo has quit IRC | 23:54 | |
| *** kyleolivo has joined #openstack-horizon | 23:55 | |
| *** ydixon has quit IRC | 23:56 | |
| *** nzeplowi has joined #openstack-horizon | 23:57 | |
| *** stevemar has quit IRC | 23:57 | |
| *** bradjones has joined #openstack-horizon | 23:58 | |
| *** bradjones has quit IRC | 23:58 | |
| *** bradjones has joined #openstack-horizon | 23:58 | |
| openstackgerrit | KBrown proposed openstack/horizon: JSCS Cleanup - Fix eslint errors in workflow file https://review.openstack.org/201374 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!