tqtran | sqchen, tyr: ok testing the auto collect on panel now | 00:00 |
---|---|---|
*** jmolo has joined #openstack-horizon | 00:00 | |
tqtran | seems like it worked :) | 00:00 |
tqtran | although scss have to be added manually | 00:00 |
kfox1111_ | cool. I'll have a look. thanks. :) | 00:01 |
kfox1111_ | if you copy my_panel to mypanel2 and remove the static subdir, can you still use mycontroller? | 00:02 |
*** alexvictorchan has quit IRC | 00:03 | |
*** tjones has quit IRC | 00:03 | |
*** tjones has joined #openstack-horizon | 00:04 | |
*** lucas__ has joined #openstack-horizon | 00:04 | |
*** nlahouti1 has joined #openstack-horizon | 00:07 | |
sqchen | tqtran, yes, we should create a approach to add scss automatically. | 00:08 |
*** rajatvig has quit IRC | 00:08 | |
*** lucas__ has quit IRC | 00:08 | |
sqchen | this enabled another level of scss plugin/customization | 00:08 |
openstackgerrit | Dan Siwiec proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 00:10 |
*** nlahouti has quit IRC | 00:10 | |
*** jasondotstar has quit IRC | 00:11 | |
tqtran | kfox1111_: yes | 00:11 |
tqtran | assuming that you enabled my_panel | 00:12 |
kfox1111_ | k. | 00:12 |
kfox1111_ | trying to merge in the code... | 00:12 |
tqtran | but you shouldnt do that, each panel really should have its own controller | 00:12 |
tqtran | there can be common services they share, but controller is not one of them | 00:12 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS Cleanup - Metadata widgets cleanup https://review.openstack.org/203795 | 00:13 |
kfox1111_ | the code is going to end up being exactly the same, just 2 different ways of filtering the data. | 00:13 |
kfox1111_ | one panel showing the entries that are "launchable". the other showing all entries. | 00:14 |
kfox1111_ | so sharing the javascript makes sense. | 00:15 |
kfox1111_ | for example, still having the issue where encodeURIComponentFilter isn't in scope. | 00:15 |
kfox1111_ | its generic enough to use from both panels... | 00:15 |
kfox1111_ | ah... I see. something like: ng-controller="admin.my-panel.controller as ctrl" | 00:16 |
*** jasondotstar has joined #openstack-horizon | 00:17 | |
kfox1111_ | hmm... but the controller name is also named admin.my-panel.controller... so is it just global then? | 00:19 |
*** Piet has quit IRC | 00:21 | |
kfox1111_ | hmmm... I do see the javascript inside the compiled .js file. | 00:23 |
kfox1111_ | so it is including it now. | 00:23 |
kfox1111_ | just for some reason its out of scope of templates/my_panel/index.html | 00:23 |
*** david-lyle has quit IRC | 00:24 | |
*** lhcheng_ has joined #openstack-horizon | 00:24 | |
*** lhcheng_ has left #openstack-horizon | 00:24 | |
*** jmolo has quit IRC | 00:25 | |
*** dansiwie_ has quit IRC | 00:25 | |
*** dansiwiec has joined #openstack-horizon | 00:25 | |
kfox1111_ | Ahh.. there we go. miss spelled ADD_ANGULAR_MODULES | 00:26 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS Cleanup - Metadata widgets cleanup https://review.openstack.org/203795 | 00:26 |
kfox1111_ | ok. now into the horizon changes themselves... seeing Unknown provider: heatAPIProvider <- heatAPI <- appCatalogTableCtrl... | 00:27 |
*** dansiwiec has quit IRC | 00:30 | |
*** dansiwiec has joined #openstack-horizon | 00:31 | |
*** dansiwiec has quit IRC | 00:33 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Add HTTP Async Batch call https://review.openstack.org/206772 | 00:33 |
openstackgerrit | Thai Tran proposed openstack/horizon: Add HTTP Async Batch call https://review.openstack.org/206772 | 00:33 |
*** garthb has quit IRC | 00:35 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 00:36 |
tqtran | kfox1111_: if you provide me a link to your repo, i can help debug it | 00:37 |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 00:38 |
*** albertom has quit IRC | 00:39 | |
kfox1111_ | tqtran: sec... this part of the code's actually part of horizon... to be contributed. let me get a review going. | 00:39 |
*** Guest4324 has quit IRC | 00:39 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Create a Bootstrap Theme Preview Page with HTML Hints https://review.openstack.org/187818 | 00:41 |
*** albertom has joined #openstack-horizon | 00:43 | |
openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 00:43 |
kfox1111_ | tqtran: ^---- that one. :) | 00:43 |
kfox1111_ | Trying to make use of heatAPI in the plugin and its not registered quite right. | 00:43 |
kfox1111_ | bbiab. | 00:44 |
tqtran | in your horizon folder, do you have the patch enabled? | 00:44 |
tqtran | you might be on master, thats why its not seeing it? | 00:44 |
kfox1111_ | I'm taking master, adding that patch, and then installing my plugin on top of it. | 00:44 |
kfox1111_ | the plugin tries to use heatAPI as provided by the review. | 00:45 |
kfox1111_ | since ideally horizon would provide that long term. | 00:45 |
kfox1111_ | I'll get the plugin into a git repo maybe tomorrow. we're creating a stackforge repo for it. | 00:45 |
kfox1111_ | I'm on the right branch. kfox2@mantis:~/svn/horizon-app-catalog4$ git branch | 00:46 |
kfox1111_ | * app-catalog-deps | 00:46 |
kfox1111_ | bbiab. | 00:46 |
*** bpokorny has quit IRC | 00:50 | |
*** yingjun has joined #openstack-horizon | 00:50 | |
*** bpokorny has joined #openstack-horizon | 00:51 | |
*** sqchen has quit IRC | 00:54 | |
*** tyr has quit IRC | 00:56 | |
*** bpokorny has quit IRC | 00:56 | |
*** zhenguo has joined #openstack-horizon | 00:57 | |
*** ybathia has quit IRC | 01:00 | |
*** garthb has joined #openstack-horizon | 01:00 | |
*** garthb_ has joined #openstack-horizon | 01:00 | |
*** garthb_ has quit IRC | 01:00 | |
*** lucas____ has joined #openstack-horizon | 01:05 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Moving Trove to contrib https://review.openstack.org/206780 | 01:05 |
*** tjones has quit IRC | 01:06 | |
*** drupalmonkey has quit IRC | 01:09 | |
*** lucas____ has quit IRC | 01:10 | |
kfox1111_ | back. | 01:10 |
*** xiangxinyong has joined #openstack-horizon | 01:10 | |
*** jasondotstar has quit IRC | 01:12 | |
kfox1111_ | hmm... ok. so the other panel uses glanceAPI which should be fine in horizon and that one's failing too. so it may be the plugin after all. I'll post the code as soon as I can. thanks. | 01:15 |
*** shivrao has quit IRC | 01:16 | |
*** xiangxinyong1 has joined #openstack-horizon | 01:16 | |
openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Configurable token hashing https://review.openstack.org/206765 | 01:17 |
*** jasondotstar has joined #openstack-horizon | 01:17 | |
*** xiangxinyong has quit IRC | 01:19 | |
openstackgerrit | ziyu032 proposed openstack/horizon: Display the project name in user detail page https://review.openstack.org/205983 | 01:19 |
*** jasondotstar has quit IRC | 01:22 | |
*** annashen has joined #openstack-horizon | 01:26 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Add HTTP Async Batch call https://review.openstack.org/206772 | 01:28 |
tqtran | kfox1111_: sure thing, im gonna take off for now, but i can help debug once you have the code up | 01:28 |
kfox1111_ | k. thanks for the help. | 01:29 |
*** tqtran has quit IRC | 01:29 | |
*** nlahouti1 has quit IRC | 01:30 | |
*** annashen has quit IRC | 01:31 | |
*** jbell8 has joined #openstack-horizon | 01:32 | |
openstackgerrit | LIU Yulong proposed openstack/horizon: Add floating IP panel to admin dashboard https://review.openstack.org/143628 | 01:33 |
*** lucas____ has joined #openstack-horizon | 01:33 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Add HTTP Async Batch call https://review.openstack.org/206772 | 01:35 |
*** lhcheng has joined #openstack-horizon | 01:36 | |
*** lhcheng has left #openstack-horizon | 01:36 | |
*** lucas____ has quit IRC | 01:37 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Add HTTP Async Batch call https://review.openstack.org/206772 | 01:41 |
*** lexholden has quit IRC | 01:43 | |
*** linkedinyou has joined #openstack-horizon | 01:47 | |
*** yamamoto has joined #openstack-horizon | 01:51 | |
*** annashen has joined #openstack-horizon | 01:55 | |
*** annashen has quit IRC | 02:00 | |
*** skylerberg has quit IRC | 02:02 | |
openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 02:03 |
kfox1111_ | Plugin's fully working external with ^--- applied. :) | 02:04 |
*** garthb has quit IRC | 02:10 | |
*** annashen has joined #openstack-horizon | 02:10 | |
*** annashen has quit IRC | 02:12 | |
*** Drago has quit IRC | 02:16 | |
*** dboik has joined #openstack-horizon | 02:18 | |
*** david-lyle has joined #openstack-horizon | 02:19 | |
*** ChanServ sets mode: +o david-lyle | 02:19 | |
*** david-lyle has quit IRC | 02:23 | |
*** yingjun has quit IRC | 02:25 | |
*** Piet has joined #openstack-horizon | 02:26 | |
*** annashen has joined #openstack-horizon | 02:27 | |
*** dboik has quit IRC | 02:27 | |
*** dboik has joined #openstack-horizon | 02:27 | |
*** bpokorny has joined #openstack-horizon | 02:28 | |
*** yingjun has joined #openstack-horizon | 02:31 | |
*** annashen has quit IRC | 02:32 | |
*** lucas__ has joined #openstack-horizon | 02:34 | |
*** jacalcat_ has joined #openstack-horizon | 02:35 | |
*** lucas__ has quit IRC | 02:39 | |
*** saksham has quit IRC | 02:46 | |
*** sqchen has joined #openstack-horizon | 02:50 | |
*** KunalGandhi has quit IRC | 02:50 | |
*** sqchen has quit IRC | 02:52 | |
*** jacalcat_ has quit IRC | 03:02 | |
*** dansiwiec has joined #openstack-horizon | 03:03 | |
*** tjones has joined #openstack-horizon | 03:04 | |
*** jbell8 has quit IRC | 03:06 | |
*** jbell8 has joined #openstack-horizon | 03:07 | |
*** dboik has quit IRC | 03:08 | |
*** dboik has joined #openstack-horizon | 03:09 | |
*** annashen has joined #openstack-horizon | 03:10 | |
*** dansiwiec has quit IRC | 03:12 | |
*** dboik has quit IRC | 03:14 | |
*** drupalmonkey has joined #openstack-horizon | 03:20 | |
openstackgerrit | Li Yingjun proposed openstack/horizon: Disable lagency launch when LAUNCH_INSTANCE_LEGACY_ENABLED is False https://review.openstack.org/206802 | 03:28 |
*** drupalmonkey has quit IRC | 03:30 | |
*** annashen_ has joined #openstack-horizon | 03:32 | |
*** tjones has quit IRC | 03:33 | |
*** david-lyle has joined #openstack-horizon | 03:34 | |
*** ChanServ sets mode: +o david-lyle | 03:34 | |
*** annashen has quit IRC | 03:35 | |
*** radez is now known as radez_g0n3 | 03:39 | |
*** ducttape_ has joined #openstack-horizon | 03:44 | |
*** fedexo has joined #openstack-horizon | 03:46 | |
*** bpokorny has quit IRC | 03:47 | |
*** jingjing_ren has joined #openstack-horizon | 03:48 | |
*** yingjun has quit IRC | 03:51 | |
*** jingjing_ren has quit IRC | 03:51 | |
*** amotoki has joined #openstack-horizon | 03:56 | |
*** annashen has joined #openstack-horizon | 03:58 | |
*** ducttape_ has quit IRC | 04:00 | |
*** sayan has joined #openstack-horizon | 04:01 | |
*** jhesketh has quit IRC | 04:01 | |
*** jhesketh has joined #openstack-horizon | 04:02 | |
*** annashen has quit IRC | 04:03 | |
*** sqchen has joined #openstack-horizon | 04:04 | |
*** annashen_ has quit IRC | 04:07 | |
*** dboik has joined #openstack-horizon | 04:09 | |
*** vishwanathj has joined #openstack-horizon | 04:10 | |
*** sqchen has quit IRC | 04:13 | |
*** dboik has quit IRC | 04:14 | |
*** fedexo has quit IRC | 04:21 | |
*** sqchen has joined #openstack-horizon | 04:32 | |
*** xiangxinyong1 has quit IRC | 04:36 | |
*** lucas__ has joined #openstack-horizon | 04:38 | |
*** lucas__ has quit IRC | 04:42 | |
*** sqchen has quit IRC | 04:42 | |
*** ducttape_ has joined #openstack-horizon | 04:44 | |
*** fedexo has joined #openstack-horizon | 04:48 | |
*** ducttape_ has quit IRC | 04:48 | |
*** annashen has joined #openstack-horizon | 04:49 | |
*** masco has joined #openstack-horizon | 04:50 | |
*** stevemar has joined #openstack-horizon | 04:56 | |
*** annashen_ has joined #openstack-horizon | 04:59 | |
*** annashen_ has quit IRC | 05:03 | |
*** sqchen has joined #openstack-horizon | 05:05 | |
*** KunalGandhi has joined #openstack-horizon | 05:06 | |
*** KunalGan_ has joined #openstack-horizon | 05:09 | |
*** annashen has quit IRC | 05:10 | |
*** KunalGandhi has quit IRC | 05:11 | |
*** annashen has joined #openstack-horizon | 05:16 | |
*** stevemar has quit IRC | 05:19 | |
*** stevemar has joined #openstack-horizon | 05:20 | |
*** stevemar has quit IRC | 05:24 | |
*** nlahouti has joined #openstack-horizon | 05:34 | |
*** sayan has quit IRC | 05:38 | |
*** lucas__ has joined #openstack-horizon | 05:40 | |
*** lucas__ has quit IRC | 05:44 | |
*** fedexo has quit IRC | 05:45 | |
*** fedexo has joined #openstack-horizon | 05:46 | |
*** yamamoto has quit IRC | 05:50 | |
*** nlahouti has quit IRC | 05:51 | |
*** nlahouti has joined #openstack-horizon | 05:51 | |
*** yingjun has joined #openstack-horizon | 05:55 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS Cleanup - Metadata widgets cleanup https://review.openstack.org/203795 | 05:56 |
*** fedexo has quit IRC | 05:57 | |
*** nlahouti has quit IRC | 05:59 | |
*** annashen_ has joined #openstack-horizon | 06:00 | |
*** annashen has quit IRC | 06:00 | |
*** annashen_ has quit IRC | 06:04 | |
*** kiran-r has joined #openstack-horizon | 06:05 | |
*** xiangxinyong1 has joined #openstack-horizon | 06:15 | |
*** MaxV has joined #openstack-horizon | 06:15 | |
openstackgerrit | Merged openstack/horizon: Adding PUT to REST api service https://review.openstack.org/206639 | 06:18 |
*** sqchen has quit IRC | 06:21 | |
*** sqchen has joined #openstack-horizon | 06:22 | |
*** josecastroleon has joined #openstack-horizon | 06:22 | |
*** yamamoto has joined #openstack-horizon | 06:22 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/206881 | 06:23 |
*** jbell8 has quit IRC | 06:27 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Use mock module to avoid using window https://review.openstack.org/199333 | 06:29 |
*** rajatvig has joined #openstack-horizon | 06:30 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 06:31 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/206891 | 06:32 |
*** rahulshivsharan has joined #openstack-horizon | 06:32 | |
*** zhenguo has quit IRC | 06:32 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Fix ISO tests https://review.openstack.org/199686 | 06:34 |
*** zhenguo has joined #openstack-horizon | 06:40 | |
*** lucas__ has joined #openstack-horizon | 06:42 | |
*** MaxV has quit IRC | 06:44 | |
*** lucas__ has quit IRC | 06:46 | |
*** kfox1111_ has quit IRC | 06:47 | |
*** MaxV has joined #openstack-horizon | 06:52 | |
*** markus_z has joined #openstack-horizon | 06:58 | |
*** sqchen has quit IRC | 06:59 | |
*** annashen has joined #openstack-horizon | 07:01 | |
*** MaxV has quit IRC | 07:01 | |
*** annashen has quit IRC | 07:05 | |
*** sqchen has joined #openstack-horizon | 07:14 | |
*** sqchen has quit IRC | 07:14 | |
*** mpavlase has joined #openstack-horizon | 07:15 | |
*** rajatvig has quit IRC | 07:15 | |
*** KunalGan_ has quit IRC | 07:25 | |
*** kmARC has joined #openstack-horizon | 07:28 | |
openstackgerrit | lyanchih proposed openstack/horizon: Couldn't provision instance from volume snapshot https://review.openstack.org/199457 | 07:30 |
*** rdopiera has joined #openstack-horizon | 07:34 | |
*** markus_z has quit IRC | 07:34 | |
*** rdopiera_ has joined #openstack-horizon | 07:35 | |
*** romainh has joined #openstack-horizon | 07:36 | |
*** rdopiera_ has quit IRC | 07:36 | |
*** rdopiera has quit IRC | 07:36 | |
*** rdopiera has joined #openstack-horizon | 07:36 | |
*** JeanBriceCombebi has joined #openstack-horizon | 07:38 | |
*** lucas__ has joined #openstack-horizon | 07:43 | |
*** lucas__ has quit IRC | 07:48 | |
*** markus_z has joined #openstack-horizon | 07:51 | |
*** sayan has joined #openstack-horizon | 07:51 | |
*** bfic has joined #openstack-horizon | 07:51 | |
*** bluex-pl has joined #openstack-horizon | 07:51 | |
*** bluex-pl has quit IRC | 07:51 | |
*** annashen has joined #openstack-horizon | 08:01 | |
*** xiangxinyong2 has joined #openstack-horizon | 08:01 | |
*** annashen_ has joined #openstack-horizon | 08:02 | |
*** xiangxinyong1 has quit IRC | 08:04 | |
*** rahulshivsharan has quit IRC | 08:05 | |
*** annashen has quit IRC | 08:05 | |
*** annashen_ has quit IRC | 08:06 | |
*** lucas__ has joined #openstack-horizon | 08:08 | |
*** lucas__ has quit IRC | 08:12 | |
*** ygbo has joined #openstack-horizon | 08:14 | |
*** yingjun has quit IRC | 08:15 | |
*** KingKhan has joined #openstack-horizon | 08:20 | |
*** robcresswell has joined #openstack-horizon | 08:22 | |
*** KunalGandhi has joined #openstack-horizon | 08:23 | |
*** ^Gal^ has quit IRC | 08:23 | |
*** ^Gal^ has joined #openstack-horizon | 08:23 | |
*** yingjun has joined #openstack-horizon | 08:24 | |
*** jasondotstar has joined #openstack-horizon | 08:25 | |
*** KunalGandhi has quit IRC | 08:27 | |
*** MaxV has joined #openstack-horizon | 08:28 | |
openstackgerrit | ziyu032 proposed openstack/horizon: Confirm Dialog for Delete operation in Network Topology https://review.openstack.org/128873 | 08:30 |
*** MaxV has quit IRC | 08:34 | |
*** e0ne has joined #openstack-horizon | 08:40 | |
*** markus_z has quit IRC | 08:43 | |
*** e0ne has quit IRC | 08:43 | |
*** markus_z has joined #openstack-horizon | 08:43 | |
*** yingjun has quit IRC | 08:44 | |
*** Ala has joined #openstack-horizon | 08:49 | |
*** MaxV has joined #openstack-horizon | 08:50 | |
*** ZZelle has quit IRC | 08:53 | |
*** ZZelle has joined #openstack-horizon | 08:53 | |
*** JeanBriceCombebi has quit IRC | 08:58 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:58 | |
*** markus_z has quit IRC | 09:02 | |
*** annashen has joined #openstack-horizon | 09:02 | |
*** jtomasek has quit IRC | 09:05 | |
*** amotoki has quit IRC | 09:05 | |
*** jtomasek has joined #openstack-horizon | 09:06 | |
*** annashen has quit IRC | 09:07 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 09:13 |
*** lexholden has joined #openstack-horizon | 09:17 | |
*** markus_z has joined #openstack-horizon | 09:19 | |
*** alexpilotti has joined #openstack-horizon | 09:24 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 09:24 |
*** yamamoto has quit IRC | 09:26 | |
-openstackstatus- NOTICE: Currently our CI system is broken, jobs are not getting processed at all. | 09:28 | |
*** ChanServ changes topic to "Currently our CI system is broken, jobs are not getting processed at all." | 09:28 | |
*** yamamoto has joined #openstack-horizon | 09:35 | |
*** yingjun has joined #openstack-horizon | 09:35 | |
*** yingjun has quit IRC | 09:35 | |
*** bluex-pl has joined #openstack-horizon | 09:37 | |
*** romainh has left #openstack-horizon | 09:37 | |
*** bluex-pl has quit IRC | 09:37 | |
*** bluex-pl has joined #openstack-horizon | 09:37 | |
*** romainh has joined #openstack-horizon | 09:39 | |
*** sayan_ has joined #openstack-horizon | 09:40 | |
*** sayan has quit IRC | 09:40 | |
*** kzaitsev_mb has quit IRC | 09:40 | |
*** kzaitsev_mb has joined #openstack-horizon | 09:40 | |
*** kzaitsev_mb has quit IRC | 09:45 | |
*** markus_z has quit IRC | 09:46 | |
*** sayan_ has quit IRC | 09:47 | |
*** sayan has joined #openstack-horizon | 09:49 | |
*** e0ne has joined #openstack-horizon | 09:57 | |
*** jasondotstar has quit IRC | 09:57 | |
*** ygbo has quit IRC | 10:00 | |
*** mitz has quit IRC | 10:00 | |
*** dguerri` has quit IRC | 10:00 | |
*** mitz has joined #openstack-horizon | 10:00 | |
*** xiangxinyong1 has joined #openstack-horizon | 10:00 | |
*** dguerri` has joined #openstack-horizon | 10:01 | |
*** dguerri` is now known as dguerri | 10:01 | |
*** dguerri has joined #openstack-horizon | 10:01 | |
*** kmARC has quit IRC | 10:01 | |
*** annashen has joined #openstack-horizon | 10:02 | |
*** e0ne_ has joined #openstack-horizon | 10:02 | |
*** kiran-r has quit IRC | 10:03 | |
*** ygbo has joined #openstack-horizon | 10:03 | |
*** annashen_ has joined #openstack-horizon | 10:04 | |
*** nullvariable has quit IRC | 10:05 | |
*** Ala has quit IRC | 10:05 | |
*** linkedinyou has quit IRC | 10:05 | |
*** zacdev has quit IRC | 10:05 | |
*** e0ne has quit IRC | 10:05 | |
*** xiangxinyong2 has quit IRC | 10:05 | |
*** Piet has quit IRC | 10:05 | |
*** e0ne_ is now known as e0ne | 10:06 | |
*** annashen has quit IRC | 10:06 | |
*** nullvariable has joined #openstack-horizon | 10:08 | |
*** annashen_ has quit IRC | 10:08 | |
*** jasondotstar has joined #openstack-horizon | 10:09 | |
*** linkedinyou has joined #openstack-horizon | 10:12 | |
*** kiran-r has joined #openstack-horizon | 10:12 | |
*** zhenguo has quit IRC | 10:13 | |
*** josecastroleon has quit IRC | 10:15 | |
*** kmARC has joined #openstack-horizon | 10:16 | |
*** Ala has joined #openstack-horizon | 10:18 | |
*** ^Gal^ has quit IRC | 10:19 | |
openstackgerrit | ziyu032 proposed openstack/horizon: Pseudo-folder name string should not contanins slash character https://review.openstack.org/206973 | 10:19 |
*** ^Gal^ has joined #openstack-horizon | 10:19 | |
*** romainh has quit IRC | 10:20 | |
*** KingKhan has quit IRC | 10:28 | |
*** xiangxinyong1 has quit IRC | 10:29 | |
*** aix has quit IRC | 10:38 | |
*** jpomeroy has quit IRC | 10:46 | |
*** lexholden has quit IRC | 10:46 | |
*** jpomeroy has joined #openstack-horizon | 10:46 | |
*** kzaitsev_mb has joined #openstack-horizon | 10:48 | |
*** robcresswell has quit IRC | 10:51 | |
*** markus_z has joined #openstack-horizon | 10:53 | |
*** yamamoto has quit IRC | 10:57 | |
*** yamamoto has joined #openstack-horizon | 10:59 | |
*** jsheeren has joined #openstack-horizon | 11:04 | |
*** annashen has joined #openstack-horizon | 11:04 | |
*** annashen has quit IRC | 11:09 | |
*** jprovazn has joined #openstack-horizon | 11:11 | |
*** romainh has joined #openstack-horizon | 11:14 | |
*** sayan has quit IRC | 11:20 | |
*** jasondot_ has joined #openstack-horizon | 11:23 | |
*** sayan has joined #openstack-horizon | 11:24 | |
*** e0ne has quit IRC | 11:25 | |
*** jasondotstar has quit IRC | 11:25 | |
*** juggler has quit IRC | 11:30 | |
*** belmoreira has joined #openstack-horizon | 11:31 | |
*** juggler has joined #openstack-horizon | 11:33 | |
*** e0ne has joined #openstack-horizon | 11:35 | |
*** jsheeren has quit IRC | 11:49 | |
*** josecastroleon has joined #openstack-horizon | 11:55 | |
*** e0ne has quit IRC | 11:59 | |
openstackgerrit | Romain Hardouin proposed openstack/horizon: Show datastores and versions for Trove https://review.openstack.org/163196 | 12:00 |
*** annashen has joined #openstack-horizon | 12:02 | |
*** yamamoto has quit IRC | 12:02 | |
*** annashen_ has joined #openstack-horizon | 12:05 | |
*** aix has joined #openstack-horizon | 12:07 | |
*** annashen has quit IRC | 12:07 | |
*** annashen_ has quit IRC | 12:10 | |
*** ducttape_ has joined #openstack-horizon | 12:10 | |
*** kiran-r has quit IRC | 12:18 | |
openstackgerrit | Paul Karikh proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 12:22 |
*** ducttape_ has quit IRC | 12:25 | |
*** KunalGandhi has joined #openstack-horizon | 12:25 | |
*** e0ne has joined #openstack-horizon | 12:25 | |
*** jacalcat has joined #openstack-horizon | 12:29 | |
*** KunalGandhi has quit IRC | 12:30 | |
*** bluex-pl has quit IRC | 12:30 | |
*** pauloewerton has joined #openstack-horizon | 12:31 | |
*** JeanBriceCombebi has joined #openstack-horizon | 12:32 | |
*** yingjun has joined #openstack-horizon | 12:33 | |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:33 |
*** caspinol has quit IRC | 12:35 | |
*** _crobertsrh is now known as crobertsrh | 12:42 | |
svasheka | mpavlase, ^ | 12:42 |
*** yingjun has quit IRC | 12:48 | |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 12:48 |
*** caspinol has joined #openstack-horizon | 12:49 | |
*** ChanServ changes topic to "OpenStack Horizon" | 12:49 | |
-openstackstatus- NOTICE: zuul's disks were at capacity. Space has been freed up and jobs are being re-queued. | 12:49 | |
*** yamamoto has joined #openstack-horizon | 12:49 | |
mpavlase | svasheka: you was faster than my comments :-) | 12:53 |
*** kfox1111 has joined #openstack-horizon | 12:54 | |
svasheka | mpavlase, :) | 12:56 |
mpavlase | svasheka: FYI, please find my comment in the latest patchset (#13) | 12:57 |
*** mpavlase has quit IRC | 13:01 | |
*** mpavlase has joined #openstack-horizon | 13:03 | |
*** matt-borland has joined #openstack-horizon | 13:03 | |
*** jpomeroy has quit IRC | 13:03 | |
*** mwhagedorn has joined #openstack-horizon | 13:03 | |
*** annashen has joined #openstack-horizon | 13:06 | |
*** hurgleburgler has quit IRC | 13:06 | |
*** annashen has quit IRC | 13:10 | |
*** dboik has joined #openstack-horizon | 13:12 | |
openstackgerrit | svasheka proposed openstack/horizon: Add _save_screenshot functionality to helpers. https://review.openstack.org/194646 | 13:13 |
svasheka | mpavlase, agree | 13:13 |
*** jtriley has joined #openstack-horizon | 13:14 | |
openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 13:15 |
*** rahulshivsharan has joined #openstack-horizon | 13:16 | |
rahulshivsharan | rom keystoneclient.v3 import client | 13:17 |
rahulshivsharan | keystone = client.Client(username=username, password=password,tenant_id=tenant_id, auth_url=auth_url) | 13:17 |
rahulshivsharan | can I get Token from the keyston object | 13:18 |
rahulshivsharan | like keystone.getToken() | 13:18 |
rahulshivsharan | or keyston.get["X-Auth-Token"] or keyston.get["X-Subject-Token"] | 13:18 |
*** lucas__ has joined #openstack-horizon | 13:19 | |
*** JeanBriceCombebi has quit IRC | 13:21 | |
*** JeanBriceCombebi has joined #openstack-horizon | 13:22 | |
*** jpomeroy has joined #openstack-horizon | 13:23 | |
*** neelashah has joined #openstack-horizon | 13:24 | |
-openstackstatus- NOTICE: zuul jobs after about 07:00 UTC may need a 'recheck' to enter the queue. Look if your change is in http://status.openstack.org/zuul/ and recheck if not. | 13:26 | |
*** lexholden has joined #openstack-horizon | 13:26 | |
*** doug-fish has joined #openstack-horizon | 13:33 | |
*** stevemar has joined #openstack-horizon | 13:34 | |
*** lucas__ has quit IRC | 13:38 | |
*** lucas__ has joined #openstack-horizon | 13:39 | |
*** matt-borland has quit IRC | 13:40 | |
*** drupalmonkey has joined #openstack-horizon | 13:43 | |
*** romainh has left #openstack-horizon | 13:44 | |
*** ducttape_ has joined #openstack-horizon | 13:46 | |
*** jasondotstar has joined #openstack-horizon | 13:48 | |
*** bfic has quit IRC | 13:51 | |
*** robcresswell has joined #openstack-horizon | 13:51 | |
*** mpavlase has quit IRC | 13:51 | |
*** jasondot_ has quit IRC | 13:52 | |
*** wim_dc has joined #openstack-horizon | 13:52 | |
crobertsrh | A couple questions about how the Sahara dashboard (now in contrib) might go about using the manila service: | 13:52 |
crobertsrh | 1) The manila dashboard stuff (and api) currently lives outside of the horizon repo. Is it reasonable for us to bring it into openstacki_dashboard/api, or since it's [currently] only Sahara that wants to use it, should we keep it in our corner of the repo? | 13:52 |
*** mpavlase has joined #openstack-horizon | 13:53 | |
crobertsrh | 2) Are we still "allowed" to add python-manilaclient to requirements.txt? | 13:54 |
*** bfic has joined #openstack-horizon | 13:55 | |
crobertsrh | ...or is there a more preferred way of things in contrib handling their own requirements? (I can't think of any other way at the moment) | 13:55 |
ducttape_ | crobertsrh - I have very little say, but I would prefer to not have client requirements added to the horizon core. the plugin should add that requirement | 13:55 |
*** katyafervent is now known as katyafervent_awa | 13:55 | |
crobertsrh | the manila plugin? | 13:56 |
ducttape_ | and you can also define the same path of openstack_dashboard/api/manila.py if you wanted to | 13:56 |
ducttape_ | yep. the manila plugin should declare that it requires the client library | 13:56 |
crobertsrh | I'm just imagining a [probably somewhat likely] scenario of an install with Sahara turned on, but without the manila plugin. Sahara still needs to use the manila client library for some thing. | 13:57 |
ducttape_ | david-lyle might be online soon, if not already. he would be a better one to guide you. this is just my $0.02 worth | 13:57 |
ducttape_ | then sahara should also declare that requirement too | 13:58 |
crobertsrh | Ok, thanks. I figured I should get this sorted out now rather than after I've gone through a dozen patch sets. | 13:58 |
crobertsrh | but sahara lives in the horizon repo | 13:58 |
*** katyafervent_awa is now known as katyafervent | 13:58 | |
ducttape_ | not for long? ;) | 13:58 |
crobertsrh | It just moved to /contrib | 13:58 |
*** neelashah1 has joined #openstack-horizon | 13:58 | |
ducttape_ | ah, ok | 13:58 |
*** bfic has quit IRC | 13:58 | |
crobertsrh | I'm hoping it may stay awhile :) | 13:59 |
ducttape_ | yes, sorry. I thought it might move to its own repo | 13:59 |
crobertsrh | Of course...life would be easier in some respects. | 13:59 |
crobertsrh | Yeah, I thought we might get the boot for awhile too :) | 13:59 |
ducttape_ | I think you are free to do that, if you prefer | 13:59 |
*** neelashah has quit IRC | 13:59 | |
ducttape_ | you could then have other reviewers for +2 / merging etc | 14:00 |
crobertsrh | Oh yes, we would be free to create any monstrosity we saw fit | 14:01 |
crobertsrh | Which, we have proved before, we would do...and it's not a great thing :) | 14:01 |
crobertsrh | Thanks for your input. I'll look up David when I see him. | 14:02 |
*** annashen has joined #openstack-horizon | 14:03 | |
*** ericpeterson has joined #openstack-horizon | 14:04 | |
*** EmilienM has quit IRC | 14:05 | |
*** rdopiera has quit IRC | 14:07 | |
*** annashen_ has joined #openstack-horizon | 14:07 | |
*** JeanBriceCombebi has quit IRC | 14:07 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:07 | |
*** JeanBriceCombebi has quit IRC | 14:08 | |
*** annashen has quit IRC | 14:08 | |
*** ducttape_ has quit IRC | 14:08 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:09 | |
*** EmilienM has joined #openstack-horizon | 14:09 | |
*** caspinol has quit IRC | 14:10 | |
*** annashen_ has quit IRC | 14:11 | |
*** SimonChung has joined #openstack-horizon | 14:17 | |
*** Miouge has joined #openstack-horizon | 14:18 | |
robcresswell | I thought the plan was to move Sahara out soon? Like, M release | 14:19 |
crobertsrh | I'm looking at making these changes for L though. | 14:20 |
crobertsrh | I have not heard of a target date for the Sahara-ectomy from the horizon repo | 14:21 |
* ericpeterson hopes he doesn't have a Sahara-ectomy anytime soon | 14:22 | |
crobertsrh | Was the move to /contrib just meant to be an intermediate pit stop for us? | 14:23 |
*** absubram has joined #openstack-horizon | 14:25 | |
ericpeterson | crobertsrh : again, I'm not sure. but I could see a situation where moving files/folders within a single repo is much easier than creating a second repo with QA jobs and approvers etc | 14:27 |
ericpeterson | that would seem the likely reason, b/c it is easier to do that... and see what breaks | 14:28 |
*** neelashah1 has quit IRC | 14:28 | |
*** yamamoto has quit IRC | 14:29 | |
*** yamamoto has joined #openstack-horizon | 14:29 | |
*** tvanderwiel has joined #openstack-horizon | 14:31 | |
*** tvanderwiel has left #openstack-horizon | 14:31 | |
*** JeanBriceCombebi has quit IRC | 14:34 | |
*** JeanBriceCombebi has joined #openstack-horizon | 14:34 | |
*** caspinol has joined #openstack-horizon | 14:34 | |
*** rahulshivsharan has quit IRC | 14:36 | |
*** yamamoto has quit IRC | 14:38 | |
*** Ephur has joined #openstack-horizon | 14:38 | |
robcresswell | david-lyle: ping | 14:40 |
*** Rahul_S has joined #openstack-horizon | 14:40 | |
robcresswell | I thought the plan was to move to contrib temporarily, then move out of repo when the plugins have themselves setup etc | 14:40 |
robcresswell | I may well have misunderstood though | 14:40 |
*** Rahul_S has quit IRC | 14:41 | |
*** SimonChung has quit IRC | 14:42 | |
*** SimonChung has joined #openstack-horizon | 14:42 | |
crobertsrh | robcresswell: My horizon meeting attendance has been spotty lately, so I may have totally missed that plan. If that is the plan, we (Sahara people) should get moving on it. | 14:43 |
*** vijendar has joined #openstack-horizon | 14:44 | |
*** vijendar has quit IRC | 14:44 | |
*** vijendar has joined #openstack-horizon | 14:44 | |
ericpeterson | I think robcresswell is on the right track too, it will be best for sahara (my opinion) | 14:45 |
*** nlahouti has joined #openstack-horizon | 14:45 | |
*** nlahouti has quit IRC | 14:46 | |
*** ZZelle has quit IRC | 14:48 | |
*** masco has quit IRC | 14:49 | |
robcresswell | crobertsrh: Reach out to David to check, but I believe the overall goal (i.e. very long term) here is to reduce the overall amount of in-tree code, so plugins will maintain their own repos, while we effectively provide a pluggable library for OpenStack UIs | 14:51 |
robcresswell | Kinda like Neutron with its vendor plugins | 14:51 |
robcresswell | Otherwise Horizon ends up as a blocker on code, because there isn't enough knowledge of the various components | 14:52 |
*** wim_dc has quit IRC | 14:54 | |
*** yamamoto has joined #openstack-horizon | 14:54 | |
ericpeterson | I think we might need to strength the version dependency ties with horizon and plugins. like a plugin might only work with certain horizon versions, and bring in other requirments.... this aspect probably has some work todo here | 14:55 |
*** absubram has quit IRC | 14:55 | |
ericpeterson | but this effort will flush out a lot of that stuff, I would hope | 14:55 |
*** neelashah has joined #openstack-horizon | 14:56 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Remove Router Dashboard https://review.openstack.org/197969 | 14:57 |
robcresswell | ^^ | 14:57 |
*** dsneddon has quit IRC | 14:57 | |
*** dsneddon has joined #openstack-horizon | 14:58 | |
*** belmoreira has quit IRC | 14:59 | |
*** absubram has joined #openstack-horizon | 14:59 | |
*** jasondotstar has quit IRC | 14:59 | |
crobertsrh | robcresswell: I totally agree. I will check with David. Thanks. | 15:00 |
robcresswell | no problem | 15:00 |
*** hurgleburgler has joined #openstack-horizon | 15:01 | |
*** e0ne has quit IRC | 15:02 | |
*** nullvariable has quit IRC | 15:02 | |
*** jacalcat has quit IRC | 15:02 | |
*** e0ne has joined #openstack-horizon | 15:04 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 15:07 |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 15:07 |
*** annashen has joined #openstack-horizon | 15:07 | |
*** annashen has quit IRC | 15:13 | |
*** josecastroleon has quit IRC | 15:15 | |
*** lblanchard has joined #openstack-horizon | 15:16 | |
*** jprovazn has quit IRC | 15:16 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: WIP Refactor d-o-a code to use keystoneauth library https://review.openstack.org/205251 | 15:16 |
pauloewerton | doug-fish, hi. I think you'd be interested in taking a look ^^^ | 15:20 |
*** Drago has joined #openstack-horizon | 15:21 | |
doug-fish | pauloewerton: yes cool - thx for the heads up! | 15:21 |
*** Drago has quit IRC | 15:21 | |
*** Drago has joined #openstack-horizon | 15:21 | |
pauloewerton | doug-fish, np ;-) | 15:23 |
pauloewerton | the patch is functional for manual testing, but making the tests pass is being a pain =\ | 15:23 |
*** Miouge has quit IRC | 15:25 | |
*** bpokorny has joined #openstack-horizon | 15:28 | |
*** lucas__ has quit IRC | 15:30 | |
*** lucas__ has joined #openstack-horizon | 15:32 | |
*** btully has quit IRC | 15:34 | |
*** btully has joined #openstack-horizon | 15:34 | |
*** alexpilotti has quit IRC | 15:34 | |
*** lucas__ has quit IRC | 15:37 | |
*** lucas____ has joined #openstack-horizon | 15:41 | |
*** vishwanathj has quit IRC | 15:41 | |
*** alexvictorchan has joined #openstack-horizon | 15:42 | |
*** tyr has joined #openstack-horizon | 15:42 | |
*** JeanBriceCombebi has quit IRC | 15:44 | |
*** jmolo has joined #openstack-horizon | 15:45 | |
*** JeanBriceCombebi has joined #openstack-horizon | 15:45 | |
*** lucas____ has quit IRC | 15:46 | |
*** Sukhdev_ has joined #openstack-horizon | 15:47 | |
mwhagedorn | does anyone know how to configure horizon so that it sends emails on horizon errors, just like generic django apps do? Is this in general disabled for horizon? Anybody know? | 15:48 |
*** rhagarty_ has quit IRC | 15:48 | |
*** rhagarty has quit IRC | 15:48 | |
david-lyle | mwhagedorn: it's in the configuration for adminui, you might check there | 15:50 |
*** ongk has joined #openstack-horizon | 15:50 | |
david-lyle | IIRC | 15:50 |
mwhagedorn | thanks david-lyle will look there. Good old HPPC | 15:51 |
david-lyle | robcresswell: pong | 15:53 |
robcresswell | david-lyle: Just wondering what the timescale was around moving sahara etc out of tree | 15:53 |
robcresswell | It was relevant to earlier discussion | 15:53 |
david-lyle | robcresswell: good question :) | 15:53 |
david-lyle | in Liberty I just wanted to get Sahara and Trove to contrib and work out the issues around that | 15:54 |
robcresswell | Yeah, I had said it would be M | 15:54 |
robcresswell | crobertsrh: Still around? | 15:54 |
crobertsrh | Yep. Thanks for pinging on my behalf. | 15:55 |
robcresswell | np | 15:55 |
david-lyle | then possibly in Mitaka move out to separate repo if there is a good testing story | 15:55 |
david-lyle | the plugin testing piece needs help before I think we're ready to move out of tree | 15:55 |
david-lyle | but tuskar-ui and manila-ui already do this | 15:56 |
david-lyle | but sahara has integration tests, so that's another level of testing that needs to be supported | 15:56 |
david-lyle | just moving to /contrib illuminated some issues | 15:57 |
david-lyle | some are solved, some are not | 15:57 |
david-lyle | mostly solved though | 15:57 |
crobertsrh | Ok, so for L, we are definitely staying in /contrib. I think that's all I needed to know for now. | 15:57 |
david-lyle | yeah, definitely for L | 15:58 |
david-lyle | L-2 was tagged yesterday | 15:58 |
crobertsrh | One slightly ugly thing that we are looking at doing for L is using Manila | 15:58 |
*** rhagarty has joined #openstack-horizon | 15:58 | |
*** rhagarty_ has joined #openstack-horizon | 15:58 | |
*** nlahouti has joined #openstack-horizon | 15:58 | |
david-lyle | there is an out of tree manila-ui plugin | 15:58 |
crobertsrh | we would need python-manilaclient in requirements and would add a manila.py api module somewhere. | 15:58 |
david-lyle | manila.py would live in /contrib/sahara/api I think | 15:59 |
crobertsrh | Ok, that works for me. | 15:59 |
david-lyle | would be nice to have conditional requirements, but not sure how that would work | 15:59 |
crobertsrh | Yeah, the requirements bit is ugly | 16:00 |
david-lyle | other than out of tree plugins | 16:00 |
david-lyle | so sahara will always use manila? | 16:00 |
crobertsrh | yeah...and since we're still sort of an in-tree plugin for now, ugliness rules | 16:00 |
crobertsrh | If manila is enabled in the service catalog, we offer the option for using it for somethings. | 16:00 |
david-lyle | I have to jump into a meeting, but let me think about that one a bit | 16:01 |
crobertsrh | Job binaries can be stored in a manila share and eventually input/output for the jobs can also live there. | 16:01 |
crobertsrh | Ok, sounds good. | 16:01 |
david-lyle | I fear ugly is the path forward, but maybe there's a better option :) | 16:01 |
robcresswell | david-lyle: When you get a moment: https://review.openstack.org/#/c/197969/ | 16:01 |
crobertsrh | I'm on vacation until next week, but people in OS-sahara can also probably discuss | 16:01 |
robcresswell | Making Horizon marginally less ugly :) | 16:02 |
david-lyle | robcresswell: boom! | 16:02 |
david-lyle | \o/ | 16:02 |
david-lyle | ok will review in a bit | 16:02 |
crobertsrh | Very easy review there :) | 16:02 |
robcresswell | Thanks | 16:02 |
david-lyle | just have to look for tentacles | 16:02 |
*** jbell8 has joined #openstack-horizon | 16:03 | |
*** lucas____ has joined #openstack-horizon | 16:04 | |
*** annashen has joined #openstack-horizon | 16:04 | |
*** garthb has joined #openstack-horizon | 16:06 | |
*** garthb_ has joined #openstack-horizon | 16:06 | |
*** garthb_ has quit IRC | 16:07 | |
*** ygbo has quit IRC | 16:08 | |
*** annashen_ has joined #openstack-horizon | 16:08 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 16:08 |
*** annashen has quit IRC | 16:09 | |
openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 16:12 |
*** davidmichaelkarr has quit IRC | 16:13 | |
*** ameade has quit IRC | 16:13 | |
*** annashen_ has quit IRC | 16:13 | |
*** Piet has joined #openstack-horizon | 16:13 | |
*** lucas____ has quit IRC | 16:15 | |
*** lucas__ has joined #openstack-horizon | 16:15 | |
*** kmARC has quit IRC | 16:17 | |
*** david-lyle has quit IRC | 16:18 | |
*** lsmola has quit IRC | 16:20 | |
*** TravT_ has joined #openstack-horizon | 16:22 | |
*** belmoreira has joined #openstack-horizon | 16:23 | |
*** TravT has quit IRC | 16:25 | |
*** sayan has quit IRC | 16:25 | |
*** rajatvig has joined #openstack-horizon | 16:27 | |
*** ongk has joined #openstack-horizon | 16:28 | |
*** markus_z has quit IRC | 16:29 | |
ericpeterson | interesting chart on the session breakdown: http://nmala.maishsk.com/blog/images/OpenStack-Summit-VotingAnalyzing-the-num_884F/image_thumb.png | 16:36 |
*** KunalGandhi has joined #openstack-horizon | 16:37 | |
med_ | truestory | 16:37 |
ericpeterson | chart credit: med_ | 16:38 |
med_ | chart credit: maisha | 16:39 |
*** crobertsrh has quit IRC | 16:39 | |
*** rdopiera has joined #openstack-horizon | 16:41 | |
*** david-lyle has joined #openstack-horizon | 16:42 | |
*** ChanServ sets mode: +o david-lyle | 16:42 | |
*** rajatvig has quit IRC | 16:43 | |
*** ameade has joined #openstack-horizon | 16:43 | |
*** nullvariable has joined #openstack-horizon | 16:45 | |
*** alexpilotti has joined #openstack-horizon | 16:46 | |
*** JeanBriceCombebi has quit IRC | 16:48 | |
*** robcresswell has quit IRC | 16:50 | |
*** sqchen has joined #openstack-horizon | 16:52 | |
*** shivrao has joined #openstack-horizon | 16:53 | |
*** rajatvig has joined #openstack-horizon | 16:53 | |
ericpeterson | david-lyle -on the requirements thing.... if you made the plugins all python eggs, then they could enforce additional requirements to be installed (instead of making a huge requirements in horizon) | 16:54 |
*** mohankumar has quit IRC | 16:54 | |
*** Ala has quit IRC | 16:54 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for getting default quotas in admin https://review.openstack.org/207126 | 16:55 |
*** jingjing_ren has joined #openstack-horizon | 16:56 | |
david-lyle | ericpeterson: out of ducttape_? | 16:56 |
*** shivrao_ has joined #openstack-horizon | 16:56 | |
ericpeterson | irc client gets stupid. lemme close / reopen | 16:56 |
david-lyle | so essentially vendored plugins? | 16:56 |
*** ericpeterson has quit IRC | 16:56 | |
*** ducttape_ has joined #openstack-horizon | 16:57 | |
*** nlahouti has quit IRC | 16:57 | |
*** shivrao has quit IRC | 16:57 | |
*** shivrao_ is now known as shivrao | 16:57 | |
*** skylerberg has joined #openstack-horizon | 16:57 | |
ducttape_ | yes, vendor plugin is what you have anyways | 16:57 |
ducttape_ | maybe the term vendor is not appropriate, but you are going to have a group with this plugin.... and that thing will need to say which versions of horizon it would work with, and which client libs it needs | 16:58 |
david-lyle | well one is source and one is packaged and included | 16:58 |
ducttape_ | you want to get those items out of your source tree, though. correct? | 16:59 |
david-lyle | yes, I think that's really the correct answer | 16:59 |
ducttape_ | so then let's do the correct things | 16:59 |
david-lyle | but we have an interlude before that | 16:59 |
ducttape_ | you do right now, but you don't need to | 16:59 |
*** sayan has joined #openstack-horizon | 16:59 | |
*** nlahouti has joined #openstack-horizon | 16:59 | |
*** nlahouti has quit IRC | 17:01 | |
*** mwhagedorn has quit IRC | 17:01 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 17:02 |
*** jacalcat_ has joined #openstack-horizon | 17:02 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] - Dashboard ReOrg - collect dashboards on horizon.dashboard https://review.openstack.org/207128 | 17:03 |
*** e0ne has quit IRC | 17:03 | |
*** davidmichaelkarr has joined #openstack-horizon | 17:03 | |
*** tjones has joined #openstack-horizon | 17:06 | |
*** MaxV has quit IRC | 17:07 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 17:07 |
*** nlahouti has joined #openstack-horizon | 17:08 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 17:08 |
*** mwhagedorn has joined #openstack-horizon | 17:09 | |
*** annashen has joined #openstack-horizon | 17:09 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Move APIs into app/core https://review.openstack.org/197330 | 17:10 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Fix ng-di errors on cloud-services https://review.openstack.org/198840 | 17:11 |
*** annashen has quit IRC | 17:13 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - Use mock module to avoid using window https://review.openstack.org/199333 | 17:13 |
*** alexpilotti has quit IRC | 17:14 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - Relocate Launch Instance module https://review.openstack.org/197234 | 17:16 |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - hz.dashboard --> horizon.dashboard https://review.openstack.org/206760 | 17:18 |
*** annashen has joined #openstack-horizon | 17:19 | |
*** dboik has quit IRC | 17:19 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] - Dashboard ReOrg - collect dashboards on horizon.dashboard https://review.openstack.org/207128 | 17:20 |
*** ybathia has joined #openstack-horizon | 17:21 | |
*** alexpilotti has joined #openstack-horizon | 17:23 | |
tjones | I'd appreciate reviews on this one if anyone has the time - https://review.openstack.org/#/c/195751/ | 17:25 |
*** kzaitsev_mb has quit IRC | 17:27 | |
*** dsneddon has quit IRC | 17:28 | |
*** dsneddon has joined #openstack-horizon | 17:28 | |
*** tjones1 has joined #openstack-horizon | 17:30 | |
*** aix has quit IRC | 17:30 | |
*** tjones1 has quit IRC | 17:32 | |
*** tjones1 has joined #openstack-horizon | 17:33 | |
*** tjones1 has quit IRC | 17:33 | |
*** saksham has joined #openstack-horizon | 17:36 | |
*** tqtran has joined #openstack-horizon | 17:39 | |
*** rhagarty_ has quit IRC | 17:39 | |
*** rhagarty has quit IRC | 17:39 | |
tqtran | TravT_: when are you free? lets go over the hz-include stuff | 17:40 |
*** lblanchard has quit IRC | 17:40 | |
*** annashen has quit IRC | 17:42 | |
*** rhagarty has joined #openstack-horizon | 17:42 | |
*** rhagarty_ has joined #openstack-horizon | 17:42 | |
*** mpavlase has quit IRC | 17:42 | |
*** dsneddon has quit IRC | 17:43 | |
*** matt-borland has joined #openstack-horizon | 17:44 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - collect dashboards on horizon.dashboard https://review.openstack.org/207128 | 17:45 |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Dashboard ReOrg - collect dashboards on horizon.dashboard https://review.openstack.org/207128 | 17:45 |
*** annashen has joined #openstack-horizon | 17:46 | |
*** Sukhdev_ has quit IRC | 17:47 | |
tyr | sqchen: tqtran I think dashboard plugin functionality makes sense as a feature of the horizon.dashboard module, separate from horizon.app....but I'd like your opinions on the idea when you have a chance. --> https://review.openstack.org/#/c/207128/ | 17:47 |
*** nlahouti has quit IRC | 17:47 | |
sqchen | tyr: I am looking into it… | 17:48 |
tqtran | tyr: only issue is, if the plugin provides other utility things that isnt dashboard related | 17:50 |
tqtran | for example, maybe i have some cool utility code that i want shared across my dashboard, but its only available through my plugin | 17:51 |
*** dsneddon has joined #openstack-horizon | 17:51 | |
tqtran | using this mechanism, it will all go under dashboard | 17:51 |
tyr | tqtran: in our app, is "plugin" === "dashboard"? | 17:51 |
tyr | since the enabled files have to list a "DASHBOARD = " that they are part of? | 17:51 |
tqtran | plugin could be dashboard, or panel, or workflow (in the future) | 17:52 |
tqtran | yes, but your javascript code doesn't have to be restricted to just dashboard code | 17:52 |
*** nlahouti has joined #openstack-horizon | 17:52 | |
*** mwhagedorn has quit IRC | 17:52 | |
tqtran | the static collector will include any modules you want | 17:52 |
tyr | at the moment, we don't really have a mechanism to "plugin" to app/core | 17:53 |
sqchen | tyr: in your change app === app.core, in my mind plugin === app.plugin | 17:53 |
sqchen | dashboard === app + framework | 17:53 |
*** jasondotstar has joined #openstack-horizon | 17:54 | |
tyr | so perhaps horizon.dashboard becomes horizon.plugins...one of which is the list of discovered dashboards? | 17:55 |
sqchen | I don’t like the idear of removing app/ under /dashboards/static/ since it will keep misleading us to somewhere else, and it is more expensive that having an app folder there. | 17:55 |
*** jingjing_ren has quit IRC | 17:55 | |
sqchen | horizon.plugins can mean something else, for example a lpugin to horizon platform, framework, least likely a plugin to app. | 17:56 |
*** e0ne has joined #openstack-horizon | 17:56 | |
tqtran | sqchen: can you get kelly to post/email the etherpad that contains the JSCS work? | 17:57 |
tqtran | i'd really really like to wrap that up | 17:57 |
*** lucas__ has quit IRC | 17:58 | |
tyr | sqchen: I think that is slightly different. In this case, I'm trying to figure out if there is any need to preserve the horizon.dashboard module. It *is* the root of all dashboards (i.e. horizon.dashboard.identity) but at the moment it is an empty module serving no functional purpose. | 17:58 |
tyr | My patch gives it a (small) purpose by making it the integration point for anything horizon.dashboard.* | 17:59 |
sqchen | tqtran, don’t really understand your request, but I’ll try to find Kelly. | 17:59 |
tyr | tqtran: I think that adding a plugin which provides a utility function would perhaps not live in horizon.dashboard.* but would be something like 'horizon.app.util.*', and therefore not collected onto horizon.dashboard module. | 18:00 |
tqtran | kelly has an etherpad containing list of jscs work | 18:00 |
tqtran | just wanted to take a look at it and help push those patches through | 18:00 |
tqtran | tyr: i agree, but atm I think we should focus on content. we've had too much re-orgs already :P I won't stop you, but it just won't be high priority for me | 18:01 |
tqtran | to the end user, it doesnt matter where it plug in as long as it is available | 18:02 |
sqchen | I see, thx, I will find the etherpad from Kelly. I agree with you we want that jod done. | 18:02 |
tyr | I understand tqtran. However this is a consequence of the re-org that we already decided would be a good idea (moving launch instance, moving the apis). That leaves us with a dummy module we need to either give a purpose, or remove | 18:03 |
sqchen | I prefer remove once the re-org is done. | 18:04 |
tqtran | im kind of with sean here.... | 18:05 |
tyr | This final series of re-orgs (along with JSCS) is blocking content progress as the organization of openstack_dashboard has tech debt that makes it confusing where new code lives. | 18:05 |
*** mohankumar has joined #openstack-horizon | 18:05 | |
*** lucas__ has joined #openstack-horizon | 18:05 | |
tqtran | once you have different plugin points, one to framework, one to app/core, one to dashboard, it starts to get messy | 18:05 |
sqchen | unless we want to use it do this: dashboard === app + framework. but it is very low priority IMO. | 18:05 |
*** annashen_ has joined #openstack-horizon | 18:05 | |
*** TravT_ has quit IRC | 18:05 | |
*** SimonChung has quit IRC | 18:06 | |
*** e0ne has quit IRC | 18:06 | |
*** ongk has joined #openstack-horizon | 18:08 | |
tyr | ok, point taken. People will want to add modules which are not always under horizon.dashboard....so collecting all modules onto horizon.dashboard won't always make sense. | 18:08 |
ongk | tqtran: I heard you were looking for me | 18:08 |
tyr | For now, we collect everything onto horizon.app. Isolating this onto horizon.app.plugins or something is maybe interesting, but low priority. | 18:09 |
tyr | ok. thanks! | 18:09 |
tqtran | tyr: yes :) perfectly summarized | 18:09 |
tqtran | ongk: yes mam! can you link the etherpad for jscs work? | 18:09 |
*** lucas__ has quit IRC | 18:09 | |
*** e0ne has joined #openstack-horizon | 18:09 | |
*** lucas__ has joined #openstack-horizon | 18:10 | |
tqtran | i remember you mentioning that you have something that tracks all of the jscs files and patches that would fix them | 18:10 |
*** annashen_ has quit IRC | 18:10 | |
ongk | yup, let me find it | 18:12 |
*** kyleolivo has joined #openstack-horizon | 18:12 | |
ongk | tqtran: https://etherpad.openstack.org/p/jscs-cleanup | 18:12 |
tqtran | tyvm! | 18:13 |
ongk | np | 18:15 |
*** SimonChung has joined #openstack-horizon | 18:18 | |
*** SimonChung1 has joined #openstack-horizon | 18:20 | |
*** annashen has quit IRC | 18:21 | |
*** jasondotstar has quit IRC | 18:23 | |
*** SimonChung has quit IRC | 18:23 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: JSCS Cleanup - Metadata widgets cleanup https://review.openstack.org/203795 | 18:23 |
*** annashen has joined #openstack-horizon | 18:24 | |
*** dboik has joined #openstack-horizon | 18:25 | |
*** lblanchard has joined #openstack-horizon | 18:27 | |
sqchen | Thanks tyr. | 18:28 |
*** josecastroleon has joined #openstack-horizon | 18:28 | |
*** openstackgerrit has quit IRC | 18:31 | |
*** openstackgerrit has joined #openstack-horizon | 18:32 | |
*** nlahouti has quit IRC | 18:32 | |
*** Drago has quit IRC | 18:36 | |
*** vishwanathj_ has joined #openstack-horizon | 18:39 | |
*** sayan has quit IRC | 18:40 | |
*** annashen has quit IRC | 18:42 | |
*** vishwanathj has joined #openstack-horizon | 18:42 | |
*** mwhagedorn has joined #openstack-horizon | 18:46 | |
*** vishwanathj has quit IRC | 18:46 | |
*** nlahouti has joined #openstack-horizon | 18:50 | |
*** nlahouti has quit IRC | 18:54 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: favicon, logo and logo-splash should allow theme overrides https://review.openstack.org/195751 | 18:55 |
*** Sukhdev_ has joined #openstack-horizon | 18:55 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/206881 | 18:56 |
*** sayan has joined #openstack-horizon | 18:57 | |
*** mpavlase has joined #openstack-horizon | 18:57 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: favicon, logo and logo-splash should allow theme overrides https://review.openstack.org/195751 | 18:57 |
*** josecastroleon has quit IRC | 18:58 | |
*** xiangxinyong1 has joined #openstack-horizon | 19:00 | |
matt-borland | david-lyle: regarding the panel/test issues we talked about yesterday...is that something I can work on fixing? Or do you have a patch you're working on? | 19:01 |
*** TravT has joined #openstack-horizon | 19:01 | |
matt-borland | thanks for taking the time to look into that | 19:01 |
matt-borland | I know it was a weird issue | 19:02 |
openstackgerrit | Merged openstack/horizon: Auto-collect app/ instead of only app/core/ https://review.openstack.org/205720 | 19:02 |
*** Drago has joined #openstack-horizon | 19:04 | |
*** Drago has quit IRC | 19:06 | |
*** Drago has joined #openstack-horizon | 19:06 | |
*** lucas__ has quit IRC | 19:07 | |
*** xiangxinyong1 has quit IRC | 19:08 | |
*** nlahouti has joined #openstack-horizon | 19:08 | |
*** Piet has quit IRC | 19:10 | |
*** linkedinyou has quit IRC | 19:11 | |
*** geoffarnold has joined #openstack-horizon | 19:12 | |
*** ZZelle has joined #openstack-horizon | 19:13 | |
*** dansiwiec has joined #openstack-horizon | 19:13 | |
*** dansiwiec has quit IRC | 19:13 | |
*** nlahouti has quit IRC | 19:14 | |
*** sqchen has quit IRC | 19:14 | |
*** sqchen has joined #openstack-horizon | 19:15 | |
*** sayan has quit IRC | 19:15 | |
openstackgerrit | Shaoquan Chen proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 19:16 |
*** davidmichaelkarr has quit IRC | 19:17 | |
*** jasondotstar has joined #openstack-horizon | 19:18 | |
*** dansiwiec has joined #openstack-horizon | 19:19 | |
*** jmolo has quit IRC | 19:20 | |
*** jmolo has joined #openstack-horizon | 19:21 | |
*** tjones has quit IRC | 19:21 | |
*** lucas__ has joined #openstack-horizon | 19:22 | |
*** yamamoto has quit IRC | 19:24 | |
sqchen | Hi cores, we want a fix for Jasmine test from tyr to get in, can you help? https://review.openstack.org/#/c/206267/ | 19:24 |
openstackgerrit | Yunpeng Li proposed openstack/horizon: Added .project & .pydevproject to .gitignore. https://review.openstack.org/207186 | 19:24 |
*** dansiwiec has quit IRC | 19:26 | |
*** kyleolivo has quit IRC | 19:27 | |
*** rajatvig has quit IRC | 19:27 | |
tyr | Thanks for the quick review tqtran! | 19:28 |
kfox1111 | tqtran: Got it working. :) some angular thigns were renamed in trunk. | 19:31 |
tqtran | nice! | 19:31 |
kfox1111 | testing out the from scratch setup instructions and then posting the code. | 19:31 |
*** lucas__ has quit IRC | 19:32 | |
*** lucas__ has joined #openstack-horizon | 19:33 | |
openstackgerrit | Yunpeng Li proposed openstack/horizon: Added .project & .pydevproject to .gitignore. https://review.openstack.org/207186 | 19:35 |
*** vishwanathj has joined #openstack-horizon | 19:35 | |
*** alexvictorchan has quit IRC | 19:36 | |
*** annashen has joined #openstack-horizon | 19:42 | |
*** tjones has joined #openstack-horizon | 19:42 | |
kfox1111 | Awesome. works. :) | 19:43 |
kfox1111 | git pushing... | 19:43 |
kfox1111 | https://github.com/kfox1111/apps-catalog-ui.git :) | 19:45 |
*** MaxV has joined #openstack-horizon | 19:46 | |
*** belmoreira has quit IRC | 19:47 | |
*** HenryG has quit IRC | 19:49 | |
tqtran | :) cool | 19:49 |
*** e0ne has quit IRC | 19:51 | |
*** HenryG has joined #openstack-horizon | 19:52 | |
*** tqtran has quit IRC | 19:54 | |
*** e0ne has joined #openstack-horizon | 19:55 | |
*** tqtran has joined #openstack-horizon | 19:55 | |
*** jmolo has quit IRC | 19:55 | |
*** vishwanathj has quit IRC | 19:57 | |
*** MaxV has quit IRC | 19:58 | |
*** lblanchard has quit IRC | 20:00 | |
*** jmolo has joined #openstack-horizon | 20:01 | |
*** sqchen has quit IRC | 20:01 | |
*** alexvictorchan has joined #openstack-horizon | 20:02 | |
*** e0ne has quit IRC | 20:03 | |
*** emw has joined #openstack-horizon | 20:03 | |
*** jmolo1 has joined #openstack-horizon | 20:04 | |
*** jmolo has quit IRC | 20:04 | |
*** annashen_ has joined #openstack-horizon | 20:06 | |
*** vishwanathj has joined #openstack-horizon | 20:10 | |
*** annashen_ has quit IRC | 20:11 | |
*** e0ne has joined #openstack-horizon | 20:11 | |
*** alexvictorchan has quit IRC | 20:16 | |
*** tqtran_ has joined #openstack-horizon | 20:16 | |
*** openstackgerrit has quit IRC | 20:16 | |
*** openstackgerrit has joined #openstack-horizon | 20:17 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Angular code theory documentation https://review.openstack.org/203862 | 20:17 |
*** tqtran has quit IRC | 20:17 | |
*** sqchen has joined #openstack-horizon | 20:17 | |
*** sqchen has left #openstack-horizon | 20:18 | |
*** alexvictorchan has joined #openstack-horizon | 20:18 | |
*** jasondotstar has quit IRC | 20:19 | |
*** vishwanathj has quit IRC | 20:20 | |
*** nlahouti has joined #openstack-horizon | 20:24 | |
*** yamamoto has joined #openstack-horizon | 20:24 | |
*** rajatvig has joined #openstack-horizon | 20:27 | |
*** rajatvig has quit IRC | 20:27 | |
*** dansiwiec has joined #openstack-horizon | 20:27 | |
*** lucas__ has quit IRC | 20:28 | |
*** dansiwiec has quit IRC | 20:29 | |
*** yamamoto has quit IRC | 20:29 | |
*** lucas__ has joined #openstack-horizon | 20:31 | |
*** jasondotstar has joined #openstack-horizon | 20:32 | |
*** dansiwie_ has joined #openstack-horizon | 20:33 | |
*** lucas__ has quit IRC | 20:35 | |
*** tjones1 has joined #openstack-horizon | 20:35 | |
*** dansiwie_ has quit IRC | 20:36 | |
*** tjones2 has joined #openstack-horizon | 20:36 | |
*** rajatvig has joined #openstack-horizon | 20:36 | |
*** stevemar has quit IRC | 20:37 | |
*** tjones1 has quit IRC | 20:40 | |
*** rajatvig has quit IRC | 20:40 | |
*** jacalcat_ has quit IRC | 20:43 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:44 | |
*** lucas__ has joined #openstack-horizon | 20:48 | |
*** tjones has quit IRC | 20:49 | |
*** lucas__ has quit IRC | 20:51 | |
*** lucas__ has joined #openstack-horizon | 20:51 | |
*** lblanchard has joined #openstack-horizon | 20:51 | |
*** Sukhdev_ has quit IRC | 20:55 | |
*** lucas__ has quit IRC | 20:55 | |
*** sergio__ has joined #openstack-horizon | 20:56 | |
*** sergio__ has quit IRC | 20:57 | |
*** lucas__ has joined #openstack-horizon | 20:57 | |
*** sergio__ has joined #openstack-horizon | 20:58 | |
*** sergio__ has quit IRC | 20:59 | |
*** sergio__ has joined #openstack-horizon | 20:59 | |
*** sergio__ has quit IRC | 20:59 | |
*** sergio__ has joined #openstack-horizon | 20:59 | |
*** sergio__ has quit IRC | 21:00 | |
*** alexvictorchan has quit IRC | 21:01 | |
*** lucas__ has quit IRC | 21:01 | |
ducttape_ | matt-borland - can you WIP https://review.openstack.org/#/c/204731/ ? I'm wondering if gerrit allows that, or if Kyle needs to do that | 21:04 |
*** absubram has quit IRC | 21:04 | |
ducttape_ | (set workflow to -1) | 21:04 |
matt-borland | Kyle Olivo owns that | 21:05 |
matt-borland | he has to | 21:05 |
matt-borland | I can tell them to try to keep the WIP active | 21:05 |
matt-borland | thx ducttape | 21:05 |
david-lyle | done | 21:05 |
ducttape_ | ah ok. I was just wondering permissions as much as anything | 21:05 |
ducttape_ | thanks | 21:05 |
matt-borland | david-lyle, I'll let those guys know to -1 WIP their stuff everytime | 21:06 |
TravT | i really wish gerrit would allow WIP to stay across patches until toggled back. | 21:06 |
matt-borland | if that is your desire | 21:06 |
ducttape_ | if you have multiple devs sharing a patch, who can do what? was my thinking | 21:06 |
matt-borland | yeah | 21:07 |
matt-borland | it would be great if -1 WIP persisted, or was triggered by something in the commit message. | 21:07 |
*** alexvictorchan has joined #openstack-horizon | 21:08 | |
*** rdopiera has quit IRC | 21:08 | |
tyr | "[WIP]" in title is reasonably effective | 21:09 |
ducttape_ | the tooling with automated reviews / check jobs needs something in the data model to enforce this, without just relying upon the title | 21:10 |
ducttape_ | but yeah, that helps people parse reviews | 21:11 |
matt-borland | the problem is because it's not persistent, it also relies on the owner remembering to -1 WIP it | 21:11 |
*** yamamoto has joined #openstack-horizon | 21:12 | |
matt-borland | I will attest to the fact that I'm not going to let panels go up WIP | 21:12 |
tqtran_ | changing commit message shouldnt trigger a gate job either | 21:12 |
matt-borland | (not the ones I'm working on) | 21:12 |
tyr | matt-borland: Why are the panels not WIP? | 21:13 |
matt-borland | they are! | 21:13 |
ducttape_ | tqtran_ - the jobs check the commit messages, so that needs a job to run | 21:13 |
tyr | matt-borland: what did you mean "not going to let panels go up WIP" | 21:14 |
TravT | tqtran_: yeah that commit message changing causing a zuul job is annoying. | 21:14 |
matt-borland | tyr: I mean, I am not going to ask people to approve stuff that is still in progress | 21:14 |
matt-borland | :) | 21:14 |
*** yamamoto has quit IRC | 21:14 | |
TravT | tqtran: i've got 15 mins now if you want to talk about your hz-include patch. | 21:14 |
TravT | or we can touch base in about an hour | 21:14 |
matt-borland | time to peace out | 21:14 |
matt-borland | o/ | 21:14 |
*** matt-borland has quit IRC | 21:15 | |
*** vokhrimenko has quit IRC | 21:15 | |
*** ekarlso has quit IRC | 21:16 | |
*** tqtran_ has quit IRC | 21:20 | |
*** vokhrimenko has joined #openstack-horizon | 21:20 | |
*** tjones2 has quit IRC | 21:21 | |
*** e0ne has quit IRC | 21:24 | |
*** lblanchard has quit IRC | 21:24 | |
*** tjones has joined #openstack-horizon | 21:24 | |
*** tjones1 has joined #openstack-horizon | 21:25 | |
*** tjones2 has joined #openstack-horizon | 21:26 | |
*** tjones1 has quit IRC | 21:26 | |
*** rajatvig has joined #openstack-horizon | 21:26 | |
*** pauloewerton has quit IRC | 21:27 | |
*** cbader has quit IRC | 21:28 | |
*** tjones has quit IRC | 21:29 | |
kfox1111 | david-lyle: https://github.com/kfox1111/apps-catalog-ui | 21:34 |
david-lyle | kfox1111: is that where all the magic happens? | 21:35 |
kfox1111 | has the steps to go from a fresh checkout to the plugin working. | 21:35 |
kfox1111 | most. :) | 21:35 |
kfox1111 | its really raw at the moment, but it works. that and the review for horizon. | 21:35 |
david-lyle | do you have the horizon review? | 21:36 |
kfox1111 | yup. just a sec | 21:36 |
david-lyle | ah it's in the README | 21:36 |
kfox1111 | https://review.openstack.org/#/c/206773/ | 21:36 |
david-lyle | I seei t | 21:36 |
kfox1111 | yup. | 21:36 |
kfox1111 | hmm.. rst mangled it... gota figoure out how to make it show the steps individually... | 21:36 |
david-lyle | * works | 21:37 |
*** annashen has quit IRC | 21:39 | |
*** vijendar has quit IRC | 21:39 | |
*** alexvictorchan has quit IRC | 21:39 | |
*** tjones2 has left #openstack-horizon | 21:40 | |
*** vishwanathj_ has quit IRC | 21:41 | |
*** jasondotstar has quit IRC | 21:41 | |
*** kaliya has joined #openstack-horizon | 21:43 | |
*** jtriley has quit IRC | 21:43 | |
*** annashen has joined #openstack-horizon | 21:43 | |
*** emw has quit IRC | 21:44 | |
*** ekarlso has joined #openstack-horizon | 21:44 | |
*** dboik has quit IRC | 21:46 | |
*** tjones has joined #openstack-horizon | 21:48 | |
*** alexvictorchan has joined #openstack-horizon | 21:48 | |
openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 21:49 |
kfox1111 | that should fix the pep8 errors... | 21:49 |
kfox1111 | david-lyle: Does that review look to be a reasonable size, or should I try and break it up further? | 21:50 |
david-lyle | kfox1111: size is fine | 21:51 |
kfox1111 | k. thx. | 21:52 |
*** alexvictorchan has quit IRC | 21:53 | |
*** alexvictorchan has joined #openstack-horizon | 21:54 | |
*** drupalmonkey has quit IRC | 21:57 | |
openstackgerrit | Yash Bathia proposed openstack/horizon: Check if Cinder is enabled before populating drop-down menu in Launch Instance https://review.openstack.org/205339 | 21:59 |
*** dboik has joined #openstack-horizon | 21:59 | |
*** jbell8 has quit IRC | 21:59 | |
*** jingjing_ren has joined #openstack-horizon | 22:03 | |
*** sqchen has joined #openstack-horizon | 22:04 | |
*** jpomeroy has quit IRC | 22:04 | |
*** annashen_ has joined #openstack-horizon | 22:07 | |
*** dansiwiec has joined #openstack-horizon | 22:10 | |
*** neelashah has quit IRC | 22:11 | |
*** annashen_ has quit IRC | 22:12 | |
*** yamamoto has joined #openstack-horizon | 22:15 | |
*** Sukhdev_ has joined #openstack-horizon | 22:19 | |
*** yamamoto has quit IRC | 22:20 | |
*** kzaitsev_mb has quit IRC | 22:22 | |
*** sqchen has quit IRC | 22:22 | |
*** dansiwiec has quit IRC | 22:23 | |
*** dansiwiec has joined #openstack-horizon | 22:24 | |
*** dboik has quit IRC | 22:25 | |
*** jasondotstar has joined #openstack-horizon | 22:28 | |
*** dansiwiec has quit IRC | 22:33 | |
*** dansiwiec has joined #openstack-horizon | 22:35 | |
openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 22:36 |
*** kyleolivo has joined #openstack-horizon | 22:37 | |
*** kristinebrown has joined #openstack-horizon | 22:37 | |
*** dansiwiec has quit IRC | 22:40 | |
openstackgerrit | Thai Tran proposed openstack/horizon: WIP Adding CREATE action to identity users panel https://review.openstack.org/202315 | 22:43 |
*** dansiwiec has joined #openstack-horizon | 22:44 | |
openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 22:45 |
*** tqtran has joined #openstack-horizon | 22:46 | |
tqtran | TravT: looks like i got disconnected :( | 22:46 |
tqtran | did you wan to touch base now? or still busy? | 22:47 |
*** ericksonsantos has quit IRC | 22:50 | |
*** htruta has quit IRC | 22:50 | |
*** jpomeroy has joined #openstack-horizon | 22:50 | |
*** Ephur has quit IRC | 22:51 | |
*** kristinebrown has quit IRC | 22:51 | |
*** mwhagedorn has quit IRC | 22:51 | |
*** ducttape_ has quit IRC | 22:53 | |
*** vishwanathj has joined #openstack-horizon | 22:53 | |
*** kzaitsev_mb has joined #openstack-horizon | 22:55 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 22:56 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 22:57 |
*** dsneddon has quit IRC | 22:57 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 22:58 |
*** kristinebrown has joined #openstack-horizon | 23:00 | |
*** alexvictorchan has quit IRC | 23:00 | |
*** kzaitsev_mb has quit IRC | 23:01 | |
tqtran | r1chardj0n3s: around? got a question for you | 23:01 |
openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - horizon/ tech-debt https://review.openstack.org/199345 | 23:01 |
*** alexpilotti has quit IRC | 23:05 | |
r1chardj0n3s | tqtran: hi, yeah? | 23:07 |
*** ZZelle has quit IRC | 23:07 | |
tqtran | for some reason, im not able to hit this api | 23:08 |
tqtran | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/keystone.py#L512 | 23:09 |
r1chardj0n3s | what happens when you try? | 23:09 |
tqtran | nvm found the problem | 23:10 |
r1chardj0n3s | yw | 23:10 |
r1chardj0n3s | :) | 23:10 |
tqtran | theres an extra white space in the url | 23:10 |
tqtran | -_- | 23:10 |
r1chardj0n3s | \o/ | 23:10 |
r1chardj0n3s | so, what did I miss over the last half a week? :( | 23:11 |
hurgleburgler | We rewrote horizon in React | 23:11 |
tqtran | helped kfox1111 tested the plugin with angular panel | 23:11 |
tqtran | https://github.com/tqtran7/mon-ext | 23:12 |
r1chardj0n3s | hurgleburgler: I thought you were pushing for that other one... darnit, I forgot the name tho :( | 23:12 |
tqtran | created an example plugin project for extending panels | 23:12 |
r1chardj0n3s | cool | 23:12 |
r1chardj0n3s | I saw that in passing - that's david-lyle's github project? | 23:12 |
tqtran | yeah, i forked his | 23:12 |
r1chardj0n3s | nice | 23:12 |
r1chardj0n3s | wow, I have a lot of reviews to read | 23:13 |
r1chardj0n3s | also, since my inbox hasn't been weeded in a while, apparently I have many bootycall/drug offers to take up! | 23:13 |
kfox1111 | and: https://github.com/kfox1111/apps-catalog-ui/ :) | 23:13 |
kfox1111 | tqtran: thoughts on https://review.openstack.org/#/c/206773 would be good too. :) | 23:14 |
hurgleburgler | r1chardj0n3s Canjs ಠ◡ಠ | 23:14 |
hurgleburgler | but no one has heard of that, so React was funnier | 23:14 |
r1chardj0n3s | ah yes | 23:14 |
r1chardj0n3s | :) | 23:14 |
tqtran | r1chardj0n3s: lol bootycall/drug offers, nice nice | 23:15 |
r1chardj0n3s | tqtran: I can forward them to you if you like? | 23:15 |
tqtran | i have it starred kfox1111, will eventually get around to it | 23:15 |
tqtran | r1chardj0n3s: no thanks :) i have enough weed | 23:16 |
tqtran | in my emails | 23:16 |
r1chardj0n3s | :) | 23:16 |
kfox1111 | tqtran: ok, thanks. :) | 23:16 |
*** jpomeroy has quit IRC | 23:17 | |
*** jpomeroy has joined #openstack-horizon | 23:17 | |
*** vishwanathj has quit IRC | 23:20 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Keystone project role REST is broken https://review.openstack.org/207252 | 23:20 |
openstackgerrit | Thai Tran proposed openstack/horizon: Keystone project role REST is broken https://review.openstack.org/207252 | 23:21 |
tqtran | TravT: I'm done with the create action, the only remaining item is the hz-include directive, lets touch base soon so i can start on the remaining actions. | 23:25 |
*** jacalcat has joined #openstack-horizon | 23:25 | |
r1chardj0n3s | ... | 23:25 |
r1chardj0n3s | hz-include? | 23:25 |
TravT | hey tqtran. | 23:25 |
r1chardj0n3s | ohai TravT | 23:26 |
tqtran | https://review.openstack.org/#/c/202330/ | 23:26 |
TravT | heya r1chardj0n3s | 23:26 |
TravT | you alive again r1chardj0n3s? | 23:26 |
r1chardj0n3s | fever down to minimal annoyance level, so close enough :) | 23:26 |
r1chardj0n3s | brain actually firing this morning, we'll see how long that lasts | 23:26 |
tqtran | gonna have me an ice cream cone | 23:27 |
tqtran | its so hot over here im melting | 23:27 |
r1chardj0n3s | OK, so there's nowhere near enough justification against that patch, tqtran :) | 23:27 |
hurgleburgler | tqtran how hot? ಠ_ಠ | 23:27 |
r1chardj0n3s | tqtran: *why* is creating a scope bad enough that we create a new mechanism to avoid it? | 23:28 |
tqtran | like 90 | 23:28 |
tqtran | because, ng-repeat creates it for you whether you like it or not | 23:28 |
*** annashen has quit IRC | 23:28 | |
tqtran | and this is very problematic | 23:28 |
TravT | tqtran, i'm in the middle of a deep debugging session on something... will be able to focus here in just a sec | 23:28 |
tqtran | for example, i want to use it on transfer table, to avoid template duplication | 23:29 |
tqtran | but i cant use it with ng-include, it would break it due to the child scope | 23:29 |
tqtran | this keeps coming up again and again, so i think its worth considering | 23:31 |
*** zhenguo has joined #openstack-horizon | 23:31 | |
*** jasondotstar has quit IRC | 23:33 | |
tqtran | hurgleburgler: actually its says 95 on my weather app | 23:33 |
*** kzaitsev_mb has joined #openstack-horizon | 23:36 | |
hurgleburgler | tqtran san jose, right? | 23:36 |
tqtran | yep | 23:36 |
*** jacalcat has quit IRC | 23:38 | |
TravT | anybody have a good online diff tool where I can share the diff via URL? just trying to show somebody the diff in API output easily. | 23:39 |
* TravT expects a lmgtfy.com link | 23:39 | |
*** jamielennox is now known as jamielennox|away | 23:39 | |
r1chardj0n3s | nothing springs to mind | 23:41 |
r1chardj0n3s | I think some of the pastebin-ish things handle diffs tho | 23:42 |
*** kristinebrown has quit IRC | 23:42 | |
*** ybathia has quit IRC | 23:43 | |
*** mpavlase has quit IRC | 23:44 | |
*** jasondotstar has joined #openstack-horizon | 23:45 | |
*** mwhagedorn has joined #openstack-horizon | 23:47 | |
*** darrenc is now known as darrenc_afk | 23:47 | |
*** jmolo1 has quit IRC | 23:50 | |
*** jmolo has joined #openstack-horizon | 23:50 | |
tqtran | can someone verify that master jasmine spec runner is passing? | 23:50 |
tqtran | im getting failures on master | 23:50 |
tqtran | nvm... seems to work now | 23:54 |
*** jmolo has quit IRC | 23:55 | |
*** rajatvig has quit IRC | 23:55 | |
openstackgerrit | Kyle Olivo proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!