| *** ybathia has quit IRC | 00:01 | |
| *** mpavlase has quit IRC | 00:02 | |
| *** kzaitsev_mb has quit IRC | 00:05 | |
| openstackgerrit | Merged openstack/horizon: Use the JP Style Guide for KeyStone Service https://review.openstack.org/211782 | 00:06 |
|---|---|---|
| *** ducttape_ has joined #openstack-horizon | 00:07 | |
| kfox1111 | nice. the dialog stuff works. :) | 00:09 |
| kfox1111 | now just gota put usefull stuff in it. :) | 00:09 |
| *** Ctina_ has quit IRC | 00:11 | |
| *** TravT_ has joined #openstack-horizon | 00:13 | |
| *** shivrao has quit IRC | 00:14 | |
| *** TravT has quit IRC | 00:15 | |
| *** SimonChung1 has quit IRC | 00:16 | |
| *** geoffarnold has quit IRC | 00:17 | |
| *** eroussel has joined #openstack-horizon | 00:18 | |
| *** jingjing_ren has quit IRC | 00:20 | |
| *** kristinebrown has quit IRC | 00:21 | |
| *** TravT has joined #openstack-horizon | 00:21 | |
| *** jingjing_ren has joined #openstack-horizon | 00:21 | |
| *** TravT_ has quit IRC | 00:24 | |
| *** jbell8 has joined #openstack-horizon | 00:24 | |
| *** garthb_ has quit IRC | 00:25 | |
| tqtran | have a good one everyone, logging off! | 00:25 |
| *** tqtran has quit IRC | 00:25 | |
| r1chardj0n3s | cya! | 00:26 |
| *** jingjing_ren has quit IRC | 00:26 | |
| *** ducttape_ has quit IRC | 00:34 | |
| *** ZZelle-off has quit IRC | 00:34 | |
| *** eroussel has quit IRC | 00:36 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:36 | |
| *** ducttape_ has joined #openstack-horizon | 00:40 | |
| *** ducttape_ has quit IRC | 00:40 | |
| *** ducttape_ has joined #openstack-horizon | 00:41 | |
| *** ducttape_ has quit IRC | 00:48 | |
| *** Sukhdev has quit IRC | 00:50 | |
| *** jingjing_ren has joined #openstack-horizon | 00:51 | |
| *** jingjing_ren has quit IRC | 00:55 | |
| *** kzaitsev_mb has quit IRC | 00:56 | |
| *** ctina has quit IRC | 01:03 | |
| *** jwy has quit IRC | 01:04 | |
| *** ctina has joined #openstack-horizon | 01:07 | |
| *** ducttape_ has joined #openstack-horizon | 01:10 | |
| *** bpokorny_ has quit IRC | 01:10 | |
| *** hurgleburgler has joined #openstack-horizon | 01:12 | |
| *** jpomeroy has quit IRC | 01:18 | |
| *** zhenguo has joined #openstack-horizon | 01:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 01:23 | |
| *** jpomeroy has joined #openstack-horizon | 01:24 | |
| *** lyanchih has joined #openstack-horizon | 01:29 | |
| logan2 | running kilo, the images owned by a project are not showing up under the images overview. project shows no items. glance image-list shows the images owned by the project however | 01:35 |
| logan2 | then if i add membership with member-create, the image shows up under the member tenant "shared with me", however it is not limited to only the member tenant. it shows up under every tenant's "shared" images | 01:36 |
| *** saksham has quit IRC | 01:39 | |
| *** jwy has joined #openstack-horizon | 01:42 | |
| *** jbell8 has quit IRC | 01:43 | |
| *** tjones has joined #openstack-horizon | 01:43 | |
| logan2 | so that is with a tenant id set as 'owner' field, or member-create. now I decided to test uploading an image via horizon directly and the result was an image which still did not show up under the tenant, which has no owner set | 01:44 |
| *** tjones has left #openstack-horizon | 01:44 | |
| *** tyr_ has joined #openstack-horizon | 01:51 | |
| *** hurgleburgler has quit IRC | 01:53 | |
| *** kzaitsev_mb has quit IRC | 01:54 | |
| *** tyr_ has quit IRC | 01:56 | |
| *** jbell8 has joined #openstack-horizon | 02:01 | |
| *** ducttape_ has quit IRC | 02:02 | |
| *** yamamoto has joined #openstack-horizon | 02:05 | |
| *** jbell8 has quit IRC | 02:06 | |
| *** jwy has quit IRC | 02:10 | |
| *** yamamoto has quit IRC | 02:14 | |
| *** kzaitsev_mb has joined #openstack-horizon | 02:20 | |
| *** kzaitsev_mb has quit IRC | 02:27 | |
| *** clu_ has quit IRC | 02:28 | |
| *** Piet has joined #openstack-horizon | 02:32 | |
| *** bpokorny has joined #openstack-horizon | 02:35 | |
| *** lyanchih has quit IRC | 02:36 | |
| openstackgerrit | Merged openstack/horizon: Moving inline html code out of transfer-table.spec.js https://review.openstack.org/213367 | 02:44 |
| *** logan2 has quit IRC | 02:44 | |
| stevemar | david-lyle: what do you mean by "Give me something that I can exhaustively list in the API I can build from" | 02:49 |
| *** lyanchih has joined #openstack-horizon | 02:51 | |
| *** jpomeroy has quit IRC | 02:58 | |
| *** bpokorny has quit IRC | 03:06 | |
| *** tyr_ has joined #openstack-horizon | 03:06 | |
| *** yamamoto has joined #openstack-horizon | 03:06 | |
| *** tyr_ has quit IRC | 03:11 | |
| *** bpokorny has joined #openstack-horizon | 03:23 | |
| *** garthb has joined #openstack-horizon | 03:32 | |
| *** logan2 has joined #openstack-horizon | 03:34 | |
| *** fedexo has joined #openstack-horizon | 03:47 | |
| *** KunalGandhi has quit IRC | 03:59 | |
| *** lyanchih has quit IRC | 04:03 | |
| david-lyle | stevemar: they is a way to map the information if I have a building block like the list of projects, from there I can find users that I need and I have enough structure to discover the rest. Without a common resource to index, I don't have the ability to do it otherwise. And yes I've worked in an environment where 500 domains and 500 projects were not enough to even come close. | 04:04 |
| david-lyle | s/they/there/ | 04:04 |
| *** zhenguo has quit IRC | 04:06 | |
| *** lhcheng has quit IRC | 04:06 | |
| *** zz_ttrifonov is now known as ttrifonov | 04:10 | |
| *** ttrifonov is now known as zz_ttrifonov | 04:11 | |
| *** tjones has joined #openstack-horizon | 04:14 | |
| *** tjones has left #openstack-horizon | 04:14 | |
| stevemar | david-lyle: i'm still not following :\ | 04:15 |
| *** clu_ has joined #openstack-horizon | 04:15 | |
| stevemar | david-lyle: how is GET /v3/projects not working if thats the case? | 04:16 |
| david-lyle | if I don't filter, how would it for > 500? | 04:17 |
| david-lyle | assuming 500 is the API limit | 04:17 |
| *** clu_ has quit IRC | 04:17 | |
| david-lyle | I'll get 500 and then error that there is more, but no way to index into it | 04:17 |
| r1chardj0n3s | david-lyle: got time for a question about the selenium tests? | 04:19 |
| david-lyle | r1chardj0n3s: sure | 04:20 |
| stevemar | david-lyle: i'm not grokking, but i'll bug you about it tomorrow, maybe over a quick call | 04:21 |
| r1chardj0n3s | david-lyle: one test that's failing is because the page it hits returns "500 Error" - to try to get some actual info on what's failing, I turned DEBUG on in the test settings.py, but that cause a strange knock-on error in the settings configuration around static files - does that ring any bells? | 04:21 |
| david-lyle | stevemar: that works | 04:21 |
| david-lyle | r1chardj0n3s: knock-on? | 04:22 |
| *** fedexo has quit IRC | 04:22 | |
| david-lyle | which test? | 04:22 |
| r1chardj0n3s | as in, turning DEBUG=True in test/settings.py results in the live server startup failing with an error in settings "ImproperlyConfigured: Empty static prefix not permitted" | 04:22 |
| david-lyle | I've been digging into the identity, but the names requested are not on the page, so call the action URL with that object is a 500 error | 04:23 |
| r1chardj0n3s | openstack_dashboard.dashboards.identity.projects.tests:SeleniumTests.test_inline_editing_cancel | 04:23 |
| r1chardj0n3s | the URL being requested is just /identity/ which is a valid URL but the page just has "500 Error" on it, yes | 04:23 |
| r1chardj0n3s | & I have zero information about what might be causing the 500, so I tried turning DEBUG on, and that cause the static file config to complain, and I thought maybe you might know why, since I don't even understand why DEBUG isn't turned on for the tests in the first place.... | 04:24 |
| r1chardj0n3s | (since without DEBUG on, it's nigh on impossible to actually debug test failures... there's no logging AFAICT) | 04:25 |
| r1chardj0n3s | (I don't know why I don't seem to be able to spell "caused" correctly, just so you know) | 04:26 |
| david-lyle | DEBUG does not look to actually work with selenium | 04:26 |
| david-lyle | I get 52 errors instead of 5 for openstack_dashboard | 04:26 |
| r1chardj0n3s | yes, because of the static file configuration error, I imagine :) | 04:27 |
| david-lyle | the first request succeeds to /identity/ | 04:27 |
| david-lyle | it's the action that fails with 500 | 04:27 |
| r1chardj0n3s | how do you know that? | 04:27 |
| david-lyle | I put prints in the test | 04:27 |
| r1chardj0n3s | oh | 04:27 |
| david-lyle | old school :P | 04:27 |
| r1chardj0n3s | oh my | 04:27 |
| david-lyle | but you can print the result | 04:27 |
| david-lyle | and analyze it | 04:27 |
| david-lyle | I just don't know why "name__1" is not in the page | 04:28 |
| david-lyle | but it's not and hence it's not foudn | 04:28 |
| david-lyle | *found | 04:28 |
| david-lyle | html_elem = self.selenium.find_element_by_tag_name("html") | 04:29 |
| david-lyle | print html_elem.get_attribute("innerHTML").encode("UTF-8") | 04:29 |
| david-lyle | will dump the page to the console | 04:29 |
| r1chardj0n3s | oh my | 04:29 |
| david-lyle | of course sending to a file would be faster | 04:29 |
| r1chardj0n3s | this is, like, the worst possible scenario for debugging selenium test failures :9 | 04:29 |
| r1chardj0n3s | :( | 04:29 |
| david-lyle | bingo | 04:29 |
| r1chardj0n3s | there's a crazy lack of information here :( | 04:29 |
| david-lyle | which is why with over 40 active devs it's you and me :D | 04:30 |
| r1chardj0n3s | ARGH and I can't even "import pdb; pdb.set_trace()" in the goddamn test because NOSE YOU UTTER CRAP TOOL | 04:30 |
| david-lyle | you should be able to use pdb | 04:30 |
| r1chardj0n3s | it went all screwy | 04:30 |
| david-lyle | haven't tried with selenium, but the other nose tests work fine | 04:31 |
| r1chardj0n3s | shouldn't make a difference | 04:31 |
| david-lyle | not sure what the selenium joy is adding to that hot mess | 04:31 |
| *** lhcheng has joined #openstack-horizon | 04:32 | |
| *** kiran-r has joined #openstack-horizon | 04:32 | |
| r1chardj0n3s | and also, selenium tests using xpath to find the elements? so fragile :( | 04:32 |
| david-lyle | yeah pdb sends it off into never-never land | 04:33 |
| r1chardj0n3s | just add a damned id to the element :( | 04:33 |
| r1chardj0n3s | ok, I've got pdb going | 04:33 |
| david-lyle | yeah selenium is not my favorite tool | 04:34 |
| r1chardj0n3s | selenium isn't perfect, but using xpath for element selection is just asking for trouble | 04:35 |
| *** kiran-r has quit IRC | 04:37 | |
| r1chardj0n3s | OK, so I get the "500 Error" before it attempts to find the name__1 element, so that explains why it can't be found | 04:40 |
| r1chardj0n3s | just trying to reload the page when it's sitting on the failed test, timing out, results in the 500 error. I really need to know what is causing that error | 04:41 |
| r1chardj0n3s | looks like I'm gonna be trying to figure out what that static file configuration issue is :( | 04:41 |
| david-lyle | so it's the initial page load that 500s and then the action that results in a page render? | 04:42 |
| david-lyle | I just started digging back into this again today | 04:42 |
| r1chardj0n3s | no, I get an initial page load, but I think the static files stuff is all messed up 'cos the styling is broken and all. I think maybe the JS isn | 04:42 |
| r1chardj0n3s | 't being loaded correctly | 04:42 |
| david-lyle | well it's always been broken | 04:43 |
| david-lyle | style wise | 04:43 |
| r1chardj0n3s | \o/ | 04:43 |
| david-lyle | but the js used to work | 04:43 |
| r1chardj0n3s | oh, there's no MEDIA_URL defined | 04:44 |
| david-lyle | we don't use that | 04:44 |
| r1chardj0n3s | it's used ;) | 04:45 |
| david-lyle | by what? | 04:45 |
| david-lyle | and since when? | 04:45 |
| r1chardj0n3s | File "/Users/richard/src/openstack/horizon/openstack_dashboard/test/urls.py", line 46, in <module> | 04:45 |
| r1chardj0n3s | urlpatterns += static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT) | 04:45 |
| r1chardj0n3s | File "/Users/richard/src/openstack/horizon/.venv/lib/python2.7/site-packages/django/conf/urls/static.py", line 24, in static | 04:45 |
| r1chardj0n3s | raise ImproperlyConfigured("Empty static prefix not permitted") | 04:45 |
| r1chardj0n3s | ImproperlyConfigured: Empty static prefix not permitted | 04:45 |
| r1chardj0n3s | that's what you get if you turn DEBUG on | 04:45 |
| r1chardj0n3s | openstack_dashboard/settings.py does define a MEDIA_URL | 04:46 |
| r1chardj0n3s | ugh, disabling that url pattern I get a server that starts up, but even with DEBUG on all I see is that bloody "500 Errro" | 04:48 |
| r1chardj0n3s | I think logging is going to be needed for this | 04:48 |
| david-lyle | says media and static need to be different | 04:49 |
| david-lyle | mine already are | 04:49 |
| lifeless | r1chardj0n3s: could you use rpdb ? | 04:49 |
| r1chardj0n3s | lifeless: thanks, but I've moved on from that | 04:50 |
| lifeless | r1chardj0n3s: cool, np, gol | 04:50 |
| lifeless | erm gl | 04:50 |
| r1chardj0n3s | now I have to see if I can find where the "test" logging handler is defined | 04:50 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L367 | 04:51 |
| david-lyle | oops wrong file, ignore | 04:51 |
| lifeless | david-lyle: if you haven't seen it - https://pypi.python.org/pypi/rpdb - very useful when stdout is captured or the process as a whole is inaccessible to you | 04:52 |
| *** bpokorny has quit IRC | 04:52 | |
| david-lyle | r1chardj0n3s: https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/settings.py#L157 | 04:52 |
| david-lyle | lifeless: nice, thank you | 04:52 |
| r1chardj0n3s | david-lyle: oh, I see that - but it refers to the 'test' handler, and I can't find where it's defined | 04:53 |
| r1chardj0n3s | hm, or I just create my own and ignore the test handler | 04:53 |
| r1chardj0n3s | (and then he found himself reading https://docs.python.org/3/library/logging.config.html#logging-config-dictschema and wondered "how did I get here today?") | 04:54 |
| *** hurgleburgler has joined #openstack-horizon | 04:55 | |
| r1chardj0n3s | AH, the test handler is defined in the horizon test settings | 04:55 |
| *** yingjun has joined #openstack-horizon | 04:56 | |
| david-lyle | selenium is set to DEBUG | 04:57 |
| david-lyle | but to the null handler | 04:58 |
| david-lyle | joy | 04:58 |
| r1chardj0n3s | don't actually need selenium's logging (it's not usually helpful) | 04:58 |
| r1chardj0n3s | urgh. so apparently the server isn't logging a damned thing | 04:59 |
| * r1chardj0n3s installs logging_tree to try to figure out how this logging configuration is broken | 04:59 | |
| david-lyle | not for selenium at least | 04:59 |
| *** sayan has joined #openstack-horizon | 05:00 | |
| *** tjones has joined #openstack-horizon | 05:00 | |
| r1chardj0n3s | holy crap that is the largest logging tree I've ever seen | 05:01 |
| *** hurgleburgler has quit IRC | 05:01 | |
| r1chardj0n3s | could take me a couple of days to decipher it alone! | 05:01 |
| r1chardj0n3s | \o/ I have an exception in my log \o/ | 05:03 |
| r1chardj0n3s | argh it's a bloody mox UnexpectedMethodCallError | 05:04 |
| *** yingjun has quit IRC | 05:04 | |
| *** gyee has quit IRC | 05:04 | |
| r1chardj0n3s | david-lyle: I think it's breaking because api.keystone.tenant_list is not mox'ed? where is stuff mox'ed? | 05:05 |
| r1chardj0n3s | hmm, I think that this should be doing it ... @test.create_stubs({api.keystone: ('tenant_list', 'tenant_get', 'tenant_update')}) | 05:06 |
| *** kmARC_ has joined #openstack-horizon | 05:07 | |
| *** tyr has joined #openstack-horizon | 05:07 | |
| *** kmARC__ has joined #openstack-horizon | 05:07 | |
| r1chardj0n3s | oh, wait, mox requires you to mock every call individually, doesn't it. so if there's >1 call... | 05:08 |
| david-lyle | you could try MutlipleTimes | 05:08 |
| *** tyr has quit IRC | 05:11 | |
| david-lyle | MultipleTimes yields new errors | 05:13 |
| r1chardj0n3s | definitely changes the error conditions yup | 05:14 |
| r1chardj0n3s | (sorry, ducked away for a moment there) | 05:14 |
| *** vijendar has quit IRC | 05:14 | |
| david-lyle | no worries, I'm not sure the error is better | 05:15 |
| r1chardj0n3s | hmm, I still get a mox UnexpectedMethodCallError from the same line though... that's weird | 05:15 |
| *** jbell8 has joined #openstack-horizon | 05:15 | |
| *** tjones has quit IRC | 05:15 | |
| david-lyle | what line? | 05:16 |
| r1chardj0n3s | no, wait, the log file was the old one. | 05:16 |
| r1chardj0n3s | dead herring | 05:16 |
| david-lyle | looks like only one list should happen | 05:17 |
| david-lyle | the next is a get to update the row of the item operated upon | 05:17 |
| r1chardj0n3s | oh, I'm testing the _cancel test ;) | 05:18 |
| r1chardj0n3s | it still doesn't pass, but the UI interaction appears to work... | 05:18 |
| david-lyle | progress | 05:19 |
| r1chardj0n3s | I'm switching to _update so at least we're looking at the same fail | 05:20 |
| *** yingjun has joined #openstack-horizon | 05:21 | |
| *** garthb has quit IRC | 05:22 | |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/tests.py#L1661 | 05:23 |
| *** kzaitsev_mb has joined #openstack-horizon | 05:23 | |
| david-lyle | is that intended to fail? | 05:24 |
| r1chardj0n3s | now that the page is rendering correctly, that's what I'm trying to determine :) | 05:24 |
| *** tyr has joined #openstack-horizon | 05:24 | |
| david-lyle | shouldn't be | 05:24 |
| *** yingjun has quit IRC | 05:24 | |
| *** yingjun has joined #openstack-horizon | 05:25 | |
| r1chardj0n3s | oh, hai error in console | 05:26 |
| david-lyle | the only other reference I see to name__1 is https://github.com/openstack/horizon/blob/master/horizon/test/tests/tables.py | 05:26 |
| r1chardj0n3s | injector error looking for horizon.app | 05:27 |
| r1chardj0n3s | (when the edit button is clicked) | 05:27 |
| *** kzaitsev_mb has quit IRC | 05:27 | |
| *** tyr has quit IRC | 05:29 | |
| r1chardj0n3s | I can't see where Sean's magic js file finder is hooked into the test settings.py | 05:31 |
| *** yamamoto has quit IRC | 05:32 | |
| david-lyle | well testing is not important | 05:32 |
| r1chardj0n3s | :P | 05:32 |
| *** yingjun has quit IRC | 05:33 | |
| *** vgridnev has joined #openstack-horizon | 05:34 | |
| *** yingjun has joined #openstack-horizon | 05:34 | |
| r1chardj0n3s | \o/ | 05:34 |
| r1chardj0n3s | moar success! | 05:34 |
| r1chardj0n3s | selenium can now edit, but the mox assertion post-edit is incorrect | 05:35 |
| *** hurgleburgler has joined #openstack-horizon | 05:35 | |
| r1chardj0n3s | \o/ complete success | 05:38 |
| *** yingjun has quit IRC | 05:38 | |
| *** lsmola has joined #openstack-horizon | 05:39 | |
| david-lyle | r1chardj0n3s: I can duplicate the success | 05:40 |
| *** yingjun has joined #openstack-horizon | 05:40 | |
| r1chardj0n3s | \o/ | 05:40 |
| david-lyle | added MEDIA_URL, MEDIA_ROOT, and find_static_files() | 05:40 |
| r1chardj0n3s | didn't need to add MEDIA* | 05:41 |
| r1chardj0n3s | (DEBUG is not on) | 05:41 |
| david-lyle | ok | 05:41 |
| david-lyle | add STATIC_URL too | 05:41 |
| david-lyle | but may not need that | 05:41 |
| r1chardj0n3s | ok, I'm going to branch fresh from master and submit the patch; just need to figure how many tests this causes to pass | 05:41 |
| david-lyle | I've been only running on openstack_dashboard side | 05:42 |
| r1chardj0n3s | I need to add find_static_files to horizon test settings too | 05:42 |
| r1chardj0n3s | yeah | 05:42 |
| david-lyle | yup | 05:42 |
| david-lyle | man you have a peaceful work day | 05:43 |
| david-lyle | excluding me | 05:43 |
| r1chardj0n3s | what, with me screaming obscenities at horizon? :) | 05:44 |
| david-lyle | if you scream obscenities in an empty forest... | 05:44 |
| r1chardj0n3s | :) | 05:44 |
| r1chardj0n3s | hmm, looks like the horizon test failures aren't affected by this fix | 05:45 |
| r1chardj0n3s | but then they failed because of that "select all" widget that wasn't appearing | 05:45 |
| r1chardj0n3s | that's not JS I think | 05:46 |
| r1chardj0n3s | also the entire qunit suite is still failing, and that probably is because of JS config, but can be a separate patch | 05:46 |
| david-lyle | yeah, at least put up the openstack_dashboard side | 05:46 |
| david-lyle | we'll get that piece moving | 05:46 |
| r1chardj0n3s | I think I should probably *not* patch sean's js finder into horizon test settings until we know it solves some problem | 05:47 |
| david-lyle | easy +2 from me | 05:47 |
| r1chardj0n3s | yep | 05:47 |
| r1chardj0n3s | oh, cool, only 2 fails in openstack_dashboard side | 05:47 |
| david-lyle | I get none on openstack_dashboard side | 05:47 |
| david-lyle | which is failing for you? | 05:47 |
| david-lyle | selenium only | 05:47 |
| david-lyle | I guess I should run the whole suite | 05:48 |
| r1chardj0n3s | test_create_image_from_file, test_modal_create_image_from_file | 05:48 |
| david-lyle | that's working for me now | 05:48 |
| r1chardj0n3s | hm | 05:48 |
| r1chardj0n3s | you also added MEDIA and STATIC URL | 05:48 |
| david-lyle | I removed MEDIA | 05:48 |
| r1chardj0n3s | what did you set those to? | 05:48 |
| r1chardj0n3s | ok | 05:49 |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 05:49 |
| david-lyle | STATIC_URL = '/static/' | 05:49 |
| david-lyle | added WEBROOT = '/' too | 05:49 |
| r1chardj0n3s | ok, re-testing | 05:49 |
| r1chardj0n3s | nup, still see fails | 05:50 |
| r1chardj0n3s | hm | 05:50 |
| david-lyle | do you have any other editS? | 05:50 |
| r1chardj0n3s | nup. ok, how about you push up your patch, it's silly for me to try to reproduce yours. | 05:50 |
| r1chardj0n3s | tho then you can't +2 it ;) | 05:51 |
| david-lyle | ok running horizon and openstack_dashboard, hopefully no interplay | 05:51 |
| *** Sukhdev has joined #openstack-horizon | 05:51 | |
| david-lyle | I can find folks | 05:51 |
| r1chardj0n3s | :) | 05:51 |
| *** yamamoto has joined #openstack-horizon | 05:51 | |
| david-lyle | still running | 05:52 |
| david-lyle | problem is they don't run in the gate | 05:52 |
| david-lyle | or check | 05:52 |
| david-lyle | you'd have to pull to verify for now | 05:52 |
| r1chardj0n3s | yup | 05:52 |
| *** yamamoto has quit IRC | 05:53 | |
| david-lyle | ok, still succeeded | 05:53 |
| r1chardj0n3s | ship it! | 05:53 |
| *** vgridnev has quit IRC | 05:53 | |
| *** yamamoto has joined #openstack-horizon | 05:53 | |
| *** ^Gal^ has joined #openstack-horizon | 05:54 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixes Selenium tests for openstack_dashboard https://review.openstack.org/214011 | 05:57 |
| *** yamamoto has quit IRC | 05:58 | |
| *** SimonChung has joined #openstack-horizon | 06:00 | |
| r1chardj0n3s | um. wtf. I get zero failures in either horizon or openstack_dashboard with --only-selenium | 06:02 |
| r1chardj0n3s | with that patch | 06:02 |
| *** masco has joined #openstack-horizon | 06:02 | |
| david-lyle | wanted to add you as a co-author | 06:02 |
| david-lyle | what should I put? | 06:02 |
| *** ^Gal^ has quit IRC | 06:03 | |
| *** ^Gal^ has joined #openstack-horizon | 06:03 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixes Selenium tests for openstack_dashboard https://review.openstack.org/214011 | 06:03 |
| david-lyle | change as necessary | 06:03 |
| *** SimonChung1 has joined #openstack-horizon | 06:04 | |
| r1chardj0n3s | oh, thanks :) | 06:04 |
| david-lyle | no horizon failures? | 06:04 |
| david-lyle | I was still seeing horizon failures | 06:04 |
| david-lyle | :( | 06:04 |
| david-lyle | cray cray | 06:04 |
| r1chardj0n3s | oh, I buggered up the phantomjs webdriver import and that just silently removed tests from the suite :/ | 06:04 |
| david-lyle | ah, ok, 1 less cray | 06:05 |
| r1chardj0n3s | :) | 06:05 |
| *** yamamoto has joined #openstack-horizon | 06:06 | |
| *** mhorban has quit IRC | 06:06 | |
| *** SimonChung has quit IRC | 06:06 | |
| r1chardj0n3s | I really should put in a patch for phantomjs support | 06:06 |
| david-lyle | same changes on horizon side, 0 effect | 06:06 |
| r1chardj0n3s | I wanted to ask you tho - so it looks like run_tests configures testing stuff thru environment vars | 06:06 |
| r1chardj0n3s | so adding another env var to say --use-phantomjs would be ok? | 06:07 |
| david-lyle | sure | 06:07 |
| r1chardj0n3s | ok | 06:07 |
| r1chardj0n3s | nup, I still see those two image test fails | 06:09 |
| david-lyle | I see them pass on my system | 06:09 |
| *** yamamoto has quit IRC | 06:09 | |
| david-lyle | I mean I see the pages and the actions | 06:09 |
| *** yamamoto has joined #openstack-horizon | 06:09 | |
| david-lyle | interesting | 06:09 |
| r1chardj0n3s | I'll keep poking at them | 06:09 |
| david-lyle | I'll try fresh | 06:10 |
| *** juggler has quit IRC | 06:10 | |
| r1chardj0n3s | were you seeing them fail without your patch? | 06:10 |
| david-lyle | yes | 06:10 |
| r1chardj0n3s | ok | 06:10 |
| david-lyle | either way, it's not worse | 06:11 |
| david-lyle | we can get someone else to determine quorum | 06:11 |
| r1chardj0n3s | yup | 06:11 |
| r1chardj0n3s | ok, so this is gonna make your day | 06:11 |
| r1chardj0n3s | running test_create_image_from_file by itself passes | 06:11 |
| r1chardj0n3s | hmm | 06:11 |
| r1chardj0n3s | actually | 06:11 |
| david-lyle | cleaned static and it still passes | 06:12 |
| r1chardj0n3s | ah, it might be a phantom vs. firefox thing | 06:12 |
| r1chardj0n3s | yep | 06:12 |
| r1chardj0n3s | fails in phantom | 06:12 |
| r1chardj0n3s | passes in firefox | 06:12 |
| r1chardj0n3s | ugh | 06:12 |
| david-lyle | robust test suite for the win | 06:12 |
| r1chardj0n3s | usually such errors come down to timing | 06:13 |
| r1chardj0n3s | er, such discrepancies that is | 06:13 |
| david-lyle | if it's that fragile on timing then it's really an error | 06:14 |
| r1chardj0n3s | yeah, there's no pause between the typing in the filename and looking to see whether the ui has changed | 06:15 |
| r1chardj0n3s | *might* be the cause | 06:16 |
| r1chardj0n3s | hmm | 06:16 |
| r1chardj0n3s | um. so there's no entry box on the page for file name. just a "choose file" button | 06:19 |
| r1chardj0n3s | I don't think you can send_keys() that | 06:19 |
| david-lyle | test file again? | 06:20 |
| r1chardj0n3s | test_create_image_from_file | 06:20 |
| david-lyle | in images/images or just images :) | 06:20 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/214020 | 06:20 |
| r1chardj0n3s | oh, project/images/tests.py | 06:21 |
| r1chardj0n3s | 433 | 06:21 |
| david-lyle | got it | 06:21 |
| r1chardj0n3s | feel free to stop working any time now, btw. I'll be stopping work in 40 minutes ;) | 06:21 |
| david-lyle | wait on 432 lines in that file | 06:21 |
| david-lyle | *only | 06:21 |
| r1chardj0n3s | good point | 06:22 |
| r1chardj0n3s | I added a line | 06:22 |
| *** lyanchih has joined #openstack-horizon | 06:22 | |
| david-lyle | it's selecting the type on 427 | 06:22 |
| r1chardj0n3s | 432 is the line raising the exception | 06:22 |
| r1chardj0n3s | line 429 is where it does the typey typey | 06:22 |
| r1chardj0n3s | but it's a file selection input, which has no typey typey input | 06:23 |
| r1chardj0n3s | at least not in WebKit | 06:23 |
| david-lyle | try the live UI | 06:23 |
| david-lyle | it works weird | 06:23 |
| david-lyle | I remember walking through it | 06:23 |
| david-lyle | but will look again | 06:23 |
| *** zhenguo has joined #openstack-horizon | 06:24 | |
| *** tyr has joined #openstack-horizon | 06:25 | |
| r1chardj0n3s | looks like this is a known problem with phantomjs file upload and send_keys | 06:27 |
| r1chardj0n3s | :( | 06:27 |
| david-lyle | you're winning with phantomjs | 06:27 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/214023 | 06:28 |
| *** jtomasek has joined #openstack-horizon | 06:29 | |
| r1chardj0n3s | having said all that, I'm not sure why send_keys is being used | 06:29 |
| *** tyr has quit IRC | 06:29 | |
| david-lyle | bad test, someone was lazy | 06:29 |
| r1chardj0n3s | and not set_value (IIRC) | 06:29 |
| *** stevemar has quit IRC | 06:29 | |
| * r1chardj0n3s wanders off to selenium manual | 06:30 | |
| david-lyle | or cut and paster | 06:30 |
| david-lyle | typo, but I like it | 06:30 |
| *** hurgleburgler has quit IRC | 06:32 | |
| *** zhenguo has quit IRC | 06:32 | |
| *** ybathia has joined #openstack-horizon | 06:36 | |
| *** linkedinyou has quit IRC | 06:40 | |
| *** openstackgerrit_ has joined #openstack-horizon | 06:43 | |
| r1chardj0n3s | ok, I mis-remembered that bit of selenium (previously I've had a set_value helper which wrapped the selenium yuckiness) .. unfortunately phantom and file upload just is an unhappy mess. tests work in firefox tho | 06:46 |
| *** vgridnev has joined #openstack-horizon | 06:55 | |
| *** mrunge has joined #openstack-horizon | 07:01 | |
| *** amotoki has quit IRC | 07:01 | |
| david-lyle | would be nice if they were portable though | 07:02 |
| david-lyle | I'm now in the bowels of the horizon table code looking into the multiselect failure | 07:03 |
| david-lyle | the element isn't even being added to the page, not sure why yet | 07:03 |
| *** mpavlase has joined #openstack-horizon | 07:04 | |
| openstackgerrit | Marcos FermÃn Lobo proposed openstack/horizon: Add hostname validation for create instance https://review.openstack.org/185904 | 07:06 |
| *** Sukhdev has quit IRC | 07:07 | |
| r1chardj0n3s | david-lyle: that's the behaviour I saw - hence I was quite unsure where the fault lay | 07:09 |
| * r1chardj0n3s is stopping for the day tho | 07:09 | |
| * david-lyle should too | 07:09 | |
| david-lyle | maybe after sleep it will just occur to me | 07:10 |
| david-lyle | doubtful, but can't hurt | 07:10 |
| david-lyle | have a good evening | 07:10 |
| *** sayan has quit IRC | 07:11 | |
| *** peristeri has joined #openstack-horizon | 07:11 | |
| r1chardj0n3s | have a good sleep :) | 07:13 |
| *** sayan has joined #openstack-horizon | 07:13 | |
| *** dguerri` is now known as dguerri | 07:13 | |
| *** markus_z has joined #openstack-horizon | 07:14 | |
| *** kmARC__ has quit IRC | 07:14 | |
| *** kmARC_ has quit IRC | 07:15 | |
| *** vgridnev has quit IRC | 07:16 | |
| *** dguerri is now known as dguerri` | 07:16 | |
| openstackgerrit | Merged openstack/horizon: Add default sorting to the Security Groups table. https://review.openstack.org/213143 | 07:21 |
| *** fedexo has joined #openstack-horizon | 07:22 | |
| *** dguerri` is now known as dguerri | 07:24 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: API for getting and updating quotas https://review.openstack.org/207126 | 07:25 |
| *** MaxV has joined #openstack-horizon | 07:26 | |
| *** mpavlase has quit IRC | 07:28 | |
| *** tmazur has joined #openstack-horizon | 07:30 | |
| *** stevemar has joined #openstack-horizon | 07:30 | |
| *** dguerri is now known as dguerri` | 07:32 | |
| *** MaxV has quit IRC | 07:32 | |
| *** dguerri` is now known as dguerri | 07:32 | |
| *** stevemar has quit IRC | 07:34 | |
| *** lyanchih has quit IRC | 07:34 | |
| *** lhcheng has quit IRC | 07:35 | |
| *** exploreshaifali has joined #openstack-horizon | 07:36 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 07:37 |
| *** fedexo has quit IRC | 07:38 | |
| *** dguerri is now known as dguerri` | 07:39 | |
| *** tmazur has quit IRC | 07:39 | |
| *** lyanchih has joined #openstack-horizon | 07:41 | |
| *** amotoki has joined #openstack-horizon | 07:42 | |
| *** yingjun has quit IRC | 07:45 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 07:51 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 07:52 |
| *** bradjones has quit IRC | 07:53 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 07:54 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 07:54 |
| *** linkedinyou has joined #openstack-horizon | 07:55 | |
| *** bradjones has joined #openstack-horizon | 07:56 | |
| *** bradjones has quit IRC | 07:56 | |
| *** bradjones has joined #openstack-horizon | 07:56 | |
| *** kmARC_ has joined #openstack-horizon | 07:56 | |
| *** jcoufal has joined #openstack-horizon | 07:56 | |
| *** kmARC_ has quit IRC | 07:56 | |
| *** MaxV has joined #openstack-horizon | 08:00 | |
| *** ybathia has quit IRC | 08:03 | |
| *** MaxV has quit IRC | 08:05 | |
| *** sayan has quit IRC | 08:08 | |
| *** mpavlase has joined #openstack-horizon | 08:10 | |
| *** mpavlase has joined #openstack-horizon | 08:10 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/214020 | 08:11 |
| *** romainh has joined #openstack-horizon | 08:12 | |
| *** vgridnev has joined #openstack-horizon | 08:13 | |
| *** MaxV has joined #openstack-horizon | 08:15 | |
| *** tyr has joined #openstack-horizon | 08:24 | |
| *** bluex-pl has joined #openstack-horizon | 08:27 | |
| *** bluex-pl has quit IRC | 08:28 | |
| *** bluex-pl has joined #openstack-horizon | 08:28 | |
| *** tyr has quit IRC | 08:29 | |
| *** exploreshaifali has quit IRC | 08:29 | |
| *** yingjun has joined #openstack-horizon | 08:43 | |
| *** liangbo has joined #openstack-horizon | 08:44 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 08:47 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 08:47 |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/214023 | 08:50 |
| *** shikel has quit IRC | 09:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:04 | |
| *** sh1kel has joined #openstack-horizon | 09:06 | |
| *** sayan has joined #openstack-horizon | 09:11 | |
| *** liangbo has quit IRC | 09:12 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding informative message when deleting a using volume type https://review.openstack.org/213709 | 09:18 |
| *** liangbo has joined #openstack-horizon | 09:18 | |
| *** tosky has joined #openstack-horizon | 09:20 | |
| *** gerchardon has joined #openstack-horizon | 09:23 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding informative message when deleting a using volume type https://review.openstack.org/213709 | 09:25 |
| *** ^Gal^ has quit IRC | 09:26 | |
| *** ^Gal^ has joined #openstack-horizon | 09:26 | |
| *** ^Gal^ has quit IRC | 09:28 | |
| *** ^Gal^ has joined #openstack-horizon | 09:28 | |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Support autoconfiguration for templates https://review.openstack.org/207399 | 09:30 |
| *** stevemar has joined #openstack-horizon | 09:31 | |
| *** yingjun has quit IRC | 09:31 | |
| *** stevemar has quit IRC | 09:35 | |
| *** neillc is now known as neillc_away | 09:42 | |
| *** jbell8 has quit IRC | 09:49 | |
| *** mohankumar has joined #openstack-horizon | 09:51 | |
| *** jbell8 has joined #openstack-horizon | 09:53 | |
| *** jrist has quit IRC | 09:54 | |
| *** romainh has quit IRC | 10:06 | |
| *** liangbo has quit IRC | 10:08 | |
| *** exploreshaifali has joined #openstack-horizon | 10:12 | |
| *** akrivoka has joined #openstack-horizon | 10:14 | |
| *** jprovazn has joined #openstack-horizon | 10:23 | |
| *** sayali has quit IRC | 10:24 | |
| *** sayali has joined #openstack-horizon | 10:25 | |
| openstackgerrit | Arata Notsu proposed openstack/horizon: Stop using naturalSort in hypervisors table https://review.openstack.org/214126 | 10:36 |
| openstackgerrit | Arata Notsu proposed openstack/horizon: Remove an unused method in admin/hypervisors view https://review.openstack.org/214127 | 10:36 |
| *** kiran-r has joined #openstack-horizon | 10:36 | |
| openstackgerrit | Arata Notsu proposed openstack/horizon: Stop using naturalSort in hypervisors table https://review.openstack.org/208154 | 10:39 |
| openstackgerrit | Arata Notsu proposed openstack/horizon: Remove an unused method in admin/hypervisors view https://review.openstack.org/214127 | 10:39 |
| *** exploreshaifali has quit IRC | 10:43 | |
| *** lyanchih has quit IRC | 10:44 | |
| openstackgerrit | Arata Notsu proposed openstack/horizon: Remove an unused method in admin/hypervisors view https://review.openstack.org/214127 | 10:44 |
| robcresswell | o/ | 10:46 |
| *** sh1kel has quit IRC | 10:48 | |
| *** _kiran_ has joined #openstack-horizon | 11:07 | |
| *** kiran-r has quit IRC | 11:11 | |
| *** _kiran_ has quit IRC | 11:12 | |
| *** exploreshaifali has joined #openstack-horizon | 11:13 | |
| *** yamamoto has quit IRC | 11:13 | |
| *** lyanchih has joined #openstack-horizon | 11:25 | |
| *** stevemar has joined #openstack-horizon | 11:32 | |
| *** jprovazn has quit IRC | 11:34 | |
| *** stevemar has quit IRC | 11:35 | |
| *** romainh has joined #openstack-horizon | 11:37 | |
| *** rward has quit IRC | 11:37 | |
| *** jprovazn has joined #openstack-horizon | 11:37 | |
| *** DuncanT has quit IRC | 11:38 | |
| *** jprovazn has quit IRC | 11:39 | |
| *** mohankumar has quit IRC | 11:39 | |
| *** ramishra has quit IRC | 11:40 | |
| *** yamamoto has joined #openstack-horizon | 11:47 | |
| *** yamamoto has quit IRC | 11:47 | |
| *** yamamoto has joined #openstack-horizon | 11:47 | |
| *** lyanchih has quit IRC | 11:48 | |
| *** yamamoto_ has joined #openstack-horizon | 11:48 | |
| *** yamamoto has quit IRC | 11:52 | |
| *** amotoki has quit IRC | 11:53 | |
| *** MaxV has quit IRC | 11:55 | |
| openstackgerrit | Lennart Regebro proposed openstack/tuskar-ui: Enhance plan validation https://review.openstack.org/196051 | 11:59 |
| *** petertr7_away is now known as petertr7 | 12:09 | |
| *** mohankumar has joined #openstack-horizon | 12:12 | |
| *** TravT_ has joined #openstack-horizon | 12:15 | |
| *** TravT has quit IRC | 12:16 | |
| *** ducttape_ has joined #openstack-horizon | 12:19 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 12:21 |
| *** jprovazn has joined #openstack-horizon | 12:25 | |
| *** lapalm has joined #openstack-horizon | 12:28 | |
| *** yamamoto_ has quit IRC | 12:29 | |
| *** zhenguo has joined #openstack-horizon | 12:29 | |
| *** ducttape_ has quit IRC | 12:37 | |
| *** ducttape_ has joined #openstack-horizon | 12:38 | |
| *** ducttape_ has quit IRC | 12:38 | |
| *** ZZelle-off has joined #openstack-horizon | 12:42 | |
| *** ctina has quit IRC | 12:43 | |
| *** ctina has joined #openstack-horizon | 12:44 | |
| *** yamamoto has joined #openstack-horizon | 12:45 | |
| *** yamamoto has joined #openstack-horizon | 12:46 | |
| *** exploreshaifali has quit IRC | 12:48 | |
| *** _crobertsrh is now known as crobertsrh | 12:49 | |
| *** yamamoto has quit IRC | 12:49 | |
| *** chlong has joined #openstack-horizon | 12:52 | |
| *** MaxV has joined #openstack-horizon | 12:52 | |
| openstackgerrit | Merged openstack/horizon: Add todo regarding code removal in M https://review.openstack.org/211892 | 12:52 |
| *** neelashah has joined #openstack-horizon | 12:55 | |
| *** lyanchih has joined #openstack-horizon | 12:56 | |
| *** MaxV has quit IRC | 12:57 | |
| openstackgerrit | Chad Roberts proposed openstack/horizon: Adding support for Manila-based shares in Sahara https://review.openstack.org/207086 | 12:59 |
| *** lyanchih has quit IRC | 13:01 | |
| *** pauloewerton has joined #openstack-horizon | 13:04 | |
| *** yamamoto has joined #openstack-horizon | 13:04 | |
| *** yamamoto has quit IRC | 13:08 | |
| *** yamamoto has joined #openstack-horizon | 13:12 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** exploreshaifali has joined #openstack-horizon | 13:16 | |
| *** hurgleburgler has joined #openstack-horizon | 13:22 | |
| *** julim has joined #openstack-horizon | 13:24 | |
| *** MaxV has joined #openstack-horizon | 13:24 | |
| *** masco has quit IRC | 13:28 | |
| *** lblanchard has joined #openstack-horizon | 13:31 | |
| *** yamamoto has joined #openstack-horizon | 13:31 | |
| *** mrunge has quit IRC | 13:33 | |
| *** jtriley has joined #openstack-horizon | 13:39 | |
| *** ducttape_ has joined #openstack-horizon | 13:40 | |
| *** neelashah has quit IRC | 13:42 | |
| *** mhorban has joined #openstack-horizon | 13:43 | |
| *** tvanderwiel has joined #openstack-horizon | 13:50 | |
| *** tvanderwiel has left #openstack-horizon | 13:53 | |
| *** jpomeroy has joined #openstack-horizon | 13:54 | |
| *** tyr has joined #openstack-horizon | 13:56 | |
| *** neelashah has joined #openstack-horizon | 13:56 | |
| *** mwhagedorn has joined #openstack-horizon | 13:57 | |
| *** bluex-pl has quit IRC | 13:57 | |
| *** tyr has quit IRC | 14:00 | |
| *** neelashah has quit IRC | 14:01 | |
| kfox1111 | the heat wizard with the app catalog no longer works with trunk. :/ | 14:01 |
| *** lapalm has quit IRC | 14:02 | |
| *** ramishra has joined #openstack-horizon | 14:02 | |
| *** DuncanT has joined #openstack-horizon | 14:03 | |
| *** lapalm has joined #openstack-horizon | 14:03 | |
| *** lapalm_ has joined #openstack-horizon | 14:05 | |
| *** Drago has joined #openstack-horizon | 14:07 | |
| robcresswell | :( | 14:07 |
| *** lapalm has quit IRC | 14:07 | |
| *** Drago has quit IRC | 14:08 | |
| *** Drago has joined #openstack-horizon | 14:09 | |
| robcresswell | kfox1111: Any idea when/ which patch broke it? | 14:14 |
| kfox1111 | not yet. trying to narrow it down. :/ | 14:14 |
| *** tyr has joined #openstack-horizon | 14:15 | |
| kfox1111 | the image create dialog's broken too. :/ | 14:17 |
| *** ZZelle-off has quit IRC | 14:18 | |
| *** peristeri has quit IRC | 14:20 | |
| *** mwhagedorn has quit IRC | 14:20 | |
| kfox1111 | and nova too... :( | 14:21 |
| *** tyr has quit IRC | 14:21 | |
| *** wmlynch has quit IRC | 14:23 | |
| *** wmlynch has joined #openstack-horizon | 14:24 | |
| robcresswell | Uh | 14:25 |
| robcresswell | *everything* is broken? | 14:26 |
| *** tosky has quit IRC | 14:26 | |
| kfox1111 | from the catalog plugin. :/ | 14:27 |
| kfox1111 | strange... | 14:27 |
| kfox1111 | like, I pop up the heat dilog, and get the title, but nothing inside it... | 14:27 |
| kfox1111 | no.... inside is: <form id="select_template" class="ng-scope ng-pristine ng-valid" enctype="multipart/form-data" method="POST" action="/project/stacks/select_template" autocomplete="" name="" ng-controller="DummyController"> | 14:29 |
| *** wmlynch has quit IRC | 14:29 | |
| kfox1111 | <div ng-switch="asset.service.type"> </div> | 14:29 |
| kfox1111 | </form> | 14:29 |
| kfox1111 | that looks very wrong... its like part of my code and part of horizon... | 14:29 |
| *** zul has joined #openstack-horizon | 14:29 | |
| *** lyanchih has joined #openstack-horizon | 14:30 | |
| kfox1111 | I wonder if something else changed in my code. I recently added a directive. maybe its causing some badness. | 14:30 |
| *** tosky has joined #openstack-horizon | 14:30 | |
| *** kiran-r has joined #openstack-horizon | 14:31 | |
| *** kiran-r has quit IRC | 14:31 | |
| *** kiran-r has joined #openstack-horizon | 14:31 | |
| *** stevemar has joined #openstack-horizon | 14:32 | |
| kfox1111 | Yup. that was it. The directiive I added somehow was breaking the other dialogs. | 14:32 |
| kfox1111 | sorry for the noise. :/ | 14:32 |
| *** kzaitsev_mb has quit IRC | 14:33 | |
| *** kiran-r has quit IRC | 14:33 | |
| *** MaxV has quit IRC | 14:33 | |
| *** kiran-r has joined #openstack-horizon | 14:33 | |
| *** rward has joined #openstack-horizon | 14:34 | |
| *** MaxV has joined #openstack-horizon | 14:36 | |
| *** mrunge has joined #openstack-horizon | 14:37 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Display admin users in project table and detail pages https://review.openstack.org/214220 | 14:37 |
| *** jrist has joined #openstack-horizon | 14:38 | |
| *** jrist has quit IRC | 14:38 | |
| *** jrist has joined #openstack-horizon | 14:38 | |
| *** stevemar has quit IRC | 14:39 | |
| *** stevemar has joined #openstack-horizon | 14:39 | |
| robcresswell | kfox1111: Ha, no problem. | 14:39 |
| *** exploreshaifali has quit IRC | 14:40 | |
| *** fnordahl has quit IRC | 14:42 | |
| *** vijendar has joined #openstack-horizon | 14:42 | |
| *** wmlynch has joined #openstack-horizon | 14:44 | |
| *** tjones has joined #openstack-horizon | 14:48 | |
| *** kzaitsev_mb has joined #openstack-horizon | 14:50 | |
| *** julim_ has joined #openstack-horizon | 14:51 | |
| *** aorourke_ has joined #openstack-horizon | 14:51 | |
| *** MaxV has quit IRC | 14:52 | |
| *** zul has quit IRC | 14:54 | |
| robcresswell | kfox1111: The app catalog extension is murano-dashboard, right? | 14:56 |
| *** wmlynch_ has joined #openstack-horizon | 14:56 | |
| *** m3m0 has joined #openstack-horizon | 14:58 | |
| *** stevemar has quit IRC | 14:59 | |
| *** julim has quit IRC | 14:59 | |
| *** Piet has quit IRC | 14:59 | |
| *** m3m0_ has quit IRC | 14:59 | |
| *** jtomasek has quit IRC | 14:59 | |
| *** early has quit IRC | 14:59 | |
| *** aorourke has quit IRC | 14:59 | |
| *** cody-somerville- has quit IRC | 14:59 | |
| *** wznoinsk has quit IRC | 14:59 | |
| *** jbell8 has quit IRC | 15:00 | |
| kfox1111 | robcresswell: no. its more generic then that. it can load stuff into murano, but it also can do glance and heat. We're also going to add solum language packs and other stuff that's "loadable" into openstack. | 15:03 |
| kfox1111 | there's some overlap between the two projects though, and thats confusing. we're going to have to figure that one out at some point. | 15:04 |
| *** julim has joined #openstack-horizon | 15:04 | |
| *** stevemar has joined #openstack-horizon | 15:05 | |
| *** early has joined #openstack-horizon | 15:06 | |
| *** julim_ has quit IRC | 15:06 | |
| *** SimonChung1 has quit IRC | 15:07 | |
| *** amotoki has joined #openstack-horizon | 15:08 | |
| *** doug-fish has joined #openstack-horizon | 15:08 | |
| *** zul has joined #openstack-horizon | 15:09 | |
| *** hurgleburgler has quit IRC | 15:11 | |
| *** jtomasek has joined #openstack-horizon | 15:12 | |
| *** cody-somerville- has joined #openstack-horizon | 15:12 | |
| *** wznoinsk has joined #openstack-horizon | 15:12 | |
| *** neelashah has joined #openstack-horizon | 15:12 | |
| *** tyr has joined #openstack-horizon | 15:13 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 15:15 |
| *** fnordahl has joined #openstack-horizon | 15:16 | |
| *** tyr has quit IRC | 15:19 | |
| *** mohankumar has quit IRC | 15:19 | |
| *** Piet has joined #openstack-horizon | 15:20 | |
| *** jbell8 has joined #openstack-horizon | 15:23 | |
| *** garthb has joined #openstack-horizon | 15:26 | |
| *** garthb_ has joined #openstack-horizon | 15:26 | |
| *** garthb has quit IRC | 15:27 | |
| *** _kiran_ has joined #openstack-horizon | 15:32 | |
| *** kiran-r has quit IRC | 15:33 | |
| *** bpokorny has joined #openstack-horizon | 15:33 | |
| *** vgridnev has quit IRC | 15:34 | |
| *** hhuang has quit IRC | 15:34 | |
| kfox1111 | Piet: sorry, I haven't had time to review yet. :( we've got an outage on Thursay and I've been spending time prepairing. :( | 15:35 |
| kfox1111 | I'll try and review as soon as I can. | 15:36 |
| *** hhuang has joined #openstack-horizon | 15:36 | |
| tsufiev | mrunge, hello, Matthias! By the way, I fixed most of integration tests here https://review.openstack.org/214238 (again!) | 15:36 |
| *** ramishra has quit IRC | 15:36 | |
| *** DuncanT has quit IRC | 15:36 | |
| *** rward has quit IRC | 15:36 | |
| tsufiev | the real issue to me seems that nobody believes in their results and tends to make them non-voting once the first failure occurs | 15:37 |
| *** btully has joined #openstack-horizon | 15:37 | |
| mrunge | tsufiev, I agree | 15:37 |
| tsufiev | and once they're non-voting, they are going to be ruined after 10-15 commits | 15:37 |
| mrunge | tsufiev, thank you for the effort! | 15:37 |
| mrunge | reminds me to propose django-1.8 to be turned to voting | 15:38 |
| *** mwhagedorn has joined #openstack-horizon | 15:38 | |
| mrunge | tsufiev, the issue is, any commit in openstack world can basically screw us | 15:38 |
| tsufiev | mrunge, np ). W/o these tests we are blind on whether package changes break our Horizon or don't break | 15:38 |
| mrunge | tsufiev, so we should have horizon integration tests in other projects integrated, too | 15:39 |
| mrunge | just to be sure, i.e keystoneclient api changes don't break everything ;-) | 15:39 |
| tsufiev | I see the integration tests on gate as an ultimate answer to the question: Will Horizon work after this particular change | 15:39 |
| tsufiev | so, I'll try to finalize this commit (right now 4 tests are still failing, but before that they all have been failing) asap | 15:40 |
| tosky | tsufiev: thanks for the fix | 15:40 |
| tsufiev | it would be worth discussing on the next meeting immediate re-enabling of these tests on gate | 15:41 |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few tweaks to make the App Catalog plugin work. https://review.openstack.org/206773 | 15:43 |
| *** mwhagedorn has quit IRC | 15:45 | |
| *** sayali has quit IRC | 15:45 | |
| *** zul has quit IRC | 15:46 | |
| *** geoffarnold has joined #openstack-horizon | 15:46 | |
| Piet | kfoz1111: now worries! | 15:48 |
| *** btully has quit IRC | 15:48 | |
| Piet | kfox1111: now worries! | 15:48 |
| *** _kiran_ has quit IRC | 15:50 | |
| *** geoffarnold has quit IRC | 15:50 | |
| kfox1111 | I'll try and get to it as soon as I can. :/ | 15:50 |
| *** geoffarnold has joined #openstack-horizon | 15:50 | |
| Piet | For everyone, we're kicking around the idea of adding a "Create and add another" button to the bottom of the modal. | 15:51 |
| *** KunalGandhi has joined #openstack-horizon | 15:51 | |
| robcresswell | Piet: +1 | 15:51 |
| robcresswell | Piet: As long as it doesnt make it too busy, its a good idea. | 15:51 |
| Piet | Should it be a dropdown from the "Add Button" or it's own button? My concern is that it's getting busy if you include cancel, back and next. | 15:52 |
| Piet | https://openstack.invisionapp.com/d/main/#/console/4168226/94870823/preview | 15:52 |
| robcresswell | kfox1111: Where does the code live for the app catalog? | 15:52 |
| *** sayan has quit IRC | 15:53 | |
| kfox1111 | its still quite raw, but: https://github.com/stackforge/apps-catalog-ui | 15:54 |
| robcresswell | kfox1111: Ta. Just adding a list of Horizon plugins to the docs | 15:54 |
| robcresswell | afaik there isnt one so far | 15:54 |
| kfox1111 | ah. cool. :) | 15:54 |
| *** wmlynch has quit IRC | 15:57 | |
| tsufiev | Piet, what's about creating in batches? | 15:57 |
| *** ccesario_ has quit IRC | 15:57 | |
| *** ccesario_ has joined #openstack-horizon | 16:00 | |
| *** lsmola has quit IRC | 16:00 | |
| *** kzaitsev_mb has quit IRC | 16:02 | |
| *** ZZelle has joined #openstack-horizon | 16:02 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add plugin registry to docs https://review.openstack.org/214253 | 16:02 |
| *** ZZelle is now known as ZZelle-off | 16:02 | |
| *** sayali has joined #openstack-horizon | 16:03 | |
| robcresswell | david-lyle: ^^ That patch might help with the plugin work a little | 16:03 |
| david-lyle | robcresswell: awesome, thanks | 16:04 |
| david-lyle | will verify the sphinx formatting in a minute | 16:04 |
| *** tjones has quit IRC | 16:04 | |
| robcresswell | david-lyle: Yeah, no rush, just thought I'd let you know. | 16:05 |
| david-lyle | robcresswell: partial critical bug fix https://review.openstack.org/#/c/214011/ | 16:05 |
| david-lyle | back at you :) | 16:05 |
| robcresswell | Yup, I saw this earlier, it's on my list :D | 16:05 |
| david-lyle | cool, thanks | 16:05 |
| robcresswell | Actually, I'll do it now. Got time. | 16:06 |
| david-lyle | still working on the horizon side, but halfway home | 16:06 |
| david-lyle | but we can fix that part separately | 16:06 |
| Piet | tsufiev: Same database, but more than one? | 16:07 |
| tsufiev | Piet, uh, I actually thought about instances | 16:09 |
| Piet | Good question, let me check | 16:10 |
| *** romainh has quit IRC | 16:12 | |
| *** ramishra has joined #openstack-horizon | 16:12 | |
| *** DuncanT has joined #openstack-horizon | 16:12 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: In Stack Details do not display as links events leading to nowhere https://review.openstack.org/208554 | 16:12 |
| *** tjones has joined #openstack-horizon | 16:14 | |
| tsufiev | Piet, btw, I left a verbose comment at Image Create mockups (although it's already in 'Done' state). Do the notifications work for mockups in 'done' state? | 16:15 |
| Piet | tsufiev: Just posted your question to invision and cc'd you | 16:15 |
| tsufiev | ok | 16:15 |
| david-lyle | robcresswell: looks good, one comment though | 16:15 |
| *** DWfuturetec has joined #openstack-horizon | 16:17 | |
| robcresswell | david-lyle: Derp. Good spot. | 16:17 |
| david-lyle | :) | 16:18 |
| *** exploreshaifali has joined #openstack-horizon | 16:18 | |
| Piet | tsufiev: Are you referring to the long file uploads? | 16:18 |
| tsufiev | Piet, yes | 16:18 |
| Piet | Do we currently have a pattern for "in progress" for modals? | 16:19 |
| Piet | Seems like we don't.... | 16:19 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Add plugin registry to docs https://review.openstack.org/214253 | 16:19 |
| *** jcoufal has quit IRC | 16:20 | |
| kfox1111 | say I'm in an angular-ui dialog, and I want to pop up the glance dialog via ajax-modal link. it doesn't work. whats the best way around that? | 16:20 |
| robcresswell | Hmm. I've put it under general info, but perhaps it should be under using horizon. I'll link to it elsewhere too. | 16:21 |
| Piet | tsufiev: Need to head to the ops meeting! Can we pick-up again later? | 16:21 |
| tsufiev | kfox1111, something like that https://review.openstack.org/#/c/154230/ ? | 16:21 |
| tsufiev | Piet, sure, np | 16:21 |
| david-lyle | robcresswell: let me look again | 16:21 |
| *** exploreshaifali has quit IRC | 16:22 | |
| kfox1111 | tsufiev: yeah, that may do the trick. :) | 16:22 |
| kfox1111 | thanks. | 16:22 |
| robcresswell | I wonder if perhaps it should be linked from the customising section too. | 16:22 |
| david-lyle | I'm not sure the last one seems right | 16:23 |
| tsufiev | kfox1111, good, if it would be needed more than just one murano-dashboard, it might be merged into horizon | 16:24 |
| *** Piet has quit IRC | 16:24 | |
| tsufiev | I knew that it would be eventually needed :) | 16:24 |
| tsufiev | kfox1111, please ping me, if you'll be able to put this into use | 16:25 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 16:26 |
| *** Samos123 has quit IRC | 16:27 | |
| *** geoffarnold has quit IRC | 16:27 | |
| kfox1111 | tsufiev: didn't work. :( | 16:27 |
| robcresswell | david-lyle: last one? | 16:28 |
| *** rward has joined #openstack-horizon | 16:28 | |
| david-lyle | customization | 16:28 |
| *** petertr7 is now known as petertr7_away | 16:28 | |
| david-lyle | maybe??? | 16:28 |
| david-lyle | I could be convinced I suppose | 16:28 |
| robcresswell | Heh, I'm not too worried as long as its somewhere accessible | 16:28 |
| robcresswell | Atm its just under the General Info part of the dev docs, in the Index. | 16:29 |
| *** tjones has quit IRC | 16:30 | |
| *** tyr has joined #openstack-horizon | 16:30 | |
| *** Samos123 has joined #openstack-horizon | 16:30 | |
| robcresswell | As long as people can google "horizon plugins" or glance at the index page and find it, that should be fine. | 16:30 |
| *** tjones has joined #openstack-horizon | 16:30 | |
| *** Piet has joined #openstack-horizon | 16:31 | |
| *** Piet has quit IRC | 16:31 | |
| *** Piet has joined #openstack-horizon | 16:31 | |
| *** exploreshaifali has joined #openstack-horizon | 16:31 | |
| *** doug-fish has quit IRC | 16:32 | |
| *** doug-fish has joined #openstack-horizon | 16:33 | |
| *** tyr has quit IRC | 16:35 | |
| *** Ephur has joined #openstack-horizon | 16:35 | |
| *** sayan has joined #openstack-horizon | 16:36 | |
| kfox1111 | so is there a good way to do a dialog in dialog? or should I try and dismiss the one dialog before poping up the next? | 16:37 |
| kfox1111 | unfortunatly that may have undesirable affects if the user cancels the nested stack. it should return to the first dialog. | 16:37 |
| *** Piet has quit IRC | 16:39 | |
| krotscheck | Did the npm run lint job get switched to voting in the gate? | 16:40 |
| krotscheck | (If so, that's both awesome and unfortunate for my patch ;) | 16:41 |
| david-lyle | krotscheck: yes, turned on last night | 16:44 |
| krotscheck | david-lyle: Woohoo! | 16:44 |
| david-lyle | horizon issues fixed | 16:44 |
| krotscheck | ALso, yikes. | 16:44 |
| krotscheck | dun dun duuuuuun | 16:44 |
| david-lyle | better fly right :) | 16:45 |
| krotscheck | Yep! And now upgrading a linting plugin actually requires _work_. Phaw | 16:45 |
| krotscheck | ;) | 16:45 |
| *** lyanchih has quit IRC | 16:46 | |
| *** doug-fish has quit IRC | 16:46 | |
| *** doug-fish has joined #openstack-horizon | 16:46 | |
| robcresswell | krotscheck: Yeah, I approved that before realising that job was voting now... woops | 16:49 |
| krotscheck | robcresswell: But that's good! This is why we jenkins baby [/bad 90's rap] | 16:49 |
| * krotscheck will not publicly admit to actually liking that song. | 16:50 | |
| robcresswell | I was a child for most of the 90s, I don't know whats going on | 16:51 |
| robcresswell | Well, all of the 90s | 16:51 |
| openstackgerrit | David Lyle proposed openstack/horizon: Fix docs translation import errors https://review.openstack.org/214277 | 16:55 |
| *** kzaitsev_mb has joined #openstack-horizon | 16:55 | |
| *** mwhagedorn has joined #openstack-horizon | 16:56 | |
| *** lapalm_ has quit IRC | 16:57 | |
| *** lapalm has joined #openstack-horizon | 16:58 | |
| openstackgerrit | David Lyle proposed openstack/horizon: STATIC_ROOT underline too short https://review.openstack.org/214278 | 17:01 |
| *** lapalm has quit IRC | 17:02 | |
| *** Piet has joined #openstack-horizon | 17:04 | |
| *** tosky has quit IRC | 17:04 | |
| *** zhenguo has quit IRC | 17:05 | |
| *** mpavlase has quit IRC | 17:06 | |
| *** markus_z has quit IRC | 17:07 | |
| *** mwhagedorn has quit IRC | 17:07 | |
| *** mpavlase has joined #openstack-horizon | 17:08 | |
| *** mpavlase has quit IRC | 17:08 | |
| openstackgerrit | Duk Loi proposed openstack/horizon: Support operations on a trove instance user https://review.openstack.org/187259 | 17:10 |
| *** kiran-r has joined #openstack-horizon | 17:11 | |
| *** kiran-r has quit IRC | 17:16 | |
| *** absubram has joined #openstack-horizon | 17:20 | |
| *** jingjing_ren has joined #openstack-horizon | 17:21 | |
| *** geoffarnold has joined #openstack-horizon | 17:22 | |
| rhagarty_ | robcresswell: what is the criteria for making it onto the official Horizon plug-in list? (re: https://review.openstack.org/#/c/214253) | 17:24 |
| david-lyle | rhagarty_: existence? | 17:25 |
| david-lyle | and open | 17:25 |
| *** yamamoto has quit IRC | 17:25 | |
| *** lhcheng has joined #openstack-horizon | 17:25 | |
| rhagarty_ | david-lyle: so would our HP specific plug-in fit? or is there another place we can list them? | 17:26 |
| david-lyle | if it's proprietary in that development is closed, no, but if the only HP specific thing it does is support HP hardware (or similar) I'm ok with listing it | 17:27 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 17:27 |
| david-lyle | if it's supporting proprietary software, I'm less inclined to have it listed | 17:27 |
| *** lhcheng has quit IRC | 17:27 | |
| *** jpomeroy has quit IRC | 17:28 | |
| ducttape_ | idea: have the list of plugins point to a location / listing.... and you could over-ride that. so vendor X could have a different list of plugins | 17:28 |
| rhagarty_ | it's all open source (our legal has approved it as such), but does only work with our backend hardware | 17:29 |
| david-lyle | hardware I'm less concerned about, HP for sale service only, no bueno | 17:29 |
| david-lyle | HP as a for instance | 17:29 |
| rhagarty_ | are you asking if we charge for the plug-in? | 17:30 |
| kfox1111 | fyi, the corisponding cinder plugin is already upstream... | 17:30 |
| david-lyle | ducttape_: so the deployer is going to update the plugin doc, for whom. If they updated it, the person who needs to add plugins already addressed the issue | 17:30 |
| david-lyle | I don't want to list plugins for things like my-company-proprietary-monitoring-service which is closed source and only available by purchase | 17:32 |
| david-lyle | vendor specific hardware support is fine | 17:32 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix doc reference to 'hz' instead of 'horizon' https://review.openstack.org/214289 | 17:32 |
| rhagarty_ | david-lyle: we pass that test | 17:33 |
| ducttape_ | yeah, I guess I see it as - the official listing is kinda helpful... but in distro-vendors case they want a different listing anyways | 17:33 |
| david-lyle | rhagarty_: I figured you did | 17:33 |
| david-lyle | with the cinder focus and all | 17:33 |
| ducttape_ | and we have found that the official vs non official plugins is a discovery process when talking w vendors | 17:33 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Fix doc reference 'hz' should be 'horizon' https://review.openstack.org/214289 | 17:34 |
| rhagarty_ | any thought to adding the list to a Horizon admin panel... just a list with links to github | 17:34 |
| david-lyle | ducttape_: ah, so you're saying someone like redhat and ubuntu would update the listing | 17:34 |
| david-lyle | ? | 17:34 |
| ducttape_ | right | 17:34 |
| david-lyle | that makes more sense | 17:34 |
| david-lyle | sweet talk robcresswell into doing it :) | 17:35 |
| ducttape_ | when hp sells hellion distro, they have there own hellion-rific plugins | 17:35 |
| david-lyle | sure | 17:35 |
| ducttape_ | and vanilla OS has the big tent type plugins | 17:35 |
| david-lyle | rhagarty_: I'm reluctant to add it there, because it goes don't a path I'm not excited about which is hot loading plugins | 17:36 |
| david-lyle | s/don't/down/ | 17:36 |
| *** jprovazn has quit IRC | 17:36 | |
| *** tqtran has joined #openstack-horizon | 17:37 | |
| robcresswell | My ears are burning | 17:37 |
| david-lyle | people saw your simple list and want complexity | 17:37 |
| ducttape_ | talking plugin listing, rob | 17:37 |
| david-lyle | :D | 17:37 |
| kfox1111 | hot adding plugins would be awesome. but I do understand if there's deps involved that that could be really painful. :/ | 17:37 |
| rhagarty_ | david-lyle: I hear you, but right now there is NO visibility to what plug-ins exist. Search github for "horizon.."? | 17:37 |
| *** rajatvig has joined #openstack-horizon | 17:37 | |
| david-lyle | rhagarty_: these docs are shipped with horizon | 17:37 |
| ducttape_ | kfox1111 - hot add would not be advised for static collection and compression etc | 17:37 |
| david-lyle | so we're adding the list | 17:38 |
| robcresswell | Ah, I see | 17:38 |
| rhagarty_ | docs are the last place users would look! | 17:38 |
| kfox1111 | ducttape_: still could be done... just harder. :) | 17:38 |
| david-lyle | it will also be published to docs.openstack.org/developer/horizon | 17:38 |
| robcresswell | rhagarty_: Docs are published online | 17:38 |
| david-lyle | it's not for users | 17:38 |
| ducttape_ | kfox1111 - it's a good idea, yes.... but I think first we need a working plugin mechanism with more mileage behind it | 17:38 |
| kfox1111 | ducttape_: +1. | 17:38 |
| david-lyle | if the deployer is not adding it, it existing in the wild makes little difference | 17:38 |
| robcresswell | Once Google figures it out, should likely be a top result for "Horizon plugins" or similar | 17:39 |
| kfox1111 | should be ok. the individual links should contain instructions for distro's versions. so, for example, the readme for the apps-catalog-ui could contain instructions for using rpm's for rdo. | 17:40 |
| robcresswell | As to what's added... I feel like its anything thats open right? It shouldn't end up as an advertisement for services. | 17:40 |
| david-lyle | right, open | 17:40 |
| david-lyle | #1 criteria | 17:40 |
| *** TravT has joined #openstack-horizon | 17:41 | |
| ducttape_ | I'd think anything listed in the default listing should be a big tent member | 17:41 |
| *** saksham has joined #openstack-horizon | 17:41 | |
| *** rajatvig has quit IRC | 17:41 | |
| ducttape_ | if distro vendor - x wants more things added, make your own listing | 17:41 |
| *** haypo has joined #openstack-horizon | 17:41 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix integration tests https://review.openstack.org/214238 | 17:42 |
| david-lyle | ducttape_: there are things in stackforge that are legitimate additions | 17:42 |
| haypo | hi. can somone please review https://review.openstack.org/#/c/201098/? a short patch to fix an issue related to Python 3, but it also makes the code simpler | 17:42 |
| david-lyle | although that's being retired | 17:42 |
| *** ybathia has joined #openstack-horizon | 17:42 | |
| haypo | "Fix code that modified dictionaries while iterating over them" | 17:42 |
| kfox1111 | david-lyle: yeah, very soon there will be no more stackforge. its all big tent now. | 17:42 |
| ducttape_ | right, like monasca is going big tent | 17:42 |
| *** TravT_ has quit IRC | 17:43 | |
| kfox1111 | the apps-catalog too. | 17:43 |
| david-lyle | yup, we're going to need a bigger tent | 17:43 |
| * kfox1111 chuckles | 17:43 | |
| david-lyle | ducttape_: does monasca have a non-vertica story yet | 17:44 |
| robcresswell | Yeah. I see no harm in linking the stackforge repos for now though, its still open code. If there's something missing from the list that you think should be on there, just comment | 17:44 |
| david-lyle | that's not just a comedy? | 17:44 |
| *** geoffarnold has quit IRC | 17:45 | |
| david-lyle | I suppose either way, it's probably still big tent fodder | 17:46 |
| ducttape_ | david-lyle - yes, a story exists. It's part fairy tale, but it is a story | 17:46 |
| *** shivrao has joined #openstack-horizon | 17:47 | |
| *** geoffarnold has joined #openstack-horizon | 17:47 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Fix code that modified dictionaries while iterating over them https://review.openstack.org/201098 | 17:47 |
| ducttape_ | haypo - for that patch, if you had instructions on how the tests fail with python 3 (and how your patch fixes that)... I'd be ears for that change | 17:49 |
| *** sayan has quit IRC | 17:49 | |
| haypo | ducttape_: just run "tox -e py34" and see tests failing | 17:50 |
| robcresswell | ducttape_: tox -epy34 should just fail outright | 17:50 |
| *** petertr7_away is now known as petertr7 | 17:50 | |
| *** DWfuturetec has quit IRC | 17:50 | |
| ducttape_ | ok. and your patch resolves that then. thanks | 17:50 |
| haypo | ducttape_: my patch solves one py3 bug, other py3 already have been merged | 17:50 |
| rhagarty_ | david-lyle: any action items from this discussion on plug-in "exposure"? | 17:51 |
| ducttape_ | ok. adding those instructions would help other reviewers | 17:51 |
| *** rajatvig has joined #openstack-horizon | 17:51 | |
| *** rajatvig has quit IRC | 17:52 | |
| haypo | ducttape_: there is a blueprint, https://blueprints.launchpad.net/horizon/+spec/porting-python3 | 17:52 |
| haypo | ducttape_: should i modify it to mention "tox -e py34"? | 17:53 |
| ducttape_ | It would have helped me. I -1 b/c changing the base table class with no tests is automatic red flag for me | 17:53 |
| ducttape_ | but knowing how to test this change and see the difference, now is better | 17:54 |
| haypo | ducttape_: see my comment on the review, no new test is required | 17:54 |
| haypo | ducttape_: hopefully, the modified is already _well_ tested | 17:54 |
| ducttape_ | I understand, yep | 17:54 |
| *** garthb_ has quit IRC | 17:55 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Port last test to Python 3 https://review.openstack.org/214291 | 17:57 |
| haypo | heeeere you have ^^ with this second patch (based on the first one), tox -e py34 now pass! | 17:57 |
| robcresswell | :o | 17:57 |
| *** tyr has joined #openstack-horizon | 17:58 | |
| haypo | ducttape_: i'm writing a patch to add a non-voting py34 check job to horizon | 17:58 |
| ducttape_ | that would be nice, it would help show this. right now I'm getting all the p3 libs installed to test your change. have the cloud do this for me ;) | 17:59 |
| *** jingjing_ren has quit IRC | 18:00 | |
| david-lyle | rhagarty_: follow on patch to robcresswell's patch | 18:00 |
| haypo | ducttape_: what do you mean? tox installs all dependencies for me in .tox/py34 venv | 18:00 |
| robcresswell | david-lyle, rhagarty_ ? | 18:01 |
| robcresswell | Did I miss something? | 18:01 |
| david-lyle | action for rhagarty_ not robcresswell | 18:01 |
| ducttape_ | there is some cryptography library that goes out and tries to compile stuff, needing python.h file. | 18:01 |
| *** jpomeroy has joined #openstack-horizon | 18:02 | |
| * robcresswell safely evades work | 18:02 | |
| ducttape_ | maybe I should have already had that thing installed, but I needed it to test your stuff haypo | 18:02 |
| rhagarty_ | david-lyle: not sure what the action is... sorry for confusion. | 18:02 |
| *** tyr has quit IRC | 18:03 | |
| david-lyle | rhagarty_: if you want it in the list, propose a follow on patch to robcresswell's patch creating the list | 18:03 |
| rhagarty_ | david-lyle: I heard a lot of suggestions for possible future steps... nothing concrete | 18:03 |
| rhagarty_ | david-lyle: oh, ok | 18:04 |
| *** jwy has joined #openstack-horizon | 18:06 | |
| *** chlong has quit IRC | 18:06 | |
| *** amotoki has quit IRC | 18:07 | |
| robcresswell | Folks, we have another Horizon Drivers meeting for blueprint review tomorrow. Are there any angular blueprints that need looking at? | 18:08 |
| *** gyee has joined #openstack-horizon | 18:08 | |
| haypo | i just wrote https://review.openstack.org/214292 : Add a non-voting py34 check job to Horizon | 18:09 |
| *** chlong has joined #openstack-horizon | 18:09 | |
| tqtran | hey robcresswell, just added a few: https://blueprints.launchpad.net/horizon/+spec/babel-translate-inner-tags | 18:10 |
| tqtran | https://blueprints.launchpad.net/horizon/+spec/transfer-table-clone-feature | 18:10 |
| tqtran | both are already done | 18:10 |
| tqtran | just waiting for reviews | 18:10 |
| robcresswell | Cool, added both bps to list. | 18:11 |
| haypo | ducttape_: are you now able to see python3 failures? | 18:11 |
| tqtran | thanks :) | 18:11 |
| robcresswell | https://wiki.openstack.org/wiki/Meetings/HorizonDrivers#Agenda_for_August_19_2000_UTC | 18:11 |
| *** openstackgerrit_ has quit IRC | 18:11 | |
| ducttape_ | haypo - with your change I see less failures, yes | 18:11 |
| tqtran | i think you can remove the jscs one, linting is now a voting job | 18:11 |
| ducttape_ | when you ask me "do I see failures" - you are going to need to be pretty specific. :P | 18:12 |
| robcresswell | tqtran: Yeah, probably right | 18:13 |
| robcresswell | david-lyle: What was the level of review on the bps again? Just prioritisation? | 18:14 |
| *** jingjing_ren has joined #openstack-horizon | 18:15 | |
| *** geoffarnold has quit IRC | 18:17 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 18:17 |
| *** lapalm has joined #openstack-horizon | 18:17 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 18:18 |
| *** geoffarnold has joined #openstack-horizon | 18:18 | |
| haypo | robcresswell: i replied to your comment on the project-config review | 18:18 |
| haypo | robcresswell: i see why you want to add the dependency to my horizon change | 18:18 |
| *** btully has joined #openstack-horizon | 18:18 | |
| haypo | robcresswell: depends-on has some issues when used on different project | 18:19 |
| haypo | for example, if the project-config is approved but depneds on a horizon change, it will not automatically be merged when the horizon change is approved and merged | 18:19 |
| robcresswell | haypo: Really? I thought that was the purpose of Depends-On. It's a nitpick I suppose, it just seems that if the patches are already there, you may as well let them merge for throwing another FAIL across everyones test results | 18:20 |
| haypo | the project-config change* | 18:20 |
| robcresswell | merge before* | 18:20 |
| haypo | robcresswell: i want to add a non-voting check job, it will not make tests to fail | 18:20 |
| haypo | since it's non-voting | 18:20 |
| haypo | tests: i mean the "jenkins" user on gerrit | 18:21 |
| *** sambetts has quit IRC | 18:21 | |
| robcresswell | No, I know it won't make them fail | 18:21 |
| haypo | for example, swift has a non-voting py34 job whereas tox -e py34 still fails badly on swift | 18:21 |
| robcresswell | I was just saying that, since you already have the fixes, it seems sensible to wait for the fixes to merge before throwing more failures into the mix. | 18:21 |
| robcresswell | Its not like it would affect the change to a voting job | 18:22 |
| haypo | robcresswell: i don't like adding useless dependencies, it just slowndown my work :) | 18:22 |
| haypo | robcresswell: maybe you can approved my horizon changes, so the question on dependency goes away :-D | 18:22 |
| *** btully has quit IRC | 18:23 | |
| haypo | robcresswell: my point is that adding a check job will show that py34 now pass with my latest horizon patch | 18:23 |
| *** sambetts has joined #openstack-horizon | 18:23 | |
| haypo | robcresswell: so reviewers probably trust more jenkins than me, no? | 18:23 |
| robcresswell | Makes sense | 18:24 |
| *** Piet has quit IRC | 18:24 | |
| robcresswell | Approve it you trolls! https://review.openstack.org/#/c/214253/ :p | 18:24 |
| *** yamamoto has joined #openstack-horizon | 18:26 | |
| david-lyle | robcresswell: you had me at trolls | 18:26 |
| robcresswell | haha | 18:27 |
| *** geoffarnold has quit IRC | 18:28 | |
| robcresswell | david-lyle: Not sure if you saw, but I've put up a list for the drivers meeting, should give us something to work with. Aiming to get another 15 - 20 looked through. | 18:28 |
| robcresswell | If we maintain that rate we should get on top of the sorting fairly quickly. | 18:28 |
| *** ducttape_ has quit IRC | 18:29 | |
| david-lyle | that would be awesome. I think greater attendance may mean lower rate :) | 18:30 |
| david-lyle | which is fine | 18:30 |
| *** yamamoto has quit IRC | 18:30 | |
| *** tyr has joined #openstack-horizon | 18:31 | |
| *** gyee has quit IRC | 18:31 | |
| robcresswell | That's true. We'll see how we get on. | 18:31 |
| *** gyee has joined #openstack-horizon | 18:32 | |
| haypo | ddd | 18:39 |
| haypo | é | 18:39 |
| *** geoffarnold has joined #openstack-horizon | 18:40 | |
| *** ducttape_ has joined #openstack-horizon | 18:47 | |
| *** Sukhdev has joined #openstack-horizon | 18:52 | |
| *** ducttape_ has quit IRC | 18:54 | |
| *** ducttape_ has joined #openstack-horizon | 18:55 | |
| *** geoffarnold has quit IRC | 18:56 | |
| *** jingjing_ren has quit IRC | 18:57 | |
| *** tjones has quit IRC | 19:00 | |
| *** gyee has quit IRC | 19:00 | |
| *** SimonChung has joined #openstack-horizon | 19:01 | |
| *** Piet has joined #openstack-horizon | 19:01 | |
| *** ybathia has quit IRC | 19:02 | |
| *** Piet has quit IRC | 19:02 | |
| *** ybathia has joined #openstack-horizon | 19:03 | |
| *** DWfuturetec has joined #openstack-horizon | 19:04 | |
| *** lapalm has quit IRC | 19:06 | |
| *** lapalm has joined #openstack-horizon | 19:07 | |
| *** e0ne has joined #openstack-horizon | 19:07 | |
| *** SimonChung has quit IRC | 19:08 | |
| *** amotoki has joined #openstack-horizon | 19:08 | |
| *** hurgleburgler has joined #openstack-horizon | 19:10 | |
| *** kiran-r has joined #openstack-horizon | 19:10 | |
| *** _kiran_ has joined #openstack-horizon | 19:11 | |
| *** lapalm has quit IRC | 19:11 | |
| *** tyr has quit IRC | 19:12 | |
| *** btully has joined #openstack-horizon | 19:13 | |
| *** amotoki has quit IRC | 19:13 | |
| openstackgerrit | Justin Pomeroy proposed openstack/horizon: WIP Support angular workflow extension as a feature plugin https://review.openstack.org/214306 | 19:13 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Inconsistent karma conf for xstatic files https://review.openstack.org/213846 | 19:13 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Cleaning up the Transfer Table https://review.openstack.org/208867 | 19:13 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Adding clone feature to Transfer Table https://review.openstack.org/211345 | 19:13 |
| *** kiran-r has quit IRC | 19:13 | |
| kfox1111 | in the expandable table, is there a way to know which entry's expanded in angular? | 19:14 |
| *** btully has quit IRC | 19:18 | |
| *** hurgleburgler has quit IRC | 19:26 | |
| *** doug-fish has quit IRC | 19:26 | |
| *** doug-fish has joined #openstack-horizon | 19:27 | |
| *** geoffarnold has joined #openstack-horizon | 19:30 | |
| *** vgridnev has joined #openstack-horizon | 19:34 | |
| *** belmoreira has joined #openstack-horizon | 19:36 | |
| *** geoffarnold has quit IRC | 19:38 | |
| *** geoffarnold has joined #openstack-horizon | 19:38 | |
| *** jingjing_ren has joined #openstack-horizon | 19:39 | |
| *** e0ne has quit IRC | 19:44 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixing .rst file issues https://review.openstack.org/214318 | 19:47 |
| dloi | ll | 19:48 |
| *** DWfuturetec has quit IRC | 19:48 | |
| *** mwhagedorn has joined #openstack-horizon | 19:50 | |
| *** belmoreira has quit IRC | 19:51 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Added volume type description for volume type https://review.openstack.org/133872 | 19:51 |
| *** mrunge has quit IRC | 19:58 | |
| *** jingjing_ren has quit IRC | 19:59 | |
| *** bpokorny_ has joined #openstack-horizon | 20:00 | |
| *** bpokorny has quit IRC | 20:00 | |
| *** bpokorny_ has quit IRC | 20:00 | |
| *** bpokorny has joined #openstack-horizon | 20:01 | |
| *** jingjing_ren has joined #openstack-horizon | 20:01 | |
| *** lapalm has joined #openstack-horizon | 20:01 | |
| *** neelashah has quit IRC | 20:01 | |
| *** mwhagedorn has quit IRC | 20:02 | |
| *** neelashah has joined #openstack-horizon | 20:02 | |
| *** linkedinyou has quit IRC | 20:02 | |
| *** lapalm_ has joined #openstack-horizon | 20:03 | |
| *** lapalm has quit IRC | 20:06 | |
| *** petertr7 is now known as petertr7_away | 20:09 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Address deprecated templatetags in Django 1.7 https://review.openstack.org/173921 | 20:10 |
| *** SimonChung has joined #openstack-horizon | 20:12 | |
| *** SimonChung1 has joined #openstack-horizon | 20:14 | |
| krotscheck | robcresswell: I'm trying to fix these linting errors, most of them seem to be related to really long comment lines of the pattern |-----------------------| - what are those used for? | 20:14 |
| *** mwhagedorn has joined #openstack-horizon | 20:14 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fix docs translation import errors https://review.openstack.org/214277 | 20:15 |
| krotscheck | It looks like a recent version of eslint added comments as a valid target for max-len | 20:15 |
| openstackgerrit | David Lyle proposed openstack/horizon: STATIC_ROOT underline too short https://review.openstack.org/214278 | 20:15 |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixing .rst file issues https://review.openstack.org/214318 | 20:15 |
| *** tyr has joined #openstack-horizon | 20:15 | |
| krotscheck | robcresswell: The alternative is to add ignoreComments. | 20:16 |
| *** kzaitsev_mb has quit IRC | 20:16 | |
| krotscheck | Actually, I should take this to the javascript channel..... | 20:17 |
| *** SimonChung has quit IRC | 20:17 | |
| robcresswell | krotscheck: Got an example? | 20:18 |
| krotscheck | robcresswell: http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/static/app/core/workflow/workflow.module.js#n29 | 20:19 |
| *** btully has joined #openstack-horizon | 20:19 | |
| krotscheck | robcresswell: Also, #openstack-javascript | 20:19 |
| kfox1111 | need a solution for nested dialogs... :( | 20:22 |
| robcresswell | TravT: ping | 20:24 |
| TravT | hey robcresswell | 20:24 |
| robcresswell | yo | 20:24 |
| robcresswell | Any idea how to handle the max line length with things like this? http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/static/app/core/workflow/workflow.module.js#n29 | 20:25 |
| robcresswell | I would imagine the "-------" can be removed and we can just wrap the @link | 20:25 |
| TravT | I wonder if we really need that whole section | 20:26 |
| *** jingjing_ren has quit IRC | 20:26 | |
| *** jingjing_ren has joined #openstack-horizon | 20:27 | |
| tqtran | TravT, robcresswell, krotscheck: I think we should just remove that section | 20:27 |
| *** akrivoka has quit IRC | 20:27 | |
| robcresswell | woop | 20:27 |
| tqtran | we're not really generating docs out of them atm, so having links there is actually useless | 20:27 |
| TravT | without @link, it is useless | 20:27 |
| krotscheck | Well, tell ya what: I'll remove it, add sean as a reviewer, and we'll see what he thinks :) | 20:28 |
| TravT | looks like maintenance overhead to me at the moment. | 20:28 |
| *** zul has joined #openstack-horizon | 20:28 | |
| robcresswell | I don't really know much about the ngdoc syntax. I would assume the @link section could just be wrapped to keep the line count down? | 20:28 |
| robcresswell | Thats all the issue is, right? | 20:29 |
| tqtran | the way i see it is as follows. we are using ndoc to document code, but we are not generating docs out of them. so having the links there is extra overhead that is completely useless atm | 20:29 |
| *** geoffarnold has quit IRC | 20:30 | |
| tqtran | so unless we are generating docs, i would rather not have them atm | 20:30 |
| TravT | i'm fine with getting rid of until / if we generate docs. OR get rid of the table formatting and leave @link by itself | 20:30 |
| *** geoffarnold has joined #openstack-horizon | 20:30 | |
| robcresswell | I think it makes more sense to just drop the formatting so the line lengths fit, otherwise we're just delteting and readding information | 20:30 |
| *** tjones has joined #openstack-horizon | 20:30 | |
| robcresswell | deleting* re-adding* | 20:30 |
| tqtran | we can always add them if we ever decide to generate docs out of them at some point (which i think is a much bigger debate) | 20:30 |
| robcresswell | true | 20:31 |
| TravT | i generated the docs a few times early on just to try it out, but haven't recently. | 20:31 |
| *** Piet has joined #openstack-horizon | 20:31 | |
| TravT | they haven't been consistently added. | 20:31 |
| robcresswell | IMO: we should generate docs from them at some point, so may as well keep the content unless its a huge inconvenience. Just alter formatting so it doesnt break eslint rules. | 20:32 |
| robcresswell | But if its holding up the patch, then we can sort it later. | 20:32 |
| *** SimonChung1 has quit IRC | 20:33 | |
| TravT | I'd go with just keeping @link... | 20:33 |
| krotscheck | If it adds to the conversation at all, generating docs is fairly high on my "JS-in-openstack" todo list. | 20:33 |
| tqtran | the thing is, we have really long names for our modules | 20:33 |
| krotscheck | Because that also needs to be consistent. | 20:33 |
| tqtran | so even if we remvoe the table format, we could still potentially run into max-len issues | 20:33 |
| TravT | krotscheck, that'd be nice | 20:33 |
| *** SimonChung has joined #openstack-horizon | 20:33 | |
| TravT | does adding the @link below even add any value? | 20:34 |
| TravT | or do the generated docs already link to the module content? | 20:34 |
| krotscheck | TravT: Well, with 6 (I think) and growing projects on the javascript train, getting the tooling solid and consistent is going to make everyone's life happier. | 20:34 |
| TravT | i mean, that's just a link to something in the module. | 20:34 |
| krotscheck | Also, in case anyone has an opinion on what the openstack equivalent of the angular $ prefix should be... I'm personally leaning towards o$ (OpenStack) | 20:35 |
| robcresswell | with the $? | 20:35 |
| TravT | tqtran: ^ that would apply to the transfer table patch you have going | 20:35 |
| robcresswell | Oh wait | 20:35 |
| TravT | os$ | 20:35 |
| tqtran | what about just os? | 20:36 |
| krotscheck | robcresswell: $provider. $http, $resource, etc. | 20:36 |
| tqtran | o$ look a bit strange.... | 20:36 |
| robcresswell | krotscheck: Yeah, sorry, I was thinking about directive prefixes. ng- etc | 20:36 |
| TravT | wait a minute, are you saying all services would be named with o$ prefix? | 20:37 |
| *** Piet has quit IRC | 20:37 | |
| krotscheck | TravT: Eeeehhhh not really. | 20:37 |
| robcresswell | Which is something I meant to ask. atm translate is clean; while ugly, should it not be hz-translate? | 20:37 |
| krotscheck | TravT: I'm thinking more like this library could replace the $$ that I originally used once we publish it: http://git.openstack.org/cgit/openstack/ironic-webclient/tree/app/js/modules/openstack/storage.js | 20:38 |
| tqtran | it can't be robcresswell, we are using angular-gettext for that | 20:38 |
| tqtran | so we are stuck with the syntax that they use | 20:38 |
| robcresswell | ahh | 20:38 |
| robcresswell | My bad, I assumed we'd named it ourselves | 20:38 |
| TravT | $$ is also used by angular, i believ | 20:38 |
| tqtran | yeah for $$ inner scopes | 20:39 |
| krotscheck | It'd be a use case for "Library names that could possibly conflict with an applications names so we're using a prefix as a pseudo namespace" | 20:39 |
| TravT | we've been using longer service names | 20:40 |
| TravT | fully qualifying them to match the longer module name | 20:40 |
| TravT | e.g. https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/cinder.service.js#L21 | 20:41 |
| krotscheck | On a completely unrelated note, I REALLY want to grab all the service mocks that horizon has and push those into their own libraries. | 20:42 |
| *** lhcheng has joined #openstack-horizon | 20:42 | |
| robcresswell | I'm gonna run away before I get too involved. It's 9.40 and I haven't had dinner yet :) | 20:42 |
| robcresswell | see you tomorrow folks | 20:42 |
| TravT | see you tomorrow robcresswell | 20:42 |
| robcresswell | oh and remember the Horizon Drivers meeting if you're about! | 20:42 |
| krotscheck | TravT: Hrm. That's... very verbose. | 20:43 |
| robcresswell | https://wiki.openstack.org/wiki/Meetings/HorizonDrivers :) | 20:43 |
| *** rdopiera has joined #openstack-horizon | 20:43 | |
| krotscheck | A very... python way of trying to solve that problem. | 20:43 |
| *** gyee has joined #openstack-horizon | 20:43 | |
| TravT | well, its not going to change at this point. | 20:43 |
| TravT | it matches what you see in the dir structure of the javascript console | 20:44 |
| TravT | angular modules give you no actual namespace protection | 20:44 |
| TravT | by themselves | 20:44 |
| krotscheck | I'm not yet decided on whether that's a good idea or not. | 20:44 |
| krotscheck | I mean: Yeah, I see the problem, and I see the solution y'all are using, and that TOTALLY works. | 20:45 |
| krotscheck | My brain is sifting through counterexamples where that might be a problem. | 20:45 |
| *** lblanchard has quit IRC | 20:45 | |
| krotscheck | And is sorting them on whether I care enough. | 20:45 |
| TravT | i dunno. | 20:45 |
| TravT | the external library you are talking about sounds like an interesting discussion | 20:46 |
| TravT | could be rather useful | 20:46 |
| krotscheck | Oslo for javascript. | 20:46 |
| krotscheck | The thing about the javascript world is that the dependencies are super atomic, so for example the session lib I linked earlier would be its own package. | 20:47 |
| david-lyle | holy cow! /dashboard as horizon root in devstack just merged | 20:47 |
| david-lyle | \o/ | 20:47 |
| david-lyle | break me now fools | 20:47 |
| david-lyle | :P | 20:47 |
| david-lyle | by fools I mean, distinguish associates, or course | 20:47 |
| krotscheck | Waitwaitwait. Does that mean that the old stuff can go byebye? | 20:48 |
| TravT | david-lyle: oh good, was just debating whether or not to restack. | 20:48 |
| TravT | but there is a devstack plugin for searchlight I'm also hoping merges today as well... | 20:48 |
| rdopiera | david-lyle: what was it before? horizon? | 20:48 |
| TravT | still holding out hope | 20:48 |
| david-lyle | means the :80 port domination is devstack no longer exists | 20:48 |
| david-lyle | rdopiera: just / | 20:48 |
| rdopiera | aah | 20:48 |
| *** ctina has quit IRC | 20:49 | |
| david-lyle | rdopiera: been trying to get this to land for months and horizon changes kept breaking it | 20:49 |
| rdopiera | david-lyle: I know that feeling :) | 20:50 |
| david-lyle | rdopiera: I know you do | 20:51 |
| rdopiera | david-lyle: it's not that bad on my side, actually | 20:51 |
| *** Sukhdev has quit IRC | 20:52 | |
| rdopiera | david-lyle: congrats on getting it done, anyways | 20:52 |
| *** hurgleburgler has joined #openstack-horizon | 20:52 | |
| tqtran | do the happy dance david-lyle | 20:52 |
| david-lyle | rdopiera: I'm still interested in moving the config file changes in, but I think we've gone to far in Liberty to move now, plus I'd like a migration story | 20:52 |
| rdopiera | david-lyle: yeah. I also think the settings changed too much | 20:53 |
| rdopiera | david-lyle: especially the web root stuff | 20:53 |
| *** _kiran_ has quit IRC | 20:53 | |
| rdopiera | david-lyle: more logic inside settings.py :( | 20:53 |
| david-lyle | rdopiera: yeah, not a fan of that | 20:53 |
| *** lhcheng_ has joined #openstack-horizon | 20:55 | |
| rdopiera | I wonder if instead of doing one mega-patch like that, I should first move the logic out of settings.py into utility functions | 20:56 |
| *** lhcheng has quit IRC | 20:57 | |
| ducttape_ | +1 rdopiera having a bunch of stuff in settings, that is both logic and required to get something to work... seems like it is not really a "setting" | 20:58 |
| rdopiera | plus it's not covered by unit tests | 20:59 |
| rdopiera | or tested in any way | 21:00 |
| ducttape_ | well, let's not get ahead of ourselves writing unit tests and all ;) | 21:00 |
| *** julim has quit IRC | 21:00 | |
| rdopiera | since tests have their own settings.py | 21:00 |
| *** zul has quit IRC | 21:00 | |
| *** vgridnev has quit IRC | 21:00 | |
| *** vijendar has quit IRC | 21:01 | |
| *** vijendar has joined #openstack-horizon | 21:01 | |
| *** ongk has joined #openstack-horizon | 21:01 | |
| *** ongk has quit IRC | 21:01 | |
| *** Piet has joined #openstack-horizon | 21:03 | |
| kfox1111 | is nested modal's something that horizon's willing to fix, or should I abandon modal for my modal so horizon's modals will work? | 21:03 |
| david-lyle | kfox1111: nested angular modals should work | 21:04 |
| rdopiera | kfox1111: we have to go deeper ;) | 21:04 |
| david-lyle | heck, nest django should work, but the stack for those is a mess | 21:04 |
| david-lyle | *nested | 21:04 |
| rdopiera | but nested modals are generally speaking a bad practice from ui point of view, so should be avoided if possible | 21:05 |
| david-lyle | in fact I though nest angular ones did work | 21:05 |
| *** stevemar has quit IRC | 21:05 | |
| rdopiera | of course that's not always possible | 21:05 |
| *** neelashah has quit IRC | 21:05 | |
| *** jbell8 has quit IRC | 21:06 | |
| *** jbell8_ has joined #openstack-horizon | 21:06 | |
| kfox1111 | david-lyle: doesn't seem to. :( | 21:07 |
| kfox1111 | the workflow is, select app from the icon grid, it pops up a dialog box with details. | 21:08 |
| *** lapalm_ has quit IRC | 21:08 | |
| kfox1111 | there's an "Install" or "Launch" icon there. | 21:08 |
| tqtran | kfox1111: https://openstack.invisionapp.com/d/main/#/console/4168226/94870823/preview | 21:08 |
| kfox1111 | if you click on that, it should take you to the horizon wizard that's appropriate. | 21:08 |
| tqtran | heres an example of a "slide out | 21:08 |
| *** lapalm has joined #openstack-horizon | 21:09 | |
| kfox1111 | tqtran: having a look... | 21:09 |
| tqtran | maybe instead of nesting it, you can have a "slide out" where you can modify stuff while you're inside of a modal dialog | 21:09 |
| ducttape_ | nested modals is used for assign FIP, and the user does not have any FIPs allocated | 21:09 |
| david-lyle | create keypair works on the new launch instances wizard, unless broken recently | 21:09 |
| *** amotoki has joined #openstack-horizon | 21:10 | |
| *** crobertsrh is now known as _crobertsrh | 21:11 | |
| kfox1111 | but I don't control horizon's modals. | 21:11 |
| kfox1111 | so I can't nest them. I can only poke them to have them pop up. | 21:11 |
| david-lyle | kfox1111: ?? | 21:12 |
| ducttape_ | you want a modal contained within another one... not just place a new modal on top | 21:12 |
| krotscheck | New Eslint rule activation for your consideration: https://review.openstack.org/214351 | 21:12 |
| ducttape_ | that would be a different flow / user experience | 21:12 |
| kfox1111 | no, I want to just have it pop up on top. but it doesn't seem to do that. | 21:12 |
| ducttape_ | not even for key imports during launch.... or assign a fip ? | 21:13 |
| krotscheck | Without it, linting will fail on horizon/static/framework/widgets/metadata/tree/tree.service.js with the new version of eslint | 21:13 |
| kfox1111 | let me make a quick video showing the issue... | 21:14 |
| ducttape_ | I think the middle popup is hidden for a second, I think I get what you are saying | 21:15 |
| *** amotoki has quit IRC | 21:15 | |
| *** jtriley has quit IRC | 21:16 | |
| *** stevemar has joined #openstack-horizon | 21:16 | |
| kfox1111 | https://youtu.be/7cOVCCjYjJs | 21:18 |
| kfox1111 | the install button shares code in both views. | 21:19 |
| kfox1111 | it works when the button isn't in a modal. | 21:19 |
| kfox1111 | it breaks strangely when its in a modal poping up the horizon modal. | 21:19 |
| *** hurgleburgler has quit IRC | 21:20 | |
| david-lyle | better hit up an angularoon here in the room | 21:21 |
| david-lyle | angularaut? | 21:21 |
| *** zul has joined #openstack-horizon | 21:22 | |
| tqtran | looking at your video | 21:22 |
| *** doug-fish has quit IRC | 21:22 | |
| *** doug-fish has joined #openstack-horizon | 21:22 | |
| tqtran | kfox1111: so your first modal dialog is actually legacy modal correct? | 21:23 |
| kfox1111 | the app catalog modal? or the horizon ones? | 21:24 |
| *** hurgleburgler has joined #openstack-horizon | 21:24 | |
| kfox1111 | the modal that has the app catalog details is angular. the rest are whatever they are in horizon. | 21:24 |
| tqtran | sorry, let me take a step back and try and understand what you're trying to do | 21:24 |
| tqtran | so you're trying to bring up the app catalog details first, which is angular, and when you click on install, open up another modal dialog (create image?) | 21:25 |
| kfox1111 | In the video where I switch over to grid view, click on details, and hit "Install", I'd expect the Glance dialog to pop up at that point just like it does at the very begining of the video where I click install. | 21:25 |
| kfox1111 | instead, the window turns more gray, the dialog doesn't show up, and it kind of wedges. | 21:25 |
| tqtran | right ok, i think i know why it doesn't work | 21:26 |
| david-lyle | oh, yeah there's no wiring for such shenanigans | 21:26 |
| tqtran | so first of all, the glance dialog is more legacy which uses bootstrap's modal underneath it | 21:26 |
| *** ducttape_ has quit IRC | 21:26 | |
| tqtran | and you trigger that via the 'ajax-modal' class i believe | 21:27 |
| kfox1111 | correct. | 21:27 |
| kfox1111 | same with nova and heat. | 21:27 |
| tqtran | now the new angular modal that you created, that is using angular-bootstrap, which ALSO happens to use bootstrap modal underneath it | 21:27 |
| *** Piet has quit IRC | 21:27 | |
| *** ducttape_ has joined #openstack-horizon | 21:27 | |
| *** lapalm has quit IRC | 21:28 | |
| kfox1111 | sure. | 21:28 |
| tqtran | i'm not sure if bootstrap allows more than one modal open at a time | 21:28 |
| kfox1111 | and they don't play nice with each other? | 21:28 |
| tqtran | but if it doesn't you can still do it via a different mechanism | 21:28 |
| kfox1111 | ah. :/ | 21:28 |
| tqtran | basically, the legacy modal is just pointing to a particular view | 21:29 |
| krotscheck | And, of course, the eslint people decide _right now_ to release another version. | 21:29 |
| *** wmlynch_ has quit IRC | 21:29 | |
| * krotscheck continues to tapdance on quicksand. | 21:29 | |
| tqtran | with the exception that it doesn't do a full page render, it renders the content of that view inside of a modal dialog | 21:29 |
| tqtran | all you have to do is, make a request to that same view, but render the content inside of another element (like a <div> or something) | 21:30 |
| tqtran | however, you'd either have to invent your own sliding mechanism or pop up mechanism to make this happen | 21:30 |
| tqtran | but that shouldnt be too hard to do, its just a div with a fixed height and width | 21:31 |
| tqtran | with z-position and absolute positioning | 21:31 |
| tqtran | high *z-index | 21:31 |
| kfox1111 | would it be easier to just make my own modal from scratch for my stuff? | 21:31 |
| tqtran | i don't recommend that, let me find out if you can open a modal inside of another modal first | 21:32 |
| kfox1111 | I was kind of pondering that anyway, since a squarish window would look similarish to the squarish icon, making it look nice. | 21:32 |
| kfox1111 | k. | 21:32 |
| tqtran | kfox1111: https://github.com/angular-ui/bootstrap/issues/943 | 21:33 |
| tqtran | but they are both angular modals, as oppose to angular-bootstrap modal and legacy-bootstrap modal | 21:33 |
| *** garthb has joined #openstack-horizon | 21:34 | |
| tqtran | kfox1111: if you're using both angular modals, it should work http://plnkr.co/edit/vfWJogYvMFFL2XcvM0pJ?p=preview | 21:34 |
| *** cbader has quit IRC | 21:35 | |
| tqtran | but i havent try angular modal opening a legacy one, it "should" work but you'd probably have to do some debugging | 21:35 |
| tqtran | to pinpoint what is causing the 2nd one to fail | 21:35 |
| kfox1111 | would it be easier just to upgrade horizon to use angular modals rather then lagacy ones? | 21:36 |
| *** stevemar has quit IRC | 21:36 | |
| tqtran | so looking at stackoverflow, doesn't seem like bootstrap limits the number of modals you can open at a time http://stackoverflow.com/questions/19528173/bootstrap-open-another-modal-in-modal | 21:36 |
| tqtran | so technically it SHOULD be possible | 21:36 |
| tqtran | kfox1111: that depends :P if you're willing to put in the work to create the glance modal, then yes | 21:37 |
| kfox1111 | I'd have to do it for glance, heat, and nova... | 21:37 |
| tqtran | but if you just want something quick, might be easier to debug and pinpoint the issue | 21:37 |
| *** geoffarnold has quit IRC | 21:37 | |
| kfox1111 | true. | 21:37 |
| kfox1111 | needs to work for liberty, so whatever's reasonable in that time frame. | 21:38 |
| tqtran | well give it a shot first, i might be able to lend a hand sometime next week, trying to wrap up the angular panel work | 21:38 |
| kfox1111 | ok. thanks for the help. | 21:38 |
| *** jbell8_ has quit IRC | 21:41 | |
| *** jingjing_ren has quit IRC | 21:45 | |
| *** Piet has joined #openstack-horizon | 21:45 | |
| *** bpokorny has quit IRC | 21:46 | |
| *** bpokorny_ has joined #openstack-horizon | 21:46 | |
| *** bpokorny_ has quit IRC | 21:48 | |
| *** Piet has quit IRC | 21:48 | |
| *** bpokorny has joined #openstack-horizon | 21:49 | |
| *** zul has quit IRC | 21:49 | |
| r1chardj0n3s | morning | 21:51 |
| esp | sup r1chardj0n3s | 21:52 |
| r1chardj0n3s | me, barely ;) | 21:52 |
| esp | lol | 21:52 |
| *** bpokorny has quit IRC | 21:52 | |
| *** bpokorny has joined #openstack-horizon | 21:52 | |
| esp | you need stronger coffee | 21:52 |
| r1chardj0n3s | haven't had coffee yet | 21:53 |
| r1chardj0n3s | just woke up ;) | 21:53 |
| esp | gotcha | 21:53 |
| esp | someone should make coffee infused toothpaste | 21:53 |
| r1chardj0n3s | looking forward to hearing that david-lyle has fixed all the seleniums | 21:53 |
| * esp makes a note | 21:53 | |
| r1chardj0n3s | lol | 21:53 |
| *** garthb has quit IRC | 21:55 | |
| kfox1111 | esp: no, just buy this: http://www.thinkgeek.com/product/5a65/ :) | 21:56 |
| david-lyle | r1chardj0n3s: I got distracted :( | 21:56 |
| david-lyle | might have to wait a bit | 21:56 |
| r1chardj0n3s | david-lyle: s'ok, I'll get back into it today :() | 21:56 |
| david-lyle | :/ | 21:56 |
| r1chardj0n3s | er :) | 21:56 |
| r1chardj0n3s | once I can type | 21:56 |
| kfox1111 | r1chardj0n3s: need more soap. ;) | 21:56 |
| *** pauloewerton has quit IRC | 21:57 | |
| r1chardj0n3s | I couldn't find a solution to the file upload input field issue with phantomjs/selenium though :( | 21:57 |
| esp | whoa, thx kfox1111! | 21:57 |
| r1chardj0n3s | kfox1111: yikes | 21:58 |
| *** jingjing_ren has joined #openstack-horizon | 21:58 | |
| kfox1111 | :) | 21:59 |
| openstackgerrit | Merged openstack/horizon: Add plugin registry to docs https://review.openstack.org/214253 | 22:01 |
| *** absubram has quit IRC | 22:01 | |
| *** garthb has joined #openstack-horizon | 22:03 | |
| *** garthb has quit IRC | 22:03 | |
| *** garthb has joined #openstack-horizon | 22:03 | |
| *** btully has quit IRC | 22:04 | |
| *** doug-fish has quit IRC | 22:05 | |
| *** gyee has quit IRC | 22:06 | |
| *** DWfuturetec has joined #openstack-horizon | 22:07 | |
| *** SimonChung has quit IRC | 22:07 | |
| *** ybathia has quit IRC | 22:07 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Moving translation to HTML for launch-instance network step https://review.openstack.org/210366 | 22:07 |
| *** btully has joined #openstack-horizon | 22:08 | |
| *** amotoki has joined #openstack-horizon | 22:10 | |
| *** vijendar has quit IRC | 22:11 | |
| *** tyr has quit IRC | 22:11 | |
| *** DWfuturetec has quit IRC | 22:14 | |
| *** mwhagedorn has quit IRC | 22:14 | |
| *** amotoki has quit IRC | 22:15 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: AVAILABLE_REGIONS picker should be responsive https://review.openstack.org/214369 | 22:27 |
| *** DWfuturetec has joined #openstack-horizon | 22:27 | |
| *** neillc_away is now known as neillc | 22:33 | |
| *** lhcheng_ has quit IRC | 22:34 | |
| *** geoffarnold has joined #openstack-horizon | 22:35 | |
| *** Piet has joined #openstack-horizon | 22:39 | |
| *** tjones has quit IRC | 22:40 | |
| *** jwy has quit IRC | 22:40 | |
| *** darrenc is now known as darrenc_afk | 22:40 | |
| *** tjones has joined #openstack-horizon | 22:40 | |
| *** Piet has quit IRC | 22:42 | |
| *** Piet has joined #openstack-horizon | 22:44 | |
| *** Piet has quit IRC | 22:46 | |
| *** SimonChung has joined #openstack-horizon | 22:47 | |
| *** cbader has joined #openstack-horizon | 22:47 | |
| *** ducttape_ has quit IRC | 22:50 | |
| *** mwhagedorn has joined #openstack-horizon | 22:52 | |
| *** cbader has quit IRC | 22:53 | |
| *** jpomeroy has quit IRC | 22:53 | |
| *** mwhagedorn has quit IRC | 22:53 | |
| *** mwhagedorn has joined #openstack-horizon | 22:55 | |
| *** darrenc_afk is now known as darrenc | 22:56 | |
| *** mwhagedorn has quit IRC | 22:58 | |
| *** dsneddon is now known as dsneddon_brb | 23:00 | |
| *** jingjing_ren has quit IRC | 23:02 | |
| *** cbader has joined #openstack-horizon | 23:02 | |
| *** jingjing_ren has joined #openstack-horizon | 23:03 | |
| *** mwhagedorn has joined #openstack-horizon | 23:03 | |
| *** geoffarnold has quit IRC | 23:07 | |
| *** exploreshaifali has quit IRC | 23:07 | |
| *** SimonChung has quit IRC | 23:08 | |
| *** SimonChung1 has joined #openstack-horizon | 23:08 | |
| *** jwy has joined #openstack-horizon | 23:10 | |
| *** amotoki has joined #openstack-horizon | 23:11 | |
| *** gyee has joined #openstack-horizon | 23:15 | |
| *** amotoki has quit IRC | 23:16 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Fixing docstring formatting errors and warnings https://review.openstack.org/214379 | 23:18 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: AVAILABLE_REGIONS picker should be responsive https://review.openstack.org/214369 | 23:18 |
| *** tyr has joined #openstack-horizon | 23:21 | |
| *** geoffarnold has joined #openstack-horizon | 23:24 | |
| *** jingjing_ren has quit IRC | 23:25 | |
| *** SimonChung1 has quit IRC | 23:26 | |
| r1chardj0n3s | oh :( ghostdriver dev (the phantomjs webdriver for selenium) is appealing for people to come and take over the project. Looks like no fix there for file upload in the interim. Guess I'm firing up a VM so I can run selenium tests :/ | 23:26 |
| *** jpomeroy has joined #openstack-horizon | 23:27 | |
| *** cbader has quit IRC | 23:28 | |
| *** chlong has quit IRC | 23:29 | |
| *** ZZelle-off has quit IRC | 23:38 | |
| *** jingjing_ren has joined #openstack-horizon | 23:38 | |
| *** dshaw___ has joined #openstack-horizon | 23:39 | |
| dshaw___ | trying to learn the review process and could use advice on my simple patch! https://review.openstack.org/#/c/212041/ | 23:40 |
| *** jingjing_ren has quit IRC | 23:47 | |
| *** jingjing_ren has joined #openstack-horizon | 23:48 | |
| *** geoffarnold has quit IRC | 23:49 | |
| *** jingjing_ren has quit IRC | 23:49 | |
| *** geoffarnold has joined #openstack-horizon | 23:49 | |
| openstackgerrit | Victor Stinner proposed openstack/horizon: Port babel_extract_angular test to Python 3 https://review.openstack.org/214291 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!