| *** julim has quit IRC | 00:39 | |
| *** julim has joined #openstack-horizon | 00:40 | |
| *** RA_ has joined #openstack-horizon | 00:42 | |
| *** amotoki has joined #openstack-horizon | 00:47 | |
| *** garthb has joined #openstack-horizon | 00:48 | |
| *** amotoki has quit IRC | 00:50 | |
| *** amotoki has joined #openstack-horizon | 00:56 | |
| *** jtriley has joined #openstack-horizon | 00:57 | |
| *** zhenguo has joined #openstack-horizon | 01:01 | |
| *** jtriley has quit IRC | 01:04 | |
| *** shivrao has quit IRC | 01:32 | |
| *** linkedinyou has joined #openstack-horizon | 01:43 | |
| *** jbell8 has quit IRC | 01:52 | |
| *** KunalGan_ has joined #openstack-horizon | 01:54 | |
| *** KunalGandhi has quit IRC | 01:57 | |
| *** yamamoto has joined #openstack-horizon | 02:07 | |
| *** yamamoto has quit IRC | 02:18 | |
| *** jamielennox is now known as jamielennox|away | 02:20 | |
| *** jamielennox|away is now known as jamielennox | 02:32 | |
| *** shivrao has joined #openstack-horizon | 02:47 | |
| *** garthb has quit IRC | 02:49 | |
| *** shivrao has quit IRC | 02:51 | |
| *** jbell8 has joined #openstack-horizon | 02:58 | |
| *** Daisy has joined #openstack-horizon | 03:02 | |
| *** yamamoto has joined #openstack-horizon | 03:04 | |
| *** KunalGan_ has quit IRC | 03:17 | |
| *** julim has quit IRC | 03:30 | |
| *** openstackgerrit has quit IRC | 03:31 | |
| *** openstackgerrit has joined #openstack-horizon | 03:32 | |
| *** saksham has joined #openstack-horizon | 03:37 | |
| *** Drago has quit IRC | 03:59 | |
| *** saksham_ has joined #openstack-horizon | 04:16 | |
| *** saksham has quit IRC | 04:18 | |
| *** saksham_ is now known as saksham | 04:18 | |
| *** shivrao has joined #openstack-horizon | 04:19 | |
| *** jtriley has joined #openstack-horizon | 04:46 | |
| *** jtriley has quit IRC | 04:50 | |
| *** Daisy has quit IRC | 04:57 | |
| *** fedexo has quit IRC | 04:57 | |
| *** Daisy has joined #openstack-horizon | 04:57 | |
| *** Daisy has quit IRC | 04:58 | |
| *** Daisy has joined #openstack-horizon | 05:04 | |
| *** Daisy has quit IRC | 05:08 | |
| *** kiran-r has joined #openstack-horizon | 05:10 | |
| *** geoffarnold has joined #openstack-horizon | 05:11 | |
| *** geoffarnold has quit IRC | 05:15 | |
| *** Daisy has joined #openstack-horizon | 05:15 | |
| *** Daisy has quit IRC | 05:19 | |
| *** geoffarnold has joined #openstack-horizon | 05:21 | |
| *** Daisy has joined #openstack-horizon | 05:31 | |
| *** cody-somerville has joined #openstack-horizon | 05:35 | |
| *** cody-somerville has quit IRC | 05:35 | |
| *** cody-somerville has joined #openstack-horizon | 05:35 | |
| *** Daisy has quit IRC | 05:36 | |
| *** stevemar has joined #openstack-horizon | 05:43 | |
| *** Daisy has joined #openstack-horizon | 05:43 | |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 05:47 |
|---|---|---|
| *** jamielennox is now known as jamielennox|away | 05:47 | |
| *** Daisy has quit IRC | 05:48 | |
| openstackgerrit | Karthik Suresh proposed openstack/horizon: Added small block to remove default panels https://review.openstack.org/213139 | 05:50 |
| *** shivrao has quit IRC | 05:54 | |
| *** Daisy has joined #openstack-horizon | 05:59 | |
| *** jtriley has joined #openstack-horizon | 06:00 | |
| *** Daisy has quit IRC | 06:00 | |
| *** Daisy has joined #openstack-horizon | 06:00 | |
| *** jtriley has quit IRC | 06:06 | |
| *** lsmola has joined #openstack-horizon | 06:11 | |
| *** jbell8 has quit IRC | 06:20 | |
| *** saksham has quit IRC | 06:20 | |
| *** geoffarnold is now known as geoffarnoldX | 06:21 | |
| *** pkarikh_ has joined #openstack-horizon | 06:22 | |
| pkarikh_ | amotiki: hi! Do you know anything about Horizon translation and translation scripts? I'm trying to follow https://wiki.openstack.org/wiki/Translations/Infrastructure#Horizon this man locally. Is there a way to compile translation strings locally? | 06:25 |
| *** _kiran_ has joined #openstack-horizon | 06:25 | |
| *** peristeri has joined #openstack-horizon | 06:26 | |
| pkarikh_ | amotoki: ^^^ sorry, I often make mistypes in the morning | 06:27 |
| *** kiran-r has quit IRC | 06:27 | |
| *** geoffarnoldX is now known as geoffarnold | 06:27 | |
| amotoki | pkarikh_: I think https://github.com/openstack-dev/devstack/blob/master/lib/horizon#L83-L87 helps you | 06:29 |
| *** geoffarnold is now known as geoffarnoldX | 06:29 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 06:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 06:29 |
| amotoki | pkarikh_: for django openstack auth, https://github.com/openstack-dev/devstack/blob/master/lib/horizon#L168 | 06:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 06:30 |
| *** rajatvig has joined #openstack-horizon | 06:30 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 06:33 |
| pkarikh_ | amotoki: yes, but looks like http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/propose_translation_update_horizon.sh this script make a lot of work too. Shouldn't I run it locally too? | 06:33 |
| *** xnox has joined #openstack-horizon | 06:33 | |
| amotoki | pkarikh_: it depends on what you want to do. | 06:34 |
| amotoki | pkarikh_: for minimum, what you need to do are "tx pull" and compile message catalogs. | 06:34 |
| pkarikh_ | amotoki: I want to backport new translations into the older versions of Horizon. | 06:35 |
| amotoki | pkarikh_: is the updated version of translation available in Transifex "Kilo" resource now? | 06:36 |
| pkarikh_ | amotoki: so, looks like I need to somehow compile or compress new files before committing them | 06:36 |
| amotoki | pkarikh_: compiled message catalogs are no longer maintained in our git repo | 06:37 |
| amotoki | so I don't think you need to compile thme. | 06:37 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Detail-page directives (Angular/UX) with CSS https://review.openstack.org/158881 | 06:37 |
| amotoki | pkarikh_: what are the target version? | 06:37 |
| pkarikh_ | amotoki: hm..Kilo, as far as I know. | 06:38 |
| amotoki | pkarikh_: more confirmation: are you try to backport Kilo translation to the upstream repo, or just apply it to your local deployment? | 06:40 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP - Image Details Edit/Delete (UX/Angular) https://review.openstack.org/158409 | 06:42 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 06:42 |
| pkarikh_ | amotoki: I want try to back port upstream translations into the Kilo Horizon of Mirantis Openstack. It doesn't affect upstream, but I want to make it the same way it was for Kilo. | 06:42 |
| *** mrunge has joined #openstack-horizon | 06:43 | |
| amotoki | pkarikh_: for the upsteram translations, what I usually do is to download latest translations using "tx pull" with some threshold, "git add" them and commit, and then propose for review. | 06:44 |
| amotoki | pkarikh_: that's all. | 06:44 |
| amotoki | pkarikh_: /FYI/ this is the script I usually use to propose translation imports: https://github.com/amotoki/horizon-i18n-tools/blob/master/propose-trans.sh | 06:46 |
| amotoki | I borrow a bunch of code from project-config, but most of them are for automation (to cleanup a previous run) and skip to create a new commit if no new translation is available. | 06:47 |
| *** vgridnev has joined #openstack-horizon | 06:47 | |
| pkarikh_ | amotoki: hm.. Ok. So, I shouldn't have some transfix credits to pull upstream translations? tx pull takes right transfix repo and git add them. I should'n run manage.py makemessages? | 06:48 |
| amotoki | pkarikh_: re: makemessages, it depends on a case. | 06:49 |
| amotoki | pkarikh_: if your source code is updated and the source string is changed, you should run makemessage to keep source and trnaslation strings synced. | 06:50 |
| amotoki | otherwise there is no need to run it. | 06:50 |
| pkarikh_ | amotoki: Am I right that if source strings was not changed and I run make messages, it will not break anything? | 06:51 |
| amotoki | pkarikh_: right. it should not break anything. | 06:51 |
| *** stevemar has quit IRC | 06:53 | |
| *** stevemar has joined #openstack-horizon | 06:55 | |
| *** stevemar has quit IRC | 06:56 | |
| *** juggler has quit IRC | 06:57 | |
| *** RA_ has quit IRC | 07:09 | |
| *** _kiran_ has quit IRC | 07:17 | |
| pkarikh_ | amotoki: ok, thank you! | 07:18 |
| *** markus_z has joined #openstack-horizon | 07:19 | |
| *** saksham has joined #openstack-horizon | 07:20 | |
| *** pkarikh_ has quit IRC | 07:20 | |
| *** saksham has left #openstack-horizon | 07:21 | |
| *** romainh has joined #openstack-horizon | 07:23 | |
| *** linkedinyou has quit IRC | 07:24 | |
| *** bfic has joined #openstack-horizon | 07:26 | |
| *** yamamoto has quit IRC | 07:26 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:27 | |
| *** ^Gal^ has quit IRC | 07:29 | |
| *** jtomasek has quit IRC | 07:29 | |
| *** rdopiera has joined #openstack-horizon | 07:31 | |
| *** ^Gal^ has joined #openstack-horizon | 07:32 | |
| *** arxcruz has joined #openstack-horizon | 07:33 | |
| *** jcoufal has joined #openstack-horizon | 07:33 | |
| openstackgerrit | Merged openstack/horizon: Remove _40_router.py.example file https://review.openstack.org/215248 | 07:34 |
| *** Ala has joined #openstack-horizon | 07:34 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:41 | |
| openstackgerrit | Wim De Clercq proposed openstack/horizon: Add allowed address pair extension UI for neutron ports. https://review.openstack.org/193079 | 07:42 |
| *** yamamoto has joined #openstack-horizon | 07:49 | |
| *** kzaitsev_mb has quit IRC | 07:50 | |
| *** MaxV has joined #openstack-horizon | 07:56 | |
| *** bluex-pl has joined #openstack-horizon | 07:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 07:58 | |
| *** mpavlase has joined #openstack-horizon | 08:00 | |
| *** jtriley has joined #openstack-horizon | 08:07 | |
| *** jtriley has quit IRC | 08:13 | |
| *** kzaitsev_mb has quit IRC | 08:14 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 08:18 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 08:18 |
| *** vgridnev has quit IRC | 08:23 | |
| *** ygbo has joined #openstack-horizon | 08:24 | |
| *** rajatvig has quit IRC | 08:25 | |
| *** linkedinyou has joined #openstack-horizon | 08:26 | |
| *** tosky has joined #openstack-horizon | 08:46 | |
| *** tosky has quit IRC | 08:46 | |
| *** tosky has joined #openstack-horizon | 08:48 | |
| *** tosky has quit IRC | 08:51 | |
| *** tosky has joined #openstack-horizon | 08:53 | |
| robcresswell | o/ Morning folks. Please ping me if you would like some code reviewed. L-3 is next week, please don't leave it to the last day :D | 09:02 |
| *** jcoufal has quit IRC | 09:03 | |
| pkarikh | amotoki: looks like transifex wants some credentials. tx pull retirns "Exception: No user credentials found for host https://www.transifex.com." | 09:10 |
| amotoki | pkarikh: you need to have a transifex account. | 09:11 |
| *** vgridnev has joined #openstack-horizon | 09:12 | |
| *** aix has joined #openstack-horizon | 09:20 | |
| *** DWfuturetec has joined #openstack-horizon | 09:21 | |
| *** kzaitsev_mb has joined #openstack-horizon | 09:25 | |
| pkarikh | amotoki: yes, I thought that I can do it without account. So, am I right that backporting translations would be look like tx pool on branch I want to update translations? | 09:27 |
| pkarikh | robcresswell: morning! For example, this patch - https://review.openstack.org/#/c/142481/ | 09:36 |
| *** jcoufal has joined #openstack-horizon | 09:37 | |
| *** akrivoka has joined #openstack-horizon | 09:50 | |
| *** e0ne has joined #openstack-horizon | 09:51 | |
| robcresswell | pkarikh: Woah patch sets | 09:52 |
| pkarikh | robcresswell: :D | 09:53 |
| *** romainh has quit IRC | 09:53 | |
| robcresswell | pkarikh: Added to my list boss :D | 09:55 |
| pkarikh | robcresswell: thanks. :) And how long it that list? | 09:56 |
| robcresswell | pkarikh: Only a handful so far. Should get to it today. | 09:56 |
| * robcresswell makes no promises :p | 09:56 | |
| *** yamamoto has quit IRC | 09:57 | |
| *** cody-somerville has quit IRC | 09:58 | |
| pkarikh | robcresswell: looks like it is really hard to be a core-dev. :) | 09:58 |
| tsufiev | pkarikh, I think there is a constant pressure of answering expectations | 09:59 |
| mrunge | pkarikh, whatever he says, it's harder ;-) | 09:59 |
| pkarikh | mrunge, robcresswell: so, thanks you are doing it. :) | 10:01 |
| *** e0ne has quit IRC | 10:08 | |
| *** vgridnev has quit IRC | 10:08 | |
| *** liangbo has joined #openstack-horizon | 10:08 | |
| robcresswell | :) | 10:09 |
| *** DWfuturetec has quit IRC | 10:11 | |
| *** aix has quit IRC | 10:15 | |
| *** e0ne has joined #openstack-horizon | 10:18 | |
| *** jtomasek has joined #openstack-horizon | 10:19 | |
| *** ekarlso has quit IRC | 10:32 | |
| *** ekarlso has joined #openstack-horizon | 10:32 | |
| *** DWfuturetec has joined #openstack-horizon | 10:35 | |
| *** Daisy has quit IRC | 10:36 | |
| *** Daisy has joined #openstack-horizon | 10:36 | |
| *** jtriley has joined #openstack-horizon | 10:37 | |
| *** e0ne has quit IRC | 10:40 | |
| *** Daisy has quit IRC | 10:41 | |
| *** romainh has joined #openstack-horizon | 10:43 | |
| *** jtriley has quit IRC | 10:44 | |
| *** yamamoto has joined #openstack-horizon | 10:47 | |
| *** aix has joined #openstack-horizon | 10:48 | |
| *** yamamoto has quit IRC | 10:50 | |
| *** yamamoto has joined #openstack-horizon | 10:50 | |
| *** jamielennox|away has quit IRC | 10:50 | |
| *** yamamoto_ has joined #openstack-horizon | 10:50 | |
| *** liangbo has quit IRC | 10:52 | |
| *** yamamoto has quit IRC | 10:54 | |
| *** zul has quit IRC | 10:56 | |
| *** jroll has quit IRC | 10:56 | |
| *** ameade has quit IRC | 10:58 | |
| *** ameade has joined #openstack-horizon | 10:59 | |
| *** jroll has joined #openstack-horizon | 11:02 | |
| *** amotoki has quit IRC | 11:02 | |
| *** yamamoto_ has quit IRC | 11:03 | |
| *** jamielennox|away has joined #openstack-horizon | 11:04 | |
| *** jamielennox|away is now known as jamielennox | 11:04 | |
| *** romainh has quit IRC | 11:05 | |
| *** vgridnev has joined #openstack-horizon | 11:05 | |
| *** ^Gal^ has quit IRC | 11:16 | |
| *** romainh has joined #openstack-horizon | 11:19 | |
| *** yamamoto has joined #openstack-horizon | 11:21 | |
| *** liangbo has joined #openstack-horizon | 11:22 | |
| *** nikunj2512 has joined #openstack-horizon | 11:23 | |
| *** nikunj2512 has quit IRC | 11:24 | |
| *** nikunj2512 has joined #openstack-horizon | 11:25 | |
| *** fsaifee has joined #openstack-horizon | 11:26 | |
| nikunj2512 | Hi, in the Horizon logs, i am getting debug logs but i have set the log level to info | 11:26 |
| nikunj2512 | {"tags": [], "color": "", "@version": 1, "@timestamp": "2015-08-24T09:06:39.696196Z", "user_identity": "", "project": "unknown", "instance": "", "host": "cmc", "version": "unknown", "path": "/opt/stack/venvs/openstack/lib/python2.7/site-packages/heatclient/common/http.py", "logger": "heatclient.common.http", "type": "horizon", "message": "curl -i - | 11:26 |
| nikunj2512 | X GET -H 'X-Auth-Token: {SHA1}47667d3daab769bafdbd1d81d428cf0a933b8367' -H 'Content-Type: application/json' -H 'Accept: application/json' -H 'User-Agent: python-heatclient' --cacert /usr/local/share/ca-certificates/ephemeralca-cacert.crt http://192.168.0.1:8004/v1/7c63eee5fa49416dbe79e38d21c4b84a/stacks?sort_dir=desc&sort_key=created_at&limit=17&ma | 11:26 |
| nikunj2512 | rker=1d001654-9a0a-41ab-b0b0-acf3c10477dc", "levelname": "DEBUG"} | 11:26 |
| nikunj2512 | Please can anyone tell me how to stop printing debug logs when log level is still INFO> | 11:27 |
| nikunj2512 | ? | 11:27 |
| *** nikunj2512 has quit IRC | 11:29 | |
| *** nikunj2512 has joined #openstack-horizon | 11:30 | |
| *** ^Gal^ has joined #openstack-horizon | 11:35 | |
| robcresswell | nikunj2512: Where have you set the log level? | 11:36 |
| robcresswell | && is DEBUG True? | 11:37 |
| nikunj2512 | @robcresswell: In the /etc/horizon/local_settings.py and DEBUG is False | 11:37 |
| pkarikh | nikunj2512: it could be stupid but... Are you sure that Horizon uses that local_settings.py? There is no another local_settings on that env? | 11:38 |
| nikunj2512 | i think i got the issue.. i changed the log level in /etc/apache2/sites-enabled/horizon.conf file from debug to info | 11:38 |
| tsufiev | mrunge, hi! Are you aware of dj18 deprecation warnings being outputted while running ./manage.py compress? | 11:39 |
| nikunj2512 | i am using this local_settings.py file and adding it in the settings.py filr | 11:39 |
| nikunj2512 | *file | 11:39 |
| mrunge | tsufiev, yes, there are a few | 11:39 |
| *** ttrifonov is now known as zz_ttrifonov | 11:39 | |
| tsufiev | mrunge, okay, then I'm relieved :) | 11:40 |
| robcresswell | tsufiev: Deprecated in dj18, or removed? | 11:40 |
| mrunge | tsufiev, they are harmless and looking for a fix | 11:40 |
| tsufiev | robcresswell, http://paste2.org/ejcDLx0k - deprecated | 11:40 |
| mrunge | IMHO deprecations like The django.forms.util module has been renamed. Use django.forms.utils instead. | 11:40 |
| mrunge | Loading the `url` tag from the `future` library is deprecated and will be removed in Django 1.9. Use the default `url` tag instead. | 11:41 |
| mrunge | those are easy fixes | 11:41 |
| mrunge | someone just needs to do it | 11:41 |
| robcresswell | tsufiev: Huh, I thought I removed those | 11:41 |
| robcresswell | I swear I had a patch to remove the cycle and firstof warnings just a few days back | 11:41 |
| robcresswell | Maybe it didnt merge yet | 11:42 |
| tsufiev | robcresswell, hm, they may haven't yet got it into the commit I'm reviewing | 11:42 |
| tsufiev | (because it wasn't rebased to the actual master) | 11:42 |
| robcresswell | tsufiev: https://review.openstack.org/#/c/173921/ | 11:42 |
| robcresswell | Ah, I see | 11:42 |
| pkarikh | Folks, has anyone faced "Don't know how to merge conflicting combinators: <SimpleSelector: u'+ .btn:not(:first-child)'> and <SimpleSelector: u'> .btn'>" error? I've googled some IRC log where r1chardj0n3s said about it and pyScss problems, but I cant find a log with some solution. | 11:42 |
| tsufiev | robcresswell, yep, thanks for taking care of them ) | 11:42 |
| robcresswell | tsufiev: np, was only minor bug. | 11:43 |
| mrunge | pkarikh, wait | 11:45 |
| mrunge | I tracked that down last friday | 11:46 |
| mrunge | it is an pyScss issue, your pyScss may be to new | 11:46 |
| mrunge | pkarikh, I have a patch for this, but it's not acceptable upstream, let me find the bug for you | 11:47 |
| mrunge | pkarikh, https://bugs.launchpad.net/horizon/+bug/1487506 | 11:48 |
| openstack | Launchpad bug 1487506 in OpenStack Dashboard (Horizon) "compression error" [Undecided,New] | 11:48 |
| pkarikh | mrunge: yep, I remember same problem a few months ago. It as something wrong with pyScss version and I had to downgrade it. But I can't find right version | 11:48 |
| mrunge | pkarikh, IMHO horizon/static/angular/action-list/action-list.scss is broken and should be fixed | 11:48 |
| mrunge | it's the only reference to .btn:not(:first-child) { | 11:49 |
| mrunge | just dropping it solves the compression issue | 11:49 |
| pkarikh | mrunge: so I can't fix it just with another version of django-pyscss or pyscss? | 11:50 |
| nikunj2512 | robcresswell: in the settings.py file i have defined something i this -> http://paste.openstack.org/show/426012/ | 11:51 |
| nikunj2512 | robcresswell: if you see the config i pasted in the above url, you will see this filename -> /var/log/horizon/horizon-json.log. In this file i am seeing the debug logs | 11:52 |
| *** frickler has joined #openstack-horizon | 11:53 | |
| mrunge | pkarikh, you could probably downgrade to python-scss-1.2.1 | 11:53 |
| pkarikh | mrunge: looks like downgrading django-pyscss to 1.0.6 from 2.0.2 helped | 11:53 |
| mrunge | for me, this is not a real option, and since requirements for liberty is pyScss>=1.3.4 we need to fix it anyways | 11:54 |
| mrunge | I wonder how this passes the gate | 11:55 |
| *** Daisy has joined #openstack-horizon | 11:57 | |
| *** KingKhan has joined #openstack-horizon | 11:58 | |
| openstackgerrit | Raga lahari proposed openstack/horizon: Update Settings tab in the dashboard https://review.openstack.org/216218 | 11:58 |
| *** Daisy has quit IRC | 12:02 | |
| *** lapalm has joined #openstack-horizon | 12:03 | |
| frickler | how can I debug why the "Volumes" tab is missing from my dashboard? working with volumes via cli works fine, I can also see it in the service catalog: http://paste.openstack.org/show/426013/ | 12:08 |
| *** nikunj2512 has quit IRC | 12:10 | |
| mrunge | frickler, you might need a cinder v1 endpoint | 12:13 |
| *** piotr_k has joined #openstack-horizon | 12:15 | |
| robcresswell | :s How am I getting npm run lint failures on master, yet the gate is fine...? | 12:16 |
| *** geoffarnoldX is now known as geoffarnold | 12:16 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Move i18n to HTML for launch-instance source step https://review.openstack.org/216230 | 12:17 |
| *** liangbo has quit IRC | 12:17 | |
| *** lyanchih has joined #openstack-horizon | 12:17 | |
| piotr_k | hello all, horizon newbie here. Why when I add neutron's endpoint to the regionOne horizon is detecting that service to be enabled on regionTwo? Is there any way to chage that? I'd like to have nova-network in the regionOne and neutron in the regionTwo | 12:18 |
| piotr_k | Can anybody at least point me in the right direction in horizon, please? | 12:18 |
| *** geoffarnold is now known as geoffarnoldX | 12:19 | |
| *** julim has joined #openstack-horizon | 12:22 | |
| mrunge | piotr_k, horizon pulls that info from keystone | 12:22 |
| mrunge | piotr_k, no need to change horizon settings | 12:23 |
| piotr_k | yes, I know but the problem is that I want to add neutron to the regionTwo only...when I do that horizon detect two regions but in both I have enabled neutron and I cannot launch VM in region one using nova network | 12:25 |
| *** daemontool__ has joined #openstack-horizon | 12:27 | |
| *** daemontool_ has quit IRC | 12:29 | |
| *** DWfuturetec has quit IRC | 12:33 | |
| *** petertr7_away is now known as petertr7 | 12:37 | |
| *** zul has joined #openstack-horizon | 12:39 | |
| *** Daisy has joined #openstack-horizon | 12:40 | |
| *** zz_ttrifonov is now known as ttrifonov | 12:43 | |
| *** jtriley has joined #openstack-horizon | 12:44 | |
| frickler | mrunge: in fact it works if I create an endpoint with name/type="cinder/volume" pointing to the cinder v2 API | 12:47 |
| *** sayan has joined #openstack-horizon | 12:47 | |
| *** doug-fish has joined #openstack-horizon | 12:48 | |
| mrunge | frickler, yes, that's my understanding | 12:48 |
| *** MaxV has quit IRC | 12:48 | |
| *** MaxV has joined #openstack-horizon | 12:48 | |
| frickler | mrunge: so is this a deficiency of horizon, when cinder+nova seem to work well with "cinderv2/volumev2"? | 12:49 |
| mrunge | frickler, horizon currently requires volume v1 and volume v2 endpoints. so: yes it's a bug. if it's not already filed, you should probably file a bug | 12:51 |
| mrunge | frickler, did you configure the preferred version for volume in local_settings.py ? | 12:51 |
| frickler | mrunge: yes: OPENSTACK_API_VERSIONS = { "volume": 2 } | 12:53 |
| mrunge | ok, that's not solving it either :( | 12:53 |
| *** jtriley has quit IRC | 12:54 | |
| frickler | mrunge: and it looks like I really do not need the v1 endpoint, just the v2 endpoint with a different service name/type | 12:54 |
| mrunge | yupp | 12:55 |
| mrunge | there must be some code explicitly looking for an endpoint named volume or cindev1 (or so) | 12:56 |
| mrunge | frickler, when you're filing a bug, could you please add the version you're using? I.e. kilo or master branch? | 12:58 |
| frickler | mrunge: I found https://bugs.launchpad.net/horizon/+bug/1415712 which seems to fit, will update with my results | 12:58 |
| openstack | Launchpad bug 1415712 in OpenStack Dashboard (Horizon) ""Volumes" tab doesn't show up if cinder v1 isn't registered" [Undecided,In progress] - Assigned to IWAMOTO Toshihiro (iwamoto) | 12:58 |
| rdopiera | does anybody know how I would check if we are using neutron or nova-network? | 12:59 |
| mrunge | rdopiera, iirc they are compatible from api side | 13:01 |
| piotr_k | rdopiera, openstack endpoint list | 13:01 |
| mrunge | there should be an api to ask, if neutron feauture foo is enabled | 13:02 |
| *** mrunge has quit IRC | 13:02 | |
| openstackgerrit | Frode Nordahl proposed openstack/horizon: Add support for creating subnets with Neutron subnet allocation https://review.openstack.org/203570 | 13:08 |
| fnordahl | mrunge: you have is_extension_supported and is_service_enabled | 13:12 |
| fnordahl | mrunge: the former checks against the neutron extension list, the latter both checks Horizon configuration and the Neutron extension list. | 13:13 |
| fnordahl | mrunge: Could that be what you are looking for? | 13:13 |
| fnordahl | rdopiera: base.is_service_enabled(request, 'network') | 13:14 |
| piotr_k | newbie question: the object "request" is passed as an argument to a lot of functions. Where can I find definition of that object? | 13:14 |
| fnordahl | rdopiera: have a look at openstack_dashboard/api/network.py | 13:15 |
| piotr_k | anybody? ;) | 13:16 |
| rdopiera | fnordahl: thanks! | 13:17 |
| fnordahl | piotr_k: it's a HttpReqest object from the http module. | 13:17 |
| rdopiera | piotr_k: it's a webob request | 13:17 |
| tsufiev | piotr_k, https://docs.djangoproject.com/en/1.8/ref/request-response/ | 13:17 |
| rdopiera | ah | 13:17 |
| rdopiera | sorry, django request | 13:17 |
| * rdopiera is getting the projects mixed up | 13:17 | |
| rdopiera | piotr_k: but it has a lot of stuff added | 13:17 |
| robcresswell | tqtran: https://review.openstack.org/#/c/216230/ | 13:20 |
| piotr_k | rdopiera, I asked because I am wandering about this line in api/base.py | 13:20 |
| piotr_k | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/base.py#L332 | 13:20 |
| piotr_k | the object request.user.services_region | 13:21 |
| fsaifee | I am a newbie to opentstack. I have assigned myself to a bug - " launch instance should add config for require ssh key " on horizon. I have also set up dev env. Can anyone tell me what should I do now? Where should I start? | 13:21 |
| piotr_k | is it region_id or region | 13:21 |
| *** Samos123 has quit IRC | 13:22 | |
| piotr_k | because later on in the function is_service_enabled it is compared with _get_endpoint_region(endpoint) == region: | 13:22 |
| *** dsneddon has quit IRC | 13:22 | |
| *** lapalm_ has joined #openstack-horizon | 13:22 | |
| piotr_k | and I am wandering whether this is correct | 13:23 |
| robcresswell | fsaifee: Can you link the bug please? Generally, you should look for bugs tagged "low-hanging-fruit" for first bugs. | 13:23 |
| *** jroll has quit IRC | 13:23 | |
| fsaifee | https://bugs.launchpad.net/horizon/+bug/1473549 | 13:23 |
| openstack | Launchpad bug 1473549 in OpenStack Dashboard (Horizon) "launch instance should add config for require ssh key" [Undecided,New] - Assigned to Fatema Saifee (fatema-saifee711) | 13:23 |
| *** e0ne has joined #openstack-horizon | 13:23 | |
| fsaifee | yes it is low hanging bug | 13:24 |
| *** Daisy has quit IRC | 13:24 | |
| *** jamielennox has quit IRC | 13:26 | |
| robcresswell | fsaifee: Ah, nice. Well, look over the bug report, find the setting referenced, and see how to go about implementing it. It seems to be similar to an existing setting. Also, the bug author is ducttape_, so you can pester him for info ;) | 13:26 |
| *** lapalm has quit IRC | 13:26 | |
| *** lapalm_ has quit IRC | 13:26 | |
| *** Samos123 has joined #openstack-horizon | 13:27 | |
| *** doug-fish has quit IRC | 13:27 | |
| *** lapalm has joined #openstack-horizon | 13:28 | |
| *** doug-fish has joined #openstack-horizon | 13:28 | |
| *** _crobertsrh is now known as crobertsrh | 13:28 | |
| fsaifee | robcresswell: thank you. I'll start looking t its reposrt | 13:28 |
| *** bapalm_ has joined #openstack-horizon | 13:28 | |
| *** doug-fis_ has joined #openstack-horizon | 13:29 | |
| *** liangbo has joined #openstack-horizon | 13:30 | |
| *** doug-fi__ has joined #openstack-horizon | 13:31 | |
| *** doug-fish has quit IRC | 13:32 | |
| *** fsaifee has quit IRC | 13:32 | |
| *** doug-fish has joined #openstack-horizon | 13:33 | |
| *** exploreshaifali has joined #openstack-horizon | 13:33 | |
| *** doug-fis_ has quit IRC | 13:34 | |
| *** dsneddon has joined #openstack-horizon | 13:34 | |
| *** doug-fish has quit IRC | 13:34 | |
| *** doug-fish has joined #openstack-horizon | 13:34 | |
| *** yamamoto has quit IRC | 13:34 | |
| *** lyanchih has quit IRC | 13:35 | |
| *** doug-fi__ has quit IRC | 13:36 | |
| *** petertr7 is now known as petertr7_away | 13:36 | |
| *** jroll has joined #openstack-horizon | 13:37 | |
| tsufiev | doug-fish, hello, Doug! A wonderful day to finally fix integration tests, isn't it :)? | 13:39 |
| *** jpomeroy has joined #openstack-horizon | 13:40 | |
| *** jtriley has joined #openstack-horizon | 13:42 | |
| *** jamielennox|away has joined #openstack-horizon | 13:43 | |
| *** doug-fish has quit IRC | 13:43 | |
| *** jamielennox|away is now known as jamielennox | 13:43 | |
| *** doug-fish has joined #openstack-horizon | 13:43 | |
| *** KingKhan has quit IRC | 13:47 | |
| *** lawrancejing has joined #openstack-horizon | 13:48 | |
| *** doug-fish has quit IRC | 13:48 | |
| lawrancejing | hello cindy & rob , for the two patch : https://review.openstack.org/#/c/216230/ & https://review.openstack.org/#/c/215792/ could we add one common bug for such patch, so that others can contribute and add `Partial-Bug: xxxxxx` | 13:48 |
| *** geoffarnoldX is now known as geoffarnold | 13:50 | |
| *** yamamoto has joined #openstack-horizon | 13:50 | |
| *** neelashah has joined #openstack-horizon | 13:50 | |
| *** doug-fish has joined #openstack-horizon | 13:50 | |
| *** bfic has left #openstack-horizon | 13:53 | |
| doug-fish | tsufiev: you're fishing for a hug, aren't you | 13:55 |
| doug-fish | :-) | 13:55 |
| doug-fish | yeah, it's nice to see that code moving along | 13:55 |
| tsufiev | doug-fish, for a beer, actually ;) | 13:56 |
| tsufiev | doug-fish, so I had to fall back to a less straightforward 'data-selenium' assignment in tables code, otherwise a lot of unit tests failed | 13:56 |
| *** petertr7_away is now known as petertr7 | 13:57 | |
| *** lapalm has quit IRC | 13:58 | |
| tsufiev | also, although tests start to pass in https://review.openstack.org/#/c/214671/ they are still very fragile until the next commit is merged also | 13:58 |
| doug-fish | in a class and can't chat much todqay | 13:58 |
| tsufiev | ok | 13:59 |
| *** lblanchard has joined #openstack-horizon | 13:59 | |
| *** amotoki has joined #openstack-horizon | 14:00 | |
| *** pauloewerton has joined #openstack-horizon | 14:03 | |
| openstackgerrit | Yves-Gwenael Bourhis proposed openstack/horizon: Show external networks https://review.openstack.org/199127 | 14:04 |
| *** mwhagedorn has joined #openstack-horizon | 14:04 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 14:06 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 14:06 |
| *** frickler_ has joined #openstack-horizon | 14:07 | |
| *** neelashah has left #openstack-horizon | 14:07 | |
| *** mrunge has joined #openstack-horizon | 14:07 | |
| *** frickler has quit IRC | 14:07 | |
| *** tyr has joined #openstack-horizon | 14:08 | |
| *** jamielennox has quit IRC | 14:08 | |
| *** Ala has quit IRC | 14:08 | |
| *** ducttape_ has joined #openstack-horizon | 14:09 | |
| *** tyr has quit IRC | 14:09 | |
| ducttape_ | marked https://bugs.launchpad.net/horizon/+bug/1473549 as dupe of https://bugs.launchpad.net/horizon/+bug/1283148 fyi | 14:10 |
| openstack | Launchpad bug 1283148 in OpenStack Dashboard (Horizon) "duplicate for #1473549 add keypair config params for instance creation" [Medium,In progress] - Assigned to Eric Peterson (ericpeterson-l) | 14:10 |
| openstack | Launchpad bug 1283148 in OpenStack Dashboard (Horizon) "add keypair config params for instance creation" [Medium,In progress] - Assigned to Eric Peterson (ericpeterson-l) | 14:10 |
| *** aortega_ has quit IRC | 14:10 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Move i18n to HTML for launch-instance source step https://review.openstack.org/216230 | 14:10 |
| *** jamielennox|away has joined #openstack-horizon | 14:10 | |
| *** jamielennox|away is now known as jamielennox | 14:11 | |
| *** DWfuturetec has joined #openstack-horizon | 14:13 | |
| *** jprovazn has joined #openstack-horizon | 14:13 | |
| *** mwhagedorn has quit IRC | 14:13 | |
| *** mwhagedorn has joined #openstack-horizon | 14:14 | |
| *** zhenguo has quit IRC | 14:17 | |
| *** lyanchih has joined #openstack-horizon | 14:17 | |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Correct local_settings example from overwriting settings https://review.openstack.org/212090 | 14:19 |
| *** frickler_ is now known as frickler | 14:19 | |
| *** petertr7 is now known as petertr7_away | 14:20 | |
| *** mrunge has quit IRC | 14:20 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angular metadata update modal https://review.openstack.org/184274 | 14:25 |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Angularize metadata update modals https://review.openstack.org/184275 | 14:25 |
| *** petertr7_away is now known as petertr7 | 14:25 | |
| openstackgerrit | Szymon Wróblewski proposed openstack/horizon: Allow to edit image metadata from project view https://review.openstack.org/184280 | 14:26 |
| openstackgerrit | lawrancejing proposed openstack/horizon: Moving inline html code out of magic-search spec file https://review.openstack.org/216281 | 14:32 |
| *** alejandrito has joined #openstack-horizon | 14:37 | |
| openstackgerrit | lawrancejing proposed openstack/horizon: Moving inline html code out of magic-search spec file https://review.openstack.org/216281 | 14:38 |
| *** liangbo has quit IRC | 14:38 | |
| *** MaxV has quit IRC | 14:39 | |
| *** liangbo has joined #openstack-horizon | 14:40 | |
| *** bapalm_ has quit IRC | 14:41 | |
| *** vijendar has joined #openstack-horizon | 14:42 | |
| lawrancejing | liangbo | 14:44 |
| liangbo | Hi, bro | 14:45 |
| *** bapalm- has joined #openstack-horizon | 14:46 | |
| *** exploreshaifali has quit IRC | 14:46 | |
| *** zhenguo has joined #openstack-horizon | 14:47 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Use security group id not name in the create instance dialog https://review.openstack.org/211046 | 14:47 |
| openstackgerrit | David Lyle proposed openstack/horizon: [Sahara] Add support for event logs https://review.openstack.org/158715 | 14:54 |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Correct local_settings example from overwriting settings https://review.openstack.org/212090 | 14:55 |
| *** neelashah has joined #openstack-horizon | 14:59 | |
| *** jcoufal has quit IRC | 15:01 | |
| pkarikh | doug-fish: hi! Do you know, what should I do if I found mistake in the Kilo translation strings? Do we have any person to contact about it? | 15:01 |
| *** geoffarnold is now known as geoffarnoldX | 15:01 | |
| *** bluex-pl has quit IRC | 15:06 | |
| *** bluex-pl has joined #openstack-horizon | 15:06 | |
| *** yamamoto has quit IRC | 15:07 | |
| *** MaxV has joined #openstack-horizon | 15:11 | |
| *** lyanchih has quit IRC | 15:12 | |
| *** arxcruz has quit IRC | 15:12 | |
| *** lyanchih has joined #openstack-horizon | 15:12 | |
| *** bluex-pl has quit IRC | 15:14 | |
| *** amotoki has quit IRC | 15:16 | |
| openstackgerrit | Darren Shaw proposed openstack/horizon: Correct local_settings example from overwriting settings https://review.openstack.org/212090 | 15:17 |
| *** jbell8 has joined #openstack-horizon | 15:17 | |
| *** geoffarnoldX is now known as geoffarnold | 15:22 | |
| *** peristeri has quit IRC | 15:23 | |
| *** geoffarnold has quit IRC | 15:28 | |
| *** piotr_k has quit IRC | 15:29 | |
| *** zhenguo has quit IRC | 15:31 | |
| *** Sukhdev has joined #openstack-horizon | 15:33 | |
| *** Mohh has joined #openstack-horizon | 15:34 | |
| *** Drago has joined #openstack-horizon | 15:34 | |
| *** Drago has quit IRC | 15:34 | |
| *** Drago has joined #openstack-horizon | 15:35 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Theming Mechanism now supports 3rd party themes https://review.openstack.org/197821 | 15:35 |
| Mohh | Hi there. I clone horizon source, and I ran run_test script. The script executed properly with no errror. But after I login to the horizon the following error occured: | 15:35 |
| Mohh | Exception Value: global name '_' is not defined Exception Location:/home/stack/source_codes/horizon/.venv/local/lib/python2.7/site-packages/openstack_auth/plugin/base.py in list_projects, line 95 Python Executable:/home/stack/source_codes/horizon/.venv/bin/python | 15:35 |
| *** ccesario has quit IRC | 15:36 | |
| *** garthb has joined #openstack-horizon | 15:36 | |
| *** Daisy has joined #openstack-horizon | 15:36 | |
| david-ly_ | Mohh: what version of horizon are you using, this reminds me of an old bug that's been fixed | 15:37 |
| *** david-ly_ is now known as david-lyle | 15:38 | |
| *** ChanServ sets mode: +o david-lyle | 15:38 | |
| Mohh | in virtual env 1.7 is installed | 15:38 |
| david-lyle | https://bugs.launchpad.net/horizon/+bug/1452232 specifically | 15:38 |
| openstack | Launchpad bug 1452232 in OpenStack Dashboard (Horizon) ""NameError: global name '_' is not defined" on keystone authorization error" [Medium,Fix committed] - Assigned to Doug Fish (drfish) | 15:38 |
| Mohh | david-lyle: Is that merged? | 15:39 |
| david-lyle | yes | 15:39 |
| Mohh | david-lyle: OK, just checking git pull... | 15:40 |
| david-lyle | https://review.openstack.org/#/c/180486/ for liberty and https://review.openstack.org/#/c/199194/ for kilo | 15:40 |
| hurgleburgler1 | If anyone would like to gives some feedback/testing on this review: https://review.openstack.org/#/c/197821/ … I'd be much obliged … This is the Material Design theme for Horizon | 15:40 |
| *** Daisy has quit IRC | 15:41 | |
| *** e0ne has quit IRC | 15:42 | |
| *** e0ne has joined #openstack-horizon | 15:44 | |
| *** exploreshaifali has joined #openstack-horizon | 15:44 | |
| *** garthb_ has joined #openstack-horizon | 15:44 | |
| robcresswell | hurgleburgler1: Sooo much aaawesome | 15:45 |
| robcresswell | Will add to list | 15:45 |
| hurgleburgler1 | Yay! | 15:46 |
| *** garthb has quit IRC | 15:46 | |
| *** garthb_ has quit IRC | 15:46 | |
| hurgleburgler1 | robcresswell ٩(͡๏̮͡๏)۶ Thanks! | 15:46 |
| *** garthb has joined #openstack-horizon | 15:46 | |
| *** lhcheng has joined #openstack-horizon | 15:47 | |
| *** SimonChung has joined #openstack-horizon | 15:47 | |
| *** ccesario has joined #openstack-horizon | 15:48 | |
| *** exploreshaifali has quit IRC | 15:48 | |
| *** doug-fish has quit IRC | 15:49 | |
| *** sqchen has joined #openstack-horizon | 15:49 | |
| *** doug-fish has joined #openstack-horizon | 15:49 | |
| *** SimonChung1 has joined #openstack-horizon | 15:51 | |
| *** SimonChung has quit IRC | 15:52 | |
| *** cody-somerville has joined #openstack-horizon | 15:53 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: enable_quotas=False breaks Neutron usage https://review.openstack.org/211310 | 15:53 |
| *** alejandrito has quit IRC | 15:53 | |
| *** doug-fish has quit IRC | 15:54 | |
| openstackgerrit | Michael Hagedorn proposed openstack/horizon: Neutron Quota Settings Flag Disables Neutron GUI https://review.openstack.org/210100 | 15:54 |
| *** gyee has joined #openstack-horizon | 15:54 | |
| *** vijendar has quit IRC | 15:55 | |
| *** petertr7 is now known as petertr7_away | 15:56 | |
| *** geoffarnold has joined #openstack-horizon | 16:01 | |
| *** mtanino has joined #openstack-horizon | 16:02 | |
| *** vgridnev has quit IRC | 16:02 | |
| *** doug-fish has joined #openstack-horizon | 16:05 | |
| *** markus_z has quit IRC | 16:06 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Use security group id not name in the create instance dialog https://review.openstack.org/211046 | 16:06 |
| doug-fish | pkarikh: I'm not sure there is a good formal process to report translations bugs ... I found success going into the translator's channel #openstack-i18n and whining; hopefully they can point to you the real process from there! | 16:07 |
| robcresswell | ofc, fastest way is to contribute yourself ;) | 16:07 |
| kfox1111 | david-lyle: any more comments for https://review.openstack.org/#/c/206773/ ? It seems to be kind of stuck. | 16:08 |
| *** yamamoto has joined #openstack-horizon | 16:08 | |
| *** yamamoto has quit IRC | 16:12 | |
| Mohh | david-lyle: Thanks David, the patch works. | 16:14 |
| *** aortega has joined #openstack-horizon | 16:16 | |
| *** ygbo has quit IRC | 16:18 | |
| *** mpavlase has quit IRC | 16:18 | |
| *** Mohh has quit IRC | 16:20 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Document OPENSTACK_KEYSTONE_ADMIN_ROLES https://review.openstack.org/216325 | 16:22 |
| *** liangbo has quit IRC | 16:23 | |
| *** jcoufal has joined #openstack-horizon | 16:29 | |
| *** jbell8 has quit IRC | 16:31 | |
| *** doug-fish has quit IRC | 16:31 | |
| *** doug-fish has joined #openstack-horizon | 16:31 | |
| *** rajatvig has joined #openstack-horizon | 16:39 | |
| *** lyanchih has quit IRC | 16:39 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Logo Documentation is out of date https://review.openstack.org/213473 | 16:41 |
| *** absubram has joined #openstack-horizon | 16:42 | |
| robcresswell | hurgleburgler1: Theme looks fairly good. Works fine, see no errors. But some things are odd - the responsive nav menu icon is sorta glitchy (Chrome), and the headers are massive in the workflows descriptions | 16:44 |
| hurgleburgler1 | Yes | 16:44 |
| *** kzaitsev_mb has quit IRC | 16:44 | |
| hurgleburgler1 | robcresswell : not all of horizon is themeable yet either … there are some fucky parts, but I'm gonna fix those | 16:44 |
| robcresswell | But I assume thats because of our markup | 16:44 |
| robcresswell | ya | 16:44 |
| hurgleburgler1 | as each piece becomes theme compliant, it will just fall through and look clean | 16:44 |
| robcresswell | Either way, this is a cool examples | 16:44 |
| robcresswell | example* | 16:44 |
| hurgleburgler1 | and as a drop in replacement for Blue, it already hits the ground running :) | 16:45 |
| hurgleburgler1 | I'm gonna work on making Tables, Login and Fonts theme compliant this week | 16:45 |
| robcresswell | One more question; in the local_settings, the default CUSTOM_THEME_PATH is 'static/themes/default'. Is that correct? Should it not be 'themes/default'? | 16:45 |
| hurgleburgler1 | That wrong | 16:46 |
| hurgleburgler1 | but is addressed here : https://review.openstack.org/#/c/213473/ | 16:46 |
| robcresswell | cool, great | 16:47 |
| hurgleburgler1 | Documentation, in general, got away from me a bit, :( but this review sums up everything that has changed recently | 16:47 |
| robcresswell | I haven't had chance to look yet. Is the rest of the docs up to date? Any info needed on adding new css etc? | 16:48 |
| robcresswell | Thanks for doing that btw, docs stuff helps alot even though its v boring to do. | 16:48 |
| hurgleburgler1 | There's a lot more that we can add, on how to customize things … but I think as a general stab at the current flexibility, it covers all the new stuff | 16:49 |
| hurgleburgler1 | are there docs for that other that settings.rst and customizing.rst? | 16:49 |
| robcresswell | Every time I see "izing" I want to correct it :/ | 16:50 |
| *** vgridnev has joined #openstack-horizon | 16:50 | |
| *** jtriley has quit IRC | 16:50 | |
| robcresswell | afaik those are the main places. But we may want more info around how to contribute CSS etc, not just how to change high level themes etc. | 16:50 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Cloud Service directive to check if Service is enabled https://review.openstack.org/212125 | 16:50 |
| *** liangbo has joined #openstack-horizon | 16:51 | |
| *** jbell8 has joined #openstack-horizon | 16:52 | |
| *** lhcheng has quit IRC | 16:52 | |
| *** ybathia has joined #openstack-horizon | 16:53 | |
| *** ybathia_ has joined #openstack-horizon | 16:54 | |
| *** jwy has joined #openstack-horizon | 16:56 | |
| *** romainh has left #openstack-horizon | 16:57 | |
| *** ybathia has quit IRC | 16:57 | |
| *** ybathia_ is now known as ybathia | 16:57 | |
| *** jtriley has joined #openstack-horizon | 16:57 | |
| kfox1111 | odd... is a liberty horizon incompatable with a juno keystone? | 16:58 |
| *** rdopiera has quit IRC | 16:58 | |
| kfox1111 | Its trying to contact: [Mon Aug 24 16:57:26.599634 2015] [:error] [pid 1764] Unable to establish connection to https://identity.cloud.pnnl.gov:5000/v3/auth/tokens | 16:58 |
| kfox1111 | hmm... there's an extra /auth in there for some reason... | 16:59 |
| kfox1111 | no, that was just v2... nm. | 16:59 |
| openstackgerrit | Ethan Gafford proposed openstack/horizon: [Sahara] Unified job interface map UI https://review.openstack.org/209683 | 17:00 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Moving inline html code out of action-list.spec.js https://review.openstack.org/213383 | 17:01 |
| kfox1111 | ah. looks like it was selinux. :/ | 17:04 |
| *** shivrao has joined #openstack-horizon | 17:05 | |
| robcresswell | tqtran: Can't recall if I pointed you to this already... https://review.openstack.org/#/c/216230/ | 17:05 |
| robcresswell | I think I did | 17:06 |
| openstackgerrit | Ethan Gafford proposed openstack/horizon: [Sahara] Unified job interface map UI https://review.openstack.org/209683 | 17:07 |
| *** MaxV has quit IRC | 17:08 | |
| *** doug-fish has quit IRC | 17:08 | |
| *** doug-fish has joined #openstack-horizon | 17:09 | |
| robcresswell | doug-fish: o/ | 17:10 |
| *** mpavlase has joined #openstack-horizon | 17:10 | |
| *** doug-fish has quit IRC | 17:13 | |
| *** petertr7_away is now known as petertr7 | 17:20 | |
| *** mpavlase has quit IRC | 17:20 | |
| *** aix has quit IRC | 17:20 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon: Only insert "Any Availability Zone" if there are more than one AZs. https://review.openstack.org/216345 | 17:26 |
| *** jingjing_ren has joined #openstack-horizon | 17:28 | |
| openstackgerrit | David Lyle proposed openstack/horizon: Adding missing mocks to lbaas tests https://review.openstack.org/216346 | 17:31 |
| *** lhcheng has joined #openstack-horizon | 17:31 | |
| david-lyle | Tired of noisy test console logs, and errant API calls. Then I have the patch for you. ^^^^^ | 17:32 |
| * david-lyle goes back to what he was trying to verify | 17:33 | |
| *** Sukhdev has quit IRC | 17:33 | |
| *** jtomasek has quit IRC | 17:43 | |
| *** kzaitsev_mb has joined #openstack-horizon | 17:44 | |
| *** doug-fish has joined #openstack-horizon | 17:48 | |
| *** wolverineav has joined #openstack-horizon | 17:51 | |
| *** jcoufal has quit IRC | 17:52 | |
| *** Sukhdev has joined #openstack-horizon | 17:52 | |
| *** Ephur has joined #openstack-horizon | 17:53 | |
| *** Ephur has quit IRC | 17:54 | |
| *** pkarikh_ has joined #openstack-horizon | 17:55 | |
| *** jprovazn has quit IRC | 17:55 | |
| *** tqtran has joined #openstack-horizon | 18:01 | |
| *** TravT has quit IRC | 18:03 | |
| *** Sukhdev has quit IRC | 18:03 | |
| *** vgridnev has quit IRC | 18:10 | |
| *** TravT has joined #openstack-horizon | 18:10 | |
| *** saksham has joined #openstack-horizon | 18:11 | |
| kfox1111 | tqtran: get a chance yet to reviewhttps://review.openstack.org/#/c/206773/ ? | 18:18 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Moving translation to HTML for launch-instance flavor step https://review.openstack.org/215792 | 18:18 |
| kfox1111 | I'm trying to get the app catalog plugin into rdo, but their horizon's based on trunk, which doesn't have the fixes. :/ | 18:18 |
| *** bapalm- is now known as bapalm_ | 18:19 | |
| *** Drago has quit IRC | 18:19 | |
| *** ybathia has quit IRC | 18:19 | |
| tqtran | ok, i'll take a look at in after the one i'm currently reviewing | 18:19 |
| kfox1111 | thanks. | 18:20 |
| *** jtriley has quit IRC | 18:22 | |
| *** vgridnev has joined #openstack-horizon | 18:22 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel https://review.openstack.org/206203 | 18:22 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 18:22 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: API Services for Flavors Panel https://review.openstack.org/214896 | 18:22 |
| rajatvig | Can the patches https://review.openstack.org/#/c/214057/ and https://review.openstack.org/#/c/211741/ be reviewed? Currently eslint does not run on javascripts inside openstack_dashboard/dashboard/*/static. | 18:25 |
| rajatvig | the patches fix existing violations and future based of new eslint rules based off changes from https://review.openstack.org/#/c/213818/ | 18:26 |
| *** jtriley has joined #openstack-horizon | 18:28 | |
| *** liangbo has quit IRC | 18:30 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Use the JP Style Guide for OpenStack Services https://review.openstack.org/212838 | 18:31 |
| *** vijendar has joined #openstack-horizon | 18:31 | |
| *** Drago has joined #openstack-horizon | 18:35 | |
| *** Drago has quit IRC | 18:35 | |
| *** Drago has joined #openstack-horizon | 18:36 | |
| *** absubram has quit IRC | 18:36 | |
| *** exploreshaifali has joined #openstack-horizon | 18:36 | |
| *** rajatvig has quit IRC | 18:41 | |
| *** mrunge has joined #openstack-horizon | 18:43 | |
| *** Mzoorikh has joined #openstack-horizon | 18:47 | |
| Mzoorikh | Hi. I wrote a tenant-delete test case, but I can't delete the project: test_tenant | 18:48 |
| Mzoorikh | This error occured: 'Unable to delete project: test_tenant' | 18:48 |
| *** rajatvig has joined #openstack-horizon | 18:49 | |
| Mzoorikh | Is there anybody know why? | 18:49 |
| kfox1111 | ever seen this one? its with a trunk rdo build... Error: [$injector:modulerr] Failed to instantiate module horizon.app due to: | 18:49 |
| *** geoffarnold is now known as geoffarnoldX | 18:49 | |
| *** geoffarnoldX is now known as geoffarnold | 18:49 | |
| kfox1111 | [$injector:modulerr] Failed to instantiate module horizon.auth due to: | 18:49 |
| kfox1111 | [$injector:nomod] Module 'horizon.auth' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. | 18:49 |
| *** ttrifonov is now known as zz_ttrifonov | 18:49 | |
| ducttape_ | kfox1111 - I've seen that | 18:49 |
| mrunge | Mzoorikh, without seeing a bit more context, it's probably impossible to tell what you're talking about | 18:49 |
| ducttape_ | it's like my top 5 favorite bugs, for sure kfox1111 | 18:50 |
| kfox1111 | know a fix? :) | 18:50 |
| mrunge | that should be in trunk as well | 18:50 |
| mrunge | trunk rdo build is built from github at each commit in horizon | 18:51 |
| ducttape_ | yep, for me that happens when the code base and the settings are out of wack / do not match. and I also need to re-run collectstatic and compressor | 18:51 |
| ducttape_ | usually the settings and even the static settings util stuff are giving you problems kfox1111 | 18:51 |
| kfox1111 | I thought the latter happened at http restart via the systemctl hooks. | 18:51 |
| mrunge | hmm, collectstatic and compress is run at httpd restart | 18:52 |
| mrunge | yepp | 18:52 |
| kfox1111 | k. so I need to figure out why the local_settings are too old? | 18:52 |
| ducttape_ | ok. then check your settings and the static settings specifically | 18:52 |
| ducttape_ | yep | 18:52 |
| ducttape_ | or too new - maybe a bug was added recently ;) that situation has caused me to loose a couple of days (if that makes you feel any better) | 18:53 |
| mrunge | this is called on httpd restart /usr/lib/systemd/system/httpd.service.d/openstack-dashboard.conf | 18:53 |
| Mzoorikh | mrunge: I want to delete 'test_tenant' project in my test case with the following line of codes: form_data = {'action': 'tenants__delete__%s' % project_id} res = self.client.post(INDEX_URL, form_data, follow=True) | 18:53 |
| Mzoorikh | mrunge: But the res object contains the error message: Unable to delete project: test_tenant. | 18:53 |
| *** jingjing_ren has quit IRC | 18:53 | |
| mrunge | Mzoorikh, yes, that's what you wrote earlier before | 18:54 |
| Mzoorikh | mrunge: exactly. But that was worked before. | 18:54 |
| mrunge | Mzoorikh, you're surely mocking api calls, don't you? | 18:55 |
| Mzoorikh | mrunge: Yeah I did. http://www.pastebin.ca/3126875 | 18:58 |
| kfox1111 | ducttape_: both settings look about right. :/ | 19:02 |
| ducttape_ | kfox1111 : after that, I had to turn off compression on two machines, and compare what libraries where not being included... I think I tracked it down to something related to HORIZON[static something or rather] for my case | 19:03 |
| ducttape_ | but I had one machine working, and the other not so much | 19:03 |
| kfox1111 | k. | 19:04 |
| kfox1111 | I did see they tried to move stuff into /dashboard/static, but don't think they fully got there... | 19:04 |
| *** e0ne has quit IRC | 19:04 | |
| Mzoorikh | mrunge: Did you see my API call mocks? http://www.pastebin.ca/3126875 | 19:08 |
| openstackgerrit | Vitaly Gridnev proposed openstack/horizon: [Sahara] Add missing job type in libs selection https://review.openstack.org/216384 | 19:10 |
| tqtran | ducttape_, r1chardj0n3s, david-lyle: question for you guys, should I use POST or GET for resource validation or permission? | 19:10 |
| tqtran | according to HTTP spec, POST should only be use for creating something new, but in policy, we use POST to ask whether some rules are allowed. | 19:11 |
| tqtran | kfox1111's patch uses GET to validation a heat template. not sure what the norm should be? | 19:12 |
| ducttape_ | hmm.... not sure. the other think could be to use a head call for a quick check? | 19:12 |
| ducttape_ | think/thing | 19:13 |
| ducttape_ | tqtran - so this is purely for policy checks such as "can I create or list users?" | 19:14 |
| tqtran | well, im asking for a more general approach, what is the correct pattern we should be using when it comes to just checking or validating something. | 19:15 |
| ducttape_ | yep. understood. I agree that doing a POST feels akward for this type of use case. | 19:16 |
| tqtran | i personally prefer POST but I can understand why someone would use GET instead. but we should be consistent, so just asking for 2nd opinions | 19:16 |
| ducttape_ | david-lyle you at keyboard ? | 19:16 |
| kfox1111 | tqtran: yeah. its borderline. it shouldn't cause side affects, so get seems like its reasonable, but it can take a while, so post may be better? | 19:17 |
| kfox1111 | I could go either way. :/ | 19:17 |
| ducttape_ | it would be interesting (to me) to have http headers on resources, describing permissions. so you'd call /api/users and the http headers would say "you have permission to do x/y/z" | 19:17 |
| ducttape_ | we always have CRUD, plus list | 19:18 |
| kfox1111 | or maybe a HEAD like thing... | 19:18 |
| kfox1111 | tqtran: a thought... maybe we should just see what heat does? | 19:20 |
| kfox1111 | They have it as POST. | 19:20 |
| kfox1111 | seems like a good thing to copy then. | 19:20 |
| tqtran | ok lets go with POST then | 19:21 |
| kfox1111 | k. | 19:21 |
| tqtran | just wanted to be consistent :P | 19:21 |
| kfox1111 | yeah. | 19:21 |
| ducttape_ | I like HEAD calls for this, but consistency would win for me too | 19:22 |
| kfox1111 | if the rest stuff is supposed to be just a wraper around the real services rest, then POST is probably best. | 19:23 |
| ducttape_ | this is something else though.... this is horizon doing a policy check, and returning the results of that call (if I understand this correctly). | 19:23 |
| ducttape_ | i.e. no additional network calls | 19:24 |
| tqtran | right | 19:24 |
| tqtran | but in kfox1111's case, he is using heat to validate | 19:24 |
| ducttape_ | but if heat does something like this, then consistency is better than idealism ;) | 19:24 |
| tqtran | so that is slightly different.... | 19:24 |
| *** petertr7 is now known as petertr7_away | 19:25 | |
| tqtran | kfox1111: let me finish reviewing it before you go off and update the patch :P | 19:25 |
| kfox1111 | k. :) | 19:25 |
| tqtran | we can save the gate a few cycles | 19:26 |
| kfox1111 | thanks for reviewing. | 19:26 |
| tqtran | np | 19:26 |
| *** petertr7_away is now known as petertr7 | 19:29 | |
| doug-fish | tsufiev: are you still around? | 19:30 |
| *** jwy has quit IRC | 19:30 | |
| *** jingjing_ren has joined #openstack-horizon | 19:31 | |
| david-lyle | ducttape_: here | 19:32 |
| kfox1111 | thats... unfortunate... | 19:33 |
| kfox1111 | doesn't look like /home/kfox2/svn/horizon-app-catalog7/openstack_dashboard/test/helpers.py handles POSTS? | 19:33 |
| david-lyle | what are we posting? | 19:33 |
| kfox1111 | david-lyle: https://review.openstack.org/#/c/206773/ | 19:34 |
| kfox1111 | in the heat rest api, we just decided it should be POST not GET. | 19:34 |
| ducttape_ | david-lyle - if we want a js / rest call to determine policy results..... how should that be done? | 19:34 |
| david-lyle | why is that a post? | 19:35 |
| ducttape_ | that was / is question orig from tqtran | 19:35 |
| kfox1111 | david-lyle: cause its a post in Heat. | 19:35 |
| ducttape_ | because heat did it first ;) | 19:35 |
| david-lyle | oh, not a policy check | 19:35 |
| kfox1111 | we figured it was probably best to be consistant? | 19:35 |
| tqtran | even the REST policy check is a POST | 19:36 |
| david-lyle | in that case, makes sense | 19:36 |
| ducttape_ | the preference in the room was (I think) a HTTP HEAD call would be nice, but consistency with some other pattern is even better | 19:36 |
| ducttape_ | but if that post pattern is only within horizon and heat.... I think we might want to not pay as much attention to this precendence | 19:36 |
| david-lyle | tqtran: it is? what dumb dodo wrote that? | 19:37 |
| tqtran | *cough cough* some old fella | 19:37 |
| * david-lyle knows it was him | 19:37 | |
| kfox1111 | hmm.. nova_rest_tests.py does a post... so can probably adapt that code... | 19:37 |
| ducttape_ | so if dave orig wrote it, then it's probably wrong and a terrible idea | 19:37 |
| tqtran | lol | 19:37 |
| david-lyle | tqtran: I meant to revisit it, now I have another reason | 19:38 |
| * ducttape_ realizes he will see no more merges | 19:38 | |
| tqtran | originally i thought POST was ok, but then i realized i was confusing form POST vs rest POST | 19:38 |
| Mzoorikh | mrunge: Are you there? | 19:39 |
| kfox1111 | hm... yea... that probably will change this code a bit. :_( | 19:39 |
| mrunge | Mzoorikh, no | 19:39 |
| Mzoorikh | mrunge: OK | 19:39 |
| *** Ephur has joined #openstack-horizon | 19:46 | |
| *** shivrao has quit IRC | 19:47 | |
| mrunge | Mzoorikh, sorry, I'm still quite busy :( | 19:48 |
| *** zul has quit IRC | 19:49 | |
| *** sayan has quit IRC | 19:49 | |
| *** ZZelle has joined #openstack-horizon | 19:49 | |
| *** ZZelle is now known as ZZll-off | 19:49 | |
| Mzoorikh | mrunge: No worries. I am waiting, and working to get rid of the error by my own! | 19:49 |
| *** ducttape_ has quit IRC | 19:52 | |
| *** jwy has joined #openstack-horizon | 19:52 | |
| *** exploreshaifali has quit IRC | 19:53 | |
| *** sqchen has quit IRC | 19:55 | |
| *** shivrao has joined #openstack-horizon | 19:57 | |
| *** sqchen has joined #openstack-horizon | 19:58 | |
| *** exploreshaifali has joined #openstack-horizon | 20:04 | |
| kfox1111 | is there any way to make mock more verbose? | 20:05 |
| kfox1111 | I'm shooting a bit blind here. :/ | 20:05 |
| *** ducttape_ has joined #openstack-horizon | 20:05 | |
| kfox1111 | tqtran: other then the POST/GET thing, how does the rest of the patch look? | 20:06 |
| *** mrunge has quit IRC | 20:10 | |
| *** ericpeterson has joined #openstack-horizon | 20:12 | |
| *** exploreshaifali has quit IRC | 20:13 | |
| *** ducttape_ has quit IRC | 20:15 | |
| tqtran | kfox1111: still reviewing it :P | 20:15 |
| kfox1111 | k. thanks. | 20:15 |
| tqtran | ok done with the review, take a moment to read and let me know what you think | 20:18 |
| kfox1111 | so you want me to patch the forms in the plugin? | 20:20 |
| kfox1111 | tqtran: I was hoping to merge before cloudbase goes away since it seemed much farther along. Is that the case? | 20:21 |
| *** absubram has joined #openstack-horizon | 20:21 | |
| tqtran | if by patching forms, you mean moving the get_initial blocks then yes | 20:21 |
| kfox1111 | that makes the plugin specific to a horizon's internals. | 20:23 |
| tqtran | yes, cloud services is going to get replace, so a rebase on top of that would be ideal | 20:23 |
| kfox1111 | that I really want to avoid. :/ | 20:23 |
| tqtran | the thing is, we're not using that piece anywhere else in trunk, so its just kind of sitting there | 20:23 |
| kfox1111 | I could just drop out the change to the file entirely. it would merge today, then get deleted when the other patch merges. | 20:23 |
| kfox1111 | I'm sure the murano folks would use it too. | 20:24 |
| kfox1111 | or anyone else writing a plugin to pop up the dialogs. | 20:24 |
| tqtran | right, which is why i think the nested dialog deserves its own patch, that part i can understand | 20:24 |
| kfox1111 | yeah, but just poping up a dialog without filling any bits in is not very useful. | 20:25 |
| tqtran | but the get_initial block and additions to image-form-controller is less clear | 20:25 |
| *** Sukhdev has joined #openstack-horizon | 20:25 | |
| kfox1111 | the thing is, you can pop up the dialog, and set some of the stuff via ajax-modal and form vars, but not some others. | 20:25 |
| *** ducttape_ has joined #openstack-horizon | 20:26 | |
| kfox1111 | the ones that you cant have the fix in for. that makes them all setable. | 20:26 |
| kfox1111 | is that not a bug? | 20:26 |
| *** ericpeterson has quit IRC | 20:26 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 20:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Run ESLint on Javascript files in dashboards https://review.openstack.org/214057 | 20:26 |
| david-lyle | kfox1111: so the heat views piece is so you can have a template already selected? | 20:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 20:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: JSCS Cleanup - use DI in launch instance model https://review.openstack.org/211741 | 20:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 20:26 |
| kfox1111 | david-lyle: exactly. same with te glance image create patch. | 20:27 |
| kfox1111 | so I can pass the ui a heat template to launch with, and the glance image a url to import, name, etc. | 20:27 |
| kfox1111 | I just take the stuff in the app catalog and pass it to the horizon dialog when asked by the user. | 20:28 |
| david-lyle | kfox1111: why do I want to land on the select template and not the next step? | 20:28 |
| kfox1111 | because you might want to customize the environment. | 20:28 |
| david-lyle | that's what I was wondering, but in the app-catalog case? | 20:29 |
| david-lyle | probably | 20:29 |
| kfox1111 | yeah. I didn't want to exclude the case. In the future, we can maybe add more metadata into the catalog to allow skipping for certain items. | 20:30 |
| david-lyle | I think that could be generally useful | 20:30 |
| kfox1111 | basically the dialogs are just the handoff point between the app catalog plugin and horizon. | 20:31 |
| *** rajatvig has quit IRC | 20:31 | |
| david-lyle | why not just go ahead and create the image? | 20:31 |
| *** rajatvig has joined #openstack-horizon | 20:31 | |
| david-lyle | seems like almost everything is passed in | 20:31 |
| david-lyle | the public and protected? | 20:31 |
| kfox1111 | the user can further customize the import, such as setting the public flag, changing the default sizes, etc. | 20:32 |
| kfox1111 | protected, yeah. | 20:32 |
| kfox1111 | plus there is no restapi for image creation yet. ;) | 20:32 |
| kfox1111 | I figured I'ld try and write that for M... | 20:32 |
| kfox1111 | just trying to get very basic but functional app catalog in L. | 20:32 |
| *** jerrygb has joined #openstack-horizon | 20:33 | |
| david-lyle | right and I think tqtran and I are just trying to verifywe're not just merging one offs to allow that | 20:33 |
| david-lyle | being able to seed a form is generally useful | 20:34 |
| kfox1111 | ah. | 20:34 |
| *** jerrygb is now known as test0rz | 20:34 | |
| *** test0rz is now known as asd112z | 20:34 | |
| kfox1111 | yeah. its something that use to work, up until some of the angular stuff kicked in. | 20:34 |
| david-lyle | the image controller part | 20:36 |
| kfox1111 | yeah. | 20:36 |
| david-lyle | because you aren't triggering selectImageFormat? | 20:39 |
| david-lyle | seems rather selective for just the two fields | 20:39 |
| david-lyle | because the others are already set? | 20:39 |
| kfox1111 | the rest of the fields were being copied ok. Somethign to do with the angularness on them. | 20:40 |
| david-lyle | that's a sweet mess | 20:40 |
| kfox1111 | yeah. :/ | 20:40 |
| david-lyle | but if you have two initialization methods, you don't have much choice | 20:40 |
| * kfox1111 nods. | 20:40 | |
| kfox1111 | should be better once everything's totally angular. | 20:41 |
| * david-lyle hears judy garland singing | 20:41 | |
| *** petertr7 is now known as petertr7_away | 20:42 | |
| kfox1111 | arg... this get->post thing is a real pain. :/ | 20:42 |
| kfox1111 | I need to spend a week and just sit down with mock and better understand it. | 20:42 |
| robcresswell | And then try and explain to your boss what you did this week :( | 20:43 |
| kfox1111 | yeah. :( | 20:43 |
| david-lyle | ok, I'm good with the initialization code | 20:44 |
| kfox1111 | k. thanks. | 20:45 |
| david-lyle | the modal changes scare me quite a bit | 20:45 |
| david-lyle | I have to walk through that a bunch, that code is quite fragile, IIRC | 20:46 |
| *** rajatvig has quit IRC | 20:46 | |
| kfox1111 | heh. yeah, scared me too when I saw it doing global css selection before my change. :/ | 20:46 |
| david-lyle | it | 20:46 |
| david-lyle | it's a mess | 20:46 |
| kfox1111 | yeah. | 20:46 |
| david-lyle | someone once tried to fix it, and bailed | 20:47 |
| david-lyle | large patchset | 20:47 |
| kfox1111 | I think the last line in the change isn't needed after the moving of the parent. | 20:47 |
| kfox1111 | since it moves it to :last anyway. | 20:47 |
| kfox1111 | It too should get much better once angularized. | 20:47 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add API services for system information https://review.openstack.org/205196 | 20:48 |
| robcresswell | I had a thought. How does theming work with all the inline widget scss? | 20:48 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular system information panel https://review.openstack.org/204731 | 20:48 |
| kfox1111 | without moving the parent, the other line's required to fix the js it breaks when calling modal.modal() on. | 20:48 |
| david-lyle | but there's a whole pop side too | 20:49 |
| david-lyle | not saying what you have is wrong, I just need more time to evaluate it | 20:50 |
| *** shivrao has quit IRC | 20:51 | |
| kfox1111 | sure. | 20:52 |
| *** jwy has quit IRC | 20:53 | |
| Mzoorikh | It seems utils.logout_with_message() function is not worked in tests? it it? | 20:54 |
| *** pkarikh_ has quit IRC | 20:57 | |
| *** shivrao has joined #openstack-horizon | 20:58 | |
| *** DWfuturetec has quit IRC | 20:59 | |
| *** rajatvig has joined #openstack-horizon | 20:59 | |
| *** jbell8 has quit IRC | 21:01 | |
| *** jingjing_ren has quit IRC | 21:03 | |
| *** lblanchard has quit IRC | 21:11 | |
| *** jbell8 has joined #openstack-horizon | 21:12 | |
| kfox1111 | david-lyle: should the patch be broken up? | 21:13 |
| kfox1111 | I'm ok doing that. just worried it will delay the review a lot more. | 21:14 |
| *** jingjing_ren has joined #openstack-horizon | 21:14 | |
| tqtran | i think it would actually make it easier to review :P | 21:17 |
| kfox1111 | ok. I'll split it then. | 21:17 |
| *** DWfuturetec has joined #openstack-horizon | 21:17 | |
| kfox1111 | about half the files are the new heat rest api. | 21:17 |
| kfox1111 | should I just split it to heat and non heat? | 21:17 |
| *** jwy has joined #openstack-horizon | 21:18 | |
| tqtran | yeah that would make sense | 21:19 |
| tqtran | you can chain them if you want, to show that one depends on another | 21:20 |
| *** Piet has joined #openstack-horizon | 21:20 | |
| kfox1111 | ok. sounds good. | 21:20 |
| kfox1111 | really, the validate one's icing. so I'll do that one last. The plugin can be quickly adapted to work without it. | 21:21 |
| *** jcoufal has joined #openstack-horizon | 21:21 | |
| kfox1111 | the rest are really critical to make it work. | 21:21 |
| *** absubram has quit IRC | 21:23 | |
| *** rajatvig has quit IRC | 21:23 | |
| kfox1111 | what about the rebase on https://review.openstack.org/#/c/179516/? I'm trying to merge quickly, and I keep getting new things to rebase on. | 21:24 |
| kfox1111 | should I just not make any changes to cloud-services.service.js | 21:25 |
| kfox1111 | and when the other merge happens, the file just gets dropped? | 21:25 |
| kfox1111 | I only patched it since there were other api entries there. I don't belive I actually use it. | 21:25 |
| *** crobertsrh is now known as _crobertsrh | 21:26 | |
| r1chardj0n3s | morning | 21:28 |
| *** jtriley has quit IRC | 21:31 | |
| hurgleburgler1 | r1chardj0n3s morning | 21:31 |
| *** rajatvig has joined #openstack-horizon | 21:33 | |
| *** rajatvig has quit IRC | 21:39 | |
| tqtran | kfox1111: i think that will be fine, you can just leave cloud-services.js out of your patch to avoid the rebase | 21:39 |
| kfox1111 | ok. thanks. | 21:39 |
| kfox1111 | there we go... got get->post fixed up. now to split the patch. | 21:40 |
| *** geoffarnold has quit IRC | 21:41 | |
| *** Piet has quit IRC | 21:42 | |
| *** Mzoorikh has quit IRC | 21:44 | |
| *** andersonvom has joined #openstack-horizon | 21:55 | |
| *** mwhagedorn has quit IRC | 21:56 | |
| *** pauloewerton has quit IRC | 21:56 | |
| andersonvom | hey folks, do we have a tag or some sort of way to track low-hanging-fruit bugs on launchpad that I could use to locate easy-to-fix bugs for newcomers? | 21:56 |
| andersonvom | nevermind, we do. for whatever reason I totally missed that | 21:58 |
| tqtran | andersonvom: haha just about to say that, cool, welcome to the community! | 21:59 |
| *** neelashah has quit IRC | 21:59 | |
| *** vgridnev has quit IRC | 21:59 | |
| *** tqtran is now known as tqtran-afk | 21:59 | |
| *** ybathia has joined #openstack-horizon | 22:00 | |
| *** ybathia has quit IRC | 22:00 | |
| *** ybathia has joined #openstack-horizon | 22:00 | |
| *** mwhagedorn has joined #openstack-horizon | 22:02 | |
| andersonvom | tqtran: thanks! :D too bad the list of easy bugs is pretty much taken already! ;) | 22:02 |
| *** rajatvig has joined #openstack-horizon | 22:03 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few fixes to make the App Catalog plugin work. https://review.openstack.org/206773 | 22:04 |
| *** mwhagedorn has joined #openstack-horizon | 22:05 | |
| *** rajatvig has quit IRC | 22:07 | |
| openstackgerrit | Kirill Zaitsev proposed openstack/django_openstack_auth: Use set comprehension instead of converting lists to sets https://review.openstack.org/216441 | 22:08 |
| *** rajatvig has joined #openstack-horizon | 22:08 | |
| *** aortega_ has joined #openstack-horizon | 22:12 | |
| *** aortega has quit IRC | 22:12 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: Javascript Heat API https://review.openstack.org/216443 | 22:14 |
| kfox1111 | tqtran: split. | 22:15 |
| *** vijendar has quit IRC | 22:16 | |
| *** rajatvig has quit IRC | 22:18 | |
| kzaitsev_mb | kfox1111: care to update the 1st patch 1st line, to make it a bit more informative? =) | 22:18 |
| kzaitsev_mb | while you're still at it, and it haven't got much reviews, I mean ) | 22:18 |
| kfox1111 | yeah, sure. suggestions? ;) | 22:19 |
| *** akrivoka has quit IRC | 22:19 | |
| *** akrivoka has joined #openstack-horizon | 22:20 | |
| kzaitsev_mb | Something like "Allow passing params to form stack/image dialogs" ? | 22:21 |
| kfox1111 | How about: | 22:25 |
| kfox1111 | This fixes passing params to stack and image creation form dialogs. | 22:25 |
| kfox1111 | It also fixes a bug with nested dialogs. | 22:25 |
| *** aortega_ has quit IRC | 22:25 | |
| *** Sukhdev has quit IRC | 22:25 | |
| *** rajatvig has joined #openstack-horizon | 22:25 | |
| *** asd112z has quit IRC | 22:25 | |
| kzaitsev_mb | yep, why not ) | 22:26 |
| *** mpavlase has joined #openstack-horizon | 22:26 | |
| openstackgerrit | Kevin Fox proposed openstack/horizon: A few fixes to make the App Catalog plugin work. https://review.openstack.org/206773 | 22:26 |
| kfox1111 | done. thanks. :) | 22:26 |
| *** akrivoka has quit IRC | 22:28 | |
| *** jcoufal has quit IRC | 22:32 | |
| *** doug-fish has quit IRC | 22:34 | |
| *** doug-fish has joined #openstack-horizon | 22:34 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: API Services for Flavors Panel https://review.openstack.org/214896 | 22:35 |
| *** jpomeroy has quit IRC | 22:36 | |
| *** doug-fis_ has joined #openstack-horizon | 22:37 | |
| *** geoffarnold has joined #openstack-horizon | 22:38 | |
| *** doug-fish has quit IRC | 22:38 | |
| *** tsufiev has quit IRC | 22:41 | |
| *** doug-fish has joined #openstack-horizon | 22:41 | |
| *** kzaitsev_ws has quit IRC | 22:41 | |
| *** doug-fis_ has quit IRC | 22:42 | |
| *** geoffarnold has quit IRC | 22:42 | |
| *** kzaitsev_ws has joined #openstack-horizon | 22:42 | |
| *** nullvariable has quit IRC | 22:42 | |
| *** geoffarnold has joined #openstack-horizon | 22:45 | |
| *** doug-fish has quit IRC | 22:46 | |
| *** tsufiev has joined #openstack-horizon | 22:46 | |
| *** rajatvig has quit IRC | 22:47 | |
| *** tosky has quit IRC | 22:49 | |
| *** vgridnev has joined #openstack-horizon | 22:50 | |
| *** mpavlase has quit IRC | 22:50 | |
| *** tosky has joined #openstack-horizon | 22:50 | |
| *** tosky has quit IRC | 22:51 | |
| *** vgridnev has quit IRC | 22:52 | |
| *** tosky has joined #openstack-horizon | 22:53 | |
| *** tosky has quit IRC | 22:55 | |
| *** tosky has joined #openstack-horizon | 22:57 | |
| *** rajatvig has joined #openstack-horizon | 22:57 | |
| *** Drago has quit IRC | 22:57 | |
| *** tosky has quit IRC | 22:58 | |
| *** tosky has joined #openstack-horizon | 23:00 | |
| *** tosky has quit IRC | 23:01 | |
| *** ducttape_ has quit IRC | 23:05 | |
| *** mwhagedorn has quit IRC | 23:06 | |
| *** rajatvig has quit IRC | 23:08 | |
| *** kzaitsev_mb has quit IRC | 23:10 | |
| *** ccesario has quit IRC | 23:13 | |
| *** rajatvig has joined #openstack-horizon | 23:15 | |
| *** rajatvig has quit IRC | 23:19 | |
| *** Ephur has quit IRC | 23:22 | |
| *** ccesario has joined #openstack-horizon | 23:26 | |
| *** doug-fish has joined #openstack-horizon | 23:34 | |
| *** EmilienM has quit IRC | 23:34 | |
| *** NightKhaos has quit IRC | 23:35 | |
| *** saksham has quit IRC | 23:35 | |
| *** rajatvig has joined #openstack-horizon | 23:35 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:36 | |
| *** EmilienM has joined #openstack-horizon | 23:36 | |
| *** dsneddon is now known as dsneddon_away | 23:36 | |
| *** wolverineav has quit IRC | 23:38 | |
| *** DuncanT has quit IRC | 23:38 | |
| *** doug-fish has quit IRC | 23:38 | |
| *** wolverineav has joined #openstack-horizon | 23:38 | |
| *** DuncanT has joined #openstack-horizon | 23:39 | |
| kfox1111 | is there a reason wait condition's timeout tops out at 43200? | 23:40 |
| *** NightKhaos has joined #openstack-horizon | 23:42 | |
| *** morganfainberg is now known as morgan | 23:42 | |
| kfox1111 | oh. did the math a little wrong. 43200 is 12 hours. | 23:42 |
| kfox1111 | that should be ok. | 23:42 |
| *** DWfuturetec has quit IRC | 23:42 | |
| *** garthb has quit IRC | 23:45 | |
| *** jtriley has joined #openstack-horizon | 23:46 | |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: Add angular flavors panel subflows https://review.openstack.org/214294 | 23:46 |
| openstackgerrit | KBrown proposed openstack/horizon: WIP: API Services for Flavors Panel https://review.openstack.org/214896 | 23:46 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Create a Angular Modules for Admin Dashboard https://review.openstack.org/214779 | 23:47 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : API for Metadata Definitions https://review.openstack.org/215721 | 23:47 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 23:47 |
| *** jingjing_ren has quit IRC | 23:48 | |
| *** mwhagedorn has joined #openstack-horizon | 23:49 | |
| *** rajatvig has quit IRC | 23:50 | |
| *** mwhagedorn has quit IRC | 23:51 | |
| *** jcoufal has joined #openstack-horizon | 23:57 | |
| kfox1111 | tqtran-afk: Thanks. :) | 23:58 |
| *** tqtran-afk is now known as tqtran | 23:58 | |
| tqtran | np | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!