Tuesday, 2015-11-24

*** pumaranikar has joined #openstack-horizon00:00
*** SimonChung1 has quit IRC00:04
*** lhcheng has quit IRC00:07
*** jwy has joined #openstack-horizon00:11
*** pumaranikar has quit IRC00:13
*** jtriley has quit IRC00:14
*** openstackgerrit has quit IRC00:16
*** openstackgerrit has joined #openstack-horizon00:16
*** jtriley has joined #openstack-horizon00:20
*** jtriley has quit IRC00:25
*** rebase has quit IRC00:39
*** jtriley has joined #openstack-horizon00:43
*** bpokorny has quit IRC00:44
openstackgerritMerged openstack/horizon: Split instance details and source in Launch Instance wizard.  https://review.openstack.org/23500400:47
*** bpokorny has joined #openstack-horizon00:51
*** jtriley has quit IRC00:56
*** kyleolivo has quit IRC00:57
*** errolpais has joined #openstack-horizon00:58
*** aortega has quit IRC00:59
*** yamamoto has joined #openstack-horizon01:02
openstackgerritMerged openstack/horizon: Handle glanceclient CommunicationError in horizon  https://review.openstack.org/24773201:03
*** neelashah has joined #openstack-horizon01:06
*** neelashah1 has quit IRC01:07
*** yamamoto has quit IRC01:07
*** jerrygb has quit IRC01:09
*** neelashah1 has joined #openstack-horizon01:09
*** jerrygb has joined #openstack-horizon01:10
openstackgerritzhengyue proposed openstack/horizon: Fix bug at update quota of project's network item  https://review.openstack.org/24049301:10
*** neelashah has quit IRC01:10
*** errolpais has quit IRC01:12
*** jerrygb has quit IRC01:14
*** jhesketh has joined #openstack-horizon01:15
*** rebase has joined #openstack-horizon01:15
*** alexvictorchan has quit IRC01:16
*** jhesketh has quit IRC01:16
*** sambetts-afk has quit IRC01:18
*** jingjing_ren has quit IRC01:29
openstackgerritCindy Lu proposed openstack/horizon: Launch Instance Wizard - Avail items count doesn't update  https://review.openstack.org/24669801:29
*** clu_ has quit IRC01:29
openstackgerritCindy Lu proposed openstack/horizon: Launch Instance Wizard - Avail items count doesn't update  https://review.openstack.org/24669801:34
*** hurgleburgler has quit IRC01:34
*** shu has quit IRC01:37
*** shu-mutou has joined #openstack-horizon01:37
*** zhenguo has joined #openstack-horizon01:38
*** julim has joined #openstack-horizon01:43
openstackgerritCindy Lu proposed openstack/horizon: Launch Instance Wizard - Avail items count doesn't update  https://review.openstack.org/24669801:44
*** kzaitsev_mb has quit IRC01:45
*** zhurong has joined #openstack-horizon01:52
*** SimonChung has joined #openstack-horizon01:55
*** kzaitsev_mb has joined #openstack-horizon01:56
*** jbell8 has joined #openstack-horizon01:56
*** SimonChung1 has joined #openstack-horizon01:57
*** jhesketh has joined #openstack-horizon01:58
*** jingjing_ren has joined #openstack-horizon02:00
*** SimonChung has quit IRC02:00
*** jhesketh has quit IRC02:03
*** sahilsinha has joined #openstack-horizon02:04
*** jingjing_ren has quit IRC02:06
*** jhesketh has joined #openstack-horizon02:06
sahilsinhahas anyone set up horizon with websso/open id connect?02:08
*** wolverineav has joined #openstack-horizon02:08
*** ducttape_ has joined #openstack-horizon02:09
*** amotoki has joined #openstack-horizon02:13
*** kzaitsev_mb has quit IRC02:15
*** yamamoto has joined #openstack-horizon02:17
*** jwy has quit IRC02:18
*** yamamoto has quit IRC02:21
*** btully has quit IRC02:28
*** david-ly_ has quit IRC02:36
*** neillc_away is now known as neillc02:36
*** wolverineav has quit IRC02:43
*** jerrygb has joined #openstack-horizon02:44
*** wolverineav has joined #openstack-horizon02:46
*** ducttape_ has quit IRC02:48
*** jtriley has joined #openstack-horizon02:52
*** ducttape_ has joined #openstack-horizon02:53
*** mohankumar_ has joined #openstack-horizon02:56
*** rebase has quit IRC02:56
*** jtriley has quit IRC02:57
*** wolverineav has quit IRC03:03
*** wolverineav has joined #openstack-horizon03:03
*** yamamoto has joined #openstack-horizon03:04
*** ducttape_ has quit IRC03:06
*** neelashah1 has quit IRC03:07
*** neelashah has joined #openstack-horizon03:08
*** jerrygb has quit IRC03:11
*** neelashah1 has joined #openstack-horizon03:11
*** neelashah has quit IRC03:12
*** jerrygb has joined #openstack-horizon03:13
*** ducttape_ has joined #openstack-horizon03:19
*** wolverineav has quit IRC03:19
*** errolpais has joined #openstack-horizon03:22
*** mohankumar_ has quit IRC03:23
*** pcaruana has quit IRC03:27
*** mohankumar_ has joined #openstack-horizon03:29
*** ccard__ has joined #openstack-horizon03:31
*** errolpais has quit IRC03:33
*** ccard_ has quit IRC03:34
*** errolpais has joined #openstack-horizon03:39
*** SurajD has joined #openstack-horizon03:43
*** ducttape_ has quit IRC03:44
*** ducttape_ has joined #openstack-horizon03:49
*** ducttape_ has quit IRC03:50
*** jbell8 has quit IRC03:54
*** KingKhan has joined #openstack-horizon03:57
*** btully has joined #openstack-horizon03:59
*** btully has quit IRC04:03
*** bpokorny has quit IRC04:06
*** david-lyle has joined #openstack-horizon04:08
*** ChanServ sets mode: +o david-lyle04:08
*** mohankumar_ has quit IRC04:09
*** sahilsinha has quit IRC04:17
*** ducttape_ has joined #openstack-horizon04:19
*** jerrygb has quit IRC04:24
*** ducttape_ has quit IRC04:24
*** btully has joined #openstack-horizon04:29
*** ducttape_ has joined #openstack-horizon04:36
*** jtriley has joined #openstack-horizon04:52
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854604:57
*** jtriley has quit IRC04:59
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854605:01
*** deray has joined #openstack-horizon05:02
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854605:04
*** neelashah1 has quit IRC05:07
*** neelashah has joined #openstack-horizon05:08
*** neelashah1 has joined #openstack-horizon05:11
*** neelashah has quit IRC05:12
*** neelashah has joined #openstack-horizon05:14
*** neelashah1 has quit IRC05:15
*** errolpais has quit IRC05:15
*** rcernin has joined #openstack-horizon05:15
*** ducttape_ has quit IRC05:18
*** wolverineav has joined #openstack-horizon05:19
*** wolverineav has quit IRC05:24
*** aortega has joined #openstack-horizon05:30
*** rcernin has quit IRC05:34
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854605:38
*** mohankumar_ has joined #openstack-horizon05:42
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854605:46
*** masco has joined #openstack-horizon05:48
*** pcaruana has joined #openstack-horizon05:49
*** alexvictorchan has joined #openstack-horizon05:52
*** jbell8 has joined #openstack-horizon05:58
*** hughhalf has quit IRC06:04
*** zhurong_ has joined #openstack-horizon06:05
*** zhurong has quit IRC06:09
*** wznoinsk has quit IRC06:11
*** nlahouti has joined #openstack-horizon06:11
*** hughhalf has joined #openstack-horizon06:12
*** wznoinsk has joined #openstack-horizon06:12
*** nlahouti1 has joined #openstack-horizon06:12
*** nlahouti2 has joined #openstack-horizon06:14
*** nlahouti has quit IRC06:16
*** Ramanjaneya has joined #openstack-horizon06:16
*** nlahouti1 has quit IRC06:16
*** rcernin has joined #openstack-horizon06:18
openstackgerritRajat Vig proposed openstack/horizon: REST API to Get a Volume and Volume Type(s)  https://review.openstack.org/24141506:24
*** Ramanjaneya has quit IRC06:26
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/24902806:27
openstackgerritKenji Ishii proposed openstack/horizon: Fix return value in "Update default quota"  https://review.openstack.org/24732506:27
*** pcaruana has quit IRC06:28
openstackgerritRajat Vig proposed openstack/horizon: Add Magic Search Filtering to NG Flavors  https://review.openstack.org/23375506:32
*** Ramanjaneya has joined #openstack-horizon06:32
*** errolpais has joined #openstack-horizon06:35
openstackgerritRajat Vig proposed openstack/horizon: Add button to Create new Flavor  https://review.openstack.org/23487506:37
openstackgerritRajat Vig proposed openstack/horizon: Add angular flavors panel Edit Subflow  https://review.openstack.org/23487406:37
openstackgerritRajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel  https://review.openstack.org/23487306:37
openstackgerritRajat Vig proposed openstack/horizon: API Services for Flavors Panel  https://review.openstack.org/21489606:37
*** e0ne has joined #openstack-horizon06:40
openstackgerritMasco Kaliyamoorthy proposed openstack/horizon: Adding angular QoS panel in horizon  https://review.openstack.org/24799706:53
*** jtriley has joined #openstack-horizon06:55
*** errolpais has quit IRC06:57
*** jtriley has quit IRC07:00
*** josecastroleon has joined #openstack-horizon07:06
*** e0ne has quit IRC07:08
*** neelashah1 has joined #openstack-horizon07:13
*** neelashah has quit IRC07:14
*** neelashah has joined #openstack-horizon07:16
*** btully has quit IRC07:16
*** neelashah1 has quit IRC07:17
*** mohankumar_ has quit IRC07:21
*** nlahouti2 has quit IRC07:29
*** mohankumar_ has joined #openstack-horizon07:33
*** jerrygb has joined #openstack-horizon07:37
*** jerrygb has quit IRC07:42
*** deray has quit IRC07:45
*** errolpais has joined #openstack-horizon07:50
*** SurajD has quit IRC07:51
*** btully has joined #openstack-horizon07:51
*** SurajD has joined #openstack-horizon07:52
*** jingjing_ren has joined #openstack-horizon07:54
*** btully has quit IRC07:56
*** shu-mutou has quit IRC07:57
*** itxaka has joined #openstack-horizon07:58
*** jingjing_ren has quit IRC07:59
*** errolpais has quit IRC07:59
*** tmazur has joined #openstack-horizon08:01
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854608:03
*** tmazur has quit IRC08:04
*** rdopiera has joined #openstack-horizon08:09
*** jerrygb has joined #openstack-horizon08:12
*** wuhg has joined #openstack-horizon08:13
*** jerrygb has quit IRC08:17
*** deray has joined #openstack-horizon08:19
*** wolverineav has joined #openstack-horizon08:19
*** wolverineav has quit IRC08:25
*** tmazur has joined #openstack-horizon08:27
*** shu-mutou has joined #openstack-horizon08:27
*** mpavlase has joined #openstack-horizon08:28
*** shu-mutou has quit IRC08:31
*** Ala has joined #openstack-horizon08:40
*** Drago1 has quit IRC08:40
*** e0ne has joined #openstack-horizon08:49
betherlyMorning :)08:49
*** jtriley has joined #openstack-horizon08:55
*** jtriley has quit IRC09:00
openstackgerritMasco Kaliyamoorthy proposed openstack/horizon: Adding angular QoS panel in horizon  https://review.openstack.org/24799709:01
*** Ala has quit IRC09:09
*** Ala has joined #openstack-horizon09:13
*** vgridnev has joined #openstack-horizon09:15
*** ygbo has joined #openstack-horizon09:16
*** deray has quit IRC09:16
*** openstackgerrit has quit IRC09:16
*** openstackgerrit has joined #openstack-horizon09:16
*** zhurong_ has quit IRC09:22
ygboHi all, now that we've switched to zanata, is there an equivalent to this to fetch new translations?: https://github.com/OpenStack-I18n/Translation/wiki/Horizon-I18n-Test#step-2-check-out-the-latest-translation-from-transifex09:23
robcresswellygbo: Not sure if its documented within the openstack context but there is a CLI for it. http://zanata-client.readthedocs.org/en/latest/commands/pull/09:25
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854609:26
robcresswellygbo: You'll have more luck on #openstack-i18n09:26
robcresswellHope that helps!09:26
ygborobcresswell: I already tried #openstack-i18n yesterday :-) Thanks for your help09:26
amotokiygbo: After migrating to Zanata, I haven't tried CLI, but we have infra scripts which push/pull translations from/to Zanata.09:28
amotokiygbo: it may help you.09:28
amotokiygbo: http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/propose_translation_update.sh09:28
ygboamotoki: thanks :-)09:28
amotokiygbo: http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/upstream_translation_update.sh09:29
amotokiygbo: About Zanata CLI, you find help at http://zanata.org/help/09:29
ygboThanks amotoki and robcresswell for your links.09:31
amotokiygbo: I am usually on #-i18n too, but perhaps I wasn't there at that time :(09:32
*** btully has joined #openstack-horizon09:40
*** btully has quit IRC09:44
robcresswellBug day today! See https://etherpad.openstack.org/p/horizon-bug-day and get involved :D09:45
*** lhcheng has joined #openstack-horizon09:54
*** zhenguo has quit IRC10:02
*** aix has joined #openstack-horizon10:05
*** neelashah has quit IRC10:14
*** neelashah1 has joined #openstack-horizon10:14
*** deray has joined #openstack-horizon10:17
*** neelashah has joined #openstack-horizon10:18
*** neelashah1 has quit IRC10:18
*** kzaitsev_mb has joined #openstack-horizon10:20
openstackgerritSimon Murray proposed openstack/horizon: Add Support For Required Architecture Metadata  https://review.openstack.org/23691010:20
*** tosky has joined #openstack-horizon10:22
mascoif the patch is Abandoned for long time we need to remove the assignee and what status need to be set?10:28
*** wdeclercq has joined #openstack-horizon10:28
mascolet it be in-progress?10:28
robcresswellmasco: If its still a bug, change back to Confirmed and remove assignee10:28
robcresswellIn Progress is only if there is an active assignee10:28
mascorobcresswell, ok thanks!10:29
robcresswellmasco: Which bug btw?10:30
mascorobcresswell, https://bugs.launchpad.net/horizon/+bug/109264710:31
openstackLaunchpad bug 1092647 in OpenStack Dashboard (Horizon) "Multiple-select checkboxes activate "dangerous" buttons regardless of permissions" [Wishlist,In progress]10:31
tsufievr1chardj0n3s, read your comment about 'faiing to install murano' in bug etherpad10:33
tsufievaren't murano-dashboard and app-catalog-ui different apps?10:33
robcresswellIndeed, should speak to kfox1111 about app catalog10:34
*** josecastroleon1 has joined #openstack-horizon10:34
robcresswell-ui*10:34
*** josecastroleon has quit IRC10:35
kzaitsev_mbI can confirm, that the bug is not about murano (dashboard or otherwise.) app-catalog-ui is a dasbhoard for apps.openstack.org — it makes it simple installing and launching, say glance images from the site, by invoking the some of horizons dashboards and pre-entering some of the fields in the forms10:38
tsufievr1chardj0n3s, ^^^10:38
robcresswellIf anyone needs help looking at a bug report or changing something, ping me!10:43
mascorobcresswell, i changed this to fix released https://bugs.launchpad.net/horizon/+bug/109804710:44
openstackLaunchpad bug 1098047 in OpenStack Dashboard (Horizon) "memoized will eventually fill up all of memory" [Wishlist,Fix released] - Assigned to Radomir Dopieralski (thesheep)10:44
*** sambetts has joined #openstack-horizon10:47
robcresswellmasco: Wow thats old!10:48
robcresswellmasco: Yep seems sensible10:49
*** Liuqing has joined #openstack-horizon10:50
mascorobcresswell, lot of bugs with abandoned patch, i am just removing the assignees10:52
* masco AFK10:52
*** flwang has quit IRC10:55
*** jtriley has joined #openstack-horizon10:56
*** flwang has joined #openstack-horizon11:00
*** jtriley has quit IRC11:01
*** amotoki has quit IRC11:01
*** kzaitsev_mb has quit IRC11:01
robcresswellmasco: Remember to change from In Progress to Confirmed please.11:06
robcresswellor ping me to. I can't remember who can change what values.11:06
*** yamamoto has quit IRC11:10
openstackgerritTimur Sufiev proposed openstack/horizon: Add mechanism for hiding multiple failure messages for workflows  https://review.openstack.org/14070811:10
*** deray has quit IRC11:12
openstackgerritRajat Vig proposed openstack/horizon: Add button to Create new Flavor  https://review.openstack.org/23487511:12
openstackgerritRajat Vig proposed openstack/horizon: Add angular flavors panel Edit Subflow  https://review.openstack.org/23487411:12
openstackgerritRajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel  https://review.openstack.org/23487311:12
openstackgerritRajat Vig proposed openstack/horizon: API Services for Flavors Panel  https://review.openstack.org/21489611:12
*** rcernin is now known as rcernin|lunch11:13
*** aix has quit IRC11:14
openstackgerritRajat Vig proposed openstack/horizon: Remove the truncate function from horizon.quota.js  https://review.openstack.org/21984111:14
*** aix has joined #openstack-horizon11:15
*** Daisy_ has joined #openstack-horizon11:19
*** kzaitsev_mb has joined #openstack-horizon11:22
SurajDHi, In testing my code when I run 'tox' some tests in 'py27dj17' fail, while I run './run_tests.sh' it says 'Tests completed successfully.'. So what is the problem? Is it okay if './run_tests.sh' only passes. Please give me some pointers.11:27
robcresswellSurajD: Which version of Horizon is this?11:29
mrungeSurajD, are you mixing Liberty and mitaka versions?11:30
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854611:32
SurajDmrunge, robcresswell well I am not sure, I am new to openstack! and this is my first bug that I am solving. Can you point me right direction?11:33
tsufievrobcresswell, how do we handle situations when bug was obviosly fixed in past (I mean, setting correct milestone)11:34
mrungeSurajD, check out horizon from github, master branch11:34
openstackgerritMerged openstack/horizon: Fix mocks on update firewall rule tests  https://review.openstack.org/24728011:34
mrungethen try to reproduce your issue there11:34
tsufieve.g. https://bugs.launchpad.net/horizon/+bug/1384666 is not reproducible already for stable/kilo, but I can only set M milestones for it11:34
openstackLaunchpad bug 1384666 in OpenStack Dashboard (Horizon) "Selenium tests fail if run with '--with-selenium' switch" [Medium,Fix released] - Assigned to utsav dusad (utsavdusad)11:34
mrungeSurajD, it's reproducible, fix it on *master* branch first11:35
robcresswelltsufiev: I believe we just leave it as Fix Released11:35
SurajDmrunge, sure thank you for the pointer11:35
mrungethat won't get you in the situation of failing py27dj17 tests11:35
tsufievrobcresswell, ok11:35
mrungeSurajD, when your patch is merged on master, cherry-pick it to previous branches, if needed11:36
robcresswellSurajD: Er, well I mean, how did you install Horizon without knowing what version it was :p11:36
robcresswellSurajD: Did you pull from git? Or install via a package? Devstack?11:37
SurajDrobcresswell, devstack11:37
robcresswellSurajD: Oh. Do a git pull on the master branch. We dropped dj17 and dont support it.11:37
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854611:37
openstackgerritItxaka Serrano Garcia proposed openstack/horizon: Try to be more verbose on sec group error  https://review.openstack.org/24627511:37
*** Daisy_ has quit IRC11:37
mrungeSurajD, a patch is only acceptable, when fixed in master branch first11:37
robcresswellUnless this is for stable/liberty.11:38
*** Daisy has joined #openstack-horizon11:38
mrungerobcresswell, I saw quite a few requests on how to install devstack in icehouse release11:38
SurajDrobcresswell, mrunge sure, thanks for clearing that out for me11:38
mrungewtf...11:38
robcresswellmrunge: >.<11:38
robcresswellback in 1511:40
*** Daisy has quit IRC11:41
*** Daisy has joined #openstack-horizon11:41
openstackgerritLin Hua Cheng proposed openstack/horizon: Add support for identity provider management  https://review.openstack.org/24499111:42
*** josecastroleon1 has quit IRC11:42
openstackgerritLin Hua Cheng proposed openstack/horizon: Add basic CRUD for federation mapping  https://review.openstack.org/24855111:43
*** Daisy has quit IRC11:43
*** Daisy has joined #openstack-horizon11:46
lhchengrobcresswell: check https://bugs.launchpad.net/horizon/+bug/1517704 see if it makes sense to keep open11:47
openstackLaunchpad bug 1517704 in OpenStack Dashboard (Horizon) "Test still passes even with tests failure" [Undecided,Invalid]11:47
*** Daisy has quit IRC11:51
*** Daisy has joined #openstack-horizon11:51
*** Daisy has quit IRC11:53
*** Daisy has joined #openstack-horizon11:53
*** yamamoto has joined #openstack-horizon11:57
tsufievrobcresswell, do you think that this one https://bugs.launchpad.net/horizon/+bug/1238005 is already covered by your commits?12:01
openstackLaunchpad bug 1238005 in OpenStack Dashboard (Horizon) "breadcrumbs not fully implemented" [Low,Confirmed]12:01
openstackgerritLin Hua Cheng proposed openstack/horizon: Add basic CRUD for federation mapping  https://review.openstack.org/24855112:03
openstackgerritShan Guo proposed openstack/horizon: Networks tab does not show external configuration  https://review.openstack.org/24916512:04
*** Daisy has quit IRC12:05
*** Daisy has joined #openstack-horizon12:06
*** josecastroleon has joined #openstack-horizon12:08
*** Daisy has quit IRC12:11
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854612:11
openstackgerritShan Guo proposed openstack/horizon: Networks tab does not show external configuration  https://review.openstack.org/24916512:11
lhcheng^Gal^: ping12:18
^Gal^lhcheng: hi12:18
lhchengabout the blueprint for heat12:20
lhcheng^Gal^: this is to support nested template right?12:20
^Gal^correct12:20
lhchengI see you already have a mockup :)12:21
lhchengdo you already have a working code for this BP?12:21
openstackgerritShan Guo proposed openstack/horizon: VPN forms help text could be improved  https://review.openstack.org/24854612:22
^Gal^sadly I haven't started the development , as atm I have more urgent tasks12:23
^Gal^you could take it if you're interested12:23
*** neelashah has quit IRC12:26
*** neelashah has joined #openstack-horizon12:26
*** neelashah1 has joined #openstack-horizon12:29
*** neelashah has quit IRC12:31
*** neelashah has joined #openstack-horizon12:32
openstackgerritShan Guo proposed openstack/horizon: Networks tab does not show external configuration  https://review.openstack.org/24917312:33
*** neelashah1 has quit IRC12:33
*** alejandrito has joined #openstack-horizon12:34
*** SurajD has quit IRC12:35
*** KingKhan has quit IRC12:36
*** rcernin|lunch is now known as rcernin12:36
*** SurajD has joined #openstack-horizon12:37
*** pauloewerton has joined #openstack-horizon12:44
lhcheng^Gal^: I have other stuff in my plate, but we like to have this for M to make it easier for users to use Heat in horizon.12:46
lhcheng^Gal^: I can work on this if you haven't started by the time I get free.12:47
*** yamamoto has quit IRC12:47
lhchengwill ping you before I start12:47
robcresswelltsufiev: Oh nice find! I think that can be closed, IMO12:47
^Gal^lhcheng: sure sounds great, let's keep in touch12:47
lhcheng^Gal^: def! thanks for the initial work, that looks great!12:48
^Gal^lhcheng: thanks :) scraped that in photoshop :)12:48
robcresswelllhcheng: I see your point, that makes sense12:49
lhcheng^Gal^: Its pretty good, I really thought you already have something working :D12:49
*** SurajD has quit IRC12:49
^Gal^lhcheng: hehe :) I used to do design back in the day12:49
^Gal^love UI12:50
*** lhcheng_ has joined #openstack-horizon12:51
*** lhcheng has quit IRC12:51
*** SurajD has joined #openstack-horizon12:51
robcresswelllhcheng: Definition is going to get weird though. A "test failure" is really an assertion failure right? It seems more like the tests need more assertions, or we need more tests.12:51
*** ducttape_ has joined #openstack-horizon12:55
*** SurajD has quit IRC12:56
*** jtriley has joined #openstack-horizon12:57
*** yamamoto has joined #openstack-horizon12:59
*** SurajD has joined #openstack-horizon13:00
*** zhenguo has joined #openstack-horizon13:01
*** jtriley has quit IRC13:02
robcresswelltsufiev: Could you look at https://bugs.launchpad.net/horizon/+bug/1517084 ? Seems to me that it may have crossover with integration tests13:04
openstackLaunchpad bug 1517084 in OpenStack Dashboard (Horizon) "Unit tests should not be strict on html contents" [Undecided,In progress] - Assigned to Diana Whitten (hurgleburgler)13:04
tsufievrobcresswell, not exactly, unit tests are analyzing html from a different perspective (than integration tests)13:05
robcresswelltsufiev: I was curious if the solution proposed could be used by both?13:06
tsufievunit tests treat it as a text, integration tests treat it as a DOM/ image13:06
robcresswellOr is it not really relevant13:06
robcresswellAh, I see13:06
*** jhesketh has quit IRC13:06
tsufievnot relevant, since Selenium uses differnt approach13:06
robcresswellUnderstood13:06
tsufievhonestly, I feel like bug day should be a bug week or even a bug month for Horizon )13:07
*** jhesketh has joined #openstack-horizon13:07
robcresswellHa!13:08
robcresswellI'm working on reducing the number of "Undecided" right now13:08
robcresswell561 :(13:08
*** lhcheng_ has quit IRC13:09
*** bluex has joined #openstack-horizon13:12
*** bluex has quit IRC13:12
*** bluex has joined #openstack-horizon13:13
*** bpokorny has joined #openstack-horizon13:14
*** btully has joined #openstack-horizon13:16
*** lhcheng has joined #openstack-horizon13:20
*** aortega_ has joined #openstack-horizon13:20
*** ducttape_ has quit IRC13:20
*** btully has quit IRC13:20
*** tmazur has quit IRC13:20
robcresswellAnyone else getting timeouts on launchpad?13:22
openstackgerritMarcos Fermín Lobo proposed openstack/horizon: No hostname validation in launch instance angularjs panel  https://review.openstack.org/24414513:22
*** aortega has quit IRC13:23
robcresswelllhcheng, mrunge: Generally I mark any missing translation as High, as it is a blocker for non-english speakers. Does that seem reasonable? Or should it be based on the text that is untranslated?13:25
mascorobcresswell, https://bugs.launchpad.net/horizon/+bug/125074013:27
openstackLaunchpad bug 1250740 in OpenStack Dashboard (Horizon) "Horizon doesn't support filtering images on Admin Panel" [Wishlist,In progress] - Assigned to LIU Yulong (dragon889)13:27
mrungerobcresswell, good question13:27
mascoshall i do fix committed?13:28
robcresswellmrunge: As I said, currently marking them all as high, but unsure.13:28
lhchenghmm I would think it  is med-low, as the bug does not make horizon unusable, functionality still works.13:28
mrungerobcresswell, that would make it having the same impact comparable to launch instance not working13:28
mrungeyepp, that's my feeling, too13:28
robcresswelllhcheng: Well. Sort of. If you can't read a UI its pretty difficult to understand.13:29
robcresswellI couldnt do LI if it was in Russian, for example.13:29
*** josh6627 has joined #openstack-horizon13:29
*** josh6627 has quit IRC13:29
mrungetrue, but you could probably use a workaround13:29
mrungelike switching to english?13:30
*** doug-fish has joined #openstack-horizon13:30
robcresswellLol, but I'm suggesting text that isnt translated13:30
mrungeif LI does not work, you'll have to use cli13:30
*** jhesketh has quit IRC13:30
robcresswellAs in, if Horizon does not provided a translation for someone who does not speak English, they cannot use it13:31
mrungebut yes, you're probably right13:31
*** Liuqing_ has joined #openstack-horizon13:31
robcresswellWhat I'm curious about though, is at what level that is High/ Med/ low etc13:31
robcresswellso one string should not be high probably13:31
lhchengis the cli translated?13:31
mrungethere are two cases: a) string not translatable, b) string not translated to your desired locale13:31
mrungelhcheng, I keep hearing rumors about that13:31
robcresswellmrunge: Sure, but we can only control A) within the context of Horizon13:32
mrungeexactly13:32
robcresswelllhcheng: I'm not sure it matters if it is or not, in this context13:32
lhchengrobcresswell: I agree, I was just curious :)13:32
*** jbell8 has quit IRC13:32
robcresswellAh, sorry :p13:32
mrungerobcresswell, lhcheng afaik they are even translating error messages from other services13:32
*** Liuqing has quit IRC13:32
robcresswellwe still translate logs which we are not supposed to do13:33
robcresswellbut thats a different use case, for debugging13:33
doug-fishto the original question: I've most recently been marking missing untranslatable-ness as high priority13:33
lhchengrobcresswell: are you referring to like missing translation on buttons? or missing whole translation for a language?13:33
robcresswelllhcheng: I'm referring to untranslatable text, not missing translations13:34
robcresswellmissing translations is mostly an i18n issue, and outside our control :)13:34
mrungesounds we already have an agreement? at least a majority13:34
doug-fishdo we have any bugs for missing translations?13:34
lhchengrobcresswell: ah okay :)13:35
robcresswelldoug-fish: Yours, which I confirmed and marked High iirc13:35
robcresswellhttps://bugs.launchpad.net/horizon/+bug/151100913:35
openstackLaunchpad bug 1511009 in OpenStack Dashboard (Horizon) ""Please enter a number" message not translated" [Low,In progress] - Assigned to Tony Dunbar (adunbar)13:35
robcresswellThats another example13:35
doug-fishoh - I know more about that one13:35
robcresswellI marked Low, but was originally thinking of High too.13:35
doug-fishand I see it hasn't been shared13:36
robcresswell:(13:36
doug-fishI think that specific one is in the Low-Invalid range13:36
doug-fishthis is a message that comes from the browser based on HTML5 type=number validation13:36
*** masco has quit IRC13:36
robcresswellAh, I see13:36
doug-fishif your browser is in a different language you get the message in that language13:36
robcresswellDo you work with Tony?13:36
doug-fishI do13:36
robcresswellAh cool13:37
robcresswellSo I can close those bugs then/13:37
robcresswell?*13:37
doug-fishyep13:37
doug-fishor I can13:37
tsufievrobcresswell, do we still use weekly bug reports? While triaging bugs I came to several bugfixes of mine, which haven't got any serious attention in a year or so13:37
robcresswellAll invalidated :)13:37
doug-fishthx13:37
robcresswelltsufiev: Well, I'm still attempting to push it, as I htink its useful while our bug list is such a mess13:38
robcresswelltsufiev: So I think it has value for people with little time, as I list in the page. Whether people actually use it, is a different matter. I imagine not, given how people have reacted previously.13:38
*** JeanBriceCombebi has joined #openstack-horizon13:39
robcresswelltsufiev: Here is the link https://wiki.openstack.org/wiki/Horizon/WeeklyBugReport if you'd like to alter it.13:39
tsufievrobcresswell, thanks, will amend it13:39
robcresswellLooks like hurgleburglers having fun adding bugs to it too :p13:40
tsufievthe speed at which she upload new commits surpasses my reviewing bandwidth )13:40
robcresswellI'm going to remove those actually, the ones she's added are like 7 down in a chain13:41
tsufievI think that this list should be used for bugs that haven't seen any attention from cores for a significantly long time13:42
robcresswelltsufiev: There are a couple on there are already that have been sitting for a long time. The v1 volumes patch and ipv6 subnetpool fix13:43
robcresswelltsufiev: As I said, feel free to add a couple of bugs, but please don't overload it. It's useful to have a small focus sometimes :)13:44
tsufievwell, I didn't mean that every bug already posted there is not old enough )13:44
tsufievyep, that's exactly what I meant (not overuse)13:44
*** bpokorny has quit IRC13:45
robcresswell547 Undecided. Slowly getting better.13:47
*** _crobertsrh is now known as crobertsrh13:48
openstackgerritTimur Sufiev proposed openstack/horizon: Make configurable the default date range used on Overview panel  https://review.openstack.org/23820413:52
robcresswelldoug-fish: Thoughts on https://bugs.launchpad.net/horizon/+bug/1323599 ?13:56
openstackLaunchpad bug 1323599 in OpenStack Dashboard (Horizon) "Network topology: some terms still not translatable" [Medium,In progress]13:56
robcresswelldoug-fish: It's referring to the old network topology13:56
doug-fishThe bug is actually in the pop-up panels for the objects13:57
doug-fishso I expect it has been carried along13:57
doug-fishThe challenge is that it needs these mapping lists of states->translated states ...13:57
doug-fishbut it really needs it in javascript13:57
robcresswelldoug-fish: I'm looking now, and it seems that it is mostly translated.13:57
doug-fishyep13:57
doug-fishit's mostly fixed13:57
doug-fishbut I assume state values aren't handled yet?13:58
robcresswellPrecisely, I was just typing that out :p13:58
doug-fishcool.13:58
robcresswellThe States are untranslated13:58
doug-fishThe challenge is that the states are defined in our python bundle13:58
robcresswellIs there a bug for that? I think a new bug would be more useful13:58
doug-fishmaybe you are missing the point of bug day ...13:58
doug-fishwe want fewer, not more!13:59
robcresswellhaha :(13:59
doug-fish*shrug*13:59
doug-fishHonestly, no strong opinion on how it's tracked13:59
doug-fishit's still partly broken. A bug needs to be open13:59
robcresswellSure. I'll update the existing one.13:59
doug-fishsounds good - thanks!13:59
*** tosky_ has joined #openstack-horizon14:01
*** jhesketh has joined #openstack-horizon14:02
*** jhesketh has quit IRC14:03
*** tosky has quit IRC14:03
robcresswellUgh, there is literally not enough time to add/fix all the things I want to fix. Still need to fix Network/ Subnet error handling14:03
*** rcernin has quit IRC14:03
*** jhesketh has joined #openstack-horizon14:04
*** Ramanjaneya has quit IRC14:04
robcresswelllhcheng: What are your thoughts on priorities for missing unit tests? I tend to go with High, because no test == broken code.14:04
*** ^Gal^ has quit IRC14:05
lhchengdoug-fish: I don't think horizon can do anything for : https://bugs.launchpad.net/horizon/+bug/141614914:06
openstackLaunchpad bug 1416149 in OpenStack Dashboard (Horizon) "Horizon doesn't show a useful message when a service user is locked out" [Undecided,New]14:06
doug-fishlhcheng: I hadn't studied it enough to know that. I haven't been harassed about it lately ...14:07
doug-fishdon't people ususally configure service users in the database anyway?14:07
doug-fishperhaps this was a poor configuration choice14:07
doug-fishlhcheng: in any case, I'm good with having it marked invalid. I'll trust your judgement.14:08
lhchengrobcresswell: before I marked those as "wishlist" for missing unit tests.  we should be prioritizing unit tests, but in reality this will be treated as wishlist (even if we mark it as high) :P14:08
lhchengrobcresswell: might as well mark it wishlist - to be more realistic.14:10
robcresswellHmm14:13
*** ducttape_ has joined #openstack-horizon14:13
lhchengdoug-fish: yeah, service account as typically backed by databases.14:13
doug-fishlhcheng: I marked it invalid14:14
krotscheckSoliciting cores to review the reduction of scope of our eslint rules - https://review.openstack.org/#/c/248870/14:14
doug-fishI thought maybe you were just being too nice to mark my bug invalid.14:14
*** SurajD has quit IRC14:14
*** ducttape_ has quit IRC14:14
*** matt-borland has joined #openstack-horizon14:15
*** SurajD has joined #openstack-horizon14:15
robcresswellkrotscheck: Ah that looks sensible14:16
krotscheckrobcresswell: It really, really does. I should have done that first.14:16
*** ducttape_ has joined #openstack-horizon14:16
lhchengdoug-fish: hah just checking in maybe you found something to fix the bug. If you have, I'll let you fix it rather than marking it as invalid. :)14:17
doug-fishlhcheng: I'm satisfied with the statement that it's impossible to fix and the system shouldn't be set up that way anyway.14:19
doug-fishIt's always nice to blame people for problems they bring to you. :-)14:19
lhchengdoug-fish: haha14:19
lhchengdoug-fish: what do you think about "missing unit test"?  wishlist or high?14:20
doug-fishHigh14:20
*** matt-borland has quit IRC14:20
doug-fishTests are important.14:21
lhchengI do agree that missing unit tests is important, but just thinking that we should mark those with more realistic expectation.14:21
*** matt-borland has joined #openstack-horizon14:21
robcresswellI'm still thinking High. I don't think we should use Wishlist just because of lazy programmers. If something is untested, we shouldnt let it in. If we discover missing tests later on, it is very important to add them.14:21
doug-fishCode without tests is broken14:21
robcresswelldoug-fish: +100014:21
doug-fishif they aren't priority High they'll never get fixed14:21
mrungeagreed14:21
doug-fishMaybe I'm weird, but sometimes I look at the top priorities of the bug list14:21
lhchengI definitely agree with that, we should not merge code without tests, even if its promised as follow-up patch :P14:21
doug-fishand I rarely get past critical + high14:21
mrungelhcheng, + 100114:22
lhchengokay, makes sense to me14:22
lhchenglets move those to high then14:22
robcresswellwoohoo!14:22
*** jerrygb has joined #openstack-horizon14:23
*** matt-borland has quit IRC14:26
*** matt-borland has joined #openstack-horizon14:30
*** amotoki has joined #openstack-horizon14:32
*** willsama has joined #openstack-horizon14:36
*** mtanino has joined #openstack-horizon14:37
*** matt-borland has quit IRC14:37
*** matt-borland has joined #openstack-horizon14:42
*** ygl has joined #openstack-horizon14:43
*** goodygum_ is now known as noqa_v_qoovnie14:44
*** jtriley has joined #openstack-horizon14:46
matt-borlandTravT, following up on the Glance API patch, I want to finish that today, so I have a couple things to discuss, when you're available.14:47
*** lapalm has joined #openstack-horizon14:47
*** kzaitsev_mb has quit IRC14:47
*** mohankumar_ has quit IRC14:48
*** tosky_ is now known as tosky14:48
*** mohankumar has joined #openstack-horizon14:48
doug-fishrobcresswell: krotscheck I have to ask remedial questions about https://review.openstack.org/#/c/248870/ ... I don't understand what this is enabling - do we have failing tests?14:51
doug-fishor maybe the new linting rules aren't being used yet?14:52
robcresswelldoug-fish: Its disabling linting rules for legacy, so that as we increase the amount of linting, we don't have to keep altering legacy code14:52
krotscheckdoug-fish: Sortof. We upgraded eslint-config-openstack from 1.2.2 to 1.2.3 recently, but because of the # of violations, most of the rules were disabled so we could hit them one by one. That particular patch says: Oh yeah, by the way, we're not going to bother linting all that legacy code.14:52
krotscheckIf you look at the horizon lint job before this patch, it shoes about 1000 warnings.14:53
krotscheckThis one reduces it to about 30014:53
doug-fish:-) okay that's good - let me go back and look14:53
*** mohankumar has quit IRC14:53
*** matt-borland has quit IRC14:53
*** matt-borland has joined #openstack-horizon14:54
krotscheckThe patch chain that starts with that patch also enables various rules.14:54
krotscheckWhich I had to rewrite because it turns out disabling legacy removed all the violations.14:54
*** JeanBriceCombebi has quit IRC14:54
*** pumaranikar has joined #openstack-horizon14:54
*** jerrygb has quit IRC14:56
*** jerrygb has joined #openstack-horizon14:57
openstackgerritDirk Mueller proposed openstack/horizon: Strip white space from instance names  https://review.openstack.org/24926014:59
*** kzaitsev_mb has joined #openstack-horizon14:59
krotscheckrobcresswell: doug-fish: Thanks for the approval :)15:00
doug-fishno worries - thanks for taking the time to share the background.15:01
*** mohankumar has joined #openstack-horizon15:02
*** matt-borland has quit IRC15:02
*** lapalm has quit IRC15:03
robcresswell522 Undecided.15:03
robcresswellSlowly improving15:04
*** lapalm has joined #openstack-horizon15:04
*** btully has joined #openstack-horizon15:04
*** SurajD has quit IRC15:06
robcresswelldoug-fish: Do you have an exhaustive list of missing translations anywhere?15:08
*** SurajD has joined #openstack-horizon15:08
doug-fishrobcresswell: I don't15:08
*** btully has quit IRC15:09
robcresswellOh scrap that, we have an i18n tag.15:09
robcresswellNeat.15:09
doug-fishyeah15:09
doug-fishthat was going to be my suggestion15:09
doug-fishthough I'm not sure it's been used consistently15:09
*** JeanBriceCombebi has joined #openstack-horizon15:10
*** kzaitsev_mb has quit IRC15:10
* doug-fish going to tag more stuff as i18n15:10
robcresswelldoug-fish: Same here, will keep that tag in mind.15:10
*** mpavlase has quit IRC15:11
robcresswelldoug-fish: Another one of Tonys here https://bugs.launchpad.net/horizon/+bug/1511013 Is this the same as the last ones?15:12
openstackLaunchpad bug 1511013 in OpenStack Dashboard (Horizon) "Browse button and "No file selected" not translated" [Undecided,In progress] - Assigned to Tony Dunbar (adunbar)15:12
yglhi all15:12
robcresswellygl: o/15:12
*** mohankumar has quit IRC15:13
*** hurgleburgler has joined #openstack-horizon15:13
doug-fishrobcresswell: yes, that's the same issue15:13
doug-fishI'm remembering now I discussed this with Tony immediately before he left for some PTO.15:14
doug-fishI think he opened very specific bugs as he was investigating this too - there is probably a whole group of bugs hiding here15:14
*** peristeri has joined #openstack-horizon15:15
ygli heard abt a new feature in horizon15:15
yglwork flows or something15:15
yglwhat exactly is that15:15
robcresswellI'm assuming this is Justins patch15:15
*** jerrygb has quit IRC15:15
robcresswellWhat was the context you heard about this in, btw?15:16
*** jerrygb has joined #openstack-horizon15:16
doug-fishTony sat in my office and asked me about some bugs he had opened15:16
robcresswellha sorry, I meant that at ygl15:16
doug-fish:-)15:16
robcresswelldoug-fish: I think I got most of Tonys bugs cleaned up now15:17
*** btully has joined #openstack-horizon15:17
doug-fishrobcresswell: cool - thx15:17
robcresswellygl: I imagine it was this patch you heard about? https://review.openstack.org/#/c/214306/15:17
ygldoes this feature shows any debugging information in hroizon ?15:17
mrungeawesome, so many bugs marked as FIX COMMITTED :D15:17
robcresswellygl: Nope15:18
yglok15:18
doug-fishgotta run for now. Back later to talk more about bugs!15:19
robcresswellcya later doug15:19
*** Drago has joined #openstack-horizon15:19
krotscheckHas everyone voted on the new set of eslint rules up for review? https://review.openstack.org/#/q/status:open+project:openstack/eslint-config-openstack,n,z15:19
*** vgridnev has quit IRC15:19
mrungekrotschek, please clean up some bugs first before harassing us for votes on eslint :P15:20
*** wolverineav has joined #openstack-horizon15:20
openstackgerritDiana Whitten proposed openstack/horizon: Top and Bottom Padding should be removed from navbar-brand  https://review.openstack.org/24783515:20
openstackgerritDiana Whitten proposed openstack/horizon: Top Nav shouldn't include giant bottom margin  https://review.openstack.org/24825715:21
krotscheckmrunge: It's hardly harassment15:22
*** matt-borland has joined #openstack-horizon15:24
krotscheckmrunge: You doing ok? That last comment of yours seemed a bit grumpy.15:24
*** vijendar has joined #openstack-horizon15:24
mrungekrotscheck, I couldn't resist.15:24
*** wolverineav has quit IRC15:25
mrungekrotscheck, it was, you were asking for lots of reviews lately15:25
mrungeat least it seemed so. our review queue is still insane. every helping hand with reviewing code is very much appreciated15:26
krotscheckmrunge: Is that a bad thing? OpenStack is notoriously slow for those who are willing to wait for cores to get around to things.15:26
mrunge*hint* ;-) krotscheck15:26
openstackgerritDiana Whitten proposed openstack/horizon: Branding: Horizon Header should be more composable  https://review.openstack.org/24839415:26
krotscheckmrunge: Oh no, if I do that you might accidentally make me core, and I do NOT want that.15:26
mrungehahaha, I think we don't actually make people core by accident15:27
* krotscheck is content to write code and make others review it.15:27
krotscheckmrunge: You won't be able to help yourself when exposed to the scintillating prose of my code reviews.15:27
mrungeseriously, reviewing code helps a lot to reduce load of cores15:28
robcresswelldoug-fish: Marked https://bugs.launchpad.net/horizon/+bug/1334382 as invalid given the discussion. Let me know if thats incorrect.15:28
openstackLaunchpad bug 1334382 in OpenStack Dashboard (Horizon) "API endpoint service names are not translated" [Low,Invalid] - Assigned to Amit Prakash Pandey (amitpp23)15:28
robcresswellMan this is slow work.15:28
krotscheckmrunge: I actually don't think it does. A core is still ultimately responsible for anything that lands, so even if 100 people review something, a core can't just rubberstamp it.15:28
mrungethat in consequence leaves code reviews to cores15:29
mrungeI mean, ALL code reviews15:29
robcresswellkrotscheck: I totally disagree, I often won't look at something until it has at least a couple of +1s and has been stable for a couple of days. Reduces time spent on stupid reviews.15:29
robcresswellthat said, my review count this cycle is not as high as I'd like it to be. Took a week or so off :)15:30
krotscheckrobcresswell, mrunge: Fascinating. I'd love to do a poll of how cores actually behave. A15:30
krotscheckI've also noticed that some cores simply won't look at code that has a -115:30
krotscheckActually, how about we discuss this when y'all are not busy with bug day?15:31
mrungekrotscheck, well, at least, I'm looking at code reviews for others15:31
robcresswellkrotscheck: Heh, its probably quite inconsistent. Its quite a subjective thing in some ways. I mean look at stackalytics approval %, they vary wildly15:31
*** vijendar has left #openstack-horizon15:31
*** masco has joined #openstack-horizon15:31
robcresswellYeah, back to bugs :)15:31
krotscheckYeah, but maybe, if we actually look at how people do it, and what we actually want cores to do, we can come up with a way better set of dashboards for openstack that streamline all this.15:32
mrungeyupp, it looks like we agree to disagree here15:32
krotscheckBecause robcresswell's approach makes sense. And the -1 makes sense.15:32
krotscheckIs there some way though that we can adjust how things are prioritized on different dashboards?15:33
* krotscheck goes off to the UX channel to ponder.15:33
mrungekrotscheck, priorities are being set during the summit15:33
robcresswellkrotscheck: Like, this type of thing? https://github.com/openstack/gerrit-dash-creator15:33
*** jerrygb has quit IRC15:33
krotscheckrobcresswell: Yes. That15:34
robcresswellI imagine there are optimisations that could be done. Certainly worth a discussion at some point. But not right now :)15:34
openstackgerritMarcos Fermín Lobo proposed openstack/horizon: No hostname validation in launch instance angularjs panel  https://review.openstack.org/24414515:35
*** kmARC has quit IRC15:37
*** kmARC has joined #openstack-horizon15:38
robcresswellmatt-borland: o/ helping out with bug day?15:39
mrungerobcresswell, any direct interest in https://bugs.launchpad.net/horizon/+bug/1416838 ?15:40
openstackLaunchpad bug 1416838 in OpenStack Dashboard (Horizon) "Network Details should be a tabbed page" [Wishlist,Triaged] - Assigned to Rob Cresswell (robcresswell)15:40
robcresswellmrunge: I have a patch on the go for that15:40
robcresswellmrunge: Its still loca though15:40
robcresswelllocal*15:40
mrungeaha, ok15:40
mrungenot removing you as assignee15:40
robcresswellThanks15:41
*** Drago has quit IRC15:43
*** matt-borland has quit IRC15:43
openstackgerritMatthias Runge proposed openstack/horizon: Integration test - support login multiple regions  https://review.openstack.org/14358715:44
*** mpavlase has joined #openstack-horizon15:46
*** mpavlase has quit IRC15:48
*** jbell8 has joined #openstack-horizon15:49
*** matt-borland has joined #openstack-horizon15:50
openstackgerritMatt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance  https://review.openstack.org/23683215:51
*** Liuqing_ has quit IRC15:54
*** JeanBriceCombebi has quit IRC15:57
TravTmatt-borland15:58
matt-borlandhey TravT !15:58
*** bluex has quit IRC15:59
TravTjust looked through latest glance api patch15:59
matt-borlandyeah, is that getting closer to what you were thinking?15:59
TravTi think it should take inspiration from that actual glance v2 api for properties.15:59
matt-borlandok...15:59
TravTre: the extra roperties15:59
TravTproperties15:59
*** JeanBriceCombebi has joined #openstack-horizon16:00
TravThttp://developer.openstack.org/api-ref-image-v2.html#createImage-v216:00
TravTglance api puts them in a properties entry16:00
TravTbut in your patch, everything is already in a properties entry...16:00
*** alexvictorchan has quit IRC16:00
matt-borlandOK, gotta admit, I feel directionless.16:01
matt-borlandAm I supposed to be mimicing the v2 API and converting everything when possible to the v1 API?16:01
matt-borlandI am feeling like we're chasing a moving target/requirement, and the Image panels are suffering.16:02
TravTv1 is nearly deprecated, so I'm not sure why it was used as the inspiration here16:02
matt-borlandok.16:02
matt-borlandwell, this kinda throws that whole patch chain into jeopardy16:03
matt-borland(which is not your fault)16:03
TravTno it doesn't you are over reacting16:03
matt-borlandok16:03
matt-borlandI'm not trying to overreact, I'm trying to understand scope.16:03
matt-borlandI'm OK with changes, I just want to understand the goals.16:04
TravTwell, the glance create API and client allows for passing arbitrary properties through in addition to the defined ones16:04
TravTand i'm providing the feedback that we should consider that with this api16:04
matt-borlandyep, nothing I'm saying is directed at you16:05
matt-borlandI picked up a patch and am trying to figure out its goals :)16:05
*** Drago has joined #openstack-horizon16:05
TravTi just don't want to back us into a corner where that is blocked.16:05
matt-borlandexactly16:06
*** Drago has quit IRC16:06
*** Drago has joined #openstack-horizon16:06
*** JeanBriceCombebi has quit IRC16:07
matt-borlandTravT, OK, so this is a kind of extistential question (API-wise)...16:07
TravTi'm no sure that anything needs to be changed...16:07
*** ericksonsantos has joined #openstack-horizon16:07
TravTs/no/not16:07
matt-borlandyeah, I'm trying to figure out the balance of making the APIs similar, and the utility of 'flattening' them16:08
matt-borlandthat is,16:08
matt-borlandbundling metadata in a single API call (JS -> API),16:08
matt-borlandvs. breaking out metadata API calls.16:08
TravTi see no reason for us to intentionally or accidentally block something that is possible via the direct service APIS16:09
matt-borlandyep16:09
matt-borlandso basically,16:09
matt-borlandpass thru the 'properties' value16:10
matt-borlandfor create16:10
TravTall we need to consider is whether to pass through any extra properties16:10
matt-borlandI think that makes sense16:10
TravTand make sure the other values we are plucking off of the "properties" object now should be under the properties object16:10
TravTjust want to double check that on glance16:10
matt-borlandok, cool16:11
matt-borlandthanks for bearing with me :)16:11
*** vgridnev has joined #openstack-horizon16:11
TravTno worries, i know it is painful to go through several rounds of revisions.16:11
openstackgerritMatt Borland proposed openstack/horizon: Add unit tests for load-edit directive  https://review.openstack.org/23778816:12
matt-borlandheh, it's OK TravT16:14
matt-borlandI really just am asking quesions, I didn't mean any of it as criticism16:14
TravTmatt-borland: seriously, no worries at all!16:14
matt-borlandok, let me look at that API code some more and try to see how to better align the JS REST call and the v2 API16:15
matt-borlandI think that's the gist of what we're talking about16:15
TravTirc has this permanent problem of not being able to see faces, which causes misperception of people's mood. :)16:15
matt-borlandyep16:15
*** Ala has quit IRC16:15
matt-borlandemoticons only go so far :)16:15
*** rcernin has joined #openstack-horizon16:16
TravTFYI, i'm reading through the glance service side API at the moment just to look at a couple things.  The docs are somewhat lacking16:17
lhchengrobcresswell: down to 499 undecided \o/16:18
*** JeanBriceCombebi has joined #openstack-horizon16:18
robcresswelllhcheng: yeah!16:19
robcresswellTime for another shout out actually: https://etherpad.openstack.org/p/horizon-bug-day Feel free to join in and help us sort our bugs out!16:20
robcresswellAlso TravT, tqtran-afk, if you guys could look at https://review.openstack.org/#/c/209631/ again, would like to get it in so the next patches can get moving16:21
*** jtriley has quit IRC16:21
TravTrobcresswell: ok16:22
robcresswellThanks!16:23
openstackgerritTimur Sufiev proposed openstack/horizon: Add pagination support to the volume page  https://review.openstack.org/11845016:25
TravTmatt-borland: i think what we said above and the current code in the patch actually pretty much works with the v2 api as well. it is just missing the extra properties16:27
TravThttps://github.com/openstack/glance/blob/master/glance/domain/__init__.py#L75-L7816:27
matt-borlandYeah, that's basically my conclusion too16:28
TravTif you trace through the glance API a few layers deep, you end up at the above lines of code16:28
TravTwhich matches almost exactly with what is in the patch set for what is on root node and what is in properties node of object structure16:28
matt-borlandhm, ok16:29
*** zhenguo has quit IRC16:29
*** lhcheng_ has joined #openstack-horizon16:29
*** rebase has joined #openstack-horizon16:30
TravTso, in other words, i think the patch is in pretty good shape.16:30
matt-borland:) Thanks!16:30
openstackgerritKelly Domico proposed openstack/horizon: Fix flavor quota charts in NG Launch Instance  https://review.openstack.org/24931016:31
TravTmy question is what happens if we go ahead and send the arbitrary properties through to the v1 glance client call that is currently in horizon16:31
TravTwill it blow up?16:31
*** josecastroleon has quit IRC16:31
*** JeanBriceCombebi has quit IRC16:31
TravTi can try that really quick... i already have that setup from my testing of the API yesterday16:31
*** JeanBriceCombebi has joined #openstack-horizon16:31
*** lhcheng has quit IRC16:32
matt-borlandgood point TravT16:32
*** itxaka has quit IRC16:34
*** rebase has quit IRC16:34
*** jtriley has joined #openstack-horizon16:35
openstackgerritKelly Domico proposed openstack/horizon: Fix flavor quota charts in NG Launch Instance  https://review.openstack.org/24931016:36
matt-borlandIn my case it seems to have stripped properties, at least based on what is returned in the response TravT16:37
*** david_cu has joined #openstack-horizon16:38
openstackgerritMerged openstack/horizon: Disable all new linting rules in legacy code  https://review.openstack.org/24887016:38
*** david-lyle changes topic to "OpenStack Horizon -- Bug day https://etherpad.openstack.org/p/horizon-bug-day"16:38
openstackgerritDiana Whitten proposed openstack/horizon: New Preview Page Needs All Sizes of Button Groups  https://review.openstack.org/24931616:38
david-lylelate to the party, but is there any rhyme or reason as to what bugs people are looking at?16:40
*** aix has quit IRC16:40
matt-borlandDo new tests fall in line with bug day?16:41
matt-borland:)16:41
robcresswellmatt-borland: this is specifically for organising the bugs list16:42
robcresswelldavid-lyle: Most of us having been going through those with Undecided importance16:42
robcresswellCurrently down to 496 undecided16:43
david-lylenice16:44
david-lylethat's 100 better than we were16:44
robcresswellWin16:44
*** tqtran has joined #openstack-horizon16:44
*** tqtran is now known as tqtran-afk16:45
*** ongk has joined #openstack-horizon16:48
*** masco has quit IRC16:50
*** tqtran-afk has quit IRC16:52
*** tqtran-afk has joined #openstack-horizon16:52
*** alexvictorchan has joined #openstack-horizon16:53
*** tosky has quit IRC16:53
*** tosky has joined #openstack-horizon16:54
*** e0ne has quit IRC16:58
*** tqtran-afk has quit IRC17:07
*** tqtran-afk has joined #openstack-horizon17:07
*** kzaitsev_mb has joined #openstack-horizon17:07
*** mohankumar has joined #openstack-horizon17:10
*** tqtran-afk has quit IRC17:11
*** tqtran-afk has joined #openstack-horizon17:12
*** tqtran-afk has quit IRC17:17
*** tqtran-afk has joined #openstack-horizon17:17
openstackgerritMatt Borland proposed openstack/horizon: Add unit tests for load-edit directive  https://review.openstack.org/23778817:19
robcresswellShouldnt we be marking bugs Confirmed rather than Triaged btw?17:19
*** david-ly_ has joined #openstack-horizon17:19
robcresswelltsufiev, mrunge ^^17:19
robcresswell"Some bugs are filed with an attached patch. We should review if the patch looks indeed like a patch, and if yes, set the bug status to Triaged to show that it comes with a likely solution, ready to be implemented."17:20
tsufievrobcresswell, hm... is it compatible with our workflow?17:20
tsufievpeople usually provide patch via gerrit, which moves a bug into In Progress state17:21
robcresswellWell, for example, if someone proposes a patch but then leaves17:21
robcresswellWe should remove assignee and move to Triaged17:21
robcresswellThis is from the openstack docs, so its specific to us I think17:21
tsufievah, so Confirmed = No patch, Triaged = some patch (e.g. Abandoned in gerrit), right?17:21
robcresswellI believe so. If it has a solution, i.e. substantial code, but perhaps needs a small fix, or a resolved merge, then it should be Triaged17:22
robcresswellOtherwise, just New if you dont have the time to confirm yet, or Confirmed if you take the time to investigate.17:22
tsufievthe next question is how could I change the bugs I marked as Triaged to Confirmed :)?17:22
tsufievis there any launchpad history?17:23
*** david-l__ has joined #openstack-horizon17:23
*** david-ly_ has quit IRC17:23
*** david-lyle has quit IRC17:23
*** jtriley has quit IRC17:24
robcresswellErrm, unsure. There is the mailer, which has been spamming my filter folder all day :D17:24
*** ygbo has quit IRC17:24
tsufievbtw, shouldn't we mark this one https://bugs.launchpad.net/horizon/+bug/1403216 as Invalid?17:24
openstackLaunchpad bug 1403216 in OpenStack Dashboard (Horizon) "Router popover in network topology not next to router box" [Undecided,New]17:24
*** ygl has left #openstack-horizon17:25
tsufievI believe that new Network Topology is free from this bug17:25
*** SurajD has quit IRC17:25
robcresswelltsufiev: I dont have an IE setup, so I can't confirm.17:25
robcresswellJust removed assignee and set to new so it was back in the bug workflow properly.17:26
tsufievrobcresswell, sounds reasonable17:26
robcresswell484 undecided17:26
*** JeanBriceCombebi has quit IRC17:26
robcresswellKeep at it :D17:26
*** jbell8 has quit IRC17:27
*** yamamoto has quit IRC17:29
ongkrobcresswell, tsufiev: I can check that to see if that bug ^^ still occurs on IE17:29
robcresswellongk: That would be very helpful17:30
*** david-l__ has quit IRC17:30
*** tqtran-afk has quit IRC17:31
*** tqtran-afk has joined #openstack-horizon17:31
*** rdopiera has quit IRC17:32
*** SimonChung1 has quit IRC17:33
*** mohankumar has quit IRC17:35
*** ducttape_ has quit IRC17:40
*** sayali has quit IRC17:42
*** jbell8 has joined #openstack-horizon17:43
*** david-lyle has joined #openstack-horizon17:44
*** ChanServ sets mode: +o david-lyle17:44
*** tqtran-afk has quit IRC17:45
openstackgerritDiana Whitten proposed openstack/horizon: New Preview Page Needs All Input Types  https://review.openstack.org/24934217:45
*** tqtran-afk has joined #openstack-horizon17:46
*** SimonChung has joined #openstack-horizon17:50
*** lapalm has quit IRC17:52
openstackgerritDiana Whitten proposed openstack/horizon: New Preview Page Needs All Input Types  https://review.openstack.org/24934217:52
*** SurajD has joined #openstack-horizon17:54
*** aix has joined #openstack-horizon17:57
tsufievongk, thanks! Will you check new network topology against IE?17:58
ongkYup, will do that17:58
*** mohankumar has joined #openstack-horizon17:58
tsufievnice )17:59
*** sambetts is now known as sambetts-afk17:59
*** david_cu has quit IRC17:59
*** e0ne has joined #openstack-horizon18:01
robcresswell"post-creation option not working in icehouse"18:03
robcresswellWe got some oooold bugs.18:03
*** SimonChung has quit IRC18:03
*** SimonChung has joined #openstack-horizon18:03
*** david-lyle has quit IRC18:03
robcresswellWow this isn't even 6 months old actually18:03
openstackgerritMerged openstack/horizon: Top and Bottom Padding should be removed from navbar-brand  https://review.openstack.org/24783518:03
*** SimonChung1 has joined #openstack-horizon18:03
*** SimonChung has quit IRC18:03
*** SimonChung has joined #openstack-horizon18:05
*** SimonChung1 has quit IRC18:05
*** SimonChung1 has joined #openstack-horizon18:05
*** SimonChung has quit IRC18:05
*** jtriley has joined #openstack-horizon18:08
robcresswellhttps://bugs.launchpad.net/horizon/+bug/150226918:10
openstackLaunchpad bug 1502269 in OpenStack Dashboard (Horizon) "boot from volume from image broken" [Undecided,New]18:10
openstackgerritMatt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance  https://review.openstack.org/23683218:10
robcresswellIs this bug report referring to the new LI? I can't actually tell18:10
*** wasmum has joined #openstack-horizon18:11
robcresswellI removed some of the text because it was mostly just capslock and raging18:11
*** kzaitsev_mb has quit IRC18:11
*** david-lyle has joined #openstack-horizon18:11
*** ChanServ sets mode: +o david-lyle18:11
openstackgerritCindy Lu proposed openstack/horizon: Launch Instance Wizard - Security Group Available table  https://review.openstack.org/24884818:11
robcresswellmatt-borland: ping18:12
robcresswellAny angular folk about?18:13
*** tqtran-afk has quit IRC18:15
*** tqtran-afk has joined #openstack-horizon18:15
*** jingjing_ren has joined #openstack-horizon18:16
*** jingjing_ren has quit IRC18:16
*** jingjing_ren has joined #openstack-horizon18:17
*** wolverineav has joined #openstack-horizon18:18
matt-borlandrobcresswell, ping back18:18
matt-borland:)18:18
*** neelashah has quit IRC18:18
*** neelashah has joined #openstack-horizon18:19
robcresswellI was playing around with the bug above. When changing the Source, the Available table is always stuck on Available(2)18:19
matt-borlanduh oh!18:19
robcresswellWhether I pick image, volume etc18:19
matt-borlandneed a hand, or a review?18:20
robcresswellEr, no, just wondering if that was a known bug18:20
robcresswellin the new LI18:20
*** kevinbenton has quit IRC18:20
matt-borlandI didn't know offhand...strange I've not seen it...was it a regression from the patch yesterday, or did it precede it, I wonder offhand18:21
matt-borlandlooks like it preceded it18:21
*** wolverineav has quit IRC18:23
robcresswellI saw some other issues with tables, I think Cindy had a bug up or something18:23
robcresswelldoesnt seem to be on irc18:23
matt-borlandhunh, yeah, it seems kind of odd that this wouldn't have been working18:24
*** jtriley has quit IRC18:24
tsufievomg, I've just realized that the thing meant to be 'queue' in legacy client Horizon is actually a stack ))18:25
TravTrobcresswell: that sounds familiar18:26
tsufiev(speaking of https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/horizon.communication.js#L46)18:26
TravTbut i haven't looked into it18:26
*** tosky has quit IRC18:26
*** yamamoto has joined #openstack-horizon18:29
robcresswellTravT: Ah, no worries.18:29
*** tjones has joined #openstack-horizon18:31
openstackgerritMatt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance  https://review.openstack.org/23683218:31
robcresswelldavid-lyle: Down to 475 Undecided. Overall we have 868 bugs that are New/Confirmed/Triaged/Incomplete/In Progress18:33
robcresswellI'm about done for the day though :)18:33
david-lylerobcresswell: nice!18:33
* david-lyle is fighting devstack18:34
david-lyleand losing18:34
robcresswellHaha. unstack, clean, reboot. its the only way.18:34
*** yamamoto has quit IRC18:34
robcresswelldavid-lyle: I'll send out a quick email in the morning and summarise what was achieved. Overall I think that was quite productive. Another few and we should be getting on top of it.18:35
*** kzaitsev_mb has joined #openstack-horizon18:35
david-lylerobcresswell: thanks!18:36
ongkrobcresswell, tsufiev: looks like the popup is working correctly in IE10. https://bugs.launchpad.net/horizon/+bug/1403216 can be marked invalid18:37
openstackLaunchpad bug 1403216 in OpenStack Dashboard (Horizon) "Router popover in network topology not next to router box" [Undecided,New]18:37
robcresswellongk: Great18:37
robcresswellI think I'll maark that invalid then18:38
ongkbtw, in IE9, everything looks awful. Are we still supporting IE9?18:38
robcresswellIt does?18:38
robcresswell*sigh*18:38
david-lylethe bug lists IE918:38
robcresswellYes, we are18:38
*** kzaitsev_mb has quit IRC18:38
robcresswellso, bug is very valid18:38
*** kzaitsev_mb has joined #openstack-horizon18:38
ongkYeah, the nav takes up the whole width of the browser18:39
david-lylecould be rolled into an "IE9 blows" bug18:39
robcresswellHas anyone ever done a survey of our user base and browsers?18:39
robcresswellPiet get in here18:39
robcresswell:p18:39
Pietk18:39
robcresswell:o that was cool18:39
PietWhat's up?18:39
robcresswellPiet: Any idea on browsers being used by end users?18:40
PietI like using "IE Blows" as an error message18:40
david-lylerobcresswell: the biggest issue is some companies and govt agencies have very little flexibility as far as browser choice goes18:40
PietCan we change message to "MS Blows?"18:40
david-lylePiet: no18:40
PietI have don't have the information handy18:41
robcresswelldavid-lyle: Yeah, I know. But it would be interesting to know either way.18:41
david-lyle know for HP public cloud it was < 2%18:41
doug-fishI'm trying to decipher this: https://support.microsoft.com/en-us/lifecycle/search?sort=PN&alpha=internet%20explorer18:41
doug-fishI'm not sure if Microsoft has support for IE918:41
doug-fishespecially beginning Jan 12, 201618:42
PietI would ask Kevin and Christine was version they are using18:42
robcresswelldoug-fish: As long as Vista is supported, IE9 is18:42
sjmc7i know many people still using win XP at work, so whether MS support it doesn’t mean too much :)18:42
*** tqtran-afk is now known as tqtran18:42
Pietkfox1111 You around?18:42
robcresswellsjmc7: Doesnt matter, XP is out of support18:42
david-lyleyou can buy extended support18:42
doug-fishI'm sure we could be bought too18:43
david-lylebut I'm good with delisting IE9 support in January18:43
sjmc7either way, lots of people don’t care about whether it’s supported18:43
ongkrobcresswell: I can’t verify whether that popover bug shows up in IE9. The topology isn’t rendering :)18:43
hurgleburglerdavid-lyle +1!18:43
PietI would check with some of the folks with government agency.18:43
PietDOn't make this a holy war because you hate IE18:44
robcresswellVista is already on Extended support, until April 201718:44
hurgleburglersvg doesn't work right in ie918:44
hurgleburgleror 1018:44
robcresswellThats the official IE9 is dead day18:44
hurgleburglerhttp://caniuse.com/#feat=svg18:44
hurgleburgleror 1118:44
hurgleburglerIE9-11 desktop & mobile don't properly scale SVG files18:44
robcresswellThen it jumps to 11 until like 2023 or something, if we follow extended support.18:44
hurgleburglerbut, we can likely fix it with the proper css eventually18:44
robcresswellI am 100% for dropping IE9 ha. But I'd love some numbers on who it affects.18:45
david-lylepersonally, I'd let MS track those numbers18:45
david-lyleif they're not updating browsers in the past 8 years, they probably aren't on a new version of openstack either18:46
Pietrobcresswell I'm particularly concerned with the government agencies.  Check with them.18:46
david-lylethat's what stable branches support18:46
openstackgerritCindy Lu proposed openstack/horizon: Launch Instance Wizard - Avail items count doesn't update  https://review.openstack.org/24669818:46
robcresswellPiet: One of the problems there is, they may actually negotiate incredibly long support contracts with MS18:46
openstackgerritTimur Sufiev proposed openstack/horizon: Escape RegEx characters from table quick search text  https://review.openstack.org/11393218:46
*** mtanino has quit IRC18:47
robcresswellAlthough I suppose companies are just as likely.18:47
Pietrobcresswell It would be helpful to get a data point from them . Can't hurt to ask18:47
*** lapalm has joined #openstack-horizon18:47
robcresswellTrue. Any contacts?18:47
robcresswelldavid-lyle: You're for removing IE9 support this cycle then?18:48
hurgleburglerIt'd be nice if we can get some real numbers, instead of survey numbers18:48
Pietkfox1111 is a good start18:48
hurgleburglerif we could add some basic analyic tools to horizon and ask companies to opt in to provide with usage information18:48
PietChristine with you-know-who would have some answers18:49
*** ongk has quit IRC18:49
*** ongk has joined #openstack-horizon18:50
robcresswellyou-know-who?18:52
tqtranwoohoo +1 to delisting IE918:53
doug-fishpotential sources of info: http://www.w3counter.com/globalstats.php http://www.w3schools.com/browsers/browsers_explorer.asp18:54
doug-fishthese sources put IE9 usages on the order of 1-2%18:54
doug-fishI'd expect it to be lower among potential Horizon users18:54
doug-fishunless we have somebody specific in mind.18:54
hurgleburglerIt'd be useful to also get information on devices, for accessibility concerns as well18:54
*** jprovazn has joined #openstack-horizon18:55
tqtranwe only support chrome and FF, if you use anything else, use at your own risk *BAM* lay down the hammer david! LAY IT DOWN!18:56
*** SimonChung has joined #openstack-horizon18:57
*** SimonChung1 has quit IRC18:57
david-lyleI think support for IE 10 is fine tqtran. Let's not go crazy18:57
hurgleburglerlol18:57
*** SimonChung has quit IRC18:57
david-lyleanything that would make us that happy can't be good :P18:57
*** SimonChung1 has joined #openstack-horizon18:57
tqtranhuhuhu18:57
robcresswellActually, you can drop 9 and 10 at the same time. MS dont support 10 iirc. They support 9 and 11.18:58
david-lylerobcresswell: you're right18:58
david-lyle11 all the way18:58
david-lyleor what is most current18:58
david-lyleas 11 may not be that18:58
*** lapalm_ has joined #openstack-horizon18:58
tqtranedge18:58
robcresswellIt'll be 11 for a while due to Win 8. But, 11 is fairly reasonable.18:59
*** fedexo has joined #openstack-horizon18:59
hurgleburglerI can help out with that effort19:00
*** jerrygb has joined #openstack-horizon19:01
*** errolpais has joined #openstack-horizon19:01
*** wuhg has quit IRC19:01
*** lapalm has quit IRC19:02
robcresswellI'll stick up a BP for removing IE9 and 10 then. It'll likely need a few CSS removals, and need to be reno'd anyway.19:02
robcresswellBest Horizon day ever.19:02
david-lyle1 version of django, 1 version of IE19:03
* robcresswell wondering how much hacky IE9 code we have19:03
david-lylelife is simpler now19:03
david-lylerobcresswell: not much I bet19:03
robcresswellSweet19:03
david-lylejudging by how well it works :P19:03
robcresswellhaha19:03
openstackgerritDan Nguyen proposed openstack/horizon: Updates horizon's copy of the cinder policy file  https://review.openstack.org/24937919:04
robcresswellRight I'm off for the evening. Keep working at bugs if you get chance :D19:09
*** mohankumar has quit IRC19:09
*** kevinbenton has joined #openstack-horizon19:10
*** alejandrito has quit IRC19:10
hurgleburglerhttp://caniuse.com/#feat=flexbox19:11
hurgleburgler♪└|∵|┐♪└|∵|┘♪┌|∵|┘♪ ♪└|∵┌|└| ∵ |┘|┐∵|┘19:11
openstackgerritLucas Palm proposed openstack/horizon: WIP: Convert the Heat stack creation wizard to a workflow  https://review.openstack.org/24938419:11
*** neelashah1 has joined #openstack-horizon19:17
*** jtriley has joined #openstack-horizon19:17
*** mtanino has joined #openstack-horizon19:18
*** neelashah has quit IRC19:19
*** neelashah has joined #openstack-horizon19:20
*** kzaitsev_mb has quit IRC19:20
*** neelashah1 has quit IRC19:21
*** tjones has quit IRC19:24
*** jtriley has quit IRC19:26
*** tjones has joined #openstack-horizon19:27
*** kzaitsev_mb has joined #openstack-horizon19:30
*** kzaitsev_mb has quit IRC19:36
openstackgerritLucas Palm proposed openstack/horizon: WIP: Convert the Heat stack creation wizard to a workflow  https://review.openstack.org/24938419:38
*** kzaitsev_mb has joined #openstack-horizon19:41
*** jtriley has joined #openstack-horizon19:41
*** kyleolivo has joined #openstack-horizon19:43
*** jobewan has joined #openstack-horizon19:43
*** kzaitsev_mb has quit IRC19:50
*** jingjing_ren has quit IRC19:50
*** jingjing_ren has joined #openstack-horizon19:51
*** kzaitsev_mb has joined #openstack-horizon19:52
PietDoes Volume size consume from the Total Size of Volumes and Snapshots quota?19:52
sjmc7dougfish and hurgleburgler: for https://review.openstack.org/#/c/246549/, if i modify the tests i added to check that an element with the id exists (and the css classes?) is that enough? i could also check the context data for href and other more data-y things19:54
*** lapalm_ has quit IRC19:57
*** dsneddon is now known as dsneddon_lunch20:01
*** kyleolivo has quit IRC20:01
*** kyleolivo has joined #openstack-horizon20:01
*** jingjing_ren has quit IRC20:02
*** jwy has joined #openstack-horizon20:05
*** kyleolivo has quit IRC20:12
*** errolpais has quit IRC20:14
*** kyleolivo has joined #openstack-horizon20:14
*** mounica has joined #openstack-horizon20:15
*** mounica has quit IRC20:16
*** jingjing_ren has joined #openstack-horizon20:29
*** sayan_ has quit IRC20:31
*** fedexo has quit IRC20:31
*** SurajD has quit IRC20:31
*** kyleolivo has quit IRC20:34
*** jingjing_ren has quit IRC20:35
*** neelashah1 has joined #openstack-horizon20:36
*** neelashah has quit IRC20:38
*** e0ne has quit IRC20:38
*** neelashah has joined #openstack-horizon20:39
*** jprovazn has quit IRC20:40
*** neelashah1 has quit IRC20:41
*** neelashah1 has joined #openstack-horizon20:43
*** neelashah has quit IRC20:44
*** ducttape_ has joined #openstack-horizon20:45
*** ducttape_ has quit IRC20:45
*** ducttape_ has joined #openstack-horizon20:45
*** neelashah has joined #openstack-horizon20:46
*** neelashah1 has quit IRC20:48
*** lapalm has joined #openstack-horizon20:50
*** david_cu has joined #openstack-horizon20:51
*** crobertsrh1 has joined #openstack-horizon20:53
openstackgerritCindy Lu proposed openstack/horizon: material theme close icon isn't showing up  https://review.openstack.org/24941920:57
hurgleburgler sjmc7 I would happiest with id + class, I can cave on the href requirement, if we _really_ want to also test that, but I def. think we can leave off element type21:00
*** lhcheng_ has quit IRC21:01
sjmc7i’m happy to leave it off. how about text content?21:05
*** tqtran has quit IRC21:07
hurgleburglerI think we should leave that off21:08
hurgleburglerit prevents anyone from changing the content of the anchor21:08
hurgleburglerlike adding or removing an icon21:08
hurgleburglerI can look at how we might be able to just check the context of a template21:08
hurgleburglerinstead of rending the entire template21:09
hurgleburglerbut, that'll have to come a bit later21:09
*** kzaitsev_mb has quit IRC21:10
sjmc7checking the context is easy21:11
sjmc7the tests already have to do that to get at the table data21:11
*** jbell8 has quit IRC21:12
*** errolpais has joined #openstack-horizon21:12
*** kzaitsev_mb has joined #openstack-horizon21:13
*** pauloewerton has quit IRC21:13
hurgleburglerthen can't we just check for the variables to be present in the template context and not require that they get rendered a very specific way on the page?21:16
sjmc7yes21:16
hurgleburglerat least for href and text and things like that?21:16
sjmc7but again, that then doesn’t test the template21:16
sjmc7yes, we could do both21:17
openstackgerritMatt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance  https://review.openstack.org/23683221:17
hurgleburglertesting 'id' tests that the template rendered.21:17
sjmc7yep21:18
sjmc7there’s also not much point testing this for each action of each table since they all use the same code21:18
hurgleburglertesting that 'action.get_link_url' tests the href21:18
hurgleburglerThere should already be a unit test for that function21:18
*** Ala has joined #openstack-horizon21:18
hurgleburgleryeah, its a bunch of redundant testing21:19
sjmc7yep21:19
*** kzaitsev_mb has quit IRC21:21
sjmc7well, i’ll put up a patch just testing ids21:21
hurgleburgler\o/21:21
sjmc7after that, the bikeshedding will have to continue without me21:21
hurgleburglerI'll push it along21:22
openstackgerritMatt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance  https://review.openstack.org/23683221:22
openstackgerritMatt Borland proposed openstack/horizon: WIP Adding Magic Search codebase to Horizon  https://review.openstack.org/24528821:27
openstackgerritSteve McLellan proposed openstack/horizon: Make unit testing HTML more flexible  https://review.openstack.org/24654921:30
*** Ala has quit IRC21:36
*** aorourke is now known as aorourke-afk21:36
*** Ala has joined #openstack-horizon21:36
*** dsneddon_lunch is now known as dsneddon21:38
*** kyleolivo has joined #openstack-horizon21:38
*** jtriley has quit IRC21:40
*** alexvictorchan has quit IRC21:42
*** alexvictorchan has joined #openstack-horizon21:44
neillcno IE9! my life just got so much simpler :)21:47
hurgleburglerIts the best christmas present ever21:47
hurgleburglerno IE10 either, sounds like!21:47
r1chardj0n3s\o/21:49
openstackgerritErrol Pais proposed openstack/horizon: WIP: Launch Instance - Download Private Key  https://review.openstack.org/24944221:49
matt-borlandthanks errolpais21:51
matt-borlandit's now in my list :)21:51
*** SimonChung has joined #openstack-horizon21:56
*** SimonChung1 has quit IRC21:56
*** lhcheng has joined #openstack-horizon21:57
*** SimonChung1 has joined #openstack-horizon22:00
*** SimonChung has quit IRC22:00
*** david_cu has quit IRC22:13
*** jerrygb has quit IRC22:14
*** mpavlase has joined #openstack-horizon22:15
*** jerrygb has joined #openstack-horizon22:15
*** Piet has quit IRC22:16
*** ZZelle_ has joined #openstack-horizon22:18
*** kzaitsev_mb has joined #openstack-horizon22:21
*** crobertsrh1 has quit IRC22:22
*** vgridnev has quit IRC22:24
*** kzaitsev_mb has quit IRC22:26
*** matt-borland has quit IRC22:29
*** Ala has quit IRC22:31
*** jtriley has joined #openstack-horizon22:43
*** doug-fis_ has joined #openstack-horizon22:49
*** fedexo has joined #openstack-horizon22:51
*** doug-fish has quit IRC22:53
*** doug-fis_ has quit IRC22:53
*** lapalm has quit IRC22:55
*** jingjing_ren has joined #openstack-horizon22:55
*** jtriley has quit IRC22:56
*** wuhg has joined #openstack-horizon22:57
*** peristeri has quit IRC22:57
mpavlasemrunge: Hi23:04
*** doug-fish has joined #openstack-horizon23:04
mpavlaser1chardj0n3s: Hi23:08
r1chardj0n3smpavlase: hi23:08
*** doug-fish has quit IRC23:08
*** SimonChung has joined #openstack-horizon23:09
mpavlaser1chardj0n3s: I've a question about Horizon bug day... I'd like to be sure about the etherpad:23:09
*** SimonChung1 has quit IRC23:09
*** david-lyle changes topic to "OpenStack Horizon -- Bug day https://etherpad.openstack.org/p/horizon-bug-day"23:09
r1chardj0n3s(ohai david-lyle ;-)23:09
david-lylehi r1chardj0n3s23:10
david-lylewas grabbing URL and then ended up setting the topic again :D23:10
mpavlaser1chardj0n3s: the purpose is to have discussion about unclear bugs at one place, not as place to list of today's created bugs, isn't it?23:10
r1chardj0n3smpavlase: it's a place to list activity - if you opened, closed or otherwise looked at a bug then list it. it's a score card, really23:11
mpavlaser1chardj0n3s: aha, happy to hear such words, thanks :-) I'm asking, because I've discovered two bugs, and I'm in the middle of writing description of the second one..23:12
*** ZZelle_ has quit IRC23:17
*** jwy has quit IRC23:18
openstackgerritDan Nguyen proposed openstack/horizon: Runs openstack dashboard tests with keystone v2  https://review.openstack.org/24947623:19
*** kyleolivo has quit IRC23:20
*** pumaranikar has quit IRC23:24
*** kyleolivo has joined #openstack-horizon23:28
*** ducttape_ has quit IRC23:29
*** lhcheng_ has joined #openstack-horizon23:29
*** lhcheng has quit IRC23:30
*** willsama has quit IRC23:31
*** jwy has joined #openstack-horizon23:33
*** SimonChung1 has joined #openstack-horizon23:38
*** SimonChung has quit IRC23:38
*** SimonChung1 has quit IRC23:38
*** SimonChung has joined #openstack-horizon23:38
*** SimonChung has quit IRC23:39
*** SimonChung1 has joined #openstack-horizon23:39
*** ducttape_ has joined #openstack-horizon23:40
*** rcernin has quit IRC23:42
*** Drago has quit IRC23:47
*** neelashah1 has joined #openstack-horizon23:52
*** neelashah has quit IRC23:52
openstackgerritDan Nguyen proposed openstack/horizon: Adding download for openrc file for keystone v3  https://review.openstack.org/18684623:56
*** neelashah1 has quit IRC23:56
*** neelashah has joined #openstack-horizon23:57
r1chardj0n3smordred: if you have a moment, please review https://review.openstack.org/#/c/205623/ as we (Horizon community) would very much like to get that progressed23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!