*** openstack has joined #openstack-horizon | 15:44 | |
*** vkmc has joined #openstack-horizon | 15:48 | |
*** e0ne has joined #openstack-horizon | 15:48 | |
*** jprovazn has joined #openstack-horizon | 15:49 | |
*** lapalm_ has joined #openstack-horizon | 15:50 | |
*** bpokorny has joined #openstack-horizon | 15:51 | |
*** lapalm has quit IRC | 15:52 | |
*** jtomasek has joined #openstack-horizon | 15:52 | |
*** bpokorny has quit IRC | 15:52 | |
*** TravT has quit IRC | 15:52 | |
*** amotoki has quit IRC | 15:53 | |
*** agireud has joined #openstack-horizon | 15:53 | |
*** ^Gal^ has joined #openstack-horizon | 15:57 | |
*** hurgleburgler has joined #openstack-horizon | 15:57 | |
*** jasondotstar has joined #openstack-horizon | 15:58 | |
*** TravT has joined #openstack-horizon | 16:01 | |
*** tqtran has joined #openstack-horizon | 16:01 | |
*** e0ne has quit IRC | 16:02 | |
*** btully has quit IRC | 16:05 | |
*** kevinbenton_ has quit IRC | 16:07 | |
*** btully has joined #openstack-horizon | 16:07 | |
*** kevinbenton has joined #openstack-horizon | 16:07 | |
*** david_cu has joined #openstack-horizon | 16:10 | |
*** wolverineav has quit IRC | 16:10 | |
*** SimonChung has quit IRC | 16:12 | |
*** tjones has joined #openstack-horizon | 16:14 | |
openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Add truncated flag support https://review.openstack.org/250869 | 16:14 |
---|---|---|
*** openstackstatus has joined #openstack-horizon | 16:15 | |
*** ChanServ sets mode: +v openstackstatus | 16:15 | |
*** david_cu_ has joined #openstack-horizon | 16:15 | |
*** david_cu has quit IRC | 16:16 | |
*** mohankumar has joined #openstack-horizon | 16:16 | |
*** jtriley has joined #openstack-horizon | 16:19 | |
*** lapalm_ has quit IRC | 16:20 | |
*** david_cu_ has quit IRC | 16:20 | |
*** david_cu has joined #openstack-horizon | 16:21 | |
*** nlahouti has joined #openstack-horizon | 16:24 | |
openstackgerrit | Steve McLellan proposed openstack/horizon: Make unit testing less reliant on HTML fragments https://review.openstack.org/246549 | 16:24 |
*** rhagarty has joined #openstack-horizon | 16:27 | |
*** nlahouti has quit IRC | 16:28 | |
*** lapalm has joined #openstack-horizon | 16:28 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Support volume snapshots and backups pagination https://review.openstack.org/251427 | 16:30 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Add pagination support to the volume page https://review.openstack.org/118450 | 16:33 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Support volume snapshots and backups pagination https://review.openstack.org/251427 | 16:33 |
*** mounica has joined #openstack-horizon | 16:35 | |
*** nlahouti has joined #openstack-horizon | 16:36 | |
*** tjones has left #openstack-horizon | 16:37 | |
*** pvillarruel has joined #openstack-horizon | 16:38 | |
*** pvillarruel is now known as Open_BR | 16:39 | |
Open_BR | Hi, guys anybody here? I need a little of help | 16:39 |
*** chlong has joined #openstack-horizon | 16:40 | |
Open_BR | I am installing horizon by git, but I need use proxy http when I run "python setup.py" | 16:40 |
Open_BR | are there any way use proxy_http when I run python setup.py? | 16:41 |
sjmc7 | Open_BR - pip should respect the http_proxy and https_proxy environment variables | 16:43 |
*** tqtran has quit IRC | 16:44 | |
Open_BR | that's true, but pip install does not work with http_proxy | 16:44 |
*** tqtran has joined #openstack-horizon | 16:44 | |
Open_BR | the correct is use pip --proxy, where I can add this line on setup file? | 16:45 |
*** kmartin has joined #openstack-horizon | 16:53 | |
*** jpomeroy has joined #openstack-horizon | 16:53 | |
*** lhcheng has joined #openstack-horizon | 16:56 | |
*** swebb has quit IRC | 16:56 | |
*** lhcheng has quit IRC | 17:00 | |
*** Open_BR has quit IRC | 17:01 | |
*** ygbo has quit IRC | 17:02 | |
*** Open_BR has joined #openstack-horizon | 17:08 | |
*** tqtran has quit IRC | 17:12 | |
*** tqtran has joined #openstack-horizon | 17:12 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Show a toast with success on instance creation https://review.openstack.org/251476 | 17:12 |
*** JeanBriceCombebi has quit IRC | 17:15 | |
*** lhcheng has joined #openstack-horizon | 17:15 | |
*** SimonChung has joined #openstack-horizon | 17:19 | |
*** rebase has joined #openstack-horizon | 17:19 | |
*** jobewan has joined #openstack-horizon | 17:22 | |
*** Piet has joined #openstack-horizon | 17:22 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Make breadcrumb appear on sec groups and keypair details https://review.openstack.org/251407 | 17:24 |
*** rajatvig has joined #openstack-horizon | 17:25 | |
*** lhcheng_ has joined #openstack-horizon | 17:27 | |
*** gyee has joined #openstack-horizon | 17:28 | |
*** swebb has joined #openstack-horizon | 17:29 | |
*** lhcheng has quit IRC | 17:30 | |
*** kzaitsev_mb has quit IRC | 17:30 | |
*** tqtran has quit IRC | 17:31 | |
*** tqtran has joined #openstack-horizon | 17:32 | |
SurajD | Can somebody please review this https://review.openstack.org/#/c/249662/ | 17:33 |
*** SurajD has quit IRC | 17:35 | |
*** errolpais has joined #openstack-horizon | 17:37 | |
*** rdopiera has quit IRC | 17:41 | |
*** nlahouti has quit IRC | 17:47 | |
*** rajatvig has quit IRC | 17:56 | |
*** nlahouti has joined #openstack-horizon | 17:58 | |
tqtran | TravT: why did we make release note as follow on? that doesn't make a lot of sense to me | 18:00 |
tqtran | if someone wanted to backport a patch, they would have to backport 2 patches now? | 18:00 |
*** vgridnev has joined #openstack-horizon | 18:07 | |
TravT | tqtran: that is a good point. I definitely agree it is best practice | 18:08 |
*** aix has quit IRC | 18:09 | |
*** harlowja has joined #openstack-horizon | 18:10 | |
*** chlong has quit IRC | 18:10 | |
*** mohankumar has quit IRC | 18:11 | |
TravT | actually, i'm wondering about the release note... | 18:11 |
TravT | if it should be separate. | 18:11 |
*** sambetts is now known as sambetts-afk | 18:11 | |
TravT | i don't know how these will end up getting published | 18:11 |
tqtran | I think the only time release notes should be a follow on patch is if there is are multiple patches that needs to get in before a release note is submitted | 18:11 |
TravT | i mean, if they are backported, will they show up in the right published location for stable releases? | 18:12 |
TravT | dhellmann: are you around? | 18:12 |
TravT | question on release notes and backporting | 18:12 |
tqtran | that i dont know, but it doesn't hurt to have the release note nevertheless, i think you're just creating more problems by having it separate | 18:13 |
dhellmann | TravT : here | 18:13 |
TravT | is it best practice to include the release note with a patch or as a separate patch? just wondering how this might affect release notes being backported | 18:13 |
TravT | and that the release notes show up for the right release. | 18:13 |
dhellmann | TravT, tqtran : reno looks at the files and tags in the git history to figure out which notes exist in which versions of the software | 18:13 |
dhellmann | you should put your notes in the branches where the code is, before tagging the release | 18:14 |
dhellmann | it doesn't matter if that's a separate patch, but it's simpler in a lot of cases to do it that way, especially because of the backporting question | 18:14 |
TravT | okay, cool. that's good to know. | 18:14 |
dhellmann | we built a tool to try to keep this simple, so if you put the note in with the code change you're lives will be easier | 18:15 |
dhellmann | :-) | 18:15 |
*** jpomeroy has quit IRC | 18:15 | |
tqtran | i think we should amend the release notes docs to reflect this | 18:15 |
TravT | tqtran: i'll put that up now | 18:15 |
tqtran | cool thanks | 18:15 |
*** neillc has quit IRC | 18:17 | |
*** flwang has quit IRC | 18:17 | |
*** freyes has quit IRC | 18:18 | |
*** neillc has joined #openstack-horizon | 18:18 | |
*** tqtran has quit IRC | 18:19 | |
*** swebb has quit IRC | 18:19 | |
*** tqtran has joined #openstack-horizon | 18:19 | |
*** nlahouti has quit IRC | 18:20 | |
*** rajatvig has joined #openstack-horizon | 18:20 | |
*** davidlenwell has quit IRC | 18:21 | |
*** matt-borland has joined #openstack-horizon | 18:22 | |
matt-borland | TravT, sorry, late to the conversation due to proxy problem :) | 18:22 |
*** freyes has joined #openstack-horizon | 18:22 | |
*** davidlenwell has joined #openstack-horizon | 18:23 | |
*** Guest83268 has quit IRC | 18:23 | |
matt-borland | I'm happy to put the release note in the patch | 18:23 |
*** nlahouti has joined #openstack-horizon | 18:23 | |
*** jamespd has quit IRC | 18:25 | |
*** brad[] has quit IRC | 18:25 | |
*** chlong has joined #openstack-horizon | 18:26 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 18:27 |
*** yamamoto has quit IRC | 18:27 | |
*** petertr7 is now known as petertr7_away | 18:27 | |
*** mgagne has joined #openstack-horizon | 18:28 | |
*** mgagne is now known as Guest63453 | 18:28 | |
*** doug-fish has quit IRC | 18:28 | |
matt-borland | TravT, tqtran : I merged the release notes into https://review.openstack.org/#/c/236832/ ...no other changes. | 18:30 |
*** jingjing_ren has joined #openstack-horizon | 18:31 | |
*** jingjing_ren has joined #openstack-horizon | 18:31 | |
*** jingjing_ren has quit IRC | 18:31 | |
*** jamespd has joined #openstack-horizon | 18:31 | |
*** jingjing_ren has joined #openstack-horizon | 18:32 | |
*** lhcheng_ has quit IRC | 18:32 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: Improve release notes guidance - single patch https://review.openstack.org/251501 | 18:34 |
TravT | tqtran: ^ | 18:35 |
*** brad[] has joined #openstack-horizon | 18:36 | |
*** tosky has quit IRC | 18:36 | |
*** flwang has joined #openstack-horizon | 18:38 | |
*** Guest63453 has quit IRC | 18:38 | |
*** Guest63453 has joined #openstack-horizon | 18:38 | |
*** Guest63453 is now known as mgagne | 18:39 | |
*** swebb has joined #openstack-horizon | 18:42 | |
openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Refactor d-o-a to use keystoneauth library https://review.openstack.org/205251 | 18:48 |
*** rajatvig has quit IRC | 18:50 | |
*** wolverineav has joined #openstack-horizon | 18:50 | |
*** rajatvig has joined #openstack-horizon | 18:52 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 18:52 |
*** jpomeroy has joined #openstack-horizon | 18:55 | |
Piet | UX Cores: LBaaS edit workflows. Please review and -2 / +2 invis.io/59524AX4J | 18:56 |
*** tyagiprince has joined #openstack-horizon | 18:58 | |
*** wolverineav has quit IRC | 18:59 | |
*** lapalm_ has joined #openstack-horizon | 19:00 | |
*** lapalm__ has joined #openstack-horizon | 19:02 | |
*** lapalm has quit IRC | 19:02 | |
*** lapalm_ has quit IRC | 19:04 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Remove the truncate function from horizon.quota.js https://review.openstack.org/219841 | 19:06 |
*** tyagiprince has quit IRC | 19:10 | |
*** ducttape_ has quit IRC | 19:10 | |
*** tyagiprince has joined #openstack-horizon | 19:10 | |
*** neelashah has joined #openstack-horizon | 19:10 | |
*** btully has quit IRC | 19:10 | |
*** btully has joined #openstack-horizon | 19:11 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 19:17 |
*** petertr7_away is now known as petertr7 | 19:18 | |
*** ducttape_ has joined #openstack-horizon | 19:23 | |
*** tyagiprince has quit IRC | 19:27 | |
*** yamamoto has joined #openstack-horizon | 19:28 | |
*** lhcheng has joined #openstack-horizon | 19:29 | |
*** garthb has joined #openstack-horizon | 19:30 | |
*** neelashah has quit IRC | 19:31 | |
*** yamamoto has quit IRC | 19:33 | |
*** petertr7 is now known as petertr7_away | 19:33 | |
r1chardj0n3s | morning | 19:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add button to Create new Flavor https://review.openstack.org/234875 | 19:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel Edit Subflow https://review.openstack.org/234874 | 19:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel https://review.openstack.org/234873 | 19:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 19:34 |
rajatvig | morning | 19:35 |
*** SimonChung has quit IRC | 19:35 | |
*** SimonChung1 has joined #openstack-horizon | 19:35 | |
r1chardj0n3s | ohai rajatvig | 19:35 |
r1chardj0n3s | tqtran: re https://review.openstack.org/#/c/251205/ I think I'd like to see the fix for that bug go in as a separate patch, rather than it go in as part of a mega (unrelated) patch, better chance of backporting, etc. what do you think? | 19:36 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular admin images panel https://review.openstack.org/230150 | 19:40 |
*** petertr7_away is now known as petertr7 | 19:42 | |
*** garthb has quit IRC | 19:45 | |
*** garthb_ has joined #openstack-horizon | 19:45 | |
*** SimonChung1 has quit IRC | 19:47 | |
*** SimonChung has joined #openstack-horizon | 19:47 | |
*** garthb_ has quit IRC | 19:56 | |
*** tqtran has quit IRC | 19:57 | |
*** garthb has joined #openstack-horizon | 19:57 | |
*** tqtran has joined #openstack-horizon | 19:57 | |
tqtran | r1chardj0n3s: yeah, i think a separate patch for it makes sense | 19:59 |
tqtran | ok now i remember why you need the isFinished in the after_submit | 20:00 |
tqtran | after you submit, there is still potential for errors to occur, and the toast will display it | 20:01 |
*** kzaitsev_mb has joined #openstack-horizon | 20:01 | |
tqtran | but if you dont have it reset, you will no longer be able to submit | 20:01 |
r1chardj0n3s | even after the modal's closed? | 20:01 |
tqtran | i dont want to lose all of my work if an error occurs | 20:02 |
tqtran | it shouldn't close the form on error | 20:02 |
r1chardj0n3s | sure, but the close() has been invoked | 20:02 |
r1chardj0n3s | so I re-enable the button if an error is displayed, definitely | 20:03 |
tqtran | hm.... yeah close is being called.... not sure why when i tested mine, it didnt | 20:04 |
tqtran | i mean, it shouldn't... that would be really bad | 20:04 |
r1chardj0n3s | close should close, yes :-) | 20:04 |
tqtran | =/ no idea, but im fine with the patch | 20:05 |
r1chardj0n3s | thanks! | 20:06 |
tqtran | what do you think of having that logic inside the controller instead of the template though? | 20:06 |
r1chardj0n3s | no user feedback | 20:06 |
r1chardj0n3s | I like there being some user feedback that something happened when they pressed the button | 20:06 |
tqtran | ah... | 20:07 |
r1chardj0n3s | otherwise, with sufficient slow processing, they can just sit pressing the button wondering why nothing's happenening :-) | 20:07 |
tqtran | ok done deal sir. | 20:07 |
r1chardj0n3s | cool | 20:07 |
tqtran | ok last nit pick, should we rename isFinished to something else? | 20:09 |
r1chardj0n3s | *shrug* ideas? :-) | 20:09 |
*** lapalm__ has quit IRC | 20:09 | |
tqtran | inProgress is a bit more intuitive? | 20:09 |
tqtran | isSubmitting? | 20:10 |
r1chardj0n3s | I like isSubmitting | 20:10 |
tqtran | ok :P thats what i used for mine | 20:10 |
tqtran | perfecto | 20:10 |
*** lapalm_ has joined #openstack-horizon | 20:14 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Disable angular wizard finish button when clicked https://review.openstack.org/251205 | 20:14 |
*** doug-fish has joined #openstack-horizon | 20:14 | |
*** ongk has joined #openstack-horizon | 20:16 | |
tqtran | i'll +2 it once it passes gate | 20:16 |
*** freyes has left #openstack-horizon | 20:17 | |
*** jwy has joined #openstack-horizon | 20:19 | |
r1chardj0n3s | cheers | 20:20 |
*** rajatvig has quit IRC | 20:21 | |
*** pauloewerton has left #openstack-horizon | 20:24 | |
*** pauloewerton has joined #openstack-horizon | 20:25 | |
*** jwy has quit IRC | 20:25 | |
*** rajatvig has joined #openstack-horizon | 20:27 | |
*** kzaitsev_mb has quit IRC | 20:27 | |
*** neelashah has joined #openstack-horizon | 20:28 | |
*** nlahouti has quit IRC | 20:29 | |
*** jwy has joined #openstack-horizon | 20:29 | |
*** garthb has quit IRC | 20:30 | |
*** wznoinsk has left #openstack-horizon | 20:31 | |
*** adelia has joined #openstack-horizon | 20:31 | |
*** neelashah has quit IRC | 20:38 | |
*** doug-fish has quit IRC | 20:51 | |
*** belmoreira has joined #openstack-horizon | 20:53 | |
*** doug-fish has joined #openstack-horizon | 20:54 | |
*** doug-fis_ has joined #openstack-horizon | 20:55 | |
*** mfisch` has quit IRC | 20:56 | |
*** mfisch has joined #openstack-horizon | 20:57 | |
*** mfisch is now known as Guest7150 | 20:57 | |
*** doug-fi__ has joined #openstack-horizon | 20:57 | |
*** pauloewerton has left #openstack-horizon | 20:57 | |
*** pauloewerton has quit IRC | 20:57 | |
*** doug-fish has quit IRC | 20:58 | |
*** doug-fis_ has quit IRC | 21:00 | |
*** Guest7150 has quit IRC | 21:01 | |
*** doug-fi__ has quit IRC | 21:02 | |
*** lhcheng has quit IRC | 21:03 | |
*** Piet has quit IRC | 21:04 | |
*** doug-fish has joined #openstack-horizon | 21:04 | |
*** Drago has quit IRC | 21:06 | |
*** doug-fish has quit IRC | 21:09 | |
*** saksham has joined #openstack-horizon | 21:12 | |
*** vgridnev has quit IRC | 21:13 | |
*** jcooley has quit IRC | 21:23 | |
*** jcooley has joined #openstack-horizon | 21:25 | |
*** rajatvig has quit IRC | 21:28 | |
*** jprovazn has quit IRC | 21:30 | |
*** doug-fish has joined #openstack-horizon | 21:32 | |
*** doug-fis_ has joined #openstack-horizon | 21:35 | |
*** doug-fis_ has quit IRC | 21:35 | |
*** Open_BR has quit IRC | 21:35 | |
*** doug-fis_ has joined #openstack-horizon | 21:35 | |
*** clu_ has joined #openstack-horizon | 21:37 | |
*** doug-fish has quit IRC | 21:37 | |
*** rajatvig has joined #openstack-horizon | 21:37 | |
*** Piet has joined #openstack-horizon | 21:41 | |
*** lapalm_ has quit IRC | 21:41 | |
*** tqtran has quit IRC | 21:44 | |
*** tqtran has joined #openstack-horizon | 21:44 | |
*** mfisch has joined #openstack-horizon | 21:48 | |
*** mfisch has quit IRC | 21:48 | |
*** mfisch has joined #openstack-horizon | 21:48 | |
*** vgridnev has joined #openstack-horizon | 21:53 | |
*** petertr7 is now known as petertr7_away | 21:55 | |
*** nlahouti has joined #openstack-horizon | 22:00 | |
*** lapalm has joined #openstack-horizon | 22:01 | |
*** matt-borland has quit IRC | 22:03 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular admin images panel https://review.openstack.org/230150 | 22:06 |
*** crobertsrh is now known as _crobertsrh | 22:07 | |
tqtran | rajatvig: around? | 22:09 |
*** julim has quit IRC | 22:16 | |
*** ducttape_ has quit IRC | 22:16 | |
*** robcresswell has quit IRC | 22:17 | |
*** nlahouti has quit IRC | 22:18 | |
*** robcresswell has joined #openstack-horizon | 22:18 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 22:20 |
*** neelashah has joined #openstack-horizon | 22:21 | |
*** mpavlase has quit IRC | 22:21 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Give material theme modals more room https://review.openstack.org/250607 | 22:23 |
*** ZZelle has joined #openstack-horizon | 22:23 | |
rajatvig | yes | 22:24 |
rajatvig | tqtran: got in today. back to work :) | 22:25 |
*** neelashah has quit IRC | 22:26 | |
*** vgridnev has quit IRC | 22:27 | |
*** vijendar has quit IRC | 22:34 | |
*** neelashah has joined #openstack-horizon | 22:34 | |
*** adelia_ has joined #openstack-horizon | 22:37 | |
*** jtriley has quit IRC | 22:40 | |
*** adelia has quit IRC | 22:41 | |
*** btully has quit IRC | 22:41 | |
*** adelia_ has quit IRC | 22:42 | |
*** neelashah has quit IRC | 22:43 | |
*** btully has joined #openstack-horizon | 22:43 | |
*** doug-fis_ has quit IRC | 22:44 | |
*** doug-fish has joined #openstack-horizon | 22:44 | |
*** jpomeroy has quit IRC | 22:46 | |
*** lapalm has quit IRC | 22:47 | |
*** nlahouti has joined #openstack-horizon | 22:48 | |
*** doug-fish has quit IRC | 22:49 | |
*** doug-fish has joined #openstack-horizon | 22:49 | |
*** ongk has quit IRC | 22:50 | |
*** doug-fis_ has joined #openstack-horizon | 22:50 | |
*** doug-fish has quit IRC | 22:54 | |
*** doug-fis_ has quit IRC | 22:55 | |
*** mounica has quit IRC | 22:56 | |
*** jobewan has quit IRC | 22:57 | |
*** doug-fish has joined #openstack-horizon | 23:03 | |
*** clu_ has quit IRC | 23:04 | |
*** ducttape_ has joined #openstack-horizon | 23:04 | |
*** doug-fish has quit IRC | 23:07 | |
rajatvig | hi folks, I fixed some of the lint errors in openstack_dashboard/static/ . Is there a blueprint I can use for the work? | 23:07 |
rajatvig | Or do I create a new bug and mark it against that? | 23:07 |
*** tqtran has quit IRC | 23:16 | |
*** Ephur has quit IRC | 23:20 | |
*** peristeri has quit IRC | 23:23 | |
rajatvig | Anyone know? | 23:32 |
*** ZZelle has quit IRC | 23:33 | |
r1chardj0n3s | sorry rajatvig, nothing comes to mind | 23:34 |
rajatvig | thanks. I'll log a bug and push against that | 23:34 |
r1chardj0n3s | so this is new linting errors? | 23:34 |
rajatvig | r1chardj0n3s: when I run npm lint, there's lots of warnings thrown. I fixed some of them. Mostly to with brace alignment. | 23:35 |
rajatvig | reduces the noise. | 23:36 |
r1chardj0n3s | ahh, this is fixing warnings | 23:37 |
rajatvig | yes | 23:37 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Fix some lint warnings in openstack_dashboard/static/app/ https://review.openstack.org/251583 | 23:39 |
*** jerrygb has quit IRC | 23:39 | |
*** jerrygb has joined #openstack-horizon | 23:39 | |
*** cbader has joined #openstack-horizon | 23:41 | |
*** david_cu has quit IRC | 23:43 | |
*** Ephur has joined #openstack-horizon | 23:44 | |
*** nlahouti has quit IRC | 23:46 | |
*** nlahouti has joined #openstack-horizon | 23:53 | |
*** docaedo has joined #openstack-horizon | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!