| *** chestack has joined #openstack-horizon | 00:00 | |
| *** e0ne_ has quit IRC | 00:00 | |
| *** ongk has quit IRC | 00:00 | |
| *** lhcheng has quit IRC | 00:03 | |
| *** ZZelle has quit IRC | 00:06 | |
| doug-fish | ducttape_: you avail to argue about https://review.openstack.org/#/c/244444/? | 00:15 |
|---|---|---|
| doug-fish | ugh - I guess I'm not available to argue either. But we should. | 00:16 |
| *** jerrygb has joined #openstack-horizon | 00:16 | |
| *** btully has quit IRC | 00:17 | |
| *** yamamoto has joined #openstack-horizon | 00:22 | |
| *** btully has joined #openstack-horizon | 00:24 | |
| *** ajmiller has joined #openstack-horizon | 00:24 | |
| *** nlahouti1 has joined #openstack-horizon | 00:32 | |
| *** nlahouti has quit IRC | 00:32 | |
| *** btully has quit IRC | 00:38 | |
| *** ajmiller has quit IRC | 00:38 | |
| *** nlahouti1 has quit IRC | 00:38 | |
| *** nlahouti has joined #openstack-horizon | 00:40 | |
| ducttape_ | doug-fish still there? | 00:41 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 00:43 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 00:44 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 00:45 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 00:45 |
| *** zhenguo has joined #openstack-horizon | 00:45 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 00:45 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 00:46 |
| *** rajatvig has quit IRC | 00:50 | |
| *** btully has joined #openstack-horizon | 00:51 | |
| *** ctina_ has joined #openstack-horizon | 00:55 | |
| *** jpomeroy has quit IRC | 00:59 | |
| *** yamamoto has quit IRC | 01:00 | |
| *** ctina_ has quit IRC | 01:00 | |
| *** nlahouti has quit IRC | 01:03 | |
| doug-fish | ducttape_: here now | 01:05 |
| ducttape_ | hey | 01:05 |
| doug-fish | so ... how are things? | 01:05 |
| ducttape_ | yeah, I guess I'm ok with that approach for add-in install. | 01:05 |
| doug-fish | oh cool | 01:05 |
| doug-fish | that's too easy | 01:05 |
| ducttape_ | it's not how we do stuff, but we can adjust | 01:05 |
| doug-fish | which "we"? | 01:06 |
| ducttape_ | the bigger thing is getting everything on the same page, and updates to any distro installers, if needed | 01:06 |
| ducttape_ | we - > TWC | 01:06 |
| doug-fish | got it | 01:06 |
| doug-fish | I assume the TWC approach is what you had documented? | 01:06 |
| ducttape_ | I know if we have a shared folder, that others modify, that is typically not in this kind of location | 01:07 |
| ducttape_ | yes, something like that is what I documented | 01:07 |
| doug-fish | maybe /etc/something would be a more expected location? | 01:07 |
| ducttape_ | yes, I think so. we would need to get the python path to pickup that location too, if we keep these as python files | 01:08 |
| doug-fish | I actually tried the approach you had documented and it didn't work for me - I had some sort of SECRET_KEY related error .. does that sound familiar? | 01:09 |
| ducttape_ | so it's not insurmountable, but right now there is some hand waiving and generous use of "todo" items | 01:09 |
| doug-fish | oh yeah | 01:09 |
| doug-fish | absolutely agreed | 01:09 |
| ducttape_ | the secret_key item usually is b/c horizon / apache is running as a user that is trying to write to a folder they don't have perms for | 01:10 |
| ducttape_ | you should be able to specify a SECRET_KEY in your local settings.py and get around that | 01:10 |
| doug-fish | hmm, yeah I had that ... maybe a perm problem that I hadn't sorted out | 01:10 |
| ducttape_ | just hard code SECRET_KEY | 01:11 |
| ducttape_ | something like SECRET_KEY = | 01:11 |
| ducttape_ | doh! | 01:11 |
| ducttape_ | SECRET_KEY = 'dougsKey' | 01:11 |
| doug-fish | :-O how did you know! | 01:11 |
| ducttape_ | for your own testing etc | 01:11 |
| doug-fish | oh | 01:11 |
| doug-fish | I thought the local_settings example file did something reasonable | 01:12 |
| ducttape_ | it just is the key that the session gets serialized with. for upstream devs, they probably don't need to care about that | 01:12 |
| doug-fish | (going to look) | 01:12 |
| *** mtanino has quit IRC | 01:12 | |
| ducttape_ | it tries to generate a random key and place it on the filesystem or something fancy | 01:12 |
| ducttape_ | it's kind of too smart for it's own good | 01:13 |
| doug-fish | I sense you aren't a believer in that process? | 01:13 |
| *** Daisy has joined #openstack-horizon | 01:13 | |
| ducttape_ | https://github.com/openstack/horizon/blob/4de120386aed56168284e649428d1a590c4d82c1/openstack_dashboard/local/local_settings.py.example#L106 | 01:13 |
| ducttape_ | well, if you are going to deploy horizon in a large setup, you'd never use that approach | 01:14 |
| doug-fish | understood | 01:14 |
| doug-fish | I assume you really do hardcode the SECRET_KEY to something? | 01:14 |
| ducttape_ | you need to coordinate keys across machines etc... its just a bell/whistle that is not really needed. | 01:14 |
| ducttape_ | ideally you'd use puppet, have puppet encrypt them in encrypted yaml... etc | 01:15 |
| doug-fish | oh sure | 01:15 |
| doug-fish | that would be cool :-) | 01:15 |
| ducttape_ | or some type of tool to coordinate the setup and deployment, and protect them etc | 01:15 |
| ducttape_ | so that code in horizon, it's a feature looking for a problem.... but I digress | 01:16 |
| *** btully has quit IRC | 01:17 | |
| ducttape_ | https://github.com/openstack/puppet-horizon/blob/master/README.md#beginning-with-horizon is the puppet docs for that, fwiw | 01:17 |
| *** Daisy has quit IRC | 01:18 | |
| doug-fish | thx | 01:18 |
| doug-fish | ... did the python based lbaas v2 wizard actually work? I never got it to create load balancers | 01:18 |
| ducttape_ | neither did I. It has some opportunities, I believe. ;) | 01:19 |
| doug-fish | yeah, but I'm afraid they are going to become opportunities for replacement. | 01:19 |
| ducttape_ | well, it's something that creates the basic parts of the UI. it's something. I would like to have more time to rewrite that / finish it off, but wishes don't really pay the bills | 01:21 |
| ducttape_ | :'( | 01:21 |
| doug-fish | yeah understood | 01:21 |
| *** btully has joined #openstack-horizon | 01:23 | |
| *** cody-somerville has quit IRC | 01:29 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 01:29 |
| *** SimonChung1 has quit IRC | 01:30 | |
| *** tjones has quit IRC | 01:34 | |
| *** jingjing_ren has quit IRC | 01:35 | |
| *** cody-somerville has joined #openstack-horizon | 01:36 | |
| *** btully has quit IRC | 01:37 | |
| *** btully has joined #openstack-horizon | 01:39 | |
| *** RA has joined #openstack-horizon | 01:42 | |
| *** RA is now known as Guest79212 | 01:42 | |
| *** kzaitsev_mb has quit IRC | 01:42 | |
| *** jerrygb has quit IRC | 01:50 | |
| *** lhcheng has joined #openstack-horizon | 01:51 | |
| *** jerrygb has joined #openstack-horizon | 01:55 | |
| *** lhcheng has quit IRC | 01:56 | |
| *** btully has quit IRC | 01:57 | |
| *** doug-fish has quit IRC | 01:59 | |
| *** doug-fish has joined #openstack-horizon | 01:59 | |
| *** doug-fish has quit IRC | 01:59 | |
| *** doug-fish has joined #openstack-horizon | 02:00 | |
| *** SlickN1k has joined #openstack-horizon | 02:03 | |
| *** saksham has quit IRC | 02:09 | |
| openstackgerrit | Merged openstack/horizon: Add API to Create/Update/Delete Images in Glance https://review.openstack.org/236832 | 02:28 |
| *** david-lyle has joined #openstack-horizon | 02:31 | |
| *** ChanServ sets mode: +o david-lyle | 02:31 | |
| *** doug-fish has quit IRC | 02:34 | |
| *** doug-fish has joined #openstack-horizon | 02:34 | |
| *** doug-fish has quit IRC | 02:39 | |
| *** SurajD has joined #openstack-horizon | 02:46 | |
| *** chestack has quit IRC | 02:50 | |
| *** SimonChung has joined #openstack-horizon | 02:58 | |
| *** jwy has left #openstack-horizon | 02:59 | |
| *** david-lyle has quit IRC | 03:00 | |
| *** SimonChung1 has joined #openstack-horizon | 03:00 | |
| *** SimonChung has quit IRC | 03:02 | |
| *** chestack has joined #openstack-horizon | 03:06 | |
| *** Guest79212 has quit IRC | 03:06 | |
| *** gyee has quit IRC | 03:16 | |
| *** yamamoto has joined #openstack-horizon | 03:16 | |
| *** btully has joined #openstack-horizon | 03:25 | |
| *** ducttape_ has quit IRC | 03:32 | |
| *** jerrygb has quit IRC | 03:34 | |
| *** jerrygb has joined #openstack-horizon | 03:34 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: WIP Horizon Checkboxes are now themeable. https://review.openstack.org/252161 | 03:36 |
| *** jtriley has joined #openstack-horizon | 03:38 | |
| *** jerrygb has quit IRC | 03:39 | |
| *** ducttape_ has joined #openstack-horizon | 03:47 | |
| *** ducttape_ has quit IRC | 03:48 | |
| *** ducttape_ has joined #openstack-horizon | 03:48 | |
| *** hurgleburgler has quit IRC | 03:50 | |
| *** vijendar has quit IRC | 03:52 | |
| *** jbell8 has joined #openstack-horizon | 04:31 | |
| *** SurajD has quit IRC | 04:31 | |
| *** SurajD has joined #openstack-horizon | 04:34 | |
| *** ducttape_ has quit IRC | 04:41 | |
| *** david-lyle has joined #openstack-horizon | 04:44 | |
| *** ChanServ sets mode: +o david-lyle | 04:44 | |
| *** crobertsrh is now known as _crobertsrh | 04:46 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add function to re-create ec2 credential https://review.openstack.org/252190 | 05:07 |
| *** ducttape_ has joined #openstack-horizon | 05:10 | |
| *** darrenc is now known as darrenc_afk | 05:10 | |
| *** mohankumar has joined #openstack-horizon | 05:13 | |
| *** mohankumar has quit IRC | 05:18 | |
| *** ducttape_ has quit IRC | 05:18 | |
| *** amotoki has joined #openstack-horizon | 05:20 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for Metadata Definitions https://review.openstack.org/215721 | 05:23 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 05:23 |
| *** rajatvig has joined #openstack-horizon | 05:24 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for Metadata Definitions https://review.openstack.org/215721 | 05:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 05:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 05:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 05:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 05:27 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 05:28 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 05:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 05:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 05:29 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 05:29 |
| *** mohankumar has joined #openstack-horizon | 05:30 | |
| *** darrenc_afk is now known as darrenc | 05:32 | |
| *** mohankumar has quit IRC | 05:36 | |
| *** btully has quit IRC | 05:46 | |
| *** hurgleburgler has joined #openstack-horizon | 05:47 | |
| *** mohankumar has joined #openstack-horizon | 05:48 | |
| *** rcernin has joined #openstack-horizon | 05:52 | |
| *** mohankumar has quit IRC | 05:53 | |
| *** masco has joined #openstack-horizon | 05:55 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add extensions to $q for resolving all promises https://review.openstack.org/240589 | 05:56 |
| *** chestack has quit IRC | 05:59 | |
| *** sanjana has joined #openstack-horizon | 06:00 | |
| *** nlahouti has joined #openstack-horizon | 06:01 | |
| *** btully has joined #openstack-horizon | 06:05 | |
| *** mohankumar has joined #openstack-horizon | 06:07 | |
| *** jtriley has quit IRC | 06:08 | |
| *** chestack has joined #openstack-horizon | 06:13 | |
| *** mohankumar has quit IRC | 06:13 | |
| *** SurajD has quit IRC | 06:14 | |
| *** hurgleburgler has quit IRC | 06:14 | |
| *** harlowja has quit IRC | 06:16 | |
| *** SimonChung1 has quit IRC | 06:16 | |
| *** SurajD has joined #openstack-horizon | 06:16 | |
| *** chestack has quit IRC | 06:20 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/252204 | 06:20 |
| *** chestack has joined #openstack-horizon | 06:20 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Transfer table should update allocatedIds when allocated changes https://review.openstack.org/252205 | 06:20 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Transfer table should update allocatedIds when allocated changes https://review.openstack.org/252205 | 06:21 |
| *** mohankumar has joined #openstack-horizon | 06:25 | |
| *** rcernin has quit IRC | 06:25 | |
| *** mohankumar has quit IRC | 06:29 | |
| openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 06:30 |
| *** SimonChung has joined #openstack-horizon | 06:33 | |
| *** sanjana has quit IRC | 06:35 | |
| openstackgerrit | Di XiaoLi proposed openstack/horizon: Add handle get_file when launch stack from horizon https://review.openstack.org/241700 | 06:40 |
| *** mohankumar has joined #openstack-horizon | 06:41 | |
| *** mohankumar has quit IRC | 06:46 | |
| *** nlahouti has quit IRC | 06:47 | |
| *** nlahouti has joined #openstack-horizon | 06:48 | |
| *** rajatvig has quit IRC | 06:49 | |
| *** nlahouti1 has joined #openstack-horizon | 06:52 | |
| *** nlahouti has quit IRC | 06:52 | |
| *** SurajD has quit IRC | 06:55 | |
| *** nlahouti has joined #openstack-horizon | 06:55 | |
| *** nlahouti1 has quit IRC | 06:56 | |
| *** SurajD has joined #openstack-horizon | 06:56 | |
| *** mohankumar has joined #openstack-horizon | 06:59 | |
| *** nlahouti has quit IRC | 07:02 | |
| *** nlahouti has joined #openstack-horizon | 07:02 | |
| *** mohankumar has quit IRC | 07:05 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding angular QoS panel in horizon https://review.openstack.org/247997 | 07:07 |
| *** zhenguo has quit IRC | 07:07 | |
| *** rcernin has joined #openstack-horizon | 07:09 | |
| openstackgerrit | celik esra proposed openstack/horizon: Volume limits and floating ip graphic label consistency https://review.openstack.org/251237 | 07:15 |
| *** mohankumar has joined #openstack-horizon | 07:16 | |
| *** aortega_ has quit IRC | 07:16 | |
| *** jerrygb has joined #openstack-horizon | 07:21 | |
| *** SurajD has quit IRC | 07:22 | |
| *** mohankumar has quit IRC | 07:22 | |
| *** SurajD has joined #openstack-horizon | 07:25 | |
| *** jerrygb has quit IRC | 07:25 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add function to re-create ec2 credential https://review.openstack.org/252190 | 07:26 |
| *** mohankumar has joined #openstack-horizon | 07:30 | |
| *** mohankumar has quit IRC | 07:36 | |
| *** itxaka has joined #openstack-horizon | 07:55 | |
| *** nlahouti1 has joined #openstack-horizon | 07:56 | |
| *** nlahouti has quit IRC | 07:59 | |
| *** yamamoto_ has joined #openstack-horizon | 08:06 | |
| *** nlahouti1 has quit IRC | 08:08 | |
| *** yamamoto has quit IRC | 08:08 | |
| *** nlahouti has joined #openstack-horizon | 08:09 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 08:10 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 08:10 |
| *** nlahouti1 has joined #openstack-horizon | 08:11 | |
| *** nlahouti has quit IRC | 08:12 | |
| *** nlahouti1 has quit IRC | 08:16 | |
| *** vgridnev has joined #openstack-horizon | 08:22 | |
| *** btully has quit IRC | 08:35 | |
| *** aortega has joined #openstack-horizon | 08:37 | |
| *** mpavlase has joined #openstack-horizon | 08:43 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 08:47 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image metadata when using v2 https://review.openstack.org/251704 | 08:47 |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding angular QoS panel in horizon https://review.openstack.org/247997 | 08:48 |
| *** btully has joined #openstack-horizon | 08:52 | |
| *** lhcheng has joined #openstack-horizon | 08:54 | |
| *** oetrog has joined #openstack-horizon | 08:57 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Add launchpad link to the plugin registry list https://review.openstack.org/252272 | 09:01 |
| *** kzaitsev_mb has joined #openstack-horizon | 09:04 | |
| *** ygbo has joined #openstack-horizon | 09:04 | |
| *** rdopiera has joined #openstack-horizon | 09:05 | |
| *** btully has quit IRC | 09:06 | |
| *** oetrog has quit IRC | 09:12 | |
| *** oetrog has joined #openstack-horizon | 09:12 | |
| *** oetrog has quit IRC | 09:14 | |
| *** oetrog has joined #openstack-horizon | 09:14 | |
| *** raginbajin has joined #openstack-horizon | 09:17 | |
| *** vgridnev has quit IRC | 09:20 | |
| *** tyagiprince has joined #openstack-horizon | 09:21 | |
| *** aix has joined #openstack-horizon | 09:21 | |
| *** SlickNik has quit IRC | 09:23 | |
| *** SlickN1k is now known as SlickNik | 09:23 | |
| *** mohankumar has joined #openstack-horizon | 09:23 | |
| tyagiprince | Hey people.. I am having problem in fetching users from active directory.. when I run the openstack user list command, it takes around 15 to 20 seconds to list the users.. whereas when I open the Users tab inside the identity panel, it takes around a minute or two.. | 09:24 |
| tyagiprince | So What step should I take? I am thinking about changing the horizon code and fetch only the first 100 users and then on filtering the results through horizon, the user list should update itself in horizon and still show me the best 100 results matching the criteria.. | 09:24 |
| *** kzaitsev_mb has quit IRC | 09:25 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 09:26 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image when using v2 https://review.openstack.org/251672 | 09:26 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix update image metadata when using v2 https://review.openstack.org/251704 | 09:26 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix creating instance when using image v2 https://review.openstack.org/252282 | 09:26 |
| mrunge | tyagiprince, horizon does not talk to active directory | 09:26 |
| mrunge | but keystone does | 09:26 |
| mrunge | tyagiprince, how many users do you have in your ad? | 09:27 |
| mrunge | > 500? | 09:27 |
| tyagiprince | mrunge: Yes more than 10000... | 09:27 |
| mrunge | ok, that's an ad issue | 09:27 |
| *** SlickNik has left #openstack-horizon | 09:27 | |
| mrunge | tyagiprince, you should get in touch with keystone folks and with Microsoft make them fix their AD | 09:28 |
| *** mohankumar has quit IRC | 09:28 | |
| tyagiprince | mrunge, If there is a resolution available by which I can cache the users and use it from there.. That would be great | 09:28 |
| tyagiprince | But since keystone fetches the users in 15 seconds.. | 09:28 |
| tyagiprince | mrunge, it is horizon taking time to display the users.. cuz I think horizon takes time to display the users in formatted css and for so many users, it has to do a lot of work.. | 09:29 |
| mrunge | ah, sorry, read you wrong here | 09:29 |
| mrunge | tyagiprince, which version? | 09:30 |
| mrunge | I mean, which horizon version? | 09:30 |
| tyagiprince | its the kilo version I am using | 09:30 |
| *** aheller has joined #openstack-horizon | 09:32 | |
| *** jbell8 has quit IRC | 09:34 | |
| *** jbell8 has joined #openstack-horizon | 09:35 | |
| *** aortega has quit IRC | 09:37 | |
| *** jbell8 has quit IRC | 09:39 | |
| *** mohankumar has joined #openstack-horizon | 09:42 | |
| pkarikh | tyagiprince: I'm working exactly on this problem. :) There lots of problems there. https://review.openstack.org/#/c/250869/ | 09:46 |
| *** oetrog has quit IRC | 09:48 | |
| *** aheller has quit IRC | 09:48 | |
| pkarikh | tyagiprince: Keystone has patch to support 'truncated' flag. But actually they also need a patch in python-keystoneclient. And also user api filtering in Horizon now is in progress too. | 09:48 |
| *** aheller has joined #openstack-horizon | 09:49 | |
| pkarikh | tyagiprince: Horizon truncated flag patch: https://review.openstack.org/#/c/250869/; Keustone cllient truncated patch: https://review.openstack.org/#/c/250473/1; Horizon users api filtering patch: https://review.openstack.org/#/c/112744/15 | 09:50 |
| *** mohankumar has quit IRC | 09:50 | |
| *** aortega has joined #openstack-horizon | 09:53 | |
| tyagiprince | pkarikh, mrunge, There is a function inside the indexView Class get_data which fetches the users using the api.keystone.user_get function and finally returns the users list.. I want to know from where is this function being called? | 09:55 |
| *** aheller has quit IRC | 09:56 | |
| mrunge | pkarikh, but that being said, there won't be a backport for this, right? | 09:58 |
| mrunge | I mean, tyagiprince is complaining about kilo | 09:58 |
| mrunge | which just receives security fixes from upstream | 09:58 |
| pkarikh | mrunge: I belive that it is so. I'm not sure that keystone team will backport it. | 09:59 |
| mrunge | yes, and it's across two versions... | 09:59 |
| mrunge | and finally, we can not test it, if it's not released in keystone | 09:59 |
| pkarikh | tyagiprince: actually users api filtering patch: https://review.openstack.org/#/c/112744/15 has truncating on the Horizon side. May be you will be interested | 10:00 |
| pkarikh | mrunge: sure. Until it is not released by Keystone there is no way except local testing, I think. Am I right that there is no way to say "hey, Gerrit, use this patch for keystone and keystone client" for unit tests? | 10:01 |
| mrunge | pkarikh, exactly | 10:02 |
| pkarikh | tyagiprince: if I'm not mistaken here is the place you are trying to find. https://github.com/openstack/horizon/blob/master/horizon/tables/views.py#L187 | 10:02 |
| *** e0ne has joined #openstack-horizon | 10:03 | |
| *** amotoki has quit IRC | 10:05 | |
| *** tmazur has joined #openstack-horizon | 10:06 | |
| *** e0ne has quit IRC | 10:06 | |
| *** e0ne_ has joined #openstack-horizon | 10:07 | |
| *** e0ne_ has quit IRC | 10:09 | |
| *** e0ne has joined #openstack-horizon | 10:09 | |
| *** e0ne_ has joined #openstack-horizon | 10:14 | |
| *** e0ne has quit IRC | 10:16 | |
| *** zhurong has joined #openstack-horizon | 10:21 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon: Add launchpad link to the plugin registry list https://review.openstack.org/252272 | 10:22 |
| *** kzaitsev_mb has joined #openstack-horizon | 10:25 | |
| *** marlinc has quit IRC | 10:29 | |
| *** e0ne_ has quit IRC | 10:30 | |
| *** sanjana has joined #openstack-horizon | 10:34 | |
| *** vgridnev has joined #openstack-horizon | 10:34 | |
| *** yamamoto_ has quit IRC | 10:34 | |
| *** tosky has joined #openstack-horizon | 10:35 | |
| *** oetrog has joined #openstack-horizon | 10:38 | |
| sanjana | When i run tox tests (py34) in local dev environment, i get the following runtime error: dictionary changed size during iteration around line 1060 in horizon/horizon/tables/base.py | 10:38 |
| sanjana | Since this is base code, i suspect this has to do anything with my changes. How do i test compatibility for py34 ? | 10:39 |
| *** weihan has joined #openstack-horizon | 10:39 | |
| robcresswell | Should just be tox -e py34 | 10:39 |
| sanjana | I have tried the command tox -e py34 and tox -epy34. Both behave same | 10:40 |
| *** btully has joined #openstack-horizon | 10:40 | |
| sanjana | Did anyone see this error before when running tox tests, since it does not involve the code changes which I have made | 10:41 |
| *** zhurong has quit IRC | 10:41 | |
| robcresswell | sanjana: Upstream tests don't appear to have the same issue | 10:42 |
| robcresswell | sanjana: Just running locally now... | 10:45 |
| *** btully has quit IRC | 10:45 | |
| *** wdeclercq has joined #openstack-horizon | 10:48 | |
| robcresswell | sanjana: No issues locally I'm afraid. Is your code in sync with master? | 10:49 |
| sanjana | What I notice is that in tables/base.py, around line 1060, we are manipulating the dict(pop operation) from within the for loop. Therefore, any test which is using that snippet of code will fail for "dictionary changed size..." | 10:49 |
| *** oetrog has quit IRC | 10:49 | |
| robcresswell | :s I don't see this code, which line? | 10:53 |
| sanjana | I think the base version that I was working on was not in sync with master. | 10:55 |
| sanjana | I just relaized, thanks for guiding | 10:55 |
| robcresswell | sanjana: No problem. | 10:56 |
| *** lhcheng_ has joined #openstack-horizon | 11:02 | |
| *** lhcheng has quit IRC | 11:03 | |
| *** lhcheng has joined #openstack-horizon | 11:04 | |
| *** lhcheng_ has quit IRC | 11:04 | |
| *** chestack has quit IRC | 11:07 | |
| sanjana | I need a suggestion. I have already put my patch for review and now i realize that my codebase was not in sync with master. How can i sync it with master and resubmit a patch? | 11:08 |
| *** oetrog has joined #openstack-horizon | 11:10 | |
| sanjana | Also my patch is dependent on another old patch that is still under review. | 11:10 |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/252204 | 11:10 |
| tsufiev | sanjana, rebase the dependency, then rebase your patch. There is a button for that task in Gerrit | 11:13 |
| *** oetrog has quit IRC | 11:15 | |
| sanjana | When i click on the Rebase change button on the dependency patch, it gives a server unavailable error | 11:21 |
| *** doug-fish has joined #openstack-horizon | 11:21 | |
| *** SurajD has quit IRC | 11:23 | |
| *** SurajD has joined #openstack-horizon | 11:24 | |
| *** sambetts-afk is now known as sambetts | 11:24 | |
| *** doug-fish has quit IRC | 11:26 | |
| *** erlon has joined #openstack-horizon | 11:26 | |
| openstackgerrit | sanjana proposed openstack/horizon: Adding Ceilometer Alarm API https://review.openstack.org/215569 | 11:28 |
| *** aix has quit IRC | 11:34 | |
| *** jbell8 has joined #openstack-horizon | 11:36 | |
| robcresswell | tsufiev: Do you still have that nice list of needed integration tests? | 11:37 |
| robcresswell | tsufiev: I thought I might have a go at a couple of them over christmas holidays :) | 11:37 |
| *** jbell8 has quit IRC | 11:40 | |
| *** sanjana has quit IRC | 11:43 | |
| openstackgerrit | Merged openstack/horizon: Add symbol equal "=" in several filter texts https://review.openstack.org/252044 | 11:48 |
| *** Daisy_ has joined #openstack-horizon | 11:50 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 11:50 |
| mrunge | tsufiev, you assigned yourself to https://bugs.launchpad.net/django-openstack-auth/+bug/1338986 | 11:53 |
| openstack | Launchpad bug 1338986 in django-openstack-auth "domain_context is not set in the client session" [High,Confirmed] - Assigned to Timur Sufiev (tsufiev-x) | 11:53 |
| mrunge | are you still working on this Timur? | 11:53 |
| *** jprovazn has joined #openstack-horizon | 11:54 | |
| *** Daisy_ has quit IRC | 11:54 | |
| *** Daisy has joined #openstack-horizon | 11:55 | |
| tsufiev | robcresswell, it was the exact thing I'm convincing myself to finalize right now | 11:55 |
| tsufiev | I mean, the full list of needed tests | 11:55 |
| tsufiev | mrunge, Matthias, I unassigned myself, thanks for reminder | 11:56 |
| mrunge | tsufiev, hahaha, I thought you already had a fix ;-) | 11:56 |
| tsufiev | mrunge, wasn't able to reproduce it | 11:56 |
| mrunge | oh! | 11:56 |
| *** ygl has joined #openstack-horizon | 11:57 | |
| tsufiev | well, I don't remember all the details, but the our own issue which I initially thought to be another consequence of this bug happened to be caused by bad config | 11:57 |
| mrunge | tsufiev, ok, I see. I have at least 2 customers being hit by this. Looks like I'd be looking at that then | 11:58 |
| tsufiev | mrunge, it's all yours :) | 11:58 |
| mrunge | yes, thank you tsufiev :) | 11:59 |
| tsufiev | robcresswell, at least now I have additional reason to finish that list | 11:59 |
| *** Daisy has quit IRC | 11:59 | |
| robcresswell | tsufiev: Yessir. I haven't forgotten. Just got caught up in other bits and pieces. | 12:00 |
| *** doug-fish has joined #openstack-horizon | 12:00 | |
| tsufiev | robcresswell, mrunge: is it right that we no longer have a meeting at 12:00 UTC? | 12:00 |
| robcresswell | tsufiev: That is true :) | 12:01 |
| tsufiev | oh, good, another hour to do some actual work :) | 12:01 |
| robcresswell | The days aren't long enough :( | 12:01 |
| *** aix has joined #openstack-horizon | 12:04 | |
| *** btully has joined #openstack-horizon | 12:08 | |
| tsufiev | robcresswell, hm, it appears that we forgot to sent an announcement about meeting cancellation, didn't we? | 12:09 |
| robcresswell | Oops. Was that my job? | 12:10 |
| tsufiev | robcresswell, nope, I was meaning 'collective community overmind' :) | 12:10 |
| tsufiev | well, the exact moment of decision to cancel this timeslot eluded me, so I am asking | 12:12 |
| robcresswell | Last week I think | 12:12 |
| robcresswell | Basically because it was just you me and mrunge | 12:12 |
| robcresswell | and a sleepy david | 12:12 |
| robcresswell | made it pointless to timebox an hour when we could just discuss in chat | 12:13 |
| tsufiev | masco, that was the point ^^^ | 12:13 |
| robcresswell | and masco too :) | 12:13 |
| mrunge | yes | 12:13 |
| tsufiev | robcresswell, thanks, got it. I think I was sleepy too the moment everybody agreed on that | 12:13 |
| mrunge | but if all of you are here willing to chat, let's kill some bugs | 12:13 |
| tsufiev | masco, do you have something specific in mind? | 12:14 |
| masco | but in the other time it is impossible me to join :( | 12:14 |
| tsufiev | mrunge, not that really :) | 12:14 |
| tsufiev | masco, what's the time at your TZ right now? | 12:15 |
| masco | 5.45PM | 12:16 |
| masco | tsufiev, ^ | 12:16 |
| robcresswell | masco: We still have the regular meeting at 1200/2000 | 12:16 |
| masco | robcresswell, oh, only today meeting got canceled? | 12:17 |
| robcresswell | There are 2 meetings | 12:17 |
| tsufiev | perhaps we could move this timeslot to some later time? But if we still keep regular meeting at 1200, it would cause a lot of confusion | 12:17 |
| robcresswell | Horizon Drivers and Horizon | 12:17 |
| mrunge | this was only the horizon drivers meeting being cancelled | 12:17 |
| robcresswell | There is still Horizon meeting, at 1200 and 2000 UTC, alternating | 12:18 |
| mrunge | for folks in US west, this is very early right now | 12:18 |
| robcresswell | And then there is Horizon Drivers, at 2000UTC every other week | 12:18 |
| robcresswell | All we cancelled is the 1200UTC Horizon Drivers meeting, as attendance was 4 people | 12:18 |
| masco | the other one is 1.30AM for me | 12:18 |
| *** btully has quit IRC | 12:19 | |
| mrunge | agreed, meeting times are currently optimized for europeans and US | 12:19 |
| masco | yeah i agree the active ppl in this slot is very less | 12:19 |
| robcresswell | All we do in that meeting is discuss blueprints | 12:19 |
| *** SurajD has quit IRC | 12:20 | |
| tyagiprince | mrunge: pkarikh: Hey I want to implement pagination in the users page.. what do I need to do for that? I read in users/tables.py file that pagination is supported.. | 12:20 |
| tsufiev | tyagiprince, the short answer is: NO | 12:20 |
| masco | i need to build a strong community in india,i guess :) | 12:20 |
| tsufiev | :) | 12:20 |
| robcresswell | masco: We still have the 1200UTC general meeting | 12:20 |
| robcresswell | So, you're not being left without a meeting | 12:21 |
| pkarikh | tyagiprince: keystone does not support pagination in 2 or 3 version (I'm not sure which one). | 12:21 |
| masco | robcresswell, ok, thanks | 12:21 |
| robcresswell | tsufiev: I thought you got permission in the end? | 12:21 |
| lhcheng | mrunge: just to confirm, is the horizon driver meeting cancelled going forward? | 12:21 |
| robcresswell | Horizon Drivers 1200 UTC is cancelled | 12:21 |
| tyagiprince | pkarikh: but pagination code is added to instances list | 12:21 |
| tsufiev | robcresswell, nope, we were given kind of a workaround for that | 12:21 |
| *** SurajD has joined #openstack-horizon | 12:22 | |
| lhcheng | robcresswell: just for today? | 12:22 |
| robcresswell | tyagiprince: It's dependant on the services | 12:22 |
| tsufiev | filtering + limits allows us not to use pagination | 12:22 |
| robcresswell | lhcheng: My understanding was that it is every 1200 meeting | 12:22 |
| lhcheng | oh okay, so we'll still have the 2000 driver meeting | 12:23 |
| robcresswell | lhcheng: Yes :) | 12:23 |
| pkarikh | tyagiprince: yep, but instances are Nova, and Nova supports pagination, I guess. It depends on openstack service. Necause you need to send pagination marker to service and get correct "page" from it | 12:23 |
| robcresswell | tyagiprince: Every service has varying support for pagination, and even if they do, its nearly always implemented differently. | 12:24 |
| lhcheng | robcresswell: ah right, the wiki doesn't have the 1200UTC time anymore :) | 12:24 |
| lhcheng | haven't looked at it for awhile :P | 12:24 |
| robcresswell | lhcheng: Yep, just updated. My apologies, I think I was supposed to be doing that last week but it slipped my mind. | 12:24 |
| lhcheng | no worries, no one got up early to attend :) | 12:25 |
| *** btully has joined #openstack-horizon | 12:25 | |
| tyagiprince | pkarikh: Okay let my case be that keystone does not support pagination. and on opening the users tab, keystone sends all the users to horizon.. and then the horizon takes time to build a table for so many users.. can i just tell the horizon to display just 100 users | 12:25 |
| tyagiprince | but filter should be applied to all the users list sent by keystone.. | 12:25 |
| robcresswell | tsufiev: I thought there was a plan to do similar to what tyagiprince is describing? | 12:26 |
| masco | bye all, if possible will try to attend 2000 UTC meeting :) | 12:26 |
| robcresswell | masco: o/ | 12:27 |
| robcresswell | tyagiprince: the plan that was discussed was very similar to what you have mentioned. We would display an empty table at first (or just all users, if total is a small number), and then on filter display users that match. | 12:27 |
| tyagiprince | robcresswell: pkarikh: cuz this one is taking a lot of time.. And since I am not familiar with django framework.. I want to find the section (where the for loop is) where the list is populated.. | 12:28 |
| robcresswell | tyagiprince: And if the filter returned too large a number, we would ask for a more specific filter | 12:28 |
| tsufiev | robcresswell, yes, that's true. pkarikh is going to create a blueprint for this initiative | 12:28 |
| pkarikh | tyagiprince: https://review.openstack.org/#/c/112744/15 this patch will be insteresting for you. Actually jpomero abondoned it in favour of angular tables, and I'm working on it refactoring now. There Justing implemented horizon-side truncating users list. https://review.openstack.org/#/c/112744/15/horizon/tables/views.py Take a look at linit data function | 12:28 |
| robcresswell | tyagiprince: I don't think this is an "afternoon hack job" of coding :) | 12:28 |
| pkarikh | tsufiev, robcresswell: yep, looks like there a lot of work should be done in different projects, so I think we need a blueprint for it | 12:29 |
| tyagiprince | pkarikh: Sorry being new to the patches and all.. I dont know how to apply these patches to my setup.. | 12:30 |
| tyagiprince | pkarikh: this patch is exactly what describes my use case | 12:30 |
| tsufiev | tyagiprince, I suggest to wait a few more days until pkarikh combines already existing pieces + server-side keystone filtering | 12:31 |
| *** masco has quit IRC | 12:31 | |
| tsufiev | well, maybe a week or two until it's really polished | 12:31 |
| pkarikh | tsufiev: as far as I know tyagiprince needs a solution for Kilo, so keystone truncating is not available | 12:31 |
| tsufiev | that would be difficult | 12:32 |
| tyagiprince | robcresswell: lol.. I thought I could just change the for loop to 100 users and display them.. since the users list will be containing all the users fetched from AD, the filter would be applied to that users list and re populate the table again.. | 12:32 |
| *** kiran-r has joined #openstack-horizon | 12:33 | |
| pkarikh | tyagiprince: there few ways: 1) Clone horizon repo and `git review -d 112744` to get this patch and run it locally 2) Same as 1 but you can create git patch file from thath commit and try to apply it on your test env 3) Mannyally apply all changes by editing files | 12:33 |
| *** Daisy has joined #openstack-horizon | 12:35 | |
| *** btully has quit IRC | 12:38 | |
| *** oetrog has joined #openstack-horizon | 12:40 | |
| *** btully has joined #openstack-horizon | 12:41 | |
| *** kiran-r has quit IRC | 12:47 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Add truncated flag support https://review.openstack.org/250869 | 12:49 |
| *** oetrog has quit IRC | 12:52 | |
| *** SurajD has quit IRC | 12:54 | |
| *** SurajD has joined #openstack-horizon | 12:54 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 12:55 |
| *** ygl has quit IRC | 12:56 | |
| *** pauloewerton has joined #openstack-horizon | 13:00 | |
| robcresswell | tsufiev: Integration tests seem happy atm :D | 13:09 |
| *** Daisy has quit IRC | 13:10 | |
| *** Daisy has joined #openstack-horizon | 13:10 | |
| *** ducttape_ has joined #openstack-horizon | 13:11 | |
| *** btully has quit IRC | 13:13 | |
| *** tyagiprince has quit IRC | 13:15 | |
| *** Daisy has quit IRC | 13:15 | |
| *** btully has joined #openstack-horizon | 13:15 | |
| *** lapalm has joined #openstack-horizon | 13:15 | |
| *** kzaitsev_mb has quit IRC | 13:21 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Show a toast with success on instance creation https://review.openstack.org/251476 | 13:23 |
| *** ducttape_ has quit IRC | 13:32 | |
| *** amotoki has joined #openstack-horizon | 13:34 | |
| *** btully has quit IRC | 13:41 | |
| *** btully has joined #openstack-horizon | 13:42 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects API https://review.openstack.org/208581 | 13:44 |
| *** yamamoto has joined #openstack-horizon | 13:45 | |
| itxaka | Can anyone recommend a good book/Article/Post/whatever for debugging stuff in Angular with Jasmine? Im having a hard time seeing stuff :( | 13:46 |
| robcresswell | itxaka: You'll likely have more luck if you ask when the US folk are on | 13:47 |
| robcresswell | itxaka: Most of the angular work is focused around UTC-5 to UTC-8 :p | 13:47 |
| itxaka | :) | 13:47 |
| itxaka | thanks, will re-ask again later then | 13:47 |
| robcresswell | itxaka: What's the issue though? I might have a couple suggestions. paste.openstack.org is useful for sharing code too. | 13:48 |
| itxaka | robcresswell Im adding a toast for the create instance ng, but it breaks quite some tests | 13:49 |
| *** crobertsrh has joined #openstack-horizon | 13:49 | |
| itxaka | So Im poking around trying to see why and what kind of objects are expected and so on | 13:49 |
| itxaka | but its quite difficult for a javascript noob to do so :) | 13:50 |
| robcresswell | itxaka: Just pulling code to check myself :) | 13:51 |
| itxaka | im resorting to console.log everything, which is bad and I should feel bad | 13:52 |
| *** tmazur has quit IRC | 13:53 | |
| *** jtriley has joined #openstack-horizon | 13:53 | |
| robcresswell | Oh, its all failing on the same thing | 13:53 |
| tsufiev | itxaka, I found debugging tests in Webstorm to be really insightful | 13:55 |
| *** josecastroleon has quit IRC | 13:56 | |
| *** josecastroleon has joined #openstack-horizon | 13:57 | |
| *** matt-borland has joined #openstack-horizon | 13:57 | |
| itxaka | thanks tsufiev will have a look with webstorm | 13:59 |
| itxaka | I kind of think that I know what it is, but a good ide could help me a lot | 13:59 |
| *** mohankumar has joined #openstack-horizon | 14:01 | |
| *** zhurong has joined #openstack-horizon | 14:03 | |
| openstackgerrit | Tatiana Ovchinnikova proposed openstack/horizon: Protocol port should be required for LBaaS Add Member https://review.openstack.org/252409 | 14:03 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Members https://review.openstack.org/245340 | 14:09 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Panel https://review.openstack.org/199139 | 14:09 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Create Action - Details https://review.openstack.org/215352 | 14:09 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Quota https://review.openstack.org/252412 | 14:09 |
| *** jerrygb has joined #openstack-horizon | 14:10 | |
| *** btully has quit IRC | 14:10 | |
| *** jpomeroy has joined #openstack-horizon | 14:12 | |
| *** e0ne has joined #openstack-horizon | 14:14 | |
| *** btully has joined #openstack-horizon | 14:17 | |
| *** peristeri has joined #openstack-horizon | 14:18 | |
| *** vijendar has joined #openstack-horizon | 14:22 | |
| *** lblanchard has joined #openstack-horizon | 14:22 | |
| *** e0ne_ has joined #openstack-horizon | 14:23 | |
| *** petertr7_away is now known as petertr7 | 14:23 | |
| *** neelashah has joined #openstack-horizon | 14:23 | |
| *** e0ne has quit IRC | 14:24 | |
| *** tyagiprince has joined #openstack-horizon | 14:29 | |
| *** btully has quit IRC | 14:31 | |
| *** mounica has joined #openstack-horizon | 14:31 | |
| *** btully has joined #openstack-horizon | 14:31 | |
| *** josecastroleon1 has joined #openstack-horizon | 14:34 | |
| *** jtriley has quit IRC | 14:34 | |
| *** josecastroleon has quit IRC | 14:35 | |
| *** absubram has joined #openstack-horizon | 14:35 | |
| *** vijendar has quit IRC | 14:40 | |
| *** yamamoto has quit IRC | 14:42 | |
| matt-borland | Hey robcresswell, is https://review.openstack.org/#/c/246625/ ready for a full review? | 14:42 |
| robcresswell | matt-borland: Yep yep | 14:43 |
| matt-borland | excellent, I'll take a look at it this morning | 14:43 |
| matt-borland | any particularly good ways of visually testing this? | 14:44 |
| matt-borland | "check panels x, y, z..?" | 14:44 |
| robcresswell | matt-borland: I enabled the images and users panels, before the patch and compared them to the python users/images panels | 14:44 |
| robcresswell | matt-borland: Then pull the patch and compare again. Visually should be much more similar. | 14:44 |
| openstackgerrit | George Peristerakis proposed openstack/horizon: Generating a rdp file for a windows instance https://review.openstack.org/91394 | 14:45 |
| robcresswell | matt-borland: Other than that, check I haven't missed any tricks in the angular styles or broken something :) | 14:45 |
| matt-borland | excellent, thanks robcresswell | 14:45 |
| *** zhurong has quit IRC | 14:45 | |
| *** yamamoto has joined #openstack-horizon | 14:46 | |
| robcresswell | matt-borland: End goal is to try and make sure the python/ angular is using as much of the same CSS as possible, so theming is easier, code is easier to maintain, and there's just less of it overall. | 14:47 |
| robcresswell | Plus its less jarring when using the angular panels :) | 14:47 |
| matt-borland | exactly, sounds great | 14:47 |
| matt-borland | I like that is is a net code removal :) | 14:48 |
| matt-borland | There is one thing robcresswell that I haven't tackled yet that is a little bit of a formatting problem | 14:51 |
| matt-borland | When doing the details pages, the header needs to be in the context of the angular controller to be dynamic | 14:51 |
| matt-borland | which it needs to be, | 14:51 |
| *** mohankumar has quit IRC | 14:52 | |
| matt-borland | which means we can't use the '{% block title %}{% trans "Images" %}{% endblock %}' Django header | 14:52 |
| matt-borland | I think we just leave it blank and have a header in the Image Detail page, but it seems clumsy | 14:52 |
| *** SurajD has quit IRC | 14:54 | |
| *** josecastroleon has joined #openstack-horizon | 14:56 | |
| *** SurajD has joined #openstack-horizon | 14:56 | |
| *** btully has quit IRC | 14:57 | |
| robcresswell | matt-borland: Yeah that's actually something I'm unsure about. I had to add a blank block to hide the margins etc from the page_header block. https://review.openstack.org/#/c/246625/3/openstack_dashboard/dashboards/project/ngimages/templates/ngimages/index.html | 14:57 |
| matt-borland | exactly | 14:57 |
| matt-borland | that's what made me think of that | 14:57 |
| robcresswell | matt-borland: I wonder if a better solution would've been to just alter how that block behaves. | 14:57 |
| matt-borland | well, | 14:57 |
| robcresswell | As in, if page_title do something, else nope | 14:57 |
| matt-borland | ah, yeah. | 14:58 |
| *** josecastroleon1 has quit IRC | 14:58 | |
| matt-borland | I'm not worried, but maybe we can look at a solution to that in the image detail patch | 14:58 |
| matt-borland | which is where I've run into that | 14:58 |
| *** mohankumar has joined #openstack-horizon | 14:59 | |
| robcresswell | It doesn't make a huge difference, but I'm happy to alter it if people prefer a different solution. | 14:59 |
| *** btully has joined #openstack-horizon | 14:59 | |
| *** josecastroleon1 has joined #openstack-horizon | 15:00 | |
| *** julim has quit IRC | 15:00 | |
| *** josecastroleon has quit IRC | 15:00 | |
| *** ducttape_ has joined #openstack-horizon | 15:02 | |
| *** yamamoto has quit IRC | 15:04 | |
| *** SurajD has quit IRC | 15:08 | |
| *** SurajD has joined #openstack-horizon | 15:10 | |
| *** btully has quit IRC | 15:10 | |
| *** btully has joined #openstack-horizon | 15:11 | |
| *** tyagiprince1 has joined #openstack-horizon | 15:14 | |
| *** tyagiprince has quit IRC | 15:16 | |
| *** tyagiprince1 is now known as tyagiprince | 15:16 | |
| *** raginbajin has quit IRC | 15:16 | |
| *** raginbajin has joined #openstack-horizon | 15:17 | |
| *** vijendar has joined #openstack-horizon | 15:20 | |
| *** tyagiprince has quit IRC | 15:20 | |
| *** tyagiprince1 has joined #openstack-horizon | 15:21 | |
| *** mohankumar has quit IRC | 15:21 | |
| *** tyagiprince1 is now known as tyagiprince | 15:23 | |
| *** vijendar has left #openstack-horizon | 15:24 | |
| *** absubram has quit IRC | 15:26 | |
| *** absubram has joined #openstack-horizon | 15:26 | |
| *** petertr7 is now known as petertr7_away | 15:28 | |
| *** josecastroleon has joined #openstack-horizon | 15:28 | |
| *** btully has quit IRC | 15:28 | |
| *** josecastroleon1 has quit IRC | 15:29 | |
| *** petertr7_away is now known as petertr7 | 15:29 | |
| *** hurgleburgler has joined #openstack-horizon | 15:29 | |
| *** Piet_ has quit IRC | 15:30 | |
| *** weihan has quit IRC | 15:30 | |
| *** btully has joined #openstack-horizon | 15:30 | |
| *** wdeclercq has quit IRC | 15:33 | |
| *** raginbajin has quit IRC | 15:34 | |
| *** SimonChung has quit IRC | 15:34 | |
| *** Ephur has quit IRC | 15:34 | |
| *** pauloewerton has quit IRC | 15:34 | |
| *** doug-fish has quit IRC | 15:34 | |
| *** erlon has quit IRC | 15:34 | |
| *** lhcheng has quit IRC | 15:34 | |
| *** vgridnev has quit IRC | 15:34 | |
| *** itxaka has quit IRC | 15:34 | |
| *** TravT has quit IRC | 15:34 | |
| *** NightKhaos has quit IRC | 15:34 | |
| *** zz_john5223 has quit IRC | 15:34 | |
| *** ccard__ has quit IRC | 15:34 | |
| *** sjmc7 has quit IRC | 15:34 | |
| *** mrunge has quit IRC | 15:34 | |
| *** pkarikh has quit IRC | 15:34 | |
| *** tsufiev has quit IRC | 15:34 | |
| *** katyafervent has quit IRC | 15:34 | |
| *** stevemar has quit IRC | 15:34 | |
| *** chlong has quit IRC | 15:34 | |
| *** reedip has quit IRC | 15:34 | |
| *** amit213 has quit IRC | 15:34 | |
| *** flwang has quit IRC | 15:34 | |
| *** brad[] has quit IRC | 15:34 | |
| *** jamespd has quit IRC | 15:34 | |
| *** swebb has quit IRC | 15:34 | |
| *** mgagne has quit IRC | 15:34 | |
| *** davidlenwell has quit IRC | 15:34 | |
| *** btully has quit IRC | 15:34 | |
| *** josecastroleon has quit IRC | 15:34 | |
| *** absubram has quit IRC | 15:34 | |
| *** e0ne_ has quit IRC | 15:34 | |
| *** lblanchard has quit IRC | 15:34 | |
| *** jerrygb has quit IRC | 15:34 | |
| *** crobertsrh has quit IRC | 15:34 | |
| *** aix has quit IRC | 15:34 | |
| *** david-lyle has quit IRC | 15:34 | |
| *** cody-somerville has quit IRC | 15:34 | |
| *** rhagarty has quit IRC | 15:34 | |
| *** hughhalf has quit IRC | 15:34 | |
| *** mdavidson has quit IRC | 15:34 | |
| *** cbader has quit IRC | 15:34 | |
| *** kevinbenton has quit IRC | 15:35 | |
| *** vkmc has quit IRC | 15:35 | |
| *** bluex has quit IRC | 15:35 | |
| *** aorourke has quit IRC | 15:35 | |
| *** anteaya has quit IRC | 15:35 | |
| *** radez has quit IRC | 15:35 | |
| *** _stowa has quit IRC | 15:35 | |
| *** docaedo has quit IRC | 15:35 | |
| *** mordred has quit IRC | 15:35 | |
| *** kfox1111 has quit IRC | 15:35 | |
| *** lifeless has quit IRC | 15:35 | |
| *** Madkiss has quit IRC | 15:35 | |
| *** cody-somerville- has quit IRC | 15:35 | |
| *** ccesario has quit IRC | 15:35 | |
| *** htruta has quit IRC | 15:35 | |
| *** jhesketh has quit IRC | 15:35 | |
| *** dloi_ has quit IRC | 15:35 | |
| *** sshen_ has quit IRC | 15:35 | |
| *** fnordahl has quit IRC | 15:35 | |
| *** robcresswell has quit IRC | 15:35 | |
| *** mhorban_ has quit IRC | 15:35 | |
| *** bapalm has quit IRC | 15:35 | |
| *** jgrassler has quit IRC | 15:35 | |
| *** SurajD has quit IRC | 15:35 | |
| *** sambetts has quit IRC | 15:35 | |
| *** r1chardj0n3s has quit IRC | 15:35 | |
| *** boltR has quit IRC | 15:35 | |
| *** bradjones has quit IRC | 15:35 | |
| *** noqa_v_g1ovnie has quit IRC | 15:35 | |
| *** DuncanT has quit IRC | 15:35 | |
| *** ramishra has quit IRC | 15:35 | |
| *** zul has quit IRC | 15:35 | |
| *** sballe has quit IRC | 15:35 | |
| *** iurygregory has quit IRC | 15:35 | |
| *** tonyb has quit IRC | 15:35 | |
| *** ameade has quit IRC | 15:35 | |
| *** binBASH has quit IRC | 15:35 | |
| *** betherly has quit IRC | 15:35 | |
| *** ducttape_ has quit IRC | 15:35 | |
| *** neelashah has quit IRC | 15:35 | |
| *** mpavlase has quit IRC | 15:35 | |
| *** jcooley has quit IRC | 15:35 | |
| *** krotscheck has quit IRC | 15:35 | |
| *** petertr7 has quit IRC | 15:35 | |
| *** darrenc has quit IRC | 15:35 | |
| *** _crobertsrh has quit IRC | 15:35 | |
| *** jrist has quit IRC | 15:35 | |
| *** mdnadeem has quit IRC | 15:35 | |
| *** NikitaKonovalov has quit IRC | 15:35 | |
| *** ericksonfgds has quit IRC | 15:35 | |
| *** abramley has quit IRC | 15:35 | |
| *** trams_ has quit IRC | 15:35 | |
| *** gdeforest has quit IRC | 15:35 | |
| *** HenryG has quit IRC | 15:35 | |
| *** ccard has quit IRC | 15:35 | |
| *** sbadia has quit IRC | 15:35 | |
| *** zigo has quit IRC | 15:35 | |
| *** dsneddon has quit IRC | 15:35 | |
| *** patk has quit IRC | 15:35 | |
| *** ir2ivps10 has quit IRC | 15:35 | |
| *** logan- has quit IRC | 15:35 | |
| *** esp has quit IRC | 15:35 | |
| *** ttrifonov has quit IRC | 15:35 | |
| *** EmilienM has quit IRC | 15:35 | |
| *** med_ has quit IRC | 15:35 | |
| *** Anticimex has quit IRC | 15:35 | |
| *** toabctl has quit IRC | 15:35 | |
| *** davidmichaelkarr has quit IRC | 15:35 | |
| *** jroll has quit IRC | 15:35 | |
| *** jamielennox has quit IRC | 15:35 | |
| *** wasmum has quit IRC | 15:35 | |
| *** early has quit IRC | 15:35 | |
| matt-borland | hey robcresswell , I forget...when do you like to get updates to the Horizon Bug list? | 15:35 |
| *** dloi_ has joined #openstack-horizon | 15:37 | |
| *** sshen_ has joined #openstack-horizon | 15:37 | |
| *** fnordahl has joined #openstack-horizon | 15:37 | |
| *** aortega_ has joined #openstack-horizon | 15:37 | |
| *** aortega has quit IRC | 15:38 | |
| *** kzaitsev_mb has joined #openstack-horizon | 15:38 | |
| *** adelia has joined #openstack-horizon | 15:38 | |
| *** pauloewerton has joined #openstack-horizon | 15:39 | |
| *** doug-fish has joined #openstack-horizon | 15:39 | |
| *** erlon has joined #openstack-horizon | 15:39 | |
| *** lhcheng has joined #openstack-horizon | 15:39 | |
| *** vgridnev has joined #openstack-horizon | 15:39 | |
| *** itxaka has joined #openstack-horizon | 15:39 | |
| *** TravT has joined #openstack-horizon | 15:39 | |
| *** NightKhaos has joined #openstack-horizon | 15:39 | |
| *** zz_john5223 has joined #openstack-horizon | 15:39 | |
| *** ccard__ has joined #openstack-horizon | 15:39 | |
| *** sjmc7 has joined #openstack-horizon | 15:39 | |
| *** mrunge has joined #openstack-horizon | 15:39 | |
| *** pkarikh has joined #openstack-horizon | 15:39 | |
| *** tsufiev has joined #openstack-horizon | 15:39 | |
| *** katyafervent has joined #openstack-horizon | 15:39 | |
| *** stevemar has joined #openstack-horizon | 15:39 | |
| *** chlong has joined #openstack-horizon | 15:39 | |
| *** reedip has joined #openstack-horizon | 15:39 | |
| *** amit213 has joined #openstack-horizon | 15:39 | |
| *** swebb has joined #openstack-horizon | 15:39 | |
| *** flwang has joined #openstack-horizon | 15:39 | |
| *** brad[] has joined #openstack-horizon | 15:39 | |
| *** jamespd has joined #openstack-horizon | 15:39 | |
| *** mgagne has joined #openstack-horizon | 15:39 | |
| *** davidlenwell has joined #openstack-horizon | 15:39 | |
| *** SurajD has joined #openstack-horizon | 15:39 | |
| *** sambetts has joined #openstack-horizon | 15:39 | |
| *** r1chardj0n3s has joined #openstack-horizon | 15:39 | |
| *** boltR has joined #openstack-horizon | 15:39 | |
| *** bradjones has joined #openstack-horizon | 15:39 | |
| *** noqa_v_g1ovnie has joined #openstack-horizon | 15:39 | |
| *** DuncanT has joined #openstack-horizon | 15:39 | |
| *** ramishra has joined #openstack-horizon | 15:39 | |
| *** zul has joined #openstack-horizon | 15:39 | |
| *** sballe has joined #openstack-horizon | 15:39 | |
| *** iurygregory has joined #openstack-horizon | 15:39 | |
| *** tonyb has joined #openstack-horizon | 15:39 | |
| *** btully has joined #openstack-horizon | 15:39 | |
| *** raginbajin has joined #openstack-horizon | 15:40 | |
| *** zigo has joined #openstack-horizon | 15:40 | |
| *** dsneddon has joined #openstack-horizon | 15:40 | |
| *** patk has joined #openstack-horizon | 15:40 | |
| *** ir2ivps10 has joined #openstack-horizon | 15:40 | |
| *** logan- has joined #openstack-horizon | 15:40 | |
| *** esp has joined #openstack-horizon | 15:40 | |
| *** ttrifonov has joined #openstack-horizon | 15:40 | |
| *** EmilienM has joined #openstack-horizon | 15:40 | |
| *** med_ has joined #openstack-horizon | 15:40 | |
| *** Anticimex has joined #openstack-horizon | 15:40 | |
| *** toabctl has joined #openstack-horizon | 15:40 | |
| *** iurygregory has quit IRC | 15:41 | |
| *** jhesketh has joined #openstack-horizon | 15:41 | |
| *** robcresswell has joined #openstack-horizon | 15:42 | |
| *** mhorban_ has joined #openstack-horizon | 15:42 | |
| *** bapalm has joined #openstack-horizon | 15:42 | |
| *** jgrassler has joined #openstack-horizon | 15:42 | |
| *** itisha has joined #openstack-horizon | 15:42 | |
| *** ameade has joined #openstack-horizon | 15:42 | |
| *** binBASH has joined #openstack-horizon | 15:42 | |
| *** betherly has joined #openstack-horizon | 15:42 | |
| *** SimonChung has joined #openstack-horizon | 15:42 | |
| *** Ephur has joined #openstack-horizon | 15:42 | |
| *** davidmichaelkarr has joined #openstack-horizon | 15:44 | |
| *** jroll has joined #openstack-horizon | 15:44 | |
| *** jamielennox has joined #openstack-horizon | 15:44 | |
| *** wasmum has joined #openstack-horizon | 15:44 | |
| *** early has joined #openstack-horizon | 15:44 | |
| *** radez has joined #openstack-horizon | 15:44 | |
| *** david_cu has joined #openstack-horizon | 15:49 | |
| *** ctina has joined #openstack-horizon | 15:51 | |
| *** btully has quit IRC | 15:51 | |
| *** aix has joined #openstack-horizon | 15:51 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Sort images list in ascending alphabetical order https://review.openstack.org/130844 | 15:52 |
| *** mpavlase1 has joined #openstack-horizon | 15:52 | |
| *** katyafervent is now known as katyafervent_awa | 15:52 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Dropdown now inherits from Bootstrap Theme https://review.openstack.org/232735 | 15:52 |
| *** katyafervent_awa is now known as katyafervent | 15:53 | |
| *** NikitaKonovalov has joined #openstack-horizon | 15:53 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon Dropdown now inherits from Bootstrap Theme https://review.openstack.org/232735 | 15:54 |
| *** jrist has joined #openstack-horizon | 15:59 | |
| *** josecastroleon has joined #openstack-horizon | 15:59 | |
| *** absubram has joined #openstack-horizon | 15:59 | |
| *** e0ne_ has joined #openstack-horizon | 15:59 | |
| *** lblanchard has joined #openstack-horizon | 15:59 | |
| *** jerrygb has joined #openstack-horizon | 15:59 | |
| *** crobertsrh has joined #openstack-horizon | 15:59 | |
| *** david-lyle has joined #openstack-horizon | 15:59 | |
| *** cody-somerville has joined #openstack-horizon | 15:59 | |
| *** rhagarty has joined #openstack-horizon | 15:59 | |
| *** hughhalf has joined #openstack-horizon | 15:59 | |
| *** mdavidson has joined #openstack-horizon | 15:59 | |
| *** cbader has joined #openstack-horizon | 15:59 | |
| *** kevinbenton has joined #openstack-horizon | 15:59 | |
| *** vkmc has joined #openstack-horizon | 15:59 | |
| *** bluex has joined #openstack-horizon | 15:59 | |
| *** aorourke has joined #openstack-horizon | 15:59 | |
| *** anteaya has joined #openstack-horizon | 15:59 | |
| *** mordred has joined #openstack-horizon | 15:59 | |
| *** kfox1111 has joined #openstack-horizon | 15:59 | |
| *** lifeless has joined #openstack-horizon | 15:59 | |
| *** Madkiss has joined #openstack-horizon | 15:59 | |
| *** cody-somerville- has joined #openstack-horizon | 15:59 | |
| *** ccesario has joined #openstack-horizon | 15:59 | |
| *** htruta has joined #openstack-horizon | 15:59 | |
| *** wolfe.freenode.net sets mode: +o david-lyle | 15:59 | |
| *** rcernin has quit IRC | 15:59 | |
| *** docaedo has joined #openstack-horizon | 16:00 | |
| *** zul has quit IRC | 16:00 | |
| *** jtriley has joined #openstack-horizon | 16:04 | |
| *** ctina has quit IRC | 16:07 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Launch Instance Modal should be exist as a Service https://review.openstack.org/220214 | 16:07 |
| *** ctina has joined #openstack-horizon | 16:07 | |
| *** jrist has quit IRC | 16:09 | |
| *** josecastroleon has quit IRC | 16:09 | |
| *** absubram has quit IRC | 16:09 | |
| *** e0ne_ has quit IRC | 16:09 | |
| *** lblanchard has quit IRC | 16:09 | |
| *** jerrygb has quit IRC | 16:09 | |
| *** crobertsrh has quit IRC | 16:09 | |
| *** david-lyle has quit IRC | 16:09 | |
| *** cody-somerville has quit IRC | 16:09 | |
| *** rhagarty has quit IRC | 16:09 | |
| *** hughhalf has quit IRC | 16:09 | |
| *** mdavidson has quit IRC | 16:09 | |
| *** cbader has quit IRC | 16:09 | |
| *** kevinbenton has quit IRC | 16:09 | |
| *** vkmc has quit IRC | 16:09 | |
| *** bluex has quit IRC | 16:09 | |
| *** aorourke has quit IRC | 16:09 | |
| *** anteaya has quit IRC | 16:09 | |
| *** mordred has quit IRC | 16:09 | |
| *** kfox1111 has quit IRC | 16:09 | |
| *** lifeless has quit IRC | 16:09 | |
| *** Madkiss has quit IRC | 16:09 | |
| *** cody-somerville- has quit IRC | 16:09 | |
| *** ccesario has quit IRC | 16:09 | |
| *** htruta has quit IRC | 16:09 | |
| *** _stowa has joined #openstack-horizon | 16:09 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Add identity v3 API filtering to users and projects tables https://review.openstack.org/252488 | 16:12 |
| *** SimonChung has quit IRC | 16:15 | |
| matt-borland | (resend from before the drop) hey robcresswell , I forget...when do you like to get updates to the Horizon Bug list? | 16:18 |
| *** amotoki has quit IRC | 16:18 | |
| *** jbell8 has joined #openstack-horizon | 16:23 | |
| *** opilotte_ has joined #openstack-horizon | 16:26 | |
| opilotte_ | question about horizon: when I add 'heat' to 'dashboards' and restart httpd, the hole menu disappear | 16:27 |
| opilotte_ | i'm not sure what i'm doing wrong | 16:27 |
| *** sbadia has joined #openstack-horizon | 16:34 | |
| *** ccard has joined #openstack-horizon | 16:34 | |
| *** HenryG has joined #openstack-horizon | 16:34 | |
| *** gdeforest has joined #openstack-horizon | 16:34 | |
| *** trams_ has joined #openstack-horizon | 16:34 | |
| *** abramley has joined #openstack-horizon | 16:34 | |
| *** ericksonsantos has joined #openstack-horizon | 16:34 | |
| *** mdnadeem has joined #openstack-horizon | 16:34 | |
| *** _crobertsrh has joined #openstack-horizon | 16:34 | |
| *** darrenc has joined #openstack-horizon | 16:34 | |
| *** petertr7 has joined #openstack-horizon | 16:34 | |
| *** krotscheck has joined #openstack-horizon | 16:34 | |
| *** jcooley has joined #openstack-horizon | 16:34 | |
| *** neelashah has joined #openstack-horizon | 16:34 | |
| *** ducttape_ has joined #openstack-horizon | 16:34 | |
| *** mohankumar has joined #openstack-horizon | 16:34 | |
| *** cbader has joined #openstack-horizon | 16:34 | |
| *** zul has joined #openstack-horizon | 16:34 | |
| *** mtanino has joined #openstack-horizon | 16:34 | |
| *** jrist has joined #openstack-horizon | 16:34 | |
| *** absubram has joined #openstack-horizon | 16:34 | |
| *** lblanchard has joined #openstack-horizon | 16:34 | |
| *** jerrygb has joined #openstack-horizon | 16:34 | |
| *** crobertsrh has joined #openstack-horizon | 16:34 | |
| *** david-lyle has joined #openstack-horizon | 16:34 | |
| *** cody-somerville has joined #openstack-horizon | 16:34 | |
| *** rhagarty has joined #openstack-horizon | 16:34 | |
| *** hughhalf has joined #openstack-horizon | 16:34 | |
| *** mdavidson has joined #openstack-horizon | 16:34 | |
| *** kevinbenton has joined #openstack-horizon | 16:34 | |
| *** vkmc has joined #openstack-horizon | 16:34 | |
| *** aorourke has joined #openstack-horizon | 16:34 | |
| *** anteaya has joined #openstack-horizon | 16:34 | |
| *** mordred has joined #openstack-horizon | 16:34 | |
| *** kfox1111 has joined #openstack-horizon | 16:34 | |
| *** lifeless has joined #openstack-horizon | 16:34 | |
| *** Madkiss has joined #openstack-horizon | 16:34 | |
| *** cody-somerville- has joined #openstack-horizon | 16:34 | |
| *** ccesario has joined #openstack-horizon | 16:34 | |
| *** htruta has joined #openstack-horizon | 16:34 | |
| *** wolfe.freenode.net sets mode: +o david-lyle | 16:34 | |
| *** docaedo has quit IRC | 16:38 | |
| *** docaedo has joined #openstack-horizon | 16:40 | |
| *** cbader_ has joined #openstack-horizon | 16:41 | |
| opilotte_ | Dashboard with slug "heat" is not registered. | 16:44 |
| *** emilyw has joined #openstack-horizon | 16:44 | |
| *** cbader has quit IRC | 16:45 | |
| *** zul has quit IRC | 16:45 | |
| *** mtanino has quit IRC | 16:45 | |
| *** jrist has quit IRC | 16:45 | |
| *** absubram has quit IRC | 16:45 | |
| *** lblanchard has quit IRC | 16:45 | |
| *** jerrygb has quit IRC | 16:45 | |
| *** crobertsrh has quit IRC | 16:45 | |
| *** david-lyle has quit IRC | 16:45 | |
| *** cody-somerville has quit IRC | 16:45 | |
| *** rhagarty has quit IRC | 16:45 | |
| *** hughhalf has quit IRC | 16:45 | |
| *** mdavidson has quit IRC | 16:45 | |
| *** kevinbenton has quit IRC | 16:45 | |
| *** vkmc has quit IRC | 16:45 | |
| *** aorourke has quit IRC | 16:45 | |
| *** anteaya has quit IRC | 16:45 | |
| *** mordred has quit IRC | 16:45 | |
| *** kfox1111 has quit IRC | 16:45 | |
| *** lifeless has quit IRC | 16:45 | |
| *** Madkiss has quit IRC | 16:45 | |
| *** cody-somerville- has quit IRC | 16:45 | |
| *** ccesario has quit IRC | 16:45 | |
| *** htruta has quit IRC | 16:45 | |
| *** mohankumar has quit IRC | 16:45 | |
| *** ducttape_ has quit IRC | 16:45 | |
| *** neelashah has quit IRC | 16:45 | |
| *** jcooley has quit IRC | 16:45 | |
| *** krotscheck has quit IRC | 16:45 | |
| *** petertr7 has quit IRC | 16:45 | |
| *** darrenc has quit IRC | 16:45 | |
| *** _crobertsrh has quit IRC | 16:45 | |
| *** mdnadeem has quit IRC | 16:45 | |
| *** ericksonsantos has quit IRC | 16:45 | |
| *** abramley has quit IRC | 16:45 | |
| *** trams_ has quit IRC | 16:45 | |
| *** gdeforest has quit IRC | 16:45 | |
| *** HenryG has quit IRC | 16:45 | |
| *** ccard has quit IRC | 16:45 | |
| *** sbadia has quit IRC | 16:45 | |
| opilotte_ | how do I fix that error? : Dashboard with slug "heat" is not registered. | 16:45 |
| *** bpokorny has joined #openstack-horizon | 16:46 | |
| *** Drago has joined #openstack-horizon | 16:46 | |
| *** htruta has joined #openstack-horizon | 16:46 | |
| *** ccesario has joined #openstack-horizon | 16:46 | |
| *** cody-somerville- has joined #openstack-horizon | 16:46 | |
| *** Madkiss has joined #openstack-horizon | 16:46 | |
| *** lifeless has joined #openstack-horizon | 16:46 | |
| *** kfox1111 has joined #openstack-horizon | 16:46 | |
| *** mordred has joined #openstack-horizon | 16:46 | |
| *** anteaya has joined #openstack-horizon | 16:46 | |
| *** aorourke has joined #openstack-horizon | 16:46 | |
| *** vkmc has joined #openstack-horizon | 16:46 | |
| *** kevinbenton has joined #openstack-horizon | 16:46 | |
| *** mdavidson has joined #openstack-horizon | 16:46 | |
| *** hughhalf has joined #openstack-horizon | 16:46 | |
| *** rhagarty has joined #openstack-horizon | 16:46 | |
| *** cody-somerville has joined #openstack-horizon | 16:46 | |
| *** david-lyle has joined #openstack-horizon | 16:46 | |
| *** crobertsrh has joined #openstack-horizon | 16:46 | |
| *** jerrygb has joined #openstack-horizon | 16:46 | |
| *** lblanchard has joined #openstack-horizon | 16:46 | |
| *** absubram has joined #openstack-horizon | 16:46 | |
| *** jrist has joined #openstack-horizon | 16:46 | |
| *** mtanino has joined #openstack-horizon | 16:46 | |
| *** zul has joined #openstack-horizon | 16:46 | |
| *** mohankumar has joined #openstack-horizon | 16:46 | |
| *** ducttape_ has joined #openstack-horizon | 16:46 | |
| *** neelashah has joined #openstack-horizon | 16:46 | |
| *** jcooley has joined #openstack-horizon | 16:46 | |
| *** krotscheck has joined #openstack-horizon | 16:46 | |
| *** petertr7 has joined #openstack-horizon | 16:46 | |
| *** darrenc has joined #openstack-horizon | 16:46 | |
| *** _crobertsrh has joined #openstack-horizon | 16:46 | |
| *** mdnadeem has joined #openstack-horizon | 16:46 | |
| *** ericksonsantos has joined #openstack-horizon | 16:46 | |
| *** abramley has joined #openstack-horizon | 16:46 | |
| *** trams_ has joined #openstack-horizon | 16:46 | |
| *** gdeforest has joined #openstack-horizon | 16:46 | |
| *** HenryG has joined #openstack-horizon | 16:46 | |
| *** ccard has joined #openstack-horizon | 16:46 | |
| *** sbadia has joined #openstack-horizon | 16:46 | |
| *** wolfe.freenode.net sets mode: +o david-lyle | 16:46 | |
| *** mpavlase1 has quit IRC | 16:46 | |
| *** rajatvig has joined #openstack-horizon | 16:46 | |
| matt-borland | rajatvig, thanks for rebasing https://review.openstack.org/#/c/220214/ | 16:47 |
| matt-borland | I was going to suggest doing that | 16:47 |
| matt-borland | :) | 16:47 |
| rajatvig | no issues :) | 16:48 |
| *** itisha has quit IRC | 16:48 | |
| *** itisha has joined #openstack-horizon | 16:48 | |
| *** radez has quit IRC | 16:48 | |
| *** radez has joined #openstack-horizon | 16:48 | |
| *** aix has quit IRC | 16:48 | |
| *** aix has joined #openstack-horizon | 16:48 | |
| *** emilyw has quit IRC | 16:48 | |
| *** emilyw has joined #openstack-horizon | 16:48 | |
| *** btully has joined #openstack-horizon | 16:48 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Show a toast with success on instance creation https://review.openstack.org/251476 | 16:53 |
| *** docaedo has quit IRC | 16:54 | |
| *** ygbo has quit IRC | 16:55 | |
| *** docaedo has joined #openstack-horizon | 16:57 | |
| robcresswell | matt-borland: Where else does Launch Instance currently get used? Is it just Compute > Instances? | 16:58 |
| robcresswell | the angular one. | 16:58 |
| *** kzaitsev_mb has quit IRC | 16:58 | |
| matt-borland | several places! | 16:58 |
| matt-borland | You can launch it from an Image, | 16:58 |
| matt-borland | let's see...where else... | 16:59 |
| robcresswell | One will do, just wanted to verify that patch | 17:00 |
| robcresswell | running it from different places to check it doesnt explode stuff | 17:00 |
| *** btully has quit IRC | 17:00 | |
| *** btully has joined #openstack-horizon | 17:00 | |
| robcresswell | approved | 17:01 |
| *** kzaitsev_mb has joined #openstack-horizon | 17:01 | |
| rajatvig | the patch in particular will allow us to use it from anywhere, right now only in Image. | 17:01 |
| rajatvig | You can also launch an instance from the Volumes panel. | 17:01 |
| robcresswell | Ah cool, wasn't sure whether it'd been tied in to multiple places as with Python | 17:02 |
| *** bluex has joined #openstack-horizon | 17:05 | |
| *** e0ne has joined #openstack-horizon | 17:05 | |
| matt-borland | thanks rajatvig for clarifying (I was in a meeting), and thanks robcresswell for looking at that patch | 17:05 |
| *** btully is now known as Guest87049 | 17:05 | |
| *** tyagiprince has quit IRC | 17:07 | |
| *** belmoreira has joined #openstack-horizon | 17:08 | |
| *** tyagiprince has joined #openstack-horizon | 17:09 | |
| *** rcernin has joined #openstack-horizon | 17:11 | |
| *** mounica has quit IRC | 17:12 | |
| *** gyee has joined #openstack-horizon | 17:12 | |
| *** julim has joined #openstack-horizon | 17:14 | |
| *** Guest87049 has quit IRC | 17:17 | |
| krotscheck | TravT: Question for ya (and other cores). Would a patch that only runs lint on changed javascript files be worthwhile?? It'd greatly simplify things like lint rule updates that otherwise would result in massive patches. | 17:17 |
| TravT | that's kind of interesting | 17:18 |
| TravT | is this related to that lint rule that would has 2000 violations? | 17:18 |
| TravT | remove "would" in above | 17:18 |
| krotscheck | TravT: Yeah, the func-names one. | 17:19 |
| krotscheck | I'm thinking something like this: https://gist.github.com/krotscheck/2a6212c822957fb7f1fd | 17:19 |
| TravT | is there any way that we could do that on a per rule basis? | 17:19 |
| krotscheck | TravT: Not without support from the eslint team :/ | 17:19 |
| TravT | could always file a bug on that with them and hope for the best. ;) | 17:20 |
| krotscheck | TravT: Which would require VCS abstraction in eslint itself, because they can't always assume git. | 17:20 |
| krotscheck | TravT: Yeaaaaaahhhh.... I don't think they're that interested :) | 17:21 |
| TravT | lol | 17:21 |
| * krotscheck is having enough problems getting things landed in angular. | 17:21 | |
| krotscheck | TravT: Anyway- lint only on js docs that were changed. Good idea/bad idea/just submit a patch and see who argues about it? | 17:22 |
| robcresswell | krotscheck: Lint isn't exactly a slow thing, but if its a trivial change it doesnt hurt | 17:22 |
| *** btully has joined #openstack-horizon | 17:23 | |
| *** nlahouti has joined #openstack-horizon | 17:23 | |
| *** itxaka has quit IRC | 17:23 | |
| TravT | so, i like the idea, but this would have another ramification. if I make a change in a file for reason "X", I'd have to also refactor it to fix all eslint rule changes since it landed. | 17:23 |
| TravT | right? | 17:23 |
| krotscheck | robcresswell: I'm more worried about linting rule additions piling up over time and then a single-line bug change requiring a full file refactor. | 17:23 |
| krotscheck | Yeah, taht | 17:23 |
| TravT | that is kind of problematic | 17:23 |
| TravT | you can't isolate changes as well. | 17:24 |
| robcresswell | Er, would the trick there just be to not add new rules until we've cleaned up the existing ones? | 17:25 |
| krotscheck | robcresswell: That or set them to warn. | 17:25 |
| robcresswell | I'm not sure if I'm oversimplifiying things | 17:25 |
| TravT | well, that's status quo | 17:25 |
| robcresswell | Sure but adding tons of warnings long term is pointless if they're just ignored. | 17:25 |
| krotscheck | robcresswell: There's a rule under discussion right now which triggers 2000 errors in horizon | 17:25 |
| krotscheck | (func-names - disallow anonymous functions) | 17:25 |
| robcresswell | Though I get that its useful at the moment with the current version change structure. | 17:25 |
| *** vgridnev has quit IRC | 17:26 | |
| krotscheck | The general feel I'm getting is "Yeah, thsi rules is good, but OMG so many errors" | 17:26 |
| *** belmoreira has quit IRC | 17:26 | |
| TravT | yep, that's basically the summary of my comment on that rule | 17:26 |
| robcresswell | wait, thats excluding legacy too? | 17:26 |
| *** SimonChung has joined #openstack-horizon | 17:26 | |
| krotscheck | So I'm brainstorming ways that we could minimize that friction. | 17:26 |
| *** vgridnev has joined #openstack-horizon | 17:26 | |
| krotscheck | robcresswell: I think so. Let me check. | 17:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 17:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 17:26 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 17:26 |
| krotscheck | robcresswell: 886 if disabled for legacy | 17:28 |
| robcresswell | So, still a lot. | 17:28 |
| krotscheck | Exactly. So yay rule, boo work. | 17:29 |
| TravT | krotscheck: i think this is really creative thinking on your part, but with the example we have in mind, i am hesitant on it due to the forced changes. | 17:29 |
| TravT | :S | 17:29 |
| robcresswell | My thought is more; where does time invested outweigh benefits | 17:29 |
| robcresswell | I don't want a situation where people are just relying on you to manage our eslint etc | 17:30 |
| robcresswell | Because its completely unmaintainable. And then we end up just adding hundreds of warnings and hiding them, which isn't much different to not having the rule in the first place. | 17:30 |
| TravT | this might be one of those rules that we can put into common eslint rules, but have to override to off in horizon | 17:30 |
| robcresswell | Indeed | 17:31 |
| TravT | even though i would like it on new files. | 17:31 |
| TravT | if we could enforce it on changes lines only... | 17:31 |
| TravT | two pass eslint job? | 17:32 |
| TravT | warning: over engineering statements to follow | 17:32 |
| krotscheck | I was just considering that ;) | 17:32 |
| robcresswell | lol | 17:33 |
| TravT | pass one is regular... pass two is warnings for just changed files. | 17:34 |
| TravT | but, i'm guessing 99% of the time it'd be ignored | 17:34 |
| tsufiev | TravT, and then if someone just moves code from one place to another... kaboom! | 17:35 |
| TravT | but we're so good at that tsufiev! | 17:36 |
| tsufiev | yes, that's a good way to prevent people moving code around, I like it :) | 17:36 |
| tsufiev | robcresswell, omg, the list of integration tests is already 143 lines and growing | 17:37 |
| tsufiev | and that's only the Compute panel group | 17:38 |
| krotscheck | TravT: I'm going to vote on "overengineering". Even if we split it out into a different (nonvoting) gate job, it'd blow up in our faces. | 17:39 |
| krotscheck | OSrry | 17:39 |
| krotscheck | No | 17:39 |
| krotscheck | Not blow up- be ignored. | 17:40 |
| krotscheck | If we set warnings: they'll be ignored. | 17:40 |
| robcresswell | tsufiev: Ha, interesting. | 17:40 |
| tsufiev | robcresswell, still WIP https://etherpad.openstack.org/p/horizon-integration-tests | 17:40 |
| krotscheck | If we do changed-files-only, then we create landmines. | 17:40 |
| krotscheck | If we do "new files only", then we ignore changes elsewhere. | 17:40 |
| TravT | yeah, probably not worth it | 17:40 |
| *** lhcheng has quit IRC | 17:40 | |
| tsufiev | I'm at the beginning of Project->Network | 17:41 |
| krotscheck | Of all of those, I'm most in favor of the landmine approach, because it actually moves the codebase towards betterness. | 17:42 |
| krotscheck | Even though it's going to annoy a LOT of people. | 17:42 |
| robcresswell | I'm not sure on that approach. Larger files are going to need total rewrites when someone wants to add a trivial fix 6 months down the line. | 17:44 |
| krotscheck | Yeah, it's not optimal. | 17:45 |
| krotscheck | Might as well stick with our old approach of fix-it-when-we-land-it | 17:45 |
| robcresswell | I think landmines will get really annoying for stable code. It works for code thats being altered often, but when its been sitting for a while... :/ | 17:47 |
| robcresswell | There is a problem with the warnings thing, but I don't think landmines would solve that, just annoy people. | 17:47 |
| tsufiev | krotscheck: another possible approach is to exclude all existing code and the slowly fix it removing from exclude list | 17:48 |
| tsufiev | Like py34 job failures were addressed | 17:48 |
| krotscheck | robcresswell: ooooh, good point. How might this impact stable-maint? | 17:49 |
| krotscheck | tsufiev: That can be done via .eslintrc files. | 17:49 |
| krotscheck | tsufiev: But who'd be motivated to go rename 800 functions? | 17:49 |
| tsufiev | krotscheck: guess ;) | 17:49 |
| robcresswell | tsufiev: Different situation though. Py34 isn't rapidly evolving like eslint-config is. The issue here is that as eslint-config adds new rules, we need to make Horizon pass them. So we set them to warnings not errors, but then they get ignored. | 17:50 |
| krotscheck | Woohoo, tsufiev volunteered! | 17:50 |
| krotscheck | robcresswell: We could restrict rule updates to once a cycle. | 17:50 |
| krotscheck | robcresswell: Swallow the bitter pill once a cycle, rather than continuously | 17:51 |
| tsufiev | krotscheck: ouch, that was not what I meant :) | 17:51 |
| robcresswell | krotscheck: Heh, I was actually just referring to code that was stable as in untouched recently, not stable as in a stable-release. | 17:51 |
| krotscheck | robcresswell: Oh, gotcha. Well, both applies. | 17:51 |
| krotscheck | robcresswell: Honestly, the stable-maint issue is probably the big veto for the incremental lint. When backporting something, you don't want to be surprised by a landmine that could potentially change functionality. | 17:52 |
| robcresswell | krotscheck: Wouldn't eslint-config just be capped for a release? Sorry, I think I'm missing the issue here | 17:53 |
| krotscheck | robcresswell: Assume there's a stable file that hasn't been changed since a rule update, and thus was never linted. A bug is identified in stable, which requires an update to that file, and BOOM - have to update 100 lines of code just to backport a fix. | 17:54 |
| robcresswell | ooh, I understand. I was thinking of the current format, not landmines. | 17:54 |
| krotscheck | Yeah, so no incremental linting. | 17:55 |
| krotscheck | Because OMG backport | 17:55 |
| robcresswell | :/ I think the current approach is still the lesser of two evils. | 17:56 |
| robcresswell | Back in 5, need food | 17:57 |
| *** nlahouti has quit IRC | 17:59 | |
| * krotscheck is relocating to home office, back in 10 | 17:59 | |
| *** kzaitsev_mb has quit IRC | 18:00 | |
| *** julim_ has joined #openstack-horizon | 18:01 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:03 | |
| *** jbell8 has quit IRC | 18:03 | |
| *** julim has quit IRC | 18:04 | |
| *** btully has quit IRC | 18:06 | |
| *** SurajD has quit IRC | 18:09 | |
| *** jbell8 has joined #openstack-horizon | 18:09 | |
| *** SurajD has joined #openstack-horizon | 18:12 | |
| *** harlowja has joined #openstack-horizon | 18:12 | |
| *** e0ne has quit IRC | 18:13 | |
| *** vgridnev has quit IRC | 18:16 | |
| *** rebase_ has joined #openstack-horizon | 18:20 | |
| *** jobewan has joined #openstack-horizon | 18:21 | |
| *** kzaitsev_mb has quit IRC | 18:28 | |
| *** jprovazn has quit IRC | 18:30 | |
| *** vishwanathj has quit IRC | 18:33 | |
| *** vishwanathj has joined #openstack-horizon | 18:34 | |
| robcresswell | rajatvig: Your comment here has confused me... https://review.openstack.org/#/c/229835/ The patch doesn't appear to be in conflict | 18:38 |
| rajatvig | it's rather old and I'd like to see it rebased against what exists. | 18:39 |
| rajatvig | I couldn't test it as my static files etc conflicted. | 18:39 |
| rajatvig | the code change itself looks good. | 18:40 |
| robcresswell | Just rebase it locally when you test it. I don't think thats really a valid reason to hold up someones code at all. | 18:41 |
| rajatvig | the UI for the Launch Instance has changed from when the patch was created | 18:41 |
| rajatvig | cool. I took off the -1. | 18:41 |
| *** nullvariable has quit IRC | 18:41 | |
| *** itisha has quit IRC | 18:41 | |
| robcresswell | Thanks | 18:42 |
| rajatvig | although, I don't quite agree on doing a review after doing a rebase locally as that changes the patch. | 18:42 |
| robcresswell | Thats all jenkins will do | 18:43 |
| robcresswell | If anythin you probably *should* rebase it off master locally | 18:43 |
| robcresswell | If there's a merge conflict gerrit will flag it | 18:43 |
| robcresswell | Actually, now I'm curious if others do that. Personally I rebase everything on master before reviewing it, but I don't know if thats general practice. | 18:44 |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Updates horizon's copy of the cinder policy file https://review.openstack.org/249379 | 18:45 |
| rajatvig | I understand what you're saying about Jenkins doing it and I'll be mindful of not putting -1 for this reason. This particular patch though made the UI look drastically different from what exists now, so I wasn't sure if I was testing the correct thing. | 18:45 |
| rajatvig | I could've rebased locally but then I'm not reviewing the code that was put up. It might just be me :) | 18:45 |
| *** saksham has joined #openstack-horizon | 18:46 | |
| robcresswell | You're still reviewing the same code though. I'm not sure I really follow the distinction. | 18:50 |
| matt-borland | robcresswell, sometimes I rebase locally, sometimes not. Depends on if I want to mess up my existing review votes. | 18:50 |
| matt-borland | (and other factors) | 18:50 |
| robcresswell | matt-borland: I meant for testing | 18:50 |
| robcresswell | As in, when I 'm going to review something, I pull master, then pull the patch and rebase on master | 18:51 |
| robcresswell | Because thats what the end result will look like when its merged | 18:51 |
| matt-borland | I don't, I test on the current base. That's why it's good to keep rebasng patches. | 18:51 |
| matt-borland | I guess I could start doing that for things quite close to merging. | 18:51 |
| robcresswell | Also means I don't get constant issues with statics, or dependencies changing | 18:51 |
| *** vgridnev has joined #openstack-horizon | 18:52 | |
| robcresswell | What do you gain by not rebasing locally when testing? | 18:52 |
| robcresswell | Just curious | 18:52 |
| *** tosky has quit IRC | 18:52 | |
| *** btully has joined #openstack-horizon | 18:52 | |
| tsufiev | I would love some early feedback (see https://etherpad.openstack.org/p/horizon-integration-tests) from people who know current Horizon (Django) panels really well | 18:53 |
| robcresswell | tsufiev: Will get to it tomorrow :) | 18:53 |
| tsufiev | especially interested in Instances, Images, Networks, Routers, Volumes: Project vs Admin differences | 18:53 |
| tsufiev | I still don't know for sure if it's worth to separately tests Project and Admin functional and how much could be reused (safely for testing coverage) | 18:54 |
| tsufiev | robcresswell, sure! | 18:54 |
| *** jingjing_ren has joined #openstack-horizon | 18:55 | |
| matt-borland | robcresswell, re: rebasing, it's a great idea, I should really start doing that for patches that are lined up to merge. | 18:55 |
| * tsufiev set off home | 18:56 | |
| openstackgerrit | Merged openstack/horizon: Fix for the broken header's dropdowns for both v0.11.2 and v0.13 https://review.openstack.org/218815 | 19:01 |
| *** jbell8 has quit IRC | 19:03 | |
| *** lhcheng has joined #openstack-horizon | 19:04 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 19:04 |
| rajatvig | to me if I rebase then I'm intentionally changing the code that the patch was put up with. the assumption that the patch made about the current state may or may not hold. | 19:05 |
| rajatvig | so I mostly hold off rebasing. If I do rebase and review, then I make sure I also push it upstream as I reviewed it post the rebase. | 19:05 |
| *** itisha has joined #openstack-horizon | 19:06 | |
| *** btully has quit IRC | 19:07 | |
| *** SimonChung has quit IRC | 19:07 | |
| *** SimonChung1 has joined #openstack-horizon | 19:07 | |
| *** mounica has joined #openstack-horizon | 19:08 | |
| *** vishwanathj has quit IRC | 19:08 | |
| *** lhcheng has quit IRC | 19:09 | |
| *** btully has joined #openstack-horizon | 19:10 | |
| *** errolpais has joined #openstack-horizon | 19:11 | |
| robcresswell | rajatvig: Right, but if they've made an incorrect assumption, or not rebased for 6 months, that wouldn't be caught in your review, thats all Im thinking. | 19:11 |
| robcresswell | There doesn't seem to be any gain in it :/ | 19:12 |
| *** rdopiera has quit IRC | 19:12 | |
| rajatvig | robcresswell: you make a valid point. | 19:12 |
| matt-borland | yeah, robcresswell , I agree it seems like a good best-practice, at least for near-gate reviews. | 19:13 |
| matt-borland | (near-merge0 | 19:13 |
| rajatvig | guess I'll review with and without rebase | 19:15 |
| *** SurajD has quit IRC | 19:16 | |
| *** nullvariable has joined #openstack-horizon | 19:16 | |
| *** aix has quit IRC | 19:20 | |
| *** btully has quit IRC | 19:22 | |
| *** vishwanathj_ has joined #openstack-horizon | 19:23 | |
| *** btully has joined #openstack-horizon | 19:24 | |
| *** jbell8 has joined #openstack-horizon | 19:29 | |
| *** jbell8 has quit IRC | 19:30 | |
| *** jbell8 has joined #openstack-horizon | 19:32 | |
| *** marlinc has joined #openstack-horizon | 19:32 | |
| *** vkmc is now known as vkmc-afk | 19:33 | |
| *** davidmichaelkarr has quit IRC | 19:33 | |
| *** sballe has quit IRC | 19:33 | |
| *** ameade has quit IRC | 19:33 | |
| *** tyagiprince1 has joined #openstack-horizon | 19:34 | |
| *** nlahouti has joined #openstack-horizon | 19:35 | |
| *** tyagiprince has quit IRC | 19:35 | |
| *** nlahouti has quit IRC | 19:35 | |
| *** tyagiprince1 is now known as tyagiprince | 19:35 | |
| *** nlahouti1 has joined #openstack-horizon | 19:35 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Magic Search in Angular Users table https://review.openstack.org/202265 | 19:36 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Adding Magic Search codebase to Horizon https://review.openstack.org/245288 | 19:36 |
| *** btully has quit IRC | 19:37 | |
| *** btully has joined #openstack-horizon | 19:41 | |
| *** sqchen has joined #openstack-horizon | 19:45 | |
| *** pumaranikar has joined #openstack-horizon | 19:46 | |
| *** DuncanT has quit IRC | 19:54 | |
| *** erlon has quit IRC | 19:54 | |
| *** ramishra has quit IRC | 19:54 | |
| *** julim_ has quit IRC | 19:54 | |
| *** patk has quit IRC | 20:03 | |
| *** pat has joined #openstack-horizon | 20:03 | |
| *** mohankumar has quit IRC | 20:04 | |
| r1chardj0n3s | morning | 20:06 |
| mrunge | morning r1chardj0n3s | 20:06 |
| *** erlon has joined #openstack-horizon | 20:06 | |
| *** julim has joined #openstack-horizon | 20:07 | |
| *** nlahouti has joined #openstack-horizon | 20:08 | |
| *** nlahouti1 has quit IRC | 20:09 | |
| *** lhcheng has joined #openstack-horizon | 20:10 | |
| *** Piet has joined #openstack-horizon | 20:10 | |
| *** ameade has joined #openstack-horizon | 20:15 | |
| *** rajatvig has quit IRC | 20:19 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding hz-if-neutron-extensions directive https://review.openstack.org/252597 | 20:20 |
| *** lhcheng_ has joined #openstack-horizon | 20:21 | |
| *** sballe has joined #openstack-horizon | 20:21 | |
| *** lhcheng has quit IRC | 20:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:25 | |
| *** hurgleburgler has left #openstack-horizon | 20:25 | |
| *** btully has quit IRC | 20:28 | |
| tyagiprince | Hey people.. need some help with horizon.. The problem I am facing is that on clicking the users tab on the left navigation menu.. The horizon hangs up and takes time to load users from AD.. So I went inside the code to see what was taking so much time.. So what I find out is that the IndexView.get_data is fetching all the users and calling table.render to display the table and the table being used is UserTable.. | 20:31 |
| *** btully has joined #openstack-horizon | 20:32 | |
| tyagiprince | So table.render is taking too much time as there are more than 10000 users in the AD.. | 20:32 |
| *** davidmichaelkarr has joined #openstack-horizon | 20:32 | |
| tyagiprince | I want to change all this.. What I want is to display just the 100 users at a time and when the user filters the users, the list again gets repopulated.. | 20:33 |
| tyagiprince | Could anyone help me out on this..? | 20:34 |
| r1chardj0n3s | tyagiprince: do all of the users in AD need to be active in OpenStack? | 20:34 |
| tyagiprince | Yes.. I cant change anything on the AD as it might disrupt some other projects running outside.. | 20:35 |
| tyagiprince | r1chardj0n3s: | 20:35 |
| r1chardj0n3s | I seem to recall there's a way to filter the active list of users in AD through Keystone - using an AD role. But I'm failing to find it searching at the moment. | 20:36 |
| tyagiprince | r1chardj0n3s: Also I dont want to do any changes to the users.. like creating a new one and updating one etc.. so will removing the row_actions help me in reducing the amount of time it currently takes..? | 20:36 |
| r1chardj0n3s | tyagiprince: I can't say for certain but I believe so | 20:37 |
| tyagiprince | r1chardj0n3s: there is an option in keystone under ldap section.. user_filter I guess.. | 20:37 |
| tsufiev | tyagiprince, I'm still suggesting to collaborate with pkarikh on that | 20:38 |
| tyagiprince | he is still awake.. I was talking to him 12 hours back :P | 20:39 |
| tsufiev | tyagiprince, well, chances are low, but as we said 7 hours back, it's not a 5-minutes task | 20:40 |
| tsufiev | we've been only discussing the whole design with Keystone guys for several months :) | 20:40 |
| tyagiprince | pkarikh, will removing the row_actions from the UsersTable help me in reducing the time to load the Users page? | 20:41 |
| tyagiprince | mrunge: | 20:41 |
| *** absubram has quit IRC | 20:41 | |
| *** nlahouti has quit IRC | 20:42 | |
| mrunge | tyagiprince, yes? | 20:42 |
| tyagiprince | r1chardj0n3s: tsufiev: pkarikh: mrunge: Cant I just use pagination in users table, what difference does the keystone make in this since I am applying pagination after retrieving all the users from keystone.. | 20:43 |
| tsufiev | tyagiprince, if you need it so urgent, you could cut off the users list here https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L319 | 20:43 |
| tsufiev | tyagiprince, but that would be an ad hoc solution | 20:43 |
| tsufiev | please take a little patience and wait 1-2 weeks for a fully polished series of patches | 20:43 |
| tsufiev | we're almost there | 20:43 |
| tsufiev | (comparing to the amount of time already spent) | 20:44 |
| mrunge | tyagiprince, you have been told this once or twice today already | 20:44 |
| tyagiprince | mrunge: yes, but then I now learned django and looked into the code and it makes sense.. | 20:44 |
| mrunge | but on the other side, horizon is not a tool to maintain 10k's of users | 20:44 |
| mrunge | tyagiprince, submit patches for review, if you want an opinion | 20:45 |
| *** btully has quit IRC | 20:46 | |
| tyagiprince | mrunge: Yes I dont want to see all the users.. I just want to display users after filter | 20:46 |
| tyagiprince | tsufiev: mrunge: how does keystone affect the pagination on users in horizon? | 20:47 |
| *** ramishra has joined #openstack-horizon | 20:48 | |
| tyagiprince | yes I am going to be the next contributor I hope:P | 20:48 |
| *** DuncanT has joined #openstack-horizon | 20:48 | |
| tsufiev | tyagiprince, have fun while reading that http://lists.openstack.org/pipermail/openstack-dev/2015-August/072082.html | 20:48 |
| mrunge | tyagiprince, does ad support paginating? | 20:49 |
| tyagiprince | mrunge: I have to see that.. how do I check that? | 20:50 |
| mrunge | tyagiprince, iirc, it does not. part of the issue | 20:50 |
| tyagiprince | In paging policy, it says None and there are other options as well.. Sinple page, plain vlv, framed vlv etc.. is that what you are talking about? | 20:51 |
| tyagiprince | mrunge: | 20:52 |
| tyagiprince | I will check if paging could be there on ad... why? does it make any difference to horizon? | 20:53 |
| tsufiev | tyagiprince, see above thread, it already contains all the questions you've asked so far and will ask during the next 3 days ;) | 20:54 |
| tsufiev | as well as answers to them | 20:55 |
| mrunge | maybe because keystone can not paginate, if the backend can not paginate? | 20:55 |
| mrunge | but as timur already answered several times, read the thread | 20:55 |
| *** Piet has quit IRC | 20:57 | |
| *** emily_w has joined #openstack-horizon | 21:01 | |
| *** ZZelle has joined #openstack-horizon | 21:01 | |
| mrunge | rhagarty, don't get me wrong here, I really appreciate your fix! | 21:01 |
| *** emilyw has quit IRC | 21:01 | |
| david-lyle | inconsistency at least leads to double checking | 21:02 |
| *** emily-w has joined #openstack-horizon | 21:03 | |
| mrunge | wait, when it says GiB, values are correct | 21:03 |
| mrunge | when we have GB; it's reported either by nova, by quota or it's RAM? | 21:03 |
| *** rajatvig has joined #openstack-horizon | 21:03 | |
| rhagarty | this started as a cinder thing, which the community is very interested in fixing. Nova, not so much | 21:03 |
| rhagarty | GiB is a block storage thing, and admins know the difference. | 21:04 |
| mrunge | yeah, what value is reported, when nova reports block storage then? | 21:04 |
| rhagarty | so when they created a 1GB volume, they are confused when it allocated 1GiB on the backend array | 21:04 |
| rhagarty | mrunge, that is what I'm trying to get the Nova folks to investigate | 21:05 |
| doug-fish | glance too, right? | 21:05 |
| rhagarty | they have swap, root, etc disk space allocations that we currently show as GB | 21:06 |
| mrunge | rhagarty, the issue was in the past, you could disable cinder and use nova for storage | 21:06 |
| *** emily_w has quit IRC | 21:06 | |
| mrunge | but both values are reported through the same api | 21:06 |
| rhagarty | doug-fish, probably right | 21:06 |
| rhagarty | nova apis dealing with volumes are deprecated | 21:06 |
| *** kzaitsev_mb has quit IRC | 21:07 | |
| doug-fish | so I'm concerned it may be equally confusing to have what Horizon reports as a 10 GB image fill up a 10 GiB volume | 21:07 |
| rhagarty | doug-fish, agree | 21:07 |
| mrunge | doug-fish, that mostly depends on storage backend, file system etc, no? | 21:08 |
| doug-fish | rhagarty: so I'm glad you are looking into this and driving it - just sharing why I hope to see all/most of the labels change at the same time | 21:08 |
| rhagarty | and as someone already mention, we have quotas and defaults that explicity use the term gigabyte... more confusion | 21:08 |
| rhagarty | doug-fish, I think if we get Nova eyes on this, and changes made, that would be 90% of it | 21:09 |
| *** btully has joined #openstack-horizon | 21:09 | |
| doug-fish | agreed | 21:09 |
| rhagarty | so maybe we get all the patches lined up and not merge till they all are approved? | 21:10 |
| doug-fish | works for me | 21:10 |
| rhagarty | like i mentioned, was hoping to isolate patches so people only look at what effects them | 21:10 |
| mrunge | I'm still thinking of how to organize this all? | 21:11 |
| mrunge | I mean, merging huge patches is a nightmare, because of constant rebases | 21:11 |
| doug-fish | rhagarty: yep, understood. that's a sensible approach | 21:11 |
| rhagarty | mrunge, I don't think the horizon side will be difficult. | 21:11 |
| doug-fish | I assume the hard part is to find out definitively if the flavors api (for example) is giving numbers that are GB or GiB | 21:12 |
| rhagarty | if projects change their default quota names, we will have to coordinate so Horizon doesn't break | 21:12 |
| rhagarty | doug-fish, yes | 21:13 |
| *** lhcheng_ has quit IRC | 21:13 | |
| rhagarty | mrunge, hoping its a manageable number, like 3 or 4 | 21:13 |
| *** lhcheng has joined #openstack-horizon | 21:13 | |
| doug-fish | I'm mildly opposed to changing the quota names in the APIs - is that being seriously considered? | 21:13 |
| mrunge | should we have a blueprint? | 21:14 |
| rhagarty | the key names? yes | 21:14 |
| david-lyle | would be easier for tracking if there was a bp | 21:14 |
| mrunge | doug-fish, I would think of a deprecation period then when changing the api | 21:14 |
| david-lyle | the dependent patches in other services could be linked | 21:14 |
| *** pauloewerton has quit IRC | 21:14 | |
| mrunge | yes | 21:14 |
| doug-fish | mrunge: oh right - that would work | 21:15 |
| rhagarty | this started as a cinder defect, but I will create a blue print | 21:15 |
| *** kzaitsev_mb has joined #openstack-horizon | 21:15 | |
| mrunge | there are folks using horizon cross version | 21:15 |
| mrunge | and we will hurt them badly by just switching apis | 21:15 |
| rhagarty | not sure if cinder will make that change, but someone is working on it - https://bugs.launchpad.net/cinder/+bug/1517108 | 21:16 |
| openstack | Launchpad bug 1517108 in Cinder "Quota properties should be stated in gibibytes instead of gigabytes" [Undecided,New] - Assigned to Slade Baumann (sladebaumann) | 21:16 |
| mrunge | david-lyle, do we need the full blueprint process for this? I mean, that is mostly for tracking | 21:16 |
| mrunge | and there's not much doubt about it. | 21:17 |
| david-lyle | no, lightweight is perfect | 21:17 |
| david-lyle | just something to reference to see all the moving pieces | 21:17 |
| mrunge | great | 21:17 |
| rhagarty | I'm on it | 21:18 |
| *** lhcheng has quit IRC | 21:18 | |
| *** btully has quit IRC | 21:22 | |
| *** apuimedo has joined #openstack-horizon | 21:23 | |
| *** ducttape_ has quit IRC | 21:25 | |
| *** kzaitsev_mb has quit IRC | 21:26 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:30 | |
| *** tyagiprince has quit IRC | 21:32 | |
| *** vkmc-afk is now known as vkmc | 21:33 | |
| *** btully has joined #openstack-horizon | 21:35 | |
| *** itisha has quit IRC | 21:36 | |
| *** lhcheng has joined #openstack-horizon | 21:37 | |
| *** slogan621_ has joined #openstack-horizon | 21:39 | |
| slogan621_ | quick question - if I have my own non-official project that I would like to add UI to horizon for (a new panel I suppose), where does that panel live (in what repo) and how do I integrate with horizon? | 21:41 |
| slogan621_ | a link to the answer would be fine if that is best | 21:41 |
| *** ducttape_ has joined #openstack-horizon | 21:41 | |
| mrunge | slogan621_, should become an own repository | 21:42 |
| mrunge | and you'd be integrating like a plugin | 21:43 |
| mrunge | that should be documented already | 21:43 |
| *** lapalm has quit IRC | 21:43 | |
| slogan621_ | okay | 21:44 |
| lhcheng | rhagarty: would making the Gib vs Gb label configurable make sense? | 21:44 |
| mrunge | slogan621_, ok, doc is here: https://review.openstack.org/244407 | 21:44 |
| *** vishwanathj_ has quit IRC | 21:44 | |
| mrunge | lhcheng, I don't think so | 21:45 |
| rhagarty | lhcheng, maybe, but wouldn't that change it everywhere? | 21:45 |
| david-lyle | lhcheng: API returns GiB | 21:45 |
| *** ctina_ has joined #openstack-horizon | 21:45 | |
| *** nlahouti has joined #openstack-horizon | 21:46 | |
| lhcheng | does nova volume also return GiB? | 21:46 |
| mrunge | lhcheng, unknown and nova volume is deprecated | 21:46 |
| slogan621_ | I've done django for maybe 3 or 4 years outside of openstack, I assume what I am doing basically is writing a django app and plugin represents whatever infrastructure horizon needs to integrate my app into the dashboard. Is that roughly the way to view it? | 21:46 |
| slogan621_ | mrunge: thanks | 21:47 |
| mrunge | lhcheng, nova folks are investigating this, according to rhagarty | 21:47 |
| lhcheng | mrunge: it is deprecated, but some operator may still be using it. | 21:47 |
| mrunge | lhcheng, yes, that's correct | 21:47 |
| rhagarty | lhcheng, think so, but need to verify | 21:47 |
| mrunge | so, depending on your storage configuration, reported values are now right or wrong | 21:48 |
| *** btully has quit IRC | 21:48 | |
| mrunge | and after the change wrong or right | 21:48 |
| *** ctina has quit IRC | 21:49 | |
| *** ctina_ has quit IRC | 21:50 | |
| lhcheng | mrunge: if the unit reported is based on storage configuration, doesn't that mean the value displayed in horizon could either be gb or gib? | 21:50 |
| mrunge | lhcheng, that's my understanding, yes | 21:50 |
| rhagarty | block storage is always in GiB | 21:51 |
| mrunge | rhagarty, but it's unclear, what nova volume reported, right? | 21:51 |
| rhagarty | yeah, not sure what they are doing under the covers | 21:52 |
| slogan621_ | monasca-ui project looks like a good example of what a horizon plugin should be, I'll use that for inspiration | 21:55 |
| *** kzaitsev_mb has quit IRC | 21:57 | |
| lhcheng | rhagarty: ah okay, changing it to GiB for volumes/cinder sounds good then. | 21:59 |
| rhagarty | lhcheng, yes, good first step. Then have to deal with other panels that reference storage | 22:00 |
| *** slogan621_ has quit IRC | 22:01 | |
| lhcheng | rhagarty: great, thank you for driving this | 22:02 |
| *** crobertsrh has left #openstack-horizon | 22:02 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:03 | |
| mrunge | rhagarty, btw, did you create a bp? | 22:03 |
| rhagarty | lhcheng, np, hopefully get enough buy-in from other projects to make this right | 22:03 |
| rhagarty | mrunge, typing it up now | 22:03 |
| mrunge | awesome | 22:03 |
| *** saksham has quit IRC | 22:05 | |
| *** petertr7 is now known as petertr7_away | 22:06 | |
| *** jtriley has quit IRC | 22:06 | |
| *** lblanchard has quit IRC | 22:11 | |
| rhagarty | mrunge, https://blueprints.launchpad.net/horizon/+spec/gb-to-gib-conversion | 22:11 |
| *** julim has quit IRC | 22:11 | |
| rhagarty | mrunge, should I add links to existing bugs, patches? | 22:11 |
| *** SimonChung1 has quit IRC | 22:11 | |
| r1chardj0n3s | david-lyle: Piet ain't on here right now, did you and he talk midcycle already? I'll start up an email otherwise | 22:11 |
| *** SimonChung has joined #openstack-horizon | 22:11 | |
| *** SimonChung1 has joined #openstack-horizon | 22:12 | |
| *** SimonChung has quit IRC | 22:12 | |
| *** saksham has joined #openstack-horizon | 22:12 | |
| *** SimonChung1 has quit IRC | 22:12 | |
| *** SimonChung has joined #openstack-horizon | 22:12 | |
| mrunge | rhagarty, preferrably you'd change the commit message on your patch | 22:13 |
| *** SimonChung has quit IRC | 22:14 | |
| mrunge | rhagarty, but putting in links to bugs is great as well | 22:14 |
| *** SimonChung1 has joined #openstack-horizon | 22:14 | |
| rhagarty | mrunge, will do | 22:14 |
| mrunge | rhagarty, thank you | 22:14 |
| *** emily_w has joined #openstack-horizon | 22:20 | |
| *** emily-w has quit IRC | 22:20 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 22:20 |
| *** kzaitsev_mb has quit IRC | 22:21 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:23 | |
| *** vgridnev has quit IRC | 22:24 | |
| *** matt-borland has quit IRC | 22:25 | |
| *** erlon has quit IRC | 22:26 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 22:28 |
| *** kzaitsev_mb has quit IRC | 22:33 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 22:34 |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add Create Volume Action for the Image https://review.openstack.org/229677 | 22:35 |
| *** ianbrown has joined #openstack-horizon | 22:36 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:36 | |
| *** adelia has quit IRC | 22:41 | |
| *** btully has joined #openstack-horizon | 22:46 | |
| *** kzaitsev_mb has quit IRC | 22:53 | |
| *** ianbrown has quit IRC | 22:54 | |
| *** TravT has quit IRC | 22:55 | |
| openstackgerrit | Merged openstack/horizon: Launch Instance Modal should be exist as a Service https://review.openstack.org/220214 | 22:56 |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 23:02 |
| *** RichardRaseley has joined #openstack-horizon | 23:02 | |
| *** btully has quit IRC | 23:05 | |
| *** SimonChung has joined #openstack-horizon | 23:06 | |
| *** SimonChung1 has quit IRC | 23:06 | |
| *** peristeri has quit IRC | 23:07 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 23:08 |
| robcresswell | Just read the meeting logs. Sorry I missed it. I see the GiB saga continues. | 23:09 |
| *** pumaranikar has quit IRC | 23:13 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:13 | |
| *** btully has joined #openstack-horizon | 23:15 | |
| *** neelashah has quit IRC | 23:16 | |
| *** david_cu has quit IRC | 23:17 | |
| *** neelashah has joined #openstack-horizon | 23:17 | |
| *** david_cu has joined #openstack-horizon | 23:17 | |
| *** kzaitsev_mb has quit IRC | 23:18 | |
| *** lhcheng has quit IRC | 23:21 | |
| *** Daisy has joined #openstack-horizon | 23:21 | |
| *** david_cu has quit IRC | 23:21 | |
| *** vgridnev has joined #openstack-horizon | 23:22 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:23 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 23:24 |
| *** neelashah has quit IRC | 23:24 | |
| david-lyle | doug-fish: ping | 23:24 |
| david-lyle | https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/pages/navigation.py#L51 | 23:25 |
| david-lyle | holy cow | 23:25 |
| *** Daisy_ has joined #openstack-horizon | 23:25 | |
| *** Daisy has quit IRC | 23:26 | |
| openstackgerrit | Merged openstack/horizon: Replace "Terminate Instance" with "Delete Instance" https://review.openstack.org/231428 | 23:27 |
| *** Daisy_ has quit IRC | 23:30 | |
| *** jpomeroy has quit IRC | 23:31 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 23:34 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 23:34 |
| *** Daisy has joined #openstack-horizon | 23:35 | |
| *** vgridnev has quit IRC | 23:36 | |
| *** mounica has quit IRC | 23:36 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for angular Volumes panel https://review.openstack.org/233760 | 23:37 |
| *** kzaitsev_mb has quit IRC | 23:37 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Create Volume Action for the Image https://review.openstack.org/229677 | 23:37 |
| *** sqchen has quit IRC | 23:38 | |
| *** btully has quit IRC | 23:38 | |
| *** Daisy has quit IRC | 23:39 | |
| *** sqchen has joined #openstack-horizon | 23:48 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Use "GiB" and "gibibyte" labels in volume panels https://review.openstack.org/243880 | 23:50 |
| *** ZZelle has quit IRC | 23:51 | |
| *** RichardRaseley has quit IRC | 23:56 | |
| *** apuimedo has quit IRC | 23:57 | |
| *** apuimedo has joined #openstack-horizon | 23:57 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!