| *** pat has quit IRC | 00:00 | |
| *** jerrygb has quit IRC | 00:01 | |
| *** Daisy has quit IRC | 00:01 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for Create a Volume, get QoS and tenant limits https://review.openstack.org/233760 | 00:04 |
|---|---|---|
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 00:05 |
| *** kzaitsev_mb has joined #openstack-horizon | 00:06 | |
| *** yamamoto has joined #openstack-horizon | 00:09 | |
| *** jpomeroy has quit IRC | 00:10 | |
| openstackgerrit | Merged openstack/horizon: Move Detail page styling into theme https://review.openstack.org/245182 | 00:12 |
| *** nlahouti has quit IRC | 00:13 | |
| *** pat has joined #openstack-horizon | 00:18 | |
| *** yamamoto has quit IRC | 00:21 | |
| *** zul has quit IRC | 00:22 | |
| *** jtriley has joined #openstack-horizon | 00:22 | |
| *** mordred has quit IRC | 00:23 | |
| *** zul has joined #openstack-horizon | 00:23 | |
| *** mordred has joined #openstack-horizon | 00:23 | |
| *** gyee has joined #openstack-horizon | 00:25 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Single Row Action button should appear as buttons https://review.openstack.org/243796 | 00:25 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow specifying item to use for actions in the actions directive https://review.openstack.org/254365 | 00:25 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow callback prefix for actions directive https://review.openstack.org/254415 | 00:25 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 00:25 |
| *** chlong has joined #openstack-horizon | 00:28 | |
| *** gokrokve has joined #openstack-horizon | 00:28 | |
| *** jtriley has quit IRC | 00:30 | |
| *** belmoreira has quit IRC | 00:30 | |
| *** jingjing_ren has joined #openstack-horizon | 00:31 | |
| *** ZZelle_ has quit IRC | 00:33 | |
| *** jingjing_ren has quit IRC | 00:36 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Edit Image Action to angular images panel https://review.openstack.org/217828 | 00:37 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding Create Image Action to angular images panel https://review.openstack.org/236042 | 00:37 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 00:37 |
| *** kzaitsev_mb has quit IRC | 00:38 | |
| *** ducttape_ has joined #openstack-horizon | 00:38 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for Create a Volume, get QoS and tenant limits https://review.openstack.org/233760 | 00:42 |
| *** gokrokve has quit IRC | 00:43 | |
| *** gokrokve has joined #openstack-horizon | 00:44 | |
| *** jtriley has joined #openstack-horizon | 00:45 | |
| *** RichardRaseley has quit IRC | 00:45 | |
| *** gokrokve has quit IRC | 00:49 | |
| *** openstackstatus has quit IRC | 00:50 | |
| *** openstack has joined #openstack-horizon | 00:52 | |
| *** ducttape_ has quit IRC | 00:53 | |
| *** rajatvig has quit IRC | 00:56 | |
| *** gokrokve has joined #openstack-horizon | 00:58 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:59 | |
| *** ianbrown_ has quit IRC | 01:03 | |
| *** kzaitsev_mb has quit IRC | 01:04 | |
| *** bpokorny_ has joined #openstack-horizon | 01:06 | |
| *** bpokorny has quit IRC | 01:09 | |
| *** bpokorny_ has quit IRC | 01:10 | |
| *** itisha has quit IRC | 01:16 | |
| *** tqtran has quit IRC | 01:19 | |
| *** ducttape_ has joined #openstack-horizon | 01:23 | |
| *** zhenguo has joined #openstack-horizon | 01:24 | |
| *** garthb has quit IRC | 01:32 | |
| *** ducttape_ has quit IRC | 01:44 | |
| *** esp has joined #openstack-horizon | 01:46 | |
| *** jamielennox is now known as jamielennox|away | 01:47 | |
| *** jtriley has quit IRC | 01:47 | |
| *** ducttape_ has joined #openstack-horizon | 01:47 | |
| *** Liuqing has joined #openstack-horizon | 01:48 | |
| *** gokrokve has quit IRC | 01:50 | |
| *** jwy1 has joined #openstack-horizon | 01:52 | |
| *** jwy has quit IRC | 01:52 | |
| openstackgerrit | Merged openstack/horizon: Remove usage of user project caching https://review.openstack.org/244420 | 01:53 |
| *** Liuqing has quit IRC | 01:58 | |
| *** chlong has quit IRC | 02:03 | |
| *** errolpais has quit IRC | 02:03 | |
| *** yamamoto has joined #openstack-horizon | 02:09 | |
| *** yamamoto has quit IRC | 02:10 | |
| *** vgridnev has quit IRC | 02:12 | |
| *** gokrokve has joined #openstack-horizon | 02:14 | |
| *** ducttape_ has quit IRC | 02:16 | |
| *** ducttape_ has joined #openstack-horizon | 02:17 | |
| *** mtanino has quit IRC | 02:17 | |
| *** ducttape_ has quit IRC | 02:18 | |
| *** zhurong has joined #openstack-horizon | 02:18 | |
| *** ducttape_ has joined #openstack-horizon | 02:23 | |
| *** zhurong has quit IRC | 02:25 | |
| *** jwy1 has quit IRC | 02:28 | |
| *** gokrokve has quit IRC | 02:30 | |
| *** gokrokve has joined #openstack-horizon | 02:31 | |
| *** zhurong has joined #openstack-horizon | 02:33 | |
| *** chestack has joined #openstack-horizon | 02:33 | |
| *** gokrokve has quit IRC | 02:38 | |
| *** jwy has joined #openstack-horizon | 02:38 | |
| openstackgerrit | Merged openstack/horizon: Removing sahara specific exception ref https://review.openstack.org/254343 | 02:41 |
| *** ducttape_ has quit IRC | 02:43 | |
| *** ducttape_ has joined #openstack-horizon | 02:46 | |
| *** jamielennox|away is now known as jamielennox | 02:50 | |
| *** ducttape_ has quit IRC | 02:57 | |
| *** jerrygb has joined #openstack-horizon | 02:57 | |
| *** jwy has quit IRC | 02:58 | |
| *** jwy has joined #openstack-horizon | 02:59 | |
| *** gokrokve has joined #openstack-horizon | 02:59 | |
| *** yamamoto has joined #openstack-horizon | 02:59 | |
| *** ducttape_ has joined #openstack-horizon | 03:01 | |
| *** jerrygb has quit IRC | 03:02 | |
| *** jtriley has joined #openstack-horizon | 03:03 | |
| *** gokrokve has quit IRC | 03:04 | |
| *** SurajD has quit IRC | 03:08 | |
| *** ducttape_ has quit IRC | 03:09 | |
| *** SurajD has joined #openstack-horizon | 03:13 | |
| *** ducttape_ has joined #openstack-horizon | 03:14 | |
| *** chlong has joined #openstack-horizon | 03:16 | |
| *** jerrygb has joined #openstack-horizon | 03:18 | |
| *** mwhagedorn has joined #openstack-horizon | 03:18 | |
| *** sanjana has quit IRC | 03:22 | |
| *** sanjana has joined #openstack-horizon | 03:22 | |
| *** masco has joined #openstack-horizon | 03:23 | |
| *** Piet has joined #openstack-horizon | 03:23 | |
| *** Piet has quit IRC | 03:26 | |
| *** jbell8 has joined #openstack-horizon | 03:29 | |
| *** mtanino has joined #openstack-horizon | 03:31 | |
| *** ducttape_ has quit IRC | 03:42 | |
| *** wolverineav has joined #openstack-horizon | 03:43 | |
| *** zhurong has quit IRC | 03:44 | |
| openstackgerrit | zhu.rong proposed openstack/horizon: Delete the unused LOG configure code https://review.openstack.org/222847 | 03:44 |
| *** zhurong has joined #openstack-horizon | 03:45 | |
| *** jerrygb has quit IRC | 03:48 | |
| *** wolverineav has quit IRC | 03:48 | |
| *** jerrygb has joined #openstack-horizon | 03:48 | |
| *** chlong has quit IRC | 03:49 | |
| *** zhurong has quit IRC | 03:50 | |
| openstackgerrit | zhu.rong proposed openstack/horizon: Delete the unused LOG configure code https://review.openstack.org/222847 | 03:50 |
| *** zhurong has joined #openstack-horizon | 03:52 | |
| openstackgerrit | javeme proposed openstack/horizon: Avoid warnings caused by the positional args https://review.openstack.org/255061 | 03:52 |
| *** alejandrito has quit IRC | 03:52 | |
| *** jerrygb has quit IRC | 03:52 | |
| *** chlong has joined #openstack-horizon | 03:53 | |
| *** jerrygb has joined #openstack-horizon | 04:03 | |
| *** gyee has quit IRC | 04:03 | |
| *** mtanino has quit IRC | 04:03 | |
| *** shu-mutou has joined #openstack-horizon | 04:20 | |
| *** gokrokve has joined #openstack-horizon | 04:22 | |
| *** gokrokve has quit IRC | 04:30 | |
| *** masco has quit IRC | 04:40 | |
| *** mwhagedorn has quit IRC | 04:41 | |
| *** jtriley has quit IRC | 04:41 | |
| *** bpokorny has joined #openstack-horizon | 04:44 | |
| *** jerrygb has quit IRC | 04:49 | |
| *** hurgleburgler has joined #openstack-horizon | 04:49 | |
| *** jbell8 has quit IRC | 04:50 | |
| *** jerrygb has joined #openstack-horizon | 04:51 | |
| *** jerrygb has quit IRC | 04:51 | |
| *** jerrygb has joined #openstack-horizon | 04:51 | |
| *** jbell8 has joined #openstack-horizon | 04:52 | |
| *** jwy has quit IRC | 04:52 | |
| *** sanjana has quit IRC | 04:52 | |
| *** bpokorny has quit IRC | 04:55 | |
| *** jtriley has joined #openstack-horizon | 04:55 | |
| *** jbell8 has quit IRC | 05:01 | |
| *** gokrokve has joined #openstack-horizon | 05:01 | |
| *** hurgleburgler has quit IRC | 05:01 | |
| *** jtriley has quit IRC | 05:02 | |
| *** mwhagedorn has joined #openstack-horizon | 05:05 | |
| *** lhcheng has joined #openstack-horizon | 05:06 | |
| *** hurgleburgler has joined #openstack-horizon | 05:07 | |
| *** lhcheng has quit IRC | 05:12 | |
| *** hurgleburgler has quit IRC | 05:14 | |
| *** hurgleburgler1 has joined #openstack-horizon | 05:14 | |
| *** gokrokve_ has joined #openstack-horizon | 05:28 | |
| *** gokrokve has quit IRC | 05:28 | |
| *** mohankumar has joined #openstack-horizon | 05:29 | |
| *** mwhagedorn has quit IRC | 05:31 | |
| *** vgridnev has joined #openstack-horizon | 05:42 | |
| *** gokrokve_ has quit IRC | 05:51 | |
| *** gokrokve has joined #openstack-horizon | 05:52 | |
| *** chestack has quit IRC | 06:11 | |
| *** jerrygb has quit IRC | 06:17 | |
| *** jerrygb has joined #openstack-horizon | 06:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/254569 | 06:20 |
| *** jerrygb has quit IRC | 06:21 | |
| *** logan- has quit IRC | 06:24 | |
| *** hurgleburgler1 has quit IRC | 06:25 | |
| *** rajatvig has joined #openstack-horizon | 06:29 | |
| *** gokrokve has quit IRC | 06:32 | |
| *** SurajD has quit IRC | 06:35 | |
| *** jbell8 has joined #openstack-horizon | 06:36 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Single Row Action button should appear as buttons https://review.openstack.org/243796 | 06:38 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow specifying item to use for actions in the actions directive https://review.openstack.org/254365 | 06:38 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow callback prefix for actions directive https://review.openstack.org/254415 | 06:38 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 06:38 |
| *** SurajD has joined #openstack-horizon | 06:39 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 06:40 |
| *** chlong has quit IRC | 06:40 | |
| *** jbell8 has quit IRC | 06:42 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add API services for system information https://review.openstack.org/205196 | 06:47 |
| *** masco has joined #openstack-horizon | 06:47 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular system information panel https://review.openstack.org/204731 | 06:47 |
| *** jtriley has joined #openstack-horizon | 06:57 | |
| *** jerrygb has joined #openstack-horizon | 07:00 | |
| *** gokrokve has joined #openstack-horizon | 07:02 | |
| *** jtriley has quit IRC | 07:02 | |
| *** jtomasek has joined #openstack-horizon | 07:03 | |
| openstackgerrit | zhu.rong proposed openstack/horizon: Delete the unused LOG configure code https://review.openstack.org/222847 | 07:05 |
| *** rajatvig has left #openstack-horizon | 07:05 | |
| *** jtomasek has quit IRC | 07:06 | |
| *** jerrygb has quit IRC | 07:06 | |
| *** gokrokve has quit IRC | 07:07 | |
| *** rcernin has joined #openstack-horizon | 07:20 | |
| *** jtomasek has joined #openstack-horizon | 07:21 | |
| *** mflobo has joined #openstack-horizon | 07:37 | |
| mflobo | Good morning o/ | 07:37 |
| mrunge | good morning | 07:41 |
| r1chardj0n3s | Hullo mrunge o/ | 07:45 |
| r1chardj0n3s | I'm in a restaurant, but should be along to the meeting later if I can stay awake (5am start, 11pm meeting lol) | 07:46 |
| mrunge | r1chardj0n3s, you probably shouldn't be checking irc while dining ;-) | 07:47 |
| mrunge | r1chardj0n3s, thank you, I'll update david, when he's around. those 12 UTC meetings are mostly quiet anyways | 07:48 |
| *** rhagarty_ has joined #openstack-horizon | 07:48 | |
| *** rhagarty has quit IRC | 07:49 | |
| *** e0ne has joined #openstack-horizon | 07:52 | |
| *** pece has joined #openstack-horizon | 07:56 | |
| mflobo | Any love for patch regarding "Add Metadata page to angular Launch Instance wizard" https://review.openstack.org/#/c/232234/ ? :) | 07:56 |
| *** itxaka has joined #openstack-horizon | 08:01 | |
| *** gokrokve has joined #openstack-horizon | 08:03 | |
| *** pece has quit IRC | 08:04 | |
| *** gokrokve has quit IRC | 08:08 | |
| *** SurajD has quit IRC | 08:11 | |
| *** jtriley has joined #openstack-horizon | 08:15 | |
| *** SurajD has joined #openstack-horizon | 08:15 | |
| *** belmoreira has joined #openstack-horizon | 08:15 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Fix issue when using glance v2 api https://review.openstack.org/249531 | 08:20 |
| *** jtriley has quit IRC | 08:21 | |
| *** amotoki has joined #openstack-horizon | 08:22 | |
| *** vgridnev has quit IRC | 08:23 | |
| *** tosky has joined #openstack-horizon | 08:25 | |
| *** chestack has joined #openstack-horizon | 08:30 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Adding angular QoS panel in horizon https://review.openstack.org/247997 | 08:30 |
| openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248546 | 08:44 |
| *** KingKhan has joined #openstack-horizon | 08:44 | |
| *** ^Gal^ has joined #openstack-horizon | 08:52 | |
| *** rdopiera has joined #openstack-horizon | 08:54 | |
| *** tosky_ has joined #openstack-horizon | 08:58 | |
| *** ^Gal^ has quit IRC | 08:59 | |
| *** tosky has quit IRC | 08:59 | |
| openstackgerrit | Matthias Runge proposed openstack/horizon: Add testr support https://review.openstack.org/255136 | 09:00 |
| *** oetrog has joined #openstack-horizon | 09:01 | |
| *** oetrog is now known as omer_etrog | 09:01 | |
| *** jerrygb has joined #openstack-horizon | 09:02 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Refactor includes in the tables templates https://review.openstack.org/254741 | 09:02 |
| *** gokrokve has joined #openstack-horizon | 09:04 | |
| *** zhurong has quit IRC | 09:04 | |
| *** openstackstatus has quit IRC | 09:05 | |
| *** openstack has joined #openstack-horizon | 09:07 | |
| *** jerrygb has quit IRC | 09:08 | |
| *** ygbo has joined #openstack-horizon | 09:09 | |
| mrunge | masco, while thinking about amotoki's comment, I would thing it makes sense to rename the qos panel to something like neutron_qos, no? | 09:09 |
| *** gokrokve has quit IRC | 09:09 | |
| mrunge | I mean, there is qos for cinder, too, but we don't have a panel for it right now | 09:10 |
| masco | mrunge, you mean the panel name? | 09:11 |
| mrunge | masco, yeah | 09:11 |
| mrunge | and probably the folder name under projects should be renamed | 09:11 |
| mrunge | basically all folder names containing only qos, masco | 09:12 |
| mrunge | what do you think? | 09:12 |
| masco | mrunge, ah, ok. make sense | 09:12 |
| masco | mrunge, what about the display name for the panel? | 09:12 |
| mrunge | masco, I admit, I did not mention this before | 09:12 |
| mrunge | masco, you mean like here: https://review.openstack.org/#/c/247997/8/openstack_dashboard/dashboards/project/qos/templates/qos/index.html,cm ? | 09:13 |
| mrunge | I would name that Network QoS policies | 09:13 |
| mrunge | policy with lower 'p' and an 'o' somewhere... | 09:13 |
| mrunge | masco^^ | 09:13 |
| mrunge | masco, shall I do a quick review? | 09:14 |
| masco | mrunge, nice suggestion | 09:14 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix decription for admins Image create modal https://review.openstack.org/255144 | 09:14 |
| masco | mrunge, sure, always welcome | 09:15 |
| *** e0ne has quit IRC | 09:15 | |
| *** KingKhan has quit IRC | 09:19 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Fix decription for admins Image create modal https://review.openstack.org/255144 | 09:20 |
| *** vgridnev has joined #openstack-horizon | 09:32 | |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit has joined #openstack-horizon | 09:33 | |
| *** omer_etr_ has joined #openstack-horizon | 09:45 | |
| *** lhcheng has joined #openstack-horizon | 09:46 | |
| *** omer_et__ has joined #openstack-horizon | 09:48 | |
| *** omer_etr_ has quit IRC | 09:48 | |
| openstackgerrit | Merged openstack/horizon: Remove disabled attribute from select fields on submit https://review.openstack.org/227167 | 09:48 |
| *** omer_etrog has quit IRC | 09:49 | |
| *** SurajD has quit IRC | 09:54 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/254569 | 09:55 |
| *** SurajD has joined #openstack-horizon | 09:57 | |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** zhenguo has quit IRC | 10:02 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:03 | |
| *** openstackgerrit has joined #openstack-horizon | 10:03 | |
| robcresswell | Morning all | 10:06 |
| robcresswell | This time last week had abotu 15 reviews open, now 2. Time to write more code :) | 10:06 |
| robcresswell | about* | 10:06 |
| *** e0ne has joined #openstack-horizon | 10:10 | |
| *** jamielennox is now known as jamielennox|away | 10:13 | |
| *** JeanBriceCombebi has quit IRC | 10:14 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:14 | |
| *** omer_et__ has quit IRC | 10:15 | |
| *** pece has joined #openstack-horizon | 10:16 | |
| *** jtriley has joined #openstack-horizon | 10:17 | |
| *** aix has joined #openstack-horizon | 10:20 | |
| *** jtriley has quit IRC | 10:22 | |
| *** ^Gal^ has quit IRC | 10:22 | |
| *** ygl has joined #openstack-horizon | 10:26 | |
| ibmko | robcresswell, sorry, coming back to yesterdays discussion, after I did the collectstatic -c, now I am getting ommandError: An error occured during rendering /usr/share/openstack-dashboard/openstack_dashboard/templates/_stylesheets.html: 'dashboard/scss/horizon.scss' could not be found in the COMPRESS_ROOT '/usr/share/openstack-dashboard/static' or with staticfiles. when running compress | 10:28 |
| robcresswell | ibmko: Hmmm | 10:29 |
| *** ianbrown has joined #openstack-horizon | 10:30 | |
| ibmko | by chance, do you know if this is a known bug? On google I see something similar appeared on Mirantis OpenStack | 10:30 |
| *** chestack has quit IRC | 10:30 | |
| openstackgerrit | Marcos Fermín Lobo proposed openstack/horizon: No hostname validation in launch instance angularjs panel https://review.openstack.org/244145 | 10:30 |
| robcresswell | ibmko: One moment. Just grabbing a stable/kilo env from github. | 10:31 |
| *** mflobo has left #openstack-horizon | 10:31 | |
| ibmko | no problem | 10:32 |
| *** cbader has quit IRC | 10:32 | |
| *** cbader has joined #openstack-horizon | 10:33 | |
| *** ygl has quit IRC | 10:34 | |
| robcresswell | I can't recreate it :/ | 10:34 |
| ibmko | the file dashboard/scss/horizon.scss is somehow autogenerated ? (sorrry, I am not exactly a web developer) | 10:36 |
| *** aix has quit IRC | 10:37 | |
| robcresswell | Does collectstatic run without issue? | 10:38 |
| robcresswell | Running collectstatic should give you that filepath yes | 10:39 |
| robcresswell | at openstack-dashboard/static | 10:39 |
| *** mohankumar has quit IRC | 10:41 | |
| ibmko | collectstatic runs without issue but it doesn't generate the dashboard/scss/horizon.scss path | 10:41 |
| ibmko | 772 other static files generated and copied | 10:41 |
| robcresswell | 772? stable/kilo for me is 938 | 10:42 |
| openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/255198 | 10:42 |
| ibmko | its stable/kilo installed from Ubuntu repos | 10:42 |
| robcresswell | We don't oversee the packaging ourselves unfortunately | 10:44 |
| robcresswell | Which makes it difficult for me to debug | 10:44 |
| ibmko | I understand, thanks, I will keep digging | 10:44 |
| *** mwhagedorn has joined #openstack-horizon | 10:45 | |
| robcresswell | ibmko: Could you do `tree -L 1 static` please? Just paste it to http://paste.openstack.org/ | 10:45 |
| mrunge | ibmko, you're using debian packages? | 10:46 |
| robcresswell | mrunge: I was wondering the same thing :p | 10:46 |
| robcresswell | *blame zigo* | 10:46 |
| mrunge | I would think Canonical *borrowed* them from Debian | 10:46 |
| robcresswell | They usually do | 10:46 |
| mrunge | so, zigo is the person to ask | 10:46 |
| zigo | For Ubuntu stuff? | 10:47 |
| zigo | Certainly NOT ! | 10:47 |
| mrunge | full disclosure, zigo is doing packages for debian | 10:47 |
| robcresswell | hahaa | 10:47 |
| zigo | They maintained their broken Horizon package by themselves. | 10:47 |
| mrunge | good to know | 10:47 |
| zigo | And when I say broken, I mean SERIOUSLY broken. | 10:47 |
| ibmko | so the ubuntu horizon package is broken ? | 10:48 |
| mrunge | ibmko, then you should file a bug at canonical | 10:48 |
| zigo | Runtime writing in /usr and the like. | 10:48 |
| mrunge | ouch | 10:48 |
| zigo | ibmko: It may appear to work for an average user... | 10:48 |
| zigo | But that's a travesty it does. | 10:48 |
| zigo | :) | 10:48 |
| robcresswell | Could just change the source and use zigo's package no? | 10:48 |
| zigo | robcresswell: That's not enough. | 10:49 |
| mrunge | that would void warranty, if there is | 10:49 |
| zigo | robcresswell: Canonical decided it was more fun to re-embbed JS within the python-xstatic-* packages. | 10:49 |
| zigo | Hum... | 10:49 |
| zigo | It will be enough, sorry. | 10:49 |
| zigo | :P | 10:49 |
| ibmko | http://paste.openstack.org/show/481291/ | 10:49 |
| zigo | Though it will not fix xstatic packages, they will still appear to work with the embedded .js | 10:49 |
| mrunge | ibmko, or are you using Mirantis OpenStack? | 10:50 |
| ibmko | no, it is Ubuntu 14.04 with stable/kilo | 10:51 |
| ibmko | installed from Canonical repos, (without Juju) | 10:51 |
| mrunge | that probably means: no support at all | 10:52 |
| mrunge | but I may be wrong! | 10:52 |
| ibmko | I am not worried about warranty at the moment. Just need to get it going to understand the problem, and then we just ivolve developer to get it fixed or we will push on Canonical to fix it (I am working on a commercial deployment of OpenStack) | 10:53 |
| robcresswell | Odd. ibmko, repeat it with a depth of two on the static/dashboard folder. I\m curious why it doesnt seem to have the same number of static files as me. | 10:53 |
| robcresswell | as in tree -L 2 static/dashboard. Just trying to see whats being generated or not | 10:54 |
| ibmko | right | 10:54 |
| mrunge | ibmko, the right way would be to have it fixed in the distro. otherwise you'll be broken again on the next update | 10:54 |
| *** rdopiera has quit IRC | 10:55 | |
| ibmko | mrunge, yes, definitely agree | 10:55 |
| ibmko | http://paste.openstack.org/show/481292/ | 10:55 |
| ibmko | mrunge, when I said that we involve developer, I really meant that we will involve developer who will work with community to fix it. We definitely don't plan to maintain our own branches with fixes | 10:57 |
| robcresswell | Huh. Yeah that scss/ folder is missing multiple files | 10:57 |
| robcresswell | OH | 10:57 |
| robcresswell | I think... | 10:57 |
| robcresswell | Ah! mrunge, this may be before I fixed the MANIFEST for scss | 10:58 |
| robcresswell | So it doesnt not contain them, and so has not gathered them | 10:58 |
| mrunge | robcresswell, but still... | 10:58 |
| mrunge | how could e.g Red Hat packages or Debian package be NOT broken | 10:58 |
| mrunge | robcresswell, you fixed that slightly before liberty release | 10:59 |
| * robcresswell throws idea out the window | 10:59 | |
| ibmko | hmm this kilo install is from September | 10:59 |
| *** rdopiera has joined #openstack-horizon | 10:59 | |
| *** mpavlase has joined #openstack-horizon | 11:00 | |
| mrunge | Kilo was released in April | 11:02 |
| tsufiev | ibmko, for the record here, I do not recall such kind of problems in Mirantis Openstack | 11:02 |
| robcresswell | I'm still curious about why there is a ~200 difference in the static files | 11:02 |
| tsufiev | if it were, we should have had it here https://bugs.launchpad.net/mos/+bugs?field.tag=horizon | 11:02 |
| ibmko | hmm, I see there is a newer version of openstack-dashboard available in the repo | 11:02 |
| ibmko | newer than the one I have currently installed | 11:03 |
| *** lhcheng_ has joined #openstack-horizon | 11:03 | |
| ibmko | mrunge, right, but some fixes to the stable/kilo may have come after the April right | 11:03 |
| mrunge | oh yes, definitely ibmko | 11:03 |
| mrunge | I, for myself are still fixing kilo issues | 11:04 |
| *** jerrygb has joined #openstack-horizon | 11:04 | |
| ibmko | so I will upgrade the package and will see it gets fixed ok ? | 11:04 |
| ibmko | or should I collect some other info for you before doing that? | 11:04 |
| robcresswell | Update. We don't need to debug problems that may have already been solved IMO. | 11:05 |
| mrunge | I would think, staying in the same release shouldn't do any harm to your system | 11:05 |
| *** kmartin has quit IRC | 11:05 | |
| ibmko | robcresswell, ;) | 11:05 |
| *** chestack has joined #openstack-horizon | 11:05 | |
| mrunge | robcresswell, your manifest patch was not backported, no? | 11:05 |
| *** kmartin has joined #openstack-horizon | 11:05 | |
| robcresswell | If it gets worse, I claim no responsibility ;) | 11:05 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix bad performance when editing domain members https://review.openstack.org/177005 | 11:05 |
| robcresswell | mrunge: No, actually. I never proposed it for backporting. | 11:06 |
| *** lhcheng has quit IRC | 11:06 | |
| robcresswell | mrunge: It was this commit https://github.com/openstack/horizon/commit/09706c6e3754c218b00dcaf210629aa6970dc80a | 11:06 |
| mrunge | robcresswell, I don't remember issues while packaging kilo version | 11:06 |
| ibmko | no, same problem after upgrading the package :( | 11:07 |
| robcresswell | It may be irrelevant, but was just a suggestion | 11:07 |
| ibmko | 772 static files copied to '/usr/share/openstack-dashboard/static'. | 11:07 |
| mrunge | yeah, that seems to be ok | 11:07 |
| robcresswell | Strange, I have 937 when pulling from stable/kilo. | 11:07 |
| mrunge | I would have to check how many files that were for kilo | 11:07 |
| mrunge | yeah | 11:08 |
| mrunge | that's right | 11:08 |
| ibmko | mrunge, robcresswell says it should be over 900 | 11:08 |
| mrunge | I would think of > 900 too | 11:08 |
| robcresswell | Liberty is now >1400 | 11:08 |
| robcresswell | Mitaka* | 11:09 |
| *** jerrygb has quit IRC | 11:09 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 11:09 |
| openstackgerrit | Shan Guo proposed openstack/horizon: VPN forms help text could be improved https://review.openstack.org/248546 | 11:09 |
| mrunge | ok, I have 818 static files in Kilo version to be copied | 11:10 |
| mrunge | 772 might be possible then | 11:10 |
| ibmko | mrunge, is the file dashboard/scss/horizon.scss among them ? | 11:11 |
| mrunge | yes, it is | 11:11 |
| robcresswell | ibmko: Something crude to try; copy openstack_dashboard/static/dashboard/scss/ to static/dashboard/scss/ | 11:13 |
| *** aix has joined #openstack-horizon | 11:14 | |
| mrunge | I believe I have seen something like this, when dependencies were messed up | 11:15 |
| *** JeanBriceCombebi has quit IRC | 11:15 | |
| ibmko | robcresswell, the static dir is symlink to openstack_dashboard/static so the source and destination is same dir | 11:16 |
| ibmko | in that command | 11:16 |
| ibmko | mrunge, looking at the reported issue in the Mirantis OpenStack, it seems it might something around dependencies | 11:17 |
| ibmko | https://bugs.launchpad.net/mos/+bug/1470143 | 11:17 |
| openstack | Launchpad bug 1470143 in Mirantis OpenStack "'dashboard/scss/horizon.scss' could not be found in the COMPRESS_ROOT '/usr/share/openstack-dashboard/static' after installation" [High,Fix released] - Assigned to MOS Packaging Team (mos-packaging) | 11:17 |
| *** kzaitsev_mb has joined #openstack-horizon | 11:18 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 11:18 | |
| robcresswell | Oh, I thought it was just the horizon dir that had a symlink. my mistake. | 11:19 |
| mrunge | https://bugs.launchpad.net/mos/+bug/1470143/comments/6 | 11:23 |
| openstack | Launchpad bug 1470143 in Mirantis OpenStack "'dashboard/scss/horizon.scss' could not be found in the COMPRESS_ROOT '/usr/share/openstack-dashboard/static' after installation" [High,Fix released] - Assigned to MOS Packaging Team (mos-packaging) | 11:23 |
| mrunge | hmm, the proposed fix suggests a packaging issue https://review.fuel-infra.org/#/c/9170/ | 11:24 |
| mrunge | but I can not comment on that | 11:24 |
| r1chardj0n3s | hullo | 11:25 |
| robcresswell | o/ | 11:26 |
| mrunge | r1chardj0n3s, o/ | 11:26 |
| r1chardj0n3s | so I'm still awake, which is odd :) | 11:26 |
| robcresswell | r1chardj0n3s, tsufiev: I'm looking forward to when you both get your first experience of "something I approved broke Horizon" :p | 11:26 |
| r1chardj0n3s | robcresswell: yes! | 11:26 |
| mrunge | btw robcresswell did you had that already? | 11:27 |
| r1chardj0n3s | actually, I was going to ask, are there any horizon core guidelines, or any secret handshakes I should know about? | 11:27 |
| robcresswell | mrunge: Yes :( I broke every single modal in something I merged :p | 11:27 |
| mrunge | oh, I didn't knew that | 11:27 |
| r1chardj0n3s | robcresswell: hey, I've written patches that were merged that broke stuff, so I reckon I already win the prize for that :) | 11:28 |
| r1chardj0n3s | those failures-after-merging errors we're seeing are kinda bizarre too | 11:28 |
| robcresswell | Yeah, I fixed it pretty promptly. It was one of the JS refactor patches and I just tested the new LI. Turned out it broke the modals too. | 11:28 |
| robcresswell | r1chardj0n3s: The test ones? | 11:28 |
| r1chardj0n3s | yeah | 11:28 |
| robcresswell | Mostly just missing assertions right | 11:28 |
| mrunge | r1chardj0n3s, the only "rule" we have is an informal one: do not push through code from your own company | 11:29 |
| r1chardj0n3s | well, except if I understand it correctly the tests are failing post-merge but the test run passes in jenkins | 11:29 |
| r1chardj0n3s | mrunge: yep, that's a common one, so I'm cool with that | 11:29 |
| mrunge | I actually believe, that is a really good one | 11:29 |
| robcresswell | r1chardj0n3s: I think the errors still show in the test logs, but unfortunately people rarely run the tests; they just assume passing = right. | 11:29 |
| ibmko | mrunge, is the 'dashboard/scss/horizon.scss' present on your system before running the collectstatic? I mean, the collectstatic command really generates stuff or it just collect (copies) existing stuff ? | 11:29 |
| mrunge | ibmko, it copies existing stuff | 11:30 |
| robcresswell | It just collects/copies existing files | 11:30 |
| r1chardj0n3s | robcresswell: hmm, so they're errors but not assertion errors | 11:30 |
| robcresswell | r1chardj0n3s: I believe so | 11:30 |
| ibmko | ok so the problem must be that the file is just not present on my system | 11:30 |
| r1chardj0n3s | robcresswell: why isn't the test runner flagging those as Error results then, I wonder | 11:30 |
| robcresswell | Now that I do not know | 11:31 |
| r1chardj0n3s | hmm | 11:31 |
| r1chardj0n3s | probably too many bare try/except | 11:31 |
| robcresswell | You can create it quite easily with the policy handling it networking | 11:31 |
| robcresswell | in* | 11:31 |
| *** flwang1 has joined #openstack-horizon | 11:31 | |
| ibmko | mrunge, when you just clean the collected files, where is the horizon.scss file located on your system ? | 11:34 |
| ibmko | I mean after cleaning the collected files, somewhere must be the original | 11:34 |
| ibmko | so the next collection doesnt fail | 11:34 |
| mrunge | ibmko, it's /usr/share/openstack-dashboard/openstack_dashboard/static/dashboard/scss/horizon.scss | 11:35 |
| mrunge | that's a Red Hat package, and it could be completely different from yours | 11:36 |
| robcresswell | Do the packages just symlink all the files? | 11:36 |
| robcresswell | Rather than collectstatic | 11:36 |
| mrunge | I can answer that only for rpm packages, were we collectstatic with copy | 11:37 |
| r1chardj0n3s | lol I do not know what the new buttons in gerrit do but I am willing to mash them until something happens :) | 11:37 |
| mrunge | robcresswell, there is a parameter to collectstatic to actually link files | 11:37 |
| tsufiev | robcresswell, speaking of 'stuff that broke all horizon' - that's why I'm so focused on more tests | 11:38 |
| mrunge | I could recommend gertty for reviews.... | 11:38 |
| tsufiev | to save myself from an inevitable failure :) | 11:38 |
| ibmko | it seems my collectstatic copies stuff from here, example of one file copied during collectstatic: Copying '/usr/lib/python2.7/dist-packages/horizon/static/angular/form/form.spec.js' | 11:38 |
| *** sambetts-afk is now known as sambetts | 11:38 | |
| r1chardj0n3s | so I now know that hitting the "workflow+1" button is the wrong thing to do :-) | 11:39 |
| mrunge | tsufiev, just do it right away, break it and you're through that pain ;-) | 11:39 |
| tsufiev | r1chardj0n3s, yesterday I barely avoided pressing +1 WF instead of just voting a first +2 | 11:39 |
| robcresswell | +2, or +2 and +1 workflow | 11:39 |
| robcresswell | There is nothing stopping you from approving right away, other than convention. | 11:40 |
| robcresswell | As in, no system to stop it. | 11:40 |
| r1chardj0n3s | tsufiev: I just hit the +1 button but didn't +2 first because I thought the special button would do the +2 also but no, so now I wonder why there's that special button at all | 11:40 |
| tsufiev | robcresswell, yes, the whole system runs on trust that people respect the conventions | 11:40 |
| r1chardj0n3s | yep, which is reasonable | 11:40 |
| mrunge | yepp | 11:40 |
| robcresswell | Which special button? the +1 workflow? | 11:40 |
| r1chardj0n3s | yeah | 11:41 |
| mrunge | you wouldn't be in this position, if people wouldn't trust you | 11:41 |
| robcresswell | Well thats what actually does stuff right? a +2 is just symbolic I thought | 11:41 |
| mrunge | robcresswell, imho you can not +a a patch without a single +2 | 11:41 |
| robcresswell | Perhaps we should test this theory :) | 11:42 |
| mrunge | ah yes | 11:42 |
| tsufiev | mrunge, regarding 'do not push the patch from your own company' - does it mean that I shouldn't +2 any patch from my company? | 11:42 |
| r1chardj0n3s | tsufiev: correct | 11:43 |
| robcresswell | tsufiev: Of the 2 core votes and the uploader, at least one *must* be from a different company | 11:43 |
| mrunge | exactly what robcresswell said | 11:43 |
| robcresswell | I think you can approve as long as another core has +2'd | 11:43 |
| r1chardj0n3s | but it's considered bad form in most projects | 11:43 |
| mrunge | that prevents a single company to push in code | 11:43 |
| tsufiev | ok | 11:44 |
| robcresswell | Yeah, ideally all 3 should be separate. | 11:44 |
| mrunge | ideally | 11:44 |
| robcresswell | Easy for me, I'm the only person in Cisco on Horizon :) | 11:44 |
| mrunge | well, as a core, there is no real reason to give +1 votes either | 11:45 |
| tsufiev | robcresswell, huh, did you +2 network topology stuff :)? | 11:45 |
| robcresswell | tsufiev: I approved it, yeah | 11:45 |
| robcresswell | Not ideal :) | 11:45 |
| tsufiev | it's the real world :) | 11:45 |
| robcresswell | Yeah, angular is often thai and cindy approving things | 11:46 |
| robcresswell | But, there are only 3 angular-focused cores, so its difficult | 11:46 |
| robcresswell | Updating bug report; any requests? | 11:47 |
| tsufiev | robcresswell, just https://review.openstack.org/#/c/215277/ | 11:47 |
| robcresswell | Also going to propose Bug Day for Tuesday 12th January; is an email now a bit too early? | 11:48 |
| r1chardj0n3s | well, I'd say https://launchpad.net/bugs/1503396 except I'm having trouble getting the damn patch to pass in the gate :-) | 11:48 |
| openstack | Launchpad bug 1503396 in OpenStack Dashboard (Horizon) "glance wizard form var passing broken" [Undecided,In progress] - Assigned to Richard Jones (r1chardj0n3s) | 11:48 |
| r1chardj0n3s | (also, I just noticed the "it breaks me in other ways" comment on the patch, so I still have work to do there) | 11:49 |
| *** kmartin has quit IRC | 11:49 | |
| r1chardj0n3s | robcresswell: um, actually, have a look at the last comment on https://review.openstack.org/#/c/251670/ | 11:49 |
| r1chardj0n3s | robcresswell: the paste, in particular | 11:50 |
| *** gokrokve has joined #openstack-horizon | 11:50 | |
| flwang1 | greetings, anybody can help take a quick look for this one https://review.openstack.org/#/c/255213/1 ? in my local test, i can run horizon server successfully but can't see the "queues" panel i added | 11:50 |
| flwang1 | mrunge: ^ | 11:50 |
| robcresswell | tsufiev: Added | 11:51 |
| robcresswell | r1chardj0n3s: Looking | 11:51 |
| tsufiev | robcresswell, thanks. I think in case of Jan 12 it's still too early | 11:52 |
| r1chardj0n3s | robcresswell: I'm not going to be able to look into that in the next ... probably 12 hours or so, or maybe even a little longer, but I am absolutely willing to do so | 11:52 |
| mrunge | flwang, yes | 11:52 |
| mrunge | flwang1, ack | 11:52 |
| flwang1 | mrunge: thank you very much | 11:52 |
| robcresswell | r1chardj0n3s: That looks unrelated to your patch... | 11:52 |
| robcresswell | r1chardj0n3s: In fact, its my dev dashboard | 11:53 |
| r1chardj0n3s | robcresswell: could be, but who knows, it's Javascript, right? | 11:53 |
| r1chardj0n3s | :-) | 11:53 |
| mrunge | flwang1, could you please add info on how to configure ceilo and zaqar to create such a queue? | 11:53 |
| robcresswell | Module 'horizon.dashboard.developer' is not available! | 11:53 |
| robcresswell | Just a static file issue | 11:53 |
| r1chardj0n3s | robcresswell: yeah, but we have no idea *why* that error is being raised | 11:53 |
| flwang1 | mrunge: yep, sure, i saw your comments, but i haven't add my comments, sorry about that | 11:54 |
| r1chardj0n3s | robcresswell: you reckon a nuke-static-compile is all's needed eh? | 11:54 |
| flwang1 | mrunge: btw, searchlights is going to forward notifications into zaqar queues, so maybe we don't need ceilometer finally | 11:54 |
| robcresswell | r1chardj0n3s: static files generated before dev patch, dev patch added, run server and fail, would be my thought | 11:54 |
| r1chardj0n3s | *fingers crossed* | 11:54 |
| robcresswell | r1chardj0n3s: Yup | 11:54 |
| r1chardj0n3s | (also, ugh) | 11:54 |
| mrunge | flwang1, unfortunately such things slow down reviews a lot. if folks don't have a clue on how to test, you can not expect honest reviews | 11:55 |
| flwang1 | mrunge: this is the spec of searchlights https://review.openstack.org/246220 | 11:55 |
| mrunge | flwang1, thanks for sharing, really useful! | 11:55 |
| r1chardj0n3s | I'll rebase, to make it easier | 11:55 |
| openstackgerrit | Richard Jones proposed openstack/horizon: Fix Create Image angularjs code https://review.openstack.org/251670 | 11:55 |
| flwang1 | mrunge: that's my fault, really busy recently | 11:55 |
| robcresswell | tsufiev: 12th of Jan, as in that is too early to have the bug day, or too early to send email? | 11:55 |
| flwang1 | i will address your comments asap | 11:55 |
| *** gokrokve has quit IRC | 11:55 | |
| mrunge | flwang1, no worries, that applies to all of us more or less | 11:55 |
| robcresswell | flwang1: Looking | 11:55 |
| robcresswell | Also, you need to fix some of your copyrights are wrong I think, flwang1 | 11:56 |
| robcresswell | Ugh, words | 11:56 |
| robcresswell | You get the idea ^^ :) | 11:56 |
| flwang1 | robcresswell: no problem | 11:57 |
| flwang1 | pls figure it out and i'm happy to fix it | 11:57 |
| robcresswell | Horizon meeting in a couple of minutes in #openstack-meeting-3 | 11:57 |
| robcresswell | flwang1: I'll leave comments inline. got meeting first :) | 11:58 |
| tsufiev | robcresswell, sorry, I meant too early to send an email right now | 11:58 |
| flwang1 | robcresswell: really appreciate | 11:58 |
| robcresswell | tsufiev: Understood. I agree. Draft saved | 11:58 |
| *** lhcheng_ is now known as lhcheng | 12:00 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add message of the day option https://review.openstack.org/253192 | 12:02 |
| *** yamamoto has quit IRC | 12:03 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add message of the day option https://review.openstack.org/253192 | 12:04 |
| *** yamamoto has joined #openstack-horizon | 12:06 | |
| *** mohankumar has joined #openstack-horizon | 12:06 | |
| *** JeanBriceCombebi has quit IRC | 12:10 | |
| *** yamamoto has quit IRC | 12:15 | |
| *** ygbo has quit IRC | 12:15 | |
| *** jtriley has joined #openstack-horizon | 12:18 | |
| *** jtriley has quit IRC | 12:23 | |
| ibmko | guys, I've just checked and the file horizon.scss comes with the ubuntu package - so it is not autogenerated. With this regard, should I actually be calling collectstatic -c in production system ? | 12:32 |
| ibmko | if I consider that the collectstatic -c deletes this file and others | 12:33 |
| ibmko | I only need to work with custom themes which should be "production" in Kilo | 12:33 |
| ibmko | I dont need to regenerate all files (unlike when actually developing Horizon) | 12:33 |
| mrunge | ibmko, somewhere I read that is not recommended on ubuntu/debian packages | 12:34 |
| ibmko | what is not recommended ? | 12:34 |
| mrunge | calling collectstatic | 12:34 |
| ibmko | ok but how do I get the custom theme up and running | 12:35 |
| mrunge | as that deletes files still required, at least in that configuration | 12:35 |
| mrunge | ibmko, no idea; that needs canonical to tell you | 12:35 |
| ibmko | here one guys says: | 12:36 |
| ibmko | Why exactly are you trying to call manage.py collecstatic? You should *not* do that. There's no issue in the package, and collectstatic should never be done, end of the story, IMO | 12:36 |
| ibmko | its from here: https://bugs.launchpad.net/mos/+bug/1470143 | 12:36 |
| openstack | Launchpad bug 1470143 in Mirantis OpenStack "'dashboard/scss/horizon.scss' could not be found in the COMPRESS_ROOT '/usr/share/openstack-dashboard/static' after installation" [High,Fix released] - Assigned to MOS Packaging Team (mos-packaging) | 12:36 |
| mrunge | ibmko, yes, I already linked that earlier | 12:37 |
| ibmko | so if I completely disregard Canonical, normally, in vanilla horizon, what is the recommended way to get the custom themes up and running? | 12:38 |
| ibmko | just configuring the "CUSTOM_THEME_PATH" variable and rebooting apache ? | 12:38 |
| mrunge | in best case: update custom_theme_path, run collectstatic and restart httpd | 12:38 |
| ibmko | and should it really be "collectstatic -c" or just "collectstatic"? Maybe the right way would be to just run collecstatic as it only replaces files on top of existing stuff which kind of sounds how custom templates might work anyway | 12:40 |
| *** alejandrito has joined #openstack-horizon | 12:40 | |
| ibmko | template -> theme | 12:40 |
| *** ducttape_ has joined #openstack-horizon | 12:40 | |
| *** Daisy has joined #openstack-horizon | 12:41 | |
| mrunge | ./manage.py collectstatic --clear --noinput | 12:41 |
| *** doug-fis_ is now known as doug-fish | 12:42 | |
| *** chlong has joined #openstack-horizon | 12:42 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:46 | |
| *** jerrygb has joined #openstack-horizon | 12:53 | |
| *** amotoki_ has joined #openstack-horizon | 12:56 | |
| *** ducttape_ has quit IRC | 12:58 | |
| *** amotoki__ has joined #openstack-horizon | 12:59 | |
| *** amotoki has quit IRC | 12:59 | |
| *** amotoki__ is now known as amotoki___ | 12:59 | |
| *** julim has joined #openstack-horizon | 13:01 | |
| *** amotoki___ is now known as amotoki__ | 13:02 | |
| r1chardj0n3s | g'night all | 13:02 |
| *** amotoki_ has quit IRC | 13:02 | |
| *** amotoki__ is now known as amotoki | 13:02 | |
| tsufiev | r1chardj0n3s, night! | 13:02 |
| mrunge | good night r1chardj0n3s | 13:02 |
| robcresswell | mrunge: collectstatic -c == collectstatic --clear | 13:02 |
| robcresswell | I think its still undocumented in django lol. | 13:03 |
| mrunge | robcresswell, I guessed that, but was not sure and too lazy to look that up | 13:03 |
| mrunge | robcresswell, yes, that's right. it's not documented | 13:03 |
| robcresswell | ibmko: That comment was from zigo, who was here earlier :) | 13:03 |
| robcresswell | The one about not using collectstatic | 13:03 |
| tsufiev | robcresswell, I thought he already gave up on this idea | 13:04 |
| mrunge | tsufiev, that comment was from mid this year | 13:05 |
| robcresswell | I'm unsure what the current status is on that | 13:05 |
| *** Daisy has quit IRC | 13:05 | |
| *** Liuqing has joined #openstack-horizon | 13:05 | |
| tsufiev | mrunge, ah, ok | 13:05 |
| *** doug-fish has quit IRC | 13:06 | |
| *** pauloewerton has joined #openstack-horizon | 13:07 | |
| robcresswell | flwang1: Got it working | 13:12 |
| robcresswell | flwang1: Want me to push a new patch, or justl eave comments? | 13:14 |
| robcresswell | just leave* | 13:14 |
| *** jtriley has joined #openstack-horizon | 13:22 | |
| *** mwhagedorn has quit IRC | 13:23 | |
| *** doug-fish has joined #openstack-horizon | 13:23 | |
| *** jtriley has quit IRC | 13:27 | |
| *** SurajD has quit IRC | 13:31 | |
| *** SurajD has joined #openstack-horizon | 13:33 | |
| robcresswell | flwang1: Pushing a new patchset to fix issues. Hope it doesnt interfere with your workflow. | 13:36 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Move d-o-a auth library to keystoneauth https://review.openstack.org/205251 | 13:37 |
| *** JeanBriceCombebi has quit IRC | 13:39 | |
| doug-fish | In the plugin i18n area, I've looked at 2 areas of concern so far: 1) i18n plugins can't contribute new messages: https://bugs.launchpad.net/horizon/+bug/1523930 | 13:39 |
| openstack | Launchpad bug 1523930 in OpenStack Dashboard (Horizon) "Javascript message catalogs need to be retreived from plugins" [Undecided,New] - Assigned to Doug Fish (drfish) | 13:39 |
| doug-fish | and 2) there is a lot of copying of Horizon tools like ./run_tests.sh and the /tools directory to extract and compile messages | 13:39 |
| robcresswell | doug-fish: Yeah. I recently scrapped run_tests from cisco-ui | 13:40 |
| doug-fish | On 2, I'm thinking of having Horizon provide some of those scripts in an externally accessible fashion, so plugins can just call something like run_test.sh --makemessages from a Horizon based tool | 13:40 |
| doug-fish | robcresswell: how did you replace it? | 13:41 |
| *** petertr7_away is now known as petertr7 | 13:41 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Revert - Cache the User's Project by Token ID https://review.openstack.org/235609 | 13:41 |
| robcresswell | doug-fish: tox for testing. The others jsut using the actual commands | 13:41 |
| robcresswell | Tbh once the translation infrastructure takes over we dont those commands, do we? | 13:41 |
| doug-fish | actual commands not coded anywhere? | 13:41 |
| robcresswell | No, just using the programs themselves, like pybabel etc | 13:42 |
| robcresswell | dont need those commands* | 13:42 |
| doug-fish | we normally don't distribute .mo files in the packages | 13:42 |
| doug-fish | so I'd think a compile step would need to be externalizable | 13:42 |
| doug-fish | or part of a package setup maybe | 13:42 |
| robcresswell | run_tests is just a layer over the top right? | 13:42 |
| doug-fish | right | 13:43 |
| robcresswell | so it would just be pybabel compile etc. | 13:43 |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:43 | |
| *** masco has quit IRC | 13:43 | |
| doug-fish | hmm, so you're thinking that the run_tests doesn't provide enough value to bother with | 13:43 |
| * doug-fish thinking | 13:43 | |
| robcresswell | Actually, I wonder how it works with plugins | 13:44 |
| doug-fish | it? | 13:44 |
| robcresswell | So, if we install a plugin, does run_tests build the .mo fiels from the plugins too | 13:44 |
| robcresswell | files* | 13:44 |
| doug-fish | no | 13:44 |
| *** yamamoto has joined #openstack-horizon | 13:44 | |
| robcresswell | Ah okay | 13:44 |
| doug-fish | right now I'm experiementing with a edited copy of run_tests.sh for neutron-lbaas-dashboard | 13:45 |
| robcresswell | So each plugin will have to compile its own .mo files | 13:45 |
| doug-fish | it doesn't look very good | 13:45 |
| doug-fish | yeah | 13:45 |
| robcresswell | No, its a duplication of 600 lines. Personally I don't even see the value of it in Horizon itself, as its just a layer of obfuscated wrapper stuff. | 13:45 |
| doug-fish | the message capture command is a bit longish if I recall | 13:46 |
| doug-fish | nice to have it encoded to make sure it always gets called the same way | 13:46 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/django_openstack_auth: Move d-o-a auth library to keystoneauth https://review.openstack.org/205251 | 13:46 |
| robcresswell | The extraction part is, but that should just be infra | 13:46 |
| robcresswell | The compile part is literally a wrapper iirc | 13:47 |
| doug-fish | Not sure we should assume/require infra | 13:47 |
| robcresswell | I'm pretty sure --compilemessages just does manage.py compilemessages | 13:47 |
| doug-fish | yep | 13:47 |
| doug-fish | https://github.com/openstack/horizon/blob/master/run_tests.sh#L470 | 13:47 |
| robcresswell | Hmm, I was thinking of openstack/ plugins | 13:47 |
| ibmko | robcresswell, ah, ok :) | 13:47 |
| robcresswell | doug-fish: This is the long-ish bit https://github.com/openstack/horizon/blob/master/run_tests.sh#L432 | 13:48 |
| doug-fish | yeah | 13:48 |
| doug-fish | My thought was to break the translation related tools out of ./run_tests and have a more horizon-translation focused tool that would get installed as part of the Horizon setup | 13:49 |
| doug-fish | with the idea plugins could use Horizon's scripts to capture/pseudo translate/compile messages | 13:49 |
| doug-fish | maybe tools aren't always required for that though - compilemessages is a pretty thin wrapper! | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects API https://review.openstack.org/208581 | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Members https://review.openstack.org/245340 | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Panel https://review.openstack.org/199139 | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Quota https://review.openstack.org/252412 | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding Identity NGProjects Create Action - Details https://review.openstack.org/215352 | 13:50 |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding hz-if-neutron-extensions directive https://review.openstack.org/252597 | 13:51 |
| robcresswell | doug-fish: I'd just document the block and leave it at that | 13:52 |
| *** yamamoto has quit IRC | 13:53 | |
| doug-fish | robcresswell: I'll think on that a while -- my immediate thought is that I'd be unhappy trying to maintain Horizon without having that scripted | 13:53 |
| doug-fish | and tools > documentation for saying how a thing should be done | 13:54 |
| *** ducttape_ has joined #openstack-horizon | 13:54 | |
| robcresswell | Sure. We could break up run_tests into the tools folder so at least people only take parts of it | 13:54 |
| robcresswell | then its not much different to the install_venv files which are all over openstack. | 13:55 |
| doug-fish | true - though I'd really hope to not need that either | 13:55 |
| doug-fish | I'll try to put together a patch - I think that will help me sort out if I think it's worth capturing these processes in code or not | 13:57 |
| robcresswell | Woop, just retested that zaqar-ui patch and I've at least put it back on the right tracks in terms of it working :p | 13:58 |
| robcresswell | doug-fish: Sure thing. An alternative may be to make it available in python so it can be imported easily | 13:59 |
| doug-fish | yeah, I did think about that too | 13:59 |
| robcresswell | doug-fish: Thanks for looking into this btw, really appreciate it! | 13:59 |
| doug-fish | no worries - thanks for chatting through some of the issues with me | 14:00 |
| *** jtriley has joined #openstack-horizon | 14:00 | |
| *** logan- has joined #openstack-horizon | 14:01 | |
| jgrassler | Good afternoon. | 14:01 |
| jgrassler | Could somebody have another look at https://review.openstack.org/#/c/238419/ ? | 14:01 |
| jgrassler | It has been broken for quite some time now, and we'd like to get our fix upstream at some stage | 14:02 |
| robcresswell | Looks clean. Best people to ping for d_o_a are usually david-lyle, lhcheng | 14:03 |
| robcresswell | US timezones, but lhcheng may still be UTC +1. | 14:04 |
| mrunge | I thought this is a duplicate? | 14:04 |
| jgrassler | Duplicate? | 14:04 |
| mrunge | jgrassler, were you using pki token? | 14:04 |
| jgrassler | mrunge: No, regular UUID tokens | 14:04 |
| jgrassler | I dimly remember a different bug with the same failure mode, though | 14:05 |
| mrunge | interesting | 14:05 |
| jgrassler | That might be a source of confusion :-) | 14:05 |
| mrunge | yes, exactly; this is why I was thinking of a duplicate | 14:05 |
| jgrassler | The issue at hand is not related to token type - the problem is a bad endpoint URL | 14:06 |
| *** SurajD has quit IRC | 14:06 | |
| mrunge | In my understanding, endpoints work with both urls | 14:06 |
| mrunge | even using v2.0 and forcing horizon to use keystone v3 worked | 14:07 |
| *** SurajD has joined #openstack-horizon | 14:08 | |
| *** ducttape_ has quit IRC | 14:08 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add support for identity provider protocol CRUD https://review.openstack.org/248865 | 14:08 |
| *** jerrygb_ has joined #openstack-horizon | 14:08 | |
| jgrassler | No such luck - the URL without version information 404s, at least in our cloud | 14:09 |
| jgrassler | Anyway, it looks like time zones are aligned right now :-) | 14:10 |
| mrunge | I have been told by keystone guys, it's mostly version agnostic, and keystone should just work | 14:10 |
| mrunge | huh? | 14:11 |
| jgrassler | (according to openstackgerrit lhcheng appears to be online) | 14:11 |
| *** tosky_ is now known as tosky | 14:11 | |
| openstackgerrit | Paul Karikh proposed openstack/django_openstack_auth: Add domain initial value on login https://review.openstack.org/254838 | 14:11 |
| *** jerrygb has quit IRC | 14:11 | |
| *** pece has quit IRC | 14:11 | |
| *** jpomeroy has joined #openstack-horizon | 14:12 | |
| mrunge | jgrassler, yes, he's currently in EU | 14:12 |
| jgrassler | mrunge: Maybe they meant "you can talk 2.0 to /3.0 just fine" by "version agnostic". /tokens can be relied on to 404 in our Openstack setup. | 14:12 |
| lhcheng | oops, didn't notice the message | 14:13 |
| * lhcheng reading back | 14:13 | |
| *** peristeri has joined #openstack-horizon | 14:13 | |
| jgrassler | lhcheng: tl;dr wondering if my latest patch set on https://review.openstack.org/#/c/238419/ passes muster now :-) | 14:14 |
| pkarikh | lhcheng: hi! Since you're here - I refactored DOA patch for pre-filling domain field. Now it is being filled from cookies, as you suggested. https://review.openstack.org/#/c/254838/ | 14:14 |
| *** breitz has quit IRC | 14:19 | |
| lhcheng | jgrassler: how come the identity endpoint in your service catalog doesn't have the version? | 14:19 |
| *** breitz has joined #openstack-horizon | 14:19 | |
| lhcheng | thought version-less auth is not yet there.. | 14:19 |
| *** lblanchard has joined #openstack-horizon | 14:20 | |
| *** matt-borland has joined #openstack-horizon | 14:21 | |
| jgrassler | lhcheng: That's a good question. It may well be due to misconfiguration. It's beenn a while since we configured that... | 14:21 |
| lhcheng | pkarikh: the bug associated with the patch does not match the change in the patch anymore :) | 14:21 |
| pkarikh | lhcheng: yep, changed commit msg and forgot to change bug. Going to fix it, thanks. :) | 14:21 |
| *** gokrokve has joined #openstack-horizon | 14:22 | |
| jgrassler | lhcheng: Alright, the guy wo configured it does not know where he heard it, but says version-less out is here as of Kilo. | 14:23 |
| jgrassler | s/out/auth/ | 14:23 |
| jgrassler | Maybe it just works for everything else because everything else appends its version of choice to the base URL (nothing else appears to run into these 404s, at any rate). | 14:24 |
| *** Piet has joined #openstack-horizon | 14:25 | |
| lhcheng | jgrassler: hmm I don't see it in the keystone release notes: https://wiki.openstack.org/wiki/ReleaseNotes/Kilo#OpenStack_Identity_.28Keystone.29 | 14:25 |
| *** Piet has quit IRC | 14:28 | |
| lhcheng | jgrassler: yeah, not even sure if command on keystone client would work if the identity endpoints does not have the version. | 14:28 |
| jgrassler | lhcheng: Not in the release notes, but there are people claiming it works as of Kilo (https://ask.openstack.org/en/question/67292/what-are-implication-of-using-both-v20-and-v3-endpoint-of-keystone/) | 14:30 |
| jgrassler | And at least the openstack command line client works just fine | 14:31 |
| *** mtanino has joined #openstack-horizon | 14:31 | |
| *** nullvariable has joined #openstack-horizon | 14:31 | |
| *** mflobo has joined #openstack-horizon | 14:33 | |
| *** yamamoto has joined #openstack-horizon | 14:34 | |
| mflobo | I have a question about css for a new Panel in Horizon, is anyone up to try to help me? :) | 14:34 |
| mrunge | I'd still not really convinced here | 14:34 |
| mrunge | jgrassler, I'm all in for making it more clear | 14:35 |
| mrunge | and I agree using keystone v3 but defining v2.0 as endpoint looks just ugly | 14:35 |
| mrunge | if we can make that more clear: yes | 14:36 |
| jgrassler | mrunge: Yep. And it's not as if there's no configuration option explicitely specifying the version, after all :-) | 14:36 |
| mrunge | still I'm not convinced that is a real issue; maybe I'm using it wrong? | 14:36 |
| mrunge | jgrassler, even if I'm specifying the version, it just works(tm) | 14:37 |
| tsufiev | mflobo, what's the problem with it? | 14:37 |
| lhcheng | jgrassler: the suggestion sounds specific to only work with openstackclient | 14:37 |
| lhcheng | jgrassler: if it doesn't work even with keystoneclient, that doesn't sound right | 14:37 |
| *** vijendar has joined #openstack-horizon | 14:38 | |
| mflobo | tsufiev, thanks, I'm creating a new panel for Compute section, let's call it "panel_a". I would like to know where shoould I put my CSS files for this new panel | 14:39 |
| *** jtriley has quit IRC | 14:40 | |
| tsufiev | mflobo, please take a look at https://review.openstack.org/#/c/233709/12/doc/source/tutorials/plugin.rst line 353 | 14:41 |
| tsufiev | the whole doc may also be quite useful to you | 14:42 |
| *** jtriley has joined #openstack-horizon | 14:44 | |
| mflobo | tsufiev, ahh, I see, so I can put where ever and just put the reference in my "enable" file, right? | 14:44 |
| *** neelashah has joined #openstack-horizon | 14:45 | |
| lhcheng | jgrassler: the version-less endpoint is not in tempest, so I am not if that is supported.. for that to work, it assumes there is a discovery code in the client. | 14:46 |
| lhcheng | jgrassler: you can't guarantee that all clients will have that logic, you might end up with more headache :/ | 14:47 |
| mflobo | tsufiev, so I guess this tutorial http://docs.openstack.org/developer/horizon/topics/tutorial.html is now obsolete | 14:48 |
| tsufiev | mflobo, yes, it's obsolete to some degree, but the doc I pointed you to is still WIP | 14:48 |
| jgrassler | lhcheng: Well, most clients appear to have that logic...our only trouble is with django-openstack_auth at this point :-/ | 14:49 |
| mflobo | tsufiev, so... is not production? | 14:49 |
| *** gokrokve has quit IRC | 14:49 | |
| tsufiev | mflobo, the feature being documented is in production, but documentation is not yet :) | 14:51 |
| lhcheng | jgrassler: after updating django_openstack_auth, would the keystone operation in horizon just works? | 14:52 |
| jgrassler | lhcheng: What do you mean by updating? Updating to a version with my patch applied? | 14:53 |
| lhcheng | jgrassler: yes, I meant after applying your patch | 14:54 |
| jgrassler | lhcheng: Then yes (and without it the Projects dropdown remains empty (everything else works)) | 14:54 |
| *** ducttape_ has joined #openstack-horizon | 14:54 | |
| tsufiev | itxaka, didn't notice any performance boost from template refactoring :/ | 14:54 |
| itxaka | :( | 14:54 |
| itxaka | on the volumes tab? | 14:54 |
| itxaka | havent tried there | 14:54 |
| tsufiev | yes | 14:54 |
| itxaka | I think that the more actions available, the more speed ups | 14:54 |
| itxaka | Only tried on users myself | 14:54 |
| tsufiev | yes, it makes sense | 14:55 |
| itxaka | Im guessing that a good test would be to have 500 instances and page limit set to 500 as they have a lot of actions in there | 14:56 |
| tsufiev | itxaka, will try it with fake instances, once I have enough of them | 14:56 |
| itxaka | still that sucks, I expected it to gain some speed everywhere :( | 14:57 |
| itxaka | did you had the dajngo-debug-toolbar-template-timings installed? | 14:57 |
| tsufiev | nope | 14:57 |
| itxaka | that shows how many times a template has been called, so its a good indicator IMO | 14:57 |
| tsufiev | I prefer to use simple tools, like stop-watch and my own eyes ) | 14:57 |
| itxaka | the more calls, the more saving :) | 14:57 |
| itxaka | I wonder if selenium could be leveraged to have some timings | 15:00 |
| itxaka | just simple tests of opening page X after inserting X entries and saving the times to a log would be good enough to see any improvements between patches | 15:01 |
| tsufiev | yes, could try that | 15:01 |
| *** jtriley_ has joined #openstack-horizon | 15:01 | |
| tsufiev | although Selenium and particularly the way some page objects in horizon are currently written sometimes introduces a significant overhead | 15:02 |
| *** mounica has joined #openstack-horizon | 15:02 | |
| *** petertr7 is now known as petertr7_away | 15:02 | |
| *** matt-borland has quit IRC | 15:03 | |
| tsufiev | itxaka, it's in priorities list, see https://etherpad.openstack.org/p/mitaka-horizon-priorities line 107 | 15:04 |
| *** jtriley has quit IRC | 15:05 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Add ID to security groups on launch instance https://review.openstack.org/254123 | 15:05 |
| *** petertr7_away is now known as petertr7 | 15:06 | |
| itxaka | We just need to make sure that we ALWAYS introduce the same overhead, as to have a baseline overhead | 15:06 |
| itxaka | not sure if joking :D | 15:06 |
| robcresswell | itxaka: I meant to ask, did it take anything special to get the debug-toolbar working in horizon? | 15:07 |
| *** pumaranikar has joined #openstack-horizon | 15:07 | |
| *** pumaranikar has quit IRC | 15:07 | |
| *** pumaranikar has joined #openstack-horizon | 15:08 | |
| *** pushkaru has joined #openstack-horizon | 15:08 | |
| mflobo | tsufiev, thank you | 15:08 |
| *** pushkaru has quit IRC | 15:08 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Add truncated flag support https://review.openstack.org/250869 | 15:08 |
| *** pumaranikar has quit IRC | 15:09 | |
| *** pumaranikar has joined #openstack-horizon | 15:09 | |
| robcresswell | Hey tsufiev now I can pester you for reviews right? :D | 15:09 |
| itxaka | robcresswell, not really, just import INSTALLED_APPS from openstack_dashboard.settings and if you can import debug_toolbar then add it to the INSTALLED_APPS | 15:09 |
| robcresswell | Cool. I looked into it briefly and it seemed like the redirects didnt work when clicking on a panel | 15:10 |
| itxaka | ah, didnt check that panle, I usually deactivate everything that I can | 15:10 |
| robcresswell | Ah okay | 15:10 |
| itxaka | s/panle/panel/g | 15:10 |
| tsufiev | robcresswell, sure | 15:11 |
| *** jtriley_ has quit IRC | 15:12 | |
| lhcheng | jgrassler: added some comments on the patch. I have to dig around further on the version-less endpoint, I'm still not convince about using it. | 15:13 |
| *** jtriley has joined #openstack-horizon | 15:13 | |
| robcresswell | tsufiev: Nothing yet, but there will be :p | 15:13 |
| jgrassler | lhcheng: Alright, thanks :-) | 15:13 |
| lhcheng | jgrassler: would be interesting to see if devstack would work: https://review.openstack.org/#/c/255294/ | 15:13 |
| jgrassler | lhcheng: In the meantime I'll work on the things you commented on, just in case :-) | 15:14 |
| tsufiev | robcresswell, haha, I always have some reviews to pester you :) | 15:14 |
| lhcheng | jgrassler: sounds good | 15:15 |
| * tsufiev could not imagine the situation when his patches queue becomes empty | 15:16 | |
| *** mohankumar has quit IRC | 15:17 | |
| openstackgerrit | Lin Hua Cheng proposed openstack/horizon: Add message of the day option https://review.openstack.org/253192 | 15:18 |
| robcresswell | tsufiev: Mine has suddenly emptied. I had 10/15 last week. Now 2. | 15:18 |
| tsufiev | wow | 15:21 |
| tsufiev | robcresswell, then would you mind looking at https://review.openstack.org/#/c/215277/ ;)? | 15:22 |
| *** noqa_v_qoovnie has quit IRC | 15:22 | |
| *** jtriley has quit IRC | 15:24 | |
| *** Daisy has joined #openstack-horizon | 15:25 | |
| robcresswell | tsufiev: Shall do | 15:26 |
| tsufiev | robcresswell, thanks! | 15:26 |
| *** Daisy has quit IRC | 15:29 | |
| *** gokrokve has joined #openstack-horizon | 15:30 | |
| *** TravT has joined #openstack-horizon | 15:30 | |
| *** Ephur has joined #openstack-horizon | 15:30 | |
| *** TravT has quit IRC | 15:31 | |
| *** TravT has joined #openstack-horizon | 15:31 | |
| *** gokrokve has quit IRC | 15:35 | |
| *** jprovazn has joined #openstack-horizon | 15:35 | |
| *** jtriley has joined #openstack-horizon | 15:38 | |
| *** hurgleburgler has joined #openstack-horizon | 15:39 | |
| *** mounica has quit IRC | 15:39 | |
| *** belmoreira has quit IRC | 15:39 | |
| openstackgerrit | ayoung proposed openstack/horizon: Federated Identity Mapping https://review.openstack.org/232114 | 15:43 |
| robcresswell | Question: Do tabs/tabletabs respond properly to policy? | 15:43 |
| robcresswell | tsufiev: Will be on that patch in a moment, juat had one last test to fix on mine :/ | 15:44 |
| *** gokrokve has joined #openstack-horizon | 15:45 | |
| *** Liuqing has quit IRC | 15:47 | |
| tsufiev | robcresswell, ok. Any reasons to think that Tabs disobey the policy? def allowed() IMO should check the policy | 15:49 |
| robcresswell | I'm altering the Net Details to be tabbed, had this patch on the go for ages | 15:49 |
| *** hurgleburgler has quit IRC | 15:50 | |
| *** TravT has quit IRC | 15:50 | |
| robcresswell | For some reason, the Create Subnet action doesnt make its policy called | 15:50 |
| robcresswell | call* | 15:50 |
| robcresswell | and I've no idea why | 15:50 |
| *** TravT has joined #openstack-horizon | 15:50 | |
| tsufiev | I think (Table)Tabs should behave the same way as a higher-level components, like https://github.com/openstack/horizon/blob/master/horizon/base.py#L131 | 15:51 |
| tsufiev | it they do not, it's a bug | 15:51 |
| tsufiev | (or a feature request) | 15:52 |
| tsufiev | I remember doing the same things for workflows here https://review.openstack.org/#/c/144152/12/horizon/test/tests/workflows.py | 15:52 |
| tsufiev | might be a bit easier for tabs | 15:52 |
| *** TravT has quit IRC | 15:55 | |
| *** TravT has joined #openstack-horizon | 15:55 | |
| *** TravT has quit IRC | 15:55 | |
| *** TravT has joined #openstack-horizon | 15:56 | |
| robcresswell | Getting to the point where I've spent so long with this tests file that I know the line numbers of individual tests :s | 15:56 |
| robcresswell | V frustrating. | 15:56 |
| *** gokrokve has quit IRC | 15:58 | |
| *** mflobo has left #openstack-horizon | 15:59 | |
| *** erlon has joined #openstack-horizon | 15:59 | |
| *** gokrokve has joined #openstack-horizon | 15:59 | |
| *** tjones has joined #openstack-horizon | 15:59 | |
| *** zz_john5223 is now known as john5223 | 16:03 | |
| *** pumaranikar has quit IRC | 16:04 | |
| *** pumaranikar has joined #openstack-horizon | 16:05 | |
| *** kmartin has joined #openstack-horizon | 16:07 | |
| *** vishwanathj has quit IRC | 16:08 | |
| *** vishwanathj has joined #openstack-horizon | 16:08 | |
| openstackgerrit | Paul Karikh proposed openstack/django_openstack_auth: Add domain initial value on login https://review.openstack.org/254838 | 16:12 |
| *** TravT is now known as TravT_away | 16:12 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Ability to turn off client search for full text search https://review.openstack.org/228665 | 16:15 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add test for the Heat Service validate method https://review.openstack.org/237272 | 16:16 |
| *** hurgleburgler has joined #openstack-horizon | 16:18 | |
| *** jerrygb_ has quit IRC | 16:18 | |
| *** vgridnev has quit IRC | 16:23 | |
| *** hurgleburgler has quit IRC | 16:24 | |
| *** Drago has joined #openstack-horizon | 16:27 | |
| *** lapalm has joined #openstack-horizon | 16:32 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Prepare for 'AVAILABLE_REGIONS' renaming https://review.openstack.org/224759 | 16:32 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222132 | 16:32 |
| *** bpokorny has joined #openstack-horizon | 16:37 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Use JQuery promise/deferred objects to track AJAX https://review.openstack.org/172067 | 16:38 |
| *** ctina_ has joined #openstack-horizon | 16:43 | |
| *** apuimedo is now known as away | 16:44 | |
| *** away is now known as Guest32752 | 16:45 | |
| *** jprovazn has quit IRC | 16:46 | |
| *** peristeri has quit IRC | 16:47 | |
| *** jprovazn has joined #openstack-horizon | 16:48 | |
| *** gokrokve has quit IRC | 16:51 | |
| *** mohankumar has joined #openstack-horizon | 16:54 | |
| *** jtriley has quit IRC | 16:55 | |
| openstackgerrit | Timur Sufiev proposed openstack/django_openstack_auth: Prepare for 'AVAILABLE_REGIONS' renaming https://review.openstack.org/224756 | 16:56 |
| *** gyee has joined #openstack-horizon | 16:56 | |
| *** petertr7 is now known as petertr7_away | 16:59 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Prepare for 'AVAILABLE_REGIONS' renaming https://review.openstack.org/224759 | 17:00 |
| *** petertr7_away is now known as petertr7 | 17:00 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Prepare for 'AVAILABLE_REGIONS' renaming https://review.openstack.org/224759 | 17:00 |
| openstackgerrit | Timur Sufiev proposed openstack/django_openstack_auth: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222129 | 17:02 |
| *** lhcheng has quit IRC | 17:04 | |
| *** jprovazn has quit IRC | 17:06 | |
| *** jprovazn has joined #openstack-horizon | 17:06 | |
| *** JeanBriceCombebi has quit IRC | 17:06 | |
| *** steveng has joined #openstack-horizon | 17:09 | |
| steveng | Hey people.. I have a query.. I was trying to change the horizon code where project members are managed.. | 17:10 |
| *** rcernin has quit IRC | 17:11 | |
| tsufiev | steveng, what's the problem? | 17:11 |
| steveng | Since my LDAP has more that 10000 users, I don't want horizon to load users. I want a textbox in place where users list gets populated. I did everything till here. | 17:12 |
| tsufiev | steveng, please, take a look at https://review.openstack.org/#/c/252488/ | 17:12 |
| steveng | # Get list of available users | 17:12 |
| steveng | all_users = [] | 17:12 |
| steveng | # try: | 17:12 |
| steveng | # all_users = api.keystone.user_list(request, | 17:12 |
| steveng | # domain=domain_id) | 17:12 |
| steveng | # except Exception: | 17:12 |
| steveng | # exceptions.handle(request, err_msg) | 17:12 |
| steveng | users_list = [(user.id, user.name) for user in all_users] | 17:12 |
| steveng | users_list.append(('foo', 'foo')) | 17:12 |
| steveng | # Get list of roles | 17:13 |
| steveng | Is this patch completed? | 17:13 |
| tsufiev | steveng, we could use your expertise in reviewing that patch :) | 17:13 |
| tsufiev | I guess it's still WIP, since some tests are failing | 17:13 |
| tsufiev | pkarikh is working on it | 17:14 |
| steveng | I am happy to help.. Okay.. I will add this patch to my setup.. | 17:14 |
| *** vgridnev has joined #openstack-horizon | 17:15 | |
| openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Allow add/delete networks ports as a tenant https://review.openstack.org/253112 | 17:15 |
| steveng | tsufiev: I am new to git.. could you tell me how can I copy this patch in one step instead of coping each and every file? | 17:16 |
| robcresswell | steveng: It's on the patch page | 17:17 |
| robcresswell | Next to the Patch Set 5 bit there is a "Download" descriptor | 17:18 |
| *** ianbrown has quit IRC | 17:20 | |
| steveng | robcresswell: tsufiev: I wanna know one thing.. Is horizon only able to add members to projects who are in the users_list[] array ? | 17:21 |
| tsufiev | steveng, hmm, that code with users_list seems outdated to me | 17:22 |
| david-lyle | or in your git repo for horizon "git review -d <change-id> | 17:22 |
| david-lyle | " | 17:22 |
| david-lyle | would likely have to rebase that branch to whatever your master is | 17:23 |
| *** ianbrown has joined #openstack-horizon | 17:23 | |
| *** tosky has quit IRC | 17:23 | |
| *** tosky has joined #openstack-horizon | 17:23 | |
| tsufiev | steveng, I believe that https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/keystone.py#L569 is a more modern way to cycle through users' roles | 17:23 |
| *** mounica has joined #openstack-horizon | 17:23 | |
| steveng | I dont have git repo.. I installed the horizon using kilo guide earlier and following the same pattern since then. I have the horizon files in /usr/share/openstack-dashboard/ directory where I make changes to the code and see the results on the browser. | 17:24 |
| david-lyle | ah, robcresswell 's method will work then | 17:24 |
| david-lyle | probably why he suggested it | 17:24 |
| david-lyle | robcresswell: follows the whole conversation, show oof | 17:25 |
| david-lyle | *off | 17:25 |
| robcresswell | My bad | 17:25 |
| david-lyle | :D | 17:25 |
| tsufiev | steveng, ah, I got it, in kilo (which you're speaking of) code is different indeed | 17:26 |
| robcresswell | Question: anyone written unit tests for content loaded in table tabs before? | 17:26 |
| tsufiev | robcresswell, I wrote some tests for lazily loaded tabs | 17:26 |
| robcresswell | Ah, thats what I'm looking for | 17:26 |
| tsufiev | it was my first experience and it was very awkward | 17:26 |
| tsufiev | I guess I used Selenium for thta | 17:27 |
| robcresswell | Ah | 17:27 |
| tsufiev | never again :) | 17:27 |
| tsufiev | I mean, no Selenium for this kind of tests | 17:27 |
| steveng | tsufiev: can I use liberty keystone with all other services in kilo? | 17:27 |
| robcresswell | Since I moved the Subnets/ Ports tables to lazy loaded tabs, I'm unsure how to fix the table_action tests | 17:27 |
| *** jpomeroy has quit IRC | 17:28 | |
| tsufiev | steveng, I think it should work, since the lag is just 1 version | 17:28 |
| ducttape_ | robcresswell - I can help explain the concept of what you will need | 17:28 |
| tsufiev | robcresswell, perhaps make them not lazy? | 17:28 |
| tsufiev | :) | 17:28 |
| robcresswell | tsufiev: Networks tend to have a lot of associated objects, so I think lazy may be useful in this instance. | 17:29 |
| ducttape_ | essentially, the test before loaded data for all 4 (is it 4?) tabs, getting all the data for all the tests. you will likely need to remove a bunch of mock setup stuff in the tests, and break that into many separate tests | 17:29 |
| robcresswell | Otherwise you load all subnets, ports and dhcp agents at once. | 17:29 |
| robcresswell | Ah, okay | 17:29 |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222132 | 17:30 |
| ducttape_ | so now you would need a test for tabA, a test for tabB .... etc | 17:30 |
| ducttape_ | before you could do a lot of that in one test | 17:30 |
| *** gokrokve has joined #openstack-horizon | 17:30 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222132 | 17:30 |
| ducttape_ | I *think* that is what you are dealing with | 17:30 |
| *** jbell8 has joined #openstack-horizon | 17:31 | |
| *** jpomeroy has joined #openstack-horizon | 17:32 | |
| robcresswell | The issue i have now is that the rendered template is empty because the data is lazy-loaded | 17:32 |
| robcresswell | So I can check tha tthe tab exists, but it has no content | 17:32 |
| *** jtriley has joined #openstack-horizon | 17:32 | |
| robcresswell | and thus no actions for me to verify | 17:32 |
| ducttape_ | right, you will need to format a new request to load the other tab | 17:33 |
| david-lyle | robcresswell: you will have to load the appropriate tab | 17:33 |
| ducttape_ | that request will be a bit different | 17:33 |
| tsufiev | steveng, nobody likes reading the docs, yet I suggest to start here: https://wiki.openstack.org/wiki/How_To_Contribute#Reviewing | 17:36 |
| tsufiev | (speaking of your git issues and the whole workflow) | 17:36 |
| tsufiev | ducttape_, david-lyle: I wonder if the ajax nature of tab lazy loading will stand in the way of testing? | 17:38 |
| tsufiev | hm, on the second thought, I think it should be fine, since the ajax/js code was initiating the second request you're talking about | 17:39 |
| ducttape_ | is this a new lazy loaded tab concept? we have examples of the current lazy loaded stuff | 17:39 |
| robcresswell | No, just the usual preload=false | 17:40 |
| *** errolpais has joined #openstack-horizon | 17:41 | |
| ducttape_ | yeah, so the instances page does this | 17:41 |
| robcresswell | Yeah, thats the example I'm trying to mirror atm | 17:41 |
| ducttape_ | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tests.py#L980-L994 | 17:42 |
| ducttape_ | like that, the %s=%s stuff etc | 17:42 |
| *** jtriley has quit IRC | 17:43 | |
| *** nlahouti has joined #openstack-horizon | 17:43 | |
| *** crobertsrh1 has joined #openstack-horizon | 17:44 | |
| *** itxaka has quit IRC | 17:52 | |
| *** kzaitsev_mb has quit IRC | 17:54 | |
| *** rajatvig has joined #openstack-horizon | 17:55 | |
| *** rajatvig has quit IRC | 18:00 | |
| *** rajatvig has joined #openstack-horizon | 18:01 | |
| *** jtriley has joined #openstack-horizon | 18:02 | |
| *** petertr7 is now known as petertr7_away | 18:02 | |
| *** nlahouti has quit IRC | 18:03 | |
| *** nlahouti has joined #openstack-horizon | 18:05 | |
| *** yamamoto has quit IRC | 18:05 | |
| openstackgerrit | Paulo Ewerton Gomes Fragoso proposed openstack/horizon: Adding NGProjects Create Action - Quota https://review.openstack.org/252412 | 18:13 |
| *** mpavlase has quit IRC | 18:13 | |
| *** SurajD has quit IRC | 18:14 | |
| *** mohankumar has quit IRC | 18:17 | |
| *** SurajD has joined #openstack-horizon | 18:17 | |
| *** sambetts is now known as sambetts-afk | 18:18 | |
| *** gyee has quit IRC | 18:19 | |
| openstackgerrit | Timur Sufiev proposed openstack/django_openstack_auth: Prepare for 'AVAILABLE_REGIONS' renaming https://review.openstack.org/224756 | 18:19 |
| openstackgerrit | Timur Sufiev proposed openstack/django_openstack_auth: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222129 | 18:19 |
| openstackgerrit | Timur Sufiev proposed openstack/django_openstack_auth: Rename 'AVAILABLE_REGIONS' to 'KEYSTONE_ENDPOINTS' https://review.openstack.org/222129 | 18:20 |
| *** yamamoto has joined #openstack-horizon | 18:22 | |
| *** yamamoto has quit IRC | 18:23 | |
| openstackgerrit | Matt Wood proposed openstack/django_openstack_auth: STUPID MUSINGS REGARDING AZURE CLOUD STUFF https://review.openstack.org/255424 | 18:26 |
| *** ducttape_ has quit IRC | 18:26 | |
| *** jpomeroy has quit IRC | 18:29 | |
| *** mounica has quit IRC | 18:30 | |
| *** tosky has quit IRC | 18:33 | |
| *** jingjing_ren has joined #openstack-horizon | 18:39 | |
| *** e0ne has quit IRC | 18:41 | |
| *** dsneddon has quit IRC | 18:42 | |
| *** neelashah has quit IRC | 18:42 | |
| *** aix has quit IRC | 18:43 | |
| *** errolpais has quit IRC | 18:43 | |
| openstackgerrit | Matt Wood proposed openstack/django_openstack_auth: STUPID MUSINGS REGARDING AZURE CLOUD STUFF https://review.openstack.org/255424 | 18:44 |
| *** TravT_away has quit IRC | 18:46 | |
| *** dsneddon has joined #openstack-horizon | 18:46 | |
| *** marlinc has quit IRC | 18:48 | |
| *** rdopiera has quit IRC | 18:49 | |
| *** ducttape_ has joined #openstack-horizon | 18:50 | |
| *** flwang1 has quit IRC | 18:50 | |
| *** flwang1 has joined #openstack-horizon | 18:51 | |
| *** lhcheng has joined #openstack-horizon | 18:52 | |
| *** marlinc has joined #openstack-horizon | 18:53 | |
| *** lapalm has quit IRC | 18:56 | |
| *** gokrokve has quit IRC | 18:57 | |
| *** lhcheng has quit IRC | 18:57 | |
| *** jpomeroy has joined #openstack-horizon | 18:58 | |
| *** gokrokve has joined #openstack-horizon | 18:59 | |
| *** gokrokve has quit IRC | 18:59 | |
| *** flwang1 has quit IRC | 19:00 | |
| *** yamamoto has joined #openstack-horizon | 19:00 | |
| *** david-ly_ has joined #openstack-horizon | 19:00 | |
| *** ducttape_ has quit IRC | 19:00 | |
| *** ducttape_ has joined #openstack-horizon | 19:01 | |
| *** jingjing_ren has quit IRC | 19:02 | |
| *** yamamoto has quit IRC | 19:02 | |
| *** bpokorny_ has joined #openstack-horizon | 19:02 | |
| *** david-ly_ is now known as david-lyle_ | 19:03 | |
| *** david-lyle has quit IRC | 19:03 | |
| *** bpokorny_ has quit IRC | 19:03 | |
| *** neelashah has joined #openstack-horizon | 19:04 | |
| *** bpokorny_ has joined #openstack-horizon | 19:04 | |
| *** gokrokve has joined #openstack-horizon | 19:04 | |
| *** david-lyle_ is now known as david-lyle | 19:04 | |
| *** ChanServ sets mode: +o david-lyle | 19:04 | |
| *** lapalm has joined #openstack-horizon | 19:05 | |
| *** gokrokve has quit IRC | 19:05 | |
| *** gokrokve has joined #openstack-horizon | 19:06 | |
| *** bpokorny has quit IRC | 19:06 | |
| *** doug-fish has quit IRC | 19:08 | |
| *** doug-fish has joined #openstack-horizon | 19:09 | |
| *** gokrokve has quit IRC | 19:10 | |
| *** bpokorny_ has quit IRC | 19:11 | |
| *** bpokorny has joined #openstack-horizon | 19:12 | |
| *** doug-fish has quit IRC | 19:14 | |
| *** bpokorny_ has joined #openstack-horizon | 19:14 | |
| *** gyee has joined #openstack-horizon | 19:14 | |
| *** e0ne has joined #openstack-horizon | 19:15 | |
| *** petertr7_away is now known as petertr7 | 19:15 | |
| *** lhcheng has joined #openstack-horizon | 19:16 | |
| *** bpokorny has quit IRC | 19:17 | |
| *** jtriley has quit IRC | 19:17 | |
| *** lhcheng_ has joined #openstack-horizon | 19:17 | |
| *** lhcheng has quit IRC | 19:21 | |
| *** doug-fish has joined #openstack-horizon | 19:23 | |
| *** doug-fish has quit IRC | 19:23 | |
| *** doug-fish has joined #openstack-horizon | 19:23 | |
| *** _ducttape_ has joined #openstack-horizon | 19:34 | |
| *** ducttape_ has quit IRC | 19:38 | |
| *** aortega has quit IRC | 19:43 | |
| *** aortega has joined #openstack-horizon | 19:43 | |
| *** TravT_away has joined #openstack-horizon | 19:45 | |
| *** SurajD has quit IRC | 19:47 | |
| *** flwang1 has joined #openstack-horizon | 19:49 | |
| *** tqtran has joined #openstack-horizon | 19:49 | |
| *** bpokorny_ has quit IRC | 19:51 | |
| *** gokrokve has joined #openstack-horizon | 19:51 | |
| *** gokrokve has quit IRC | 19:52 | |
| *** gokrokve has joined #openstack-horizon | 19:52 | |
| *** gokrokve has quit IRC | 19:53 | |
| *** jtriley has joined #openstack-horizon | 19:53 | |
| *** kevinbenton has quit IRC | 19:54 | |
| *** john5223 is now known as zz_john5223 | 19:56 | |
| *** pkarikh_ has joined #openstack-horizon | 19:57 | |
| *** david-lyle has quit IRC | 19:58 | |
| *** david-lyle has joined #openstack-horizon | 19:58 | |
| *** ChanServ sets mode: +o david-lyle | 19:58 | |
| r1chardj0n3s | morning | 19:59 |
| *** tjones has quit IRC | 19:59 | |
| *** bpokorny has joined #openstack-horizon | 20:00 | |
| david-lyle | howdy | 20:00 |
| tqtran | i got a python url question for yall | 20:01 |
| *** peristeri has joined #openstack-horizon | 20:01 | |
| _ducttape_ | good, I got an ng question for you tqtran | 20:02 |
| tqtran | urlpatterns += patterns('', url(...), url(...)) | 20:02 |
| _ducttape_ | monasca has this bug - https://docs.angularjs.org/error/$injector/strictdi and I have a patch to push for that, wanted someone who knows more than I to chime in | 20:02 |
| tqtran | what does that '' in the begining do? is that a prefix? | 20:02 |
| _ducttape_ | the += part ? | 20:02 |
| *** crobertsrh1 has quit IRC | 20:02 | |
| tqtran | the patterns('' part | 20:03 |
| tqtran | the blank string | 20:03 |
| _ducttape_ | ah yeah, I think that is a namespace thing, for the url resolver | 20:03 |
| *** neelashah has quit IRC | 20:03 | |
| r1chardj0n3s | tqtran: https://docs.djangoproject.com/en/1.9/ref/urls/#patterns | 20:03 |
| _ducttape_ | so you can have various url patterns, they can be placed in different namespaces..... I am 100% making this up from memory | 20:04 |
| _ducttape_ | yeah, thats a good example r1chardj0n3s +1 | 20:04 |
| tqtran | ok so the prefix saves you from typing it over again in the url | 20:04 |
| tqtran | and does it also help you resolve them? | 20:04 |
| *** lhcheng_ has quit IRC | 20:05 | |
| _ducttape_ | that gets done via stuff like this: (r'^articles/([0-9]{4})/$' | 20:05 |
| *** ZZelle_ has joined #openstack-horizon | 20:05 | |
| *** lhcheng has joined #openstack-horizon | 20:06 | |
| _ducttape_ | so that says the uri folder path will be articles/4-digit-number/ | 20:06 |
| _ducttape_ | something like that | 20:06 |
| tqtran | ok i think i understand, its mainly useful if you specify the view as a string. | 20:09 |
| tqtran | and allows grping of them, otherwise, easier to just import the view and use object notation | 20:09 |
| tqtran | _ducttape_: so regarding the bug above, is it related to https://review.openstack.org/#/c/247212/ ? | 20:10 |
| tqtran | i am guessing monasca just recently caught the bug? | 20:11 |
| _ducttape_ | https://bugs.launchpad.net/monasca/+bug/1524475 yeah | 20:11 |
| openstack | Launchpad bug 1524475 in Monasca "monasca-ui is broken with latest horizon code" [Undecided,New] - Assigned to Eric Peterson (ericpeterson-l) | 20:11 |
| _ducttape_ | I have / am working on the fix right now | 20:11 |
| tqtran | ok, looking through their plugin now | 20:12 |
| _ducttape_ | not sure how many other projects are going to break | 20:12 |
| *** kevinbenton_ has joined #openstack-horizon | 20:13 | |
| tqtran | right, its an easy fix, just have to rewrite the current notation to use $inject | 20:13 |
| flwang1 | robcresswell: ping | 20:14 |
| tqtran | https://review.openstack.org/#/c/247212/4/horizon/static/auth/login/login-finder.directive.js provides an example | 20:14 |
| *** kevinbenton_ has quit IRC | 20:14 | |
| _ducttape_ | this is kind of a process questions for me. horizon is going to "improve" the other add-ins (with this change).... by breaking them ? | 20:14 |
| *** kevinbenton has joined #openstack-horizon | 20:14 | |
| tqtran | i dont think sean and i saw this coming. | 20:16 |
| tqtran | we assumed most existing plugins do not have angular code, and the ones that do already use existing strict mode, so def our fault on this. but at the same time, not sure how else to proceed | 20:17 |
| *** vgridnev has quit IRC | 20:17 | |
| _ducttape_ | I think the angular horse is out of the barn, now you have to support it and consider breaking changes | 20:17 |
| _ducttape_ | ;) | 20:17 |
| _ducttape_ | https://docs.angularjs.org/error/$injector/strictdi this also mentions two patterns - is one better than the other tqtran? will I get -1 votes if I use the 2nd pattern ? | 20:18 |
| tqtran | the first pattern is the one that is error prone, 2nd is more bullet proof | 20:19 |
| tqtran | it comes down to your compression configuration, if name mangling is turn on, first pattern will fail | 20:19 |
| tqtran | which is why we wanted to enable strict mode, to prevent this in case someone decided to use their own compressor | 20:20 |
| _ducttape_ | ok, I like the 2nd pattern in this situation anyways - thanks | 20:21 |
| _ducttape_ | 8) | 20:21 |
| tqtran | yep, sorry for the trouble. if you see bugs like these, feel free to forward them my way, i can fix | 20:21 |
| _ducttape_ | I'll add you to review of this tqtran - the monasca team could use some extra verification that this is really needed | 20:21 |
| tqtran | sure thing, will be happy to help | 20:22 |
| r1chardj0n3s | wasn't the app catalog also broken by the strictdi change too? | 20:22 |
| _ducttape_ | thanks | 20:22 |
| r1chardj0n3s | but I think that's been addressed | 20:22 |
| tqtran | right... we didnt see that coming. but i think the change is a good one. good intention, unintended consequences :P | 20:23 |
| r1chardj0n3s | yep | 20:23 |
| *** gokrokve has joined #openstack-horizon | 20:24 | |
| *** steveng has quit IRC | 20:24 | |
| *** steveng has joined #openstack-horizon | 20:25 | |
| tqtran | david-lyle: https://review.openstack.org/#/c/233709/11..12/doc/source/tutorials/plugin.rst L107 should be correct right? | 20:25 |
| tqtran | could you also look at urls.py ? seems like what richard and eric said, it should be ok right? | 20:26 |
| robcresswell | flwang1: Hi | 20:26 |
| david-lyle | tqtran: yes, correct as is | 20:26 |
| david-lyle | otherwise API is not in | 20:26 |
| tqtran | and the urls one? i think that is also correct as is | 20:27 |
| tqtran | since we are importing conf (one level up) and using views object directly | 20:27 |
| *** gokrokve has quit IRC | 20:27 | |
| *** gokrokve has joined #openstack-horizon | 20:28 | |
| robcresswell | tqtran: With the URLs thing, we can actually drop the '' notation because nothing uses it. could just do the list pattern in dj18 | 20:29 |
| robcresswell | scanning chat :) | 20:29 |
| tqtran | david-lyle, doug-fish: whats the difference between using setup.cfg vs manifest.in? one allows wildcarding and the other doesn't? | 20:29 |
| david-lyle | tqtran: running horizondrivers meeting ATM, can chat more later :) | 20:30 |
| flwang1 | robcresswell: thanks for the patch set | 20:31 |
| flwang1 | i'm going to test it on my local, but now i'm seeing another problem | 20:31 |
| *** petertr7 is now known as petertr7_away | 20:31 | |
| robcresswell | flwang1: No problem; hope I didn't interrupt your work too much. | 20:31 |
| robcresswell | flwang1: Oh? | 20:31 |
| doug-fish | tqtran: I'll mostly defer to david-lyle. I understand many openstack projects don't even use a manifest.in, I'm not sure there is a reason plugins would require | 20:32 |
| flwang1 | when i try to run "./run_tests.sh --runserver 127.0.0.1:8080" | 20:32 |
| *** jprovazn has quit IRC | 20:32 | |
| flwang1 | robcresswell: I got this error "Could not process panel queues: 'NoneType' object has no attribute 'panels'" | 20:32 |
| david-lyle | pbr uses setup.cfg plus magic. If you are doing an sdist, it uses manifest.in | 20:32 |
| robcresswell | flwang1: Did ou try my patch? Thats the error I fixed, which was preventing your panel from showing earlier | 20:33 |
| robcresswell | you* | 20:33 |
| flwang1 | and on firefox, when i access http://127.0.0.1:8080, i always is redirected to http://127.0.0.1:8080/dashboard/auth/login/?next=/ and got 404 | 20:33 |
| robcresswell | Oh, I don't know about the FF issue | 20:35 |
| *** RichardRaseley has joined #openstack-horizon | 20:35 | |
| flwang1 | ok, after copied the new plugin config file, the error "Could not process panel queues: 'NoneType' object has no attribute 'panels'" has gone | 20:36 |
| flwang1 | but i still get the 404 error | 20:36 |
| flwang1 | robcresswell: so in your test, you can see the queues panel successfully, right? | 20:37 |
| *** petertr7_away is now known as petertr7 | 20:37 | |
| *** neelashah has joined #openstack-horizon | 20:37 | |
| david-lyle | tqtran: pbr/sdist comment above was for you, forgot the nick | 20:39 |
| robcresswell | flwang1: Yes indeed | 20:39 |
| flwang1 | robcresswell: awesome, thank you so much for the help | 20:39 |
| tqtran | yup saw that, catching up the log on the drivers meeting lol | 20:39 |
| flwang1 | robcresswell: then i will retry it | 20:39 |
| flwang1 | robcresswell: btw, do you think currently the code is in a good shape if we will go for angularjs ? | 20:40 |
| robcresswell | flwang1: No problem | 20:40 |
| robcresswell | flwang1: I havent done a code review yet, just wanted to get it running :) | 20:40 |
| *** belmoreira has joined #openstack-horizon | 20:41 | |
| flwang1 | robcresswell: awesome, would you mind reviewing the zaqar-ui code in the future? we really need some expertise from horizon team | 20:42 |
| flwang1 | basically, we won't merge any patch if there is no at least one +1 from horizon guys | 20:43 |
| *** gokrokve has quit IRC | 20:43 | |
| robcresswell | flwang1: Possssibly. I'm fairly swamped right now. In a meeting too :) | 20:46 |
| _ducttape_ | https://review.openstack.org/255504 has that change tqtran | 20:50 |
| _ducttape_ | thanks! :) | 20:50 |
| tqtran | ok will take a look after drivers meeting | 20:50 |
| *** nlahouti has quit IRC | 20:53 | |
| *** kzaitsev_mb has joined #openstack-horizon | 20:54 | |
| *** TravT_away has quit IRC | 20:56 | |
| *** bpokorny has quit IRC | 20:58 | |
| *** Daisy has joined #openstack-horizon | 21:00 | |
| flwang1 | robcresswell: ok, cool, thanks | 21:00 |
| *** rajatvig has quit IRC | 21:02 | |
| lhcheng | tqtran: I don't agree with including the duration flag as a requirement | 21:03 |
| tqtran | its a flag that operator can specify to show all the time, or only once | 21:03 |
| tqtran | that way, users arent spam with the same message everytime | 21:03 |
| *** lblanchard has quit IRC | 21:03 | |
| *** TravT_away has joined #openstack-horizon | 21:04 | |
| lhcheng | well the operator will only use the messaging if there is something important to show | 21:04 |
| tqtran | if i updated horizon to version X with new features Y, i dont wanna be reminded everytime | 21:04 |
| *** Daisy has quit IRC | 21:04 | |
| lhcheng | user will not login every minute | 21:04 |
| robcresswell | I think david is probably right on this. We're in developer land too much. | 21:04 |
| *** pkarikh_ has quit IRC | 21:04 | |
| tqtran | that is true, but it will get annoying if the message is there each time i log in | 21:05 |
| robcresswell | If its not a valid concern, then we needn't worry about it. | 21:05 |
| robcresswell | Would rather defer to those with more deployment experience. I'm sure _ducttape_ will weigh in on it too :p | 21:05 |
| * _ducttape_ reads scrollback | 21:06 | |
| robcresswell | _ducttape_: We were just discussing lhcheng's message of the day proposal. The concern was that showing a message every login may get annoying, but others pointed out that realistically you wont be logging in that often, so its a non-issue. | 21:06 |
| _ducttape_ | not sure I get the question yet | 21:07 |
| _ducttape_ | ah ok. and if you don't set it - nothing shows then? | 21:07 |
| lhcheng | yup | 21:07 |
| _ducttape_ | that seems not too bad. I'd like to have the message so I can set it sometimes | 21:08 |
| *** ctina_ has quit IRC | 21:09 | |
| _ducttape_ | like during an incident, or after a new service is added - have the message. but 90% of the time have 0 message | 21:10 |
| robcresswell | Cool. I'm all for approving the bp then. | 21:10 |
| robcresswell | _ducttape_: I believe thats the intention. | 21:10 |
| david-lyle | exactly | 21:10 |
| david-lyle | it will require a change to production servers, people aren't going to do it for trivial reasons | 21:10 |
| tqtran | _ducttape_: looks like they already merged your patch. i was going to point out that there were a few directives in ng-tags-input.js but most of those are using the [] notation so might be ok | 21:10 |
| _ducttape_ | and this will get stored in a db or something? or be config driven ? | 21:11 |
| david-lyle | just file system driven | 21:11 |
| _ducttape_ | yeah, sorry tqtran - I asked that they wait for you | 21:11 |
| *** lblanchard has joined #openstack-horizon | 21:12 | |
| *** pauloewerton has quit IRC | 21:13 | |
| lhcheng | robcresswell: we use this feature in-house, and that is specifically the reason to inform people about incidents/upcoming upgrade. | 21:13 |
| robcresswell | lhcheng: Yeah, understood | 21:14 |
| *** neelashah has quit IRC | 21:15 | |
| robcresswell | tqtran: That strict check broke magnum-ui too | 21:15 |
| robcresswell | Unsure if its fixed yet | 21:15 |
| robcresswell | I wonder if its worth updating the plugin list with 'primary language' 'translations available' and 'liaison' columns. | 21:16 |
| *** erlon has quit IRC | 21:16 | |
| robcresswell | Might help us support them easier. | 21:16 |
| _ducttape_ | the message of the day.... a DB would be better than filesystem, just b/c of the coordinated deploy / nature of things... but otherwise seems ok | 21:16 |
| tqtran | robcresswell: that might be helpful in the long run | 21:17 |
| robcresswell | Might do that quickly tomorrow then. | 21:18 |
| david-lyle | _ducttape_: a DB where? | 21:18 |
| lhcheng | _ducttape_: yeah, DB would be nice. User would be able to set it in horizon. | 21:18 |
| lhcheng | _ducttape_: not sure if ops want to setup one more DB though | 21:18 |
| *** _ducttape_ has quit IRC | 21:19 | |
| david-lyle | or are you talking API call to set in horizon server DB? | 21:19 |
| *** ducttape_ has joined #openstack-horizon | 21:19 | |
| ducttape_ | a db that lives in my imaginary deployment where things are setup as I want them to be - that's where | 21:19 |
| david-lyle | oh, that one | 21:20 |
| david-lyle | no problem | 21:20 |
| david-lyle | will work perfectly there | 21:20 |
| ducttape_ | it just works™® | 21:20 |
| david-lyle | just don't try it ™ | 21:20 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Plugin Docs https://review.openstack.org/233709 | 21:22 |
| * david-lyle back in a bit | 21:23 | |
| *** steveng has quit IRC | 21:25 | |
| *** belmoreira has quit IRC | 21:26 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: hzIfApiVersion directive to check if api version enabled https://review.openstack.org/253178 | 21:26 |
| *** neelashah has joined #openstack-horizon | 21:27 | |
| *** e0ne has quit IRC | 21:32 | |
| *** ianbrown has quit IRC | 21:33 | |
| *** rajatvig has joined #openstack-horizon | 21:35 | |
| *** neelashah1 has joined #openstack-horizon | 21:38 | |
| *** neelashah has quit IRC | 21:38 | |
| *** steveng has joined #openstack-horizon | 21:44 | |
| openstackgerrit | Mark Sturdevant proposed openstack/manila-ui: Fix call to Client() with 2 api_version args https://review.openstack.org/255541 | 21:47 |
| *** Guest32752 is now known as apuimedo | 21:49 | |
| *** zz_john5223 is now known as john5223 | 21:52 | |
| *** garthb has joined #openstack-horizon | 22:01 | |
| *** jtriley_ has joined #openstack-horizon | 22:06 | |
| *** nlahouti has joined #openstack-horizon | 22:08 | |
| *** jtriley has quit IRC | 22:08 | |
| *** TravT_away has quit IRC | 22:08 | |
| *** neelashah1 has quit IRC | 22:08 | |
| *** Piet has joined #openstack-horizon | 22:09 | |
| *** jtriley_ has quit IRC | 22:10 | |
| *** lblanchard has quit IRC | 22:10 | |
| *** crobertsrh is now known as _crobertsrh | 22:13 | |
| *** neelashah has joined #openstack-horizon | 22:13 | |
| *** TravT_away has joined #openstack-horizon | 22:13 | |
| *** petertr7 is now known as petertr7_away | 22:18 | |
| *** neelashah has quit IRC | 22:25 | |
| *** alejandrito has quit IRC | 22:26 | |
| *** lapalm has quit IRC | 22:32 | |
| *** david-lyle has quit IRC | 22:34 | |
| *** lapalm has joined #openstack-horizon | 22:36 | |
| *** betherly has quit IRC | 22:36 | |
| *** lapalm has quit IRC | 22:36 | |
| *** david-ly_ has joined #openstack-horizon | 22:39 | |
| *** piet1 has joined #openstack-horizon | 22:41 | |
| *** david-ly_ is now known as david-lyle | 22:45 | |
| *** ChanServ sets mode: +o david-lyle | 22:45 | |
| *** aortega has quit IRC | 22:49 | |
| *** aortega has joined #openstack-horizon | 22:50 | |
| *** harlowja has quit IRC | 22:51 | |
| *** harlowja has joined #openstack-horizon | 22:51 | |
| *** peristeri has quit IRC | 22:53 | |
| *** kzaitsev_mb has quit IRC | 22:56 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Single Row Action button should appear as buttons https://review.openstack.org/243796 | 22:58 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow specifying item to use for actions in the actions directive https://review.openstack.org/254365 | 22:58 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Allow callback prefix for actions directive https://review.openstack.org/254415 | 22:58 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add Action to delete multiple and single images to images panel https://review.openstack.org/217422 | 22:58 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Callbacks should be passed as functions to the Actions directive https://review.openstack.org/255581 | 22:58 |
| *** kzaitsev_mb has joined #openstack-horizon | 22:58 | |
| *** ducttape_ has quit IRC | 22:59 | |
| *** aortega has quit IRC | 23:00 | |
| *** vijendar has quit IRC | 23:01 | |
| *** vgridnev has joined #openstack-horizon | 23:03 | |
| *** gokrokve has joined #openstack-horizon | 23:04 | |
| *** doug-fish has quit IRC | 23:06 | |
| *** piet1 has quit IRC | 23:06 | |
| *** gokrokve has quit IRC | 23:08 | |
| *** jpomeroy has quit IRC | 23:15 | |
| *** pumaranikar has quit IRC | 23:17 | |
| *** pushkaru has joined #openstack-horizon | 23:18 | |
| *** jbell8 has quit IRC | 23:19 | |
| *** vgridnev has quit IRC | 23:19 | |
| *** TravT_away has quit IRC | 23:20 | |
| *** Piet has quit IRC | 23:20 | |
| tqtran | robcresswell: ping | 23:25 |
| tqtran | actually anyone can help, have question: https://review.openstack.org/#/c/209631/31/releasenotes/notes/bp-bootstrap-theme-preview-65da171c9b943646.yaml | 23:25 |
| *** Ephur has quit IRC | 23:25 | |
| tqtran | how do you generate the release number? | 23:25 |
| lhcheng | tqtran: run "tox -e venv -- reno new <bug-,bp-,whatever>" | 23:26 |
| lhcheng | it will generate bug-<random number>.yaml | 23:26 |
| tqtran | nvm found the docs for it | 23:27 |
| *** pushkaru has quit IRC | 23:30 | |
| *** jbell8 has joined #openstack-horizon | 23:32 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Support javascript translation for plugin https://review.openstack.org/255590 | 23:34 |
| openstackgerrit | Errol Pais proposed openstack/horizon: Add extensions to $q for resolving all promises https://review.openstack.org/240589 | 23:36 |
| *** ianbrown has joined #openstack-horizon | 23:36 | |
| *** ianbrown has quit IRC | 23:36 | |
| *** rcernin has joined #openstack-horizon | 23:38 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: API for Metadata Definitions https://review.openstack.org/215721 | 23:44 |
| openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 23:44 |
| *** lhcheng_ has joined #openstack-horizon | 23:46 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: WIP: Add Create Volume Action for the Image https://review.openstack.org/229677 | 23:47 |
| *** betherly has joined #openstack-horizon | 23:48 | |
| openstackgerrit | Rajat Vig proposed openstack/horizon: Add test for the Heat Service validate method https://review.openstack.org/237272 | 23:48 |
| *** lhcheng has quit IRC | 23:50 | |
| openstackgerrit | Errol Pais proposed openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 23:52 |
| *** ianbrown has joined #openstack-horizon | 23:55 | |
| *** lhcheng_ has quit IRC | 23:56 | |
| *** jingjing_ren has joined #openstack-horizon | 23:58 | |
| *** ZZelle_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!