*** SimonChung has joined #openstack-horizon | 00:01 | |
*** SimonChung1 has quit IRC | 00:01 | |
*** jbell8 has quit IRC | 00:03 | |
*** yamamoto_ has quit IRC | 00:03 | |
*** agireud has quit IRC | 00:06 | |
*** agireud has joined #openstack-horizon | 00:08 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:09 | |
*** ducttape_ has joined #openstack-horizon | 00:18 | |
*** e0ne has quit IRC | 00:18 | |
*** Drago has joined #openstack-horizon | 00:26 | |
*** wolverin_ has quit IRC | 00:28 | |
*** wolverineav has joined #openstack-horizon | 00:29 | |
*** jtriley has quit IRC | 00:29 | |
*** flwang has quit IRC | 00:29 | |
*** Drago has quit IRC | 00:36 | |
*** jtriley has joined #openstack-horizon | 00:38 | |
*** kzaitsev_mb has quit IRC | 00:39 | |
*** flwang has joined #openstack-horizon | 00:43 | |
*** sjmc7 has quit IRC | 00:49 | |
*** ducttape_ has quit IRC | 00:49 | |
*** ducttape_ has joined #openstack-horizon | 00:51 | |
*** lblanchard has joined #openstack-horizon | 00:53 | |
*** kzaitsev_mb has joined #openstack-horizon | 00:54 | |
*** ducttape_ has quit IRC | 00:55 | |
*** ducttape_ has joined #openstack-horizon | 01:01 | |
*** gokrokve has joined #openstack-horizon | 01:05 | |
*** Mounica has quit IRC | 01:09 | |
*** ybathia has quit IRC | 01:09 | |
*** Mounica has joined #openstack-horizon | 01:11 | |
*** ducttape_ has quit IRC | 01:11 | |
*** Mounica has quit IRC | 01:13 | |
*** garthb has quit IRC | 01:14 | |
*** gokrokve has quit IRC | 01:17 | |
*** ducttape_ has joined #openstack-horizon | 01:17 | |
*** hurgleburgler has quit IRC | 01:22 | |
*** tqtran has quit IRC | 01:24 | |
*** itisha has quit IRC | 01:26 | |
*** mtanino has quit IRC | 01:29 | |
*** ducttape_ has quit IRC | 01:30 | |
*** kzaitsev_mb has quit IRC | 01:30 | |
*** SimonChung has quit IRC | 01:40 | |
*** darrenc is now known as darrenc_afk | 01:47 | |
*** piet has joined #openstack-horizon | 01:50 | |
*** gyee has quit IRC | 01:53 | |
openstackgerrit | Merged openstack/horizon: "Required" fields are no longer visually indicated https://review.openstack.org/278029 | 01:57 |
---|---|---|
*** wolverin_ has joined #openstack-horizon | 01:58 | |
openstackgerrit | Renjie Sun proposed openstack/horizon: Try to keep container_format across image update https://review.openstack.org/275482 | 01:59 |
*** darrenc_afk is now known as darrenc | 01:59 | |
openstackgerrit | Merged openstack/horizon: Integration tests naming sanity https://review.openstack.org/278009 | 02:00 |
openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/277700 | 02:01 |
*** wolverineav has quit IRC | 02:01 | |
openstackgerrit | Merged openstack/horizon: Port dashboard containers to Python 3 https://review.openstack.org/275257 | 02:01 |
openstackgerrit | Merged openstack/horizon: Port identity provider dashboard to Python 3 https://review.openstack.org/275265 | 02:01 |
openstackgerrit | Merged openstack/horizon: Set proper z-index value on messages and navbar https://review.openstack.org/145775 | 02:01 |
*** wolverin_ has quit IRC | 02:02 | |
*** piet has quit IRC | 02:05 | |
*** bpokorny has quit IRC | 02:10 | |
*** sid14726 has joined #openstack-horizon | 02:12 | |
*** ducttape_ has joined #openstack-horizon | 02:12 | |
*** yamamoto has joined #openstack-horizon | 02:12 | |
*** Ephur has quit IRC | 02:13 | |
*** kzaitsev_mb has joined #openstack-horizon | 02:27 | |
*** yamamoto has quit IRC | 02:31 | |
*** SimonChung has joined #openstack-horizon | 02:49 | |
*** dan_nguyen has quit IRC | 02:56 | |
*** darrenc is now known as darrenc_afk | 02:58 | |
*** kzaitsev_mb has quit IRC | 02:58 | |
*** lhcheng has quit IRC | 03:10 | |
*** logan-- has joined #openstack-horizon | 03:10 | |
*** darrenc_afk is now known as darrenc | 03:11 | |
*** logan-- has quit IRC | 03:14 | |
*** logan- has quit IRC | 03:22 | |
*** logan- has joined #openstack-horizon | 03:23 | |
*** yamamoto has joined #openstack-horizon | 03:29 | |
*** gokrokve has joined #openstack-horizon | 03:37 | |
*** jtriley has quit IRC | 03:40 | |
*** gokrokve_ has joined #openstack-horizon | 03:43 | |
*** omer_etrog has joined #openstack-horizon | 03:45 | |
*** gokrokve has quit IRC | 03:45 | |
*** gokrokve has joined #openstack-horizon | 03:48 | |
*** gokrokve_ has quit IRC | 03:48 | |
*** gokrokve has quit IRC | 03:53 | |
*** gokrokve has joined #openstack-horizon | 03:53 | |
*** kzaitsev_mb has joined #openstack-horizon | 03:55 | |
*** SimonChung1 has joined #openstack-horizon | 03:55 | |
*** SimonChung has quit IRC | 03:56 | |
*** kzaitsev_mb has quit IRC | 04:00 | |
*** lhcheng has joined #openstack-horizon | 04:02 | |
*** sjmc7 has joined #openstack-horizon | 04:02 | |
*** flwang1 has quit IRC | 04:02 | |
*** ducttape_ has quit IRC | 04:02 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 04:03 |
*** ducttape_ has joined #openstack-horizon | 04:03 | |
*** lhcheng_ has joined #openstack-horizon | 04:05 | |
*** ducttape_ has quit IRC | 04:08 | |
*** lhcheng has quit IRC | 04:08 | |
*** omer_etrog has quit IRC | 04:10 | |
*** omer_etrog has joined #openstack-horizon | 04:11 | |
*** sjmc7 has quit IRC | 04:16 | |
*** amotoki has joined #openstack-horizon | 04:17 | |
*** amotoki has quit IRC | 04:17 | |
*** Daisy has joined #openstack-horizon | 04:18 | |
*** ducttape_ has joined #openstack-horizon | 04:21 | |
*** hurgleburgler has joined #openstack-horizon | 04:21 | |
*** Daisy has quit IRC | 04:23 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Context Picker should inherit BS dropdown styles https://review.openstack.org/271858 | 04:23 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Style: Material: Fixes colors for navbar and menu https://review.openstack.org/274371 | 04:23 |
*** Daisy has joined #openstack-horizon | 04:23 | |
*** wolverineav has joined #openstack-horizon | 04:23 | |
*** wolverineav has quit IRC | 04:28 | |
*** Daisy has quit IRC | 04:28 | |
*** ducttape_ has quit IRC | 04:31 | |
*** ppiela has quit IRC | 04:33 | |
*** lhcheng_ has quit IRC | 04:33 | |
*** ppiela has joined #openstack-horizon | 04:33 | |
*** wolverineav has joined #openstack-horizon | 04:36 | |
*** wolverineav has quit IRC | 04:36 | |
*** wolverineav has joined #openstack-horizon | 04:36 | |
*** lblanchard has quit IRC | 04:57 | |
*** kzaitsev_mb has joined #openstack-horizon | 04:57 | |
*** shu-mutou-AFK is now known as shu-mutou | 04:57 | |
*** omer_etrog has quit IRC | 04:59 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 05:00 |
*** wolverin_ has joined #openstack-horizon | 05:00 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 05:01 |
*** kzaitsev_mb has quit IRC | 05:02 | |
*** wolverineav has quit IRC | 05:04 | |
*** gokrokve_ has joined #openstack-horizon | 05:05 | |
*** wolverin_ has quit IRC | 05:05 | |
*** gokrokve has quit IRC | 05:06 | |
*** piet has joined #openstack-horizon | 05:13 | |
*** jbell8 has joined #openstack-horizon | 05:17 | |
sudheer | Hello TravT | 05:24 |
sudheer | iam the one who is looking for support for search light panel | 05:25 |
*** masco has joined #openstack-horizon | 05:39 | |
*** hurgleburgler has quit IRC | 05:40 | |
*** gokrokve_ has quit IRC | 05:42 | |
*** ianbrown_ has quit IRC | 05:44 | |
*** ianbrown_ has joined #openstack-horizon | 05:45 | |
*** gokrokve has joined #openstack-horizon | 05:45 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Fix the color of question circle in checkbox https://review.openstack.org/277333 | 05:47 |
*** gokrokve has quit IRC | 05:48 | |
*** gokrokve_ has joined #openstack-horizon | 05:48 | |
*** piet has quit IRC | 05:55 | |
*** kzaitsev_mb has joined #openstack-horizon | 05:58 | |
openstackgerrit | Merged openstack/horizon: Launch Instance - Create Keypair Service https://review.openstack.org/261130 | 05:59 |
*** kzaitsev_mb has quit IRC | 06:03 | |
*** gokrokve_ has quit IRC | 06:06 | |
TravT | hi sudheer | 06:16 |
TravT | i saw your comments last night | 06:16 |
TravT | i pulled the patch and it worked for me today. | 06:17 |
TravT | i also continued some refactoring i'm doing and checked it in. | 06:17 |
TravT | but i'd like to help out if i can | 06:17 |
TravT | was just heading to bed, but can stick on here a few minutes | 06:17 |
sudheer | ok http://imgur.com/nVmyC8i | 06:23 |
*** jsheeren has joined #openstack-horizon | 06:23 | |
sudheer | please check this | 06:23 |
TravT | so is this a devstack? | 06:23 |
sudheer | yeah | 06:23 |
TravT | and how recent did you pull the patch? | 06:24 |
sudheer | like two days ago | 06:24 |
TravT | is this on apache or via run_tests.sh? | 06:24 |
sudheer | apache | 06:24 |
TravT | we just pulled in the search bar widget (magic-search) | 06:25 |
TravT | i'm wondering if there's any chance your deployment still is relying on the xtstatic packaged one. | 06:26 |
sudheer | i have pulled https://review.openstack.org/#/c/227036/ | 06:26 |
TravT | in /opt/stack/horizon/requirements.txt | 06:27 |
sudheer | this patch only should i need to pull another patches to make this work | 06:27 |
TravT | yes, it should work... | 06:27 |
TravT | but stranger things have happened | 06:27 |
TravT | in requirements.txt do you see XStatic-Magic-Search | 06:28 |
*** aortega has quit IRC | 06:29 | |
sudheer | i jsut cherry picked the patch into my horizon code base . Ran collect static and then compressed and restarted apache | 06:29 |
sudheer | one min i will check it | 06:29 |
TravT | oh you cherry picked | 06:29 |
TravT | i think you need to do git review -d or you won't get the parent patch to the searchlight panel patch | 06:30 |
sudheer | yeah i just cherry picked the pathc | 06:31 |
sudheer | what are the additional things i needed to do | 06:31 |
TravT | can you try this | 06:31 |
TravT | cd /opt/stack/horizon | 06:31 |
TravT | git review -d 227036 | 06:31 |
sudheer | after cherry picking the content | 06:32 |
sudheer | ?? | 06:32 |
TravT | no don't cherry pick | 06:33 |
TravT | so you cherry picked onto master? | 06:33 |
sudheer | yeah | 06:33 |
sudheer | i ran devstack to install openstack and then went to /opt/stack/horizon using the gerrit link i cherry picked | 06:34 |
sudheer | my requirements.txt has an entry for XStatic-Magic-Search>=0.2.5.1 # Apache 2.0 License | 06:34 |
TravT | hmm, i'm pretty sure that doesn't pull the parent patch | 06:35 |
TravT | okay, i think we have a couple problems... | 06:35 |
TravT | XStatic-magic-search was removed on Feb 4th with this patch: 245288 | 06:35 |
TravT | https://review.openstack.org/#/c/245288/ | 06:36 |
TravT | so merged to master. | 06:36 |
TravT | the current searchlight patch was rebased onto that. | 06:36 |
TravT | so, i'm not really sure how well it'll work in the environment to start with | 06:36 |
*** jtriley has joined #openstack-horizon | 06:36 | |
TravT | the next thing is that you shouldn't cherry pick it. | 06:37 |
sudheer | so what i have to do , i have a backup for master horizon | 06:37 |
TravT | it would be getter to do git review -d | 06:37 |
TravT | okay, restore your horizon backup | 06:37 |
sudheer | so i can replace it , and then i will follow the steps that you mentioned | 06:37 |
TravT | then follow those steps | 06:37 |
TravT | you'll still need to collectstatic and compress | 06:38 |
sudheer | yeah that i know but you mentioned problems about xstatic package of magic search | 06:39 |
TravT | we'll i *think* it'll work with just pulling that patch | 06:39 |
TravT | git review -d | 06:39 |
sudheer | searchlight@searchlight:/opt/stack/horizon$ git review -d 227036 git: 'review' is not a git command. See 'git --help'. | 06:40 |
TravT | oh... | 06:40 |
TravT | ubunutu? | 06:41 |
sudheer | yeah | 06:41 |
TravT | apt-get install git-review | 06:41 |
sudheer | and then it is asking gerrit username | 06:45 |
TravT | okay, so you have not set up for openstack dev before? | 06:46 |
TravT | it is pretty easy | 06:46 |
TravT | http://docs.openstack.org/infra/manual/developers.html | 06:47 |
TravT | it looks intimidating but it really isn't | 06:47 |
TravT | you could also try to do the pull rather than cherry pick | 06:47 |
sudheer | i was using my Sudheerkall my gerrit username | 06:48 |
sudheer | but still getting the same error Could not connect to gerrit at ssh://SudheerKall@review.openstack.org:29418/openstack/horizon.git | 06:48 |
TravT | might just be this: git config --global gitreview.username yourgerritusername | 06:49 |
TravT | but might also be that you don't have ssh keys setup properly | 06:49 |
TravT | that link has all the info. | 06:50 |
TravT | whenever you directly cherry pick or pull, it'd recommend doing it on a new local branch | 06:51 |
TravT | git checkout -b my-local-branch | 06:51 |
TravT | than you could try doing the Pull command | 06:51 |
sudheer | ya ok i hava added my ssh keys now properly seems it is working fine | 06:51 |
TravT | okay | 06:52 |
TravT | good | 06:52 |
TravT | progress! | 06:52 |
sudheer | git review -d 227036 , and can i just run the compress and collectstatic commands | 06:52 |
TravT | yes | 06:52 |
*** ianbrown_ has quit IRC | 06:52 | |
sudheer | running commands now | 06:52 |
*** ianbrown_ has joined #openstack-horizon | 06:53 | |
sudheer | yeah thanks | 06:57 |
sudheer | it's working fine now | 06:57 |
sudheer | thanks alot travis | 06:57 |
TravT | aweomse! | 06:58 |
TravT | awesome! | 06:58 |
TravT | great, would love feedback... even though still developing. | 06:58 |
TravT | also, on your devstack you can use CLI | 06:58 |
sudheer | how can i use CLI | 06:59 |
sudheer | is there any user guides that i can follow | 06:59 |
TravT | source ~/devstack/openrc admin demo | 06:59 |
TravT | openstack search facet list --type OS::Glance::Image | 06:59 |
TravT | openstack search query --help | 06:59 |
*** kzaitsev_mb has joined #openstack-horizon | 06:59 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: WIP Searchlight Search Panel https://review.openstack.org/227036 | 06:59 |
TravT | openstack search query 'name: cirros AND updated_at: [now-1y TO now]' | 07:00 |
TravT | and you can get really fancy | 07:01 |
TravT | openstack search query 'name: cirros AND updated_at: [now-1y TO now]' --source -c Source -f json | 07:01 |
TravT | sudheer: i've got to head to bed. | 07:02 |
TravT | please feel free to leave feedback on the patch. it is work in progress. | 07:02 |
sudheer | yeah man thanks a lot for the help | 07:02 |
TravT | sure. | 07:02 |
TravT | also, if you have any interest in contributing towards searchlight, please join us! | 07:03 |
*** kzaitsev_mb has quit IRC | 07:04 | |
*** gokrokve has joined #openstack-horizon | 07:06 | |
sudheer | yeah | 07:09 |
*** rdopiera has joined #openstack-horizon | 07:10 | |
*** jsheeren has quit IRC | 07:10 | |
*** jprovazn has joined #openstack-horizon | 07:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/278234 | 07:12 |
*** belmoreira has joined #openstack-horizon | 07:13 | |
*** gokrokve has quit IRC | 07:14 | |
*** rcernin has joined #openstack-horizon | 07:14 | |
*** lhcheng has joined #openstack-horizon | 07:14 | |
openstackgerrit | Yury Tregubov proposed openstack/horizon: Added image create delete and edit tests https://review.openstack.org/271249 | 07:14 |
*** rudolfvriend has joined #openstack-horizon | 07:17 | |
*** akulshin has joined #openstack-horizon | 07:33 | |
openstackgerrit | Merged openstack/horizon: Context Picker should inherit BS dropdown styles https://review.openstack.org/271858 | 07:36 |
*** jbell8 has quit IRC | 07:38 | |
*** jbell8 has joined #openstack-horizon | 07:40 | |
*** jsheeren has joined #openstack-horizon | 07:46 | |
*** openstackgerrit has quit IRC | 07:47 | |
*** openstackgerrit has joined #openstack-horizon | 07:48 | |
*** jtomasek_ has joined #openstack-horizon | 07:51 | |
*** jbell8 has quit IRC | 07:51 | |
*** jbell8 has joined #openstack-horizon | 07:52 | |
*** rcernin has quit IRC | 07:52 | |
*** lhcheng has quit IRC | 07:53 | |
*** omer_etrog has joined #openstack-horizon | 07:57 | |
*** omer_etrog has quit IRC | 07:57 | |
*** e0ne has joined #openstack-horizon | 07:58 | |
*** rdopiera has quit IRC | 08:00 | |
*** wolverineav has joined #openstack-horizon | 08:00 | |
*** kzaitsev_mb has joined #openstack-horizon | 08:00 | |
*** rdopiera has joined #openstack-horizon | 08:00 | |
*** wolverineav has quit IRC | 08:03 | |
*** itisha has joined #openstack-horizon | 08:03 | |
*** wolverineav has joined #openstack-horizon | 08:04 | |
*** kzaitsev_mb has quit IRC | 08:04 | |
*** omer_etrog has joined #openstack-horizon | 08:06 | |
*** omer_etrog has quit IRC | 08:10 | |
*** rcernin has joined #openstack-horizon | 08:15 | |
*** sinese_ has joined #openstack-horizon | 08:17 | |
*** wolverineav has quit IRC | 08:19 | |
*** wolverineav has joined #openstack-horizon | 08:35 | |
*** e0ne has quit IRC | 08:39 | |
*** gokrokve has joined #openstack-horizon | 08:40 | |
*** Drago has joined #openstack-horizon | 08:43 | |
*** Drago has quit IRC | 08:44 | |
*** Drago has joined #openstack-horizon | 08:44 | |
*** gokrokve has quit IRC | 08:44 | |
*** akulshin has quit IRC | 08:46 | |
*** wolverineav has quit IRC | 08:49 | |
*** aortega has joined #openstack-horizon | 08:51 | |
*** mpavlase has joined #openstack-horizon | 08:57 | |
*** reedip is now known as outofmemory | 08:57 | |
*** Drago has quit IRC | 09:00 | |
*** kzaitsev_mb has joined #openstack-horizon | 09:01 | |
*** kzaitsev_mb has quit IRC | 09:05 | |
*** tosky has joined #openstack-horizon | 09:05 | |
*** omer_etr_ has joined #openstack-horizon | 09:08 | |
*** omer_etr_ is now known as omer_etrog_ | 09:08 | |
*** itxaka has joined #openstack-horizon | 09:14 | |
*** kzaitsev_mb has joined #openstack-horizon | 09:20 | |
robcresswell | sudheer TravT: \o/ Just reading the scrollback. Glad that was all sorted out! | 09:26 |
openstackgerrit | Merged openstack/horizon: Add test for create/delete Namespace inside "Metadata Definitions" https://review.openstack.org/268039 | 09:27 |
*** jbell8 has quit IRC | 09:32 | |
sudheer | Yeah but that took hell lot of explaination from TarvT | 09:33 |
*** jbell8 has joined #openstack-horizon | 09:33 | |
robcresswell | sudheer: Heh, yeah, I didn't realise you'd not done any openstack dev before. There are guides for that. | 09:34 |
sudheer | yeah i have done openstack dev before but not in recenrt times | 09:35 |
robcresswell | ah okay | 09:35 |
sudheer | i have query regarding the git pulling and cherry picking | 09:35 |
*** jbell8 has quit IRC | 09:35 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Re-enable keypairs integration test https://review.openstack.org/276820 | 09:36 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow @tables.bind_row_action() to bind in 2 additional scenarios https://review.openstack.org/271805 | 09:36 |
sudheer | say for example iam working on stable liberty and i want a change that has been merged in master but not in liberty branch how can i get the change | 09:37 |
robcresswell | Just cherry pick it | 09:38 |
sudheer | but TravT said cherry picking is not going to help we need to do git review -d | 09:38 |
*** jbell8 has joined #openstack-horizon | 09:39 | |
robcresswell | You don't *have* to use git review, its just a very very handy shortcut | 09:39 |
sudheer | yeah but as you can see our discussion i have cherry picked first but that doesn't worked so he asked me to do git review -d | 09:40 |
robcresswell | I think you can cherrypick with git review -x | 09:40 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Ensure that integration tests are being run in proper project https://review.openstack.org/276678 | 09:40 |
robcresswell | Probably because there's a ton of code added in Mitaka so cherry picking that single patch wont work | 09:41 |
robcresswell | Angular is still building out a framework in Horizon so its not surprising that a cherry pick would fail | 09:41 |
*** omer_etrog_ has quit IRC | 09:41 | |
*** gokrokve has joined #openstack-horizon | 09:41 | |
*** omer_etrog has joined #openstack-horizon | 09:42 | |
sudheer | ok ok i have a local setup of horizon liberty with my custom changes on it so if i want to use this patch can i do cherry pick?? | 09:42 |
robcresswell | A local stable/liberty? I very much doubt a cherry pick would work | 09:43 |
sudheer | is there is any way can i achieve this ??? | 09:43 |
*** omer_etrog has quit IRC | 09:44 | |
robcresswell | Why are you trying to run a WIP Mitaka patch on a stable Liberty installation? :/ | 09:44 |
robcresswell | You could feasibly track down every patch that the angular framework in Horizon relies on, but you'd end up with a spaghetti mess of custom patches | 09:44 |
sudheer | seems intimidating | 09:44 |
robcresswell | Indeed :) | 09:45 |
robcresswell | If you want to test it, just use the git repos master branch | 09:45 |
*** kzaitsev_mb has quit IRC | 09:46 | |
*** gokrokve has quit IRC | 09:48 | |
*** wolverineav has joined #openstack-horizon | 09:49 | |
openstackgerrit | Merged openstack/django_openstack_auth: Remove openstack-common.conf https://review.openstack.org/273480 | 09:51 |
*** mvk has joined #openstack-horizon | 09:52 | |
*** wolverineav has quit IRC | 09:54 | |
*** akulshin has joined #openstack-horizon | 09:55 | |
*** mvk has quit IRC | 09:56 | |
*** shu-mutou is now known as shu-mutou-AFK | 09:56 | |
openstackgerrit | Yury Tregubov proposed openstack/horizon: Added image create delete and edit tests https://review.openstack.org/271249 | 10:00 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that user should not have ability to disable himself. https://review.openstack.org/275623 | 10:06 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to verify disabling and then enabling user https://review.openstack.org/275206 | 10:06 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for disabling, enabling project (Identity->Projects). https://review.openstack.org/277409 | 10:06 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for changing password for newly created user https://review.openstack.org/274659 | 10:06 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check new project creation during new user creation. https://review.openstack.org/276640 | 10:06 |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test to check that it is not be possible to disable current project. https://review.openstack.org/278289 | 10:06 |
*** e0ne has joined #openstack-horizon | 10:07 | |
*** kmARC has quit IRC | 10:09 | |
openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check volume types management functionality https://review.openstack.org/267403 | 10:10 |
openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added tests for check change volume functionality https://review.openstack.org/267630 | 10:11 |
openstackgerrit | Tatyana Kuterina proposed openstack/horizon: Added test for check launch volume as instance functionality https://review.openstack.org/276654 | 10:11 |
^Gal^ | Hi, when is the upcoming Horizon Drivers meeting? | 10:12 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 10:12 |
robcresswell | ^Gal^: Next week, Wednesday 2000UTC | 10:12 |
^Gal^ | robcresswell: thanks! | 10:12 |
robcresswell | tsufiev: Could you bump this please? Super minor patch, just fixes some styling issues on master. https://review.openstack.org/#/c/277439/ | 10:15 |
*** mvk has joined #openstack-horizon | 10:16 | |
*** sinese_ has quit IRC | 10:16 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Enhance policy rules to workflow actions https://review.openstack.org/144152 | 10:18 |
*** omer_etrog has joined #openstack-horizon | 10:22 | |
tsufiev | robcresswell, looking | 10:28 |
tsufiev | robcresswell, done. Could you in return look at https://review.openstack.org/#/c/271805/ ? Another really minor (but still valuable) i9n tests fix | 10:35 |
robcresswell | sure thing | 10:35 |
*** omer_etrog has quit IRC | 10:35 | |
*** omer_etrog has joined #openstack-horizon | 10:35 | |
robcresswell | tsufiev: Looks good. I do like how nice it is being able to look at the i9n logs to see if a test works :p | 10:36 |
tsufiev | robcresswell, yet in some cases it's not very nice to look at logs when a test doesn't work :) | 10:37 |
tsufiev | fixed here https://review.openstack.org/#/c/277755/ | 10:38 |
tsufiev | with a dependent patch https://review.openstack.org/#/c/261930/10 could be used as a demonstration of logs being fixed | 10:38 |
*** omer_etrog has quit IRC | 10:40 | |
robcresswell | 0.o thats gonna take a little more time | 10:40 |
tsufiev | robcresswell, never mind, put it aside if you had something other in mind to review | 10:41 |
robcresswell | Working on some code atm :) | 10:42 |
tsufiev | I'm trying to disperse the i9n fixes review burden over as many core reviewers as I know | 10:42 |
*** omer_etrog has joined #openstack-horizon | 10:42 | |
tsufiev | this approach works better than dumping all existing reviews onto a single core | 10:43 |
robcresswell | Makes sense | 10:46 |
*** kzaitsev_mb has joined #openstack-horizon | 10:49 | |
*** akulshin has quit IRC | 10:54 | |
*** akulshin has joined #openstack-horizon | 10:56 | |
*** JeanBriceCombebi has joined #openstack-horizon | 10:56 | |
*** JeanBriceCombebi has quit IRC | 11:01 | |
*** JeanBriceCombebi has joined #openstack-horizon | 11:04 | |
*** NightKhaos has quit IRC | 11:04 | |
*** omer_etrog has quit IRC | 11:10 | |
*** omer_etrog has joined #openstack-horizon | 11:11 | |
*** NightKhaos has joined #openstack-horizon | 11:11 | |
*** omer_etrog has quit IRC | 11:15 | |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Net topology: Show console link only when useful https://review.openstack.org/278311 | 11:16 |
openstackgerrit | Yury Tregubov proposed openstack/horizon: Added image create delete and edit tests https://review.openstack.org/271249 | 11:16 |
*** NightKhaos has quit IRC | 11:16 | |
*** akulshin has quit IRC | 11:17 | |
*** NightKhaos has joined #openstack-horizon | 11:19 | |
*** akulshin has joined #openstack-horizon | 11:19 | |
*** Daisy has joined #openstack-horizon | 11:36 | |
*** jtriley has quit IRC | 11:40 | |
*** erlon has joined #openstack-horizon | 11:43 | |
*** kzaitsev_mb has quit IRC | 11:47 | |
*** kmartin__ has quit IRC | 11:48 | |
*** sinese_ has joined #openstack-horizon | 11:49 | |
*** wolverineav has joined #openstack-horizon | 11:51 | |
*** sid14726 has quit IRC | 11:54 | |
*** permalac has joined #openstack-horizon | 11:55 | |
*** wolverineav has quit IRC | 11:56 | |
*** Daisy has quit IRC | 11:58 | |
*** mvk has quit IRC | 12:00 | |
openstackgerrit | Merged openstack/horizon: Refresh the networks on ajax update https://review.openstack.org/256460 | 12:01 |
mrunge | do we have a meeting now? | 12:02 |
*** mvk has joined #openstack-horizon | 12:02 | |
mrunge | ah, according https://wiki.openstack.org/wiki/Meetings/Horizon we don't | 12:02 |
openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Add test_router integration test https://review.openstack.org/260360 | 12:03 |
openstackgerrit | Tatyana Gladysheva proposed openstack/horizon: Added test for create/delete router actions from network topology page https://review.openstack.org/278327 | 12:03 |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log an operation of users to Horizon https://review.openstack.org/272935 | 12:05 |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log an operation of users to Horizon https://review.openstack.org/272935 | 12:07 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 12:09 |
*** akulshin has quit IRC | 12:09 | |
*** kzaitsev_mb has joined #openstack-horizon | 12:12 | |
*** omer_etrog has joined #openstack-horizon | 12:12 | |
*** masco has quit IRC | 12:13 | |
*** omer_etrog has quit IRC | 12:17 | |
*** JeanBriceCombebi has quit IRC | 12:18 | |
*** yamamoto has quit IRC | 12:20 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 12:21 |
*** sinese_ has quit IRC | 12:25 | |
*** akulshin has joined #openstack-horizon | 12:26 | |
*** sinese_ has joined #openstack-horizon | 12:27 | |
*** krotscheck_dcm is now known as krotscheck | 12:38 | |
*** akulshin has quit IRC | 12:41 | |
*** vgridnev has joined #openstack-horizon | 12:44 | |
*** akulshin has joined #openstack-horizon | 12:47 | |
*** akulshin has quit IRC | 12:48 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add function to recreate ec2 credential https://review.openstack.org/252190 | 12:48 |
*** joker_ has joined #openstack-horizon | 12:50 | |
*** jtriley has joined #openstack-horizon | 12:51 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Modify issue that a image is not displayed in ng-launch instance wizard https://review.openstack.org/260601 | 12:52 |
*** sid14726 has joined #openstack-horizon | 12:57 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add feature to log an operation of users to Horizon https://review.openstack.org/272935 | 13:02 |
*** ducttape_ has joined #openstack-horizon | 13:06 | |
*** e0ne has quit IRC | 13:09 | |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 13:09 |
*** vgridnev has quit IRC | 13:09 | |
*** e0ne has joined #openstack-horizon | 13:09 | |
betherly | hi all! fun python q. got a line of code that throws up a pep8 error as over the line character limit but its already condensed | 13:13 |
betherly | https://www.irccloud.com/pastebin/twL1yyQJ/ | 13:13 |
betherly | the maint_reason=maint_reason part throws it over | 13:13 |
betherly | did some research on it and looked like using parantheses around the .node_set_maintenance would allow me to put that also on a new line break but that still errored | 13:14 |
*** Mounica has joined #openstack-horizon | 13:15 | |
robcresswell | betherly: You don't have to wrap it right at the end like that XD | 13:16 |
*** JeanBriceCombebi has joined #openstack-horizon | 13:16 | |
openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: [WIP] Add test for network topology page https://review.openstack.org/276845 | 13:16 |
*** kmARC has joined #openstack-horizon | 13:16 | |
*** itisha has quit IRC | 13:16 | |
*** vgridnev has joined #openstack-horizon | 13:19 | |
betherly | robcresswell: what do you mean dont have to wrap it at the end? like put the (request ... on the line below? | 13:20 |
robcresswell | yeah :) | 13:20 |
*** Mounica has quit IRC | 13:20 | |
*** vgridnev has quit IRC | 13:21 | |
robcresswell | betherly: Something like http://paste.openstack.org/show/486549/ should work | 13:21 |
*** ducttape_ has quit IRC | 13:21 | |
betherly | thanks robcresswell | 13:22 |
betherly | :) | 13:22 |
*** e0ne has quit IRC | 13:24 | |
*** e0ne has joined #openstack-horizon | 13:25 | |
*** vgridnev has joined #openstack-horizon | 13:27 | |
*** yamamoto has joined #openstack-horizon | 13:29 | |
*** JeanBriceCombebi has quit IRC | 13:35 | |
*** JeanBriceCombebi has joined #openstack-horizon | 13:35 | |
*** JeanBriceCombebi has quit IRC | 13:36 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Change TestImageAdmin to test proper pages https://review.openstack.org/278365 | 13:39 |
*** permalac has quit IRC | 13:39 | |
*** akulshin has joined #openstack-horizon | 13:40 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Change TestImageAdmin to test proper pages https://review.openstack.org/278365 | 13:40 |
*** akulshin has quit IRC | 13:41 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Change TestImageAdmin to test proper pages https://review.openstack.org/278365 | 13:42 |
*** ygbo has joined #openstack-horizon | 13:43 | |
*** akulshin has joined #openstack-horizon | 13:45 | |
*** gokrokve has joined #openstack-horizon | 13:49 | |
*** matt-borland has joined #openstack-horizon | 13:52 | |
*** itxaka has quit IRC | 13:52 | |
*** gokrokve has quit IRC | 13:53 | |
*** piet has joined #openstack-horizon | 13:53 | |
*** itxaka has joined #openstack-horizon | 13:55 | |
*** lapalm has joined #openstack-horizon | 13:56 | |
*** peristeri has joined #openstack-horizon | 14:00 | |
*** jtriley has quit IRC | 14:02 | |
*** peristeri has quit IRC | 14:02 | |
*** akulshin has quit IRC | 14:04 | |
*** peristeri has joined #openstack-horizon | 14:04 | |
*** petertr7_away is now known as petertr7 | 14:06 | |
*** ducttape_ has joined #openstack-horizon | 14:08 | |
*** piet has quit IRC | 14:09 | |
*** jtriley has joined #openstack-horizon | 14:09 | |
*** piet has joined #openstack-horizon | 14:09 | |
*** Daisy has joined #openstack-horizon | 14:10 | |
*** mtanino has joined #openstack-horizon | 14:12 | |
*** omer_etrog has joined #openstack-horizon | 14:14 | |
openstackgerrit | Alexander Koryagin proposed openstack/horizon: Add test for modification of Public and Protected fields for NameSpace. https://review.openstack.org/271995 | 14:14 |
*** Daisy has quit IRC | 14:14 | |
*** julim has joined #openstack-horizon | 14:15 | |
*** neelashah has joined #openstack-horizon | 14:17 | |
*** omer_etrog has quit IRC | 14:18 | |
openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Test for images (create volume/launch instance from image) https://review.openstack.org/273467 | 14:20 |
*** ducttape_ has quit IRC | 14:20 | |
*** permalac has joined #openstack-horizon | 14:22 | |
*** jtriley has quit IRC | 14:22 | |
*** jpomeroy has joined #openstack-horizon | 14:25 | |
*** sid14726 has quit IRC | 14:25 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Add Magic Search client side filtering NG Images https://review.openstack.org/217437 | 14:26 |
*** masco has joined #openstack-horizon | 14:28 | |
*** lblanchard has joined #openstack-horizon | 14:28 | |
*** crobertsrh has left #openstack-horizon | 14:31 | |
*** matt-borland has quit IRC | 14:32 | |
*** matt-borland has joined #openstack-horizon | 14:32 | |
*** sudheer has quit IRC | 14:34 | |
*** sanjana has quit IRC | 14:34 | |
*** shu-mutou-AFK has quit IRC | 14:34 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 14:35 |
*** lblanchard has quit IRC | 14:39 | |
matt-borland | https://review.openstack.org/#/c/201582/ is ready for core review, has one +2. Gets use of MagicSearch into Launch Instance. | 14:46 |
*** gokrokve has joined #openstack-horizon | 14:50 | |
*** Daisy has joined #openstack-horizon | 14:53 | |
*** jtriley has joined #openstack-horizon | 14:53 | |
*** gariveradlt has joined #openstack-horizon | 14:54 | |
*** ygbo has quit IRC | 14:54 | |
openstackgerrit | Alexandra Allakhverdieva proposed openstack/horizon: Test for images (create volume/launch instance from image) https://review.openstack.org/273467 | 14:54 |
*** ygbo has joined #openstack-horizon | 14:54 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Image Detail Redesign (Angular/UX) https://review.openstack.org/173885 | 14:55 |
*** gokrokve has quit IRC | 14:56 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Add test for volumes attach/detach https://review.openstack.org/275231 | 14:57 |
*** gokrokve has joined #openstack-horizon | 14:58 | |
*** ducttape_ has joined #openstack-horizon | 14:58 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Fix bug at update quota of project's network item https://review.openstack.org/240493 | 15:00 |
*** matt-borland has quit IRC | 15:01 | |
*** masco has quit IRC | 15:01 | |
*** vkmc is now known as vkmc|midcycle | 15:01 | |
*** sjmc7 has joined #openstack-horizon | 15:04 | |
*** Daisy has quit IRC | 15:07 | |
*** vijendar has joined #openstack-horizon | 15:08 | |
*** esp has joined #openstack-horizon | 15:09 | |
*** vgridnev has quit IRC | 15:09 | |
*** vijendar has left #openstack-horizon | 15:09 | |
*** mtanino has quit IRC | 15:09 | |
*** vgridnev has joined #openstack-horizon | 15:10 | |
*** jsheeren has quit IRC | 15:12 | |
*** permalac has quit IRC | 15:13 | |
*** esp has quit IRC | 15:13 | |
*** vgridnev has quit IRC | 15:17 | |
*** gokrokve has quit IRC | 15:19 | |
*** lblanchard has joined #openstack-horizon | 15:22 | |
robcresswell | matt-borland: approved. | 15:22 |
*** haypo has left #openstack-horizon | 15:25 | |
*** Mounica has joined #openstack-horizon | 15:25 | |
*** omer_etrog has joined #openstack-horizon | 15:26 | |
*** aortega has quit IRC | 15:27 | |
*** omer_etrog has quit IRC | 15:27 | |
*** omer_etrog has joined #openstack-horizon | 15:28 | |
*** mvk has quit IRC | 15:29 | |
*** mvk has joined #openstack-horizon | 15:29 | |
*** mvk has quit IRC | 15:30 | |
*** mvk has joined #openstack-horizon | 15:31 | |
*** omer_etrog has quit IRC | 15:32 | |
*** rcernin has quit IRC | 15:33 | |
*** vgridnev has joined #openstack-horizon | 15:33 | |
*** matt-borland has joined #openstack-horizon | 15:33 | |
matt-borland | TravT, I just posted a simple WIP registry service: https://review.openstack.org/#/c/278447/ | 15:34 |
matt-borland | do you think I should put the Image registration code into that patch or a follow-on? | 15:34 |
*** e0ne has quit IRC | 15:34 | |
TravT | let me see | 15:34 |
matt-borland | might be easier in the short term to integrate them. | 15:34 |
TravT | i'd probably put them together to start | 15:35 |
TravT | or else nobody will understand it I think. | 15:35 |
*** e0ne has joined #openstack-horizon | 15:35 | |
*** omer_etrog has joined #openstack-horizon | 15:35 | |
*** yamamoto has quit IRC | 15:35 | |
matt-borland | yep :) | 15:36 |
matt-borland | sounds good, TravT | 15:36 |
*** gokrokve has joined #openstack-horizon | 15:43 | |
*** vgridnev has quit IRC | 15:45 | |
*** vgridnev has joined #openstack-horizon | 15:45 | |
*** gariveradlt has quit IRC | 15:46 | |
*** piet has quit IRC | 15:46 | |
*** gokrokve has quit IRC | 15:47 | |
*** omer_etrog has quit IRC | 15:49 | |
*** omer_etrog has joined #openstack-horizon | 15:50 | |
*** Daisy has joined #openstack-horizon | 15:50 | |
*** wolverineav has joined #openstack-horizon | 15:53 | |
*** omer_etrog has quit IRC | 15:54 | |
*** yamamoto has joined #openstack-horizon | 15:54 | |
*** Daisy has quit IRC | 15:55 | |
*** hurgleburgler has joined #openstack-horizon | 15:55 | |
*** mtanino has joined #openstack-horizon | 15:56 | |
*** piet has joined #openstack-horizon | 15:56 | |
piet | Morning | 15:56 |
*** wolverineav has quit IRC | 15:57 | |
*** sid14726 has joined #openstack-horizon | 16:01 | |
*** rcernin has joined #openstack-horizon | 16:01 | |
*** esp has joined #openstack-horizon | 16:04 | |
*** gokrokve has joined #openstack-horizon | 16:04 | |
*** kmartin has joined #openstack-horizon | 16:05 | |
*** jtriley has quit IRC | 16:11 | |
*** esp has quit IRC | 16:11 | |
*** Drago has joined #openstack-horizon | 16:11 | |
*** Drago1 has joined #openstack-horizon | 16:12 | |
*** Drago1 has quit IRC | 16:13 | |
*** Drago1 has joined #openstack-horizon | 16:13 | |
*** gariveradlt has joined #openstack-horizon | 16:13 | |
*** jtriley has joined #openstack-horizon | 16:15 | |
*** rudolfvriend has quit IRC | 16:15 | |
*** Drago has quit IRC | 16:15 | |
*** garthb has joined #openstack-horizon | 16:17 | |
*** esp has joined #openstack-horizon | 16:17 | |
*** cbader has quit IRC | 16:22 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add button to Create new Flavor https://review.openstack.org/234875 | 16:24 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular flavors panel Edit Subflow https://review.openstack.org/234874 | 16:24 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add Multiple and Single delete actions for the flavors panel https://review.openstack.org/234873 | 16:24 |
openstackgerrit | Rajat Vig proposed openstack/horizon: API Services for Flavors Panel https://review.openstack.org/214896 | 16:24 |
*** rcernin has quit IRC | 16:24 | |
*** esp has quit IRC | 16:24 | |
*** mpavlase has quit IRC | 16:33 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: Hypervisors Panel: REST API for Enable/Disable Compute Host https://review.openstack.org/240610 | 16:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Hypervisors Panel: UI for Enable/Disable Compute Host https://review.openstack.org/241845 | 16:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Hypervisors Panel: REST API for Summary Table https://review.openstack.org/237270 | 16:34 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Hypervisors Panel: UI for Summary Table https://review.openstack.org/237271 | 16:34 |
*** Ephur has joined #openstack-horizon | 16:35 | |
*** vgridnev has quit IRC | 16:36 | |
*** SimonChung1 has quit IRC | 16:39 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: API for getting and updating quotas https://review.openstack.org/207126 | 16:40 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel subflows for admin https://review.openstack.org/234986 | 16:40 |
openstackgerrit | Rajat Vig proposed openstack/horizon: Add angular defaults panel for admin https://review.openstack.org/205296 | 16:40 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 16:40 |
*** doug-fish has quit IRC | 16:40 | |
*** belmoreira has quit IRC | 16:41 | |
*** doug-fish has joined #openstack-horizon | 16:41 | |
*** bpokorny has joined #openstack-horizon | 16:41 | |
*** jtomasek_ has quit IRC | 16:42 | |
openstackgerrit | Rajat Vig proposed openstack/horizon: WIP : Angular panel for Metadata Definitions https://review.openstack.org/216141 | 16:44 |
*** jtriley has quit IRC | 16:44 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 16:45 |
openstackgerrit | Itxaka Serrano Garcia proposed openstack/horizon: Net topology: Show console link only when useful https://review.openstack.org/278311 | 16:45 |
*** doug-fish has quit IRC | 16:45 | |
*** jbell8 has quit IRC | 16:46 | |
*** jbell8 has joined #openstack-horizon | 16:47 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port more tests to Python 3 https://review.openstack.org/278505 | 16:48 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 16:49 |
*** vijendar has joined #openstack-horizon | 16:50 | |
*** aortega has joined #openstack-horizon | 16:51 | |
*** doug-fish has joined #openstack-horizon | 16:51 | |
ducttape_ | tsufiev- I was just reviewing that change ;) | 16:54 |
ducttape_ | I lost my vote button :'( | 16:54 |
ducttape_ | hurgleburgler, lots of comments, but for the most part it looks good | 16:55 |
*** gyee has joined #openstack-horizon | 16:55 | |
ducttape_ | I think its just minor cleanup stuff | 16:55 |
tsufiev | ducttape_, sorry, we must have been discussed this change with hurgleburgler in public | 16:55 |
tsufiev | I helped with writing i9n test for it | 16:56 |
ducttape_ | no worries :D | 16:56 |
ducttape_ | I think patch 11 to 12 was not too big of a change, for my comments / concerns | 16:56 |
*** doug-fish has quit IRC | 16:57 | |
* ducttape_ needs to pay attention better too | 16:57 | |
tsufiev | hurgleburgler, you have redefined the border possible/impossible with that patch for me :) | 16:58 |
hurgleburgler | tsufiev ducttape_ ٩(͡๏̮͡๏)۶ | 16:59 |
*** gariveradlt has quit IRC | 17:00 | |
tsufiev | hurgleburgler: have you ever used WinAmp? | 17:06 |
hurgleburgler | Not for years and years | 17:07 |
*** e0ne has quit IRC | 17:08 | |
*** sid14726 has quit IRC | 17:09 | |
tsufiev | I recalled its 'skins' feature once looked at theme picker | 17:09 |
*** jtriley has joined #openstack-horizon | 17:12 | |
*** itxaka has quit IRC | 17:14 | |
*** ygbo has quit IRC | 17:15 | |
*** vgridnev has joined #openstack-horizon | 17:15 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 17:16 |
*** amotoki has joined #openstack-horizon | 17:16 | |
*** amotoki has quit IRC | 17:16 | |
matt-borland | TravT, https://review.openstack.org/#/c/278447/ now eliminates the unneeded batch- and row- action services. | 17:17 |
hurgleburgler | Horizon Skins … it whips the Llamas *** | 17:17 |
hurgleburgler | hehehehe | 17:17 |
*** pushkaru has joined #openstack-horizon | 17:18 | |
matt-borland | and implements the use of the row and batch actions in Images using the registry | 17:18 |
*** ygbo has joined #openstack-horizon | 17:18 | |
robcresswell | hurgleburgler: Big patch | 17:20 |
robcresswell | Just starting to look at it :) | 17:20 |
*** dan_nguyen has joined #openstack-horizon | 17:21 | |
robcresswell | hurgleburgler: At some point we should probably fix the requirement on _variable and _styles. You shouldnt really need both :p | 17:22 |
hurgleburgler | well ….. i think we might | 17:22 |
hurgleburgler | since _variables comes first in the overrides | 17:23 |
hurgleburgler | and _styles come last | 17:23 |
*** haypo has joined #openstack-horizon | 17:23 | |
openstackgerrit | Victor Stinner proposed openstack/horizon: Port last unit tests to Python 3 https://review.openstack.org/278505 | 17:23 |
robcresswell | Realistically couldn't someone make a theme just by listing out a few new styles though? | 17:23 |
haypo | rdopiera, robcresswell, r1chardj0n3s & cie ^^ enjoy, i ported all unit tests to py3 ;-) https://review.openstack.org/278505 | 17:23 |
robcresswell | wait, a few new variables overrides I mean | 17:23 |
robcresswell | haypo: All of them?? | 17:24 |
haypo | robcresswell: all _unit_ tests, yep | 17:24 |
robcresswell | Awesome work! | 17:24 |
*** vijendar has quit IRC | 17:24 | |
haypo | robcresswell: see change on tox.ini, it removes the whitelist, because *all* unit tests now pass on py3 | 17:24 |
haypo | robcresswell: next step: port _integration_ tests ;) | 17:24 |
hurgleburgler | But, I think we can make it so they aren't REQUIRED, but it will use them | 17:24 |
haypo | at least, tox -e pep8,py27,py34 pass locally. i didn't expect that. i removed .tox/ and rechecked, just to be sure :) | 17:25 |
robcresswell | :o it works | 17:26 |
rdopiera | haypo: noooooooooooooo! | 17:27 |
*** ygbo has quit IRC | 17:27 | |
haypo | ok, tomorrow i will propose a patch to drop py2 support :D | 17:28 |
haypo | (just kidding, i have to fix integration tests first) | 17:28 |
robcresswell | hurgleburgler: This is really cool. | 17:28 |
*** doug-fish has joined #openstack-horizon | 17:29 | |
hurgleburgler | \o/ | 17:31 |
robcresswell | I got a few comments, but just reading more | 17:31 |
*** vijendar has joined #openstack-horizon | 17:32 | |
robcresswell | hurgleburgler: So a few things on the design. Would every theme have 'themes/' prepended, or does it take absolute paths too? Also do we need a separate slug value? I understand the human-readable name, but it seems like the slug could be shared with the themes/<slug> bit. Less to configure | 17:33 |
robcresswell | hurgleburgler: Also Material throws a console error: Could not load 'GET <URL>/-' | 17:34 |
robcresswell | where URL si the current page :) | 17:34 |
*** SimonChung has joined #openstack-horizon | 17:36 | |
*** piet has quit IRC | 17:36 | |
*** lhcheng has joined #openstack-horizon | 17:37 | |
*** tqtran has joined #openstack-horizon | 17:37 | |
hurgleburgler | Yeah, that console error is due to the fact that we have to short circuit the bootswatch font load for the packagers | 17:38 |
hurgleburgler | ITs always been there, but it was being hidden by the scss compilation before | 17:38 |
hurgleburgler | I'm thinking that I can just create a dummy file at '-' to get rid of the error | 17:38 |
robcresswell | Yeah I noticed it before, but now that its in the browser rather than logs, its a little more prominent | 17:38 |
*** ducttape_ has quit IRC | 17:39 | |
*** ducttape_ has joined #openstack-horizon | 17:39 | |
hurgleburgler | yeah, I can fix that :) | 17:39 |
robcresswell | ta | 17:40 |
*** fedexo has joined #openstack-horizon | 17:40 | |
*** fedexo_ has joined #openstack-horizon | 17:41 | |
robcresswell | ducttape_: "either escape this or don't. there is no try / todo" Best comment. | 17:42 |
robcresswell | I feel like I should point this out because I only recently discovered it, but you can use '[' and ']' to page through gerrit patches. | 17:42 |
ducttape_ | there is no try, indeed | 17:44 |
*** kzaitsev_mb has quit IRC | 17:45 | |
*** jtomasek has joined #openstack-horizon | 17:48 | |
*** SimonChung has quit IRC | 17:49 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 17:50 |
*** rcernin has joined #openstack-horizon | 17:52 | |
matt-borland | TravT, I think I'm done with the coding of the registration patch. I'll add docs once the names/input settles. | 17:54 |
TravT | okay, cool | 17:54 |
matt-borland | should I rebase some of the Images actions patches on that? | 17:54 |
*** petertr7 is now known as petertr7_away | 17:54 | |
matt-borland | e.g. https://review.openstack.org/#/c/217964/ ? | 17:54 |
*** itisha has joined #openstack-horizon | 17:55 | |
*** sid14726 has joined #openstack-horizon | 17:55 | |
matt-borland | that patch is +174/-280, and that's just with Images actions :) | 17:56 |
*** mvk has quit IRC | 17:59 | |
*** SimonChung has joined #openstack-horizon | 18:00 | |
*** vijendar has quit IRC | 18:05 | |
*** vijendar has joined #openstack-horizon | 18:06 | |
robcresswell | matt-borland: Question; why do we have simple-modal and angular-bootstraps modal? | 18:07 |
matt-borland | hm, I'll have to revisit that (didn't write that), I'll let you know robcresswell | 18:08 |
robcresswell | matt-borland: Oh, no worries its not urgent so don't waste time on it. Just wondering if you knew. | 18:09 |
robcresswell | Just seems odd that we have a lib to do something, but then we have our own service too...? | 18:09 |
matt-borland | not offhand :) | 18:09 |
*** jpomeroy has quit IRC | 18:15 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Adding resource type registry service https://review.openstack.org/278447 | 18:18 |
*** yamamoto has quit IRC | 18:19 | |
*** e0ne has joined #openstack-horizon | 18:20 | |
*** cbader has joined #openstack-horizon | 18:23 | |
*** wolverineav has joined #openstack-horizon | 18:23 | |
robcresswell | matt-borland: http://imgur.com/a/kpuNa | 18:24 |
robcresswell | im in ur angular codez, fixing ur bootstrapz | 18:24 |
robcresswell | :) | 18:24 |
matt-borland | thanks rob! :) | 18:24 |
matt-borland | that search icon has been a problem | 18:25 |
matt-borland | it all looks much better, robcresswell | 18:25 |
matt-borland | FYI, that patch I've been working on this morning basically makes all of our actions componentized so they can be easily reused in other areas, and also so they can be dynamically added to | 18:26 |
matt-borland | as opposed to having hard-coded lists in custom JS files (batch-action...js) | 18:26 |
matt-borland | this lines us of for consuming/exposing those actions in Searchlight, etc. | 18:27 |
robcresswell | ahhh I see | 18:27 |
matt-borland | also takes up a lot less code/testing/opportunities for problems | 18:27 |
robcresswell | Sounds good | 18:27 |
matt-borland | makes the actions much simpler overall :) | 18:28 |
*** matt-borland has quit IRC | 18:32 | |
*** matt-borland has joined #openstack-horizon | 18:32 | |
*** sjmc7 has quit IRC | 18:34 | |
*** jpomeroy has joined #openstack-horizon | 18:35 | |
*** vijendar has quit IRC | 18:35 | |
matt-borland | jpomeroy, how are things going with LBaaS dev? do you need some more reviews? | 18:37 |
matt-borland | also, are there more patches that you plan that aren't up there now? thanks! | 18:38 |
jpomeroy | matt-borland, i think right now the big one is this: https://review.openstack.org/266610 | 18:39 |
jpomeroy | it requires barbican | 18:39 |
matt-borland | yeah...hm | 18:39 |
matt-borland | That might set me back a bit | 18:39 |
jpomeroy | there will be more. we are working on actions like edit and delete for all the resources now. | 18:39 |
matt-borland | OK, cool. | 18:40 |
matt-borland | is your expectation that this is all done within the Mitaka timeline? | 18:40 |
matt-borland | I may have trouble with the Barbican right off the bat, but can help with other patches. | 18:41 |
jpomeroy | mitaka is the goal for everything right now. i imagine there could be some additional items we don't get to until newton but nothing definite. | 18:42 |
*** vijendar has joined #openstack-horizon | 18:43 | |
jpomeroy | your eyes on the code itself would be good, even if you don't get it running. | 18:43 |
jpomeroy | i know doug-fish is working on getting it running right now | 18:43 |
*** gariveradlt has joined #openstack-horizon | 18:45 | |
jpomeroy | i'll probably make that smaller WIP decode filter patch ready pretty soon here | 18:45 |
*** cbader_ has joined #openstack-horizon | 18:46 | |
*** sid14726 has quit IRC | 18:49 | |
*** Drago1 has quit IRC | 18:49 | |
*** Drago has joined #openstack-horizon | 18:50 | |
*** neelashah has quit IRC | 18:50 | |
*** cbader has quit IRC | 18:50 | |
*** yamamoto has joined #openstack-horizon | 18:50 | |
*** petertr7_away is now known as petertr7 | 18:52 | |
*** wolverineav has quit IRC | 18:57 | |
*** jpomeroy has quit IRC | 18:58 | |
*** TravT_ has joined #openstack-horizon | 18:58 | |
*** bpokorny_ has joined #openstack-horizon | 18:59 | |
*** bpokorny_ has quit IRC | 18:59 | |
*** bpokorny_ has joined #openstack-horizon | 19:00 | |
*** TravT has quit IRC | 19:00 | |
*** jpomeroy has joined #openstack-horizon | 19:01 | |
*** petertr7 is now known as petertr7_away | 19:01 | |
*** doug-fis_ has joined #openstack-horizon | 19:02 | |
*** bpokorny has quit IRC | 19:02 | |
*** sjmc7 has joined #openstack-horizon | 19:03 | |
*** doug-fi__ has joined #openstack-horizon | 19:04 | |
*** doug-fish has quit IRC | 19:05 | |
*** doug-fis_ has quit IRC | 19:06 | |
*** jtriley has quit IRC | 19:08 | |
*** doug-fi__ has quit IRC | 19:09 | |
openstackgerrit | Travis Tripp proposed openstack/horizon: Add Magic Search client side filtering NG Images https://review.openstack.org/217437 | 19:10 |
*** neelashah has joined #openstack-horizon | 19:10 | |
*** wolverineav has joined #openstack-horizon | 19:15 | |
TravT_ | robcresswell: if you have a minute can you look at this patch? https://review.openstack.org/#/c/277645 | 19:16 |
*** TravT_ is now known as TravT | 19:16 | |
*** fedexo_ has quit IRC | 19:17 | |
*** fedexo has quit IRC | 19:17 | |
*** bpokorny_ has quit IRC | 19:17 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Match python/ angular table styles https://review.openstack.org/246625 | 19:17 |
*** bpokorny has joined #openstack-horizon | 19:18 | |
robcresswell | TravT: Looking | 19:18 |
*** jprovazn has quit IRC | 19:20 | |
* TravT lunchtime... | 19:21 | |
*** petertr7_away is now known as petertr7 | 19:28 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Adding multiple row actions for the Image table https://review.openstack.org/217964 | 19:29 |
*** SimonChung has quit IRC | 19:30 | |
*** ankurgupta has quit IRC | 19:33 | |
openstackgerrit | David Lyle proposed openstack/horizon: Support update volume type public status https://review.openstack.org/235069 | 19:34 |
*** neelashah1 has joined #openstack-horizon | 19:34 | |
*** neelashah has quit IRC | 19:35 | |
*** rdopiera has quit IRC | 19:37 | |
*** sid14726 has joined #openstack-horizon | 19:38 | |
*** SimonChung has joined #openstack-horizon | 19:41 | |
*** jtriley has joined #openstack-horizon | 19:41 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Renaming hzTable to hzTableHelper https://review.openstack.org/278581 | 19:43 |
*** doug-fish has joined #openstack-horizon | 19:43 | |
*** jbell8 has quit IRC | 19:43 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: WIP Renaming hzTable to hzTableHelper https://review.openstack.org/278581 | 19:44 |
*** jbell8 has joined #openstack-horizon | 19:45 | |
*** jtriley has quit IRC | 19:46 | |
matt-borland | TravT, I fixed the metadata action in https://review.openstack.org/#/c/217964/ . | 19:46 |
*** krotscheck is now known as krotscheck_dcm | 19:47 | |
*** lapalm_ has joined #openstack-horizon | 19:47 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: Renaming hzTable to hzTableHelper https://review.openstack.org/278581 | 19:48 |
*** lapalm__ has joined #openstack-horizon | 19:50 | |
*** lapalm has quit IRC | 19:51 | |
*** lapalm_ has quit IRC | 19:52 | |
openstackgerrit | Merged openstack/horizon: Don't overwrite original traceback in certain cases of i9n failures https://review.openstack.org/277755 | 19:52 |
openstackgerrit | Merged openstack/horizon: Allow @tables.bind_row_action() to bind in 2 additional scenarios https://review.openstack.org/271805 | 19:55 |
*** doug-fish has quit IRC | 19:55 | |
r1chardj0n3s | morning | 19:55 |
*** jbell8 has quit IRC | 19:55 | |
*** jtriley has joined #openstack-horizon | 19:56 | |
*** jbell8 has joined #openstack-horizon | 19:56 | |
r1chardj0n3s | haypo: \o/ | 19:56 |
tqtran | anyone know how to make a word bold in doc rst? | 19:57 |
tqtran | *make a word appear bold | 19:57 |
tsufiev | r1chardj0n3s, morning! | 19:57 |
r1chardj0n3s | **bold** | 19:57 |
tqtran | nice, thanks | 19:57 |
tsufiev | r1chardj0n3s, could you please rebase your patch for integration_tests/horizon_local.conf? I´d love to see it merged :) | 19:58 |
r1chardj0n3s | tsufiev: yup, will do | 19:59 |
tsufiev | nice! | 19:59 |
*** tosky has quit IRC | 19:59 | |
robcresswell | ohoh meeting | 19:59 |
robcresswell | in 30 secs | 19:59 |
r1chardj0n3s | yep | 19:59 |
*** jbell8 has quit IRC | 19:59 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Re-enable keypairs integration test https://review.openstack.org/276820 | 19:59 |
*** jbell8 has joined #openstack-horizon | 20:00 | |
r1chardj0n3s | Horizon meeting in #openstack-meeting-3 starting now | 20:01 |
*** doug-fish has joined #openstack-horizon | 20:02 | |
openstackgerrit | Richard Jones proposed openstack/horizon: Add configuration mechanism to turn off browser maximisation https://review.openstack.org/274996 | 20:05 |
r1chardj0n3s | tsufiev: ^^ | 20:07 |
tsufiev | \o/ | 20:08 |
tsufiev | will +2 once jobs pass | 20:08 |
*** jtomasek has quit IRC | 20:10 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Tutorial for extending a workflow https://review.openstack.org/244407 | 20:15 |
*** doug-fish has quit IRC | 20:18 | |
*** doug-fish has joined #openstack-horizon | 20:20 | |
*** tyr_ has joined #openstack-horizon | 20:20 | |
*** Mounica has quit IRC | 20:23 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Do not make unnecessary calls to Nova from FIPs and Volumes tabs https://review.openstack.org/213260 | 20:25 |
*** piet has joined #openstack-horizon | 20:26 | |
*** Mounica has joined #openstack-horizon | 20:26 | |
*** SimonChung has quit IRC | 20:30 | |
*** SimonChung1 has joined #openstack-horizon | 20:30 | |
*** SimonChung has joined #openstack-horizon | 20:30 | |
*** SimonChung1 has quit IRC | 20:30 | |
*** SimonChung1 has joined #openstack-horizon | 20:31 | |
*** SimonChung has quit IRC | 20:31 | |
*** e0ne has quit IRC | 20:32 | |
*** SimonChung1 has quit IRC | 20:36 | |
*** sid14726 has quit IRC | 20:37 | |
*** SimonChung has joined #openstack-horizon | 20:39 | |
*** gokrokve has quit IRC | 20:40 | |
*** SimonChung1 has joined #openstack-horizon | 20:40 | |
*** SimonChung has quit IRC | 20:40 | |
*** flwang1 has joined #openstack-horizon | 20:40 | |
*** SimonChung1 has quit IRC | 20:40 | |
*** SimonChung has joined #openstack-horizon | 20:41 | |
*** kzaitsev_mb has joined #openstack-horizon | 20:42 | |
*** SimonChung has quit IRC | 20:42 | |
*** SimonChung1 has joined #openstack-horizon | 20:42 | |
*** petertr7 is now known as petertr7_away | 20:42 | |
*** alexpilotti_ has joined #openstack-horizon | 20:44 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 20:48 |
*** gariveradlt has quit IRC | 20:51 | |
*** gariveradlt has joined #openstack-horizon | 20:52 | |
*** e0ne has joined #openstack-horizon | 20:53 | |
*** petertr7_away is now known as petertr7 | 20:53 | |
*** jbell8 has quit IRC | 20:54 | |
*** Mounica has quit IRC | 20:54 | |
*** jbell8 has joined #openstack-horizon | 20:54 | |
*** SimonChung has joined #openstack-horizon | 20:56 | |
*** SimonChung1 has quit IRC | 20:56 | |
*** matt-borland has left #openstack-horizon | 21:00 | |
*** wolverin_ has joined #openstack-horizon | 21:00 | |
*** matt-borland has joined #openstack-horizon | 21:01 | |
robcresswell | TravT: Genuinely burst out laughing at the spinner remark. | 21:01 |
*** wolverin_ has quit IRC | 21:01 | |
*** wolverin_ has joined #openstack-horizon | 21:01 | |
mrunge | david-lyle, I would revisit https://review.openstack.org/#/c/272644/ tomorrow and fix current issues with that | 21:01 |
robcresswell | Can someone bump this btw? Its super minor, just fixes the padding issue around the tables on master https://review.openstack.org/#/c/277439/ | 21:01 |
TravT | robcresswell: hehe | 21:02 |
david-lyle | mrunge: sounds good | 21:02 |
* robcresswell must resist buying XCOM. | 21:02 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 21:03 |
*** wolverin_ has quit IRC | 21:04 | |
*** wolverineav has quit IRC | 21:04 | |
*** sinese_ has quit IRC | 21:04 | |
*** wolverineav has joined #openstack-horizon | 21:05 | |
betherly | robcresswell: done | 21:06 |
*** wolverineav has quit IRC | 21:07 | |
*** ybathia has joined #openstack-horizon | 21:07 | |
*** SimonChung has quit IRC | 21:07 | |
*** SimonChung has joined #openstack-horizon | 21:07 | |
*** wolverineav has joined #openstack-horizon | 21:08 | |
*** e0ne has quit IRC | 21:09 | |
*** mvandijk has left #openstack-horizon | 21:13 | |
openstackgerrit | Merged openstack/django_openstack_auth: Add app_label https://review.openstack.org/277359 | 21:19 |
*** alexpilotti_ has quit IRC | 21:19 | |
tqtran | TravT, r1chardj0n3s: hey guys, need your opinion on something | 21:25 |
tqtran | so we current use hz-table to supplement things that st-table is missing | 21:25 |
tqtran | things like check all boxes | 21:25 |
tqtran | clu is working on an hz-table directive that will create a table for you given data and columns | 21:25 |
tqtran | would it be alright for her to rename the current hz-table to something else and reuse that for her directive? | 21:26 |
TravT | hmm... that's a big question... | 21:27 |
TravT | there are already plugins out there using it | 21:27 |
TravT | if they were done in this cycle | 21:28 |
TravT | then maybe they can change | 21:28 |
TravT | sounds like a great directive | 21:28 |
*** vijendar has quit IRC | 21:30 | |
*** pushkaru has quit IRC | 21:30 | |
jpomeroy | matt-borland, this one is fairly simple https://review.openstack.org/275821 | 21:32 |
matt-borland | nice, I'll get to it later today or tomorrow morning | 21:32 |
*** ZZelle_ has joined #openstack-horizon | 21:33 | |
*** ZZelle_ has quit IRC | 21:33 | |
*** ZZelle_ has joined #openstack-horizon | 21:33 | |
*** vijendar has joined #openstack-horizon | 21:34 | |
*** Mounica has joined #openstack-horizon | 21:35 | |
r1chardj0n3s | tqtran: heh, so I'm using hz-table myself and don't have an issue with rename from that perspective. TravT's concern about plugins is quite valid. | 21:36 |
tqtran | yeah, theres quite a few plugins using it | 21:37 |
r1chardj0n3s | so is clu's hz-table completely incompatible with current hz-table, or could the two feature sets be mostly merged? | 21:37 |
*** ybathia_ has joined #openstack-horizon | 21:39 | |
*** al_indigo has joined #openstack-horizon | 21:39 | |
*** clu_ has joined #openstack-horizon | 21:39 | |
*** ducttape_ has quit IRC | 21:39 | |
*** wolverin_ has joined #openstack-horizon | 21:39 | |
*** clu__ has joined #openstack-horizon | 21:40 | |
*** clu_ has quit IRC | 21:40 | |
*** cbader_2 has joined #openstack-horizon | 21:40 | |
*** pai15- has joined #openstack-horizon | 21:40 | |
*** erlon_ has joined #openstack-horizon | 21:41 | |
*** kzaitsev_mb has quit IRC | 21:41 | |
*** tqtran_ has joined #openstack-horizon | 21:41 | |
tqtran_ | sorry about that, apparently i got dc without knowing it | 21:42 |
clu__ | hi tqtran_ | 21:42 |
tqtran_ | could you explain why hz-table features could not merge into one? | 21:42 |
r1chardj0n3s | I'll repeat my question just in case and for clu__ :-) "so is clu's hz-table completely incompatible with current hz-table, or could the two feature sets be mostly merged?" | 21:42 |
tqtran_ | the reason is that a few of the plugins have started to use hz-table, so renaming it could break their stuff | 21:43 |
clu__ | oh, that's fine then, we don't need to rename | 21:43 |
tqtran_ | but can we merge the new features into hz-table? i forgot why we couldnt | 21:44 |
clu__ | if a user choses to write the HTML themselves | 21:44 |
clu__ | then we don't want to overload the directive | 21:45 |
tqtran_ | but werent you checking for items and config attribute? | 21:45 |
tqtran_ | if those dont exist, then dont overload | 21:45 |
tqtran_ | btw, heres the patch https://review.openstack.org/#/c/252014/ | 21:46 |
tqtran_ | so we're all on the same page | 21:46 |
openstackgerrit | Mark Vanderwiel proposed openstack/horizon: Add trace to integration gate scripts https://review.openstack.org/273270 | 21:46 |
*** HenryG_ has joined #openstack-horizon | 21:47 | |
*** kzaitsev_mb has joined #openstack-horizon | 21:47 | |
clu__ | yea, we could combine | 21:47 |
*** cbader_2 has quit IRC | 21:48 | |
tqtran_ | are you sure? i thought you ran into issues? | 21:48 |
*** cbader has joined #openstack-horizon | 21:48 | |
*** wolverineav has quit IRC | 21:48 | |
*** ybathia has quit IRC | 21:48 | |
*** cbader_ has quit IRC | 21:48 | |
*** tqtran has quit IRC | 21:48 | |
*** erlon has quit IRC | 21:48 | |
*** jrist has quit IRC | 21:48 | |
*** pai15 has quit IRC | 21:48 | |
*** zhenguo_ has quit IRC | 21:48 | |
*** al_indig_ has quit IRC | 21:48 | |
*** betherly has quit IRC | 21:48 | |
*** HenryG has quit IRC | 21:48 | |
*** dhellmann has quit IRC | 21:48 | |
*** ramishra has quit IRC | 21:48 | |
*** mariusv has quit IRC | 21:48 | |
*** HenryG_ is now known as HenryG | 21:48 | |
*** ybathia_ is now known as ybathia | 21:48 | |
openstackgerrit | Thai Tran proposed openstack/horizon: Panel static finder https://review.openstack.org/246683 | 21:48 |
clu__ | yea i did, because of the hzTable + stTable dependencies | 21:48 |
*** dhellmann has joined #openstack-horizon | 21:49 | |
tqtran_ | so would having something like hz-table-generator be ok? | 21:49 |
*** erlon_ is now known as erlon | 21:49 | |
tqtran_ | or.... you can just change the name and go to the different repos and propose a fix | 21:50 |
david-lyle | retasking an existing name is problematic | 21:50 |
clu__ | yea, hz-table-generator is a good name | 21:50 |
david-lyle | IMO | 21:50 |
tqtran_ | damn, we're stuck then? :( | 21:50 |
clu__ | yea, i guess we'll just leave hz-table as is even tho it's not the most descriptive | 21:50 |
*** wolverin_ is now known as wolverineav | 21:51 | |
tqtran_ | sounds good, thanks for input dave | 21:52 |
*** HenryG has quit IRC | 21:52 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/278665 | 21:52 |
*** kzaitsev_mb has quit IRC | 21:53 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/275486 | 21:53 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/manila-ui: Updated from global requirements https://review.openstack.org/278683 | 21:54 |
*** jrist has joined #openstack-horizon | 21:54 | |
*** gariveradlt has quit IRC | 21:55 | |
*** xinwu has joined #openstack-horizon | 21:55 | |
*** HenryG has joined #openstack-horizon | 21:56 | |
*** ramishra has joined #openstack-horizon | 21:56 | |
wolverineav | hey everyone, i'm looking at the various horizon plugins as listed here: http://docs.openstack.org/developer/horizon/plugin_registry.html | 21:56 |
*** bpokorny has quit IRC | 21:56 | |
wolverineav | i'd like to add one similar to it for big switch networks. | 21:57 |
wolverineav | how do i go about creating a repo under github.com/openstack ? | 21:57 |
*** betherly has joined #openstack-horizon | 21:57 | |
*** vgridnev has quit IRC | 21:58 | |
wolverineav | i couldn't find a doc page specifying the instructions. | 21:58 |
tqtran_ | you have to submit a patch to create a repo in openstack/infra | 22:00 |
*** tqtran_ has quit IRC | 22:00 | |
*** tqtran_ has joined #openstack-horizon | 22:00 | |
*** zhenguo_ has joined #openstack-horizon | 22:00 | |
tqtran_ | omg having some serious connection issue | 22:01 |
tqtran_ | wolverineav: did someone answer your question yet? if not, here is the link to get started on creating a new repo | 22:01 |
tqtran_ | http://docs.openstack.org/infra/manual/creators.html | 22:01 |
tqtran_ | you'll have to submit a patch to infra for a new repo | 22:01 |
tqtran_ | mrunge, david-lyle: around? | 22:02 |
wolverineav | tqtran_ thanks for that link! | 22:02 |
tqtran_ | like to run this patch by you guys, had a brief discussion over it at the tokyo summit, https://review.openstack.org/#/c/246683/ | 22:02 |
david-lyle | tqtran_: looking | 22:04 |
*** lblanchard has quit IRC | 22:05 | |
tqtran_ | self.source_dir is 'static' | 22:06 |
tqtran_ | self.storage is the list of folders to collect from | 22:06 |
*** rcernin has quit IRC | 22:07 | |
*** jtriley has quit IRC | 22:07 | |
*** petertr7 is now known as petertr7_away | 22:08 | |
r1chardj0n3s | argh, my patch has been haypo'd :-) | 22:09 |
*** Guest15678 has joined #openstack-horizon | 22:10 | |
*** TravT has quit IRC | 22:10 | |
*** jbell8 has quit IRC | 22:12 | |
*** jbell8 has joined #openstack-horizon | 22:12 | |
*** julim has quit IRC | 22:16 | |
*** julim has joined #openstack-horizon | 22:17 | |
*** julim has quit IRC | 22:17 | |
*** petertr7z has joined #openstack-horizon | 22:18 | |
*** wolverineav has quit IRC | 22:18 | |
*** petertr7z is now known as petertr7 | 22:18 | |
*** wolverineav has joined #openstack-horizon | 22:21 | |
*** wolverineav has quit IRC | 22:21 | |
*** wolverineav has joined #openstack-horizon | 22:21 | |
*** chlong_ has joined #openstack-horizon | 22:22 | |
*** petertr7_away has quit IRC | 22:22 | |
*** dhellmann has quit IRC | 22:22 | |
*** chlong has quit IRC | 22:22 | |
*** dhellmann has joined #openstack-horizon | 22:23 | |
*** ducttape_ has joined #openstack-horizon | 22:27 | |
tqtran_ | can we get more folks to weigh in on this one? https://review.openstack.org/#/c/218538/ prototype vs ng approach for extending a native arrays object | 22:28 |
*** TravT has joined #openstack-horizon | 22:29 | |
*** lapalm__ has quit IRC | 22:31 | |
*** onovy has joined #openstack-horizon | 22:40 | |
*** lhcheng has quit IRC | 22:40 | |
onovy | hi guys. Can you look to this review pls? http://paste.openstack.org/show/486633/ it's same reviews in all xstatic projects. Same patch already merged in majority of OS projects. Thanks | 22:43 |
*** clu__ has quit IRC | 22:46 | |
*** clu__ has joined #openstack-horizon | 22:47 | |
*** neelashah1 has quit IRC | 22:47 | |
*** piet has quit IRC | 22:56 | |
*** doug-fish has quit IRC | 22:59 | |
*** doug-fish has joined #openstack-horizon | 23:00 | |
matt-borland | tqtran_, what is that value of that patch? | 23:03 |
*** doug-fish has quit IRC | 23:05 | |
*** lhcheng has joined #openstack-horizon | 23:06 | |
*** vijendar has quit IRC | 23:06 | |
*** matt-borland has quit IRC | 23:08 | |
*** doug-fis_ has joined #openstack-horizon | 23:08 | |
*** btully has quit IRC | 23:08 | |
*** doug-fis_ has quit IRC | 23:10 | |
*** doug-fis_ has joined #openstack-horizon | 23:11 | |
openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Magic Search in new Launch Instance https://review.openstack.org/201582 | 23:11 |
*** btully has joined #openstack-horizon | 23:11 | |
*** sid14726 has joined #openstack-horizon | 23:12 | |
openstackgerrit | Merged openstack/horizon: Adding Neutron extensions API https://review.openstack.org/273082 | 23:15 |
*** erlon has quit IRC | 23:16 | |
*** jpomeroy has quit IRC | 23:19 | |
*** ducttape_ has quit IRC | 23:24 | |
*** ZZelle_ has quit IRC | 23:29 | |
*** doug-fis_ has quit IRC | 23:33 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Dynamic Themes https://review.openstack.org/277220 | 23:34 |
*** peristeri has quit IRC | 23:34 | |
*** gariveradlt has joined #openstack-horizon | 23:40 | |
*** jtriley has joined #openstack-horizon | 23:44 | |
*** chlong_ has quit IRC | 23:46 | |
*** tyr_ has quit IRC | 23:50 | |
*** tyr_ has joined #openstack-horizon | 23:51 | |
openstackgerrit | German Rivera proposed openstack/horizon: adding-required-subnets-cidrs https://review.openstack.org/274222 | 23:51 |
openstackgerrit | German Rivera proposed openstack/horizon: adding-required-subnets-cidrs https://review.openstack.org/274222 | 23:52 |
*** tyr_ has quit IRC | 23:55 | |
*** bpokorny has joined #openstack-horizon | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!