*** piet has quit IRC | 00:03 | |
*** erlon has quit IRC | 00:06 | |
*** ducttape_ has quit IRC | 00:07 | |
*** ducttape_ has joined #openstack-horizon | 00:08 | |
*** piet has joined #openstack-horizon | 00:08 | |
*** ducttape_ has quit IRC | 00:09 | |
*** yingjun has joined #openstack-horizon | 00:11 | |
*** shangxdy has joined #openstack-horizon | 00:18 | |
*** shangxdy has quit IRC | 00:20 | |
*** shangxdy has joined #openstack-horizon | 00:20 | |
*** piet has quit IRC | 00:21 | |
*** shangxdy has quit IRC | 00:21 | |
*** shangxdy has joined #openstack-horizon | 00:21 | |
*** shangxdy has quit IRC | 00:22 | |
*** shangxdy has joined #openstack-horizon | 00:23 | |
*** shangxdy has quit IRC | 00:23 | |
*** shangxdy has joined #openstack-horizon | 00:24 | |
*** shangxdy has quit IRC | 00:25 | |
*** piet has joined #openstack-horizon | 00:25 | |
*** shangxdy has joined #openstack-horizon | 00:26 | |
*** shangxdy has quit IRC | 00:27 | |
*** shangxdy has joined #openstack-horizon | 00:28 | |
*** shangxdy has quit IRC | 00:28 | |
*** shangxdy has joined #openstack-horizon | 00:29 | |
*** shangxdy has quit IRC | 00:29 | |
*** shangxdy has joined #openstack-horizon | 00:30 | |
*** shangxdy has quit IRC | 00:31 | |
*** shangxdy has joined #openstack-horizon | 00:45 | |
*** shangxdy has quit IRC | 00:46 | |
*** shangxdy has joined #openstack-horizon | 00:46 | |
*** shangxdy has quit IRC | 00:47 | |
*** shangxdy has joined #openstack-horizon | 00:48 | |
*** shangxdy has quit IRC | 00:49 | |
*** shangxdy has joined #openstack-horizon | 00:49 | |
*** shangxdy has quit IRC | 00:50 | |
*** shangxdy has joined #openstack-horizon | 00:52 | |
*** shangxdy has quit IRC | 00:53 | |
*** shangxdy has joined #openstack-horizon | 00:53 | |
*** shangxdy has quit IRC | 00:54 | |
*** shangxdy has joined #openstack-horizon | 00:54 | |
*** shangxdy has quit IRC | 00:55 | |
*** shangxdy has joined #openstack-horizon | 00:56 | |
*** shangxdy has quit IRC | 00:57 | |
*** shangxdy has joined #openstack-horizon | 00:57 | |
*** shangxdy has quit IRC | 00:58 | |
*** shangxdy has joined #openstack-horizon | 00:59 | |
*** piet has quit IRC | 00:59 | |
*** piet has joined #openstack-horizon | 00:59 | |
*** shangxdy has quit IRC | 01:00 | |
*** shangxdy has joined #openstack-horizon | 01:00 | |
*** shangxdy has quit IRC | 01:02 | |
*** shangxdy has joined #openstack-horizon | 01:02 | |
*** shangxdy has quit IRC | 01:03 | |
*** shangxdy has joined #openstack-horizon | 01:03 | |
*** shangxdy has quit IRC | 01:05 | |
*** shangxdy has joined #openstack-horizon | 01:05 | |
*** shangxdy has quit IRC | 01:07 | |
*** jamielennox is now known as jamielennox|away | 01:09 | |
*** shangxdy has joined #openstack-horizon | 01:09 | |
*** shangxdy has quit IRC | 01:10 | |
*** shangxdy has joined #openstack-horizon | 01:11 | |
*** shangxdy has quit IRC | 01:11 | |
*** shangxdy has joined #openstack-horizon | 01:12 | |
*** shangxdy has quit IRC | 01:13 | |
*** shangxdy has joined #openstack-horizon | 01:13 | |
*** piet has quit IRC | 01:14 | |
*** piet has joined #openstack-horizon | 01:14 | |
*** shangxdy has quit IRC | 01:15 | |
*** shangxdy has joined #openstack-horizon | 01:17 | |
*** shangxdy has quit IRC | 01:18 | |
*** shangxdy has joined #openstack-horizon | 01:18 | |
*** shangxdy has quit IRC | 01:19 | |
*** shangxdy has joined #openstack-horizon | 01:20 | |
*** shangxdy has quit IRC | 01:20 | |
*** shangxdy has joined #openstack-horizon | 01:21 | |
*** shangxdy has quit IRC | 01:22 | |
*** zhurong has joined #openstack-horizon | 01:22 | |
*** shangxdy has joined #openstack-horizon | 01:22 | |
*** shangxdy has quit IRC | 01:23 | |
*** shangxdy has joined #openstack-horizon | 01:24 | |
*** shangxdy has quit IRC | 01:24 | |
*** shangxdy has joined #openstack-horizon | 01:25 | |
*** shangxdy has quit IRC | 01:26 | |
*** shangxdy has joined #openstack-horizon | 01:26 | |
*** shangxdy has quit IRC | 01:27 | |
*** shangxdy has joined #openstack-horizon | 01:28 | |
*** amotoki has quit IRC | 01:28 | |
*** shangxdy has quit IRC | 01:28 | |
*** shangxdy has joined #openstack-horizon | 01:29 | |
*** piet has quit IRC | 01:29 | |
*** shangxdy_ has joined #openstack-horizon | 01:30 | |
*** shangxdy_ has quit IRC | 01:31 | |
*** shangxdy_ has joined #openstack-horizon | 01:32 | |
*** shangxdy_ has quit IRC | 01:32 | |
*** shangxdy_ has joined #openstack-horizon | 01:33 | |
*** shangxdy_ has quit IRC | 01:33 | |
*** shangxdy_ has joined #openstack-horizon | 01:34 | |
*** shangxdy has quit IRC | 01:34 | |
*** shangxdy_ has quit IRC | 01:34 | |
*** ducttape_ has joined #openstack-horizon | 01:40 | |
*** jamielennox|away is now known as jamielennox | 01:43 | |
*** ducttape_ has quit IRC | 01:45 | |
*** amotoki has joined #openstack-horizon | 01:46 | |
*** amotoki has quit IRC | 01:51 | |
*** jamielennox is now known as jamielennox|away | 01:53 | |
*** Daisy has joined #openstack-horizon | 01:55 | |
*** amotoki has joined #openstack-horizon | 01:58 | |
*** shu-mutou has joined #openstack-horizon | 02:02 | |
*** amotoki has quit IRC | 02:03 | |
*** wangbo has quit IRC | 02:03 | |
*** wangbo has joined #openstack-horizon | 02:04 | |
*** Daisy has quit IRC | 02:06 | |
*** Daisy has joined #openstack-horizon | 02:06 | |
*** Daisy has quit IRC | 02:11 | |
*** asettle has joined #openstack-horizon | 02:13 | |
*** wangbo has quit IRC | 02:15 | |
*** wangbo has joined #openstack-horizon | 02:15 | |
*** btully has joined #openstack-horizon | 02:18 | |
*** asettle has quit IRC | 02:19 | |
*** btully has quit IRC | 02:23 | |
*** Daisy has joined #openstack-horizon | 02:27 | |
*** wangbo has quit IRC | 02:31 | |
*** akulshin has joined #openstack-horizon | 02:33 | |
*** amotoki has joined #openstack-horizon | 02:35 | |
*** akulshin has quit IRC | 02:37 | |
*** ducttape_ has joined #openstack-horizon | 02:42 | |
*** jamielennox|away is now known as jamielennox | 02:43 | |
*** kbaikov has quit IRC | 02:44 | |
*** kbaikov has joined #openstack-horizon | 02:44 | |
*** yingjun has quit IRC | 02:46 | |
*** yingjun has joined #openstack-horizon | 02:47 | |
*** ducttape_ has quit IRC | 02:48 | |
*** Daisy has quit IRC | 02:54 | |
*** Daisy has joined #openstack-horizon | 02:54 | |
*** Daisy_ has joined #openstack-horizon | 02:59 | |
*** wangbo has joined #openstack-horizon | 03:00 | |
*** Daisy has quit IRC | 03:03 | |
*** wangbo has quit IRC | 03:05 | |
*** rcernin has joined #openstack-horizon | 03:09 | |
*** piet_ has joined #openstack-horizon | 03:10 | |
*** roxanagh_ has joined #openstack-horizon | 03:11 | |
*** wangbo has joined #openstack-horizon | 03:22 | |
*** amotoki has quit IRC | 03:25 | |
*** piet_ has quit IRC | 03:26 | |
*** Daisy_ has quit IRC | 03:37 | |
*** Daisy has joined #openstack-horizon | 03:37 | |
*** akulshin has joined #openstack-horizon | 03:41 | |
*** Daisy has quit IRC | 03:42 | |
*** ducttape_ has joined #openstack-horizon | 03:44 | |
*** ducttape_ has quit IRC | 03:48 | |
*** M00nr41n has joined #openstack-horizon | 03:56 | |
*** akulshin has quit IRC | 04:00 | |
*** Daisy has joined #openstack-horizon | 04:06 | |
*** btully has joined #openstack-horizon | 04:07 | |
*** amotoki has joined #openstack-horizon | 04:10 | |
*** yingjun has quit IRC | 04:11 | |
*** btully has quit IRC | 04:11 | |
*** yingjun has joined #openstack-horizon | 04:11 | |
*** Daisy has quit IRC | 04:11 | |
*** btully has joined #openstack-horizon | 04:12 | |
*** yingjun has quit IRC | 04:16 | |
*** Daisy has joined #openstack-horizon | 04:18 | |
*** Daisy has quit IRC | 04:23 | |
*** Daisy has joined #openstack-horizon | 04:24 | |
*** roxanagh_ has quit IRC | 04:24 | |
*** zhurong has quit IRC | 04:26 | |
*** M00nr41n has quit IRC | 04:28 | |
*** Daisy has quit IRC | 04:29 | |
*** Daisy has joined #openstack-horizon | 04:30 | |
*** roxanagh_ has joined #openstack-horizon | 04:30 | |
*** Daisy has quit IRC | 04:35 | |
*** Daisy has joined #openstack-horizon | 04:35 | |
*** yingjun has joined #openstack-horizon | 04:39 | |
*** roxanagh_ has quit IRC | 04:40 | |
*** Daisy has quit IRC | 04:40 | |
*** roxanagh_ has joined #openstack-horizon | 04:43 | |
*** ratailor has joined #openstack-horizon | 04:44 | |
*** ducttape_ has joined #openstack-horizon | 04:44 | |
*** roxanagh_ has quit IRC | 04:47 | |
*** amotoki has quit IRC | 04:48 | |
*** ducttape_ has quit IRC | 04:49 | |
*** Daisy has joined #openstack-horizon | 05:00 | |
*** Daisy_ has joined #openstack-horizon | 05:02 | |
*** zhurong has joined #openstack-horizon | 05:03 | |
*** Daisy has quit IRC | 05:05 | |
*** wangbo has quit IRC | 05:08 | |
*** yingjun has quit IRC | 05:13 | |
*** yingjun has joined #openstack-horizon | 05:13 | |
*** yingjun has quit IRC | 05:18 | |
*** wangbo has joined #openstack-horizon | 05:20 | |
*** akulshin has joined #openstack-horizon | 05:23 | |
*** M00nr41n has joined #openstack-horizon | 05:24 | |
*** akulshin has quit IRC | 05:28 | |
*** pt_15 has quit IRC | 05:36 | |
*** amotoki has joined #openstack-horizon | 05:36 | |
*** yingjun has joined #openstack-horizon | 05:37 | |
*** yamamoto_ has joined #openstack-horizon | 05:38 | |
*** itisha has quit IRC | 05:40 | |
*** roxanagh_ has joined #openstack-horizon | 05:44 | |
*** Nikolay_St has joined #openstack-horizon | 05:45 | |
*** ducttape_ has joined #openstack-horizon | 05:45 | |
*** pt_15 has joined #openstack-horizon | 05:46 | |
*** itisha has joined #openstack-horizon | 05:47 | |
*** roxanagh_ has quit IRC | 05:48 | |
*** asettle has joined #openstack-horizon | 05:48 | |
*** ducttape_ has quit IRC | 05:50 | |
*** asettle has quit IRC | 05:54 | |
*** rcernin has quit IRC | 06:01 | |
*** amotoki has quit IRC | 06:02 | |
*** wangbo has quit IRC | 06:07 | |
*** akulshin has joined #openstack-horizon | 06:10 | |
*** mpavlase has joined #openstack-horizon | 06:11 | |
*** akulshin has quit IRC | 06:15 | |
*** Daisy_ has quit IRC | 06:18 | |
*** Daisy has joined #openstack-horizon | 06:18 | |
*** mpavlase has quit IRC | 06:21 | |
*** wangbo has joined #openstack-horizon | 06:21 | |
*** akulshin has joined #openstack-horizon | 06:21 | |
*** hogepodge has quit IRC | 06:25 | |
*** hogepodge has joined #openstack-horizon | 06:27 | |
*** masco has joined #openstack-horizon | 06:30 | |
*** amotoki has joined #openstack-horizon | 06:31 | |
*** rcernin has joined #openstack-horizon | 06:33 | |
*** wangbo has quit IRC | 06:34 | |
*** purva has joined #openstack-horizon | 06:36 | |
*** roxanagh_ has joined #openstack-horizon | 06:44 | |
*** pcaruana has joined #openstack-horizon | 06:46 | |
*** ducttape_ has joined #openstack-horizon | 06:46 | |
*** wangbo has joined #openstack-horizon | 06:47 | |
*** roxanagh_ has quit IRC | 06:49 | |
*** ducttape_ has quit IRC | 06:50 | |
openstackgerrit | zhurong proposed openstack/horizon: [TrivialFix]Use the right indent for MigrateHostView https://review.openstack.org/337464 | 06:52 |
---|---|---|
*** btully has quit IRC | 06:54 | |
*** kenji-i has joined #openstack-horizon | 06:55 | |
*** wangbo has quit IRC | 06:56 | |
*** amotoki has quit IRC | 07:01 | |
*** amotoki has joined #openstack-horizon | 07:04 | |
*** wangbo has joined #openstack-horizon | 07:08 | |
*** tesseract- has joined #openstack-horizon | 07:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/337484 | 07:12 |
*** vgridnev has quit IRC | 07:16 | |
*** rhagarty__ has quit IRC | 07:17 | |
*** rhagarty__ has joined #openstack-horizon | 07:18 | |
*** amotoki has quit IRC | 07:21 | |
*** vgridnev has joined #openstack-horizon | 07:22 | |
*** amotoki has joined #openstack-horizon | 07:36 | |
*** ducttape_ has joined #openstack-horizon | 07:47 | |
openstackgerrit | zhurong proposed openstack/horizon: [TrivialFix]Use the right indent for MigrateHostView https://review.openstack.org/337464 | 07:49 |
*** ducttape_ has quit IRC | 07:51 | |
openstackgerrit | yuki kasuya proposed openstack/horizon: Fix create container modal style https://review.openstack.org/336410 | 07:52 |
*** chlong has quit IRC | 07:52 | |
*** amotoki has quit IRC | 07:57 | |
*** chlong has joined #openstack-horizon | 08:04 | |
*** zhurong has quit IRC | 08:11 | |
*** ygbo has joined #openstack-horizon | 08:12 | |
*** shu-mutou has quit IRC | 08:16 | |
*** asettle has joined #openstack-horizon | 08:19 | |
*** roxanagh_ has joined #openstack-horizon | 08:33 | |
*** wolverineav has quit IRC | 08:36 | |
*** roxanagh_ has quit IRC | 08:37 | |
*** btully has joined #openstack-horizon | 08:38 | |
*** kenji-i has quit IRC | 08:42 | |
*** btully has quit IRC | 08:43 | |
*** amotoki has joined #openstack-horizon | 08:43 | |
*** Daisy has quit IRC | 08:44 | |
*** Daisy has joined #openstack-horizon | 08:44 | |
openstackgerrit | Sergei Chipiga proposed openstack/horizon: The integration test for the New Launch Instance wizard https://review.openstack.org/297277 | 08:45 |
*** ducttape_ has joined #openstack-horizon | 08:48 | |
*** ducttape_ has quit IRC | 08:52 | |
*** amotoki has quit IRC | 08:58 | |
*** asettle has quit IRC | 09:24 | |
*** asettle has joined #openstack-horizon | 09:24 | |
*** lcastell has quit IRC | 09:24 | |
*** lcastell has joined #openstack-horizon | 09:26 | |
*** asettle has quit IRC | 09:30 | |
*** yingjun has quit IRC | 09:32 | |
*** yingjun has joined #openstack-horizon | 09:32 | |
*** wolverineav has joined #openstack-horizon | 09:37 | |
*** yingjun has quit IRC | 09:37 | |
*** itxaka has joined #openstack-horizon | 09:38 | |
*** asettle has joined #openstack-horizon | 09:41 | |
*** wolverineav has quit IRC | 09:41 | |
*** yingjun has joined #openstack-horizon | 09:45 | |
*** yingjun has quit IRC | 09:48 | |
*** ducttape_ has joined #openstack-horizon | 09:48 | |
*** ducttape_ has quit IRC | 09:53 | |
*** itxaka has quit IRC | 10:02 | |
*** lcastell has quit IRC | 10:15 | |
*** lcastell has joined #openstack-horizon | 10:18 | |
*** itxaka has joined #openstack-horizon | 10:19 | |
*** roxanagh_ has joined #openstack-horizon | 10:21 | |
*** roxanagh_ has quit IRC | 10:25 | |
*** akulshin has quit IRC | 10:29 | |
*** Daisy has quit IRC | 10:33 | |
*** Daisy has joined #openstack-horizon | 10:33 | |
*** piet has joined #openstack-horizon | 10:36 | |
*** erlon has joined #openstack-horizon | 10:37 | |
*** Daisy has quit IRC | 10:38 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/337484 | 10:38 |
*** rajalokan has joined #openstack-horizon | 10:42 | |
*** itxaka has quit IRC | 10:45 | |
*** ducttape_ has joined #openstack-horizon | 10:49 | |
*** itisha has quit IRC | 10:50 | |
*** rodrigods has quit IRC | 10:51 | |
*** rodrigods has joined #openstack-horizon | 10:51 | |
*** itisha has joined #openstack-horizon | 10:52 | |
*** ducttape_ has quit IRC | 10:54 | |
*** pt_15 has quit IRC | 10:56 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 10:58 |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 10:59 |
*** itxaka has joined #openstack-horizon | 11:04 | |
*** piet has quit IRC | 11:18 | |
*** asettle has quit IRC | 11:20 | |
*** asettle has joined #openstack-horizon | 11:21 | |
*** asettle has quit IRC | 11:26 | |
*** yingjun has joined #openstack-horizon | 11:28 | |
*** yingjun has quit IRC | 11:33 | |
*** akulshin has joined #openstack-horizon | 11:37 | |
*** wolverineav has joined #openstack-horizon | 11:38 | |
*** wolverineav has quit IRC | 11:44 | |
*** asettle has joined #openstack-horizon | 11:47 | |
*** ducttape_ has joined #openstack-horizon | 11:50 | |
*** ducttape_ has quit IRC | 11:55 | |
*** amotoki has joined #openstack-horizon | 11:56 | |
*** yamamoto_ has quit IRC | 11:57 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 11:58 |
*** ratailor has quit IRC | 11:59 | |
mrunge | robcresswell, when you have the time, could you have a brief look at https://review.openstack.org/#/c/331974/ ? | 12:06 |
robcresswell | mrunge: Sure, it will be later this afternoon though; doing some internal work atm. Is that okay? | 12:07 |
mrunge | robcresswell, sure! it's an easy fix, one line to review :P | 12:08 |
mrunge | we should have a karma bot here | 12:08 |
*** roxanagh_ has joined #openstack-horizon | 12:09 | |
mrunge | just to give cookies, beer, whatever to awesome people | 12:09 |
mrunge | even if that's just virtual | 12:09 |
robcresswell | haha | 12:09 |
robcresswell | I like it | 12:09 |
*** ducttape_ has joined #openstack-horizon | 12:09 | |
*** aortega has joined #openstack-horizon | 12:11 | |
*** chlong has quit IRC | 12:12 | |
*** roxanagh_ has quit IRC | 12:13 | |
*** btully has joined #openstack-horizon | 12:16 | |
*** openstackgerrit has quit IRC | 12:19 | |
*** openstackgerrit has joined #openstack-horizon | 12:20 | |
*** btully has quit IRC | 12:21 | |
*** wangbo has quit IRC | 12:25 | |
*** ducttape_ has quit IRC | 12:27 | |
*** wangbo has joined #openstack-horizon | 12:32 | |
*** ppiela has joined #openstack-horizon | 12:38 | |
*** chlong has joined #openstack-horizon | 12:43 | |
*** yingjun has joined #openstack-horizon | 12:46 | |
*** amotoki has quit IRC | 12:47 | |
*** Nikolay_St has quit IRC | 12:47 | |
*** pauloewerton has joined #openstack-horizon | 12:48 | |
*** yamamoto has joined #openstack-horizon | 12:49 | |
*** mdavidson has quit IRC | 12:55 | |
*** matt-borland has joined #openstack-horizon | 12:56 | |
*** wangbo has quit IRC | 13:02 | |
*** julim has joined #openstack-horizon | 13:05 | |
*** rajalokan has quit IRC | 13:05 | |
*** wangbo has joined #openstack-horizon | 13:07 | |
*** amotoki has joined #openstack-horizon | 13:08 | |
matt-borland | tsufiev, did you figure out the problem with $sourceItems in your transfer-table patch? | 13:14 |
tsufiev | matt-borland, yes :)! | 13:14 |
*** ducttape_ has joined #openstack-horizon | 13:14 | |
matt-borland | excellent, I'll take a look at the patches | 13:14 |
tsufiev | yep, will upload it in about an hour | 13:14 |
*** ducttape_ has quit IRC | 13:15 | |
tsufiev | it was the preLink vs postLink issue in hz-dynamic-table | 13:15 |
matt-borland | interesting | 13:17 |
*** peristeri has joined #openstack-horizon | 13:17 | |
*** yingjun has quit IRC | 13:19 | |
*** yingjun has joined #openstack-horizon | 13:19 | |
*** zhurong has joined #openstack-horizon | 13:20 | |
*** yingjun has quit IRC | 13:24 | |
*** vishwanathj has joined #openstack-horizon | 13:35 | |
*** Daisy has joined #openstack-horizon | 13:39 | |
*** lblanchard has joined #openstack-horizon | 13:39 | |
*** cardeois has joined #openstack-horizon | 13:39 | |
*** wolverineav has joined #openstack-horizon | 13:41 | |
*** jtriley has joined #openstack-horizon | 13:43 | |
*** Daisy has quit IRC | 13:44 | |
*** wolverineav has quit IRC | 13:46 | |
*** jtomasek_ has joined #openstack-horizon | 13:48 | |
*** uxdanielle has joined #openstack-horizon | 13:48 | |
*** ducttape_ has joined #openstack-horizon | 13:50 | |
*** itisha has quit IRC | 13:50 | |
*** Daisy has joined #openstack-horizon | 13:50 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 13:52 |
tsufiev | matt-borland, here you are ^^^ | 13:53 |
matt-borland | awesome, thanks! | 13:53 |
tsufiev | that was the trickiest angular bug I've been dealing this year :) | 13:54 |
*** Daisy has quit IRC | 13:55 | |
*** roxanagh_ has joined #openstack-horizon | 13:57 | |
*** roxanagh_ has quit IRC | 14:01 | |
*** Daisy has joined #openstack-horizon | 14:02 | |
*** cardeois_ has joined #openstack-horizon | 14:03 | |
*** btully has joined #openstack-horizon | 14:05 | |
*** cardeois has quit IRC | 14:06 | |
*** Daisy has quit IRC | 14:07 | |
*** btully has quit IRC | 14:10 | |
matt-borland | tsufiev, taking a look now | 14:10 |
*** permalac has quit IRC | 14:14 | |
*** yingjun has joined #openstack-horizon | 14:14 | |
ducttape_ | tsufiev robcresswell itxaka I have a bug with this change https://github.com/openstack/horizon/commit/fd92d8ec59c2f4d91f4a1c5463d95d1237f07b21 seems to impact lots of places | 14:14 |
ducttape_ | not sure how this was not caught earlier | 14:14 |
*** cardeois_ has quit IRC | 14:15 | |
ducttape_ | mainly it is https://github.com/openstack/horizon/blob/master/horizon/forms/views.py#L173 | 14:15 |
*** cardeois_ has joined #openstack-horizon | 14:15 | |
*** TravT has joined #openstack-horizon | 14:15 | |
*** ChanServ sets mode: +v TravT | 14:15 | |
ducttape_ | do you guys have a few mins to discuss ? | 14:15 |
*** zhurong has quit IRC | 14:18 | |
*** weezS has joined #openstack-horizon | 14:18 | |
*** Daisy has joined #openstack-horizon | 14:18 | |
*** weezS has quit IRC | 14:19 | |
*** piet has joined #openstack-horizon | 14:21 | |
*** weezS has joined #openstack-horizon | 14:21 | |
*** Daisy has quit IRC | 14:23 | |
matt-borland | tsufiev, https://review.openstack.org/#/c/326641/ has some small -1s on it, otherwise looks really nice. Patch really cleans up/solidifies the transfer table. | 14:24 |
itxaka | ducttape_: what bug does it raise now? | 14:26 |
ducttape_ | https://bugs.launchpad.net/horizon/+bug/1598302 | 14:26 |
openstack | Launchpad bug 1598302 in OpenStack Dashboard (Horizon) "failed forms are not calling correct context data" [Undecided,New] - Assigned to Eric Peterson (ericpeterson-l) | 14:26 |
ducttape_ | itxaka: the problem is not that forms are not having their get_context_data method called, which is very important for some forms | 14:26 |
ducttape_ | so the end user experience is a general red message box with "an error has occured", when in fact it should have form clean methods with things like "this field is required" etc | 14:27 |
ducttape_ | so forms with input errors bomb out in a very unfriendly way now | 14:28 |
ducttape_ | or at least some of them fail in this way, perhaps not all of them | 14:28 |
ducttape_ | the main problem being this line - https://github.com/openstack/horizon/blob/master/horizon/forms/views.py#L173 | 14:29 |
ducttape_ | it should not call super | 14:29 |
ducttape_ | it should be calling the self method instead of super | 14:29 |
ducttape_ | this makes it so my form view with a get_context_data never gets called | 14:29 |
*** Daisy has joined #openstack-horizon | 14:29 | |
itxaka | aha, nice catch | 14:31 |
ducttape_ | the problem now is that just changing this one line, means that like 6 tests fail..... because we "cleaned up" tests after finding that some apis no longer get called | 14:32 |
ducttape_ | but in reality, these apis should get called | 14:33 |
ducttape_ | it's kind of a mess | 14:33 |
*** wolverineav has joined #openstack-horizon | 14:33 | |
*** purva has quit IRC | 14:34 | |
*** Daisy has quit IRC | 14:34 | |
tsufiev | ducttape_, :( | 14:36 |
*** xenogear has joined #openstack-horizon | 14:36 | |
ducttape_ | lots of fun / opportunities | 14:36 |
ducttape_ | :P | 14:36 |
*** wolverineav has quit IRC | 14:37 | |
*** jtomasek_ has quit IRC | 14:41 | |
openstackgerrit | Eric Peterson proposed openstack/horizon: Correcting form_invalid get_context_data call https://review.openstack.org/337703 | 14:41 |
*** sjmc7 has joined #openstack-horizon | 14:41 | |
*** wangbo has quit IRC | 14:42 | |
*** purva has joined #openstack-horizon | 14:43 | |
*** itisha has joined #openstack-horizon | 14:43 | |
*** Daisy has joined #openstack-horizon | 14:46 | |
*** uxdanielle has quit IRC | 14:47 | |
*** uxdanielle has joined #openstack-horizon | 14:49 | |
*** Daisy has quit IRC | 14:51 | |
*** piet has quit IRC | 14:51 | |
*** weezS has quit IRC | 14:52 | |
*** weezS has joined #openstack-horizon | 14:54 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Fixes issue where metadata is always removed on edit https://review.openstack.org/320122 | 14:57 |
*** Daisy has joined #openstack-horizon | 14:57 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 14:58 |
*** piet has joined #openstack-horizon | 15:00 | |
*** cardeois__ has joined #openstack-horizon | 15:01 | |
*** Daisy has quit IRC | 15:02 | |
*** Daisy has joined #openstack-horizon | 15:03 | |
*** cardeois_ has quit IRC | 15:04 | |
*** wangbo has joined #openstack-horizon | 15:05 | |
*** rajalokan has joined #openstack-horizon | 15:06 | |
openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 15:11 |
*** roxanagh_ has joined #openstack-horizon | 15:11 | |
*** Daisy has quit IRC | 15:13 | |
*** roxanagh_ has quit IRC | 15:16 | |
*** Daisy has joined #openstack-horizon | 15:19 | |
*** wolverineav has joined #openstack-horizon | 15:23 | |
*** weezS has quit IRC | 15:24 | |
*** Daisy has quit IRC | 15:24 | |
*** yingjun has quit IRC | 15:27 | |
*** yingjun has joined #openstack-horizon | 15:28 | |
*** wangbo has quit IRC | 15:30 | |
*** _ducttape_ has joined #openstack-horizon | 15:30 | |
*** wangbo has joined #openstack-horizon | 15:30 | |
*** ducttape_ has quit IRC | 15:31 | |
*** yingjun has quit IRC | 15:32 | |
*** openstackgerrit has quit IRC | 15:33 | |
*** openstackgerrit has joined #openstack-horizon | 15:34 | |
*** amotoki has quit IRC | 15:34 | |
*** wolverineav has quit IRC | 15:36 | |
*** wolverineav has joined #openstack-horizon | 15:37 | |
*** harlowja has joined #openstack-horizon | 15:40 | |
robcresswell | _ducttape_: Just got back to PC, looking | 15:42 |
*** wangbo has quit IRC | 15:42 | |
_ducttape_ | k. short brexit, I get it | 15:42 |
_ducttape_ | ;) | 15:42 |
robcresswell | _ducttape_: I have a feeling thats going to mentioned a lot at the midcycle | 15:43 |
_ducttape_ | https://review.openstack.org/#/c/337703/ is essentially I think what is needed | 15:43 |
_ducttape_ | but I am cleaning up the tests that are busted | 15:43 |
_ducttape_ | robcresswell: I just wanted to bring up the brexit thing, b/c otherwise I'm sure you hadn't heard yet ;) | 15:44 |
_ducttape_ | you are welcome | 15:44 |
*** wangbo has joined #openstack-horizon | 15:45 | |
*** gyee has joined #openstack-horizon | 15:45 | |
*** btully has joined #openstack-horizon | 15:47 | |
*** _ducttape_ has quit IRC | 15:47 | |
robcresswell | _ducttape_: Do you have time to handle that forms bug? | 15:47 |
*** ducttape_ has joined #openstack-horizon | 15:48 | |
robcresswell | Also, is that the same bug that was causing the weird submissions bugs in modal forms recently? | 15:48 |
ducttape_ | sorry I dropped robcresswell | 15:48 |
ducttape_ | it certainly could be causing lots of form submission stuff, but this is really around form errors | 15:49 |
ducttape_ | many forms are probably just bombing out when you fill out a form incorrectly | 15:49 |
robcresswell | So I know recently there were some bugs where forms were being submitted with errors, and then it would give you the form back, and even if you fixed it, it would error | 15:49 |
ducttape_ | ah, hmm | 15:49 |
ducttape_ | I guess that could be related? | 15:50 |
ducttape_ | I can think of a few cases where that might occur | 15:50 |
ducttape_ | anywho - I feel like I am the horizon gastroenterologist right now | 15:50 |
*** wolverineav has quit IRC | 15:50 | |
*** zackf has joined #openstack-horizon | 15:51 | |
robcresswell | ducttape_: https://bugs.launchpad.net/horizon/+bug/1576869 | 15:51 |
openstack | Launchpad bug 1576869 in OpenStack Dashboard (Horizon) "Attach Interface form error" [Medium,In progress] - Assigned to Ankur (ankur-gupta-f) | 15:51 |
robcresswell | Thats the one I was thinking of | 15:51 |
robcresswell | Although it sounds like they are different issues | 15:51 |
*** amotoki has joined #openstack-horizon | 15:51 | |
*** amotoki has quit IRC | 15:51 | |
*** Daisy has joined #openstack-horizon | 15:52 | |
ducttape_ | when I was working with Ankur we did find some similar stuff | 15:54 |
ducttape_ | I think you are onto something robcresswell. In that case, I think Ankur (and I) just did some other weird stuff to work around it | 15:54 |
*** wolverineav has joined #openstack-horizon | 15:55 | |
robcresswell | I'll look into it. Finishing off some internal work today/ tomorrow then will be finishing the tabs fix, so I'll look into that form stuff around the end of the week | 15:56 |
robcresswell | It sounds like that might fix numerous issues then, so we have to revert/modify those other fixes too. | 15:56 |
*** Daisy has quit IRC | 15:57 | |
ducttape_ | robcresswell: I hope to have a patch by EOD | 15:57 |
robcresswell | -.- | 15:57 |
ducttape_ | fixing tests right now, then we can see whats what ? | 15:58 |
robcresswell | Ah, I see! I thought you meant you expect a patch from me by EOD :p | 15:58 |
ducttape_ | not saying /implying anything on timeline on reviews | 15:58 |
ducttape_ | nah | 15:58 |
robcresswell | Awesome, thanks for handling that. | 15:58 |
ducttape_ | I look for PTL and cores to be reviewers and keep things working, software dev is secondary role | 15:59 |
robcresswell | \o/ | 15:59 |
robcresswell | Yeah I don't get much time to code :( | 15:59 |
*** dsneddon has joined #openstack-horizon | 16:00 | |
*** cardeois__ is now known as cardeois | 16:00 | |
*** Daisy has joined #openstack-horizon | 16:03 | |
*** bpokorny has joined #openstack-horizon | 16:05 | |
*** sdake has joined #openstack-horizon | 16:06 | |
*** ygbo has quit IRC | 16:09 | |
openstackgerrit | Eric Peterson proposed openstack/horizon: Correcting form_invalid get_context_data call https://review.openstack.org/337703 | 16:09 |
openstackgerrit | Eric Peterson proposed openstack/horizon: Correcting form_invalid get_context_data call https://review.openstack.org/337703 | 16:10 |
*** sdake has quit IRC | 16:11 | |
*** AlexOughton has quit IRC | 16:11 | |
*** AlexOughton has joined #openstack-horizon | 16:12 | |
*** roxanagh_ has joined #openstack-horizon | 16:12 | |
*** Daisy has quit IRC | 16:13 | |
*** rajalokan has quit IRC | 16:16 | |
*** roxanagh_ has quit IRC | 16:16 | |
*** Marcellin_ has joined #openstack-horizon | 16:20 | |
*** Daisy has joined #openstack-horizon | 16:20 | |
*** masco has quit IRC | 16:22 | |
*** Daisy has quit IRC | 16:25 | |
*** Daisy has joined #openstack-horizon | 16:25 | |
*** mtanino has joined #openstack-horizon | 16:26 | |
*** bpokorny has quit IRC | 16:27 | |
*** _stowa has joined #openstack-horizon | 16:29 | |
*** Daisy has quit IRC | 16:30 | |
*** Daisy has joined #openstack-horizon | 16:31 | |
*** rcernin has quit IRC | 16:31 | |
*** asettle has quit IRC | 16:32 | |
*** tesseract- has quit IRC | 16:33 | |
*** pcaruana has quit IRC | 16:33 | |
*** hogepodge has quit IRC | 16:34 | |
*** _stowa has quit IRC | 16:34 | |
*** bpokorny has joined #openstack-horizon | 16:34 | |
matt-borland | tsufiev, thanks for the quick update to that patch | 16:37 |
matt-borland | reviewing again now | 16:37 |
*** sergio_nubeliu has joined #openstack-horizon | 16:39 | |
*** hogepodge has joined #openstack-horizon | 16:41 | |
*** Daisy has quit IRC | 16:41 | |
ducttape_ | https://review.openstack.org/#/c/335269/ also a good review from Richard. handles swift objects / pseudo folders with the same names etc | 16:46 |
ducttape_ | small code changes too | 16:46 |
*** Daisy has joined #openstack-horizon | 16:47 | |
tsufiev | matt-borland, btw, I've just realized that I removed search bar from keypairs | 16:48 |
matt-borland | whoops! tsufiev | 16:48 |
tsufiev | do you think we need magic search there? | 16:48 |
*** hogepodge has quit IRC | 16:50 | |
tsufiev | lemme check if it's easy now to put search bar there... | 16:50 |
*** Daisy has quit IRC | 16:52 | |
*** zhurong has joined #openstack-horizon | 16:56 | |
*** masco has joined #openstack-horizon | 16:56 | |
*** wolverineav has quit IRC | 16:57 | |
*** wangbo has quit IRC | 16:57 | |
*** akulshin has quit IRC | 16:57 | |
*** kzaitsev_mb has joined #openstack-horizon | 16:58 | |
*** Daisy has joined #openstack-horizon | 16:59 | |
*** wangbo has joined #openstack-horizon | 17:00 | |
matt-borland | tsufiev, it should be really easy | 17:02 |
matt-borland | although it is not too useful, it's nice to have | 17:02 |
*** hogepodge has joined #openstack-horizon | 17:02 | |
matt-borland | if someone has a lot of keys | 17:02 |
*** vishwanathj has quit IRC | 17:03 | |
*** Daisy has quit IRC | 17:03 | |
*** piet has quit IRC | 17:03 | |
*** masco has quit IRC | 17:04 | |
*** piet has joined #openstack-horizon | 17:04 | |
*** Daisy has joined #openstack-horizon | 17:04 | |
*** Nikolay_St has joined #openstack-horizon | 17:06 | |
*** Daisy has quit IRC | 17:09 | |
*** permalac has joined #openstack-horizon | 17:09 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 17:09 |
tsufiev | matt-borland, done! | 17:09 |
matt-borland | good good | 17:09 |
tsufiev | ironically, we don't need extendObj filter | 17:10 |
tsufiev | took playing a bit with conditional filterFacets to realize that | 17:10 |
*** Daisy has joined #openstack-horizon | 17:10 | |
tsufiev | unfortunately, this approach won't work for $sourceItems - still need to use that complext filterAvailable expression | 17:10 |
*** wangbo has quit IRC | 17:13 | |
*** tqtran has joined #openstack-horizon | 17:14 | |
*** Daisy has quit IRC | 17:15 | |
*** Daisy has joined #openstack-horizon | 17:16 | |
*** ankur-gupta-f1 has joined #openstack-horizon | 17:16 | |
*** wangbo has joined #openstack-horizon | 17:16 | |
*** rcernin has joined #openstack-horizon | 17:17 | |
*** hogepodge has quit IRC | 17:17 | |
*** Daisy has quit IRC | 17:21 | |
tsufiev | robcresswell, are we going to have meeting tomorrow at 08:00 UTC? | 17:23 |
*** mdavidson has joined #openstack-horizon | 17:23 | |
*** hogepodge has joined #openstack-horizon | 17:23 | |
*** bpokorny has quit IRC | 17:26 | |
*** hogepodge has quit IRC | 17:28 | |
*** hogepodge has joined #openstack-horizon | 17:36 | |
*** bpokorny has joined #openstack-horizon | 17:38 | |
*** Chirag has joined #openstack-horizon | 17:41 | |
*** wolverineav has joined #openstack-horizon | 17:41 | |
*** wolverineav has quit IRC | 17:42 | |
*** ducttape_ has quit IRC | 17:42 | |
*** wolverineav has joined #openstack-horizon | 17:43 | |
*** rajalokan has joined #openstack-horizon | 17:43 | |
matt-borland | tsufiev, I haven't tried, but with $isAllocatedTable can you use grouping to help alleviate the use of the availableFilter? e.g. $isAllocatedTable ? (something | filter) : another_value? | 17:44 |
matt-borland | either way, I will +1 what you have. | 17:44 |
tsufiev | matt-borland, doesn't work, I don't know why | 17:44 |
matt-borland | heh, hm | 17:44 |
tsufiev | if it worked, then I would certainly do that :) | 17:45 |
matt-borland | heh, makes sense | 17:45 |
tsufiev | but... wait, did you said 'grouping'? | 17:45 |
tsufiev | because I didn't try parenthesis :) | 17:45 |
*** zhurong has quit IRC | 17:47 | |
*** btully has quit IRC | 17:49 | |
tsufiev | you know what, matt-borland? It works with grouping :D! | 17:49 |
matt-borland | ha! | 17:49 |
matt-borland | (I thought it would) | 17:49 |
tsufiev | which means I can get rid of 'bypass' argument to the filter | 17:49 |
matt-borland | excellent | 17:49 |
tsufiev | well, I hope this will be the last edit to that patch :) | 17:50 |
matt-borland | it's worth it! | 17:50 |
matt-borland | it's a good simplification | 17:50 |
*** asettle has joined #openstack-horizon | 17:51 | |
matt-borland | yeah, the expression language is simple, but can help with a lot of basic logic esp. with grouping | 17:51 |
tsufiev | I totally forgot about operators priority | 17:51 |
tsufiev | have been thinking that it was some weird scoping issue | 17:52 |
*** ankur-gupta-f1 has quit IRC | 17:52 | |
*** itxaka has quit IRC | 17:53 | |
*** ducttape_ has joined #openstack-horizon | 17:55 | |
*** hogepodge has quit IRC | 17:55 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 17:55 |
*** sjmc7 has quit IRC | 17:58 | |
*** wangbo has quit IRC | 17:59 | |
*** wangbo has joined #openstack-horizon | 18:00 | |
*** bpokorny has quit IRC | 18:04 | |
*** Chirag has quit IRC | 18:07 | |
*** wangbo has quit IRC | 18:11 | |
*** kzaitsev_mb has quit IRC | 18:12 | |
*** wangbo has joined #openstack-horizon | 18:13 | |
-openstackstatus- NOTICE: Job instability resulting from a block storage connectivity error on mirror.iad.rax.openstack.org has been corrected; jobs running in rax-iad should be more reliable again. | 18:14 | |
*** sjmc7 has joined #openstack-horizon | 18:18 | |
*** yamamoto has quit IRC | 18:23 | |
*** hogepodge has joined #openstack-horizon | 18:26 | |
*** bpokorny has joined #openstack-horizon | 18:35 | |
*** asettle has quit IRC | 18:37 | |
*** bpokorny has quit IRC | 18:39 | |
*** hogepodge has quit IRC | 18:53 | |
*** piet has quit IRC | 18:56 | |
*** aortega has quit IRC | 18:58 | |
*** M00nr41n has quit IRC | 18:58 | |
*** M00nr41n has joined #openstack-horizon | 19:00 | |
*** hogepodge has joined #openstack-horizon | 19:00 | |
*** piet has joined #openstack-horizon | 19:03 | |
*** bpokorny has joined #openstack-horizon | 19:18 | |
*** julim has quit IRC | 19:19 | |
*** piet has quit IRC | 19:23 | |
*** yamamoto has joined #openstack-horizon | 19:23 | |
*** lennyb has joined #openstack-horizon | 19:24 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Modify hz-cell to use hz-field https://review.openstack.org/334065 | 19:24 |
*** rajalokan has quit IRC | 19:25 | |
*** hogepodge has quit IRC | 19:27 | |
*** hogepodge has joined #openstack-horizon | 19:29 | |
*** gyee has quit IRC | 19:31 | |
*** btully has joined #openstack-horizon | 19:34 | |
*** yamamoto has quit IRC | 19:35 | |
*** ankur-gupta-f1 has joined #openstack-horizon | 19:38 | |
*** btully has quit IRC | 19:39 | |
*** kzaitsev_mb has joined #openstack-horizon | 19:39 | |
*** hogepodge has quit IRC | 19:43 | |
*** hogepodge has joined #openstack-horizon | 19:44 | |
*** julim has joined #openstack-horizon | 19:45 | |
*** roxanagh_ has joined #openstack-horizon | 19:48 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Adding hz-property/-list and filter/value retrieval from properties https://review.openstack.org/334069 | 19:52 |
*** roxanagh_ has quit IRC | 19:52 | |
*** lblanchard has quit IRC | 19:55 | |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image uses hz-property for its drawer information https://review.openstack.org/334083 | 19:55 |
*** aortega has joined #openstack-horizon | 19:57 | |
*** asettle has joined #openstack-horizon | 19:58 | |
*** asettle has quit IRC | 19:58 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Adding hz-property/-list and filter/value retrieval from properties https://review.openstack.org/334069 | 19:59 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image uses hz-property for its drawer information https://review.openstack.org/334083 | 20:00 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Image uses hz-property for its drawer information https://review.openstack.org/334083 | 20:09 |
matt-borland | TravT, I modified the hz-field and hz-property &c directives in the way you suggested | 20:10 |
TravT | ok, thx matt-borland. will go through it again shortly | 20:10 |
matt-borland | there is definitely a remaining confusion between resourceType.format() and hz-field ouputting. | 20:10 |
matt-borland | I didn't address that yet, we should probably talk thru it | 20:10 |
openstackgerrit | Ankur proposed openstack/horizon: Remove Unneeded API Calls, Functions https://review.openstack.org/337847 | 20:15 |
*** piet has joined #openstack-horizon | 20:18 | |
*** bpokorny has quit IRC | 20:22 | |
*** bpokorny has joined #openstack-horizon | 20:28 | |
*** bpokorny has quit IRC | 20:28 | |
*** bpokorny has joined #openstack-horizon | 20:29 | |
*** hogepodge has quit IRC | 20:29 | |
*** hogepodge has joined #openstack-horizon | 20:31 | |
*** Nikolay_St has quit IRC | 20:37 | |
*** wolverin_ has joined #openstack-horizon | 20:41 | |
*** wolverin_ has quit IRC | 20:41 | |
*** wolverineav has quit IRC | 20:41 | |
*** wolverineav has joined #openstack-horizon | 20:42 | |
*** hogepodge has quit IRC | 20:45 | |
*** hogepodge has joined #openstack-horizon | 20:47 | |
*** tjones has left #openstack-horizon | 20:53 | |
*** gyee has joined #openstack-horizon | 20:55 | |
*** ducttape_ has quit IRC | 21:03 | |
*** asettle has joined #openstack-horizon | 21:07 | |
*** hogepodge has quit IRC | 21:09 | |
*** hogepodge has joined #openstack-horizon | 21:14 | |
*** ducttape_ has joined #openstack-horizon | 21:16 | |
*** jtriley_ has joined #openstack-horizon | 21:21 | |
*** pauloewerton has quit IRC | 21:22 | |
*** matt-borland has quit IRC | 21:23 | |
*** jtriley has quit IRC | 21:24 | |
*** jtriley_ has quit IRC | 21:25 | |
*** wolverin_ has joined #openstack-horizon | 21:28 | |
*** mpavlase has joined #openstack-horizon | 21:30 | |
*** bpokorny has quit IRC | 21:31 | |
*** wolverineav has quit IRC | 21:31 | |
*** roxanagh_ has joined #openstack-horizon | 21:36 | |
*** roxanagh_ has quit IRC | 21:41 | |
*** bpokorny has joined #openstack-horizon | 21:42 | |
*** xiong has joined #openstack-horizon | 21:44 | |
*** cardeois has quit IRC | 22:03 | |
*** cardeois has joined #openstack-horizon | 22:04 | |
*** sjmc7 has quit IRC | 22:05 | |
*** cardeois has quit IRC | 22:09 | |
*** piet has quit IRC | 22:20 | |
*** piet has joined #openstack-horizon | 22:22 | |
*** asettle has quit IRC | 22:24 | |
*** purva has quit IRC | 22:24 | |
*** erlon has quit IRC | 22:26 | |
xiong | Hey guys, I'm trying to create a plugin with a new Angular dashboard for Horizon. I was following Cindy Lu's example: https://developer.ibm.com/opentech/2015/10/08/add-angularjs-dashboard-plugin-openstack-horizon/ | 22:28 |
xiong | The code for her example can be found here: https://github.com/clu-7/horizon-plugin/tree/master/mydashboard | 22:29 |
xiong | However, when I tried to include table.html into index.html, it doesn't seem to get picked up. Here is my code: https://github.com/mmxiong/horizon-xiong | 22:29 |
xiong | index.html can be found in bsndashboard/reachabilitytests/templates/reachabilitytests/index.html | 22:30 |
*** ducttape_ has quit IRC | 22:30 | |
xiong | To be more clear, I can see the index.html panel, but the ng-include of table.html is not showing up. | 22:31 |
*** ankur-gupta-f1 has left #openstack-horizon | 22:35 | |
xiong | ping TravT | 22:37 |
xiong | Oops, meant to ping tqtran, who has a similar example of adding a panel | 22:39 |
*** mpavlase has quit IRC | 22:41 | |
tqtran | xiong: looking at your code atm | 22:42 |
*** wolverin_ has quit IRC | 22:42 | |
xiong | tqtran: Thanks a lot. I appreciate the help | 22:42 |
*** wolverineav has joined #openstack-horizon | 22:42 | |
*** piet has quit IRC | 22:43 | |
tqtran | is your base html showing up? | 22:43 |
tqtran | https://github.com/mmxiong/horizon-xiong/blob/master/horizon_bsn/bsndashboard/templates/bsndashboard/base.html#L9 | 22:43 |
tqtran | doesnt look like there are any references to the table html from here | 22:43 |
tqtran | if you re-read cindy's guide, there is a code snippet you have to add <ng-include src="'{{ STATIC_URL }}dashboard/my_dashboard/my_panel/table/table.html'"></ng-include> | 22:44 |
tqtran | that points to the your table.html | 22:45 |
*** piet has joined #openstack-horizon | 22:48 | |
xiong | Shoudn't the reference be in index.html? | 22:48 |
xiong | It's my understanding that base.html is the base of the dashboard, not the panel. | 22:49 |
xiong | index.html has some text that does show up. | 22:50 |
xiong | It's also where I added the line that points to table.html | 22:52 |
xiong | ping tqtran | 22:57 |
*** itisha has quit IRC | 23:00 | |
tqtran | yes, sorry i meant to say index.html | 23:07 |
tqtran | you named yours base.html but it should really be call index.html | 23:08 |
tqtran | hope that makes sense | 23:08 |
xiong | tqtran: I don't understand. I have a base.html in horizon_bsn/bsndashboard/templates/bsndashboard, which doesn't seem to be relevant to the problem. | 23:12 |
*** btully has joined #openstack-horizon | 23:12 | |
xiong | I also have index.html in horizon_bsn/bsndashboard/reachabilitytests/templates/reachabilitytests, which I think is the index.html you're referring to. | 23:13 |
xiong | In index.html, I have included the line of code you referenced in Cindy Lu's tutorial. | 23:13 |
tqtran | looking | 23:15 |
xiong | In case it's useful, Cindy's index.html is in: https://github.com/clu-7/horizon-plugin/blob/master/mydashboard/mypanel/templates/mypanel/index.html | 23:16 |
*** piet has quit IRC | 23:16 | |
tqtran | so does your index page load up? | 23:17 |
tqtran | and when you inspect it, does it include the table.html? | 23:17 |
*** btully has quit IRC | 23:17 | |
*** rcernin has quit IRC | 23:18 | |
xiong | index.html loads, and I see the simple text that I've written. I also see the <ng-include> directive, but table.html itself doesn't | 23:20 |
*** peristeri has quit IRC | 23:20 | |
tqtran | im not following | 23:21 |
tqtran | so index.html loads, and you also see ng-include, but you are not seeing the table.html? or not seeing the <table> tag? | 23:21 |
xiong | There's no <table> tag. What I see is just the code in index.html, which is something like: <ng-include src="'/static/...'"> | 23:22 |
tqtran | and is it grayed out? or are there contents in it? | 23:23 |
xiong | What do you mean grayed out? the html I see is just a copy of what's in the file | 23:24 |
*** roxanagh_ has joined #openstack-horizon | 23:24 | |
tqtran | try hitting this template directly in the url | 23:25 |
tqtran | something like /static/dashboard/reachabilitytests/table.html | 23:26 |
tqtran | are you able to reach the template? if you are not, then it probably has something to do with your packaging | 23:26 |
xiong | You mean, instead of {{ STATIC_URL }}..., just typing /static/dashboard/reachabilitytests/table.html? | 23:27 |
tqtran | is your horizon deployed? | 23:27 |
xiong | Yes | 23:27 |
tqtran | mine is deployed to localhost:3001 | 23:27 |
tqtran | so i would try to hit localhost:3001/static/dashboard/reachabilitytests/table.html | 23:27 |
tqtran | to see if the static resource actually exists | 23:28 |
tqtran | if it does not, then it means your static resources were not packaged correctly | 23:28 |
xiong | It does | 23:28 |
tqtran | so you are able to see something resembling your table? | 23:28 |
xiong | Yes | 23:29 |
tqtran | ok, now try pasting that url directly into your index.html in the ng-include directive | 23:29 |
tqtran | see if that works | 23:29 |
*** roxanagh_ has quit IRC | 23:29 | |
xiong | It doesn't | 23:30 |
tqtran | that makes no sense, it should work | 23:34 |
tqtran | if you are able to directly hit the table.html | 23:34 |
tqtran | then your index.html should be able to retrieve the table.html | 23:35 |
tqtran | can you paste in the snippet? | 23:35 |
*** permalac has quit IRC | 23:35 | |
xiong | so i tried to apply the same logic to the path for logo and it worked: http://paste.openstack.org/show/526103/ | 23:37 |
xiong | but ng-include doesn't seem to be working. is there any other ng directive that i can try? | 23:38 |
xiong | which snippet would you like to see? i pasted my index.html updated. | 23:39 |
xiong | this still helps in debugging :) thanks for that trick. not giving up yet! | 23:41 |
*** kenji-i has joined #openstack-horizon | 23:41 | |
tqtran | you need to specify the full path | 23:42 |
tqtran | try this | 23:42 |
tqtran | if you openup the web console | 23:43 |
tqtran | type in STATIC_URL | 23:43 |
tqtran | what do you get? | 23:43 |
xiong | this is the URL and its corresponding output: http://paste.openstack.org/show/526107/ | 23:45 |
*** ducttape_ has joined #openstack-horizon | 23:46 | |
tqtran | awesome | 23:47 |
tqtran | in your index.html try | 23:47 |
tqtran | <ng-include src="'http://127.0.0.1:4000/static/dashboard/bsndashboard/reachabilitytests/table.html'"></ng-include> | 23:47 |
tqtran | see if anything shows up | 23:47 |
tqtran | also, check that when you type in STATIC_URL in the web debugger's console that it matches 127.0.0.1:4000/static/ | 23:48 |
xiong | omg. i just may have found the root cause. clicked on 'console' while looking for the URL and saw error loading my angular module which causes horizon.app to not load. and thus ng directive may not work! | 23:49 |
xiong | and yes, pasted the whole URL in ng-include and it still didn't load. so def the horizon.app error causing this issue | 23:50 |
xiong | this is the error on the browser console: http://paste.openstack.org/show/526109/ | 23:53 |
xiong | let me try to figure out what's wrong there. | 23:53 |
xiong | thanks for the pointers tqtran | 23:53 |
xiong | i'll let you know as i fix it. or come back for help again O:) | 23:54 |
*** dlevy has joined #openstack-horizon | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!