| *** btully has joined #openstack-horizon | 00:00 | |
| *** bpokorny has quit IRC | 00:02 | |
| *** btully has quit IRC | 00:05 | |
| *** dan_nguyen has quit IRC | 00:07 | |
| *** zhurong has quit IRC | 00:07 | |
| *** jtriley has joined #openstack-horizon | 00:21 | |
| *** sdake_ has quit IRC | 00:28 | |
| *** clu_ has quit IRC | 00:33 | |
| *** tqtran has quit IRC | 00:37 | |
| *** jtriley has quit IRC | 00:37 | |
| *** wolverin_ has joined #openstack-horizon | 00:52 | |
| *** xiong has quit IRC | 00:54 | |
| *** wolverineav has quit IRC | 00:55 | |
| *** wolverin_ has quit IRC | 00:59 | |
| *** dan_nguyen has joined #openstack-horizon | 01:03 | |
| *** shu-mutou has joined #openstack-horizon | 01:08 | |
| openstackgerrit | Merged openstack/xstatic-angular-cookies: Add basic tox.ini file https://review.openstack.org/344404 | 01:11 |
|---|---|---|
| openstackgerrit | Merged openstack/xstatic-spin: Add .gitreview file https://review.openstack.org/344427 | 01:12 |
| openstackgerrit | Merged openstack/xstatic-spin: Add basic tox.ini file https://review.openstack.org/344428 | 01:12 |
| *** zhurong has joined #openstack-horizon | 01:13 | |
| openstackgerrit | Merged openstack/xstatic-qunit: Add .gitreview file https://review.openstack.org/344425 | 01:13 |
| openstackgerrit | Merged openstack/xstatic-qunit: Add basic tox.ini file https://review.openstack.org/344426 | 01:13 |
| openstackgerrit | Merged openstack/xstatic-jquery.tablesorter: Add .gitreview file https://review.openstack.org/344423 | 01:13 |
| openstackgerrit | Merged openstack/xstatic-jquery.tablesorter: Add basic tox.ini file https://review.openstack.org/344424 | 01:13 |
| openstackgerrit | Merged openstack/xstatic-jquery.quicksearch: Add .gitreview file https://review.openstack.org/344421 | 01:14 |
| openstackgerrit | Merged openstack/xstatic-jquery.quicksearch: Add basic tox.ini file https://review.openstack.org/344422 | 01:14 |
| openstackgerrit | Merged openstack/xstatic-jquery-migrate: Add .gitreview file https://review.openstack.org/344419 | 01:14 |
| openstackgerrit | Merged openstack/xstatic-hogan: Add .gitreview file https://review.openstack.org/344417 | 01:14 |
| openstackgerrit | Merged openstack/xstatic-hogan: Add basic tox.ini file https://review.openstack.org/344418 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-angular-sanitize: Add .gitreview file https://review.openstack.org/344415 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-angular-sanitize: Add basic tox.ini file https://review.openstack.org/344416 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-jquery-migrate: Add basic tox.ini file https://review.openstack.org/344420 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-jasmine: Add basic tox.ini file https://review.openstack.org/344407 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-angular-smart-table: Add basic tox.ini file https://review.openstack.org/344406 | 01:15 |
| openstackgerrit | Merged openstack/xstatic-angular-mock: Add basic tox.ini file https://review.openstack.org/344405 | 01:16 |
| *** yingjun has quit IRC | 01:17 | |
| *** yingjun has joined #openstack-horizon | 01:18 | |
| *** yingjun has quit IRC | 01:22 | |
| *** Liuqing has joined #openstack-horizon | 01:34 | |
| Liuqing | morning | 01:35 |
| *** rajalokan has joined #openstack-horizon | 01:37 | |
| *** harlowja has joined #openstack-horizon | 01:37 | |
| Liuqing | HI there, r1chardj0n3s | 01:39 |
| r1chardj0n3s | hi Liuqing | 01:40 |
| *** rafael__ has joined #openstack-horizon | 01:40 | |
| Liuqing | https://review.openstack.org/#/c/344032/ the patch had merged. but it failed to release | 01:40 |
| Liuqing | Release xstatic-angular-smart-table 1.4.13 | 01:40 |
| Liuqing | robcresswell said that we need to debug horizon xstatic side | 01:40 |
| Liuqing | xstatic-mdi also failed to release.. | 01:41 |
| *** rafael__ has quit IRC | 01:42 | |
| Liuqing | we may miss something base on openstack release readme | 01:43 |
| Liuqing | will we have meeting today? | 01:44 |
| Liuqing | r1chardj0n3s | 01:44 |
| r1chardj0n3s | I've just approved a raft of changes to the xstatic repos to fix that issue | 01:45 |
| r1chardj0n3s | https://review.openstack.org/#/q/topic:xstatic-add-tox | 01:46 |
| r1chardj0n3s | so it should be possible to re-submit the releases patch now for those to get them released | 01:46 |
| openstackgerrit | Allen proposed openstack/horizon: Adding identity ng-roles panel https://review.openstack.org/222825 | 01:47 |
| *** asettle has joined #openstack-horizon | 01:47 | |
| r1chardj0n3s | also Liuqing I'm pretty sure there'll be a 2016-07-20 meeting at 2000 UTC | 01:48 |
| *** dan_nguyen has left #openstack-horizon | 01:49 | |
| *** dan_nguyen has joined #openstack-horizon | 01:49 | |
| *** dan_nguyen has left #openstack-horizon | 01:49 | |
| Liuqing | ok, r1chardj0n3s | 01:50 |
| *** asettle has quit IRC | 01:54 | |
| *** revon has quit IRC | 02:00 | |
| *** jtriley has joined #openstack-horizon | 02:03 | |
| *** yingjun has joined #openstack-horizon | 02:05 | |
| *** pt_15 has joined #openstack-horizon | 02:13 | |
| *** yamamoto has quit IRC | 02:17 | |
| *** yamamoto has joined #openstack-horizon | 02:17 | |
| *** ducttape_ has quit IRC | 02:18 | |
| *** rafael__ has joined #openstack-horizon | 02:19 | |
| *** ducttape_ has joined #openstack-horizon | 02:25 | |
| *** rafael__ has quit IRC | 02:43 | |
| *** zackf has quit IRC | 02:45 | |
| *** lblanchard has quit IRC | 02:50 | |
| Liuqing | r1chardj0n3s， how could we re-release the xstatic smart table? re-submit a patch to openstack/release? | 02:59 |
| r1chardj0n3s | Liuqing: yup | 02:59 |
| Liuqing | but the patch already there. | 02:59 |
| *** zhurong has quit IRC | 02:59 | |
| *** Liuqing has quit IRC | 02:59 | |
| *** zhurong has joined #openstack-horizon | 03:00 | |
| *** Liuqing has joined #openstack-horizon | 03:00 | |
| Liuqing | forget that hash value, | 03:03 |
| Liuqing | will re-submit a patch | 03:03 |
| r1chardj0n3s | Liuqing: let me know when you have, I'll take a look | 03:08 |
| Liuqing | do it now, back soon and will ping you r1chardj0n3s | 03:09 |
| *** zackf has joined #openstack-horizon | 03:10 | |
| *** zackf has quit IRC | 03:14 | |
| *** vkmc has quit IRC | 03:15 | |
| Liuqing | i have add a patch to release smart table: https://review.openstack.org/#/c/344547/ | 03:15 |
| Liuqing | https://review.openstack.org/#/c/344547/ | 03:15 |
| Liuqing | r1chardj0n3s | 03:15 |
| r1chardj0n3s | ta | 03:15 |
| r1chardj0n3s | Liuqing: -1 see review sorry | 03:19 |
| r1chardj0n3s | happy to explain further if necessary | 03:19 |
| *** vkmc has joined #openstack-horizon | 03:21 | |
| Liuqing | thanks for the explanation had re-submit a patch | 03:23 |
| *** jtriley has quit IRC | 03:30 | |
| *** julim has quit IRC | 03:32 | |
| r1chardj0n3s | it's just a shame that we can't have a gate check to run for the patch :-( | 03:32 |
| *** zackf has joined #openstack-horizon | 03:32 | |
| *** btully has joined #openstack-horizon | 03:36 | |
| *** ducttape_ has quit IRC | 03:36 | |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 03:45 |
| *** yamamoto has quit IRC | 03:47 | |
| *** david-lyle has joined #openstack-horizon | 03:49 | |
| *** ChanServ sets mode: +o david-lyle | 03:49 | |
| *** liuyulong_ has quit IRC | 03:54 | |
| *** liuyulong has joined #openstack-horizon | 03:57 | |
| *** jlopezgu has quit IRC | 03:58 | |
| *** jlopezgu has joined #openstack-horizon | 03:58 | |
| *** zackf has quit IRC | 04:06 | |
| *** mtanino has quit IRC | 04:07 | |
| *** david-lyle_ has joined #openstack-horizon | 04:19 | |
| *** david-lyle has quit IRC | 04:19 | |
| *** zackf has joined #openstack-horizon | 04:25 | |
| *** david-lyle_ has quit IRC | 04:26 | |
| *** zackf has quit IRC | 04:29 | |
| *** amotoki has joined #openstack-horizon | 04:32 | |
| *** itisha has joined #openstack-horizon | 04:36 | |
| *** yamamoto has joined #openstack-horizon | 04:37 | |
| *** zackf has joined #openstack-horizon | 04:44 | |
| *** zackf has quit IRC | 04:48 | |
| *** ratailor has joined #openstack-horizon | 04:52 | |
| *** masco has joined #openstack-horizon | 05:20 | |
| *** javeriak has joined #openstack-horizon | 05:20 | |
| *** jprovazn has joined #openstack-horizon | 05:30 | |
| *** jprovazn has quit IRC | 05:31 | |
| *** jprovazn has joined #openstack-horizon | 05:31 | |
| openstackgerrit | Allen proposed openstack/horizon: Adding identity ng-roles panel https://review.openstack.org/222825 | 05:33 |
| openstackgerrit | Allen proposed openstack/horizon: Add Angular keytone role creation action https://review.openstack.org/344572 | 05:33 |
| *** tnovacik has joined #openstack-horizon | 05:39 | |
| *** rcernin has quit IRC | 05:44 | |
| *** asettle has joined #openstack-horizon | 05:53 | |
| openstackgerrit | Allen proposed openstack/horizon: Adding identity ng-roles panel https://review.openstack.org/222825 | 05:56 |
| *** asettle has quit IRC | 06:00 | |
| *** javeriak has quit IRC | 06:01 | |
| *** rcernin has joined #openstack-horizon | 06:07 | |
| *** jprovazn has quit IRC | 06:22 | |
| *** btully has quit IRC | 06:28 | |
| *** wolverineav has joined #openstack-horizon | 06:28 | |
| *** jerrygb has quit IRC | 06:29 | |
| *** wolverineav has quit IRC | 06:32 | |
| *** roxanaghe has joined #openstack-horizon | 06:32 | |
| *** vishwanathj has quit IRC | 06:33 | |
| *** roxanaghe has quit IRC | 06:37 | |
| *** wolverineav has joined #openstack-horizon | 06:43 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Display notifications defined by the mechanism of MESSAGE_PATH in angular panel https://review.openstack.org/326244 | 06:43 |
| *** tesseract- has joined #openstack-horizon | 06:50 | |
| *** lelyakin has quit IRC | 06:50 | |
| openstackgerrit | Merged openstack/horizon: Fix jasmine tests failing due to missing ng-file-upload dep https://review.openstack.org/344394 | 06:53 |
| *** belmoreira has joined #openstack-horizon | 07:01 | |
| *** itxaka has joined #openstack-horizon | 07:03 | |
| *** javeriak has joined #openstack-horizon | 07:07 | |
| *** asettle has joined #openstack-horizon | 07:11 | |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 07:16 |
| *** asettle has quit IRC | 07:19 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/344091 | 07:23 |
| *** wolverineav has quit IRC | 07:29 | |
| *** jerrygb has joined #openstack-horizon | 07:30 | |
| *** jerrygb has quit IRC | 07:35 | |
| *** tmazur has joined #openstack-horizon | 07:37 | |
| *** mpavlase has joined #openstack-horizon | 07:39 | |
| *** wolverineav has joined #openstack-horizon | 07:41 | |
| *** alexvictorchan has quit IRC | 07:45 | |
| *** wolverineav has quit IRC | 07:46 | |
| *** alexvictorchan has joined #openstack-horizon | 07:50 | |
| *** wolverineav has joined #openstack-horizon | 07:51 | |
| *** wolverineav has quit IRC | 07:58 | |
| *** javeriak has quit IRC | 08:02 | |
| *** javeriak has joined #openstack-horizon | 08:04 | |
| *** btully has joined #openstack-horizon | 08:13 | |
| *** wolverineav has joined #openstack-horizon | 08:15 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: [Trivial]Fix the number that failed to delete in swift https://review.openstack.org/344636 | 08:16 |
| *** btully has quit IRC | 08:18 | |
| zigo | What should be used instead of django.conf.urls.patterns() ? | 08:18 |
| zigo | sahara-dashboard uses that, but it's removed from Django 1.10 | 08:18 |
| zigo | Oh, it's described in the error message... | 08:19 |
| *** roxanaghe has joined #openstack-horizon | 08:21 | |
| *** wolverineav has quit IRC | 08:24 | |
| *** roxanaghe has quit IRC | 08:25 | |
| *** pjm6_ is now known as pjm6 | 08:27 | |
| *** pjm6 has left #openstack-horizon | 08:28 | |
| *** jerrygb has joined #openstack-horizon | 08:31 | |
| *** jerrygb has quit IRC | 08:35 | |
| *** asettle has joined #openstack-horizon | 08:36 | |
| *** wolverineav has joined #openstack-horizon | 08:39 | |
| robcresswell | zigo: Its just a format change. Uses a list of urls now. | 08:41 |
| robcresswell | r1chardj0n3s: Just following the scrollback | 08:42 |
| robcresswell | Liuqing: Please don't release packages | 08:42 |
| robcresswell | Liuqing: I would prefer you wait for me or r1chardj0n3s to fix issues before the wider community start attempting releases. | 08:42 |
| openstackgerrit | Merged openstack/xstatic-angular-bootstrap: Remove py33 from the default envlist https://review.openstack.org/344463 | 08:44 |
| robcresswell | Liuqing, r1chardj0n3s: I assume you've realised by now, but I reverted both of the previous release patches so they can be processed the same way now | 08:45 |
| zigo | robcresswell: I'm trying to fix it, and I'm not sure how... | 08:45 |
| zigo | For example: | 08:46 |
| *** wolverineav has quit IRC | 08:46 | |
| Liuqing | robcresswell, r1chardj0n3s add a raft of changes to the xstatic repos to fix that issue:ix that issue | 08:46 |
| Liuqing | https://review.openstack.org/#/q/topic:xstatic-add-tox | 08:46 |
| zigo | urlpatterns = patterns( | 08:46 |
| zigo | 'openstack_dashboard.dashboards.project.ngdetails.views', | 08:46 |
| zigo | url('', views.IndexView.as_view(), name='index'), | 08:46 |
| zigo | ) | 08:46 |
| zigo | What should I set as 2nd param? | 08:46 |
| robcresswell | zigo: that would be: urlpatterns = [ | 08:46 |
| robcresswell | url('', views.IndexView.as_view(), name='index'), | 08:46 |
| zigo | Yeah, that point I got it. | 08:46 |
| robcresswell | ] | 08:46 |
| robcresswell | thats it | 08:46 |
| zigo | Oh, that's it? | 08:46 |
| zigo | Ok. | 08:46 |
| zigo | Easy then. | 08:46 |
| robcresswell | Yep | 08:46 |
| Liuqing | robcresswell , so you think the patch is not ready now : https://review.openstack.org/#/c/344547/ | 08:47 |
| Liuqing | ?? | 08:47 |
| robcresswell | Liuqing: It seems that it is okay now, would just prefer if we had waited for mdi to go through to check for issues | 08:47 |
| robcresswell | rather than handling this in multiple places | 08:48 |
| robcresswell | its creating extra work for me :) | 08:48 |
| Liuqing | they're in the same level :-) | 08:48 |
| robcresswell | Well, I had to go and revert multiple patches and track changes | 08:48 |
| *** asettle has quit IRC | 08:49 | |
| openstackgerrit | Thomas Goirand proposed openstack/horizon: [Django 1.10] django.conf.urls.patterns() removed https://review.openstack.org/344651 | 08:53 |
| zigo | robcresswell: Does it look good? | 08:53 |
| robcresswell | zigo: You've left the patterns import in :) | 08:54 |
| robcresswell | but otherwise yes | 08:54 |
| Liuqing | robcresswell, maybe that's a test patch for xstatic release process:-) | 08:54 |
| zigo | robcresswell: It's not a fault, as the class still exists, but ok, I'll remove it. | 08:54 |
| robcresswell | zigo: Unused imports will fail tests | 08:55 |
| robcresswell | pep8 | 08:55 |
| robcresswell | Oh, I already have this patch, I thought I had looked into it | 08:55 |
| robcresswell | https://review.openstack.org/#/c/335433/ | 08:55 |
| zigo | Oh ok. | 08:55 |
| openstackgerrit | Thomas Goirand proposed openstack/horizon: [Django 1.10] django.conf.urls.patterns() removed https://review.openstack.org/344651 | 08:55 |
| robcresswell | zigo: See above, I think we dont need both. It is already on the blueprint | 08:56 |
| zigo | Ok. | 08:56 |
| zigo | robcresswell: How come it fails gate-horizon-dsvm-integration? | 08:57 |
| robcresswell | zigo: I think it may have been a random failure. I ran a recheck. | 08:58 |
| *** asettle has joined #openstack-horizon | 08:58 | |
| *** ygbo has joined #openstack-horizon | 09:00 | |
| openstackgerrit | Shu Muto proposed openstack/horizon: [WIP] Add "nextUrl" to action-result https://review.openstack.org/344659 | 09:03 |
| *** shu-mutou is now known as shu-mutou-AFK | 09:04 | |
| *** asettle has quit IRC | 09:06 | |
| *** asettle has joined #openstack-horizon | 09:06 | |
| *** ratailor has quit IRC | 09:11 | |
| *** asettle has quit IRC | 09:13 | |
| *** asettle has joined #openstack-horizon | 09:14 | |
| *** wolverineav has joined #openstack-horizon | 09:14 | |
| *** ratailor has joined #openstack-horizon | 09:16 | |
| *** yingjun has quit IRC | 09:18 | |
| *** yingjun has joined #openstack-horizon | 09:19 | |
| *** wolverineav has quit IRC | 09:19 | |
| *** sdake has joined #openstack-horizon | 09:21 | |
| *** wolverineav has joined #openstack-horizon | 09:21 | |
| *** sdake has quit IRC | 09:23 | |
| *** wolverineav has quit IRC | 09:26 | |
| *** mvk has quit IRC | 09:27 | |
| *** javeriak has quit IRC | 09:29 | |
| *** tmazur has quit IRC | 09:29 | |
| *** yingjun has quit IRC | 09:30 | |
| *** tmazur has joined #openstack-horizon | 09:32 | |
| *** jerrygb has joined #openstack-horizon | 09:32 | |
| *** jerrygb has quit IRC | 09:36 | |
| *** javeriak has joined #openstack-horizon | 09:39 | |
| *** javeriak has quit IRC | 09:41 | |
| *** wolverineav has joined #openstack-horizon | 09:42 | |
| *** lelyakin has joined #openstack-horizon | 09:47 | |
| *** wolverineav has quit IRC | 09:47 | |
| lelyakin | Hi, everywhere! | 09:48 |
| lelyakin | Can somebody help me with Horizon Integration tests? | 09:49 |
| lelyakin | I have commit to Sahara-Dashboard project https://review.openstack.org/#/c/333273/ | 09:49 |
| *** rajalokan has quit IRC | 09:50 | |
| lelyakin | In this patch I use JS with Ajax requests in templates to load horizon tabs dynamically | 09:50 |
| lelyakin | But our Integration tests aren't support dynamically loaded tabs. | 09:51 |
| lelyakin | I always have NoSuchElementException | 09:52 |
| Liuqing | lelyakin, http://horizon/detail#abc | 09:53 |
| Liuqing | we could avoid dynamically loaded tabs via such link http://horizon/detail#abc , maybe | 09:54 |
| lelyakin | Sorry, have you missprint in link? | 09:55 |
| *** wolverineav has joined #openstack-horizon | 09:55 | |
| robcresswell | lelyakin: Its an example, not a link :) | 09:55 |
| Liuqing | yep | 09:56 |
| openstackgerrit | xujun proposed openstack/horizon: fix magic search bug https://review.openstack.org/344692 | 09:56 |
| lelyakin | then I don't understand how I can rewrite my solution. I can not avoid dynamically-loaded tabs :( | 09:57 |
| lelyakin | I have around 30-35 tabs in workflow, and If a load it at once it take around 40-45 sec | 09:58 |
| robcresswell | A workflow with 35 tabs!? | 09:58 |
| lelyakin | yes, we have too many configurations | 09:59 |
| *** tosky has joined #openstack-horizon | 10:01 | |
| *** zhurong has quit IRC | 10:02 | |
| *** Liuqing has quit IRC | 10:03 | |
| lelyakin | http://picpaste.com/Screenshot_from_2016-07-20_13_03_50-kpIZLdfX.png | 10:03 |
| *** wolverineav has quit IRC | 10:04 | |
| robcresswell | :/ | 10:04 |
| robcresswell | I think you guys should consider rewriting that workflow :) | 10:04 |
| robcresswell | In terms of the integration tests, I would try asking tsufiev, as our resident expert | 10:05 |
| *** amotoki has quit IRC | 10:05 | |
| *** amotoki has joined #openstack-horizon | 10:05 | |
| lelyakin | very thanks! | 10:06 |
| kenji-i | robcresswell: Hi, thank you for your comment about the bp of hierarchical projects previously! and I apologize for the late thank you. | 10:06 |
| *** roxanaghe has joined #openstack-horizon | 10:09 | |
| lelyakin | You are absolutely sure that dynamically-loaded tabs is bad practice? If is possible integrate it to Horizon, I can make patch in holiday, when I will be available | 10:09 |
| robcresswell | lelyakin: Its not a bad practice in general, but that workflow design for 20+ tabs is not a good idea | 10:09 |
| robcresswell | lelyakin: Dynamically loaded tabs aren't go going away though | 10:10 |
| robcresswell | aren't going* | 10:10 |
| tosky | robcresswell: how to model then that case? Each tab contains the options for a service which is dynamically enabled/disabled | 10:11 |
| tosky | so the number of tabs can be smaller or larger depending on your hadoop/spark/bigdata cluster | 10:11 |
| vgridnev | tosky, +1, was writing the same question | 10:11 |
| *** tnovacik has quit IRC | 10:11 | |
| *** roxanaghe has quit IRC | 10:14 | |
| vgridnev | tosky, my only thought is to make some kind of Advanced configs tab and that will collects links to open other steps, but I'm not sure how good it's | 10:14 |
| *** sdake has joined #openstack-horizon | 10:14 | |
| tosky | hide all the dynamic tabs under a unique tab, loaded on demand? Uhm | 10:15 |
| * tosky is not an usability expert | 10:15 | |
| tosky | for sure, if such solution is implemented, the additional tab should not take age to be populated (so everything on demand as much as possible) | 10:16 |
| robcresswell | tosky: Difficult to say without understanding the API underneath it | 10:16 |
| robcresswell | However: with that kind of involved process, easier to create a base object then boot user to details page and configure there by addingconfig | 10:16 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix unit tests https://review.openstack.org/344163 | 10:16 |
| robcresswell | So things like networks, you could have all subnets, ports etc in one workflow, or break it in to multiple | 10:16 |
| *** sdake_ has joined #openstack-horizon | 10:17 | |
| *** sdake has quit IRC | 10:19 | |
| vgridnev | robcresswell, API is simple. plugin will give you a map {target: list of configs} and {target: [list of processes]}. If we have a workflow step per target (and yeah, there are around 30 possible targets), and if user selected some process, we will show that workflow steps. Then we are collecting configs from all steps and creating a cluster in one API call | 10:21 |
| *** sdake_ has quit IRC | 10:22 | |
| *** wolverineav has joined #openstack-horizon | 10:24 | |
| *** sdake has joined #openstack-horizon | 10:25 | |
| robcresswell | vgridnev: Does the targets list continue to grow? | 10:25 |
| robcresswell | As in, in 2 years time, will there be 50 possible targets? | 10:25 |
| robcresswell | I wonder how manageable that workflow will be, and whether it might make sense to have an intermediate step, where each target is a separate action. | 10:26 |
| vgridnev | Good question. So I would say no, but usually per release there 2-3 new services supported by vendors | 10:28 |
| *** wolverineav has quit IRC | 10:29 | |
| *** jerrygb has joined #openstack-horizon | 10:33 | |
| *** ratailor has quit IRC | 10:34 | |
| *** sdake has quit IRC | 10:38 | |
| *** jerrygb has quit IRC | 10:39 | |
| *** sdake has joined #openstack-horizon | 10:42 | |
| *** mvk has joined #openstack-horizon | 10:44 | |
| *** wolverineav has joined #openstack-horizon | 10:46 | |
| *** wolverineav has quit IRC | 10:50 | |
| *** ratailor has joined #openstack-horizon | 10:51 | |
| *** asettle has quit IRC | 10:52 | |
| *** zhurong has joined #openstack-horizon | 11:07 | |
| *** tnovacik has joined #openstack-horizon | 11:08 | |
| *** wolverineav has joined #openstack-horizon | 11:10 | |
| *** zhurong has quit IRC | 11:11 | |
| *** sdake has quit IRC | 11:12 | |
| *** zhurong has joined #openstack-horizon | 11:13 | |
| *** wolverineav has quit IRC | 11:14 | |
| *** yamamoto has quit IRC | 11:15 | |
| *** yamamoto has joined #openstack-horizon | 11:21 | |
| *** aortega has joined #openstack-horizon | 11:21 | |
| *** yamamoto has quit IRC | 11:22 | |
| *** rodrigods has quit IRC | 11:26 | |
| *** lelyakin has quit IRC | 11:26 | |
| *** wolverineav has joined #openstack-horizon | 11:31 | |
| *** jerrygb has joined #openstack-horizon | 11:35 | |
| *** wolverineav has quit IRC | 11:36 | |
| *** davidc_ has joined #openstack-horizon | 11:36 | |
| davidc_ | Hi | 11:36 |
| *** wolverineav has joined #openstack-horizon | 11:37 | |
| *** jerrygb has quit IRC | 11:39 | |
| *** wolverineav has quit IRC | 11:45 | |
| *** pt_15 has quit IRC | 11:46 | |
| *** tnovacik has quit IRC | 11:46 | |
| *** wolverineav has joined #openstack-horizon | 11:48 | |
| *** itisha has quit IRC | 11:50 | |
| *** btully has joined #openstack-horizon | 11:51 | |
| *** wolverineav has quit IRC | 11:54 | |
| *** btully has quit IRC | 11:56 | |
| openstackgerrit | Merged openstack/manila-ui: Fix unit tests https://review.openstack.org/344163 | 11:58 |
| *** florianf has joined #openstack-horizon | 12:05 | |
| *** ducttape_ has joined #openstack-horizon | 12:07 | |
| *** Liuqing has joined #openstack-horizon | 12:10 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/344091 | 12:10 |
| *** yamamoto has joined #openstack-horizon | 12:11 | |
| *** rodrigods has joined #openstack-horizon | 12:12 | |
| *** ducttape_ has quit IRC | 12:12 | |
| *** asettle has joined #openstack-horizon | 12:15 | |
| zigo | robcresswell: Before I attempt to send it for review, does this look reasonable? http://paste.openstack.org/show/538811/ | 12:17 |
| *** yamamoto has quit IRC | 12:20 | |
| *** tnovacik has joined #openstack-horizon | 12:20 | |
| *** ratailor has quit IRC | 12:22 | |
| *** yamamoto has joined #openstack-horizon | 12:23 | |
| robcresswell | zigo: It looks like you've replaced the view class for auth/login with a generic one | 12:24 |
| zigo | robcresswell: I really don't know what I'm doing ... :) | 12:24 |
| zigo | robcresswell: Though the old code fails in Django 1.10. | 12:24 |
| robcresswell | zigo: You can review things/ leave notes on the bp, that would help me a lot | 12:28 |
| robcresswell | zigo: Even if its like "this issue, these docs might help" | 12:29 |
| zigo | I did write in the whiteboard, and expect to do that more. | 12:29 |
| robcresswell | zigo: Yep, thats great | 12:29 |
| *** julim has joined #openstack-horizon | 12:31 | |
| *** wolverineav has joined #openstack-horizon | 12:35 | |
| *** jerrygb has joined #openstack-horizon | 12:36 | |
| *** jojden has quit IRC | 12:39 | |
| *** jerrygb has quit IRC | 12:41 | |
| *** pauloewerton has joined #openstack-horizon | 12:44 | |
| *** javeriak has joined #openstack-horizon | 12:44 | |
| *** wolverineav has quit IRC | 12:44 | |
| *** rajalokan has joined #openstack-horizon | 12:45 | |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Provide the bones of profiler: api, models and middleware https://review.openstack.org/273085 | 12:49 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: [WIP] Wrap api calls with tracing recorators https://review.openstack.org/339675 | 12:49 |
| openstackgerrit | Paul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard https://review.openstack.org/303514 | 12:49 |
| *** wolverineav has joined #openstack-horizon | 12:51 | |
| *** yamamoto has quit IRC | 12:54 | |
| *** yamamoto has joined #openstack-horizon | 12:56 | |
| *** matt-borland has joined #openstack-horizon | 12:57 | |
| *** ducttape_ has joined #openstack-horizon | 12:58 | |
| *** wolverineav has quit IRC | 12:59 | |
| *** purva has joined #openstack-horizon | 13:03 | |
| Liuqing | HI, matt-borland:-) | 13:05 |
| openstackgerrit | Liuqing Jing proposed openstack/horizon: [TrivialFix] Hide expand in angular table if we haven't setSummaryTemplateUrl https://review.openstack.org/344819 | 13:05 |
| Liuqing | ping | 13:05 |
| matt-borland | Hey Liuqing! | 13:05 |
| matt-borland | want me to take a look at the above? | 13:06 |
| Liuqing | how could we integrate django actions and angular tables? | 13:06 |
| matt-borland | Liuqing, tyr will be putting up a patch, but you can see generally how it works as part of the patch in https://review.openstack.org/#/c/329700/, the server-side-action portion | 13:06 |
| Liuqing | review on above patch is appreciated :-)) | 13:07 |
| matt-borland | that patch allows us to register Django actions using the Angular registration, etc., but it needs to be cleaned up. | 13:07 |
| *** uxdanielle has joined #openstack-horizon | 13:08 | |
| Liuqing | seems cool, will check that patch | 13:08 |
| matt-borland | Liuqing, with your patch, I do suggest filing a simple bug to associate with that patch. It can be a very simple bug, just describe when it doesn't work quite right. | 13:09 |
| Liuqing | OK, will report a bug :) | 13:09 |
| matt-borland | thanks for putting that together! | 13:09 |
| Liuqing | my pleasure, matt-borland | 13:10 |
| matt-borland | I'll check with tyr to see when he's going to put up a separate patch for the Django/Angular actions. | 13:11 |
| *** peristeri has joined #openstack-horizon | 13:11 | |
| *** lblanchard has joined #openstack-horizon | 13:13 | |
| Liuqing | ok, i'm not very clear about tyr's timezeon.. | 13:13 |
| Liuqing | s/timezeon/timezone/ | 13:13 |
| openstackgerrit | xujun proposed openstack/horizon: fix magic search bug https://review.openstack.org/344692 | 13:15 |
| *** jtriley has joined #openstack-horizon | 13:17 | |
| matt-borland | Liuqing, tyr works with me here in Colorado, but usually starts his work day in about 2 hours. | 13:17 |
| *** ducttape_ has quit IRC | 13:18 | |
| Liuqing | gotcha | 13:19 |
| *** rajalokan has quit IRC | 13:19 | |
| *** sdake has joined #openstack-horizon | 13:21 | |
| *** tnovacik has quit IRC | 13:22 | |
| *** pt_15 has joined #openstack-horizon | 13:24 | |
| *** javeriak_ has joined #openstack-horizon | 13:25 | |
| *** javeriak has quit IRC | 13:26 | |
| *** javeriak has joined #openstack-horizon | 13:26 | |
| *** rajalokan has joined #openstack-horizon | 13:28 | |
| *** javeriak_ has quit IRC | 13:30 | |
| *** btully has joined #openstack-horizon | 13:34 | |
| *** mtanino has joined #openstack-horizon | 13:36 | |
| *** jerrygb has joined #openstack-horizon | 13:37 | |
| *** aortega has quit IRC | 13:39 | |
| *** masco has quit IRC | 13:40 | |
| *** sjmc7 has joined #openstack-horizon | 13:41 | |
| *** jerrygb has quit IRC | 13:41 | |
| *** javeriak_ has joined #openstack-horizon | 13:44 | |
| *** roxanaghe has joined #openstack-horizon | 13:45 | |
| *** javeria__ has joined #openstack-horizon | 13:45 | |
| *** javeriak has quit IRC | 13:45 | |
| *** wolverineav has joined #openstack-horizon | 13:45 | |
| *** cardeois_ has joined #openstack-horizon | 13:46 | |
| *** cardeois_ is now known as cardeois | 13:46 | |
| *** cardeois has quit IRC | 13:46 | |
| *** cardeois has joined #openstack-horizon | 13:47 | |
| *** cardeois has quit IRC | 13:47 | |
| *** asettle has quit IRC | 13:49 | |
| *** ducttape_ has joined #openstack-horizon | 13:49 | |
| *** javeriak_ has quit IRC | 13:49 | |
| *** roxanaghe has quit IRC | 13:49 | |
| *** asettle has joined #openstack-horizon | 13:49 | |
| *** itisha has joined #openstack-horizon | 13:49 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Flavors panel using Angular https://review.openstack.org/343917 | 13:50 |
| *** uxdanielle has quit IRC | 13:52 | |
| *** jerrygb has joined #openstack-horizon | 13:53 | |
| *** wolverineav has quit IRC | 13:53 | |
| *** wolverineav has joined #openstack-horizon | 13:55 | |
| *** rajalokan has quit IRC | 13:56 | |
| *** cardeois has joined #openstack-horizon | 13:56 | |
| *** tnovacik has joined #openstack-horizon | 13:57 | |
| robcresswell | matt-borland: I think create-net is functionally complete *except* for the little * on invalid steps | 13:59 |
| *** TravT has quit IRC | 13:59 | |
| openstackgerrit | Steve McLellan proposed openstack/horizon: Allow horizon to function without nova https://review.openstack.org/342283 | 13:59 |
| robcresswell | matt-borland: I did have thought about though. I think I could use ngForm (which exists exactly for this reason) | 14:00 |
| robcresswell | "It is useful to nest forms, for example if the validity of a sub-group of controls needs to be determined." | 14:00 |
| ducttape_ | robcresswell - lets have 2 mins of talk on https://review.openstack.org/#/c/342619/ | 14:01 |
| robcresswell | ducttape_: Sure | 14:01 |
| *** TravT has joined #openstack-horizon | 14:01 | |
| *** ChanServ sets mode: +v TravT | 14:01 | |
| ducttape_ | so here is my problem with this approach from you and Dianna | 14:01 |
| ducttape_ | horizon upstream makes changes, breaks plugins | 14:01 |
| *** yingjun has joined #openstack-horizon | 14:02 | |
| ducttape_ | and you don't want to write code than is backwards compatible | 14:02 |
| *** sdake_ has joined #openstack-horizon | 14:02 | |
| *** roxanaghe has joined #openstack-horizon | 14:02 | |
| ducttape_ | instead the viewpoint is "your config is bad - we now require this" | 14:02 |
| ducttape_ | the problem is, this type of new config etc is something that needs to take a release or two / three to add new stuff | 14:02 |
| ducttape_ | instead, I'd think a warning etc would be printed | 14:03 |
| robcresswell | How long ago was that key added? | 14:03 |
| ducttape_ | not sure, but was is stated that it was required ? | 14:03 |
| robcresswell | My issue isn't with backwards compatibility, its with just supporting everything forever because of old testing settings files | 14:03 |
| *** sdake has quit IRC | 14:03 | |
| ducttape_ | there was no notice given to plugins that they need to change something | 14:03 |
| ducttape_ | it's just "poof" - now things are broken | 14:04 |
| robcresswell | I'd have to check through the release notes and see | 14:04 |
| *** sdake has joined #openstack-horizon | 14:05 | |
| ducttape_ | fair enough. it could be that this is required or some docs take care of this | 14:05 |
| ducttape_ | but it seems to me that several plugins were busted / surprised | 14:05 |
| ducttape_ | and the code to support the old stuff is not very large | 14:05 |
| *** roxanaghe has quit IRC | 14:06 | |
| robcresswell | Which is fine, and if we've failed to properly document this change then I apologise and we should merge the compatibility fix | 14:06 |
| ducttape_ | i'd think some version of that patch, and you could log a warning that a new config is needed..... that would be a good transition patch | 14:06 |
| robcresswell | What I *don't* want is a situation where Horizon documents changes, has an early FF, a milestone release every two months, and then when something doesnt work in a plugin, everyone blames horizon. | 14:07 |
| robcresswell | There is a middle ground, thats all. | 14:07 |
| *** sdake_ has quit IRC | 14:07 | |
| robcresswell | Let me dig into the code a bit more and see what's going wrong | 14:07 |
| ducttape_ | fair enough. not trying to say horizon needs to support plugins from 2 years ago | 14:08 |
| ducttape_ | but if 2-3 plugins from master break on a horizon change, that is a red flag | 14:08 |
| lcastell | morning all | 14:11 |
| ducttape_ | o/ | 14:12 |
| robcresswell | o/ | 14:12 |
| zhurong | @robcresswell ducttape_ sorry for the interrupt, Can you give me some help what is the correct way to make the plugin setting without this error? | 14:12 |
| robcresswell | https://review.openstack.org/#/c/343640/ | 14:13 |
| *** yingjun_ has joined #openstack-horizon | 14:13 | |
| robcresswell | patches like that are the way to go ^^ | 14:13 |
| *** Tamayo has joined #openstack-horizon | 14:13 | |
| zhurong | Not the test setting, my develop env gives the error | 14:14 |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-ui: Add Share Migration support https://review.openstack.org/344431 | 14:15 |
| ducttape_ | agree with robcresswell on that fix | 14:15 |
| zhurong | https://bugs.launchpad.net/horizon/+bug/1603307 look this bug, I add the snapshot, make some changes, horizon will give the error too | 14:15 |
| openstack | Launchpad bug 1603307 in OpenStack Dashboard (Horizon) "horizon plugin gives the KeyError" [Undecided,In progress] - Assigned to zhurong (zhu-rong) | 14:15 |
| robcresswell | zhurong: Sorry, I don't understand, when you're running Horizon you see the error? | 14:15 |
| *** yingjun has quit IRC | 14:16 | |
| ducttape_ | ah that is different, yeah | 14:16 |
| *** wolverineav has quit IRC | 14:16 | |
| robcresswell | ducttape_: There are release notes about older settings being deprecated, but not about requiring the new ones. I'll look into the patch and add a warning in there too. | 14:16 |
| ducttape_ | thanks for hearing me vent robcresswell (again) | 14:17 |
| openstackgerrit | Liuqing Jing proposed openstack/horizon: [TrivialFix] Hide expand in angular table if we haven't setSummaryTemplateUrl https://review.openstack.org/344819 | 14:18 |
| robcresswell | zhurong: It looks like Murano dashboard is overriding the entire compress logic!? | 14:18 |
| robcresswell | Timurs patch seems to fix the issue too | 14:18 |
| zhurong | No, I test the patch, can not fix the issue | 14:18 |
| kzaitsev_ws | robcresswell: I don't like the idea of including every single js file of murano-dashboard on every single page of horizon | 14:19 |
| robcresswell | kzaitsev_ws: Right now every single JS file is included on every single page anyway | 14:20 |
| robcresswell | We don't use any form of module loading in base Horizon | 14:20 |
| kzaitsev_ws | and no, I don't think that we're overriding all the compress logic, we're just adding all the files to all the pages of murano-dashboard | 14:20 |
| *** uxdanielle has joined #openstack-horizon | 14:20 | |
| kzaitsev_ws | https://github.com/openstack/murano-dashboard/blob/master/muranodashboard/templates/murano_base.html | 14:21 |
| kzaitsev_ws | all the templates in murano-dashboard inherit from this template and we just add an extra {% compress js %} block to {% block js %} | 14:21 |
| *** wolverineav has joined #openstack-horizon | 14:21 | |
| kzaitsev_ws | without throwing away what horizon is putting there | 14:22 |
| matt-borland | robcresswell, sorry, I was afk | 14:22 |
| robcresswell | Ah I see | 14:22 |
| matt-borland | had to let the chickens out into the yard after a nice rain | 14:23 |
| kzaitsev_ws | so we're overriding =) but I believe we're doing it respectfully ) | 14:23 |
| robcresswell | kzaitsev_ws: The compressor must be functioning differently to Horizon though if its missing contextual info | 14:23 |
| *** tosky has quit IRC | 14:24 | |
| kzaitsev_ws | robcresswell: my take on this was that everybody seem to use old settings.py, but I haven't had time to dig deeper | 14:24 |
| kzaitsev_ws | the thing is we have dashboard CI, that uses master horizon+master dashboard and runs some selenium tests | 14:25 |
| kzaitsev_ws | and it's green =) | 14:25 |
| kzaitsev_ws | this is the major point why I think that dashboard and horizon are actually ok, and the problem is in the local configuration | 14:26 |
| *** sjmc7 has quit IRC | 14:26 | |
| Liuqing | the problem is in the local configuration seems wired..kzaitsev_ws | 14:26 |
| openstackgerrit | Yosef Hoffman proposed openstack/horizon: Configure vol_create in Launch Instance defaults https://review.openstack.org/309539 | 14:26 |
| Liuqing | really? or because of not dive deep.. | 14:27 |
| *** sjmc7 has joined #openstack-horizon | 14:27 | |
| *** vishwanathj has joined #openstack-horizon | 14:27 | |
| *** tyr has joined #openstack-horizon | 14:27 | |
| *** wolverineav has quit IRC | 14:28 | |
| ducttape_ | tsufiev: did you read my reply on https://review.openstack.org/#/c/337703/ ? | 14:28 |
| kzaitsev_ws | unfortunatelly I'm in the middle of tearing down configuration file of our dashboard/panels into multiple small pieces, so it's hard to test, but I'll try to get to it sooner rather than later | 14:28 |
| *** yohoffman has joined #openstack-horizon | 14:28 | |
| kzaitsev_ws | Liuqing: not sure, that I got you message | 14:28 |
| robcresswell | Liuqing: Compile and compress works fine with murano dashboard and Horizon master | 14:30 |
| Liuqing | so what's the problem.. | 14:30 |
| robcresswell | Unsure, just checking. I think settings file being out of date. | 14:31 |
| *** julim has quit IRC | 14:32 | |
| Liuqing | robcresswell, we need docs/notes about settings and test settings in horizon plugin page | 14:32 |
| zhurong | @robcresswell https://launchpadlibrarian.net/274118063/snapshot.png take a look at this snapshot | 14:32 |
| robcresswell | zhurong: I don't understand what this shows. | 14:33 |
| *** dave-mccowan has joined #openstack-horizon | 14:33 | |
| robcresswell | Liuqing: Indeed, I will add recommendations | 14:33 |
| *** wolverineav has joined #openstack-horizon | 14:33 | |
| Liuqing | thanks robcresswell, maybe i can help with the docs or recommendations:-) | 14:34 |
| zhurong | @robcresswell horizon/project index will give the error too | 14:34 |
| robcresswell | zhurong: Because you have changed it. It does not error in the repo. | 14:34 |
| Liuqing | anywaym i'm fine with the fix from zhurong | 14:34 |
| robcresswell | I'm going to update it to add deprecation warnings | 14:34 |
| robcresswell | I think the entire thing arises because AVAILABLE_THEMES isn't configured in test settings. | 14:37 |
| Liuqing | kzaitsev_ws, zhurong, maybe that's the root cause: kzaitsev_ws | 14:37 |
| Liuqing | https://github.com/openstack/horizon/blob/master/horizon/themes.py#L71-L81 | 14:37 |
| robcresswell | https://github.com/openstack/horizon/blob/107488f2f53f55ce2b727e52b5496db47ffc21ce/horizon/themes.py#L42 | 14:37 |
| Liuqing | robcresswell, you got the point:-) | 14:38 |
| robcresswell | FYI, link to a hash, not to /master, otherwise the logs will not make sense in the future. | 14:38 |
| *** wolverineav has quit IRC | 14:38 | |
| *** uxdanielle has quit IRC | 14:38 | |
| robcresswell | So then context['THEME'] is not set | 14:39 |
| robcresswell | Rather than default to a [], it should throw a configuration error. | 14:39 |
| openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 14:39 |
| robcresswell | or default to ['default'] | 14:39 |
| ducttape_ | yep | 14:40 |
| Liuqing | yep | 14:40 |
| ducttape_ | if theme is not there, I'd bet default is not as well. default is fairly new | 14:40 |
| ducttape_ | but you could have that config error on both if you wanted | 14:41 |
| *** yingjun has joined #openstack-horizon | 14:41 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix missing 'THEME' key https://review.openstack.org/344871 | 14:42 |
| robcresswell | something like that ^^ | 14:42 |
| *** yingjun_ has quit IRC | 14:42 | |
| robcresswell | That should just always fall back to the 'default' theme packaged with Horizon | 14:42 |
| ducttape_ | perhaps. but if you really want this to be required, need to log some warning etc | 14:44 |
| robcresswell | Yes, was just about to add that | 14:44 |
| ducttape_ | I just don't want this implied requirement that gets swept under the rug | 14:44 |
| *** wolverineav has joined #openstack-horizon | 14:45 | |
| *** uxdanielle has joined #openstack-horizon | 14:47 | |
| *** wolverineav has quit IRC | 14:47 | |
| *** wolverineav has joined #openstack-horizon | 14:48 | |
| *** wolverineav has quit IRC | 14:48 | |
| robcresswell | Yup | 14:49 |
| *** uxdanielle has quit IRC | 14:49 | |
| *** wolverineav has joined #openstack-horizon | 14:49 | |
| *** tosky has joined #openstack-horizon | 14:50 | |
| *** wolverineav has quit IRC | 14:50 | |
| *** zhurong has quit IRC | 14:50 | |
| *** wolverineav has joined #openstack-horizon | 14:50 | |
| *** wolverineav has joined #openstack-horizon | 14:51 | |
| *** wolverineav has quit IRC | 14:51 | |
| *** wolverineav has joined #openstack-horizon | 14:51 | |
| *** wolverineav has quit IRC | 14:51 | |
| *** Marcellin_ has joined #openstack-horizon | 14:51 | |
| *** wolverineav has joined #openstack-horizon | 14:52 | |
| *** aortega has joined #openstack-horizon | 14:52 | |
| *** aortega has joined #openstack-horizon | 14:52 | |
| kzaitsev_ws | robcresswell: I'll ask my colleagues to check if this patch fixes the problem ) | 14:53 |
| *** wolverineav has quit IRC | 14:54 | |
| *** wolverineav has joined #openstack-horizon | 14:54 | |
| *** wolverineav has joined #openstack-horizon | 14:55 | |
| *** wolverineav has quit IRC | 14:55 | |
| *** wolverineav has joined #openstack-horizon | 14:55 | |
| *** wolverineav has quit IRC | 14:55 | |
| *** wolverineav has joined #openstack-horizon | 14:56 | |
| *** javeria__ has quit IRC | 14:57 | |
| *** zackf has joined #openstack-horizon | 14:58 | |
| *** uxdanielle has joined #openstack-horizon | 14:59 | |
| matt-borland | Liuqing, +1 on https://review.openstack.org/#/c/344819/ . Good catch, it's a good, simple fix. | 14:59 |
| Liuqing | thanks matt-borland | 14:59 |
| *** ZZelle has joined #openstack-horizon | 15:00 | |
| *** wolverineav has quit IRC | 15:00 | |
| *** yingjun has quit IRC | 15:03 | |
| *** yingjun has joined #openstack-horizon | 15:04 | |
| robcresswell | matt-borland: Remember to target bugs to N-3 or Next please :) | 15:04 |
| *** wolverineav has joined #openstack-horizon | 15:05 | |
| matt-borland | robcresswell, oh, I really didn't know :) | 15:05 |
| matt-borland | What is the way I decide what to target for? | 15:05 |
| robcresswell | Yeah, if it looks likely to merge soon, go for N-3, if not just hit Next. I pull them in from Next every now and then to keep track of whats gone in | 15:05 |
| matt-borland | Like, if a fix is present, target for next milesone? got it...thanks! | 15:05 |
| yohoffman | r1chardj0n3s: Regarding changing security rule name from "ALLOW -1:-1/icmp from 0.0.0.0/0" to "ALLOW any port/icmp from 0.0.0.0/0" for all ports, do you think we should keep "-1:-1" and mark this as not a bug? Or maybe change to "any_port", "anyport", or "any-port" instead of "any port"? | 15:06 |
| *** Liuqing has quit IRC | 15:07 | |
| yohoffman | Does anyone else think "ALLOW any port/icmp from 0.0.0.0/0" is more confusing than "ALLOW -1:-1/icmp from 0.0.0.0/0"? | 15:07 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Register apps in unit tests properly https://review.openstack.org/344879 | 15:07 |
| *** jplopezgu_ has joined #openstack-horizon | 15:07 | |
| *** uxdanielle has quit IRC | 15:08 | |
| *** rcernin has quit IRC | 15:09 | |
| *** pumaranikar_ has joined #openstack-horizon | 15:09 | |
| robcresswell | yohoffman: Better off asking neutron or ops than upstream horizon devs. | 15:09 |
| *** wolverineav has quit IRC | 15:09 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Register apps in unit tests properly https://review.openstack.org/344879 | 15:09 |
| *** rajalokan has joined #openstack-horizon | 15:11 | |
| *** uxdanielle has joined #openstack-horizon | 15:11 | |
| robcresswell | matt-borland: Yup :) | 15:11 |
| *** rcernin has joined #openstack-horizon | 15:12 | |
| robcresswell | matt-borland: I also have a new suggestion for tracking "priority items" which is a million items more easy than writing that wiki page | 15:12 |
| matt-borland | oh, cool! robcresswell | 15:12 |
| robcresswell | matt-borland: Realised I can do this: https://review.openstack.org/#/q/starredby:rob-cresswell+status:open | 15:12 |
| robcresswell | So I'll just star things and tell people to look at that list | 15:12 |
| matt-borland | heh heh, yeah, starred items | 15:12 |
| robcresswell | much faster | 15:12 |
| matt-borland | cool | 15:13 |
| robcresswell | The point is, I hadnt realise starred by others were exposed to the public | 15:13 |
| matt-borland | I just added a bookmark for "Rob's Fave Patches" | 15:13 |
| matt-borland | :) | 15:13 |
| robcresswell | So we can make use of that to focus on specific items | 15:13 |
| robcresswell | ha, so what you can do too is change the links under the "My" section in gerrit | 15:13 |
| robcresswell | And append the hash part of the URL | 15:14 |
| *** uxdanielle has quit IRC | 15:14 | |
| *** kbaikov has quit IRC | 15:15 | |
| robcresswell | matt-borland: Like the bottom of this img: http://imgur.com/a/KIxzp | 15:15 |
| *** cardeois has quit IRC | 15:16 | |
| robcresswell | I'll suggest it in the meeting anyway; its a good way of getting reviewers to focus on specific items I think. | 15:16 |
| matt-borland | sounds good | 15:16 |
| *** wolverineav has joined #openstack-horizon | 15:16 | |
| *** yingjun_ has joined #openstack-horizon | 15:17 | |
| *** yingjun_ has quit IRC | 15:17 | |
| *** yingjun_ has joined #openstack-horizon | 15:17 | |
| *** rafael__ has joined #openstack-horizon | 15:17 | |
| *** yingjun has quit IRC | 15:18 | |
| *** belmoreira has quit IRC | 15:18 | |
| *** rafael__ has quit IRC | 15:19 | |
| *** pumaranikar_ has quit IRC | 15:19 | |
| *** jplopezgu_ has quit IRC | 15:19 | |
| *** wolverineav has quit IRC | 15:20 | |
| *** jplopezgu_ has joined #openstack-horizon | 15:20 | |
| *** pumaranikar_ has joined #openstack-horizon | 15:21 | |
| *** kbaikov has joined #openstack-horizon | 15:22 | |
| *** rcernin has quit IRC | 15:22 | |
| *** yamamoto has quit IRC | 15:23 | |
| *** uxdanielle has joined #openstack-horizon | 15:23 | |
| *** tesseract- has quit IRC | 15:25 | |
| *** wolverineav has joined #openstack-horizon | 15:26 | |
| *** peristeri has quit IRC | 15:26 | |
| *** woodburn has joined #openstack-horizon | 15:26 | |
| *** sdake has quit IRC | 15:26 | |
| *** kbaikov has quit IRC | 15:29 | |
| *** dave-mccowan has quit IRC | 15:29 | |
| *** sdake has joined #openstack-horizon | 15:29 | |
| *** alexvictorchan has quit IRC | 15:29 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Add share replication support https://review.openstack.org/226389 | 15:30 |
| *** krotscheck is now known as krotscheck_dcm | 15:30 | |
| *** bpokorny has joined #openstack-horizon | 15:31 | |
| *** jplopezgu_ has quit IRC | 15:32 | |
| *** pumaranikar_ has quit IRC | 15:32 | |
| *** bpokorny has quit IRC | 15:32 | |
| zigo | File "/usr/lib/python2.7/dist-packages/django/views/generic/edit.py", line 93, in get_context_data | 15:35 |
| zigo | kwargs['form'] = self.get_form() | 15:35 |
| zigo | TypeError: get_form() takes exactly 2 arguments (1 given) | 15:35 |
| zigo | robcresswell: I've been trying to find out what's going on for what's above ^ | 15:36 |
| zigo | And I still don't understand even after a few hours of investigation. | 15:36 |
| robcresswell | zigo: form_class requires a default arg | 15:36 |
| zigo | There's only a single place where there's a get_form() function in Horizon. | 15:36 |
| zigo | openstack_dashboard/usage/base.py | 15:36 |
| zigo | Adding another param there don't fix it. | 15:37 |
| zigo | robcresswell: What function would that be? | 15:37 |
| *** lucas__ has joined #openstack-horizon | 15:38 | |
| robcresswell | Its just looking for a form class to use as a default | 15:38 |
| robcresswell | If one isnt defined | 15:38 |
| *** woodburn has quit IRC | 15:39 | |
| zigo | That's the first big class of issue for what's in openstack_dashboad, the 2nd one would be: | 15:40 |
| zigo | AttributeError: 'set' object has no attribute 'setdefault' | 15:40 |
| *** mvk has quit IRC | 15:40 | |
| zigo | Hopefully, I'll be able to investigate later on today. | 15:40 |
| zigo | Bye. | 15:40 |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Add share replication support https://review.openstack.org/226389 | 15:41 |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Flavors panel using Angular https://review.openstack.org/343917 | 15:41 |
| *** dave-mccowan has joined #openstack-horizon | 15:42 | |
| *** kbaikov has joined #openstack-horizon | 15:42 | |
| *** wolverineav has quit IRC | 15:44 | |
| openstackgerrit | Yosef Hoffman proposed openstack/horizon: Improve security rule notification message https://review.openstack.org/313086 | 15:44 |
| *** yingjun_ has quit IRC | 15:48 | |
| *** wolverineav has joined #openstack-horizon | 15:51 | |
| *** harlowja has quit IRC | 15:52 | |
| *** lucas__ has quit IRC | 15:57 | |
| openstackgerrit | Merged openstack/manila-ui: Updated from global requirements https://review.openstack.org/343711 | 15:57 |
| *** uxdanielle has quit IRC | 15:58 | |
| *** alexvictorchan has joined #openstack-horizon | 15:59 | |
| *** ygbo has quit IRC | 16:01 | |
| *** itxaka has quit IRC | 16:02 | |
| *** roxanaghe has joined #openstack-horizon | 16:02 | |
| *** ttrifonov has quit IRC | 16:08 | |
| *** davidc_ has quit IRC | 16:08 | |
| *** ttrifonov has joined #openstack-horizon | 16:10 | |
| *** drupalmonkey has joined #openstack-horizon | 16:10 | |
| *** roxanaghe has quit IRC | 16:11 | |
| *** TravT has quit IRC | 16:14 | |
| *** jprovazn has joined #openstack-horizon | 16:15 | |
| *** javeriak has joined #openstack-horizon | 16:15 | |
| *** wolverineav has quit IRC | 16:17 | |
| *** roxanaghe has joined #openstack-horizon | 16:17 | |
| *** roxanaghe has quit IRC | 16:18 | |
| *** roxanaghe has joined #openstack-horizon | 16:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/344312 | 16:18 |
| *** david-lyle has joined #openstack-horizon | 16:19 | |
| *** ChanServ sets mode: +o david-lyle | 16:19 | |
| *** tnovacik has quit IRC | 16:21 | |
| *** rajalokan has quit IRC | 16:21 | |
| *** wolverineav has joined #openstack-horizon | 16:21 | |
| *** jamielennox|away is now known as jamielennox | 16:23 | |
| *** yamamoto has joined #openstack-horizon | 16:24 | |
| *** javeriak has quit IRC | 16:26 | |
| *** wolverineav has quit IRC | 16:27 | |
| *** rafael__ has joined #openstack-horizon | 16:28 | |
| *** v12aml has quit IRC | 16:30 | |
| *** javeriak has joined #openstack-horizon | 16:31 | |
| *** yamamoto has quit IRC | 16:31 | |
| *** wolverineav has joined #openstack-horizon | 16:32 | |
| *** v12aml has joined #openstack-horizon | 16:33 | |
| matt-borland | Angular folks: Liuqing's patch: https://review.openstack.org/#/c/344819/ solves a bug due to changes to defaults in the registry...I gave a +1 but could use other perspectives. | 16:34 |
| *** uxdanielle has joined #openstack-horizon | 16:36 | |
| *** uxdanielle has quit IRC | 16:36 | |
| *** bpokorny has joined #openstack-horizon | 16:37 | |
| *** jtomasek has quit IRC | 16:38 | |
| *** wolverineav has quit IRC | 16:38 | |
| *** harlowja has joined #openstack-horizon | 16:40 | |
| *** wolverineav has joined #openstack-horizon | 16:40 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Add share replication support https://review.openstack.org/226389 | 16:42 |
| *** david-lyle has quit IRC | 16:42 | |
| *** vishwanathj has quit IRC | 16:44 | |
| robcresswell | ducttape_: So I did some more digging, and that patch with the missing key doesn't cause any issues with plugins functioning within Horizon | 16:45 |
| *** wolverineav has quit IRC | 16:46 | |
| robcresswell | ducttape_: The *only* time it arises is when a plugin is testing using an outdated test settings file | 16:46 |
| robcresswell | ducttape_: So the plugins aren'ty actually broken at all. its just a UT issue that arises from bad test config. | 16:46 |
| robcresswell | as far as I can tell | 16:46 |
| *** wolverineav has joined #openstack-horizon | 16:46 | |
| robcresswell | back in a bit | 16:47 |
| ducttape_ | k. I have some comments on this, I think | 16:48 |
| ducttape_ | robcresswell ping me when back | 16:48 |
| zigo | robcresswell: I've fixed the get_form() issue! :) | 16:51 |
| *** wolverineav has quit IRC | 16:52 | |
| *** wolverineav has joined #openstack-horizon | 16:53 | |
| openstackgerrit | Thomas Goirand proposed openstack/horizon: [Django 1.10] Fix get_form uses kwargs https://review.openstack.org/344931 | 16:55 |
| *** tnovacik has joined #openstack-horizon | 16:57 | |
| robcresswell | ducttape_: Back | 17:02 |
| *** rafael__ has quit IRC | 17:05 | |
| ducttape_ | ok | 17:06 |
| *** Marcellin_ has quit IRC | 17:07 | |
| ducttape_ | so you are saying that the plugins broke b/c the config is not up to date with new config settings | 17:07 |
| *** sdake has quit IRC | 17:07 | |
| ducttape_ | and I agree.... but it's on horizon to manage transition to new required configs | 17:07 |
| ducttape_ | tell others that stuff is going to break, etc | 17:08 |
| ducttape_ | give time to update things, so on | 17:08 |
| ducttape_ | either way I think horizon needs to write code that is more forgiving of old configs | 17:09 |
| ducttape_ | defensive programming, etc | 17:09 |
| * ducttape_ wonders if he is the crazy one | 17:10 | |
| *** javeriak_ has joined #openstack-horizon | 17:10 | |
| *** javeriak has quit IRC | 17:10 | |
| *** sdake has joined #openstack-horizon | 17:11 | |
| *** wolverineav has quit IRC | 17:11 | |
| robcresswell | Sure. I just wanted to clarify what caused this situation. | 17:11 |
| *** mpavlase has quit IRC | 17:11 | |
| robcresswell | Damn internet. | 17:11 |
| ducttape_ | the horizon plugin developers may or may not be watching every little horizon change to merge. in general, they have something that works and might be ignoring horizon day to day changes | 17:11 |
| ducttape_ | no worries ;) | 17:11 |
| robcresswell | Right, my implication was more that the way they appear to have set up test settings is very fragile | 17:12 |
| robcresswell | Thats on us to document better. | 17:12 |
| *** florianf has quit IRC | 17:12 | |
| ducttape_ | yes, this is all very fragile ;). The plugin framework stuff can be easily broken, and how to test plugins is an exercise left to the reader | 17:13 |
| *** wolverineav has joined #openstack-horizon | 17:13 | |
| *** sdake has quit IRC | 17:16 | |
| *** wolverineav has quit IRC | 17:19 | |
| *** wolverineav has joined #openstack-horizon | 17:20 | |
| robcresswell | ducttape_: I don't know if you've been following the mailer today, but would be interested to hear your thoughts | 17:21 |
| *** aortega has quit IRC | 17:22 | |
| ducttape_ | k. will read the mail list from my special email folder | 17:23 |
| *** _stowa has joined #openstack-horizon | 17:24 | |
| *** florianf has joined #openstack-horizon | 17:26 | |
| *** pcaruana has quit IRC | 17:27 | |
| *** jtomasek has joined #openstack-horizon | 17:31 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Add more Nova API features for NG Instances https://review.openstack.org/344949 | 17:32 |
| *** _stowa has quit IRC | 17:32 | |
| *** wolverineav has quit IRC | 17:36 | |
| *** dave-mccowan has quit IRC | 17:37 | |
| *** dan_nguyen has joined #openstack-horizon | 17:39 | |
| *** hoonetorg has quit IRC | 17:40 | |
| *** ducttape_ has quit IRC | 17:43 | |
| *** sjmc7 has quit IRC | 17:51 | |
| *** tosky has quit IRC | 17:51 | |
| *** hoonetorg has joined #openstack-horizon | 17:54 | |
| *** wolverineav has joined #openstack-horizon | 17:55 | |
| *** wolverineav has joined #openstack-horizon | 17:55 | |
| *** dave-mccowan has joined #openstack-horizon | 17:57 | |
| *** matt-borland has quit IRC | 18:05 | |
| *** tqtran has joined #openstack-horizon | 18:05 | |
| *** sjmc7 has joined #openstack-horizon | 18:06 | |
| *** Tamayo has quit IRC | 18:08 | |
| *** Tamayo has joined #openstack-horizon | 18:14 | |
| *** harlowja has quit IRC | 18:19 | |
| *** btully has quit IRC | 18:21 | |
| *** ducttape_ has joined #openstack-horizon | 18:28 | |
| *** _ducttape_ has joined #openstack-horizon | 18:29 | |
| *** clu_ has joined #openstack-horizon | 18:32 | |
| *** ChanServ sets mode: +v clu_ | 18:32 | |
| *** dan_nguyen has quit IRC | 18:32 | |
| *** ducttape_ has quit IRC | 18:33 | |
| *** tmazur has quit IRC | 18:34 | |
| *** uxdanielle has joined #openstack-horizon | 18:34 | |
| *** dan_nguyen has joined #openstack-horizon | 18:34 | |
| *** pkarikh has quit IRC | 18:37 | |
| *** asettle has quit IRC | 18:38 | |
| *** katyafervent_awa has quit IRC | 18:39 | |
| *** kzaitsev_ws has quit IRC | 18:39 | |
| *** tsufiev has quit IRC | 18:39 | |
| *** matt-borland has joined #openstack-horizon | 18:39 | |
| *** javeriak has joined #openstack-horizon | 18:39 | |
| *** asettle has joined #openstack-horizon | 18:40 | |
| *** javeriak_ has quit IRC | 18:42 | |
| *** asettle has quit IRC | 18:45 | |
| *** bpokorny_ has joined #openstack-horizon | 18:45 | |
| *** roxanaghe has quit IRC | 18:46 | |
| *** pcaruana has joined #openstack-horizon | 18:48 | |
| *** bpokorny has quit IRC | 18:49 | |
| *** bpokorny_ has quit IRC | 18:49 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Flavors panel using Angular https://review.openstack.org/343917 | 18:50 |
| *** vishwanathj has joined #openstack-horizon | 18:52 | |
| *** matt-borland has quit IRC | 18:55 | |
| *** asettle has joined #openstack-horizon | 18:55 | |
| *** _ducttape_ has quit IRC | 18:59 | |
| *** ducttape_ has joined #openstack-horizon | 18:59 | |
| *** matt-borland has joined #openstack-horizon | 18:59 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: NG Images Create Volume should use constant from images.module.js https://review.openstack.org/344989 | 19:00 |
| *** bpokorny has joined #openstack-horizon | 19:00 | |
| *** asettle has quit IRC | 19:01 | |
| *** piet_ has joined #openstack-horizon | 19:02 | |
| matt-borland | clu_, thanks for the review! I | 19:02 |
| matt-borland | will follow up shortly. | 19:02 |
| clu_ | np matt-borland :) | 19:05 |
| tqtran | matt-borland: gm matt, got a question for you | 19:06 |
| matt-borland | hey tqtran, what's up | 19:06 |
| matt-borland | ? | 19:06 |
| tqtran | i remember tyr did something with promises to replace the events | 19:07 |
| openstackgerrit | Daniel Castellanos proposed openstack/horizon: Removed inline_edit functionality for tables https://review.openstack.org/343861 | 19:07 |
| matt-borland | tqtran, basically actions return promises. | 19:07 |
| *** dan_nguyen has quit IRC | 19:07 | |
| tqtran | what did they return before? | 19:07 |
| matt-borland | in particular, *perform* returns a promise | 19:07 |
| matt-borland | nothing | 19:07 |
| matt-borland | they just wandered off and did things | 19:08 |
| tqtran | we wanted perform to return a promise for what reasons again? | 19:08 |
| matt-borland | so we can react to the completion of the action | 19:08 |
| matt-borland | that is, figure out if we need to refresh a display, or whatever behavior is appropriate | 19:08 |
| tqtran | and the table controller is listenting to this how? | 19:09 |
| matt-borland | if you look at the result handler features, that will give you some perspective on that | 19:09 |
| matt-borland | it will basically use a .then(...) on the promise that the action returned | 19:09 |
| tqtran | lets say i just added a new instance via an action, and i want to update the instances table | 19:09 |
| tqtran | can you give me a link to github with the xample in mind? | 19:10 |
| matt-borland | first off, most of that is handled for you if your promises' resolve item indicates updates. | 19:10 |
| tqtran | i gotta run for a bit but will be back and talk more | 19:10 |
| matt-borland | no problem, it's a useful topic | 19:10 |
| *** tqtran is now known as tqtran-afk | 19:10 | |
| *** javeriak has quit IRC | 19:11 | |
| *** javeriak has joined #openstack-horizon | 19:12 | |
| *** roxanaghe has joined #openstack-horizon | 19:13 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Image uses hz-property for its drawer information https://review.openstack.org/334083 | 19:14 |
| matt-borland | clu_, ^^ Updated per your comments | 19:15 |
| *** harlowja has joined #openstack-horizon | 19:19 | |
| *** peristeri has joined #openstack-horizon | 19:21 | |
| *** peristeri has quit IRC | 19:21 | |
| *** peristeri has joined #openstack-horizon | 19:22 | |
| *** zackf has quit IRC | 19:28 | |
| *** zackf has joined #openstack-horizon | 19:29 | |
| openstackgerrit | Eddie Ramirez proposed openstack/horizon: WIP: Fix Sort Indicator Position https://review.openstack.org/345001 | 19:29 |
| *** ducttape_ has quit IRC | 19:32 | |
| *** zackf has quit IRC | 19:33 | |
| *** jprovazn has quit IRC | 19:36 | |
| *** harlowja has quit IRC | 19:36 | |
| *** sdake has joined #openstack-horizon | 19:38 | |
| *** pkarikh has joined #openstack-horizon | 19:40 | |
| *** katyafervent_awa has joined #openstack-horizon | 19:43 | |
| *** dan_nguyen has joined #openstack-horizon | 19:44 | |
| *** revon has joined #openstack-horizon | 19:45 | |
| *** tsufiev has joined #openstack-horizon | 19:46 | |
| *** ChanServ sets mode: +v tsufiev | 19:46 | |
| *** sdake has quit IRC | 19:47 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:52 | |
| *** tnovacik has quit IRC | 19:52 | |
| openstackgerrit | Eddie Ramirez proposed openstack/horizon: More filters in servers (Nova) https://review.openstack.org/332922 | 19:55 |
| *** asettle has joined #openstack-horizon | 19:58 | |
| *** Tamayo has quit IRC | 19:58 | |
| *** Liuqing has joined #openstack-horizon | 19:58 | |
| *** asettle has quit IRC | 19:58 | |
| *** dan_nguyen has quit IRC | 19:59 | |
| openstackgerrit | Eddie Ramirez proposed openstack/horizon: Server-side filtering Identity https://review.openstack.org/324112 | 20:00 |
| *** Marcellin_ has joined #openstack-horizon | 20:00 | |
| *** Tamayo has joined #openstack-horizon | 20:00 | |
| *** dan_nguyen has joined #openstack-horizon | 20:01 | |
| robcresswell | Meeting in #openstack-meeting-3 | 20:01 |
| *** Tamayo has quit IRC | 20:01 | |
| *** Tamayo has joined #openstack-horizon | 20:02 | |
| *** julim has joined #openstack-horizon | 20:02 | |
| *** btully has joined #openstack-horizon | 20:08 | |
| *** btully has quit IRC | 20:12 | |
| *** uxdanielle has quit IRC | 20:18 | |
| *** peristeri has quit IRC | 20:25 | |
| *** TravT has joined #openstack-horizon | 20:25 | |
| *** ChanServ sets mode: +v TravT | 20:25 | |
| *** jtriley_ has joined #openstack-horizon | 20:31 | |
| *** javeriak has quit IRC | 20:33 | |
| *** uxdanielle has joined #openstack-horizon | 20:34 | |
| *** jtriley has quit IRC | 20:34 | |
| *** jtriley_ has quit IRC | 20:36 | |
| *** florianf has quit IRC | 20:38 | |
| *** lblanchard has quit IRC | 20:41 | |
| *** dan_nguyen has quit IRC | 20:46 | |
| *** dan_nguyen has joined #openstack-horizon | 20:47 | |
| *** bpokorny has quit IRC | 20:48 | |
| *** wolverin_ has joined #openstack-horizon | 20:50 | |
| *** wolverin_ has quit IRC | 20:51 | |
| *** wolverin_ has joined #openstack-horizon | 20:52 | |
| *** pcaruana has quit IRC | 20:53 | |
| *** wolverineav has quit IRC | 20:53 | |
| *** NightKhaos has quit IRC | 20:54 | |
| *** jerrygb has quit IRC | 20:56 | |
| *** wolverin_ has quit IRC | 20:57 | |
| *** piet_ has quit IRC | 20:57 | |
| *** matt-borland has quit IRC | 20:58 | |
| *** xiong has joined #openstack-horizon | 20:58 | |
| *** gyee has joined #openstack-horizon | 21:00 | |
| *** bpokorny has joined #openstack-horizon | 21:02 | |
| *** jerrygb has joined #openstack-horizon | 21:02 | |
| *** PatSplinter1 has joined #openstack-horizon | 21:05 | |
| *** PatSplinter has quit IRC | 21:05 | |
| xiong | r1chardj0n3s: Hey richard, I've created a panel that makes an API call to a neutron plugin, but my GUI doesn't automatically update after making it. Are you familiar with where and how the current images panel automatically updates when an image is created? | 21:07 |
| *** Tamayo has quit IRC | 21:07 | |
| *** mpavlase has joined #openstack-horizon | 21:07 | |
| Liuqing | status choice make that works | 21:09 |
| Liuqing | in table | 21:09 |
| r1chardj0n3s | morning | 21:11 |
| *** Liuqing has quit IRC | 21:12 | |
| r1chardj0n3s | xiong: I didn't code that panel but I believe it uses the ActionResult mechanism to communicate changes like that from actions to the the table | 21:12 |
| *** NightKhaos has joined #openstack-horizon | 21:13 | |
| tyr | xiong: are you talking about the Django images panel? | 21:14 |
| tyr | Most actions implemented on the Django side return a redirect to the browser in response to the form submit. Often, this is used to re-load the list of resources such as images. | 21:14 |
| tyr | the exact behavior is action dependent. As we move to Angular, the pattern becomes make a REST call for the action (such as create image). The response is parsed by the client-side action into an ActionResult promise that the panel can use (or not) to reload all rows, some rows, highlight "dirty" rows, etc. | 21:17 |
| tyr | if you are using hz-dynamic-table directive, the ActionResult promise will be returned to you via the "resultHandler" callback. | 21:18 |
| openstackgerrit | Daniel Castellanos proposed openstack/horizon: Removed inline_edit functionality for tables https://review.openstack.org/343861 | 21:19 |
| lcastell | morning r1chardj0n3s | 21:20 |
| tyr | alternatively, you can simply use hz-resource-table directive, which implements an ActionResult handler to automatically reload data on action completion. | 21:20 |
| *** bpokorny has quit IRC | 21:20 | |
| *** bpokorny has joined #openstack-horizon | 21:21 | |
| *** xiong has quit IRC | 21:22 | |
| *** tqtran-afk is now known as tqtran | 21:22 | |
| *** gyee has quit IRC | 21:22 | |
| *** pauloewerton has quit IRC | 21:26 | |
| *** gyee has joined #openstack-horizon | 21:26 | |
| *** NightKhaos has quit IRC | 21:28 | |
| *** jerrygb has quit IRC | 21:32 | |
| *** mpavlase has quit IRC | 21:37 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Flavors panel using Angular https://review.openstack.org/343917 | 21:38 |
| *** darrenc is now known as darrenc_afk | 21:41 | |
| *** PatSplinter1 has quit IRC | 21:41 | |
| openstackgerrit | Yosef Hoffman proposed openstack/horizon: Use nav-tabs in workflows https://review.openstack.org/345062 | 21:43 |
| *** PatSplinter has joined #openstack-horizon | 21:44 | |
| *** xiong has joined #openstack-horizon | 21:47 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Adding project name column to ng images https://review.openstack.org/339256 | 21:48 |
| *** NightKhaos has joined #openstack-horizon | 21:50 | |
| xiong | tyr: Sorry I stepped away a moment. I am talking about the angular side of things. Currently, I use hz-resource-table in my panel.html, and register an action with my resource. | 21:52 |
| *** yohoffman has quit IRC | 21:53 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Schema Form Modal Service https://review.openstack.org/345067 | 21:53 |
| xiong | Then for the back end, I have a service that opens the modal and sends the data to the API. I see the result service that people have mentioned in the ngimages version of things | 21:53 |
| tyr | robcresswell: See https://review.openstack.org/345067 Schema Form Modal Service | 21:53 |
| xiong | Do I just return actionResultService.getActionResult().created(resourceType, data).result; ? | 21:54 |
| tyr | yes, but strike the ".result" | 21:55 |
| *** uxdanielle has quit IRC | 21:56 | |
| tyr | the idea is that any client side "action" returns a promise that contains standardized data. In this way, the action that you register as an OS::Glance::Image action, can be called by anyone, even if they didn't know your action existed. | 21:57 |
| tyr | because the return is a promise, the caller can tell when the action completes (or not), and because it contains an ActionResult object...the caller knows if you have "updated", "deleted" or "created" any items...and the type of those items. | 21:58 |
| tyr | the caller can then decide if it cares about those types. For example, you can "create volume from image" which is an image action...but returns a volume...so the images page can choose to ignore the returned data. | 21:59 |
| tyr | sorry, I might have confused the promise and return type. I meant that the action "perform" method should return a promise that resolves when the action is complete. | 22:02 |
| tyr | and the promise should resolve with an ActionResult object as data. Promise chaining is used to make that all work. Let me know if you need examples. | 22:03 |
| xiong | Hm, let me give it a try, and I'll ping you if I need something more concrete to look at | 22:04 |
| *** TravT_ has joined #openstack-horizon | 22:09 | |
| *** ChanServ sets mode: +v TravT_ | 22:09 | |
| *** mvk has joined #openstack-horizon | 22:09 | |
| openstackgerrit | Steve McLellan proposed openstack/horizon: WIP Swift account quota support https://review.openstack.org/345071 | 22:10 |
| *** harlowja has joined #openstack-horizon | 22:11 | |
| *** TravT has quit IRC | 22:11 | |
| *** harlowja has quit IRC | 22:11 | |
| *** piet_ has joined #openstack-horizon | 22:13 | |
| *** sjmc7 has quit IRC | 22:14 | |
| *** uxdanielle has joined #openstack-horizon | 22:16 | |
| *** TravT_ has quit IRC | 22:22 | |
| *** darrenc_afk is now known as darrenc | 22:24 | |
| *** purva has quit IRC | 22:24 | |
| r1chardj0n3s | yo tqtran | 22:31 |
| *** jerrygb has joined #openstack-horizon | 22:33 | |
| tqtran | r1chardj0n3s: shello | 22:34 |
| *** wolverineav has joined #openstack-horizon | 22:34 | |
| r1chardj0n3s | ohai, just read your initScope response, thanks! | 22:35 |
| r1chardj0n3s | I'll respond in email, but I did want to pick your brain about the re-use aspect of the workflow steps: do you have a concrete example of where that would be used, because it seems we're jumping through hoops to support it without one (ie. YAGNI) | 22:35 |
| tqtran | yeah, the metadata update step is an example | 22:36 |
| tqtran | let me double check and see if i can find a reference to it | 22:37 |
| r1chardj0n3s | any others? | 22:37 |
| tqtran | so far thats the only one | 22:37 |
| tqtran | i know that doug-fish argued strongly for it when he was around | 22:37 |
| r1chardj0n3s | so if we ignore re-use, the data model becomes a lot simpler and events are unnecessary AFAICT | 22:38 |
| tqtran | his team did more of the plugin work, i just helped lay the foundation for it | 22:38 |
| r1chardj0n3s | and re-use is, as far as I can tell, only potentially useful in one step type | 22:38 |
| tqtran | i actually think it might be ok, you can still do the workflow.model thing | 22:38 |
| tqtran | and still have the step controllers be independent | 22:39 |
| *** piet_ has quit IRC | 22:39 | |
| tqtran | workflow.model defines an empty object, which the steps controller will populate | 22:39 |
| tqtran | and you can still share data between steps via scope.$watch | 22:39 |
| r1chardj0n3s | the schemaform changes will potentially make that reuse stuff a lot easier too | 22:39 |
| *** piet_ has joined #openstack-horizon | 22:39 | |
| r1chardj0n3s | since the form model will be defined at a higher level, so should be shareable | 22:39 |
| *** jerrygb has quit IRC | 22:39 | |
| tqtran | yeah, thats true | 22:40 |
| r1chardj0n3s | yep, the *key* change is that the scope stuff isn't done in a *service* but rather in controllers which *have* scopes, unlike services :-) | 22:40 |
| r1chardj0n3s | watching is definitely still necessary | 22:40 |
| tqtran | yes, but the thing is, your step controller has a different scope than your table controller | 22:41 |
| r1chardj0n3s | yeah, the table scope -> workflow controller scope -> [n step controller scopes] | 22:41 |
| tqtran | yes, thats the way it works today, and we are able to do it because we initScope | 22:41 |
| r1chardj0n3s | oh, hmm, no the workflow controller scope is aside it in the modal | 22:41 |
| r1chardj0n3s | so the *workflow controller* should be manually scoped, not the action | 22:42 |
| r1chardj0n3s | lemme just rewrite that | 22:42 |
| tqtran | the scope gets pass onto the $modal with then launches the workflow with the scope taken from table | 22:42 |
| r1chardj0n3s | yes, but at the moment that scope capture is done in the service, which is bad (do we agree on that?) when it should be done in the workflow controller | 22:42 |
| tqtran | let me reword that: the scope from the table is propagated from table -> $modal -> workflow -> steps | 22:43 |
| tqtran | i agree it is bad, yes | 22:43 |
| tqtran | but i dont see a workaround atm. | 22:43 |
| r1chardj0n3s | I do :-) | 22:43 |
| tqtran | if you launched the $modal from the table controller, then you avoid the initScope | 22:44 |
| r1chardj0n3s | so I think that the action perform() needs to require a scope which is passed through to the modal controller (ie. the workflow controller) | 22:44 |
| tqtran | what is the workaround you have in mind? | 22:44 |
| tqtran | and where does the workflow controller gets its scope? | 22:45 |
| r1chardj0n3s | gimme a sec, just confirming something | 22:46 |
| r1chardj0n3s | I'm pretty sure the workflow controller *is* the $modal controller | 22:46 |
| r1chardj0n3s | ah, no, there's a generic WizardModalController in-between | 22:47 |
| tqtran | i believe the wizard modal controller launches the $modal | 22:47 |
| tqtran | and guess where $modal gets it scope from :P | 22:48 |
| tqtran | the table controller | 22:48 |
| r1chardj0n3s | the WizardModalService invokes $modal.open | 22:48 |
| tqtran | right | 22:48 |
| r1chardj0n3s | ... which is hard-coded to use WizardModalController | 22:48 |
| r1chardj0n3s | but it does so using the scope passed in | 22:48 |
| r1chardj0n3s | (the scope passed to WizardModalService.modal) | 22:49 |
| tyr | r1chardj0n3s: what are the events in question. Is there a reason data binding isn't appropriate? | 22:49 |
| r1chardj0n3s | *that* is currently taken from the action service invoking the modal | 22:49 |
| r1chardj0n3s | tyr: tqtran is arguiing that events need to propogate out from the workflow, yes, though I'm not sure which ones | 22:50 |
| r1chardj0n3s | I think that ActionResult was intended to replace all that though | 22:50 |
| *** bpokorny has quit IRC | 22:50 | |
| *** itisha has quit IRC | 22:50 | |
| r1chardj0n3s | (since workflows are created as part of an action) | 22:50 |
| tqtran | r1chardj0n3s: yeah, action result was intended to replace events | 22:50 |
| *** wolverineav has quit IRC | 22:50 | |
| tqtran | but my argument is, i still think that you need to initScope (especially if you are going to be watching models in the steps controller) | 22:51 |
| r1chardj0n3s | *inside* the workflow, we can definitely do data binding and watching inside the workflow scope independently of the table | 22:51 |
| r1chardj0n3s | tqtran: ^^ :-) | 22:51 |
| tqtran | i think some code will go a long way | 22:51 |
| tqtran | right now, we could just be talking pass each other | 22:51 |
| tyr | is this a patch currently? | 22:51 |
| r1chardj0n3s | no, but it will be soon, I hope | 22:51 |
| tqtran | it is not, we are talking about it | 22:52 |
| r1chardj0n3s | (that I will write) | 22:52 |
| xiong | tyr: Have a question about the actionResultService, but don't want to mix up tqtran and r1chardj0n3s conversation. Is there a way to unicast you? Alternatively, I don't mind waiting | 22:52 |
| *** catintheroof has joined #openstack-horizon | 22:52 | |
| r1chardj0n3s | tqtran / tyr : I will respond to Thai's email and look into a concrete patch | 22:52 |
| tyr | r1chardj0n3s: Please add me as a reviewer to that (future) patch. I have particular interest in seeing data binding usage spread | 22:53 |
| r1chardj0n3s | tyr: did you see the email? | 22:53 |
| *** TravT has joined #openstack-horizon | 22:53 | |
| tyr | *the* email? :) no. | 22:53 |
| r1chardj0n3s | we don't get *that* much [Horizon] email :-P | 22:53 |
| *** ChanServ sets mode: +v TravT | 22:53 | |
| tyr | outlook hides it somewhere on me | 22:54 |
| r1chardj0n3s | "[Horizon] Angular action services and initScope" in openstack-dev | 22:54 |
| r1chardj0n3s | your thoughts would be appreciated | 22:54 |
| r1chardj0n3s | I'm worried that changes I make in this sort of patch will be out of date when robcresswell's schemaform patch lands though | 22:55 |
| *** asettle has joined #openstack-horizon | 22:55 | |
| r1chardj0n3s | but I'll have a crack anyway, to get the general idea across | 22:55 |
| *** wolverineav has joined #openstack-horizon | 22:55 | |
| *** bpokorny has joined #openstack-horizon | 22:55 | |
| tyr | fwiw, I haven't even coded initScope in any actions for months | 22:56 |
| r1chardj0n3s | that's because you're a good person tyr | 22:57 |
| tyr | lol...I just meant, outside of workflows, the conversion to returning action promises eliminated the need | 22:57 |
| tyr | and thank you. At least somebody thinks so. | 22:57 |
| r1chardj0n3s | yep | 22:57 |
| * r1chardj0n3s blames a lot of confusion for AngularJS calling things "factory" when they're not | 22:58 | |
| r1chardj0n3s | service and factory being basically exactly the same thing, only *slightly* different in a way that doesn't really matter at all and yet we have those two things like they *seem* to be different to newbies (and some experienced folks) | 22:59 |
| r1chardj0n3s | (and their docs etc. all just revert to "factory() returns a service" which triply-confuses things) | 22:59 |
| r1chardj0n3s | ugh | 23:00 |
| tyr | you are interested in cleaning up workflows in particualr? | 23:00 |
| tyr | perhaps isolating the steps as individual actions? | 23:00 |
| *** harlowja has joined #openstack-horizon | 23:00 | |
| r1chardj0n3s | Foremost is nuking initScope across the board; to do so I will most likely need to make some changes to workflow, hopefully not too drastic (the email talks about the changes in a broad sense) | 23:01 |
| tyr | roger. I'm a big fan | 23:02 |
| tyr | have to run, but feel free to loop me in on further developments. | 23:02 |
| r1chardj0n3s | I'll be keeping that email discussion up to date | 23:02 |
| tyr | I resubscribed to the list. | 23:03 |
| *** tyr has quit IRC | 23:03 | |
| *** harlowja has quit IRC | 23:03 | |
| r1chardj0n3s | \o/ | 23:04 |
| r1chardj0n3s | fwiw I mark [Horizon] and [all] interesting, and everything else goes into to an easy-to-delete folder ;-) | 23:04 |
| r1chardj0n3s | keeps the noise under control | 23:04 |
| *** alexvictorchan has quit IRC | 23:05 | |
| xiong | r1chardj0n3s: Do you know anybody other than tyr that is familiar w/ the ngimages panel/how actionResultServices are handled? | 23:05 |
| r1chardj0n3s | xiong: I am somewhat familiar with that stuff though I've not implemented anything using it yet | 23:05 |
| xiong | Do you mind helping me out? I was just going to ask him about getting the angular page to autoupdate after an API call. | 23:06 |
| xiong | He mentioned returning an actionResultService being passed as the resolve value of a promise from the perform() function in the action service | 23:07 |
| *** TravT has quit IRC | 23:07 | |
| *** harlowja has joined #openstack-horizon | 23:07 | |
| r1chardj0n3s | yep | 23:07 |
| r1chardj0n3s | are you using hz-dynamic-table or hz-resource-table for your table rendering? | 23:07 |
| xiong | My understanding is that if I return one of those promises, whatever function in the framework calls the service will also be responsible for updating after the API call, is that correct? | 23:08 |
| xiong | hz-resource-table | 23:08 |
| openstackgerrit | Merged openstack/horizon: Image uses hz-property for its drawer information https://review.openstack.org/334083 | 23:08 |
| r1chardj0n3s | hz-dynamic-table and hz-resource-table have methods of handling ActionResults from a perform() ... dynamic is manual (through an explicit handler provided to the directive) and resource is automatic | 23:08 |
| r1chardj0n3s | so it should be updated automatically | 23:09 |
| xiong | So as long as that action is registered to the resource type, the hz-resource-table that uses that resource type will automatically update? | 23:09 |
| r1chardj0n3s | see actions/create-volume.service.js in the ngimages | 23:09 |
| r1chardj0n3s | app/core/images/actions... that is | 23:10 |
| *** revon has quit IRC | 23:10 | |
| r1chardj0n3s | you can see that the perform() creates a modal, which when it resolves will invoke submit() which when it resolves invokes showSuccessMessage which right at the end returns the action result which is propogated all the way back through all those promises | 23:11 |
| *** TravT has joined #openstack-horizon | 23:11 | |
| *** ChanServ sets mode: +v TravT | 23:11 | |
| r1chardj0n3s | and that is handled automatically by hz-resource-table | 23:11 |
| xiong | Right, that's what I'm trying to emulate, but I can't seem to get the update | 23:11 |
| r1chardj0n3s | so yes, the resource type code must match | 23:12 |
| r1chardj0n3s | we use injectables to ensure we get the type code correct | 23:12 |
| r1chardj0n3s | volumeResourceType in the create-volume case | 23:12 |
| *** harlowja has quit IRC | 23:12 | |
| r1chardj0n3s | (that should really be volumeResourceTypeCode, but alas) | 23:12 |
| xiong | Hm, I will take another look at my code because it seems my understanding was correct | 23:15 |
| xiong | The other thing I'm curious about is the initScope function that's in some of the services | 23:15 |
| xiong | I took a peek at what you guys were talking about above, and it seems like that's not essential? and that you want to get rid of it? | 23:15 |
| r1chardj0n3s | xiong: it's definitely not essential and yes I wish to nuke it | 23:16 |
| xiong | It looked like a way to set up watchers on certain fields in workflows, is that right? | 23:16 |
| r1chardj0n3s | you can definitely write action services which don't need to use it | 23:16 |
| r1chardj0n3s | something like that yes | 23:16 |
| xiong | Ok, but I guess the bottom line is that I'll live just fine not knowing what it does :P | 23:17 |
| *** Marcellin_ has quit IRC | 23:17 | |
| xiong | Thanks for clarifying :) helps a lot | 23:18 |
| r1chardj0n3s | yep :-) | 23:20 |
| *** asettle has quit IRC | 23:21 | |
| *** TravT has quit IRC | 23:25 | |
| xiong | r1chardj0n3s: In my panel, I'm not using the wizardModalService that create-volume.service.js and create.action.service.js use. Is it important that I use that in order for hz-resource-table to autoupdate? I'm returning a actionResult like the two services, and the only difference I can tell is that I don't use the wizard. | 23:29 |
| r1chardj0n3s | no, if you don't have a wizard/workflow then you don't need to use that thing | 23:29 |
| *** roxanaghe has quit IRC | 23:35 | |
| *** jerrygb has joined #openstack-horizon | 23:35 | |
| *** alexvictorchan has joined #openstack-horizon | 23:39 | |
| *** jerrygb has quit IRC | 23:41 | |
| *** btully has joined #openstack-horizon | 23:45 | |
| openstackgerrit | Timur Sufiev proposed openstack/horizon: Allow wiring of <hz-dynamic-table> into <transfer-table> https://review.openstack.org/326641 | 23:47 |
| *** zhurong has joined #openstack-horizon | 23:48 | |
| *** btully has quit IRC | 23:50 | |
| *** kzaitsev_mb has quit IRC | 23:53 | |
| *** uxdanielle has quit IRC | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
