Friday, 2016-07-29

*** piet has joined #openstack-horizon00:02
*** wolverineav has quit IRC00:12
*** wolverineav has joined #openstack-horizon00:13
*** wolverineav has quit IRC00:14
*** wolverineav has joined #openstack-horizon00:15
*** yingjun has joined #openstack-horizon00:16
*** sdake has quit IRC00:23
*** cloudtrainme has quit IRC00:24
*** hwcomcn has joined #openstack-horizon00:24
*** tqtran has quit IRC00:25
*** yamamoto_ has joined #openstack-horizon00:25
*** cloudtrainme has joined #openstack-horizon00:26
*** ircuser-1 has quit IRC00:28
*** chasmo77 has quit IRC00:28
*** yamamoto_ has quit IRC00:31
*** cloudtrainme has quit IRC00:31
*** btully has quit IRC00:32
*** btully has joined #openstack-horizon00:37
*** uxdanielle has joined #openstack-horizon00:46
*** piet has quit IRC00:48
*** btully has quit IRC00:49
*** piet has joined #openstack-horizon00:49
*** jamielennox is now known as jamielennox|away00:49
*** aortega has quit IRC00:54
*** hwcomcn has quit IRC00:55
*** gyee has quit IRC00:57
*** btully has joined #openstack-horizon01:00
openstackgerritKenji Ishii proposed openstack/horizon: Fix untranslated strings  https://review.openstack.org/34772501:01
*** roxanaghe has joined #openstack-horizon01:03
openstackgerritKenji Ishii proposed openstack/horizon: Fix untranslated strings  https://review.openstack.org/34772501:03
*** ducttape_ has quit IRC01:04
*** ducttape_ has joined #openstack-horizon01:06
openstackgerritTravis Tripp proposed openstack/horizon: hz-dynamic-table: Column level permissions  https://review.openstack.org/34624901:07
*** jtriley has joined #openstack-horizon01:07
*** roxanaghe has quit IRC01:07
*** wolverin_ has joined #openstack-horizon01:08
*** bpokorny has quit IRC01:10
*** itisha has quit IRC01:10
*** wolverineav has quit IRC01:11
*** Liuqing has joined #openstack-horizon01:12
*** wolverin_ has quit IRC01:12
*** zhurong has joined #openstack-horizon01:12
*** sdake has joined #openstack-horizon01:13
*** sdake has quit IRC01:13
*** sdake has joined #openstack-horizon01:13
*** sdake_ has joined #openstack-horizon01:15
*** pt_15 has quit IRC01:16
openstackgerritTravis Tripp proposed openstack/horizon: hz-dynamic-table: Column level permissions  https://review.openstack.org/34624901:16
*** sdake has quit IRC01:18
openstackgerritTravis Tripp proposed openstack/horizon: hz-dynamic-table: Column level permissions  https://review.openstack.org/34624901:20
*** TravT has quit IRC01:21
*** asettle has joined #openstack-horizon01:22
*** yamamoto_ has joined #openstack-horizon01:27
*** asettle has quit IRC01:27
*** piet has quit IRC01:30
*** Daisy has joined #openstack-horizon01:30
*** piet has joined #openstack-horizon01:30
*** yamamoto_ has quit IRC01:32
*** Daisy has quit IRC01:33
*** jamielennox|away is now known as jamielennox01:34
openstackgerritKenji Ishii proposed openstack/horizon: Support fixed ip address when attaching interface  https://review.openstack.org/33384601:36
openstackgerritKenji Ishii proposed openstack/horizon: Fix the issue workflow filter do not show all users  https://review.openstack.org/31848501:36
*** aortega has joined #openstack-horizon01:40
*** piet has quit IRC01:41
*** jtriley has quit IRC01:41
*** TravT has joined #openstack-horizon01:49
*** ChanServ sets mode: +v TravT01:49
*** Daisy has joined #openstack-horizon01:51
*** TravT has quit IRC01:54
*** TravT has joined #openstack-horizon01:58
*** ChanServ sets mode: +v TravT01:58
*** TravT has quit IRC01:58
*** bpokorny has joined #openstack-horizon02:07
*** btully has quit IRC02:09
*** ducttape_ has quit IRC02:10
*** bpokorny has quit IRC02:11
*** btully has joined #openstack-horizon02:15
*** btully has quit IRC02:19
*** sdake_ has quit IRC02:19
*** zhurong has quit IRC02:24
*** zhurong has joined #openstack-horizon02:24
*** yamamoto_ has joined #openstack-horizon02:28
*** Daisy has quit IRC02:29
*** Liuqing has quit IRC02:32
*** jamielennox is now known as jamielennox|away02:32
*** Liuqing has joined #openstack-horizon02:33
*** yamamoto_ has quit IRC02:34
*** _ducttape_ has joined #openstack-horizon02:35
*** Liuqing has quit IRC02:37
*** uxdanielle has quit IRC02:38
*** btully has joined #openstack-horizon02:38
*** Liuqing has joined #openstack-horizon02:39
*** Daisy has joined #openstack-horizon02:39
*** TravT has joined #openstack-horizon02:43
*** ChanServ sets mode: +v TravT02:43
*** btully has quit IRC02:51
*** btully has joined #openstack-horizon03:02
*** _ducttape_ has quit IRC03:04
*** ducttape_ has joined #openstack-horizon03:05
*** ducttape_ has quit IRC03:05
*** btully has quit IRC03:07
*** bpokorny has joined #openstack-horizon03:08
*** TravT has quit IRC03:10
*** TravT has joined #openstack-horizon03:11
*** ChanServ sets mode: +v TravT03:11
*** btully has joined #openstack-horizon03:12
*** bpokorny has quit IRC03:14
*** TravT has quit IRC03:15
*** Daisy has quit IRC03:16
*** Daisy has joined #openstack-horizon03:18
*** btully has quit IRC03:23
openstackgerritEddie Ramirez proposed openstack/horizon: Server-side filtering for Instances (Project/Admin)  https://review.openstack.org/33292203:26
*** yamamoto_ has joined #openstack-horizon03:31
openstackgerritgecong proposed openstack/horizon: modify the home-page info with the developer documentation  https://review.openstack.org/34871003:32
*** yamamoto_ has quit IRC03:36
*** ducttape_ has joined #openstack-horizon03:37
*** btully has joined #openstack-horizon03:37
*** yamamoto_ has joined #openstack-horizon03:44
*** liuyulong has joined #openstack-horizon03:45
*** btully has quit IRC03:50
*** zackf has quit IRC03:52
*** ducttape_ has quit IRC03:58
*** adriant has joined #openstack-horizon03:59
*** btully has joined #openstack-horizon04:02
*** roxanaghe has joined #openstack-horizon04:04
*** yingjun has quit IRC04:06
*** yingjun has joined #openstack-horizon04:06
*** Daisy has quit IRC04:07
*** roxanaghe has quit IRC04:09
*** yingjun has quit IRC04:10
*** rajalokan has joined #openstack-horizon04:11
*** btully has quit IRC04:15
*** ircuser-1 has joined #openstack-horizon04:28
*** Daisy has joined #openstack-horizon04:29
*** chasmo77 has joined #openstack-horizon04:30
*** yamamoto_ has quit IRC04:34
*** btully has joined #openstack-horizon04:37
*** zackf has joined #openstack-horizon04:37
*** yingjun has joined #openstack-horizon04:39
openstackgerritEddie Ramirez proposed openstack/horizon: [WIP] Show message if no matches found when using filters  https://review.openstack.org/34872704:42
openstackgerritEddie Ramirez proposed openstack/horizon: Hide IPv6 filter choice if enable_ipv6 is set to False  https://review.openstack.org/33515904:43
*** zackf has quit IRC04:44
*** ducttape_ has joined #openstack-horizon04:59
*** ducttape_ has quit IRC05:04
*** Daisy has quit IRC05:04
*** tnovacik has joined #openstack-horizon05:05
*** Daisy has joined #openstack-horizon05:06
*** masco has joined #openstack-horizon05:07
*** yingjun has quit IRC05:10
*** bpokorny has joined #openstack-horizon05:11
*** yamamoto_ has joined #openstack-horizon05:15
*** bpokorny has quit IRC05:16
*** amitkqed has quit IRC05:19
*** amitkqed has joined #openstack-horizon05:20
*** zackf has joined #openstack-horizon05:21
*** zackf has quit IRC05:25
*** ducttape_ has joined #openstack-horizon05:29
*** ducttape_ has quit IRC05:34
*** amotoki has joined #openstack-horizon05:46
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/horizon: [WIP] Testing latest u-c  https://review.openstack.org/30342905:49
*** yingjun has joined #openstack-horizon05:59
openstackgerritRichard Jones proposed openstack/horizon: Migrate Swift to use ResourceType  https://review.openstack.org/34711405:59
openstackgerritRichard Jones proposed openstack/horizon: WIP: expose more of Swift to ResourceType  https://review.openstack.org/34874105:59
*** david-lyle has joined #openstack-horizon06:07
*** ChanServ sets mode: +o david-lyle06:07
*** Daisy has quit IRC06:15
*** r1chardj0n3s is now known as r1chardj0n3s_afk06:19
*** tnovacik has quit IRC06:20
*** tnovacik has joined #openstack-horizon06:22
*** Daisy has joined #openstack-horizon06:27
*** tnovacik has quit IRC06:27
*** kzaitsev_mb has joined #openstack-horizon06:28
*** Daisy has quit IRC06:29
*** ducttape_ has joined #openstack-horizon06:30
*** ducttape_ has quit IRC06:35
*** tesseract- has joined #openstack-horizon06:37
*** btully has quit IRC06:43
*** btully has joined #openstack-horizon06:43
*** david-lyle has quit IRC06:45
*** pcaruana has joined #openstack-horizon06:45
*** itisha has joined #openstack-horizon06:53
*** roxanaghe has joined #openstack-horizon06:53
*** pt_15 has joined #openstack-horizon06:54
*** btully has quit IRC06:56
*** Daisy has joined #openstack-horizon06:56
*** roxanaghe has quit IRC06:58
*** Daisy has quit IRC07:01
*** zhenguo has joined #openstack-horizon07:04
*** adriant has quit IRC07:09
*** Daisy has joined #openstack-horizon07:09
*** kzaitsev_mb has quit IRC07:09
*** kzaitsev_mb has joined #openstack-horizon07:12
*** bpokorny has joined #openstack-horizon07:12
*** bpokorny has quit IRC07:17
*** btully has joined #openstack-horizon07:17
*** vishwanathj has quit IRC07:21
*** btully has quit IRC07:22
*** davidlenwell has quit IRC07:22
*** zackf has joined #openstack-horizon07:32
*** davidlenwell has joined #openstack-horizon07:34
openstackgerritKenji Ishii proposed openstack/horizon: Ability to manage implied roles  https://review.openstack.org/34595507:35
*** btully has joined #openstack-horizon07:37
*** kzaitsev_mb has quit IRC07:37
*** zackf has quit IRC07:39
*** kzaitsev_mb has joined #openstack-horizon07:40
*** kzaitsev_mb has quit IRC07:45
*** tnovacik has joined #openstack-horizon07:48
robcresswellMorning everyone07:48
*** btully has quit IRC07:49
*** jpich has joined #openstack-horizon07:55
*** zackf has joined #openstack-horizon07:56
*** zackf has quit IRC08:02
*** Daisy has quit IRC08:07
*** yingjun has quit IRC08:16
*** yingjun has joined #openstack-horizon08:17
*** btully has joined #openstack-horizon08:17
*** zackf has joined #openstack-horizon08:19
*** yingjun has quit IRC08:21
*** btully has quit IRC08:21
*** zackf has quit IRC08:26
*** ygbo has joined #openstack-horizon08:26
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/34766708:27
*** ducttape_ has joined #openstack-horizon08:30
*** yamamoto_ has quit IRC08:30
*** btully has joined #openstack-horizon08:31
*** zackf has joined #openstack-horizon08:33
*** btully has quit IRC08:35
*** ducttape_ has quit IRC08:35
*** btully has joined #openstack-horizon08:37
*** wolverineav has joined #openstack-horizon08:38
*** zackf has quit IRC08:40
*** btully has quit IRC08:41
*** roxanaghe has joined #openstack-horizon08:41
*** wolverineav has quit IRC08:43
*** roxanaghe has quit IRC08:46
*** wolverineav has joined #openstack-horizon08:50
*** zackf has joined #openstack-horizon08:51
*** hoobaman has quit IRC08:54
*** wolverineav has quit IRC08:55
*** btully has joined #openstack-horizon08:56
*** amotoki has quit IRC08:56
*** mpavlase has joined #openstack-horizon08:56
*** zackf has quit IRC08:57
*** amotoki has joined #openstack-horizon09:00
*** wolverineav has joined #openstack-horizon09:02
*** btully has quit IRC09:05
*** wolverineav has quit IRC09:06
*** revon has quit IRC09:10
*** btully has joined #openstack-horizon09:12
*** bpokorny has joined #openstack-horizon09:14
*** bpokorny has quit IRC09:19
*** btully has quit IRC09:21
*** wolverineav has joined #openstack-horizon09:24
*** wolverineav has quit IRC09:28
*** zackf has joined #openstack-horizon09:29
*** rajalokan has quit IRC09:30
*** btully has joined #openstack-horizon09:32
*** ducttape_ has joined #openstack-horizon09:32
*** permalac has joined #openstack-horizon09:33
*** zackf has quit IRC09:35
*** ducttape_ has quit IRC09:36
robcresswelltsufiev: It looks like angular 1.4 release didnt cause any problems09:44
openstackgerritPaul Karikh proposed openstack/horizon: Provide the bones of profiler: api, models and middleware  https://review.openstack.org/27308509:44
openstackgerritPaul Karikh proposed openstack/horizon: [WIP] Wrap api calls with tracing decorators  https://review.openstack.org/33967509:44
openstackgerritPaul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard  https://review.openstack.org/30351409:44
*** wolverineav has joined #openstack-horizon09:47
openstackgerritgengchc2 proposed openstack/horizon: modify the home-page info with the developer documentation  https://review.openstack.org/34880809:47
*** btully has quit IRC09:47
tsufievrobcresswell, is it actually used now in Horizon?09:47
tsufievit seems to me that there is still 1.309:48
robcresswelltsufiev: Yes. It's an uncapped dependency and released yesterday09:48
robcresswelltsufiev: Have you rebuilt your venv? :)09:48
robcresswelltsufiev: venv wont automagically pull a later dependency if your local already meets the requirement09:48
* tsufiev double checking09:48
tsufievrobcresswell, ah, yes, my bad, it is really there. I did `pip install -U -r requirements.txt' and it pulled 1.409:50
tsufievone step closer to the ng bleeding edge :)09:50
robcresswellHmm, seems gate is still pulling 1.309:51
robcresswell:/09:51
*** wolverineav has quit IRC09:52
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Add share replication support  https://review.openstack.org/22638909:52
*** tlbr has quit IRC09:52
tsufievrobcresswell, https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L3309:52
tsufievwe use u-c in tox [testenv]09:53
*** tlbr has joined #openstack-horizon09:53
*** tlbr has quit IRC09:53
robcresswellah ofc. derp.09:53
tsufievbut the dsvm job is what really matters here09:53
* tsufiev checking dsvm job requirements09:53
*** tlbr has joined #openstack-horizon09:54
robcresswellLooks like integration also has 1.309:54
*** tlbr has quit IRC09:54
*** wolverineav has joined #openstack-horizon09:55
tsufievdo you have some link to the recent dsvm job after the 1.4 release?09:55
*** tlbr has joined #openstack-horizon09:56
robcresswellI was just looking at patches with recent jenkins on gerrit09:56
tsufievI don't think that dsvm uses some special requirements, as py27 does09:56
*** tlbr is now known as Guest4546609:56
tsufievcould it be just the package propagating to infra mirrors slowly, robcresswell?09:57
robcresswellpotentially09:58
robcresswellKeep eyes peeled for issues then :)09:58
*** Guest45466 has quit IRC10:00
*** zackf has joined #openstack-horizon10:02
*** zhurong has quit IRC10:03
*** Liuqing has quit IRC10:03
*** wolverineav has quit IRC10:06
*** zackf has quit IRC10:09
*** tlbr_ has joined #openstack-horizon10:13
*** wolverineav has joined #openstack-horizon10:16
*** tlbr_ has quit IRC10:17
*** tosky has joined #openstack-horizon10:18
*** wolverineav has quit IRC10:20
*** liuyulong has quit IRC10:21
*** wolverineav has joined #openstack-horizon10:22
*** sdake has joined #openstack-horizon10:25
*** liuyulong has joined #openstack-horizon10:29
*** roxanaghe has joined #openstack-horizon10:30
*** ducttape_ has joined #openstack-horizon10:33
*** roxanaghe has quit IRC10:34
*** zackf has joined #openstack-horizon10:36
*** wolverineav has quit IRC10:36
*** ducttape_ has quit IRC10:37
*** btully has joined #openstack-horizon10:37
*** zackf has quit IRC10:43
*** btully has quit IRC10:48
*** wolverineav has joined #openstack-horizon10:50
*** wolverineav has quit IRC10:54
*** sguduru has joined #openstack-horizon11:13
*** bpokorny has joined #openstack-horizon11:15
*** btully has joined #openstack-horizon11:17
*** zackf has joined #openstack-horizon11:19
*** rodrigods has quit IRC11:19
*** rodrigods has joined #openstack-horizon11:19
*** asettle has joined #openstack-horizon11:20
*** bpokorny has quit IRC11:20
*** btully has quit IRC11:22
*** aortega has quit IRC11:22
*** jrcloud has joined #openstack-horizon11:25
*** zackf has quit IRC11:26
*** sdake has quit IRC11:27
*** jprovazn has joined #openstack-horizon11:29
*** jrcloud has quit IRC11:31
*** btully has joined #openstack-horizon11:35
*** Guest5363 has joined #openstack-horizon11:36
*** btully has quit IRC11:39
*** btully has joined #openstack-horizon11:40
*** itisha has quit IRC11:40
*** zackf has joined #openstack-horizon11:46
*** btully has quit IRC11:50
*** wolverineav has joined #openstack-horizon11:51
*** sguduru has quit IRC11:52
*** zackf has quit IRC11:53
*** wolverineav has quit IRC11:55
*** martianwars has joined #openstack-horizon11:56
*** aortega has joined #openstack-horizon11:58
*** zackf has joined #openstack-horizon11:59
*** tlbr_ has joined #openstack-horizon12:05
*** hwcomcn has joined #openstack-horizon12:05
*** zackf has quit IRC12:06
*** sjmc7 has joined #openstack-horizon12:06
*** hwcomcn has quit IRC12:07
*** hwcomcn has joined #openstack-horizon12:07
*** wolverineav has joined #openstack-horizon12:09
*** hwcomcn has quit IRC12:09
*** tlbr_ has quit IRC12:09
*** hwcomcn has joined #openstack-horizon12:10
*** masco has quit IRC12:11
*** sjmc7 has quit IRC12:11
*** hwcomcn has quit IRC12:11
*** ducttape_ has joined #openstack-horizon12:11
*** hwcomcn has joined #openstack-horizon12:12
*** zackf has joined #openstack-horizon12:12
*** hwcomcn has quit IRC12:13
*** hwcomcn has joined #openstack-horizon12:14
*** itisha has joined #openstack-horizon12:16
*** btully has joined #openstack-horizon12:17
*** zackf has quit IRC12:18
*** wolverineav has quit IRC12:20
*** Liuqing has joined #openstack-horizon12:20
*** btully has quit IRC12:22
*** pauloewerton has joined #openstack-horizon12:23
*** zackf has joined #openstack-horizon12:26
*** ducttape_ has quit IRC12:26
*** jrcloud has joined #openstack-horizon12:32
*** zackf has quit IRC12:32
*** Guest41883 has joined #openstack-horizon12:35
*** wolverineav has joined #openstack-horizon12:37
*** jrcloud has quit IRC12:38
openstackgerritMerged openstack/manila-ui: Updated from global requirements  https://review.openstack.org/34863612:39
*** Guest41883 has quit IRC12:40
*** wolverineav has quit IRC12:41
*** wolverineav has joined #openstack-horizon12:48
*** tlbr_ has joined #openstack-horizon12:48
*** btully has joined #openstack-horizon12:51
*** wolverineav has quit IRC12:52
*** tlbr_ has quit IRC12:52
*** sergio_nubeliu has joined #openstack-horizon12:52
*** matt-borland has joined #openstack-horizon12:55
*** btully has quit IRC13:00
*** btully has joined #openstack-horizon13:01
*** zackf has joined #openstack-horizon13:01
*** sjmc7 has joined #openstack-horizon13:07
*** zackf has quit IRC13:08
*** sjmc7 has quit IRC13:12
*** bpokorny has joined #openstack-horizon13:17
*** wolverineav has joined #openstack-horizon13:20
*** ducttape_ has joined #openstack-horizon13:21
*** bpokorny has quit IRC13:22
*** wolverineav has quit IRC13:27
openstackgerritMatt Borland proposed openstack/horizon: Add more Nova API features for NG Instances  https://review.openstack.org/34494913:28
*** wolverineav has joined #openstack-horizon13:29
*** wolverineav has quit IRC13:33
*** wolverineav has joined #openstack-horizon13:34
*** ducttape_ has quit IRC13:34
matt-borlandSo robcresswell, did you talk with infra about the legacy unit/integration test options (more jobs, etc.)?13:36
*** zackf has joined #openstack-horizon13:37
*** tnovacik has quit IRC13:38
*** wolverineav has quit IRC13:38
*** catintheroof has quit IRC13:42
*** zackf has quit IRC13:44
*** btully has quit IRC13:50
*** wolverineav has joined #openstack-horizon13:51
openstackgerritMatt Borland proposed openstack/horizon: Flavors panel can switch to Angular  https://review.openstack.org/34391713:51
*** zackf has joined #openstack-horizon13:51
openstackgerritMatt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel  https://review.openstack.org/34445613:51
*** btully has joined #openstack-horizon13:51
robcresswellmatt-borland: Not yet, no13:52
robcresswellsplitting out the schema stuff for tyr13:52
matt-borlandsounds good...that's a great boon13:52
matt-borlandrobcresswell, were you imagining that we'd have to replicate each python version test, one for Angular, one for Legacy?  And same for Integration?13:53
matt-borlandI'm wondering if it's better just to have separate panels.13:54
matt-borlandand just deprecate one and enable the other.13:54
matt-borlandI guess that wouldn't work with Django routing.13:54
matt-borlandIt's almost as though we need two different repos ;)13:55
robcresswellNot sure what problem that solves?13:56
robcresswellOther than that, instead of one new test job, we need a new repo and a new test job13:56
*** zackf has quit IRC13:57
*** amotoki has quit IRC13:58
matt-borlandI know :)13:58
matt-borlandI just am thinking that if we duplicate most of our test jobs, most of which replicate the same tests, we just have longer runs, that's all.13:59
matt-borlandeither way, let me know if there's a way for me to assist in getting those going.14:00
*** wolverineav has quit IRC14:04
*** roxanaghe has joined #openstack-horizon14:05
*** zackf has joined #openstack-horizon14:07
tsufievomg14:08
*** wolverineav has joined #openstack-horizon14:08
matt-borlandwhat's up, tsufiev?14:09
*** cloudtrainme has joined #openstack-horizon14:09
*** roxanaghe has quit IRC14:10
tsufievmatt-borland, getting another repo just for the new panels seems like a maintenance hell to me14:10
tsufievor at least the beginning of a road to it14:10
matt-borlandheh heh14:10
matt-borlandwell, it depends on how you look at it.  I was kind of playing devil's advocate.14:10
matt-borlandI think running two sets of jobs, one that assumes all the Angular work is enabled, and one assuming all the Django work is enabled, is equally incorrect/burdensome.14:11
tsufievwhy is it?14:11
matt-borlandI count about 7 jobs that we're talking about replicating (?)14:12
tsufievwhat would make sense to me is splitting horizon package-wise, to that to build each package its own set of unit-tests would be run14:12
matt-borlandright now, 90+% of them would run the exact same tests.14:12
tsufievI thought there was a discussion about replicating just one job - dsvm-integration14:13
*** wolverineav has quit IRC14:13
*** zackf has quit IRC14:13
matt-borlandI think robcresswell pointed out we'd have to do the same for unit tests (?)14:13
tsufievwhat jobs need to be replicated as well?14:13
tsufievoh14:13
matt-borlandgate-horizon-python3414:13
matt-borlandetc.14:13
matt-borlandIt's talk like this that makes me worry that this is a precondition for flipping on an Angular panel.14:14
tsufievno, I don't think we need this14:14
tsufievbecause unit tests can override the setting that enables/disables specific angular panel14:14
matt-borlandif it's just integration tests, I'm OK with it.14:14
tsufievyep, it's just for integration tests which cannot control what Horizon content is enabled14:14
tsufievother tests can do it14:15
matt-borlandok14:15
matt-borlandso when you say 'can' do it, is there any work I can do now to prep to do that?14:15
matt-borlandbecause we're running low on time14:15
matt-borlandand a healthy division of labor is probably in order14:15
tsufievwell, it's scattered everywhere, let me find an example14:15
*** hwcomcn has quit IRC14:16
tsufievmatt-borland, take a look at this beauty https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/tests/quotas.py#L14414:18
matt-borlandoh, cool...thanks!14:18
tsufievif we were desperate enough to test it with dsvm-integration job, we would have to provide two jobs as well14:18
*** Tamayo has joined #openstack-horizon14:18
tsufievfor both values of this particular setting14:18
tsufievthat's how unit tests fight the combinatorial explosion of horizon settings14:19
*** sjmc7 has joined #openstack-horizon14:19
openstackgerritMatt Borland proposed openstack/horizon: hz-resource-table handles transitional states  https://review.openstack.org/34617414:19
openstackgerritMatt Borland proposed openstack/horizon: hz-images have transitional states defined  https://review.openstack.org/34621014:20
*** tyr has joined #openstack-horizon14:26
*** wolverineav has joined #openstack-horizon14:26
robcresswelltsufiev: We still need to run the unit tests for deprecated panels though, IMO14:27
robcresswellespecially since "unit" in django land is more functional14:27
tyro/14:27
openstackgerritMatt Borland proposed openstack/horizon: [WIP] Resource Action Enablements  https://review.openstack.org/32970014:27
robcresswellhey tyr14:27
tyrmorning robcresswell!14:27
matt-borlandrobcresswell, I think tsufiev is saying they will run...right?14:29
matt-borlandor would they just not be picked up?14:29
openstackgerritMerged openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/34766714:29
matt-borlandso robcresswell, a nice hypothetical question for you.  What if we changed a feature, like modified the Ports table (only) to use Angular to render it.  What would the test strategy then be?14:30
matt-borlandBecause in that case it's just a feature change.14:31
matt-borland(really just a rendering change)14:31
*** asettle has quit IRC14:32
matt-borlandI ask because we have loads of generatable tables lying in GitHub.14:32
robcresswellThere's a bit more to it than that14:32
matt-borlandOK14:32
robcresswellFor example details pages render table row actions14:32
robcresswellSo you'd need to think about how to move the tests that rely on that content to a separate env14:33
matt-borlandTrue.  Some tables don't have details, just data and actions.14:33
*** piet_ has joined #openstack-horizon14:33
robcresswellMost have details, even if minimal14:33
*** tlbr_ has joined #openstack-horizon14:33
matt-borlandI get *most*, I'm talking about those other cases.14:34
*** tlbr_ has quit IRC14:34
robcresswellIf there arent any tests then we don't need to do anything14:34
matt-borlandanyway, is it your opinion we need to run two sets of, say, gate-horizon-python34 tests?14:35
*** wolverineav has quit IRC14:35
*** ducttape_ has joined #openstack-horizon14:35
matt-borlandI'm trying to understand the scope of what is being suggested by different people.14:35
robcresswellWe shouldn't need to run two full sets14:36
robcresswellJust the subset for the deprecated panel14:36
*** wolverineav has joined #openstack-horizon14:37
matt-borlandah, so gate-horizon-python34 would run the 'enabled' stuff and we'd have a gate-horizon-python34-deprecated14:37
robcresswellyeah14:37
matt-borlandso we'd have 2x the number of unit and integration test jobs14:38
matt-borlandso, about 7 more jobs.  I just want to make sure I am not misunderstanding.14:38
robcresswellIf we decide to test it that extent, then yes I imagine so.14:38
matt-borlandI thought that we did decide to test it to that extent...is there something we're waiting on, a decision from someone else?14:39
tyrcan we decide to not test deprecated panels ?14:39
robcresswellFor example, we might not run multiple levels of django on a deprecated panel14:39
robcresswelltyr: No14:39
matt-borlandso, we have decided to proceed with this, right?14:39
robcresswellWe can't just abandon content the second we deprecate code14:39
matt-borlandthat's fine, so we're going ahead with this plan?14:40
*** zhurong has joined #openstack-horizon14:40
matt-borlandI mean, there is no other way to do this, right?14:40
robcresswellNot that I'm aware of.14:40
robcresswellso we'd create a test env that runs specific tests for python14:40
robcresswellThats not too difficult14:41
matt-borlandok14:41
robcresswellWhen you deprecate something you could literally just alter the tox.ini14:41
matt-borlandOK.  So outside of 'could,' what are the next steps?14:42
*** hurgleburgler has joined #openstack-horizon14:42
*** ChanServ sets mode: +v hurgleburgler14:42
matt-borlandI am not familiar with setting up test jobs14:42
*** david-lyle has joined #openstack-horizon14:42
*** ChanServ sets mode: +o david-lyle14:42
matt-borlandshould I go put together a patch in project-config that starts to enable this?14:42
robcresswelldsvm I don't know about, but tox is simple. Just add the tox env to Horizon then alter infra to run that job14:42
robcresswellmatt-borland: Take a look at https://review.openstack.org/#/c/335401/ and its Depends-On14:43
matt-borlandOK.14:44
*** zhurong_ has joined #openstack-horizon14:44
matt-borlandso, right now the switch simply limits the panel tests to Angular or Legacy when run.14:44
matt-borlandthat's different from what you are suggesting.14:44
matt-borlandBecause in what you're suggesting, in one job the 'enabled' tests runs, in the other, ONLY the deprecated tests run.14:45
matt-borlandfor that to be the case, would we instead specify another set of test files/directories to be run, essentially?14:45
*** wolverineav has quit IRC14:45
robcresswellSimilar to how we did for python3 whitelisting14:46
* matt-borland reflects on tsufiev's comments about another repo14:46
*** zhurong has quit IRC14:46
*** david-lyle_ has joined #openstack-horizon14:46
matt-borlandok, I'll have to take a look at that too.14:47
robcresswellI'll dig up a patch14:47
robcresswellSo you can see how it worked14:47
*** uxdanielle has joined #openstack-horizon14:47
matt-borlandawesome.  you can see that what I'm trying to do is put together a game plan.14:47
*** david-lyle has quit IRC14:47
robcresswellhttps://github.com/openstack/horizon/commit/68de5710973a3d5db79de18150ca6440635c7a9a#diff-b91f3d5bd63fcd17221b267e851608e814:47
matt-borlandthanks14:47
robcresswellTake a look at the tox.ini in there14:47
robcresswellWe just had a list of running python tests in the tox env14:47
matt-borlandrobcresswell, should I put together a blueprint for these tasks?14:48
matt-borlandand target it for N-3 or whatever?14:48
matt-borlandas essential?14:48
*** david-lyle__ has joined #openstack-horizon14:48
*** mpavlase has quit IRC14:48
robcresswellSure14:48
matt-borlandthanks14:48
matt-borlandI'll put together what I've learned from this and try to work with you and probably tsufiev on making that plan pretty complete.14:49
matt-borlandthanks, this is really helpful14:49
*** tlbr_ has joined #openstack-horizon14:50
matt-borlandok, I have to sign off for a few minutes, but thanks again!14:50
*** zackf has joined #openstack-horizon14:50
robcresswellnp14:51
*** david-lyle_ has quit IRC14:52
*** tlbr_ has quit IRC14:53
*** zackf has quit IRC14:57
*** wolverineav has joined #openstack-horizon14:57
tsufievare we discussing moving into a separate job the Django tests for Angular, robcresswell?14:58
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/34800014:58
tsufievor some new type of functional tests which are not yet even written?14:58
tsufievlike functional tests for new Angular content, for which (it's my personal opinion) it makes not sense to use Django tests?14:59
tsufievthere seem to be few missing parts in this equation14:59
matt-borlandtsufiev, I believe we're saying that the jobs are separated into a) 'current' code and b) 'deprecated' code15:02
matt-borlandthe Angular unit (npm) tests are not duplicated in this scheme15:03
matt-borland'current' is defined by the switch, but the 'deprecated' is slightly different in this case.15:04
matt-borlandI don't think what is proposed quite aligns yet, but let's discuss in a blueprint.15:04
*** zackf has joined #openstack-horizon15:06
*** zackf has quit IRC15:08
*** zackf has joined #openstack-horizon15:08
robcresswelltsufiev: We still need to run tests for deprecated content, so we could just put them in a separate tox test runnger15:10
robcresswellrunner*15:10
matt-borlandrobcresswell, it seems like some of this runs against the notion of the switch...that we have to add certain things to whitelists, etc. to ensure this test is run but not that test, etc.15:10
tsufievI see, so it's not 'replicating', it's 'separating'15:10
matt-borlandyeah15:11
matt-borlandthat makes more sense to me.  But will other tests make sense when separated?15:11
tsufievbut since both sets of tests are in the same codebase, we'll need to eventually move them out of that codebase15:11
matt-borlandI mean, what is separated?15:11
matt-borlandexactly15:11
matt-borlandI feel like we're chasing a ghost15:11
tsufievit's more a convenience tool for disabling a set of tests using one switch, nothing more15:11
matt-borlandyep15:11
*** wolverineav has quit IRC15:12
matt-borlandthat's fine with me15:12
robcresswellI'm confused, why is it confusing?15:12
robcresswellWe remove them once deprecaton period has passed15:12
matt-borlandI think I understand the plan15:13
matt-borlandIt's just that there's more than flipping a switch15:13
matt-borlandone would have to flip the switch, but then also change whitelists, etc.15:13
robcresswellchange whitelists in this case would only be to add a line to the tox config15:14
matt-borlandright15:14
matt-borlandthat's fine15:14
matt-borlandI'm just saying, it's more than flipping one switch, as we already kind of ran into15:14
robcresswellWell, if anyone can think of a cleaner solution, I'm all ears15:15
robcresswellstepping away for a bit :)15:16
tsufievwhy do we need a separate job at all for unit/functional tests?15:16
*** bpokorny has joined #openstack-horizon15:18
*** cfriesen_ has quit IRC15:22
*** cfriesen_ has joined #openstack-horizon15:22
*** bpokorny has quit IRC15:23
*** david-lyle has joined #openstack-horizon15:23
*** ChanServ sets mode: +o david-lyle15:23
*** david-lyle__ has quit IRC15:23
*** wolverineav has joined #openstack-horizon15:24
robcresswellOh. I'm having a slow day15:24
matt-borlandtsufiev, robcresswell I put up https://blueprints.launchpad.net/horizon/+spec/test-deprecated-features15:24
robcresswellmatt-borland: We can just override the panel swap in the test setting15:24
robcresswellto always be legacy15:24
matt-borlandIf one of you can mark as N-3/Essential that would work.15:24
robcresswellThen we don't need to alter anything else15:24
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/34800015:24
* robcresswell is thinking out loud15:24
matt-borlandrobcresswell, in what you suggest that would mean it would rerun all the other tests too, right?15:25
matt-borlandhence the whitelisting?15:25
robcresswellbut we wouldnt need two jobs in that case15:25
*** bpokorny has joined #openstack-horizon15:25
matt-borlandrobcresswell, in integration tests, we'd need to restart Horizon15:26
robcresswellWe could swap in the deployment settings but leave the test setting as legacy15:26
robcresswellThat would handle all the UTs15:26
robcresswellIts only dsvm that is an issue then15:26
matt-borlandI think that's true for UTs15:26
matt-borlandso I guess I don't really know how tests work.  Are tests run regardless of their panel's status?15:27
matt-borlandUTs15:27
robcresswellall panels do is update HORIZON_CONFIG, which is just a setting15:27
robcresswellbut you could just alter it to legacy after the panel import15:28
robcresswellThat should work15:28
matt-borlandbut wait15:28
matt-borlandwhy then do we even care about screening by panel type for UTs?15:28
*** zhurong_ has quit IRC15:28
matt-borlandI mean, they should just work without respecting the panel setting either way15:28
matt-borlandwhy decorate them NOT to run15:28
matt-borlandjust...let them run, right?15:29
*** Guest79767 has joined #openstack-horizon15:29
* robcresswell is thinking15:29
*** wolverineav has quit IRC15:29
*** bpokorny has quit IRC15:29
matt-borlandor do they break due to interesting reasosn?15:29
*** cfriesen_ has quit IRC15:30
matt-borlandlet's perform a practical experiment15:30
robcresswellThe reason they normally break is because of URLs15:30
matt-borlandbut shouldn't they just test reverse lookups?15:30
matt-borlandwhich should be accommodated?15:30
matt-borlandhold on15:30
robcresswellAs long as the urls.py alters based on the settings, should be fine15:32
*** Liuqing has quit IRC15:33
*** TravT has joined #openstack-horizon15:33
*** ChanServ sets mode: +v TravT15:33
matt-borlandrobcresswell, testing now15:33
*** Guest79767 has quit IRC15:34
matt-borlandIf it just comes down to running two integration test jobs, even with duplication, I'd be happy. :)15:34
*** yamamoto has joined #openstack-horizon15:34
*** wolverineav has joined #openstack-horizon15:37
* tsufiev totally missed the point about different URLs15:38
matt-borlandtsufiev, I think he means when tests ensure you land at a particular Django route.15:39
*** sdake has joined #openstack-horizon15:39
matt-borlandwhich at this point we should be replicating in the Angular switch.15:39
*** tlbr_ has joined #openstack-horizon15:40
matt-borlandThere appears to be some problem with running the legacy UTs (without any changes) when the angular switch is on...hold on.15:40
matt-borlandbut you're right robcresswell, we can probably just change the switch value.15:41
matt-borlandin the UT15:41
matt-borlandor fix the test to not make bad assumptions, either way15:41
*** tlbr_ has quit IRC15:45
jlopezgumorning o/15:45
*** wolverineav has quit IRC15:45
openstackgerritErnest Millan proposed openstack/horizon: Create common code for horizon.instances.js and horizon.firewalls.js  https://review.openstack.org/34186415:46
robcresswellYeah it sounds like we were overcomplicating things15:47
*** liuyulong has quit IRC15:48
*** wolverineav has joined #openstack-horizon15:49
*** liuyulong has joined #openstack-horizon15:50
*** roxanaghe has joined #openstack-horizon15:52
matt-borlandrobcresswell, tsufiev, what's the best way to set the HORIZON_CONFIG value on the UT so that it correctly affects the unit test?15:53
*** kfox1111 has joined #openstack-horizon15:54
matt-borlanddecoration?  some sort of beforeEach?  It seems to work if I just brute-force set it, but only when the test is run in isolation15:54
robcresswellmatt-borland: Just append it to the test settings15:54
matt-borlandrobcresswell, I guess I don't know what that means15:54
robcresswellThen just make any necessary changes to the urls.py to account for it the config variable15:54
robcresswellargh words.15:55
robcresswellhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/test/settings.py15:55
kfox1111I just noticed our horizon was handing out v3 keystone auth url's in the v2 rc download button. :/15:55
matt-borlandurls.py does accommodate it15:55
matt-borlandbut robcresswell, then that's a global setting.15:55
matt-borlandOH15:55
matt-borlandI see what you mean.15:56
matt-borlandI think.15:56
matt-borlandjust leave the setting at 'legacy'15:56
matt-borlandexcellent15:56
robcresswellSo, leave the test setting as legacy, but the deployment setting as angular, or whatever15:56
*** roxanaghe has quit IRC15:56
robcresswellThat should work fine, I think...15:56
*** btully has quit IRC15:56
david-lylekfox1111: probably due to  an overzealous version correction fix15:56
*** tyr_ has joined #openstack-horizon15:56
*** tyr has quit IRC15:57
matt-borlandkfox1111, probably a patch that I put up recently15:57
*** wolverineav has quit IRC15:57
*** vishwanathj has joined #openstack-horizon15:57
matt-borlandhttps://review.openstack.org/#/c/331788/ ? kfox111115:58
*** btully has joined #openstack-horizon15:59
openstackgerritDiana Whitten proposed openstack/horizon: Horizon Spinner/Loader should inherit from theme  https://review.openstack.org/31368516:00
*** pcaruana has quit IRC16:01
kfox1111its in mitaka too I think.16:01
*** wolverineav has joined #openstack-horizon16:02
*** cloudtrainme has quit IRC16:03
matt-borlandkfox1111, yeah, it naturally got backported :/16:09
kfox1111:/16:09
matt-borlandkfox1111, what is the specific problem?  I think we just added some items.16:09
kfox1111k. I'll file a bug.16:09
kfox1111if you download the v2.0 rc file, the auth_url is for v3.16:10
kfox1111one of our users downloaded it, tried it and it failed, as it was trying to speak the wrong api version to the endpoint.16:11
kfox1111it only supported v2.16:11
*** wolverineav has quit IRC16:12
kfox1111ah... this: https://bugs.launchpad.net/horizon/+bug/154706116:12
openstackLaunchpad bug 1547061 in OpenStack Dashboard (Horizon) "openrc v2.sh contains /v3 url" [Undecided,Won't fix] - Assigned to Robin Cernin (rcernin)16:12
kfox1111yeah.... we have a v3 auth url, so its just passing it through.16:15
*** tjones has joined #openstack-horizon16:16
matt-borlandsure enough robcresswell, using that setting file and setting it to 'legacy' works great for unit tests.  So we just need to address integration tests.16:16
matt-borlandr1chardj0n3s had already done this properly. :)16:17
*** wolverineav has joined #openstack-horizon16:17
matt-borland(unit tests that is)16:17
*** ygbo has quit IRC16:17
robcresswellAh, cool.16:19
kfox1111can we get the wont'fix pulled from 1547061?16:20
*** Liuqing has joined #openstack-horizon16:21
robcresswellkfox1111: done.16:22
tsufievmatt-borland, what particular UT do you mean? Some Django UT are more like functional tests16:23
tsufievthe thing is that for tests which are actually UNIT, that almost never should be a problem16:24
matt-borlandtsufiev, I'll be clear, I mean tests found in dashboards/[project|admin])16:24
matt-borlandregardless of actual kind of test16:24
* tsufiev sighs16:24
tsufievI'm afraid they are both16:24
matt-borlandthat's fine, point is they work as r1chardj0n3s had already demonstrated16:25
tsufievthat may be a good reason to rethink how the line between unit and functional is drawn in Horizon16:25
kfox1111robcresswell: thanks.16:25
*** wolverineav has quit IRC16:25
robcresswelltsufiev: It's not relevant here16:25
openstackgerritMatt Borland proposed openstack/horizon: Make 'switch' between legacy and Angular Images  https://review.openstack.org/33912216:26
robcresswelltsufiev: The point is that it works when angular is default16:26
robcresswellas long a the tests run, that is what matters :)16:26
tsufievand it shouldn't, right?16:26
*** jpich has quit IRC16:26
matt-borlandrobcresswell, I updated the Images switch patch to run the legacy code test16:27
matt-borland*s16:27
openstackgerritMatt Borland proposed openstack/horizon: Enable Angular Image panel  https://review.openstack.org/33916416:27
robcresswelltsufiev: ?? We want both sets of tests to run16:27
*** wolverineav has joined #openstack-horizon16:27
*** cloudtrainme has joined #openstack-horizon16:27
robcresswellmatt-borland: Cool. Just integration to look to then.16:28
matt-borlandin that case robcresswell I think the code is correct and we just need to add a new integration job16:28
*** Guest30197 has joined #openstack-horizon16:28
tsufievrobcresswell, ah, ignore my previous question16:28
matt-borlandone that switches the horizon_conf setting and the test horizon.conf setting.16:28
*** tesseract- has quit IRC16:30
*** bpokorny has joined #openstack-horizon16:30
*** permalac has quit IRC16:31
openstackgerritMatt Borland proposed openstack/horizon: Make 'switch' between legacy and Angular Images  https://review.openstack.org/33912216:32
*** jamielennox|away is now known as jamielennox16:32
openstackgerritMatt Borland proposed openstack/horizon: Make 'switch' between legacy and Angular Images  https://review.openstack.org/33912216:32
*** Guest30197 has quit IRC16:33
*** roxanaghe has joined #openstack-horizon16:34
*** tqtran has joined #openstack-horizon16:34
*** bpokorny has quit IRC16:34
*** tqtran_ has joined #openstack-horizon16:35
openstackgerritPaul Karikh proposed openstack/horizon: Wrap api calls with tracing decorators  https://review.openstack.org/33967516:36
*** wolverineav has quit IRC16:36
*** wolverineav has joined #openstack-horizon16:37
*** wolverineav has quit IRC16:37
*** wolverineav has joined #openstack-horizon16:38
*** wolverineav has quit IRC16:38
*** tqtran has quit IRC16:38
*** wolverineav has joined #openstack-horizon16:38
*** wolverineav has quit IRC16:39
*** wolverineav has joined #openstack-horizon16:39
*** wolverineav has joined #openstack-horizon16:39
*** wolverineav has quit IRC16:40
*** wolverineav has joined #openstack-horizon16:40
*** tlbr_ has joined #openstack-horizon16:40
openstackgerritMatt Borland proposed openstack/horizon: Make 'switch' between legacy and Angular Images  https://review.openstack.org/33912216:40
openstackgerritMatt Borland proposed openstack/horizon: Enable Angular Image panel  https://review.openstack.org/33916416:40
*** wolverineav has joined #openstack-horizon16:40
*** wolverineav has quit IRC16:41
*** wolverineav has joined #openstack-horizon16:41
*** wolverineav has joined #openstack-horizon16:41
*** wolverineav has quit IRC16:42
*** wolverineav has joined #openstack-horizon16:42
*** wolverineav has joined #openstack-horizon16:42
matt-borlandtsufiev, so is there a 'simple' way to, for a new integration test environment, to change the HORIZON_CONFIG and the integration test's horizon.conf files, or at least their respected values?16:42
*** wolverineav has quit IRC16:43
matt-borlandis that pre-test hooks?16:43
*** wolverineav has joined #openstack-horizon16:43
*** wolverineav has joined #openstack-horizon16:43
*** wolverineav has quit IRC16:44
*** wolverineav has joined #openstack-horizon16:44
*** tlbr_ has quit IRC16:44
openstackgerritMatt Borland proposed openstack/horizon: Flavors panel can switch to Angular  https://review.openstack.org/34391716:44
*** Liuqing has quit IRC16:44
*** wolverineav has joined #openstack-horizon16:44
*** wolverineav has quit IRC16:45
*** wolverineav has joined #openstack-horizon16:45
*** wolverineav has joined #openstack-horizon16:45
*** wolverineav has quit IRC16:45
*** wolverineav has joined #openstack-horizon16:46
*** wolverineav has joined #openstack-horizon16:46
*** wolverineav has quit IRC16:47
*** wolverineav has joined #openstack-horizon16:47
*** wolverineav has quit IRC16:47
*** Liuqing has joined #openstack-horizon16:47
*** wolverineav has joined #openstack-horizon16:47
*** wolverineav has quit IRC16:51
*** wolverineav has joined #openstack-horizon16:51
*** wolverineav has quit IRC16:51
*** wolverineav has joined #openstack-horizon16:51
*** wolverineav has quit IRC16:52
*** wolverineav has joined #openstack-horizon16:52
*** wolverineav has quit IRC16:52
*** wolverineav has joined #openstack-horizon16:52
*** wolverineav has quit IRC16:53
*** wolverineav has joined #openstack-horizon16:53
*** wolverineav has joined #openstack-horizon16:53
*** TravT has quit IRC16:54
*** Liuqing has quit IRC16:54
*** wolverineav has quit IRC16:55
*** wolverineav has joined #openstack-horizon16:55
*** wolverineav has quit IRC16:55
*** Liuqing has joined #openstack-horizon16:55
*** wolverineav has joined #openstack-horizon16:55
*** wolverineav has quit IRC16:56
*** wolverineav has joined #openstack-horizon16:56
*** wolverineav has quit IRC16:57
*** wolverineav has joined #openstack-horizon16:57
*** wolverineav has quit IRC16:57
*** wolverineav has joined #openstack-horizon16:57
*** wolverineav has quit IRC16:58
*** wolverineav has joined #openstack-horizon16:58
*** wolverineav has quit IRC16:58
openstackgerritRob Cresswell proposed openstack/horizon: Add Angular Schema Form and Create Net Workflow  https://review.openstack.org/33274516:58
*** piet_ has quit IRC16:58
*** wolverineav has joined #openstack-horizon16:58
*** roxanaghe has quit IRC16:58
*** TravT has joined #openstack-horizon16:58
*** ChanServ sets mode: +v TravT16:58
*** wolverineav has quit IRC16:59
*** wolverineav has joined #openstack-horizon16:59
openstackgerritRob Cresswell proposed openstack/horizon: Add Angular Schema Form and Create Net Workflow  https://review.openstack.org/33274516:59
*** wolverineav has joined #openstack-horizon16:59
*** wolverineav has quit IRC17:00
*** wolverineav has joined #openstack-horizon17:00
*** wolverineav has joined #openstack-horizon17:00
*** wolverineav has quit IRC17:01
*** cloudtrainme has quit IRC17:01
*** wolverineav has joined #openstack-horizon17:01
*** wolverineav has joined #openstack-horizon17:01
*** wolverineav has quit IRC17:02
*** wolverineav has joined #openstack-horizon17:02
*** wolverineav has quit IRC17:02
*** wolverineav has joined #openstack-horizon17:02
*** wolverineav has quit IRC17:03
*** wolverineav has joined #openstack-horizon17:03
*** wolverineav has joined #openstack-horizon17:03
*** wolverineav has quit IRC17:04
*** wolverineav has joined #openstack-horizon17:04
*** wolverineav has joined #openstack-horizon17:04
*** wolverineav has quit IRC17:05
*** ducttape_ has quit IRC17:05
*** wolverineav has joined #openstack-horizon17:05
openstackgerritMatt Borland proposed openstack/horizon: Flavors panel can switch to Angular  https://review.openstack.org/34391717:05
tsufievmatt-borland, yes, that's it17:05
*** wolverineav has joined #openstack-horizon17:05
matt-borlandcool, are the pre-test hooks defined for tox in the Horizon codebase?17:05
*** wolverineav has quit IRC17:06
matt-borlandthat is, is that where/how I would approach that?17:06
openstackgerritPaul Karikh proposed openstack/horizon: Provide the bones of profiler: api, models and middleware  https://review.openstack.org/27308517:06
*** wolverineav has joined #openstack-horizon17:06
openstackgerritRob Cresswell proposed openstack/horizon: Add Angular Schema Form  https://review.openstack.org/33274517:06
*** wolverineav has joined #openstack-horizon17:06
matt-borlandnice robcresswell ^^17:06
openstackgerritPaul Karikh proposed openstack/horizon: Add the Profiler panel to the Developer dashboard  https://review.openstack.org/30351417:06
robcresswelltyr_: https://review.openstack.org/#/c/33274517:06
*** wolverineav has quit IRC17:07
robcresswellSeparated and tests done.17:07
tyr_yeah!!17:07
*** wolverineav has joined #openstack-horizon17:07
*** wolverineav has quit IRC17:07
*** wolverineav has joined #openstack-horizon17:07
*** wolverineav has quit IRC17:08
*** wolverineav has joined #openstack-horizon17:08
*** wolverineav has joined #openstack-horizon17:08
*** wolverineav has quit IRC17:09
*** wolverineav has joined #openstack-horizon17:09
*** wolverineav has quit IRC17:09
*** wolverineav has joined #openstack-horizon17:09
*** wolverineav has quit IRC17:10
*** wolverineav has joined #openstack-horizon17:10
openstackgerritPaul Karikh proposed openstack/horizon: Wrap api calls with tracing decorators  https://review.openstack.org/33967517:10
*** wolverineav has quit IRC17:10
*** wolverineav has joined #openstack-horizon17:10
*** wolverineav has quit IRC17:11
*** wolverineav has joined #openstack-horizon17:11
*** wolverineav has quit IRC17:11
*** wolverineav has joined #openstack-horizon17:11
openstackgerritRob Cresswell proposed openstack/horizon: Add Angular Schema Form  https://review.openstack.org/33274517:11
*** wolverineav has quit IRC17:12
openstackgerritTyr Johanson proposed openstack/horizon: Resource Browser links now respect webroot  https://review.openstack.org/34896817:12
*** wolverineav has joined #openstack-horizon17:12
*** wolverineav has joined #openstack-horizon17:12
*** wolverineav has quit IRC17:13
*** wolverineav has joined #openstack-horizon17:13
*** wolverineav has quit IRC17:13
*** wolverineav has joined #openstack-horizon17:13
tsufievmatt-borland, not exactly, see https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml#L2717:13
*** tosky has quit IRC17:14
matt-borlandok, thanks tsufiev17:14
* matt-borland learning is hard :)17:14
tsufievI'm afraid that parameterizing pre_test_hook won't be that easy17:14
*** wolverineav has quit IRC17:15
*** wolverineav has joined #openstack-horizon17:15
*** wolverineav has quit IRC17:15
*** piet has joined #openstack-horizon17:15
*** wolverineav has joined #openstack-horizon17:15
*** wolverineav has quit IRC17:16
*** wolverineav has joined #openstack-horizon17:16
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/34800017:16
tsufievbecause the actual script is wrapped into another function which is then exported to devstack-gate script17:16
tsufievperhaps infra folks know how to enhance it...17:16
openstackgerritRob Cresswell proposed openstack/horizon: Add Create Net Workflow  https://review.openstack.org/34896917:16
*** wolverineav has joined #openstack-horizon17:16
*** wolverineav has joined #openstack-horizon17:17
*** wolverineav has quit IRC17:17
*** cloudtrainme has joined #openstack-horizon17:17
*** wolverineav has joined #openstack-horizon17:17
*** wolverineav has quit IRC17:19
*** wolverineav has joined #openstack-horizon17:19
*** wolverineav has quit IRC17:19
*** wolverineav has joined #openstack-horizon17:19
*** wolverineav has quit IRC17:20
*** wolverineav has joined #openstack-horizon17:20
robcresswellmatt-borland: Okay I separated the two patches17:20
*** roxanaghe has joined #openstack-horizon17:20
*** wolverineav has joined #openstack-horizon17:20
*** wolverineav has quit IRC17:21
*** wolverineav has joined #openstack-horizon17:21
*** wolverineav has quit IRC17:21
robcresswellJust need reviews now really17:21
*** wolverineav has joined #openstack-horizon17:21
*** wolverineav has quit IRC17:22
openstackgerritDiana Whitten proposed openstack/horizon: Horizon Forms should allow themable number spinners  https://review.openstack.org/33793617:22
*** wolverineav has joined #openstack-horizon17:22
*** wolverineav has joined #openstack-horizon17:22
*** wolverineav has quit IRC17:23
matt-borlandtsufiev, when you say "it won't be easy," then I get worried ( robcresswell )17:23
*** wolverineav has joined #openstack-horizon17:23
matt-borlandas in, "will take a few hours" or "will be fragile or hard to complete at all?"17:23
*** wolverineav has joined #openstack-horizon17:23
*** wolverineav has quit IRC17:24
matt-borlandI don't want this to block the development of our UI17:24
*** wolverineav has joined #openstack-horizon17:24
*** wolverineav has joined #openstack-horizon17:24
*** wolverineav has quit IRC17:25
*** wolverineav has joined #openstack-horizon17:25
*** wolverineav has quit IRC17:25
robcresswellmatt-borland: Its unavoidable17:25
*** tlbr_ has joined #openstack-horizon17:25
*** wolverineav has joined #openstack-horizon17:25
*** wolverineav has quit IRC17:26
matt-borlandthen let's solve the problems robcresswell regardless of whether they are hard to solve.17:26
*** wolverineav has joined #openstack-horizon17:26
matt-borlandtsufiev, why is this difficult?17:26
robcresswellindeed :)17:26
robcresswellthat said, its 6:30 on a Friday so I'm done for now17:26
*** wolverineav has joined #openstack-horizon17:26
matt-borlandof course...thanks for everything robcresswell! have a good weekend.17:26
*** wolverineav has quit IRC17:27
robcresswellmatt-borland: You should set up an IRC bouncer so people can leave updates ;)17:27
*** wolverineav has joined #openstack-horizon17:27
*** cloudtrainme has quit IRC17:27
matt-borlandI guess I could :)17:27
*** wolverineav has joined #openstack-horizon17:28
*** wolverineav has joined #openstack-horizon17:28
*** wolverineav has quit IRC17:29
*** wolverineav has joined #openstack-horizon17:29
*** wolverineav has joined #openstack-horizon17:29
*** wolverineav has quit IRC17:30
*** tlbr_ has quit IRC17:30
*** wolverineav has joined #openstack-horizon17:30
*** wolverineav has quit IRC17:30
*** wolverineav has joined #openstack-horizon17:30
*** wolverineav has quit IRC17:31
*** wolverineav has joined #openstack-horizon17:31
*** wolverineav has joined #openstack-horizon17:31
*** wolverineav has quit IRC17:32
*** wolverineav has joined #openstack-horizon17:32
*** wolverineav has joined #openstack-horizon17:32
*** wolverineav has quit IRC17:33
*** wolverineav has joined #openstack-horizon17:33
*** wolverineav has joined #openstack-horizon17:33
*** wolverineav has quit IRC17:35
*** wolverineav has joined #openstack-horizon17:35
*** wolverineav has quit IRC17:35
*** jamielennox is now known as jamielennox|away17:35
*** wolverineav has joined #openstack-horizon17:35
*** wolverineav has quit IRC17:36
*** wolverineav has joined #openstack-horizon17:36
*** Liuqing has quit IRC17:36
*** bpokorny has joined #openstack-horizon17:36
openstackgerritMatt Borland proposed openstack/horizon: Add more Nova API features for NG Instances  https://review.openstack.org/34494917:36
*** wolverineav has joined #openstack-horizon17:36
*** wolverineav has quit IRC17:38
*** wolverineav has joined #openstack-horizon17:38
*** wolverineav has joined #openstack-horizon17:38
*** wolverineav has quit IRC17:39
*** wolverineav has joined #openstack-horizon17:39
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/34800017:40
*** wolverineav has quit IRC17:41
*** wolverineav has joined #openstack-horizon17:41
*** wolverineav has quit IRC17:41
*** wolverineav has joined #openstack-horizon17:41
*** wolverineav has quit IRC17:42
*** wolverineav has joined #openstack-horizon17:42
*** wolverineav has quit IRC17:42
*** wolverineav has joined #openstack-horizon17:42
*** wolverineav has quit IRC17:43
*** btully has quit IRC17:43
*** vakovalchuk has quit IRC17:43
*** wolverineav has joined #openstack-horizon17:43
*** wolverineav has quit IRC17:43
*** wolverineav has joined #openstack-horizon17:44
tsufievmatt-borland, sorry, a lot of meetings today17:44
matt-borlandnp, it's late in your day :)17:44
matt-borlandwe can follow up on Monday17:44
* tsufiev was in a middle of writing the next line17:44
tsufiev... but, having 2 different jobs which use different pre_test hooks is absolutely doable with existing infra17:44
tsufievspeaking of parameterized pre_test_hook I was actually answering to the suggestion robcresswell made some time ago17:45
*** btully has joined #openstack-horizon17:46
matt-borlandah17:46
*** ducttape_ has joined #openstack-horizon17:46
tsufievhas it clarified the situation for you, matt-borland?17:47
*** wolverineav has quit IRC17:48
* matt-borland reading back over lots of lines of IRC17:48
matt-borlandI guess I'm having difficulty understanding which approach is being suggested as preferable17:49
*** wolverineav has joined #openstack-horizon17:49
matt-borlandand where I start :)17:49
*** sguduru has joined #openstack-horizon17:50
matt-borlandSounds like I should familiarize myself with https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml#L27 as you suggest17:51
matt-borlandthen figure out where to intervene to supply the correct parameterization?17:51
*** wolverineav has quit IRC17:57
*** _stowa has joined #openstack-horizon17:58
*** cloudtrainme has joined #openstack-horizon17:58
tsufievmatt-borland, kind of. Once you understand that the pre_test_hook script is being executed from pre_test_hook err.. hook, you need to look at https://github.com/openstack/horizon/blob/master/tools/gate/integration/pre_test_hook.sh#L817:58
tsufieva config snippet is enabled there17:58
matt-borlandyep17:59
tsufievso, you need to use a slightly different snippet, which enables all angular things17:59
*** jprovazn has quit IRC17:59
matt-borlandAnd this is something that gets executed after the horizon codebase is loaded onto the test node, but before Horizon is run and tests are run?17:59
tsufievexactly!17:59
matt-borlandok, cool.  thanks...I think I can figure something out...the have someone tell me of a more elegant way :)  which is fine by me18:00
tsufievby the moment pre_test hook is run, all needed openstack repos are cloned, some of them even set to a specific branch18:00
tsufievbut none of devstack setup code was executed yet18:00
tsufievjust in case, partially this is covered in the testing topic guide18:01
tsufievtime for me to leave the office18:01
*** jprovazn has joined #openstack-horizon18:02
tsufievbye, matt-borland18:02
matt-borlandthanks again tsufiev!!18:02
*** cloudtrainme has quit IRC18:07
*** _stowa has quit IRC18:07
*** piet has quit IRC18:09
*** mtanino has joined #openstack-horizon18:14
*** wolverineav has joined #openstack-horizon18:16
*** tnovacik has joined #openstack-horizon18:17
*** piet has joined #openstack-horizon18:17
*** wolverineav has quit IRC18:19
*** wolverineav has joined #openstack-horizon18:19
*** cloudtrainme has joined #openstack-horizon18:20
*** sguduru_ has joined #openstack-horizon18:23
*** sguduru has quit IRC18:24
openstackgerritDiana Whitten proposed openstack/horizon: Style: Update Image Metadata overflow fail  https://review.openstack.org/34900818:26
openstackgerritJuan Pablo lopez Gutierrez proposed openstack/horizon: Move get_filters to parent Class  https://review.openstack.org/34177618:27
openstackgerritDiana Whitten proposed openstack/horizon: Style: Update Image Metadata overflow fail  https://review.openstack.org/34900818:27
*** wolverineav has quit IRC18:28
*** wolverineav has joined #openstack-horizon18:29
openstackgerritTravis Tripp proposed openstack/horizon: Remove array metadata when no items + fix case  https://review.openstack.org/34811918:42
openstackgerritMatt Borland proposed openstack/horizon: Pre-test hook for integration tests/deprecated  https://review.openstack.org/34902018:47
*** sdake has quit IRC18:47
*** sjmc7 has quit IRC18:48
openstackgerritJuan Pablo lopez Gutierrez proposed openstack/horizon: Server-side filtering networks  https://review.openstack.org/32918418:50
*** sjmc7 has joined #openstack-horizon18:52
openstackgerritDiana Whitten proposed openstack/horizon: UX: Add IPSec Policy Modal Hint List is hard to read  https://review.openstack.org/34902618:53
*** hoonetorg has quit IRC18:56
*** tlbr has joined #openstack-horizon19:00
*** tlbr is now known as Guest8412419:00
*** mpavlase has joined #openstack-horizon19:01
*** Tamayo has quit IRC19:02
*** Guest84124 has quit IRC19:04
*** yamamoto has quit IRC19:06
*** fifieldt has quit IRC19:07
*** roxanaghe has quit IRC19:10
*** mpavlase has quit IRC19:10
*** ducttape_ has quit IRC19:12
*** btully has quit IRC19:12
*** btully has joined #openstack-horizon19:13
*** ducttape_ has joined #openstack-horizon19:15
*** cloudtrainme has quit IRC19:17
*** fifieldt has joined #openstack-horizon19:18
*** piet has quit IRC19:21
*** sdake has joined #openstack-horizon19:35
*** btully has quit IRC19:37
openstackgerritDavid Lyle proposed openstack/horizon: Remove old style policy checks  https://review.openstack.org/34112819:46
*** Guest79100 has joined #openstack-horizon19:46
*** Guest79100 has quit IRC19:51
*** jprovazn has quit IRC19:54
*** asettle has joined #openstack-horizon19:58
*** sdake has quit IRC19:59
*** asettle has quit IRC20:03
*** roxanaghe has joined #openstack-horizon20:05
*** yamamoto has joined #openstack-horizon20:07
*** yamamoto has quit IRC20:12
*** btully has joined #openstack-horizon20:20
openstackgerritDavid Lyle proposed openstack/horizon: Update Plugin Registry  https://review.openstack.org/34588820:22
*** kzaitsev_mb has joined #openstack-horizon20:27
*** kzaitsev_mb has quit IRC20:33
*** sguduru_ has quit IRC20:40
*** kzaitsev_mb has joined #openstack-horizon20:42
*** Guest80 has joined #openstack-horizon20:42
*** aortega has quit IRC20:42
*** Guest80 has quit IRC20:42
*** kzaitsev_mb has quit IRC20:59
*** wolverin_ has joined #openstack-horizon21:03
*** wolverineav has quit IRC21:06
*** yamamoto has joined #openstack-horizon21:08
*** btully has quit IRC21:10
*** btully has joined #openstack-horizon21:10
*** yamamoto has quit IRC21:13
*** piet has joined #openstack-horizon21:14
*** matt-borland has quit IRC21:17
r1chardj0n3s_afkTravT: so I have a concrete need for ui-router (nested views) now in https://review.openstack.org/#/c/34874121:21
r1chardj0n3s_afk(also, I just reviewed that permissions patch, sorry I didn't do it yesterday)21:21
* TravT bites tongue21:23
TravTr1chardj0n3s_afk ^21:23
r1chardj0n3s_afkindeed21:23
david-lyleTravT: bite louder21:23
TravThehe21:23
TravTr1chardj0n3s_afk: thanks for the review on your saturday.21:24
openstackgerritTravis Tripp proposed openstack/horizon: hz-dynamic-table: Column level permissions  https://review.openstack.org/34624921:25
TravTr1chardj0n3s_afk: i fixed your nit. can you look again?21:26
r1chardj0n3s_afkTravT: done21:27
TravTthank you, sir21:27
*** ppiela has quit IRC21:28
tyr_r1chardj0n3s_afk: I believe you were trying to register resource types with complex identifiers. You might have a special interest in https://review.openstack.org/#/c/346269/21:28
r1chardj0n3s_afktyr_: yeah, I ran into that with list. I'm not using hz-resource-table (yet, possibly ever, don't know)21:31
*** pauloewerton has quit IRC21:32
tyr_I hit the same with Designate.21:32
r1chardj0n3s_afkyeah, I see that in that patch21:32
*** Guest97891 has joined #openstack-horizon21:32
r1chardj0n3s_afkI'll add that to my "things to look at" for Monday21:32
*** btully has quit IRC21:33
tyr_Designate zones contain recordsets. I registered recordsets as their own resource type...but their list function requires a "zoneId" parameter. That patch (and the linked example) shows my take on solving it that is also compatible with passing magic search filters through the list function.21:33
tyr_Thanks!21:33
*** btully has joined #openstack-horizon21:34
*** sergio_nubeliu has quit IRC21:38
*** Guest97891 has quit IRC21:39
*** tnovacik has quit IRC21:40
*** bpokorny has quit IRC21:40
*** wolverin_ has quit IRC21:41
*** aorourke has quit IRC21:43
*** liuyulong_ has joined #openstack-horizon21:44
*** liuyulong has quit IRC21:44
*** tlbr_ has joined #openstack-horizon21:46
*** liuyulong has joined #openstack-horizon21:47
*** tlbr_ has quit IRC21:47
*** liuyulong_ has quit IRC21:48
*** liuyulong_ has joined #openstack-horizon21:49
*** liuyulong has quit IRC21:52
*** tlbr_ has joined #openstack-horizon22:00
*** liuyulong_ has quit IRC22:03
*** liuyulong has joined #openstack-horizon22:04
*** tlbr_ has quit IRC22:04
*** kzaitsev_mb has joined #openstack-horizon22:04
*** kzaitsev_mb has quit IRC22:09
*** sjmc7 has quit IRC22:09
*** yamamoto has joined #openstack-horizon22:10
*** kzaitsev_mb has joined #openstack-horizon22:10
*** wolverineav has joined #openstack-horizon22:13
*** Guest13477 has joined #openstack-horizon22:14
*** ducttape_ has quit IRC22:14
*** yamamoto has quit IRC22:15
*** wolverineav has quit IRC22:18
*** Guest13477 has quit IRC22:19
*** sjmc7 has joined #openstack-horizon22:20
*** liuyulong_ has joined #openstack-horizon22:21
*** liuyulong has quit IRC22:22
*** wolverineav has joined #openstack-horizon22:33
ediardodavid-lyle: good idea using instagram for screenshots :P https://launchpadlibrarian.net/275739490/volume_source.png22:34
*** tlbr_ has joined #openstack-horizon22:35
*** liuyulong has joined #openstack-horizon22:37
*** wolverineav has quit IRC22:37
david-lylenot sure where the color filter came from22:38
david-lylebut pure excellence as always22:38
david-lylethose are my rose colored glasses22:38
*** dave-mccowan has quit IRC22:38
*** liuyulong_ has quit IRC22:39
*** wolverineav has joined #openstack-horizon22:40
*** tlbr_ has quit IRC22:40
*** wolverineav has quit IRC22:40
*** wolverineav has joined #openstack-horizon22:41
*** liuyulong_ has joined #openstack-horizon22:41
*** liuyulong has quit IRC22:41
*** liuyulong has joined #openstack-horizon22:47
*** sjmc7 has quit IRC22:49
*** liuyulong_ has quit IRC22:50
*** ducttape_ has joined #openstack-horizon22:50
*** Guest59655 has joined #openstack-horizon22:56
*** piet has quit IRC22:57
*** piet has joined #openstack-horizon22:58
*** Guest59655 has quit IRC23:02
*** martianwars has quit IRC23:03
*** xiong has joined #openstack-horizon23:09
openstackgerritTyr Johanson proposed openstack/horizon: Schema Form Developer Panel  https://review.openstack.org/34800023:10
*** yamamoto has joined #openstack-horizon23:12
*** tyr_ has quit IRC23:14
*** yamamoto has quit IRC23:17
*** tlbr_ has joined #openstack-horizon23:22
*** tlbr_ has quit IRC23:27
*** kzaitsev_mb has quit IRC23:28
*** jtriley has joined #openstack-horizon23:28
*** ducttape_ has quit IRC23:30
*** jtriley has quit IRC23:35
*** btully has quit IRC23:38
*** btully has joined #openstack-horizon23:40
*** jtriley has joined #openstack-horizon23:42
*** roxanaghe has quit IRC23:45
*** piet has quit IRC23:46
openstackgerritTravis Tripp proposed openstack/horizon: Adding project name column to ng images  https://review.openstack.org/33925623:46
*** ducttape_ has joined #openstack-horizon23:47
*** jtriley has quit IRC23:50
*** vishwanathj has quit IRC23:52
*** ducttape_ has quit IRC23:53
*** xiong has quit IRC23:53
*** piet has joined #openstack-horizon23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!