*** TravT has joined #openstack-horizon | 00:01 | |
*** ChanServ sets mode: +v TravT | 00:01 | |
*** TravT has quit IRC | 00:10 | |
*** mtanino has quit IRC | 00:11 | |
*** jtriley has quit IRC | 00:12 | |
*** TravT has joined #openstack-horizon | 00:15 | |
*** ChanServ sets mode: +v TravT | 00:15 | |
*** piet has quit IRC | 00:16 | |
*** wolverineav has joined #openstack-horizon | 00:17 | |
*** TravT has quit IRC | 00:19 | |
*** wolverin_ has quit IRC | 00:22 | |
*** TravT has joined #openstack-horizon | 00:25 | |
*** ChanServ sets mode: +v TravT | 00:25 | |
*** wolverineav has quit IRC | 00:26 | |
*** wolverineav has joined #openstack-horizon | 00:26 | |
*** bpokorny_ has joined #openstack-horizon | 00:31 | |
*** wolverineav has quit IRC | 00:31 | |
*** bpokorny has quit IRC | 00:34 | |
*** bpokorny_ has quit IRC | 00:36 | |
*** TravT has quit IRC | 00:38 | |
*** jtriley has joined #openstack-horizon | 00:38 | |
*** xiong has quit IRC | 00:40 | |
*** TravT has joined #openstack-horizon | 00:43 | |
*** ChanServ sets mode: +v TravT | 00:43 | |
*** aortega has quit IRC | 00:46 | |
*** jtriley has quit IRC | 00:46 | |
*** TravT has quit IRC | 00:56 | |
*** sdake has quit IRC | 00:57 | |
*** sdake has joined #openstack-horizon | 00:59 | |
*** TravT has joined #openstack-horizon | 01:01 | |
*** ChanServ sets mode: +v TravT | 01:01 | |
*** zhurong has joined #openstack-horizon | 01:10 | |
*** TravT has quit IRC | 01:14 | |
*** tqtran has quit IRC | 01:23 | |
*** clu_ has quit IRC | 01:29 | |
*** jtriley has joined #openstack-horizon | 01:34 | |
*** liuyulong_ has quit IRC | 01:35 | |
*** liuyulong has joined #openstack-horizon | 01:42 | |
*** TravT has joined #openstack-horizon | 01:43 | |
*** ChanServ sets mode: +v TravT | 01:43 | |
*** sdake has quit IRC | 01:44 | |
*** TravT has quit IRC | 01:47 | |
*** itisha has quit IRC | 01:50 | |
*** TravT has joined #openstack-horizon | 01:52 | |
*** ChanServ sets mode: +v TravT | 01:52 | |
*** pt_15 has quit IRC | 01:56 | |
*** aortega has joined #openstack-horizon | 01:56 | |
*** TravT has quit IRC | 02:01 | |
*** TravT has joined #openstack-horizon | 02:05 | |
*** ChanServ sets mode: +v TravT | 02:05 | |
*** btully has quit IRC | 02:13 | |
*** TravT has quit IRC | 02:18 | |
*** TravT has joined #openstack-horizon | 02:19 | |
*** ChanServ sets mode: +v TravT | 02:19 | |
*** TravT has quit IRC | 02:24 | |
*** TravT has joined #openstack-horizon | 02:28 | |
*** ChanServ sets mode: +v TravT | 02:28 | |
*** aortega has quit IRC | 02:31 | |
*** zhurong has quit IRC | 02:39 | |
*** zhurong has joined #openstack-horizon | 02:40 | |
*** dave-mccowan has joined #openstack-horizon | 02:41 | |
*** piet has joined #openstack-horizon | 02:48 | |
*** TravT has quit IRC | 02:54 | |
*** TravT has joined #openstack-horizon | 02:54 | |
*** ChanServ sets mode: +v TravT | 02:54 | |
*** TravT has quit IRC | 02:55 | |
*** tyr_ has joined #openstack-horizon | 02:56 | |
*** kfox1111 has quit IRC | 02:59 | |
*** tyr_ has quit IRC | 03:01 | |
*** piet has quit IRC | 03:01 | |
*** dave-mccowan has quit IRC | 03:08 | |
openstackgerrit | Merged openstack/horizon: Move get_filters to parent Class https://review.openstack.org/341776 | 03:10 |
---|---|---|
*** rajalokan has joined #openstack-horizon | 03:26 | |
*** btully has joined #openstack-horizon | 03:28 | |
*** yamamoto_ has joined #openstack-horizon | 03:33 | |
*** btully has quit IRC | 03:33 | |
*** roxanaghe has joined #openstack-horizon | 03:35 | |
*** sguduru has joined #openstack-horizon | 03:38 | |
*** sguduru_ has joined #openstack-horizon | 03:39 | |
*** sguduru has quit IRC | 03:42 | |
*** sdake has joined #openstack-horizon | 03:50 | |
*** sdake_ has joined #openstack-horizon | 03:54 | |
*** tyr_ has joined #openstack-horizon | 03:56 | |
*** sdake has quit IRC | 03:58 | |
*** tyr_ has quit IRC | 04:02 | |
*** sdake_ has quit IRC | 04:05 | |
*** zhurong has quit IRC | 04:07 | |
*** zhurong has joined #openstack-horizon | 04:11 | |
*** yingjun has quit IRC | 04:12 | |
*** yingjun has joined #openstack-horizon | 04:13 | |
*** ratailor has joined #openstack-horizon | 04:15 | |
*** yingjun has quit IRC | 04:17 | |
*** amotoki has joined #openstack-horizon | 04:20 | |
*** btully has joined #openstack-horizon | 04:24 | |
*** masco has joined #openstack-horizon | 04:29 | |
*** flwang has quit IRC | 04:35 | |
*** yingjun has joined #openstack-horizon | 04:38 | |
openstackgerrit | Merged openstack/horizon: Fix project name refresh in project menu bar https://review.openstack.org/316307 | 04:43 |
*** rajalokan has quit IRC | 04:49 | |
*** TravT has joined #openstack-horizon | 04:49 | |
*** ChanServ sets mode: +v TravT | 04:49 | |
*** yingjun has quit IRC | 04:49 | |
*** yingjun has joined #openstack-horizon | 04:49 | |
*** jtriley has quit IRC | 04:52 | |
*** yingjun has quit IRC | 04:54 | |
*** TravT has quit IRC | 04:58 | |
*** julim has quit IRC | 05:02 | |
*** TravT has joined #openstack-horizon | 05:02 | |
*** ChanServ sets mode: +v TravT | 05:02 | |
*** roxanaghe has quit IRC | 05:05 | |
*** TravT has quit IRC | 05:12 | |
*** rajalokan has joined #openstack-horizon | 05:13 | |
*** rcernin has joined #openstack-horizon | 05:28 | |
*** rajalokan has quit IRC | 05:35 | |
*** tyr_ has joined #openstack-horizon | 05:46 | |
*** yingjun has joined #openstack-horizon | 05:47 | |
*** tyr_ has quit IRC | 05:52 | |
*** julim has joined #openstack-horizon | 05:57 | |
*** sdake has joined #openstack-horizon | 06:07 | |
*** sdake has quit IRC | 06:07 | |
*** sdake has joined #openstack-horizon | 06:07 | |
*** javeriak has joined #openstack-horizon | 06:09 | |
*** TravT has joined #openstack-horizon | 06:17 | |
*** ChanServ sets mode: +v TravT | 06:17 | |
*** tqtran has joined #openstack-horizon | 06:21 | |
openstackgerrit | Kenji Ishii proposed openstack/horizon: Add a parameter fixed ip when creating a port https://review.openstack.org/325104 | 06:22 |
*** sdake has quit IRC | 06:23 | |
*** tqtran has quit IRC | 06:25 | |
*** TravT has quit IRC | 06:27 | |
*** TravT has joined #openstack-horizon | 06:31 | |
*** ChanServ sets mode: +v TravT | 06:31 | |
*** TravT has quit IRC | 06:40 | |
*** tovchinnikova has joined #openstack-horizon | 06:41 | |
*** belmoreira has joined #openstack-horizon | 06:42 | |
*** tesseract- has joined #openstack-horizon | 06:45 | |
*** mpavlase has joined #openstack-horizon | 06:47 | |
*** btully has quit IRC | 07:07 | |
*** btully has joined #openstack-horizon | 07:14 | |
*** btully has quit IRC | 07:19 | |
*** pcaruana has joined #openstack-horizon | 07:21 | |
*** cfriesen_ has quit IRC | 07:21 | |
*** ratailor has quit IRC | 07:24 | |
*** ratailor has joined #openstack-horizon | 07:25 | |
*** TravT has joined #openstack-horizon | 07:30 | |
*** ChanServ sets mode: +v TravT | 07:30 | |
robcresswell | tyr_, r1chardj0n3s: didn't the hz table work merge this cycle? You can change what you like if its within a release cycle | 07:31 |
r1chardj0n3s | robcresswell: a fine point | 07:34 |
*** jpich has joined #openstack-horizon | 07:35 | |
r1chardj0n3s | FWIW I banged my head against ui-router enough today to get a WIP going for swift ui but ... geez, it's a bit rough in places :/ | 07:35 |
*** tyr_ has joined #openstack-horizon | 07:35 | |
r1chardj0n3s | (like, you can have a route that consumes "the rest of the URL path" but the functions that generate URLs from your routes *can't generate URLs with paths in them* (the paths end up URI encoded!?) | 07:36 |
r1chardj0n3s | kinda bizarro | 07:36 |
*** javeriak has quit IRC | 07:38 | |
*** TravT has quit IRC | 07:39 | |
*** tyr_ has quit IRC | 07:40 | |
*** TravT has joined #openstack-horizon | 07:44 | |
*** ChanServ sets mode: +v TravT | 07:44 | |
*** TravT has quit IRC | 07:53 | |
*** rajalokan has joined #openstack-horizon | 07:55 | |
*** TravT has joined #openstack-horizon | 07:58 | |
*** ChanServ sets mode: +v TravT | 07:58 | |
*** amotoki has quit IRC | 08:00 | |
robcresswell | r1chardj0n3s: Cool. I can throw up an xstatic package if you're set on this being the way forward. Do we need 1.5.x? | 08:01 |
robcresswell | Just for testing purposes, that is. | 08:01 |
*** amotoki has joined #openstack-horizon | 08:04 | |
*** amotoki has quit IRC | 08:05 | |
*** Yaroslav has left #openstack-horizon | 08:06 | |
*** rajalokan has quit IRC | 08:10 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/horizon: [WIP] Testing latest u-c https://review.openstack.org/303429 | 08:10 |
*** TravT has quit IRC | 08:14 | |
*** amotoki has joined #openstack-horizon | 08:17 | |
*** amotoki_ has joined #openstack-horizon | 08:18 | |
*** TravT has joined #openstack-horizon | 08:19 | |
*** ChanServ sets mode: +v TravT | 08:19 | |
*** amotoki has quit IRC | 08:21 | |
*** tqtran has joined #openstack-horizon | 08:23 | |
*** tqtran has quit IRC | 08:27 | |
*** ygbo has joined #openstack-horizon | 08:28 | |
*** amotoki_ has quit IRC | 08:29 | |
*** itxaka has joined #openstack-horizon | 08:33 | |
*** TravT has quit IRC | 08:37 | |
*** TravT has joined #openstack-horizon | 08:42 | |
*** ChanServ sets mode: +v TravT | 08:42 | |
*** amotoki has joined #openstack-horizon | 08:45 | |
*** amotoki has quit IRC | 08:53 | |
*** TravT has quit IRC | 08:56 | |
*** TravT has joined #openstack-horizon | 09:00 | |
*** ChanServ sets mode: +v TravT | 09:00 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/349633 | 09:00 |
*** amotoki has joined #openstack-horizon | 09:02 | |
*** asettle has joined #openstack-horizon | 09:02 | |
*** amitkqed has quit IRC | 09:04 | |
*** amitkqed has joined #openstack-horizon | 09:04 | |
*** TravT has quit IRC | 09:10 | |
openstackgerrit | Timur Sufiev proposed openstack/horizon: [NG] Enhance Create Image workflow with upload tracking https://review.openstack.org/317457 | 09:13 |
*** TravT has joined #openstack-horizon | 09:14 | |
*** ChanServ sets mode: +v TravT | 09:14 | |
*** mflobo has joined #openstack-horizon | 09:20 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add Angular Schema Form https://review.openstack.org/332745 | 09:22 |
*** TravT has quit IRC | 09:23 | |
*** tyr_ has joined #openstack-horizon | 09:24 | |
*** tyr_ has quit IRC | 09:29 | |
*** yingjun has quit IRC | 09:35 | |
*** hoobaman has joined #openstack-horizon | 09:41 | |
*** yamamoto_ has quit IRC | 09:41 | |
hoobaman | hi | 09:41 |
hoobaman | can sombody elaborate the plans concerning the following bug? https://bugs.launchpad.net/horizon/+bug/1415588 | 09:41 |
openstack | Launchpad bug 1415588 in OpenStack Dashboard (Horizon) "Cannot list users and groups with Keystone v3" [Undecided,New] | 09:41 |
hoobaman | it gives somehow confusing behaviour for novice users | 09:42 |
mrunge | hoobaman, that bug has quite a history, and I'm sure folks there have quite different setups | 09:46 |
mrunge | hoobaman, what do you have? | 09:46 |
mrunge | hoobaman, like if you're syncing accounts from active directory, file a bug at microsoft | 09:47 |
mrunge | their implementation just sucks | 09:47 |
*** hughhalf has quit IRC | 09:47 | |
hoobaman | +mrunge: thx for your reply. Any workarounds available so that users get a more meaningfull error instead of a forced logout/403 forbidden? this is no problem for my automation but gives confusing behaviour for novice users that use horizon | 09:49 |
mrunge | no need to + or @ in front of the username | 09:50 |
mrunge | hoobaman, what happens? | 09:50 |
mrunge | hoobaman, what do you do, and what do you expect | 09:50 |
mrunge | hoobaman, and what version are you running? | 09:50 |
*** TravT has joined #openstack-horizon | 09:51 | |
*** ChanServ sets mode: +v TravT | 09:51 | |
hoobaman | pressing the button users or groups in the identity (login domain default with admin user) without setting a domain context gives a 403 forbidden (and forces user to logout) | 09:51 |
*** javeriak has joined #openstack-horizon | 09:51 | |
hoobaman | i am running liberty | 09:51 |
mrunge | domain support for keystone domains was merged in mitaka | 09:52 |
*** hughhalf has joined #openstack-horizon | 09:52 | |
hoobaman | but it is supported in liberty | 09:53 |
mrunge | who does? | 09:53 |
mrunge | as stated, the code for this was merged in mitaka development cycle | 09:53 |
mrunge | it can not be in liberty | 09:53 |
hoobaman | maybe because i am running osp8.0 (official RH liberty release), they confirmed it is supported in liberty | 09:54 |
mrunge | I see | 09:54 |
hoobaman | and indeed it works | 09:54 |
mrunge | hoobaman, please contact your tam/customer contact | 09:54 |
hoobaman | except from this weird 403 behaviour (no deomain context being set) | 09:54 |
mrunge | and we'll work it out | 09:54 |
hoobaman | ok was not aware you worked for RH :D, will do | 09:55 |
hoobaman | thx! | 09:55 |
*** TravT has quit IRC | 09:56 | |
mrunge | hoobaman, you can directly file a bug, https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20OpenStack | 09:56 |
mrunge | component python-django-horizon | 09:56 |
hoobaman | mrunge: thx! | 09:57 |
mrunge | hoobaman, actively setting the domain context fixes this for you? | 09:57 |
mrunge | I believe I remember a bug on this, and I think I even had a one line patch | 09:58 |
hoobaman | mrunge, yes if i set/switch to domain context first, it works | 09:58 |
mrunge | please note that in your bug report/to your supporter. that helps immensely | 09:59 |
hoobaman | mrunge, ok i will make full bug report with reproducable steps and debug output | 09:59 |
mrunge | hoobaman, thanks a lot | 10:00 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Add Angular Schema Form https://review.openstack.org/332745 | 10:02 |
*** TravT has joined #openstack-horizon | 10:05 | |
*** ChanServ sets mode: +v TravT | 10:05 | |
*** amit213 has quit IRC | 10:10 | |
*** amit213 has joined #openstack-horizon | 10:12 | |
hoobaman | mrunge: no problem :) | 10:13 |
*** zhurong has quit IRC | 10:13 | |
*** TravT has quit IRC | 10:14 | |
*** yamamoto has joined #openstack-horizon | 10:17 | |
*** TravT has joined #openstack-horizon | 10:18 | |
*** ChanServ sets mode: +v TravT | 10:18 | |
*** alexander__ is now known as amakarov | 10:19 | |
*** javeriak has quit IRC | 10:21 | |
*** yamamoto has quit IRC | 10:22 | |
*** yamamoto has joined #openstack-horizon | 10:23 | |
*** tosky has joined #openstack-horizon | 10:25 | |
*** asettle has quit IRC | 10:27 | |
*** asettle has joined #openstack-horizon | 10:27 | |
*** yamamoto has quit IRC | 10:28 | |
*** amotoki has quit IRC | 10:30 | |
*** rodrigods has quit IRC | 10:30 | |
*** rodrigods has joined #openstack-horizon | 10:30 | |
*** TravT has quit IRC | 10:32 | |
openstackgerrit | Rob Cresswell proposed openstack/xstatic-bootstrap-scss: Update xstatic-bootstrap to 3.3.7.0 https://review.openstack.org/350514 | 10:38 |
*** amotoki has joined #openstack-horizon | 10:39 | |
*** tosky has quit IRC | 10:39 | |
*** tosky has joined #openstack-horizon | 10:39 | |
*** tosky has quit IRC | 10:39 | |
*** tosky has joined #openstack-horizon | 10:40 | |
*** amotoki has quit IRC | 10:41 | |
*** aortega has joined #openstack-horizon | 10:41 | |
*** tosky has quit IRC | 10:41 | |
*** tosky has joined #openstack-horizon | 10:43 | |
*** tosky has quit IRC | 10:49 | |
*** javeriak has joined #openstack-horizon | 10:51 | |
*** btully has joined #openstack-horizon | 10:53 | |
*** tosky has joined #openstack-horizon | 10:54 | |
*** yamamoto has joined #openstack-horizon | 10:55 | |
*** btully has quit IRC | 10:57 | |
*** yamamoto has quit IRC | 11:11 | |
*** javeriak has quit IRC | 11:12 | |
*** tyr_ has joined #openstack-horizon | 11:12 | |
openstackgerrit | Richard Jones proposed openstack/horizon: WIP: use ui-router for swift ui panel construction https://review.openstack.org/350523 | 11:13 |
r1chardj0n3s | robcresswell: I've already put up the ui-router xstatic package, and that ^^ is my WIP very raw, needs a bunch of work experiment in getting it into swift ui. | 11:13 |
robcresswell | r1chardj0n3s: Ah, nice | 11:14 |
r1chardj0n3s | robcresswell: there's some patterns used ui-router that don't mesh well with the patterns I used in swift ui so there's still some re-working for it to make more sense | 11:15 |
r1chardj0n3s | hoping I'll find some time to do that tomorrow | 11:15 |
*** tyr_ has quit IRC | 11:17 | |
robcresswell | r1chardj0n3s: Cool. I won't get much time this week to look at it, but may do next week. | 11:17 |
robcresswell | r1chardj0n3s: Thanks for the POC anyway, helps a lot | 11:18 |
*** mflobo has quit IRC | 11:18 | |
*** mflobo has joined #openstack-horizon | 11:28 | |
*** javeriak has joined #openstack-horizon | 11:29 | |
*** aortega has quit IRC | 11:31 | |
*** mflobo has quit IRC | 11:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/350529 | 11:40 |
*** sguduru_ has quit IRC | 11:52 | |
*** yamamoto has joined #openstack-horizon | 11:54 | |
*** yamamoto has quit IRC | 11:59 | |
*** yamamoto has joined #openstack-horizon | 12:00 | |
*** TravT has joined #openstack-horizon | 12:05 | |
*** ChanServ sets mode: +v TravT | 12:05 | |
openstackgerrit | Yury Tregubov proposed openstack/horizon: Added test for flavor metadata update https://review.openstack.org/293860 | 12:05 |
*** yamamoto has quit IRC | 12:05 | |
*** ducttape_ has joined #openstack-horizon | 12:06 | |
*** javeriak has quit IRC | 12:08 | |
*** yamamoto has joined #openstack-horizon | 12:11 | |
*** aortega has joined #openstack-horizon | 12:19 | |
openstackgerrit | Merged openstack/horizon: Remove 'default' theme styles https://review.openstack.org/310857 | 12:21 |
openstackgerrit | Merged openstack/horizon: NG Images Create Volume should use constant from images.module.js https://review.openstack.org/344989 | 12:23 |
*** TravT has quit IRC | 12:23 | |
*** tqtran has joined #openstack-horizon | 12:25 | |
*** TravT has joined #openstack-horizon | 12:28 | |
*** ChanServ sets mode: +v TravT | 12:28 | |
*** tqtran has quit IRC | 12:30 | |
*** pt_15 has joined #openstack-horizon | 12:31 | |
*** zhurong has joined #openstack-horizon | 12:33 | |
*** sdake has joined #openstack-horizon | 12:37 | |
*** javeriak has joined #openstack-horizon | 12:45 | |
*** javeriak has quit IRC | 12:46 | |
*** piet_ has joined #openstack-horizon | 12:46 | |
*** ratailor has quit IRC | 12:47 | |
*** julim has quit IRC | 12:48 | |
*** yamamoto has quit IRC | 12:49 | |
*** matt-borland has joined #openstack-horizon | 12:51 | |
*** tosky has quit IRC | 12:53 | |
*** tosky has joined #openstack-horizon | 12:55 | |
*** tyr_ has joined #openstack-horizon | 13:01 | |
*** btully has joined #openstack-horizon | 13:02 | |
*** jtriley has joined #openstack-horizon | 13:04 | |
*** pauloewerton has joined #openstack-horizon | 13:04 | |
*** piet_ has quit IRC | 13:05 | |
*** tyr_ has quit IRC | 13:06 | |
matt-borland | o/ robcresswell...that Images switch patch is amended as you suggested, and both it and the follow-on passed check, with the correctly skipped/run tests. | 13:09 |
*** ezpz has joined #openstack-horizon | 13:09 | |
robcresswell | brilliant, thanks matt | 13:10 |
*** dave-mccowan has joined #openstack-horizon | 13:10 | |
robcresswell | matt-borland: I updated schema form to add tests for uuid and comments etc | 13:10 |
matt-borland | awesome! | 13:10 |
matt-borland | thanks for doing that robcresswell | 13:11 |
*** ducttape_ has quit IRC | 13:11 | |
robcresswell | matt-borland: I'm kinda running up against how much longer I can spend on that patch, so feel free to dive in and make any small amendments yourself | 13:11 |
matt-borland | I'll review, and probably give it my +1.99... | 13:11 |
*** yamamoto has joined #openstack-horizon | 13:13 | |
*** TravT has quit IRC | 13:14 | |
matt-borland | robcresswell, tsufiev...is that Launch Instance error resolved? Or does it need attention? | 13:14 |
*** agireud has quit IRC | 13:14 | |
robcresswell | matt-borland: Needs attention. My time is wrapped up in django upgrades and reviews at the moment | 13:15 |
matt-borland | OK, I'll look at it. | 13:15 |
robcresswell | and schema-form/create net :) | 13:15 |
robcresswell | matt-borland: Great, thanks! | 13:15 |
*** zhurong has quit IRC | 13:15 | |
matt-borland | I'm about to drop that mighty +1, once I verify a couple things with the schema-form | 13:15 |
*** zhurong has joined #openstack-horizon | 13:16 | |
*** agireud has joined #openstack-horizon | 13:17 | |
*** TravT has joined #openstack-horizon | 13:18 | |
*** ChanServ sets mode: +v TravT | 13:18 | |
matt-borland | +1 robcresswell...I think it's time for your patch to land. | 13:20 |
robcresswell | Thanks matt-borland | 13:23 |
tsufiev | matt-borland, thanks for looking into this! | 13:24 |
*** hoobaman has quit IRC | 13:25 | |
robcresswell | Apologies to anyone who gets caught up in the abandon-storm going on. | 13:25 |
matt-borland | no problem, I think it was a combo change that killed it. | 13:25 |
matt-borland | hzDynamicTable is seeing a lot of traffic | 13:25 |
*** zhurong has quit IRC | 13:25 | |
tsufiev | yep, two angular experts has been reviewing hz-dynamic-table/transfer-table patch itself and didn't find any issues | 13:25 |
*** yamamoto has quit IRC | 13:26 | |
*** zhurong has joined #openstack-horizon | 13:26 | |
*** TravT has quit IRC | 13:27 | |
*** belmoreira has quit IRC | 13:31 | |
robcresswell | tsufiev: Probably just one of those strange issues that sneaks through :) | 13:31 |
tsufiev | robcresswell, software w/o bugs is just a software w/o proper testing ;) | 13:33 |
matt-borland | tsufiev, robcresswell the cause is the deep copy of the configuration that was added in the columns permissions patch | 13:37 |
matt-borland | It's the right thing, but has an effect (that I still have to grasp) | 13:37 |
matt-borland | If you comment out that deep copy, the keypair (including the permissions) works fine. | 13:37 |
matt-borland | The issue is that in passing around the config and attaching things to it, we'd be holding those at the config itself, not a copy, which is why he implemented a deep copy. | 13:38 |
matt-borland | Let me look at options. | 13:40 |
*** lblanchard has joined #openstack-horizon | 13:40 | |
*** asettle has quit IRC | 13:41 | |
robcresswell | lcastell: Do you still have time to work on the inline edit removal? | 13:41 |
*** TravT has joined #openstack-horizon | 13:41 | |
*** ChanServ sets mode: +v TravT | 13:41 | |
matt-borland | TravT, looking at a side-effect issue with the column permissions patch on LI keypair | 13:44 |
matt-borland | (well, on the transfer table work) | 13:44 |
matt-borland | I think I have a solution | 13:44 |
tsufiev | matt-borland, what if that deepcopy will be moved to postLink? | 13:45 |
matt-borland | see patch I will have in about 1.2 minutes | 13:46 |
openstackgerrit | Matt Borland proposed openstack/horizon: Don't overwrite dynamic-table config with deep copy https://review.openstack.org/350593 | 13:47 |
matt-borland | ok, 1.4 minutes. | 13:48 |
matt-borland | tsufiev, robcresswell ^^ | 13:48 |
* tsufiev is going to see what tests say | 13:48 | |
robcresswell | thanks matt-borland | 13:48 |
*** zhurong has quit IRC | 13:48 | |
matt-borland | Yeah, I should probably lint it...I just wanted to suggest a solution | 13:49 |
*** zhurong has joined #openstack-horizon | 13:49 | |
matt-borland | It passes lint and js tests | 13:50 |
*** uxdanielle has joined #openstack-horizon | 13:51 | |
matt-borland | TravT, you might want to check out that fix as well ^^ | 13:52 |
*** TravT has quit IRC | 13:55 | |
*** zhurong has quit IRC | 13:57 | |
*** asettle has joined #openstack-horizon | 13:58 | |
*** zhurong has joined #openstack-horizon | 13:58 | |
*** TravT has joined #openstack-horizon | 14:00 | |
*** ChanServ sets mode: +v TravT | 14:00 | |
*** krot_sickleave is now known as krotscheck | 14:00 | |
*** asettle has quit IRC | 14:02 | |
*** ducttape_ has joined #openstack-horizon | 14:06 | |
*** cfriesen_ has joined #openstack-horizon | 14:07 | |
robcresswell | Just abandoned a good number of patches, feel free to restore if they are still valid | 14:07 |
robcresswell | They were all >3 months old with - votes | 14:07 |
matt-borland | sounds good | 14:09 |
matt-borland | do Abandoned patches ever get fully deleted? | 14:09 |
robcresswell | I don't know the answer to that | 14:10 |
robcresswell | Probably not, since its really just git history | 14:10 |
*** TravT has quit IRC | 14:13 | |
*** amotoki has joined #openstack-horizon | 14:18 | |
*** TravT has joined #openstack-horizon | 14:18 | |
*** ChanServ sets mode: +v TravT | 14:18 | |
*** yingjun has joined #openstack-horizon | 14:19 | |
openstackgerrit | Matt Borland proposed openstack/horizon: Flavors panel can switch to Angular https://review.openstack.org/343917 | 14:20 |
openstackgerrit | Matt Borland proposed openstack/horizon: WIP: Enable Angular Flavors Panel https://review.openstack.org/344456 | 14:20 |
*** sjmc7 has joined #openstack-horizon | 14:21 | |
*** ppiela has quit IRC | 14:26 | |
*** yamamoto has joined #openstack-horizon | 14:26 | |
*** ppiela has joined #openstack-horizon | 14:28 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Improve Horizon nav sidebar https://review.openstack.org/297733 | 14:31 |
*** TravT has quit IRC | 14:32 | |
*** yamamoto has quit IRC | 14:33 | |
*** mtanino has joined #openstack-horizon | 14:40 | |
*** amotoki has quit IRC | 14:40 | |
*** TravT has joined #openstack-horizon | 14:41 | |
*** ChanServ sets mode: +v TravT | 14:41 | |
*** tyr_ has joined #openstack-horizon | 14:42 | |
*** TravT has quit IRC | 14:45 | |
*** amotoki has joined #openstack-horizon | 14:45 | |
*** TravT has joined #openstack-horizon | 14:46 | |
*** ChanServ sets mode: +v TravT | 14:46 | |
*** TravT_ has joined #openstack-horizon | 14:49 | |
*** ChanServ sets mode: +v TravT_ | 14:49 | |
*** TravT has quit IRC | 14:50 | |
TravT_ | matt-borland: tyr put up a patch that fixes to config copying and conflicts with your patch. | 14:51 |
TravT_ | https://review.openstack.org/#/c/346269 | 14:51 |
*** TravT_ is now known as TravT | 14:51 | |
matt-borland | TravT, let's land the fix first. | 14:51 |
*** hurgleburgler1 has joined #openstack-horizon | 14:51 | |
matt-borland | if it's fixed differently, then land that separately. | 14:51 |
matt-borland | I don't want a critical fix tied up with a feature. | 14:51 |
TravT | hmm, let me look at both. if his fixes it as well and is ready to land then i don't think we need to do that. | 14:52 |
*** tjones has joined #openstack-horizon | 14:54 | |
tyr_ | mine does. I'd prefer we iterate on my patch. At this point in the game I don't think we want to change the scope attributes on hz-dynamic-table. That risks breaking hz-detail-row templates that make assumptions about what data they can use. | 14:54 |
*** Tamayo has joined #openstack-horizon | 14:54 | |
tyr_ | unless we need a quick short term fix | 14:55 |
matt-borland | master is broken currently, which is the issue. | 14:55 |
tyr_ | See what you think about https://review.openstack.org/#/c/346269 | 14:56 |
*** amakarov has quit IRC | 14:58 | |
matt-borland | It sounds like we're close on your patch tyr_. If TravT is at a +2 phase, then let's find a second core that's ready to close on it within 24 horus. | 14:58 |
matt-borland | *hours | 14:58 |
tyr_ | roger | 14:58 |
matt-borland | I don't want inappropriate pressure to land your patch in order to solve this problem | 14:58 |
*** asettle has joined #openstack-horizon | 14:59 | |
tyr_ | I'll keep close watch on it today. I can spin in any changes as needed. It fixes a number of non-dynamic binding issues which I *think* might show up as race conditions. | 14:59 |
matt-borland | awesome | 14:59 |
TravT | agreed. if there are major issues or concerns with tyr's then we shouldn't hold up your fix matt-borland. But, let's look through Tyr's now. If you could also look at his patch, I'm doing the same right now. | 14:59 |
matt-borland | If you do iterate, please add: Closes-Bug: 1608462 | 15:00 |
tyr_ | k | 15:00 |
openstack | bug 1608462 in OpenStack Dashboard (Horizon) "'non-assignable' JS error in NG LI" [Critical,In progress] https://launchpad.net/bugs/1608462 - Assigned to Matt Borland (palecrow) | 15:00 |
*** amakarov has joined #openstack-horizon | 15:00 | |
*** weezS has joined #openstack-horizon | 15:01 | |
*** asettle has quit IRC | 15:03 | |
*** amotoki has quit IRC | 15:06 | |
openstackgerrit | Merged openstack/horizon: No more braces-style eslint errors https://review.openstack.org/346244 | 15:06 |
robcresswell | argh someone's done url patterns in the 1.7 style *again* :( | 15:06 |
sjmc7 | flay them alive! | 15:07 |
robcresswell | Patch no.4 to undo this. | 15:07 |
sjmc7 | unless it was me | 15:07 |
*** roxanaghe has joined #openstack-horizon | 15:07 | |
robcresswell | I've removed them all from horizon several times and people keep merging new ones, gah | 15:07 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: [Django 1.10] Fix urls.url wrong call https://review.openstack.org/345259 | 15:08 |
*** bpokorny has joined #openstack-horizon | 15:10 | |
openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/350529 | 15:13 |
*** julim has joined #openstack-horizon | 15:16 | |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix missing 'THEME' key https://review.openstack.org/344871 | 15:16 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: Fix URL patterns again https://review.openstack.org/350642 | 15:18 |
openstackgerrit | Rob Cresswell proposed openstack/horizon: [Django 1.10] Fix URL patterns again https://review.openstack.org/350642 | 15:18 |
*** amotoki has joined #openstack-horizon | 15:22 | |
*** dave-mccowan has quit IRC | 15:24 | |
robcresswell | fixed ^^ | 15:25 |
*** yingjun has quit IRC | 15:28 | |
*** yingjun has joined #openstack-horizon | 15:28 | |
*** wolverineav has joined #openstack-horizon | 15:30 | |
*** zhurong has quit IRC | 15:33 | |
*** yingjun has quit IRC | 15:33 | |
ediardo | hurglerburgler: did you have a chance to look at the 404 error page? | 15:33 |
*** yingjun has joined #openstack-horizon | 15:34 | |
ediardo | ^^ https://bugs.launchpad.net/horizon/+bug/1606294 ^^ | 15:34 |
openstack | Launchpad bug 1606294 in OpenStack Dashboard (Horizon) "Error 404 is poorly styled" [Undecided,New] | 15:34 |
*** mflobo has joined #openstack-horizon | 15:36 | |
*** yingjun has quit IRC | 15:38 | |
*** piet has joined #openstack-horizon | 15:39 | |
*** hurgleburgler has joined #openstack-horizon | 15:43 | |
*** ChanServ sets mode: +v hurgleburgler | 15:43 | |
*** hurgleburgler1 has quit IRC | 15:43 | |
*** pece has joined #openstack-horizon | 15:45 | |
*** itxaka has quit IRC | 15:46 | |
pece | hi, does DDT (Django Debug Toolbar) work with Horizon? | 15:48 |
zigo | robcresswell: Your new patch at https://review.openstack.org/#/c/345259/ makes it 32 errors instead of 4 in Django 1.10 horizon unit tests. | 15:56 |
openstackgerrit | Zarrouk Mohamed proposed openstack/horizon: Do not send shared param when not allowed. https://review.openstack.org/350661 | 15:57 |
*** alexvictorchan has joined #openstack-horizon | 15:58 | |
openstackgerrit | Zarrouk Mohamed proposed openstack/horizon: Do not send shared param when not allowed. https://review.openstack.org/350661 | 15:58 |
david-lyle | zigo, wrong direction?? | 15:58 |
zigo | david-lyle: I'm almost sure that my version of the patch is wrong too! :) | 15:59 |
*** rfinn has joined #openstack-horizon | 16:02 | |
*** itisha has joined #openstack-horizon | 16:04 | |
*** esp has joined #openstack-horizon | 16:04 | |
openstackgerrit | Ankur proposed openstack/horizon: Add Port-Create in Project Dashboard https://review.openstack.org/320203 | 16:05 |
openstackgerrit | Ankur proposed openstack/horizon: Ability to delete network items from their details page https://review.openstack.org/336662 | 16:05 |
openstackgerrit | Rebecca Finn proposed openstack/horizon: Allow instance snapshot to be pre-selected as source image https://review.openstack.org/350291 | 16:08 |
*** ygbo has quit IRC | 16:10 | |
openstackgerrit | Juan Pablo lopez Gutierrez proposed openstack/horizon: Server-side filtering routers https://review.openstack.org/333007 | 16:16 |
*** roxanaghe has quit IRC | 16:20 | |
*** tovchinnikova has quit IRC | 16:26 | |
*** tqtran has joined #openstack-horizon | 16:27 | |
*** tqtran has quit IRC | 16:31 | |
*** roxanaghe has joined #openstack-horizon | 16:35 | |
*** rcernin has quit IRC | 16:38 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: DynamicTypedChoiceField https://review.openstack.org/350687 | 16:44 |
*** pece has quit IRC | 16:44 | |
*** roxanaghe has quit IRC | 16:45 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: DynamicTypedChoiceField https://review.openstack.org/350687 | 16:46 |
*** roxanaghe has joined #openstack-horizon | 16:47 | |
*** javeriak has joined #openstack-horizon | 16:48 | |
*** krotscheck is now known as kro_focused | 16:53 | |
*** weezS has quit IRC | 16:53 | |
*** roxanaghe has quit IRC | 16:56 | |
*** roxanaghe has joined #openstack-horizon | 16:57 | |
*** roxanaghe has quit IRC | 16:57 | |
*** roxanaghe has joined #openstack-horizon | 16:57 | |
*** clu_ has joined #openstack-horizon | 16:59 | |
*** ChanServ sets mode: +v clu_ | 16:59 | |
*** asettle has joined #openstack-horizon | 17:00 | |
*** pcaruana has quit IRC | 17:00 | |
*** tqtran has joined #openstack-horizon | 17:00 | |
*** tqtran_ has joined #openstack-horizon | 17:01 | |
*** tesseract- has quit IRC | 17:03 | |
*** tqtran has quit IRC | 17:04 | |
openstackgerrit | Purva Tendulkar proposed openstack/horizon: Help tooltips added for dashboard names in the left navigation bar using Bootstrap tooltips. https://review.openstack.org/350236 | 17:05 |
*** openstackgerrit_ has joined #openstack-horizon | 17:07 | |
*** openstackgerrit_ has quit IRC | 17:08 | |
*** bpokorny has quit IRC | 17:08 | |
robcresswell | zigo: I'll investigate, probably a typo or something. | 17:09 |
*** piet has quit IRC | 17:09 | |
robcresswell | pece: Yes, it works, but you'll have to add it manually I suppose. | 17:10 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon: Revert "i18n: trim whitespaces in extracted messages" https://review.openstack.org/349758 | 17:11 |
openstackgerrit | Diana Whitten proposed openstack/horizon: UX: Add IPSec Policy Modal Hint List is hard to read https://review.openstack.org/349026 | 17:14 |
openstackgerrit | Diana Whitten proposed openstack/horizon: UX: System Information Overflow Fail https://review.openstack.org/350281 | 17:14 |
openstackgerrit | Purva Tendulkar proposed openstack/horizon: Help tooltips added for dashboard names in the left navigation bar https://review.openstack.org/350236 | 17:15 |
robcresswell | amotoki: Is there not an improvement to the gettect logic we can use, to avoid a revert? | 17:15 |
robcresswell | amotoki: Fixing a bug with a lesser bug is a bit of a sad state of affairs :) | 17:15 |
amotoki | robcresswell: I think the root cause is that we use diffierent logic for extraction and displaying. | 17:16 |
amotoki | robcresswell: we use babel for extracting messages and use angular-gettext when looking for translated messages. | 17:16 |
*** piet has joined #openstack-horizon | 17:16 | |
robcresswell | amotoki: Happy to revert as I understand your point about it being a lesser issue. | 17:17 |
amotoki | robcresswell: I might be missing something because I haven't fully investigated angular-gettext but we need to match both logic. | 17:17 |
robcresswell | Hm :/ I don't have time to look into this right now, either | 17:18 |
robcresswell | We can revert I suppose, and I'll re-open the original bug | 17:18 |
amotoki | robcresswell: totally agree. we need to re-open the original bug. | 17:18 |
robcresswell | amotoki: Should I remove you as assignee? Or will you be able to investigate? | 17:19 |
robcresswell | https://bugs.launchpad.net/horizon/+bug/1592965 | 17:19 |
openstack | Launchpad bug 1592965 in OpenStack Dashboard (Horizon) "i18n: babel_extract_angular should trim whitespaces in AngularJS templates" [Medium,Confirmed] - Assigned to Akihiro Motoki (amotoki) | 17:19 |
amotoki | robcresswell: i think it is better to remove me from the assignee. it would be great if someone dive it in :) | 17:20 |
amotoki | robcresswell: anyway it is in my mind | 17:20 |
robcresswell | sure, thanks amotoki :) | 17:20 |
*** dave-mccowan has joined #openstack-horizon | 17:20 | |
amotoki | i will add the background of the revert to the bug to help others | 17:21 |
*** bpokorny has joined #openstack-horizon | 17:21 | |
robcresswell | amotoki: Thanks. I linked the patch in the comments too | 17:22 |
*** dave-mcc_ has joined #openstack-horizon | 17:22 | |
*** amakarov is now known as amakarov_away | 17:24 | |
*** sguduru has joined #openstack-horizon | 17:24 | |
*** dave-mccowan has quit IRC | 17:27 | |
*** Marcellin_ has joined #openstack-horizon | 17:27 | |
*** sguduru has quit IRC | 17:28 | |
*** TravT has quit IRC | 17:35 | |
*** javeriak has quit IRC | 17:35 | |
*** weezS has joined #openstack-horizon | 17:35 | |
*** TravT has joined #openstack-horizon | 17:35 | |
*** ChanServ sets mode: +v TravT | 17:35 | |
*** zackf has joined #openstack-horizon | 17:38 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: replace horizon.alert used by client-side with horizon.toast https://review.openstack.org/350706 | 17:38 |
*** wolverin_ has joined #openstack-horizon | 17:40 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Allow listFunction extra params https://review.openstack.org/346269 | 17:41 |
*** wolverineav has quit IRC | 17:42 | |
*** piet has quit IRC | 17:45 | |
*** julim has quit IRC | 17:53 | |
*** julim has joined #openstack-horizon | 17:56 | |
kro_focused | matt-borland: Added two escape brackets to your patch. It should pass the gate now. | 17:57 |
kro_focused | matt-borland: I forgot that once you started to do variable replacements, the function closure brackets needed to be doubly escaped. | 17:58 |
*** harlowja has quit IRC | 17:58 | |
*** wolverin_ has quit IRC | 18:00 | |
*** harlowja has joined #openstack-horizon | 18:00 | |
*** wolverineav has joined #openstack-horizon | 18:00 | |
*** esp has quit IRC | 18:02 | |
openstackgerrit | Ryan Peters proposed openstack/horizon: Horizon Radio Buttons are now themeable. https://review.openstack.org/278041 | 18:03 |
*** mpavlase has quit IRC | 18:04 | |
*** piet has joined #openstack-horizon | 18:04 | |
*** wolverin_ has joined #openstack-horizon | 18:05 | |
*** wolverin_ has quit IRC | 18:05 | |
*** wolverin_ has joined #openstack-horizon | 18:05 | |
*** asettle has quit IRC | 18:07 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: Allow listFunction extra params https://review.openstack.org/346269 | 18:07 |
*** wolverineav has quit IRC | 18:08 | |
*** dave-mcc_ has quit IRC | 18:08 | |
*** tosky has quit IRC | 18:09 | |
*** Tamayo has quit IRC | 18:10 | |
*** Tamayo has joined #openstack-horizon | 18:11 | |
*** Tamayo has quit IRC | 18:11 | |
*** Tamayo has joined #openstack-horizon | 18:11 | |
*** xenogear has quit IRC | 18:12 | |
*** Tamayo has quit IRC | 18:12 | |
*** yohoffman has quit IRC | 18:13 | |
*** esp has joined #openstack-horizon | 18:13 | |
*** Tamayo_ has joined #openstack-horizon | 18:15 | |
*** Tamayo_ has quit IRC | 18:17 | |
*** Tamayo_ has joined #openstack-horizon | 18:18 | |
*** Tamayo_ has quit IRC | 18:19 | |
*** Tamayo has joined #openstack-horizon | 18:20 | |
*** jpich has quit IRC | 18:22 | |
*** Tamayo has quit IRC | 18:24 | |
*** mflobo has quit IRC | 18:27 | |
openstackgerrit | Diana Whitten proposed openstack/horizon: UX: Add IPSec Policy Modal Hint List is hard to read https://review.openstack.org/349026 | 18:27 |
*** yohoffman has joined #openstack-horizon | 18:28 | |
*** bpokorny has quit IRC | 18:28 | |
matt-borland | kro_focused, THANK YOU!!! :) | 18:32 |
*** bpokorny has joined #openstack-horizon | 18:33 | |
*** bpokorny has quit IRC | 18:35 | |
*** amotoki has quit IRC | 18:37 | |
*** piet has quit IRC | 18:43 | |
*** Tamayo has joined #openstack-horizon | 18:43 | |
*** xenogear has joined #openstack-horizon | 18:44 | |
*** ametts has joined #openstack-horizon | 18:45 | |
*** julim has quit IRC | 18:46 | |
*** piet has joined #openstack-horizon | 18:50 | |
*** wolverin_ has quit IRC | 18:52 | |
*** ezpz has quit IRC | 18:54 | |
*** Tamayo has quit IRC | 18:59 | |
openstackgerrit | Rebecca Finn proposed openstack/horizon: Do not allow spaces as key pair name https://review.openstack.org/350747 | 19:00 |
*** dave-mccowan has joined #openstack-horizon | 19:04 | |
*** fifieldt has quit IRC | 19:07 | |
openstackgerrit | Merged openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/349633 | 19:09 |
openstackgerrit | Merged openstack/django_openstack_auth: Not authorized when logout and creating instance https://review.openstack.org/340689 | 19:09 |
*** fifieldt has joined #openstack-horizon | 19:18 | |
*** mpavlase has joined #openstack-horizon | 19:23 | |
*** zul_ has joined #openstack-horizon | 19:23 | |
*** bpokorny has joined #openstack-horizon | 19:23 | |
*** schipiga has joined #openstack-horizon | 19:24 | |
*** bpokorny has quit IRC | 19:24 | |
*** bpokorny has joined #openstack-horizon | 19:24 | |
*** asettle has joined #openstack-horizon | 19:27 | |
*** piet has quit IRC | 19:28 | |
*** piet has joined #openstack-horizon | 19:29 | |
*** tesseract- has joined #openstack-horizon | 19:31 | |
*** ametts has quit IRC | 19:32 | |
*** rfinn has quit IRC | 19:34 | |
*** aortega has quit IRC | 19:34 | |
*** zul_ has quit IRC | 19:35 | |
*** zul_ has joined #openstack-horizon | 19:35 | |
*** tesseract- has quit IRC | 19:37 | |
*** dsneddon has quit IRC | 19:39 | |
*** dsneddon has joined #openstack-horizon | 19:39 | |
robcresswell | tsufiev: https://review.openstack.org/#/c/344871/ | 19:40 |
robcresswell | tsufiev: That should solve your issues? | 19:40 |
*** asettle has quit IRC | 19:42 | |
*** ametts has joined #openstack-horizon | 19:45 | |
tsufiev | robcresswell, thank you. To be sure I need to test it first with https://review.openstack.org/#/c/345628/ | 19:48 |
*** roxanaghe has quit IRC | 19:48 | |
openstackgerrit | Steve McLellan proposed openstack/horizon: Swift account quota support https://review.openstack.org/345071 | 19:53 |
*** rfinn has joined #openstack-horizon | 19:55 | |
*** TravT has quit IRC | 19:56 | |
*** asettle has joined #openstack-horizon | 19:59 | |
*** asettle has quit IRC | 19:59 | |
*** TravT has joined #openstack-horizon | 19:59 | |
*** ChanServ sets mode: +v TravT | 19:59 | |
tsufiev | ducttape_, just have tried to absorb the info in the etherpad about quotas-redo | 20:01 |
*** revon has joined #openstack-horizon | 20:01 | |
tsufiev | :-O | 20:01 |
ducttape_ | does that seem reasonable / ok tsufiev ? thoughts ? | 20:01 |
tsufiev | well, the scope covered there looks like a good approach to a new project in a big tent ;) | 20:02 |
Krenair | When you edit a DNS record from Designate, Horizon doesn't show you the existing description? | 20:02 |
*** permalac has quit IRC | 20:02 | |
ducttape_ | it seems like having a central block of code for all the quota stuff to be pasted into, is not scalable. I sure hope this can be solved without another project | 20:02 |
ducttape_ | Krenair: is the description in a table row ? | 20:02 |
Krenair | no | 20:03 |
tsufiev | I'll try to post something valuable there, ducttape_ | 20:03 |
ducttape_ | ok. if you want / need that added Krenair let me know / file bug etc. I can help you with that | 20:03 |
Krenair | I'll dig into the code later and have a go | 20:03 |
*** permalac has joined #openstack-horizon | 20:03 | |
ducttape_ | thanks tsufiev on the quotas stuff. I think we can do something without another project, it should be possible / not that bad | 20:03 |
* tsufiev feels a bit guilty about making a call 'let's make quotas great again' and then running away | 20:04 | |
ducttape_ | quotas suck tsufiev, and like my cinder thing could go in and we can fix quotas later, or fixing quotas can be a blocker. I don't like the blocker approach, but I also agree that if you don't fix quotas when there is a need - it probably won't get touched | 20:05 |
tsufiev | yeah, it's the choice between the ugly and scary :) | 20:06 |
r1chardj0n3s | morning | 20:06 |
openstackgerrit | David Lyle proposed openstack/horizon: Fix missing 'THEME' key https://review.openstack.org/344871 | 20:06 |
tsufiev | ugly = don't touch them, scary = touch them | 20:06 |
openstackgerrit | Rebecca Finn proposed openstack/horizon: Do not allow spaces as key pair name https://review.openstack.org/350747 | 20:08 |
openstackgerrit | Merged openstack/horizon: Stop memoizing on request argument in neutron api https://review.openstack.org/316258 | 20:25 |
tsufiev | r1chardj0n3s, richard, would you share your opinion on using scope here https://review.openstack.org/#/c/317457/23/openstack_dashboard/static/app/core/images/actions/create.action.service.js ? | 20:27 |
*** schipiga has quit IRC | 20:27 | |
r1chardj0n3s | tsufiev: progress eh, yeah, hmm, I have actions in swift which I think are doing similar things that use explicit progress callbacks | 20:29 |
r1chardj0n3s | *shrug* it's just dangerous to tie a scope to a service - that's a singleton shared amongst potentially many consumers, so should not have state | 20:29 |
tsufiev | so what is the new proposed way to send progress notifications, if not by events? | 20:30 |
r1chardj0n3s | tsufiev: apart from explicit callbacks? I am not sure? tyr_, TravT? | 20:31 |
TravT | brain just split | 20:31 |
* tsufiev not ready for a serious discussion at this time of the day anyways | 20:32 | |
tsufiev | maybe we could continue it in review, r1chardj0n3s | 20:33 |
r1chardj0n3s | yup | 20:34 |
zigo | There's a problem with the Horizon template loader init method, but I can't find where it's defined. | 20:34 |
zigo | Does one of you know? | 20:34 |
zigo | TypeError: __init__() takes exactly 3 argumyents (2 given) <--- That's one of the issues I fixed in some Python modules. | 20:35 |
zigo | Though for the Horizon case, I can't find the init method. | 20:36 |
zigo | tsufiev: Do you know where it's defined? | 20:36 |
tsufiev | no | 20:36 |
zigo | :/ | 20:36 |
zigo | r1chardj0n3s: Maybe you know? | 20:36 |
*** jtriley has quit IRC | 20:36 | |
r1chardj0n3s | zigo: I'd have to have a specific case to look into but usually it'd be coming from a base class | 20:37 |
zigo | from django.template.loaders.base import Loader as tLoaderCls | 20:37 |
zigo | The ThemeTemplateLoader or the TemplateLoader both inerit from the tLoaderCls. | 20:38 |
zigo | r1chardj0n3s: So that's Django's native class. | 20:38 |
zigo | It'd be surprising to see the Django's native class is broken ! :) | 20:39 |
*** roxanaghe has joined #openstack-horizon | 20:39 | |
r1chardj0n3s | very surprising indeed | 20:39 |
r1chardj0n3s | what environment are you running (python ver, django ver) | 20:39 |
zigo | Something in Horizon must be adding an init function to one of these class... | 20:39 |
zigo | r1chardj0n3s: Debian Sid, django 1.10 beta2, python 2.7 | 20:39 |
zigo | r1chardj0n3s: I'm trying to fix Django 1.10 issues. | 20:39 |
zigo | I did fix lots of them already. | 20:40 |
zigo | (I wrote 7 patches) | 20:40 |
r1chardj0n3s | from a glance at the code I can't see how you'd get that error from that code. Are you sure that's where the error is coming from? | 20:41 |
tyr_ | tsufiev: have you considered doing notifications on the promise returned by the action? | 20:42 |
zigo | r1chardj0n3s: Quite sure, I'm searching for a patch I wrote to show you. | 20:42 |
tsufiev | tyr_, could you please elaborate that in review? | 20:44 |
tyr_ | sure | 20:44 |
tsufiev | thanks | 20:44 |
zigo | r1chardj0n3s: I can't find the kind of patch I'm searching for, however, here's the stack dump: http://paste.openstack.org/show/547852/ | 20:50 |
zigo | If by reading that trace, you can tell me what method Django is trying to call, then I'm confident I can produce a patch. | 20:50 |
zigo | To me, it looks like the __init__() method of the Loader class. | 20:51 |
zigo | It could match the "The dirs parameter for the following functions is removed:" from Django 1.10 release notes at https://docs.djangoproject.com/en/1.10/releases/1.10/ | 20:51 |
*** ametts has quit IRC | 20:52 | |
r1chardj0n3s | zigo: I suspect that the loader_class in that exception is not ThemeTemplateLoader or TemplateLoader | 20:53 |
zigo | r1chardj0n3s: Ah, that's helpful! :) | 20:54 |
zigo | r1chardj0n3s: What class then? | 20:54 |
r1chardj0n3s | without some extra instrumentation in that output (like a debug output of what load_class is) I can't say | 20:54 |
zigo | r1chardj0n3s: ok, I'll try to debug. | 20:54 |
r1chardj0n3s | "print loader_class" line 122 of django/template/engine.py :-) | 20:55 |
zigo | Yup! :) | 20:56 |
zigo | print(loader_class) though, I don't want to be Py3 incompatible! :P | 20:56 |
r1chardj0n3s | I'm old school ;-) | 20:57 |
*** v12aml has quit IRC | 20:57 | |
*** ezpz has joined #openstack-horizon | 21:03 | |
*** matt-borland has quit IRC | 21:03 | |
*** v12aml has joined #openstack-horizon | 21:04 | |
zigo | r1chardj0n3s: The only thing that prints is: http://paste.openstack.org/show/547854/ | 21:04 |
zigo | That's not helpful :( | 21:04 |
r1chardj0n3s | wait, so it still errors, and presumably on the last one?? | 21:05 |
zigo | Yup. | 21:08 |
zigo | Hum... | 21:08 |
r1chardj0n3s | well I guess that rules out ThemeTemplateLoader or TemplateLoader | 21:08 |
r1chardj0n3s | weird tho | 21:08 |
*** yamamoto has joined #openstack-horizon | 21:09 | |
*** lblanchard has quit IRC | 21:12 | |
*** pauloewerton has quit IRC | 21:13 | |
*** fifieldt has quit IRC | 21:15 | |
zigo | I wonder why horizon.themes.ThemeTemplateLoader and horizon.loaders.TemplateLoader, which I defined in openstack_dashboard/test/settings.py (in TEMPLATES[{'loaders' ) isn't taken into account. | 21:16 |
*** yamamoto has quit IRC | 21:18 | |
*** fifieldt has joined #openstack-horizon | 21:25 | |
*** wolverineav has joined #openstack-horizon | 21:32 | |
*** adriant has joined #openstack-horizon | 21:33 | |
*** weezS has quit IRC | 21:41 | |
*** wolverineav has quit IRC | 21:42 | |
*** sdake has quit IRC | 21:43 | |
*** wolverineav has joined #openstack-horizon | 21:44 | |
*** ezpz has quit IRC | 21:50 | |
*** wolverineav has quit IRC | 21:52 | |
openstackgerrit | Rebecca Finn proposed openstack/horizon: Allow instance snapshot to be pre-selected as source image https://review.openstack.org/350291 | 21:56 |
Krenair | ducttape_, I did some digging and... I'm actually not sure the issue is with Horizon | 22:01 |
Krenair | I checked python-designateclient using v2, it returns a description | 22:02 |
Krenair | But when I checked using the CLI tool, it shows None | 22:02 |
Krenair | Not sure why yet but I'm guessing Horizon does the same thing as the CLI tool | 22:02 |
ducttape_ | ah ok. I thought you were saying that description is not a field that the ui even tries to display | 22:03 |
ducttape_ | and yes, the cli tool and horizon use the same path to get data | 22:03 |
*** piet has quit IRC | 22:05 | |
*** sjmc7 has quit IRC | 22:06 | |
Krenair | ducttape_, aha... v1 shows None for the description | 22:06 |
Krenair | v2 shows what I expected | 22:06 |
Krenair | designate's horizon dashboard uses v1 right? | 22:06 |
ducttape_ | I think so, but I'm not certain | 22:06 |
ducttape_ | yep https://github.com/openstack/designate-dashboard/blob/master/designatedashboard/api/designate.py#L17 | 22:07 |
Krenair | getting closer... thanks for your help ducttape_ | 22:08 |
openstackgerrit | Travis Tripp proposed openstack/horizon: Adding project name column to ng images https://review.openstack.org/339256 | 22:08 |
ducttape_ | sure no problem. good luck Krenair | 22:09 |
Krenair | ruled out python-designateclient too, hit the designate rest api directly and /v1/domains/{domain}/records/{record} has a null description but /v2/zones/{zone}/recordsets/{recordset} has it right | 22:15 |
Krenair | v2 api does also seem wrong | 22:19 |
ducttape_ | if you go much deeper into the api, the designate irc channel might be a better spot for help | 22:19 |
ducttape_ | #openstack-dns | 22:19 |
*** wolverineav has joined #openstack-horizon | 22:20 | |
tyr_ | Krenair: I've been working on a v2 UI...what is the issue you are chasing? | 22:20 |
*** wolverineav has quit IRC | 22:20 | |
Krenair | ducttape_, yeah I was gonna switch to that | 22:21 |
*** wolverineav has joined #openstack-horizon | 22:21 | |
Krenair | tyr_, when you edit a record, its description is missing | 22:21 |
ducttape_ | tyr_ - the ui is not showing info for description, but the rest api is not providing it | 22:21 |
Krenair | v2 api is providing it correctly, but also v2 api docs are wrong | 22:21 |
*** bpokorny has quit IRC | 22:21 | |
tyr_ | yes...there are many omissions in the api docs | 22:22 |
tyr_ | Graham and Kial are aware of some of them, not sure about description in particular | 22:23 |
Krenair | tyr_, shall we move to -dns? | 22:28 |
*** yamamoto has joined #openstack-horizon | 22:29 | |
*** yamamoto_ has joined #openstack-horizon | 22:31 | |
tyr_ | sure | 22:31 |
*** yamamoto has quit IRC | 22:31 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: hz-resource-table handles transitional states https://review.openstack.org/346174 | 22:35 |
*** julim has joined #openstack-horizon | 22:37 | |
*** xiong has joined #openstack-horizon | 22:37 | |
*** ducttape_ has quit IRC | 22:41 | |
*** zul_ has quit IRC | 22:46 | |
r1chardj0n3s | robcresswell: I've just installed 1.5.8 locally and all testing seems fine so far | 22:46 |
*** revon has quit IRC | 22:50 | |
*** bpokorny has joined #openstack-horizon | 22:50 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: hz-resource-table handles transitional states https://review.openstack.org/346174 | 22:52 |
openstackgerrit | Diana Whitten proposed openstack/horizon: The sidebar caret should spin correctly. https://review.openstack.org/350818 | 22:52 |
*** bpokorny has quit IRC | 22:55 | |
*** mpavlase has quit IRC | 22:56 | |
*** asettle has joined #openstack-horizon | 22:57 | |
*** weezS has joined #openstack-horizon | 22:58 | |
openstackgerrit | Tyr Johanson proposed openstack/horizon: hz-images have transitional states defined https://review.openstack.org/346210 | 22:59 |
openstackgerrit | Diana Whitten proposed openstack/horizon: Horizon selects are now themable: DynamicTypedChoiceField https://review.openstack.org/350687 | 22:59 |
*** rfinn has quit IRC | 22:59 | |
*** uxdanielle has quit IRC | 23:00 | |
*** ducttape_ has joined #openstack-horizon | 23:02 | |
*** sdake has joined #openstack-horizon | 23:03 | |
*** asettle has quit IRC | 23:09 | |
*** pt_15 has quit IRC | 23:10 | |
*** richil has quit IRC | 23:11 | |
*** pt_15 has joined #openstack-horizon | 23:14 | |
*** hurgleburgler has quit IRC | 23:14 | |
*** aortega has joined #openstack-horizon | 23:18 | |
*** weezS has quit IRC | 23:19 | |
*** zackf has quit IRC | 23:22 | |
*** bpokorny has joined #openstack-horizon | 23:23 | |
*** ducttape_ has quit IRC | 23:24 | |
*** ducttape_ has joined #openstack-horizon | 23:25 | |
*** zackf has joined #openstack-horizon | 23:25 | |
*** zackf has quit IRC | 23:29 | |
*** zackf has joined #openstack-horizon | 23:30 | |
*** tyr_ has quit IRC | 23:31 | |
openstackgerrit | Cindy Lu proposed openstack/horizon: add translation and cleanup resource-browser-item.html https://review.openstack.org/350823 | 23:34 |
*** zackf has quit IRC | 23:35 | |
*** hoonetorg has quit IRC | 23:39 | |
*** hoonetorg has joined #openstack-horizon | 23:44 | |
*** zhurong has joined #openstack-horizon | 23:45 | |
*** wolverineav has quit IRC | 23:47 | |
*** roxanaghe has quit IRC | 23:47 | |
*** jamielennox is now known as jamielennox|away | 23:48 | |
*** ducttape_ has quit IRC | 23:49 | |
*** wolverineav has joined #openstack-horizon | 23:49 | |
*** wolverineav has joined #openstack-horizon | 23:49 | |
*** jrist has quit IRC | 23:49 | |
*** sdake has quit IRC | 23:51 | |
*** zhurong has quit IRC | 23:54 | |
*** sdake has joined #openstack-horizon | 23:55 | |
*** Marcellin_ has quit IRC | 23:57 | |
*** TravT has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!