Wednesday, 2016-08-10

*** zhurong has quit IRC00:00
*** aortega has joined #openstack-horizon00:00
*** kzaitsev_mb has quit IRC00:08
*** yingjun has joined #openstack-horizon00:10
*** ducttape_ has quit IRC00:10
*** mtanino has quit IRC00:23
*** jlopezgu_ has quit IRC00:25
*** kzaitsev_mb has joined #openstack-horizon00:27
*** yamamot__ has joined #openstack-horizon00:27
*** yamamot__ has quit IRC00:34
*** esp has quit IRC00:37
*** bpokorny_ has joined #openstack-horizon00:41
*** TravT has quit IRC00:43
*** TravT has joined #openstack-horizon00:43
*** ChanServ sets mode: +v TravT00:43
*** bpokorny has quit IRC00:45
*** TravT has quit IRC00:45
*** bpokorny_ has quit IRC00:46
*** sdake has joined #openstack-horizon00:59
*** aortega has quit IRC01:01
*** kzaitsev_mb has quit IRC01:07
*** zhurong has joined #openstack-horizon01:07
*** ducttape_ has joined #openstack-horizon01:11
*** btully has joined #openstack-horizon01:13
*** ducttape_ has quit IRC01:16
*** btully has quit IRC01:17
*** TravT has joined #openstack-horizon01:24
*** ChanServ sets mode: +v TravT01:24
*** TravT has quit IRC01:26
*** ducttape_ has joined #openstack-horizon01:26
*** ducttape_ has quit IRC01:28
*** Berezin has quit IRC01:32
*** wolverineav has quit IRC01:34
*** saksham has quit IRC01:35
*** wolverineav has joined #openstack-horizon01:37
*** amotoki has joined #openstack-horizon01:40
*** liuyulong has quit IRC01:45
*** wolverineav has quit IRC01:46
*** amotoki has quit IRC01:48
*** amotoki has joined #openstack-horizon01:58
*** amotoki has quit IRC01:59
*** amotoki has joined #openstack-horizon02:00
*** btully has joined #openstack-horizon02:04
*** wolverineav has joined #openstack-horizon02:04
*** Berezin has joined #openstack-horizon02:06
*** liuyulong has joined #openstack-horizon02:08
*** wolverineav has quit IRC02:09
*** btully has quit IRC02:13
*** btully has joined #openstack-horizon02:14
*** btully has quit IRC02:27
*** ducttape_ has joined #openstack-horizon02:28
*** ducttape_ has quit IRC02:33
*** wolverineav has joined #openstack-horizon02:34
*** btully has joined #openstack-horizon02:38
*** ducttape_ has joined #openstack-horizon02:38
*** wolverineav has quit IRC02:42
*** zhurong has quit IRC02:42
*** zhurong has joined #openstack-horizon02:44
*** tyr_ has joined #openstack-horizon02:46
*** zhurong has quit IRC02:48
*** wolverineav has joined #openstack-horizon02:48
*** zhurong has joined #openstack-horizon02:49
*** tyr_ has quit IRC02:52
*** liuyulong has quit IRC02:54
*** btully has quit IRC02:55
*** yingjun has quit IRC02:56
*** wolverineav has quit IRC02:56
*** yingjun has joined #openstack-horizon02:56
*** gyee has quit IRC02:57
*** zhurong has quit IRC02:58
*** yingjun has quit IRC02:58
*** yingjun has joined #openstack-horizon02:58
*** zhurong has joined #openstack-horizon02:58
*** liuyulong has joined #openstack-horizon02:59
*** yingjun has quit IRC03:03
*** wolverineav has joined #openstack-horizon03:04
*** ducttape_ has quit IRC03:04
*** wolverineav has quit IRC03:08
*** tyr_ has joined #openstack-horizon03:11
*** sdake has quit IRC03:17
*** yamamot__ has joined #openstack-horizon03:20
*** yamamot__ has quit IRC03:20
*** yamamot__ has joined #openstack-horizon03:22
*** wolverineav has joined #openstack-horizon03:22
*** wolverineav has quit IRC03:30
*** julim has quit IRC03:30
*** yingjun has joined #openstack-horizon03:32
*** wolverineav has joined #openstack-horizon03:35
*** wolverineav has quit IRC03:39
*** yamamot__ has quit IRC03:44
*** btully has joined #openstack-horizon03:48
*** wolverineav has joined #openstack-horizon03:54
*** wolverineav has quit IRC03:58
*** btully has quit IRC04:00
*** sguduru has joined #openstack-horizon04:01
*** btully has joined #openstack-horizon04:06
*** yingjun has quit IRC04:11
*** yingjun has joined #openstack-horizon04:11
*** yamamot__ has joined #openstack-horizon04:11
*** saksham has joined #openstack-horizon04:12
*** rkrum has joined #openstack-horizon04:13
*** saksham has quit IRC04:16
*** yingjun has quit IRC04:16
*** tsufiev has quit IRC04:18
*** tsufiev has joined #openstack-horizon04:18
*** ChanServ sets mode: +v tsufiev04:18
*** permalac has quit IRC04:25
*** permalac has joined #openstack-horizon04:26
*** masco has joined #openstack-horizon04:27
*** roxanaghe has joined #openstack-horizon04:27
*** ppiela has quit IRC04:31
*** ducttape_ has joined #openstack-horizon04:35
*** yamamot__ has quit IRC04:36
*** ducttape_ has quit IRC04:40
*** yingjun has joined #openstack-horizon04:42
*** roxanaghe has quit IRC04:51
*** yingjun has quit IRC04:51
*** yingjun has joined #openstack-horizon04:52
*** yingjun has quit IRC04:56
*** javeriak has joined #openstack-horizon05:00
*** wolverineav has joined #openstack-horizon05:00
*** pcaruana has quit IRC05:01
*** wolverineav has quit IRC05:05
*** tyr_ has quit IRC05:12
*** ratailor has joined #openstack-horizon05:12
*** yamamot__ has joined #openstack-horizon05:16
*** roxanaghe has joined #openstack-horizon05:17
-openstackstatus- NOTICE: zuul is being restarted to reload configuration. Jobs should be re-enqueued but if you're missing anything (and it's not on http://status.openstack.org/zuul/) please issue a recheck in 30min.05:24
*** wolverineav has joined #openstack-horizon05:29
*** hurgleburgler has quit IRC05:34
*** roxanaghe has quit IRC05:35
*** wolverineav has quit IRC05:36
*** yingjun has joined #openstack-horizon05:43
*** ducttape_ has joined #openstack-horizon05:47
*** wolverineav has joined #openstack-horizon05:51
*** ducttape_ has quit IRC05:52
*** vishwanathj has quit IRC05:56
*** wolverineav has quit IRC06:01
*** rcernin has joined #openstack-horizon06:04
*** wolverineav has joined #openstack-horizon06:05
*** wolverineav has quit IRC06:10
*** wolverineav has joined #openstack-horizon06:15
openstackgerritTimur Sufiev proposed openstack/horizon: Pre-test hook for integration tests/deprecated  https://review.openstack.org/34902006:22
*** wolverineav has quit IRC06:24
*** wolverineav has joined #openstack-horizon06:28
*** vishwanathj has joined #openstack-horizon06:28
*** vishwanathj has quit IRC06:29
*** wolverineav has quit IRC06:33
*** agireud has quit IRC06:34
*** jprovazn has joined #openstack-horizon06:34
*** wolverineav has joined #openstack-horizon06:37
*** adriant has quit IRC06:39
*** agireud has joined #openstack-horizon06:40
*** wolverineav has quit IRC06:41
*** agireud has quit IRC06:44
*** tesseract- has joined #openstack-horizon06:44
*** javeriak has quit IRC06:44
*** javeriak has joined #openstack-horizon06:45
*** ducttape_ has joined #openstack-horizon06:48
*** agireud has joined #openstack-horizon06:48
*** tosky has joined #openstack-horizon06:49
*** wolverineav has joined #openstack-horizon06:49
*** ducttape_ has quit IRC06:53
*** btully has quit IRC06:59
*** wolverineav has quit IRC07:00
*** agireud has quit IRC07:06
*** rkrum has quit IRC07:06
*** wolverineav has joined #openstack-horizon07:11
*** btully has joined #openstack-horizon07:11
*** wolverineav has quit IRC07:16
*** yingjun has quit IRC07:16
*** yingjun has joined #openstack-horizon07:17
*** btully has quit IRC07:21
*** zackf has joined #openstack-horizon07:22
*** pcaruana has joined #openstack-horizon07:24
*** agireud has joined #openstack-horizon07:24
*** zackf has quit IRC07:26
*** jprovazn has quit IRC07:29
*** javeriak has quit IRC07:31
*** yingjun has quit IRC07:33
*** yingjun has joined #openstack-horizon07:34
*** yingjun has quit IRC07:38
*** btully has joined #openstack-horizon07:42
*** jpich has joined #openstack-horizon07:43
*** btully has quit IRC07:46
*** agireud has quit IRC07:46
*** wolverineav has joined #openstack-horizon07:47
*** ducttape_ has joined #openstack-horizon07:49
*** agireud has joined #openstack-horizon07:50
*** wolverineav has quit IRC07:52
*** ducttape_ has quit IRC07:54
*** javeriak has joined #openstack-horizon07:54
*** agireud has quit IRC07:55
*** agireud has joined #openstack-horizon07:57
*** agireud has quit IRC08:02
*** mrunge_ is now known as mrunge08:03
robcresswelltsufiev: https://review.openstack.org/#/c/345998/ your review is not based on master :)08:04
*** agireud has joined #openstack-horizon08:09
*** btully has joined #openstack-horizon08:12
*** agireud has quit IRC08:13
*** javeriak has quit IRC08:15
*** agireud has joined #openstack-horizon08:16
*** sguduru_ has joined #openstack-horizon08:17
*** openstackgerrit has quit IRC08:18
*** agireud has quit IRC08:19
*** openstackgerrit has joined #openstack-horizon08:19
*** sguduru__ has joined #openstack-horizon08:20
*** sguduru_ has quit IRC08:20
*** sguduru has quit IRC08:21
*** yingjun has joined #openstack-horizon08:23
*** btully has quit IRC08:24
*** agireud has joined #openstack-horizon08:28
*** wolverineav has joined #openstack-horizon08:36
*** btully has joined #openstack-horizon08:37
*** agireud has quit IRC08:39
tsufievrobcresswell, nope, still the result with compress and the patch based on master08:39
*** permalac has quit IRC08:40
robcresswelltsufiev: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/volumes/cg_snapshots/urls.py08:40
robcresswelltsufiev: That failure line does not exist in master08:40
robcresswellI patched it out a while ago08:40
tsufievrobcresswell, then it's not the only error that patch had08:40
*** wolverineav has quit IRC08:41
robcresswellThere's another issue in 1.10 that manage.py check also flags up08:41
robcresswellThing is, all 1.10 patches will fail on another 1.10 issue08:41
tsufievwhat is it?08:42
robcresswellhttps://docs.djangoproject.com/en/1.10/releases/1.10/#using-user-is-authenticated-and-user-is-anonymous-as-methods08:42
robcresswelld_o_a issue08:42
robcresswellworking on it now08:42
*** btully has quit IRC08:42
*** agireud has joined #openstack-horizon08:42
tsufievrobcresswell, that seems to be true for make_web_conf, but for compress there is another issue: http://paste.openstack.org/show/553501/08:43
robcresswellah, I didnt notice that08:45
*** wolverineav has joined #openstack-horizon08:46
robcresswelltsufiev: Oh I see, you're saying Ivan should patch that file too08:46
tsufievyep08:46
robcresswelltsufiev: Cool, changed vote, good catch. I was only testing the changed files, rather than checking for other uses of optparse.08:48
robcresswelltsufiev: Sorry for the hassle.08:48
*** ducttape_ has joined #openstack-horizon08:50
*** wolverineav has quit IRC08:50
openstackgerritTimur Sufiev proposed openstack/horizon: Pre-test hook for integration tests/deprecated  https://review.openstack.org/34902008:50
tsufievrobcresswell, np.08:51
tsufievbtw, there is something we forgot to add to Matt's infra patch for splitting dsvm job08:51
tsufievI've noticed it on Diana's patch - https://review.openstack.org/#/c/313685/ - test_reports dir was missing08:52
tsufievso we'll need another patch to infra to handle that gracefully08:52
*** kzaitsev_mb has joined #openstack-horizon08:53
robcresswelltsufiev: Oh, so post_hook takes the same parameter?08:53
tsufievit should take it, but currently it doesn't, robcresswell08:54
robcresswellYes, I see08:54
robcresswelltsufiev: Good catch08:54
tsufievI completely forgot about gathering test artifacts :(08:54
*** ducttape_ has quit IRC08:55
tsufievrobcresswell, could you take another look at https://review.openstack.org/#/c/317457/ ?08:55
robcresswelltsufiev: Will do. Just want to fix d_o_a for 1.10 first, then look at angular panel settings dict idea08:57
tsufievsure08:57
robcresswelltsufiev: so probably this afternoon :)08:57
*** agireud has quit IRC09:01
openstackgerritOpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Zanata  https://review.openstack.org/35333109:03
*** agireud has joined #openstack-horizon09:05
*** wolverineav has joined #openstack-horizon09:06
*** wolverineav has quit IRC09:11
*** agireud has quit IRC09:25
*** wolverineav has joined #openstack-horizon09:27
*** agireud has joined #openstack-horizon09:37
*** yingjun has quit IRC09:37
*** wolverineav has quit IRC09:38
openstackgerritRob Cresswell proposed openstack/django_openstack_auth: Add is_authenticated and is_anonymous properties  https://review.openstack.org/35335009:41
robcresswelltsufiev: One less error ^^09:41
*** agireud has quit IRC09:42
*** yamamot__ has quit IRC09:44
*** sdake has joined #openstack-horizon09:47
*** agireud has joined #openstack-horizon09:49
*** ducttape_ has joined #openstack-horizon09:50
*** wolverineav has joined #openstack-horizon09:54
*** ducttape_ has quit IRC09:56
*** Berezin has quit IRC09:57
*** wolverineav has quit IRC09:59
*** kzaitsev_mb has quit IRC10:00
*** zhurong has quit IRC10:02
*** wolverineav has joined #openstack-horizon10:06
*** mflobo has joined #openstack-horizon10:13
*** Berezin has joined #openstack-horizon10:17
*** wolverineav has quit IRC10:19
*** rkrum has joined #openstack-horizon10:23
*** btully has joined #openstack-horizon10:24
*** wolverineav has joined #openstack-horizon10:25
*** mflobo has quit IRC10:29
*** wolverineav has quit IRC10:29
*** btully has quit IRC10:29
*** javeriak has joined #openstack-horizon10:41
*** btully has joined #openstack-horizon10:41
openstackgerritRob Cresswell proposed openstack/horizon: Add ANGULAR_FEATURES setting dict  https://review.openstack.org/35337710:47
openstackgerritRob Cresswell proposed openstack/horizon: Add ANGULAR_FEATURES setting dict  https://review.openstack.org/35337710:48
*** wolverineav has joined #openstack-horizon10:49
*** jtriley has joined #openstack-horizon10:50
*** ducttape_ has joined #openstack-horizon10:51
*** btully has quit IRC10:52
*** permalac has joined #openstack-horizon10:53
*** mflobo has joined #openstack-horizon10:54
*** ducttape_ has quit IRC10:56
*** wolverineav has quit IRC10:59
*** mrunge has quit IRC11:00
*** mflobo has quit IRC11:01
*** wolverineav has joined #openstack-horizon11:02
*** kzaitsev_mb has joined #openstack-horizon11:07
*** Anticime1 is now known as Anticimex11:10
*** mrunge has joined #openstack-horizon11:11
*** ChanServ sets mode: +v mrunge11:11
*** wolverineav has quit IRC11:14
openstackgerritOpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata  https://review.openstack.org/35338711:16
*** javeriak has quit IRC11:26
*** mvk has quit IRC11:30
*** wolverineav has joined #openstack-horizon11:36
*** sergio_nubeliu has joined #openstack-horizon11:41
*** wolverineav has quit IRC11:42
*** rkrum has quit IRC11:43
*** sguduru__ has quit IRC11:47
*** amotoki has quit IRC11:51
*** sdake has quit IRC11:51
*** sdake has joined #openstack-horizon11:51
*** ducttape_ has joined #openstack-horizon11:52
*** wolverineav has joined #openstack-horizon11:53
*** amotoki has joined #openstack-horizon11:56
*** sdake_ has joined #openstack-horizon11:56
*** ducttape_ has quit IRC11:57
*** wolverineav has quit IRC11:58
*** sdake has quit IRC11:59
*** amotoki has quit IRC12:00
*** mflobo has joined #openstack-horizon12:02
*** mvk has joined #openstack-horizon12:05
*** mflobo has quit IRC12:07
*** ducttape_ has joined #openstack-horizon12:07
*** aortega has joined #openstack-horizon12:12
*** mflobo has joined #openstack-horizon12:12
*** amotoki has joined #openstack-horizon12:15
*** pauloewerton has joined #openstack-horizon12:21
*** zhurong has joined #openstack-horizon12:25
*** amotoki has quit IRC12:28
*** mtanino has joined #openstack-horizon12:30
openstackgerritGleb Stepanov proposed openstack/horizon: Refactor novaclient code  https://review.openstack.org/34841612:31
*** ducttape_ has quit IRC12:31
*** btully has joined #openstack-horizon12:42
*** wolverineav has joined #openstack-horizon12:45
*** btully has quit IRC12:53
*** wolverineav has quit IRC12:54
*** jtriley has quit IRC12:54
*** mtanino has quit IRC12:56
*** kzaitsev_mb has quit IRC13:00
*** Ephur has joined #openstack-horizon13:00
*** mflobo has quit IRC13:02
*** matt-borland has joined #openstack-horizon13:06
matt-borlandtsufiev, with the post_test_hook, why/where does that use an extra parameter?13:07
matt-borlandIs there another patch I'm missing?13:07
tsufievmatt-borland, directory where test artifacts are gathered into is named after job name13:08
tsufievand it was changed13:08
matt-borlandso where is the code for the post_test_hook change?13:08
tsufievwhich code do you mean13:09
tsufiev?13:09
matt-borlandIn https://review.openstack.org/#/c/353321/ , you add code that passes a parameter to *post* test hook13:09
matt-borlandonly *pre* test hook takes in a parameter afaik13:09
tsufievnope, check https://review.openstack.org/#/c/349020/10/tools/gate/integration/post_test_hook.sh13:10
*** wolverineav has joined #openstack-horizon13:10
matt-borlandOh!  ha, I missed that, thanks!13:10
tsufievwill you remove -1 from infra patch ;)?13:11
matt-borlandjust did13:11
matt-borland+113:11
tsufievalso, I'd like to merge that part in horizon/post_test_hook as soon as an infra follow-up patch is merged13:11
matt-borlandthanks tsufiev!13:11
tsufievsince now we lost our test_reports, which made debugging dsvm failures much more difficult13:11
tsufievmy fault :/13:11
matt-borlandOK, there are a couple of dependencies we should work out13:12
*** jtriley has joined #openstack-horizon13:12
robcresswellmatt: https://review.openstack.org/#/c/353377/13:12
matt-borlandyep, robcresswell, was looking at that too13:12
robcresswellcool13:12
robcresswellJust eating lunch atm, may be a little slow to respond13:13
matt-borlandso let's plan the order, because there are some interdependencies13:13
matt-borlandhttps://review.openstack.org/#/c/353321/ can go in now, even though it won't immediately fix anything13:13
robcresswellself.assertTrue(False) ?13:14
matt-borlandIf https://review.openstack.org/#/c/349020/ passes gate, then it can go in, but the deprecated.py example will need to be changed in https://review.openstack.org/#/c/353377/13:14
matt-borlandis that the order we want?13:14
robcresswellyup13:15
*** btully has joined #openstack-horizon13:15
tsufievrobcresswell, I added it to see how failures are handled13:15
*** amotoki has joined #openstack-horizon13:15
*** wolverineav has quit IRC13:15
robcresswelltsufiev: Ah13:16
robcresswellunderstood13:16
matt-borlandThe problem with that order is that https://review.openstack.org/#/c/349020/ doesn't seem to be up to snuff13:17
*** sdake_ is now known as sdake13:18
matt-borlandor maybe I just need to rerun the tests?13:18
robcresswellmatt-borland: Timur's put a failure in on purpose :) you need to remove it13:19
robcresswellmatt-borland: The one I pointed to a few lines up13:19
matt-borlandrobcresswell, oh, heh, hm13:19
matt-borlandsorry13:19
* matt-borland looks for coffee13:19
robcresswellJust edit the line out13:19
robcresswellThat will push a new patch and put it in the gate13:19
matt-borlandsorry, brain hurt.  one minute.13:20
robcresswelltsufiev: Sorry, I just saw your comment on https://review.openstack.org/#/c/353350/ !13:20
robcresswellmatt-borland: Timur put a failure in on purpose. You can just delete the failure line.13:20
matt-borlandOK, yeah, in test_instances.  OK.13:21
matt-borlandSo I can remove that now?13:21
robcresswellYeah. I don't know if depends-on will cause it to correctly use the infra patch though.13:21
robcresswellYes, I believe so. tsufiev said it works13:21
matt-borlandIt won't use it, but it uses it 'enough.'13:21
robcresswellWould double check with him first13:21
matt-borlandtsufiev, can I go ahead and remove that False == True assertion?13:22
matt-borlandDepends-On is a gate workflow thing, I don't believe it does anything else (like ensure use of other code)13:22
matt-borland(please correct me if wrong)13:22
*** harlowja has quit IRC13:23
tsufievrobcresswell, well I'm not sure13:23
robcresswellOh, we can just keep the failure then13:23
matt-borlandI see no harm in passing the tests.13:23
tsufievit's just a guard to make sure that one patch won't be merged ahead of another13:23
matt-borlandI can -1 the W.13:24
robcresswell*crosstalk*13:24
*** julim has joined #openstack-horizon13:24
robcresswelltsufiev: Yeah, I don't think it does correctly apply the workflow like git branches do13:24
robcresswellANYWAY. lets wait for infra13:24
matt-borlandOK.  I'll also re -1 the workflow.13:25
*** woodburn has quit IRC13:26
matt-borlandWhat was the 'xvfb missing' error in the one integration test failure?  Just a fluke?13:27
*** ducttape_ has joined #openstack-horizon13:27
tsufievO_O13:27
matt-borlandhttp://logs.openstack.org/20/349020/10/check/gate-horizon-dsvm-integration-current/9f74abe/console.html13:27
tsufievhttp://logs.openstack.org/20/349020/10/check/gate-horizon-dsvm-integration-current/9f74abe/console.html#_2016-08-10_10_25_23_409697 it's all fine13:30
*** vishwanathj has joined #openstack-horizon13:30
matt-borlandk, thanks tsufiev13:30
*** ratailor has quit IRC13:31
*** wolverineav has joined #openstack-horizon13:31
*** ducttape_ has quit IRC13:31
* matt-borland getting that coffee13:33
*** wolverineav has quit IRC13:35
*** ametts has joined #openstack-horizon13:36
*** wolverineav has joined #openstack-horizon13:40
*** yamamoto has joined #openstack-horizon13:41
*** kzaitsev_mb has joined #openstack-horizon13:43
*** woodburn has joined #openstack-horizon13:45
*** wolverineav has quit IRC13:47
*** rkrum has joined #openstack-horizon13:47
*** lblanchard has joined #openstack-horizon13:51
*** wolverineav has joined #openstack-horizon13:54
*** rodrigods has quit IRC13:56
*** uxdanielle has joined #openstack-horizon13:56
*** rodrigods has joined #openstack-horizon13:56
*** Ephur has quit IRC13:57
*** sjmc7 has joined #openstack-horizon13:57
*** wolverineav has quit IRC13:58
*** yamamoto has quit IRC13:59
*** ducttape_ has joined #openstack-horizon13:59
matt-borlandrobcresswell, if we want to have https://review.openstack.org/#/c/353377/ follow the horizon integration test patch, we should just make it dependent and change the deprecated.py.example in your patch...right?14:00
robcresswellmatt-borland: Yep, exactly14:01
matt-borlandcool, just checking, thanks14:01
matt-borlandFYI I will be gone this afternoon (so in about 4 hours) for the rest of the day14:01
*** wolverineav has joined #openstack-horizon14:02
*** hurgleburgler has joined #openstack-horizon14:02
*** ChanServ sets mode: +v hurgleburgler14:02
robcresswellmatt-borland: Sure, np14:06
*** asettle has joined #openstack-horizon14:06
*** wolverineav has quit IRC14:06
robcresswellmatt-borland: I think the problems are all solved, we're just waiting on changes to go through reviews/gates really14:06
robcresswellFYI I went with ANGULAR_FEATURES rather than ANGULAR_PANELS because that way we can use keys for different things14:07
matt-borland+1 robcresswell, I like 'features' over 'panels'14:07
robcresswellworkflows etc (I was thinking of create net, specifically)14:07
matt-borlandyep14:08
*** zhurong has quit IRC14:09
*** catintheroof has joined #openstack-horizon14:09
*** zackf has joined #openstack-horizon14:10
*** edtubill has joined #openstack-horizon14:12
lcastellmorning folks14:12
*** zhurong has joined #openstack-horizon14:12
*** rkrum has quit IRC14:15
*** asettle has quit IRC14:19
*** asettle has joined #openstack-horizon14:20
robcresswellgah d_o_a UTs are hosed.14:20
robcresswellinvestigating time :)14:21
*** yamamoto has joined #openstack-horizon14:24
*** TravT has joined #openstack-horizon14:25
*** ChanServ sets mode: +v TravT14:25
robcresswell(if anyone else is also tracking this, there was a release of requests just two days ago, which looks suspicious14:29
*** mtanino has joined #openstack-horizon14:30
robcresswellreverting to requests 2.10.0 and the tests run fine, so something in that update has borked doa.14:33
matt-borlandinteresting...everything happens at once14:33
robcresswellYeah, I was baffled because I put up a patch that ran fine locally, then failed *everything* upstream14:34
robcresswellturns out my tox envs were out of date :)14:34
openstackgerritRob Cresswell proposed openstack/horizon: Add ANGULAR_FEATURES setting dict  https://review.openstack.org/35337714:36
*** wolverineav has joined #openstack-horizon14:37
openstackgerritRob Cresswell proposed openstack/horizon: Add ANGULAR_FEATURES setting dict  https://review.openstack.org/35337714:37
TravTjust added a comment to your patch robcresswell14:37
robcresswellTravT: Responded. What did you mean by a message about feature deprecation?14:40
TravTi mean there is a new setting saying whether or not to use the angular feature True / False14:41
TravTin 2 cycles in theory, there will only be one version of the given feature14:41
robcresswellWell, minimum of 2 cycles, yes, depending on deployers.14:42
TravTand we'll do what, start removing the setting.14:42
robcresswellAh, so a message that the setting will be removed once the deprecation goes through?14:42
TravTyeah, something like that14:43
TravTi don't know... just thinking of trying to give proper notice.14:43
TravTmaybe even when a setting is added we should add a comment noting when it is eligible for deprecation and will just become default.14:43
robcresswellIt should be properly notified elsewhere via release notes and logs14:43
TravTi mean, who is going to go back and search through release notes of past releases to figure it out?14:44
TravTactually, there are really a few states a feature can be in14:45
robcresswellWell if they're deploying it they'll see it in the logs14:45
robcresswellIf they are new, then they'll default to the new one anyway14:45
TravTfor example, LI was available for at least a release or two before it became default.14:46
TravTso it was more experimental and the old one wasn't deprecated14:46
robcresswellRight14:46
TravTonce it became default, the django one became deprecated14:47
robcresswellBut if we're deprecating things properly then you should get log warnings saying "this thing is deprcated"14:47
TravTwhich in theory means in two releases it can be removed14:47
TravTi'm just saying that if we do that for every piece of code, it will be hard to go back and cross correlate.14:47
TravTwould be easier if this was tracked somewhere as we go.14:47
TravTso, you know going into each release what is eligible to be removed14:48
*** wolverineav has quit IRC14:49
*** yamamoto has quit IRC14:49
*** zhurong has quit IRC14:49
TravTanyway, just a thought. i'm not blocking that patch, just adding some commentary.14:49
*** yamamoto has joined #openstack-horizon14:50
*** yamamoto has quit IRC14:50
*** yamamoto has joined #openstack-horizon14:50
*** yamamoto has quit IRC14:50
matt-borlandWe should at least have a comment set that describes the current supported states (even if deprecated) and the release during which deprecated features/code are removed.14:50
matt-borlandagain, not necessarily for this patch.14:51
*** yamamoto has joined #openstack-horizon14:51
robcresswellI mean, we can comment next to the setting if you like14:51
robcresswellbut it would just be a TODO "remove this thing when you remove the rest"14:51
robcresswellWe could do an oslo or django style deprecation, where its a little more obvious that something is deprecated and then removed14:53
robcresswellAt the moment it really just relies on a message and warning, its not standardised.14:53
matt-borlandWhat do they do?14:53
matt-borlandI just want to keep track of it somewhere other than in our fragile minds, and to provide a roadmap of sorts as we know it.14:53
matt-borlandagain, all forward-looking, not -1 on the patch14:53
openstackgerritzzxwill proposed openstack/manila-ui: Correct typo  https://review.openstack.org/35354914:54
*** aortega has quit IRC14:55
*** yamamoto has quit IRC14:56
*** ezpz has joined #openstack-horizon14:57
robcresswellmatt-borland: https://github.com/openstack/oslo.log/blob/54fbbffeb7e4f2a4e3e7b9bc9130207222dfc65d/oslo_log/versionutils.py#L8414:58
matt-borlandinteresting14:59
robcresswelland Django has things like https://github.com/django/django/blob/1.10/django/utils/deprecation.py15:00
robcresswellSo we could have something like that, too, if we wanted to make it a bit more formal.15:01
*** aortega has joined #openstack-horizon15:01
TravTthat oslo thing looks pretty good15:02
TravTwhere would it go?15:02
TravTfor the panel use case15:02
openstackgerritMerged openstack/manila-ui: Delete openstack/common from the exclude list of flake8 in tox  https://review.openstack.org/35107315:03
*** masco has quit IRC15:03
*** revon has joined #openstack-horizon15:03
openstackgerritMerged openstack/manila-ui: Update Django 1.10 tox env  https://review.openstack.org/35153215:03
robcresswellSo, as Dave pointed out yesterday, Django has its own logging built on top of pythons standard logging, and I dont know how those interact15:03
robcresswellI dont know if its as straightforward as dropping in and using it15:04
*** sdake_ has joined #openstack-horizon15:04
*** tyr_ has joined #openstack-horizon15:05
*** wolverineav has joined #openstack-horizon15:06
*** sdake has quit IRC15:07
*** wolverineav has quit IRC15:10
*** david-lyle has quit IRC15:12
*** yamamoto has joined #openstack-horizon15:12
*** yamamoto has quit IRC15:12
*** david-lyle has joined #openstack-horizon15:12
*** ChanServ sets mode: +o david-lyle15:12
robcresswellTravT: The other thing to consider is whether you set removal in stone15:13
robcresswellTravT: For example, I imagine it'll be much easier to kick swift than LI.15:13
matt-borlandheh, yeah.  I have a patch (not a very serious one yet) that removes the old LI.15:14
TravTyep, that'll all come down to what the team can continue to support.15:14
*** wolverineav has joined #openstack-horizon15:15
*** weezS has joined #openstack-horizon15:18
*** wolverineav has quit IRC15:20
*** wolverineav has joined #openstack-horizon15:21
*** jrist has quit IRC15:22
*** jrist has joined #openstack-horizon15:23
*** wolverineav has quit IRC15:28
*** wolverineav has joined #openstack-horizon15:30
*** purva has joined #openstack-horizon15:31
*** itisha has joined #openstack-horizon15:32
*** pt_15 has joined #openstack-horizon15:33
*** jlopezgu_ has joined #openstack-horizon15:38
jlopezgumorning o/15:38
*** wolverineav has quit IRC15:44
*** sdake has joined #openstack-horizon15:45
openstackgerritEddie Ramirez proposed openstack/horizon: Hide IPv6 filter choice if enable_ipv6 is set to False  https://review.openstack.org/33515915:46
openstackgerritRob Cresswell proposed openstack/horizon: Deprecate via oslo.log  https://review.openstack.org/35360015:47
robcresswellTravT, matt-borland: ^^ something like that?15:47
*** sdake_ has quit IRC15:48
matt-borlandha, interesting!  I like it.15:48
*** wolverineav has joined #openstack-horizon15:48
openstackgerritYosef Hoffman proposed openstack/horizon: Configure vol_create in Launch Instance defaults  https://review.openstack.org/30953915:49
*** bpokorny has joined #openstack-horizon15:54
*** piet has joined #openstack-horizon15:56
*** wolverineav has quit IRC16:01
*** rcernin has quit IRC16:01
*** jprovazn has joined #openstack-horizon16:01
*** wolverineav has joined #openstack-horizon16:03
openstackgerritDiana Whitten proposed openstack/horizon: Datepicker should inherit from theme  https://review.openstack.org/31893316:06
*** wolverineav has quit IRC16:08
*** roxanaghe has joined #openstack-horizon16:08
*** yamamoto has joined #openstack-horizon16:13
TravTtsufiev are you around?16:15
tsufievTravT, yep16:16
TravTlet's talk about the memoization16:16
TravTre: https://review.openstack.org/#/c/339256/16:17
TravTdid you get a chance to read my comments?16:17
tsufievI saw you responded there but I hasnĀ“t yet processed it16:18
tsufievgoing to do it today16:18
TravTokay, sounds good.16:18
TravTif i'm wrong about something, then please let me know16:19
TravTbut let's get it figured out16:19
*** yamamoto has quit IRC16:19
tsufievsure16:20
*** wolverineav has joined #openstack-horizon16:24
*** rfinn has joined #openstack-horizon16:25
*** TravT has quit IRC16:26
*** TravT has joined #openstack-horizon16:27
*** ChanServ sets mode: +v TravT16:27
*** pcaruana has quit IRC16:29
openstackgerritRebecca Finn proposed openstack/horizon: Allow instance snapshot to be pre-selected as source image  https://review.openstack.org/35029116:29
openstackgerritMerged openstack/horizon: [NG] Enhance Create Image workflow with upload tracking  https://review.openstack.org/31745716:29
*** esp has joined #openstack-horizon16:30
*** uxdanielle has quit IRC16:30
*** TravT_ has joined #openstack-horizon16:33
*** ChanServ sets mode: +v TravT_16:33
*** Ephur has joined #openstack-horizon16:35
*** TravT has quit IRC16:35
bpokornymatt-borland: Thanks for your response on this one: https://review.openstack.org/#/c/320039/. I think we should include any changes needed to align the angular work into that patch, so that the v2 stuff all merges together.16:36
bpokornyDo you happen to know off the top of your head if the issue we were looking at during the midcycle still exists?16:36
matt-borlandOK, sounds good.  One second.16:36
matt-borlandI think there was an issue with how metadata was being displayed and being loaded.16:36
bpokornyJust wondering if there's still an issue, and if so, if you've already got a fix in mind.16:36
matt-borlandI think the display was easy to fix (removed one line of code).  I think it's probably similar for the metadata, but that's a complex beast and I missed why it's not working.16:37
matt-borlandbasically it needs to point to the correct place for the metadata feature.16:37
openstackgerritJuan Pablo lopez Gutierrez proposed openstack/horizon: Implements admin_filter_first in networks  https://review.openstack.org/35306716:37
matt-borlandand possibly somehow distinguish metadata from standard properties.16:38
matt-borlandI have to leave for a while this afternoon, but perhaps tomorrow I can follow up more completely.16:38
*** ametts has quit IRC16:38
bpokornyI see. Could you let me know what line of code to remove to fix the display, and I'll start looking at what's going on with the loading?16:38
matt-borlandsure, 1 sec16:39
matt-borlandIn the Angular images panel, which is currently enabled via your local_settings.py via: HORIZON_CONFIG.update({"images_panel": "angular"})16:39
*** TravT_ has quit IRC16:39
matt-borlandthe results have an expanded drawer that will show known metadata types if associated16:40
matt-borlandbpokorny, I believe https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/details/drawer.html#L17, the 'item.properties || item' just becomes 'item'16:41
*** Tamayo has joined #openstack-horizon16:41
matt-borlandlet me check for other changes in the branch I created16:42
*** TravT has joined #openstack-horizon16:43
*** ChanServ sets mode: +v TravT16:43
*** asettle has quit IRC16:43
*** asettle has joined #openstack-horizon16:43
matt-borlandbpokorny, I just emailed you a diff from the branch I had very briefly worked on.16:48
bpokornymatt-borland: Great, thanks. I'll test that out and start looking at the loading, and will let you know how it goes.16:49
matt-borlandit's not necessarily going in the right direction, but may clue you in as to where things may be going wrong.  I would suggest just testing it first, then reading through the patch to see where things might have gone wrong.16:49
matt-borlandI'm certain that that diff does not *solve* the problems :)16:49
bpokornyGood to know :)16:49
*** tosky has quit IRC16:50
*** jpich has quit IRC16:53
openstackgerritJuan Pablo lopez Gutierrez proposed openstack/horizon: Implements admin_filter_first in routers  https://review.openstack.org/35310016:59
*** asettle has quit IRC17:00
*** wolverineav has quit IRC17:03
*** adelia has joined #openstack-horizon17:03
*** xenogear_ has joined #openstack-horizon17:07
*** btully has quit IRC17:11
openstackgerritTimur Sufiev proposed openstack/horizon: Support for Glance v2  https://review.openstack.org/32003917:14
*** btully has joined #openstack-horizon17:14
*** wolverineav has joined #openstack-horizon17:19
*** bpokorny has quit IRC17:23
*** mvk has quit IRC17:23
*** btully has quit IRC17:27
*** harlowja has joined #openstack-horizon17:27
*** ametts has joined #openstack-horizon17:28
*** ducttape_ has quit IRC17:30
*** wolverineav has quit IRC17:30
*** kzaitsev_mb has quit IRC17:30
*** btully has joined #openstack-horizon17:31
*** wolverineav has joined #openstack-horizon17:36
*** bpokorny has joined #openstack-horizon17:37
*** xenogear_ has quit IRC17:40
*** xenogear_ has joined #openstack-horizon17:40
*** wolverineav has quit IRC17:44
*** ducttape_ has joined #openstack-horizon17:48
*** btully has quit IRC17:48
*** btully has joined #openstack-horizon17:49
*** wolverineav has joined #openstack-horizon17:49
tsufievTravT, so I've changed my mind :)17:51
tsufievbpokorny, I'm going to see how Glance V2 patch works with NG Create image from file17:51
TravTtsufiev oh good!17:51
TravTthanks for looking again17:51
bpokornytsufiev: Sounds good17:52
tsufievyep, for me it was mostly the choice between lesser and greater evil ;)17:52
*** asettle has joined #openstack-horizon17:52
tsufievhurgleburgler, hi! A minor change I made to https://review.openstack.org/#/c/313685/ seems to have changed the errors in dsvm job. Now we have to wait until test_reports returns to its lawful place again17:54
*** wolverineav has quit IRC17:55
*** matt-borland has quit IRC17:55
hurgleburglertsufiev: hmmm, k17:56
*** btully has quit IRC18:01
*** btully has joined #openstack-horizon18:02
tsufievbpokorny, hmm, it seems we need a new layer of typecasting for Angular workflows18:05
tsufievwhere Django did things like '42' -> 42 for free, with Angular we're on our own18:06
tsufievTravT, ^^^ speaking of Glance V218:06
*** ducttape_ has quit IRC18:07
*** uxdanielle has joined #openstack-horizon18:07
*** ducttape_ has joined #openstack-horizon18:07
bpokornytsufiev: Yeah. That makes sense. I've run into that with some other angular patches.18:11
bpokornySounds like Glance v2 support is going to get even more complex.18:11
*** mvk has joined #openstack-horizon18:12
TravTtsufiev: maybe for angular we should start just doing cors exclusively...18:12
*** tesseract- has quit IRC18:13
* TravT knows the downfalls and is just wishful thinking18:13
*** TravT_ has joined #openstack-horizon18:15
*** ChanServ sets mode: +v TravT_18:15
*** hurgleburgler has quit IRC18:15
*** hurgleburgler has joined #openstack-horizon18:15
*** ChanServ sets mode: +v hurgleburgler18:15
*** TravT has quit IRC18:17
*** kenji-i_ has quit IRC18:21
tsufievTravT_, not sure if that helps, we still need to pass non-blobs the usual way even with Angular - and there comes the tricky part18:29
tsufievthat's not exactly Angular fault, it's more related to how new REST API  wrappers are implemented18:31
tsufievsince browser sends all data to server layer as strings, here https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/rest/glance.py#L183 we need to somehow convert specific fields string->number etc18:33
tsufievor pass type hints in the browser request along with actual data to be used on server-side for typecasts18:33
*** catintheroof has quit IRC18:34
tsufievthe second way looks even more promising, because it may be easier to automate18:34
*** ducttape_ has quit IRC18:38
*** ametts has quit IRC18:42
*** ametts has joined #openstack-horizon18:43
*** zul has quit IRC18:44
*** _stowa has joined #openstack-horizon18:47
*** ducttape_ has joined #openstack-horizon18:49
*** zul has joined #openstack-horizon18:49
openstackgerritRevon Mathews proposed openstack/horizon: Server-side filtering Orchestration  https://review.openstack.org/34745918:53
*** _stowa has quit IRC18:56
*** aortega has quit IRC19:02
*** fifieldt has quit IRC19:02
*** btully has quit IRC19:04
*** btully has joined #openstack-horizon19:05
tyr_tsufiev: do the $http transformations help?19:06
*** zul has quit IRC19:06
openstackgerritNashwan Azhari proposed openstack/horizon: Switches to using oslo_log for all logging purposes.  https://review.openstack.org/35369519:10
*** asettle has quit IRC19:12
*** TravT_ has quit IRC19:12
*** TravT has joined #openstack-horizon19:12
*** ChanServ sets mode: +v TravT19:12
*** sjmc7 has quit IRC19:13
*** fifieldt has joined #openstack-horizon19:18
*** tyr__ has joined #openstack-horizon19:19
*** tyr_ has quit IRC19:22
*** rfinn has quit IRC19:22
*** sjmc7 has joined #openstack-horizon19:28
*** roxanaghe has quit IRC19:29
*** zul has joined #openstack-horizon19:30
*** rfinn has joined #openstack-horizon19:32
*** roxanaghe has joined #openstack-horizon19:34
*** mtanino has quit IRC19:34
*** piet has quit IRC19:35
robcresswell^^ thats an interesting patch...19:39
*** aortega has joined #openstack-horizon19:41
*** hurgleburgler1 has joined #openstack-horizon19:42
*** hurgleburgler has quit IRC19:42
*** TravT_ has joined #openstack-horizon19:42
*** ChanServ sets mode: +v TravT_19:42
tsufievtyr_: no idea :/19:44
*** wolverineav has joined #openstack-horizon19:45
*** TravT has quit IRC19:45
*** jprovazn has quit IRC19:46
*** wolverineav has quit IRC19:48
*** wolverineav has joined #openstack-horizon19:48
*** roxanaghe has quit IRC19:49
*** roxanaghe has joined #openstack-horizon19:56
openstackgerritRevon Mathews proposed openstack/horizon: Server-side filtering Orchestration  https://review.openstack.org/34745919:58
*** TravT_ is now known as TravT20:01
*** Tamayo has quit IRC20:02
*** roxanaghe has quit IRC20:04
*** roxanaghe has joined #openstack-horizon20:07
*** Tamayo has joined #openstack-horizon20:08
*** asettle has joined #openstack-horizon20:09
*** TravT_ has joined #openstack-horizon20:10
*** ChanServ sets mode: +v TravT_20:10
robcresswelldavid-lyle: I'm drowning in sarcasm20:11
david-lyleshort and sweet20:11
*** TravT has quit IRC20:11
*** wolverineav has quit IRC20:15
*** kzaitsev_mb has joined #openstack-horizon20:20
*** btully has quit IRC20:20
*** wolverineav has joined #openstack-horizon20:22
*** btully has joined #openstack-horizon20:22
*** wolverineav has quit IRC20:26
*** TravT has joined #openstack-horizon20:27
*** ChanServ sets mode: +v TravT20:27
*** TravT_ has quit IRC20:30
*** julim has quit IRC20:30
*** lblanchard has quit IRC20:32
*** roxanaghe has quit IRC20:33
*** btully has quit IRC20:33
*** ametts has quit IRC20:34
*** btully has joined #openstack-horizon20:36
*** roxanaghe has joined #openstack-horizon20:38
*** wolverineav has joined #openstack-horizon20:43
*** purva has quit IRC20:45
*** roxanaghe has quit IRC20:46
*** roxanaghe has joined #openstack-horizon20:47
*** wolverineav has quit IRC20:51
*** roxanaghe has quit IRC20:56
*** wolverineav has joined #openstack-horizon20:58
*** esp has quit IRC20:59
*** Tamayo has quit IRC21:01
*** esp has joined #openstack-horizon21:02
*** Tamayo has joined #openstack-horizon21:02
*** roxanaghe has joined #openstack-horizon21:03
*** sergio_nubeliu has quit IRC21:07
openstackgerritDaniel Castellanos proposed openstack/horizon: Server-side filtering for project images  https://review.openstack.org/33301121:13
*** ducttape_ has quit IRC21:18
*** ducttape_ has joined #openstack-horizon21:20
*** pauloewerton has quit IRC21:22
*** jtriley has quit IRC21:28
*** ducttape_ has quit IRC21:36
*** ducttape_ has joined #openstack-horizon21:38
*** adriant has joined #openstack-horizon21:39
*** weezS has quit IRC21:43
*** TravT has quit IRC21:47
*** TravT has joined #openstack-horizon21:48
*** ChanServ sets mode: +v TravT21:48
*** Ephur has quit IRC21:49
*** edtubill has quit IRC21:49
*** kzaitsev_mb has quit IRC22:06
*** kzaitsev_mb has joined #openstack-horizon22:10
*** yamamoto has joined #openstack-horizon22:11
*** adelia has quit IRC22:15
*** kzaitsev_mb has quit IRC22:17
*** ducttape_ has quit IRC22:19
*** ducttape_ has joined #openstack-horizon22:20
*** yamamoto has quit IRC22:20
openstackgerritRevon Mathews proposed openstack/horizon: Server-side filtering Orchestration  https://review.openstack.org/34745922:22
*** kzaitsev_mb has joined #openstack-horizon22:22
*** ducttape_ has quit IRC22:24
*** wolverineav has quit IRC22:25
*** wolverineav has joined #openstack-horizon22:26
*** kzaitsev_mb has quit IRC22:29
*** yamamoto has joined #openstack-horizon22:31
*** uxdanielle has quit IRC22:33
*** yamamoto has quit IRC22:33
*** wolverineav has quit IRC22:36
*** sdake has quit IRC22:38
*** kzaitsev_mb has joined #openstack-horizon22:39
*** ezpz has quit IRC22:39
*** weezS has joined #openstack-horizon22:46
*** wolverineav has joined #openstack-horizon22:47
*** yamamoto has joined #openstack-horizon22:47
*** asettle has quit IRC22:47
*** rfinn has quit IRC22:50
*** kzaitsev_mb has quit IRC22:50
*** yamamoto has quit IRC22:54
*** kzaitsev_mb has joined #openstack-horizon22:59
*** weezS has quit IRC22:59
*** sjmc7 has quit IRC23:00
*** wolverineav has quit IRC23:06
*** wolverineav has joined #openstack-horizon23:07
*** wolverineav has quit IRC23:12
*** wolverineav has joined #openstack-horizon23:13
*** Ephur has joined #openstack-horizon23:25
*** sdake has joined #openstack-horizon23:26
*** chlong|mtg has quit IRC23:31
*** zhurong has joined #openstack-horizon23:37
*** aortega has quit IRC23:44
*** Tamayo has quit IRC23:47
*** rkrum has joined #openstack-horizon23:50
*** TravT has quit IRC23:54
*** kzaitsev_mb has quit IRC23:57
*** TravT has joined #openstack-horizon23:57
*** ChanServ sets mode: +v TravT23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!