| *** roxanaghe has quit IRC | 00:02 | |
| *** zhurong has quit IRC | 00:06 | |
| *** davidlenwell has quit IRC | 00:11 | |
| *** TravT has joined #openstack-horizon | 00:23 | |
| *** ChanServ sets mode: +v TravT | 00:23 | |
| *** TravT has quit IRC | 00:23 | |
| *** TravT has joined #openstack-horizon | 00:23 | |
| *** ChanServ sets mode: +v TravT | 00:23 | |
| *** davidlenwell has joined #openstack-horizon | 00:25 | |
| *** wolverineav has quit IRC | 00:30 | |
| *** tqtran has quit IRC | 00:31 | |
| *** lexplua has quit IRC | 00:36 | |
| *** gyee has quit IRC | 00:43 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 00:52 | |
| *** ducttape_ has quit IRC | 01:08 | |
| *** Guest80925 has quit IRC | 01:16 | |
| *** zhurong has joined #openstack-horizon | 01:18 | |
| *** ruoyu has joined #openstack-horizon | 01:27 | |
| *** clu_ has quit IRC | 01:28 | |
| *** ruoyu has quit IRC | 01:32 | |
| *** ruoyu has joined #openstack-horizon | 01:34 | |
| *** ruoyu has quit IRC | 01:36 | |
| *** ducttape_ has joined #openstack-horizon | 01:36 | |
| openstackgerrit | xiaozhuangqing proposed openstack/horizon: Drop the undesired executable bit for the following file: 1. doc/source/topics/settings.rst https://review.openstack.org/377287 | 01:37 |
|---|---|---|
| *** ducttape_ has quit IRC | 01:37 | |
| *** zhihui has joined #openstack-horizon | 01:38 | |
| *** ducttape_ has joined #openstack-horizon | 01:41 | |
| *** kzaitsev_mb has quit IRC | 01:51 | |
| *** Jeffrey4l has joined #openstack-horizon | 01:58 | |
| *** kmartin has quit IRC | 02:02 | |
| *** zhihui has quit IRC | 02:06 | |
| *** ducttape_ has quit IRC | 02:09 | |
| *** ppiela has joined #openstack-horizon | 02:17 | |
| *** zhihui has joined #openstack-horizon | 02:20 | |
| *** ppiela has quit IRC | 02:22 | |
| *** jtriley has quit IRC | 02:28 | |
| *** shu-mutou has quit IRC | 02:44 | |
| *** shu-mutou has joined #openstack-horizon | 02:44 | |
| *** prometheanfire has joined #openstack-horizon | 02:52 | |
| prometheanfire | can any horizon people tell me why https://review.openstack.org/377992 is needed? | 02:53 |
| prometheanfire | since stable/mitaka is branch it needs reasoning imo | 02:53 |
| *** btully has joined #openstack-horizon | 02:53 | |
| *** david-lyle has quit IRC | 03:04 | |
| *** wolverineav has joined #openstack-horizon | 03:07 | |
| *** wolverineav has quit IRC | 03:07 | |
| *** wolverineav has joined #openstack-horizon | 03:07 | |
| *** btully has quit IRC | 03:08 | |
| *** ducttape_ has joined #openstack-horizon | 03:09 | |
| *** btully has joined #openstack-horizon | 03:10 | |
| *** jtriley has joined #openstack-horizon | 03:11 | |
| *** wolverin_ has joined #openstack-horizon | 03:11 | |
| *** wolverineav has quit IRC | 03:11 | |
| *** sdake_ has quit IRC | 03:17 | |
| *** ppiela has joined #openstack-horizon | 03:18 | |
| *** kenji-i has quit IRC | 03:21 | |
| *** ppiela has quit IRC | 03:22 | |
| *** tqtran has joined #openstack-horizon | 03:30 | |
| *** ducttape_ has quit IRC | 03:33 | |
| *** tqtran has quit IRC | 03:36 | |
| *** roxanaghe has joined #openstack-horizon | 03:38 | |
| *** sdake has joined #openstack-horizon | 03:39 | |
| *** ppiela has joined #openstack-horizon | 03:43 | |
| *** sdake_ has joined #openstack-horizon | 03:50 | |
| *** sdake has quit IRC | 03:51 | |
| *** roxanaghe has quit IRC | 03:52 | |
| *** wolverineav has joined #openstack-horizon | 03:52 | |
| *** wolverin_ has quit IRC | 03:56 | |
| *** roxanaghe has joined #openstack-horizon | 03:59 | |
| *** kenji-i has joined #openstack-horizon | 04:15 | |
| *** yamamoto_ has quit IRC | 04:17 | |
| *** btully has quit IRC | 04:20 | |
| *** btully has joined #openstack-horizon | 04:21 | |
| *** roxanaghe has quit IRC | 04:23 | |
| *** jtriley has quit IRC | 04:24 | |
| *** amotoki has joined #openstack-horizon | 04:28 | |
| *** ppiela has quit IRC | 04:36 | |
| *** masco has joined #openstack-horizon | 04:46 | |
| *** yamamoto has joined #openstack-horizon | 04:59 | |
| *** ratailor has joined #openstack-horizon | 05:07 | |
| *** ppiela has joined #openstack-horizon | 05:19 | |
| *** prometheanfire has quit IRC | 05:23 | |
| *** weezS has quit IRC | 05:24 | |
| *** ppiela has quit IRC | 05:24 | |
| openstackgerrit | xiaozhuangqing proposed openstack/horizon: Drop the undesired executable bit for the following file: https://review.openstack.org/377287 | 05:27 |
| *** prometheanfire has joined #openstack-horizon | 05:30 | |
| *** sdake_ has quit IRC | 05:30 | |
| openstackgerrit | xiaozhuangqing proposed openstack/horizon: Drop the undesired executable bit from non-executable file https://review.openstack.org/377287 | 05:31 |
| *** prometheanfire has left #openstack-horizon | 05:31 | |
| *** weezS has joined #openstack-horizon | 05:44 | |
| *** zhihui has quit IRC | 06:01 | |
| *** zhihui has joined #openstack-horizon | 06:02 | |
| *** weezS has quit IRC | 06:07 | |
| *** rcernin has joined #openstack-horizon | 06:14 | |
| *** ppiela has joined #openstack-horizon | 06:25 | |
| *** rhagarty__ has quit IRC | 06:26 | |
| *** rhagarty__ has joined #openstack-horizon | 06:27 | |
| *** ppiela has quit IRC | 06:30 | |
| *** kenji-i has quit IRC | 06:32 | |
| *** mrunge has quit IRC | 06:36 | |
| *** pcaruana has joined #openstack-horizon | 06:37 | |
| *** btully has quit IRC | 06:40 | |
| *** mrunge has joined #openstack-horizon | 06:42 | |
| *** ChanServ sets mode: +v mrunge | 06:42 | |
| *** zhihui has quit IRC | 06:43 | |
| *** jrist has joined #openstack-horizon | 06:54 | |
| *** zhihui has joined #openstack-horizon | 06:57 | |
| *** marlinc has joined #openstack-horizon | 06:59 | |
| *** jrist has quit IRC | 07:04 | |
| *** itxaka has joined #openstack-horizon | 07:14 | |
| *** marlinc has quit IRC | 07:21 | |
| *** marlinc has joined #openstack-horizon | 07:28 | |
| *** btully has joined #openstack-horizon | 07:29 | |
| *** jpich has joined #openstack-horizon | 07:35 | |
| *** marlinc has quit IRC | 07:58 | |
| robcresswell | prometheanfire: Its just a minor bugfix release. We removed the breaking change to do a bugfix release (thats what the revert is, and it was documented in the commit message) | 08:05 |
| openstackgerrit | Michael Lelyakin proposed openstack/horizon: Remove unused line from local_settings.py.example https://review.openstack.org/378354 | 08:14 |
| robcresswell | r1chardj0n3s: I think we need to consider making the integration tests non-voting for a bit. | 08:19 |
| *** marlinc has joined #openstack-horizon | 08:24 | |
| *** btully has quit IRC | 08:27 | |
| r1chardj0n3s | robcresswell: so not much progress eh :-( | 08:32 |
| *** tqtran has joined #openstack-horizon | 08:34 | |
| robcresswell | r1chardj0n3s: I've tagged new d_o_a and horizon RC2, but the last week has just been a recheck battle | 08:34 |
| robcresswell | r1chardj0n3s: Kind of losing patience with it now. There are patches out with dozens of rechecks all over. | 08:34 |
| r1chardj0n3s | robcresswell: yeah. I'm not up to speed with where all the various approaches for stability are at (except the two-fer patch that landed) | 08:35 |
| robcresswell | r1chardj0n3s: I think there is one more in flight, but thats also failing currently. | 08:36 |
| r1chardj0n3s | robcresswell: yep. my concern is regression, of course, but at the moment it's too difficult to even use the integration tests for that :/ | 08:37 |
| r1chardj0n3s | if we do de-promote it, we need to be extra vigilant when checking UIs | 08:37 |
| *** tqtran has quit IRC | 08:38 | |
| r1chardj0n3s | and then the next question is whether we reinstate those tests or look for something different (which is already a summit topic) | 08:38 |
| r1chardj0n3s | robcresswell: OK, I just looked at my "Needs Reverify" report and it's crazypants. Do you have the round tuits to push thru the change to de-promote integration tests? | 08:40 |
| r1chardj0n3s | (cash in some of those reverifies for some extra tuits, I suppose ;-) | 08:40 |
| robcresswell | round tuits? | 08:40 |
| r1chardj0n3s | oh, is that an Aussie thing? | 08:40 |
| robcresswell | I think so | 08:41 |
| robcresswell | I thought it was a typo | 08:41 |
| robcresswell | But internet says its a thing | 08:41 |
| *** sdake has joined #openstack-horizon | 08:41 | |
| r1chardj0n3s | anyway, "if you have time" :-) | 08:41 |
| robcresswell | r1chardj0n3s: Oh, yeah sure | 08:42 |
| *** sdake has quit IRC | 08:42 | |
| r1chardj0n3s | ok, cool, we should do it then | 08:42 |
| r1chardj0n3s | Once it's done, could you pls email openstack-dev? I'll also add to the agenda for tomorrow's meeting. | 08:44 |
| robcresswell | r1chardj0n3s: Sure | 08:45 |
| r1chardj0n3s | my rough count is we have at least 40 patches hitting random integration test failures | 08:45 |
| r1chardj0n3s | oh, I didn't scroll | 08:45 |
| r1chardj0n3s | probably 2-3x that number, actually | 08:46 |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-horizon | 08:49 | |
| *** wolverineav has quit IRC | 08:54 | |
| *** wolverineav has joined #openstack-horizon | 08:55 | |
| *** kzaitsev_mb has joined #openstack-horizon | 08:58 | |
| *** jamielennox is now known as jamielennox|away | 08:59 | |
| *** lexplua has joined #openstack-horizon | 09:09 | |
| *** lexplua has quit IRC | 09:09 | |
| *** lexplua has joined #openstack-horizon | 09:10 | |
| tsufiev | robcresswell, r1chardj0n3s: sad news indeed :( | 09:18 |
| tsufiev | but I understand the reasoning, since currently no one has enough the time to debug the issue with tests | 09:18 |
| openstackgerrit | George Tian proposed openstack/horizon: Using sys.exit(main()) instead of main() may be more reasonable. https://review.openstack.org/378459 | 09:19 |
| *** btully has joined #openstack-horizon | 09:24 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:25 | |
| robcresswell | r1chardj0n3s: The meeting chair change has been merged | 09:27 |
| *** lexplua has quit IRC | 09:28 | |
| *** lexplua has joined #openstack-horizon | 09:46 | |
| *** zhihui has quit IRC | 09:47 | |
| *** zhurong has quit IRC | 10:02 | |
| *** yamamoto has quit IRC | 10:13 | |
| *** ruoyu has joined #openstack-horizon | 10:50 | |
| *** ruoyu has quit IRC | 10:54 | |
| *** skamalakannan has joined #openstack-horizon | 11:02 | |
| skamalakannan | Hello any experts in Horizon. I am facing issue with dashboard not coming up for a long time | 11:02 |
| robcresswell | skamalakannan: Sure, need logs and description etc | 11:05 |
| robcresswell | and version | 11:05 |
| *** btully has quit IRC | 11:14 | |
| *** btully has joined #openstack-horizon | 11:15 | |
| skamalakannan | robcresserll, I am using liberty on ubuntu | 11:28 |
| *** yasemin has joined #openstack-horizon | 11:29 | |
| skamalakannan | do you need any particular log file | 11:31 |
| yasemin | hi, i want to add checkbox in launch instance form, which file edit ? i edited /horizon/openstack_dashboard/ dashboards/project/instances/workflows/create_instances.py, /horizon/openstack_dashboard/static/dashboard/project/workflow/configuration/details.html and /horizon/static/dashboard/project/workflow/launch-instances/details/details.html, but can't show my checkbox. can you help me ? | 11:35 |
| *** masco has quit IRC | 11:41 | |
| *** zhurong has joined #openstack-horizon | 11:41 | |
| *** jrist has joined #openstack-horizon | 11:49 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix metadata_to_str function code injection vulnerability https://review.openstack.org/378557 | 11:54 |
| *** sdake has joined #openstack-horizon | 12:02 | |
| *** ruoyu has joined #openstack-horizon | 12:03 | |
| *** ruoyu has quit IRC | 12:07 | |
| *** mtanino has joined #openstack-horizon | 12:12 | |
| *** jdwald has joined #openstack-horizon | 12:13 | |
| *** ruoyu has joined #openstack-horizon | 12:15 | |
| *** yamamoto has joined #openstack-horizon | 12:16 | |
| *** ducttape_ has joined #openstack-horizon | 12:17 | |
| *** ducttape_ has quit IRC | 12:19 | |
| *** ducttape_ has joined #openstack-horizon | 12:19 | |
| *** wangbo has joined #openstack-horizon | 12:20 | |
| *** ruoyu has quit IRC | 12:20 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** jamielennox|away is now known as jamielennox | 12:29 | |
| *** ratailor has quit IRC | 12:34 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix broken unit tests https://review.openstack.org/378581 | 12:34 |
| zigo | robcresswell: r1chardj0n3s: It's finally there: http://mirror.dfw.rax.openstack.org/debian-openstack/pool/main/h/horizon/ \o/ | 12:38 |
| zigo | Though I can't build django-openstack-auth in Sid. | 12:38 |
| zigo | It looks like there's issues with the latest version of requests. | 12:38 |
| zigo | hang on, will past the unit tests errors. | 12:38 |
| *** lexplua_ has joined #openstack-horizon | 12:39 | |
| *** ducttape_ has quit IRC | 12:40 | |
| *** vponomaryov has quit IRC | 12:41 | |
| *** lexplua has quit IRC | 12:41 | |
| *** ppiela has joined #openstack-horizon | 12:41 | |
| *** vponomaryov has joined #openstack-horizon | 12:43 | |
| *** yamamoto has joined #openstack-horizon | 12:45 | |
| *** yamamoto has quit IRC | 12:45 | |
| zigo | robcresswell: r1chardj0n3s: tsufiev: http://paste.debian.net/843108/ | 12:45 |
| zigo | It looks like a single issue to me. | 12:45 |
| *** rodrigods has quit IRC | 12:47 | |
| *** rodrigods has joined #openstack-horizon | 12:47 | |
| *** yamamoto has joined #openstack-horizon | 12:49 | |
| robcresswell | zigo: That's been fixed in the most recent version | 12:50 |
| zigo | robcresswell: Of what component? | 12:50 |
| robcresswell | zigo: d_o_a | 12:50 |
| zigo | robcresswell: That's 2.4.0 that I'm buliding ... | 12:50 |
| robcresswell | zigo: Should be 2.4.1 | 12:50 |
| zigo | Oh ! | 12:50 |
| robcresswell | :) | 12:50 |
| zigo | :) | 12:51 |
| zigo | robcresswell: Released YESTERDAY ! :) | 12:51 |
| robcresswell | zigo: of course | 12:51 |
| zigo | robcresswell: Does 2.4.1 includes that dj 1.10 patch we discussed in #openstack-release? | 12:51 |
| robcresswell | zigo: No, that was the release of 2.4.1 that was being debated | 12:51 |
| zigo | Ok, I'll keep the patch in debian/patches then. | 12:52 |
| robcresswell | zigo: Horizon RC2 has django 1.10 compatibility. For Django OpenStack Auth you will need to add: https://github.com/openstack/django_openstack_auth/commit/00346889c99c26f1bbdaf3c392bac6dfefb509c7 | 12:53 |
| robcresswell | zigo: After Newton release, I'll tag new d_o_a (3.0.0) which will have Django 1.10 support. That will be around the 10th of October. | 12:53 |
| zigo | robcresswell: Yup, it's in my package already. | 12:53 |
| robcresswell | Cool :) | 12:53 |
| robcresswell | Its in master, so its just waiting on a release now. | 12:54 |
| robcresswell | zigo: Horizon RC2 was tagged today btw, if you wanted to try building that. | 12:54 |
| zigo | robcresswell: Will do. | 12:55 |
| zigo | Waiting first for https://review.openstack.org/378593 to be built and merged, then I'll attempt to build Horizon in Sid. | 12:56 |
| *** david-lyle has joined #openstack-horizon | 12:57 | |
| *** ChanServ sets mode: +o david-lyle | 12:57 | |
| zigo | robcresswell: FYI, I know the openstack-dashboard package could be installed in Jessie, together with collect-static and compress working, as I could build designate-dashboard in Infra. | 12:58 |
| *** vishwanathj has joined #openstack-horizon | 12:58 | |
| *** ruoyu has joined #openstack-horizon | 12:58 | |
| zigo | So, it's looking good at least in the Jessie backport. | 12:58 |
| zigo | Hopefully, there wont be too many problems form now on but small DJ 1.10 fixes in plugins. | 12:58 |
| *** yasemin has left #openstack-horizon | 12:59 | |
| robcresswell | zigo: Let me know if you need help. I should know most of the fixes off the top of my head now. | 13:01 |
| zigo | robcresswell: I really guess you do, since I've had to know a few of them myself ! :) | 13:01 |
| zigo | It's always the same issues comming again and again. | 13:01 |
| *** ruoyu has quit IRC | 13:02 | |
| robcresswell | zigo: Yeah, r1chardj0n3s grabbed a couple as well | 13:03 |
| *** wangbo has quit IRC | 13:04 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/manila-ui: Fix broken unit tests https://review.openstack.org/378581 | 13:05 |
| *** ruoyu has joined #openstack-horizon | 13:05 | |
| *** yamamoto has quit IRC | 13:07 | |
| *** yamamoto has joined #openstack-horizon | 13:08 | |
| *** mtanino has quit IRC | 13:09 | |
| *** peristeri has joined #openstack-horizon | 13:13 | |
| *** masco has joined #openstack-horizon | 13:13 | |
| *** matt-borland has joined #openstack-horizon | 13:14 | |
| *** skamalakannan has quit IRC | 13:14 | |
| zigo | robcresswell: There's many warning when doing unit tests in Py3, but d_o_a builds fine... | 13:17 |
| *** jperry has joined #openstack-horizon | 13:17 | |
| *** lexplua_ has quit IRC | 13:18 | |
| *** ducttape_ has joined #openstack-horizon | 13:20 | |
| robcresswell | zigo: Ah, PEP8 warnings? | 13:21 |
| zigo | robcresswell: http://paste.openstack.org/show/583297/ | 13:22 |
| zigo | not sure what this is about... | 13:22 |
| robcresswell | Hmm | 13:24 |
| robcresswell | zigo: I'll investigate, but it seems to be working atm | 13:24 |
| *** ducttape_ has quit IRC | 13:25 | |
| *** lblanchard has joined #openstack-horizon | 13:26 | |
| *** jperry has quit IRC | 13:27 | |
| *** btully has quit IRC | 13:29 | |
| *** jtriley has joined #openstack-horizon | 13:29 | |
| *** btully has joined #openstack-horizon | 13:30 | |
| *** lexplua has joined #openstack-horizon | 13:32 | |
| *** jperry has joined #openstack-horizon | 13:33 | |
| *** wolverineav has quit IRC | 13:34 | |
| amotoki | robcresswell: hi | 13:35 |
| zigo | robcresswell: All unit tests passed in Sid for Horizon rc1 with the dj 1.10 patch! :) | 13:35 |
| zigo | Now awaiting for the rc2 to build in infra before I try to build it in Sid. | 13:35 |
| zigo | So, all good, it seems. | 13:35 |
| robcresswell | zigo: Great! | 13:36 |
| robcresswell | amotoki: Hello! | 13:36 |
| amotoki | robcresswell: is anyone investigating horizon integration test failures now? | 13:36 |
| amotoki | robcresswell: I checked the current failure rate using graphite.o.o and it says 90% is failing. | 13:36 |
| robcresswell | amotoki: Not at this very minute. I think tsufiev is doing Mirantis work, and I've only just finished pushing through RC2 and am now chasing up potential backports etc. | 13:36 |
| robcresswell | amotoki: Yes, I've pushed a patched to make non-voting. | 13:37 |
| zigo | robcresswell: Do you know what's that btw? http://paste.openstack.org/show/583299/ | 13:37 |
| amotoki | robcresswell: agree to change them to non-voting temporarily. | 13:37 |
| zigo | Is it safe to ignore? | 13:37 |
| *** masco has quit IRC | 13:38 | |
| robcresswell | zigo: Yes, it is. Its actually gone in master, thanks to this patch: https://github.com/openstack/horizon/commit/fbbe16f76d6d9437a9dcbd78e368f8f101f5a4fa | 13:38 |
| zigo | robcresswell: Is it in the rc2 already? | 13:38 |
| robcresswell | zigo: No, it wasnt backported | 13:39 |
| zigo | Ok, I'll carry the patch then. | 13:39 |
| robcresswell | zigo: Its a clean backport, so I'll see how stable team feel about having it in 10.0.1 potentially. | 13:40 |
| robcresswell | amotoki: Its not an ideal solution, but the random failures delayed RC2 several days :/ | 13:40 |
| amotoki | robcresswell: I took a look a bit but I haven't found the cause so far :( | 13:41 |
| amotoki | robcresswell: the failure modes have changed from a week ago. I honestly wonder what happens.. | 13:42 |
| robcresswell | amotoki: Likely a change in the webdriver or a FF update | 13:42 |
| robcresswell | unless we are still pinned. | 13:42 |
| robcresswell | Which I think we are, actually. | 13:43 |
| *** roxanaghe has joined #openstack-horizon | 13:43 | |
| amotoki | ah.. that's possible. | 13:43 |
| amotoki | I am now preparing Grafana dashboard for horizon as neutron does http://grafana.openstack.org/dashboard/db/neutron-failure-rate | 13:44 |
| *** roxanaghe has quit IRC | 13:45 | |
| amotoki | once I push it for review, let you know. | 13:45 |
| robcresswell | amotoki: Great, thanks! | 13:45 |
| *** ducttape_ has joined #openstack-horizon | 13:49 | |
| *** schipiga has joined #openstack-horizon | 13:49 | |
| zigo | robcresswell: Applying the patch fails the build: http://logs.openstack.org/28/378628/1/check/gate-deb-horizon-dpkg-debian-jessie/228cd44/console.html#_2016-09-28_13_49_40_496609 | 13:50 |
| zigo | I'm removing it. | 13:50 |
| robcresswell | zigo: Thats odd. That patch has merged, it works fine. That module is definitely valid too, it has an __init__.py | 13:53 |
| zigo | Let's *not* investigate this for now... :P | 13:54 |
| robcresswell | zigo: haha, sure thing :) | 13:54 |
| *** woodburn has quit IRC | 13:57 | |
| *** uxdanielle has joined #openstack-horizon | 13:58 | |
| *** woodburn has joined #openstack-horizon | 13:59 | |
| *** mtanino has joined #openstack-horizon | 13:59 | |
| *** Tamayo has joined #openstack-horizon | 14:01 | |
| *** mtanino has quit IRC | 14:04 | |
| tsufiev | robcresswell, yes, that's true that I'm currently keen-deep in Mirantis stuff :( | 14:06 |
| tsufiev | well, didn't imply that I'm unhappy about it, just but for integration tests | 14:07 |
| robcresswell | tsufiev: Haha, I understand :) | 14:07 |
| tsufiev | robcresswell, but I just spoke with schipiga and he's going to take the baton from my hands | 14:08 |
| tsufiev | he's got approval from his manager | 14:08 |
| tsufiev | schipiga, did I put it right? | 14:08 |
| schipiga | robcresswell, tsufiev yep, I'm ready to dedicated at least 2 days per week for upstream integration test issues | 14:09 |
| tsufiev | \o/ | 14:10 |
| tsufiev | wonderful news :) | 14:10 |
| amotoki | :) | 14:11 |
| *** sjmc7 has joined #openstack-horizon | 14:14 | |
| robcresswell | Thats great news schipiga | 14:15 |
| schipiga | thank you :) | 14:16 |
| *** annakoppad has joined #openstack-horizon | 14:17 | |
| vkmc | hey everybody, annakoppad is an applicant for the Outreachy program | 14:17 |
| vkmc | she is interested in contributing to Horizon | 14:18 |
| vkmc | and she is working on her first contribution | 14:18 |
| annakoppad | vkmc, thanks for the intro | 14:18 |
| vkmc | she has a few doubts, hopefully one of you can give her a hand | 14:18 |
| vkmc | annakoppad, anytime | 14:18 |
| annakoppad | vkmc, thanks, | 14:19 |
| annakoppad | all, here is my problem, I am working on this https://bugs.launchpad.net/horizon/+bug/1604056 I started looking at files that display the required. This file has the required meta definitions that display the data. /opt/stack/horizon/openstack_dashboard/dashboards/admin/metadata_defs/templates/metadata_defs But I am not sure how to adjust the table formats. Is it possible for you to guide me on this further? so that th | 14:19 |
| openstack | Launchpad bug 1604056 in OpenStack Dashboard (Horizon) "UX: Sort Indicator does not fit in table cell" [Undecided,Confirmed] - Assigned to Annapoornima Koppad (annakoppad) | 14:19 |
| openstackgerrit | Annapoornima Koppad proposed openstack/horizon: Strip white space from instance names https://review.openstack.org/249260 | 14:23 |
| *** raildo has joined #openstack-horizon | 14:26 | |
| *** tjones has joined #openstack-horizon | 14:26 | |
| *** tjones has left #openstack-horizon | 14:28 | |
| raildo | hey guys, I'm wondering if makes sense add unit test on this change? https://review.openstack.org/#/c/249260/ can someone guidance annakoppad on it? I'm trying to help her, but I'm not rock on horizon :( | 14:30 |
| annakoppad | raildo,no answers here??? | 14:30 |
| lcastell | raildo it makes perfect sense to add unit test | 14:31 |
| raildo | lcastell, do have any idea where we can add those tests? | 14:31 |
| lcastell | 1 sec | 14:33 |
| lcastell | raildo I think you can start looking here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tests.py | 14:34 |
| raildo | lcastell, sounds a good start point :) thanks sir | 14:36 |
| lcastell | np raildo | 14:36 |
| raildo | so, annakoppad I think we can create similar to this test: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tests.py#L1384-L1398 | 14:39 |
| raildo | annakoppad, when we pass a server.name(with a whitespace) as args here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/tests.py#L1395 | 14:40 |
| zigo | Horizon rc2 uploaded to Experimental. | 14:41 |
| annakoppad | @raildo, please dont mind if I sound stupid. but where is the run.py file located? | 14:42 |
| raildo | annakoppad, so, we don't use this kind of run.py style :) we run tests using tox. I suggest take a look on this link https://wiki.openstack.org/wiki/Testing | 14:43 |
| annakoppad | raildo, my head is floating in the code.. | 14:44 |
| annakoppad | sorry | 14:45 |
| raildo | annakoppad, np :) | 14:46 |
| annakoppad | I did run tox once. | 14:47 |
| annakoppad | But where do I add my test case now? | 14:47 |
| annakoppad | raildo, I think I know. | 14:47 |
| annakoppad | Let me do this and get back to you. | 14:47 |
| raildo | annakoppad, ok | 14:48 |
| *** tjones has joined #openstack-horizon | 14:49 | |
| *** yamamoto has quit IRC | 14:52 | |
| *** yamamoto has joined #openstack-horizon | 14:52 | |
| *** _ducttape_ has joined #openstack-horizon | 14:54 | |
| *** kmartin has joined #openstack-horizon | 14:54 | |
| *** ducttape_ has quit IRC | 14:57 | |
| *** zhurong has quit IRC | 15:01 | |
| *** rcernin has quit IRC | 15:04 | |
| *** kzaitsev_mb has quit IRC | 15:13 | |
| *** amotoki has quit IRC | 15:16 | |
| *** weezS has joined #openstack-horizon | 15:17 | |
| *** absubram has joined #openstack-horizon | 15:18 | |
| *** ruoyu has quit IRC | 15:24 | |
| *** _ducttape_ has quit IRC | 15:26 | |
| *** ducttape_ has joined #openstack-horizon | 15:27 | |
| *** ruoyu has joined #openstack-horizon | 15:27 | |
| *** ruoyu has quit IRC | 15:28 | |
| *** ruoyu has joined #openstack-horizon | 15:28 | |
| *** ruoyu has quit IRC | 15:28 | |
| *** ruoyu has joined #openstack-horizon | 15:35 | |
| *** ruoyu has quit IRC | 15:39 | |
| *** ruoyu has joined #openstack-horizon | 15:41 | |
| *** ruoyu has quit IRC | 15:45 | |
| *** wolverineav has joined #openstack-horizon | 15:46 | |
| *** rafael__ has joined #openstack-horizon | 15:47 | |
| *** ruoyu has joined #openstack-horizon | 15:47 | |
| *** rafael__ has quit IRC | 15:48 | |
| *** ruoyu has quit IRC | 15:52 | |
| *** ruoyu has joined #openstack-horizon | 16:01 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Behavioral fixes to Magic-Search https://review.openstack.org/371726 | 16:02 |
| *** lexplua has quit IRC | 16:03 | |
| *** mtanino has joined #openstack-horizon | 16:04 | |
| *** ruoyu has quit IRC | 16:05 | |
| *** ruoyu has joined #openstack-horizon | 16:08 | |
| *** roxanaghe has joined #openstack-horizon | 16:11 | |
| *** ruoyu has quit IRC | 16:13 | |
| *** jpich has quit IRC | 16:16 | |
| *** ruoyu has joined #openstack-horizon | 16:17 | |
| *** ruoyu has quit IRC | 16:18 | |
| *** ruoyu has joined #openstack-horizon | 16:18 | |
| *** jamielennox is now known as jamielennox|away | 16:21 | |
| *** lexplua has joined #openstack-horizon | 16:21 | |
| *** Guest46101 is now known as mgagne | 16:21 | |
| *** mgagne has quit IRC | 16:21 | |
| *** mgagne has joined #openstack-horizon | 16:21 | |
| *** yamamoto has quit IRC | 16:23 | |
| *** ruoyu has quit IRC | 16:23 | |
| *** jrist has quit IRC | 16:28 | |
| *** bkeller` has joined #openstack-horizon | 16:34 | |
| *** bkeller` has left #openstack-horizon | 16:34 | |
| *** jperry has quit IRC | 16:36 | |
| *** jperry has joined #openstack-horizon | 16:36 | |
| *** weezS has quit IRC | 16:37 | |
| david-lyle | annakoppad: are you still around? | 16:41 |
| annakoppad | Hi David | 16:41 |
| annakoppad | Dvid, Yes, indeed I am here, Sorry to bother over email | 16:41 |
| david-lyle | didn't fully read the scrollback, but is the question the same as the email? | 16:41 |
| openstackgerrit | Merged openstack/manila-ui: Fix broken unit tests https://review.openstack.org/378581 | 16:42 |
| annakoppad | David, yes, I was asking your help regarding this one. https://bugs.launchpad.net/horizon/+bug/1604056 | 16:42 |
| openstack | Launchpad bug 1604056 in OpenStack Dashboard (Horizon) "UX: Sort Indicator does not fit in table cell" [Undecided,Confirmed] - Assigned to Annapoornima Koppad (annakoppad) | 16:42 |
| david-lyle | I just reread the bug | 16:43 |
| david-lyle | thought it was something else :) | 16:43 |
| david-lyle | ok so there's two places that will effect that column header potentially | 16:44 |
| david-lyle | roughly here https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L54 | 16:44 |
| david-lyle | and then in the metadata table class itself | 16:45 |
| annakoppad | is it not in the metadata definitions file that I mentioned? | 16:45 |
| *** ruoyu has joined #openstack-horizon | 16:45 | |
| annakoppad | david, ok, will look at it as well. | 16:45 |
| david-lyle | annakoppad: well, that is the second place | 16:45 |
| annakoppad | david, I had already typed and hit return before I saw your second line. | 16:46 |
| david-lyle | the file you mentioned is an instance of the first | 16:46 |
| david-lyle | if we're not seeing it in other tables, that would point to something special about the metadata table | 16:46 |
| annakoppad | David, I did look up this file, https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L54 | 16:47 |
| annakoppad | david, it gives data for the tables, and not the table outline if I am not wrong. | 16:48 |
| annakoppad | David, I was more inclined towards changing /opt/stack/horizon/openstack_dashboard/dashboards/admin/metadata_defs/templates/metadata_defs | 16:48 |
| david-lyle | annakoppad: it defines table for horizon | 16:48 |
| david-lyle | all tables use that as the base | 16:49 |
| annakoppad | ok, | 16:49 |
| david-lyle | it does the rendering | 16:49 |
| david-lyle | the individual table classes merely provide the data and some variables as to how to render the data | 16:49 |
| annakoppad | david, I see it now. | 16:49 |
| *** ruoyu has quit IRC | 16:50 | |
| david-lyle | but I don't see anything unique to that table that would effect column headers | 16:50 |
| annakoppad | david, so it has nothing to do with the dt, dd, dl elements in the file, /opt/stack/horizon/openstack_dashboard/dashboards/admin/metadata_defs/templates/metadata_defs | 16:51 |
| annakoppad | I think those elements are the ones that set the table width, column, etc. | 16:51 |
| david-lyle | this is the template for the table view https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/metadata_defs/templates/metadata_defs/index.html | 16:52 |
| david-lyle | I hope I'm assuming correctly this is the base view for metadata and not a workflow? | 16:53 |
| annakoppad | david, one of the things that I thought I could do for the table was to do something like <div class="col-md-6 detail"> | 16:53 |
| * david-lyle does to reproduce the bug | 16:53 | |
| david-lyle | annakoppad: the problem is, that the col width is defined in the common code not for that specific table | 16:54 |
| david-lyle | so it would seem to indicate a problem in the common code rather than this specific instance | 16:55 |
| annakoppad | david, exactly thats the problem, if I change the base code, then the entire table for other views will also change | 16:55 |
| david-lyle | I'm wondering if it effects other views | 16:55 |
| annakoppad | I was wondering if I could set the width in the specific instance rather than the common code by doing something like, dt { 59 dt { 60 width: (($dl-horizontal-offset/2) - 20); 60 width: ($dl-horizontal-offset/2) - $padding-large-vertical; 61 } 61 } 62 62 dd { 63 dd { 63 margin-left: $dl-horizontal-offset/2; 64 margin-left: $dl-horizontal-offset/2; 64 | 16:55 |
| david-lyle | hence I'm trying to reproduce | 16:56 |
| annakoppad | ok | 16:56 |
| david-lyle | almost there | 16:56 |
| *** Tamayo has quit IRC | 16:58 | |
| david-lyle | I'm wondering why the description is claiming so much width | 17:00 |
| annakoppad | can I trim some spaces..??? | 17:01 |
| annakoppad | using strip method? | 17:01 |
| *** ruoyu has joined #openstack-horizon | 17:01 | |
| *** rafael__ has joined #openstack-horizon | 17:02 | |
| *** ruoyu has quit IRC | 17:02 | |
| *** ruoyu has joined #openstack-horizon | 17:02 | |
| *** ducttape_ has quit IRC | 17:02 | |
| *** lexplua has quit IRC | 17:02 | |
| *** rafael__ has quit IRC | 17:03 | |
| *** Tamayo has joined #openstack-horizon | 17:04 | |
| david-lyle | annakoppad: I can reproduce on another page too | 17:04 |
| david-lyle | the Description field is starving the rest of the page of space | 17:05 |
| david-lyle | I set the description on a Project on the Identity -> Projects panel to something really long and the Enable column shows the same issue | 17:06 |
| annakoppad | david, so this bug is actually requires some definitive code change | 17:07 |
| *** lexplua has joined #openstack-horizon | 17:07 | |
| david-lyle | annakoppad: yes | 17:07 |
| annakoppad | david, I want to puruse this one. | 17:07 |
| david-lyle | in the common code | 17:07 |
| david-lyle | it is yours to pursue :) | 17:07 |
| annakoppad | david, I am sorry but I will bug more you more to resolve this..:) | 17:08 |
| david-lyle | that's why I'm here | 17:08 |
| david-lyle | welcome BTW | 17:08 |
| david-lyle | also a pointer for IRC | 17:08 |
| annakoppad | David, great, thanks a ton | 17:08 |
| david-lyle | if you use the nick of the person, .e.g., david-lyle when addressing them, most clients will notify the person of their nick being used, and the person is more likely to see it | 17:09 |
| annakoppad | oh, ok, thanks for the tip | 17:09 |
| david-lyle | no problem, I just wouldn't want to miss your questions | 17:10 |
| david-lyle | it's also fine to ask generally in the room if you don't have a recipient in mind | 17:10 |
| david-lyle | but there are more and less active periods especially depending on what people are working on | 17:11 |
| david-lyle | so don't be offended if no one responds right away | 17:11 |
| annakoppad | david-lyle, one more question, what times are you available. | 17:11 |
| david-lyle | I'm UTC -6 | 17:11 |
| annakoppad | david-lyle, I am not offended when people dont respond, I get hyper when writing code and am disappointed when I hit a block | 17:12 |
| david-lyle | so most of the day in the US | 17:12 |
| annakoppad | david-lyle, ok, are the current timings most suitable for you? | 17:12 |
| david-lyle | annakoppad: I was implying you were, just a little more getting started info | 17:12 |
| david-lyle | annakoppad: yes | 17:12 |
| david-lyle | s/was/wasn't/ | 17:13 |
| david-lyle | and typing is hard | 17:13 |
| annakoppad | david-lyle, I did not understand the later part? | 17:13 |
| annakoppad | david-lyle, sorry? | 17:13 |
| david-lyle | it's vi for replacing text | 17:14 |
| david-lyle | I was trying to write: "I wasn't implying you were" | 17:14 |
| *** jperry has quit IRC | 17:15 | |
| *** jperry has joined #openstack-horizon | 17:15 | |
| annakoppad | david-lyle, testing openstack interface is just cumbersome, it takes somewhere between 20-30 minutes for stack.sh to run and load | 17:16 |
| annakoppad | david-lyle, I get vexed when writing code, and testing takes up so much bandwidth | 17:16 |
| david-lyle | annakoppad: there is a better way | 17:16 |
| david-lyle | please don't restack everytime you make a change | 17:16 |
| annakoppad | david-lyle, please, please let me know | 17:17 |
| david-lyle | https://github.com/openstack/horizon/blob/master/doc/source/quickstart.rst | 17:17 |
| *** itxaka has quit IRC | 17:17 | |
| *** annakoppad has quit IRC | 17:17 | |
| david-lyle | tl;dr; get openstack up and running | 17:17 |
| david-lyle | on the same VM clone the horizon repo | 17:18 |
| david-lyle | run the django test server from that repo | 17:18 |
| david-lyle | leave the version that devstack installs alone | 17:18 |
| *** annakoppad has joined #openstack-horizon | 17:18 | |
| david-lyle | if you must edit in the devstack copy | 17:18 |
| david-lyle | merely restart apache to pick up your changes | 17:18 |
| david-lyle | but a separate clone works much better | 17:19 |
| *** clu_ has joined #openstack-horizon | 17:19 | |
| *** ChanServ sets mode: +v clu_ | 17:19 | |
| *** rafael_ has joined #openstack-horizon | 17:19 | |
| david-lyle | if you don't mind configuring port forwarding you can do horizon dev and test server on a different machine than the VM running devstack | 17:20 |
| david-lyle | but that's more the master class | 17:20 |
| david-lyle | let's get you up and running with the standard version first | 17:20 |
| annakoppad | david-lyle, I just lost a whole lot of conversation, can you repaste what ever you wrote? | 17:20 |
| annakoppad | Or is there a log that I can look at? | 17:20 |
| david-lyle | it's logged | 17:20 |
| david-lyle | http://eavesdrop.openstack.org/irclogs/%23openstack-horizon/%23openstack-horizon.2016-09-28.log.html | 17:21 |
| david-lyle | there is a little lag | 17:21 |
| annakoppad | david-lyle, ok great | 17:22 |
| *** yamamoto has joined #openstack-horizon | 17:23 | |
| *** ducttape_ has joined #openstack-horizon | 17:29 | |
| *** yamamoto has quit IRC | 17:31 | |
| *** lexplua has quit IRC | 17:33 | |
| robcresswell | annakoppad: If its easier, I'm UTC+1, usually around during the day. Just been busy recently with finalising the Newton release. | 17:35 |
| robcresswell | annakoppad: So you can bug me if dave is asleep | 17:35 |
| annakoppad | robcresswell, | 17:35 |
| annakoppad | robcresswell, thanks a lot, I was about to bug david-lyle on another bug. | 17:36 |
| david-lyle | annakoppad: we have a few | 17:36 |
| robcresswell | david-lyle: yes, 1 or 2 | 17:37 |
| robcresswell | ...thousand. | 17:37 |
| annakoppad | david-lyle, robcresswell, I have a quite a few bug fixing to do..:) am going to be bugging you people | 17:37 |
| david-lyle | some I didn't even create | 17:37 |
| david-lyle | ok, a couple | 17:37 |
| *** lexplua has joined #openstack-horizon | 17:37 | |
| robcresswell | I was gonna say... | 17:37 |
| ediardo | lol | 17:37 |
| annakoppad | david-lyle, yeah, I write code and then after some time, I look at it, and wonder if I actually wrote that | 17:38 |
| annakoppad | so, here I am fixing other's bugs...:) | 17:38 |
| ediardo | :) | 17:38 |
| david-lyle | penance | 17:38 |
| robcresswell | annakoppad: Yeah. I read code and wonder which idiot wrote it, and then realise it was my code :) | 17:38 |
| robcresswell | ...or daves | 17:39 |
| annakoppad | robcresswell, now you can add mine too.. | 17:39 |
| annakoppad | :P | 17:39 |
| annakoppad | just saying | 17:39 |
| * david-lyle takes a note of robcresswell's slight | 17:39 | |
| * robcresswell has a bad feeling about this | 17:39 | |
| david-lyle | I see the integration tests are now non-voting again | 17:40 |
| david-lyle | I feel like we've been here before | 17:40 |
| david-lyle | I recognize all the trees | 17:40 |
| *** lexplua has quit IRC | 17:40 | |
| david-lyle | and the bush | 17:40 |
| robcresswell | I felt like we were improving too much | 17:40 |
| robcresswell | Thought I'd pull us back a bit | 17:40 |
| david-lyle | maybe we should really consider a new strategy | 17:42 |
| robcresswell | Its on the summit agenda. And yes, I agree | 17:42 |
| david-lyle | good | 17:42 |
| robcresswell | The time and frustration going into these tests is not worth the benefit IMO. | 17:42 |
| david-lyle | indeed | 17:42 |
| robcresswell | I would genuinely prefer the dozen bugs it catches just get introduced and we spend the time fixing them, rather than hours of rechecking and waiting and poking the framework to make it pass. | 17:43 |
| robcresswell | (Obviously, I'd just prefer working E2E/integration testing) | 17:43 |
| david-lyle | we have a tempest plugin, I wonder if leveraging that now somehow instead would be more robust? | 17:43 |
| david-lyle | but selenium will still be involved | 17:44 |
| david-lyle | so who knows | 17:44 |
| robcresswell | selenium will likely be involved whatever we do. I wonder if we should move away from the page object structure though. Feels like the barrier to entry is high when fixing these tests | 17:45 |
| robcresswell | Either way I'll be doing some research before the summit and come up with some ideas. | 17:45 |
| david-lyle | I look forward to being dazzled | 17:45 |
| annakoppad | robcresswell, I want to be involved, please, let me in! I promise to write better code | 17:45 |
| annakoppad | no headaches, :) | 17:46 |
| robcresswell | annakoppad: Rewriting testing framework might be a little ambitious just yet :p | 17:46 |
| annakoppad | robcresswell, I am working on this bug, https://bugs.launchpad.net/horizon/+bug/1519386 | 17:47 |
| openstack | Launchpad bug 1519386 in OpenStack Dashboard (Horizon) "launching of instances with names including white spaces at the end fail" [Low,In progress] - Assigned to Annapoornima Koppad (annakoppad) | 17:47 |
| annakoppad | I wrote a testcase for the code, and that s failing now. | 17:47 |
| david-lyle | I've reviewed code for that bug | 17:48 |
| david-lyle | I thought | 17:48 |
| robcresswell | annakoppad: If you want to show us code etc. you can use paste.openstack.org for snippets | 17:48 |
| robcresswell | david-lyle: I think it was the same bug on routers. | 17:48 |
| david-lyle | it was nova related because I dug into their regex's for names | 17:49 |
| david-lyle | maybe flavors | 17:49 |
| robcresswell | Oh, maybe | 17:49 |
| robcresswell | That sounds familiar too | 17:49 |
| david-lyle | annakoppad: look for a similar closed bug and copy the fix :) | 17:50 |
| david-lyle | unless you want to dig into nova's name validation code | 17:50 |
| david-lyle | I know I enjoyed my time in there / | 17:51 |
| *** annakoppad has quit IRC | 17:52 | |
| david-lyle | https://review.openstack.org/#/c/339318/ | 17:52 |
| david-lyle | apparently it never merged | 17:52 |
| david-lyle | hmmm | 17:52 |
| robcresswell | Oh yeah, they were asking me for a review | 17:53 |
| robcresswell | thats why I left that -1 | 17:53 |
| *** _ducttape_ has joined #openstack-horizon | 17:53 | |
| robcresswell | probably not what they wanted | 17:53 |
| robcresswell | There's this patch for key pairs https://review.openstack.org/#/c/350747/ | 17:54 |
| robcresswell | That might help | 17:54 |
| david-lyle | that's a winner | 17:54 |
| david-lyle | and annakoppad left :( | 17:55 |
| *** annakoppad has joined #openstack-horizon | 17:55 | |
| robcresswell | Its logged :D | 17:55 |
| david-lyle | added links to the patches in the bug comment too | 17:56 |
| *** ducttape_ has quit IRC | 17:57 | |
| robcresswell | win | 17:58 |
| *** lexplua has joined #openstack-horizon | 18:04 | |
| *** weezS has joined #openstack-horizon | 18:05 | |
| *** kzaitsev_mb has joined #openstack-horizon | 18:08 | |
| *** sjmc7 has quit IRC | 18:10 | |
| annakoppad | robcresswell, I am not sure how this relates to my bug. | 18:13 |
| *** _ducttape_ has quit IRC | 18:13 | |
| annakoppad | For robcresswell, there can be white spaces in between instance names and not towards the end is what I think? | 18:13 |
| *** ducttape_ has joined #openstack-horizon | 18:13 | |
| *** tqtran has joined #openstack-horizon | 18:14 | |
| robcresswell | annakoppad: Well, it might be useful. It shows how to use a regex to match it, and it shows how to test it | 18:15 |
| robcresswell | annakoppad: So you could probably just adapt it, with a different match, I think | 18:15 |
| robcresswell | Its a thought anyway :) | 18:15 |
| annakoppad | oh I understood that process. | 18:16 |
| *** sjmc7 has joined #openstack-horizon | 18:16 | |
| *** tqtran has quit IRC | 18:18 | |
| annakoppad | I wrote this test case after the code, http://paste.openstack.org/show/583357/ | 18:19 |
| annakoppad | Let me run the tests and I will let you know what happens after that. | 18:19 |
| *** Jeffrey4l has quit IRC | 18:28 | |
| *** ducttape_ has quit IRC | 18:41 | |
| *** Tamayo has quit IRC | 18:41 | |
| *** Tamayo has joined #openstack-horizon | 18:42 | |
| *** TravT_ has joined #openstack-horizon | 18:44 | |
| *** ChanServ sets mode: +v TravT_ | 18:44 | |
| *** sdake has quit IRC | 18:46 | |
| *** TravT has quit IRC | 18:47 | |
| *** TravT_ has quit IRC | 18:48 | |
| *** wolverineav has quit IRC | 18:51 | |
| *** wolverineav has joined #openstack-horizon | 18:53 | |
| *** ducttape_ has joined #openstack-horizon | 18:55 | |
| *** hogepodge has quit IRC | 19:01 | |
| *** annakoppad has quit IRC | 19:01 | |
| *** TravT has joined #openstack-horizon | 19:04 | |
| *** ChanServ sets mode: +v TravT | 19:04 | |
| *** tqtran has joined #openstack-horizon | 19:06 | |
| *** kzaitsev_mb has quit IRC | 19:08 | |
| *** TravT has quit IRC | 19:09 | |
| *** hoonetorg has quit IRC | 19:14 | |
| *** wolverineav has quit IRC | 19:17 | |
| *** wolverineav has joined #openstack-horizon | 19:19 | |
| *** shu-mutou-AWAY has quit IRC | 19:20 | |
| ducttape_ | tox -e cover is no longer working for me..... what memo did I miss??? :\ | 19:20 |
| robcresswell | ducttape_: Can you elaborate? Any error messages? | 19:23 |
| ducttape_ | I used to be able to run "tox -e cover" in the horizon repo.... it would run tests, gather results, etc | 19:24 |
| ducttape_ | and it is not currently working for me | 19:24 |
| ducttape_ | just pulled upstream master copy..... this could have been an upstream outside change, or it could be a horizon change in the last 2 months | 19:25 |
| ducttape_ | https://github.com/openstack/horizon/blob/master/tox.ini#L104-L109 is what I am running, and it seems to bomb on the xml line | 19:26 |
| *** tqtran has quit IRC | 19:26 | |
| *** kzaitsev_mb has joined #openstack-horizon | 19:26 | |
| *** yohoffman has quit IRC | 19:26 | |
| *** xenogear has quit IRC | 19:26 | |
| *** yohoffman has joined #openstack-horizon | 19:27 | |
| ducttape_ | http://paste.openstack.org/show/583368/ is how it looks to me | 19:27 |
| *** wolverineav has quit IRC | 19:28 | |
| robcresswell | ducttape_: Yeah, same error, just ran it | 19:30 |
| robcresswell | derp | 19:30 |
| robcresswell | ducttape_: Have you got a bug for it? | 19:30 |
| openstackgerrit | Merged openstack/manila-ui: Fix metadata_to_str function code injection vulnerability https://review.openstack.org/378557 | 19:30 |
| ducttape_ | no fix for it | 19:30 |
| ducttape_ | just reaching out to see if I am doing something stupid. thanks for the confirmation robcresswell | 19:30 |
| *** tqtran has joined #openstack-horizon | 19:31 | |
| ducttape_ | I will do something stupid.... but TODAY IS NOT THAT DAY* *yet | 19:31 |
| *** TravT has joined #openstack-horizon | 19:31 | |
| *** ChanServ sets mode: +v TravT | 19:31 | |
| *** hoonetorg has joined #openstack-horizon | 19:31 | |
| *** btully has quit IRC | 19:32 | |
| *** TravT has quit IRC | 19:32 | |
| *** xenogear has joined #openstack-horizon | 19:32 | |
| *** btully has joined #openstack-horizon | 19:33 | |
| *** wolverineav has joined #openstack-horizon | 19:33 | |
| robcresswell | ducttape_: If you get a moment, please put up a bug with the paste in it | 19:34 |
| *** sdake has joined #openstack-horizon | 19:34 | |
| ducttape_ | https://bugs.launchpad.net/horizon/+bug/1628661 robcresswell | 19:36 |
| openstack | Launchpad bug 1628661 in OpenStack Dashboard (Horizon) "horizon tox -e cover not working" [Undecided,New] | 19:36 |
| *** TravT has joined #openstack-horizon | 19:36 | |
| *** ChanServ sets mode: +v TravT | 19:36 | |
| *** TravT has quit IRC | 19:36 | |
| *** TravT has joined #openstack-horizon | 19:36 | |
| *** ChanServ sets mode: +v TravT | 19:36 | |
| *** TravT has quit IRC | 19:37 | |
| robcresswell | thanks ducttape_ | 19:37 |
| ducttape_ | sure... will see if I can hack together quick fix | 19:38 |
| *** TravT has joined #openstack-horizon | 19:38 | |
| *** ChanServ sets mode: +v TravT | 19:38 | |
| *** wolverineav has quit IRC | 19:45 | |
| *** wolverineav has joined #openstack-horizon | 19:46 | |
| *** TravT has quit IRC | 19:47 | |
| *** wolverineav has quit IRC | 19:50 | |
| *** wolverineav has joined #openstack-horizon | 19:52 | |
| *** ppiela has quit IRC | 19:57 | |
| r1chardj0n3s | good morning | 19:57 |
| robcresswell | r1chardj0n3s: o/ | 19:57 |
| robcresswell | Meeting over in #openstack-meeting-3 in 2 mins :) | 19:58 |
| r1chardj0n3s | thanks robcresswell :-) | 19:58 |
| robcresswell | np | 19:59 |
| *** wolverineav has quit IRC | 19:59 | |
| robcresswell | tsufiev, ducttape_, matt-borland, clu_, tqtran: meeting is on if you're around :) | 20:02 |
| *** Tamayo has quit IRC | 20:02 | |
| ducttape_ | thanks | 20:02 |
| *** annakoppad has joined #openstack-horizon | 20:02 | |
| annakoppad | robcresswell, david-lyle, need your help here | 20:02 |
| *** Tamayo has joined #openstack-horizon | 20:03 | |
| *** kzaitsev_mb has quit IRC | 20:03 | |
| *** Tamayo has quit IRC | 20:03 | |
| *** wolverineav has joined #openstack-horizon | 20:03 | |
| *** Tamayo has joined #openstack-horizon | 20:03 | |
| robcresswell | annakoppad: Just in the Horizon meeting in #openstack-meeting-3 right now, may be slow to reply | 20:04 |
| annakoppad | ok, robcresswell! here is my test case, that I pasted in, http://paste.openstack.org/show/583377/ | 20:05 |
| annakoppad | robcresswell, and the error with that testcase is here, http://paste.openstack.org/show/583378/ | 20:06 |
| annakoppad | david-lyle, can you please help, http://paste.openstack.org/show/583377/, http://paste.openstack.org/show/583378/ | 20:07 |
| *** wolverineav has quit IRC | 20:08 | |
| *** weezS has quit IRC | 20:10 | |
| annakoppad | hello everyone, I am trying to fix the bug, https://launchpad.net/bugs/1519386, here is my fix, https://review.openstack.org/#/c/249260/. I wrote a test case, http://paste.openstack.org/show/583377/, which is throwing up an error, http://paste.openstack.org/show/583378/, can someone help? | 20:10 |
| openstack | Launchpad bug 1519386 in OpenStack Dashboard (Horizon) "launching of instances with names including white spaces at the end fail" [Low,In progress] - Assigned to Annapoornima Koppad (annakoppad) | 20:10 |
| david-lyle | annakoppad: pretty much all are in #openstack-meeting-3 until the top of the hour | 20:12 |
| annakoppad | ok, will bug you laters then. | 20:12 |
| *** weezS has joined #openstack-horizon | 20:13 | |
| ducttape_ | annakoppad - you did not mock something correctly. I recognize this error | 20:13 |
| annakoppad | ducttape_, thanks for answering, but what do you mean by did not mock something correctly? | 20:14 |
| annakoppad | does openstack have to be up and running for this code to run? | 20:14 |
| ducttape_ | at the top of your test method, you need to declare you want a certain api mocked out | 20:14 |
| ducttape_ | and then you need to do the mock itself in the body of the test code | 20:14 |
| ducttape_ | see example like https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/users/tests.py#L97 | 20:15 |
| ducttape_ | how it declares user_create at the header above, then down in the body too | 20:15 |
| *** wolverineav has joined #openstack-horizon | 20:16 | |
| ducttape_ | can spend more time after meeting, but that error is a common pain point for me | 20:17 |
| annakoppad | ducttape_, I see what is happening. Let me try some more code and testing, and I will revert back. Thanks for answering though | 20:18 |
| *** roxanaghe has quit IRC | 20:22 | |
| robcresswell | annakoppad: Where is that test declared? | 20:32 |
| annakoppad | robcresswell, in the file, openstack_dashboard/dashboards/project/instances/tests.py | 20:32 |
| robcresswell | annakoppad: Ah okay | 20:33 |
| annakoppad | I think I know why it is throwing up an error | 20:33 |
| annakoppad | like ducttape_ mentioned, I had not mocked up the data | 20:33 |
| *** kzaitsev_mb has joined #openstack-horizon | 20:34 | |
| robcresswell | annakoppad: Ah, yeah I see the scrollback | 20:34 |
| *** wolverineav has quit IRC | 20:34 | |
| *** wolverineav has joined #openstack-horizon | 20:36 | |
| annakoppad | robcresswell, are you free now? I need to ask a lot of qiestions? | 20:37 |
| annakoppad | robcresswell, questions* | 20:37 |
| robcresswell | annakoppad: Sure. I can sleep at the weekend. Fire away. | 20:38 |
| ducttape_ | robcresswell: thanks again for PTL run, as r1chardj0n3s said in the meeting. agree with this sentiment | 20:38 |
| annakoppad | I think I resolved the test case. | 20:38 |
| *** Tamayo has quit IRC | 20:39 | |
| david-lyle | annakoppad: you have to mock the api calls | 20:39 |
| david-lyle | ah ducttape_ provided that help already | 20:39 |
| annakoppad | robcresswell, the questions that I have is, I have changed the code at four different places, do I need to create 4 different testcases for them? | 20:40 |
| robcresswell | ducttape_: Thanks! | 20:40 |
| * r1chardj0n3s goes back to being on vacation | 20:40 | |
| robcresswell | annakoppad: Er, 4 places? Can you elaborate? The answer is, maybe. | 20:40 |
| robcresswell | annakoppad: Quickest way may be to push your code for review and let us comment there :) | 20:40 |
| ducttape_ | it needs to be a square number though david-lyle, this much is true | 20:41 |
| annakoppad | robcresswell, david-lyle, and will do, | 20:41 |
| annakoppad | before I forget, ducttape_, thank you! | 20:41 |
| ducttape_ | sure no prob | 20:41 |
| *** wolverineav has quit IRC | 20:42 | |
| *** ccesario has quit IRC | 20:43 | |
| annakoppad | robcresswell, david-lyle, ducttape_, I just had another question. | 20:43 |
| robcresswell | sure | 20:44 |
| ducttape_ | you get 1.2 questions / day | 20:44 |
| ducttape_ | go ahead | 20:44 |
| annakoppad | robcresswell, david-lyle, ducttape_, now that I know that the particular method provides the stripped result, where do I see the difference between what the earlier code gave and my current code will give? | 20:44 |
| *** jamielennox|away is now known as jamielennox | 20:45 | |
| annakoppad | robcresswell, david-lyle, ducttape_, | 20:45 |
| annakoppad | robcresswell, david-lyle, ducttape_, sorry, today I cannot sleep without getting this fixed. | 20:45 |
| annakoppad | robcresswell, david-lyle, ducttape_, I will use my other day quotas today. promise will not ask more questions tomorrow | 20:45 |
| ducttape_ | I'm not sure I understand annakoppad | 20:46 |
| *** lblanchard has quit IRC | 20:46 | |
| ducttape_ | you mean this is a table view with stripped results ? | 20:46 |
| robcresswell | annakoppad: As long as your test is passing, and it has extra whitespace in the name, then you know your code is working. So you're done. | 20:46 |
| ducttape_ | and you want to preview before and after ? | 20:46 |
| annakoppad | robcresswell, david-lyle, ducttape_, https://bugs.launchpad.net/horizon/+bug/1519386 give me long message. Now my current code gives striped message | 20:47 |
| openstack | Launchpad bug 1519386 in OpenStack Dashboard (Horizon) "launching of instances with names including white spaces at the end fail" [Low,In progress] - Assigned to Annapoornima Koppad (annakoppad) | 20:47 |
| ducttape_ | robcresswell is 100% correct. if you have test cases passing, you should sleep right then and there | 20:47 |
| annakoppad | robcresswell, david-lyle, ducttape_, how do I see the difference? is my question | 20:47 |
| robcresswell | annakoppad: Yeah, if your test passes, then you've succeeded | 20:47 |
| robcresswell | annakoppad: I'm not sure I understand. What difference are you trying to see? | 20:47 |
| annakoppad | but since robcresswell insists that testcases pass, I think one testcase is passing. | 20:47 |
| robcresswell | Yup, if it is passing, then you're done :) | 20:48 |
| david-lyle | annakoppad: you mean via git? | 20:48 |
| annakoppad | oh nothing. | 20:48 |
| annakoppad | its ok. | 20:48 |
| robcresswell | Oh, did you mean the code difference? | 20:48 |
| annakoppad | I see that I am trying to reproduce the earlier bug and now see that it gives me the current result. | 20:49 |
| ducttape_ | annakoppad: one nit - having a key name be spaces only is not a common thing. something more like "my key" would be a more useful test | 20:49 |
| annakoppad | thats enough. I answered my own question. | 20:49 |
| robcresswell | annakoppad: Best thing to do for now is push the code for review, and we'll review it :) | 20:49 |
| david-lyle | ducttape_: that's a valid value though | 20:49 |
| annakoppad | ducttape_ | 20:49 |
| david-lyle | "my key " however is not | 20:49 |
| david-lyle | because, awesome | 20:50 |
| ducttape_ | I'd focus on realistic things you would encounter is my only point. | 20:50 |
| robcresswell | IIRC the test in this case was just retrieving the first item in the dest data, and appending " " and then checking that the sanitation code works. | 20:50 |
| annakoppad | ducttape_, my concern would be that since this is just a name, I think stripping woule be enugh | 20:50 |
| robcresswell | So, it will probably be a valid name. | 20:50 |
| annakoppad | in case, if I had to check it was a valid name then I would have to do the regex check that robcresswell mentioned. | 20:51 |
| david-lyle | annakoppad: so you're adjusting the input? | 20:51 |
| * david-lyle needs to see the ccode | 20:51 | |
| robcresswell | Yeah, just put the code online and we'll take a look :) | 20:51 |
| robcresswell | it's easier then talking | 20:51 |
| robcresswell | than* | 20:51 |
| *** wolverineav has joined #openstack-horizon | 20:52 | |
| annakoppad | robcresswell, server.id = server.id + ' ' | 20:52 |
| annakoppad | I did that. | 20:52 |
| annakoppad | in the testcase | 20:52 |
| robcresswell | yup, sounds correct, will have to take a look. | 20:52 |
| ducttape_ | annakoppad: this counts exactly as .2 questions. your quota looks ok | 20:53 |
| annakoppad | well, thank you guys for all the support. I | 20:54 |
| annakoppad | am going to upload the testcase, and then go to sleep. I am dreaming of code today. | 20:54 |
| robcresswell | annakoppad: Cool, thanks for the bug fix | 20:55 |
| annakoppad | robcresswell, david-lyle, ducttape_, not without your support. | 20:55 |
| robcresswell | I'm off to bed, night all | 20:56 |
| annakoppad | robcresswell,good night | 20:57 |
| *** tqtran_ has joined #openstack-horizon | 20:57 | |
| david-lyle | later robcresswell | 20:58 |
| *** btully has quit IRC | 20:58 | |
| *** raildo has quit IRC | 20:58 | |
| *** tqtran has quit IRC | 20:59 | |
| *** btully has joined #openstack-horizon | 21:00 | |
| *** tqtran_ has quit IRC | 21:04 | |
| *** clu_ has quit IRC | 21:04 | |
| *** clu_ has joined #openstack-horizon | 21:04 | |
| *** ChanServ sets mode: +v clu_ | 21:04 | |
| openstackgerrit | Annapoornima Koppad proposed openstack/horizon: Strip white space from instance names https://review.openstack.org/249260 | 21:05 |
| *** annakoppad has quit IRC | 21:06 | |
| *** jtriley has quit IRC | 21:06 | |
| *** tqtran has joined #openstack-horizon | 21:06 | |
| *** clu_ has quit IRC | 21:08 | |
| *** kzaitsev_mb has quit IRC | 21:08 | |
| *** clu_ has joined #openstack-horizon | 21:08 | |
| *** ChanServ sets mode: +v clu_ | 21:08 | |
| *** ruoyu has quit IRC | 21:08 | |
| ducttape_ | I've got the coverage fix I think david-lyle. were you asleep when I was talking about this ? | 21:09 |
| david-lyle | no I wasn't asleep | 21:09 |
| david-lyle | I do remember someone removing the job run in the gate because it didn't work anymore | 21:10 |
| ducttape_ | I've got the fix to make it great again | 21:10 |
| ducttape_ | ™® | 21:10 |
| *** ruoyu has joined #openstack-horizon | 21:11 | |
| *** wolverineav has quit IRC | 21:11 | |
| *** btully has quit IRC | 21:12 | |
| *** wolverineav has joined #openstack-horizon | 21:13 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Fix tox cover to not fail https://review.openstack.org/379002 | 21:13 |
| *** ruoyu has quit IRC | 21:15 | |
| ducttape_ | david-lyle: is there a way to place that test code back into place? | 21:18 |
| * ducttape_ can't believe what he is asking for | 21:18 | |
| *** btully has joined #openstack-horizon | 21:18 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Fix tox cover to not fail https://review.openstack.org/379002 | 21:21 |
| *** roxanaghe has joined #openstack-horizon | 21:22 | |
| *** wolverineav has quit IRC | 21:25 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:25 | |
| *** hogepodge has joined #openstack-horizon | 21:28 | |
| *** weezS has quit IRC | 21:30 | |
| *** jdwald has quit IRC | 21:32 | |
| *** matt-borland has quit IRC | 21:32 | |
| *** wolverineav has joined #openstack-horizon | 21:37 | |
| *** peristeri has quit IRC | 21:37 | |
| *** kzaitsev_mb has quit IRC | 21:41 | |
| *** absubram has quit IRC | 21:42 | |
| *** wolverineav has quit IRC | 21:44 | |
| david-lyle | ducttape_: why "-a" on openstack_dashboard but not horizon? | 21:48 |
| ducttape_ | b/c that ammends the previous run's output | 21:48 |
| david-lyle | ah | 21:48 |
| ducttape_ | the first step is to erase / clear it | 21:48 |
| david-lyle | replaced the combine | 21:48 |
| ducttape_ | then you create the initial file, them ammend | 21:48 |
| ducttape_ | then finally.... 4) PROFIT | 21:48 |
| david-lyle | ok | 21:49 |
| ducttape_ | right, the combine seems to be not good | 21:49 |
| *** wolverineav has joined #openstack-horizon | 21:49 | |
| david-lyle | probably deprecated and removed | 21:49 |
| ducttape_ | I think the amend is correct anyways, and before we ended up blowing away the first run of data | 21:49 |
| ducttape_ | thats what I found, running each step in different orders, looking at the file sizes | 21:50 |
| ducttape_ | irregardlessly - this is much less bader now | 21:50 |
| * ducttape_ is terrific at English | 21:50 | |
| david-lyle | apparently combine was confusing | 21:51 |
| david-lyle | reading the changelog for py coverage | 21:51 |
| david-lyle | ok you have my +2 | 21:52 |
| ducttape_ | Richard is on vacation? is tqtran still around ? | 21:53 |
| * ducttape_ knew he should have captured tqtran when he had the chance | 21:54 | |
| ducttape_ | thanks david-lyle | 21:54 |
| *** wolverineav has quit IRC | 21:57 | |
| *** kzaitsev_mb has joined #openstack-horizon | 21:58 | |
| *** jperry has quit IRC | 22:01 | |
| *** kzaitsev_mb has quit IRC | 22:04 | |
| *** btully has quit IRC | 22:05 | |
| *** btully has joined #openstack-horizon | 22:06 | |
| *** wolverineav has joined #openstack-horizon | 22:08 | |
| *** lexplua has quit IRC | 22:08 | |
| *** tqtran has quit IRC | 22:09 | |
| *** clu_ has quit IRC | 22:09 | |
| *** clu_ has joined #openstack-horizon | 22:09 | |
| *** ChanServ sets mode: +v clu_ | 22:09 | |
| *** tqtran has joined #openstack-horizon | 22:11 | |
| *** clu_ has quit IRC | 22:11 | |
| *** wolverineav has quit IRC | 22:12 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:14 | |
| *** wolverineav has joined #openstack-horizon | 22:15 | |
| *** kzaitsev_mb has quit IRC | 22:21 | |
| *** wolverineav has quit IRC | 22:22 | |
| *** ducttape_ has quit IRC | 22:22 | |
| *** vishwanathj has quit IRC | 22:29 | |
| *** sjmc7 has quit IRC | 22:38 | |
| *** kzaitsev_mb has joined #openstack-horizon | 22:42 | |
| *** ducttape_ has joined #openstack-horizon | 22:46 | |
| *** weezS has joined #openstack-horizon | 22:46 | |
| *** wolverineav has joined #openstack-horizon | 22:52 | |
| *** ducttape_ has quit IRC | 22:52 | |
| *** sdake has quit IRC | 22:56 | |
| *** ducttape_ has joined #openstack-horizon | 22:58 | |
| *** wolverineav has quit IRC | 22:59 | |
| *** wolverineav has joined #openstack-horizon | 23:03 | |
| *** bpokorny has joined #openstack-horizon | 23:06 | |
| *** weezS has quit IRC | 23:07 | |
| *** wolverineav has quit IRC | 23:10 | |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/375988 | 23:11 |
| openstackgerrit | Merged openstack/horizon: Fixed serial console not appearing in horizon https://review.openstack.org/372860 | 23:13 |
| *** ducttape_ has quit IRC | 23:13 | |
| *** tqtran_ has joined #openstack-horizon | 23:13 | |
| *** tqtran has quit IRC | 23:14 | |
| *** kzaitsev_mb has quit IRC | 23:17 | |
| *** tqtran_ has quit IRC | 23:18 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:22 | |
| *** wolverineav has joined #openstack-horizon | 23:25 | |
| *** TravT has joined #openstack-horizon | 23:28 | |
| *** ChanServ sets mode: +v TravT | 23:28 | |
| *** wolverineav has quit IRC | 23:30 | |
| *** wolverineav has joined #openstack-horizon | 23:31 | |
| *** sdake has joined #openstack-horizon | 23:32 | |
| *** sdake_ has joined #openstack-horizon | 23:35 | |
| *** wolverineav has quit IRC | 23:35 | |
| *** sdake has quit IRC | 23:38 | |
| *** kzaitsev_mb has quit IRC | 23:43 | |
| *** kenji-i has joined #openstack-horizon | 23:44 | |
| *** kzaitsev_mb has joined #openstack-horizon | 23:44 | |
| *** zhurong has joined #openstack-horizon | 23:46 | |
| *** wolverineav has joined #openstack-horizon | 23:47 | |
| *** kzaitsev_mb has quit IRC | 23:52 | |
| *** wolverineav has quit IRC | 23:52 | |
| *** roxanaghe has quit IRC | 23:58 | |
| *** TravT_ has joined #openstack-horizon | 23:59 | |
| *** ChanServ sets mode: +v TravT_ | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!