| *** ctayal has quit IRC | 00:00 | |
| *** bpokorny has quit IRC | 00:02 | |
| *** bpokorny has joined #openstack-horizon | 00:02 | |
| *** ctayal has joined #openstack-horizon | 00:04 | |
| *** mtanino has quit IRC | 00:10 | |
| *** itisha has quit IRC | 00:12 | |
| *** katyafervent_awa has quit IRC | 00:14 | |
| *** katyafervent_awa has joined #openstack-horizon | 00:14 | |
| *** ctayal has quit IRC | 00:16 | |
| *** Pavo has quit IRC | 00:16 | |
| *** tsufiev has quit IRC | 00:16 | |
| *** ducttape_ has joined #openstack-horizon | 00:17 | |
| *** tsufiev has joined #openstack-horizon | 00:17 | |
| *** ChanServ sets mode: +v tsufiev | 00:17 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon: Add charts to show volume quotas on Python launch instance modal https://review.openstack.org/390409 | 00:18 |
|---|---|---|
| *** Pavo has joined #openstack-horizon | 00:21 | |
| *** rcernin has quit IRC | 00:22 | |
| *** ctayal has joined #openstack-horizon | 00:24 | |
| *** kzaitsev_mb has joined #openstack-horizon | 00:29 | |
| *** harlowja has joined #openstack-horizon | 00:30 | |
| *** alexvictorchan has quit IRC | 00:44 | |
| *** ducttape_ has quit IRC | 00:53 | |
| *** sacharya has joined #openstack-horizon | 00:58 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: Add Angular keystone user details use registry https://review.openstack.org/336394 | 00:59 |
| *** sacharya has quit IRC | 01:03 | |
| *** kzaitsev_mb has quit IRC | 01:05 | |
| *** Zer0Byte__ has quit IRC | 01:06 | |
| *** ctayal has quit IRC | 01:06 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 01:19 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: WIP - Add cinder group types to Admin volume panel https://review.openstack.org/410490 | 01:28 |
| *** piet has joined #openstack-horizon | 01:30 | |
| *** bpokorny_ has joined #openstack-horizon | 01:32 | |
| *** bpokorny_ has quit IRC | 01:32 | |
| *** yamamoto has quit IRC | 01:33 | |
| *** bpokorny has quit IRC | 01:35 | |
| *** zhugaoxiao has quit IRC | 01:51 | |
| *** zhugaoxiao has joined #openstack-horizon | 01:52 | |
| *** yamamoto has joined #openstack-horizon | 01:52 | |
| *** ducttape_ has joined #openstack-horizon | 01:53 | |
| *** ducttape_ has quit IRC | 01:55 | |
| *** ducttape_ has joined #openstack-horizon | 01:55 | |
| *** ctayal has joined #openstack-horizon | 01:59 | |
| *** ruoyu has joined #openstack-horizon | 02:02 | |
| *** ctayal_ has joined #openstack-horizon | 02:05 | |
| *** ctayal has quit IRC | 02:05 | |
| *** Jeffrey4l has quit IRC | 02:05 | |
| *** tqtran has quit IRC | 02:07 | |
| *** Pavo has quit IRC | 02:09 | |
| *** ducttape_ has quit IRC | 02:09 | |
| *** dave-mccowan has quit IRC | 02:10 | |
| *** ruoyu has quit IRC | 02:10 | |
| *** Pavo has joined #openstack-horizon | 02:11 | |
| *** dave-mccowan has joined #openstack-horizon | 02:11 | |
| *** ruoyu has joined #openstack-horizon | 02:11 | |
| *** Pavo has quit IRC | 02:12 | |
| *** Pavo has joined #openstack-horizon | 02:13 | |
| *** Jeffrey4l has joined #openstack-horizon | 02:15 | |
| *** pghmt1 has joined #openstack-horizon | 02:18 | |
| *** ruoyu has quit IRC | 02:18 | |
| *** pghmt has quit IRC | 02:18 | |
| *** ducttape_ has joined #openstack-horizon | 02:21 | |
| *** ruoyu has joined #openstack-horizon | 02:29 | |
| *** ruoyu has quit IRC | 02:31 | |
| *** ruoyu has joined #openstack-horizon | 02:32 | |
| *** clu_ has quit IRC | 02:33 | |
| *** lblanchard has quit IRC | 02:35 | |
| *** ruoyu has quit IRC | 02:41 | |
| *** ruoyu has joined #openstack-horizon | 02:41 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Update for ui bootstrap changes https://review.openstack.org/401245 | 02:44 |
| *** mrunge has quit IRC | 02:49 | |
| *** bpokorny has joined #openstack-horizon | 02:51 | |
| *** mrunge has joined #openstack-horizon | 02:54 | |
| *** ChanServ sets mode: +v mrunge | 02:54 | |
| *** bpokorny has quit IRC | 02:55 | |
| *** ducttape_ has quit IRC | 02:56 | |
| *** sacharya has joined #openstack-horizon | 02:59 | |
| *** ruoyu has quit IRC | 03:01 | |
| *** ruoyu has joined #openstack-horizon | 03:02 | |
| *** pghmt1 has quit IRC | 03:02 | |
| *** sacharya has quit IRC | 03:04 | |
| *** pghmt has joined #openstack-horizon | 03:08 | |
| *** ruoyu has quit IRC | 03:09 | |
| openstackgerrit | chenyingnan proposed openstack/horizon: Replace six.iteritems(iter) with iter.items() https://review.openstack.org/409615 | 03:15 |
| *** bpokorny has joined #openstack-horizon | 03:24 | |
| *** sacharya has joined #openstack-horizon | 03:25 | |
| *** jtriley has joined #openstack-horizon | 03:25 | |
| *** pghmt has quit IRC | 03:25 | |
| *** pghmt has joined #openstack-horizon | 03:25 | |
| *** bpokorny has quit IRC | 03:29 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: Update for ui bootstrap changes https://review.openstack.org/401245 | 03:34 |
| *** piet has quit IRC | 03:35 | |
| *** dave-mccowan has quit IRC | 03:39 | |
| *** pghmt has quit IRC | 03:41 | |
| *** bpokorny has joined #openstack-horizon | 03:55 | |
| *** bpokorny has quit IRC | 03:56 | |
| *** ducttape_ has joined #openstack-horizon | 03:57 | |
| *** ducttape_ has quit IRC | 04:01 | |
| *** tqtran has joined #openstack-horizon | 04:03 | |
| *** tqtran has quit IRC | 04:08 | |
| *** shu-mutou has quit IRC | 04:09 | |
| *** jtriley has quit IRC | 04:09 | |
| *** Pavo has quit IRC | 04:13 | |
| *** udesale has joined #openstack-horizon | 04:14 | |
| *** shu-mutou has joined #openstack-horizon | 04:15 | |
| *** Pavo has joined #openstack-horizon | 04:17 | |
| *** ducttape_ has joined #openstack-horizon | 04:33 | |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 04:38 |
| *** ducttape_ has quit IRC | 04:44 | |
| *** chlong has joined #openstack-horizon | 04:44 | |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 04:45 |
| *** jrcloud has joined #openstack-horizon | 04:50 | |
| *** zackf has quit IRC | 04:53 | |
| *** tqtran has joined #openstack-horizon | 05:06 | |
| *** tqtran has quit IRC | 05:10 | |
| *** jrcloud has quit IRC | 05:12 | |
| *** masco has joined #openstack-horizon | 05:12 | |
| *** ratailor has joined #openstack-horizon | 05:13 | |
| *** wolverineav has joined #openstack-horizon | 05:18 | |
| *** ctayal_ has quit IRC | 05:22 | |
| *** wolverineav has quit IRC | 05:22 | |
| *** ducttape_ has joined #openstack-horizon | 05:44 | |
| *** ducttape_ has quit IRC | 05:49 | |
| *** adriant has quit IRC | 05:53 | |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 06:07 |
| *** amotoki has joined #openstack-horizon | 06:12 | |
| *** Pavo has quit IRC | 06:13 | |
| *** ctayal has joined #openstack-horizon | 06:13 | |
| *** amotoki has quit IRC | 06:14 | |
| *** amotoki has joined #openstack-horizon | 06:17 | |
| *** Pavo has joined #openstack-horizon | 06:17 | |
| *** hurgleburgler has quit IRC | 06:27 | |
| *** hurgleburgler has joined #openstack-horizon | 06:28 | |
| *** ChanServ sets mode: +v hurgleburgler | 06:28 | |
| *** hurgleburgler has quit IRC | 06:28 | |
| *** zackf has joined #openstack-horizon | 06:31 | |
| *** zackf has quit IRC | 06:35 | |
| *** zackf has joined #openstack-horizon | 06:51 | |
| *** tobberydberg has joined #openstack-horizon | 07:04 | |
| *** ducttape_ has joined #openstack-horizon | 07:04 | |
| *** tobberyd_ has joined #openstack-horizon | 07:06 | |
| *** tobberyd_ has joined #openstack-horizon | 07:06 | |
| openstackgerrit | Yakup Adaklı proposed openstack/horizon: Text and checkbox should align in "Create Project" form https://review.openstack.org/409804 | 07:07 |
| *** tobberydberg has quit IRC | 07:09 | |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 07:09 |
| *** zackf has quit IRC | 07:12 | |
| *** bapalm has quit IRC | 07:18 | |
| *** yamamoto has quit IRC | 07:18 | |
| *** ducttape_ has quit IRC | 07:24 | |
| *** jprovazn has joined #openstack-horizon | 07:24 | |
| *** ctayal has quit IRC | 07:25 | |
| *** sacharya has quit IRC | 07:26 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Zanata https://review.openstack.org/410568 | 07:32 |
| *** bapalm has joined #openstack-horizon | 07:38 | |
| *** Foxlik has joined #openstack-horizon | 07:38 | |
| *** Foxlik1 has joined #openstack-horizon | 07:40 | |
| *** ctayal has joined #openstack-horizon | 07:41 | |
| *** Foxlik has quit IRC | 07:42 | |
| *** rcernin has joined #openstack-horizon | 07:56 | |
| *** yamamoto has joined #openstack-horizon | 07:56 | |
| *** rcernin has quit IRC | 07:56 | |
| *** rcernin has joined #openstack-horizon | 07:57 | |
| *** pcaruana has joined #openstack-horizon | 07:59 | |
| *** sacharya has joined #openstack-horizon | 08:00 | |
| *** sacharya has quit IRC | 08:05 | |
| *** tqtran has joined #openstack-horizon | 08:08 | |
| openstackgerrit | Yakup Adaklı proposed openstack/horizon: Text and checkbox should align in "Create Project" form https://review.openstack.org/409804 | 08:10 |
| *** tqtran has quit IRC | 08:12 | |
| *** Pavo has quit IRC | 08:12 | |
| *** Pavo has joined #openstack-horizon | 08:18 | |
| *** ducttape_ has joined #openstack-horizon | 08:25 | |
| *** jpich has joined #openstack-horizon | 08:27 | |
| *** ducttape_ has quit IRC | 08:30 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Zanata https://review.openstack.org/410568 | 08:32 |
| *** breitz has quit IRC | 08:33 | |
| *** breitz has joined #openstack-horizon | 08:33 | |
| *** Zer0Byte__ has joined #openstack-horizon | 08:39 | |
| *** ctayal has quit IRC | 08:45 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| robcresswell | rhagarty: Let's discuss microversions. There are at least 3 people now working in isolation on the implementation. | 08:50 |
| *** shu-mutou is now known as shu-mutou-AWAY | 08:59 | |
| *** ianychoi has joined #openstack-horizon | 09:05 | |
| *** openstackgerrit has joined #openstack-horizon | 09:10 | |
| openstackgerrit | Kenji Ishii proposed openstack/horizon: Add Port-Create in Project Dashboard https://review.openstack.org/320203 | 09:10 |
| *** tobberyd_ has quit IRC | 09:10 | |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 09:12 |
| openstackgerrit | anusha proposed openstack/horizon: Networks panel can't be actually disabled https://review.openstack.org/408583 | 09:14 |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Simple tenant usage pagination https://review.openstack.org/410337 | 09:15 |
| *** rmoe has quit IRC | 09:16 | |
| *** tobberyd_ has joined #openstack-horizon | 09:21 | |
| *** tobberyd_ has quit IRC | 09:26 | |
| *** rmoe has joined #openstack-horizon | 09:30 | |
| *** itisha has joined #openstack-horizon | 09:39 | |
| *** Zer0Byte__ has quit IRC | 09:41 | |
| *** tobberydberg has joined #openstack-horizon | 09:52 | |
| *** rmoe has quit IRC | 09:52 | |
| *** rmoe has joined #openstack-horizon | 09:55 | |
| *** ducttape_ has joined #openstack-horizon | 09:56 | |
| *** ducttape_ has quit IRC | 10:00 | |
| *** tobberydberg has quit IRC | 10:03 | |
| *** tobberydberg has joined #openstack-horizon | 10:04 | |
| *** tobberydberg has quit IRC | 10:08 | |
| *** tqtran has joined #openstack-horizon | 10:09 | |
| *** zackf has joined #openstack-horizon | 10:10 | |
| *** brad[] has quit IRC | 10:11 | |
| *** Pavo has quit IRC | 10:13 | |
| *** tqtran has quit IRC | 10:13 | |
| *** tobberydberg has joined #openstack-horizon | 10:14 | |
| *** zackf has quit IRC | 10:14 | |
| *** Pavo has joined #openstack-horizon | 10:17 | |
| *** tobberydberg has quit IRC | 10:19 | |
| *** rmoe has quit IRC | 10:24 | |
| *** mvk has quit IRC | 10:24 | |
| *** tobberydberg has joined #openstack-horizon | 10:36 | |
| *** tobberydberg has quit IRC | 10:47 | |
| *** wolverineav has joined #openstack-horizon | 10:50 | |
| *** tosky has joined #openstack-horizon | 10:55 | |
| *** tobberydberg has joined #openstack-horizon | 10:56 | |
| *** mvk has joined #openstack-horizon | 10:56 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Properly compare versions in APIVersionManager https://review.openstack.org/410688 | 10:59 |
| *** tobberydberg has quit IRC | 11:01 | |
| *** udesale has quit IRC | 11:05 | |
| *** yamamoto has quit IRC | 11:12 | |
| openstackgerrit | Yakup Adaklı proposed openstack/horizon: Flavor detail page added. https://review.openstack.org/410693 | 11:13 |
| *** rmoe has joined #openstack-horizon | 11:23 | |
| *** brad[] has joined #openstack-horizon | 11:24 | |
| *** yamamoto has joined #openstack-horizon | 11:26 | |
| *** ducttape_ has joined #openstack-horizon | 11:26 | |
| *** ratailor has quit IRC | 11:28 | |
| *** tobberydberg has joined #openstack-horizon | 11:29 | |
| *** ducttape_ has quit IRC | 11:31 | |
| *** tobberyd_ has joined #openstack-horizon | 11:38 | |
| *** tobbery__ has joined #openstack-horizon | 11:40 | |
| *** tobberydberg has quit IRC | 11:41 | |
| *** tobber___ has joined #openstack-horizon | 11:41 | |
| *** tobberyd_ has quit IRC | 11:43 | |
| *** tobbery__ has quit IRC | 11:44 | |
| *** tobberydberg has joined #openstack-horizon | 11:44 | |
| *** tobber___ has quit IRC | 11:45 | |
| *** tobberydberg has quit IRC | 11:49 | |
| *** tobberydberg has joined #openstack-horizon | 11:50 | |
| *** sacharya has joined #openstack-horizon | 12:02 | |
| *** dave-mccowan has joined #openstack-horizon | 12:04 | |
| *** sacharya has quit IRC | 12:07 | |
| *** tqtran has joined #openstack-horizon | 12:11 | |
| *** ^Gal^ has joined #openstack-horizon | 12:12 | |
| *** Pavo has quit IRC | 12:12 | |
| *** tqtran has quit IRC | 12:15 | |
| openstackgerrit | Rodrigo Barbieri proposed openstack/manila-ui: Implement Share Migration Ocata improvements https://review.openstack.org/406307 | 12:16 |
| *** zackf has joined #openstack-horizon | 12:16 | |
| *** Pavo has joined #openstack-horizon | 12:17 | |
| *** zackf has quit IRC | 12:20 | |
| *** aortega has quit IRC | 12:40 | |
| *** jamielennox is now known as jamielennox|away | 12:43 | |
| rdopiera | robcresswell: ok, lets | 12:47 |
| *** jamielennox|away is now known as jamielennox | 12:50 | |
| robcresswell | rdopiera: ? | 12:51 |
| robcresswell | ah yes, now there are 4 patches to API handling | 12:52 |
| robcresswell | :D | 12:52 |
| rdopiera | \o/ | 12:52 |
| rdopiera | what's with this `except Exception: pass` recently? | 12:54 |
| rdopiera | I've been seeing that in our patches more and more | 12:54 |
| robcresswell | rdopiera: Why handle exceptions when you could bury them and pretend they didnt happen | 12:56 |
| robcresswell | rdopiera: But, do you have an example? | 12:56 |
| *** ducttape_ has joined #openstack-horizon | 12:57 | |
| *** masco has quit IRC | 12:57 | |
| rdopiera | robcresswell: that microversion patch, for instance | 13:00 |
| rdopiera | https://review.openstack.org/#/c/410490/1/openstack_dashboard/api/base.py line 139 | 13:00 |
| robcresswell | idk | 13:00 |
| robcresswell | I would at least log something and return None there | 13:01 |
| robcresswell | Not sure why it is just being swallowed. That patch is WIP and needs a lot of work though. | 13:01 |
| *** ducttape_ has quit IRC | 13:01 | |
| rdopiera | yeah, but I've seen that a lot recently in various patches | 13:03 |
| rdopiera | maybe it's just selection bias | 13:03 |
| robcresswell | The only thing I can think is that people are just sketching out their ideas in code and forgetting to update it later on | 13:04 |
| rdopiera | probably | 13:05 |
| rdopiera | good thing we are reviewing it meticulously :) | 13:05 |
| robcresswell | :D | 13:05 |
| *** ducttape_ has joined #openstack-horizon | 13:09 | |
| *** mvk has quit IRC | 13:15 | |
| robcresswell | rdopiera: It might even be worth just removing all 'pass' and replacing it with a debug(e) statement. | 13:20 |
| robcresswell | As in just logging the error... not sure why burying it is ever useful really. | 13:20 |
| rdopiera | robcresswell: it doesn't help much when people don't look at the test logs anyways | 13:20 |
| rdopiera | robcresswell: well, burying it is useful when you *expect* the error most of the time | 13:21 |
| robcresswell | I suppose | 13:21 |
| rdopiera | robcresswell: but then you should catch the exact error you expect | 13:21 |
| robcresswell | right | 13:21 |
| *** brad[] has quit IRC | 13:28 | |
| robcresswell | how has this not merged :( | 13:29 |
| robcresswell | https://review.openstack.org/#/c/155939/ | 13:29 |
| rdopiera | I guess because I didn't give workflow+1, to give you a chance to look at the nits :) | 13:29 |
| robcresswell | haha | 13:30 |
| rdopiera | but if you think it's fine, do workflow+1 yourself | 13:30 |
| robcresswell | rdopiera: I was hoping ana would update it | 13:30 |
| rdopiera | ah, no, sorry, that's nto your patch | 13:30 |
| rdopiera | ignore what I just said | 13:30 |
| *** chlong has quit IRC | 13:32 | |
| *** aortega has joined #openstack-horizon | 13:34 | |
| *** jdwald has joined #openstack-horizon | 13:35 | |
| *** ducttape_ has quit IRC | 13:45 | |
| *** brad[] has joined #openstack-horizon | 13:52 | |
| openstackgerrit | Yakup Adaklı proposed openstack/horizon: AngularJS based panels page title updated https://review.openstack.org/409753 | 13:54 |
| *** sacharya has joined #openstack-horizon | 14:03 | |
| *** sacharya has quit IRC | 14:08 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Properly compare versions in APIVersionManager https://review.openstack.org/410688 | 14:12 |
| rdopiera | stupid json with its stupid serialization, grumble | 14:12 |
| *** Pavo has quit IRC | 14:12 | |
| *** tqtran has joined #openstack-horizon | 14:12 | |
| *** Pavo has joined #openstack-horizon | 14:13 | |
| *** Pavo has quit IRC | 14:14 | |
| *** Pavo has joined #openstack-horizon | 14:14 | |
| *** ducttape_ has joined #openstack-horizon | 14:15 | |
| *** tqtran has quit IRC | 14:17 | |
| *** lblanchard has joined #openstack-horizon | 14:21 | |
| robcresswell | rdopiera: :D | 14:29 |
| robcresswell | rdopiera: I'm still wrestling with how best to do microversions | 14:29 |
| rdopiera | I don't have an opinion | 14:32 |
| robcresswell | My stance is still totally hostile, which is making it difficult to write logical code. | 14:33 |
| robcresswell | oh well. | 14:33 |
| *** ducttape_ has quit IRC | 14:34 | |
| *** mvk has joined #openstack-horizon | 14:36 | |
| *** breitz has quit IRC | 14:37 | |
| *** breitz_ has joined #openstack-horizon | 14:37 | |
| *** jtriley has joined #openstack-horizon | 14:45 | |
| *** udesale has joined #openstack-horizon | 14:47 | |
| *** ruoyu has joined #openstack-horizon | 14:50 | |
| openstackgerrit | Merged openstack/horizon: Add generic session/cookie value getters/setters https://review.openstack.org/155939 | 14:50 |
| *** mtanino has joined #openstack-horizon | 14:52 | |
| *** ^Gal^ has quit IRC | 15:01 | |
| *** mvk has quit IRC | 15:02 | |
| *** hurgleburgler has joined #openstack-horizon | 15:03 | |
| *** ChanServ sets mode: +v hurgleburgler | 15:03 | |
| *** lblanchard has quit IRC | 15:03 | |
| *** ruoyu has quit IRC | 15:05 | |
| *** ruoyu has joined #openstack-horizon | 15:05 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 15:05 |
| *** lblanchard has joined #openstack-horizon | 15:08 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon: Move all Django configuration into .conf file https://review.openstack.org/404735 | 15:09 |
| *** mvk has joined #openstack-horizon | 15:16 | |
| *** ducttape_ has joined #openstack-horizon | 15:16 | |
| *** ruoyu has quit IRC | 15:16 | |
| *** chlong has joined #openstack-horizon | 15:21 | |
| *** ruoyu has joined #openstack-horizon | 15:21 | |
| *** tosky has quit IRC | 15:22 | |
| *** fedruantine_ has quit IRC | 15:30 | |
| rdopiera | robcresswell: the way I see it, whichever way we go, it's going to be painful | 15:36 |
| robcresswell | rdopiera: I think I have a solution that is not too bad locally. I'm just poking it with sticks | 15:37 |
| rdopiera | robcresswell: so lets to the simplest thing that could possibly work, and let people handle special cases themselves, and when we have a better understanding and more actual use cases, we can replace it with something horrible | 15:37 |
| robcresswell | rdopiera: Currently the horrible part is having to test and hard code a version for every microversion feature :( | 15:37 |
| ediardo | o/ | 15:38 |
| rdopiera | robcresswell: aren't most features supported with a >= ? | 15:38 |
| rdopiera | robcresswell: the ones for which you need to downgrade should be rare? | 15:38 |
| robcresswell | rdopiera: *most* yes, but not guaranteed | 15:38 |
| rdopiera | sure, then let people code the exceptions | 15:39 |
| robcresswell | rdopiera: Things can also be supported for a range only | 15:39 |
| robcresswell | rdopiera: That will get hacky, quickly, and break without us knowing | 15:39 |
| rdopiera | do we have exceptions of such features already? | 15:39 |
| rdopiera | or is this just theoretical? | 15:39 |
| rdopiera | s/exceptions/examples | 15:39 |
| robcresswell | There are already features in both cinder and nova that work only for a range | 15:39 |
| rdopiera | sorry | 15:39 |
| robcresswell | grep the codebase and scream | 15:40 |
| rdopiera | I think it's ok to have a hacky code for a hacky thing | 15:40 |
| rdopiera | if that makes majority of the code simpler | 15:40 |
| robcresswell | I don't want Horizon to have to maintain hacky code on top of hacky nova code | 15:40 |
| robcresswell | No, it makes it more complex | 15:40 |
| robcresswell | This way is simple code, but a little more maintenance of feature list | 15:41 |
| rdopiera | I think that coming up with a general solution that handles every possible case would be more complex? | 15:41 |
| *** Marcellin__ has joined #openstack-horizon | 15:41 | |
| robcresswell | No, because you just fix the version for each feature | 15:41 |
| robcresswell | So it can never break, really. | 15:41 |
| rdopiera | ah, but then you create a new client for every call? | 15:41 |
| rdopiera | and a new connection | 15:42 |
| rdopiera | robcresswell: have you seen how they do they microversions in nova api? | 15:42 |
| rdopiera | robcresswell: they have a neat decorator for it | 15:42 |
| robcresswell | rdopiera: Yes, potentially. The design right now has a fixed list per feature, so if the microversion changes on a request it will use a new client | 15:43 |
| robcresswell | Well, decorators are just syntax sugar. I could write a neat decorator too but it doesnt change how shitty the implementation is :) | 15:44 |
| rdopiera | as long as nobody looks... ;) | 15:44 |
| rdopiera | yay! | 15:44 |
| robcresswell | rdopiera: Look at examples like this: http://docs.openstack.org/developer/nova/api_microversion_dev.html#removing-an-api-method | 15:44 |
| rdopiera | I finally squashed the tempest problem with that config patch! | 15:44 |
| rdopiera | robcresswell: did you have a chance to take a look at it? | 15:45 |
| robcresswell | Its in the documentation to only use something between 2.1 and 2.4 for example, horrible. | 15:45 |
| robcresswell | nice one | 15:45 |
| robcresswell | no, not yet, sorry :( | 15:45 |
| rdopiera | no worries, as long as I can guilt-pressure it into reviewing it someday :) | 15:45 |
| rdopiera | s/it/you | 15:45 |
| rdopiera | well, not necessarily a proper review | 15:46 |
| rdopiera | just comments on the approach, etc. | 15:46 |
| *** dave-mccowan has quit IRC | 15:46 | |
| *** udesale has quit IRC | 15:47 | |
| robcresswell | haha, yes its on my list, but then all of a sudden microversions and everyone decided to solve it without talking to each other | 15:48 |
| rdopiera | that's the best way | 15:48 |
| robcresswell | so now im doing magic implementation no.4 to fix the myriad implementations <insert relevant xkcd> | 15:48 |
| rdopiera | right after a staring contest, that is | 15:48 |
| rdopiera | by the way, that tempest-horizon failed legitimately | 15:50 |
| rdopiera | and no other test caught that problem | 15:50 |
| robcresswell | :D | 15:50 |
| robcresswell | go temepst | 15:50 |
| rdopiera | so I think it is useful after all | 15:50 |
| robcresswell | tempest* | 15:50 |
| rdopiera | though it was difficult to figure out why it was failing | 15:50 |
| robcresswell | rdopiera: What was the cause of the failure? | 15:54 |
| SamYaple | Hello. "Create New Volume" seems to be set to yes by default in Newton. How can I set that to "no" by default? | 15:55 |
| rdopiera | robcresswell: I was handling the default values for stuff like LOGIN_URL, etc. in the defaults for the conf file, but the python config, which gets loaded afterwards, changed WEBROOT | 15:55 |
| robcresswell | SamYaple: IIRC there's no way to change it without editing source | 15:56 |
| rdopiera | robcresswell: I had to put back the code that sets the values for LOGIN_URL, etc. based on the WEBROOT back in the settings.py | 15:56 |
| *** tobberyd_ has joined #openstack-horizon | 15:56 | |
| SamYaple | wow. really? that seems really bad. Thats really messed up some workflows causing lots of cinder volume confusion | 15:56 |
| SamYaple | any reason that was changed to be a default? | 15:57 |
| *** _ducttape_ has joined #openstack-horizon | 15:57 | |
| robcresswell | SamYaple: https://github.com/openstack/horizon/blob/e6647d4a0a176ddea82f44faae3cbce239ef69a6/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js#L406 | 15:57 |
| *** GMAzrael has joined #openstack-horizon | 15:58 | |
| GMAzrael | Anyone familiar with idle timeouts and NoVNC? | 15:58 |
| robcresswell | SamYaple: Feedback from others that making it default made more sense | 15:58 |
| SamYaple | robcresswell: thanks for the link. perhaps this could be made configurable? I am not familiar enough with horizon to know if that is easy to do | 15:59 |
| SamYaple | robcresswell: and thanks for the link | 15:59 |
| SamYaple | oh i said that :) | 15:59 |
| *** tobberydberg has quit IRC | 15:59 | |
| *** ducttape_ has quit IRC | 16:00 | |
| *** tobberyd_ has quit IRC | 16:00 | |
| robcresswell | SamYaple: Its fairly trivial, but not high on my list | 16:01 |
| *** jlopezgu_ has joined #openstack-horizon | 16:02 | |
| robcresswell | Best bet for a quick fix is just to modify the source. Or click No on that selection. | 16:02 |
| robcresswell | patches welcome too, of course :) | 16:03 |
| rdopiera | SamYaple: if you submit a patch, the reviewers will help you get it into a state in which it can be merged | 16:03 |
| *** sacharya has joined #openstack-horizon | 16:04 | |
| *** sacharya has quit IRC | 16:08 | |
| robcresswell | rdopiera: Mind if I adopt your version patch code? | 16:09 |
| rdopiera | robcresswell: go ahead | 16:10 |
| robcresswell | \o/ | 16:10 |
| rdopiera | I think all the clients have a similar thing in them | 16:10 |
| robcresswell | They do | 16:10 |
| rdopiera | like novaclient.api_versions.APIVersion() | 16:10 |
| robcresswell | Annoyingly its not standard, so will be difficult to rely upon I think | 16:10 |
| robcresswell | Yeah, thats what I am currently using | 16:11 |
| rdopiera | maybe it's something to put in oslo? | 16:11 |
| robcresswell | it might be covered by versionedobject | 16:11 |
| robcresswell | idk | 16:11 |
| *** Pavo has quit IRC | 16:12 | |
| robcresswell | actually, the clients themselves will probably expect those objects, rather than a string | 16:13 |
| robcresswell | hmmm | 16:13 |
| *** Pavo has joined #openstack-horizon | 16:13 | |
| rdopiera | they don't accept strings too? | 16:13 |
| *** rcernin has quit IRC | 16:14 | |
| robcresswell | back into the source I go... | 16:14 |
| openstackgerrit | Ankur proposed openstack/horizon: Add Reset-State Action for Admins https://review.openstack.org/315630 | 16:16 |
| *** dave-mccowan has joined #openstack-horizon | 16:17 | |
| *** zackf has joined #openstack-horizon | 16:18 | |
| robcresswell | rdopiera: https://github.com/openstack/python-novaclient/blob/master/novaclient/api_versions.py#L326 | 16:20 |
| robcresswell | So, yeah, if thats just a string it will explode | 16:20 |
| rdopiera | so we need a separate wrapper for every client? | 16:21 |
| robcresswell | :( | 16:21 |
| rdopiera | or we could add a get_string method to our Version object | 16:22 |
| rdopiera | and every other method that is necessary | 16:22 |
| rdopiera | as long as the implementations are not inconsistent... | 16:22 |
| robcresswell | and hope that Cinder also use get_string | 16:22 |
| *** weezS has joined #openstack-horizon | 16:22 | |
| rdopiera | if they use semthing else, that;s not a problem | 16:22 |
| *** zackf has quit IRC | 16:22 | |
| rdopiera | a problem would be if it used the same method, but expected it to return something else... | 16:22 |
| robcresswell | No, its just extra hack to have a mnethod for each service | 16:23 |
| robcresswell | I wonder if it might be safer to just use each services APIVersion wrapper | 16:23 |
| *** Foxlik1 has quit IRC | 16:24 | |
| *** zackf has joined #openstack-horizon | 16:26 | |
| rdopiera | or wrap them to accept strings | 16:26 |
| rdopiera | this should really be in oslo | 16:27 |
| rdopiera | possible together with the whole microversion handling | 16:27 |
| robcresswell | yes, yes it should | 16:27 |
| *** zackf has quit IRC | 16:30 | |
| *** zackf has joined #openstack-horizon | 16:30 | |
| *** mvk has quit IRC | 16:32 | |
| *** _ducttape_ has quit IRC | 16:32 | |
| *** ducttape_ has joined #openstack-horizon | 16:33 | |
| *** chlong has quit IRC | 16:45 | |
| *** rcernin has joined #openstack-horizon | 16:46 | |
| openstackgerrit | Richard Hagarty proposed openstack/horizon: Add microversion support for consistency groups https://review.openstack.org/410860 | 16:51 |
| *** alexvictorchan has joined #openstack-horizon | 16:52 | |
| rdopiera | rhagarty: are you here? | 16:53 |
| rhagarty | rdopiera: yes, what's up? | 16:54 |
| *** ctayal has joined #openstack-horizon | 16:54 | |
| *** yamamoto has quit IRC | 16:55 | |
| robcresswell | rhagarty: We've got like 3/4 different version patches now | 16:56 |
| robcresswell | Please don't work in isolation :( | 16:57 |
| *** yamamoto has joined #openstack-horizon | 16:57 | |
| rhagarty | robcresswell: agreed... wasn't aware | 16:58 |
| *** chlong has joined #openstack-horizon | 16:58 | |
| *** TravT has joined #openstack-horizon | 16:58 | |
| *** ChanServ sets mode: +v TravT | 16:58 | |
| rhagarty | robcresswell: just got in, so looking at comments now... | 16:59 |
| *** piet has joined #openstack-horizon | 16:59 | |
| robcresswell | There's a few things, like it seems like you're using ranges again, which we've decided not to do | 17:00 |
| robcresswell | I'm just finishing up my local patch too, so we can see what works best | 17:00 |
| rhagarty | ok - I will wait for that... | 17:01 |
| *** yamamoto has quit IRC | 17:02 | |
| *** Zer0Byte__ has joined #openstack-horizon | 17:03 | |
| rdopiera | robcresswell: by the way, I wonder if we could put the feature-version mapping in the client itself | 17:03 |
| rdopiera | robcresswell: and have the project's devs maintain it | 17:03 |
| *** piet has quit IRC | 17:05 | |
| *** sacharya has joined #openstack-horizon | 17:05 | |
| *** GMAzrael has quit IRC | 17:11 | |
| *** edtubill has joined #openstack-horizon | 17:14 | |
| *** jpich has quit IRC | 17:18 | |
| *** tqtran has joined #openstack-horizon | 17:21 | |
| rhagarty | robcresswell: so how to proceed? I think cinder provides a good POC env - we have a feature added in mv 3.11 and another going away post 3.11 | 17:29 |
| *** weezS has quit IRC | 17:42 | |
| *** piet has joined #openstack-horizon | 17:45 | |
| *** ctayal has quit IRC | 17:51 | |
| *** tosky has joined #openstack-horizon | 17:54 | |
| *** yamamoto has joined #openstack-horizon | 17:56 | |
| *** Jeffrey4l has quit IRC | 17:58 | |
| *** mvandijk has left #openstack-horizon | 17:59 | |
| *** yamamoto has quit IRC | 18:01 | |
| robcresswell | rhagarty: I'll get my patch up once I finish documenting and testing | 18:03 |
| robcresswell | rhagarty: Should be next 24 hrs | 18:03 |
| robcresswell | I think it is fairly complete now in adding nova/cinder support in a fairly clean way. | 18:04 |
| *** jlopezgu_ has quit IRC | 18:04 | |
| robcresswell | rhagarty: Cinder client v2 is gone right? We should just use v3? | 18:05 |
| rhagarty | still supported | 18:06 |
| robcresswell | ack | 18:07 |
| rhagarty | yeah, it would make life easier (and cleaner) | 18:10 |
| *** Pavo has quit IRC | 18:12 | |
| *** Pavo has joined #openstack-horizon | 18:17 | |
| *** david-lyle has quit IRC | 18:21 | |
| *** yamamoto has joined #openstack-horizon | 18:26 | |
| *** yamamoto has quit IRC | 18:27 | |
| *** yamamoto has joined #openstack-horizon | 18:27 | |
| *** yamamoto has quit IRC | 18:27 | |
| *** david-lyle has joined #openstack-horizon | 18:30 | |
| *** ChanServ sets mode: +o david-lyle | 18:30 | |
| *** ctayal has joined #openstack-horizon | 18:31 | |
| *** piet has quit IRC | 18:31 | |
| *** ruoyu has quit IRC | 18:38 | |
| *** ducttape_ has quit IRC | 18:39 | |
| *** jprovazn has quit IRC | 18:48 | |
| *** ducttape_ has joined #openstack-horizon | 18:50 | |
| *** wolverineav has quit IRC | 18:55 | |
| *** tosky has quit IRC | 19:00 | |
| *** weezS has joined #openstack-horizon | 19:01 | |
| *** wolverineav has joined #openstack-horizon | 19:02 | |
| *** wolverin_ has joined #openstack-horizon | 19:06 | |
| *** wolverineav has quit IRC | 19:06 | |
| *** stupidnic has quit IRC | 19:16 | |
| *** stupidnic has joined #openstack-horizon | 19:18 | |
| *** ctayal_ has joined #openstack-horizon | 19:25 | |
| *** ctayal has quit IRC | 19:27 | |
| *** yamamoto has joined #openstack-horizon | 19:28 | |
| *** ctayal has joined #openstack-horizon | 19:29 | |
| *** wolverin_ has quit IRC | 19:29 | |
| *** ctayal_ has quit IRC | 19:32 | |
| *** yamamoto has quit IRC | 19:36 | |
| openstackgerrit | Merged openstack/horizon: Replace six.iteritems(iter) with iter.items() https://review.openstack.org/409615 | 19:47 |
| *** gugl has joined #openstack-horizon | 19:50 | |
| r1chardj0n3s | morning o/ | 19:52 |
| *** TravT has quit IRC | 19:52 | |
| r1chardj0n3s | Horizon weekly meeting in 8 minutes in #openstack-meeting-3 | 19:53 |
| *** TravT has joined #openstack-horizon | 19:56 | |
| *** ChanServ sets mode: +v TravT | 19:56 | |
| r1chardj0n3s | this thing has now started ^^ :-) | 20:01 |
| *** ruoyu has joined #openstack-horizon | 20:07 | |
| *** Pavo has quit IRC | 20:12 | |
| *** Pavo has joined #openstack-horizon | 20:17 | |
| *** ruoyu has quit IRC | 20:19 | |
| *** ruoyu has joined #openstack-horizon | 20:19 | |
| *** ruoyu has quit IRC | 20:23 | |
| *** ctayal has quit IRC | 20:26 | |
| *** ruoyu has joined #openstack-horizon | 20:30 | |
| *** TravT has quit IRC | 20:31 | |
| *** pcaruana has quit IRC | 20:33 | |
| *** TravT has joined #openstack-horizon | 20:37 | |
| *** ChanServ sets mode: +v TravT | 20:37 | |
| *** tobberydberg has joined #openstack-horizon | 20:39 | |
| *** clu_ has joined #openstack-horizon | 20:40 | |
| *** ChanServ sets mode: +v clu_ | 20:40 | |
| r1chardj0n3s | good meeting, thanks all! | 20:45 |
| rdopiera | on my last project, our mascot was a house fly | 20:45 |
| r1chardj0n3s | ... because? | 20:46 |
| rdopiera | so doge is an improvemtn | 20:46 |
| rdopiera | r1chardj0n3s: because it was called Ralph | 20:46 |
| r1chardj0n3s | ... ok :-) | 20:46 |
| *** mvk has joined #openstack-horizon | 20:46 | |
| rdopiera | r1chardj0n3s: after a character from Lord of Flies | 20:46 |
| r1chardj0n3s | ahh! | 20:47 |
| rdopiera | I wanted to use a dead pig's head | 20:48 |
| rdopiera | but was overruled | 20:49 |
| ducttape_ | we have a manager we call "lord of the flies" around here | 20:49 |
| r1chardj0n3s | you guys have the funnest workplaces | 20:49 |
| *** _ducttape_ has joined #openstack-horizon | 20:58 | |
| robcresswell | http://www.abc.net.au/news/image/1086698-3x2-940x627.jpg | 21:00 |
| robcresswell | r1chardj0n3s: ^^ still makes me laugh | 21:00 |
| *** ducttape_ has quit IRC | 21:02 | |
| r1chardj0n3s | haha, yeah, it's a shame it's fake ;-) | 21:02 |
| r1chardj0n3s | though "catastrophic" is waaay better than the actual "code red" | 21:02 |
| r1chardj0n3s | since the previous danger level is also red | 21:02 |
| *** tobberydberg has quit IRC | 21:06 | |
| *** weezS has quit IRC | 21:08 | |
| openstackgerrit | Merged openstack/horizon: Text and checkbox should align in "Create Project" form https://review.openstack.org/409804 | 21:08 |
| *** _ducttape_ has quit IRC | 21:09 | |
| robcresswell | Hmm, that looks like a CSS hack... | 21:10 |
| *** ducttape_ has joined #openstack-horizon | 21:10 | |
| *** ying_zuo_ has joined #openstack-horizon | 21:13 | |
| *** ying_zuo_ has quit IRC | 21:15 | |
| *** ianychoi has quit IRC | 21:28 | |
| *** erlon has quit IRC | 21:30 | |
| *** adriant has joined #openstack-horizon | 21:39 | |
| *** itisha has quit IRC | 21:42 | |
| *** betherly_ has quit IRC | 21:51 | |
| *** weezS has joined #openstack-horizon | 22:01 | |
| *** jtriley has quit IRC | 22:07 | |
| *** aortega has quit IRC | 22:09 | |
| *** lblanchard has quit IRC | 22:10 | |
| *** Pavo has quit IRC | 22:12 | |
| *** Pavo has joined #openstack-horizon | 22:17 | |
| *** edtubill has quit IRC | 22:26 | |
| *** ctayal has joined #openstack-horizon | 22:34 | |
| *** jdwald has quit IRC | 22:34 | |
| *** alexvictorchan has quit IRC | 22:35 | |
| *** ruoyu has quit IRC | 22:39 | |
| *** ruoyu has joined #openstack-horizon | 22:39 | |
| *** aortega has joined #openstack-horizon | 22:49 | |
| openstackgerrit | Victoria Martinez de la Cruz proposed openstack/manila-ui: Only show available share protocols on share creation modal https://review.openstack.org/372805 | 22:50 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: NG Flavor Panel add filter facets https://review.openstack.org/366957 | 22:50 |
| *** ducttape_ has quit IRC | 22:51 | |
| *** ruoyu has quit IRC | 22:52 | |
| *** ruoyu has joined #openstack-horizon | 22:54 | |
| *** dave-mccowan has quit IRC | 22:56 | |
| *** ruoyu has quit IRC | 22:57 | |
| *** ruoyu has joined #openstack-horizon | 22:57 | |
| *** ruoyu has quit IRC | 22:59 | |
| *** ruoyu has joined #openstack-horizon | 22:59 | |
| *** alexvictorchan has joined #openstack-horizon | 23:00 | |
| *** ruoyu has quit IRC | 23:04 | |
| *** rcernin has quit IRC | 23:05 | |
| *** mtanino has quit IRC | 23:15 | |
| *** mtanino has joined #openstack-horizon | 23:15 | |
| *** dave-mccowan has joined #openstack-horizon | 23:15 | |
| *** aortega has quit IRC | 23:16 | |
| *** ruoyu has joined #openstack-horizon | 23:18 | |
| *** ruoyu_ has joined #openstack-horizon | 23:20 | |
| *** ruoyu has quit IRC | 23:20 | |
| *** ruoyu has joined #openstack-horizon | 23:22 | |
| *** ruoyu__ has joined #openstack-horizon | 23:23 | |
| *** ducttape_ has joined #openstack-horizon | 23:24 | |
| *** ianychoi has joined #openstack-horizon | 23:25 | |
| *** ruoyu_ has quit IRC | 23:25 | |
| *** ruoyu has quit IRC | 23:26 | |
| *** dave-mccowan has quit IRC | 23:27 | |
| *** ruoyu__ has quit IRC | 23:28 | |
| *** ruoyu has joined #openstack-horizon | 23:31 | |
| *** ruoyu_ has joined #openstack-horizon | 23:32 | |
| *** ruoyu__ has joined #openstack-horizon | 23:34 | |
| *** ruoyu has quit IRC | 23:35 | |
| *** ruoyu_ has quit IRC | 23:36 | |
| *** chlong has quit IRC | 23:37 | |
| *** ruoyu__ has quit IRC | 23:38 | |
| *** ppiela has quit IRC | 23:51 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
