| *** ZZelle has quit IRC | 00:04 | |
| *** wolverin_ has quit IRC | 00:09 | |
| *** mtanino has joined #openstack-horizon | 00:14 | |
| *** wolverineav has joined #openstack-horizon | 00:18 | |
| *** jlopezgu has quit IRC | 00:21 | |
| *** aortega has quit IRC | 00:22 | |
| *** wolverineav has quit IRC | 00:22 | |
| *** amotoki has joined #openstack-horizon | 00:26 | |
| *** catintheroof has joined #openstack-horizon | 00:35 | |
| *** mine0901 has joined #openstack-horizon | 00:36 | |
| *** zul has quit IRC | 00:36 | |
| *** wolverineav has joined #openstack-horizon | 00:38 | |
| *** mtanino has quit IRC | 00:39 | |
| *** gyee_ has quit IRC | 00:40 | |
| *** zul has joined #openstack-horizon | 00:41 | |
| *** wolverineav has quit IRC | 00:42 | |
| *** ppiela has quit IRC | 00:46 | |
| *** ppiela has joined #openstack-horizon | 00:47 | |
| *** ppiela has quit IRC | 00:54 | |
| *** ppiela has joined #openstack-horizon | 00:55 | |
| *** catintheroof has quit IRC | 01:08 | |
| *** yamamoto has joined #openstack-horizon | 01:12 | |
| *** jamielennox is now known as jamielennox|away | 01:16 | |
| *** jamielennox|away is now known as jamielennox | 01:28 | |
| *** JDub has joined #openstack-horizon | 01:48 | |
| *** JDub has quit IRC | 01:56 | |
| *** zhurong has joined #openstack-horizon | 01:57 | |
| *** pramodrj07 has joined #openstack-horizon | 01:59 | |
| *** pramodrj07 has quit IRC | 02:01 | |
| *** MasterOfBugs has quit IRC | 02:02 | |
| *** mine0901 has quit IRC | 02:37 | |
| *** yamamoto has quit IRC | 02:41 | |
| openstackgerrit | fengzhr proposed openstack/horizon master: Fix the bug in 'Delete Extra Spec' https://review.openstack.org/447765 | 02:46 |
|---|---|---|
| *** yamamoto has joined #openstack-horizon | 02:48 | |
| *** zhurong has quit IRC | 03:05 | |
| *** zhurong has joined #openstack-horizon | 03:22 | |
| *** yamamoto has quit IRC | 03:25 | |
| *** dave-mccowan has quit IRC | 03:29 | |
| adriant | r1chardj0n3s, you around by chance? | 03:34 |
| r1chardj0n3s | adriant: yep | 03:35 |
| adriant | Sweet, let me paste this somewhere, and get your input. | 03:35 |
| adriant | I asked you ages ago if there was a good way to do this... and in the end I couldn't find a better solution: | 03:36 |
| adriant | http://paste.openstack.org/show/603553/ | 03:36 |
| adriant | Basically, for this service and panel I needed to add some extra root urls to the openstack_dashboard and I found that I could do it at the urls.py for the panel that needs them | 03:37 |
| adriant | I tried doing it in the enable file, but that occurs too early in the import process so the urlpatterns value isn't there yet. | 03:38 |
| adriant | how terrible of a hack is that? | 03:38 |
| adriant | the goal being to from the scope of a plugin, add a couple of lines here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/urls.py#L35-L39 | 03:39 |
| adriant | my hack 'appears' to work, but I notice in the debug view for django on 404 it does silly things: http://i.imgur.com/qGlLV5W.png | 03:41 |
| r1chardj0n3s | adriant: it's not a terrible hack if it works :-) | 03:41 |
| adriant | see above ^ :P | 03:41 |
| r1chardj0n3s | right. that's odd, yes | 03:42 |
| adriant | I don't 'think' I've broken any of the other url paths, but it looks very odd | 03:42 |
| r1chardj0n3s | sorry, I don't have any particular insight into monkeypatching URL confs | 03:42 |
| adriant | Who can I bug that knows the horizon panel url loading logic fairly well? | 03:43 |
| adriant | I've tried looking through it, but it is quite confusing | 03:43 |
| r1chardj0n3s | I can't think of anyone really - it might be something to bring up in either the mailing list or at the weekly meeting (tho there isn't one this week because Rob's on vacation) | 03:43 |
| adriant | At this point though I'm thinking, if I can confirm the hack doesn't break anything, go forward with it :) | 03:43 |
| *** MarkMielke has joined #openstack-horizon | 03:45 | |
| adriant | It might be worth seeing if a mechanism for loading such views is something you'd be willing to introduce to horizon, as I'm sure the ability to add public pre-login views might be useful (is there anything like that?). | 03:45 |
| r1chardj0n3s | I'm not aware of anything like that, no. And sure, if it's not possible to do without extending Horizon I can't see a problem with a BP being proposed to do it. | 03:45 |
| r1chardj0n3s | I'm not sure the BP would have broad enough appeal to implement, but we can only see. | 03:46 |
| adriant | Particularly one thing I'd love to also do is a signup form in horizon, but I'd hack to monkey patch it the same way i'm currently doing it. | 03:46 |
| adriant | ugh, english | 03:46 |
| adriant | I'd need to use the same hackish monkey patching | 03:46 |
| adriant | a less hacky mechanism would be preferred :) | 03:47 |
| r1chardj0n3s | yeah | 03:47 |
| adriant | Ok, will blueprint it, and provide some examples. | 03:47 |
| adriant | thanks! | 03:47 |
| r1chardj0n3s | cool, and don't forget to bring the blueprint up in a weekly meeting or on the mailing list! | 03:48 |
| adriant | shall do :) | 03:49 |
| MarkMielke | newbie contributor question: I am new to the community and trying to understand and have the right expectations around the workload of the core review team, and the workflow itself... | 03:52 |
| MarkMielke | I have two changes in Gerrit, the Horizon one is: https://review.openstack.org/#/c/444091/ | 03:52 |
| MarkMielke | if it's +1 by non-core review, do i need to do anything to get attention of core to merge? | 03:53 |
| MarkMielke | or just wait patiently for my turn? :-) | 03:53 |
| MarkMielke | thanks | 03:53 |
| r1chardj0n3s | MarkMielke: cores are overworked, basically. there's really only two of us fully active at the moment, and even then I've been distracted in the last week, sadly, but I'm still trying to get through the backlog | 03:53 |
| MarkMielke | ok no problem .. me too (overworked) | 03:54 |
| r1chardj0n3s | sorry that doesn't really help you get your patches mergerd :/ | 03:54 |
| MarkMielke | is this particular to Horizon or would this be true of Nova too? | 03:54 |
| r1chardj0n3s | MarkMielke: I believe most OpenStack projects are currently suffering from a reduction in cores | 03:54 |
| MarkMielke | i mostly just want some confidence that i haven't missed a step | 03:54 |
| MarkMielke | and it's just time needed | 03:55 |
| MarkMielke | it sounds like this is the case | 03:55 |
| r1chardj0n3s | MarkMielke: so in the specific case of your patch, it's well-written, but would require one of the two cores to go and research the specific glance features enough to have confidence in the patch. We're not glance experts (or nova, or cinder, or ...) That's the basic burden overhead for Horizon patches, unfortunately ;-) | 03:56 |
| MarkMielke | right | 03:56 |
| r1chardj0n3s | (and unfortunately we have an army of superficial +1'ers out there that we can't really use as solid reviews :/ ) | 03:56 |
| MarkMielke | haha nice and agree | 03:57 |
| MarkMielke | both -1 and +1 | 03:57 |
| r1chardj0n3s | if there was a glance expert who could chime in specifically attesting to the goodness of the patch, that'd help :-) | 03:57 |
| r1chardj0n3s | not even an expert, just someone who knows the feature in question | 03:57 |
| r1chardj0n3s | anyhoo, enough chit-chat, back to JS test errors | 03:58 |
| openstackgerrit | Richard Jones proposed openstack/horizon master: Expose more of Swift to ResourceType https://review.openstack.org/348741 | 03:59 |
| *** yamamoto has joined #openstack-horizon | 04:09 | |
| *** jamielennox is now known as jamielennox|away | 04:12 | |
| *** zhurong has quit IRC | 04:12 | |
| *** shu-mutou-AWAY is now known as shu-mutou | 04:15 | |
| openstackgerrit | Merged openstack/horizon master: In drawer, handle 'priority' attribute conversely against row https://review.openstack.org/413462 | 04:36 |
| openstackgerrit | Merged openstack/horizon master: Use ThemableSelectWidget for themable https://review.openstack.org/440978 | 04:41 |
| openstackgerrit | Merged openstack/horizon master: Allow to specify port security when creating a port https://review.openstack.org/444596 | 04:41 |
| *** udesale has joined #openstack-horizon | 04:50 | |
| *** zhurong has joined #openstack-horizon | 05:00 | |
| openstackgerrit | Merged openstack/horizon master: Add the 'fade' class to Python modals, for animation https://review.openstack.org/440603 | 05:02 |
| *** udesale has quit IRC | 05:03 | |
| *** udesale has joined #openstack-horizon | 05:06 | |
| *** udesale has quit IRC | 05:09 | |
| *** udesale has joined #openstack-horizon | 05:09 | |
| *** ratailor has joined #openstack-horizon | 05:13 | |
| *** zhurong has quit IRC | 05:40 | |
| *** rcernin has joined #openstack-horizon | 05:43 | |
| *** rcernin has quit IRC | 05:57 | |
| openstackgerrit | Merged openstack/horizon master: hacking: Drop import_exceptions from tox.ini https://review.openstack.org/447113 | 05:58 |
| *** udesale has quit IRC | 06:06 | |
| *** udesale has joined #openstack-horizon | 06:07 | |
| *** zackf has joined #openstack-horizon | 06:07 | |
| *** masco has joined #openstack-horizon | 06:11 | |
| *** zackf has quit IRC | 06:11 | |
| *** wangbo has joined #openstack-horizon | 06:13 | |
| *** adriant has quit IRC | 06:14 | |
| *** jprovazn has joined #openstack-horizon | 06:16 | |
| *** mine0901 has joined #openstack-horizon | 06:49 | |
| openstackgerrit | Shu Muto proposed openstack/ui-cookiecutter master: Use detailRoute constant for path of details view https://review.openstack.org/447890 | 06:50 |
| *** wangbo has quit IRC | 06:56 | |
| *** wangbo has joined #openstack-horizon | 06:56 | |
| *** amotoki_ has joined #openstack-horizon | 07:00 | |
| *** zackf has joined #openstack-horizon | 07:02 | |
| *** david-lyle has quit IRC | 07:02 | |
| *** amotoki has quit IRC | 07:03 | |
| *** zackf has quit IRC | 07:06 | |
| *** amotoki has joined #openstack-horizon | 07:18 | |
| *** amotoki_ has quit IRC | 07:21 | |
| *** jtomasek has quit IRC | 07:23 | |
| *** wangbo has quit IRC | 07:29 | |
| *** wangbo has joined #openstack-horizon | 07:30 | |
| *** tesseract has joined #openstack-horizon | 07:35 | |
| *** itxaka has joined #openstack-horizon | 07:41 | |
| openstackgerrit | Spencer Yu proposed openstack/manila-ui master: Fix oslo_debug_helper in tox.ini https://review.openstack.org/436901 | 07:46 |
| *** pcaruana has joined #openstack-horizon | 08:11 | |
| *** shu-mutou is now known as shu-mutou-AWAY-u | 08:11 | |
| *** shu-mutou-AWAY-u is now known as shu-mutou-AWAY | 08:12 | |
| *** jprovazn has quit IRC | 08:17 | |
| *** jprovazn has joined #openstack-horizon | 08:18 | |
| *** jprovazn has quit IRC | 08:24 | |
| -openstackstatus- NOTICE: Wiki is broken with database problems, we are working to resolve it | 08:30 | |
| *** ChanServ changes topic to "Wiki is broken with database problems, we are working to resolve it" | 08:30 | |
| *** jpich has joined #openstack-horizon | 08:34 | |
| *** zhurong has joined #openstack-horizon | 08:34 | |
| *** jprovazn has joined #openstack-horizon | 08:37 | |
| *** ChanServ changes topic to "Pike-1 Milestone: https://launchpad.net/horizon/+milestone/pike-1" | 08:39 | |
| -openstackstatus- NOTICE: Wiki problems have been fixed, it's up and running | 08:39 | |
| *** amoralej|off is now known as amoralej | 08:41 | |
| *** zackf has joined #openstack-horizon | 08:52 | |
| *** zackf has quit IRC | 08:57 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** openstackgerrit has joined #openstack-horizon | 09:10 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Add Microversion support to Horizon https://review.openstack.org/411919 | 09:10 |
| *** mvk has quit IRC | 09:17 | |
| *** VAhl has quit IRC | 09:24 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Fix issues with updating project/domain members https://review.openstack.org/192456 | 09:24 |
| *** aortega has joined #openstack-horizon | 09:39 | |
| *** aortega has quit IRC | 09:41 | |
| *** jtomasek has joined #openstack-horizon | 09:42 | |
| *** tosky has joined #openstack-horizon | 09:54 | |
| *** udesale has quit IRC | 09:57 | |
| *** mvk has joined #openstack-horizon | 09:58 | |
| *** zhurong has quit IRC | 10:05 | |
| *** amotoki has quit IRC | 10:17 | |
| *** udesale has joined #openstack-horizon | 10:21 | |
| *** zhurong has joined #openstack-horizon | 10:24 | |
| *** jamielennox|away is now known as jamielennox | 10:30 | |
| *** zackf has joined #openstack-horizon | 10:42 | |
| *** zackf has quit IRC | 10:47 | |
| *** wolverineav has joined #openstack-horizon | 10:48 | |
| *** wolverineav has quit IRC | 10:53 | |
| *** udesale has quit IRC | 10:54 | |
| *** faizy has joined #openstack-horizon | 10:56 | |
| *** faizy has quit IRC | 10:59 | |
| *** faizy has joined #openstack-horizon | 11:00 | |
| *** udesale has joined #openstack-horizon | 11:02 | |
| *** wolverineav has joined #openstack-horizon | 11:04 | |
| *** jamielennox is now known as jamielennox|away | 11:05 | |
| *** wolverineav has quit IRC | 11:09 | |
| *** mgould|afk is now known as mgould | 11:09 | |
| *** jamielennox|away is now known as jamielennox | 11:12 | |
| *** mvk has quit IRC | 11:12 | |
| *** wolverineav has joined #openstack-horizon | 11:16 | |
| *** udesale has quit IRC | 11:18 | |
| *** udesale has joined #openstack-horizon | 11:18 | |
| *** wolverineav has quit IRC | 11:21 | |
| *** faizy_ has joined #openstack-horizon | 11:24 | |
| *** mvk has joined #openstack-horizon | 11:25 | |
| *** faizy has quit IRC | 11:25 | |
| *** amotoki has joined #openstack-horizon | 11:36 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Add Microversion support to Horizon https://review.openstack.org/411919 | 11:43 |
| *** aortega has joined #openstack-horizon | 11:47 | |
| *** faizy_ has quit IRC | 11:48 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Option to specify MAC address of port https://review.openstack.org/444296 | 12:33 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: New input field with validation: MACAddressField https://review.openstack.org/447028 | 12:33 |
| *** dave-mccowan has joined #openstack-horizon | 12:37 | |
| *** zhurong has quit IRC | 12:39 | |
| *** dave-mccowan has quit IRC | 12:49 | |
| *** ratailor has quit IRC | 12:51 | |
| *** dave-mccowan has joined #openstack-horizon | 12:57 | |
| *** zackf has joined #openstack-horizon | 13:19 | |
| *** amoralej is now known as amoralej|lunch | 13:20 | |
| *** zackf has quit IRC | 13:21 | |
| *** wolverineav has joined #openstack-horizon | 13:23 | |
| *** wolverin_ has joined #openstack-horizon | 13:26 | |
| *** wolverineav has quit IRC | 13:28 | |
| *** jtomasek has quit IRC | 13:29 | |
| *** jtriley has joined #openstack-horizon | 13:29 | |
| *** faizy_ has joined #openstack-horizon | 13:31 | |
| *** faizy__ has joined #openstack-horizon | 13:33 | |
| *** faizy_ has quit IRC | 13:36 | |
| *** jtomasek has joined #openstack-horizon | 13:43 | |
| *** masco has quit IRC | 13:49 | |
| *** faizy__ has quit IRC | 13:51 | |
| *** amoralej|lunch is now known as amoralej | 13:53 | |
| *** lblanchard has joined #openstack-horizon | 13:53 | |
| *** tosky has quit IRC | 13:55 | |
| *** catintheroof has joined #openstack-horizon | 13:57 | |
| *** ZZelle_ has left #openstack-horizon | 13:59 | |
| *** mtanino has joined #openstack-horizon | 13:59 | |
| *** ZZelle has joined #openstack-horizon | 13:59 | |
| *** ZZelle is now known as Guest93672 | 14:00 | |
| *** tosky has joined #openstack-horizon | 14:01 | |
| *** Guest93672 is now known as ZZelle__ | 14:01 | |
| *** ZZelle__ is now known as ZZelle_ | 14:04 | |
| *** jtriley_ has joined #openstack-horizon | 14:07 | |
| *** zackf has joined #openstack-horizon | 14:07 | |
| *** jtriley has quit IRC | 14:10 | |
| *** zackf has quit IRC | 14:12 | |
| *** chlong has joined #openstack-horizon | 14:18 | |
| *** chlong has quit IRC | 14:24 | |
| openstackgerrit | Merged openstack/manila-ui master: Ignore current share's size in extend quota bar https://review.openstack.org/411382 | 14:27 |
| *** vishwanathj has joined #openstack-horizon | 14:36 | |
| *** jtriley_ has quit IRC | 14:49 | |
| *** david-lyle has joined #openstack-horizon | 14:49 | |
| *** ChanServ sets mode: +o david-lyle | 14:49 | |
| *** ratailor has joined #openstack-horizon | 14:51 | |
| *** jtriley has joined #openstack-horizon | 14:52 | |
| *** ratailor has quit IRC | 14:53 | |
| *** belmoreira has joined #openstack-horizon | 14:56 | |
| *** faizy has joined #openstack-horizon | 14:57 | |
| *** dave-mccowan has quit IRC | 15:02 | |
| *** david-lyle has quit IRC | 15:09 | |
| *** faizy has quit IRC | 15:10 | |
| *** faizy has joined #openstack-horizon | 15:11 | |
| *** faizy_ has joined #openstack-horizon | 15:14 | |
| *** david-lyle has joined #openstack-horizon | 15:15 | |
| *** ChanServ sets mode: +o david-lyle | 15:15 | |
| *** faizy__ has joined #openstack-horizon | 15:17 | |
| *** faizy has quit IRC | 15:18 | |
| *** faizy_ has quit IRC | 15:20 | |
| *** faizy__ has quit IRC | 15:21 | |
| *** faizy__ has joined #openstack-horizon | 15:21 | |
| *** dave-mccowan has joined #openstack-horizon | 15:23 | |
| *** faizy__ has quit IRC | 15:24 | |
| *** faizy__ has joined #openstack-horizon | 15:24 | |
| *** faizy__ has quit IRC | 15:26 | |
| *** faizy__ has joined #openstack-horizon | 15:27 | |
| *** faizy__ has quit IRC | 15:29 | |
| *** faizy__ has joined #openstack-horizon | 15:30 | |
| *** jrist has quit IRC | 15:33 | |
| *** jrist has joined #openstack-horizon | 15:40 | |
| *** fixedgary has joined #openstack-horizon | 15:44 | |
| *** udesale has quit IRC | 15:46 | |
| *** pbandark has joined #openstack-horizon | 15:49 | |
| *** fixedgary has quit IRC | 15:51 | |
| *** fixedgary has joined #openstack-horizon | 15:52 | |
| *** ratailor has joined #openstack-horizon | 15:53 | |
| *** pbandark has quit IRC | 15:53 | |
| *** david-lyle has quit IRC | 15:54 | |
| *** jlopezgu has joined #openstack-horizon | 15:56 | |
| openstackgerrit | Aurélien Joga proposed openstack/horizon master: Clarify the comment for WEBSSO_INITIAL_CHOICE https://review.openstack.org/447513 | 15:59 |
| *** ratailor has quit IRC | 16:00 | |
| *** david-lyle has joined #openstack-horizon | 16:01 | |
| *** ChanServ sets mode: +o david-lyle | 16:01 | |
| *** fixedgary has quit IRC | 16:03 | |
| *** fixedgary has joined #openstack-horizon | 16:03 | |
| *** fixedgary has quit IRC | 16:04 | |
| *** amotoki has quit IRC | 16:13 | |
| *** gfhellma has joined #openstack-horizon | 16:14 | |
| *** zackf has joined #openstack-horizon | 16:19 | |
| *** udesale has joined #openstack-horizon | 16:21 | |
| *** belmoreira has quit IRC | 16:25 | |
| *** zackf has quit IRC | 16:26 | |
| rdopiera | david-lyle: do you think you could have a quick look at https://review.openstack.org/192456 ? | 16:37 |
| *** faizy__ has quit IRC | 16:40 | |
| *** jpich has quit IRC | 16:43 | |
| david-lyle | rdopiera, done | 16:43 |
| rdopiera | david-lyle: thank you sir! | 16:43 |
| *** udesale has quit IRC | 16:57 | |
| openstackgerrit | Merged openstack/horizon master: Fix issues with updating project/domain members https://review.openstack.org/192456 | 17:12 |
| *** flwang has quit IRC | 17:27 | |
| *** catintheroof has quit IRC | 17:30 | |
| *** catintheroof has joined #openstack-horizon | 17:30 | |
| *** david-lyle_ has joined #openstack-horizon | 17:37 | |
| *** david-lyle has quit IRC | 17:38 | |
| *** flwang has joined #openstack-horizon | 17:39 | |
| openstackgerrit | Merged openstack/horizon master: Add charts to show volume quotas on Python launch instance modal https://review.openstack.org/390409 | 17:39 |
| *** jtomasek has quit IRC | 17:43 | |
| *** mgould is now known as mgould|afk | 17:52 | |
| *** mtanino has quit IRC | 17:58 | |
| *** markd_ has quit IRC | 18:04 | |
| *** ircuser-1 has quit IRC | 18:07 | |
| *** chasmo77 has quit IRC | 18:07 | |
| *** mtanino has joined #openstack-horizon | 18:11 | |
| *** mvk has quit IRC | 18:18 | |
| *** tesseract has quit IRC | 18:31 | |
| *** Tahvok has left #openstack-horizon | 18:39 | |
| *** pcaruana has quit IRC | 18:39 | |
| *** tosky has quit IRC | 18:40 | |
| *** david-lyle_ has quit IRC | 18:46 | |
| *** mvk has joined #openstack-horizon | 18:53 | |
| *** revon has joined #openstack-horizon | 19:04 | |
| *** aortega has quit IRC | 19:06 | |
| *** jprovazn has quit IRC | 19:10 | |
| *** chlong has joined #openstack-horizon | 19:13 | |
| *** gyee has joined #openstack-horizon | 19:26 | |
| *** MasterOfBugs has joined #openstack-horizon | 19:36 | |
| *** amoralej is now known as amoralej|off | 19:44 | |
| *** MasterOfBugs has quit IRC | 19:52 | |
| *** mpotdar_ has joined #openstack-horizon | 19:57 | |
| *** aortega has joined #openstack-horizon | 20:00 | |
| *** dave-mccowan has quit IRC | 20:02 | |
| *** zackf has joined #openstack-horizon | 20:08 | |
| *** MasterOfBugs has joined #openstack-horizon | 20:11 | |
| *** zackf has quit IRC | 20:12 | |
| *** mine0901 has quit IRC | 20:17 | |
| *** zackf has joined #openstack-horizon | 20:20 | |
| *** chlong has quit IRC | 20:21 | |
| *** zackf has quit IRC | 20:24 | |
| *** dave-mccowan has joined #openstack-horizon | 20:33 | |
| *** mpotdar_ has quit IRC | 20:38 | |
| *** aortega has quit IRC | 20:39 | |
| *** chlong has joined #openstack-horizon | 20:48 | |
| *** zackf has joined #openstack-horizon | 20:49 | |
| *** zackf has quit IRC | 20:54 | |
| gugl | Hi folks...quick question....I am able to run_tests.sh...but have some problem run tox...any special set-up before tox? I followed https://docs.openstack.org/developer/horizon/testing.html | 20:58 |
| *** zackf has joined #openstack-horizon | 20:58 | |
| *** zackf has quit IRC | 21:02 | |
| *** zackf has joined #openstack-horizon | 21:03 | |
| r1chardj0n3s | gugl: could you be more specific about what "some problem" is please? | 21:05 |
| *** zackf has quit IRC | 21:07 | |
| *** aortega has joined #openstack-horizon | 21:10 | |
| *** lblanchard has quit IRC | 21:10 | |
| *** david-lyle has joined #openstack-horizon | 21:23 | |
| *** ChanServ sets mode: +o david-lyle | 21:23 | |
| *** jtriley has quit IRC | 21:25 | |
| *** itxaka has quit IRC | 21:26 | |
| *** zackf has joined #openstack-horizon | 21:26 | |
| *** gugl has quit IRC | 21:29 | |
| *** zackf has quit IRC | 21:31 | |
| *** Jeffrey4l_ has quit IRC | 21:35 | |
| *** ircuser-1 has joined #openstack-horizon | 21:39 | |
| *** chasmo77 has joined #openstack-horizon | 21:41 | |
| *** Jeffrey4l_ has joined #openstack-horizon | 21:48 | |
| *** catintheroof has quit IRC | 21:57 | |
| *** catintheroof has joined #openstack-horizon | 21:58 | |
| *** catintheroof has quit IRC | 21:58 | |
| *** zackf has joined #openstack-horizon | 22:10 | |
| eandersson | Hey | 22:12 |
| eandersson | Maybe I am being silly... but this code https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/glance.py#L349 | 22:13 |
| eandersson | is never hit if Glance version is 2 or higher https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/glance.py#L443 | 22:13 |
| eandersson | Which means that the temporary file is never removed. | 22:13 |
| r1chardj0n3s | eandersson: could you explain a your theory a little more? | 22:14 |
| eandersson | Well we ran into an issue where the tmp folder would have a ton of old *.upload files. | 22:14 |
| *** zackf has quit IRC | 22:15 | |
| eandersson | So I checked the code path our code was taking, and I never see horizon trying to delete the image after it has been uploadd. | 22:15 |
| eandersson | The only place I can see it ever removing the file is in def image_update | 22:15 |
| eandersson | but that code path is never choosen if Glance API version is 2 or higher | 22:15 |
| r1chardj0n3s | oh, image_update isn't called for version 2+? | 22:16 |
| eandersson | Yea | 22:16 |
| eandersson | So my assumption is that anyone with Glance v2 never have the tmp file created removed. | 22:16 |
| r1chardj0n3s | right, API 2+ goes through https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/glance.py#L443 I think? | 22:18 |
| eandersson | Yep | 22:18 |
| r1chardj0n3s | hurm, I can't see why that extra code branch at L443 is even there, why it doesn't always invoke image_update | 22:21 |
| r1chardj0n3s | eandersson: please file a bug | 22:21 |
| eandersson | My guess would be that there are different ways of streaming the data. There is probably one path that does not require a local file. | 22:25 |
| eandersson | Will do | 22:27 |
| *** chlong has quit IRC | 22:27 | |
| r1chardj0n3s | but they code paths in question are essentially the same except one path attempts the remove | 22:27 |
| eandersson | Yep | 22:27 |
| r1chardj0n3s | I am not a glance expert :-) | 22:27 |
| r1chardj0n3s | and I know glance v2+ did strange things around allowing/disallowing file uploads | 22:28 |
| eandersson | Yep | 22:31 |
| eandersson | r1chardj0n3s: To me this is a security concern, as someone could potentially crash a server with this. | 22:48 |
| eandersson | Should I just post it as a "normal" bug? | 22:48 |
| eandersson | btw confirmed that forcing Glance v1 fixes this. | 22:48 |
| eandersson | Anyone with image upload capabilties could just spam upload images until /var/tmp is full. | 22:49 |
| *** adriant has joined #openstack-horizon | 22:52 | |
| r1chardj0n3s | eandersson: it's worth having the security team think about yeah | 22:55 |
| *** david-lyle has quit IRC | 22:57 | |
| *** harlowja has quit IRC | 23:06 | |
| *** gfhellma has quit IRC | 23:26 | |
| *** jtriley has joined #openstack-horizon | 23:32 | |
| *** jamielennox is now known as jamielennox|away | 23:35 | |
| *** mtanino has quit IRC | 23:38 | |
| *** jamielennox|away is now known as jamielennox | 23:39 | |
| *** irtermite has quit IRC | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
