| *** itlinux has joined #openstack-horizon | 00:01 | |
| *** ducttap__ has quit IRC | 00:07 | |
| *** ducttape_ has joined #openstack-horizon | 00:17 | |
| *** ying_zuo has quit IRC | 00:17 | |
| *** yingjun has joined #openstack-horizon | 00:19 | |
| *** ducttape_ has quit IRC | 00:21 | |
| *** ducttape_ has joined #openstack-horizon | 00:22 | |
| *** ducttape_ has quit IRC | 00:27 | |
| *** dave-mccowan has quit IRC | 00:42 | |
| *** vishwanathj has joined #openstack-horizon | 00:43 | |
| *** lucasxu has joined #openstack-horizon | 00:45 | |
| *** lucasxu has quit IRC | 00:45 | |
| *** dave-mccowan has joined #openstack-horizon | 00:46 | |
| *** ducttape_ has joined #openstack-horizon | 01:01 | |
| *** lcastell has quit IRC | 01:08 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon master: [Micro version] Support description for instance https://review.openstack.org/308139 | 01:09 |
|---|---|---|
| *** lcastell has joined #openstack-horizon | 01:11 | |
| *** ducttape_ has quit IRC | 01:12 | |
| *** lcastell has quit IRC | 01:13 | |
| *** lcastell has joined #openstack-horizon | 01:13 | |
| *** ducttape_ has joined #openstack-horizon | 01:17 | |
| *** lcastell has quit IRC | 01:17 | |
| *** ducttape_ has quit IRC | 01:21 | |
| *** Daisy_ has joined #openstack-horizon | 01:33 | |
| *** harlowja has quit IRC | 01:34 | |
| openstackgerrit | Li Yingjun proposed openstack/horizon master: [Micro version] Support description for instance https://review.openstack.org/308139 | 01:36 |
| *** rama_y_ has quit IRC | 01:38 | |
| *** Daisy_ has quit IRC | 01:44 | |
| *** Daisy_ has joined #openstack-horizon | 01:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Updated from global requirements https://review.openstack.org/484550 | 01:46 |
| *** Daisy_ has quit IRC | 01:49 | |
| *** dave-mccowan has quit IRC | 02:02 | |
| *** zhurong has joined #openstack-horizon | 02:05 | |
| *** nikhil_ has joined #openstack-horizon | 02:06 | |
| *** ameade_ has joined #openstack-horizon | 02:06 | |
| *** ankur-gupta-f4_ has joined #openstack-horizon | 02:06 | |
| *** nikhil_ is now known as Guest78669 | 02:06 | |
| *** scottda_ has joined #openstack-horizon | 02:06 | |
| *** lenards_ has joined #openstack-horizon | 02:07 | |
| *** Daisy_ has joined #openstack-horizon | 02:11 | |
| *** v12aml_ has joined #openstack-horizon | 02:12 | |
| *** scottda has quit IRC | 02:13 | |
| *** ankur-gupta-f4 has quit IRC | 02:13 | |
| *** v12aml has quit IRC | 02:13 | |
| *** ameade has quit IRC | 02:13 | |
| *** lenards has quit IRC | 02:13 | |
| *** nikhil has quit IRC | 02:13 | |
| *** glb has quit IRC | 02:13 | |
| *** v12aml_ is now known as v12aml | 02:13 | |
| *** scottda_ is now known as scottda | 02:13 | |
| *** ankur-gupta-f4_ is now known as ankur-gupta-f4 | 02:14 | |
| *** ameade_ is now known as ameade | 02:14 | |
| *** lenards_ is now known as lenards | 02:14 | |
| *** Guest78669 is now known as nikhil | 02:14 | |
| *** ducttape_ has joined #openstack-horizon | 02:15 | |
| *** rhagarty has quit IRC | 02:16 | |
| openstackgerrit | Min Sun proposed openstack/horizon master: Attach/detach volume showed in instance actions when cinder disabled https://review.openstack.org/482406 | 02:18 |
| *** rhagarty has joined #openstack-horizon | 02:19 | |
| *** ducttape_ has quit IRC | 02:19 | |
| *** rama_y has joined #openstack-horizon | 02:24 | |
| *** dave-mccowan has joined #openstack-horizon | 02:26 | |
| *** raginbajin has quit IRC | 02:41 | |
| *** yamamoto has joined #openstack-horizon | 02:41 | |
| *** rodrigods has quit IRC | 02:43 | |
| *** dave-mccowan has quit IRC | 02:44 | |
| *** rodrigods has joined #openstack-horizon | 02:55 | |
| *** raginbajin has joined #openstack-horizon | 03:00 | |
| *** chlong has quit IRC | 03:11 | |
| *** Daisy_ has quit IRC | 03:11 | |
| *** Daisy_ has joined #openstack-horizon | 03:12 | |
| *** rama_y has quit IRC | 03:15 | |
| *** Daisy_ has quit IRC | 03:16 | |
| *** jamesbenson has joined #openstack-horizon | 03:25 | |
| *** ducttape_ has joined #openstack-horizon | 03:28 | |
| *** jamesbenson has quit IRC | 03:29 | |
| *** ducttap__ has joined #openstack-horizon | 03:30 | |
| *** udesale has joined #openstack-horizon | 03:30 | |
| *** ducttape_ has quit IRC | 03:34 | |
| *** harlowja has joined #openstack-horizon | 03:40 | |
| *** ducttap__ has quit IRC | 03:43 | |
| *** ducttape_ has joined #openstack-horizon | 03:48 | |
| *** ducttape_ has quit IRC | 03:52 | |
| openstackgerrit | Chiew Yee Xin proposed openstack/horizon master: Remove changeBootSource call https://review.openstack.org/484619 | 04:10 |
| korean101 | i modify '/etc/openstack-dashboard/keystone_policy.json' files | 04:36 |
| korean101 | and restore originally | 04:36 |
| korean101 | and something changed | 04:36 |
| korean101 | i log in to demo users. i can admin panel | 04:37 |
| korean101 | how can i restore my demo user's dashboard? | 04:37 |
| *** gyee has quit IRC | 04:44 | |
| *** harlowja has quit IRC | 04:54 | |
| *** zhurong has quit IRC | 05:00 | |
| *** ratailor has joined #openstack-horizon | 05:09 | |
| *** josecastroleon1 has joined #openstack-horizon | 05:12 | |
| *** josecastroleon has quit IRC | 05:15 | |
| *** Daisy_ has joined #openstack-horizon | 05:19 | |
| *** rcernin has joined #openstack-horizon | 05:29 | |
| korean101 | sorry policy file's owenership | 05:42 |
| *** ducttape_ has joined #openstack-horizon | 05:49 | |
| *** zhurong has joined #openstack-horizon | 05:50 | |
| *** ducttape_ has quit IRC | 05:53 | |
| *** makowals has quit IRC | 06:13 | |
| *** jamesbenson has joined #openstack-horizon | 06:13 | |
| *** makowals has joined #openstack-horizon | 06:15 | |
| *** jamesbenson has quit IRC | 06:17 | |
| *** masco has joined #openstack-horizon | 06:40 | |
| *** makowals has quit IRC | 06:50 | |
| *** itxaka has joined #openstack-horizon | 06:51 | |
| *** itlinux has quit IRC | 06:57 | |
| *** tesseract has joined #openstack-horizon | 07:18 | |
| *** makowals has joined #openstack-horizon | 07:48 | |
| *** mrunge has quit IRC | 07:51 | |
| *** mrunge has joined #openstack-horizon | 07:52 | |
| robcresswell | amotoki: Could you add https://review.openstack.org/#/c/482486/ to your list? I recall you looked at quota a short while ago, I think this is related | 08:05 |
| *** rmart04 has joined #openstack-horizon | 08:10 | |
| *** lajoskatona has joined #openstack-horizon | 08:17 | |
| *** lajoskatona has quit IRC | 08:18 | |
| *** lajoskatona has joined #openstack-horizon | 08:19 | |
| *** makowals has quit IRC | 08:22 | |
| *** makowals has joined #openstack-horizon | 08:24 | |
| *** mvk has quit IRC | 08:27 | |
| *** yamamoto has quit IRC | 08:36 | |
| amotoki | robcresswell: thanks for reminding it. it is in my list. yesterday was holiday in Japan and I have some pending reviews. | 08:36 |
| robcresswell | amotoki: No rush. Hope you had a nice time off :) | 08:36 |
| *** zhurong has quit IRC | 08:44 | |
| openstackgerrit | Merged openstack/horizon master: Updated from global requirements https://review.openstack.org/484550 | 08:50 |
| *** Daisy_ has quit IRC | 08:51 | |
| *** Daisy_ has joined #openstack-horizon | 08:52 | |
| *** mvk has joined #openstack-horizon | 08:55 | |
| *** Daisy_ has quit IRC | 08:56 | |
| *** yamamoto has joined #openstack-horizon | 09:01 | |
| *** yamamoto has quit IRC | 09:02 | |
| *** yamamoto has joined #openstack-horizon | 09:04 | |
| *** udesale__ has joined #openstack-horizon | 09:05 | |
| *** udesale has quit IRC | 09:08 | |
| *** Daisy_ has joined #openstack-horizon | 09:08 | |
| *** Daisy_ has quit IRC | 09:09 | |
| *** Daisy_ has joined #openstack-horizon | 09:09 | |
| *** udesale has joined #openstack-horizon | 09:11 | |
| *** udesale__ has quit IRC | 09:13 | |
| *** sudheer has joined #openstack-horizon | 09:16 | |
| sudheer | Hello guys i have problem | 09:16 |
| sudheer | Iam using openstack mitaka horizon , when i click on console link from row actions horizon is loading very slow | 09:20 |
| robcresswell | sudheer: Unfortunately, Mitaka is EOL, so we can't really help you there | 09:21 |
| sudheer | I want to know in general sense | 09:21 |
| sudheer | what makes it very slow | 09:22 |
| robcresswell | sudheer: Does it work when you load the console from outside Horizon? | 09:22 |
| sudheer | when i kept print statement in Detail View of instance panel it shows me there is lot of data fetched related to instance | 09:23 |
| sudheer | which is displayed in overview tab | 09:23 |
| sudheer | so my doubt is when i clicked on console tab does it load all the data related to other tabs or just console tab | 09:23 |
| robcresswell | sudheer: It loads them all | 09:24 |
| sudheer | when i get nova get-console command and paste it on browser, it was quicker | 09:24 |
| sudheer | it loads them all even i click console link from row actions | 09:25 |
| sudheer | ?? | 09:25 |
| *** udesale__ has joined #openstack-horizon | 09:29 | |
| robcresswell | sudheer: yes | 09:29 |
| sudheer | And one more doubt is that when i click on instance name, it will load for some time then displays overview page, but when i click on other tabs to see the data it loads for some time with Loading ... and then displays , so what is causing delay there?? | 09:30 |
| robcresswell | sudheer: The overview page makes a bunch of calls in a row to get info. Things like flavors, volumes, image data | 09:31 |
| *** udesale has quit IRC | 09:32 | |
| sudheer | yes that i got it from the code. my doubt is when all the data is loaded at once when we click on instance name , then why does it take some time to load other tabs | 09:33 |
| *** mvk has quit IRC | 09:33 | |
| sudheer | like once you reach overview page, if you want to see log tab or console tab it will take another couple seconds with Loading symbol and then display tab info | 09:35 |
| robcresswell | sudheer: I think its just to do with the design of the page. It loads a bunch of info via python API calls, but I think the other tabs have JS contents that load on demand. | 09:35 |
| sudheer | Even i select console link from instance table row actions it still load data related to overview page right. | 09:36 |
| *** udesale__ has quit IRC | 09:36 | |
| robcresswell | sudheer: As I said, it gathers all the info it can via Python calls for overview etc. but then the other tabs have JS contents that are on demand. | 09:36 |
| *** udesale__ has joined #openstack-horizon | 09:36 | |
| sudheer | ok thanks for info @robcresswell | 09:37 |
| robcresswell | sudheer: No problem. FYI, you don't need "@" in IRC. | 09:37 |
| sudheer | in case if i had further doubts i will raise it here | 09:37 |
| robcresswell | Sure | 09:37 |
| sudheer | ok next i will not use '@' :) | 09:38 |
| *** udesale has joined #openstack-horizon | 09:40 | |
| *** Daisy_ has quit IRC | 09:40 | |
| *** Daisy_ has joined #openstack-horizon | 09:41 | |
| *** makowals has quit IRC | 09:42 | |
| *** udesale__ has quit IRC | 09:42 | |
| *** yingjun has quit IRC | 09:45 | |
| *** Daisy_ has quit IRC | 09:45 | |
| *** mvk has joined #openstack-horizon | 09:47 | |
| *** tosky has joined #openstack-horizon | 09:47 | |
| *** jamesbenson has joined #openstack-horizon | 09:49 | |
| *** jamesbenson has quit IRC | 09:54 | |
| *** udesale has quit IRC | 10:16 | |
| *** yamamoto has quit IRC | 10:18 | |
| *** yamamoto has joined #openstack-horizon | 10:28 | |
| *** elod has quit IRC | 10:34 | |
| *** yamamoto has quit IRC | 10:38 | |
| *** elod has joined #openstack-horizon | 10:47 | |
| *** zhurong has joined #openstack-horizon | 10:52 | |
| *** ducttape_ has joined #openstack-horizon | 11:00 | |
| *** ducttape_ has quit IRC | 11:05 | |
| openstackgerrit | Rob Cresswell proposed openstack/django_openstack_auth master: Fix Django 1.11 Compatibility https://review.openstack.org/484722 | 11:08 |
| robcresswell | amotoki: Would you be able to help out with Horizon stable approvals? | 11:10 |
| robcresswell | I was going to suggest the stable team add you | 11:10 |
| *** makowals has joined #openstack-horizon | 11:11 | |
| openstackgerrit | Merged openstack/ui-cookiecutter master: rearrange existing documentation to fit the new standard layout https://review.openstack.org/482415 | 11:12 |
| amotoki | robcresswell: I can help stable reviews (though I do not think I can help much in proposing backports). for the stable policy, I believe I understand it. | 11:12 |
| openstackgerrit | Merged openstack/ui-cookiecutter master: Update document link affected by document migration https://review.openstack.org/483932 | 11:13 |
| robcresswell | amotoki: Excellent. Thats fine, I can continue to propose them as Horizon is my focus. The issue was only having a single approver (me) most of the time | 11:13 |
| robcresswell | amotoki: For stable branches, if a stable core proposes the patch, a single other stable core review is enough for approval. So if I propose a backport, you can do approve without a second vote. | 11:14 |
| robcresswell | amotoki: You should have permission to merge now :) | 11:16 |
| *** dave-mccowan has joined #openstack-horizon | 11:16 | |
| amotoki | robcresswell: thanks. Your policy on stable branches sounds reasonable. If a stalbe core proposes a patch, we can assume he/she already consider the stable policy. it is a reasonable assumption. | 11:17 |
| robcresswell | amotoki: Thats actually part of core stable policy, not my own :) | 11:18 |
| robcresswell | amotoki: See https://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines "Where a team member has backported a fix, a single other +2 is sufficient for approval." in the 4th paragraph | 11:19 |
| amotoki | robcresswell: the link is what I am looking for. I've just found it. | 11:20 |
| robcresswell | adriant: See https://review.openstack.org/#/c/484722/ I haven't yet had any responses about the d_o_a merge on the mailer, so it may fall to next cycle. | 11:20 |
| robcresswell | adriant: Either way, that should fix some of the tests. | 11:21 |
| *** dave-mccowan has quit IRC | 11:23 | |
| openstackgerrit | Rob Cresswell proposed openstack/django_openstack_auth master: Fix Django 1.11 Compatibility https://review.openstack.org/484722 | 11:30 |
| sudheer | hello robcresswell i have created a bug https://bugs.launchpad.net/horizon/+bug/1705013 | 11:30 |
| openstack | Launchpad bug 1705013 in OpenStack Dashboard (Horizon) "Opening of Console screen for a VM from horizon takes huge amount of time" [Undecided,New] | 11:30 |
| openstackgerrit | Rob Cresswell proposed openstack/django_openstack_auth master: Fix Django 1.11 Compatibility https://review.openstack.org/484722 | 11:30 |
| *** ramineni has left #openstack-horizon | 11:31 | |
| lajoskatona | amotoki & robcresswell: Could you take a look when you have time on the neutron-trunk-ui patches, please? | 11:32 |
| lajoskatona | We even has some progress with the creation of trunk now, but as the angular is new to us we have questions as well (see: https://review.openstack.org/468396) | 11:33 |
| *** yamamoto has joined #openstack-horizon | 11:33 | |
| lajoskatona | Would be good have feedback if the direction is good or not | 11:33 |
| robcresswell | lajoskatona: I'm unlikely to get much time, but I will try | 11:35 |
| lajoskatona | thanks, every help is appreciated | 11:38 |
| lajoskatona | help & feedback:-) | 11:38 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/484730 | 11:38 |
| *** Daisy_ has joined #openstack-horizon | 11:46 | |
| *** wolverineav has joined #openstack-horizon | 11:47 | |
| *** Daisy_ has quit IRC | 11:50 | |
| *** felipemonteiro has joined #openstack-horizon | 11:54 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/484730 | 11:59 |
| *** chlong has joined #openstack-horizon | 12:00 | |
| *** elod has quit IRC | 12:02 | |
| *** elod has joined #openstack-horizon | 12:03 | |
| *** yamamoto has quit IRC | 12:04 | |
| *** clayton has quit IRC | 12:08 | |
| *** clayton has joined #openstack-horizon | 12:09 | |
| *** yamamoto has joined #openstack-horizon | 12:19 | |
| *** ratailor has quit IRC | 12:25 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Imported Translations from Zanata https://review.openstack.org/482935 | 12:38 |
| *** tosky_ has joined #openstack-horizon | 12:41 | |
| *** tosky has quit IRC | 12:41 | |
| *** catintheroof has joined #openstack-horizon | 12:51 | |
| *** felipemonteiro_ has joined #openstack-horizon | 12:57 | |
| *** catintheroof has quit IRC | 12:58 | |
| *** felipemonteiro__ has joined #openstack-horizon | 12:58 | |
| *** ducttape_ has joined #openstack-horizon | 13:02 | |
| *** felipemonteiro_ has quit IRC | 13:02 | |
| *** catintheroof has joined #openstack-horizon | 13:06 | |
| *** ducttape_ has quit IRC | 13:06 | |
| *** udesale has joined #openstack-horizon | 13:08 | |
| *** catintheroof has quit IRC | 13:11 | |
| *** masco has quit IRC | 13:12 | |
| *** jtriley has joined #openstack-horizon | 13:13 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: create button https://review.openstack.org/468396 | 13:18 |
| *** jtriley has quit IRC | 13:19 | |
| *** udesale has quit IRC | 13:27 | |
| *** zhurong has quit IRC | 13:28 | |
| *** udesale has joined #openstack-horizon | 13:28 | |
| *** lucasxu has joined #openstack-horizon | 13:31 | |
| *** Daisy_ has joined #openstack-horizon | 13:35 | |
| *** vishwanathj has quit IRC | 13:38 | |
| *** vishwanathj has joined #openstack-horizon | 13:39 | |
| *** Daisy_ has quit IRC | 13:40 | |
| robcresswell | amotoki, rdopiera: Need reviews urgently on https://review.openstack.org/#/c/484722 | 13:40 |
| amotoki | robcresswell: ack. checking your comments now | 13:41 |
| robcresswell | amotoki: Much appreciated. Sorry its so late for you | 13:41 |
| *** udesale has quit IRC | 13:43 | |
| *** rama_y has joined #openstack-horizon | 13:46 | |
| amotoki | robcresswell: np. I am reviewing while watching the tour de france on TV. it sounds like just connected :) | 13:48 |
| *** catintheroof has joined #openstack-horizon | 13:52 | |
| *** tosky has joined #openstack-horizon | 13:52 | |
| *** tosky_ has quit IRC | 13:53 | |
| *** ducttape_ has joined #openstack-horizon | 13:57 | |
| amotoki | robcresswell:: I am fine with the review 484722. thanks | 13:58 |
| robcresswell | amotoki: Excellent, thanks | 13:59 |
| robcresswell | I'll tag that soon then | 13:59 |
| *** jtriley has joined #openstack-horizon | 14:00 | |
| amotoki | yeah, this week is the feature freeze week for non-client libs. | 14:00 |
| *** rmart04 has quit IRC | 14:04 | |
| *** wolverineav has quit IRC | 14:09 | |
| robcresswell | yep | 14:10 |
| *** ducttape_ has quit IRC | 14:15 | |
| *** jtriley has quit IRC | 14:26 | |
| *** jtriley has joined #openstack-horizon | 14:27 | |
| *** wolverineav has joined #openstack-horizon | 14:28 | |
| betherly | any core reviews on https://review.openstack.org/#/c/445539/ and https://review.openstack.org/#/c/468018/ would be much much appreciated | 14:28 |
| *** ducttap__ has joined #openstack-horizon | 14:32 | |
| *** rama_y has quit IRC | 14:38 | |
| *** jeremy_moffitt has quit IRC | 14:41 | |
| *** jeremy_moffitt has joined #openstack-horizon | 14:42 | |
| *** jamesbenson has joined #openstack-horizon | 15:00 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Fix Django 1.11 Compatibility https://review.openstack.org/484722 | 15:06 |
| *** vinsh has joined #openstack-horizon | 15:11 | |
| *** rama_y has joined #openstack-horizon | 15:15 | |
| *** yamamoto has quit IRC | 15:17 | |
| *** yamamoto has joined #openstack-horizon | 15:21 | |
| *** Daisy_ has joined #openstack-horizon | 15:24 | |
| robcresswell | betherly: That disk issue; does that happen on the CLI? | 15:28 |
| robcresswell | betherly: I've no idea what has priority on the minimum disk out of flavour, volume and min disk | 15:28 |
| *** Daisy_ has quit IRC | 15:29 | |
| betherly | robcresswell: no its a ui issue and its exactly the same as image | 15:29 |
| *** yamamoto has quit IRC | 15:29 | |
| betherly | so basically when you launch an instance using an image if the flavor is smaller than the min disk of the image you cant select it | 15:30 |
| betherly | that already exists | 15:30 |
| robcresswell | betherly: So, the UI sends the command and nova rejects it? | 15:30 |
| betherly | the problem is that when you try to launch an instance with a volume that been created from an image, if the flavor is smaller than the image min disk associated with the volume it should still not be selectable | 15:31 |
| robcresswell | betherly: Right so, Nova rejects the command? | 15:31 |
| betherly | yes | 15:31 |
| *** rcernin has quit IRC | 15:32 | |
| robcresswell | betherly: So... which has priority on the actual minimum disk allowed? | 15:33 |
| *** vishwana_ has joined #openstack-horizon | 15:33 | |
| betherly | robcresswell: what do you mean? | 15:33 |
| robcresswell | Out of flavor / image, which is *actually* the minimum? | 15:33 |
| robcresswell | I mean, by definition, you can't have two minimums, right? Either one takes priority, or its the lower of the two | 15:34 |
| robcresswell | Thats what bugs me about the logic | 15:34 |
| *** lcastell has joined #openstack-horizon | 15:34 | |
| *** mvk has quit IRC | 15:34 | |
| robcresswell | Like, if flavor disk is 5 and image min is 7, whats the minimum? 5? or 7? Its not clear how that hierarchy works | 15:36 |
| betherly | robcresswell: i dont think the flavor has a min_disk | 15:36 |
| betherly | robcresswell: so image has a min_disk and flavor is a certain size | 15:36 |
| betherly | so if the flavor size is smaller than min_disk it shouldnt be selectable | 15:36 |
| robcresswell | Right, sorry, the source (in that logic) is the other min_disk | 15:36 |
| betherly | robcresswell: does that make sense? | 15:36 |
| *** itlinux has joined #openstack-horizon | 15:36 | |
| robcresswell | My point is, you can't have 2 minimums | 15:36 |
| betherly | robcresswell: no i know that. image has a min_disk | 15:37 |
| betherly | flavor does not | 15:37 |
| robcresswell | And source.min_disk? | 15:37 |
| *** vishwanathj has quit IRC | 15:37 | |
| robcresswell | I think that logic needs to be tidied, so its does something like work out what the actual minimum value is, and then does check against that. Because atm, there is way too many conditions in that logic | 15:38 |
| betherly | source.min_disk finds the min_disk of the image associated with the volume | 15:38 |
| robcresswell | Okay, so how is that different to source.volume_image_metadata.min_disk? | 15:38 |
| betherly | robcresswell: right. so what that code is doing is checking what the min_disk is when an instance is being launched from either a volume or an image. previously it was only doing the min_disk check on an image even though a volume also has a min_disk when it is created from an image | 15:40 |
| betherly | so i got it backwards before my bad. | 15:40 |
| betherly | source.min_disk == finds the min_disk when the source type is 'image' | 15:40 |
| betherly | source.volume_image_metadata.min_disk == finds the min_disk of the image associated with the volume when source type 'volume' is selected | 15:41 |
| robcresswell | Okay, so why not just set source.min_disk = metadata.min_disk when the source changes | 15:41 |
| robcresswell | And then drop all the other logic and use the existing compaistons | 15:41 |
| robcresswell | comparisons* | 15:41 |
| betherly | robcresswell: so do an if statement for if sourceType.type === 'volume' amd set source.min_disk = metadata.min_disk? | 15:43 |
| robcresswell | betherly: Yes | 15:44 |
| betherly | robcresswell: ok | 15:44 |
| robcresswell | betherly: Then you should just be able to use the same message interpolator too | 15:44 |
| robcresswell | instead of all this min_disk duplication all over the place | 15:44 |
| betherly | robcresswell: ye that would be cleaner youre right. im not sure re the interpolator of the label though as i had to hardcode that part to volume as it got confused with sourcetype | 15:45 |
| betherly | robcresswell: will have to test it and see | 15:45 |
| robcresswell | betherly: Why? sourceType as 'volume' is used elsewhere so it should be fine. You're already using it at L334 | 15:46 |
| *** jtriley has quit IRC | 15:46 | |
| betherly | robcresswell: it might have been in the context of all the other min_disk stuff going on. ill update it and see | 15:46 |
| robcresswell | cool cool | 15:47 |
| betherly | :) | 15:47 |
| amotoki | lajoskatona: betherly: sorry for my late reviews on the networking related patches. I believe I can have time to review them. I believe my doc-migration related stuffs are almost over. | 15:47 |
| amotoki | *tomorrow* | 15:48 |
| betherly | amotoki: thanks muchly :) | 15:48 |
| *** jtriley has joined #openstack-horizon | 15:54 | |
| *** brad[] has quit IRC | 16:00 | |
| *** vishwana_ has quit IRC | 16:01 | |
| *** vishwanathj has joined #openstack-horizon | 16:02 | |
| *** rcernin has joined #openstack-horizon | 16:02 | |
| *** Daisy_ has joined #openstack-horizon | 16:19 | |
| *** vishwanathj has quit IRC | 16:22 | |
| *** Daisy_ has quit IRC | 16:24 | |
| *** ducttape_ has joined #openstack-horizon | 16:24 | |
| *** ducttap__ has quit IRC | 16:28 | |
| *** yamamoto has joined #openstack-horizon | 16:29 | |
| *** Adri2000 has quit IRC | 16:30 | |
| *** yamamoto has quit IRC | 16:37 | |
| *** brad[] has joined #openstack-horizon | 16:40 | |
| *** yamamoto has joined #openstack-horizon | 17:07 | |
| *** yamamoto has quit IRC | 17:12 | |
| *** Daisy_ has joined #openstack-horizon | 17:13 | |
| *** Daisy_ has quit IRC | 17:17 | |
| *** ducttap__ has joined #openstack-horizon | 17:19 | |
| *** ying_zuo has joined #openstack-horizon | 17:19 | |
| *** ducttape_ has quit IRC | 17:22 | |
| *** harlowja has joined #openstack-horizon | 17:24 | |
| *** tosky has quit IRC | 17:32 | |
| *** itxaka has quit IRC | 17:40 | |
| *** tsmith has quit IRC | 17:46 | |
| *** tsmith has joined #openstack-horizon | 17:53 | |
| *** tosky has joined #openstack-horizon | 17:57 | |
| *** tesseract has quit IRC | 17:58 | |
| openstackgerrit | Tyler Smith proposed openstack/horizon master: Adds extensible header functionality https://review.openstack.org/484899 | 18:09 |
| *** deep-book-gk_ has joined #openstack-horizon | 18:13 | |
| *** deep-book-gk_ has left #openstack-horizon | 18:15 | |
| *** lcastell has quit IRC | 18:20 | |
| *** jtriley has quit IRC | 18:22 | |
| *** wolverineav has quit IRC | 18:28 | |
| *** wolverineav has joined #openstack-horizon | 18:28 | |
| *** jtriley has joined #openstack-horizon | 18:31 | |
| *** wolverineav has quit IRC | 18:33 | |
| *** lcastell has joined #openstack-horizon | 18:37 | |
| *** lcastell has quit IRC | 18:39 | |
| *** lcastell has joined #openstack-horizon | 18:45 | |
| *** lcastell has quit IRC | 18:49 | |
| *** itxaka has joined #openstack-horizon | 18:51 | |
| openstackgerrit | Tyler Smith proposed openstack/horizon master: Adds extensible header functionality https://review.openstack.org/484899 | 19:01 |
| *** Daisy_ has joined #openstack-horizon | 19:01 | |
| *** chlong_ has joined #openstack-horizon | 19:03 | |
| *** itxaka has quit IRC | 19:04 | |
| *** chlong has quit IRC | 19:05 | |
| *** Daisy_ has quit IRC | 19:06 | |
| *** gyee has joined #openstack-horizon | 19:17 | |
| *** vishwanathj has joined #openstack-horizon | 19:26 | |
| *** vishwanathj has quit IRC | 19:34 | |
| *** vishwanathj has joined #openstack-horizon | 19:35 | |
| *** vishwanathj has quit IRC | 19:48 | |
| *** vishwanathj has joined #openstack-horizon | 19:49 | |
| *** vishwanathj has quit IRC | 19:50 | |
| *** vishwanathj has joined #openstack-horizon | 19:51 | |
| *** dave-mccowan has joined #openstack-horizon | 19:58 | |
| *** wolverineav has joined #openstack-horizon | 20:14 | |
| *** dave-mccowan has quit IRC | 20:17 | |
| *** dave-mccowan has joined #openstack-horizon | 20:24 | |
| *** makowals has quit IRC | 20:25 | |
| *** dave-mccowan has quit IRC | 20:27 | |
| *** makowals has joined #openstack-horizon | 20:30 | |
| *** vishwanathj has quit IRC | 20:32 | |
| *** vishwanathj has joined #openstack-horizon | 20:33 | |
| *** jtriley has quit IRC | 20:37 | |
| *** vishwanathj has quit IRC | 20:39 | |
| *** vishwanathj has joined #openstack-horizon | 20:40 | |
| *** vishwanathj has quit IRC | 20:40 | |
| *** vishwanathj has joined #openstack-horizon | 20:41 | |
| *** vishwanathj has quit IRC | 20:45 | |
| *** vishwanathj has joined #openstack-horizon | 20:46 | |
| *** vishwanathj has quit IRC | 20:47 | |
| *** vishwanathj has joined #openstack-horizon | 20:47 | |
| *** Daisy_ has joined #openstack-horizon | 20:50 | |
| *** Daisy_ has quit IRC | 20:55 | |
| *** lcastell has joined #openstack-horizon | 20:57 | |
| *** rcernin has quit IRC | 20:57 | |
| *** lucasxu has quit IRC | 21:02 | |
| *** lucasxu has joined #openstack-horizon | 21:06 | |
| *** ducttape_ has joined #openstack-horizon | 21:07 | |
| *** ducttap__ has quit IRC | 21:10 | |
| *** lucasxu has quit IRC | 21:17 | |
| *** Daisy_ has joined #openstack-horizon | 21:42 | |
| *** wolverineav has quit IRC | 21:44 | |
| *** Daisy_ has quit IRC | 21:47 | |
| *** jamesbenson has quit IRC | 22:04 | |
| *** gyee has quit IRC | 22:20 | |
| *** felipemonteiro has quit IRC | 22:31 | |
| *** felipemonteiro__ has quit IRC | 22:31 | |
| *** felipemonteiro has joined #openstack-horizon | 22:31 | |
| *** felipemonteiro__ has joined #openstack-horizon | 22:33 | |
| *** itlinux has quit IRC | 22:37 | |
| *** felipemonteiro__ has quit IRC | 22:38 | |
| *** gyee has joined #openstack-horizon | 22:38 | |
| *** ducttape_ has quit IRC | 23:01 | |
| *** tosky has quit IRC | 23:18 | |
| *** ducttape_ has joined #openstack-horizon | 23:18 | |
| *** ducttap__ has joined #openstack-horizon | 23:20 | |
| *** ducttape_ has quit IRC | 23:20 | |
| *** ducttap__ has quit IRC | 23:24 | |
| *** catintheroof has quit IRC | 23:25 | |
| *** dave-mccowan has joined #openstack-horizon | 23:29 | |
| *** dave-mcc_ has joined #openstack-horizon | 23:37 | |
| *** dave-mccowan has quit IRC | 23:38 | |
| *** dave-mcc_ has quit IRC | 23:45 | |
| *** itlinux has joined #openstack-horizon | 23:54 | |
| *** lucasxu has joined #openstack-horizon | 23:55 | |
| *** yingjun has joined #openstack-horizon | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!