| *** itlinux has quit IRC | 00:02 | |
| *** lcastell has quit IRC | 00:33 | |
| *** lcastell has joined #openstack-horizon | 00:37 | |
| *** yingjun has joined #openstack-horizon | 00:41 | |
| *** lcastell has quit IRC | 00:41 | |
| *** lcastell has joined #openstack-horizon | 00:42 | |
| *** lcastell has quit IRC | 00:44 | |
| *** itlinux has joined #openstack-horizon | 00:53 | |
| *** itlinux has quit IRC | 00:58 | |
| *** jamielennox has quit IRC | 01:08 | |
| *** makowals has quit IRC | 01:08 | |
| *** lcastell has joined #openstack-horizon | 01:09 | |
| *** ducttape_ has joined #openstack-horizon | 01:14 | |
| *** jamielennox has joined #openstack-horizon | 01:15 | |
| *** ducttape_ has quit IRC | 01:18 | |
| *** harlowja has quit IRC | 01:19 | |
| *** makowals has joined #openstack-horizon | 01:23 | |
| CowboyPride | ying_zuo: Thanks for the repsonse, sorry only just getting back to you been working with other team members on the error... | 01:26 |
|---|---|---|
| *** yamamoto_ has quit IRC | 01:31 | |
| CowboyPride | One error that is persisitant is this but "AH01630: client denied by server configuration: /usr/bin/keystone-wsgi-public" but don't know where the permissions are to be modified... | 01:32 |
| CowboyPride | but don't know if that is related to this issue or another issue, trying to work through issues little by little. | 01:33 |
| *** yamamoto has joined #openstack-horizon | 01:35 | |
| *** flwang1 has joined #openstack-horizon | 01:35 | |
| flwang1 | hi horizon team, could you please help review https://review.openstack.org/#/c/483785/ ? the patch has been sitting there for 2 weeks and no review. | 01:36 |
| *** makowals has quit IRC | 01:38 | |
| *** zhurong has joined #openstack-horizon | 01:38 | |
| *** ducttape_ has joined #openstack-horizon | 01:38 | |
| *** makowals has joined #openstack-horizon | 01:53 | |
| *** yingjun has quit IRC | 02:03 | |
| *** jamielennox has quit IRC | 02:17 | |
| ying_zuo | CowboyPride: I am not sure about that error. If you see the list of projects on the projects panel, I think horizon can communicate with keystone fine. UpdateProjectMembersAction(openstack_dashboard/dashboards/identity/projects/workflows.py) makes requests for the data so I would set some break points there to check what went wrong. | 02:21 |
| *** shu-mutou-AWAY is now known as shu-mutou | 02:22 | |
| *** jamielennox has joined #openstack-horizon | 02:24 | |
| *** lblanchard has joined #openstack-horizon | 02:30 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Commonize load-edit directive https://review.openstack.org/483810 | 02:31 |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Enable to refresh ngdetails view https://review.openstack.org/477447 | 02:31 |
| *** lcastell has quit IRC | 02:38 | |
| *** jamesbenson_ has joined #openstack-horizon | 02:43 | |
| *** jamesbenson_ has quit IRC | 02:48 | |
| *** ducttape_ has quit IRC | 03:04 | |
| *** ducttape_ has joined #openstack-horizon | 03:11 | |
| *** lblanchard has quit IRC | 03:12 | |
| *** zhurong has quit IRC | 03:13 | |
| *** ducttape_ has quit IRC | 03:16 | |
| *** yeexin has quit IRC | 03:20 | |
| *** jamesbenson_ has joined #openstack-horizon | 03:28 | |
| *** harlowja has joined #openstack-horizon | 03:31 | |
| *** udesale has joined #openstack-horizon | 03:36 | |
| *** ramineni_ has quit IRC | 03:44 | |
| *** lcastell has joined #openstack-horizon | 03:58 | |
| *** yeexin has joined #openstack-horizon | 04:01 | |
| *** makowals has quit IRC | 04:04 | |
| *** yeexin has quit IRC | 04:06 | |
| *** jamesbenson_ has quit IRC | 04:12 | |
| *** ying_zuo has quit IRC | 04:15 | |
| openstackgerrit | Shu Muto proposed openstack/horizon master: Use load-edit directive in import key pair https://review.openstack.org/487689 | 04:19 |
| *** makowals has joined #openstack-horizon | 04:22 | |
| *** nikkonlp has quit IRC | 04:26 | |
| *** hoonetorg has joined #openstack-horizon | 04:26 | |
| *** itlinux has joined #openstack-horizon | 04:29 | |
| *** zhurong has joined #openstack-horizon | 04:39 | |
| *** harlowja has quit IRC | 04:52 | |
| *** lcastell has quit IRC | 05:04 | |
| openstackgerrit | Merged openstack/horizon master: Cleanup release notes https://review.openstack.org/486456 | 05:08 |
| *** ducttape_ has joined #openstack-horizon | 05:12 | |
| *** ducttape_ has quit IRC | 05:17 | |
| *** flwang1 has quit IRC | 05:20 | |
| *** vishwana_ has quit IRC | 05:40 | |
| *** vishwanathj has joined #openstack-horizon | 05:41 | |
| *** udesale__ has joined #openstack-horizon | 05:47 | |
| *** udesale has quit IRC | 05:50 | |
| *** ratailor has joined #openstack-horizon | 05:58 | |
| *** jamesbenson_ has joined #openstack-horizon | 06:01 | |
| *** jamesbenson_ has quit IRC | 06:05 | |
| *** yingjun has joined #openstack-horizon | 06:10 | |
| *** udesale has joined #openstack-horizon | 06:12 | |
| *** udesale__ has quit IRC | 06:14 | |
| *** masco has joined #openstack-horizon | 06:32 | |
| *** zhurong has quit IRC | 06:33 | |
| ethfci | sysinfo | 06:46 |
| ethfci | Morning | 06:46 |
| *** jtomasek_ has joined #openstack-horizon | 06:54 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Add the Snapshots tab on the Volume Details page https://review.openstack.org/270461 | 07:08 |
| *** masco has quit IRC | 07:08 | |
| *** makowals has quit IRC | 07:08 | |
| *** makowals has joined #openstack-horizon | 07:09 | |
| *** rcernin has joined #openstack-horizon | 07:13 | |
| *** jtomasek_ has quit IRC | 07:15 | |
| *** wolverineav has joined #openstack-horizon | 07:23 | |
| *** masco has joined #openstack-horizon | 07:25 | |
| openstackgerrit | Merged openstack/horizon master: Should not be able to choose flavor < volume.image.min_disk https://review.openstack.org/468018 | 07:26 |
| *** ducttape_ has joined #openstack-horizon | 07:28 | |
| openstackgerrit | Merged openstack/horizon master: If the flavor_id not in full_flavors, don't make a new API request https://review.openstack.org/418409 | 07:29 |
| *** ducttap__ has joined #openstack-horizon | 07:31 | |
| *** jtomasek_ has joined #openstack-horizon | 07:32 | |
| *** ducttape_ has quit IRC | 07:32 | |
| *** ducttap__ has quit IRC | 07:35 | |
| *** obre has quit IRC | 07:36 | |
| *** obre has joined #openstack-horizon | 07:36 | |
| *** shu-mutou has quit IRC | 07:38 | |
| *** shu-mutou has joined #openstack-horizon | 07:38 | |
| openstackgerrit | Merged openstack/horizon master: Datepicker should inherit from theme https://review.openstack.org/318933 | 07:39 |
| openstackgerrit | Merged openstack/horizon master: Add apple-touch-icon and safari-pinned-tab https://review.openstack.org/463492 | 07:42 |
| *** wolverineav has quit IRC | 07:45 | |
| *** jtomasek has quit IRC | 07:46 | |
| *** jtomasek_ is now known as jtomasek | 07:48 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Update the documentation link for doc migration https://review.openstack.org/486454 | 07:51 |
| *** e0ne has joined #openstack-horizon | 08:11 | |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: default to disabled https://review.openstack.org/487743 | 08:12 |
| *** lujinluo has joined #openstack-horizon | 08:13 | |
| *** kei1 has quit IRC | 08:19 | |
| rubasov | good morning | 08:23 |
| rubasov | robcresswell: are you around? | 08:24 |
| rubasov | robcresswell: first, here's the disable patch I promised yesterday: https://review.openstack.org/487743 | 08:24 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Update the documentation link for doc migration https://review.openstack.org/486454 | 08:35 |
| *** e0ne has quit IRC | 08:40 | |
| *** e0ne has joined #openstack-horizon | 08:42 | |
| robcresswell | rubasov: Yeah I'm around | 08:45 |
| rubasov | robcresswell: hello | 08:46 |
| rubasov | robcresswell: I have a question about your last comment in the details patch: https://review.openstack.org/464727 | 08:46 |
| rubasov | robcresswell: here it is: https://review.openstack.org/#/c/464727/16/openstack_dashboard/static/app/core/openstack-service-api/neutron.service.js@65 | 08:47 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: details for trunks and subports https://review.openstack.org/464727 | 08:51 |
| *** e0ne has quit IRC | 08:54 | |
| *** e0ne has joined #openstack-horizon | 08:54 | |
| *** kei1 has joined #openstack-horizon | 09:01 | |
| *** kei1 has quit IRC | 09:03 | |
| *** mvk has quit IRC | 09:04 | |
| *** kei1 has joined #openstack-horizon | 09:05 | |
| *** rmart04 has joined #openstack-horizon | 09:10 | |
| *** kei1_ has joined #openstack-horizon | 09:12 | |
| e0ne | hi all! do we have any kind of agenda or list of proposed topics for PTG? | 09:14 |
| *** udesale has quit IRC | 09:14 | |
| *** kei1 has quit IRC | 09:16 | |
| *** flwang1 has joined #openstack-horizon | 09:17 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 09:20 | |
| *** kei1_ has quit IRC | 09:23 | |
| *** wolverineav has joined #openstack-horizon | 09:23 | |
| *** kei1 has joined #openstack-horizon | 09:24 | |
| *** wolverineav has quit IRC | 09:27 | |
| *** flwang1 has quit IRC | 09:29 | |
| *** yingjun has quit IRC | 09:30 | |
| *** e0ne has quit IRC | 09:32 | |
| *** e0ne has joined #openstack-horizon | 09:37 | |
| *** jamesbenson_ has joined #openstack-horizon | 09:37 | |
| e0ne | amotoki: hi. are you around? I've got few questions according to your patch | 09:41 |
| amotoki | e0ne: hi | 09:41 |
| *** jamesbenson_ has quit IRC | 09:42 | |
| *** wolverineav has joined #openstack-horizon | 09:42 | |
| *** mvk has joined #openstack-horizon | 09:44 | |
| e0ne | here is it https://review.openstack.org/#/c/426496/ | 09:44 |
| e0ne | amotoki: I'm just interesting why do you use futurist.ThreadPoolExecutor instead of futurist.GreenThreadPoolExecutor there? ^^ | 09:45 |
| e0ne | amotoki: is any performance benefits for it? | 09:45 |
| amotoki | e0ne: actually I am not the author of the patch. | 09:47 |
| amotoki | e0ne: do you have any difference in performance and/or functionalities between them? | 09:48 |
| e0ne | amotoki: I'm sorry, I missed something:( | 09:49 |
| e0ne | amotoki: from performance point of view - I didn't do any tests yet | 09:49 |
| amotoki | e0ne: np, but horizon does not use eventlet now, so i wonder futurist.GreenThreadPoolExecutor does not work. | 09:49 |
| amotoki | i just looked at https://docs.openstack.org/futurist/latest/user/features.html | 09:50 |
| e0ne | amotoki: oh.. if we don't use eventlet, greenpool is not an option for horizon | 09:50 |
| amotoki | e0ne: in addition, most OpenStack projects are now working on eliminating eventlet dependencies from their API server (not all processes) | 09:51 |
| e0ne | amotoki: I know about this activity | 09:52 |
| amotoki | nice | 09:52 |
| *** kei1 has quit IRC | 09:52 | |
| e0ne | amotoki: so, does it mean that horizon won't accept eventlet ? | 09:52 |
| *** itxaka has joined #openstack-horizon | 09:52 | |
| e0ne | AFAIK, the main concern in with eventlet was that is't not fast enough as wsgi server | 09:53 |
| *** kei1 has joined #openstack-horizon | 09:54 | |
| amotoki | e0ne: it does not necessarily mean we always reject it. if we have good merits using eventlet, it is no problem I think. | 09:54 |
| e0ne | in general, using eventlet for green threads is acceptable | 09:54 |
| e0ne | amotoki: thanks for the clarification. I'll bring some perf. tests results once they will be ready. maybe we still don't need eventlet | 09:54 |
| amotoki | e0ne: you're welcome. my understanding on wsgi server with eventlet is same as your too. | 09:56 |
| *** redondo-mk has quit IRC | 09:59 | |
| *** yamamoto has quit IRC | 10:00 | |
| *** redondo-mk has joined #openstack-horizon | 10:01 | |
| *** makowals has quit IRC | 10:02 | |
| *** makowals has joined #openstack-horizon | 10:02 | |
| *** masco_ has joined #openstack-horizon | 10:10 | |
| *** masco_ has quit IRC | 10:11 | |
| *** masco has quit IRC | 10:13 | |
| *** udesale has joined #openstack-horizon | 10:17 | |
| *** masco_ has joined #openstack-horizon | 10:27 | |
| *** kei1 has quit IRC | 10:30 | |
| *** yamamoto has joined #openstack-horizon | 10:31 | |
| *** kei1 has joined #openstack-horizon | 10:32 | |
| *** kei1 has quit IRC | 10:46 | |
| *** kei1 has joined #openstack-horizon | 10:47 | |
| *** kei1 has quit IRC | 10:54 | |
| *** kei1 has joined #openstack-horizon | 10:54 | |
| *** flwang1 has joined #openstack-horizon | 10:55 | |
| *** lujinluo has quit IRC | 10:56 | |
| robcresswell | rubasov: Cool. Lets just move ahead. It works fine. | 10:58 |
| *** kei1 has quit IRC | 10:59 | |
| *** kei1 has joined #openstack-horizon | 10:59 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Update local conf https://review.openstack.org/487808 | 11:01 |
| robcresswell | e0ne: If you have some advice about any simple parallelisation, I'd love to learn more about how OpenStack as a whole prefers to handle it. I've not much knowledge there. | 11:01 |
| rubasov | robcresswell: thank you | 11:01 |
| e0ne | robcresswell: I'm investigating different options of using futurist now | 11:02 |
| rubasov | robcresswell: when you have another minute you may want to look at the disable patch too: https://review.openstack.org/487743 | 11:02 |
| e0ne | robcresswell: it looks like a very good option for horizon now | 11:02 |
| e0ne | robcresswell: I'll let you know once I'll have any results | 11:03 |
| robcresswell | rubasov: Yup, I'm looking | 11:04 |
| robcresswell | e0ne: Awesome, I appreciate that. We merged some content beforehand, that my local benchmarks seemed to show promise with, but I'm still unsure | 11:04 |
| e0ne | robcresswell: btw, do we have any horizon-specific guidelines how to deploy it for scale? I mean some kind of horizontal scale, etc | 11:04 |
| robcresswell | e0ne: Not beyond the install guide content, which I'm not familiar with | 11:05 |
| robcresswell | e0ne: I'm not a deployer myself :/ | 11:05 |
| e0ne | robcresswell: ok, thanks | 11:05 |
| * robcresswell grumbles something about teams splitting upstream from deployment teams | 11:05 | |
| e0ne | in openstack world sometimes the line between developers and operators are very thin or very big | 11:06 |
| flwang1 | robcresswell: could you please help review https://review.openstack.org/#/c/483785/ ? | 11:11 |
| flwang1 | it has been sitting there for 14 days | 11:11 |
| robcresswell | flwang1: I'll get to it | 11:12 |
| robcresswell | There are patches that have been around much longer than that | 11:12 |
| flwang1 | robcresswell: haha, so should i shutup? | 11:13 |
| robcresswell | flwang1: No, I'm just not making any promises :) | 11:13 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Update local conf https://review.openstack.org/487808 | 11:13 |
| flwang1 | robcresswell: i totally understand | 11:13 |
| flwang1 | but i know if i don't make some noises here, it may be there longer as you said | 11:14 |
| robcresswell | Yeah, thats fair enough | 11:14 |
| flwang1 | sorry for the noises, but we have customer are annoying by the bug | 11:14 |
| openstackgerrit | Merged openstack/horizon master: Trunks panel: details for trunks and subports https://review.openstack.org/464727 | 11:17 |
| flwang1 | robcresswell: is this a known issue? https://ibb.co/hH7TLQ | 11:17 |
| robcresswell | flwang1: Like I said, I understand, and I'll do what I can, I just have my own work too :) | 11:17 |
| flwang1 | the dropdown list is not showing in the correct z-index order | 11:17 |
| robcresswell | yes | 11:17 |
| robcresswell | There is a patch that I need to review :( | 11:17 |
| flwang1 | robcresswell: can you please point that out? I can help verify | 11:18 |
| robcresswell | https://review.openstack.org/#/c/389866/ | 11:18 |
| *** kazsh has quit IRC | 11:18 | |
| *** kazsh has joined #openstack-horizon | 11:19 | |
| *** ducttape_ has joined #openstack-horizon | 11:20 | |
| flwang1 | robcresswell: thanks a lot | 11:21 |
| flwang1 | robcresswell: Horizon team is still the coolest team in openstack, just like Zaqar ;) | 11:22 |
| robcresswell | :D | 11:22 |
| *** ducttape_ has quit IRC | 11:24 | |
| *** vishwanathj has quit IRC | 11:26 | |
| *** vishwanathj has joined #openstack-horizon | 11:26 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Rename Network QoS enabled file to prevent collision https://review.openstack.org/487817 | 11:52 |
| robcresswell | betherly: Can you put up a patch & relnote to disable qos panel by default? Its not ready yet | 12:01 |
| *** ducttape_ has joined #openstack-horizon | 12:07 | |
| betherly | robcresswell: why is it not ready yet? it doesnt have actions but the details and basic views are all there and working | 12:07 |
| robcresswell | betherly: Generally we don't count things as ready if you can't do anything other than list info | 12:08 |
| robcresswell | So we just disable them and mention in the release note that its available and its current capabilities | 12:08 |
| betherly | robcresswell: ok | 12:08 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: default to disabled https://review.openstack.org/487743 | 12:09 |
| *** catintheroof has joined #openstack-horizon | 12:11 | |
| *** yamamoto has quit IRC | 12:14 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Allow dropdowns to be in front of div.modal-footer https://review.openstack.org/389866 | 12:19 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Allow dropdowns to be in front of div.modal-footer https://review.openstack.org/389866 | 12:19 |
| *** ducttape_ has quit IRC | 12:19 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Allow dropdowns to be in front of div.modal-footer https://review.openstack.org/389866 | 12:23 |
| robcresswell | rdopiera, amotoki, flwang1: I updated https://review.openstack.org/#/c/389866/ | 12:23 |
| *** lblanchard has joined #openstack-horizon | 12:23 | |
| robcresswell | Would be nice if we can land that soon, hadn't realised it was still open till today | 12:23 |
| flwang1 | robcresswell: cool, i will give it a try | 12:24 |
| robcresswell | https://review.openstack.org/#/c/270461/ has also been ready for about a month, if anyone fancies merging that too. Was requested at last summit | 12:24 |
| rubasov | robcresswell: here's ps2: https://review.openstack.org/#/c/487743/2 | 12:25 |
| robcresswell | rubasov: +2+w | 12:25 |
| rubasov | robcresswell: appreciated, thanks a lot | 12:26 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Trunks panel: default to disabled https://review.openstack.org/487743 | 12:26 |
| robcresswell | rubasov: Updated the commit to fix the bp link, but then approved again. | 12:26 |
| robcresswell | betherly: Here's a reference: https://review.openstack.org/#/c/487743/ | 12:27 |
| robcresswell | betherly: If you could also rename it to 1510 to avoid the collision, that would be nice. Then I can abandon https://review.openstack.org/#/c/487817/ | 12:27 |
| rubasov | robcresswell: oh, thanks | 12:27 |
| robcresswell | np | 12:28 |
| betherly | robcresswell: sure | 12:29 |
| amotoki | robcresswell: do you change project-config to enable py27dj10 and disable py27dj11 (as py27 already covers it) ? | 12:33 |
| robcresswell | amotoki: It's on my list | 12:33 |
| robcresswell | got a few fixes that need to go in too. Well, not need, they can hit RC, but it would be nice to not FF with known issues. | 12:34 |
| robcresswell | rdopiera: thanks for review | 12:34 |
| *** ducttape_ has joined #openstack-horizon | 12:35 | |
| robcresswell | amotoki: Hmm, why isn't dj110 already running for Horizon? It's in the list :/ | 12:38 |
| amotoki | robcresswell: looking at project-config | 12:39 |
| -amotoki- - name: gate-horizon-tox-py27dj110-ubuntu-xenial | 12:41 | |
| -amotoki- branch: ^stable/(newton|ocata)$ | 12:41 | |
| amotoki | robcresswell: gate-horizon-tox-py27dj110-ubuntu-xenial is limited to stable branches now | 12:41 |
| robcresswell | ha, that should be *not* stable branches | 12:41 |
| robcresswell | It should be pike only, we did it this cycle | 12:42 |
| robcresswell | Queens should just be dj1.11, which is a nice cleanup | 12:43 |
| amotoki | looking at merded patches stable/newton around March, we had gate-horizon-tox-py27dj110-ubuntu-xenial for them | 12:43 |
| robcresswell | oh, we only bumped upper constraints now | 12:44 |
| robcresswell | but we had gate before | 12:44 |
| robcresswell | I remember | 12:44 |
| robcresswell | Why is stable *not* running 1.8? | 12:45 |
| amotoki | robcresswell: for example, https://review.openstack.org/#/c/442454/ | 12:45 |
| *** lblanchard has quit IRC | 12:45 | |
| robcresswell | yup | 12:45 |
| amotoki | py27 covers django 1.8 + py27dj19 + py27dj110 | 12:45 |
| robcresswell | ah ofc | 12:45 |
| amotoki | django version for py27 confuses us :( | 12:46 |
| robcresswell | yup | 12:46 |
| robcresswell | next cycle we can remove all the django jobs though and just run py27 | 12:46 |
| robcresswell | since its only 1.11 | 12:46 |
| amotoki | I wonder we can disable py27 and it might be better to have jobs with for individual versions. | 12:46 |
| robcresswell | amotoki: There's no need, since we will only have django version in 2 weeks time. | 12:48 |
| openstackgerrit | Beth Elwell proposed openstack/horizon master: QoS panel: default to disabled https://review.openstack.org/487832 | 12:48 |
| betherly | robcresswell: https://review.openstack.org/#/c/487832/ | 12:49 |
| *** lblanchard has joined #openstack-horizon | 12:49 | |
| *** ducttape_ has quit IRC | 12:49 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: QoS panel: default to disabled https://review.openstack.org/487832 | 12:50 |
| robcresswell | ty betherly | 12:50 |
| amotoki | robcresswell: okay. so what we need to have are: | 12:51 |
| amotoki | py27 only for queens, py27/py27dj19/py27dj110 for newton/ocata, py27/py27dj18/py27dj19/py27dj110 for pike | 12:51 |
| amotoki | right? | 12:51 |
| robcresswell | yes | 12:51 |
| robcresswell | amotoki: https://review.openstack.org/#/c/487834 | 12:51 |
| robcresswell | wait I deleted too much | 12:52 |
| openstackgerrit | Pascal Boutin proposed openstack/horizon master: Fix the error format of glance's createImage https://review.openstack.org/487592 | 12:52 |
| amotoki | robcresswell: yeah, you touched dj111 .... | 12:52 |
| *** ducttape_ has joined #openstack-horizon | 12:53 | |
| robcresswell | er wait, thats right though | 12:53 |
| robcresswell | we dont want dj111 anywhere | 12:53 |
| rdopiera | I think I found where all those <MagicMock> lines are coming from in tests | 12:53 |
| robcresswell | rdopiera: :o | 12:53 |
| amotoki | rdopiera: from mox3? | 12:53 |
| rdopiera | File "/home/rdopiera/dev/horizon/.tox/py27/lib/python2.7/site-packages/django/core/management/base.py", line 114, in write self._out.write(force_str(style_func(msg))) | 12:54 |
| rdopiera | basically django management commands are writing to stdout directly | 12:54 |
| openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: default to disabled https://review.openstack.org/487743 | 12:54 |
| rdopiera | self.stdout.write(output) | 12:54 |
| amotoki | ah... | 12:55 |
| rdopiera | I monkey-patched MagicMock to throw an exception on __repr__ | 12:55 |
| rdopiera | to find it | 12:55 |
| amotoki | if we drop --nocapture from test/settings, the MagicMock will go away as well, but I am not sure what -nocapture provides us a value | 12:55 |
| *** ratailor has quit IRC | 12:56 | |
| rubasov | robcresswell: here's the licensed, pep8 compatible version: https://review.openstack.org/#/c/487743/4 :-) | 12:56 |
| *** ratailor has joined #openstack-horizon | 12:56 | |
| robcresswell | 0.o weird that its requiring a license now... | 12:57 |
| robcresswell | but oka | 12:57 |
| robcresswell | okay* | 12:57 |
| *** ducttape_ has quit IRC | 12:57 | |
| rubasov | robcresswell: I was surprised too | 12:57 |
| *** ratailor has quit IRC | 12:57 | |
| *** lucasxu has joined #openstack-horizon | 13:03 | |
| robcresswell | rdopiera: I replied to your comments on https://review.openstack.org/#/c/270461 | 13:03 |
| openstackgerrit | Merged openstack/django_openstack_auth master: Updated from global requirements https://review.openstack.org/485609 | 13:08 |
| openstackgerrit | Merged openstack/django_openstack_auth master: Imported Translations from Zanata https://review.openstack.org/486982 | 13:08 |
| *** jamesbenson_ has joined #openstack-horizon | 13:13 | |
| *** yamamoto has joined #openstack-horizon | 13:14 | |
| *** jamesbenson_ has quit IRC | 13:17 | |
| robcresswell | rdopiera: If you try and do thing.foo = bar when bar isn't set, that'll error in Python | 13:20 |
| robcresswell | I think | 13:20 |
| robcresswell | thats why the codes using setattr, I would guess. | 13:21 |
| *** yamamoto has quit IRC | 13:21 | |
| rdopiera | robcresswell: nonsense | 13:22 |
| rdopiera | robcresswell: just try it | 13:22 |
| robcresswell | yeah, am doing | 13:22 |
| robcresswell | Yeah, NameError. | 13:22 |
| rdopiera | http://paste.openstack.org/show/616721/ | 13:23 |
| rdopiera | this works | 13:23 |
| rdopiera | what's your code? | 13:23 |
| robcresswell | rdopiera: Yeah but its not setting a value its setting a variable that may not exist. | 13:24 |
| *** jtriley has joined #openstack-horizon | 13:24 | |
| rdopiera | what's the code that fails for you? | 13:24 |
| rdopiera | not sure what you mean by "value" here | 13:24 |
| robcresswell | setattr takes an object, name, value | 13:25 |
| robcresswell | http://paste.openstack.org/show/616722/ | 13:25 |
| rdopiera | right | 13:25 |
| rdopiera | well, that will error with setattr as well | 13:25 |
| rdopiera | even before setattr is called | 13:25 |
| robcresswell | ah | 13:26 |
| robcresswell | setattr does not do what I thought it did. | 13:26 |
| rdopiera | it's just a function that calls __setattr__ | 13:26 |
| rdopiera | on the class | 13:26 |
| robcresswell | ah, I was thinking it would behave like get(), and just return some null item. | 13:27 |
| rdopiera | def setattr(obj, attr, val): obj.__class__.__setattr__(obj, attr, val) | 13:27 |
| *** yingjun_1 has joined #openstack-horizon | 13:27 | |
| rdopiera | (roughly, it actually uses MRO to get the proper __setattr__) | 13:28 |
| rdopiera | robcresswell: so I guess that NameError is another problem with that code that you found :) | 13:28 |
| robcresswell | yerp | 13:28 |
| rdopiera | but when the list is empty, the inside of the loop never executes, so it's fine | 13:28 |
| robcresswell | rdopiera: Hmm, if the first call passed but the second failed, wouyld that still happen? | 13:29 |
| robcresswell | Its 2 api calls in one try /ex | 13:29 |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Add the Snapshots tab on the Volume Details page https://review.openstack.org/270461 | 13:30 |
| robcresswell | bleurgh, anyway, I cant be bothered with nursing another patch | 13:30 |
| robcresswell | Thought it was complete but looks like it needs more work | 13:31 |
| robcresswell | rdopiera: Thanks for reviews anyway | 13:31 |
| rdopiera | robcresswell: sorry for nit-picking | 13:32 |
| robcresswell | rdopiera: No they're valid concerns; it was just a patch I adopted because it looked about done | 13:33 |
| robcresswell | rdopiera: But your python skillz > my python skillz :p | 13:33 |
| rdopiera | but it's just style stuff, the patch works | 13:35 |
| robcresswell | betherly: That qos path needs fixes btw | 13:36 |
| *** ducttape_ has joined #openstack-horizon | 13:38 | |
| openstackgerrit | Merged openstack/horizon master: Trunks panel: default to disabled https://review.openstack.org/487743 | 13:41 |
| *** yingjun_1 has quit IRC | 13:42 | |
| *** yingjun_1 has joined #openstack-horizon | 13:43 | |
| openstackgerrit | Pascal Boutin proposed openstack/horizon master: Fix the error format of glance's createImage https://review.openstack.org/487592 | 13:51 |
| *** udesale has quit IRC | 13:55 | |
| openstackgerrit | Pascal Boutin proposed openstack/horizon master: Makes the xstatic files lookup dynamic in the tests https://review.openstack.org/487862 | 14:04 |
| *** mvk has quit IRC | 14:06 | |
| openstackgerrit | Merged openstack/horizon master: Add the Snapshots tab on the Volume Details page https://review.openstack.org/270461 | 14:08 |
| *** yingjun_1 has quit IRC | 14:12 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: api.rest.neutron: Ensure dict is passed to api.neutron args https://review.openstack.org/487107 | 14:16 |
| *** lucasxu has quit IRC | 14:30 | |
| *** lucasxu has joined #openstack-horizon | 14:32 | |
| betherly | robcresswell: im in meetings the rest of today and off tomorrow. is it ok to wait until monday or shall i push on it? | 14:32 |
| *** brad[] has quit IRC | 14:33 | |
| *** brad[] has joined #openstack-horizon | 14:34 | |
| robcresswell | betherly: I'll fix it | 14:35 |
| betherly | robcresswell: sorry :/ im happy to work later tonight if its urgent to get through | 14:36 |
| robcresswell | betherly: Needs to be done before I tag really. | 14:36 |
| *** jeremy_moffitt has quit IRC | 14:37 | |
| betherly | robcresswell: when is that? | 14:37 |
| robcresswell | today | 14:37 |
| robcresswell | its cool im working on it | 14:38 |
| betherly | robcresswell: ok thanks so much. sorry about that!! | 14:38 |
| *** jeremy_moffitt has joined #openstack-horizon | 14:43 | |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Get rid of the <MagicMock> output when the tests run https://review.openstack.org/487880 | 14:46 |
| *** vishwanathj has quit IRC | 14:53 | |
| *** vishwanathj has joined #openstack-horizon | 14:54 | |
| *** lucasxu has quit IRC | 14:59 | |
| *** lucasxu has joined #openstack-horizon | 15:02 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: QoS panel: default to disabled https://review.openstack.org/487832 | 15:02 |
| robcresswell | amotoki: That doc8 check patch has messed up our releasenotes :( | 15:03 |
| *** rcernin has quit IRC | 15:03 | |
| amotoki | robcresswell: yeah, I noticed it and am exploring how we can do for it. | 15:04 |
| robcresswell | amotoki: Ah, thankyou | 15:04 |
| amotoki | robcresswell: reverting it does not solve us | 15:04 |
| amotoki | unreleased reno has a nice option which allows us to ignore specific files (or IDs) | 15:04 |
| robcresswell | doug might have a solution | 15:05 |
| amotoki | and I am waiting for the next release. | 15:05 |
| amotoki | i already talked with doug yesterday and he added the option as a workaround for nova. | 15:06 |
| amotoki | nova did the similar thing. | 15:06 |
| robcresswell | ah, gotcha | 15:06 |
| robcresswell | Okay, I have patches up to fix tests in project-config, and to raise minimum django_openstack_auth to 3.5.0 | 15:07 |
| robcresswell | Will tag horizon soon | 15:07 |
| amotoki | sorry for confusion. it really surprises me. | 15:07 |
| robcresswell | amotoki: No problem at all, I didnt notice it when I reviewed | 15:07 |
| robcresswell | amotoki: Do you have time ot review https://review.openstack.org/#/c/389866/ or is it too late? | 15:08 |
| amotoki | robcresswell: will review it soon | 15:08 |
| robcresswell | Thankyou | 15:08 |
| *** TravT has joined #openstack-horizon | 15:08 | |
| *** ChanServ sets mode: +v TravT | 15:08 | |
| *** ying_zuo has joined #openstack-horizon | 15:08 | |
| *** jamesbenson_ has joined #openstack-horizon | 15:11 | |
| *** wolverineav has quit IRC | 15:19 | |
| *** jamesbenson_ is now known as jamesbenson | 15:22 | |
| amotoki | robcresswell: thanks for the update of the modal css. I think it is a balance on the modal height vs browser height. | 15:23 |
| openstackgerrit | Merged openstack/horizon master: Add missing DOA config value to docs https://review.openstack.org/485580 | 15:27 |
| *** wolverineav has joined #openstack-horizon | 15:27 | |
| *** vishwanathj has quit IRC | 15:29 | |
| *** vishwanathj has joined #openstack-horizon | 15:29 | |
| amotoki | robcresswell: FYI: https://review.openstack.org/#/c/452725/ (launch instance with trunk port), I heard ethfci (the author of the patch) is working on UTs. Once a new patch set is coming, I will review it soon. | 15:31 |
| *** vishwana_ has joined #openstack-horizon | 15:33 | |
| *** vishwanathj has quit IRC | 15:33 | |
| *** wolverineav has quit IRC | 15:34 | |
| *** vishwana_ has quit IRC | 15:35 | |
| robcresswell | amotoki: I don't think it will be able to land in time, I need to tag soon :( | 15:35 |
| amotoki | robcresswell: no problem | 15:35 |
| *** vishwanathj has joined #openstack-horizon | 15:35 | |
| *** gyee has joined #openstack-horizon | 15:35 | |
| *** e0ne has quit IRC | 15:47 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Make default visibility option on create image modal configurable https://review.openstack.org/481794 | 15:49 |
| *** rmart04 has quit IRC | 15:50 | |
| *** rmart04 has joined #openstack-horizon | 15:50 | |
| *** lcastell has joined #openstack-horizon | 15:51 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Improve logic for volume snapshots tab https://review.openstack.org/487919 | 15:55 |
| robcresswell | rdopiera: ^^ that makes the logic a little safer after that issue you pointed out earlier, I think | 15:56 |
| *** ducttape_ has quit IRC | 15:56 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon master: Improve logic for volume snapshots tab https://review.openstack.org/487919 | 15:57 |
| openstackgerrit | Merged openstack/horizon master: Allow dropdowns to be in front of div.modal-footer https://review.openstack.org/389866 | 15:58 |
| *** ducttape_ has joined #openstack-horizon | 15:58 | |
| *** ducttape_ has quit IRC | 16:01 | |
| *** ducttape_ has joined #openstack-horizon | 16:01 | |
| *** lucasxu has quit IRC | 16:06 | |
| openstackgerrit | Merged openstack/horizon master: QoS panel: default to disabled https://review.openstack.org/487832 | 16:07 |
| *** rmart04 has quit IRC | 16:10 | |
| *** lblanchard has quit IRC | 16:16 | |
| *** gary-smith has quit IRC | 16:51 | |
| *** TravT_ has joined #openstack-horizon | 16:52 | |
| *** ChanServ sets mode: +v TravT_ | 16:52 | |
| *** TravT_ has quit IRC | 16:55 | |
| *** TravT has quit IRC | 16:55 | |
| openstackgerrit | Ying Zuo proposed openstack/horizon master: Make default visibility option on create image modal configurable https://review.openstack.org/481794 | 16:56 |
| *** rmart04 has joined #openstack-horizon | 17:01 | |
| *** rmart04 has quit IRC | 17:01 | |
| *** TravT has joined #openstack-horizon | 17:03 | |
| *** ChanServ sets mode: +v TravT | 17:03 | |
| *** lblanchard has joined #openstack-horizon | 17:05 | |
| *** harlowja has joined #openstack-horizon | 17:09 | |
| *** mvk has joined #openstack-horizon | 17:13 | |
| *** TravT has quit IRC | 17:15 | |
| *** rcernin has joined #openstack-horizon | 17:16 | |
| *** TravT has joined #openstack-horizon | 17:17 | |
| *** ChanServ sets mode: +v TravT | 17:17 | |
| *** masco_ has quit IRC | 17:24 | |
| openstackgerrit | Julie Gravel proposed openstack/horizon master: Theme Preview Page should include datepicker. https://review.openstack.org/318970 | 17:26 |
| robcresswell | Okay, I think that's everything, so I've tagged Horizon Pike-3 | 17:32 |
| robcresswell | https://review.openstack.org/#/c/487957/ is the release patch if anyone is interested :) | 17:33 |
| *** TravT has quit IRC | 17:42 | |
| *** TravT has joined #openstack-horizon | 17:46 | |
| *** ChanServ sets mode: +v TravT | 17:46 | |
| *** jtriley_ has joined #openstack-horizon | 17:49 | |
| *** jtriley has quit IRC | 17:52 | |
| *** jtriley_ has quit IRC | 17:55 | |
| *** jtriley has joined #openstack-horizon | 18:06 | |
| *** jamesbenson has quit IRC | 18:15 | |
| *** jamesbenson has joined #openstack-horizon | 18:16 | |
| openstackgerrit | Merged openstack/horizon master: Theme Preview Page should include datepicker. https://review.openstack.org/318970 | 18:21 |
| *** TravT has quit IRC | 18:33 | |
| *** TravT has joined #openstack-horizon | 18:36 | |
| *** ChanServ sets mode: +v TravT | 18:36 | |
| *** jamesbenson has quit IRC | 18:45 | |
| *** jamesbenson has joined #openstack-horizon | 18:50 | |
| *** TravT has quit IRC | 19:03 | |
| *** jamesbenson has quit IRC | 19:15 | |
| *** itxaka has quit IRC | 19:21 | |
| *** ducttap__ has joined #openstack-horizon | 19:25 | |
| *** ducttape_ has quit IRC | 19:25 | |
| *** TravT has joined #openstack-horizon | 19:25 | |
| *** ChanServ sets mode: +v TravT | 19:25 | |
| *** TravT has quit IRC | 19:29 | |
| *** ducttap__ has quit IRC | 19:32 | |
| *** vishwanathj has quit IRC | 19:34 | |
| *** vishwanathj has joined #openstack-horizon | 19:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth master: Updated from global requirements https://review.openstack.org/487990 | 19:44 |
| *** ducttape_ has joined #openstack-horizon | 19:50 | |
| *** e0ne has joined #openstack-horizon | 19:51 | |
| *** lblanchard has quit IRC | 20:05 | |
| *** TravT has joined #openstack-horizon | 20:09 | |
| *** ChanServ sets mode: +v TravT | 20:09 | |
| *** e0ne has quit IRC | 20:17 | |
| *** jtomasek has quit IRC | 20:19 | |
| *** makowals has quit IRC | 20:24 | |
| *** makowals has joined #openstack-horizon | 20:27 | |
| *** jrist has quit IRC | 20:28 | |
| *** jtomasek has joined #openstack-horizon | 20:36 | |
| *** flwang1 has quit IRC | 20:49 | |
| *** jtomasek has quit IRC | 20:49 | |
| *** jamesbenson has joined #openstack-horizon | 20:50 | |
| *** jrist has joined #openstack-horizon | 20:55 | |
| *** ducttap__ has joined #openstack-horizon | 20:59 | |
| *** vishwanathj has quit IRC | 21:01 | |
| *** vishwanathj has joined #openstack-horizon | 21:02 | |
| *** ducttape_ has quit IRC | 21:03 | |
| robcresswell | Alright! Pike-3 is now merged. amotoki ying_zuo rdopiera remember, no merging of features. If you're unsure whether something is a feature or a bugfix, just ping and ask. Anything that is a feature should be -2'd with a message about Pike Feature Freeze | 21:10 |
| ying_zuo | awesome! thanks Rob. | 21:11 |
| robcresswell | There's also a bunch of reviews open for stable/ocata, so we should review those if possible and tag a new version soon | 21:11 |
| *** yamamoto_ has joined #openstack-horizon | 21:13 | |
| ying_zuo | do those patches need one or two +1 to merge? | 21:15 |
| ying_zuo | I meant +2 | 21:15 |
| *** vishwanathj has quit IRC | 21:19 | |
| *** vishwanathj has joined #openstack-horizon | 21:20 | |
| *** yamamoto_ has quit IRC | 21:20 | |
| *** jtriley has quit IRC | 21:25 | |
| robcresswell | ying_zuo: If a member of stable team proposes the patch then one | 21:26 |
| robcresswell | If someone else proposes it, two | 21:26 |
| ying_zuo | cool. so this one can be merged right? https://review.openstack.org/#/c/486457/ | 21:27 |
| *** vishwanathj has quit IRC | 21:27 | |
| *** vishwanathj has joined #openstack-horizon | 21:28 | |
| *** vishwanathj has quit IRC | 21:28 | |
| *** vishwanathj has joined #openstack-horizon | 21:29 | |
| robcresswell | That one needs another stable review. I think it might just be me and amotoki now... Can't remember if rdopiera is on the team | 21:30 |
| *** vishwanathj has quit IRC | 21:32 | |
| ying_zuo | alright. thanks | 21:33 |
| *** vishwanathj has joined #openstack-horizon | 21:33 | |
| *** e0ne has joined #openstack-horizon | 21:37 | |
| *** jamesbenson has quit IRC | 21:42 | |
| *** ducttape_ has joined #openstack-horizon | 21:52 | |
| *** ducttap__ has quit IRC | 21:55 | |
| *** yamamoto has joined #openstack-horizon | 22:04 | |
| *** lbragstad has quit IRC | 22:08 | |
| *** e0ne has quit IRC | 22:09 | |
| *** flwang1 has joined #openstack-horizon | 22:21 | |
| *** rcernin has quit IRC | 22:26 | |
| *** catintheroof has quit IRC | 22:27 | |
| *** makowals has quit IRC | 22:34 | |
| *** openstack has joined #openstack-horizon | 22:46 | |
| *** jidar has joined #openstack-horizon | 22:47 | |
| *** lbragstad has joined #openstack-horizon | 22:47 | |
| *** kei1 has joined #openstack-horizon | 22:47 | |
| *** oomichi has joined #openstack-horizon | 22:47 | |
| *** jrist has quit IRC | 22:49 | |
| *** makowals has joined #openstack-horizon | 22:51 | |
| *** itlinux has joined #openstack-horizon | 23:03 | |
| *** pboutin has quit IRC | 23:07 | |
| openstackgerrit | Merged openstack/django_openstack_auth master: Updated from global requirements https://review.openstack.org/487990 | 23:09 |
| *** lbragstad has quit IRC | 23:12 | |
| *** jrist has joined #openstack-horizon | 23:24 | |
| *** ducttape_ has quit IRC | 23:29 | |
| *** jamesbenson has joined #openstack-horizon | 23:30 | |
| *** jamesbenson has quit IRC | 23:35 | |
| openstackgerrit | Feilong Wang proposed openstack/django_openstack_auth master: Fix region sticky issue https://review.openstack.org/483785 | 23:36 |
| *** catintheroof has joined #openstack-horizon | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!