Monday, 2017-10-02

*** TravT_ has joined #openstack-horizon00:00
*** TravT_ has quit IRC00:04
*** TravT has joined #openstack-horizon00:05
*** lnxnut has quit IRC00:07
*** TravT has quit IRC00:09
*** yamamoto has joined #openstack-horizon00:14
*** yamamoto has quit IRC00:14
*** yamamoto has joined #openstack-horizon00:14
*** dave-mccowan has joined #openstack-horizon00:15
*** yamamoto has quit IRC00:19
*** TravT has joined #openstack-horizon00:28
*** jamesbenson has joined #openstack-horizon00:34
*** TravT has quit IRC00:37
*** jamesbenson has quit IRC00:39
*** TravT has joined #openstack-horizon00:39
*** TravT has quit IRC00:40
*** TravT_ has joined #openstack-horizon00:40
*** TravT_ has quit IRC00:44
*** TravT has joined #openstack-horizon00:46
*** TravT has quit IRC00:53
*** TravT has joined #openstack-horizon00:55
*** TravT has quit IRC00:57
*** TravT_ has joined #openstack-horizon00:57
*** TravT_ has quit IRC00:58
*** TravT has joined #openstack-horizon00:58
*** jtriley has quit IRC01:07
*** TravT has quit IRC01:09
*** TravT has joined #openstack-horizon01:11
*** TravT has quit IRC01:15
*** yamamoto has joined #openstack-horizon01:19
*** yamamoto has quit IRC01:25
*** TravT has joined #openstack-horizon01:26
*** dave-mccowan has quit IRC01:30
*** dave-mccowan has joined #openstack-horizon01:32
*** TravT has quit IRC01:32
*** TravT has joined #openstack-horizon01:33
*** lnxnut has joined #openstack-horizon01:34
*** hoangcx has joined #openstack-horizon01:38
*** TravT has quit IRC01:41
*** TravT_ has joined #openstack-horizon01:41
*** TravT has joined #openstack-horizon01:46
*** TravT_ has quit IRC01:46
*** dave-mcc_ has joined #openstack-horizon01:48
*** TravT_ has joined #openstack-horizon01:50
*** TravT has quit IRC01:50
*** dave-mccowan has quit IRC01:51
*** jtriley has joined #openstack-horizon01:55
*** TravT_ has quit IRC01:56
*** TravT has joined #openstack-horizon01:56
*** dave-mccowan has joined #openstack-horizon01:57
*** dave-mcc_ has quit IRC01:59
*** TravT has quit IRC02:00
*** lnxnut has quit IRC02:01
*** shu-mutou-AWAY is now known as shu-mutou02:01
*** TravT has joined #openstack-horizon02:01
*** TravT has quit IRC02:03
*** TravT_ has joined #openstack-horizon02:03
*** TravT_ has quit IRC02:07
*** TravT has joined #openstack-horizon02:08
*** TravT has quit IRC02:13
*** TravT has joined #openstack-horizon02:13
*** dave-mcc_ has joined #openstack-horizon02:17
*** dave-mccowan has quit IRC02:18
*** yamamoto has joined #openstack-horizon02:21
*** TravT has quit IRC02:22
*** TravT has joined #openstack-horizon02:24
*** gyee has joined #openstack-horizon02:27
*** yamamoto has quit IRC02:27
*** gyee has quit IRC02:38
*** jtriley has quit IRC02:41
*** TravT has quit IRC02:44
*** TravT has joined #openstack-horizon02:49
*** TravT has quit IRC02:54
*** TravT has joined #openstack-horizon02:55
*** dave-mcc_ has quit IRC02:55
*** TravT has quit IRC02:55
*** TravT has joined #openstack-horizon02:56
*** TravT has quit IRC03:00
*** TravT has joined #openstack-horizon03:01
*** TravT has quit IRC03:16
*** TravT has joined #openstack-horizon03:20
*** jtriley has joined #openstack-horizon03:20
*** yamamoto has joined #openstack-horizon03:23
*** TravT has quit IRC03:23
*** TravT has joined #openstack-horizon03:24
*** lnxnut has joined #openstack-horizon03:28
*** TravT has quit IRC03:28
*** yamamoto has quit IRC03:29
*** TravT has joined #openstack-horizon03:29
*** TravT has quit IRC03:41
*** TravT_ has joined #openstack-horizon03:41
*** TravT_ has quit IRC03:45
*** TravT has joined #openstack-horizon03:46
*** TravT has quit IRC03:48
*** TravT_ has joined #openstack-horizon03:48
*** TravT_ has quit IRC03:52
*** TravT has joined #openstack-horizon03:53
*** lnxnut has quit IRC03:55
*** TravT_ has joined #openstack-horizon03:57
*** TravT has quit IRC03:58
*** flwang1 has quit IRC04:01
*** TravT_ has quit IRC04:01
*** TravT has joined #openstack-horizon04:02
*** TravT has quit IRC04:04
*** TravT_ has joined #openstack-horizon04:04
*** jtriley has quit IRC04:10
*** TravT has joined #openstack-horizon04:12
*** TravT_ has quit IRC04:12
*** TravT has quit IRC04:16
*** TravT has joined #openstack-horizon04:17
*** TravT has quit IRC04:23
*** yamamoto has joined #openstack-horizon04:25
*** TravT has joined #openstack-horizon04:26
*** yamamoto has quit IRC04:29
*** TravT has quit IRC04:30
*** TravT has joined #openstack-horizon04:38
*** TravT has quit IRC04:45
*** jtriley has joined #openstack-horizon04:46
*** TravT has joined #openstack-horizon04:48
*** TravT has quit IRC04:52
*** TravT has joined #openstack-horizon04:53
*** TravT has quit IRC04:57
*** TravT has joined #openstack-horizon04:58
*** TravT has quit IRC05:11
*** logan- has quit IRC05:18
*** TravT has joined #openstack-horizon05:19
*** logan- has joined #openstack-horizon05:21
*** lnxnut has joined #openstack-horizon05:22
*** yamamoto has joined #openstack-horizon05:26
*** yamamoto has quit IRC05:31
*** jtriley has quit IRC05:37
*** TravT has quit IRC05:41
*** ethfci has joined #openstack-horizon05:42
*** TravT has joined #openstack-horizon05:42
*** TravT has quit IRC05:46
*** logan- has quit IRC05:48
*** lnxnut has quit IRC05:50
*** TravT has joined #openstack-horizon05:51
*** logan- has joined #openstack-horizon05:53
*** TravT has quit IRC05:56
*** TravT_ has joined #openstack-horizon05:56
*** cshen has joined #openstack-horizon06:02
*** TravT_ has quit IRC06:07
*** jtriley has joined #openstack-horizon06:11
*** TravT has joined #openstack-horizon06:16
*** cshen has quit IRC06:20
*** TravT has quit IRC06:20
*** TravT_ has joined #openstack-horizon06:20
*** cshen has joined #openstack-horizon06:21
*** TravT_ has quit IRC06:23
*** TravT has joined #openstack-horizon06:23
*** jtomasek has joined #openstack-horizon06:24
*** lajoskatona has joined #openstack-horizon06:27
*** TravT has quit IRC06:27
*** TravT has joined #openstack-horizon06:27
*** yamamoto has joined #openstack-horizon06:28
*** TravT has quit IRC06:32
*** yamamoto has quit IRC06:33
*** TravT has joined #openstack-horizon06:33
*** TravT has quit IRC06:43
*** TravT has joined #openstack-horizon06:44
*** TravT has quit IRC06:44
*** TravT_ has joined #openstack-horizon06:45
*** TravT_ has quit IRC06:49
*** TravT has joined #openstack-horizon06:49
*** TravT has quit IRC06:55
*** TravT_ has joined #openstack-horizon06:55
*** itxaka has joined #openstack-horizon06:58
*** TravT_ has quit IRC06:59
*** TravT has joined #openstack-horizon07:00
*** TravT has quit IRC07:01
*** TravT_ has joined #openstack-horizon07:01
*** rcernin has joined #openstack-horizon07:04
*** jtriley has quit IRC07:06
*** pcaruana has joined #openstack-horizon07:08
*** lnxnut has joined #openstack-horizon07:17
*** tesseract has joined #openstack-horizon07:22
openstackgerritMarek Lyčka proposed openstack/horizon master: Show a better error message for network delete failure  https://review.openstack.org/50881507:28
*** TravT_ has quit IRC07:29
*** mrch has joined #openstack-horizon07:29
*** yamamoto has joined #openstack-horizon07:29
*** TravT has joined #openstack-horizon07:30
openstackgerritMarek Lyčka proposed openstack/horizon master: Show a better error message for network delete failure  https://review.openstack.org/50881507:32
*** rmart04 has joined #openstack-horizon07:33
*** TravT has quit IRC07:34
*** yamamoto has quit IRC07:36
*** TravT has joined #openstack-horizon07:36
*** TravT has quit IRC07:37
*** TravT_ has joined #openstack-horizon07:37
*** jtriley has joined #openstack-horizon07:39
*** lnxnut has quit IRC07:44
*** yamamoto has joined #openstack-horizon07:45
*** TravT_ has quit IRC07:45
*** TravT has joined #openstack-horizon07:46
*** ircuser-1 has joined #openstack-horizon07:46
*** TravT has quit IRC07:50
*** jpich has joined #openstack-horizon07:50
*** TravT has joined #openstack-horizon07:50
*** TravT has quit IRC08:00
*** TravT has joined #openstack-horizon08:01
*** TravT has quit IRC08:05
*** TravT has joined #openstack-horizon08:06
*** TravT has quit IRC08:07
*** TravT_ has joined #openstack-horizon08:08
*** TravT_ has quit IRC08:11
*** lnxnut has joined #openstack-horizon08:11
*** lnxnut has quit IRC08:15
*** TravT has joined #openstack-horizon08:16
*** jgravel has quit IRC08:17
*** gary-smith has quit IRC08:18
*** jeremy_moffitt has quit IRC08:18
*** TravT has quit IRC08:20
*** TravT has joined #openstack-horizon08:21
*** TravT has quit IRC08:25
*** TravT has joined #openstack-horizon08:25
*** jeremy_moffitt has joined #openstack-horizon08:26
*** gary-smith has joined #openstack-horizon08:26
*** belmoreira has joined #openstack-horizon08:32
*** TravT_ has joined #openstack-horizon08:36
*** TravT has quit IRC08:36
*** jtriley has quit IRC08:37
*** mdavidson has joined #openstack-horizon08:37
*** TravT_ has quit IRC08:40
*** TravT has joined #openstack-horizon08:40
*** TravT has quit IRC08:53
*** yamamoto has quit IRC08:56
*** TravT has joined #openstack-horizon08:56
*** TravT has quit IRC09:00
*** TravT has joined #openstack-horizon09:01
*** TravT has quit IRC09:08
*** lnxnut has joined #openstack-horizon09:13
*** jtriley has joined #openstack-horizon09:16
*** TravT has joined #openstack-horizon09:17
*** e0ne has joined #openstack-horizon09:18
*** kei-ichi has quit IRC09:20
*** TravT has quit IRC09:21
*** kei-ichi has joined #openstack-horizon09:21
*** TravT has joined #openstack-horizon09:23
*** tosky has joined #openstack-horizon09:23
*** rmart04_ has joined #openstack-horizon09:30
*** rmart04 has quit IRC09:31
*** rmart04_ is now known as rmart0409:31
*** TravT has quit IRC09:36
*** TravT has joined #openstack-horizon09:37
*** rmart04_ has joined #openstack-horizon09:38
*** TravT has quit IRC09:38
*** TravT has joined #openstack-horizon09:38
*** rmart04 has quit IRC09:38
*** rmart04_ is now known as rmart0409:38
*** lnxnut has quit IRC09:39
*** TravT has quit IRC09:42
*** TravT has joined #openstack-horizon09:47
*** belmoreira has quit IRC09:49
*** TravT has quit IRC09:52
*** TravT_ has joined #openstack-horizon09:52
*** yamamoto has joined #openstack-horizon09:56
*** TravT_ has quit IRC10:01
*** yamamoto has quit IRC10:02
*** TravT has joined #openstack-horizon10:02
*** TravT has quit IRC10:04
*** TravT_ has joined #openstack-horizon10:04
*** lnxnut has joined #openstack-horizon10:07
*** shu-mutou is now known as shu-mutou-AWAY10:08
*** lnxnut has quit IRC10:11
*** jgravel has joined #openstack-horizon10:15
*** TravT_ has quit IRC10:18
*** TravT has joined #openstack-horizon10:18
*** jtriley has quit IRC10:20
*** TravT has quit IRC10:24
*** TravT has joined #openstack-horizon10:29
e0neamotoki: hi. are you around?10:32
*** TravT has quit IRC10:33
*** jtriley has joined #openstack-horizon10:45
ethfciHello e0ne10:50
e0neethfci: hi10:50
ethfciHave You had time to check https://review.openstack.org/#/c/498018/ ?10:51
e0neethfci: no, I didn't test the latest version. I'm going to do it later today10:51
*** TravT has joined #openstack-horizon10:52
ethfciCool, thanks. I have contacted Jeremy Stanley to fix legacy-selenium-headless10:53
*** TravT has quit IRC10:56
*** TravT has joined #openstack-horizon10:57
*** yamamoto has joined #openstack-horizon10:58
*** TravT has quit IRC11:01
*** TravT has joined #openstack-horizon11:01
*** yamamoto has quit IRC11:04
*** TravT has quit IRC11:06
*** TravT has joined #openstack-horizon11:07
*** dave-mccowan has joined #openstack-horizon11:07
*** lnxnut has joined #openstack-horizon11:08
*** TravT has quit IRC11:10
*** TravT_ has joined #openstack-horizon11:11
*** TravT_ has quit IRC11:15
*** yamamoto has joined #openstack-horizon11:17
*** TravT has joined #openstack-horizon11:17
*** yamamoto has quit IRC11:18
*** TravT has quit IRC11:18
*** TravT has joined #openstack-horizon11:18
*** TravT has quit IRC11:23
*** mrunge has quit IRC11:24
*** rubasov has joined #openstack-horizon11:24
*** mrunge has joined #openstack-horizon11:24
*** yamamoto has joined #openstack-horizon11:28
*** TravT has joined #openstack-horizon11:28
*** belmoreira has joined #openstack-horizon11:32
*** lnxnut has quit IRC11:36
*** rmart04_ has joined #openstack-horizon11:37
*** rmart04 has quit IRC11:39
*** rmart04_ is now known as rmart0411:39
*** TravT has quit IRC11:39
*** TravT has joined #openstack-horizon11:40
*** rmart04_ has joined #openstack-horizon11:42
*** yamamoto has quit IRC11:43
*** rmart04 has quit IRC11:44
*** rmart04_ is now known as rmart0411:44
*** yamamoto has joined #openstack-horizon11:45
*** jtriley has quit IRC11:48
openstackgerritMarek Lyčka proposed openstack/horizon master: Show a better error message for network delete failure  https://review.openstack.org/50881511:49
*** TravT has quit IRC11:51
*** TravT has joined #openstack-horizon11:52
*** TravT has quit IRC11:57
*** TravT_ has joined #openstack-horizon11:57
*** yamamoto has quit IRC11:59
*** yamamoto has joined #openstack-horizon12:02
*** lnxnut has joined #openstack-horizon12:03
*** TravT has joined #openstack-horizon12:03
*** TravT_ has quit IRC12:05
*** catintheroof has joined #openstack-horizon12:06
*** catinthe_ has joined #openstack-horizon12:07
*** catintheroof has quit IRC12:08
*** TravT has quit IRC12:13
*** TravT has joined #openstack-horizon12:14
*** jtriley has joined #openstack-horizon12:15
*** TravT has quit IRC12:17
*** TravT_ has joined #openstack-horizon12:17
*** lnxnut has quit IRC12:21
*** TravT_ has quit IRC12:21
*** yamamoto has quit IRC12:26
*** rmart04 has quit IRC12:30
*** TravT has joined #openstack-horizon12:31
*** TravT has quit IRC12:32
*** TravT_ has joined #openstack-horizon12:32
*** TravT_ has quit IRC12:36
*** TravT has joined #openstack-horizon12:48
*** TravT_ has joined #openstack-horizon12:53
*** TravT has quit IRC12:53
*** TravT_ has quit IRC12:57
*** TravT has joined #openstack-horizon12:58
*** tosky_ has joined #openstack-horizon13:01
*** tosky has quit IRC13:01
*** tosky_ is now known as tosky13:01
*** TravT has quit IRC13:02
*** TravT has joined #openstack-horizon13:03
*** scottda_ has joined #openstack-horizon13:03
*** TravT has quit IRC13:05
*** TravT_ has joined #openstack-horizon13:06
*** lbragstad has joined #openstack-horizon13:07
*** lblanchard has joined #openstack-horizon13:08
*** erlon has joined #openstack-horizon13:11
*** TravT_ has quit IRC13:14
*** yamamoto has joined #openstack-horizon13:15
*** TravT has joined #openstack-horizon13:15
*** rmart04 has joined #openstack-horizon13:15
*** lnxnut has joined #openstack-horizon13:19
*** yamamoto has quit IRC13:21
*** TravT has quit IRC13:23
*** TravT has joined #openstack-horizon13:24
*** TravT has quit IRC13:25
*** TravT_ has joined #openstack-horizon13:25
*** belmoreira has quit IRC13:31
*** mrch has quit IRC13:31
*** mrch has joined #openstack-horizon13:32
*** belmoreira has joined #openstack-horizon13:33
*** mrch has quit IRC13:33
*** TravT_ has quit IRC13:33
*** lucasxu has joined #openstack-horizon13:34
*** TravT has joined #openstack-horizon13:38
*** Anticimex has quit IRC13:40
*** TravT has quit IRC13:41
*** Anticimex has joined #openstack-horizon13:41
*** TravT has joined #openstack-horizon13:41
openstackgerritLajos Katona proposed openstack/horizon master: Redirect back if deleting from image details  https://review.openstack.org/49086813:43
*** lnxnut has quit IRC13:45
*** TravT has quit IRC13:46
*** marlinc has quit IRC13:46
*** wolverineav has joined #openstack-horizon13:49
*** yamamoto has joined #openstack-horizon13:50
*** yamamoto_ has joined #openstack-horizon13:50
*** yamamoto has quit IRC13:54
*** marlinc has joined #openstack-horizon13:54
*** lajoskatona has quit IRC13:59
*** TravT has joined #openstack-horizon14:14
*** TravT has quit IRC14:18
*** TravT has joined #openstack-horizon14:19
*** mrch has joined #openstack-horizon14:20
*** belmoreira has quit IRC14:36
*** belmoreira has joined #openstack-horizon14:38
*** jamesbenson has joined #openstack-horizon14:38
*** jamesbenson has quit IRC14:43
*** rmart04_ has joined #openstack-horizon14:46
*** tesseract has quit IRC14:46
*** rmart04 has quit IRC14:49
*** rmart04_ is now known as rmart0414:49
*** wolverineav has quit IRC14:49
openstackgerritTyler Smith proposed openstack/horizon master: Adds extensible header functionality  https://review.openstack.org/48489914:50
*** gyee has joined #openstack-horizon14:53
*** wolverineav has joined #openstack-horizon14:56
*** wolverineav has quit IRC15:00
*** wolverineav has joined #openstack-horizon15:00
*** mrch has quit IRC15:02
*** itxaka has quit IRC15:04
*** wolverineav has quit IRC15:05
*** mvk has quit IRC15:06
*** tesseract has joined #openstack-horizon15:07
*** jamesbenson has joined #openstack-horizon15:11
*** lnxnut has joined #openstack-horizon15:13
*** rmart04 has quit IRC15:13
*** pcaruana has quit IRC15:27
*** cshen has quit IRC15:31
*** e0ne has quit IRC15:31
*** dave-mccowan has quit IRC15:32
*** lnxnut has quit IRC15:32
*** dave-mcc_ has joined #openstack-horizon15:32
*** lennyb_ has joined #openstack-horizon15:36
*** lennyb_ has quit IRC15:36
*** rcernin has quit IRC15:41
openstackgerritMarek Lyčka proposed openstack/horizon master: Show a better error message for network delete failure  https://review.openstack.org/50881515:47
*** scottda_ has quit IRC16:03
*** chlong has joined #openstack-horizon16:06
*** belmoreira has quit IRC16:13
*** lnxnut has joined #openstack-horizon16:30
*** jtomasek has quit IRC16:32
*** yamamoto_ has quit IRC16:34
*** yamamoto has joined #openstack-horizon16:39
*** lnxnut has quit IRC16:43
*** dave-mcc_ has quit IRC16:46
*** jamesbenson has quit IRC16:53
*** jamesbenson has joined #openstack-horizon16:54
*** chlong has quit IRC16:58
*** jpich has quit IRC16:59
*** dklyle has joined #openstack-horizon17:00
*** ChanServ sets mode: +o dklyle17:00
*** jamesbenson has quit IRC17:01
*** david-lyle has quit IRC17:02
*** jamesbenson has joined #openstack-horizon17:02
*** harlowja has joined #openstack-horizon17:10
*** chlong has joined #openstack-horizon17:15
*** chlong has quit IRC17:30
*** tosky has quit IRC17:31
*** chlong has joined #openstack-horizon17:31
*** e0ne has joined #openstack-horizon17:33
*** lnxnut has joined #openstack-horizon17:40
*** flwang1 has joined #openstack-horizon17:52
flwang1robcresswell: ping17:52
flwang1ying_zuo: do you have a moment to discuss a performance issue?17:53
ying_zuoflwang1: yes17:54
*** lnxnut has quit IRC17:55
flwang1ying_zuo: cool. now we're experiencing some performance issues of horizon. the typical one is instance panel loading is very slow17:55
*** tesseract has quit IRC17:55
flwang1sometimes take 8-10 secs17:55
ying_zuowith how many instances?17:55
flwang16517:56
ying_zuoalright. I was curious17:56
flwang1but we do have a lot instances in DB, given we're a public cloud17:57
ying_zuoyes, the performance of instances panel is not good17:57
ying_zuothat's why the blueprint to angularize it is high priority https://blueprints.launchpad.net/horizon/+spec/angularize-instances-table17:57
flwang1and like one of our team members asked in this channel before, we found the allowed() method of instance actions taking some extra time, like 2-3 seconds, do you think it's reasonable?17:57
ying_zuowe have to do the checking to show/hide the actions though17:59
*** tosky has joined #openstack-horizon17:59
flwang1i see. so the main purpose of that blueprint is angularize those 'actions', right?17:59
ying_zuono. the whole panel17:59
ying_zuobut unfortunately, nobody is working on it at the moment...17:59
flwang1:(18:00
ying_zuodo you see a way to optimize the allowed method?18:00
flwang1https://review.openstack.org/#/c/430029/3 that's one of our team members proposed before18:01
flwang1we're trying to provide a config in settings to bypass all the check, and leave the decision to the service API server18:01
flwang1that's not the best solution, but at least it can provide an option to the cloud ops/admin to improve the performance if that does really matter for them18:02
*** nikhil has joined #openstack-horizon18:04
e0neflwang1: hi. do you have any profiler results or filed bug?18:05
ying_zuoso this is just for the checking for the launch instance action18:05
e0neflwang1: I'm interesting in performance improvements too18:05
ying_zuoI wonder how much improvement this can make18:05
flwang1e0ne: we did the test with the built in horizon profiling and i'm going to use the profiling tool of chrome18:06
*** dklyle is now known as david-lyle18:06
e0neflwang1: it would be great if you share your results18:06
david-lyleying_zuo, the cost of the quota API call essentially18:06
ying_zuothere are a lot of actions on instances panel and they all need checking so I think that's causing the performance issue for the panel18:06
flwang1ying_zuo: yep, that's the patch proposed, but we're trying to use the idea to bypass all actions. hence why i want to discuss with you ;)18:06
david-lylequota is the only one making an API call18:07
flwang1quota is the only one18:07
flwang1and the others are policy check18:07
david-lyleright, quota is a mess18:07
flwang1but i think there is a "bug" in the policy check otherwise it shoudn't take 2-3 secs18:08
e0ne+118:08
ying_zuocool. sounds like you already got a +2 from david-lyle for the direction :)18:08
flwang1though for each instance there are 15+ actions, and horizon have 20 instances per page18:08
e0ne:)18:08
ying_zuowhy was patch abandoned?18:08
*** rmart04 has joined #openstack-horizon18:09
flwang1i asked my team members the same question, but he forgot :D18:09
flwang1so i'm here to get comments from you folks to see if that's the still the way we can go for now18:09
flwang1especially given nobody taking the angularize blueprint18:10
e0neying_zuo:  that patch disables  all quotas checks via the config. I don't think it's a good way to fix performancce18:10
flwang1david-lyle: are you happy with the idea adding a new config to bypass the check?18:10
e0neflwang1, david-lyle: I'm not a core, but I'll vote -1 for it18:11
flwang1and BTW, the quota check is making the login slow as well18:11
flwang1e0ne: i'm listening...18:11
ying_zuo@e0ne probably not a long-term fix but I am okay with giving the user the options18:12
david-lylejust a sec on the phone18:12
e0neonce we'll introduce such option, we'll have move confused users, IMO18:13
*** rmart04 has quit IRC18:13
e0neand than we'll have to follow deprecation policy to remove such option18:13
e0neI would like to see profiler results firs, to understand what actual quotas code is slow18:14
flwang1e0ne: TBH, i don't think follow deprecation policy is a problem18:14
flwang1e0ne: as I mentioned above, not only the quota check, but the allowed() check18:14
e0neflwang1: technically, it's not. but it's not user- or operators-friendly18:14
e0neflwang1: that makes confusion bigger: OPENSTACK_BUTTON_QUOTA_CHECK name doesn't tell me anything about policies18:15
flwang1let's say 10 -  30ms per check, 20+ actions per instance, so for each instance, it will take around 300ms18:16
flwang1and we have 20 instance per page18:16
flwang1above calculation is not accurate, but you got the idea18:17
e0neflwang1: again, I would like to see profiler results first18:17
e0neflwang1: maybe we can add some caching there and it will help us18:17
flwang15ms per check * 20 actions * 20 instances = 2 sec18:18
flwang1you even don't need a profiling18:19
e0neflwang1: what exactly checks do you mean?18:19
e0neI do agree that we've got performance issues18:19
flwang1allowed()18:19
e0neI don't agree that disabling checks is a good idea18:19
e0neI need to take a look on the code and test it on my lab18:19
flwang1e0ne: it would be great18:20
e0neI can't say anything about this w/o profiling18:20
e0neflwang1: I can do it on Wed only18:20
flwang1that's ok, take your time18:20
e0neflwang1: np. thanks for bringing this up18:21
flwang1i know we always like a perfect solution ;)18:21
flwang1but we do have some constricts18:21
e0ne:)18:22
e0ne+118:22
flwang1and I don't think hide the 'Launch instnace' button on instance panel based on the quota is a good idea, for me, TBH, it's a like a over-engineering idea18:23
flwang1because you never know the real-time quota status until you click the button18:24
flwang1ying_zuo: ^18:24
flwang1because, though horizon can show the button based on the quota status when user load the page,  but the user may take 1-3 mins on the pages to view or even delete some instances to release the quota. and some other users in the same tenant may create/delete instances as well. so I don't think the "pre-check quota" to decide if show the 'launch instance' button is reasonable. Please let me know if I missed something.18:27
ying_zuoflwang1: I think that's helpful. and we do that for other create actions too18:27
*** itlinux has joined #openstack-horizon18:28
ying_zuoI agree it can not be very accurate but if the user already used up the quota, it's helpful to disable the action so they don't need to find out after filling in all the info.18:28
david-lyleflwang1, I would be fine with removing the quota check on launch instance, the very next thing that happens when you open the dialog is a quota check anyway18:28
david-lylethere is not much lost in opening a dialog18:29
david-lyleI think only if the user doesn't have permission should the launch button be hidden on the table view18:29
* e0ne needs to take a break to sleep. will read the conversation tomorrow18:29
*** e0ne has quit IRC18:30
robcresswellflwang: Come ooooon, you know better than to leave empty pings :p18:30
robcresswellWhat's up18:30
ying_zuodavid-lyle: is it just for the launch instance modal, or the other create actions too?18:30
david-lyleI'm not a fan of the special case setting to disable though, that feels like a large band-aid for a more fundamental problem18:30
david-lyleying_zuo, definitely for launch instance, not sure about the others18:31
david-lyle but given django's flow front loading a bunch of API calls is not ideal18:32
ying_zuoif the quota check is done when the modal is open, I think we should remove the additional quota check just to disable the button then especially when it's so costly.18:32
*** yamamoto has quit IRC18:37
*** wolverineav has joined #openstack-horizon18:39
flwang1robcresswell: see above logs :)18:40
flwang1robcresswell: sorry for another empty ping18:40
robcresswellflwang1: Yeah, my client was playing catchup for some reason18:40
robcresswellI dunno why that message only just went18:40
robcresswellSorry about that18:41
flwang1robcresswell: we're discussing this patch https://review.openstack.org/#/c/430029/318:44
flwang1and related performance issue18:45
*** chlong has quit IRC18:45
robcresswellHappy to fix the related issue18:45
robcresswellI dont like that fix though (for the same reasons in the previous comment)18:45
flwang1I don't want to make the discussion lost focus, but another thing i'd like to see is when the image panel loads images, could we get a 'loading' icon somewhere?18:46
flwang1robcresswell: no, i think the latest idea is totally remove the quota check for the launch instance button18:46
*** chlong has joined #openstack-horizon18:46
flwang1let me summarize the current topics:   1. could we just remove the quota check for 'launch instance' button  2. could we add a new config setting to bypass all policy checks for allowed() (actions of row)  3. could we add an icon somewhere when the image panel loading images, because it may take 3-5 seconds if there are too much images, which may confuse the user with an empty table.18:49
flwang1above list are basically the questions I'd like to discuss today18:50
*** lnxnut has joined #openstack-horizon18:52
*** rcernin has joined #openstack-horizon18:54
ying_zuomy vote: 1) +1 if the quota check is done when the modal is open. 2) -1 we need the policy checks. 3) +1 please open a bug report18:56
*** dave-mccowan has joined #openstack-horizon18:59
robcresswellflwang1: Yeah, loading is a trivial thing and we should do that anyway18:59
flwang1ying_zuo: robcresswell: awesome,  thanks for the feedback18:59
robcresswellI'm not a big fan of 2), its just a workaround again18:59
flwang1robcresswell: like i said many times in this channel, this is my fav channel in openstack community19:00
robcresswell:D19:00
flwang1robcresswell: i will provide more information about the #2, and will open a bug to track this19:00
robcresswellw/ regard to 1... I am not sure. It still feels like a heavy handed solution to backend code being slow.19:01
flwang1a quick question for angularjs expert, is it possible to apply the policy check in js instead of in Django?19:01
robcresswellyou'd need to rewrite the panel, tbh19:02
flwang1robcresswell: :( i don't have the skill :(19:02
flwang1i have to head to office, ttyl, this is the most <3 channel i have found in openstack19:03
flwang1and Zaqar channel as well19:03
*** e0ne has joined #openstack-horizon19:03
robcresswello/ have a good day19:03
*** e0ne has quit IRC19:03
*** flwang1 has quit IRC19:04
*** lnxnut has quit IRC19:05
*** chlong_ has joined #openstack-horizon19:09
*** e0ne has joined #openstack-horizon19:14
*** itlinux has quit IRC19:26
*** e0ne has quit IRC19:26
*** e0ne has joined #openstack-horizon19:27
*** e0ne has quit IRC19:27
*** e0ne has joined #openstack-horizon19:27
*** e0ne has quit IRC19:28
*** e0ne has joined #openstack-horizon19:29
*** e0ne has quit IRC19:29
*** e0ne has joined #openstack-horizon19:30
*** e0ne has quit IRC19:30
*** e0ne has joined #openstack-horizon19:31
*** e0ne has quit IRC19:32
*** e0ne has joined #openstack-horizon19:33
*** e0ne has quit IRC19:33
*** yamamoto has joined #openstack-horizon19:38
*** yamamoto has quit IRC19:44
*** catinthe_ has quit IRC19:47
*** catintheroof has joined #openstack-horizon19:48
*** lnxnut has joined #openstack-horizon20:03
*** flwang1 has joined #openstack-horizon20:11
*** itlinux has joined #openstack-horizon20:13
*** dave-mcc_ has joined #openstack-horizon20:14
*** dave-mccowan has quit IRC20:16
*** dave-mcc_ is now known as dave-mccowan20:17
*** lnxnut has quit IRC20:21
*** lblanchard has quit IRC20:23
flwang1robcresswell: ying_zuo: still around? i have question about the log of horizon20:35
ying_zuoyes20:35
flwang1i'm trying to debug/profiling horizon, but i can't find how to enable a log for a particular plugin or code20:36
flwang1for example, i'm trying to add a debug log at here https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L13120:36
ying_zuodebug mode is on right?20:37
flwang1ying_zuo: i found the problem, though https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L568 is using DEBUG, but  https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L555 is using INFO20:40
flwang1but if https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L555 is set to DEBUG, there will be too much logs20:40
flwang1how can I only enable the DEBUG log of horizon but still keep the INFO for console handler?20:41
ying_zuothat's probably why. I have it set to DEBUG locally.20:41
ying_zuoI think you will need to set console as DEBUG too20:43
flwang1but after enabling that, i saw a lot of error like this "VariableDoesNotExist: Failed lookup for key [is_table_action] in u'[{\'False\': False, \'None\': None, \'True\': True}, {\'x_trace_info\': \'{"X-Trace-HMAC": ""20:55
flwang1any idea?20:55
*** mvk has joined #openstack-horizon20:59
*** dave-mccowan has quit IRC21:01
*** TravT has quit IRC21:03
ying_zuoflwang1: I have it enabled but I don't have the error21:07
flwang1ok, no problem. thanks.21:08
ying_zuoflwang1: I am seeing the errors now with master21:10
flwang1ying_zuo: ah, nice21:10
flwang1ying_zuo: and i'm going to show you something about the allowed method21:10
ying_zuoI think we need a bug report to look into these errors. flwang1, can you open one?21:13
flwang1sure21:14
ying_zuothanks21:14
*** catintheroof has quit IRC21:14
ying_zuowhat about the allowed method?21:14
flwang1i'm collecting the log, wait a moment21:16
*** lnxnut has joined #openstack-horizon21:19
*** chlong_ has quit IRC21:20
*** chlong has quit IRC21:20
flwang1ying_zuo: http://paste.openstack.org/show/622505/21:21
flwang1time unit is micro seconds21:22
flwang1i'm trying to get an amount time21:22
ying_zuolooks like the time to check different policy rules can vary a lot. I wonder why that is.21:25
ying_zuothey should be in cache21:25
flwang1for some of checks, the time is reasonable. i need to dig more and get the amount time21:30
flwang1i expect the amount time less than 1 sec21:30
flwang1if it's not, then it's a place we need to improve21:30
*** lnxnut has quit IRC21:31
ying_zuoagree21:32
*** itlinux has quit IRC21:36
*** itlinux has joined #openstack-horizon21:37
david-lylecd ..21:38
flwang1david-lyle: where are you now?   then run rm -rf /21:38
david-lylelooking for the proper place to start deleting :)21:39
flwang1good luck ;)21:40
flwang1david-lyle: just double check, so are you happy if we totally remove the quota check for 'launch instance' button?21:40
david-lyleflwang1, that21:41
david-lyle's  good with me21:41
flwang1david-lyle: awesome, thanks21:41
*** lucasxu has quit IRC21:47
*** jamesbenson has quit IRC21:55
*** itlinux has quit IRC21:56
*** rcernin has quit IRC22:02
flwang1ying_zuo: https://bugs.launchpad.net/horizon/+bug/1720893 I have opened a bug to track the weird error22:23
openstackLaunchpad bug 1720893 in OpenStack Dashboard (Horizon) "VariableDoesNotExis error when enabling DEBUG logging" [Undecided,New]22:23
*** lnxnut has joined #openstack-horizon22:28
ying_zuothanks flwang122:28
*** lbragstad has quit IRC22:36
*** lnxnut has quit IRC22:38
*** mrunge_ has joined #openstack-horizon23:05
*** mrunge has quit IRC23:07
*** tosky has quit IRC23:09
flwang1ying_zuo: still around23:13
flwang123:13
ying_zuo:)23:13
flwang1you're a hard worker23:13
flwang1i got some great progress about removing the quota check for 'launch instance' button23:14
flwang11. for some reasons, the quota check/allowed of the launch instance button will be called 2 times23:14
flwang1which takes about 0.14 seconds based on our prod env (prod API with local horizon)23:14
flwang12. the launch instance form will do the quota check again, so user will not be able to create instance and wait resp from nova if the quota has been exceeded23:15
flwang1ying_zuo: see https://ibb.co/kKm8Fb23:16
flwang1because there is no available flavor can be used to meet current request23:17
flwang1i'm going to file a bug to track this change now23:17
ying_zuowhat change?23:18
flwang1remove the quota check for 'launch instance' button23:18
ying_zuoI thought we have a bug for it?23:18
ying_zuothe one with abandoned patch23:19
flwang1that one is trying to create a new config option23:19
flwang1and it proposes changes for many tables23:19
flwang1I don't want to pick up it, but create a new one to only track the change for 'launch instance' button23:20
ying_zuodo you have the link for that one?23:20
flwang1yes, 1 sec23:20
flwang1https://review.openstack.org/#/c/430029/323:20
ying_zuothe bug report seems pretty general23:22
flwang1yep23:22
flwang1i think we can do the similar change for volume create button23:22
flwang1but I'm not sure if the image create panel does the quota check or not23:23
ying_zuocan you use this bug report for you changes?23:23
flwang1yes, I can23:23
flwang1i will add more info on that23:25
ying_zuoregarding the two points you mentioned earlier. 1) are both calls for checking if the button should be enabled?23:25
flwang1if we can bypass the quota check, then the both calls doesn't really mater IMHO23:25
ying_zuo2) it's not very obvious that all flavors have warning signs because the quota for instances is out23:26
flwang1but I don't have much bandwidth to dig why23:26
ying_zuobypass or remove?23:26
flwang1bypass=remove, sorry23:27
flwang1as for your 2) question, user will get another warning, let me show you, 1 sec23:27
flwang1https://ibb.co/kor5Tw23:28
ying_zuooh right23:28
ying_zuocool23:28
flwang1IMHO, that's a good warning than just disable the button23:28
ying_zuoyes23:29
flwang1because user can get more information on the form23:29
flwang1happy now?23:29
flwang1I'm going to propose a patch and update the bug23:29
ying_zuo👍 thanks23:29
flwang1but I'd like to use separated patch to track different changes23:30
flwang1e.g. one patch for the change on instance panel23:30
flwang1and another patch for potential change for the volume panel23:30
flwang1to get it being reviewed/merged easily23:30
*** gyee has quit IRC23:31
*** jamesbenson has joined #openstack-horizon23:33
*** lblanchard has joined #openstack-horizon23:35
*** lnxnut has joined #openstack-horizon23:36
*** jamesbenson has quit IRC23:37
*** lnxnut has quit IRC23:45
*** lblanchard has quit IRC23:51
*** lblanchard has joined #openstack-horizon23:54
ying_zuoflwang1: I think that's fine. You can argue that the existing one is suggesting to make it configurable.23:55
flwang1cool23:55
flwang1ying_zuo: thanks for all your support23:56
flwang1we(catalyst cloud) really care about the performance of Horizon, so pls expect more noisy from us23:56
ying_zuohaha23:57
ying_zuosounds good :)23:58
* flwang1 -> lunch23:58
*** lblanchard has quit IRC23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!