| *** yamamoto has quit IRC | 00:02 | |
| *** jamesbenson has joined #openstack-horizon | 00:17 | |
| *** jamesbenson has quit IRC | 00:22 | |
| *** yamamoto has joined #openstack-horizon | 00:45 | |
| *** yamamoto has quit IRC | 00:49 | |
| *** openstackstatus has quit IRC | 01:14 | |
| *** openstackstatus has joined #openstack-horizon | 01:15 | |
| *** ChanServ sets mode: +v openstackstatus | 01:15 | |
| *** zigo has quit IRC | 01:27 | |
| *** gyee has quit IRC | 01:28 | |
| *** zigo has joined #openstack-horizon | 01:31 | |
| *** yamamoto has joined #openstack-horizon | 01:47 | |
| *** yamamoto has quit IRC | 01:53 | |
| *** john5223_ has quit IRC | 02:08 | |
| *** kong_ has joined #openstack-horizon | 02:11 | |
| *** kong has quit IRC | 02:12 | |
| *** logan- has quit IRC | 02:12 | |
| *** kong_ is now known as kong | 02:12 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/509498 | 02:13 |
|---|---|---|
| *** fbouliane has quit IRC | 02:15 | |
| *** logan- has joined #openstack-horizon | 02:15 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Fix gettext warning "Empty msgid" https://review.openstack.org/509954 | 02:17 |
| *** fbouliane has joined #openstack-horizon | 02:17 | |
| *** mgagne has quit IRC | 02:23 | |
| *** mgagne has joined #openstack-horizon | 02:24 | |
| *** mgagne is now known as Guest66098 | 02:24 | |
| *** dave-mccowan has quit IRC | 02:33 | |
| *** kazsh has quit IRC | 02:35 | |
| *** kazsh has joined #openstack-horizon | 02:36 | |
| *** mrunge has quit IRC | 02:38 | |
| *** sapd has joined #openstack-horizon | 02:38 | |
| *** mrunge has joined #openstack-horizon | 02:41 | |
| *** felipemonteiro_ has joined #openstack-horizon | 03:12 | |
| *** udesale has joined #openstack-horizon | 03:38 | |
| *** udesale has quit IRC | 03:38 | |
| *** udesale has joined #openstack-horizon | 03:42 | |
| *** yamamoto has joined #openstack-horizon | 04:15 | |
| *** felipemonteiro_ has quit IRC | 04:49 | |
| *** udesale has quit IRC | 04:55 | |
| *** masco has quit IRC | 05:13 | |
| *** ratailor has joined #openstack-horizon | 05:16 | |
| *** udesale has joined #openstack-horizon | 05:18 | |
| *** masco has joined #openstack-horizon | 05:25 | |
| *** masco has quit IRC | 05:26 | |
| *** masco has joined #openstack-horizon | 05:26 | |
| *** masco has quit IRC | 05:35 | |
| *** elod has joined #openstack-horizon | 05:37 | |
| *** masco has joined #openstack-horizon | 05:48 | |
| *** e0ne has joined #openstack-horizon | 05:55 | |
| *** spectr has joined #openstack-horizon | 05:56 | |
| *** e0ne has quit IRC | 06:02 | |
| *** clayton has quit IRC | 06:16 | |
| *** ppiela has quit IRC | 06:17 | |
| *** ppiela_ has joined #openstack-horizon | 06:17 | |
| *** rcernin has joined #openstack-horizon | 06:17 | |
| *** clayton has joined #openstack-horizon | 06:18 | |
| *** lajoskatona has joined #openstack-horizon | 06:21 | |
| *** pcaruana has joined #openstack-horizon | 06:24 | |
| *** udesale has quit IRC | 06:31 | |
| *** e0ne has joined #openstack-horizon | 06:31 | |
| *** udesale has joined #openstack-horizon | 06:33 | |
| *** rcernin has quit IRC | 06:41 | |
| *** rcernin has joined #openstack-horizon | 06:43 | |
| *** e0ne has quit IRC | 06:46 | |
| *** jtomasek has joined #openstack-horizon | 06:59 | |
| *** tesseract has joined #openstack-horizon | 07:25 | |
| *** lajoskatona has quit IRC | 07:31 | |
| *** lajoskatona has joined #openstack-horizon | 07:36 | |
| *** e0ne has joined #openstack-horizon | 07:47 | |
| *** itxaka has joined #openstack-horizon | 07:58 | |
| e0ne | robcresswell: hi. are you around? I would like to discuss mox=>mock migration | 08:03 |
| *** tosky has joined #openstack-horizon | 09:15 | |
| *** jpich has joined #openstack-horizon | 09:21 | |
| *** spectr has quit IRC | 09:26 | |
| *** spectr has joined #openstack-horizon | 09:34 | |
| *** spectr has quit IRC | 09:34 | |
| *** spectr has joined #openstack-horizon | 09:36 | |
| *** spectr has quit IRC | 09:36 | |
| *** spectr has joined #openstack-horizon | 09:37 | |
| *** spectr has quit IRC | 09:38 | |
| *** spectr has joined #openstack-horizon | 09:40 | |
| *** spectr has quit IRC | 09:40 | |
| *** spectr has joined #openstack-horizon | 09:41 | |
| shu-mutou-AWAY | robcresswell: around? | 09:42 |
| *** spectr has quit IRC | 09:43 | |
| shu-mutou-AWAY | robcresswell: Could you review 'Enable to refresh ngdetails view' https://review.openstack.org/#/c/491346/ ? | 09:43 |
| *** spectr has joined #openstack-horizon | 09:43 | |
| shu-mutou-AWAY | robcresswell: Zun PTL is very worried about the lack of progress for the bug fix. | 09:44 |
| *** lajoskatona has quit IRC | 09:48 | |
| *** lajoskatona has joined #openstack-horizon | 09:49 | |
| *** jamesbenson has joined #openstack-horizon | 09:53 | |
| *** spectr has quit IRC | 09:56 | |
| *** spectr has joined #openstack-horizon | 09:57 | |
| *** spectr has quit IRC | 09:57 | |
| *** jamesbenson has quit IRC | 09:57 | |
| *** spectr has joined #openstack-horizon | 09:58 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: WIP. Switch cinder-related tests to mock https://review.openstack.org/509618 | 10:09 |
| *** lajoskatona has quit IRC | 10:25 | |
| robcresswell | e0ne: o/ wassup | 10:28 |
| robcresswell | shu-mutou-AWAY: I'll take a look, but I dont think you'll get an answer you're hoping for... | 10:29 |
| e0ne | robcresswell: at PTG we agreed to make some example and do it for new tests to migrate step by step | 10:30 |
| robcresswell | e0ne: Yup | 10:30 |
| e0ne | robcresswell: so, I tried to migrate cinder-related steps as an example because I know how this part of horizon should work | 10:31 |
| *** mrch has quit IRC | 10:32 | |
| e0ne | and I get some questions now | 10:32 |
| *** mrch has joined #openstack-horizon | 10:32 | |
| e0ne | for openstack_dashboard.api.* tests it's not easy to migrate only some of the tests to mock, because it requires changes in base helper | 10:32 |
| robcresswell | e0ne: Oh, sure, fire away | 10:32 |
| e0ne | e.g. to support mock and mox in openstack_dashboard.api.nova we have to add some hacks to the code:( | 10:33 |
| e0ne | because we need changes like: https://review.openstack.org/#/c/509618/4/openstack_dashboard/test/helpers.py | 10:34 |
| e0ne | robcresswell: that's why when we decide to go forward with mock, we have to port all existing tests in openstack_dashboard.api.* | 10:34 |
| e0ne | that's was the first issue I've found, the second one is much more complicated | 10:37 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth master: Imported Translations from Zanata https://review.openstack.org/510054 | 10:37 |
| e0ne | e.g.: https://review.openstack.org/#/c/509618/4/openstack_dashboard/dashboards/project/volumes/tests.py | 10:37 |
| e0ne | I just changed mox to mock ^^ | 10:37 |
| e0ne | and I've found a lot of duplicating code there | 10:38 |
| e0ne | I should refactor that test case into the several smaller test cases to remove code duplication and make code cleaner | 10:38 |
| e0ne | so, the question is | 10:39 |
| e0ne | how do we want to go forward with it: merge this one after I fix CI issues, or I have to refactor it first? | 10:39 |
| e0ne | I'm afraid that in change with ~1000 LoC I'll have a merge&rebase hell soon :( | 10:40 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: WIP. Switch cinder-related tests to mock https://review.openstack.org/509618 | 10:41 |
| e0ne | robcresswell: could you please share your thoughts and/or give some advise on these issues? | 10:41 |
| robcresswell | e0ne: So, you want to merge now, refactor after? | 10:43 |
| e0ne | robcresswell: TBH, I prefer this way | 10:43 |
| robcresswell | I don't think rebase hell is a huge concern in test code, would have thought it rarely changes. Have you had many issues so far? | 10:43 |
| robcresswell | I am generally reluctant to merge code with "promised follow on patches", though I trust you to do it, so we could take that plan if you would prefer. | 10:44 |
| e0ne | no, I didn't meet any merge conflict issue for the last 2-3 days | 10:44 |
| e0ne | robcresswell: I'm definitely agree with you | 10:45 |
| e0ne | that's why I'm proposing a compromise solution | 10:46 |
| e0ne | I'll split my patch into the series of depended patchsets | 10:46 |
| e0ne | and will do a final refactoring in the last one | 10:46 |
| e0ne | so we're be able to merge only all of them | 10:47 |
| e0ne | and somebody can put -2 to the first patch to not merge it by mistakes | 10:47 |
| robcresswell | e0ne: Doesn't that make your rebase issue potentially worse? | 10:53 |
| robcresswell | patch chains etc | 10:53 |
| *** yamamoto has quit IRC | 10:53 | |
| *** yamamoto has joined #openstack-horizon | 10:54 | |
| *** yamamoto has quit IRC | 10:54 | |
| e0ne | robcresswell: it's a bit harder to maintain a chain | 10:55 |
| e0ne | robcresswell: but make reviewers work easier | 10:55 |
| robcresswell | It does indeed | 10:56 |
| robcresswell | Sounds like a good approach to me if you're happy with it | 10:56 |
| e0ne | it's acceptable for me :) | 10:56 |
| robcresswell | \o/ | 10:57 |
| e0ne | thanks for the help | 10:57 |
| robcresswell | np | 10:58 |
| robcresswell | Thanks for the working on it and explaining to my small brain :D | 10:58 |
| e0ne | I hope, I'll finish it early next week and bring up patches to the next meeting | 10:58 |
| e0ne | :) | 10:58 |
| robcresswell | Sounds great! | 11:03 |
| *** masco has quit IRC | 11:08 | |
| e0ne | robcresswell: btw, do you review patches with -1? I've got one such patch and I'm bit afraid that it will leave for a while | 11:08 |
| robcresswell | e0ne: Not unless they are particularly important, or someone asks me too | 11:12 |
| robcresswell | e0ne: Which patch? | 11:12 |
| robcresswell | I'm not doing much reviewing at all right now, have been taking a bit of a break :/ | 11:12 |
| e0ne | robcresswell: I'm talking about this one https://review.openstack.org/#/c/496275/ | 11:12 |
| e0ne | I mean, do you usually review patches with -1 or just ignore them? | 11:13 |
| * e0ne spends more time on writing code than reviewing this week | 11:14 | |
| robcresswell | e0ne: Like I said, not unless they are particularly critical, or someone specifically pings me about it | 11:14 |
| e0ne | robcresswell: got it, thanks | 11:14 |
| robcresswell | e0ne: I approved it | 11:15 |
| robcresswell | e0ne: If stuff gets hung up, just ping me | 11:16 |
| e0ne | robcresswell: ok, thank you for the help | 11:16 |
| robcresswell | np | 11:16 |
| *** masco has joined #openstack-horizon | 11:20 | |
| *** dave-mccowan has joined #openstack-horizon | 11:20 | |
| *** yamamoto has joined #openstack-horizon | 11:25 | |
| *** lajoskatona has joined #openstack-horizon | 11:41 | |
| openstackgerrit | Merged openstack/horizon master: Do not call servers_update_addresses if no instances loaded https://review.openstack.org/496275 | 11:45 |
| *** spectr has quit IRC | 12:02 | |
| *** spectr has joined #openstack-horizon | 12:03 | |
| *** niraj_singh has quit IRC | 12:10 | |
| *** lblanchard has joined #openstack-horizon | 12:22 | |
| *** spectr has quit IRC | 12:28 | |
| *** ratailor has quit IRC | 12:38 | |
| *** spectr has joined #openstack-horizon | 12:39 | |
| *** erlon has joined #openstack-horizon | 12:41 | |
| *** hoangcx has quit IRC | 13:03 | |
| *** udesale has quit IRC | 13:05 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: WIP. Switch cinder-related tests to mock https://review.openstack.org/509618 | 13:07 |
| *** priteau has joined #openstack-horizon | 13:13 | |
| *** lbragstad has joined #openstack-horizon | 13:15 | |
| *** yamamoto has quit IRC | 13:21 | |
| *** spectr has quit IRC | 13:35 | |
| *** yamamoto has joined #openstack-horizon | 13:35 | |
| *** lbragstad has quit IRC | 13:36 | |
| *** lbragstad has joined #openstack-horizon | 13:36 | |
| *** spectr has joined #openstack-horizon | 13:36 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/509618 | 13:39 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510117 | 13:39 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Switch Cinder-related tests to mock https://review.openstack.org/510118 | 13:39 |
| *** lajoskatona has quit IRC | 13:48 | |
| *** lajoskatona has joined #openstack-horizon | 13:53 | |
| *** wolverineav has joined #openstack-horizon | 13:58 | |
| *** ratailor has joined #openstack-horizon | 14:00 | |
| *** catintheroof has joined #openstack-horizon | 14:05 | |
| *** catinthe_ has joined #openstack-horizon | 14:06 | |
| *** catintheroof has quit IRC | 14:07 | |
| *** itxaka has quit IRC | 14:09 | |
| *** spectr has quit IRC | 14:11 | |
| *** silva has quit IRC | 14:19 | |
| *** jtriley has quit IRC | 14:20 | |
| *** felipemonteiro_ has joined #openstack-horizon | 14:21 | |
| *** felipemonteiro__ has joined #openstack-horizon | 14:22 | |
| *** gyee has joined #openstack-horizon | 14:24 | |
| *** felipemonteiro_ has quit IRC | 14:26 | |
| *** jamesbenson has joined #openstack-horizon | 14:37 | |
| *** jtriley has joined #openstack-horizon | 14:45 | |
| *** yamamoto has quit IRC | 14:52 | |
| *** yamamoto has joined #openstack-horizon | 14:53 | |
| *** yamamoto has quit IRC | 14:53 | |
| *** spectr has joined #openstack-horizon | 15:04 | |
| *** spectr has quit IRC | 15:04 | |
| *** ratailor has quit IRC | 15:09 | |
| *** rcernin has quit IRC | 15:19 | |
| *** jeremy_moffitt has quit IRC | 15:24 | |
| *** jeremy_moffitt has joined #openstack-horizon | 15:28 | |
| *** mrch has quit IRC | 15:52 | |
| *** yamamoto has joined #openstack-horizon | 15:53 | |
| *** yamamoto has quit IRC | 16:02 | |
| openstackgerrit | Jeremy Moffitt proposed openstack/horizon master: Prevent "enter" from triggering submit action on modal forms https://review.openstack.org/461490 | 16:06 |
| *** felipemonteiro has quit IRC | 16:07 | |
| *** pcaruana has quit IRC | 16:13 | |
| *** jamesbenson has quit IRC | 16:18 | |
| *** tosky has quit IRC | 16:26 | |
| *** jpich has quit IRC | 16:27 | |
| *** jamesbenson has joined #openstack-horizon | 16:52 | |
| *** wolverin_ has joined #openstack-horizon | 17:03 | |
| *** openstackstatus has quit IRC | 17:05 | |
| *** openstack has joined #openstack-horizon | 17:09 | |
| *** ChanServ sets mode: +o openstack | 17:09 | |
| openstackgerrit | David Lyle proposed openstack/horizon master: Correct quota usage check for instances https://review.openstack.org/510188 | 17:10 |
| *** masco has quit IRC | 17:44 | |
| *** oomichi_afk is now known as oomichi | 17:44 | |
| *** yamamoto has joined #openstack-horizon | 17:45 | |
| jmccrory | hello, anyone available to review a tempest-horizon change? https://review.openstack.org/#/c/506496/ | 17:46 |
| david-lyle | jmccrory, is that part of a larger effort? | 17:48 |
| jmccrory | it's to fix an issue we're seeing in openstack-ansible and centos. the centos OS package of python is 2.7.5 but includes a backport of that ssl function | 17:49 |
| david-lyle | ok, +A'd | 17:50 |
| *** lajoskatona has quit IRC | 17:50 | |
| jmccrory | thanks | 17:50 |
| *** yamamoto has quit IRC | 17:53 | |
| *** wolverin_ has quit IRC | 18:00 | |
| *** wolverineav has joined #openstack-horizon | 18:00 | |
| *** esp has joined #openstack-horizon | 18:07 | |
| *** jtriley has quit IRC | 18:15 | |
| *** jtriley has joined #openstack-horizon | 18:15 | |
| *** jtriley has quit IRC | 18:15 | |
| *** priteau has quit IRC | 18:16 | |
| *** jtriley has joined #openstack-horizon | 18:16 | |
| *** lbragstad has quit IRC | 18:16 | |
| *** lbragstad has joined #openstack-horizon | 18:25 | |
| *** tosky has joined #openstack-horizon | 18:32 | |
| *** chlong has joined #openstack-horizon | 19:06 | |
| johnsom | Would anybody have a minute to take a look at one of our gate logs? It has started to report an error but it's not clear to me what is wrong: http://logs.openstack.org/18/501618/13/check/gate-neutron-lbaas-dashboard-nodejs4-npm-run-test/816c221/console.html#_2017-10-05_22_33_23_936960 | 19:07 |
| johnsom | I see this, but a grep doesn't find that in our code: Module 'schemaForm' is not available! | 19:07 |
| *** wolverineav has quit IRC | 19:08 | |
| *** wolverineav has joined #openstack-horizon | 19:09 | |
| *** wolverineav has quit IRC | 19:11 | |
| *** wolverin_ has joined #openstack-horizon | 19:11 | |
| *** tesseract has quit IRC | 19:31 | |
| *** wolverin_ has quit IRC | 19:35 | |
| *** gary-smith_ has joined #openstack-horizon | 19:57 | |
| *** john5223_ has joined #openstack-horizon | 20:02 | |
| *** e0ne has quit IRC | 20:05 | |
| *** jtomasek has quit IRC | 20:08 | |
| david-lyle | johnsom, https://github.com/openstack/horizon/blob/master/requirements.txt#L48 | 20:17 |
| david-lyle | looking at your repo now | 20:17 |
| johnsom | Thank you | 20:19 |
| johnsom | It had me scratching my head as it passes local. | 20:22 |
| johnsom | Maybe something dropped a requirement and now we need to add it to those gates. The odd thing is octavia-dashboard seems to still be passing. They are very similar repos due to the transition. | 20:23 |
| *** wolverineav has joined #openstack-horizon | 20:23 | |
| david-lyle | I'm not seeing any reason you would need that requirement | 20:23 |
| *** wolverineav has quit IRC | 20:25 | |
| *** wolverineav has joined #openstack-horizon | 20:26 | |
| david-lyle | nothing has changed with that package in a year or so either | 20:27 |
| *** catinthe_ has quit IRC | 20:28 | |
| johnsom | Yeah, I have been wondering if it's not some other failure, but I haven't found anything so far | 20:30 |
| david-lyle | I don't have much help to offer I'm afraid. Nothing obvious to me | 20:31 |
| johnsom | Ok, thank you for taking a look! | 20:33 |
| *** spectr has joined #openstack-horizon | 20:34 | |
| *** spectr has quit IRC | 20:36 | |
| *** david-lyle has quit IRC | 20:38 | |
| *** e0ne has joined #openstack-horizon | 20:39 | |
| *** wolverineav has quit IRC | 20:54 | |
| *** e0ne has quit IRC | 20:57 | |
| *** lblanchard has quit IRC | 21:05 | |
| *** jtriley has quit IRC | 21:12 | |
| *** david-lyle has joined #openstack-horizon | 21:19 | |
| *** ChanServ sets mode: +o david-lyle | 21:19 | |
| *** felipemonteiro__ has quit IRC | 21:21 | |
| *** wolverineav has joined #openstack-horizon | 21:30 | |
| *** dklyle has joined #openstack-horizon | 21:39 | |
| *** ChanServ sets mode: +o dklyle | 21:39 | |
| *** david-lyle has quit IRC | 21:41 | |
| *** dklyle has quit IRC | 21:41 | |
| *** dklyle has joined #openstack-horizon | 21:42 | |
| *** ChanServ sets mode: +o dklyle | 21:42 | |
| *** lbragstad has quit IRC | 21:43 | |
| *** dklyle has quit IRC | 21:52 | |
| *** jamesbenson has quit IRC | 21:55 | |
| *** jamesbenson has joined #openstack-horizon | 21:56 | |
| *** jamesbenson has quit IRC | 21:58 | |
| *** chlong has quit IRC | 22:14 | |
| *** gary-smith__ has joined #openstack-horizon | 22:23 | |
| *** gary-smith_ has quit IRC | 22:24 | |
| *** erlon has quit IRC | 22:30 | |
| *** NightKhaos has quit IRC | 22:33 | |
| *** NightKhaos has joined #openstack-horizon | 22:37 | |
| *** wolverineav has quit IRC | 22:43 | |
| *** gary-smith_ has joined #openstack-horizon | 23:13 | |
| *** jamesbenson has joined #openstack-horizon | 23:14 | |
| *** gary-smith__ has quit IRC | 23:14 | |
| *** tosky has quit IRC | 23:15 | |
| *** jamesbenson has quit IRC | 23:18 | |
| *** gary-smith_ has quit IRC | 23:22 | |
| *** david-lyle has joined #openstack-horizon | 23:42 | |
| *** ChanServ sets mode: +o david-lyle | 23:42 | |
| *** harlowja has quit IRC | 23:45 | |
| *** yamamoto has joined #openstack-horizon | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!