| *** PramodJ has joined #openstack-horizon | 00:05 | |
| *** pramodrj07 has quit IRC | 00:08 | |
| *** itlinux has joined #openstack-horizon | 00:16 | |
| *** zhurong has joined #openstack-horizon | 00:38 | |
| *** dave-mccowan has joined #openstack-horizon | 00:46 | |
| *** itlinux has quit IRC | 00:55 | |
| *** PramodJ has quit IRC | 01:04 | |
| *** BoJin has quit IRC | 01:24 | |
| openstackgerrit | Ivan Udovichenko proposed openstack/horizon master: Check if 'files' variable is actually a list https://review.openstack.org/517149 | 01:31 |
|---|---|---|
| *** itlinux has joined #openstack-horizon | 01:45 | |
| *** zhurong has quit IRC | 01:46 | |
| *** BoJin has joined #openstack-horizon | 01:47 | |
| *** nikhil has quit IRC | 01:59 | |
| *** zhurong has joined #openstack-horizon | 02:00 | |
| *** itlinux has quit IRC | 02:05 | |
| *** itlinux has joined #openstack-horizon | 02:11 | |
| *** itlinux has quit IRC | 02:32 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| *** udesale has joined #openstack-horizon | 03:16 | |
| openstackgerrit | Vu Cong Tuan proposed openstack/horizon master: Use assertRegex instead of assertRegexpMatches https://review.openstack.org/516901 | 03:50 |
| *** yamamoto has joined #openstack-horizon | 04:24 | |
| *** ratailor has joined #openstack-horizon | 05:41 | |
| *** pcaruana has joined #openstack-horizon | 05:58 | |
| *** namnh has joined #openstack-horizon | 06:19 | |
| *** BoJin has quit IRC | 06:32 | |
| *** BoJin has joined #openstack-horizon | 06:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/517177 | 06:35 |
| *** BoJin has quit IRC | 06:38 | |
| *** BoJin has joined #openstack-horizon | 06:39 | |
| *** ratailor is now known as ratailor|afk | 06:40 | |
| *** ratailor|afk is now known as ratailor | 06:45 | |
| *** bruvik_ has joined #openstack-horizon | 07:02 | |
| *** hoonetorg has quit IRC | 07:05 | |
| *** fxpester has quit IRC | 07:11 | |
| openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.openstack.org/517177 | 07:19 |
| *** zhurong has quit IRC | 07:20 | |
| *** hoonetorg has joined #openstack-horizon | 07:21 | |
| *** bruvik_ has quit IRC | 07:25 | |
| *** rcernin has quit IRC | 07:27 | |
| *** BoJin has quit IRC | 07:31 | |
| *** bruvik_ has joined #openstack-horizon | 07:33 | |
| *** rdopiera has quit IRC | 07:35 | |
| *** rdopiera has joined #openstack-horizon | 07:35 | |
| *** bruvik_ has quit IRC | 07:38 | |
| *** rubasov has joined #openstack-horizon | 07:57 | |
| *** rubasov has quit IRC | 07:57 | |
| *** zhurong has joined #openstack-horizon | 07:58 | |
| *** Kvisle has quit IRC | 08:04 | |
| *** Kvisle has joined #openstack-horizon | 08:05 | |
| *** tesseract has joined #openstack-horizon | 08:10 | |
| *** rcernin has joined #openstack-horizon | 08:26 | |
| *** spectr has joined #openstack-horizon | 08:36 | |
| *** gary-smith_ has joined #openstack-horizon | 08:53 | |
| *** gary-smith__ has quit IRC | 08:56 | |
| *** jpich has joined #openstack-horizon | 09:02 | |
| *** yamamoto has quit IRC | 09:18 | |
| *** yamamoto has joined #openstack-horizon | 09:24 | |
| *** yamamoto has quit IRC | 09:28 | |
| *** yamamoto has joined #openstack-horizon | 09:35 | |
| *** yamamoto has quit IRC | 09:35 | |
| *** zhurong has quit IRC | 09:48 | |
| *** e0ne has joined #openstack-horizon | 09:48 | |
| *** yamamoto has joined #openstack-horizon | 09:57 | |
| *** makowals has joined #openstack-horizon | 10:00 | |
| *** mvk has quit IRC | 10:22 | |
| *** mvk has joined #openstack-horizon | 10:30 | |
| *** e0ne has quit IRC | 10:41 | |
| *** e0ne has joined #openstack-horizon | 10:42 | |
| *** namnh has quit IRC | 10:51 | |
| *** zhurong has joined #openstack-horizon | 11:12 | |
| *** yamamoto has quit IRC | 11:16 | |
| *** jtriley has joined #openstack-horizon | 11:16 | |
| *** yamamoto has joined #openstack-horizon | 11:19 | |
| *** yamamoto has quit IRC | 11:24 | |
| *** jtriley has quit IRC | 11:37 | |
| *** jtriley has joined #openstack-horizon | 11:44 | |
| *** jlabarre has joined #openstack-horizon | 11:51 | |
| *** rmart04 has joined #openstack-horizon | 11:51 | |
| *** rcernin has quit IRC | 11:56 | |
| *** yamamoto has joined #openstack-horizon | 12:11 | |
| *** ratailor has quit IRC | 12:15 | |
| *** yamamoto has quit IRC | 12:15 | |
| *** yamamoto has joined #openstack-horizon | 12:15 | |
| *** yamamoto has quit IRC | 12:20 | |
| *** udesale has quit IRC | 12:33 | |
| *** catintheroof has joined #openstack-horizon | 12:34 | |
| *** jtriley has quit IRC | 12:35 | |
| *** dave-mccowan has joined #openstack-horizon | 12:36 | |
| *** yamamoto has joined #openstack-horizon | 12:47 | |
| *** yamamoto has quit IRC | 12:47 | |
| *** yamamoto has joined #openstack-horizon | 12:50 | |
| *** zhurong has quit IRC | 12:51 | |
| *** e0ne_ has joined #openstack-horizon | 12:52 | |
| *** wolverineav has joined #openstack-horizon | 12:52 | |
| *** e0ne has quit IRC | 12:55 | |
| *** BoJin has joined #openstack-horizon | 13:12 | |
| *** BoJin has quit IRC | 13:20 | |
| *** yamamoto has quit IRC | 13:24 | |
| *** yamamoto has joined #openstack-horizon | 13:28 | |
| *** lbragstad has joined #openstack-horizon | 13:34 | |
| *** lblanchard has joined #openstack-horizon | 13:39 | |
| *** jtriley has joined #openstack-horizon | 13:48 | |
| *** david-lyle has quit IRC | 14:04 | |
| *** sudhamsd has joined #openstack-horizon | 14:05 | |
| *** sudhamsd has quit IRC | 14:10 | |
| *** rwellum has joined #openstack-horizon | 14:16 | |
| cmurphy | anyone want to play tiebreaker for me on one of these https://review.openstack.org/#/c/516439/ https://review.openstack.org/#/c/491743/ for me? Will reward with a cold beverage in Sydney :) | 14:27 |
| *** nikhil has joined #openstack-horizon | 14:29 | |
| *** spectr-RH has joined #openstack-horizon | 14:30 | |
| *** spectr has quit IRC | 14:33 | |
| *** BoJin has joined #openstack-horizon | 14:43 | |
| *** felipemonteiro_ has joined #openstack-horizon | 14:48 | |
| *** felipemonteiro__ has joined #openstack-horizon | 14:49 | |
| *** felipemonteiro_ has quit IRC | 14:53 | |
| *** lvdombrkr has quit IRC | 15:05 | |
| *** lvdombrkr has joined #openstack-horizon | 15:14 | |
| *** BoJin has quit IRC | 15:14 | |
| *** itlinux has joined #openstack-horizon | 15:16 | |
| *** yamamoto has quit IRC | 15:41 | |
| *** spectr has joined #openstack-horizon | 15:41 | |
| *** yamamoto has joined #openstack-horizon | 15:43 | |
| *** spectr-RH has quit IRC | 15:44 | |
| *** yamamoto has quit IRC | 15:48 | |
| *** spectr has quit IRC | 15:55 | |
| robcresswell | cmurphy: I could've sworn I complained about novalidate before on that patch... did someone else put up the same thing? | 16:02 |
| robcresswell | I'm not a fan of the rather heavy handed approach :/ | 16:02 |
| robcresswell | Although coupled with the other patch it looks like a mix of standard html validation and angular stuff | 16:03 |
| *** yamamoto has joined #openstack-horizon | 16:04 | |
| *** yamamoto has quit IRC | 16:04 | |
| ying_zuo | robcresswell: I proposed a similar change before but there was a better fixed for that | 16:13 |
| ying_zuo | I think something is changed in django to trigger this frontend validation | 16:14 |
| ying_zuo | it wasn't like this before | 16:14 |
| ying_zuo | adding the novalidate sounds bad but the django form validation is still in place | 16:15 |
| robcresswell | ying_zuo: Yeah, I thought I posted about in the original change | 16:15 |
| robcresswell | If the validation still runs fine, fire away | 16:15 |
| robcresswell | Bugs gotta be fixed | 16:15 |
| *** dave-mccowan has quit IRC | 16:22 | |
| e0ne_ | robcresswell: patch #516439 disables client-side validation but server-side still works | 16:24 |
| robcresswell | Block things like required disabling the submit button? | 16:25 |
| robcresswell | *sigh* let's just look at the Django docs and do it properly then... | 16:25 |
| e0ne_ | who sad something about docs? ;) | 16:26 |
| *** catintheroof has quit IRC | 16:26 | |
| ying_zuo | we didn't use the frontend validation which will show a yellow tooltip for missing required field | 16:29 |
| ying_zuo | I agree that will save some requests to the server with the fronted validation though | 16:30 |
| *** catintheroof has joined #openstack-horizon | 16:30 | |
| robcresswell | I dont want to disable validation; if something changed in Django we need to find the release note and figure out how to fix it | 16:31 |
| e0ne_ | robcresswell: good point | 16:31 |
| ying_zuo | sounds good to me | 16:31 |
| robcresswell | ying_zuo: Did you say you had a previous patch for this? | 16:32 |
| robcresswell | I'm sure I looked into it and commented something about this a while ago | 16:32 |
| robcresswell | But I cant find where | 16:32 |
| ying_zuo | robcresswell: https://review.openstack.org/#/c/492354/ | 16:34 |
| robcresswell | Hmm | 16:37 |
| robcresswell | Maybe I posted it in IRC or something | 16:37 |
| robcresswell | Could be related to https://docs.djangoproject.com/en/1.11/releases/1.10/#forms | 16:38 |
| robcresswell | Specifically a change to the required field :) | 16:39 |
| ying_zuo | yes https://docs.djangoproject.com/en/1.11/ref/forms/api/#django.forms.Form.use_required_attribute | 16:39 |
| e0ne_ | robcresswell, ying_zuo: we've got required attribute for login/password | 16:42 |
| cmurphy | okay so maybe just set use_required_attribute to False for those fields here http://git.openstack.org/cgit/openstack/django_openstack_auth/tree/openstack_auth/forms.py#n80 ? | 16:44 |
| cmurphy | otherwise https://review.openstack.org/#/c/491743/ keeps the client-side validation | 16:44 |
| robcresswell | Looks like that would be the safest way to restore the previous behaviour | 16:44 |
| *** lbragstad has quit IRC | 16:46 | |
| e0ne_ | cmurphy: it sounds good to remove required attribute only if websso is enabled | 16:47 |
| cmurphy | e0ne_: do you mean if WEBSSO=True in local_settings.py or do you mean if a websso choice is selected in the dropdown? | 16:49 |
| cmurphy | because I'm going to have a harder time with the second one | 16:49 |
| *** rmart04 has quit IRC | 16:53 | |
| e0ne_ | the second one looks better | 16:53 |
| cmurphy | that seems to veer away from the django realm and into the javascript realm | 16:54 |
| cmurphy | if you don't want to set it through django then https://review.openstack.org/#/c/491743/ solves it | 16:54 |
| * e0ne_ needs to head home. bb in ~1.5 hours | 16:55 | |
| cmurphy | setting it in django no matter whether websso is enabled would restore the old behavior, it sounds like | 16:55 |
| *** mvk has quit IRC | 16:59 | |
| *** e0ne_ has quit IRC | 17:02 | |
| *** yamamoto has joined #openstack-horizon | 17:05 | |
| *** nikhil has quit IRC | 17:09 | |
| *** yamamoto has quit IRC | 17:12 | |
| *** itlinux has quit IRC | 17:23 | |
| openstackgerrit | Colleen Murphy proposed openstack/django_openstack_auth master: Don't add required attribute to html form fields https://review.openstack.org/517382 | 17:26 |
| cmurphy | robcresswell: ^ | 17:27 |
| robcresswell | cmurphy: Cool, nice one. That seems to restore the behaviour pre-1.10, which I think seems logical. | 17:28 |
| cmurphy | \o/ | 17:29 |
| *** lbragstad has joined #openstack-horizon | 17:29 | |
| *** gyee has joined #openstack-horizon | 17:37 | |
| *** bruvik_ has joined #openstack-horizon | 17:49 | |
| *** jpich has quit IRC | 17:57 | |
| *** rmart04 has joined #openstack-horizon | 18:05 | |
| *** pcaruana has quit IRC | 18:10 | |
| *** itlinux has joined #openstack-horizon | 18:11 | |
| *** rmart04 has quit IRC | 18:19 | |
| *** tesseract has quit IRC | 18:25 | |
| *** bruvik_ has quit IRC | 18:28 | |
| *** e0ne has joined #openstack-horizon | 18:34 | |
| *** bruvik_ has joined #openstack-horizon | 18:58 | |
| *** itlinux has quit IRC | 19:00 | |
| *** bruvik_ has quit IRC | 19:02 | |
| *** e0ne has quit IRC | 19:20 | |
| *** vishwanathj has quit IRC | 19:23 | |
| *** dave-mccowan has joined #openstack-horizon | 19:33 | |
| *** dave-mccowan has quit IRC | 19:56 | |
| *** itlinux has joined #openstack-horizon | 20:00 | |
| *** lblanchard has quit IRC | 20:01 | |
| *** dave-mccowan has joined #openstack-horizon | 20:15 | |
| *** gyee has quit IRC | 20:18 | |
| *** jtriley has quit IRC | 20:35 | |
| *** dave-mccowan has quit IRC | 20:35 | |
| *** gyee has joined #openstack-horizon | 20:36 | |
| *** felipemonteiro_ has joined #openstack-horizon | 20:42 | |
| *** felipemonteiro__ has quit IRC | 20:44 | |
| *** gyee has quit IRC | 20:54 | |
| zioproto | robcresswell: hello there. Are you coming to Sydney ? | 20:56 |
| zioproto | robcresswell: I sent you an email :) | 21:04 |
| *** jtriley has joined #openstack-horizon | 21:07 | |
| *** itlinux has quit IRC | 21:18 | |
| *** itlinux has joined #openstack-horizon | 21:24 | |
| *** jtomasek has quit IRC | 21:35 | |
| *** mvk has joined #openstack-horizon | 21:44 | |
| *** jtriley has quit IRC | 21:47 | |
| *** itlinux has quit IRC | 21:48 | |
| *** yamamoto has joined #openstack-horizon | 21:51 | |
| *** catintheroof has quit IRC | 21:53 | |
| *** felipemonteiro_ has quit IRC | 21:56 | |
| *** rcernin has joined #openstack-horizon | 22:01 | |
| *** lbragstad has quit IRC | 22:24 | |
| *** david-lyle has joined #openstack-horizon | 22:29 | |
| *** ChanServ sets mode: +o david-lyle | 22:29 | |
| *** wolverineav has quit IRC | 23:08 | |
| *** wolverineav has joined #openstack-horizon | 23:08 | |
| *** felipemonteiro_ has joined #openstack-horizon | 23:08 | |
| *** wolverineav has quit IRC | 23:13 | |
| *** rcernin has quit IRC | 23:17 | |
| *** nikhil has joined #openstack-horizon | 23:41 | |
| *** felipemonteiro_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!