*** nandal has quit IRC | 00:07 | |
*** wolverineav has quit IRC | 00:08 | |
*** flwang1 has quit IRC | 00:12 | |
*** Brin has joined #openstack-horizon | 00:12 | |
Brin | Excuse me, who can confirm this BUG ? https://bugs.launchpad.net/horizon/+bug/1736636 | 00:15 |
---|---|---|
openstack | Launchpad bug 1736636 in OpenStack Dashboard (Horizon) "When launch an instance, selecting the source gets the volume snapshot list incorrectly" [Undecided,New] | 00:15 |
*** flwang1 has joined #openstack-horizon | 00:24 | |
*** threestrands has joined #openstack-horizon | 00:26 | |
*** threestrands has quit IRC | 00:26 | |
*** threestrands has joined #openstack-horizon | 00:26 | |
*** flwang1 has quit IRC | 00:33 | |
*** ellopunk has joined #openstack-horizon | 00:34 | |
*** ellopunk_ has quit IRC | 00:35 | |
*** dave-mccowan has quit IRC | 00:35 | |
*** wolverineav has joined #openstack-horizon | 00:39 | |
*** wolverineav has quit IRC | 00:44 | |
*** flwang1 has joined #openstack-horizon | 00:48 | |
*** itlinux has joined #openstack-horizon | 00:59 | |
*** jtriley has joined #openstack-horizon | 01:05 | |
*** wolverineav has joined #openstack-horizon | 01:10 | |
*** dave-mccowan has joined #openstack-horizon | 01:11 | |
*** wolverineav has quit IRC | 01:17 | |
*** asettle has quit IRC | 01:19 | |
*** yamamoto has joined #openstack-horizon | 01:21 | |
*** yamamoto has quit IRC | 01:21 | |
*** asettle has joined #openstack-horizon | 01:22 | |
*** jtriley has quit IRC | 01:30 | |
*** makowals has quit IRC | 01:43 | |
*** makowals has joined #openstack-horizon | 01:44 | |
*** rmcall has quit IRC | 01:47 | |
*** yamamoto has joined #openstack-horizon | 01:57 | |
*** felipemonteiro has quit IRC | 01:57 | |
*** btully has joined #openstack-horizon | 01:59 | |
*** btully has quit IRC | 02:03 | |
*** r-daneel has quit IRC | 02:20 | |
*** catintheroof has joined #openstack-horizon | 02:38 | |
*** catintheroof has quit IRC | 02:53 | |
*** jtriley has joined #openstack-horizon | 02:56 | |
*** rmcall has joined #openstack-horizon | 02:59 | |
*** threestrands has quit IRC | 03:03 | |
*** threestrands has joined #openstack-horizon | 03:04 | |
*** threestrands has quit IRC | 03:04 | |
*** threestrands has joined #openstack-horizon | 03:04 | |
*** threestrands has quit IRC | 03:05 | |
*** threestrands has joined #openstack-horizon | 03:06 | |
*** threestrands has quit IRC | 03:06 | |
*** threestrands has joined #openstack-horizon | 03:06 | |
*** threestrands has quit IRC | 03:07 | |
*** threestrands has joined #openstack-horizon | 03:07 | |
*** dave-mccowan has quit IRC | 03:13 | |
*** jtriley has quit IRC | 03:35 | |
*** jtriley has joined #openstack-horizon | 03:39 | |
openstackgerrit | Wangliangyu proposed openstack/horizon master: Fix the 409 error for confirm/revert resize instance https://review.openstack.org/527354 | 03:46 |
*** btully has joined #openstack-horizon | 03:47 | |
*** gyee has quit IRC | 03:51 | |
*** btully has quit IRC | 03:52 | |
*** jtriley has quit IRC | 03:55 | |
*** udesale has joined #openstack-horizon | 03:57 | |
*** flwang1 has quit IRC | 03:57 | |
*** threestrands_ has joined #openstack-horizon | 03:57 | |
*** threestrands has quit IRC | 03:57 | |
*** threestrands_ has quit IRC | 03:58 | |
*** threestrands_ has joined #openstack-horizon | 03:59 | |
*** zhurong has joined #openstack-horizon | 03:59 | |
*** yamamoto_ has joined #openstack-horizon | 04:08 | |
*** yamamoto has quit IRC | 04:11 | |
*** namnh has joined #openstack-horizon | 04:14 | |
*** shu-mutou has joined #openstack-horizon | 04:20 | |
*** jtriley has joined #openstack-horizon | 04:20 | |
*** jtriley has quit IRC | 04:25 | |
*** jtriley has joined #openstack-horizon | 04:26 | |
*** felipemonteiro has joined #openstack-horizon | 05:03 | |
*** yamamoto_ has quit IRC | 05:10 | |
*** namnh has quit IRC | 05:19 | |
*** yamamoto has joined #openstack-horizon | 05:32 | |
*** rmcall has quit IRC | 06:21 | |
*** felipemonteiro has quit IRC | 06:38 | |
*** felipemonteiro has joined #openstack-horizon | 06:39 | |
*** jtriley has quit IRC | 06:39 | |
*** masco has joined #openstack-horizon | 06:43 | |
*** ianychoi has quit IRC | 06:44 | |
*** jtriley has joined #openstack-horizon | 06:46 | |
*** e0ne has joined #openstack-horizon | 06:47 | |
*** yamamoto has quit IRC | 06:49 | |
*** felipemonteiro has quit IRC | 06:50 | |
*** jtriley has quit IRC | 06:52 | |
*** threestrands_ has quit IRC | 06:57 | |
*** yamamoto has joined #openstack-horizon | 07:04 | |
*** rcernin has quit IRC | 07:08 | |
*** yamamoto has quit IRC | 07:09 | |
*** e0ne has quit IRC | 07:12 | |
*** jtriley has joined #openstack-horizon | 07:18 | |
*** e0ne has joined #openstack-horizon | 07:19 | |
*** yamamoto has joined #openstack-horizon | 07:20 | |
*** Brin has quit IRC | 07:23 | |
*** yamamoto has quit IRC | 07:24 | |
*** cshen has joined #openstack-horizon | 07:25 | |
*** e0ne has quit IRC | 07:25 | |
*** sapd has quit IRC | 07:40 | |
*** sapd has joined #openstack-horizon | 07:41 | |
*** jtriley has quit IRC | 07:54 | |
*** yamamoto has joined #openstack-horizon | 08:04 | |
*** yamamoto has quit IRC | 08:09 | |
*** hoangcx has quit IRC | 08:12 | |
*** hoangcx has joined #openstack-horizon | 08:13 | |
*** zhurong has quit IRC | 08:17 | |
*** hoonetorg has quit IRC | 08:19 | |
*** jtriley has joined #openstack-horizon | 08:19 | |
*** jtriley has quit IRC | 08:24 | |
*** jtomasek has joined #openstack-horizon | 08:27 | |
openstackgerrit | Shu Muto proposed openstack/horizon master: Use load-edit directive in import key pair https://review.openstack.org/487689 | 08:28 |
*** jtriley has joined #openstack-horizon | 08:28 | |
*** jtomasek has quit IRC | 08:31 | |
*** jtomasek has joined #openstack-horizon | 08:32 | |
*** sapd has quit IRC | 08:33 | |
*** hoonetorg has joined #openstack-horizon | 08:33 | |
*** yamamoto has joined #openstack-horizon | 08:34 | |
*** sapd has joined #openstack-horizon | 08:35 | |
*** amoralej|off is now known as amoralej | 08:35 | |
*** yamamoto has quit IRC | 08:39 | |
*** yamamoto has joined #openstack-horizon | 08:50 | |
*** yamamoto has quit IRC | 08:54 | |
*** yamamoto has joined #openstack-horizon | 08:56 | |
*** yamamoto has quit IRC | 08:56 | |
*** flwang1 has joined #openstack-horizon | 09:00 | |
*** jtriley has quit IRC | 09:03 | |
*** yamamoto has joined #openstack-horizon | 09:05 | |
openstackgerrit | Bence Romsics proposed openstack/horizon master: Trunks panel: eliminate spinner at create/edit https://review.openstack.org/524231 | 09:26 |
*** e0ne has joined #openstack-horizon | 09:26 | |
*** jtriley has joined #openstack-horizon | 09:30 | |
*** jtriley has quit IRC | 09:35 | |
*** jtriley has joined #openstack-horizon | 09:43 | |
*** tosky has joined #openstack-horizon | 10:05 | |
*** e0ne_ has joined #openstack-horizon | 10:08 | |
*** e0ne has quit IRC | 10:11 | |
*** flwang1 has quit IRC | 10:15 | |
*** jtriley has quit IRC | 10:23 | |
*** flwang1 has joined #openstack-horizon | 10:25 | |
*** anupn has quit IRC | 10:38 | |
*** anupn has joined #openstack-horizon | 10:46 | |
*** jtriley has joined #openstack-horizon | 10:48 | |
*** flwang1 has quit IRC | 10:52 | |
*** jtriley has quit IRC | 10:53 | |
*** jtriley has joined #openstack-horizon | 10:54 | |
*** btully has joined #openstack-horizon | 11:03 | |
*** btully has quit IRC | 11:07 | |
*** yamamoto_ has joined #openstack-horizon | 11:08 | |
*** yamamoto has quit IRC | 11:11 | |
*** priteau has joined #openstack-horizon | 11:24 | |
*** jtriley has quit IRC | 11:33 | |
*** jtriley has joined #openstack-horizon | 11:59 | |
*** slunkad has quit IRC | 11:59 | |
*** slunkad has joined #openstack-horizon | 12:02 | |
*** priteau has quit IRC | 12:03 | |
*** priteau has joined #openstack-horizon | 12:03 | |
*** jtriley has quit IRC | 12:04 | |
*** priteau has quit IRC | 12:08 | |
*** jtriley has joined #openstack-horizon | 12:11 | |
*** dave-mccowan has joined #openstack-horizon | 12:13 | |
*** felipemonteiro has joined #openstack-horizon | 12:46 | |
*** felipemonteiro has quit IRC | 12:50 | |
*** jtriley has quit IRC | 12:53 | |
*** jtriley has joined #openstack-horizon | 13:00 | |
*** jtriley has quit IRC | 13:05 | |
*** e0ne has joined #openstack-horizon | 13:10 | |
*** jtriley has joined #openstack-horizon | 13:11 | |
*** e0ne_ has quit IRC | 13:13 | |
*** openstackgerrit has quit IRC | 13:13 | |
-openstackstatus- NOTICE: gerrit is being restarted due to extreme slowness | 13:14 | |
*** amoralej is now known as amoralej|lunch | 13:16 | |
*** openstackgerrit has joined #openstack-horizon | 13:34 | |
openstackgerrit | Akihiro Motoki proposed openstack/django_openstack_auth master: DNM: test updated project-config https://review.openstack.org/529313 | 13:34 |
*** yamamoto_ has quit IRC | 13:34 | |
*** rmart04 has joined #openstack-horizon | 13:43 | |
*** cshen has quit IRC | 13:43 | |
*** cshen has joined #openstack-horizon | 13:45 | |
*** amoralej|lunch is now known as amoralej | 13:50 | |
*** catintheroof has joined #openstack-horizon | 13:52 | |
openstackgerrit | Akihiro Motoki proposed openstack/django_openstack_auth master: Retire project https://review.openstack.org/523928 | 13:56 |
*** catintheroof has quit IRC | 14:02 | |
*** catintheroof has joined #openstack-horizon | 14:04 | |
*** logan- has quit IRC | 14:08 | |
*** ellopunk has quit IRC | 14:10 | |
*** logan- has joined #openstack-horizon | 14:10 | |
*** yamamoto has joined #openstack-horizon | 14:10 | |
*** catinthe_ has joined #openstack-horizon | 14:22 | |
*** yamamoto has quit IRC | 14:23 | |
*** catintheroof has quit IRC | 14:26 | |
*** openstackgerrit has quit IRC | 14:33 | |
*** ellopunk has joined #openstack-horizon | 14:33 | |
*** ellopunk has quit IRC | 14:36 | |
*** lblanchard has joined #openstack-horizon | 14:37 | |
*** btully has joined #openstack-horizon | 14:40 | |
*** btully has quit IRC | 14:45 | |
*** ellopunk has joined #openstack-horizon | 14:51 | |
*** lblanchard has quit IRC | 14:54 | |
*** catinthe_ has quit IRC | 15:02 | |
*** catintheroof has joined #openstack-horizon | 15:03 | |
*** makowals has quit IRC | 15:08 | |
*** catintheroof has quit IRC | 15:08 | |
*** openstackgerrit has joined #openstack-horizon | 15:22 | |
openstackgerrit | Ahmed Zaid proposed openstack/horizon master: Drop flavor name validation in horizon side. https://review.openstack.org/528675 | 15:22 |
*** yamamoto has joined #openstack-horizon | 15:23 | |
*** masco has quit IRC | 15:29 | |
*** yamamoto has quit IRC | 15:35 | |
*** shu-mutou has quit IRC | 15:47 | |
openstackgerrit | Ruslan Aliev proposed openstack/horizon master: Fix back button on Firefox and Safari https://review.openstack.org/524948 | 15:50 |
*** pcaruana has joined #openstack-horizon | 15:51 | |
*** felipemonteiro has joined #openstack-horizon | 15:54 | |
*** shu-mutou has joined #openstack-horizon | 16:02 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Drop flavor name validation in horizon side. https://review.openstack.org/528675 | 16:14 |
*** felipemonteiro_ has joined #openstack-horizon | 16:22 | |
*** rmart04 has quit IRC | 16:24 | |
*** felipemonteiro_ has quit IRC | 16:24 | |
*** rmart04 has joined #openstack-horizon | 16:24 | |
*** felipemonteiro_ has joined #openstack-horizon | 16:24 | |
*** felipemonteiro has quit IRC | 16:26 | |
*** rmcall has joined #openstack-horizon | 16:34 | |
*** rmcall has quit IRC | 16:38 | |
openstackgerrit | Merged openstack/tempest-horizon master: zuul: Use horizon-dsvm-tempest-plugin job from horizon https://review.openstack.org/524078 | 16:42 |
*** e0ne has quit IRC | 16:49 | |
*** rmart04 has quit IRC | 16:52 | |
*** jtomasek has quit IRC | 16:54 | |
*** cshen_ has joined #openstack-horizon | 16:56 | |
*** gyee has joined #openstack-horizon | 17:01 | |
*** cshen_ has quit IRC | 17:03 | |
*** priteau has joined #openstack-horizon | 17:04 | |
*** priteau has quit IRC | 17:08 | |
*** cshen_ has joined #openstack-horizon | 17:13 | |
*** udesale has quit IRC | 17:18 | |
*** cshen_ has quit IRC | 17:19 | |
*** jtriley has quit IRC | 17:27 | |
openstackgerrit | Merged openstack/horizon master: Drop flavor name validation in horizon side. https://review.openstack.org/528675 | 17:31 |
*** cshen_ has joined #openstack-horizon | 17:39 | |
*** jtriley has joined #openstack-horizon | 17:40 | |
*** cshen_ has quit IRC | 17:50 | |
*** rmcall has joined #openstack-horizon | 17:50 | |
*** sapd_ has joined #openstack-horizon | 18:01 | |
*** sapd has quit IRC | 18:01 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Support "Get me a network" in launch instance https://review.openstack.org/514084 | 18:04 |
*** makowals has joined #openstack-horizon | 18:11 | |
*** e0ne has joined #openstack-horizon | 18:16 | |
*** flwang1 has joined #openstack-horizon | 18:19 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Updating default keystone API verson to 3 https://review.openstack.org/529393 | 18:27 |
*** flwang1 has quit IRC | 18:30 | |
*** ellopunk has quit IRC | 18:34 | |
*** ellopunk has joined #openstack-horizon | 18:35 | |
*** ellopunk has quit IRC | 18:39 | |
*** jtomasek has joined #openstack-horizon | 18:41 | |
ying_zuo | Weekly Horizon meeting is starting in an hour #openstack-meeting-3 | 19:00 |
ying_zuo | https://wiki.openstack.org/wiki/Meetings/Horizon | 19:00 |
*** ellopunk has joined #openstack-horizon | 19:12 | |
*** makowals has quit IRC | 19:15 | |
*** jeremy_moffitt has quit IRC | 19:15 | |
*** david-lyle sets mode: +v e0ne | 19:16 | |
*** jeremy_moffitt has joined #openstack-horizon | 19:21 | |
*** felipemonteiro__ has joined #openstack-horizon | 19:28 | |
*** pcaruana has quit IRC | 19:29 | |
*** felipemonteiro_ has quit IRC | 19:32 | |
*** pcaruana has joined #openstack-horizon | 19:48 | |
*** jtomasek has quit IRC | 19:50 | |
*** pcaruana has quit IRC | 19:54 | |
*** ellopunk has quit IRC | 19:57 | |
*** cshen_ has joined #openstack-horizon | 20:05 | |
*** cshen_ has joined #openstack-horizon | 20:06 | |
*** pcaruana has joined #openstack-horizon | 20:06 | |
*** flwang1 has joined #openstack-horizon | 20:09 | |
*** ellopunk has joined #openstack-horizon | 20:13 | |
*** pcaruana has quit IRC | 20:13 | |
*** ellopunk has quit IRC | 20:15 | |
*** ellopunk has joined #openstack-horizon | 20:15 | |
*** amoralej is now known as amoralej|off | 20:17 | |
*** cshen_ has quit IRC | 20:27 | |
*** cshen_ has joined #openstack-horizon | 20:28 | |
*** cshen_ has quit IRC | 20:39 | |
*** cshen_ has joined #openstack-horizon | 20:40 | |
*** cshen_ has quit IRC | 20:48 | |
*** felipemonteiro_ has joined #openstack-horizon | 20:53 | |
*** felipemonteiro__ has quit IRC | 20:53 | |
*** catintheroof has joined #openstack-horizon | 20:54 | |
*** ellopunk has quit IRC | 20:55 | |
*** cshen_ has joined #openstack-horizon | 21:01 | |
*** priteau has joined #openstack-horizon | 21:04 | |
amotoki | david-lyle: regarding bug 1739108, is it still "Incomplete" if I drop my analysis and describe only what happens? | 21:07 |
openstack | bug 1739108 in OpenStack Dashboard (Horizon) "api.keystone.is_cloud_admin/is_domain_admin do not work with the latest policy from keystone repo" [Critical,Incomplete] https://launchpad.net/bugs/1739108 | 21:08 |
*** priteau has quit IRC | 21:09 | |
amotoki | I am fine to drop my analysis. I think it is more important to keep the bug itself valid rather than my analysis. | 21:10 |
*** HARSHA has joined #openstack-horizon | 21:10 | |
*** cshen_ has quit IRC | 21:10 | |
david-lyle | amotoki, no you are correct, moved back to new | 21:10 |
david-lyle | I had to reread the title | 21:11 |
david-lyle | it's accurate | 21:11 |
david-lyle | was thinking that cause was in there, but that was my mistake | 21:11 |
amotoki | david-lyle: thanks for checking. | 21:14 |
amotoki | david-lyle: after adding "default": "rule:admin_required" again, I can see "Modify Quotas" | 21:15 |
amotoki | "cloud_admin" rule does not exist, so I guess "default" rule has an effect for non-existing policy rule. | 21:15 |
david-lyle | amotoki, it really shouldn't :) | 21:16 |
david-lyle | amotoki, ah https://github.com/openstack/horizon/blob/master/openstack_auth/policy.py#L190 | 21:18 |
amotoki | david-lyle: http://git.openstack.org/cgit/openstack/oslo.policy/tree/oslo_policy/policy.py#n213 | 21:18 |
david-lyle | oh good we lost all history | 21:18 |
david-lyle | :( | 21:18 |
david-lyle | that line is wrong | 21:19 |
david-lyle | or at least not how I wrote and intended intitally | 21:20 |
amotoki | description for an empty rule http://git.openstack.org/cgit/openstack/oslo.policy/tree/oslo_policy/policy.py#n97 | 21:20 |
*** cshen_ has joined #openstack-horizon | 21:20 | |
amotoki | it says the empty string (``""``) is equivalent to the "@" and "@" will always accept an access | 21:20 |
david-lyle | it's the missing rule check that is behaving incorrectly IMO | 21:21 |
david-lyle | we can't assume default, but we never really could | 21:21 |
david-lyle | should just allow | 21:21 |
amotoki | hmm.... but neutron policy assumes the behavior documented in the oslo_policy.policy since before horizon implemented the policy support | 21:22 |
amotoki | so I don't think the behavior of oslo_policy was changed since then. | 21:22 |
*** catinthe_ has joined #openstack-horizon | 21:23 | |
david-lyle | amotoki, I think we're talking two different points | 21:23 |
david-lyle | the problem is not the righthand side in this case | 21:23 |
amotoki | david-lyle: oslo.policy and horizon/openstack_auth policy support? | 21:23 |
david-lyle | it's the left | 21:23 |
david-lyle | the rule is missing | 21:23 |
david-lyle | so based on the line I linked above | 21:24 |
*** ellopunk has joined #openstack-horizon | 21:24 | |
david-lyle | we're trying to apply the default rule | 21:24 |
david-lyle | which is wrong | 21:24 |
david-lyle | flat out wrong | 21:24 |
david-lyle | we never even get to the right hand side | 21:24 |
*** catintheroof has quit IRC | 21:25 | |
david-lyle | we would work if the rule was defined on the left, but with no right hand side | 21:25 |
david-lyle | because we would allow | 21:25 |
david-lyle | the right answer in my opinion is to just remove https://github.com/openstack/horizon/blob/master/openstack_auth/policy.py#L184-192 | 21:27 |
amotoki | david-lyle: do you mean we should drop the fallback behavior to "default" ? | 21:28 |
flwang | hi team, i just sent an email to ops mailing list to prompt the work we have done for the performance of horizon recently | 21:28 |
flwang | [Openstack-operators] [publiccloud] Improvement for Horizon performance | 21:28 |
flwang | pls feel free to comment it | 21:29 |
flwang | sorry for chiming in | 21:29 |
david-lyle | amotoki, the other option would be check for default and return allowed if default rule is not defined | 21:30 |
david-lyle | effectively this will be the same thing once all the policy in code happens | 21:30 |
david-lyle | but leaves the option to define a default rule in the horizon policy file if desired | 21:30 |
david-lyle | that's probably the safest short term fix | 21:31 |
*** ellopunk has quit IRC | 21:31 | |
amotoki | I think it is more safe to return False if a rule is not defined. it is more defensive. | 21:32 |
david-lyle | amotoki, we don't need to be defensive | 21:32 |
david-lyle | the APIs do that for us | 21:32 |
david-lyle | we check policy for better UX only | 21:32 |
david-lyle | the APIs will always catch us when we're wrong | 21:33 |
amotoki | david-lyle: ah, i see. it makes sense | 21:33 |
david-lyle | better to be too permissive on our end than overly strict | 21:33 |
amotoki | i was thinking to keep the horizon policy behavior same as oslo.policy for easy understanding, but it is not true | 21:34 |
amotoki | david-lyle: regarding is_cloud_admin/is_domain_admin(), i am also thinking to make the rule name configurable. | 21:35 |
*** catinthe_ has quit IRC | 21:35 | |
amotoki | in my understanding, there is no common rule names for domain admin. | 21:35 |
*** HARSHA has quit IRC | 21:35 | |
*** catintheroof has joined #openstack-horizon | 21:35 | |
amotoki | it is only defined in keystone policy.v3cloudsample.json | 21:35 |
amotoki | so I wonder it is worth configurable. | 21:36 |
david-lyle | amotoki, I would be fine with that, those were always a kludge | 21:36 |
*** threestrands_ has joined #openstack-horizon | 21:36 | |
*** lblanchard has joined #openstack-horizon | 21:37 | |
david-lyle | that v3 sample policy file was always problematic as well | 21:37 |
e0ne | flwang: thanks! I added it to my TODO's list for tomorrow morning | 21:37 |
*** rmcall has quit IRC | 21:38 | |
*** catintheroof has quit IRC | 21:40 | |
amotoki | flwang: thanks for summarizing it. regarding 3 and 4, it means two extra calls. do they cost much? | 21:40 |
amotoki | flwang: regarding 5, I personally think it is not a bad idea. different folks have different opinons... | 21:42 |
*** lblanchard has quit IRC | 21:43 | |
amotoki | flwang: point 3 (usage check), does tenant_absolute_limit API call cost in your cloud? | 21:45 |
flwang | amotoki: for 3 | 21:45 |
flwang | i'm not really happy to see it's reverted, TBH | 21:46 |
flwang | I was told it's not consistent after that, but my point is, the the way is correct, why don't we change the other panels as well | 21:46 |
amotoki | what is "the way"? | 21:47 |
flwang | amotoki: it does cost, but not much. the main point for that patch is, it's doing duplicated things | 21:47 |
flwang | because when user open the modal dialog, Horizon will do another call to check it again | 21:47 |
flwang | which is silly IMHO | 21:47 |
flwang | 'the way' is 'removing the duplicated quota check' | 21:48 |
amotoki | flwang: i understand your point. checking quotas in the list table works only when a user clicks a button JUST AFTER displaying a table. otherwise, the status of a button will be obsolte easily | 21:50 |
flwang | amotoki: true | 21:50 |
amotoki | flwang: perhaps it needs to be discussed from that point | 21:51 |
*** priteau has joined #openstack-horizon | 21:51 | |
amotoki | flwang: IIRC, when the patch was reverted we discussed it only from the performance perspective. it is one API call and make tables inconsistent | 21:52 |
flwang | amotoki: it's not only related to the performance, it's related to stopping adding any unnecessary api calls to any panels | 21:52 |
flwang | dashboard is always a place easily to be over-engineered | 21:53 |
amotoki | flwang: regarding 4 (nova extension list), I agree that there is no need to call the API whenever a panel is open | 21:54 |
amotoki | flwang: it is enough to fetch it for example when a user logs in. | 21:54 |
amotoki | flwang: it is not limited to nova API. it also applies to other services too | 21:55 |
*** ellopunk has joined #openstack-horizon | 21:55 | |
*** priteau has quit IRC | 21:56 | |
*** ellopunk has quit IRC | 21:56 | |
*** ellopunk has joined #openstack-horizon | 21:59 | |
*** ellopunk has quit IRC | 21:59 | |
*** ellopunk has joined #openstack-horizon | 22:00 | |
*** itlinux_ has joined #openstack-horizon | 22:00 | |
*** ellopunk has quit IRC | 22:00 | |
*** cshen_ has quit IRC | 22:01 | |
*** ellopunk has joined #openstack-horizon | 22:03 | |
flwang | amotoki: that one is tiny, IIRC, horizon is caching it, but I don't know why it's still impacting the final performance in my testing | 22:03 |
*** ellopunk has joined #openstack-horizon | 22:06 | |
*** ellopunk has quit IRC | 22:07 | |
flwang | amotoki: as for 5, I'm still thinking it should be in | 22:07 |
amotoki | flwang: yeah, I think it is reasonable. I think "Image Name" filter won't work after image_list is dropped. | 22:08 |
amotoki | flwang: that is what I think needs to be updated. | 22:09 |
flwang | amotoki: yep, i suggest it's optional | 22:09 |
flwang | amotoki: let me explain the real world case about using instance panel | 22:10 |
flwang | as a user, i just want to get my instance list, with very basic information | 22:10 |
flwang | if i want to see details, i will open the one i'm interested | 22:10 |
flwang | otherwise, I'd like to see a very quick listing | 22:11 |
flwang | instead of listing everything on the panel slowly | 22:11 |
amotoki | flwang: I understand your motivation. i know most users do not care image name or flavor name in the instance table. | 22:13 |
amotoki | flwang: one exception from use cases of users of my cloud is IP addresses. they usually check IP addresses from the instance table | 22:13 |
amotoki | flwang: they would like to check IP addresses of multiple servers without visiting individual pages. | 22:14 |
flwang | amotoki: i understand, but I think all of them should be configurable, in a better world | 22:15 |
flwang | configurable to get better user experience/performance | 22:15 |
*** itlinux_ has quit IRC | 22:18 | |
*** felipemonteiro__ has joined #openstack-horizon | 22:20 | |
*** e0ne has quit IRC | 22:23 | |
*** felipemonteiro_ has quit IRC | 22:24 | |
*** david-lyle has quit IRC | 22:24 | |
amotoki | flwang: yeah, that is the reason I move forward servers_update_addresses patch forward :) | 22:26 |
*** e0ne has joined #openstack-horizon | 22:26 | |
*** e0ne has quit IRC | 22:26 | |
flwang | amotoki: thank you ;) | 22:26 |
*** e0ne has joined #openstack-horizon | 22:27 | |
*** e0ne has quit IRC | 22:28 | |
*** e0ne has joined #openstack-horizon | 22:28 | |
*** e0ne has quit IRC | 22:28 | |
*** itlinux_ has joined #openstack-horizon | 22:30 | |
*** rcernin has joined #openstack-horizon | 22:32 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: WIP: Cache extension list in session store https://review.openstack.org/529423 | 22:34 |
amotoki | flwang: I think the approach like the above patch works for extension list ^^ | 22:35 |
*** jappleii__ has joined #openstack-horizon | 22:35 | |
amotoki | i have no enough time to work on this more this year, but it works for your nova extension whitelist patch too. | 22:35 |
*** threestrands_ has quit IRC | 22:36 | |
amotoki | note that it does not work with the cookie-based session as it exceeds the cookie size limit. | 22:37 |
flwang | amotoki: that's alright | 22:37 |
flwang | I really appreciate for your effort on this | 22:37 |
*** itlinux_ has quit IRC | 22:54 | |
*** david-lyle has joined #openstack-horizon | 22:56 | |
*** ChanServ sets mode: +o david-lyle | 22:56 | |
*** itlinux_ has joined #openstack-horizon | 23:09 | |
*** rmcall has joined #openstack-horizon | 23:09 | |
*** jtriley has quit IRC | 23:10 | |
*** rmcall has quit IRC | 23:10 | |
*** rmcall has joined #openstack-horizon | 23:10 | |
*** dave-mccowan has quit IRC | 23:17 | |
*** jtriley has joined #openstack-horizon | 23:24 | |
*** felipemonteiro__ has quit IRC | 23:24 | |
*** felipemonteiro__ has joined #openstack-horizon | 23:24 | |
*** felipemonteiro__ has quit IRC | 23:41 | |
*** itlinux_ has quit IRC | 23:42 | |
*** itlinux__ has joined #openstack-horizon | 23:46 | |
*** felipemonteiro__ has joined #openstack-horizon | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!