*** gyee has quit IRC | 00:00 | |
*** mvkr has quit IRC | 00:05 | |
*** mvkr has joined #openstack-horizon | 00:18 | |
*** lblanchard has joined #openstack-horizon | 00:46 | |
*** btully has joined #openstack-horizon | 01:30 | |
*** btully has quit IRC | 01:34 | |
*** Bhujay has joined #openstack-horizon | 02:00 | |
*** lblanchard has quit IRC | 02:01 | |
*** Bhujay has quit IRC | 03:24 | |
*** hoonetorg has quit IRC | 04:29 | |
*** Bhujay has joined #openstack-horizon | 04:45 | |
*** hoonetorg has joined #openstack-horizon | 04:47 | |
*** Bhujay has quit IRC | 04:51 | |
*** Bhujay has joined #openstack-horizon | 04:53 | |
*** hoonetorg has quit IRC | 04:54 | |
*** hoonetorg has joined #openstack-horizon | 05:06 | |
*** rcernin has quit IRC | 06:38 | |
*** rcernin has joined #openstack-horizon | 06:40 | |
*** pcaruana has joined #openstack-horizon | 06:42 | |
*** rcernin has quit IRC | 06:51 | |
*** btully has joined #openstack-horizon | 06:56 | |
*** btully has quit IRC | 07:01 | |
*** btully has joined #openstack-horizon | 07:15 | |
*** rdopiera has joined #openstack-horizon | 07:24 | |
*** jtomasek has joined #openstack-horizon | 07:24 | |
*** tosky has joined #openstack-horizon | 07:29 | |
*** jtomasek has quit IRC | 07:33 | |
*** jtomasek has joined #openstack-horizon | 07:33 | |
*** jpich has joined #openstack-horizon | 07:39 | |
*** btully has quit IRC | 07:44 | |
*** e0ne has joined #openstack-horizon | 08:10 | |
*** ChanServ sets mode: +o e0ne | 08:10 | |
tosky | amotoki: hi! Regarding https://review.openstack.org/#/c/593059/, did you see my last comment? | 08:23 |
---|---|---|
e0ne | we've got only one patch left https://review.openstack.org/#/c/593629/ to stable/rocky before rc2 | 09:13 |
*** e0ne changes topic to "OpenStack Horizon | Rocky PTG: https://etherpad.openstack.org/p/horizon-ptg-rocky | Rocky RC2 priorities: https://launchpad.net/horizon/+milestone/rocky-rc2 | Docs: https://docs.openstack.org/horizon/latest/" | 09:16 | |
*** e0ne changes topic to "OpenStack Horizon | Stein PTG: https://etherpad.openstack.org/p/horizon-ptg-planning-denver-2018 | Rocky RC2 priorities: https://launchpad.net/horizon/+milestone/rocky-rc2 | Docs: https://docs.openstack.org/horizon/latest/" | 09:16 | |
*** btully has joined #openstack-horizon | 09:30 | |
*** btully has quit IRC | 09:34 | |
*** Bhujay has quit IRC | 10:26 | |
*** Bhujay has joined #openstack-horizon | 11:13 | |
*** e0ne has quit IRC | 11:36 | |
*** btully has joined #openstack-horizon | 13:08 | |
*** btully has quit IRC | 13:12 | |
*** e0ne has joined #openstack-horizon | 13:40 | |
*** ChanServ sets mode: +o e0ne | 13:40 | |
*** lblanchard has joined #openstack-horizon | 13:46 | |
*** lblanchard has quit IRC | 13:54 | |
amotoki | tosky: hi, you around? | 14:08 |
tosky | amotoki: hi! | 14:36 |
amotoki | tosky: hi. I updated https://review.openstack.org/#/c/593059/. I'd like to know your opinion whether dropping sahara_dashboard arg loosk good or not. | 14:36 |
tosky | amotoki: so, I need to check; I was simply copying what (I thought) I've seen in horizon | 14:38 |
amotoki | tosky: in case of horizon, we have a shell script wrapper file 'unit_tests.sh' to limit test cases | 14:39 |
amotoki | but it seems too much for sahara-dashboard. | 14:39 |
tosky | amotoki: but the cover target for horizon has both an argument and {posargs} | 14:43 |
tosky | that's where I copied | 14:43 |
tosky | even unit_tests.sh has both the argument and the additional argument as $posargs | 14:44 |
amotoki | tosky: to be honest I don't know what is the usage of {posargs} in horizon [cover] env | 14:47 |
*** r-daneel has joined #openstack-horizon | 14:47 | |
tosky | amotoki: but also checking unit_tests.sh, you can see | 14:48 |
amotoki | tosky: in horizon, tox -e py35 runs all horizon, openstack_auth and openstack_dashboard tests. if openstack_horizon is specified only tests under opnestack_dashboard will be run. if more specific test name is specified, only the test is run | 14:48 |
tosky | $testcommand horizon --settings=horizon.test.settings --verbosity 2 $tagarg $posargs | 14:48 |
tosky | which will be expanded to | 14:48 |
tosky | .../manage.py test horizon --settings=horizon.test.settings --verbosity 2 $tagarg $posargs | 14:48 |
amotoki | tosky: yes, but only when 'horizon' is specified as {posargs} | 14:49 |
amotoki | tosky: do you prefer to introducing something like horizon unit_tests.sh? | 14:51 |
tosky | that's for subset | 14:51 |
tosky | I mean, see lines 40-44 | 14:51 |
tosky | oh, nevermind | 14:51 |
tosky | let's merge as it is | 14:51 |
amotoki | okay | 14:52 |
amotoki | horizon repo contains three python modules | 14:52 |
amotoki | we just would like to run tests from this order. | 14:52 |
amotoki | tosky: I still don't understand why you think 'sahara_dashboard' argument is required. | 14:53 |
amotoki | tosky: https://docs.djangoproject.com/en/2.1/topics/testing/overview/#running-tests says 'python manage.py test' should work | 14:53 |
tosky | I see | 14:53 |
tosky | because I've seen it elsewhere and I don't know how it works | 14:54 |
tosky | that's it | 14:54 |
amotoki | > we just would like to run tests from this order | 14:54 |
amotoki | we have more reason | 14:54 |
amotoki | we would like to use separate django settings file for horizon/openstack_auth/openstack_dashboard | 14:54 |
amotoki | this is the reason | 14:55 |
*** btully has joined #openstack-horizon | 14:56 | |
*** btully has quit IRC | 15:00 | |
*** pcaruana has quit IRC | 15:09 | |
*** priteau has joined #openstack-horizon | 15:13 | |
tosky | merged, and we are backporting it to stable/rocky | 15:14 |
amotoki | tosky: thanks for checking the detail. | 15:25 |
*** Bhujay has quit IRC | 15:27 | |
*** vmarkov has joined #openstack-horizon | 15:36 | |
*** dklyle has quit IRC | 15:41 | |
*** dklyle has joined #openstack-horizon | 15:44 | |
*** ChanServ sets mode: +o dklyle | 15:44 | |
*** e0ne has quit IRC | 15:44 | |
*** marlinc has quit IRC | 15:45 | |
*** marlinc has joined #openstack-horizon | 15:53 | |
*** gyee has joined #openstack-horizon | 15:56 | |
*** rdopiera has quit IRC | 16:02 | |
*** lblanchard has joined #openstack-horizon | 16:09 | |
*** jtomasek_ has joined #openstack-horizon | 16:25 | |
*** jtomasek has quit IRC | 16:26 | |
*** jpich has quit IRC | 16:34 | |
*** vmarkov has quit IRC | 16:39 | |
*** btully has joined #openstack-horizon | 16:45 | |
*** btully has quit IRC | 16:49 | |
*** Nishant_ has joined #openstack-horizon | 16:53 | |
*** tosky has quit IRC | 17:24 | |
*** e0ne has joined #openstack-horizon | 17:42 | |
*** ChanServ sets mode: +o e0ne | 17:42 | |
*** dave-mccowan has quit IRC | 17:44 | |
*** Nishant_ has quit IRC | 18:23 | |
*** Nishant_ has joined #openstack-horizon | 18:24 | |
*** btully has joined #openstack-horizon | 18:33 | |
*** vkmc has quit IRC | 18:37 | |
*** fungi has quit IRC | 18:37 | |
*** btully has quit IRC | 18:38 | |
*** vkmc has joined #openstack-horizon | 18:40 | |
*** fbouliane has quit IRC | 18:42 | |
*** TheJulia has quit IRC | 18:42 | |
*** mnaser has quit IRC | 18:42 | |
*** tsufiev has quit IRC | 18:42 | |
*** jrist has quit IRC | 18:46 | |
*** fbouliane has joined #openstack-horizon | 18:46 | |
*** fungi has joined #openstack-horizon | 18:48 | |
*** Nishant_ has quit IRC | 18:50 | |
*** e0ne has quit IRC | 18:57 | |
*** priteau has quit IRC | 19:00 | |
*** TheJulia has joined #openstack-horizon | 19:03 | |
*** mnaser has joined #openstack-horizon | 19:09 | |
*** r-daneel has quit IRC | 19:24 | |
*** r-daneel has joined #openstack-horizon | 19:24 | |
*** ruriryan has quit IRC | 19:34 | |
*** samueldmq has quit IRC | 19:46 | |
*** BlackDex has quit IRC | 19:48 | |
*** samueldmq has joined #openstack-horizon | 19:49 | |
*** BlackDex has joined #openstack-horizon | 19:52 | |
*** r-daneel has quit IRC | 20:03 | |
*** r-daneel has joined #openstack-horizon | 20:03 | |
*** Tahvok_ has joined #openstack-horizon | 20:12 | |
*** itlinux has joined #openstack-horizon | 20:14 | |
*** edmondsw_ has joined #openstack-horizon | 20:18 | |
*** Tahvok has quit IRC | 20:19 | |
*** edmondsw has quit IRC | 20:19 | |
*** edmondsw_ is now known as edmondsw | 20:19 | |
*** Tahvok_ is now known as Tahvok | 20:19 | |
*** lblanchard has quit IRC | 20:22 | |
*** btully has joined #openstack-horizon | 20:22 | |
*** btully has quit IRC | 20:27 | |
*** harlowja has joined #openstack-horizon | 21:02 | |
*** itlinux has quit IRC | 21:51 | |
*** tosky has joined #openstack-horizon | 22:07 | |
*** rcernin has joined #openstack-horizon | 22:10 | |
*** btully has joined #openstack-horizon | 22:11 | |
*** btully has quit IRC | 22:16 | |
*** jtomasek_ has quit IRC | 22:47 | |
*** tosky has quit IRC | 23:07 | |
*** r-daneel has quit IRC | 23:09 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!