*** btully has quit IRC | 00:02 | |
*** btully has joined #openstack-horizon | 00:06 | |
*** btully has quit IRC | 00:11 | |
*** btully has joined #openstack-horizon | 00:23 | |
*** btully has quit IRC | 00:28 | |
*** btully has joined #openstack-horizon | 00:32 | |
*** btully has quit IRC | 00:36 | |
*** cshen has joined #openstack-horizon | 00:46 | |
*** cshen has quit IRC | 00:51 | |
*** Emine has quit IRC | 00:55 | |
*** btully has joined #openstack-horizon | 01:12 | |
*** btully has quit IRC | 01:17 | |
*** Bhujay has joined #openstack-horizon | 02:19 | |
*** Bhujay has quit IRC | 02:19 | |
*** Bhujay has joined #openstack-horizon | 02:20 | |
*** btully has joined #openstack-horizon | 02:32 | |
*** btully has quit IRC | 02:36 | |
*** Bhujay has quit IRC | 02:59 | |
*** btully has joined #openstack-horizon | 03:11 | |
*** btully has quit IRC | 03:18 | |
*** btully has joined #openstack-horizon | 03:31 | |
*** btully has quit IRC | 03:36 | |
*** rcernin_ has quit IRC | 03:42 | |
*** rcernin has joined #openstack-horizon | 03:43 | |
*** btully has joined #openstack-horizon | 03:46 | |
*** dave-mccowan has quit IRC | 03:46 | |
*** btully has quit IRC | 03:50 | |
*** cshen has joined #openstack-horizon | 04:54 | |
*** cshen has quit IRC | 04:58 | |
*** btully has joined #openstack-horizon | 05:21 | |
*** btully has quit IRC | 05:25 | |
*** btully has joined #openstack-horizon | 05:28 | |
*** Bhujay has joined #openstack-horizon | 05:35 | |
*** btully has quit IRC | 05:37 | |
*** btully has joined #openstack-horizon | 05:45 | |
*** btully has quit IRC | 05:49 | |
*** btully has joined #openstack-horizon | 05:53 | |
*** btully has quit IRC | 05:57 | |
*** btully has joined #openstack-horizon | 06:01 | |
*** hoangcx has quit IRC | 06:11 | |
*** hoangcx has joined #openstack-horizon | 06:12 | |
*** eric_fairbanks has joined #openstack-horizon | 06:14 | |
*** btully has quit IRC | 06:17 | |
*** btully has joined #openstack-horizon | 06:21 | |
*** btully has quit IRC | 06:26 | |
*** cshen has joined #openstack-horizon | 06:29 | |
*** btully has joined #openstack-horizon | 06:30 | |
*** pcaruana has joined #openstack-horizon | 06:33 | |
*** btully has quit IRC | 06:38 | |
*** btully has joined #openstack-horizon | 06:42 | |
*** btully has quit IRC | 06:46 | |
*** btully has joined #openstack-horizon | 06:50 | |
*** btully has quit IRC | 06:55 | |
*** btully has joined #openstack-horizon | 06:58 | |
*** btully has quit IRC | 07:03 | |
*** btully has joined #openstack-horizon | 07:07 | |
*** btully has quit IRC | 07:11 | |
*** rcernin has quit IRC | 07:12 | |
*** rdopiera has joined #openstack-horizon | 07:13 | |
*** btully has joined #openstack-horizon | 07:15 | |
adriant | rdopiera: i've yet to test out the last memoized patch you did, but it looks sane and should help. | 07:16 |
---|---|---|
*** btully has quit IRC | 07:19 | |
rdopiera | it will only help with the functions that take a request object, though | 07:20 |
rdopiera | everything else will still be cached indifinitely | 07:20 |
*** btully has joined #openstack-horizon | 07:23 | |
*** openstackgerrit has joined #openstack-horizon | 07:24 | |
openstackgerrit | Adrian Turjak proposed openstack/horizon master: Ugly fix to clear memo cache every request https://review.openstack.org/604934 | 07:24 |
adriant | rdopiera: just realised why my old version fo ^ failed to help | 07:26 |
adriant | to* | 07:26 |
adriant | of* | 07:26 |
adriant | clearing the top level cache I was creating did nothing if the cache inside the closure was still there... new version in theory, while drastic should clear everything | 07:27 |
adriant | will test it again tomorrow, and your patch | 07:27 |
*** btully has quit IRC | 07:28 | |
rdopiera | adriant: to be clear, please test this: https://review.openstack.org/#/c/605024/ | 07:28 |
rdopiera | adriant: and not the first one | 07:28 |
adriant | yep, that was the plan | 07:29 |
rdopiera | the first one, with the clear function, suffers from race conditions | 07:29 |
rdopiera | when there are multiple requests | 07:29 |
adriant | hmmm, that's a point... my patch probably would too. It would clear the cache for requests along side it rather than just the request in question | 07:31 |
* adriant has an idea | 07:31 | |
*** btully has joined #openstack-horizon | 07:32 | |
*** cshen has quit IRC | 07:32 | |
adriant | hmmm, no, doing a cache per request isn't particularly doable since the decorator doesn't know the request unless it happens to be called for a function which passes one in | 07:35 |
rdopiera | right, and for functions that don't take a request we really don't know when the value will be needed again | 07:35 |
rdopiera | one more possibility is to use an LRU cache -- this way we can have a cap on the total amount of memory used | 07:36 |
adriant | at which point we may as well just use memcached which already does that | 07:37 |
rdopiera | we can't, because Horizon doesn't require memcached | 07:37 |
rdopiera | there are installs that don't have it | 07:37 |
rdopiera | besides, it's slow | 07:37 |
adriant | yeah, we lose a lot of the benefit of replacing an api call, with... well a different api call really | 07:40 |
*** btully has quit IRC | 07:40 | |
adriant | unless memcache is running on the same host | 07:40 |
adriant | which isn't often the case | 07:40 |
rdopiera | with python 3's dicts that keep the insertion order, making a LRU cache should be easy | 07:40 |
rdopiera | you basically check the len of the dict, and if it's over the limit, remove the first element | 07:41 |
adriant | and it would be faster than iterating through and checking expiry times too | 07:42 |
*** btully has joined #openstack-horizon | 07:44 | |
adriant | and if the MAX_MEMOIZED_ENTRIES or some setting key is configurable it makes it easy enough to tweak, but we'd want to do some testing and add docs for approximate max entries vs memory usage so a deployment can easily enough tweak it | 07:44 |
*** tosky has joined #openstack-horizon | 07:45 | |
adriant | and so they are aware that it's a per worker setting (depending on their server) | 07:45 |
rdopiera | it could be a global setting, like you say, or it could be set in the decorator per function | 07:46 |
rdopiera | or some mix of the two (maybe a multiplier set per function) | 07:46 |
adriant | oooh, yeah that could be useful. | 07:46 |
rdopiera | in any case, let's try the simlest thing for now | 07:46 |
adriant | yep, will test things tomorrow | 07:47 |
rdopiera | we can't do that anyways while python 2 is still supported | 07:47 |
adriant | and we're still running horizon in py27 :( | 07:47 |
rdopiera | some customers are | 07:47 |
adriant | but switching to py36 in docker soon | 07:47 |
*** jpich has joined #openstack-horizon | 07:47 | |
adriant | ok | 07:48 |
adriant | will update you how tests go | 07:48 |
* adriant finally leaves the office | 07:48 | |
*** btully has quit IRC | 07:52 | |
*** btully has joined #openstack-horizon | 07:57 | |
*** cshen has joined #openstack-horizon | 07:59 | |
*** btully has quit IRC | 08:01 | |
*** cshen has quit IRC | 08:03 | |
*** btully has joined #openstack-horizon | 08:04 | |
*** btully has quit IRC | 08:09 | |
*** e0ne has joined #openstack-horizon | 08:12 | |
*** ChanServ sets mode: +o e0ne | 08:12 | |
*** btully has joined #openstack-horizon | 08:13 | |
*** eric_fairbanks has quit IRC | 08:16 | |
*** btully has quit IRC | 08:17 | |
*** btully has joined #openstack-horizon | 08:21 | |
*** btully has quit IRC | 08:26 | |
*** btully has joined #openstack-horizon | 08:29 | |
*** btully has quit IRC | 08:33 | |
openstackgerrit | Edward Hope-Morley proposed openstack/horizon master: Add enabled check in Backups panel https://review.openstack.org/605442 | 08:37 |
*** btully has joined #openstack-horizon | 08:37 | |
*** btully has quit IRC | 08:42 | |
*** btully has joined #openstack-horizon | 08:45 | |
*** btully has quit IRC | 08:50 | |
*** btully has joined #openstack-horizon | 08:54 | |
*** btully has quit IRC | 08:58 | |
*** btully has joined #openstack-horizon | 09:02 | |
*** btully has quit IRC | 09:06 | |
*** btully has joined #openstack-horizon | 09:10 | |
*** btully has quit IRC | 09:15 | |
*** btully has joined #openstack-horizon | 09:18 | |
*** Bhujay has quit IRC | 09:19 | |
*** btully has quit IRC | 09:23 | |
*** btully has joined #openstack-horizon | 09:24 | |
*** Emine has joined #openstack-horizon | 09:24 | |
*** Bhujay has joined #openstack-horizon | 09:25 | |
*** btully has quit IRC | 09:29 | |
adriant | oh, rdopiera (since I'm still online for silly reasons) why not just use an ordereddict since that then works with both py3 and 2? | 09:30 |
*** btully has joined #openstack-horizon | 09:31 | |
*** btully has quit IRC | 09:35 | |
*** btully has joined #openstack-horizon | 09:39 | |
*** btully has quit IRC | 09:44 | |
*** btully has joined #openstack-horizon | 09:47 | |
*** btully has quit IRC | 09:52 | |
*** btully has joined #openstack-horizon | 09:55 | |
*** btully has quit IRC | 10:00 | |
*** btully has joined #openstack-horizon | 10:04 | |
*** btully has quit IRC | 10:08 | |
*** btully has joined #openstack-horizon | 10:12 | |
*** eric_fairbanks has joined #openstack-horizon | 10:15 | |
*** btully has quit IRC | 10:21 | |
*** btully has joined #openstack-horizon | 10:24 | |
*** btully has quit IRC | 10:29 | |
*** btully has joined #openstack-horizon | 10:32 | |
*** btully has quit IRC | 10:37 | |
*** btully has joined #openstack-horizon | 10:41 | |
*** btully has quit IRC | 10:45 | |
*** btully has joined #openstack-horizon | 10:49 | |
*** btully has quit IRC | 10:54 | |
*** btully has joined #openstack-horizon | 10:57 | |
*** btully has quit IRC | 11:02 | |
*** btully has joined #openstack-horizon | 11:05 | |
*** btully has quit IRC | 11:14 | |
*** btully has joined #openstack-horizon | 11:18 | |
*** btully has quit IRC | 11:26 | |
*** btully has joined #openstack-horizon | 11:30 | |
*** eric_fairbanks is now known as eric__ | 11:33 | |
*** eric__ is now known as erickes | 11:33 | |
*** btully has quit IRC | 11:34 | |
*** btully has joined #openstack-horizon | 11:38 | |
*** btully has quit IRC | 11:43 | |
*** tosky__ has joined #openstack-horizon | 11:44 | |
*** tosky has quit IRC | 11:44 | |
*** tosky has joined #openstack-horizon | 11:45 | |
*** btully has joined #openstack-horizon | 11:46 | |
*** pcaruana has quit IRC | 11:50 | |
*** btully has quit IRC | 11:51 | |
*** Bhujay has quit IRC | 11:51 | |
*** Bhujay has joined #openstack-horizon | 11:52 | |
*** Bhujay has quit IRC | 11:53 | |
*** Bhujay has joined #openstack-horizon | 11:53 | |
*** Bhujay has quit IRC | 11:54 | |
*** btully has joined #openstack-horizon | 11:55 | |
*** lblanchard has joined #openstack-horizon | 11:59 | |
*** btully has quit IRC | 11:59 | |
*** btully has joined #openstack-horizon | 12:03 | |
*** btully has quit IRC | 12:07 | |
*** e0ne has quit IRC | 12:09 | |
*** e0ne has joined #openstack-horizon | 12:09 | |
*** ChanServ sets mode: +o e0ne | 12:09 | |
*** btully has joined #openstack-horizon | 12:11 | |
*** tosky__ has quit IRC | 12:15 | |
*** btully has quit IRC | 12:16 | |
*** btully has joined #openstack-horizon | 12:19 | |
*** btully has quit IRC | 12:24 | |
*** btully has joined #openstack-horizon | 12:27 | |
*** btully has quit IRC | 12:32 | |
*** btully has joined #openstack-horizon | 12:36 | |
*** pcaruana has joined #openstack-horizon | 12:39 | |
*** btully has quit IRC | 12:40 | |
*** btully has joined #openstack-horizon | 12:44 | |
*** noonedeadpunk has joined #openstack-horizon | 12:44 | |
noonedeadpunk | hi folks, can you please look at the patch https://review.openstack.org/#/c/605442/ ? | 12:45 |
*** btully has quit IRC | 12:48 | |
*** btully has joined #openstack-horizon | 12:52 | |
*** btully has quit IRC | 13:00 | |
e0ne | noonedeadpunk: done | 13:02 |
*** btully has joined #openstack-horizon | 13:04 | |
noonedeadpunk | e0ne thanks) | 13:04 |
*** btully has quit IRC | 13:13 | |
*** btully has joined #openstack-horizon | 13:21 | |
*** e0ne has quit IRC | 13:22 | |
*** btully has quit IRC | 13:25 | |
*** e0ne has joined #openstack-horizon | 13:26 | |
*** ChanServ sets mode: +o e0ne | 13:26 | |
*** btully has joined #openstack-horizon | 13:29 | |
openstackgerrit | Merged openstack/horizon master: Add enabled check in Backups panel https://review.openstack.org/605442 | 13:33 |
*** btully has quit IRC | 13:34 | |
*** btully has joined #openstack-horizon | 13:37 | |
*** btully has quit IRC | 13:42 | |
*** btully has joined #openstack-horizon | 13:47 | |
*** btully has quit IRC | 13:52 | |
*** itlinux has quit IRC | 13:59 | |
*** btully has joined #openstack-horizon | 14:01 | |
openstackgerrit | Vadym Markov proposed openstack/horizon master: Hide Swift network info in Horizon error message https://review.openstack.org/605731 | 14:01 |
*** btully has quit IRC | 14:05 | |
*** Leo_m has joined #openstack-horizon | 14:09 | |
*** lblanchard has quit IRC | 14:19 | |
*** btully has joined #openstack-horizon | 14:39 | |
*** btully has quit IRC | 14:44 | |
*** lblanchard has joined #openstack-horizon | 14:55 | |
*** itlinux has joined #openstack-horizon | 14:58 | |
*** btully has joined #openstack-horizon | 15:28 | |
*** tsmith_ has joined #openstack-horizon | 15:32 | |
*** btully has quit IRC | 15:32 | |
*** tsmith_ is now known as tsmith2 | 15:36 | |
*** dave-mccowan has joined #openstack-horizon | 15:41 | |
*** e0ne has quit IRC | 15:51 | |
*** gyee has joined #openstack-horizon | 15:53 | |
*** gyee has quit IRC | 15:54 | |
*** cshen has joined #openstack-horizon | 15:56 | |
*** gyee has joined #openstack-horizon | 15:57 | |
*** btully has joined #openstack-horizon | 16:03 | |
*** btully has quit IRC | 16:07 | |
*** dave-mccowan has quit IRC | 16:08 | |
*** rdopiera has quit IRC | 16:10 | |
*** cshen has quit IRC | 16:11 | |
*** jpich has quit IRC | 16:12 | |
*** cshen has joined #openstack-horizon | 16:31 | |
*** btully has joined #openstack-horizon | 16:37 | |
*** btully has quit IRC | 16:42 | |
*** cshen has quit IRC | 16:43 | |
*** cshen has joined #openstack-horizon | 16:44 | |
*** cshen has quit IRC | 16:49 | |
*** e0ne has joined #openstack-horizon | 16:52 | |
*** ChanServ sets mode: +o e0ne | 16:52 | |
*** e0ne has quit IRC | 16:54 | |
openstackgerrit | Tobias Urdin proposed openstack/horizon master: Add hide_create_volume to LAUNCH_INSTANCE_DEFAULTS https://review.openstack.org/605813 | 17:08 |
*** btully has joined #openstack-horizon | 17:15 | |
*** e0ne has joined #openstack-horizon | 17:16 | |
*** ChanServ sets mode: +o e0ne | 17:16 | |
*** btully has quit IRC | 17:19 | |
*** Emine has quit IRC | 17:21 | |
*** btully has joined #openstack-horizon | 17:23 | |
*** btully has quit IRC | 17:28 | |
*** btully has joined #openstack-horizon | 17:33 | |
*** Emine has joined #openstack-horizon | 17:34 | |
*** cshen has joined #openstack-horizon | 17:35 | |
*** goldenfri has joined #openstack-horizon | 17:36 | |
*** btully has quit IRC | 17:38 | |
*** mvkr has quit IRC | 17:42 | |
dtruong | e0ne: the patch to fix horizon gate for the xstatic-jquery problem was merged yesterday, but we are still seeing the same problem with the senlin-dashboard | 17:47 |
dtruong | this patch is failing the nodejs-npm-run-test: https://review.openstack.org/#/c/603303/ | 17:48 |
dtruong | it looks senlin-dashboard is still using xstatic-jquery-3.3.1.1: http://logs.openstack.org/03/603303/1/check/nodejs-npm-run-test/e190788/job-output.txt.gz#_2018-09-27_07_32_33_613376 | 17:49 |
dtruong | any idea what's going on? | 17:49 |
e0ne | dtruong: it sounds like we've got two issues here | 17:51 |
e0ne | dtruong: https://github.com/openstack/senlin-dashboard/blob/master/requirements.txt#L10 - you use horizon rocky | 17:51 |
e0ne | dtruong: and I didn't backport my patch to older releases yet( | 17:51 |
dtruong | i see. let me check why we have a dependency to horizon rocky in senlin-dashboard | 17:55 |
*** btully has joined #openstack-horizon | 17:55 | |
e0ne | dtruong: TBH, I'm not sure that it will help | 17:55 |
tosky | mox removal maybe? | 17:56 |
*** eandersson has joined #openstack-horizon | 17:57 | |
e0ne | I'm trying to figure out what is going with senlin | 17:58 |
goldenfri | hello, in the admin docs for queens it says you can update cpu/disk etc in horizon in queens. I could do that in mitaka but I don't have an edit flavor option in queens, only update metadata. | 17:58 |
goldenfri | Are the docs outdated, is it a bug, or a missing feature? | 17:59 |
*** btully has quit IRC | 17:59 | |
e0ne | dtruong: so it looks even worse now | 18:00 |
e0ne | dtruong: I'm afraid, that all plugins are affected, but I'm not sure | 18:02 |
e0ne | dtruong: new jquery is installed as a horizon's dependency | 18:02 |
e0ne | dtruong: or something went wrong with this https://github.com/openstack/senlin-dashboard/blob/master/package.json#L24 | 18:03 |
*** dims_ is now known as dims | 18:05 | |
*** cshen has quit IRC | 18:05 | |
e0ne | it looks like some hack:( | 18:06 |
dtruong | yea, that line looks pretty confusing | 18:07 |
dtruong | let me dig into and compare with some other dashboard projects | 18:07 |
e0ne | as I understand, it was done for local testing. we don't need it for CI | 18:08 |
e0ne | dtruong: https://review.openstack.org/#/c/605826/ - let's wait for gates. maybe it will help us | 18:10 |
dtruong | sounds good. thanks for your help. | 18:11 |
e0ne | goldenfri: sounds like a docs issue. we removed 'edit flavor' feature | 18:11 |
e0ne | dtruong: np | 18:11 |
eandersson | pretty sure magnum-ui has the same issue | 18:11 |
eandersson | Yea - magnum suffers from the same bug | 18:12 |
e0ne | eandersson: :((( | 18:13 |
eandersson | https://github.com/openstack/magnum-ui/blob/master/package.json#L29 | 18:13 |
eandersson | It also has that lovely postinstall | 18:13 |
e0ne | eandersson: I like how do you call it:) | 18:14 |
e0ne | http://lists.openstack.org/pipermail/openstack-dev/2018-September/134599.html - an important thread about plugis | 18:15 |
e0ne | *plugins | 18:16 |
e0ne | it's not an ideal solution, but should work fine in a short-term perspective with a limited resources | 18:16 |
goldenfri | thanks e0ne is that ever expected to come back or is the only option to delete then re-create a flavor just to change a disk size? | 18:21 |
e0ne | goldenfri: yes | 18:21 |
e0ne | goldenfri: nova doesn't support flavor edit. so we just removed it to not confuse people | 18:21 |
goldenfri | ah ok, thanks | 18:22 |
e0ne | eandersson: let's wait to see if my patch works for senlin | 18:22 |
eandersson | sounds good | 18:22 |
eandersson | thanks e0ne | 18:22 |
e0ne | eandersson: np | 18:23 |
e0ne | looks like zun-ui and zaqar-ui are also affected | 18:24 |
e0ne | I've just sent a note to the openstack-dev ML | 18:34 |
*** btully has joined #openstack-horizon | 18:47 | |
*** btully has quit IRC | 18:52 | |
*** btully has joined #openstack-horizon | 19:03 | |
*** btully has quit IRC | 19:07 | |
*** itlinux has quit IRC | 19:09 | |
*** dayou has quit IRC | 19:10 | |
*** btully has joined #openstack-horizon | 19:20 | |
*** cshen has joined #openstack-horizon | 19:22 | |
*** btully has quit IRC | 19:25 | |
*** cshen has quit IRC | 19:34 | |
*** dayou has joined #openstack-horizon | 19:37 | |
*** e0ne has quit IRC | 19:42 | |
*** e0ne has joined #openstack-horizon | 19:47 | |
*** ChanServ sets mode: +o e0ne | 19:47 | |
*** e0ne has quit IRC | 19:50 | |
*** btully has joined #openstack-horizon | 19:54 | |
*** pcaruana has quit IRC | 19:54 | |
*** btully has quit IRC | 19:59 | |
*** btully has joined #openstack-horizon | 20:02 | |
*** cshen has joined #openstack-horizon | 20:05 | |
*** btully has quit IRC | 20:06 | |
*** e0ne has joined #openstack-horizon | 20:08 | |
*** ChanServ sets mode: +o e0ne | 20:08 | |
*** btully has joined #openstack-horizon | 20:13 | |
*** btully has quit IRC | 20:17 | |
*** Emine has quit IRC | 20:27 | |
*** Emine has joined #openstack-horizon | 20:28 | |
*** cshen has quit IRC | 20:29 | |
*** lblanchard has quit IRC | 20:33 | |
*** dayou has quit IRC | 20:38 | |
*** btully has joined #openstack-horizon | 20:42 | |
*** btully has quit IRC | 20:46 | |
*** dayou has joined #openstack-horizon | 21:06 | |
*** e0ne has quit IRC | 21:14 | |
*** btully has joined #openstack-horizon | 21:21 | |
*** btully has quit IRC | 21:25 | |
*** btully has joined #openstack-horizon | 21:59 | |
*** Leo_m has quit IRC | 22:01 | |
*** btully has quit IRC | 22:03 | |
*** mvkr has joined #openstack-horizon | 22:13 | |
*** cshen has joined #openstack-horizon | 22:25 | |
*** rcernin has joined #openstack-horizon | 22:29 | |
*** cshen has quit IRC | 22:32 | |
*** jtomasek has quit IRC | 22:35 | |
*** btully has joined #openstack-horizon | 22:41 | |
*** btully has quit IRC | 22:46 | |
*** tosky has quit IRC | 22:53 | |
*** btully has joined #openstack-horizon | 23:22 | |
*** btully has quit IRC | 23:31 | |
*** btully has joined #openstack-horizon | 23:42 | |
*** btully has quit IRC | 23:46 | |
*** btully has joined #openstack-horizon | 23:50 | |
*** btully has quit IRC | 23:55 | |
*** btully has joined #openstack-horizon | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!