*** BjoernT has joined #openstack-horizon | 00:58 | |
*** BjoernT has quit IRC | 00:58 | |
*** duochao has joined #openstack-horizon | 00:59 | |
*** gyee has quit IRC | 01:00 | |
*** BjoernT has joined #openstack-horizon | 01:17 | |
*** BjoernT has quit IRC | 01:24 | |
*** duochao has quit IRC | 01:31 | |
*** whoami-rajat has joined #openstack-horizon | 01:34 | |
*** btully has joined #openstack-horizon | 01:34 | |
*** btully has quit IRC | 01:39 | |
*** duochao has joined #openstack-horizon | 01:39 | |
*** tkajinam has quit IRC | 02:21 | |
*** tkajinam has joined #openstack-horizon | 02:21 | |
*** btully has joined #openstack-horizon | 03:23 | |
*** btully has quit IRC | 03:27 | |
openstackgerrit | Thomas Goirand proposed openstack/horizon master: dj_2.2_fix-urls.py-for-django-2.2 https://review.opendev.org/671652 | 03:33 |
---|---|---|
openstackgerrit | Thomas Goirand proposed openstack/horizon master: dh_2.2_fix-no-renderer https://review.opendev.org/671653 | 03:38 |
openstackgerrit | Thomas Goirand proposed openstack/horizon master: dj_2.2_Fix_test_table_column_truncation https://review.opendev.org/671654 | 03:38 |
openstackgerrit | Thomas Goirand proposed openstack/horizon master: dh_2.2_repair_test_startpanel_usage_correct https://review.opendev.org/671655 | 03:38 |
openstackgerrit | Thomas Goirand proposed openstack/horizon master: dj_2.2_replaces-none-by-empty-string https://review.opendev.org/671656 | 03:38 |
zigo | amotoki: Hi man, can you lookup on this patch series for Django 2.2 compat? :) | 03:43 |
zigo | Not all is fixed, and IMO, it needs careful review and enhancement by a Django expert (ie: not me...). | 03:44 |
amotoki | zigo: thanks for the patch series. Is there any timeframe for them? | 04:00 |
amotoki | zigo: Hopefully each patch has information on Django changes (relnote or deprecation notice) so that we can check the needed changes easily. | 04:01 |
zigo | amotoki: Are you suggesting that upstream writes a proper documentation at https://docs.djangoproject.com/en/2.2/releases/2.2/ ? | 04:02 |
zigo | I don't have this opinion ! :) | 04:02 |
zigo | It took me a fair amount of hacking time to build these! :P | 04:03 |
zigo | amotoki: One big change in Django 2.2 is that formData must *not* include variable=None, but variable='' instead, it must be all over the place in Horizon, the last patch of the series. | 04:04 |
zigo | If you know Horizon better than me, then maybe you know what to check? | 04:05 |
zigo | I can't of course grep for "None" (there would be too many occurence) to find all occurences of variables that get later assigned to formData. | 04:05 |
amotoki | zigo: what I just would like to say is to include a proper pointer in commit message like https://review.opendev.org/#/c/528467/ | 04:07 |
amotoki | from my experience on Django 2.0 migration, Django release note of the latest version sometimes was not enough and we needed to check deprecation notices to know how to handle them. | 04:07 |
amotoki | For Djagno 2.2, I haven't checked any detail so far due to time limitation. | 04:08 |
zigo | amotoki: Just try running all the unit tests of Horizon under Django 2.2, and I believe you'll get the errors I'm currently bumping into. | 04:10 |
zigo | Has the team plans for adding Django 2.2 testing? | 04:11 |
amotoki | The plan now is to support django 2.2 in U-release. Horizon now only supports Django LTS versions and Train release will be expected to use with Django 1.11 LTS. | 04:12 |
amotoki | "now" means "per PTG discussion this April". | 04:13 |
*** duochao has quit IRC | 04:13 | |
zigo | amotoki: Well, I like your plan, but that's not the one of Debian, Django 2.2 is already there for me... :P | 04:15 |
zigo | (no choice, the Django 2.2 upload wont be reverted) | 04:15 |
amotoki | yes, Django 2.2 has been released. we won't drop python 2.7 support in trian so Django 1.11 support is mandatory. | 04:17 |
amotoki | django 1.11 won't reach EOL as of train. when considering our development bandwidth, we just defer it to U. | 04:17 |
amotoki | experimental support of Django 2.2 in train also makes sense to me (if we can move it forward successfully) | 04:18 |
amotoki | perhaps all my bandwidth on horizon will be used to ini-based-configuration (though I am not sure I can complete it) | 04:19 |
*** pcaruana has joined #openstack-horizon | 04:37 | |
*** duochao has joined #openstack-horizon | 04:50 | |
*** tkajinam has quit IRC | 05:01 | |
*** cshen has joined #openstack-horizon | 05:47 | |
*** slashd has quit IRC | 05:49 | |
*** slashd has joined #openstack-horizon | 05:50 | |
*** tkajinam has joined #openstack-horizon | 05:55 | |
*** rcernin has quit IRC | 06:02 | |
*** duochao has quit IRC | 06:13 | |
*** duochao has joined #openstack-horizon | 06:14 | |
*** stuartgr has quit IRC | 06:23 | |
*** stuartgr has joined #openstack-horizon | 06:24 | |
*** hoonetorg has quit IRC | 06:39 | |
*** mlycka has joined #openstack-horizon | 06:50 | |
*** hoonetorg has joined #openstack-horizon | 06:56 | |
*** btully has joined #openstack-horizon | 07:01 | |
*** btully has quit IRC | 07:05 | |
mlycka | ping | 07:13 |
*** zbr has quit IRC | 07:15 | |
*** zbr has joined #openstack-horizon | 07:16 | |
*** tosky has joined #openstack-horizon | 07:24 | |
*** duochao has quit IRC | 07:27 | |
openstackgerrit | mashuting proposed openstack/horizon master: Fix the filter value of 'state' in the response of list_availability_zones https://review.opendev.org/671665 | 07:29 |
*** cshen has quit IRC | 08:33 | |
*** mkowalski_ has joined #openstack-horizon | 08:41 | |
*** mkowalski has quit IRC | 08:44 | |
*** mkowalski_ has quit IRC | 08:49 | |
*** mkowalski_ has joined #openstack-horizon | 08:49 | |
*** btully has joined #openstack-horizon | 08:50 | |
*** cshen has joined #openstack-horizon | 08:50 | |
*** btully has quit IRC | 08:54 | |
*** cshen has quit IRC | 08:55 | |
*** tkajinam has quit IRC | 09:05 | |
*** cshen has joined #openstack-horizon | 09:11 | |
*** cshen has quit IRC | 09:16 | |
*** mkowalski_ has quit IRC | 09:17 | |
*** mkowalski has joined #openstack-horizon | 09:18 | |
*** mkowalski_ has joined #openstack-horizon | 09:19 | |
*** mkowalski has quit IRC | 09:22 | |
*** cshen has joined #openstack-horizon | 09:38 | |
*** e0ne has joined #openstack-horizon | 09:48 | |
*** ChanServ sets mode: +o e0ne | 09:48 | |
*** mkowalski_ has quit IRC | 09:53 | |
*** e0ne has quit IRC | 10:06 | |
*** priteau has joined #openstack-horizon | 10:32 | |
*** priteau has quit IRC | 10:35 | |
*** priteau has joined #openstack-horizon | 10:37 | |
*** btully has joined #openstack-horizon | 10:38 | |
*** btully has quit IRC | 10:43 | |
*** priteau has quit IRC | 10:47 | |
*** mkowalski has joined #openstack-horizon | 11:14 | |
*** mkowalski has quit IRC | 11:31 | |
*** tesseract has joined #openstack-horizon | 11:33 | |
*** mkowalski has joined #openstack-horizon | 11:40 | |
*** cshen has quit IRC | 11:48 | |
*** cshen has joined #openstack-horizon | 11:49 | |
*** spatel has joined #openstack-horizon | 11:52 | |
*** spatel has quit IRC | 12:08 | |
amotoki | mlycka: are you pinging someone? :) | 12:34 |
mlycka | amotoki: Hey. Yeah, checking if anyone is receiving. | 12:34 |
amotoki | I ignored it as I thought I am not pinged :) | 12:35 |
mlycka | amotoki: Would you mind going over a couple of +2ed commits for me and maybe looking into my reply in https://review.opendev.org/#/c/670513/? | 12:35 |
mlycka | amotoki: Alright, I'll ping you directly next time | 12:36 |
*** spatel has joined #openstack-horizon | 12:36 | |
amotoki | mlycka: thanks for your reply. Regarding the last thing on pluggable quota tab, I just concerned it forces plugins to implement two quota support. | 12:40 |
amotoki | more tricky situation is some plugins assume Django one and some others assume Angular one... | 12:40 |
amotoki | I am not sure what is the right solution on this. | 12:40 |
amotoki | I am the person who added the current pluggable tab mechanism but I am not sticking to it. Any approach is okay. My comment is just a reminder that we need to take into account horizon plugins in "quota management". | 12:41 |
*** spatel has quit IRC | 12:42 | |
mlycka | amotoki: Yeah, understood. Do we plan on deprecating pure django panels once we start using angular implementations as default? | 12:52 |
*** mkowalski has quit IRC | 13:12 | |
*** mkowalski has joined #openstack-horizon | 13:12 | |
zigo | Hi there! | 13:13 |
zigo | After applying my 5 Django 2.2. patches from yesterday, I still get one problem not fixed-up: http://paste.openstack.org/show/754579/ | 13:13 |
zigo | Does any of you got an idea where is that callback function that has one too much argument? | 13:14 |
zigo | amotoki: mlycka: ^ | 13:14 |
-amotoki- has no time to investigate them in detail till the week of last week of Jul | 13:44 | |
-amotoki- even at best | 13:44 | |
*** TheJulia is now known as needssleep | 13:48 | |
*** cshen has quit IRC | 13:56 | |
*** e0ne has joined #openstack-horizon | 14:12 | |
*** ChanServ sets mode: +o e0ne | 14:12 | |
*** spatel has joined #openstack-horizon | 14:15 | |
*** btully has joined #openstack-horizon | 14:16 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Allow to select multiattach volume that has been attached https://review.opendev.org/661526 | 14:18 |
*** btully has quit IRC | 14:21 | |
zigo | amotoki: Who can I ask then? | 14:21 |
amotoki | zigo: do you need some help right now? e0ne is on vacation these weeks. I am busy on other stuffs including presentations next week. | 14:23 |
amotoki | horizon is now a very small community, so it is not surprising that personal schedules can affect progresses on some effort.... unfortunately. | 14:26 |
amotoki | I have no good idea on improving a small community... | 14:27 |
zigo | amotoki: No worries, I'll ask Chris Lamb, the maintainer of Django in Debian, hopefully he'll be able to help, it doesn't seem that hard to fix, it's just a wrong callback signature, apparently, | 14:34 |
zigo | This makes it so I can't login to Horizon... :) | 14:34 |
*** tosky_ has joined #openstack-horizon | 14:59 | |
*** mlycka has quit IRC | 15:02 | |
*** tosky has quit IRC | 15:02 | |
*** tosky_ is now known as tosky | 15:10 | |
*** e0ne has quit IRC | 15:29 | |
*** zbr is now known as zbr|out | 15:30 | |
*** pcaruana has quit IRC | 15:49 | |
*** gyee has joined #openstack-horizon | 15:58 | |
*** btully has joined #openstack-horizon | 16:05 | |
*** tosky has quit IRC | 16:08 | |
*** btully has quit IRC | 16:10 | |
*** mkowalski has quit IRC | 16:28 | |
*** rdopiera has quit IRC | 16:31 | |
*** tesseract has quit IRC | 17:24 | |
*** whoami-rajat has quit IRC | 17:43 | |
*** tosky has joined #openstack-horizon | 17:49 | |
*** btully has joined #openstack-horizon | 17:54 | |
*** btully has quit IRC | 17:59 | |
*** mkowalski has joined #openstack-horizon | 19:33 | |
*** jtomasek has quit IRC | 19:45 | |
*** betherly has joined #openstack-horizon | 20:00 | |
*** mkowalski_ has joined #openstack-horizon | 20:01 | |
*** mkowalski has quit IRC | 20:04 | |
*** betherly has quit IRC | 20:05 | |
*** e0ne has joined #openstack-horizon | 20:51 | |
*** ChanServ sets mode: +o e0ne | 20:51 | |
openstackgerrit | Corey Bryant proposed openstack/horizon master: Switch from django string_concat to format_lazy https://review.opendev.org/671045 | 20:51 |
*** mkowalski has joined #openstack-horizon | 20:55 | |
*** e0ne has quit IRC | 20:57 | |
*** mkowalski_ has quit IRC | 20:57 | |
*** mkowalski has quit IRC | 20:59 | |
*** betherly has joined #openstack-horizon | 21:00 | |
*** betherly has quit IRC | 21:05 | |
*** betherly has joined #openstack-horizon | 21:31 | |
*** btully has joined #openstack-horizon | 21:32 | |
*** betherly has quit IRC | 21:35 | |
*** btully has quit IRC | 21:36 | |
*** tosky has quit IRC | 21:43 | |
*** spatel has quit IRC | 22:04 | |
*** needssleep is now known as TheJulia | 22:11 | |
*** betherly has joined #openstack-horizon | 22:22 | |
*** betherly has quit IRC | 22:27 | |
*** gyee has quit IRC | 22:34 | |
*** betherly has joined #openstack-horizon | 22:53 | |
*** gyee has joined #openstack-horizon | 22:57 | |
*** betherly has quit IRC | 22:58 | |
*** betherly has joined #openstack-horizon | 23:14 | |
*** betherly has quit IRC | 23:19 | |
*** takamatsu has quit IRC | 23:31 | |
*** betherly has joined #openstack-horizon | 23:35 | |
*** betherly has quit IRC | 23:39 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!