*** dave-mccowan has quit IRC | 00:01 | |
*** btully has joined #openstack-horizon | 00:04 | |
*** btully has quit IRC | 00:08 | |
*** tosky has quit IRC | 00:18 | |
*** vishalmanchanda has joined #openstack-horizon | 00:43 | |
*** gyee has quit IRC | 01:05 | |
*** spatel has joined #openstack-horizon | 01:28 | |
*** spatel has quit IRC | 01:32 | |
*** spatel has joined #openstack-horizon | 03:02 | |
*** spatel has quit IRC | 03:13 | |
*** btully has joined #openstack-horizon | 05:31 | |
*** btully has quit IRC | 05:35 | |
*** rpittau|afk is now known as rpittau | 07:24 | |
*** e0ne has joined #openstack-horizon | 07:51 | |
*** ChanServ sets mode: +o e0ne | 07:51 | |
*** e0ne has quit IRC | 07:53 | |
*** tesseract has joined #openstack-horizon | 08:12 | |
*** rcernin has quit IRC | 08:27 | |
*** tkajinam has quit IRC | 08:31 | |
*** tosky has joined #openstack-horizon | 08:46 | |
*** e0ne has joined #openstack-horizon | 08:58 | |
*** ChanServ sets mode: +o e0ne | 08:58 | |
amotoki | is anyone looking into a solution for py36/py37 failure due to pyScSS with setuptools 46.0.0? | 09:22 |
---|---|---|
e0ne | amotoki: master and stable/train should be fixed now | 09:23 |
amotoki | I looked at the meeting log this week and we see several options | 09:23 |
e0ne | amotoki: https://review.opendev.org/#/c/712777/ | 09:23 |
amotoki | e0ne: how does it solve tox failure? | 09:24 |
e0ne | there is a patch proposed to pyScSS but it's not merged yet | 09:24 |
amotoki | yeah, I see it (proposed to pyScSS) | 09:24 |
e0ne | amotoki: it uses older setuptools and pyScSS should work with it | 09:24 |
amotoki | e0ne: I think it fixes a problem in DevStack but doesn't tox install the latest setuptools into virtualenv? | 09:25 |
e0ne | let me check it | 09:25 |
e0ne | amotoki: I'm able to run unit tests with a new virtualenv on stable/train now | 09:27 |
amotoki | e0ne: which python version is used? | 09:29 |
e0ne | 3.7 | 09:30 |
amotoki | e0ne: what should I do to run tests successfully? In my understanding global-requirements change does not affect horizon UT directly. | 09:32 |
amotoki | perhaps I am missing something | 09:32 |
*** kevko has joined #openstack-horizon | 09:39 | |
kevko | amotoki: Hi Akihiro, could u check and add +1 if you are OK ? Andreas is now OK with review finally :) https://review.opendev.org/#/c/704133/ | 09:39 |
amotoki | kevko: ack. I am going to offline. will check it later. | 09:44 |
e0ne | amotoki: hm.. you're right. we need to update upper-constraints too | 09:49 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon stable/train: DNR. Test CI https://review.opendev.org/712902 | 10:29 |
kevko | why zull installing setuptools 46.0.0 even if it is not allowed in global requirements ? | 10:34 |
kevko | because of that my review is failing on installing pyScss | 10:35 |
e0ne | there is not setupcools in upper-constraints so unit tests are failing :( | 10:39 |
e0ne | amotoki: looks like pyScss is unmaintained now:(. | 10:42 |
kevko | e0ne: it is in global-requirements -> https://github.com/openstack/requirements/blob/master/global-requirements.txt -> !=46.0.0;python_version>='3.5' # PSF/ZPL | 10:43 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: DNR. Test CI https://review.opendev.org/712905 | 10:43 |
e0ne | kevko: global requirements is not used for unit tests | 10:44 |
kevko | e0ne: ah, ok , how to deal with it ? update upper-constraints to pin setuptools to lower version ? | 10:44 |
kevko | e0ne: i think it will be problem for more PyPi packages .. they removed Feature .. | 10:45 |
amotoki | kevko: we are exploring a way to fix the failure. | 10:45 |
kevko | amotoki: ah, ok, can I help somehow guys ? | 10:46 |
amotoki | kevko: "Feature" in setuptools have been deprecatd and was dropped in setuptools v46. If a PyPI is maintained well, the package would be updated, but pyscss looks unmaintained..... | 10:47 |
amotoki | that's the situation. | 10:47 |
kevko | amotoki: yeah, it looks like | 10:48 |
openstackgerrit | Pierre Riteau proposed openstack/horizon master: Fix typo in comments https://review.opendev.org/712908 | 10:55 |
amotoki | kevko: re: "why zull installing setuptools 46.0.0 even if it is not allowed in global requirements ?", it is done by tox. Creating a venv happens before installing requirements.txt. | 10:58 |
amotoki | kevko: tox calls 'python -m pip' and no --setuptools VERSION option is passed and the default VERSION is "latest", so setuptools v46 will be installed into venv. | 10:59 |
kevko | amotoki: understand | 11:05 |
*** mvkr has quit IRC | 11:08 | |
*** mvkr has joined #openstack-horizon | 11:10 | |
e0ne | looks like all python+scss stuff are 2+ years old :( | 11:18 |
e0ne | amotoki: I'm thinking about forking pyscss | 11:20 |
amotoki | e0ne: forking it would be easier (except that we need a new name). do you mean forking it under the horizon governance or as a personal project? | 11:21 |
e0ne | amotoki: pyScss2 is a good candidate | 11:22 |
e0ne | amotoki: I can do it as a personal project for now to make everything faster | 11:22 |
amotoki | "2" but no evolution :) | 11:22 |
amotoki | e0ne: sounds reasonable | 11:24 |
e0ne | IMO, it will be the fastest solution | 11:26 |
amotoki | yeah. | 11:26 |
amotoki | I looked thru libsass-python and django-sass-processor this afternoon. they looks a common way to use SCSS in Django recently and they are maintained in these 12 months, but the migration take time. | 11:26 |
e0ne | we can move it under the openstack umbrealla if needed | 11:26 |
*** rpittau is now known as rpittau|bbl | 11:28 | |
amotoki | hmm.... local devstack run fails due to pyscss... what's different from our CI???? | 11:28 |
e0ne | amotoki: let's try this one https://github.com/e0ne/pyScss | 11:36 |
amotoki | e0ne: thanks. I am on a way to home, so my testing might not be so prompt. | 11:39 |
e0ne | I'm testing it now | 11:40 |
e0ne | amotoki: we have to fork https://github.com/e0ne/pyScss too :( | 11:43 |
*** hoonetorg has quit IRC | 11:47 | |
*** hoonetorg has joined #openstack-horizon | 12:00 | |
*** vishalmanchanda has quit IRC | 13:03 | |
*** rpittau|bbl is now known as rpittau | 13:04 | |
*** rcernin has joined #openstack-horizon | 13:41 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Test forks on CI https://review.opendev.org/712957 | 14:06 |
*** btully has joined #openstack-horizon | 14:34 | |
*** btully has quit IRC | 14:39 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Test forks on CI https://review.opendev.org/712957 | 14:55 |
*** pbing19 has joined #openstack-horizon | 15:01 | |
*** opetrenko has joined #openstack-horizon | 15:02 | |
*** opetrenko has quit IRC | 15:03 | |
*** opetrenko has joined #openstack-horizon | 15:03 | |
opetrenko | Hi, I have a question. I'm runnings horizon integration tests, and part of them are failing on trying ti perform a clenup on created resources. Selenium successfully creates resources ( e.i. flavour) but when he hits delete, he stops at delete confirmation. Can anyone explain, how this is handled on devstack, and where I can find a piece of code that performs confirmation. Thanks | 15:06 |
e0ne | opetrenko: may debugger be with you;) | 15:17 |
*** gyee has joined #openstack-horizon | 15:23 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Use pyScss2 and django-pyscss2 https://review.opendev.org/712978 | 15:36 |
e0ne | amotoki: FYI ^^ | 15:36 |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Use pyScss2 and django-pyscss2 https://review.opendev.org/712978 | 16:07 |
*** openstackgerrit has quit IRC | 16:31 | |
*** openstackgerrit has joined #openstack-horizon | 16:33 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Use pyScss2 and django-pyscss2 https://review.opendev.org/712978 | 16:33 |
*** rpittau is now known as rpittau|afk | 16:58 | |
*** opetrenko has quit IRC | 17:00 | |
*** tesseract has quit IRC | 17:07 | |
*** e0ne has quit IRC | 17:31 | |
*** e0ne has joined #openstack-horizon | 19:01 | |
*** ChanServ sets mode: +o e0ne | 19:01 | |
*** btully has joined #openstack-horizon | 20:01 | |
*** btully has quit IRC | 20:05 | |
*** pbing19 has quit IRC | 20:41 | |
openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Test forks on CI https://review.opendev.org/712957 | 21:28 |
*** kevko has quit IRC | 21:29 | |
*** rdopiera has quit IRC | 21:34 | |
*** e0ne has quit IRC | 21:46 | |
*** rcernin has quit IRC | 22:58 | |
*** rcernin has joined #openstack-horizon | 22:59 | |
*** gyee has quit IRC | 23:22 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!