*** btully has joined #openstack-horizon | 01:08 | |
*** btully has quit IRC | 01:13 | |
*** btully has joined #openstack-horizon | 02:58 | |
*** btully has quit IRC | 03:02 | |
*** vishalmanchanda has joined #openstack-horizon | 03:24 | |
*** dave-mccowan has quit IRC | 04:06 | |
openstackgerrit | Merged openstack/tempest-horizon master: Update hacking https://review.opendev.org/715606 | 04:46 |
---|---|---|
openstackgerrit | Merged openstack/tempest-horizon master: Update the rst file information https://review.opendev.org/623946 | 04:46 |
*** e0ne has joined #openstack-horizon | 05:38 | |
*** ChanServ sets mode: +o e0ne | 05:38 | |
*** e0ne has quit IRC | 05:43 | |
*** e0ne has joined #openstack-horizon | 06:20 | |
*** ChanServ sets mode: +o e0ne | 06:20 | |
*** e0ne has quit IRC | 06:24 | |
*** btully has joined #openstack-horizon | 06:35 | |
*** btully has quit IRC | 06:39 | |
*** ircuser-1 has quit IRC | 06:40 | |
*** hrw has joined #openstack-horizon | 06:50 | |
*** e0ne has joined #openstack-horizon | 07:01 | |
*** ChanServ sets mode: +o e0ne | 07:01 | |
hrw | e0ne: morning | 07:03 |
*** e0ne has quit IRC | 07:05 | |
*** tosky has joined #openstack-horizon | 07:25 | |
*** rpittau|afk is now known as rpittau | 07:34 | |
*** e0ne has joined #openstack-horizon | 07:56 | |
*** ChanServ sets mode: +o e0ne | 07:56 | |
*** rdopiera has joined #openstack-horizon | 07:59 | |
*** e0ne has quit IRC | 08:01 | |
*** btully has joined #openstack-horizon | 08:24 | |
*** btully has quit IRC | 08:28 | |
*** tkajinam has quit IRC | 08:30 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add cap for hacking https://review.opendev.org/715286 | 08:31 |
*** kevko_ has joined #openstack-horizon | 08:59 | |
*** kevko has joined #openstack-horizon | 08:59 | |
*** rcernin has quit IRC | 09:00 | |
*** tkajinam has joined #openstack-horizon | 09:41 | |
vishalmanchanda | amotoki: hi. around? | 10:05 |
vishalmanchanda | amotoki: I just wanted to ask if you have not started to working on PTL Conrib doc. | 10:10 |
vishalmanchanda | I can push a initial patch.. | 10:10 |
vishalmanchanda | amotoki: e0ne^^ | 10:11 |
*** hrw has left #openstack-horizon | 10:13 | |
*** yaawang has joined #openstack-horizon | 10:53 | |
*** rpittau is now known as rpittau|bbl | 10:56 | |
*** e0ne has joined #openstack-horizon | 11:00 | |
*** ChanServ sets mode: +o e0ne | 11:00 | |
amotoki | e0ne: rdopiera: does xstatic-mdi==1.4.57.0 work in horizon (like stable/train)? | 11:01 |
amotoki | e0ne: rdopiera: I tried xstatic-mdi 1.4.57.0 in stable/train but I see strings like "xF131" instead of icons. | 11:02 |
amotoki | e0ne: rdopiera: I wonder if it works well. Or horizon might work xstatic-mdi 1.6.50.2 only while the requirements says xstatic-mdi>=1.4.57.0. | 11:03 |
amotoki | e0ne: rdopiera: what your thought on this? | 11:04 |
*** e0ne has quit IRC | 11:05 | |
*** gshippey has joined #openstack-horizon | 11:05 | |
amotoki | rdopiera might have more experience with xstatic-mdi==1.4.57.0 than I. | 11:05 |
*** e0ne has joined #openstack-horizon | 11:05 | |
*** ChanServ sets mode: +o e0ne | 11:05 | |
amotoki | I succeeded to support pyScss 1.3.7 with both xstatic-mdi 1.4.57.0 and 1.6.50.2, but I I hit the above problem. | 11:06 |
amotoki | I started to think we need to bump the min version of xstatic-mdi to 1.6.50.2. | 11:06 |
amotoki | vishalmanchanda: I haven't started it yet. I plan to to start it around RC1 as it does not affect the code. | 11:08 |
amotoki | vishalmanchanda: if you just import the template, I can do that. | 11:08 |
amotoki | vishalmanchanda: if more than that, feel free to start it. | 11:08 |
gshippey | Hi all! First time in this channel 👋 I was trying to backport this bug fix into stable/train https://review.opendev.org/#/c/714920/ but the CI jobs are currently failing due to the PyScss issues. Is stable/train going to blocked until a good fix is figured out? | 11:09 |
vishalmanchanda | amotoki: ohk. then i will push a initial the patch using that template. | 11:10 |
amotoki | vishalmanchanda: hopefully your change itself can be completed by you (as the author). | 11:11 |
vishalmanchanda | amotoki: sure. | 11:12 |
e0ne | gshippey: hi. unfortunately, stable gates are broken now. we're working on a fix | 11:15 |
*** dklyle has quit IRC | 11:15 | |
amotoki | gshippey: sorry for the delay. yeah, it is blocked by the pyscss issue. almost all pieces have landed in the master branch and I am exploring the last piece related to xstatic-mdi versions. | 11:16 |
amotoki | gshippey: I hope the stable branches (train and stein) will be fixed in a couple of days. | 11:16 |
gshippey | great I'll keep an eye on things over the next couple of days then! | 11:18 |
rdopiera | amotoki: it seemed to be working, it only broke with that recent patch | 11:42 |
amotoki | rdopiera: okay. I will post my workaround and hopefully you can test it. | 11:44 |
rdopiera | amotoki: we just upgraded to latest version | 11:48 |
amotoki | rdopiera: so, is it okay to bump the min version of xstatic-mdi to 1.6.50 in stable branches too? | 11:49 |
rdopiera | amotoki: it's fine with us, not sure about other distros | 11:49 |
openstackgerrit | Jacek Tomasiak proposed openstack/horizon master: Authenticate before Authorization https://review.opendev.org/712794 | 11:50 |
amotoki | rdopiera at least I failed to run xstatic-mdi 1.4.57 so I have no word on which way we should go...... | 11:54 |
rdopiera | ultimately we want to upgrade anyways | 11:55 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: WIP: Workaround for xstatic-mdi 1.4.57.0 support with latest pyScss https://review.opendev.org/715924 | 11:56 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Bump xstatic-mdi lower-bound https://review.opendev.org/715925 | 12:00 |
amotoki | both are options we have. | 12:00 |
amotoki | ^^ | 12:00 |
rdopiera | the first one is gentler on the maintainers | 12:00 |
amotoki | but I failed to test it in real envs..... compress succeeds though..... | 12:01 |
amotoki | rdopiera: e0ne: waiting for your input in the reviews from stable-core perspective | 12:02 |
rdopiera | I asked out deployment people, but they are offline atm | 12:03 |
rdopiera | our* | 12:03 |
*** e0ne has quit IRC | 12:04 | |
*** e0ne has joined #openstack-horizon | 12:04 | |
*** ChanServ sets mode: +o e0ne | 12:04 | |
e0ne | amotoki: I'm not a fan of bumping package versions in stable branches, but we have to do it for this particular case | 12:15 |
amotoki | e0ne: rdopiera: after further investigation, xstatic-mdi 1.4.57 works with pyScss 1.3.4, but it has more incompatible things with pyScss 1.3.7. | 12:34 |
amotoki | e0ne: rdopiera: fa icon replacements with MDI works good, but table checkboxes are broken. | 12:35 |
amotoki | e0ne: rdopiera: that's all I checked. | 12:35 |
*** rpittau|bbl is now known as rpittau | 12:46 | |
*** dave-mccowan has joined #openstack-horizon | 12:59 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Bump hacking to 3.0.0 https://review.opendev.org/715286 | 13:01 |
*** irclogbot_2 has quit IRC | 13:15 | |
*** f0o has quit IRC | 13:15 | |
*** tinwood has quit IRC | 13:15 | |
*** tinwood has joined #openstack-horizon | 13:17 | |
*** f0o has joined #openstack-horizon | 13:18 | |
*** irclogbot_2 has joined #openstack-horizon | 13:18 | |
amotoki | e0ne: rdopiera: after further investigation, the issue I see hit the master branch with xstatic-mdi 1.6.50 too https://pasteboard.co/J1uIQVW.png | 13:49 |
amotoki | e0ne: rdopiera: so I think we can move https://review.opendev.org/715924 forward and backport it to stable/branches too along with changes we have so far. | 13:50 |
amotoki | e0ne: rdopiera: in parallel, we can fix material design related issue I found | 13:50 |
amotoki | e0ne: rdopiera: thought? | 13:50 |
e0ne | amotoki, rdopiera: lgtm to unblock gates | 13:51 |
*** tmazur has joined #openstack-horizon | 14:11 | |
*** e0ne has quit IRC | 14:15 | |
*** tmazur has quit IRC | 14:17 | |
*** dklyle has joined #openstack-horizon | 14:40 | |
*** ChanServ sets mode: +o dklyle | 14:40 | |
*** dklyle sets mode: -o dklyle | 14:43 | |
amotoki | I would like to dump the plan on further actions related to pyscss in my mind. | 14:53 |
amotoki | (1) master branch | 14:53 |
amotoki | (1a) bump the min ver of xstatic-mdi (to 1.6.50.2) to make the maintenance simpler | 14:53 |
amotoki | (1b) make the material design theme work with pyScss 1.3.6 or later (I haven't filed a bug) | 14:53 |
amotoki | (1c) add a release note on the material theme issue as a known issue | 14:53 |
amotoki | (2) stable branches | 14:53 |
amotoki | (2a) squash and backport setuptools related changes as a single change (along with a release note on the material theme) | 14:53 |
amotoki | (2b) a workaround for the material design from e0ne can be a separate patch (as it is not directly related to the gate failure). | 14:53 |
amotoki | It can be together with my workaround for xstatic-mdi 1.4.57) | 14:53 |
amotoki | (2c) backport more fixes on the material design them if fixed in the master branch (future) | 14:53 |
amotoki | does it sound reasonable? | 14:53 |
amotoki | (1c) might be optional (as we haven't released ussuri yet) | 14:55 |
*** yoctozepto has quit IRC | 15:07 | |
*** yoctozepto has joined #openstack-horizon | 15:08 | |
*** obre has quit IRC | 15:09 | |
*** cmurphy has quit IRC | 15:13 | |
*** cmurphy has joined #openstack-horizon | 15:20 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Bump hacking to 3.0.0 https://review.opendev.org/715286 | 15:36 |
*** obre has joined #openstack-horizon | 15:39 | |
openstackgerrit | Andreas Jaeger proposed openstack/tempest-horizon master: Update to hacking 3.0 https://review.opendev.org/715989 | 15:44 |
*** andrein has quit IRC | 15:45 | |
*** rpittau has quit IRC | 15:45 | |
*** Anticimex has quit IRC | 15:45 | |
*** andrein has joined #openstack-horizon | 15:45 | |
*** rpittau has joined #openstack-horizon | 15:45 | |
*** Anticimex has joined #openstack-horizon | 15:45 | |
*** mkowalski[b] has quit IRC | 15:49 | |
*** e0ne has joined #openstack-horizon | 16:12 | |
*** ChanServ sets mode: +o e0ne | 16:12 | |
*** rpittau is now known as rpittau|afk | 16:12 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/train: Set tox_constraints_file for npm jobs and integration tests https://review.opendev.org/716014 | 16:27 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/train: Update pyScss to 1.3.7 https://review.opendev.org/716015 | 16:27 |
*** kevko_ has quit IRC | 16:37 | |
*** kevko has quit IRC | 16:37 | |
*** kevko has joined #openstack-horizon | 16:38 | |
*** Anticimex has quit IRC | 16:43 | |
*** Anticimex has joined #openstack-horizon | 16:44 | |
*** mkowalski[b] has joined #openstack-horizon | 16:47 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/stein: Update pyScss to 1.3.7 https://review.opendev.org/716028 | 17:22 |
*** btully has joined #openstack-horizon | 17:28 | |
*** btully has quit IRC | 17:32 | |
*** e0ne has quit IRC | 17:58 | |
*** vishalmanchanda has quit IRC | 18:18 | |
*** pbing19 has joined #openstack-horizon | 18:46 | |
*** mugsie has quit IRC | 19:51 | |
*** mugsie has joined #openstack-horizon | 19:54 | |
*** gshippey has quit IRC | 20:52 | |
*** pbing19 has quit IRC | 21:17 | |
*** rcernin has joined #openstack-horizon | 21:56 | |
*** tosky has quit IRC | 22:20 | |
*** ircuser-1 has joined #openstack-horizon | 23:28 | |
openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/train: Update pyScss to 1.3.7 https://review.opendev.org/716015 | 23:32 |
openstackgerrit | Akihiro Motoki proposed openstack/horizon stable/stein: Update pyScss to 1.3.7 https://review.opendev.org/716028 | 23:33 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!