| *** gyee has quit IRC | 00:20 | |
| *** yaawang has quit IRC | 01:57 | |
| *** yaawang has joined #openstack-horizon | 01:58 | |
| *** dave-mccowan has quit IRC | 02:51 | |
| *** vishalmanchanda has joined #openstack-horizon | 05:55 | |
| *** dayou has quit IRC | 06:20 | |
| *** e0ne has joined #openstack-horizon | 06:27 | |
| *** ChanServ sets mode: +o e0ne | 06:27 | |
| *** dayou has joined #openstack-horizon | 06:28 | |
| *** rcernin has quit IRC | 07:32 | |
| *** tosky has joined #openstack-horizon | 07:39 | |
| *** tosky has quit IRC | 08:04 | |
| *** tosky_ has joined #openstack-horizon | 08:04 | |
| *** rdopiera has joined #openstack-horizon | 08:06 | |
| *** yaawang has quit IRC | 08:13 | |
| *** yaawang has joined #openstack-horizon | 08:13 | |
| *** tosky_ is now known as tosky | 08:19 | |
| *** rcernin has joined #openstack-horizon | 09:10 | |
| *** rcernin has quit IRC | 09:35 | |
| *** yaawang has quit IRC | 10:11 | |
| *** yaawang has joined #openstack-horizon | 10:13 | |
| *** yaawang has quit IRC | 10:20 | |
| *** yaawang has joined #openstack-horizon | 10:22 | |
| *** priteau has joined #openstack-horizon | 10:34 | |
| *** tkajinam has quit IRC | 10:59 | |
| *** kevko has joined #openstack-horizon | 11:23 | |
| *** kevko_ has joined #openstack-horizon | 11:25 | |
| *** kevko has quit IRC | 11:25 | |
| *** rcernin has joined #openstack-horizon | 11:49 | |
| *** dave-mccowan has joined #openstack-horizon | 12:10 | |
| *** e0ne has quit IRC | 12:33 | |
| *** e0ne has joined #openstack-horizon | 12:37 | |
| *** ChanServ sets mode: +o e0ne | 12:37 | |
| *** rm_work has quit IRC | 12:38 | |
| *** e0ne has quit IRC | 12:39 | |
| *** mkowalski has quit IRC | 12:40 | |
| *** rm_work has joined #openstack-horizon | 12:42 | |
| *** mkowalski has joined #openstack-horizon | 12:46 | |
| *** rcernin has quit IRC | 13:32 | |
| *** e0ne has joined #openstack-horizon | 14:00 | |
| *** ChanServ sets mode: +o e0ne | 14:00 | |
| *** dave-mccowan has quit IRC | 14:07 | |
| *** dave-mccowan has joined #openstack-horizon | 14:20 | |
| *** e0ne has quit IRC | 14:22 | |
| *** e0ne has joined #openstack-horizon | 14:23 | |
| *** ChanServ sets mode: +o e0ne | 14:23 | |
| *** dave-mccowan has quit IRC | 14:26 | |
| e0ne | amotoki, vishalmanchanda, rdopiera: FYI, I'll be late at meeting for 10-15 minutes. feel free to start it without me | 14:56 |
|---|---|---|
| vishalmanchanda | e0ne: ack. | 14:56 |
| *** KeithMnemonic has joined #openstack-horizon | 14:59 | |
| *** rcernin has joined #openstack-horizon | 15:25 | |
| *** rcernin has quit IRC | 15:29 | |
| *** gyee has joined #openstack-horizon | 15:48 | |
| rdopiera | the thing is, we already have a lot of magic in those error handling routines | 16:00 |
| rdopiera | and a lot of responsibility in a signle function | 16:01 |
| amotoki | yeah, it is true... | 16:03 |
| amotoki | but I think adding redundant arg to almost all callers and the size of the magic in that function are different things. | 16:04 |
| amotoki | honestly I don't want to see similar patches in horizon plugins just to add details=str(ex).... | 16:05 |
| vishalmanchanda | amotoki: Do you have some better option? | 16:06 |
| rdopiera | amotoki: how about we make it take the details from the exception if they are not specified, but still allow to specify it explicitly? | 16:07 |
| rdopiera | amotoki: and if it's set to "", then suppress details entirely? | 16:07 |
| amotoki | what in my mind is to accept True/False/message string in 'details' and if details is True a detail message can be retrieved from the exception. | 16:08 |
| amotoki | if details is False, a caller does not want to add details. | 16:08 |
| amotoki | very similar to rdopiera's idea | 16:09 |
| rdopiera | I would prefer None/""/"string" | 16:09 |
| amotoki | rdopiera's idea sounds better | 16:09 |
| rdopiera | if it's None (default), take it from exception, if it's "", suppress it, if it's other string, use that | 16:09 |
| amotoki | agree | 16:10 |
| vishalmanchanda | rdopiera: amotoki : ok I will check in code how to implement it. | 16:12 |
| rdopiera | vishalmanchanda: do tyou know how to get the current exception? | 16:12 |
| amotoki | vishalmanchanda: exceptions.handle() calls sys.exc_info() so I believe we already have the current exception in exc_value. | 16:13 |
| vishalmanchanda | rdopiera: From sys.exc_info() | 16:13 |
| vishalmanchanda | ok guys thanks for suggestion I will check tomorrow how to implement it. | 16:15 |
| *** e0ne has quit IRC | 16:15 | |
| amotoki | vishalmanchanda: thanks for working on it | 16:17 |
| vishalmanchanda | amotoki: np. | 16:17 |
| vishalmanchanda | Also this bp patch https://review.opendev.org/#/c/734161/ is ready for review. | 16:18 |
| vishalmanchanda | It would be nice if someone take a look. | 16:19 |
| *** e0ne has joined #openstack-horizon | 17:20 | |
| *** ChanServ sets mode: +o e0ne | 17:20 | |
| *** _erlon_ has joined #openstack-horizon | 18:02 | |
| *** e0ne has quit IRC | 18:15 | |
| *** rdopiera has quit IRC | 18:35 | |
| *** e0ne has joined #openstack-horizon | 19:17 | |
| *** ChanServ sets mode: +o e0ne | 19:17 | |
| *** e0ne has quit IRC | 19:47 | |
| *** kevko_ has quit IRC | 19:55 | |
| *** e0ne has joined #openstack-horizon | 20:04 | |
| *** ChanServ sets mode: +o e0ne | 20:04 | |
| *** e0ne has quit IRC | 20:12 | |
| *** kevko_ has joined #openstack-horizon | 20:21 | |
| *** priteau has quit IRC | 20:47 | |
| *** rdopiera has joined #openstack-horizon | 21:02 | |
| *** rdopiera has quit IRC | 21:07 | |
| *** vishalmanchanda has quit IRC | 22:01 | |
| *** kevko_ has quit IRC | 22:09 | |
| *** rcernin has joined #openstack-horizon | 22:51 | |
| *** rcernin has quit IRC | 22:58 | |
| *** rcernin has joined #openstack-horizon | 23:01 | |
| *** tosky has quit IRC | 23:03 | |
| *** rcernin has quit IRC | 23:04 | |
| *** rcernin has joined #openstack-horizon | 23:05 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!