| *** kevko_ has joined #openstack-horizon | 00:10 | |
| *** yaawang has quit IRC | 01:26 | |
| *** yaawang has joined #openstack-horizon | 01:28 | |
| *** kevko_ has quit IRC | 01:42 | |
| *** gyee has quit IRC | 01:44 | |
| *** yaawang has quit IRC | 01:53 | |
| *** yaawang has joined #openstack-horizon | 01:54 | |
| *** yaawang has quit IRC | 02:36 | |
| *** yaawang has joined #openstack-horizon | 02:37 | |
| *** yaawang has quit IRC | 03:25 | |
| *** rcernin has quit IRC | 03:29 | |
| *** yaawang has joined #openstack-horizon | 03:29 | |
| *** rcernin has joined #openstack-horizon | 03:40 | |
| *** rcernin has quit IRC | 03:58 | |
| *** rcernin has joined #openstack-horizon | 04:15 | |
| *** vishalmanchanda has joined #openstack-horizon | 04:40 | |
| *** dklyle has quit IRC | 06:59 | |
| *** tosky has joined #openstack-horizon | 07:19 | |
| *** e0ne has joined #openstack-horizon | 08:55 | |
| *** ChanServ sets mode: +o e0ne | 08:55 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor error messages. https://review.opendev.org/708069 | 09:30 |
|---|---|---|
| *** rdopiera has joined #openstack-horizon | 09:50 | |
| *** rcernin has quit IRC | 10:33 | |
| *** rcernin has joined #openstack-horizon | 10:50 | |
| *** rcernin has quit IRC | 10:50 | |
| *** kevko_ has joined #openstack-horizon | 11:00 | |
| *** kevko has joined #openstack-horizon | 11:01 | |
| *** kevko_ has quit IRC | 11:01 | |
| *** tkajinam has quit IRC | 11:36 | |
| *** dave-mccowan has joined #openstack-horizon | 12:57 | |
| vishalmanchanda | rdopiera: e0ne : amotoki: Hi need a help, around? | 14:57 |
| e0ne | yep | 14:58 |
| rdopiera | what do you mean? | 14:58 |
| vishalmanchanda | So I am testing my refactor-error-messages patch https://review.opendev.org/#/c/708069/ | 14:58 |
| *** dklyle has joined #openstack-horizon | 14:59 | |
| *** ChanServ sets mode: +o dklyle | 14:59 | |
| vishalmanchanda | I have a scenario if expection.handle didn't have redirect parameter and this template is used https://review.opendev.org/#/c/708069/19/horizon/templates/horizon/client_side/_alert_message.html and details is "". | 14:59 |
| *** dklyle sets mode: -o dklyle | 14:59 | |
| vishalmanchanda | then my patch adds 'Details' href in alert box but it is not collapse able. | 15:00 |
| vishalmanchanda | But i want that if this scenario occurs 'Details' href not shows in alert box. | 15:01 |
| e0ne | can you add 'if' cause into the template? | 15:01 |
| vishalmanchanda | Although I have handled the case when redirect argument is used in exception.handle and details is "" by adding a check here https://review.opendev.org/#/c/708069/19/horizon/templates/horizon/_messages.html@37 | 15:01 |
| *** kevko has quit IRC | 15:01 | |
| vishalmanchanda | e0ne: But when i tried same thing for _alert_message.html it's not worked out. | 15:01 |
| vishalmanchanda | I have tried {% if deatils != None %} | 15:04 |
| vishalmanchanda | I have tried a couple of condition in _alert_message.html but nothing worked out. | 15:07 |
| e0ne | what actually did you di? | 15:09 |
| e0ne | we've got two types of templates with different syntax | 15:09 |
| vishalmanchanda | http://paste.openstack.org/show/796334/ | 15:14 |
| vishalmanchanda | e0ne: yeah templates using these '[[ ]]' confuses me. | 15:16 |
| e0ne | you have to use angularjs 'if' there | 15:17 |
| vishalmanchanda | e0ne: ok. I will try. | 15:20 |
| vishalmanchanda | e0ne: you mean i have to add some condition in horizon.messages.js ? | 15:21 |
| vishalmanchanda | e0ne: ok gotcha thanks. | 15:31 |
| e0ne | np | 15:36 |
| *** irclogbot_0 has quit IRC | 15:56 | |
| *** irclogbot_1 has joined #openstack-horizon | 15:57 | |
| *** e0ne has quit IRC | 16:06 | |
| *** irclogbot_1 has quit IRC | 16:15 | |
| *** irclogbot_2 has joined #openstack-horizon | 16:16 | |
| openstackgerrit | Merged openstack/horizon master: Add use_required_attribute in workflow https://review.opendev.org/648622 | 16:20 |
| *** gyee has joined #openstack-horizon | 17:45 | |
| *** dave-mccowan has quit IRC | 18:46 | |
| *** vishalmanchanda has quit IRC | 18:50 | |
| *** spatel has joined #openstack-horizon | 18:57 | |
| *** CeeMac has quit IRC | 19:34 | |
| *** CeeMac has joined #openstack-horizon | 19:45 | |
| *** coreycb has joined #openstack-horizon | 20:24 | |
| *** spatel has quit IRC | 21:04 | |
| *** rdopiera has quit IRC | 21:23 | |
| *** e0ne has joined #openstack-horizon | 21:47 | |
| *** ChanServ sets mode: +o e0ne | 21:47 | |
| *** CeeMac has quit IRC | 22:04 | |
| *** tosky has quit IRC | 22:10 | |
| *** e0ne has quit IRC | 22:20 | |
| *** e0ne has joined #openstack-horizon | 22:25 | |
| *** ChanServ sets mode: +o e0ne | 22:25 | |
| *** e0ne has quit IRC | 22:48 | |
| *** _erlon_ has quit IRC | 22:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!