| *** spatel has joined #openstack-horizon | 00:36 | |
| *** gyee has quit IRC | 00:50 | |
| *** spatel has quit IRC | 01:24 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing pep8 with pylint greater version https://review.opendev.org/750854 | 01:58 |
|---|---|---|
| *** vishalmanchanda has joined #openstack-horizon | 01:58 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: [DNM] Testing pep8 https://review.opendev.org/750854 | 02:05 |
| *** chenhaw has quit IRC | 02:15 | |
| *** chenhaw has joined #openstack-horizon | 02:15 | |
| amotoki | vishalmanchanda: I already tested pep8 job https://review.opendev.org/750843 | 02:19 |
| amotoki | vishalmanchanda: pylint 2.6 fixes the problem. | 02:19 |
| vishalmanchanda | amotoki: oh nice. | 02:19 |
| vishalmanchanda | amotoki: I am also trying with 2.4.4 | 02:20 |
| amotoki | vishalmanchanda: is there any reason to try non-latest pylint version? | 02:20 |
| vishalmanchanda | amotoki: Could you purpose a patch for that? | 02:20 |
| amotoki | vishalmanchanda: I am working on it already. testing it in local | 02:20 |
| vishalmanchanda | amotoki: cool. | 02:21 |
| vishalmanchanda | amotoki: no specific reason I am just trying with pylint 2.4.4 version. | 02:22 |
| amotoki | perhaps we should test it in advance. neutron team tested focal migration with depends-on and detected this several weeks ago. | 02:32 |
| amotoki | so this is not an unexpected failure with focal switch of base jobs. | 02:33 |
| vishalmanchanda | yeah. | 02:35 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Bump pylint version to support python3.8 https://review.opendev.org/750862 | 02:41 |
| amotoki | woops. I forgot to update test-requirements :-( | 02:41 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Bump pylint version to support python3.8 https://review.opendev.org/750862 | 02:45 |
| *** rcernin has quit IRC | 02:50 | |
| amotoki | vishalmanchanda: btw, I don't understand your last comment. I expect each tab can be identified by an URL like ?tab=volume_details__snapshots_tab. I wonder why this does not work for your case. | 02:55 |
| amotoki | vishalmanchanda: I am talking about https://review.opendev.org/#/c/734161/9/openstack_dashboard/dashboards/project/volumes/tests.py | 02:55 |
| vishalmanchanda | amotoki: When I do the same thing for my patch https://review.opendev.org/#/c/734161/10/openstack_dashboard/dashboards/project/volumes/tests.py@1509 | 02:57 |
| vishalmanchanda | amotoki: I did't get the expected response in res = self.client.get(url) https://review.opendev.org/#/c/734161/10/openstack_dashboard/dashboards/project/volumes/tests.py@1510 | 02:58 |
| amotoki | vishalmanchanda: what is the string 'messages_tab_link' after resolved? is it '?tab=volume_details__messages_tab'? | 02:59 |
| *** rcernin has joined #openstack-horizon | 02:59 | |
| vishalmanchanda | amotoki: yeah | 03:00 |
| vishalmanchanda | but in response I got an error. | 03:00 |
| amotoki | vishalmanchanda: it depends on an error you hit. I've never got into trouble in similar cases. | 03:01 |
| amotoki | vishalmanchanda: does it work in real environments? | 03:02 |
| amotoki | vishalmanchanda: I mean '?tab=volume_details__messages_tab' | 03:02 |
| amotoki | if it works, something in UT has an issue. Otherwise, something in the impl has an issue. | 03:03 |
| vishalmanchanda | amotoki: hmm I don't think there is an issue in implementation. | 03:07 |
| amotoki | vishalmanchanda: does it work? | 03:08 |
| vishalmanchanda | amotoki: here is my test result http://paste.openstack.org/show/797684/ if you find anything | 03:08 |
| vishalmanchanda | please let me know. | 03:08 |
| amotoki | vishalmanchanda: it looks a simple problem | 03:09 |
| amotoki | vishalmanchanda: just because of a missing mock | 03:09 |
| amotoki | the logic should not reach L.194 of the paste | 03:10 |
| vishalmanchanda | amotoki: ohh I See. | 03:11 |
| amotoki | i think you can check how the micro-version logic is handled in our UT | 03:11 |
| vishalmanchanda | amotoki: ok thanks for pointing me to right direction. | 03:11 |
| vishalmanchanda | amotoki: thanks I have fixed my test but I will push U.T in a separate patch as I don't want to block my feature patch. | 03:36 |
| *** dave-mccowan has quit IRC | 04:12 | |
| *** jtomasek has joined #openstack-horizon | 05:17 | |
| *** jtomasek has quit IRC | 05:22 | |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Fix ironic-ui cross job https://review.opendev.org/750874 | 06:09 |
| openstackgerrit | Akihiro Motoki proposed openstack/horizon master: Fix ironic-ui cross job https://review.opendev.org/750874 | 06:10 |
| *** dklyle has quit IRC | 06:43 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 06:54 |
| *** jtomasek has joined #openstack-horizon | 07:00 | |
| *** priteau has joined #openstack-horizon | 07:16 | |
| *** tosky has joined #openstack-horizon | 07:32 | |
| *** e0ne has joined #openstack-horizon | 07:43 | |
| *** ChanServ sets mode: +o e0ne | 07:43 | |
| *** rdopiera has joined #openstack-horizon | 07:46 | |
| *** priteau has quit IRC | 07:47 | |
| *** priteau has joined #openstack-horizon | 07:53 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 07:58 |
| *** CeeMac has joined #openstack-horizon | 07:59 | |
| *** rcernin has quit IRC | 08:35 | |
| *** kevko has joined #openstack-horizon | 08:36 | |
| *** jtomasek has quit IRC | 08:45 | |
| e0ne | amotoki: hi. are you around? I would like to discuss https://review.opendev.org/#/c/721992/ | 08:46 |
| e0ne | vishalmanchanda: hi. are you going to update your patches https://review.opendev.org/#/c/749739/ and https://review.opendev.org/#/c/734161/ today before we'll reach FF? | 08:54 |
| vishalmanchanda | e0ne: yeah working on it. | 08:54 |
| e0ne | vishalmanchanda: ok | 08:55 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Refactor error messages. https://review.opendev.org/749739 | 09:03 |
| amotoki | e0ne: hi, I was in evening break | 09:04 |
| amotoki | e0ne: vishalmanchanda: I will have a drink with friends tonight so my response would be super slower. | 09:08 |
| amotoki | e0ne: vishalmanchanda: it might be better to ask feature patch reviews to rdopiera if you land them quickly. | 09:09 |
| amotoki | e0ne: per your pong, what's about https://review.opendev.org/#/c/721992/ ? | 09:10 |
| e0ne | amotoki: I tested it a bit more: it doesn't show extended attributes if values are 0, None or '' | 09:12 |
| amotoki | e0ne: yeah, that is expected as the template engine evaluates a value in such way. | 09:13 |
| e0ne | amotoki: IMO, it's a better rather than have these values rendered as empty because we can't check policies from the code | 09:13 |
| e0ne | amotoki: even if we check horizon policies, we can't check that in nove | 09:13 |
| amotoki | e0ne: I think they need to be checked one by one. | 09:14 |
| amotoki | e0ne: for example, the common value of launch_index is 0, so it means launch_index=0 is not shown. | 09:15 |
| amotoki | e0ne: per your comment in the review, it is mainly for the admin panel. Perhaps the ideal (or better) solution would be to prepare a separate template for the admin panel. | 09:15 |
| e0ne | amotoki: no, it's for project panel | 09:16 |
| amotoki | e0ne: ah... I was confused. some of them are only for admin. | 09:16 |
| e0ne | amotoki: they are admin-only be default, but operator can configure it via policies | 09:17 |
| amotoki | perhaps only one is "instance_name" | 09:17 |
| amotoki | e0ne: do you have a good pointer for the corresponding nova policy? | 09:18 |
| e0ne | amotoki: https://github.com/openstack/nova/blob/ea5017c6f56dba413ffdc148af1f4b4df5edb141/nova/policies/extended_server_attributes.py#L30 | 09:18 |
| amotoki | e0ne: I see. Hopefully we can evaluate this policy and show these fields based on the evaluation result (perhaps via a context value). it would be straight-forward. | 09:21 |
| amotoki | e0ne: but I am not sure it can now. | 09:21 |
| e0ne | amotoki: sorry, I didn't understand what you mean | 09:21 |
| amotoki | e0ne: okay, let me rephrase it. | 09:22 |
| amotoki | e0ne: according to the nova policy definition, the visibility of these fields are controled by the single policy rule. | 09:22 |
| amotoki | e0ne: ideally, we can evaluate this rule in the horizon policy engine and store the (boolean) result into the context for the template of the instance detail. | 09:23 |
| e0ne | amotoki: oh.. I see... but this will work only on horizon side. | 09:23 |
| amotoki | e0ne: what is your concern? | 09:24 |
| amotoki | e0ne: I expect the nova policy file in both horizon and nova sides should match. | 09:24 |
| e0ne | amotoki: nova does or does not return these fields based on nova policy and even if we check it on horizon side, we still should validate nova's response | 09:25 |
| e0ne | amotoki: unfortunately, I faced a lot of deployments issues with different policies in horizon and nova/neutron/cinder :( | 09:25 |
| amotoki | e0ne: hmm | 09:26 |
| e0ne | amotoki: so I don't expect that everything is configured right and policies are equal | 09:26 |
| amotoki | e0ne: I see | 09:27 |
| amotoki | e0ne: so, another way is to prepare a dict which contains each field is available or not. | 09:28 |
| e0ne | amotoki: I like this solution | 09:28 |
| amotoki | e0ne: or these fields are controlled by the single policy so we might not need to check all fields one by one. | 09:29 |
| e0ne | I'll update my patch | 09:29 |
| e0ne | amotoki: thanks for the help | 09:30 |
| amotoki | e0ne: would it be something like "{% if instance.field_availability.launch_index %} {{ instance.launch_index }} {% endif %}" | 09:31 |
| amotoki | e0ne: or "{% instance.has_extended_attributes %} {{ instance.launch_index }} {% endif %}" ? | 09:31 |
| e0ne | amotoki: I'll add 'has_extended_attribute' property onto the https://review.opendev.org/#/c/721992/2/openstack_dashboard/api/_nova.py | 09:33 |
| amotoki | e0ne: sounds fine, thanks :) | 09:33 |
| e0ne | amotoki: thanks for helping me find a better solution | 09:34 |
| amotoki | e0ne: yw | 09:34 |
| e0ne | e0ne: enjoy your evening! | 09:34 |
| vishalmanchanda | amotoki: hi, I have one only question to ask if you have time. | 09:35 |
| vishalmanchanda | If I used this filter filtersfilters=(filters.parse_isotime, filters.timesince_sortable) for "guaranteed_until" | 09:36 |
| vishalmanchanda | then it looks wired to me https://pasteboard.co/JqpI3PL.png | 09:36 |
| vishalmanchanda | amotoki: ^^ | 09:37 |
| amotoki | vishalmanchanda: hi, that's expected as I commented in the review. | 09:37 |
| amotoki | vishalmanchanda: timesince filter assumes a target time is in the past :) | 09:38 |
| amotoki | vishalmanchanda: I am not sure the importance of "guatranteed_until" field as I don't kwno the background of this field. | 09:38 |
| amotoki | vishalmanchanda: * from user perspective | 09:39 |
| vishalmanchanda | e0ne: Ivan any suggestions here | 09:40 |
| vishalmanchanda | We are discussing this comment https://review.opendev.org/#/c/734161/11/openstack_dashboard/dashboards/project/snapshots/tables.py@275 | 09:40 |
| e0ne | amotoki, vishalmanchanda: guaranteed_until is a time when the message will expire | 09:41 |
| amotoki | but the tab is a page used much less frequently compared to the detail overview page, so the first target might be just to provide information and a way to present messages might not be so important. | 09:42 |
| amotoki | e0ne: I know. I wonder how regular users can use "guaranteed_until" and what action they can take. | 09:43 |
| e0ne | amotoki: IMO, from user perspective it's better to have 'Expired in' column | 09:44 |
| e0ne | but it's needed only to show this message to other users or operators | 09:45 |
| amotoki | e0ne: makes sense. | 09:47 |
| vishalmanchanda | amotoki: what about if I used above filter only for "created_at" and keep "guaranteed_until" date as it is https://pasteboard.co/JqpPg8u.png | 09:48 |
| vishalmanchanda | because "guaranteed_until" 0 minutes doesn't provide any information. | 09:49 |
| amotoki | vishalmanchanda: could you judge them from the POV of users who am not so familiar with cinder details? | 09:49 |
| vishalmanchanda | https://www.irccloud.com/pastebin/AWWrO5hy/ | 09:51 |
| amotoki | vishalmanchanda: do you want me a direct solution? | 09:58 |
| amotoki | vishalmanchanda: the normal UI design is first to design what it should be (mainly from user perspective). It looks like you are discussing how the implementation can be based on the current implementation. The implementation needs to close gaps between what should be and what kind of information we can get from backend APIs. | 09:58 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add cinder-user-facing messages https://review.opendev.org/734161 | 10:23 |
| *** rcernin has joined #openstack-horizon | 10:39 | |
| vishalmanchanda | rdopiera: e0ne : Pep8 is fixed by https://review.opendev.org/#/c/750862/. Please approve it to unblock the gate. once zuul +1 for this patch. | 10:44 |
| openstackgerrit | Radomir Dopieralski proposed openstack/horizon master: Refactor error messages. https://review.opendev.org/749739 | 10:45 |
| rdopiera | vishalmanchanda: that patch fails the gate, if we merge it we will break everything | 10:48 |
| rdopiera | hmm, a timeout in integration tests | 10:49 |
| rdopiera | selenium.common.exceptions.WebDriverException: Message: HTTP method not allowed | 10:49 |
| *** dave-mccowan has joined #openstack-horizon | 11:46 | |
| vishalmanchanda | rdopiera: e0ne : CI is passed for https://review.opendev.org/#/c/750862/. | 12:08 |
| e0ne | vishalmanchanda: approved | 12:28 |
| vishalmanchanda | e0ne: thanks. | 12:32 |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 12:40 |
| *** priteau has quit IRC | 13:11 | |
| *** tmazur has joined #openstack-horizon | 13:14 | |
| *** priteau has joined #openstack-horizon | 13:16 | |
| openstackgerrit | Merged openstack/horizon master: Bump pylint version to support python3.8 https://review.opendev.org/750862 | 14:02 |
| *** jtomasek has joined #openstack-horizon | 14:23 | |
| openstackgerrit | Tobias Urdin proposed openstack/horizon master: Fix missing comment in swift storage policy code https://review.opendev.org/751009 | 14:46 |
| *** dklyle has joined #openstack-horizon | 14:54 | |
| *** ChanServ sets mode: +o dklyle | 14:54 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Show all os-extended-server-attributes https://review.opendev.org/721992 | 15:24 |
| *** dklyle sets mode: -o dklyle | 15:32 | |
| *** rcernin has quit IRC | 15:50 | |
| vishalmanchanda | rdopiera: Could you take a look at cinder-user-facing-messages patch. | 16:05 |
| e0ne | vishalmanchanda, rdopiera, amotoki: FYI, I"m going to propose horizon release in 2-3 hours | 16:06 |
| vishalmanchanda | e0ne: ok. | 16:07 |
| rdopiera | 73 comments? what | 16:14 |
| e0ne | rdopieraL it's a CI issue | 16:16 |
| e0ne | rdopiera: ^ | 16:16 |
| rdopiera | and here I was expecting some drama | 16:16 |
| rdopiera | disappointing | 16:16 |
| e0ne | :) | 16:18 |
| *** jadonn has quit IRC | 16:19 | |
| *** rdopiera has quit IRC | 16:29 | |
| *** e0ne has quit IRC | 16:39 | |
| *** gyee has joined #openstack-horizon | 17:03 | |
| *** tonyb has quit IRC | 17:15 | |
| *** tonyb has joined #openstack-horizon | 17:57 | |
| openstackgerrit | Merged openstack/horizon master: Add cinder-user-facing messages https://review.opendev.org/734161 | 18:04 |
| *** gmann is now known as gmann_afk | 18:11 | |
| *** e0ne has joined #openstack-horizon | 18:57 | |
| *** ChanServ sets mode: +o e0ne | 18:57 | |
| *** priteau has quit IRC | 19:16 | |
| *** e0ne has quit IRC | 19:33 | |
| openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Add Unit Test for cinder-user-facing messages https://review.opendev.org/750882 | 20:01 |
| *** openstackgerrit has quit IRC | 20:36 | |
| *** dklyle has quit IRC | 20:40 | |
| *** david-lyle has joined #openstack-horizon | 20:40 | |
| *** ChanServ sets mode: +o david-lyle | 20:40 | |
| *** david-lyle sets mode: -o david-lyle | 20:55 | |
| *** david-lyle is now known as dklyle | 20:56 | |
| *** jtomasek has quit IRC | 21:11 | |
| *** vishalmanchanda has quit IRC | 22:21 | |
| *** tosky has quit IRC | 22:42 | |
| *** gmann_afk is now known as gmann | 22:49 | |
| *** rcernin has joined #openstack-horizon | 22:58 | |
| *** rcernin has quit IRC | 22:59 | |
| *** rcernin has joined #openstack-horizon | 22:59 | |
| *** tmazur has quit IRC | 23:13 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
