| *** zigo has quit IRC | 00:53 | |
| *** gyee has quit IRC | 01:33 | |
| *** spatel has joined #openstack-horizon | 01:44 | |
| *** tkajinam_ has joined #openstack-horizon | 02:17 | |
| *** jrosser_ has joined #openstack-horizon | 02:19 | |
| *** zigo has joined #openstack-horizon | 02:26 | |
| *** tkajinam has quit IRC | 02:27 | |
| *** johnsom has quit IRC | 02:27 | |
| *** jrosser has quit IRC | 02:27 | |
| *** jrosser_ is now known as jrosser | 02:27 | |
| *** johnsom has joined #openstack-horizon | 02:33 | |
| *** spatel has quit IRC | 04:18 | |
| -openstackstatus- NOTICE: A failing log storage endpoint has been removed, you can recheck any recent jobs with POST_FAILURE where logs have failed to upload | 04:44 | |
| *** vishalmanchanda has joined #openstack-horizon | 05:19 | |
| amotoki | vishalmanchanda: question on https://review.opendev.org/#/c/752016/ how can we test client-side messages? | 05:47 |
|---|---|---|
| amotoki | vishalmanchanda: reply to your IRC message on horizon RC1 yesterday. Do you know there is no RC in horizon? It seems you still follow cycle-with-rc model.... | 05:48 |
| amotoki | vishalmanchanda: horizon now adopts cycle-with-intermediary model, so the next target date is R-1 week ie Oct 5. | 05:49 |
| vishalmanchanda | amotoki: hi, honestly I didn't find a way to test this bug https://bugs.launchpad.net/horizon/+bug/1895570 for client-side messages but I am pretty sure Ivan patch wok for client-side messages as well. | 05:53 |
| openstack | Launchpad bug 1895570 in OpenStack Dashboard (Horizon) "when multiple error popups are shown we cannot show details of second or later popups" [High,In progress] - Assigned to Ivan Kolodyazhny (e0ne) | 05:53 |
| amotoki | vishalmanchanda: hmm... | 05:54 |
| vishalmanchanda | amotoki: although I have checked it work for single error message in client-side and it worked fine. | 05:54 |
| amotoki | vishalmanchanda: I am wondering how Date.now() is unique enough. What is the resolution? | 05:56 |
| amotoki | vishalmanchanda: according to the spec, the resolution is milisecond, so it works as long as multiple msgs are processed in a same milisecond. | 05:57 |
| vishalmanchanda | amotoki: ok let me check a real scenario for multiple error messages on client side with Ivan patch. | 05:59 |
| vishalmanchanda | amotoki: btw do you think we can use something else for unique id rather than Date. | 06:03 |
| amotoki | vishalmanchanda: no idea. I just would like to test it in real envs. | 06:05 |
| amotoki | vishalmanchanda: I am not talking about theoretical behavior. it is just a side discussion. | 06:05 |
| *** ianychoi_ is now known as ianychoi | 06:16 | |
| amotoki | vishalmanchanda: how did you test single error message in client-side? | 06:31 |
| amotoki | vishalmanchanda: I just cannot remember how I tested it... | 06:31 |
| vishalmanchanda | amotoki: just add redirect parameter in exception.handle() | 06:32 |
| amotoki | vishalmanchanda: in which file? | 06:32 |
| vishalmanchanda | amotoki: I have test it for https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L132 | 06:33 |
| amotoki | vishalmanchanda: thanks. I will try it. In case of modal forms like "Create Network", server-side message (forloop.count) is used, so I wondered why. | 06:34 |
| vishalmanchanda | amotoki: Admin->Volume_type->Click_on_create_encryption->Enter_any_value an then you will get an error | 06:35 |
| *** e0ne has joined #openstack-horizon | 06:41 | |
| *** ChanServ sets mode: +o e0ne | 06:41 | |
| *** e0ne has quit IRC | 06:45 | |
| *** dklyle has quit IRC | 06:47 | |
| *** jtomasek has joined #openstack-horizon | 06:59 | |
| *** rdopiera has joined #openstack-horizon | 07:05 | |
| amotoki | vishalmanchanda: https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L132 you mentioned has redirect parameter. | 07:07 |
| amotoki | vishalmanchanda: do you mean dropping redirect from there? | 07:07 |
| vishalmanchanda | amotoki: no need to drop redirect from there. | 07:08 |
| vishalmanchanda | amotoki: What I mean every exception.handle function which have redirect parameter will use client_side/_alert_message.html template for error messages display. | 07:10 |
| vishalmanchanda | amotoki: oops sorry for confusion yeah drop redirect from there | 07:11 |
| vishalmanchanda | amotoki: Also make sure a volume is already created with that"volume_type" which try to encrypt and just remove redirect parameter from exceptions.handle() and you will get an error message. | 07:15 |
| *** tosky has joined #openstack-horizon | 07:19 | |
| amotoki | vishalmanchanda: I tested the client-side msg by dropping redirect parameter there, doublingexceptions.handle() there with different messages, and inserting "raise Exception(...)" in handle(). | 07:20 |
| amotoki | vishalmanchanda: I got two messages and ID of the two messages are different only by 2 miliseconds. | 07:20 |
| amotoki | vishalmanchanda: message_details_1600845471116 and message_details_1600845471118.... they looks too close and I cannot say they are safe enough. | 07:21 |
| vishalmanchanda | amotoki: hmm 2 miliseconds... | 07:22 |
| amotoki | vishalmanchanda: perhaps UUID is safer | 07:24 |
| vishalmanchanda | amotoki: ok then we can use UUID. | 07:28 |
| vishalmanchanda | amotoki: Could you please comments your finding on the patch https://review.opendev.org/#/c/752016/ as well. | 07:29 |
| *** rcernin has quit IRC | 07:45 | |
| *** priteau has joined #openstack-horizon | 07:50 | |
| *** kevko has joined #openstack-horizon | 07:51 | |
| *** rdopiera has quit IRC | 07:51 | |
| *** tkajinam_ is now known as tkajinam | 08:34 | |
| *** priteau has quit IRC | 08:56 | |
| *** vinay_m has joined #openstack-horizon | 10:17 | |
| vinay_m | hi all , i have doubt ,with enabling debug-logs for horizon , as it is different from other services | 10:19 |
| vinay_m | can anyone help me out with this? | 10:19 |
| vishalmanchanda | vinay_m: hi, I think you can enable logs from local_settings.py file. | 10:23 |
| amotoki | vishalmanchanda: I added a comment on your cinder message tests https://review.opendev.org/#/c/750882/7 | 10:37 |
| amotoki | vishalmanchanda: I confirmed the message table says "No items to display." | 10:38 |
| amotoki | vishalmanchanda: In most popular cases, it looks like something goes wrong in your mocks. | 10:38 |
| amotoki | vishalmanchanda: I don't investigate more. thanks. | 10:38 |
| vishalmanchanda | amotoki: ok thanks for review will look into it. | 10:40 |
| amotoki | vinay_m: horizon is a web service, so a way to enable debug log is a bit different. | 10:41 |
| amotoki | vinay_m: setting DEBUG=True in local_settings.py just enables the debug mechanism of Django which is a framework horizon depends on. | 10:41 |
| amotoki | vinay_m: To enable debug log, you need to configure LOGGING setting in local_settings.py. | 10:42 |
| amotoki | vinay_m: in typical cases, you need to change LOGGING['handlers']['console']['class'] to 'DEBUG'. IRC the default value is 'INFO'. | 10:43 |
| amotoki | vinay_m: perhaps vishalmanchanda's advise is a bit unclear. | 10:43 |
| vishalmanchanda | I run the horizon on a development server using this command "python manage.py runserver" and I just set "DEBUG = True" in my local_settings.py file for debug logs. | 10:47 |
| *** e0ne has joined #openstack-horizon | 11:12 | |
| *** ChanServ sets mode: +o e0ne | 11:12 | |
| amotoki | vishalmanchanda: that's because https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/local/local_settings.py.example#L164 | 11:13 |
| e0ne | amotoki: hi. do you have a time to discuss https://review.opendev.org/#/c/752016/4/horizon/static/horizon/js/horizon.messages.js? | 11:34 |
| *** kevko has quit IRC | 11:37 | |
| amotoki | e0ne: hi | 11:42 |
| e0ne | amotoki: Date.now() returns returns the number of milliseconds elapsed since January 1, 1970 00:00:00 UTC. (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/now) | 11:43 |
| e0ne | and browsers executes JS in a single-thread only, so it can't be conflicting | 11:43 |
| amotoki | e0ne: do you mean at least one second is guranteed? | 11:44 |
| e0ne | amotoki: is you change https://opendev.org/openstack/horizon/src/branch/master/openstack_dashboard/dashboards/admin/volume_types/forms.py#L132 to raise an exception, it will use djang-based template https://review.opendev.org/#/c/752016/4/horizon/templates/horizon/_messages.html | 11:44 |
| amotoki | e0ne: as I commented in the comment, when I tested I dropped 'redirect' parameter, so client-side message is used. | 11:45 |
| e0ne | amotoki: got it, I'll re-check | 11:45 |
| e0ne | amotoki: technically, it can return the same date im milliseconds | 11:46 |
| amotoki | e0ne: I am not sure the proposed change is a final solution or just a workaround towards the release. | 11:47 |
| amotoki | e0ne: I am now trying UUID approach by borrowing an UUID impl from https://www.w3resource.com/javascript-exercises/javascript-math-exercise-23.php | 11:47 |
| e0ne | amotoki: I hope that client-side version will be a final | 11:49 |
| e0ne | but who knows | 11:49 |
| e0ne | amotoki: we've got this https://github.com/openstack/horizon/blob/4e0ee573db4561dc7e0c10835d31d73eddb12aca/horizon/static/framework/util/uuid/uuid.js#L29 already | 11:49 |
| *** vinay_m has quit IRC | 11:50 | |
| amotoki | e0ne: can we consume a function defined in AngularJS module in non-AngularJS module? it might be a stupid question. | 11:51 |
| e0ne | amotoki: AFAIK, we can't:( | 11:51 |
| *** vinay_m has joined #openstack-horizon | 11:52 | |
| amotoki | e0ne: but the code is exactly same as I mentioned above, so we can borrow it. | 11:52 |
| *** kevko has joined #openstack-horizon | 11:56 | |
| vinay_m | <amotoki> Thanks for these configuration suggestions. At last after these to get those debug logs from console i should run the command which <vishalmanchanda> mentioned "python manage.py runserver" ..right? | 11:59 |
| amotoki | vinay_m: it depends on how you deploy horizon. | 12:00 |
| amotoki | vinay_m: "python manage.py runserver" is only for development. | 12:00 |
| *** tosky_ has joined #openstack-horizon | 12:02 | |
| vinay_m | i use devstack ussuri version deployed in a vm | 12:02 |
| *** tosky is now known as Guest73219 | 12:03 | |
| *** tosky_ is now known as tosky | 12:03 | |
| amotoki | vinay_m: If so, it should work for apache based deployment in devstack. | 12:03 |
| amotoki | vinay_m: one thing I wonder is DEBUG should be enabled in devstack ussuri by default. At least DEBUG is enabled in ussuri devstack. | 12:05 |
| *** Guest73219 has quit IRC | 12:05 | |
| *** ianychoi has left #openstack-horizon | 12:08 | |
| e0ne | amotoki: I've got working PoC | 12:10 |
| e0ne | amotoki: need to check for angular-based panel that I didn't break uuid generator | 12:10 |
| amotoki | :) | 12:10 |
| vinay_m | amotoki: yes Debug is set to true under openstack_dashboard/local/local_settings.py | 12:11 |
| vinay_m | so logs are generated under /var/log/apache2 dir | 12:12 |
| vinay_m | under which they were specific logs like horizon_access.log, horizon_error.log | 12:13 |
| vinay_m | so i'm not aware of these debug logs where will be generating | 12:14 |
| amotoki | vinay_m: horizon_access.log is just logged by apache | 12:19 |
| amotoki | vinay_m: horizon_error.log records standard errors from WSGI application i.e. horizon on top of Django in this case. | 12:19 |
| amotoki | vinay_m: when using apache mod_wsgi, all data sent to standard error is directed to the apache logging system and then recorded into a corresponding apache error log. | 12:21 |
| *** admin0 has joined #openstack-horizon | 12:26 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 12:28 |
| e0ne | amotoki: here is it ^^ | 12:29 |
| amotoki | e0ne: thanks. Did you forget to add horizon/static/horizon/js/horizon.uuid.js? | 12:34 |
| e0ne | i did:( | 12:34 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 12:34 |
| *** priteau has joined #openstack-horizon | 12:35 | |
| amotoki | e0ne: thanks. you already did it :) | 12:35 |
| e0ne | :) | 12:36 |
| e0ne | amotoki: I didn' | 12:37 |
| e0ne | amotoki: I didn't find a solution to use angular-defined function in a pain js function, so I defined it in a pure js and re-use in angular | 12:38 |
| amotoki | e0ne: it sounds reasonable to me too. | 12:39 |
| e0ne | amotoki: it seems that https://review.opendev.org/#/c/752016/6/horizon/static/framework/util/uuid/uuid.js is not really needed anymore | 12:39 |
| e0ne | amotoki: I left if for 2 reasons: | 12:39 |
| e0ne | #1) it has some unit tests | 12:39 |
| e0ne | 2) I don't want to make such big changes right before release/rc | 12:40 |
| amotoki | e0ne: thanks for checking it. sounds good at the moment. | 12:45 |
| e0ne | amotoki: thanks for the feedback | 12:45 |
| amotoki | e0ne: I don't know the motivation that uuid angular module was implemented though. | 12:46 |
| *** tkajinam has quit IRC | 12:51 | |
| *** tkajinam has joined #openstack-horizon | 12:52 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/horizon master: Set unique identifier for Django messages https://review.opendev.org/752016 | 13:01 |
| *** tosky_ has joined #openstack-horizon | 13:26 | |
| *** tosky is now known as Guest13336 | 13:26 | |
| *** tosky_ is now known as tosky | 13:26 | |
| *** Guest13336 has quit IRC | 13:28 | |
| *** tosky_ has joined #openstack-horizon | 13:29 | |
| *** tosky is now known as Guest61020 | 13:31 | |
| *** tosky_ is now known as tosky | 13:31 | |
| *** Guest61020 has quit IRC | 13:32 | |
| *** kevko has quit IRC | 13:37 | |
| *** tmazur has joined #openstack-horizon | 13:51 | |
| *** kevko has joined #openstack-horizon | 14:04 | |
| *** tkajinam has quit IRC | 14:05 | |
| vinay_m | amotoki: Thanks sir! it's working | 14:14 |
| *** vinay_m has quit IRC | 14:38 | |
| *** kevko has quit IRC | 14:42 | |
| *** dklyle has joined #openstack-horizon | 14:48 | |
| *** ChanServ sets mode: +o dklyle | 14:48 | |
| *** gyee has joined #openstack-horizon | 15:45 | |
| *** tosky has quit IRC | 15:59 | |
| *** priteau has quit IRC | 17:02 | |
| *** jtomasek has quit IRC | 17:41 | |
| *** e0ne has quit IRC | 17:56 | |
| *** chenhaw has joined #openstack-horizon | 18:19 | |
| *** spatel has joined #openstack-horizon | 18:57 | |
| *** spatel has quit IRC | 19:02 | |
| *** tosky has joined #openstack-horizon | 19:15 | |
| *** dklyle sets mode: -o dklyle | 19:42 | |
| *** vishalmanchanda has quit IRC | 20:38 | |
| *** viks____ has quit IRC | 20:49 | |
| *** vkmc has quit IRC | 20:49 | |
| *** fyx has quit IRC | 20:49 | |
| *** jrosser has quit IRC | 20:50 | |
| *** rpittau|afk has quit IRC | 20:50 | |
| *** coreycb has quit IRC | 20:50 | |
| *** gmann has quit IRC | 20:50 | |
| *** CeeMac has quit IRC | 20:51 | |
| *** NobodyCam has quit IRC | 20:51 | |
| *** vkmc has joined #openstack-horizon | 20:51 | |
| *** kklimonda has quit IRC | 20:52 | |
| *** CeeMac has joined #openstack-horizon | 20:52 | |
| *** coreycb has joined #openstack-horizon | 20:52 | |
| *** NobodyCam has joined #openstack-horizon | 20:52 | |
| *** kklimonda has joined #openstack-horizon | 20:52 | |
| *** jrosser has joined #openstack-horizon | 20:52 | |
| *** fyx has joined #openstack-horizon | 20:52 | |
| *** rpittau|afk has joined #openstack-horizon | 20:53 | |
| *** gmann has joined #openstack-horizon | 20:53 | |
| *** rcernin has joined #openstack-horizon | 22:46 | |
| *** CeeMac has quit IRC | 22:50 | |
| *** johnsom has quit IRC | 22:50 | |
| *** ShadowJonathan has quit IRC | 22:50 | |
| *** andrein has quit IRC | 22:50 | |
| *** jberg-dev has quit IRC | 22:50 | |
| *** coreycb has quit IRC | 22:50 | |
| *** fyx has quit IRC | 22:50 | |
| *** mnaser has quit IRC | 22:50 | |
| *** NobodyCam has quit IRC | 22:51 | |
| *** vkmc has quit IRC | 22:51 | |
| *** CeeMac has joined #openstack-horizon | 22:51 | |
| *** ShadowJonathan has joined #openstack-horizon | 22:51 | |
| *** kklimonda has quit IRC | 22:51 | |
| *** andrein has joined #openstack-horizon | 22:52 | |
| *** fyx has joined #openstack-horizon | 22:52 | |
| *** kklimonda has joined #openstack-horizon | 22:52 | |
| *** rm_work has quit IRC | 22:52 | |
| *** mnaser has joined #openstack-horizon | 22:53 | |
| *** rpittau|afk has quit IRC | 22:54 | |
| *** jrosser has quit IRC | 22:54 | |
| *** rm_work has joined #openstack-horizon | 22:54 | |
| *** coreycb has joined #openstack-horizon | 22:55 | |
| *** johnsom has joined #openstack-horizon | 22:55 | |
| *** jberg-dev has joined #openstack-horizon | 22:55 | |
| *** jrosser has joined #openstack-horizon | 22:56 | |
| *** rpittau|afk has joined #openstack-horizon | 22:56 | |
| *** vkmc has joined #openstack-horizon | 22:56 | |
| *** dannins has quit IRC | 22:57 | |
| *** andrein has quit IRC | 22:58 | |
| *** NobodyCam has joined #openstack-horizon | 22:59 | |
| *** andrein has joined #openstack-horizon | 23:00 | |
| *** tkajinam has joined #openstack-horizon | 23:03 | |
| *** tmazur has quit IRC | 23:05 | |
| *** rcernin has quit IRC | 23:34 | |
| *** rcernin has joined #openstack-horizon | 23:34 | |
| *** tosky has quit IRC | 23:49 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!