*** gmann_afk is now known as gmann | 00:19 | |
*** openstackgerrit has joined #openstack-horizon | 01:06 | |
openstackgerrit | Merged openstack/horizon master: Add option to set MTU on network creation https://review.opendev.org/c/openstack/horizon/+/770870 | 01:06 |
---|---|---|
*** ircuser-1 has joined #openstack-horizon | 01:29 | |
openstackgerrit | Merged openstack/horizon master: Set Admin Password at NG Launch Instance dialog https://review.opendev.org/c/openstack/horizon/+/770528 | 01:33 |
*** rcernin has quit IRC | 02:31 | |
*** rcernin has joined #openstack-horizon | 02:40 | |
*** adriant has quit IRC | 02:58 | |
*** adriant has joined #openstack-horizon | 02:58 | |
*** hoonetorg has joined #openstack-horizon | 04:40 | |
*** openstackstatus has quit IRC | 04:58 | |
*** openstack has joined #openstack-horizon | 05:02 | |
*** ChanServ sets mode: +o openstack | 05:02 | |
*** hoonetorg has quit IRC | 05:05 | |
*** hoonetorg has joined #openstack-horizon | 05:19 | |
*** vishalmanchanda has joined #openstack-horizon | 06:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/770725 | 06:47 |
*** gyee has quit IRC | 06:54 | |
*** dklyle has quit IRC | 07:38 | |
*** rpittau|afk is now known as rpittau | 07:51 | |
*** e0ne has joined #openstack-horizon | 08:41 | |
*** ChanServ sets mode: +o e0ne | 08:41 | |
*** rcernin has quit IRC | 08:56 | |
*** e0ne has quit IRC | 09:04 | |
*** e0ne has joined #openstack-horizon | 09:05 | |
*** ChanServ sets mode: +o e0ne | 09:05 | |
*** tosky has joined #openstack-horizon | 09:12 | |
*** rdopiera has joined #openstack-horizon | 09:41 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Fix deprecation warning of 'collections' https://review.opendev.org/c/openstack/horizon/+/774790 | 09:50 |
*** kevko_ has joined #openstack-horizon | 10:06 | |
*** kevko_ has quit IRC | 10:09 | |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Update doc8 version https://review.opendev.org/c/openstack/horizon/+/774794 | 10:25 |
*** e0ne has quit IRC | 10:53 | |
*** e0ne has joined #openstack-horizon | 11:03 | |
*** ChanServ sets mode: +o e0ne | 11:03 | |
*** ianychoi__ is now known as ianychoi | 11:30 | |
*** disap has joined #openstack-horizon | 11:56 | |
amotoki | vishalmanchanda: regarding https://review.opendev.org/c/openstack/horizon/+/774790, do you see the derecation warnings even when we use collections.abc.XXXX? | 12:05 |
*** e0ne has quit IRC | 12:05 | |
amotoki | vishalmanchanda: I see no real change in that patch. you are just trying to change the import style and I see no need for the change (plus I personally prefer to collections.abc.XXX style). | 12:06 |
vishalmanchanda | amotoki: I see the warning in our gate job https://zuul.opendev.org/t/openstack/build/d8b51cd24caf422f8c6d37b6e81305cc that's why I pushed the patch. | 12:07 |
amotoki | vishalmanchanda: which line? Is it from the horizon code? | 12:08 |
*** kevko has joined #openstack-horizon | 12:17 | |
vishalmanchanda | amotoki: Actually I haven't tested it locally I have seen a deprecation warning in the gate job https://zuul.opendev.org/t/openstack/build/d8b51cd24caf422f8c6d37b6e81305cc/log/job-output.txt#25686 that's why I pushed the patch to fix it. | 12:18 |
amotoki | vishalmanchanda: It comes from unittest2. why does it mean horizon code needs a fix? | 12:19 |
vishalmanchanda | vishalmanchanda: oops:( my bad. | 12:20 |
*** e0ne has joined #openstack-horizon | 12:22 | |
*** ChanServ sets mode: +o e0ne | 12:22 | |
amotoki | vishalmanchanda: on the other hand, I just noticed we need an explicit import when using collections.abc.XXX. | 12:23 |
amotoki | vishalmanchanda: See this snippet http://paste.openstack.org/show/802512/ | 12:23 |
amotoki | vishalmanchanda: "import collections" looks insufficient. "import collections.abc" or "from collections import abc" looks required | 12:24 |
openstackgerrit | Vishal Manchanda proposed openstack/horizon master: Update doc8 min version https://review.opendev.org/c/openstack/horizon/+/774794 | 12:24 |
amotoki | vishalmanchanda: from this POV, your change (or "import collections.abc") is needed but the reason needs to be explained better. | 12:25 |
vishalmanchanda | amotoki: ok will restore the patch with a better commit-msg. | 12:25 |
openstackgerrit | Merged openstack/horizon master: Use "load static" instead of "load staticfiles" https://review.opendev.org/c/openstack/horizon/+/770610 | 12:46 |
openstackgerrit | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/770725 | 12:46 |
*** iurygregory has quit IRC | 12:51 | |
*** rcernin has joined #openstack-horizon | 13:13 | |
*** rcernin has quit IRC | 13:18 | |
*** disap has quit IRC | 13:35 | |
*** disap has joined #openstack-horizon | 13:49 | |
*** tmazur has joined #openstack-horizon | 13:55 | |
*** ianychoi has quit IRC | 14:09 | |
*** iurygregory has joined #openstack-horizon | 14:13 | |
*** rcernin has joined #openstack-horizon | 15:14 | |
*** rcernin has quit IRC | 15:18 | |
*** dklyle has joined #openstack-horizon | 15:34 | |
*** disap has quit IRC | 15:41 | |
*** jadonn has joined #openstack-horizon | 16:14 | |
rdopiera | e0ne: I wanted to ask you about the command used to run the integration tests in train -- the manage.py test -- it behaves very weird. When run by tox, it finds the tests correctly, but when I try to run it from the command line, it fails to find any. Do you know why? | 16:17 |
e0ne | hm... | 16:17 |
e0ne | interesting... I always use tos | 16:17 |
e0ne | s/tos/tox | 16:18 |
rdopiera | I tried to copy all the environment variables, all the paths are the same, I even used the same virtualenv -- I have no idea how the command even knows it's run by tox | 16:18 |
rdopiera | it's impossible but it's somehow happening | 16:19 |
e0ne | what error do you have? | 16:19 |
rdopiera | no error, just "ran 0 tests" | 16:19 |
e0ne | let me try | 16:23 |
rdopiera | I found a different way to run those tests, by giving an explicit path instead of a tag, but I find it a bit of a mystery why it doesn't work | 16:23 |
rdopiera | curiosity | 16:23 |
*** disap has joined #openstack-horizon | 16:38 | |
*** disap has quit IRC | 17:16 | |
*** e0ne has quit IRC | 17:16 | |
*** e0ne has joined #openstack-horizon | 17:22 | |
*** ChanServ sets mode: +o e0ne | 17:22 | |
*** rdopiera has quit IRC | 17:32 | |
*** e0ne has quit IRC | 18:19 | |
openstackgerrit | Andrew Bogott proposed openstack/horizon master: security_groups panel: Add neutron policy enforcement https://review.opendev.org/c/openstack/horizon/+/774922 | 18:21 |
*** rpittau is now known as rpittau|afk | 18:23 | |
openstackgerrit | Andrew Bogott proposed openstack/horizon master: security_groups panel: Add neutron policy enforcement https://review.opendev.org/c/openstack/horizon/+/774922 | 18:28 |
*** e0ne has joined #openstack-horizon | 18:29 | |
*** ChanServ sets mode: +o e0ne | 18:29 | |
*** e0ne has quit IRC | 18:29 | |
*** kevko has quit IRC | 19:55 | |
openstackgerrit | Merged openstack/horizon stable/victoria: Add WEBROOT to ngdetails navigation https://review.opendev.org/c/openstack/horizon/+/768752 | 20:03 |
openstackgerrit | Merged openstack/horizon stable/ussuri: Fix full text search at containers page https://review.opendev.org/c/openstack/horizon/+/770750 | 20:03 |
*** gyee has joined #openstack-horizon | 20:21 | |
*** jadonn has quit IRC | 20:26 | |
*** jadonn has joined #openstack-horizon | 20:35 | |
openstackgerrit | Andrew Bogott proposed openstack/horizon master: Support policy checks in the Tab base class https://review.opendev.org/c/openstack/horizon/+/775014 | 20:43 |
openstackgerrit | Andrew Bogott proposed openstack/horizon master: Server tabs: add policy enforcement for tab display https://review.opendev.org/c/openstack/horizon/+/775015 | 20:43 |
*** jadon_n has joined #openstack-horizon | 22:08 | |
*** jadonn has quit IRC | 22:10 | |
*** jadon_n has quit IRC | 22:14 | |
*** vishalmanchanda has quit IRC | 22:51 | |
openstackgerrit | Merged openstack/horizon stable/victoria: Add default index URL to Server Groups module https://review.opendev.org/c/openstack/horizon/+/768754 | 23:39 |
*** CeeMac has quit IRC | 23:51 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!