*** tmazur has quit IRC | 01:06 | |
*** vishalmanchanda has joined #openstack-horizon | 04:37 | |
*** whoami-rajat has joined #openstack-horizon | 06:12 | |
*** ralonsoh has joined #openstack-horizon | 06:29 | |
opendevreview | OpenStack Proposal Bot proposed openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/795482 | 06:48 |
---|---|---|
opendevreview | OpenStack Proposal Bot proposed openstack/horizon stable/victoria: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/795483 | 06:57 |
*** dklyle has quit IRC | 06:58 | |
*** tosky has joined #openstack-horizon | 07:53 | |
opendevreview | Merged openstack/horizon stable/victoria: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/795483 | 07:56 |
opendevreview | Merged openstack/horizon master: Imported Translations from Zanata https://review.opendev.org/c/openstack/horizon/+/795482 | 08:05 |
*** lxkong has joined #openstack-horizon | 08:07 | |
*** jchorin has joined #openstack-horizon | 08:23 | |
jchorin | Hi everyone, I get an issue with my Horizon setup with TLS support. When opening on a browser, several css and js files are not found (404 error in the "Network" part of the inspection). When attempting to curl the file directly, the logs says: "File does not exist" | 08:26 |
vishalmanchanda | jchorin: Hi Could you try "sudo python manage.py collectstatic" command | 08:28 |
vishalmanchanda | and then restart your apache server | 08:28 |
jchorin | vishalmanchanda: `0 static files copied to '/var/lib/openstack-dashboard/static', 1869 unmodified.` is that normal? | 08:31 |
jchorin | vishalmanchanda: also I get the same issue | 08:31 |
vishalmanchanda | jchorin: what type changes you have done so far. | 08:32 |
vishalmanchanda | jchorin: if css and js files are not found then it's generally your static files are not able to load. | 08:34 |
vishalmanchanda | and above command sometimes works. | 08:34 |
jchorin | vishalmanchanda: I did "manage.py compress", set the TLS support on apache, modified /etc/openstack-dashboard/local_settings.py, had to change permissions on /etc/openstack-dashboard/ for wsgi to find the local_settings.py and changed permissions for /var/lib/openstack-dashboard/secret_key as well | 08:34 |
jchorin | vishalmanchanda: the dashboard also say "Unable to establish connection to keystone endpoint." if I try to connect | 08:35 |
vishalmanchanda | jchorin: hmm looks like you are also using wrong keystone endpoint. | 08:38 |
vishalmanchanda | jchorin: Could you check your keystone endpoint using `` openstack endpoint list | grep keystone`` | 08:39 |
jchorin | vishalmanchanda: my bad there was a typo there, the keystone endpoint is working, I can log in. But the js and css are broken | 08:41 |
vishalmanchanda | jchorin: and then compare the url with https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L121 | 08:41 |
vishalmanchanda | jchorin: ok then your static files are not able to load. | 08:41 |
vishalmanchanda | jchorin: run`` python setup.py install`` and ``python manage.py collectstatic``command | 08:42 |
vishalmanchanda | clears your browser cache and cookies and restart apache server. | 08:43 |
jchorin | vishalmanchanda: which setup.py file do you mean? | 08:45 |
vishalmanchanda | jchorin: I usually run this command ``python3 setup.py install`` when I do any changes in any python files. | 08:47 |
jchorin | vishalmanchanda: I installed horizon through the apt packages, not with the sources :/ | 08:49 |
vishalmanchanda | jchorin: hmm I have no experience installing with apt packages. | 08:51 |
jchorin | vishalmanchanda: still, thanks for the help! | 09:04 |
jchorin | vishalmanchanda: do you know where the static files are supposed to be | 09:06 |
vishalmanchanda | jchorin: my setup is basically devstack setup and for me it is under horizon/static | 09:16 |
*** rdopiera has joined #openstack-horizon | 09:25 | |
vmarkov | Hi all. Could you review a patch? https://review.opendev.org/c/openstack/horizon/+/793970 | 10:22 |
*** tmazur has joined #openstack-horizon | 12:45 | |
*** josecastroleon has quit IRC | 13:09 | |
jchorin | Hi again. I still have the issue that the css and js files are not found for my dashboard (404). I can find the files in `/var/lib/openstack-dashboard/static/dashboard/` but not in `/usr/share/openstack-dashboard/openstack_dashboard/static/dashboard`. Is that normal behavior? | 13:24 |
vmarkov | How do you install Horizon? | 13:47 |
opendevreview | Heather Lemon proposed openstack/horizon master: Only delete selected row and refresh table https://review.opendev.org/c/openstack/horizon/+/788585 | 13:54 |
*** e0ne has joined #openstack-horizon | 14:15 | |
*** tosky has quit IRC | 14:16 | |
*** tosky has joined #openstack-horizon | 14:18 | |
jchorin | vmarkov: with the apt packages | 14:29 |
vmarkov | Hi e0ne ) | 14:32 |
e0ne | vmarkov: welcome back:) | 14:33 |
vishalmanchanda | #startmeeting horizon | 15:00 |
opendevmeet | Meeting started Wed Jun 9 15:00:18 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
e0ne | hi | 15:01 |
tmazur | o/ | 15:01 |
rdopiera | o/ | 15:02 |
vishalmanchanda | hello everyone. | 15:02 |
vishalmanchanda | this meeting will be short as I am not having much update. | 15:02 |
vishalmanchanda | ok let's start. | 15:02 |
vishalmanchanda | #topic Notices | 15:02 |
vishalmanchanda | I have no notices for this week. | 15:03 |
vishalmanchanda | if anyone else have any announcement please go ahead. | 15:03 |
*** dklyle has joined #openstack-horizon | 15:04 | |
rdopiera | I finally got the django-sass-processor to work | 15:04 |
e0ne | rdopiera: awesome! | 15:04 |
rdopiera | I have a proof of concept patch here: https://review.opendev.org/c/openstack/horizon/+/794809 | 15:04 |
vishalmanchanda | rdopiera: nice🙂) | 15:04 |
amotoki | hi | 15:04 |
rdopiera | there three main problems: | 15:05 |
vishalmanchanda | rdopiera: ok let's discuss it after I change the topic | 15:05 |
rdopiera | 1. it doesn't seem to underastand absolute paths the same was as scss -- it looks for the files in that absolute location | 15:05 |
vishalmanchanda | #topic django sass processor | 15:05 |
rdopiera | ok, soryr | 15:05 |
rdopiera | there three main problems: | 15:05 |
vishalmanchanda | rdopiera: floor is yours, please go ahead. | 15:05 |
rdopiera | there three main problems: | 15:05 |
rdopiera | sorry | 15:05 |
rdopiera | 1. it doesn't seem to underastand absolute paths the same was as scss -- it looks for the files in that absolute location | 15:06 |
rdopiera | (we can probably fix it by subclassing it) | 15:06 |
rdopiera | 2. the way it uses a django template tag for inclusion, it doesn't allow templating inside the scss code, so we need to find a different way of including the style overrides from user settings (or remove that setting) | 15:07 |
rdopiera | 3. it has some problems with the material theme that I don't fully understand -- something about calling a function with a function as a parameter | 15:07 |
rdopiera | that's all I have | 15:09 |
vishalmanchanda | rdopiera: ok I will take a look and try your patch in my env. | 15:10 |
amotoki | regarding the second point, I am not sure it is really needed. it might be covered by a theme. | 15:12 |
*** ikanias has joined #openstack-horizon | 15:12 | |
rdopiera | amotoki: or an additional file outside the theme | 15:13 |
rdopiera | that we can @import | 15:13 |
amotoki | I see. it should work. | 15:14 |
rdopiera | the 3. is probably just something that libsass doesn't support | 15:14 |
rdopiera | do we have anything else to discuss? | 15:17 |
amotoki | rdopiera: regarding 3, what kind of functions? | 15:17 |
rdopiera | let me quickly re-run it | 15:17 |
rdopiera | Error: Functions may not be defined within control directives or other mixins. on line 5:13 of openstack_dashboard/themes/material/static/horizon/_styles.scss | 15:18 |
rdopiera | >> @function selector-append($selector, $to-append) { | 15:18 |
rdopiera | (by the way, the error reporting seems much nicer too) | 15:19 |
amotoki | ah, we have some workdaround on this already. | 15:20 |
amotoki | that workaround was added to support the material theme with the current pyscss | 15:21 |
amotoki | we may be able to adjust it to django-scss-processor. | 15:22 |
e0ne | amotoki: +1 | 15:22 |
rdopiera | the commands needed to generate the static files will change too | 15:22 |
rdopiera | we will need to add one more manage command | 15:22 |
rdopiera | but if we can solve 1. and 3., I think we can use this | 15:23 |
vishalmanchanda | rdopiera: great... | 15:23 |
vishalmanchanda | ok moving to next topic. | 15:24 |
vishalmanchanda | #Nodejs14 migration | 15:24 |
vishalmanchanda | #topic Nodejs14 migration | 15:24 |
vishalmanchanda | small update on this topic. | 15:25 |
vishalmanchanda | All horizon plugins run horizon nodejs14 job template | 15:25 |
vishalmanchanda | https://review.opendev.org/q/topic:%22migrate-to-nodejs14%22+(status:open%20OR%20status:merged) | 15:25 |
vishalmanchanda | I forgot to push patches for some plugins to drop nodejs10 job which I try to push by today. | 15:26 |
vishalmanchanda | https://review.opendev.org/q/topic:%22drop-nodejs10%22+(status:open%20OR%20status:merged) | 15:26 |
vishalmanchanda | I was thinking if we can drop horizon-nodejs10 job template from horizon. | 15:27 |
vishalmanchanda | then horizon plugins must have to drop horizon-nodejs10 template to make their CI/CD green. | 15:28 |
vishalmanchanda | What you say or we should wait for more time? | 15:29 |
amotoki | vishalmanchanda: why didn't you replace node10 jobs with node14 jobs in plugins rather than adding node14 jobs? | 15:30 |
amotoki | if so, dropping nodejs10 job template would be simpler. | 15:31 |
vishalmanchanda | amotoki: yeah I didn't done that initially to avoid any failure. | 15:31 |
amotoki | the goal is to migrate jobs to nodejs14, so we don't need to keep both in plugins | 15:32 |
amotoki | I am not sure how it is realted to avoiding failures... | 15:33 |
vishalmanchanda | amotoki: yes. | 15:33 |
amotoki | I am against dropping nodejs10 template from horizon first. I think we should avoid breakage we can easily expect. | 15:34 |
vishalmanchanda | yeah my bad I missed that:( | 15:34 |
amotoki | vishalmanchanda: np | 15:34 |
vishalmanchanda | amotoki: ok I will wait till horizon-nodejs10 template removed from all plugins. | 15:35 |
vishalmanchanda | that's all update from my side. | 15:36 |
vishalmanchanda | #topic open-discussion | 15:36 |
vishalmanchanda | This week I am working on testing horizon with XStatic-Angular 1.8.2.1 version. | 15:37 |
vishalmanchanda | npm-test are failing as of now. | 15:37 |
vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/794774 | 15:37 |
vishalmanchanda | will reach to you guys if I need any help. | 15:37 |
amotoki | any update on django 3.x? | 15:38 |
vishalmanchanda | amotoki: I was thinking to start reviewing your django3 patches. | 15:40 |
vishalmanchanda | #link https://review.opendev.org/q/topic:%22django3-support%22+(status:open%20OR%20status:merged) | 15:40 |
amotoki | vishalmanchanda: how about django-pyscss? does it depend on rdopiera's effort? | 15:41 |
vishalmanchanda | amotoki: need to check, I was thinking how should I start. | 15:42 |
vishalmanchanda | amotoki: Should we merge that patch which add a django3 job(non-voting) first | 15:43 |
amotoki | vishalmanchanda: non-voting job patch is okay (unless the numberr of jobs is not a problem) | 15:43 |
amotoki | it is nice to have such jobs if we plan to move djnago30 support forward soon. otherwise, the django3 non-voting always fails and would be meaningless. | 15:45 |
amotoki | that's my point. | 15:45 |
vishalmanchanda | amotoki: sure, I will start with this one https://review.opendev.org/c/openstack/horizon/+/777390 | 15:46 |
vishalmanchanda | amotoki: will reach to you if have any doubts. | 15:46 |
amotoki | thanks | 15:47 |
vishalmanchanda | Does anyone have any other topics to discuss? | 15:47 |
vishalmanchanda | or we can end this meeting. | 15:47 |
rdopiera | nothing | 15:48 |
amotoki | none from me | 15:48 |
tmazur | nothing | 15:48 |
vishalmanchanda | Thanks everyone for your contributions! | 15:49 |
vishalmanchanda | will see you next week. | 15:49 |
vishalmanchanda | #endmeeting | 15:49 |
opendevmeet | Meeting ended Wed Jun 9 15:49:45 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:49 |
opendevmeet | Minutes: http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-06-09-15.00.html | 15:49 |
opendevmeet | Minutes (text): http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-06-09-15.00.txt | 15:49 |
opendevmeet | Log: http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-06-09-15.00.log.html | 15:49 |
*** jchorin has quit IRC | 15:54 | |
*** ikanias has left #openstack-horizon | 16:00 | |
*** rdopiera has quit IRC | 16:09 | |
*** e0ne_ has joined #openstack-horizon | 16:47 | |
*** e0ne has quit IRC | 16:47 | |
*** e0ne has joined #openstack-horizon | 16:52 | |
*** e0ne_ has quit IRC | 16:55 | |
*** e0ne_ has joined #openstack-horizon | 17:24 | |
*** e0ne has quit IRC | 17:29 | |
*** e0ne_ has quit IRC | 17:33 | |
*** ralonsoh has quit IRC | 17:34 | |
*** e0ne has joined #openstack-horizon | 17:34 | |
*** e0ne_ has joined #openstack-horizon | 17:36 | |
*** e0ne has quit IRC | 17:36 | |
*** whoami-rajat has quit IRC | 18:13 | |
*** vishalmanchanda has quit IRC | 19:55 | |
*** e0ne_ has quit IRC | 20:13 | |
*** tosky has quit IRC | 22:47 | |
*** whoami-rajat has joined #openstack-horizon | 22:58 | |
*** tmazur has quit IRC | 23:41 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!