| *** iury|holiday is now known as iurygregory | 05:53 | |
| *** whoami-rajat is now known as Guest89 | 09:05 | |
| *** whoami-rajat__ is now known as whoami-rajat | 09:05 | |
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Create QoS operation to Network QoS Panel https://review.opendev.org/c/openstack/horizon/+/799461 | 10:12 |
|---|---|---|
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Create QoS operation to Network QoS Panel https://review.opendev.org/c/openstack/horizon/+/799461 | 10:32 |
| nitish | how to run tests in horizon in devstack setup (*.spec.js) | 12:31 |
| vishalmanchanda | nitish: tox - e npm | 12:40 |
| nitish | thank you | 12:45 |
| nitish | I am working on developing network qos panel by adding CRUD operations | 12:46 |
| nitish | is it right place to discuss about it ? | 12:47 |
| vishalmanchanda | nitish: yes. | 12:50 |
| nitish | What are the expectations on the feature and what is the review process | 12:53 |
| nitish | I have made a base commit which enables the qos panel and added create qos policy operation | 12:53 |
| vishalmanchanda | nitish: please drop your queries here I am outside right now. | 12:55 |
| nitish | yeah sur ok | 12:55 |
| vishalmanchanda | If nobody responds to your queries I will reply soon | 12:56 |
| vishalmanchanda | Basic process is you need two +2 to get your patch merged. | 12:56 |
| vishalmanchanda | You have to add unit tests for your feature as well. | 12:57 |
| vishalmanchanda | You can also refer our documentation | 12:57 |
| nitish | ok, currently my commit is being reviewed by Akihiro Motoki | 12:57 |
| vishalmanchanda | Anyway drop your queries here I will reply soon | 12:58 |
| nitish | ok | 12:58 |
| gshippey | Will the weekly meeting be going on a bit later? I'm interested in discussing and getting some eyes on https://bugs.launchpad.net/horizon/+bug/1874705 and the related patch | 13:22 |
| vishalmanchanda | gshippey: hi, yes it is today at 15:00 UTC. Will see you there. | 13:28 |
| gshippey | 👍 | 13:29 |
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Create QoS operation to Network QoS Panel https://review.opendev.org/c/openstack/horizon/+/799461 | 13:44 |
| vishalmanchanda | #startmeeting horizon | 15:01 |
| opendevmeet | Meeting started Wed Jul 7 15:01:00 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:01 |
| vishalmanchanda | hi anyone around for horizon meeting? | 15:02 |
| -amotoki- lurks | 15:03 | |
| rdopiera | o/ | 15:03 |
| tmazur | o/ | 15:03 |
| vishalmanchanda | ok let's start. | 15:04 |
| gshippey | o/ | 15:04 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | Just an reminder Xena-2 milestone is next week. | 15:04 |
| vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:05 |
| vishalmanchanda | I have sent a mail about moving stable/queens to EOL on open-discuss ML last week. | 15:06 |
| vishalmanchanda | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023381.html | 15:06 |
| vishalmanchanda | I can see there is no open patches for stable/queens branch as of today. | 15:07 |
| vishalmanchanda | https://review.opendev.org/q/project:openstack/horizon%252Bbranch:stable/queens%252Bstatus:open | 15:07 |
| vishalmanchanda | So I have pushed a patch to release to move stable/queen to EOL. | 15:08 |
| vishalmanchanda | patch link https://review.opendev.org/c/openstack/releases/+/799543 | 15:08 |
| vishalmanchanda | last announcement is about next Virtual PTG. | 15:09 |
| vishalmanchanda | It will take place around October 18-22, 2021 | 15:09 |
| vishalmanchanda | Please see ML thread more info http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023370.html | 15:10 |
| vishalmanchanda | Does anyone have any other announcement, then please go ahead. | 15:11 |
| vishalmanchanda | ok I have no more specific topics to discuss. | 15:13 |
| vishalmanchanda | #topic open-discussion | 15:13 |
| vishalmanchanda | amotoki: rdopiera : Could we merge these open plugin patches to drop nodejs 10 https://review.opendev.org/q/topic:%22drop-nodejs10%22+(status:open%20OR%20status:merged) | 15:14 |
| ikanias | There is a bug: https://bugs.launchpad.net/horizon/+bug/1792028 | 15:14 |
| vishalmanchanda | I think we have waited enough for plugins teams. | 15:14 |
| ikanias | the bug hasn't been fixed and the solution was to skip 39 tests from the integration tests | 15:14 |
| ikanias | is this bug going to be fixed sometime? 39 tests skipped is more than 50 percent of the integration tests not running | 15:15 |
| amotoki | vishalmanchanda: it is up to you. Have you requested to merge them for example in the mailing list? | 15:15 |
| amotoki | vishalmanchanda: most horizon plugin teams just maintain horizon plugins as their side works along with their main repo | 15:16 |
| vishalmanchanda | amotoki: not yet. I will send a mail on open-discuss about it by this week. | 15:16 |
| vishalmanchanda | amotoki: thanks for suggestion. | 15:16 |
| amotoki | vishalmanchanda: I personally have no bandwidth to check plugin reviews. | 15:17 |
| vishalmanchanda | amotoki: ok np. | 15:17 |
| ikanias | anyone? | 15:18 |
| amotoki | two topics were raised in parallel. I think the topic on nodejs 10 from vishalmanchanda has been done. let's move on to the topic raised by ikanias | 15:19 |
| vishalmanchanda | ikanias: yeah it looks really bad, Let's try our best to fix those. | 15:19 |
| vishalmanchanda | skipped integration tests. | 15:20 |
| ikanias | it has not been fixed since 2018... | 15:20 |
| ikanias | at least the last comment is from that time | 15:21 |
| amotoki | at that time skipping the integration tests was reasonable to unblock the gate, but ...... no work has been done since then...... | 15:21 |
| ikanias | we miss a lot of tests... we can miss many bugs | 15:21 |
| vishalmanchanda | ikanias: +1. | 15:22 |
| amotoki | so, what is our next step? | 15:24 |
| vishalmanchanda | I personally write some integration tests for few pages but never pushed it to gerrit, will check if I still have those in my env. | 15:24 |
| amotoki | vishalmanchanda: any suggestion as PTL? | 15:25 |
| vishalmanchanda | I think next step should be fixing those skipped tests, I can help here. | 15:26 |
| amotoki | ikanias: can you work on fixing skipped tests with vishalmanchanda? | 15:27 |
| vishalmanchanda | I will check after the meeting how many such test are skipped an open a new high priority bug for it. | 15:27 |
| vishalmanchanda | and* | 15:27 |
| ikanias | amotoki: yes i can try | 15:27 |
| amotoki | ikanias: thanks | 15:27 |
| vishalmanchanda | ikanias: thanks for bringing this topic:) | 15:27 |
| ikanias | but currently these tests are a bit complicated for me to understand...i would like if someone could go over them with me... just saw them last week for the first time | 15:28 |
| ikanias | vishalmanchanda: np | 15:29 |
| vishalmanchanda | rdopiera: Do you have any update on django sass processor patch https://review.opendev.org/c/openstack/horizon/+/794809 | 15:30 |
| rdopiera | vishalmanchanda: no, I haven't done anything since then | 15:31 |
| vishalmanchanda | rdopiera: ok | 15:32 |
| rdopiera | if we want to go ahead with that plugin, I believe there were two issues remaining with it | 15:32 |
| rdopiera | the material theme problem, and a way for people to inject their own css | 15:33 |
| vishalmanchanda | but If I remember correctly Ivan and amotoki have some workaround for material theme issue atleast. | 15:34 |
| rdopiera | yes, and we can simply @import a user's scss file | 15:35 |
| amotoki | vishalmanchanda: I think it is a differnt issue. | 15:35 |
| amotoki | I am not sure what kind of differences we hit when we switch the sass processor though. | 15:36 |
| rdopiera | there are going to be differences for sure | 15:37 |
| rdopiera | I didn't go through all views to see if they render correctly | 15:37 |
| vishalmanchanda | maybe integration tests can check that. | 15:38 |
| rdopiera | no, they don't care about the looks | 15:38 |
| rdopiera | they only look at the html | 15:39 |
| rdopiera | (well, unless something overlaps something) | 15:39 |
| vishalmanchanda | ohh yeah.. | 15:39 |
| vishalmanchanda | Do we have any other topic to discuss or we can end this meeting? | 15:41 |
| rdopiera | this is one reason why if we want to switch, it would be better to do it at the beginning of the cycle, so we have more time to catch bugs | 15:41 |
| rdopiera | I don't have anything more | 15:41 |
| gshippey | id like to discuss https://bugs.launchpad.net/horizon/+bug/1874705 | 15:41 |
| vishalmanchanda | gshippey: please go ahead. | 15:42 |
| gshippey | If i were to change the fix patch to use the referrer as a backup would that make people happy | 15:42 |
| gshippey | in case the openstack keystone url is not defined | 15:42 |
| vishalmanchanda | patch link https://review.opendev.org/c/openstack/horizon/+/722685 | 15:43 |
| vishalmanchanda | gshippey: Honestly I have never used websso. | 15:46 |
| vishalmanchanda | So give me some time to understand the issue or reproduce it. | 15:46 |
| amotoki | the only reason we did not have a good progress is the current horizon reviewers have no good experience/kwowledge on websso implementations..... | 15:46 |
| amotoki | I wonder how we can move it forward.... | 15:47 |
| amotoki | keystone team might help it. they may have more knowledge than us. | 15:48 |
| vishalmanchanda | amotoki: hmm I have added the keystone team in the launchpad bug Let's see if they respod. | 15:51 |
| gshippey | Well if perhaps you'd like to have ago at recreating it and I can check in in another week or two? Otherwise I think I will make changes to make it dropback to the referrer if openstack keystone url is not defined and try get some keystone reviewers eyes on it too | 15:51 |
| vishalmanchanda | respond* | 15:51 |
| gshippey | great | 15:51 |
| rdopiera | keystone url has to be defined for horizon to work... | 15:53 |
| rdopiera | I wonder, you don't want the controller node to have access to something that is otherwise publicly accessible? Why? Does it really improve security? | 15:54 |
| amotoki | rdopiera: good point | 15:55 |
| amotoki | the description of https://bugs.launchpad.net/horizon/+bug/1874705 explains the context more. | 15:56 |
| rdopiera | I think that using the referer address may actually be a phishing protection mechanism | 15:56 |
| rdopiera | making sure you talk with the page that the user entered the password in | 15:57 |
| rdopiera | "Our Openstack services have minimal external connectivity for security reasons." is not really an explanation | 15:57 |
| jrosser | in these deployments the internal networks dont route to anywhere | 15:58 |
| jrosser | thats a deployer choice | 15:58 |
| jrosser | and requests from the end user enter via a well defined loadbalancer / SSL terminator which is the only point that has external connectivity | 15:59 |
| rdopiera | how about we used the internal endpoint always, but had an additional check in there that the referrer matches the referrer defined in the config? | 16:00 |
| rdopiera | we would add a config option for the expected referrer | 16:01 |
| vishalmanchanda | sorry to interrupt I am just ending the meeting | 16:01 |
| gshippey | would that be the WEBSSO_KEYSTONE_URL? | 16:01 |
| vishalmanchanda | #endmeeting | 16:01 |
| opendevmeet | Meeting ended Wed Jul 7 16:01:37 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-07-15.01.html | 16:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-07-15.01.txt | 16:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-07-07-15.01.log.html | 16:01 |
| amotoki | note that we can continue the discussion here | 16:01 |
| rdopiera | what I am really most afraid of is that there is some sso provider out there that uses the referrer address different than what you originally called and then expects a response on that address | 16:02 |
| jrosser | we are really looking here at the url that horizon itself uses to contact keystone | 16:04 |
| jrosser | that is the thing which ends up being the external url and therefore not working | 16:04 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!