| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 04:53 |
|---|---|---|
| *** iurygregory_ is now known as iurygregory | 12:07 | |
| amotoki | rosmaita: does the released version of cinderclient provide a way that horizon can support cinder v3 only (as your horizon patch does)? | 12:42 |
| amotoki | rosmaita: looking at the failure, the only failure happens around QuotaSet and it leads to all test failures. | 12:47 |
| rosmaita | amotoki: sorry, was not paying attention | 13:01 |
| rosmaita | amotoki: i don't think so, but let me try something | 13:02 |
| amotoki | rosmaita: no problem, thanks. | 13:04 |
| rosmaita | in the meantime, i did get my horizon patch (the latest patch set) to pass unit tests and selenium-headless locally (i replaced 'cinderclient' in the tox virtualenv in site-packages with a symlink to my cinderclient git repo) | 13:04 |
| rosmaita | i don't know how to run the integration tests locally, though, they are all failing | 13:05 |
| rosmaita | amotoki: i think we (cinder project) will need to do an emergency release of cinderclient that contains cinderclient.v3.quotas.QuotaSet class | 13:13 |
| rosmaita | amotoki: i think this is what we need: https://review.opendev.org/c/openstack/python-cinderclient/+/800945 | 13:19 |
| amotoki | rosmaita: I believe your change is the right way. or you can add some fallback logic in test_data/cinder_data in horizon test if another release take time. | 13:24 |
| rosmaita | amotoki: if your team is OK with fallback logic, that may be a lot faster | 13:25 |
| amotoki | rosmaita: I am okay with it | 13:25 |
| rosmaita | ok, let me revise the patch real quick | 13:26 |
| amotoki | rosmaita: as I see QuotaSet is defined in the cinderclient patch to removes v2 support | 13:26 |
| rosmaita | amotoki: good point, i will make sure that is documented in the commit message | 13:35 |
| rosmaita | amotoki: looks like there is at least one more "missing" v3 class, and likely to be one or two more ... working on that now | 13:59 |
| amotoki | rosmaita: it is around 11pm in my side. I can check the patch tomorrow soon. | 14:08 |
| rosmaita | amotoki: ok, have a good evening! thanks for your help | 14:15 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 14:16 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 14:47 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 15:03 |
| opendevreview | Brian Rosmaita proposed openstack/horizon master: Use cinderclient v3 classes https://review.opendev.org/c/openstack/horizon/+/800814 | 15:19 |
| rosmaita | it's finally passing pep8 ^^ !!! | 15:36 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!