| opendevreview | Takashi Kajinami proposed openstack/horizon master: Remove usage of cinderclient.v2 https://review.opendev.org/c/openstack/horizon/+/802419 | 02:06 |
|---|---|---|
| opendevreview | Gage Hugo proposed openstack/horizon master: Add horizontal scrollbar to role dropdown https://review.opendev.org/c/openstack/horizon/+/789606 | 02:50 |
| opendevreview | Takashi Kajinami proposed openstack/horizon master: Remove usage of cinderclient.v2 https://review.opendev.org/c/openstack/horizon/+/802419 | 04:16 |
| amotoki | vishalmanchanda: is it okay for you to cut a new release of horizon? manila-ui CI is broken due to a missing horizon release after volume v2 API removal. | 05:38 |
| amotoki | vishalmanchanda: you can find it in a non-voting manila-ui job in horizon | 05:39 |
| vishalmanchanda | amotoki: yeah, I noticed. | 05:41 |
| vishalmanchanda | amotoki: I will cut a new release once https://review.opendev.org/c/openstack/horizon/+/802419 is merged. | 05:41 |
| vishalmanchanda | amotoki: or you want to me to cut a release now? | 05:45 |
| amotoki | vishalmanchanda: i can | 05:46 |
| opendevreview | Takashi Kajinami proposed openstack/horizon master: Remove usage of cinderclient.v2 https://review.opendev.org/c/openstack/horizon/+/802419 | 05:47 |
| vishalmanchanda | amotoki: thanks, go ahead. | 06:17 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Clean up the workaround of cinderclient v2->v3 transition https://review.opendev.org/c/openstack/horizon/+/802419 | 06:18 |
| amotoki | vishalmanchanda: during you were writing a comment I was updating the commit message. Does the new version work for you? | 06:23 |
| vishalmanchanda | amotoki: works for me. | 06:24 |
| vishalmanchanda | amotoki: thanks:) | 06:24 |
| opendevreview | Akihiro Motoki proposed openstack/horizon master: Clean up the workaround of cinderclient v2->v3 transition https://review.opendev.org/c/openstack/horizon/+/802419 | 07:09 |
| vishalmanchanda | amotoki: I have pushed the patch to cut a new release https://review.opendev.org/c/openstack/releases/+/802446 | 09:55 |
| vishalmanchanda | amotoki: please take a look once you are around. | 09:56 |
| opendevreview | Vadym Markov proposed openstack/horizon master: Add POST/Redirect/GET for Domains dashboard https://review.opendev.org/c/openstack/horizon/+/802328 | 10:13 |
| amotoki | vishalmanchanda: I am already preparing it and waiting for the release.... duplicated work ah...... | 10:13 |
| amotoki | vishalmanchanda: btw why no major version bump? | 10:13 |
| vishalmanchanda | amotoki: ah I thought you forgot:( | 10:14 |
| vishalmanchanda | amotoki: major version you mean I should use 20.0.0 ? | 10:14 |
| amotoki | vishalmanchanda: I see your comment of "gate blocker" in https://review.opendev.org/c/openstack/horizon/+/802419 ? I don't see a breakage that this commit fixes. COuld you share an example of the breakage. | 10:15 |
| amotoki | vishalmanchanda: we cannot prepare a release commit unless all required aree merged. I wonder you can see the future :) | 10:16 |
| amotoki | vishalmanchanda: yes, the new version should be 20.0.0 as we dropped a feature. | 10:16 |
| amotoki | vishalmanchanda: re: gate breakage, if you mean cinderclient dependency, https://review.opendev.org/c/openstack/horizon/+/802419 does nothing. | 10:17 |
| vishalmanchanda | amotoki: when I post that comment, manila-ui breakage in my mind, yes but my comment was not appropriate, please ignore. | 10:20 |
| opendevreview | Merged openstack/horizon master: Clean up the workaround of cinderclient v2->v3 transition https://review.opendev.org/c/openstack/horizon/+/802419 | 10:21 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!