| opendevreview | Merged openstack/horizon master: Support Django 3.0 and 3.1 support (2) https://review.opendev.org/c/openstack/horizon/+/777393 | 05:19 |
|---|---|---|
| vishalmanchanda | amotoki: hi, around? | 05:56 |
| amotoki | vishalmanchanda: hi | 05:57 |
| vishalmanchanda | amotoki: I have a query on this patch https://review.opendev.org/c/openstack/horizon/+/777396 . Could you take a look? | 05:58 |
| amotoki | vishalmanchanda: Do you mean Django version 3.2b1? | 05:59 |
| amotoki | vishalmanchanda: I can if you don't mind rebasing the whole series. | 05:59 |
| vishalmanchanda | amotoki: yes, Could we change it to 3.2 | 06:00 |
| amotoki | vishalmanchanda: I am personally okay with either. | 06:00 |
| amotoki | vishalmanchanda: note that my django 3.x patch series is just to pass UT. I have never tested it in real env. | 06:01 |
| vishalmanchanda | amotoki: Yeah I am testing patch in my env. as well, Also I hope integration job passing means we are good here. | 06:03 |
| vishalmanchanda | amotoki: What's your thought on https://review.opendev.org/c/openstack/horizon/+/777391/2 | 06:04 |
| amotoki | vishalmanchanda: do you run the integartion tests with Django 3.2 locally? | 06:04 |
| amotoki | vishalmanchanda: it is up to the team. | 06:04 |
| vishalmanchanda | amotoki: No It take too much time as my server is slow and less h/w configuration. I am relying on Zuul for integration test. | 06:06 |
| vishalmanchanda | amotoki: Should we merged https://review.opendev.org/c/openstack/horizon/+/777391/2 for now, if yes then could you please remove your -2 ? | 06:07 |
| amotoki | vishalmanchanda: so do you add the integration tests with Dango 3.2? | 06:07 |
| opendevreview | Merged openstack/horizon master: Support Django 3.0 and 3.1 support (3) https://review.opendev.org/c/openstack/horizon/+/777394 | 06:08 |
| vishalmanchanda | amotoki: Sorry I didn't get your point, integration jobs are running for django 3.2 as I can see in this patch https://review.opendev.org/c/openstack/horizon/+/777399/2 | 06:11 |
| amotoki | vishalmanchanda: In my understanding, horizon in the integration tests is isntalled via devstack following upper-constraints.txt | 06:14 |
| amotoki | vishalmanchanda: so I guess the integration tests job uses django 2.2 | 06:14 |
| amotoki | vishalmanchanda: I think only horizon-tox-python3-django3* jobs run with Django 3.x | 06:15 |
| vishalmanchanda | amotoki: Ohh I don't know about that:( | 06:18 |
| vishalmanchanda | amotoki: looking for file in devstack to run integration job with django 3.x. | 06:18 |
| vishalmanchanda | amotoki: Also, running integration with django3.2 in my local env. | 06:20 |
| amotoki | vishalmanchanda: I removed my -2 on https://review.opendev.org/c/openstack/horizon/+/777391/ so that the team can decide it. | 06:43 |
| vishalmanchanda | amotoki: ok thanks. | 06:50 |
| amotoki | vishalmanchanda: is it okay to replace Django 3.2b to 3.2? perhaps it is better to update tox.ini too | 07:02 |
| vishalmanchanda | amotoki: IMO we should use 3.2, and good to update in tox.ini too. | 07:06 |
| amotoki | vishalmanchanda: ok | 07:20 |
| amotoki | vishalmanchanda: looking at https://review.opendev.org/c/openstack/horizon/+/777395/, dj30 and dj31 jobs fail. It is not what I expect. | 07:23 |
| amotoki | vishalmanchanda: this should pass dj30 and dj31 tests as it is the last patch to support dj30/31 | 07:23 |
| amotoki | vishalmanchanda: ah... it is due to django-pyscss and we haven't merged the workaround. got it. | 07:25 |
| vishalmanchanda | amotoki: yes. | 07:25 |
| vishalmanchanda | amotoki: I need some help in running integration test with django3.x on gate. | 07:26 |
| vishalmanchanda | amotoki: I have to update django version here https://github.com/openstack/requirements/blob/7d440eb91773aa8a9f455a3f7c69db780e926679/upper-constraints.txt#L432 | 07:27 |
| amotoki | vishalmanchanda: perhaps you can propose DNM patch to requiremeents.txt to update Django version and propose a horizon patch which depends on the reqs patch | 07:28 |
| amotoki | vishalmanchanda: this is what we usually do when testing a new version of our dependencies. | 07:28 |
| vishalmanchanda | amotoki: ok thanks. | 07:28 |
| vishalmanchanda | amotoki: because if integration jobs fail with django3.2 then we would not merge further patches | 07:29 |
| amotoki | vishalmanchanda: I am okay with either. merging django 3.2 patches has no side effect from Django 2.2 perspective. we can fix issues with Dango 3.2 later separately. | 07:30 |
| vishalmanchanda | amotoki: right now when I apply this patch https://review.opendev.org/c/openstack/horizon/+/777399/2 in my env. I am not able to launch the instance although doesn't giving any error. | 07:31 |
| vishalmanchanda | amotoki: also I observe some issue with pop-up form/widgets. | 07:33 |
| amotoki | vishalmanchanda: in which commit? | 07:33 |
| vishalmanchanda | amotoki: I have applied this patch https://review.opendev.org/c/openstack/horizon/+/777399/2 in my env. | 07:34 |
| amotoki | vishalmanchanda: is it a regression in horizon with Django 2.2 or just an issue with Django 3.2? | 07:34 |
| vishalmanchanda | amotoki: yeah. | 07:36 |
| amotoki | vishalmanchanda: ??? | 07:36 |
| vishalmanchanda | amotoki: I am not sure right now because I can't see any error msg or maybe it's my env. issue. | 07:38 |
| amotoki | vishalmanchanda: does it affect Django 2.2 env? | 07:41 |
| vishalmanchanda | amotoki: I don't think so because if that's the case then integration job must failed for that patch. | 07:44 |
| vishalmanchanda | amotoki: but not completely sure maybe I am wrong. | 07:44 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: [DNM] Test Django 3.2 version with requirement repo https://review.opendev.org/c/openstack/horizon/+/809163 | 09:33 |
| opendevreview | Nitish Venkata Patcherla proposed openstack/horizon master: Add Rules operation to Network QoS Policy https://review.opendev.org/c/openstack/horizon/+/805360 | 13:16 |
| nicolasbock | Hi! This may be a known issue. I found that the time complexity of opening the project/instances/attach_interface dialog box is O(N) where N is the number of networks in the project | 14:02 |
| nicolasbock | I opened https://bugs.launchpad.net/horizon/+bug/1943639 | 14:02 |
| nicolasbock | The reason for this behavior is that the dashboard requests all ports per network in a loop over the networks | 14:03 |
| nicolasbock | It checks whether any ports exist that don't have a `device_owner` | 14:03 |
| nicolasbock | Is this a known issue? | 14:04 |
| vishalmanchanda | nicolasbock: thanks for reporting the bug, will take a look soon. | 14:05 |
| nicolasbock | Thanks vishalmanchanda | 14:05 |
| nicolasbock | Right now I don't quite see how to speed this up | 14:05 |
| nicolasbock | Something like `openstack port list --column id --column device_owner` does not work | 14:06 |
| nicolasbock | The `device_owner` seems to be returned only on `openstack port show` | 14:06 |
| opendevreview | jinyuanliu proposed openstack/horizon master: Clean up extra spaces https://review.opendev.org/c/openstack/horizon/+/809199 | 14:21 |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Sep 15 15:00:20 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hello everyone. | 15:00 |
| ganso | o/ | 15:01 |
| tmazur | o/ | 15:01 |
| vishalmanchanda | rdopiera: amotoki : e0ne: around? | 15:02 |
| vishalmanchanda | Let's wait for two more minutes then we will start. | 15:03 |
| vishalmanchanda | ok let's start. I hope more people join us. | 15:05 |
| vishalmanchanda | #topic Notices | 15:06 |
| vishalmanchanda | This week is Xena RC1 week. | 15:06 |
| vishalmanchanda | Xena Schedule https://releases.openstack.org/xena/schedule.html | 15:06 |
| vishalmanchanda | horizon follows cycle-with-intermediary release model. So probably release team will cut a release for horizon by Monday. | 15:06 |
| vishalmanchanda | Also, Please start adding your topic in etherpad which you would like to discuss during PTG. | 15:07 |
| vishalmanchanda | etherpad link https://etherpad.opendev.org/p/horizon-yoga-ptg | 15:08 |
| vishalmanchanda | That's all announcement from my side for this week. | 15:08 |
| vishalmanchanda | moving to next topic | 15:08 |
| vishalmanchanda | #topic Django3.x Support | 15:09 |
| vishalmanchanda | As you may have noticed we have merged a couple of patches from yesterday to add Django3.x support. | 15:09 |
| vishalmanchanda | https://review.opendev.org/q/topic:%22django3-support%22+(status:open%20OR%20status:merged) | 15:09 |
| vishalmanchanda | Now my question is to team that we want to add Django3.x support in Xena release or not? | 15:10 |
| vishalmanchanda | Are we too late for that? | 15:10 |
| tmazur | It seems so | 15:11 |
| vishalmanchanda | Also zigo on open-discuss send a mail that Horizon Wallaby and Xena completely broken in Debian as horizon doesn't support Dajngo3.x | 15:11 |
| vishalmanchanda | http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024873.html | 15:11 |
| vishalmanchanda | Personally I am ok to merge django series patches as they are trivial changes and doesn't affect current implementation but I would like hear team feedback for the same. | 15:13 |
| rdopiera | sorry for being late | 15:14 |
| rdopiera | I concur to the the django patches | 15:14 |
| vishalmanchanda | amotoki: e0ne: rdopiera : Please share your opinion. | 15:14 |
| amotoki | I can say that changes made in my patch series are straight-forward fixes and believe they are safe. | 15:15 |
| amotoki | one question to the team is whether the dirty workaround is acceptable. | 15:15 |
| vishalmanchanda | amotoki: yeah coming to that, I am okay to merge https://review.opendev.org/c/openstack/horizon/+/777391 workaround for now. | 15:16 |
| vishalmanchanda | amotoki: We can improve it in Yoga release. | 15:16 |
| amotoki | note that https://review.opendev.org/c/openstack/horizon/+/777391 must be updated. | 15:17 |
| amotoki | we must add django version check as I commented in the change. | 15:17 |
| amotoki | perhaps we also need to add "six" in requirements.txt again | 15:18 |
| vishalmanchanda | amotoki: Could you update that patch https://review.opendev.org/c/openstack/horizon/+/777391 | 15:21 |
| amotoki | will do tomorrow. feel free to update it if you want sooner than it | 15:21 |
| vishalmanchanda | amotoki: ok, thanks. | 15:22 |
| vishalmanchanda | Does anyone have any issue in accepting that workaround? | 15:23 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/777391 | 15:23 |
| rdopiera | no | 15:26 |
| vishalmanchanda | rdopiera: ok thanks. | 15:27 |
| vishalmanchanda | that's all update from my side for this week. | 15:28 |
| vishalmanchanda | #topic open-discussion | 15:28 |
| ganso | o. | 15:29 |
| ganso | *o/ | 15:29 |
| vishalmanchanda | We have some open patches which are good to have in Xena, So please take look | 15:29 |
| vishalmanchanda | https://etherpad.opendev.org/p/horizon-release-priorities(at line 20) | 15:29 |
| vishalmanchanda | ganso: Do you want to discuss any topic? | 15:30 |
| ganso | Just a reminder about patch https://review.opendev.org/c/openstack/horizon/+/806454 | 15:30 |
| ganso | I know everyone is busy and it is not a priority for Xena, but if you have some time and can take a look | 15:30 |
| ganso | it is a WIP, and quite drastric so I'd like feedback so I can continue working on it, so I don't have to rework so many unit tests around the code changes | 15:31 |
| ganso | I know amotoki is the most familiar with it and it is already in his review queue, but any feedback is welcome if you have time to review | 15:32 |
| ganso | that's all I had | 15:32 |
| vishalmanchanda | ganso: thanks for the patch, will take a look soon once done with Django3.x support. | 15:32 |
| ganso | vishalmanchanda: thanks | 15:33 |
| rdopiera | I would like to discuss the memcached library that we use by default in Horizon. | 15:33 |
| amotoki | ganso: yeah, it is in my queue. I was on vacation last week. sorry for late. | 15:33 |
| ganso | amotoki: no worries. I was just reminding =) | 15:35 |
| vishalmanchanda | rdopiera suggest to use pylibmc https://pypi.org/project/pylibmc/ for memcached | 15:38 |
| rdopiera | pymemcached is somewhat abandoned, and has issues with handling ipv6 addresses -- I think that it would be prudent for us to switch to a newer library. Django 3.0 gives us a bunch of options, but for Django 2.2 the only alternative that is supported is pymclib. The change would amount to adding pymclib to our requirements and modifying the example config file. | 15:38 |
| rdopiera | relevant Django documentation is https://docs.djangoproject.com/en/2.2/topics/cache/#memcached | 15:39 |
| amotoki | Looking at DJnago 3.2 documentaiton. these two are still the only supported bindings https://docs.djangoproject.com/en/3.2/topics/cache/ | 15:41 |
| rdopiera | I must have remembered incorrectly that there were more, sorry. | 15:41 |
| amotoki | I am okay with this change, but when do you plan to switch it? | 15:41 |
| rdopiera | the last commit for pymemcached was 5 years ago | 15:41 |
| amotoki | the requirement freeze happened a couple of weeks ago | 15:41 |
| rdopiera | the last commit for pymclib was last month | 15:41 |
| rdopiera | yes, this would be for the new release | 15:42 |
| rdopiera | for Yoga | 15:42 |
| amotoki | sounds good | 15:42 |
| vishalmanchanda | I am fine with switching from pymemcached is no longer maintained also have issues | 15:42 |
| vishalmanchanda | One of the bug rdopiera mentioned yesterday with pymemcached. | 15:42 |
| opendevreview | Nicolas Bock proposed openstack/horizon master: Get ports directly instead of via loop https://review.opendev.org/c/openstack/horizon/+/809230 | 15:43 |
| amotoki | this is just our default settings. packagers and deployers can consume pylibmc already, so it would be less-impact. | 15:43 |
| vishalmanchanda | https://bugzilla.redhat.com/show_bug.cgi?id=2002659 | 15:43 |
| rdopiera | well, this is also a configuration with which we test | 15:43 |
| rdopiera | in practice, our users will just copy the example config | 15:44 |
| vishalmanchanda | Ok then we can try it in early Yoga cycle. | 15:45 |
| vishalmanchanda | Do we have anything else to discuss? | 15:47 |
| rdopiera | I don't | 15:48 |
| amotoki | none from me | 15:48 |
| tmazur | nothing | 15:48 |
| vishalmanchanda | Ok let's end the meeting. | 15:48 |
| vishalmanchanda | thanks everyone for joining. | 15:48 |
| vishalmanchanda | #endmeeting | 15:49 |
| opendevmeet | Meeting ended Wed Sep 15 15:49:04 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-15-15.00.html | 15:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-15-15.00.txt | 15:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-09-15-15.00.log.html | 15:49 |
| opendevreview | Nicolas Bock proposed openstack/horizon master: Get ports directly instead of via loop https://review.opendev.org/c/openstack/horizon/+/809230 | 15:54 |
| nicolasbock | vishalmanchanda: Please have a look at https://review.opendev.org/c/openstack/horizon/+/809230 | 15:57 |
| nicolasbock | vishalmanchanda: In my local tests this implementation significantly speeds up the `attach_interface` workflow | 15:57 |
| opendevreview | Merged openstack/horizon master: Support Django 3.0 and 3.1 support (4) https://review.opendev.org/c/openstack/horizon/+/777395 | 17:59 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Support Django 3.2 support (1) https://review.opendev.org/c/openstack/horizon/+/777397 | 18:15 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Preparation for Django 3.0 and 3.1 support (2) https://review.opendev.org/c/openstack/horizon/+/777391 | 19:18 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Support Django 3.2 support (3) https://review.opendev.org/c/openstack/horizon/+/777399 | 19:38 |
| opendevreview | Merged openstack/horizon master: Support Django 3.2 support (1) https://review.opendev.org/c/openstack/horizon/+/777397 | 21:04 |
| opendevreview | Vishal Manchanda proposed openstack/horizon master: Preparation for Django 3.0 and 3.1 support (2) https://review.opendev.org/c/openstack/horizon/+/777391 | 21:15 |
| *** prometheanfire is now known as Guest1 | 21:20 | |
| *** kmasterson is now known as Guest6 | 21:21 | |
| *** promethe- is now known as prometheanfire | 21:53 | |
| opendevreview | Merged openstack/horizon master: Support Django 3.2 support (3) https://review.opendev.org/c/openstack/horizon/+/777399 | 22:16 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!