| opendevreview | Vishal Manchanda proposed openstack/horizon master: Updating python testing as per Yoga testing runtime https://review.opendev.org/c/openstack/horizon/+/821800 | 07:39 |
|---|---|---|
| *** tkajinam is now known as Guest8517 | 11:58 | |
| *** whoami-rajat__ is now known as whoami-rajat | 14:00 | |
| *** simondodsley_ is now known as simondodsley | 14:58 | |
| *** mnaser_ is now known as mnaser | 14:58 | |
| *** manpreetk_ is now known as manpreetk | 15:00 | |
| *** johnsom_ is now known as johnsom | 15:00 | |
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Dec 15 15:00:25 2021 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| *** viks___ is now known as viks__ | 15:00 | |
| vishalmanchanda | hi anyone around for horizon meeting? | 15:00 |
| rdopiera | o/ | 15:00 |
| amotoki | hi (but not feeling good :( ) | 15:01 |
| ganso | o/ | 15:01 |
| vishalmanchanda | e0ne: ping | 15:01 |
| rdopiera | amotoki: hope you will get well soon! | 15:02 |
| e0ne | hi | 15:02 |
| vishalmanchanda | Let's start the meeting. | 15:02 |
| tmazur | o/ | 15:02 |
| vishalmanchanda | #topic Notices | 15:02 |
| vishalmanchanda | few announcement from my side | 15:02 |
| vishalmanchanda | As usual Yoga Schedule reminder https://releases.openstack.org/yoga/schedule.html | 15:02 |
| vishalmanchanda | This week is R-15. | 15:03 |
| vishalmanchanda | Next announcement is about python runtime testing for Yoga cycle. | 15:03 |
| vishalmanchanda | Python runtime for Yoga can be found here https://governance.openstack.org/tc/reference/runtimes/yoga.html#python-runtimes-for-yoga | 15:04 |
| vishalmanchanda | I have already pushed a patch to update the reference in horizon https://review.opendev.org/c/openstack/horizon/+/821800 | 15:04 |
| vishalmanchanda | Please take a look. | 15:04 |
| vishalmanchanda | Next announcement is about adding review-priority check in horizon gerrit dashboard. | 15:05 |
| vishalmanchanda | I was thinking if we can add review priority check for horizon in gerrit, so patches with high priority get some attention. | 15:06 |
| vishalmanchanda | further, we monitor those in our weekly meeting if any priority patches need attention like this dashboard | 15:06 |
| vishalmanchanda | https://review.opendev.org/q/label:Review-Priority%253D%252B2+status:open+(project:openstack/cinder) | 15:07 |
| e0ne | +1. it's a good thing to have | 15:07 |
| amotoki | vishalmanchanda: do you plan to update the horizon config in gerrit-dash-creator? | 15:07 |
| amotoki | I am okay with either as I have the similar one in neutron and other projects as e0ne mentioned. | 15:08 |
| amotoki | my question is how the flag is handled. | 15:08 |
| vishalmanchanda | amotoki: no I will add in project config like this one https://review.opendev.org/c/openstack/project-config/+/739550 | 15:08 |
| amotoki | project-config defines the flag. it is a provider side. | 15:09 |
| vishalmanchanda | ok If no objections here I'll add the review priority for the horizon in gerrit. | 15:10 |
| -amotoki- hopes my gerrit dashboard config picks up such :) | 15:11 | |
| vishalmanchanda | amotoki: you mean I have to update the horizon config in gerrit-dash-creator as well? | 15:11 |
| amotoki | vishalmanchanda: it is up to you. it is optional. | 15:11 |
| vishalmanchanda | amotoki: that I will check. | 15:11 |
| vishalmanchanda | ok moving to next announcemnet | 15:11 |
| vishalmanchanda | I am on vacation next week till Thursday(23rd Dec.), So I'll not be able to chair the next meeting(22nd December) | 15:12 |
| vishalmanchanda | on 29th December week, I guess it is the holiday for all of us, So I was thinking if we can Cancel next two meetings. | 15:13 |
| e0ne | +1 | 15:13 |
| amotoki | sounds good | 15:14 |
| vishalmanchanda | ok, then our Next Weekly meeting will be on 5th January 2022. | 15:14 |
| vishalmanchanda | I will be around for any discussion after 23rd December, so feel free to reach me in case of any help. | 15:16 |
| vishalmanchanda | moving to next topic | 15:16 |
| vishalmanchanda | #topic release priorties | 15:16 |
| vishalmanchanda | No update from my side on this topic. | 15:16 |
| vishalmanchanda | Patches are up for few priorities items, please review them asap. | 15:17 |
| vishalmanchanda | Most of the patches already have one +2. | 15:17 |
| vishalmanchanda | dropping the patches link here https://review.opendev.org/c/openstack/horizon/+/816368 | 15:17 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/817814 , https://review.opendev.org/c/openstack/horizon/+/816303 | 15:18 |
| vishalmanchanda | rdopiera: would you like to add anything regarding System Scope topic? | 15:19 |
| rdopiera | vishalmanchanda: I don't have anything to add at this moment. I have to talk to the developers from Nova and other projects to figure out what should exactly be visible and work in the system scope, and what shouldn't. | 15:20 |
| rdopiera | because currently half of the admin tab doesn't work | 15:20 |
| rdopiera | and I don't know if that is a bug, a work in progress, or expected | 15:20 |
| vishalmanchanda | rdopiera: hmm we can discuss this with policy-popup team, I guess. | 15:21 |
| rdopiera | vishalmanchanda: do you have a link to that? | 15:22 |
| vishalmanchanda | rdopiera: Now we have your initial patch which at least adds the menu. | 15:22 |
| amotoki | I think I can check it during next week. at least I can check it from neutron perspective. | 15:23 |
| vishalmanchanda | rdopiera: no I don't have a link now, but I will check and drop a link here for you. | 15:24 |
| rdopiera | vishalmanchanda: thanks a lot! | 15:24 |
| vishalmanchanda | rdopiera: yw. | 15:24 |
| rdopiera | I missed it when it was announced | 15:24 |
| vishalmanchanda | moving to next topic | 15:24 |
| vishalmanchanda | #topic Bug deputy report | 15:25 |
| vishalmanchanda | We have one new bug reported for this week https://bugs.launchpad.net/horizon/+bug/1954619 | 15:25 |
| vishalmanchanda | amotoki: I also added some comments for this bug, please take a look. | 15:26 |
| amotoki | vishalmanchanda: where do we define the default device name in Angular impl? I am not sure. | 15:26 |
| vishalmanchanda | amotoki: honestly I haven't check the code for angular impl yet but I have tested it in my devstack env. | 15:28 |
| amotoki | vishalmanchanda: so, do you confirm that horizon sends 'vda' to nova API? | 15:29 |
| vishalmanchanda | I see the same result with both implementations. | 15:29 |
| vishalmanchanda | amotoki: that I will check again after the meeting. | 15:30 |
| amotoki | yeah, let's double check anyway :) | 15:30 |
| vishalmanchanda | ok. | 15:31 |
| vishalmanchanda | moving to next topic | 15:31 |
| vishalmanchanda | #topic On-Demand Agenda | 15:31 |
| vishalmanchanda | staring with first topic i.e. Horizon pain-point-elimination discussion | 15:32 |
| vishalmanchanda | So there is video call meeting regarding the pain point discussion on Wednesday last week | 15:33 |
| vishalmanchanda | Summary can be found here http://lists.openstack.org/pipermail/openstack-discuss/2021-December/026169.html | 15:33 |
| vishalmanchanda | I and amotoki also joined that meeting. | 15:34 |
| vishalmanchanda | Pain Point for horizon can be found here https://etherpad.opendev.org/p/pain-point-elimination (at line 214) | 15:34 |
| vishalmanchanda | So Can everyone please go through the list of pain point related to horizon. | 15:35 |
| vishalmanchanda | We need to check if that's valid a issue and it's a new feature request or a bug which horizon team already know and add the link for that bug/feature. | 15:36 |
| vishalmanchanda | You can use FEATURE REQUEST/DISCUSSION NEEDED/FIX NEEDED/INFO NEEDED tags. | 15:36 |
| vishalmanchanda | If you find need more information about that issue/pain-point then use INFO NEEDED tag and ask for more information. | 15:37 |
| vishalmanchanda | like amotoki did at line 232. | 15:37 |
| vishalmanchanda | Right now I am not sure about the all issue/pain point but if you know anyone of those please add your comment and then we discuss it further and also if we not have any volunteer who can work on those issue that can be discussed later. | 15:40 |
| rdopiera | speaking of pain points, I want to get rid of all the django template and deprecation warnings we have accumulated | 15:41 |
| vishalmanchanda | like for glance issue at line 218 I know there is already a similar bug in horizon | 15:41 |
| vishalmanchanda | https://bugs.launchpad.net/horizon/+bug/1935001 | 15:41 |
| rdopiera | the amount of them we have now is ridiculous and it's hard to find the error messages between them | 15:41 |
| vishalmanchanda | rdopiera: make sense, I use development server method for development and see lot of error/deprecation messages. | 15:43 |
| vishalmanchanda | amotoki: Did I missed anything from that meeting that you would like to add here? | 15:44 |
| amotoki | vishalmanchanda: nothing special to add. some have been fixed and some are not. some are not clear. | 15:45 |
| amotoki | I havent' checked one by one though | 15:46 |
| vishalmanchanda | Ok Please everyone go through that list and add your thoughts about that issue asap. | 15:48 |
| vishalmanchanda | I will also add my comment there. | 15:48 |
| vishalmanchanda | Also, Feel free to discuss any pain point here. | 15:49 |
| vishalmanchanda | ok next topic is a paste for a unit test https://paste.opendev.org/show/811691/ | 15:50 |
| vishalmanchanda | I am not sure you have added that. | 15:50 |
| ganso | that's me ^ | 15:50 |
| vishalmanchanda | ganso: ok go ahead. | 15:50 |
| ganso | I'm struggling with unit tests for that network page pagination. More specifically, what I highlighted in the pastebin | 15:50 |
| ganso | basically, I added 1 extra network for completeness of my tests | 15:50 |
| ganso | upon doing that, I broke a bunch of stuff in a weird way. I still need to go through most failures, but the 2 that strike me most are the 2 ones I included in the pastebin | 15:51 |
| ganso | so one of them has 2 extra quota calls when adding one network, that is strange | 15:51 |
| ganso | the other failure, is basically the opposite of what we would expect. It was expected to fail with the message "CIDRs allowed for user private ipv6 networks are fc00::/9." | 15:52 |
| ganso | but the result was <TemplateResponse status_code=200, "text/html; charset=utf-8"> | 15:52 |
| ganso | I'm inclined to thing those unit tests were artificially working, may be coded incorrectly, as I currently do not understand how adding one extra network is breaking them in that way | 15:53 |
| ganso | I'm a bit lost on this and spending a significant amount of time digging on those failures, so I'm also thinking about removing that extra network for my patch so it wouldn't break those unit tests | 15:54 |
| ganso | but it is somewhat a yellow flag | 15:54 |
| ganso | I just wanted to raise this concern | 15:55 |
| rdopiera | we do have a lot of tests that instead of find bugs just pin the implementation in place | 15:55 |
| rdopiera | they were converted from using a library that encouraged this kind of testing | 15:55 |
| ganso | rdopiera: like removing that specific extra network for those specific set of tests ? | 15:55 |
| vishalmanchanda | ganso: honestly, I also struggle with these unit test, so what I do update these to get passed. | 15:55 |
| rdopiera | like checking that a certain function was called an exact number of times and so on | 15:56 |
| amotoki | ganso: Althoght I am really for the late for the review, regarding the test failure, is the failure in the latest patch set of https://review.opendev.org/c/openstack/horizon/+/806454 the thing we should check? | 15:56 |
| ganso | amotoki: it is not included in that patchset (I think), I can push my latest so you can see those failures | 15:56 |
| amotoki | ganso: okay | 15:57 |
| vishalmanchanda | ganso: like If I see this error AssertionError: 7 != 9 I will update it to 9. | 15:57 |
| vishalmanchanda | ganso: to get test passed. | 15:57 |
| ganso | vishalmanchanda: lol yea I thought about that but it bothers me a bit if I don't understand why | 15:57 |
| amotoki | ganso: I checked the behavior of neutron this week and 'shared' attribute only affects networks exactly shared to a specific project even with the admin role, so the approach looks good in general. | 15:57 |
| ganso | vishalmanchanda: but the second one, I can't just update, the behavior is completely inverted | 15:57 |
| vishalmanchanda | ganso: hmm for second need to check. | 15:58 |
| rdopiera | the TemplateResponse probably needs an explicit conversion of the object to a string | 15:59 |
| ganso | rdopiera: the response code would be different than 200 for the error message expected | 15:59 |
| vishalmanchanda | ganso: ok, please push your updated patch to gerrit then we can check and help. | 16:00 |
| ganso | vishalmanchanda: sure, will do. Thanks! | 16:00 |
| vishalmanchanda | ok we are out of time. | 16:00 |
| vishalmanchanda | Thanks everyone for joining. | 16:00 |
| vishalmanchanda | amotoki: TC, get well soon. | 16:00 |
| vishalmanchanda | #endmeeting | 16:01 |
| opendevmeet | Meeting ended Wed Dec 15 16:01:24 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-15-15.00.html | 16:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-15-15.00.txt | 16:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2021/horizon.2021-12-15-15.00.log.html | 16:01 |
| amotoki | ganso: neutron team is thinking to depreate python bindigns in python-neutornclient and move it to openstacksdk, but it takes time. I am sure we can move it forward with python-neutronclient bindings. | 16:01 |
| amotoki | ganso: more than that, I will take care of all of the migation from neutronclient bindings to openstacksdk. | 16:02 |
| vishalmanchanda | rdopiera: link for policy-popup team discussion https://wiki.openstack.org/wiki/Consistent_and_Secure_Default_Policies_Popup_Team#Meeting | 16:02 |
| ganso | amotoki: yea that is w.r.t API layer, so it will not affect my patch unless one method that sends the API parameters, but it is just a matter of translating the parameters. The new logic (in the patch) will still be needed for pagination | 16:03 |
| ganso | amotoki: thanks! | 16:03 |
| amotoki | ganso: exactly | 16:04 |
| amotoki | ganso: I will help make UT work. | 16:04 |
| rdopiera | vishalmanchanda: thanks! | 16:05 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon master: [WIP] Implement pagination in admin/proj network tab https://review.opendev.org/c/openstack/horizon/+/806454 | 16:56 |
| opendevreview | Rodrigo Barbieri proposed openstack/horizon master: [WIP] Implement pagination in admin/proj network tab https://review.opendev.org/c/openstack/horizon/+/806454 | 18:05 |
| ganso | amotoki, vishalmanchanda: I found the problem and fixed it | 18:06 |
| vishalmanchanda | ganso: nice:) | 18:07 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!