| *** lajoskatona_ is now known as lajoskatona | 01:34 | |
| opendevreview | Merged openstack/horizon master: Follow-up: Drop Django based implementation of launch instance https://review.opendev.org/c/openstack/horizon/+/826262 | 11:33 |
|---|---|---|
| vishalmanchanda | #startmeeting horizon | 15:00 |
| opendevmeet | Meeting started Wed Feb 2 15:00:26 2022 UTC and is due to finish in 60 minutes. The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'horizon' | 15:00 |
| e0ne | hi | 15:01 |
| vishalmanchanda | hello everyone | 15:01 |
| ganso | o/ | 15:01 |
| vishalmanchanda | rdopiera: amotoki : tmazur: are you going to join us? | 15:02 |
| amotoki | hi | 15:03 |
| vishalmanchanda | Let's start the meeting. | 15:03 |
| vishalmanchanda | Agenda for today meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities (at line 32) | 15:04 |
| vishalmanchanda | #topic Notices | 15:04 |
| vishalmanchanda | few announcement from my side for this week | 15:04 |
| vishalmanchanda | As usual Yoga Schedule https://releases.openstack.org/yoga/schedule.html | 15:04 |
| vishalmanchanda | This week is R-8 week. | 15:05 |
| vishalmanchanda | moving to next announcement. | 15:05 |
| vishalmanchanda | next cycle PTG will take place April 4-8, 2022. | 15:06 |
| vishalmanchanda | It's virtual and free but you have to register yourself to get all PTG related updates. | 15:06 |
| vishalmanchanda | #registration link https://openinfra-ptg.eventbrite.com/ | 15:07 |
| vishalmanchanda | For more info. please see http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026888.html | 15:07 |
| vishalmanchanda | moving to next announcement | 15:08 |
| vishalmanchanda | As some of you may already know openstack/senlin-dashboard doc job is failing for stable/xena branch | 15:08 |
| vishalmanchanda | So once https://review.opendev.org/c/openstack/horizon/+/826560 land, I will cut a new release of horizon for stable/xena branch So that senlin-dashboard doc job fixed. | 15:10 |
| vishalmanchanda | that's all announcement from my side for this week. | 15:10 |
| vishalmanchanda | If anyone have any announcement to make, please go ahead | 15:11 |
| amotoki | vishalmanchanda: is it specific to xena and yoga? | 15:11 |
| amotoki | vishalmanchanda: looking at the fix, we did not change the code touched for long, so I wonder which stable branches are affected. | 15:11 |
| vishalmanchanda | amotoki: hmm, I am not sure about how many more stable branches are affected by this change but I will take a look at it. | 15:13 |
| vishalmanchanda | amotoki: I got to know about failure of stable/xena branch by this patch https://review.opendev.org/c/openstack/senlin-dashboard/+/809755 | 15:14 |
| vishalmanchanda | moving to next topic | 15:15 |
| amotoki | thanks. I am not sure what triggered the failure in senlin-dashboard doc. sphinx 4 might cause it but I am not sure. | 15:15 |
| vishalmanchanda | amotoki: yes exactly sphinx 4 which I also noticed while reviewing the patch. | 15:16 |
| vishalmanchanda | #topic On-Demand Agenda | 15:16 |
| vishalmanchanda | request for https://review.opendev.org/c/openstack/horizon/+/806454 | 15:17 |
| ganso | just a reminder, as we are getting closer to FF | 15:17 |
| vishalmanchanda | ganso: JFYI I have tested it already in my env. and work fine, now doing code-review will try to push my comments by this week. | 15:17 |
| ganso | vishalmanchanda: you re-tested the complete patch? | 15:18 |
| vishalmanchanda | ganso: yup. | 15:18 |
| ganso | \o/ | 15:18 |
| vishalmanchanda | latest one | 15:18 |
| ganso | awesome | 15:18 |
| ganso | thank you! | 15:18 |
| vishalmanchanda | I want to raise one more thing here. | 15:19 |
| amotoki | ganso: I will review it soon too. I believe I have time in coming weeks. | 15:20 |
| ganso | amotoki: thank you! | 15:20 |
| vishalmanchanda | As we are approaching Yoga cycle feature-freeze (Feb 25), So I have shortlisted few bp which are good to have in Yoga Cycle. | 15:20 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/805360 (Add Rules operation to Network QoS Policy) | 15:22 |
| vishalmanchanda | I have already reviewed it once and now waiting for feedback from amotoki as he raised some points to improve in the patch. | 15:23 |
| amotoki | last time I tested the qos patch, it seems to add a policy-check for the QoS operations. | 15:23 |
| amotoki | anyway I will look into it. | 15:23 |
| vishalmanchanda | amotoki: thanks | 15:23 |
| vishalmanchanda | Sorry guys I got disconnected. | 15:26 |
| vishalmanchanda | Now typing from my phone | 15:28 |
| vishalmanchanda | Now typing from my phone | 15:28 |
| vishalmanchanda | https://review.opendev.org/c/openstack/horizon/+/817570 ( Enable multiple-login-seesion in horizon) | 15:29 |
| vishalmanchanda | I am waiting for feedback from more team members, specifically about adding 'simultaneous_session' field in user settings format which I raised in review comment. | 15:31 |
| vishalmanchanda | I am waiting for feedback from more team members, specifically about adding 'simultaneous_session' field in user settings format which I raised in review comment. | 15:32 |
| amotoki | vishalmanchanda: are you connected? | 15:35 |
| vishalmanchanda_ | Sorry I am getting disconnected again and again. | 15:35 |
| vishalmanchanda_ | Now joined via oftc. | 15:36 |
| vishalmanchanda_ | Last one in my list is https://review.opendev.org/c/openstack/horizon/+/806454 (Implement pagination in admin/proj network tab) Which I am reviewing this week. | 15:37 |
| vishalmanchanda_ | So Please take a look at these 3 feature patches and also, let me know if any of your feature patch is up and need reviews. | 15:39 |
| amotoki | one question on the system-scoped support. what is the current status? is it completed or do we need more work? (sorry that I could not spend enough time to review it though) | 15:40 |
| vishalmanchanda_ | rdopiera: around? | 15:40 |
| vishalmanchanda_ | amotoki: Initial patch to add System Scope menu is merged https://review.opendev.org/c/openstack/horizon/+/816368 | 15:41 |
| amotoki | yeah, I know it. | 15:41 |
| amotoki | I just asked it if you know the status. anyway I will test the system-scope support in upcoming weeks. | 15:42 |
| amotoki | moving on. one more thing about https://review.opendev.org/c/openstack/horizon/+/808102 | 15:43 |
| vishalmanchanda_ | amotoki: Next step I guess is to make admin dashboard work which is depend on backend services. | 15:43 |
| amotoki | vishalmanchanda: okay. will keep it in mind when trying it | 15:44 |
| vishalmanchanda_ | amotoki: looking at your comments on the patch https://review.opendev.org/c/openstack/horizon/+/808102 | 15:45 |
| amotoki | vishalmanchanda: my comments are all related to unit tests. It fixes the resize button operation. | 15:46 |
| amotoki | my question is whether we want to merge it first and then update the unit tests (or moving the logic) or address my comments in this review. | 15:47 |
| vishalmanchanda_ | amotoki: I think Vadym Markov is fine if you update his patch | 15:47 |
| amotoki | okay. I will take care of it. | 15:48 |
| vishalmanchanda_ | amotoki: We also have to backport it to stable branches. | 15:48 |
| vishalmanchanda_ | amotoki: great. | 15:48 |
| vishalmanchanda_ | Last thing from my side for today. | 15:48 |
| amotoki | vishalmanchanda: In my understanding, this series of commits https://review.opendev.org/q/Ic8330b947b1a733f70c3bdad8b3493f20a2f26fb caused the resize button failure | 15:49 |
| vishalmanchanda_ | You may have also noticed in your horizon-cross-plugin job openstack/heat-dashboard Unit test are failing | 15:50 |
| vishalmanchanda_ | amotoki: hmm I see. | 15:51 |
| vishalmanchanda_ | amotoki: hmm, I have purposed a different approach in P.S. 1 for https://review.opendev.org/c/openstack/horizon/+/798730/1/openstack_dashboard/api/nova.py which may not break the resize button. | 15:52 |
| vishalmanchanda_ | Anyway I observed openstack/heat-dashboard start failing after https://review.opendev.org/c/openstack/horizon/+/816368 | 15:53 |
| vishalmanchanda_ | is merged | 15:53 |
| vishalmanchanda_ | I am not sure how to fix heat-dashboard unit tests as of now, So if anyone can take a look and help here. | 15:56 |
| vishalmanchanda_ | If nothing else to discuss we can end this meeting. | 15:58 |
| amotoki | at a quick look, some API calls are not mocked | 15:58 |
| amotoki | perhaps adding proper mock(s) for API calls would fix the failure. | 15:58 |
| vishalmanchanda_ | amotoki: yeah some keystone relegated api call are not mocked I guess | 15:59 |
| vishalmanchanda_ | related. | 15:59 |
| vishalmanchanda_ | Thanks everyone for joining. | 16:00 |
| vishalmanchanda_ | See you next week. | 16:00 |
| vishalmanchanda_ | #endmeeting | 16:00 |
| opendevmeet | Meeting ended Wed Feb 2 16:00:51 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-02-15.00.html | 16:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-02-15.00.txt | 16:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/horizon/2022/horizon.2022-02-02-15.00.log.html | 16:00 |
| vishalmanchanda_ | amotoki: about System Scope Support status, rdopiera discussed it with policy-pop team on 2021-12-16 | 16:05 |
| vishalmanchanda_ | amotoki: You can find some discussion here https://etherpad.opendev.org/p/policy-popup-yoga-ptg (at Line 645) | 16:06 |
| amotoki | vishalmanchanda_: thanks. I will check it soon | 16:07 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/victoria: Non-api filters not working with admin instance tab https://review.opendev.org/c/openstack/horizon/+/827405 | 21:44 |
| opendevreview | Tatiana Ovchinnikova proposed openstack/horizon stable/ussuri: Non-api filters not working with admin instance tab https://review.opendev.org/c/openstack/horizon/+/827406 | 21:44 |
| opendevreview | Merged openstack/horizon stable/xena: Fix maximum recursion depth error when generating documentation https://review.opendev.org/c/openstack/horizon/+/826560 | 22:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!